sr-dev March 2023

sr-dev@lists.kamailio.org

14 participants
250 discussions

Re: [kamailio/kamailio] nat_traversal: cast to uint64_t when using time_t value (f301ca9)

by Victor Seva

From https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=… ``` nat_traversal.c: In function 'get_register_expire': ../../core/parser/../dprint.h:321:73: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 11 has type 'long unsigned int' [-Wformat=] 321 | fprintf(stderr, "%2d(%d) %s: %.*s%s%s%s" fmt, \ | ^~~~~~~~~~~~~~~~~~~~~~~~ ../../core/parser/../dprint.h:345:25: note: in expansion of macro 'LOG_FX' 345 | LOG_FX(facility, level, lname, prefix, _FUNC_NAME_, fmt, ## args) | ^~~~~~ ../../core/parser/../dprint.h:351:25: note: in expansion of macro 'LOG_FL' 351 | LOG_FL(facility, level, NULL, prefix, fmt, ## args) | ^~~~~~ ../../core/parser/../dprint.h:354:25: note: in expansion of macro 'LOG_FP' 354 | LOG_FP(DEFAULT_FACILITY, (level), LOC_INFO, fmt, ## args) | ^~~~~~ ../../core/parser/../dprint.h:401:45: note: in expansion of macro 'LOG' 401 | # define DBG(fmt, args...) LOG(L_DBG, fmt , ## args) | ^~~ ../../core/parser/../dprint.h:405:36: note: in expansion of macro 'DBG' 405 | # define DEBUG(fmt, args...) DBG(fmt , ## args) | ^~~ ../../core/parser/../dprint.h:422:16: note: in expansion of macro 'DEBUG' 422 | #define LM_DBG DEBUG | ^~~~~ nat_traversal.c:926:9: note: in expansion of macro 'LM_DBG' 926 | LM_DBG("maximum expire for all contacts: %llu\n", (uint64_t)expire); | ^~~~~~ ``` @miconda same here -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/f301ca9cdcc044dd05e9d82139e1db3… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/f301ca9cdcc044dd05e9d82139e1db368be6dc5c/104360216(a)github.com>

1 year, 8 months

Re: [kamailio/kamailio] core: sruid - cast to uint64_t when using time_t value (33b3193)

by Victor Seva

From https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=… ``` core/utils/tmrec.c: In function 'ac_print': core/utils/tmrec.c:275:32: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] 275 | printf("\nSys time: %llu\nTime: %02d:%02d:%02d\n", (uint64_t)_atp->time, | ~~~^ ~~~~~~~~~~~~~~~~~~~~ | | | | long long unsigned int long unsigned int | %lu core/utils/tmrec.c: In function 'tr_print': core/utils/tmrec.c:515:30: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] 515 | printf("Sys time: %llu\n", (uint64_t)_trp->dtstart); | ~~~^ ~~~~~~~~~~~~~~~~~~~~~~~ | | | | | long unsigned int | long long unsigned int | %lu core/utils/tmrec.c:521:30: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] 521 | printf("End time: %llu\n", (uint64_t)_trp->dtend); | ~~~^ ~~~~~~~~~~~~~~~~~~~~~ | | | | | long unsigned int | long long unsigned int | %lu core/utils/tmrec.c:522:30: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] 522 | printf("Duration: %llu\n", (uint64_t)_trp->duration); | ~~~^ ~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | long unsigned int | long long unsigned int | %lu core/utils/tmrec.c:523:27: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] 523 | printf("Until: %llu\n", (uint64_t)_trp->until); | ~~~^ ~~~~~~~~~~~~~~~~~~~~~ | | | | | long unsigned int | long long unsigned int | %lu ``` @miconda it seems we need just ``%lu`` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/33b319353a097ba8fd80e45dc4f008c… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/33b319353a097ba8fd80e45dc4f008c2e9dfe813/104359936(a)github.com>

1 year, 8 months

Re: [kamailio/kamailio] Fix for incorrect Flow-description in AAR Media (1a1c2cf)

by Guille0007

Thanks Herle for your answer, And indeed I made it work using your scripts. Where you only rewrite SDP Offer on Orig Invite and SDP Answer on Terminating183 Session Progress. And where it does not work anymore when you try to rewrite SDP offer at both Orig and Term Invite and SDP Answer on both Orig and term 183 Session Progress. Which is what would happen when *IMS *core uses a separate VRF from access. But anyway, thanks for your answer and thank you for the dockerized environment you made available to test VoLTE with Kamailio. Regards Le dim. 12 mars 2023 à 13:01, Supreeth Herle ***(a)***.***> a écrit : > Hey @Guille0007 <https://github.com/Guille0007> > > I cant recollect completely about the AAR fix I did. But, AAR works in the > docker_open5gs repo for a call. > > — > Reply to this email directly, view it on GitHub > <https://github.com/kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab…>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/A6NCYHDHEGSLIASOJ4C5FPLW3…> > . > You are receiving this because you were mentioned.Message ID: > <kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab7b89b386a/104093331 > @github.com> > -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab7b89b386a/104131881(a)github.com>

1 year, 8 months

Re: [kamailio/kamailio] Fix for incorrect Flow-description in AAR Media (1a1c2cf)

by Supreeth Herle

Hey @Guille0007 I cant recollect completely about the AAR fix I did. But, AAR works in the docker_open5gs repo for a call. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab7b89b386a/104093331(a)github.com>

1 year, 8 months

[kamailio/kamailio] Modified ruri-user and dispatcher failover (Issue #3388)

by mtryfoss

### Description We've got a situation where we use t_send_reply() to generate early 100 Trying, before an operation that might have a small delay. The result of this operation might lead to a change which adds parameters to ruri-user. This works as expected for normal operations, but when calling ds_next_dst()/ds_next_domain() the change to $rU is lost. ### Troubleshooting I then noticed that this is because t_send_reply() indirectly does a t_newtran() before change to $rU. If it's done in the opposite order, everything works as expected. A workaround is to use for example sl_send_reply() and t_set_auto_inv_100(0), which works for me. However, I'm unsure if this revert of user is expected behaviour? #### Reproduction $rU = $rU + ";npdi"; .. ds_select_dst(..); then trigger a condition which executes failure_route and then use ds_next_dst() to fork serially. $rU is then reverted to the original value in outgoing INVITE. ### Additional Information Reproduced in master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3388 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3388(a)github.com>

1 year, 8 months

Re: [kamailio/kamailio] Fix for incorrect Flow-description in AAR Media (1a1c2cf)

by Guille0007

Hello Herlesupreth, I am struggling with pcscf Rx. At termination, PCSCF seems to request QoS for a flow between the IP/port of the SDP offer it receives and the IP/Port of the SDP Answer it receives. While it should request QoS for a flow between the IP/Port of the SDP offer it generates (after rewriting SDP) and the IP/Port of the SDP answer it receives from B. Is it why in the rtp.cfg from https://github.com/herlesupreeth/docker_open5gs you do not invoke rtpmanage on invite at termination? Does the fix you posted there solve that? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab7b89b386a/103929108(a)github.com>

1 year, 8 months

KEMI python 'KSR' has no attribute 'sanity'

by agural5＠gmail.com

Hello, I am trying to use KEMI KSR.sanity in python but got error: AttributeError: module 'KSR' has no attribute 'sanity' appreciate your help for solve this. Thanks!

1 year, 8 months

[kamailio/kamailio] auth_ephemeral: fix authentication with secrets added at runtime (PR #3390)

by Dennis

- proper way to work with shm pointer to secret list   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description In case of adding secrets at runtime with autheph.add_secret rpc, authentication with new secrets not work, this is because rpc process modify local pointer to secret list, instead shm. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3390 -- Commit Summary -- * auth_ephemeral: fix authentication with secrets added at runtime -- File Changes -- M src/modules/auth_ephemeral/auth_ephemeral_mod.c (48) M src/modules/auth_ephemeral/auth_ephemeral_mod.h (1) M src/modules/auth_ephemeral/authorize.c (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3390.patch https://github.com/kamailio/kamailio/pull/3390.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3390 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3390(a)github.com>

1 year, 8 months

git:master:6fa5a8fa: auth_ephemeral: fix authentication with secrets added at runtime (#3390)

by GitHub

Module: kamailio Branch: master Commit: 6fa5a8fa8ddfe09bdab2fb445bee94e51d86b7fc URL: https://github.com/kamailio/kamailio/commit/6fa5a8fa8ddfe09bdab2fb445bee94e… Author: Dennis <dennis_y(a)mail.ru> Committer: GitHub <noreply(a)github.com> Date: 2023-03-10T15:46:21+01:00 auth_ephemeral: fix authentication with secrets added at runtime (#3390) * auth_ephemeral: fix authentication with secrets added at runtime - proper way to work with shm pointer to secret list * fix: free secret_struct shm Free shm secret_struct in case the allocation error of secret_list pointer. --- Modified: src/modules/auth_ephemeral/auth_ephemeral_mod.c Modified: src/modules/auth_ephemeral/auth_ephemeral_mod.h Modified: src/modules/auth_ephemeral/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/6fa5a8fa8ddfe09bdab2fb445bee94e… Patch: https://github.com/kamailio/kamailio/commit/6fa5a8fa8ddfe09bdab2fb445bee94e…

1 year, 8 months

git:master:e3b8b76d: utils/kamctl: allow the definition of a specific startup file at start process

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e3b8b76d7a8773af4e10ce011682931429cd4a87 URL: https://github.com/kamailio/kamailio/commit/e3b8b76d7a8773af4e10ce011682931… Author: Gustavo Almeida <gustavo.abcdef(a)hotmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-10T15:38:33+01:00 utils/kamctl: allow the definition of a specific startup file at start process - Added the possibility to specify an alternative file different from the default: kamailio.cfg, when starting kamailio, using the kamctl tool. This makes it possible to start kamailio by passing a startup file located in a specific folder (via ETCDIR env variable) and with a specific name, instead of using the default name: kamailio.cfg. --- Modified: utils/kamctl/kamctl Modified: utils/kamctl/kamctlrc --- Diff: https://github.com/kamailio/kamailio/commit/e3b8b76d7a8773af4e10ce011682931… Patch: https://github.com/kamailio/kamailio/commit/e3b8b76d7a8773af4e10ce011682931… --- diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index fbb237eb00..214cd21e5a 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -73,6 +73,10 @@ if [ -z "$MYLIBDIR" ] ; then fi fi +if [ -z "$STARTUP_CONFIG_FILE" ]; then + STARTUP_CONFIG_FILE="kamailio.cfg" +fi + ##### ------------------------------------------------ ##### ### load base functions # @@ -2007,9 +2011,9 @@ kamailio_start() { exit 1 fi if [ $SYSLOG = 1 ] ; then - $KAMBIN -P $PID_FILE -f $ETCDIR/kamailio.cfg $STARTOPTIONS 1>/dev/null 2>/dev/null + $KAMBIN -P $PID_FILE -f $ETCDIR/$STARTUP_CONFIG_FILE $STARTOPTIONS 1>/dev/null 2>/dev/null else - $KAMBIN -P $PID_FILE -E -f $ETCDIR/kamailio.cfg $STARTOPTIONS + $KAMBIN -P $PID_FILE -E -f $ETCDIR/$STARTUP_CONFIG_FILE $STARTOPTIONS fi sleep 3 if [ ! -s $PID_FILE ] ; then diff --git a/utils/kamctl/kamctlrc b/utils/kamctl/kamctlrc index fe9cc1fc48..ce0bd9d93b 100644 --- a/utils/kamctl/kamctlrc +++ b/utils/kamctl/kamctlrc @@ -159,6 +159,10 @@ ## PID file path - default is: /run/kamailio/kamailio.pid # PID_FILE=/run/kamailio/kamailio.pid +## Kamailio Startup Configuration File +## Default is: kamailio.cfg +# STARTUP_CONFIG_FILE=kamailio.cfg + ## Extra start options - default is: not set ## example: start Kamailio with 64MB shared memory: STARTOPTIONS="-m 64" # STARTOPTIONS=

1 year, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2023