sr-dev April 2023

sr-dev@lists.kamailio.org

15 participants
264 discussions

[kamailio/kamailio] rtpengine: google sanitizer aligment warning (Issue #3058)
by sergey-safarov 10 May '23

10 May '23

``` bencode.c:149:14: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 18 26 9c ^ bencode.c:50:64: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 18 26 9c ^ bencode.c:50:54: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 00 00 00 ^ bencode.c:50:48: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 00 00 00 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3058 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3058(a)github.com>

3 8

[kamailio/kamailio] p_usrloc: Add use_domain_crc32 modparam (PR #3427)
by Stefan Mititelu 10 May '23

10 May '23

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Needed a way to use_domain but calculate crc32 for user part only. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3427 -- Commit Summary -- * p_usrloc: Add use_domain_crc32 modparam -- File Changes -- M src/modules/p_usrloc/doc/p_usrloc_admin.xml (21) M src/modules/p_usrloc/p_usrloc_mod.c (2) M src/modules/p_usrloc/p_usrloc_mod.h (1) M src/modules/p_usrloc/ul_db_handle.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3427.patch https://github.com/kamailio/kamailio/pull/3427.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3427 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3427(a)github.com>

3 7

[kamailio/kamailio] tls: Add rpc function to kill session by id (PR #3428)
by Stefan Mititelu 09 May '23

09 May '23

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Kill a TLS session by moving the TCP connectin to -2 state. Note that it may take few seconds for session to be killed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3428 -- Commit Summary -- * tls: Add rpc function to kill session by id -- File Changes -- M src/modules/tls/doc/rpc.xml (12) M src/modules/tls/tls_rpc.c (35) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3428.patch https://github.com/kamailio/kamailio/pull/3428.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3428 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3428(a)github.com>

3 4

[kamailio/kamailio] registrar: adding tcpconn_id to xavp_cfg (PR #3430)
by Julien Chavanton 09 May '23

09 May '23

3 7

Building with clang
by Ivan Ribakov 01 May '23

01 May '23

Hi all, I looked at Kamailio 5.6.3 makefiles and saw mention of clang being supported. Yet when I try to build it with clang (more precisely, I build a C++ module using clang that includes some Kamailio C headers via "extern C") I get following error: In file included from /tmp/kamailio/kamailio/modules/tm/t_funcs.h:45: /tmp/kamailio/kamailio/modules/tm/timer.h:204:2: error: no matching function for call to 'atomic_cmpxchg_int' Any suggestions on how to overcome this error or any general suggestions for using Kamailio + clang? clang version 14.0.6 (Red Hat 14.0.6-4.el9_1) -- Ivan Ribakov Software Engineer www.zaleos.net

2 3

git:master:db8258bf: debugger: convert to memory error logging helper, add missing mem error handling
by Henning Westerholt 29 Apr '23

29 Apr '23

Module: kamailio Branch: master Commit: db8258bf9ab7ca772923d237f40fce4381dbcde4 URL: https://github.com/kamailio/kamailio/commit/db8258bf9ab7ca772923d237f40fce4… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-29T19:16:32Z debugger: convert to memory error logging helper, add missing mem error handling --- Modified: src/modules/debugger/debugger_api.c Modified: src/modules/debugger/debugger_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/db8258bf9ab7ca772923d237f40fce4… Patch: https://github.com/kamailio/kamailio/commit/db8258bf9ab7ca772923d237f40fce4… --- diff --git a/src/modules/debugger/debugger_api.c b/src/modules/debugger/debugger_api.c index 5a773661845..b9137594bac 100644 --- a/src/modules/debugger/debugger_api.c +++ b/src/modules/debugger/debugger_api.c @@ -557,7 +557,10 @@ int dbg_init_bp_list(void) return -1; _dbg_bp_list = (dbg_bp_t*)shm_malloc(sizeof(dbg_bp_t)); if(_dbg_bp_list==NULL) + { + SHM_MEM_ERROR; return -1; + } memset(_dbg_bp_list, 0, sizeof(dbg_bp_t)); if(_dbg_breakpoint==1) _dbg_bp_list->set |= DBG_ABKPOINT_ON; @@ -580,7 +583,10 @@ int dbg_add_breakpoint(struct action *a, int bpon) len += sizeof(dbg_bp_t) + 1; nbp = (dbg_bp_t*)shm_malloc(len); if(nbp==NULL) + { + SHM_MEM_ERROR; return -1; + } memset(nbp, 0, len); nbp->set |= (bpon)?DBG_ABKPOINT_ON:0; nbp->cline = a->cline; @@ -605,7 +611,10 @@ int dbg_init_pid_list(void) return -1; _dbg_pid_list = (dbg_pid_t*)shm_malloc(_dbg_pid_no*sizeof(dbg_pid_t)); if(_dbg_pid_list==NULL) + { + SHM_MEM_ERROR; return -1; + } memset(_dbg_pid_list, 0, _dbg_pid_no*sizeof(dbg_pid_t)); return 0; } @@ -1202,7 +1211,7 @@ int dbg_init_mod_levels(int dbg_mod_hash_size) _dbg_mod_table = (dbg_mod_slot_t*)shm_malloc(_dbg_mod_table_size*sizeof(dbg_mod_slot_t)); if(_dbg_mod_table==NULL) { - LM_ERR("no more shm.\n"); + SHM_MEM_ERROR; return -1; } memset(_dbg_mod_table, 0, _dbg_mod_table_size*sizeof(dbg_mod_slot_t)); @@ -1367,8 +1376,9 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) return 0; } itn = (dbg_mod_level_t*)shm_malloc(sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); - if(itn==NULL) { - LM_ERR("no more shm\n"); + if(itn==NULL) + { + SHM_MEM_ERROR; return -1; } memset(itn, 0, sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); @@ -1444,7 +1454,7 @@ int dbg_set_mod_debug_facility(char *mname, int mnlen, int *mfacility) } itn = (dbg_mod_facility_t*)shm_malloc(sizeof(dbg_mod_facility_t) + (mnlen+1)*sizeof(char)); if(itn==NULL) { - LM_ERR("no more shm\n"); + SHM_MEM_ERROR; return -1; } memset(itn, 0, sizeof(dbg_mod_facility_t) + (mnlen+1)*sizeof(char)); @@ -1594,7 +1604,7 @@ int dbg_init_pvcache() _dbg_pvcache = (dbg_pvcache_t**)pkg_malloc(sizeof(dbg_pvcache_t*)*DBG_PVCACHE_SIZE); if(_dbg_pvcache==NULL) { - LM_ERR("no more memory.\n"); + SHM_MEM_ERROR; return -1; } memset(_dbg_pvcache, 0, sizeof(dbg_pvcache_t*)*DBG_PVCACHE_SIZE); @@ -1616,7 +1626,7 @@ int dbg_assign_add(str *name, pv_spec_t *spec) pvn = (dbg_pvcache_t*)pkg_malloc(sizeof(dbg_pvcache_t)); if(pvn==NULL) { - LM_ERR("no more memory\n"); + SHM_MEM_ERROR; return -1; } memset(pvn, 0, sizeof(dbg_pvcache_t)); diff --git a/src/modules/debugger/debugger_mod.c b/src/modules/debugger/debugger_mod.c index 3c35a5b033d..b586bb54da8 100644 --- a/src/modules/debugger/debugger_mod.c +++ b/src/modules/debugger/debugger_mod.c @@ -556,7 +556,18 @@ static int w_dbg_sip_msg(struct sip_msg* msg, char *level, char *facility) /* alloc private mem and copy lumps */ hdr_lumps = pkg_malloc(BUF_SIZE); + if(hdr_lumps==NULL) + { + PKG_MEM_ERROR; + return -1; + } bdy_lumps = pkg_malloc(BUF_SIZE); + if(hdr_lumps==NULL) + { + pkg_free(hdr_lumps); + PKG_MEM_ERROR; + return -1; + } new_buf_offs = 0; process_lumps(msg, msg->add_rm, hdr_lumps, &new_buf_offs, &orig_offs, &send_info, flag);

1 0

git:master:11831568: crypto: convert to memory error logging helper
by Henning Westerholt 29 Apr '23

29 Apr '23

Module: kamailio Branch: master Commit: 11831568d9eaef233fe6e482ad2c63788b04bbd9 URL: https://github.com/kamailio/kamailio/commit/11831568d9eaef233fe6e482ad2c637… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-29T19:16:32Z crypto: convert to memory error logging helper --- Modified: src/modules/crypto/crypto_aes.c --- Diff: https://github.com/kamailio/kamailio/commit/11831568d9eaef233fe6e482ad2c637… Patch: https://github.com/kamailio/kamailio/commit/11831568d9eaef233fe6e482ad2c637… --- diff --git a/src/modules/crypto/crypto_aes.c b/src/modules/crypto/crypto_aes.c index 37cdd6844a..f5728a6e42 100644 --- a/src/modules/crypto/crypto_aes.c +++ b/src/modules/crypto/crypto_aes.c @@ -25,6 +25,7 @@ #include <string.h> #include "../../core/dprint.h" +#include "../../core/mem/pkg.h" #include "crypto_aes.h" @@ -139,7 +140,7 @@ unsigned char *crypto_aes_encrypt(EVP_CIPHER_CTX *e, unsigned char *plaintext, unsigned char *ciphertext = (unsigned char *)malloc(c_len); if(ciphertext == NULL) { - LM_ERR("no more system memory\n"); + SYS_MEM_ERROR; return NULL; } /* allows reusing of 'e' for multiple encryption cycles */ @@ -179,7 +180,7 @@ unsigned char *crypto_aes_decrypt(EVP_CIPHER_CTX *e, unsigned char *ciphertext, unsigned char *plaintext = (unsigned char *)malloc(p_len); if(plaintext==NULL) { - LM_ERR("no more system memory\n"); + SYS_MEM_ERROR; return NULL; } if(!EVP_DecryptInit_ex(e, NULL, NULL, NULL, NULL)){

1 0

git:master:ea31785f: ldap: convert to memory error logging helper
by Henning Westerholt 29 Apr '23

29 Apr '23

Module: kamailio Branch: master Commit: ea31785f3458bb79d14384734f8fd4f7b628ffa2 URL: https://github.com/kamailio/kamailio/commit/ea31785f3458bb79d14384734f8fd4f… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-29T19:16:32Z ldap: convert to memory error logging helper --- Modified: src/modules/ldap/ld_session.c Modified: src/modules/ldap/ldap_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ea31785f3458bb79d14384734f8fd4f… Patch: https://github.com/kamailio/kamailio/commit/ea31785f3458bb79d14384734f8fd4f… --- diff --git a/src/modules/ldap/ld_session.c b/src/modules/ldap/ld_session.c index ad0c9a793bf..222d504ed1b 100644 --- a/src/modules/ldap/ld_session.c +++ b/src/modules/ldap/ld_session.c @@ -43,7 +43,7 @@ int add_ld_session(char *_name, LDAP *_ldh, dictionary *_d) new_lds = (struct ld_session *)pkg_malloc(sizeof(struct ld_session)); if(new_lds == NULL) { - LM_ERR("no memory\n"); + PKG_MEM_ERROR; return -1; } memset(new_lds, 0, sizeof(struct ld_session)); @@ -58,7 +58,7 @@ int add_ld_session(char *_name, LDAP *_ldh, dictionary *_d) _d, get_ini_key_name(_name, CFG_N_LDAP_HOST), CFG_DEF_HOST_NAME); new_lds->host_name = (char *)pkg_malloc(strlen(host_name) + 1); if(new_lds->host_name == NULL) { - LM_ERR("no memory\n"); + PKG_MEM_ERROR; pkg_free(new_lds); return -1; } @@ -104,7 +104,7 @@ int add_ld_session(char *_name, LDAP *_ldh, dictionary *_d) get_ini_key_name(_name, CFG_N_LDAP_BIND_DN), CFG_DEF_LDAP_BIND_DN); new_lds->bind_dn = (char *)pkg_malloc(strlen(bind_dn) + 1); if(new_lds->bind_dn == NULL) { - LM_ERR("no memory\n"); + PKG_MEM_ERROR; pkg_free(new_lds->host_name); pkg_free(new_lds); return -1; @@ -117,7 +117,7 @@ int add_ld_session(char *_name, LDAP *_ldh, dictionary *_d) CFG_DEF_LDAP_BIND_PWD); new_lds->bind_pwd = (char *)pkg_malloc(strlen(bind_pwd) + 1); if(new_lds->bind_pwd == NULL) { - LM_ERR("no memory\n"); + PKG_MEM_ERROR; pkg_free(new_lds->bind_dn); pkg_free(new_lds->host_name); pkg_free(new_lds); diff --git a/src/modules/ldap/ldap_mod.c b/src/modules/ldap/ldap_mod.c index 1fea95e458d..757d3594718 100644 --- a/src/modules/ldap/ldap_mod.c +++ b/src/modules/ldap/ldap_mod.c @@ -328,7 +328,7 @@ static int ldap_result_fixup(void **param, int param_no) lp = (struct ldap_result_params *)pkg_malloc( sizeof(struct ldap_result_params)); if(lp == NULL) { - LM_ERR("no memory\n"); + PKG_MEM_ERROR; return E_OUT_OF_MEM; } memset(lp, 0, sizeof(struct ldap_result_params)); @@ -388,7 +388,7 @@ static int ldap_result_check_fixup(void **param, int param_no) lp = (struct ldap_result_check_params *)pkg_malloc( sizeof(struct ldap_result_check_params)); if(lp == NULL) { - LM_ERR("no memory\n"); + PKG_MEM_ERROR; return E_OUT_OF_MEM; } memset(lp, 0, sizeof(struct ldap_result_check_params)); @@ -444,7 +444,7 @@ static int ldap_filter_url_encode_fixup(void **param, int param_no) } else if(param_no == 2) { spec_p = (pv_spec_t *)pkg_malloc(sizeof(pv_spec_t)); if(spec_p == NULL) { - LM_ERR("no memory\n"); + PKG_MEM_ERROR; return E_OUT_OF_MEM; } s.s = (char *)*param;

1 0

git:master:b1a47746: pua: convert to memory logging helper, add missing log message and mem error handling
by Henning Westerholt 29 Apr '23

29 Apr '23

Module: kamailio Branch: master Commit: b1a47746d6097c2d1fe47ee4799108368037283d URL: https://github.com/kamailio/kamailio/commit/b1a47746d6097c2d1fe47ee47991083… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-29T19:16:32Z pua: convert to memory logging helper, add missing log message and mem error handling --- Modified: src/modules/pua/hash.c Modified: src/modules/pua/pua.c Modified: src/modules/pua/send_publish.c Modified: src/modules/pua/send_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/b1a47746d6097c2d1fe47ee47991083… Patch: https://github.com/kamailio/kamailio/commit/b1a47746d6097c2d1fe47ee47991083… --- diff --git a/src/modules/pua/hash.c b/src/modules/pua/hash.c index 9b1fec3d0d..8bd4a442e6 100644 --- a/src/modules/pua/hash.c +++ b/src/modules/pua/hash.c @@ -229,6 +229,9 @@ void update_htable(ua_pres_t* p, time_t desired_expires, int expires, if(p->remote_contact.s== NULL) { SHM_MEM_ERROR; + if(etag) { + shm_free(p->etag.s); + } return; } memcpy(p->remote_contact.s, contact->s, contact->len); diff --git a/src/modules/pua/pua.c b/src/modules/pua/pua.c index 33ddeddba4..255d0fa1bf 100644 --- a/src/modules/pua/pua.c +++ b/src/modules/pua/pua.c @@ -601,6 +601,9 @@ static int db_restore(void) if(p->etag.s== NULL) { SHM_MEM_ERROR; + if(watcher_uri.s && watcher_uri.len) { + shm_free(p->remote_contact.s); + } goto error; } memcpy(p->etag.s, etag.s, etag.len); diff --git a/src/modules/pua/send_publish.c b/src/modules/pua/send_publish.c index 58e67de82d..c19ff1b965 100644 --- a/src/modules/pua/send_publish.c +++ b/src/modules/pua/send_publish.c @@ -409,6 +409,7 @@ void publ_cback_func(struct cell *t, int type, struct tmcb_params *ps) if(presentity->etag.s== NULL) { SHM_MEM_ERROR; + shm_free(presentity); goto error; } memcpy(presentity->etag.s, etag.s, etag.len); diff --git a/src/modules/pua/send_subscribe.c b/src/modules/pua/send_subscribe.c index dc239c61b6..1791e6cca2 100644 --- a/src/modules/pua/send_subscribe.c +++ b/src/modules/pua/send_subscribe.c @@ -654,7 +654,9 @@ void subs_cback_func(struct cell *t, int cb_type, struct tmcb_params *ps) presentity->remote_contact.s= (char*)shm_malloc(contact.len* sizeof(char)); if(presentity->remote_contact.s==NULL) { - ERR_MEM(SHARE_MEM); + SHM_MEM_ERROR; + shm_free(presentity); + return; } memcpy(presentity->remote_contact.s, contact.s, contact.len); presentity->remote_contact.len= contact.len;

1 0

git:master:89927295: utils: convert to memory logging helper
by Henning Westerholt 29 Apr '23

29 Apr '23

Module: kamailio Branch: master Commit: 89927295f23648d9e66fa5285ca3b65a615e89a5 URL: https://github.com/kamailio/kamailio/commit/89927295f23648d9e66fa5285ca3b65… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-29T19:16:32Z utils: convert to memory logging helper --- Modified: src/modules/utils/xcap_auth.c --- Diff: https://github.com/kamailio/kamailio/commit/89927295f23648d9e66fa5285ca3b65… Patch: https://github.com/kamailio/kamailio/commit/89927295f23648d9e66fa5285ca3b65… --- diff --git a/src/modules/utils/xcap_auth.c b/src/modules/utils/xcap_auth.c index 425fa105cd0..20cac431132 100644 --- a/src/modules/utils/xcap_auth.c +++ b/src/modules/utils/xcap_auth.c @@ -416,12 +416,12 @@ int get_rules_doc(str* user, str* domain, int type, str** rules_doc) doc= (str*)pkg_malloc(sizeof(str)); if (doc== NULL) { - ERR_MEM(PKG_MEM_STR); + PKG_MEM_ERROR; } doc->s= (char*)pkg_malloc(body.len* sizeof(char)); if (doc->s== NULL) { pkg_free(doc); - ERR_MEM(PKG_MEM_STR); + PKG_MEM_ERROR; } memcpy(doc->s, body.s, body.len); doc->len= body.len;

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2023