#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
commit a725b4fd224c27d84a9f5623faa5af3c3873a2e5 seems to make the `nats_publish` function require the `reply.topic` parameter required. The change from that commit breaks backward compatibility and forces the configuration to pass a reply.topic. This PR makes the `reply.topic` optional.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3507
-- Commit Summary --
* nats: nats_publish set reply parameter to be optional
-- File Changes --
M src/modules/nats/nats_mod.c (4)
M src/modules/nats/nats_mod.h (6)
M src/modules/nats/nats_pub.c (39)
M src/modules/nats/nats_pub.h (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3507.patchhttps://github.com/kamailio/kamailio/pull/3507.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3507
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3507(a)github.com>
Module: kamailio
Branch: master
Commit: 9fd006e48469d86f68926418fc749cb798fdc9b7
URL: https://github.com/kamailio/kamailio/commit/9fd006e48469d86f68926418fc749cb…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2023-07-12T09:16:27+02:00
modules: readme files regenerated - imc ... [skip ci]
---
Modified: src/modules/imc/README
---
Diff: https://github.com/kamailio/kamailio/commit/9fd006e48469d86f68926418fc749cb…
Patch: https://github.com/kamailio/kamailio/commit/9fd006e48469d86f68926418fc749cb…
---
diff --git a/src/modules/imc/README b/src/modules/imc/README
index fa467ab6148..6fa83d72aa6 100644
--- a/src/modules/imc/README
+++ b/src/modules/imc/README
@@ -45,6 +45,7 @@ Joey Golan
4. Functions
4.1. imc_manager()
+ 4.2. imc_room_active(room)
5. RPC Commands
@@ -71,7 +72,8 @@ Joey Golan
1.9. Set create_on_join parameter
1.10. Set check_on_create parameter
1.11. Usage of imc_manager() function
- 1.12. List of commands
+ 1.12. Usage of imc_room_active() function
+ 1.13. List of commands
Chapter 1. Admin Guide
@@ -99,6 +101,7 @@ Chapter 1. Admin Guide
4. Functions
4.1. imc_manager()
+ 4.2. imc_room_active(room)
5. RPC Commands
@@ -285,6 +288,7 @@ modparam("imc", "check_on_create", 1)
4. Functions
4.1. imc_manager()
+ 4.2. imc_room_active(room)
4.1. imc_manager()
@@ -310,6 +314,21 @@ if(is_method("MESSAGE)
}
...
+4.2. imc_room_active(room)
+
+ Return 1 (true) if the room is active, -1 (false) if the room is not
+ found. The parameter is the SIP URI to identify the room, it can
+ contain variables.
+
+ This function can be used from ANY_ROUTE.
+
+ Example 1.12. Usage of imc_room_active() function
+...
+ if(imc_room_active("sip:chat-sip@$fd")) {
+ ...
+ }
+...
+
5. RPC Commands
5.1. imc.list_rooms
@@ -358,7 +377,7 @@ kamcmd imc_list_members _room_
Next picture presents the list of commands and their parameters.
- Example 1.12. List of commands
+ Example 1.13. List of commands
...
1.create