sr-dev September 2023

sr-dev@lists.kamailio.org

17 participants
298 discussions

[kamailio/kamailio] ndb_redis: cannot evaluate mathematical expression in array subscript $redis(r=>value[EXPR]) (Issue #3526)

by Alex Balashov

Running `5.7.1:441300`, trying to loop through the results of an `HGETALL` operation in Redis: ``` 127.0.0.1:6379[1]> keys * 1) "customer_params:14045551212:1.1.1.1" 127.0.0.1:6379[1]> hgetall customer_params:14045551212:1.1.1.1 1) "auth_ha1" 2) "9febe8cf72c6bd063b8978cded892e4bb" ``` This means that the returned type will be `$redisd(rpl_arr)` and a loop is required. For any given key value `$redis(r=>value[x])`, the value is in the next array slot, at `$redis(r=>value[x + 1])`. With that in mind, I tried this loop: ``` $var(i) = 0; while($var(i) < $redis(r=>size)) { $var(key) = $redis(r=>value[$var(i)]); switch($var(key)) { case "auth_ha1": $var(auth_ha1) = $redis(r=>value[$var(i)+1]); break; } $var(i) = $var(i) + 1; } ``` However, this ends up storing the key value ("auth_ha1") in `$var(auth_ha1)`. I also tried `$(var(i){s.int}) + 1` for the subscript value. To get the actual next-slot value, the expression evaluation has to be externalised into an intermediate variable: ``` while($var(i) < $redis(r=>size)) { $var(key) = $redis(r=>value[$var(i)]); # For some reason, Kamailio cannot evaluate an addition expression inside this subscript: $redis(r=>value[EXPR]) $var(idx) = $var(i) + 1; switch($var(key)) { case "auth_ha1": $var(auth_ha1) = $redis(r=>value[$var(idx)]); break; } $var(i) = $var(i) + 1; } ``` This works, and yields `9febe8cf72c6bd063b8978cded892e4bb`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3526 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3526(a)github.com>

1 year

[kamailio/kamailio] OpenSSL depreacation warning (Issue #3502)

by sergey-safarov

**crypto_uuid.c** ``` CC (gcc) [M crypto.so] api.o CC (gcc) [M crypto.so] crypto_aes.o CC (gcc) [M crypto.so] crypto_evcb.o CC (gcc) [M crypto.so] crypto_mod.o CC (gcc) [M crypto.so] crypto_uuid.o crypto_uuid.c: In function 'crypto_generate_callid': crypto_uuid.c:184:9: warning: 'SHA1_Init' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 184 | SHA1_Init(&crypto_ctx); | ^~~~~~~~~ In file included from crypto_uuid.c:37: /usr/include/openssl/sha.h:49:27: note: declared here 49 | OSSL_DEPRECATEDIN_3_0 int SHA1_Init(SHA_CTX *c); | ^~~~~~~~~ crypto_uuid.c:185:9: warning: 'SHA1_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 185 | SHA1_Update(&crypto_ctx, crypto_callid_seed, SEED_LEN); | ^~~~~~~~~~~ In file included from crypto_uuid.c:37: /usr/include/openssl/sha.h:50:27: note: declared here 50 | OSSL_DEPRECATEDIN_3_0 int SHA1_Update(SHA_CTX *c, const void *data, size_t len); | ^~~~~~~~~~~ crypto_uuid.c:186:9: warning: 'SHA1_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 186 | SHA1_Update(&crypto_ctx, crypto_callid_counter, CTR_LEN); | ^~~~~~~~~~~ In file included from crypto_uuid.c:37: /usr/include/openssl/sha.h:50:27: note: declared here 50 | OSSL_DEPRECATEDIN_3_0 int SHA1_Update(SHA_CTX *c, const void *data, size_t len); | ^~~~~~~~~~~ crypto_uuid.c:187:9: warning: 'SHA1_Final' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 187 | SHA1_Final(crypto_buf, &crypto_ctx); | ^~~~~~~~~~ In file included from crypto_uuid.c:37: /usr/include/openssl/sha.h:51:27: note: declared here 51 | OSSL_DEPRECATEDIN_3_0 int SHA1_Final(unsigned char *md, SHA_CTX *c); | ^~~~~~~~~~ LD (gcc) [M crypto.so] crypto.so CC (gcc) [M tls.so] tls_bio.o ``` **auth_crypt.c** ``` CC (gcc) [M tls.so] tls_verify.o LD (gcc) [M tls.so] tls.so CC (gcc) [M auth_identity.so] auth_crypt.o auth_crypt.c: In function 'rsa_sha1_enc': auth_crypt.c:214:9: warning: 'RSA_sign' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 214 | if(RSA_sign(NID_sha1, sstrcrypted, sizeof sstrcrypted, | ^~ In file included from /usr/include/openssl/x509.h:36, from /usr/include/openssl/pem.h:23, from auth_crypt.c:33: /usr/include/openssl/rsa.h:356:27: note: declared here 356 | OSSL_DEPRECATEDIN_3_0 int RSA_sign(int type, const unsigned char *m, | ^~~~~~~~ auth_crypt.c: In function 'rsa_sha1_dec': auth_crypt.c:258:9: warning: 'EVP_PKEY_get1_RSA' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 258 | hpubkey = EVP_PKEY_get1_RSA(pkey); | ^~~~~~~ In file included from /usr/include/openssl/pem.h:22, from auth_crypt.c:33: /usr/include/openssl/evp.h:1359:16: note: declared here 1359 | struct rsa_st *EVP_PKEY_get1_RSA(EVP_PKEY *pkey); | ^~~~~~~~~~~~~~~~~ auth_crypt.c:266:9: warning: 'RSA_verify' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 266 | if(RSA_verify(NID_sha1, (unsigned char *)ssha, sshasize, | ^~ In file included from /usr/include/openssl/x509.h:36, from /usr/include/openssl/pem.h:23, from auth_crypt.c:33: /usr/include/openssl/rsa.h:359:27: note: declared here 359 | OSSL_DEPRECATEDIN_3_0 int RSA_verify(int type, const unsigned char *m, | ^~~~~~~~~~ auth_crypt.c:273:17: warning: 'RSA_free' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 273 | RSA_free(hpubkey); | ^~~~~~~~ In file included from /usr/include/openssl/x509.h:36, from /usr/include/openssl/pem.h:23, from auth_crypt.c:33: /usr/include/openssl/rsa.h:301:28: note: declared here 301 | OSSL_DEPRECATEDIN_3_0 void RSA_free(RSA *r); | ^~~~~~~~ auth_crypt.c:298:9: warning: 'RSA_free' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 298 | RSA_free(hpubkey); | ^~~~~~~~ In file included from /usr/include/openssl/x509.h:36, from /usr/include/openssl/pem.h:23, from auth_crypt.c:33: /usr/include/openssl/rsa.h:301:28: note: declared here 301 | OSSL_DEPRECATEDIN_3_0 void RSA_free(RSA *r); | ^~~~~~~~ CC (gcc) [M auth_identity.so] auth_dynstr.o CC (gcc) [M auth_identity.so] auth_hdrs.o ``` **auth_identity.c** ``` CC (gcc) [M auth_identity.so] auth_http.o CC (gcc) [M auth_identity.so] auth_identity.o auth_identity.c: In function 'mod_init': auth_identity.c:414:9: warning: 'PEM_read_RSAPrivateKey' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 414 | glb_hmyprivkey = PEM_read_RSAPrivateKey(hpemfile, NULL, NULL, NULL); | ^~~~~~~~~~~~~~ In file included from auth_identity.c:43: /usr/include/openssl/pem.h:447:1: note: declared here 447 | DECLARE_PEM_rw_cb_attr(OSSL_DEPRECATEDIN_3_0, RSAPrivateKey, RSA) | ^~~~~~~~~~~~~~~~~~~~~~ auth_identity.c:425:9: warning: 'RSA_size' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 425 | if(initdynstr(&glb_encedmsg, RSA_size(glb_hmyprivkey))) | ^~ In file included from /usr/include/openssl/x509.h:36, from /usr/include/openssl/pem.h:23, from auth_identity.c:43: /usr/include/openssl/rsa.h:212:27: note: declared here 212 | OSSL_DEPRECATEDIN_3_0 int RSA_size(const RSA *rsa); | ^~~~~~~~ auth_identity.c:429:9: warning: 'RSA_size' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 429 | if(initdynstr(&glb_b64encedmsg, (RSA_size(glb_hmyprivkey) / 3 + 1) * 4)) | ^~ In file included from /usr/include/openssl/x509.h:36, from /usr/include/openssl/pem.h:23, from auth_identity.c:43: /usr/include/openssl/rsa.h:212:27: note: declared here 212 | OSSL_DEPRECATEDIN_3_0 int RSA_size(const RSA *rsa); | ^~~~~~~~ CC (gcc) [M auth_identity.so] auth_tables.o LD (gcc) [M auth_identity.so] auth_identity.so ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3502 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3502(a)github.com>

1 year

[kamailio/kamailio] kamailio depends on obsolete pcre3 library (Issue #2946)

by Victor Seva

>From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000134: ``` Source: kamailio Severity: important User: matthew-pcredep(a)debian.org Usertags: obsolete-pcre3 Dear maintainer, Your package still depends on the old, obsolete PCRE3[0] libraries (i.e. libpcre3-dev). This has been end of life for a while now, and upstream do not intend to fix any further bugs in it. Accordingly, I would like to remove the pcre3 libraries from Debian, preferably in time for the release of Bookworm. The newer PCRE2 library was first released in 2015, and has been in Debian since stretch. Upstream's documentation for PCRE2 is available here: https://pcre.org/current/doc/html/ Many large projects that use PCRE have made the switch now (e.g. git, php); it does involve some work, but we are now at the stage where PCRE3 should not be used, particularly if it might ever be exposed to untrusted input. This mass bug filing was discussed on debian-devel@ in https://lists.debian.org/debian-devel/2021/11/msg00176.html Regards, Matthew [0] Historical reasons mean that old PCRE is packaged as pcre3 in Debian ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2946

1 year, 1 month

[kamailio/kamailio] tm:local-request not documented (#980)

by Olle E. Johansson

The local-request event route is not documented. When using our friend google I find an old blog post by @miconda but not much else. I can come up with some good text, but need to know what can be done in the route, like - modify request uri - add/remove headers - drop request - add/modify destination uri ($du) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/980

1 year, 1 month

[kamailio/kamailio] dispatcher: fix weighted sort for n<100 calls (PR #3531)

by Tyler Moore

- update weighted/relative weighted algos to use probability based sort - calls from 0-99 now follow the weighted distributions - removed the now unused shuffle_uint100array() function #### Pre-Submission Checklist - [ x ] Commit message has the format required by CONTRIBUTING guide - [ x ] Commits are split per component (core, individual modules, libs, utils, ...) - [ x ] Each component has a single commit (if not, squash them into one commit) - [ x ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ x ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description The previous random sort for weights in a dispatcher set distributed correctly only after a minimum of n=100 calls. This PR fixes the sort algorithm to distribute calls based on those weights, even for n<100 calls. The real benefit here is customers can see the weighted distribution occur sooner now, when testing. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3531 -- Commit Summary -- * dispatcher: fix weighted sort for n<100 calls -- File Changes -- M src/modules/dispatcher/dispatch.c (313) M src/modules/dispatcher/doc/dispatcher.xml (9) M src/modules/dispatcher/doc/dispatcher_admin.xml (20) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3531.patch https://github.com/kamailio/kamailio/pull/3531.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3531 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3531(a)github.com>

1 year, 1 month

git:master:f221a3ea: core: mem - defines for pkg/shm status filter functions

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f221a3eaf29b78671fb1c603813fe7e6c2314fbf URL: https://github.com/kamailio/kamailio/commit/f221a3eaf29b78671fb1c603813fe7e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-09-29T15:54:27+02:00 core: mem - defines for pkg/shm status filter functions --- Modified: src/core/mem/pkg.h Modified: src/core/mem/shm.h --- Diff: https://github.com/kamailio/kamailio/commit/f221a3eaf29b78671fb1c603813fe7e… Patch: https://github.com/kamailio/kamailio/commit/f221a3eaf29b78671fb1c603813fe7e… --- diff --git a/src/core/mem/pkg.h b/src/core/mem/pkg.h index 9b0e5087d1d..9a6b9dac2b1 100644 --- a/src/core/mem/pkg.h +++ b/src/core/mem/pkg.h @@ -65,6 +65,8 @@ void pkg_print_manager(void); #endif #define pkg_status() _pkg_root.xstatus(_pkg_root.mem_block) +#define pkg_status_filter(fmatch, fp) \ + _pkg_root.xstatus_filter(_pkg_root.mem_block, fmatch, fp) #define pkg_info(mi) _pkg_root.xinfo(_pkg_root.mem_block, mi) #define pkg_report(mr) _pkg_root.xreport(_pkg_root.mem_block, mr) #define pkg_available() _pkg_root.xavailable(_pkg_root.mem_block) diff --git a/src/core/mem/shm.h b/src/core/mem/shm.h index c83c9dd48a6..9cdadc10618 100644 --- a/src/core/mem/shm.h +++ b/src/core/mem/shm.h @@ -53,9 +53,8 @@ extern sr_shm_api_t _shm_root; #define shm_mallocxz(s) \ _shm_root.xmallocxz(_shm_root.mem_block, (s), _SRC_LOC_, _SRC_FUNCTION_, \ _SRC_LINE_, _SRC_MODULE_) -#define shm_mallocxp(s, loc, fname, nline, mname) \ - _shm_root.xmalloc(_shm_root.mem_block, (s), loc, fname, \ - nline, mname) +#define shm_mallocxp(s, loc, fname, nline, mname) \ + _shm_root.xmalloc(_shm_root.mem_block, (s), loc, fname, nline, mname) #define shm_malloc_unsafe(s) \ _shm_root.xmalloc_unsafe(_shm_root.mem_block, (s), _SRC_LOC_, \ _SRC_FUNCTION_, _SRC_LINE_, _SRC_MODULE_) @@ -65,9 +64,8 @@ extern sr_shm_api_t _shm_root; #define shm_reallocxf(p, s) \ _shm_root.xreallocxf(_shm_root.mem_block, (p), (s), _SRC_LOC_, \ _SRC_FUNCTION_, _SRC_LINE_, _SRC_MODULE_) -#define shm_reallocxp(p, s, loc, fname, nline, mname) \ - _shm_root.xrealloc(_shm_root.mem_block, (p), (s), loc, \ - fname, nline, mname) +#define shm_reallocxp(p, s, loc, fname, nline, mname) \ + _shm_root.xrealloc(_shm_root.mem_block, (p), (s), loc, fname, nline, mname) #define shm_resize(p, s) \ _shm_root.xresize(_shm_root.mem_block, (p), (s), _SRC_LOC_, \ _SRC_FUNCTION_, _SRC_LINE_, _SRC_MODULE_) @@ -89,6 +87,8 @@ extern sr_shm_api_t _shm_root; #endif #define shm_status() _shm_root.xstatus(_shm_root.mem_block) +#define shm_status_filter(fmatch, fp) \ + _shm_root.xstatus_filter(_shm_root.mem_block, fmatch, fp) #define shm_info(mi) _shm_root.xinfo(_shm_root.mem_block, mi) #define shm_report(mr) _shm_root.xreport(_shm_root.mem_block, mr) #define shm_available() _shm_root.xavailable(_shm_root.mem_block)

1 year, 1 month

git:master:7018e978: core: mem - api function to print status with filter

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 7018e978b5c6fa3ac42a64985bb6bac24b7aab27 URL: https://github.com/kamailio/kamailio/commit/7018e978b5c6fa3ac42a64985bb6bac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-09-29T15:54:27+02:00 core: mem - api function to print status with filter --- Modified: src/core/mem/memapi.h Modified: src/core/mem/q_malloc.c --- Diff: https://github.com/kamailio/kamailio/commit/7018e978b5c6fa3ac42a64985bb6bac… Patch: https://github.com/kamailio/kamailio/commit/7018e978b5c6fa3ac42a64985bb6bac…

1 year, 1 month

git:master:1947763c: modules: readme files regenerated - ims_qos ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 1947763c176f33bcd3cbdfc54d980648855dff8a URL: https://github.com/kamailio/kamailio/commit/1947763c176f33bcd3cbdfc54d98064… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-09-28T15:46:23+02:00 modules: readme files regenerated - ims_qos ... [skip ci] --- Modified: src/modules/ims_qos/README --- Diff: https://github.com/kamailio/kamailio/commit/1947763c176f33bcd3cbdfc54d98064… Patch: https://github.com/kamailio/kamailio/commit/1947763c176f33bcd3cbdfc54d98064… --- diff --git a/src/modules/ims_qos/README b/src/modules/ims_qos/README index e9c150274eb..b0981a0c151 100644 --- a/src/modules/ims_qos/README +++ b/src/modules/ims_qos/README @@ -64,6 +64,7 @@ Carsten Bock 3.21. omit_flow_ports integer 3.22. rs_default_bandwidth integer 3.23. rr_default_bandwidth integer + 3.24. suspend_transaction integer 4. Functions @@ -101,8 +102,9 @@ Carsten Bock 1.21. omit_flow_ports parameter usage 1.22. rs_default_bandwidth parameter usage 1.23. rr_default_bandwidth parameter usage - 1.24. Rx_AAR_Register - 1.25. Rx_AAR + 1.24. suspend_transaction parameter usage + 1.25. Rx_AAR_Register + 1.26. Rx_AAR Chapter 1. Admin Guide @@ -139,6 +141,7 @@ Chapter 1. Admin Guide 3.21. omit_flow_ports integer 3.22. rs_default_bandwidth integer 3.23. rr_default_bandwidth integer + 3.24. suspend_transaction integer 4. Functions @@ -202,6 +205,7 @@ Chapter 1. Admin Guide 3.21. omit_flow_ports integer 3.22. rs_default_bandwidth integer 3.23. rr_default_bandwidth integer + 3.24. suspend_transaction integer 3.1. rx_dest_realm (string) @@ -492,6 +496,17 @@ modparam("ims_qos", "rs_default_bandwidth", 600) modparam("ims_qos", "rr_default_bandwidth", 2000) ... +3.24. suspend_transaction integer + + If eneabled, suspends the tm transaction while doing the AAR. + + Default value is 1 (enabled) + + Example 1.24. suspend_transaction parameter usage +... +modparam("ims_qos", "suspend_transaction", 2000) +... + 4. Functions 4.1. Rx_AAR_Register(route_block, domain) @@ -522,7 +537,7 @@ modparam("ims_qos", "rr_default_bandwidth", 2000) p.s. this is executed asynchronously. See example on how to retrieve return value - Example 1.24. Rx_AAR_Register + Example 1.25. Rx_AAR_Register ... if(Rx_AAR_Register("REG_AAR_REPLY","location")==0){ exit; @@ -566,7 +581,7 @@ route[REG_AAR_REPLY] p.s. this is executed asynchronously. See example on how to retrieve return value - Example 1.25. Rx_AAR + Example 1.26. Rx_AAR ... if(Rx_AAR("ORIG_SESSION_AAR_REPLY","orig","",-1)==0){ exit;

1 year, 1 month

git:master:21a685a2: ims_qos: Rename new parameter's C variable

by Stefan-Cristian Mititelu

Module: kamailio Branch: master Commit: 21a685a200e1ff638358dbbee607d4ab55c57359 URL: https://github.com/kamailio/kamailio/commit/21a685a200e1ff638358dbbee607d4a… Author: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro> Date: 2023-09-28T16:43:47+03:00 ims_qos: Rename new parameter's C variable --- Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.c --- Diff: https://github.com/kamailio/kamailio/commit/21a685a200e1ff638358dbbee607d4a… Patch: https://github.com/kamailio/kamailio/commit/21a685a200e1ff638358dbbee607d4a…

1 year, 1 month

git:master:d0262f82: ims_qos: Add suspend_transaction parameter

by Stefan Mititelu

Module: kamailio Branch: master Commit: d0262f82fd9cee8670ac01e4f06eb35626b34714 URL: https://github.com/kamailio/kamailio/commit/d0262f82fd9cee8670ac01e4f06eb35… Author: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)govoip.ro> Date: 2023-09-28T16:35:52+03:00 ims_qos: Add suspend_transaction parameter --- Modified: src/modules/ims_qos/doc/ims_qos_admin.xml Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.c --- Diff: https://github.com/kamailio/kamailio/commit/d0262f82fd9cee8670ac01e4f06eb35… Patch: https://github.com/kamailio/kamailio/commit/d0262f82fd9cee8670ac01e4f06eb35…

1 year, 1 month

← Newer
1
...
10
11
12
13
14
15
16
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2023