January 2024 - sr-dev - kamailio.org

git:master:aaa3b102: pkg/kamailio/deb: remove support for tls_wolfssl on bookworm/jammy
by Victor Seva 25 Jan '24

25 Jan '24

Module: kamailio Branch: master Commit: aaa3b102c62af9ac0abe1aaac12876abaa7ad351 URL: https://github.com/kamailio/kamailio/commit/aaa3b102c62af9ac0abe1aaac12876a… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-01-25T12:23:47+01:00 pkg/kamailio/deb: remove support for tls_wolfssl on bookworm/jammy > module expects wolfssl ~ v5.6.6-stable which is equivalent to libwolfssl42(5.6.6-1.2) libwolfssl-dev_5.6.6 --- Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bookworm/rules Modified: pkg/kamailio/deb/debian/backports/bookworm Modified: pkg/kamailio/deb/debian/backports/jammy Modified: pkg/kamailio/deb/jammy/control Modified: pkg/kamailio/deb/jammy/rules --- Diff: https://github.com/kamailio/kamailio/commit/aaa3b102c62af9ac0abe1aaac12876a… Patch: https://github.com/kamailio/kamailio/commit/aaa3b102c62af9ac0abe1aaac12876a…

1 0

Re: [kamailio/kamailio] tls_wolfssl: clean-up; continue to remove OpenSSL-isms (5d3c11c)
by Victor Seva 25 Jan '24

25 Jan '24

Sorry but bookworm has 5.5.4-2 [libwolfssl35](https://packages.debian.org/bookworm/libwolfssl35) and jammy has 5.2.0-2 [libwolfssl32](https://packages.ubuntu.com/jammy/libwolfssl32) I will remove the support for bookworm and jammy for tls_wolfssl then -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/5d3c11c5e0854ce74424a10a88b0cca… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/5d3c11c5e0854ce74424a10a88b0cca4453cee75/137782904(a)github.com>

1 0

Re: [kamailio/kamailio] tls_wolfssl: clean-up; continue to remove OpenSSL-isms (5d3c11c)
by Victor Seva 25 Jan '24

25 Jan '24

This broke the nightly build: https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=… ``` tls_wolfssl_mod.c: In function 'ki_is_peer_verified': tls_wolfssl_mod.c:456:26: error: 'WOLFSSL_X509_V_OK' undeclared (first use in this function); did you mean 'WOLFSSL_X509_V3'? 456 | if(ssl_verify != WOLFSSL_X509_V_OK) { | ^~~~~~~~~~~~~~~~~ | WOLFSSL_X509_V3 tls_wolfssl_mod.c:456:26: note: each undeclared identifier is reported only once for each function it appears in ``` And the test build failed too: https://github.com/kamailio/kamailio/actions/runs/7647318901/job/20838004797 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/5d3c11c5e0854ce74424a10a88b0cca… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/5d3c11c5e0854ce74424a10a88b0cca4453cee75/137775133(a)github.com>

1 0

git:master:5d3c11c5: tls_wolfssl: clean-up; continue to remove OpenSSL-isms
by S-P Chan 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: 5d3c11c5e0854ce74424a10a88b0cca4453cee75 URL: https://github.com/kamailio/kamailio/commit/5d3c11c5e0854ce74424a10a88b0cca… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-25T06:58:39+08:00 tls_wolfssl: clean-up; continue to remove OpenSSL-isms --- Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_select.c Modified: src/modules/tls_wolfssl/tls_verify.c Modified: src/modules/tls_wolfssl/tls_verify.h Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/5d3c11c5e0854ce74424a10a88b0cca… Patch: https://github.com/kamailio/kamailio/commit/5d3c11c5e0854ce74424a10a88b0cca…

1 0

git:master:099eceec: modules: readme files regenerated - ims_charging ... [skip ci]
by Kamailio Dev 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: 099eceecab7af118bfa0bdfca68a8c0b30cec6f0 URL: https://github.com/kamailio/kamailio/commit/099eceecab7af118bfa0bdfca68a8c0… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-01-24T21:31:18+01:00 modules: readme files regenerated - ims_charging ... [skip ci] --- Modified: src/modules/ims_charging/README --- Diff: https://github.com/kamailio/kamailio/commit/099eceecab7af118bfa0bdfca68a8c0… Patch: https://github.com/kamailio/kamailio/commit/099eceecab7af118bfa0bdfca68a8c0… --- diff --git a/src/modules/ims_charging/README b/src/modules/ims_charging/README index 8e61583c0c4..b37cf9ae3a4 100644 --- a/src/modules/ims_charging/README +++ b/src/modules/ims_charging/README @@ -67,6 +67,8 @@ Carlos Ruiz Diaz 4.27. vendor_specific_chargeinfo (int) 4.28. vendor_specific_id (int) 4.29. strip_plus_from_e164 (int) + 4.30. use_pani_from_term_invite (int) + 4.31. node_func (int) 5. Functions @@ -125,8 +127,10 @@ Carlos Ruiz Diaz 1.27. vendor_specific_chargeinfoparameter usage 1.28. vendor_specific_idparameter usage 1.29. strip_plus_from_e164parameter usage - 1.30. Ro_CCR - 1.31. Ro_set_session_id_avp + 1.30. use_pani_from_term_inviteparameter usage + 1.31. node_funcparameter usage + 1.32. Ro_CCR + 1.33. Ro_set_session_id_avp Chapter 1. Admin Guide @@ -175,6 +179,8 @@ Chapter 1. Admin Guide 4.27. vendor_specific_chargeinfo (int) 4.28. vendor_specific_id (int) 4.29. strip_plus_from_e164 (int) + 4.30. use_pani_from_term_invite (int) + 4.31. node_func (int) 5. Functions @@ -378,6 +384,8 @@ Chapter 1. Admin Guide 4.27. vendor_specific_chargeinfo (int) 4.28. vendor_specific_id (int) 4.29. strip_plus_from_e164 (int) + 4.30. use_pani_from_term_invite (int) + 4.31. node_func (int) 4.1. hash_size(int) @@ -772,6 +780,34 @@ modparam("ims_charging", "vendor_specific_id", 10) modparam("ims_charging", "strip_plus_from_e164", 1) ... +4.30. use_pani_from_term_invite (int) + + P-Access-Network-Info is normally relevant for the "orig" scenario + where it's extracted from INVITE. This setting instruct Kamailio to + include it in "term" scenario too, where it might have been added to + the INVITE based on info from a REGISTER. Normally used to start a + charging session when the user is roaming. + + Default value is 0. + + Example 1.30. use_pani_from_term_inviteparameter usage +... +modparam("ims_charging", "use_pani_from_term_invite", 1) +... + +4.31. node_func (int) + + Defines what should be sent as Node-Functionality (862) in the Diameter + Ro request. Possible values are: 0 (S-CSCF), 1 (P-CSCF), 2 (I-CSCF), 3 + (MRFC), 4 (MGCF), 5 (BFCF) or 6 (AS) + + Default value is 0 (S-CSCF). + + Example 1.31. node_funcparameter usage +... +modparam("ims_charging", "node_func", 1) +... + 5. Functions 5.1. Ro_CCR(route_name, direction, reservation_units, @@ -799,7 +835,7 @@ outgoing_trunk_id) This method is executed asynchronously. See example on how to retrieve return value. - Example 1.30. Ro_CCR + Example 1.32. Ro_CCR ... xlog("L_DBG","Sending initial CCR Request for call\n"); Ro_CCR("RO_ASYNC_TERM_REPLY", "term", 30, "1", "1"); @@ -835,7 +871,7 @@ n"); This function can be used from REQUEST_ROUTE or ONREPLY_ROUTE. - Example 1.31. Ro_set_session_id_avp + Example 1.33. Ro_set_session_id_avp ... Ro_set_session_id_avp(); xlog("L_DBG","Ro session AVP has been set: $avp(ro_session_id)\n");

1 0

[kamailio/kamailio] ims_charging: Add option to get and use P-Access-Network-Info for terminating scenario (PR #3726)
by Morten Tryfoss 24 Jan '24

24 Jan '24

Add option to get and use P-Access-Network-Info for the terminating scenario, for use of billing in roaming cases where the PANI header is already known. Currently PANI is only used for the originating scenario. Fixed partly implemented config option to specific role of diameter client. It was currently hardcoded to S-CSCF.  #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3726 -- Commit Summary -- * ims_charging: Add option to get and use P-Access-Network-Info for terminating scenario -- File Changes -- M src/modules/ims_charging/Ro_data.c (2) M src/modules/ims_charging/config.h (2) M src/modules/ims_charging/doc/ims_charging_admin.xml (41) M src/modules/ims_charging/ims_charging_mod.c (10) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3726.patch https://github.com/kamailio/kamailio/pull/3726.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3726 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3726(a)github.com>

1 1

git:master:76cd7979: ims_charging: Add option to get and use P-Access-Network-Info for terminating scenario (#3726)
by GitHub 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: 76cd7979aae176b3fde3b3d73975629b06cd509c URL: https://github.com/kamailio/kamailio/commit/76cd7979aae176b3fde3b3d73975629… Author: Morten Tryfoss <morten(a)tryfoss.no> Committer: GitHub <noreply(a)github.com> Date: 2024-01-24T21:16:08+01:00 ims_charging: Add option to get and use P-Access-Network-Info for terminating scenario (#3726) Add option to configure node functionality for Ro requests --- Modified: src/modules/ims_charging/Ro_data.c Modified: src/modules/ims_charging/config.h Modified: src/modules/ims_charging/doc/ims_charging_admin.xml Modified: src/modules/ims_charging/ims_charging_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/76cd7979aae176b3fde3b3d73975629… Patch: https://github.com/kamailio/kamailio/commit/76cd7979aae176b3fde3b3d73975629…

1 0

git:master:ba36c65d: modules: readme files regenerated - tm ... [skip ci]
by Kamailio Dev 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: ba36c65dfb2a6608dd7d51422a7ed021206bcae3 URL: https://github.com/kamailio/kamailio/commit/ba36c65dfb2a6608dd7d51422a7ed02… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-01-24T17:32:06+01:00 modules: readme files regenerated - tm ... [skip ci] --- Modified: src/modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/ba36c65dfb2a6608dd7d51422a7ed02… Patch: https://github.com/kamailio/kamailio/commit/ba36c65dfb2a6608dd7d51422a7ed02… --- diff --git a/src/modules/tm/README b/src/modules/tm/README index 41dced573d2..18a3efe552e 100644 --- a/src/modules/tm/README +++ b/src/modules/tm/README @@ -1891,7 +1891,7 @@ modparam("tm", "failover_reply_codes", "code=403;code=488;class=5") ... if (!t_relay()) { - sl_reply_error(); + send_reply_error(); break; }; ...

1 0

git:master:d26b0bef: tm: docs - update to use send_reply_error() when t_relay() fails
by Daniel-Constantin Mierla 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: d26b0bef2e76be55c5cb099520f221487d362b48 URL: https://github.com/kamailio/kamailio/commit/d26b0bef2e76be55c5cb099520f2214… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-24T17:17:23+01:00 tm: docs - update to use send_reply_error() when t_relay() fails - the transaction might be already created and needs a stateful reply --- Modified: src/modules/tm/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/d26b0bef2e76be55c5cb099520f2214… Patch: https://github.com/kamailio/kamailio/commit/d26b0bef2e76be55c5cb099520f2214… --- diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml index 15643ed5d47..741505ec2d2 100644 --- a/src/modules/tm/doc/functions.xml +++ b/src/modules/tm/doc/functions.xml @@ -42,7 +42,7 @@ ... if (!t_relay()) { - sl_reply_error(); + send_reply_error(); break; }; ...

1 0

git:master:76b7beef: sl: do not send error reply if message marked with delayed-reply flag
by Daniel-Constantin Mierla 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: 76b7beef6d089272b749aa53f29e100711aa4c50 URL: https://github.com/kamailio/kamailio/commit/76b7beef6d089272b749aa53f29e100… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-24T10:31:07+01:00 sl: do not send error reply if message marked with delayed-reply flag --- Modified: src/modules/sl/sl.c Modified: src/modules/sl/sl_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/76b7beef6d089272b749aa53f29e100… Patch: https://github.com/kamailio/kamailio/commit/76b7beef6d089272b749aa53f29e100… --- diff --git a/src/modules/sl/sl.c b/src/modules/sl/sl.c index 83eb8bac0d3..ef0f0b56f3d 100644 --- a/src/modules/sl/sl.c +++ b/src/modules/sl/sl.c @@ -340,6 +340,10 @@ static int ki_send_reply_error(sip_msg_t *msg) LM_INFO("message marked with final-reply flag\n"); return -2; } + if(msg->msg_flags & FL_DELAYED_REPLY) { + LM_INFO("message marked with delayed-reply flag\n"); + return -3; + } if(sl_bind_tm != 0 && tmb.t_reply_error != NULL) { ret = tmb.t_reply_error(msg); diff --git a/src/modules/sl/sl_funcs.c b/src/modules/sl/sl_funcs.c index 29ef6835e22..5f9ac40991f 100644 --- a/src/modules/sl/sl_funcs.c +++ b/src/modules/sl/sl_funcs.c @@ -416,6 +416,10 @@ int sl_reply_error(struct sip_msg *msg) LM_INFO("message marked with final-reply flag\n"); return -2; } + if(msg->msg_flags & FL_DELAYED_REPLY) { + LM_INFO("message marked with delayed-reply flag\n"); + return -3; + } ret = err2reason_phrase( prev_ser_error, &sip_error, err_buf, sizeof(err_buf), "SL");

1 0

git:master:09c75716: tm: mark request with delayed reply flag
by Daniel-Constantin Mierla 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: 09c75716530f7d8be2671e5823dca5b640cad45a URL: https://github.com/kamailio/kamailio/commit/09c75716530f7d8be2671e5823dca5b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-24T10:26:45+01:00 tm: mark request with delayed reply flag --- Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/09c75716530f7d8be2671e5823dca5b… Patch: https://github.com/kamailio/kamailio/commit/09c75716530f7d8be2671e5823dca5b… --- diff --git a/src/modules/tm/tm.c b/src/modules/tm/tm.c index 0147bf44579..31aa25338e3 100644 --- a/src/modules/tm/tm.c +++ b/src/modules/tm/tm.c @@ -1844,16 +1844,26 @@ static int _w_t_relay_to( if(res <= 0) { if(res != E_CFG) { LM_ERR("t_forward_noack failed\n"); - /* let us save the error code, we might need it later - * when the failure_route has finished (Miklos) */ + if(get_kr() == REQ_ERR_DELAYED) { + p_msg->msg_flags |= FL_DELAYED_REPLY; + } } + /* let us save the error code, we might need it later + * when the failure_route has finished (Miklos) */ tm_error = ser_error; return -1; } return 1; } - if(is_route_type(REQUEST_ROUTE)) - return t_relay_to(p_msg, proxy, force_proto, 0 /* no replication */); + if(is_route_type(REQUEST_ROUTE)) { + res = t_relay_to(p_msg, proxy, force_proto, 0 /* no replication */); + if(res < 0) { + if(get_kr() == REQ_ERR_DELAYED) { + p_msg->msg_flags |= FL_DELAYED_REPLY; + } + } + return res; + } LM_CRIT("unsupported route type: %d\n", get_route_type()); return 0; }

1 0

git:master:5c8cfdd8: core: parser - internal flag to mark delayed local replies
by Daniel-Constantin Mierla 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: 5c8cfdd803e81a592bf9fdeb208b13404e96da25 URL: https://github.com/kamailio/kamailio/commit/5c8cfdd803e81a592bf9fdeb208b134… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-24T10:23:01+01:00 core: parser - internal flag to mark delayed local replies --- Modified: src/core/parser/msg_parser.h --- Diff: https://github.com/kamailio/kamailio/commit/5c8cfdd803e81a592bf9fdeb208b134… Patch: https://github.com/kamailio/kamailio/commit/5c8cfdd803e81a592bf9fdeb208b134… --- diff --git a/src/core/parser/msg_parser.h b/src/core/parser/msg_parser.h index 303c8c04248..45e7eb1a714 100644 --- a/src/core/parser/msg_parser.h +++ b/src/core/parser/msg_parser.h @@ -133,7 +133,8 @@ typedef enum request_method /* WARNING: Value (1 << 31) is reserved for use in kamailio * nat_traversal module (flag FL_DO_KEEPALIVE)! */ -#define FL_FINAL_REPLY (1ULL << 32) /* final reply sent */ +#define FL_FINAL_REPLY (1ULL << 32) /* local final reply sent */ +#define FL_DELAYED_REPLY (1ULL << 33) /* local reply sending delayed */ #define FL_MTU_FB_MASK (FL_MTU_TCP_FB | FL_MTU_TLS_FB | FL_MTU_SCTP_FB)

1 0

git:master:236c56f5: tm: prefixed global kill reason variable
by Daniel-Constantin Mierla 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: 236c56f5f4c11fb867e545f830182b386f0a0c66 URL: https://github.com/kamailio/kamailio/commit/236c56f5f4c11fb867e545f830182b3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-24T09:19:57+01:00 tm: prefixed global kill reason variable --- Modified: src/modules/tm/h_table.c --- Diff: https://github.com/kamailio/kamailio/commit/236c56f5f4c11fb867e545f830182b3… Patch: https://github.com/kamailio/kamailio/commit/236c56f5f4c11fb867e545f830182b3… --- diff --git a/src/modules/tm/h_table.c b/src/modules/tm/h_table.c index 2d21eb12eca..7ee7c67470c 100644 --- a/src/modules/tm/h_table.c +++ b/src/modules/tm/h_table.c @@ -52,7 +52,7 @@ - sizeof(((tm_cell_t *)0)->md5))) -static enum kill_reason kr; +static enum kill_reason _tm_kr; /* pointer to the big table where all the transaction data lives */ struct s_table *_tm_table; @@ -64,18 +64,18 @@ struct s_table *tm_get_table(void) void reset_kr(void) { - kr = 0; + _tm_kr = 0; } void set_kr(enum kill_reason _kr) { - kr |= _kr; + _tm_kr |= _kr; } enum kill_reason get_kr() { - return kr; + return _tm_kr; }

1 0

git:5.7:893e9ea4: tls_wolfssl: clean-up; remove OpenSSL-isms
by S-P Chan 24 Jan '24

24 Jan '24

Module: kamailio Branch: 5.7 Commit: 893e9ea4364f60c32a5477c5b75bdc24b619dd52 URL: https://github.com/kamailio/kamailio/commit/893e9ea4364f60c32a5477c5b75bdc2… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-24T15:53:01+08:00 tls_wolfssl: clean-up; remove OpenSSL-isms (cherry-pick from 3d0e7521c6de4023b6595685fc306129ef57b8ac) --- Modified: src/modules/tls_wolfssl/tls_cfg.c Modified: src/modules/tls_wolfssl/tls_cfg.h Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_init.c Modified: src/modules/tls_wolfssl/tls_init.h Modified: src/modules/tls_wolfssl/tls_rpc.c Modified: src/modules/tls_wolfssl/tls_server.c Modified: src/modules/tls_wolfssl/tls_util.c Modified: src/modules/tls_wolfssl/tls_util.h Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c Removed: src/modules/tls_wolfssl/tls_dump_vf.c Removed: src/modules/tls_wolfssl/tls_dump_vf.h Removed: src/modules/tls_wolfssl/tls_map.c Removed: src/modules/tls_wolfssl/tls_map.h --- Diff: https://github.com/kamailio/kamailio/commit/893e9ea4364f60c32a5477c5b75bdc2… Patch: https://github.com/kamailio/kamailio/commit/893e9ea4364f60c32a5477c5b75bdc2…

1 0

git:5.7:4240cbc1: tls_wolfssl: refactor custom BIO
by S-P Chan 24 Jan '24

24 Jan '24

Module: kamailio Branch: 5.7 Commit: 4240cbc1bdbf9eb5d8b3f7473fbf4ee9d4d90650 URL: https://github.com/kamailio/kamailio/commit/4240cbc1bdbf9eb5d8b3f7473fbf4ee… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-24T15:52:46+08:00 tls_wolfssl: refactor custom BIO - remove use of custom BIO at the expense of some memory copies (cherry-pick from 32089e134413200bf5d1a97f207378b7d10e65a2) --- Modified: src/modules/tls_wolfssl/tls_rpc.c Modified: src/modules/tls_wolfssl/tls_server.c Modified: src/modules/tls_wolfssl/tls_server.h Removed: src/modules/tls_wolfssl/tls_bio.c Removed: src/modules/tls_wolfssl/tls_bio.h --- Diff: https://github.com/kamailio/kamailio/commit/4240cbc1bdbf9eb5d8b3f7473fbf4ee… Patch: https://github.com/kamailio/kamailio/commit/4240cbc1bdbf9eb5d8b3f7473fbf4ee…

1 0

git:5.7:8e7df134: tls_wolfssl: use shared WOLFSSL_CTX
by S-P Chan 24 Jan '24

24 Jan '24

Module: kamailio Branch: 5.7 Commit: 8e7df1345c828eeb6b999c30069e75ccdd440200 URL: https://github.com/kamailio/kamailio/commit/8e7df1345c828eeb6b999c30069e75c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-24T15:52:22+08:00 tls_wolfssl: use shared WOLFSSL_CTX (cherry-pick from 88f27e2b89142652ea1b8f133df1ff403f9f61b2) --- Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/8e7df1345c828eeb6b999c30069e75c… Patch: https://github.com/kamailio/kamailio/commit/8e7df1345c828eeb6b999c30069e75c…

1 0

git:5.7:0a481501: tls_wolfssl: clean-up OpenSSL compatibility
by S-P Chan 24 Jan '24

24 Jan '24

Module: kamailio Branch: 5.7 Commit: 0a481501024b0e85bde8fa74cde1df2bebaa167b URL: https://github.com/kamailio/kamailio/commit/0a481501024b0e85bde8fa74cde1df2… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-24T15:52:08+08:00 tls_wolfssl: clean-up OpenSSL compatibility - remove unneeded OpenSSL-isms (cherry-pick from 255e563e94e9536f0e541c3baeec45cbc68fac5b) --- Modified: src/modules/tls_wolfssl/tls_config.h Modified: src/modules/tls_wolfssl/tls_ct_wrq.h Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_init.h Modified: src/modules/tls_wolfssl/tls_util.h Modified: src/modules/tls_wolfssl/tls_verify.c Modified: src/modules/tls_wolfssl/tls_verify.h Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c Removed: src/modules/tls_wolfssl/tls_rand.c Removed: src/modules/tls_wolfssl/tls_rand.h --- Diff: https://github.com/kamailio/kamailio/commit/0a481501024b0e85bde8fa74cde1df2… Patch: https://github.com/kamailio/kamailio/commit/0a481501024b0e85bde8fa74cde1df2…

1 0

git:master:3d0e7521: tls_wolfssl: clean-up; remove OpenSSL-isms
by S-P Chan 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: 3d0e7521c6de4023b6595685fc306129ef57b8ac URL: https://github.com/kamailio/kamailio/commit/3d0e7521c6de4023b6595685fc30612… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-24T15:32:26+08:00 tls_wolfssl: clean-up; remove OpenSSL-isms --- Modified: src/modules/tls_wolfssl/tls_cfg.c Modified: src/modules/tls_wolfssl/tls_cfg.h Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_init.c Modified: src/modules/tls_wolfssl/tls_init.h Modified: src/modules/tls_wolfssl/tls_rpc.c Modified: src/modules/tls_wolfssl/tls_server.c Modified: src/modules/tls_wolfssl/tls_util.c Modified: src/modules/tls_wolfssl/tls_util.h Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c Removed: src/modules/tls_wolfssl/tls_dump_vf.c Removed: src/modules/tls_wolfssl/tls_dump_vf.h Removed: src/modules/tls_wolfssl/tls_map.c Removed: src/modules/tls_wolfssl/tls_map.h --- Diff: https://github.com/kamailio/kamailio/commit/3d0e7521c6de4023b6595685fc30612… Patch: https://github.com/kamailio/kamailio/commit/3d0e7521c6de4023b6595685fc30612…

1 0

git:master:33b2e513: tm: release transaction on kill if a final response was sent
by Daniel-Constantin Mierla 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: 33b2e513aefe00bf166cdcae360e305615b223da URL: https://github.com/kamailio/kamailio/commit/33b2e513aefe00bf166cdcae360e305… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-23T21:05:41+01:00 tm: release transaction on kill if a final response was sent - do not send another final response for error cases --- Modified: src/modules/tm/t_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/33b2e513aefe00bf166cdcae360e305… Patch: https://github.com/kamailio/kamailio/commit/33b2e513aefe00bf166cdcae360e305… --- diff --git a/src/modules/tm/t_funcs.c b/src/modules/tm/t_funcs.c index b9f9949d0fb..5515a4aba6f 100644 --- a/src/modules/tm/t_funcs.c +++ b/src/modules/tm/t_funcs.c @@ -177,6 +177,11 @@ int kill_transaction(struct cell *trans, int error) int reply_ret; int ret; + if((trans->uas.request != NULL) + && (trans->uas.request->msg_flags & FL_FINAL_REPLY)) { + return t_release_transaction(trans); + } + /* we reply statefully and enter WAIT state since error might have occurred in middle of forking and we do not want to put the forking burden on upstream client; @@ -205,6 +210,11 @@ int kill_transaction_unsafe(struct cell *trans, int error) int reply_ret; int ret; + if((trans->uas.request != NULL) + && (trans->uas.request->msg_flags & FL_FINAL_REPLY)) { + return t_release_transaction(trans); + } + /* we reply statefully and enter WAIT state since error might have occurred in middle of forking and we do not want to put the forking burden on upstream client;

1 0

git:master:0f8f4d69: auth: reformat exported structures
by Daniel-Constantin Mierla 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: 0f8f4d6926e53ca5e526a11729f6ee6277b185b9 URL: https://github.com/kamailio/kamailio/commit/0f8f4d6926e53ca5e526a11729f6ee6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-23T14:25:09+01:00 auth: reformat exported structures --- Modified: src/modules/auth/auth_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0f8f4d6926e53ca5e526a11729f6ee6… Patch: https://github.com/kamailio/kamailio/commit/0f8f4d6926e53ca5e526a11729f6ee6…

1 0

git:master:aa167c41: auth: removed commented code and prefixed short global variable
by Daniel-Constantin Mierla 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: aa167c410860732918061106c4a84a7c6b030d69 URL: https://github.com/kamailio/kamailio/commit/aa167c410860732918061106c4a84a7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-23T14:25:09+01:00 auth: removed commented code and prefixed short global variable --- Modified: src/modules/auth/auth_mod.c Modified: src/modules/auth/auth_mod.h Modified: src/modules/auth/nid.c Modified: src/modules/auth/nonce.c --- Diff: https://github.com/kamailio/kamailio/commit/aa167c410860732918061106c4a84a7… Patch: https://github.com/kamailio/kamailio/commit/aa167c410860732918061106c4a84a7… --- diff --git a/src/modules/auth/auth_mod.c b/src/modules/auth/auth_mod.c index fb633a10259..9bf4ac2923a 100644 --- a/src/modules/auth/auth_mod.c +++ b/src/modules/auth/auth_mod.c @@ -138,7 +138,7 @@ calc_response_t calc_response; /*! SL API structure */ -sl_api_t slb; +sl_api_t _auth_slb; /* * Exported functions @@ -248,8 +248,6 @@ static inline int generate_random_secret(void) secret2.s = sec_rand2; secret2.len = RAND_SECRET_LEN; - /* DBG("Generated secret: '%.*s'\n", secret.len, secret.s); */ - return 0; } @@ -263,7 +261,7 @@ static int mod_init(void) auth_realm_prefix.len = strlen(auth_realm_prefix.s); /* bind the SL API */ - if(sl_load_api(&slb) != 0) { + if(sl_load_api(&_auth_slb) != 0) { LM_ERR("cannot bind to SL API\n"); return -1; } @@ -949,8 +947,8 @@ static int auth_send_reply( reason_str.s = reason; reason_str.len = strlen(reason); - return force_stateless_reply ? slb.sreply(msg, code, &reason_str) - : slb.freply(msg, code, &reason_str); + return force_stateless_reply ? _auth_slb.sreply(msg, code, &reason_str) + : _auth_slb.freply(msg, code, &reason_str); } /** diff --git a/src/modules/auth/auth_mod.h b/src/modules/auth/auth_mod.h index ea3617e3d5e..48066750d2d 100644 --- a/src/modules/auth/auth_mod.h +++ b/src/modules/auth/auth_mod.h @@ -38,7 +38,6 @@ extern str secret1; /* secret phrase used to generate nonce */ extern str secret2; /* secret phrase used to generate nonce */ extern int nonce_expire; /* nonce expire interval */ extern int protect_contacts; /* Enable/disable contact hashing in nonce */ -extern sl_api_t sl; extern avp_ident_t challenge_avpid; extern str proxy_challenge_header; extern str www_challenge_header; diff --git a/src/modules/auth/nid.c b/src/modules/auth/nid.c index 408e6ab3e14..3aee167c633 100644 --- a/src/modules/auth/nid.c +++ b/src/modules/auth/nid.c @@ -77,11 +77,6 @@ int init_nonce_id() for(r = 0; r < nid_pool_no; r++) atomic_set(&nid_crt[r].id, random()); return 0; - /* -error: - destroy_nonce_id(); - return -1; -*/ } diff --git a/src/modules/auth/nonce.c b/src/modules/auth/nonce.c index 0304b394bd7..56cd49b7ec2 100644 --- a/src/modules/auth/nonce.c +++ b/src/modules/auth/nonce.c @@ -223,7 +223,7 @@ int calc_nonce(char *nonce, int *nonce_len, int cfg, unsigned int since, len = calc_bin_nonce_md5(&b_nonce, cfg, secret1, secret2, msg); *nonce_len = base64_enc( &b_nonce.raw[0], len, (unsigned char *)nonce, *nonce_len); - assert(*nonce_len >= 0); /*FIXME*/ + assert(*nonce_len >= 0); return 0; }

1 0

git:master:32089e13: tls_wolfssl: refactor custom BIO
by S-P Chan 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: 32089e134413200bf5d1a97f207378b7d10e65a2 URL: https://github.com/kamailio/kamailio/commit/32089e134413200bf5d1a97f207378b… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-23T21:02:57+08:00 tls_wolfssl: refactor custom BIO - remove use of custom BIO at the expense of some memory copies --- Modified: src/modules/tls_wolfssl/tls_rpc.c Modified: src/modules/tls_wolfssl/tls_server.c Modified: src/modules/tls_wolfssl/tls_server.h Removed: src/modules/tls_wolfssl/tls_bio.c Removed: src/modules/tls_wolfssl/tls_bio.h --- Diff: https://github.com/kamailio/kamailio/commit/32089e134413200bf5d1a97f207378b… Patch: https://github.com/kamailio/kamailio/commit/32089e134413200bf5d1a97f207378b…

1 0

git:master:88f27e2b: tls_wolfssl: use shared WOLFSSL_CTX
by S-P Chan 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: 88f27e2b89142652ea1b8f133df1ff403f9f61b2 URL: https://github.com/kamailio/kamailio/commit/88f27e2b89142652ea1b8f133df1ff4… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-23T10:51:37+08:00 tls_wolfssl: use shared WOLFSSL_CTX --- Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/88f27e2b89142652ea1b8f133df1ff4… Patch: https://github.com/kamailio/kamailio/commit/88f27e2b89142652ea1b8f133df1ff4…

1 0

git:master:255e563e: tls_wolfssl: clean-up OpenSSL compatibility
by S-P Chan 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: 255e563e94e9536f0e541c3baeec45cbc68fac5b URL: https://github.com/kamailio/kamailio/commit/255e563e94e9536f0e541c3baeec45c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-23T10:51:37+08:00 tls_wolfssl: clean-up OpenSSL compatibility - remove unneeded OpenSSL-isms --- Modified: src/modules/tls_wolfssl/tls_config.h Modified: src/modules/tls_wolfssl/tls_ct_wrq.h Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_init.h Modified: src/modules/tls_wolfssl/tls_util.h Modified: src/modules/tls_wolfssl/tls_verify.c Modified: src/modules/tls_wolfssl/tls_verify.h Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c Removed: src/modules/tls_wolfssl/tls_rand.c Removed: src/modules/tls_wolfssl/tls_rand.h --- Diff: https://github.com/kamailio/kamailio/commit/255e563e94e9536f0e541c3baeec45c… Patch: https://github.com/kamailio/kamailio/commit/255e563e94e9536f0e541c3baeec45c…

1 0

[kamailio/kamailio] Silence “make: --libs: No such file or directory” warnings (PR #3475)
by Дилян Палаузов 23 Jan '24

23 Jan '24

With GNU make 4.4 building Kamailio prints many “make: --libs: No such file or directory” and similar warnings. This changeset utilizes immediate variables and silences the warnings on my systems. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3475 -- Commit Summary -- * lib/ims: Aviod “make: --libs: No such file or directory” warnings * auth_identity: Aviod “make: --libs: No such file or directory” warnings * auth_ephemeral: Aviod “make: --libs: No such file or directory” warnings * app_python3: Avoid “/bin/sh: line 1: --ldflags: command not found” warnings * app_python3s: Avoid “/bin/sh: line 1: --ldflags: command not found” warnings * cdp: Aviod “make: --libs: No such file or directory” warnings * cnxcc: Avoid “make: --libs-only-L: No such file or directory” warnings * cplc: Avoid “make: --libs-only-L: No such file or directory” warnings * crypto: Aviod “make: --libs: No such file or directory” warnings * db_postgres: Avoid “make: --libs-only-L: No such file or directory” warnings * db_redis: Avoid “make: --libs-only-L: No such file or directory” warning * dialplan: Avoid “make: --libs-only-L: No such file or directory” warning * gzcompress: Aviod “make: --libs: No such file or directory” warnings * http_async_client: Aviod “make: --libs: No such file or directory” warnings * http_client: Aviod “make: --libs: No such file or directory” warning * ims_auth: Avoid “make: --libs-only-L: No such file or directory” warning * ims_icscf: Aviod “make: --libs: No such file or directory” warning * ims_registrar_scscf: Avoid “make: --libs-only-L: No such file or directory” warnings * ims_registrar_pcscf: Aviod “make: --libs: No such file or directory” warning * ims_isc: Avoid “make: --libs-only-L: No such file or directory” warnings * jansson: Aviod “make: --libs: No such file or directory” warning * kazoo: Avoid “make: --libs: No such file or directory’ warning * lcr: Aviod “make: --libs: No such file or directory” warning * log_systemd: Aviod “make: --libs: No such file or directory” warning * lost: Aviod “make: --libs: No such file or directory” warnings * lwsc: Aviod “make: --libs: No such file or directory” warning * ndb_redis: Aviod “make: --libs: No such file or directory” warning * osp: Avoid “make: --libs: No such file or directory’ warning * outbound: Aviod “make: --libs: No such file or directory” warnings * presence: Avoid “make: --libs-only-L: No such file or directory” warnings * presence_conference: Aviod “make: --libs: No such file or directory” warning * presence_dialog: Aviod “make: --libs: No such file or directory” warning * presence_reginfo: Aviod “make: --libs: No such file or directory” warning * presence_xml: Avoid “make: --libs-only-L: No such file or directory” warnings * pua: Avoid “make: --libs-only-L: No such file or directory” warnings * pua_bla: Aviod “make: --libs: No such file or directory” warning * pua_dialoginfo: Aviod “make: --libs: No such file or directory” warning * pua_reginfo: Aviod “make: --libs: No such file or directory” warning * pua_usrloc: Aviod “make: --libs: No such file or directory” warning * pua_xmpp: Aviod “make: --libs: No such file or directory” warning * regex: Aviod “make: --libs: No such file or directory” warning * rls: Avoid “make: --libs-only-L: No such file or directory” warnings * slack: Aviod “make: --libs: No such file or directory” warning * systemdops: Avoid “make: --libs-only-L: No such file or directory” warning * tls: Aviod “make: --libs: No such file or directory” warnings * tlsa: Avoid “make: --libs-only-L: No such file or directory” warning * topos_redis: Aviod “make: --libs: No such file or directory” warning * utils: Avoid “make: --libs-only-L: No such file or directory” warnings * uuid: Aviod “make: --libs: No such file or directory” warning * websocket: Aviod “make: --libs: No such file or directory” warnings * xcap_server: Avoid “make: --libs-only-L: No such file or directory” warnings * xhttp_pi: Avoid “make: --libs-only-L: No such file or directory” warnings * xmlops: Aviod “make: --libs: No such file or directory” warning * xmlrpc: Aviod “make: --libs: No such file or directory” warning -- File Changes -- M src/lib/ims/Makefile (4) M src/modules/app_python3/Makefile (6) M src/modules/app_python3s/Makefile (6) M src/modules/auth_ephemeral/Makefile (2) M src/modules/auth_identity/Makefile (4) M src/modules/cdp/Makefile (4) M src/modules/cnxcc/Makefile (4) M src/modules/cplc/Makefile (4) M src/modules/crypto/Makefile (2) M src/modules/db_postgres/Makefile (2) M src/modules/db_redis/Makefile (2) M src/modules/dialplan/Makefile (2) M src/modules/gzcompress/Makefile (2) M src/modules/http_async_client/Makefile (6) M src/modules/http_client/Makefile (2) M src/modules/ims_auth/Makefile (4) M src/modules/ims_icscf/Makefile (4) M src/modules/ims_isc/Makefile (4) M src/modules/ims_registrar_pcscf/Makefile (4) M src/modules/ims_registrar_scscf/Makefile (4) M src/modules/jansson/Makefile (2) M src/modules/kazoo/Makefile (2) M src/modules/lcr/Makefile (2) M src/modules/log_systemd/Makefile (2) M src/modules/lost/Makefile (6) M src/modules/lwsc/Makefile (2) M src/modules/ndb_redis/Makefile (2) M src/modules/osp/Makefile (2) M src/modules/outbound/Makefile (7) M src/modules/presence/Makefile (4) M src/modules/presence_conference/Makefile (4) M src/modules/presence_dialoginfo/Makefile (4) M src/modules/presence_reginfo/Makefile (4) M src/modules/presence_xml/Makefile (4) M src/modules/pua/Makefile (4) M src/modules/pua_bla/Makefile (4) M src/modules/pua_dialoginfo/Makefile (4) M src/modules/pua_reginfo/Makefile (4) M src/modules/pua_usrloc/Makefile (4) M src/modules/pua_xmpp/Makefile (4) M src/modules/regex/Makefile (2) M src/modules/rls/Makefile (4) M src/modules/slack/Makefile (2) M src/modules/systemdops/Makefile (2) M src/modules/tls/Makefile (4) M src/modules/tlsa/Makefile (4) M src/modules/topos_redis/Makefile (2) M src/modules/utils/Makefile (4) M src/modules/uuid/Makefile (2) M src/modules/websocket/Makefile (2) M src/modules/xcap_server/Makefile (4) M src/modules/xhttp_pi/Makefile (4) M src/modules/xmlops/Makefile (4) M src/modules/xmlrpc/Makefile (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3475.patch https://github.com/kamailio/kamailio/pull/3475.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3475 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3475(a)github.com>

4 16

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2024