sr-dev November 2024

sr-dev@lists.kamailio.org

20 participants
376 discussions

[kamailio/kamailio] Kamailio hangs on get_profile_size method. (Issue #3947)
by schiramchetty 03 Nov '24

03 Nov '24

### Description We are facing a hang issue with Kamailio for the get_profile_size method. Randomly, the Kamailio got hangs, and the CPU went 100%. During the hanging time, we generated the TRAP and we could see that the hang happened on the get_profile_size method. We are getting this hang randomly in dlg_profile.c of the following lines: The hang occurs, causing the CPU to spike to 100% at one of the following lines randomly: 1. if(value->len == ph->value.len && memcmp(value->s, ph->value.s, value->len) == 0) { 2. ph = ph->next; 3. while(ph != profile->entries[i].first); During our analysis, we found that PROCESS ID 7608 gets a spike of 100% utilization. We suspect there may be an issue with the processing of the 'ph' variable, but we couldn't identify the root cause. I've attached the Kamailio TRAP for further details. Could you please suggest what might be causing this problem and how we can resolve it?  ### Troubleshooting We have analysed the coredump and TRAP, And found that the issue could be from the following lines: 1. if(value->len == ph->value.len && memcmp(value->s, ph->value.s, value->len) == 0) { 2. ph = ph->next; 3. while(ph != profile->entries[i].first); #### Reproduction This issue is occurring randomly.  #### Debugging Data I have attached the TRAP data. ---start 7608 ----------------------------------------------------- [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". get_profile_size (profile=0x7f7095698f50, value=0x7ffd5e21db20) at dlg_profile.c:860 860 }while( ph!=profile->entries[i].first ); #0 get_profile_size (profile=0x7f7095698f50, value=0x7ffd5e21db20) at dlg_profile.c:860 n = 0 i = 9 ph = 0x7f70958d3c98 #1 0x00007f7195585785 in w_get_profile_size_helper (msg=0x7f7198418558, profile=0x7f7095698f50, value=0x7ffd5e21db20, spd=0x7f71983a8cf0) at dialog.c:941 size = 32625 val = {rs = {s = 0x7ffd5e21da80 "\260\332!^\375\177", len = 591976160}, ri = xxxxxxxx77096, flags = 32765} __func__ = "w_get_profile_size_helper" #2 0x00007f7195585fd2 in w_get_profile_size3 (msg=0x7f7198418558, profile=0x7f7095698f50 "\200\220i\225p\177", value=0x7f71983b4b30 "80;\230q\177", result=0x7f71983a8cf0 "\004") at dialog.c:982 pve = 0x7f71983b4b30 val_s = {s = 0x7f7198346dd0 "2777995", len = 7} spd = 0x7f71983a8cf0 __func__ = "w_get_profile_size3"  #### Log Messages When Kamailio hangs, the logs are not written to the kamailio.log file.  #### SIP Traffic I have attached the TRAP file.  ### Possible Solutions We are expecting some kind of solution for it.  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio version is 5.5.5``` * **Operating System**: [gdb_kamailio_trap.zip](https://github.com/user-attachments/files/16581474/g… ``` "Debian GNU/Linux 10 (buster)"``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3947 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3947(a)github.com>

3 4

[kamailio/kamailio] ndb_redis: Error when receiving 'MOVED' response from redis-cluster with TLS (Issue #3894)
by uv-2722 03 Nov '24

03 Nov '24

### Description Hello, I am using ndb_redis module with TLS and redis-cluster. kamailio connects to the cluster endpoint when getting data, gets a 'MOVED' response and prints below error, it does not get data from the new host. ### Troubleshooting I have verified that I can connect to the cluster endpoint and the host in 'MOVED' using redis-cli on the system that kamailio is running on. I tried to connect to a self hosted cluster without TLS, it works as expected. It also works as expected with TLS and a single redis host. #### Reproduction Connect to a redis-cluster over TLS #### Log Messages  ``` 2024-06-25T20:48:53.626708963Z 2024-06-25 20:48:53.626584 3(17) NOTICE: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:437]: redisc_get_server(): Hash 31807 (ra) 2024-06-25T20:48:53.626710053Z 2024-06-25 20:48:53.626600 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:440]: redisc_get_server(): Entry 31807 (ra) 2024-06-25T20:48:53.626711073Z 2024-06-25 20:48:53.626636 3(17) NOTICE: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:444]: redisc_get_server(): Using entry 31807 (ra) 2024-06-25T20:48:53.626712073Z 2024-06-25 20:48:53.626651 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:1030]: redisc_exec(): rsrv->ctxRedis = 0x556b4456dc20 2024-06-25T20:48:53.626713073Z 2024-06-25 20:48:53.626667 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:1036]: redisc_exec(): rsrv->ctxRedis = 0x556b4456dc20 2024-06-25T20:48:53.626810463Z 2024-06-25 20:48:53.626762 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:896]: check_cluster_reply(): Redis replied: "MOVED 3667 testdbredis-masked-hostname.00000000001110000000.130-characters-long.00000000000011111111100000000.availability-zone.amazonaws.com:6379" 2024-06-25T20:48:53.626811523Z 2024-06-25 20:48:53.626777 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:904]: check_cluster_reply(): Port "6379" [4] => 6379 2024-06-25T20:48:53.626816413Z 2024-06-25 20:48:53.626793 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:914]: check_cluster_reply(): Host "testdbredis-masked-hostname.00000000001110000000.130-characters-long.000000…" [130] 2024-06-25T20:48:53.626846113Z 2024-06-25 20:48:53.626810 3(17) NOTICE: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:925]: check_cluster_reply(): Name of new connection: testdbredis-masked-hostname.00000000001110000000.130-characters-long.00000000000011111111100000000. 2024-06-25T20:48:53.626851443Z 2024-06-25 20:48:53.626827 3(17) NOTICE: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:437]: redisc_get_server(): Hash 968070864 (testdbredis-masked-hostname.00000000001110000000.130-characters-long.00000000000011111111100000000.) 2024-06-25T20:48:53.626896173Z 2024-06-25 20:48:53.626844 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:440]: redisc_get_server(): Entry 31807 (ra) 2024-06-25T20:48:53.626897503Z 2024-06-25 20:48:53.626861 3(17) NOTICE: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:450]: redisc_get_server(): No entry found. 2024-06-25T20:48:53.626955363Z 2024-06-25 20:48:53.626877 3(17) ERROR: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:947]: check_cluster_reply(): failed to print server spec string 2024-06-25T20:48:53.626957263Z 2024-06-25 20:48:53.626893 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:1115]: redisc_exec(): rpl->rplRedis->type:6 2024-06-25T20:48:53.626958443Z 2024-06-25 20:48:53.626908 3(17) ERROR: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:1117]: redisc_exec(): Redis error:MOVED 3667 testdbredis-masked-hostname.00000000001110000000.130-characters-long.00000000000011111111100000000.availability-zone.amazonaws.com:6379 ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.1 (x86_64/linux) 384843 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 384843 compiled on 19:05:30 Jun 25 2024 with gcc 12.2.0 ``` * Hiredis(v1.2.0) and hiredis-cluster(v0.13.0) are installed from source, both with ssl support. * **Operating System**:  ``` Debian 12 ``` ### Kamailio config snippet ``` loadmodule "ndb_redis.so" . . # ----- ndb_redis params ----- modparam("ndb_redis", "server", "name=ra;addr=cluster.testdbredis-masked-hostname.0000000011111111100000.availability-zone.amazonaws.com;port=6379;tls=1") modparam("ndb_redis", "init_without_redis", 1) modparam("ndb_redis", "cluster", 1) modparam("ndb_redis", "allow_dynamic_nodes", 1) modparam("ndb_redis", "ca_path", "/etc/ssl/certs") modparam("ndb_redis", "debug", 1) . . redis_cmd("ra", "HMGET usr_preferences:entry::%s:%s blocked", "$rU", "$fU", "r"); if($redis(r=>value[0]) == 1) { . } ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3894 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3894(a)github.com>

4 10

git:master:75fd8efc: modules: readme files regenerated - tm ... [skip ci]
by Kamailio Dev 02 Nov '24

02 Nov '24

Module: kamailio Branch: master Commit: 75fd8efcdf46f8745629fbfaf005bfbed5ed89e7 URL: https://github.com/kamailio/kamailio/commit/75fd8efcdf46f8745629fbfaf005bfb… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-11-02T23:31:10+01:00 modules: readme files regenerated - tm ... [skip ci] --- Modified: src/modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/75fd8efcdf46f8745629fbfaf005bfb… Patch: https://github.com/kamailio/kamailio/commit/75fd8efcdf46f8745629fbfaf005bfb… --- diff --git a/src/modules/tm/README b/src/modules/tm/README index dbeff43d002..5cb84f624ed 100644 --- a/src/modules/tm/README +++ b/src/modules/tm/README @@ -145,6 +145,7 @@ Daniel-Constantin Mierla 4.55. t_get_status_code() 4.56. t_clean() 4.57. t_exists() + 4.58. t_cell_append_branches(tindex, tlabel) 5. RPC Commands @@ -292,9 +293,10 @@ Daniel-Constantin Mierla 1.105. t_get_status_code usage 1.106. t_clean usage 1.107. t_exists usage - 1.108. event_route[tm:branch-failure:id] usage - 1.109. event_route[tm:local-request] usage - 1.110. event_route[tm:local-response] usage + 1.108. t_cell_append_branches usage + 1.109. event_route[tm:branch-failure:id] usage + 1.110. event_route[tm:local-request] usage + 1.111. event_route[tm:local-response] usage Chapter 1. Admin Guide @@ -420,6 +422,7 @@ Chapter 1. Admin Guide 4.55. t_get_status_code() 4.56. t_clean() 4.57. t_exists() + 4.58. t_cell_append_branches(tindex, tlabel) 5. RPC Commands @@ -1900,6 +1903,7 @@ modparam("tm", "failover_reply_codes", "code=403;code=488;class=5") 4.55. t_get_status_code() 4.56. t_clean() 4.57. t_exists() + 4.58. t_cell_append_branches(tindex, tlabel) 4.1. t_relay([host, port]) @@ -3113,6 +3117,17 @@ reply_route { } ... +4.58. t_cell_append_branches(tindex, tlabel) + + Append destination set branches to the transaction identified by + (tindex, tlabel). The parameters can also be variables. + + Example 1.108. t_cell_append_branches usage +... + append_branch("sip:1.2.3.4:5060"); + t_cell_append_branches("1234", "$var(tlabel)"); +... + 5. RPC Commands 5.1. tm.list @@ -3234,7 +3249,7 @@ reply_route { enabled with the t_on_branch_failure function. This event_route uses the BRANCH_FAILURE_ROUTE route type. - Example 1.108. event_route[tm:branch-failure:id] usage + Example 1.109. event_route[tm:branch-failure:id] usage ... request_route { ... @@ -3260,7 +3275,7 @@ event_route[tm:branch-failure:myroute] { The request can still be updated, i.e., changes are possible to R-URI ($ru), destination URI ($du) or the send socket ($fs). - Example 1.109. event_route[tm:local-request] usage + Example 1.110. event_route[tm:local-request] usage ... event_route [tm:local-request] { xlog("L_INFO", "Routing locally generated $rm to $ru\n"); @@ -3273,7 +3288,7 @@ event_route [tm:local-request] { Executed after the tm module sent a local generated, transaction stateful response. - Example 1.110. event_route[tm:local-response] usage + Example 1.111. event_route[tm:local-response] usage ... event_route[tm:local-response] { xlog("tm:local-response replied locally\n");

1 0

git:master:d4f3cacc: tm: docs for t_cell_append_branches(tindex, tlabel)
by Daniel-Constantin Mierla 02 Nov '24

02 Nov '24

Module: kamailio Branch: master Commit: d4f3caccbc2bd90d34fe083b208c25582aa5c3d3 URL: https://github.com/kamailio/kamailio/commit/d4f3caccbc2bd90d34fe083b208c255… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-02T23:20:03+01:00 tm: docs for t_cell_append_branches(tindex, tlabel) --- Modified: src/modules/tm/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/d4f3caccbc2bd90d34fe083b208c255… Patch: https://github.com/kamailio/kamailio/commit/d4f3caccbc2bd90d34fe083b208c255… --- diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml index 741505ec2d2..4cd7f36ba2d 100644 --- a/src/modules/tm/doc/functions.xml +++ b/src/modules/tm/doc/functions.xml @@ -1960,4 +1960,23 @@ reply_route { </example> </section> + <section id="tm.f.t_cell_append_branches"> + <title> + <function>t_cell_append_branches(tindex, tlabel)</function> + </title> + <para> + Append destination set branches to the transaction identified by + (tindex, tlabel). The parameters can also be variables. + </para> + <example> + <title><function>t_cell_append_branches</function> usage</title> + <programlisting> +... + append_branch("sip:1.2.3.4:5060"); + t_cell_append_branches("1234", "$var(tlabel)"); +... + </programlisting> + </example> + </section> + </section>

1 0

git:master:520be940: tm: new function t_cell_append_branches(tindex, tlabel)
by Daniel-Constantin Mierla 01 Nov '24

01 Nov '24

Module: kamailio Branch: master Commit: 520be940f8504fdaed281a8df20618e2f1f77783 URL: https://github.com/kamailio/kamailio/commit/520be940f8504fdaed281a8df20618e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-01T21:24:52+01:00 tm: new function t_cell_append_branches(tindex, tlabel) - append current branches to a specific transaction identified by index and label --- Modified: src/modules/tm/t_append_branches.c Modified: src/modules/tm/t_append_branches.h Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/520be940f8504fdaed281a8df20618e… Patch: https://github.com/kamailio/kamailio/commit/520be940f8504fdaed281a8df20618e… --- diff --git a/src/modules/tm/t_append_branches.c b/src/modules/tm/t_append_branches.c index 47e05809ae1..d871ba239fd 100644 --- a/src/modules/tm/t_append_branches.c +++ b/src/modules/tm/t_append_branches.c @@ -273,3 +273,51 @@ int t_append_branches(str *contact) } return ret; } + +/** + * + */ +int t_cell_append_branches(int tindex, int tlabel) +{ + tm_cell_t *t = NULL; + /* a pointer to an existing transaction or 0 if lookup fails */ + tm_cell_t *orig_t = NULL; + int ret; + int orig_branch; + str contact = STR_NULL; + + orig_t = get_t(); + orig_branch = get_t_branch(); + + /* lookup a transaction based on its identifier (hash_index:label) */ + if(t_lookup_ident(&t, tindex, tlabel) < 0) { + LM_ERR("transaction [%u:%u] not found\n", tindex, tlabel); + ret = -1; + goto done; + } + + /* check if the dialog is still in the early stage */ + if(t->flags & T_CANCELED) { + LM_DBG("transaction [%u:%u] was cancelled\n", tindex, tlabel); + ret = -2; + goto done; + } + + if(t->uas.status >= 200) { + LM_DBG("transaction [%u:%u] sent out a final response already - %d\n", + tindex, tlabel, t->uas.status); + ret = -3; + goto done; + } + + ret = t_append_branches(&contact); + +done: + /* unref the transaction which had been referred by t_lookup_ident() call. + * - restore the original transaction (if any) */ + if(t) + unref_cell(t); + set_t(orig_t, orig_branch); + + return ret; +} diff --git a/src/modules/tm/t_append_branches.h b/src/modules/tm/t_append_branches.h index 4e71f5862e2..1be1306efae 100644 --- a/src/modules/tm/t_append_branches.h +++ b/src/modules/tm/t_append_branches.h @@ -34,4 +34,6 @@ int t_append_branches(str *contact); typedef int (*t_append_branches_f)(str *contact); +int t_cell_append_branches(int tindex, int tlabel); + #endif diff --git a/src/modules/tm/tm.c b/src/modules/tm/tm.c index 0b099701587..7c7d26e2312 100644 --- a/src/modules/tm/tm.c +++ b/src/modules/tm/tm.c @@ -212,6 +212,7 @@ static int w_t_get_status_code(sip_msg_t *msg, char *p1, char *p2); static int t_clean(struct sip_msg *msg, char *key, char *value); static int w_t_exists(struct sip_msg *msg, char *p1, char *p2); +static int w_t_cell_append_branches(sip_msg_t *msg, char *pindex, char *plabel); /* by default the fr timers avps are not set, so that the avps won't be * searched for nothing each time a new transaction is created */ @@ -442,6 +443,8 @@ static cmd_export_t cmds[] = { {"t_next_contact_flow", t_next_contact_flow, 0, 0, 0, REQUEST_ROUTE}, {"t_clean", t_clean, 0, 0, 0, ANY_ROUTE}, {"t_exists", w_t_exists, 0, 0, 0, ANY_ROUTE}, + {"t_cell_append_branches", w_t_cell_append_branches, 2, fixup_igp_igp, + fixup_free_igp_igp, ANY_ROUTE}, /* not applicable from the script */ {"load_tm", (cmd_function)load_tm, NO_SCRIPT, 0, 0, 0}, @@ -3209,6 +3212,26 @@ static int w_t_exists(struct sip_msg *msg, char *p1, char *p2) return ki_t_exists(msg); } +static int w_t_cell_append_branches(sip_msg_t *msg, char *pindex, char *plabel) +{ + int tindex = 0; + int tlabel = 0; + int ret; + + if(fixup_get_ivalue(msg, (gparam_t *)pindex, &tindex) != 0) { + LM_ERR("invalid index parameter\n"); + return -1; + } + if(fixup_get_ivalue(msg, (gparam_t *)plabel, &tlabel) != 0) { + LM_ERR("invalid label parameter\n"); + return -1; + } + + ret = t_cell_append_branches(tindex, tlabel); + + return (ret == 0) ? 1 : ret; +} + #ifdef USE_DNS_FAILOVER /* parse reply codes for failover given in module parameter */ static int t_failover_parse_reply_codes()

1 0

[kamailio/kamailio] WolfSSL cipher_list (Issue #3920)
by quinnmancsym 01 Nov '24

01 Nov '24

Hi there, I am currently using the tls_wolfssl module with kamailio and was wondering why the ability to set a cipher list was disabled. From my own testing, uncommenting line 975 in tls_domain.c/ksr_tls_fix_domain adds the functionality and we haven't seen any issues with this so far. Was there an issue with this when the module was first created? Should I be avoiding using this functionality? Thanks very much. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3920 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3920(a)github.com>

5 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2024