sr-dev March 2024

sr-dev@lists.kamailio.org

14 participants
244 discussions

git:master:951ab118: ndb_redis: break on finding a server via sentinel inside redisc_reconnect_server()
by Daniel-Constantin Mierla 19 Mar '24

19 Mar '24

Module: kamailio Branch: master Commit: 951ab118bb7d9955f8e69b66bec1f0c107d474a2 URL: https://github.com/kamailio/kamailio/commit/951ab118bb7d9955f8e69b66bec1f0c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-03-19T17:39:19+01:00 ndb_redis: break on finding a server via sentinel inside redisc_reconnect_server() --- Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/… [View More]

1 0

git:master:c8f3b496: ndb_redis: fix index on parsing sentinel address inside redisc_reconnect_server()
by Daniel-Constantin Mierla 19 Mar '24

19 Mar '24

Module: kamailio Branch: master Commit: c8f3b496a05ae5bf29341dc7e2630f951d4effc5 URL: https://github.com/kamailio/kamailio/commit/c8f3b496a05ae5bf29341dc7e2630f9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-03-19T14:29:11+01:00 ndb_redis: fix index on parsing sentinel address inside redisc_reconnect_server() --- Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/… [View More]

1 0

git:master:e54051d6: ndb_redis: clang-format for WITH_SSL code
by Daniel-Constantin Mierla 19 Mar '24

19 Mar '24

Module: kamailio Branch: master Commit: e54051d698b059aa168229493dc2d6bf3cdd757c URL: https://github.com/kamailio/kamailio/commit/e54051d698b059aa168229493dc2d6b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-03-19T14:26:27+01:00 ndb_redis: clang-format for WITH_SSL code --- Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

[kamailio/kamailio] ERROR: acc [acc_extra.c:169]: parse_acc_extra() (Issue #3785)
by fulhade 19 Mar '24

19 Mar '24

This started happening with 5.8.0. I was to update our project with Docker image from 5.7.1 to 5.8.0 ``` kamailio[594]: ERROR: acc [acc_extra.c:169]: parse_acc_extra(): parse failed in <callid=$dlg(callid);src_user=$(dlg(from_uri){uri.user});dst_user=$(dlg(to_uri){uri.user});xxx_channel_id=$dlg_var(xxx_channel_id);t_error=$dlg_var(to_original_user);src_original_user=$dlg_var(from_original_user);dst_original_user=$dlg_var(to_original_user)id);src_user=$(dlg(from_uri){uri.user});dst_user=$(… [View More]

2 4

git:master:cee82c92: keepalive: small formatting updates and comments to the ka dest structure
by Daniel-Constantin Mierla 19 Mar '24

19 Mar '24

Module: kamailio Branch: master Commit: cee82c92b06a026b88fea654944f6146eb5cb4d8 URL: https://github.com/kamailio/kamailio/commit/cee82c92b06a026b88fea654944f614… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-03-19T10:21:51+01:00 keepalive: small formatting updates and comments to the ka dest structure --- Modified: src/modules/keepalive/keepalive.h --- Diff: https://github.com/kamailio/kamailio/… [View More]

1 0

git:master:9e2a0ee5: keepalive: proper storing of last up/down timestamps
by Daniel-Constantin Mierla 19 Mar '24

19 Mar '24

Module: kamailio Branch: master Commit: 9e2a0ee545646bd4491ecdbe58d7fea770764b54 URL: https://github.com/kamailio/kamailio/commit/9e2a0ee545646bd4491ecdbe58d7fea… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-03-19T09:51:28+01:00 keepalive: proper storing of last up/down timestamps - GH #3790 --- Modified: src/modules/keepalive/keepalive_core.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

[kamailio/kamailio] github: [skip ci]: bump tj-actions/changed-files from 42 to 43 (PR #3789)
by dependabot[bot] 18 Mar '24

18 Mar '24

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 42 to 43. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tj-actions/changed-files/releases">tj… releases</a>.</em></p> <blockquote> <h2>v43</h2> <h1>Changes in v43.0.0&… [View More]

2 1

git:master:9ae99b3d: github: [skip ci]: bump tj-actions/changed-files from 42 to 43
by Victor Seva 18 Mar '24

18 Mar '24

Module: kamailio Branch: master Commit: 9ae99b3dfc6eb538ea93d6775a283096fe17384c URL: https://github.com/kamailio/kamailio/commit/9ae99b3dfc6eb538ea93d6775a28309… Author: dependabot[bot] <49699333+dependabot[bot](a)users.noreply.github.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-03-18T22:47:14+01:00 github: [skip ci]: bump tj-actions/changed-files from 42 to 43 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 42 … [View More]

1 0

[kamailio/kamailio] Discrepancies in migration of commits from herlesupreeth/kamailio to upstream (Issue #3772)
by Axel Sommerfeldt 18 Mar '24

18 Mar '24

AFAIK the commits from Herle Supreeth from its fork https://github.com/herlesupreeth/kamailio were migrated manually (not via PR) to upstream at the end of last year. While reviewing the migration I have found two discrepancies: 1. https://github.com/kamailio/kamailio/commit/8b9a2977e111d9adb8595d98ab59f8c… vs. https://github.com/kamailio/kamailio/commit/a6a3bd088368fbf65c283ae27e999d3… ``` herlesupreeth/kamailio (fork) commit 8b9a2977e111d9adb8595d98ab59f8c8eb033120 Author: herlesupreeth &… [View More]lt;herlesupreeth(a)gmail.com> Date: Mon Jun 7 14:01:54 2021 +0200 IPSec fixes diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 8e0cabcb80..9de3cf7331 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -937,7 +939,14 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d) dst_port = s->port_us; } - int buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d", ci.via_host.len, ci.via_host.s, dst_port); + int buf_len = 0; + if (dst_proto == PROTO_TCP) { + buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d;transport=tcp", ci.via_host.len, ci.via_host.s, dst_port); + } else if (dst_proto == PROTO_TLS) { + buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d;transport=tls", ci.via_host.len, ci.via_host.s, dst_port); + } else { + buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d", ci.via_host.len, ci.via_host.s, dst_port); + } if((m->dst_uri.s = pkg_malloc(buf_len + 1)) == NULL) { LM_ERR("Error allocating memory for dst_uri\n"); ``` vs. ``` kamailio/kamailio (upstream) commit a6a3bd088368fbf65c283ae27e999d315db0844b Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jun 1 18:11:22 2022 +0200 ims_ipsec_pcscf: new option for ipsec_forward() to set trasport for tcp dst uri diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 5aa208d334..6f6c15e21b 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -947,8 +949,14 @@ int ipsec_forward(struct sip_msg *m, udomain_t *d, int _cflags) if(!(_cflags & IPSEC_NODSTURI_RESET)) { char buf[1024]; - int buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d", ci.via_host.len, - ci.via_host.s, dst_port); + int buf_len; + if((_cflags & IPSEC_SETDSTURI_FULL) && (dst_proto == PROTO_TCP)) { + buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d;transport=tcp", + ci.via_host.len, ci.via_host.s, dst_port); + } else { + buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d", ci.via_host.len, + ci.via_host.s, dst_port); + } if((m->dst_uri.s = pkg_malloc(buf_len + 1)) == NULL) { LM_ERR("Error allocating memory for dst_uri\n"); ``` To me it seems the handling of the case `dst_proto == PROTO_TLS` is missing upstream. 2. The commit https://github.com/kamailio/kamailio/commit/bfb0a17f3998d26991b4da7a8e83b8c… seems to be absent in upstream. (From my point of view all the other commits are migrated fine, thanks for the good work!) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3772 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3772(a)github.com> [View Less]

4 7

git:5.8:0af55b0e: pdb server: Return negative carrierid for failures. Clang format
by Stefan-Cristian Mititelu 18 Mar '24

18 Mar '24

Module: kamailio Branch: 5.8 Commit: 0af55b0eac8c3457db859a9c37fea211ece91b8a URL: https://github.com/kamailio/kamailio/commit/0af55b0eac8c3457db859a9c37fea21… Author: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro> Date: 2024-03-18T13:36:10+02:00 pdb server: Return negative carrierid for failures. Clang format (cherry-picked from commit 88b698e0f62c39ed60af9f0a4fb3ca2dc6867d8f) --- … [View More]

1 0

← Newer
1
...
11
12
13
14
15
16
17
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2024