sr-dev May 2024

sr-dev@lists.kamailio.org

15 participants
170 discussions

git:master:d72a3fbc: siputils: free head of params list for get_uri_param()
by Daniel-Constantin Mierla 29 May '24

29 May '24

Module: kamailio Branch: master Commit: d72a3fbc903da02ae3b26f3aae2ea228c9f8b255 URL: https://github.com/kamailio/kamailio/commit/d72a3fbc903da02ae3b26f3aae2ea22… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-05-29T10:15:21+02:00 siputils: free head of params list for get_uri_param() - GH #3857 --- Modified: src/modules/siputils/checks.c --- Diff: https://github.com/kamailio/kamailio/commit/d72a3fbc903da02ae3b26f3aae2ea22… Patch: https://github.com/kamailio/kamailio/commit/d72a3fbc903da02ae3b26f3aae2ea22… --- diff --git a/src/modules/siputils/checks.c b/src/modules/siputils/checks.c index 6cc977197fb..4e28aef8e8d 100644 --- a/src/modules/siputils/checks.c +++ b/src/modules/siputils/checks.c @@ -1165,6 +1165,7 @@ int get_uri_param(struct sip_msg *_msg, char *_param, char *_value) pv_value_t val; param_hooks_t hooks; + param_t *list = NULL; param_t *params; param = (str *)_param; @@ -1177,11 +1178,12 @@ int get_uri_param(struct sip_msg *_msg, char *_param, char *_value) t = _msg->parsed_uri.params; - if(parse_params(&t, CLASS_ANY, &hooks, &params) < 0) { + if(parse_params(&t, CLASS_ANY, &hooks, &list) < 0) { LM_ERR("ruri parameter parsing failed\n"); return -1; } + params = list; while(params) { if((params->name.len == param->len) && (strncmp(params->name.s, param->s, param->len) == 0)) { @@ -1196,11 +1198,11 @@ int get_uri_param(struct sip_msg *_msg, char *_param, char *_value) } } - free_params(params); + free_params(list); return -1; found: - free_params(params); + free_params(list); return 1; }

1 0

[kamailio/kamailio] Problem loadmodule secsipid on kamailio 5.6.5 (Issue #3860)
by sondesbough 29 May '24

29 May '24

failed to find command secsipid_build_identity (params 6) parse error in config file /etc/kamailio/kamailio.cfg, line 799, column 125: unknown command, missing loadmodule? parser: failed to find command secsipid_add_identity (params 6) May 24 11:26:36 vps-3471ad99 kamailio: CRITICAL: [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 802, column 125: unknown command, missing loadmodule?https://github.com/asipto/secsipidx/issues/12 May 24 11:26:36 vps-3471ad99 kamailio[70519]: ERROR: bad config file (2 errors) May 24 11:26:36 vps-3471ad99 kamailio: INFO: [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized May 24 11:26:36 vps-3471ad99 systemd[1]: kamailio.service: Control process exited, code=exited, status=255/EXCEPTION May 24 11:26:36 vps-3471ad99 systemd[1]: kamailio.service: Failed with result 'exit-code'. May 24 11:26:36 vps-3471ad99 systemd[1]: Failed to start Kamailio (OpenSER) - the Open Source SIP Server. May 24 11:26:36 vps-3471ad99 systemd[1]: kamailio.service: Scheduled restart job, restart counter is at 3. May 24 11:26:36 vps-3471ad99 systemd[1]: Stopped Kamailio (OpenSER) - the Open Source SIP Server. May 24 11:26:36 vps-3471ad99 systemd[1]: Starting Kamailio (OpenSER) - the Open Source SIP Server... May 24 11:26:36 vps-3471ad99 kamailio: ERROR: [core/cfg.y:3399]: yyparse(): cfg. parser: failed to find command secsipid_build_identity (params 6) May 24 11:26:36 vps-3471ad99 kamailio: CRITICAL: [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 799, column 125: unknown command, missing loadmodule?https://github.com/asipto/secsipidx/issues/12 May 24 11:26:36 vps-3471ad99 kamailio: ERROR: [core/cfg.y:3399]: yyparse(): cfg. parser: failed to find command secsipid_add_identity (params 6) May 24 11:26:36 vps-3471ad99 kamailio[70521]: ERROR: bad config file (2 errors) May 24 11:26:36 vps-3471ad99 kamailio: CRITICAL: [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 802, column 125: unknown command, missing loadmodule?https://github.com/asipto/secsipidx/issues/12 May 24 11:26:36 vps-3471ad99 kamailio: INFO: [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized May 24 11:26:36 vps-3471ad99 systemd[1]: kamailio.service: Control process exited, code=exited, status=255/EXCEPTION May 24 11:26:36 vps-3471ad99 systemd[1]: kamailio.service: Failed with result 'exit-code'. May 24 11:26:36 vps-3471ad99 systemd[1]: Failed to start Kamailio (OpenSER) - the Open Source SIP Server. May 24 11:26:37 vps-3471ad99 systemd[1]: kamailio.service: Scheduled restart job, restart counter is at 4. May 24 11:26:37 vps-3471ad99 systemd[1]: Stopped Kamailio (OpenSER) - the Open Source SIP Server. May 24 11:26:37 vps-3471ad99 systemd[1]: Starting Kamailio (OpenSER) - the Open Source SIP Server... May 24 11:26:37 vps-3471ad99 kamailio: ERROR: [core/cfg.y:3399]: yyparse(): cfg. parser: failed to find command secsipid_build_identity (params 6) May 24 11:26:37 vps-3471ad99 kamailio: CRITICAL: [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 799, column 125: unknown command, missing loadmodule?https://github.com/asipto/secsipidx/issues/12 May 24 11:26:37 vps-3471ad99 kamailio[70522]: ERROR: bad config file (2 errors) May 24 11:26:37 vps-3471ad99 kamailio: ERROR: [core/cfg.y:3399]: yyparse(): cfg. parser: failed to find command secsipid_add_identity (params 6) May 24 11:26:37 vps-3471ad99 kamailio: CRITICAL: [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 802, column 125: unknown command, missing loadmodule?https://github.com/asipto/secsipidx/issues/12 May 24 11:26:37 vps-3471ad99 kamailio: INFO: [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized May 24 11:26:37 vps-3471ad99 systemd[1]: kamailio.service: Control process exited, code=exited, status=255/EXCEPTION May 24 11:26:37 vps-3471ad99 systemd[1]: kamailio.service: Failed with result 'exit-code'. May 24 11:26:37 vps-3471ad99 systemd[1]: Failed to start Kamailio (OpenSER) - the Open Source SIP Server. May 24 11:26:37 vps-3471ad99 systemd[1]: kamailio.service: Scheduled restart job, restart counter is at 5. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3860 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3860(a)github.com>

2 3

[kamailio/kamailio] dispatcher not proxy sip on websocket (Issue #3864)
by liaoxingang 29 May '24

29 May '24

I want to proxy a sip server on websocket. but it's not working. I set dispatcher destination "sip:10.100.67.95:5066;transport=ws", it has some error . logs: 2024-05-29T02:49:15.436088156Z 11(22) WARNING: <core> [core/msg_translator.c:3007]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found 2024-05-29T02:49:15.436124584Z 11(22) ERROR: tm [t_msgbuilder.c:1420]: assemble_via(): via building failed 2024-05-29T02:49:15.436132262Z 11(22) ERROR: tm [t_msgbuilder.c:1611]: build_uac_req(): error while assembling Via 2024-05-29T02:49:15.436138638Z 11(22) ERROR: tm [uac.c:552]: t_uac_prepare(): Error while building message 2024-05-29T02:49:15.436145000Z 11(22) ERROR: dispatcher [dispatch.c:3981]: ds_ping_set(): unable to ping [sip:10.100.67.95:5066;transport=ws] in group [3] -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3864 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3864(a)github.com>

2 2

[kamailio/kamailio] rtpengine: Fix extra process in pkg.stats (PR #3862)
by Bastian Triller 28 May '24

28 May '24

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  When DTMF events socket is not configured, pkg.stats RPC method returns an empty entry. { entry: 13 pid: 0 rank: -128 used: 0 free: 0 real_used: 0 total_size: 67108864 total_frags: 0 desc: } Fixes: 26f6e57c8f ("Register a new worker process for dtmf event listener") You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3862 -- Commit Summary -- * rtpengine: Fix extra process in pkg.stats -- File Changes -- M src/modules/rtpengine/rtpengine.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3862.patch https://github.com/kamailio/kamailio/pull/3862.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3862 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3862(a)github.com>

2 1

git:master:e67f6048: rtpengine: Fix extra process in pkg.stats
by Victor Seva 28 May '24

28 May '24

Module: kamailio Branch: master Commit: e67f6048f4883d446df2d88fe7a7d7f2ff6daf8c URL: https://github.com/kamailio/kamailio/commit/e67f6048f4883d446df2d88fe7a7d7f… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-05-28T19:55:35+02:00 rtpengine: Fix extra process in pkg.stats When DTMF events socket is not configured, pkg.stats RPC method returns an empty entry. { entry: 13 pid: 0 rank: -128 used: 0 free: 0 real_used: 0 total_size: 67108864 total_frags: 0 desc: } Fixes: 26f6e57c8f ("Register a new worker process for dtmf event listener") --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/e67f6048f4883d446df2d88fe7a7d7f… Patch: https://github.com/kamailio/kamailio/commit/e67f6048f4883d446df2d88fe7a7d7f… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 6d62b92900d..c26f61e2483 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -2234,8 +2234,10 @@ static int mod_init(void) } } - register_procs(1); - cfg_register_child(1); + if(rtpengine_dtmf_event_sock.len > 0) { + register_procs(1); + cfg_register_child(1); + } } return 0;

1 0

git:master:24b27214: htable: error on not finding htable in pv get
by Daniel-Constantin Mierla 28 May '24

28 May '24

Module: kamailio Branch: master Commit: 24b27214231166366cceb88fcb3724298cc53b32 URL: https://github.com/kamailio/kamailio/commit/24b27214231166366cceb88fcb37242… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-05-28T11:45:37+02:00 htable: error on not finding htable in pv get --- Modified: src/modules/htable/ht_var.c --- Diff: https://github.com/kamailio/kamailio/commit/24b27214231166366cceb88fcb37242… Patch: https://github.com/kamailio/kamailio/commit/24b27214231166366cceb88fcb37242… --- diff --git a/src/modules/htable/ht_var.c b/src/modules/htable/ht_var.c index 9770e51fd19..e79c7869ee5 100644 --- a/src/modules/htable/ht_var.c +++ b/src/modules/htable/ht_var.c @@ -37,8 +37,11 @@ int pv_get_ht_cell(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) if(hpv->ht == NULL) { hpv->ht = ht_get_table(&hpv->htname); - if(hpv->ht == NULL) + if(hpv->ht == NULL) { + LM_ERR("htable not found for getting $sht(%.*s=>%.*s)\n", + hpv->htname.len, hpv->htname.s, htname.len, htname.s); return pv_get_null(msg, param, res); + } } if(pv_printf_s(msg, hpv->pve, &htname) != 0) { LM_ERR("cannot get $sht name\n");

1 0

git:master:6a8eb982: modules: readme files regenerated - permissions ... [skip ci]
by Kamailio Dev 27 May '24

27 May '24

Module: kamailio Branch: master Commit: 6a8eb982be8d8f0c731dd423827480a1a27c2d8f URL: https://github.com/kamailio/kamailio/commit/6a8eb982be8d8f0c731dd423827480a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-05-27T15:31:11+02:00 modules: readme files regenerated - permissions ... [skip ci] --- Modified: src/modules/permissions/README --- Diff: https://github.com/kamailio/kamailio/commit/6a8eb982be8d8f0c731dd423827480a… Patch: https://github.com/kamailio/kamailio/commit/6a8eb982be8d8f0c731dd423827480a…

1 0

[kamailio/kamailio] permissions: introduce func `allow_register_include_port()` (PR #3846)
by Donat Zenichev 27 May '24

27 May '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Introduce new function: `allow_register_include_port()` to be able to check the whole Contact header including port. Example, register.deny content is: ``` ALL : "^sip:.*192.168.0.101:5062" ``` If the Contact is: "Contact: <sip:testuser1004@192.168.0.101:5062>" then this will check the Contact hf including port of it. Otherwise if usual `allow_register()` function is used, then only the "testuser1004(a)192.168.0.101" will be taken into account, which will lead the regex to be failing and letting the check to pass through. The func `allow_register_include_port()` works similarly as `allow_register()` except it checks Contact's port. A separate function was created in order to not complicate things by introducing one more parameter to the existing function `allow_register()`, which already takes a variable amount of parameters, so 1 or 2 parameters (depending on if it is a "basename" or "allow-file, deny-file"). Documentation updated accordingly. Additionally, "Register File Format" section has been added to the doc (to provide allow/deny file examples). Full backwards compatibility is kept in place, no need for users of the module to change anything in their configuration or kamailio script itself. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3846 -- Commit Summary -- * permissions: introduce func `allow_register_include_port()` -- File Changes -- M src/modules/permissions/doc/permissions.xml (7) M src/modules/permissions/doc/permissions_admin.xml (142) M src/modules/permissions/permissions.c (56) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3846.patch https://github.com/kamailio/kamailio/pull/3846.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3846 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3846(a)github.com>

2 3

git:master:534a3595: permissions: introduce func `allow_register_include_port()`
by Victor Seva 27 May '24

27 May '24

Module: kamailio Branch: master Commit: 534a35956b1a79598dcd2436248c5d7ce4e92da8 URL: https://github.com/kamailio/kamailio/commit/534a35956b1a79598dcd2436248c5d7… Author: Donat Zenichev <dzenichev(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-05-27T15:21:24+02:00 permissions: introduce func `allow_register_include_port()` Introduce new function: `allow_register_include_port()` to be able to check the whole Contact header including port. Example, register.deny content is: ALL : "^sip:.*192.168.0.101:5062" If the Contact is: "Contact: <sip:testuser1004@192.168.0.101:5062>" then this will check the Contact hf including port of it. Otherwise if usual `allow_register()` function is used, then only the "testuser1004(a)192.168.0.101" will be taken into account, which will lead the regex to be failing and letting the check to pass through. The func `allow_register_include_port()` works similarly as `allow_register()` except it checks Contact's port. Full backwards compatibility is kept in place, no need for users of the module to change anything in their configuration or kamailio script itself. --- Modified: src/modules/permissions/doc/permissions.xml Modified: src/modules/permissions/doc/permissions_admin.xml Modified: src/modules/permissions/permissions.c --- Diff: https://github.com/kamailio/kamailio/commit/534a35956b1a79598dcd2436248c5d7… Patch: https://github.com/kamailio/kamailio/commit/534a35956b1a79598dcd2436248c5d7…

1 0

Re: [kamailio/kamailio] core: dns cache - warn messages on safety checks for items (d8a35b3)
by Alex Hermann 27 May '24

27 May '24

Care to explain why this is wrong? Some DNS records that are fully in spec and have functioned for years without any problem now trigger filling the logs with these warnings. Also, actually logging which record(s) are causing the issue and what would be needed to be done to fix them would be helpful, the hex address and message doesn't provide any useful info for the admin. ``` 2024-05-27T10:01:04.263247+02:00 pc1 proxy1[335503]: WARNING: <core> [core/dns_cache.c:1700]: dns_get_related(): record not alone: 0x7f714ee28250 - type: 33 2024-05-27T10:01:04.269368+02:00 pc1 proxy1[335503]: WARNING: <core> [core/dns_cache.c:1700]: dns_get_related(): record not alone: 0x7f714ee28380 - type: 1 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/d8a35b3b6c837b36779e232b65fce61… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/d8a35b3b6c837b36779e232b65fce61c3aa93387/142421279(a)github.com>

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
17
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2024