sr-dev May 2024

sr-dev@lists.kamailio.org

15 participants
166 discussions

git:master:e67f6048: rtpengine: Fix extra process in pkg.stats

by Victor Seva

Module: kamailio Branch: master Commit: e67f6048f4883d446df2d88fe7a7d7f2ff6daf8c URL: https://github.com/kamailio/kamailio/commit/e67f6048f4883d446df2d88fe7a7d7f… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-05-28T19:55:35+02:00 rtpengine: Fix extra process in pkg.stats When DTMF events socket is not configured, pkg.stats RPC method returns an empty entry. { entry: 13 pid: 0 rank: -128 used: 0 free: 0 real_used: 0 total_size: 67108864 total_frags: 0 desc: } Fixes: 26f6e57c8f ("Register a new worker process for dtmf event listener") --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/e67f6048f4883d446df2d88fe7a7d7f… Patch: https://github.com/kamailio/kamailio/commit/e67f6048f4883d446df2d88fe7a7d7f… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 6d62b92900d..c26f61e2483 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -2234,8 +2234,10 @@ static int mod_init(void) } } - register_procs(1); - cfg_register_child(1); + if(rtpengine_dtmf_event_sock.len > 0) { + register_procs(1); + cfg_register_child(1); + } } return 0;

6 months

git:master:24b27214: htable: error on not finding htable in pv get

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 24b27214231166366cceb88fcb3724298cc53b32 URL: https://github.com/kamailio/kamailio/commit/24b27214231166366cceb88fcb37242… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-05-28T11:45:37+02:00 htable: error on not finding htable in pv get --- Modified: src/modules/htable/ht_var.c --- Diff: https://github.com/kamailio/kamailio/commit/24b27214231166366cceb88fcb37242… Patch: https://github.com/kamailio/kamailio/commit/24b27214231166366cceb88fcb37242… --- diff --git a/src/modules/htable/ht_var.c b/src/modules/htable/ht_var.c index 9770e51fd19..e79c7869ee5 100644 --- a/src/modules/htable/ht_var.c +++ b/src/modules/htable/ht_var.c @@ -37,8 +37,11 @@ int pv_get_ht_cell(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) if(hpv->ht == NULL) { hpv->ht = ht_get_table(&hpv->htname); - if(hpv->ht == NULL) + if(hpv->ht == NULL) { + LM_ERR("htable not found for getting $sht(%.*s=>%.*s)\n", + hpv->htname.len, hpv->htname.s, htname.len, htname.s); return pv_get_null(msg, param, res); + } } if(pv_printf_s(msg, hpv->pve, &htname) != 0) { LM_ERR("cannot get $sht name\n");

6 months

git:master:6a8eb982: modules: readme files regenerated - permissions ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 6a8eb982be8d8f0c731dd423827480a1a27c2d8f URL: https://github.com/kamailio/kamailio/commit/6a8eb982be8d8f0c731dd423827480a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-05-27T15:31:11+02:00 modules: readme files regenerated - permissions ... [skip ci] --- Modified: src/modules/permissions/README --- Diff: https://github.com/kamailio/kamailio/commit/6a8eb982be8d8f0c731dd423827480a… Patch: https://github.com/kamailio/kamailio/commit/6a8eb982be8d8f0c731dd423827480a…

6 months

[kamailio/kamailio] permissions: introduce func `allow_register_include_port()` (PR #3846)

by Donat Zenichev

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Introduce new function: `allow_register_include_port()` to be able to check the whole Contact header including port. Example, register.deny content is: ``` ALL : "^sip:.*192.168.0.101:5062" ``` If the Contact is: "Contact: <sip:testuser1004@192.168.0.101:5062>" then this will check the Contact hf including port of it. Otherwise if usual `allow_register()` function is used, then only the "testuser1004(a)192.168.0.101" will be taken into account, which will lead the regex to be failing and letting the check to pass through. The func `allow_register_include_port()` works similarly as `allow_register()` except it checks Contact's port. A separate function was created in order to not complicate things by introducing one more parameter to the existing function `allow_register()`, which already takes a variable amount of parameters, so 1 or 2 parameters (depending on if it is a "basename" or "allow-file, deny-file"). Documentation updated accordingly. Additionally, "Register File Format" section has been added to the doc (to provide allow/deny file examples). Full backwards compatibility is kept in place, no need for users of the module to change anything in their configuration or kamailio script itself. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3846 -- Commit Summary -- * permissions: introduce func `allow_register_include_port()` -- File Changes -- M src/modules/permissions/doc/permissions.xml (7) M src/modules/permissions/doc/permissions_admin.xml (142) M src/modules/permissions/permissions.c (56) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3846.patch https://github.com/kamailio/kamailio/pull/3846.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3846 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3846(a)github.com>

6 months

git:master:534a3595: permissions: introduce func `allow_register_include_port()`

by Victor Seva

Module: kamailio Branch: master Commit: 534a35956b1a79598dcd2436248c5d7ce4e92da8 URL: https://github.com/kamailio/kamailio/commit/534a35956b1a79598dcd2436248c5d7… Author: Donat Zenichev <dzenichev(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-05-27T15:21:24+02:00 permissions: introduce func `allow_register_include_port()` Introduce new function: `allow_register_include_port()` to be able to check the whole Contact header including port. Example, register.deny content is: ALL : "^sip:.*192.168.0.101:5062" If the Contact is: "Contact: <sip:testuser1004@192.168.0.101:5062>" then this will check the Contact hf including port of it. Otherwise if usual `allow_register()` function is used, then only the "testuser1004(a)192.168.0.101" will be taken into account, which will lead the regex to be failing and letting the check to pass through. The func `allow_register_include_port()` works similarly as `allow_register()` except it checks Contact's port. Full backwards compatibility is kept in place, no need for users of the module to change anything in their configuration or kamailio script itself. --- Modified: src/modules/permissions/doc/permissions.xml Modified: src/modules/permissions/doc/permissions_admin.xml Modified: src/modules/permissions/permissions.c --- Diff: https://github.com/kamailio/kamailio/commit/534a35956b1a79598dcd2436248c5d7… Patch: https://github.com/kamailio/kamailio/commit/534a35956b1a79598dcd2436248c5d7…

6 months

Re: [kamailio/kamailio] core: dns cache - warn messages on safety checks for items (d8a35b3)

by Alex Hermann

Care to explain why this is wrong? Some DNS records that are fully in spec and have functioned for years without any problem now trigger filling the logs with these warnings. Also, actually logging which record(s) are causing the issue and what would be needed to be done to fix them would be helpful, the hex address and message doesn't provide any useful info for the admin. ``` 2024-05-27T10:01:04.263247+02:00 pc1 proxy1[335503]: WARNING: <core> [core/dns_cache.c:1700]: dns_get_related(): record not alone: 0x7f714ee28250 - type: 33 2024-05-27T10:01:04.269368+02:00 pc1 proxy1[335503]: WARNING: <core> [core/dns_cache.c:1700]: dns_get_related(): record not alone: 0x7f714ee28380 - type: 1 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/d8a35b3b6c837b36779e232b65fce61… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/d8a35b3b6c837b36779e232b65fce61c3aa93387/142421279(a)github.com>

6 months

git:master:82cfea31: htable: error on not finding htable in pv set

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 82cfea317fd8d02a6c94347bc1be18c8a06e580f URL: https://github.com/kamailio/kamailio/commit/82cfea317fd8d02a6c94347bc1be18c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-05-27T09:11:48+02:00 htable: error on not finding htable in pv set --- Modified: src/modules/htable/ht_var.c --- Diff: https://github.com/kamailio/kamailio/commit/82cfea317fd8d02a6c94347bc1be18c… Patch: https://github.com/kamailio/kamailio/commit/82cfea317fd8d02a6c94347bc1be18c… --- diff --git a/src/modules/htable/ht_var.c b/src/modules/htable/ht_var.c index fc37234f5ba..9770e51fd19 100644 --- a/src/modules/htable/ht_var.c +++ b/src/modules/htable/ht_var.c @@ -73,8 +73,11 @@ int pv_set_ht_cell( if(hpv->ht == NULL) hpv->ht = ht_get_table(&hpv->htname); - if(hpv->ht == NULL) + if(hpv->ht == NULL) { + LM_ERR("htable not found for setting $sht(%.*s=>%.*s)\n", + hpv->htname.len, hpv->htname.s, htname.len, htname.s); return -1; + } if(pv_printf_s(msg, hpv->pve, &htname) != 0) { LM_ERR("cannot get $sht name\n");

6 months

[kamailio/kamailio] PKG Memory Leak with RTPEngine Module with WebSocket (Issue #3777)

by vijaykumar-exotel

### Description  ### Troubleshooting - as checked further we particulartly tcp reciever process was consuming pkg memory , then further we checked from corex pkg_sumary for that process id, and found that rtpengine: rtpengine.c: send_rtpp_command was consuming highest memory. #### Reproduction console rtpengine url with ws endpoint.  this is reproducible, we can configure websocket in rtpengine module and then we can initate calls. and increase the number of calls over the period of time #### Debugging Data <img width="1399" alt="Screenshot 2024-03-06 at 4 30 16 PM" src="https://github.com/kamailio/kamailio/assets/115363081/0904892e-6a6e-4dc1-85…"> kamcmd pkg.stats entry: 24 pid: 378355 rank: 17 used: 7467640 free: 24348320 real_used: 9206112 total_size: 33554432 total_frags: 66 desc: tcp receiver (generic) child=0 kamcmd corex.pkg_summary pid 378355 Mar 6 16:31:52 coreproxy-4 /usr/local/sbin/kamailio[378355]: ALERT: qm_sums: qm_sums(): count= 8075 size= 4638760 bytes from rtpengine: rtpengine.c: send_rtpp_command(3040) ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) version: kamailio 5.7.0 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 01:04:28 Jan 25 2024 with gcc 9.4.0 ``` * **Operating System**:  ``` No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.6 LTS Release: 20.04 Codename: focal Linux coreproxy-4 5.15.0-1045-oracle #51~20.04.1-Ubuntu SMP Fri Sep 22 14:25:26 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3777 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3777(a)github.com>

6 months

git:5.8:c1c8c066: db_cluster: Update log levels

by Xenofon Karamanos

Module: kamailio Branch: 5.8 Commit: c1c8c066b29798189a50dd9b4f27c5af574d991d URL: https://github.com/kamailio/kamailio/commit/c1c8c066b29798189a50dd9b4f27c5a… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-05-24T14:24:48Z db_cluster: Update log levels (cherry picked from commit 467dbf3e1be16d5a760178d0801834ac67bad888) --- Modified: src/modules/db_cluster/dbcl_api.c --- Diff: https://github.com/kamailio/kamailio/commit/c1c8c066b29798189a50dd9b4f27c5a… Patch: https://github.com/kamailio/kamailio/commit/c1c8c066b29798189a50dd9b4f27c5a…

6 months

git:5.7:afa4e92b: db_cluster: Update log levels

by Xenofon Karamanos

Module: kamailio Branch: 5.7 Commit: afa4e92bbdc30bc76f0a27f73ef8c57802be99bf URL: https://github.com/kamailio/kamailio/commit/afa4e92bbdc30bc76f0a27f73ef8c57… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-05-24T14:18:35Z db_cluster: Update log levels (cherry picked from commit 467dbf3e1be16d5a760178d0801834ac67bad888) --- Modified: src/modules/db_cluster/dbcl_api.c --- Diff: https://github.com/kamailio/kamailio/commit/afa4e92bbdc30bc76f0a27f73ef8c57… Patch: https://github.com/kamailio/kamailio/commit/afa4e92bbdc30bc76f0a27f73ef8c57…

6 months

← Newer
1
...
4
5
6
7
8
9
10
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2024