### Description
Carrierroute's CRC32 algorithm over call_id tends to produce poor call distribution under real world examples. Having 4 records for a given carrier/domain combo (assuming no flags, mask, or scan_prefix) and a probability of `0.25` using a hash source of `call_id` I observed over 800 hundred consecutive calls from a carrier (bandwidth.com) where `CRC32(call_id) % 1000` was less than 250.
To be fair, the module does what it says - it uses a CRC32 hash over the call id, however the data from the UA generating the call is yielding poor results. Would it be possible to change to an alternate hashing mechanism (or add another hashing mechanism, selectable via `modparam`) such as MD5?
### Expected behavior
Even distribution across all hosts provided.
#### Actual observed behavior
Uneven distribution under real-world conditions.
#### Debugging Data
I can provide a list of > 800 call-ids observed that all routed to the same endpoint. These are pulled from real world calls, and while there's not much danger in just having call-id's I would still prefer not to post it into github for posterity.
#### Log Messages
Log messages end up looking similar to this. I validated that the number is the CRC32 hash of the call id, so it's not a bug in the module.
```
proxy-1 | 1(7) DEBUG: carrierroute [cr_func.c:449]: rewrite_on_rule(): searching for matching routing rules 1(7) DEBUG: carrierroute [prime_hash.c:66]: hash_func(): hash: 2417021133 % 1000 = 133
proxy-1 | 1(7) INFO: carrierroute [cr_func.c:689]: ki_cr_do_route_helper(): uri service was rewritten to sip:service@host-d, carrier 1, domain 1
```
### Possible Solutions
Ability to use MD5, kamailio's core hash function or other such hashing function
### Additional Information
Problem validate in 5.7.3, but since it's *correct* by module design, it shouldn't have changed in 5.8
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3786
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3786(a)github.com>
Module: kamailio
Branch: master
Commit: 637c5ce2a9f2a9f82937f9102545f896a5a8abed
URL: https://github.com/kamailio/kamailio/commit/637c5ce2a9f2a9f82937f9102545f89…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-06-07T19:46:11+02:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
Modified: src/modules/ims_ipsec_pcscf/README
---
Diff: https://github.com/kamailio/kamailio/commit/637c5ce2a9f2a9f82937f9102545f89…
Patch: https://github.com/kamailio/kamailio/commit/637c5ce2a9f2a9f82937f9102545f89…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index c915f552809..c095bc201be 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -1644,7 +1644,7 @@ onreply_route {
* setid - the set (group) id. The parameter can be an integer or a
variable holding an integer value.
* uri - the URI of the destination.
- * val - the valie of the overload control rate (from 1 to 100) - how
+ * val - the value of the overload control rate (from 1 to 100) - how
many times to skip using this destination in 100 selections.
This function can be used from ANY_ROUTE.
diff --git a/src/modules/ims_ipsec_pcscf/README b/src/modules/ims_ipsec_pcscf/README
index bce99b791da..3d831eb2c47 100644
--- a/src/modules/ims_ipsec_pcscf/README
+++ b/src/modules/ims_ipsec_pcscf/README
@@ -361,7 +361,7 @@ ipsec_destroy("location");
recv_host - received host to match the record.
recv_port - received port to match the record.
- The last three parameters have to be string valies and can contain
+ The last three parameters have to be string values and can contain
variables.
Example 1.14. ipsec_destroy_by_contact()
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Fix two small typos
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3870
-- Commit Summary --
* dispatcher: Fix typo
* ims_ipsec_pcscf: Fix typo
-- File Changes --
M src/modules/dispatcher/doc/dispatcher_admin.xml (2)
M src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3870.patchhttps://github.com/kamailio/kamailio/pull/3870.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3870
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3870(a)github.com>
Module: kamailio
Branch: master
Commit: 16e1b38fcc1593ad09eb03d86cd056ab8ff7f7f7
URL: https://github.com/kamailio/kamailio/commit/16e1b38fcc1593ad09eb03d86cd056a…
Author: Bastian Triller <bastian.triller(a)gmail.com>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-06-07T19:37:57+02:00
ims_ipsec_pcscf: Fix typo
---
Modified: src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/16e1b38fcc1593ad09eb03d86cd056a…
Patch: https://github.com/kamailio/kamailio/commit/16e1b38fcc1593ad09eb03d86cd056a…
---
diff --git a/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml b/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
index ee58f16fb63..f4a388ee777 100644
--- a/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
+++ b/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
@@ -405,7 +405,7 @@ ipsec_destroy("location");
</para>
</listitem>
</itemizedlist>
- <para>The last three parameters have to be string valies and can contain
+ <para>The last three parameters have to be string values and can contain
variables.</para>
<example>
<title>ipsec_destroy_by_contact()</title>
Module: kamailio
Branch: master
Commit: e10a629a7737c12cc58a8abebf1fe67ed1f30ab9
URL: https://github.com/kamailio/kamailio/commit/e10a629a7737c12cc58a8abebf1fe67…
Author: Bastian Triller <bastian.triller(a)gmail.com>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-06-07T19:37:57+02:00
dispatcher: Fix typo
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/e10a629a7737c12cc58a8abebf1fe67…
Patch: https://github.com/kamailio/kamailio/commit/e10a629a7737c12cc58a8abebf1fe67…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index cdd1ebc896e..e0e8d1beed8 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -2032,7 +2032,7 @@ onreply_route {
<para><emphasis>uri</emphasis> - the URI of the destination.</para>
</listitem>
<listitem>
- <para><emphasis>val</emphasis> - the valie of the overload control
+ <para><emphasis>val</emphasis> - the value of the overload control
rate (from 1 to 100) - how many times to skip using this destination
in 100 selections.</para>
</listitem>
Module: kamailio
Branch: master
Commit: a366c9a30f953571f89f539e87448ff0c5ac8585
URL: https://github.com/kamailio/kamailio/commit/a366c9a30f953571f89f539e87448ff…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-06-07T12:31:09+02:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/a366c9a30f953571f89f539e87448ff…
Patch: https://github.com/kamailio/kamailio/commit/a366c9a30f953571f89f539e87448ff…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index 209d77f4c87..c915f552809 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -122,6 +122,7 @@ Federico Cabiddu
4.14. ds_load_unset()
4.15. ds_reload()
4.16. ds_dsg_fetch(setid)
+ 4.17. ds_oc_set_rate(setid, uri, val)
5. RPC Commands
@@ -211,8 +212,9 @@ Federico Cabiddu
1.57. ds_load_unset usage
1.58. ds_reload usage
1.59. ds_dsg_fetch() usage
- 1.60. dispatcher list file
- 1.61. Kamailio config script - sample dispatcher usage
+ 1.60. ds_oc_set_rate() usage
+ 1.61. dispatcher list file
+ 1.62. Kamailio config script - sample dispatcher usage
Chapter 1. Admin Guide
@@ -289,6 +291,7 @@ Chapter 1. Admin Guide
4.14. ds_load_unset()
4.15. ds_reload()
4.16. ds_dsg_fetch(setid)
+ 4.17. ds_oc_set_rate(setid, uri, val)
5. RPC Commands
@@ -1115,6 +1118,7 @@ modparam("dispatcher", "ds_interval_mode", 7200)
4.14. ds_load_unset()
4.15. ds_reload()
4.16. ds_dsg_fetch(setid)
+ 4.17. ds_oc_set_rate(setid, uri, val)
4.1. ds_select_dst(set, alg[, limit])
@@ -1227,6 +1231,9 @@ GATEWAY | PRIORITY | ESTIMATED | ADJUSTED | LOAD
With congestion control the formula becomes :
CONGESTION_MS = CURRENT_LATENCY_MS - NORMAL_CONDITION_LATENCY_MS
ADJUSTED_PRIORITY = PRIORITY - (CONGESTION_MS/PRIORITY)
+ + ���64��� - round-robin (next destination) with over load control
+ (destination record is skipped based on over load control
+ rate).
+ ���X��� - if the algorithm is not implemented, the first entry in
set is chosen.
* limit - the maximum number of items to be stored in XAVP list for
@@ -1629,6 +1636,24 @@ onreply_route {
xinfo("set id: 1 - all: $dsg(count); active: $dsg(active)\n");
...
+4.17. ds_oc_set_rate(setid, uri, val)
+
+ Sets the overload control rate for the destination (setid, uri).
+
+ Description of parameters:
+ * setid - the set (group) id. The parameter can be an integer or a
+ variable holding an integer value.
+ * uri - the URI of the destination.
+ * val - the valie of the overload control rate (from 1 to 100) - how
+ many times to skip using this destination in 100 selections.
+
+ This function can be used from ANY_ROUTE.
+
+ Example 1.60. ds_oc_set_rate() usage
+...
+ ds_oc_set_rate("1", "sip:127.0.0.1:5080", "30");
+...
+
5. RPC Commands
5.1. dispatcher.set_state
@@ -1890,6 +1915,10 @@ kamctl rpc dispatcher.hash 4 bob server.com
* 'obproxy' - SIP URI of outbound proxy to be used when sending
pings. It overwrites the general ds_outbound_proxy parameter.
* 'latency' - latency_stats initialization in ms.
+ * 'ocmin' - minimum limit for over load control rate (value between 0
+ and 100, default 10).
+ * 'ocrate' - over load control rate (value between 0 and 100, default
+ 100).
6.1.2. File Format
@@ -1907,7 +1936,7 @@ setid(int) destination(sip uri) flags(int,opt) priority(int,opt) attrs(str,opt)
For database, each element of a line resides in a different column.
Next is a dispatcher.list file example:
- Example 1.60. dispatcher list file
+ Example 1.61. dispatcher list file
...
#
# dispatcher destination sets (groups)
@@ -1932,7 +1961,7 @@ r,opt)
Next listing shows a sample config for using the dispatcher module.
- Example 1.61. Kamailio config script - sample dispatcher usage
+ Example 1.62. Kamailio config script - sample dispatcher usage
...
#!KAMAILIO
#