sr-dev July 2024

sr-dev@lists.kamailio.org

16 participants
210 discussions

git:master:f2a7a3c0: dispatcher: remove unnecessary comparisons for unsigned

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f2a7a3c09ee881247c8a6641ec8d3b1e0e0eb812 URL: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-14T18:56:20+02:00 dispatcher: remove unnecessary comparisons for unsigned --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… Patch: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index ecd0f3a0c9d..d36141bbafd 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -408,13 +408,13 @@ int ds_set_attrs(ds_dest_t *dest, str *vattrs) str2int(&pit->body, &dest->attrs.ocrate); } } - if(dest->attrs.ocmax < 0 || dest->attrs.ocmax > 100) { + if(dest->attrs.ocmax > 100) { dest->attrs.ocmax = 100; } - if(dest->attrs.ocmin < 0 || dest->attrs.ocmin > 100) { + if(dest->attrs.ocmin > 100) { dest->attrs.ocmin = 0; } - if(dest->attrs.ocrate <= 0 || dest->attrs.ocrate > 100) { + if(dest->attrs.ocrate > 100) { dest->attrs.ocrate = 0; } if(dest->attrs.ocrate < dest->attrs.ocmin) {

4 months, 2 weeks

[kamailio/kamailio] cdp: improved routing and removed useless warning/errors in authstatemachine (PR #3914)

by Dragos Vingarzan

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Diameter requests could contain Application-Ids in multiple AVPs. This fix iterates through them, instead of giving up if the first one does not match. This solves some issues when peers don't always declare support for vendor-specific/non-specific application ids, so routing should be easier. Also fixed: - auth state machine being too verbose on regular messages being received or sent while in the Open state - add Destination-Host from auth state to requests (next-hop immediate routing) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3914 -- Commit Summary -- * cdp: improved routing and removed useless warning/errors in authstatemachine -- File Changes -- M src/modules/cdp/authstatemachine.c (42) M src/modules/cdp/routing.c (176) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3914.patch https://github.com/kamailio/kamailio/pull/3914.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3914 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3914(a)github.com>

4 months, 2 weeks

git:master:0da3eb3f: cdp: improved routing and removed useless warning/errors in authstatemachine

by Dragos Vingarzan

Module: kamailio Branch: master Commit: 0da3eb3f94c087b272ebbe19c42fd933146482f8 URL: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-14T11:46:17+02:00 cdp: improved routing and removed useless warning/errors in authstatemachine --- Modified: src/modules/cdp/authstatemachine.c Modified: src/modules/cdp/routing.c --- Diff: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93… Patch: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93…

4 months, 2 weeks

[kamailio/kamailio] Outdated OpenSIPS Sources in Kamailio Project Lack Security Fixes (CVE-2023-28098) (Issue #3911)

by Garnik Khroyan

### Description The master branch of the Kamailio project contains unpatched sources from OpenSIPS, in which [CVE-2023-28098](https://github.com/OpenSIPS/opensips/security/advisories/GH… was reported. The function `parse_param_name()` from `kamailio/src/core/parser/digest/param_parser.c` does not include security patches and updates available in newer versions of OpenSIPS. The fix for CVE can be found in this commit: [OpenSIPS Commit dd9141b6](https://github.com/OpenSIPS/opensips/commit/dd9141b6f67d7df4072f3… ### Possible Solutions I strongly recommend updating the sources from OpenSIPS to the latest version available. ### Report Origin The bug is detected by a tool developed at [CAST](https://castech.am/). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3911 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3911(a)github.com>

4 months, 2 weeks

[kamailio/kamailio] lib/ims: added cscf_get_host_from_requri (PR #3912)

by Dragos Vingarzan

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  On Mobile-Terminating, if the P-Called-Party-ID header is missing, getting the host (should also be an IP) from the Request-URI can help the P-CSCF when doing AAR for QoS. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3912 -- Commit Summary -- * lib/ims: added cscf_get_host_from_requri -- File Changes -- M src/lib/ims/ims_getters.c (15) M src/lib/ims/ims_getters.h (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3912.patch https://github.com/kamailio/kamailio/pull/3912.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3912 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3912(a)github.com>

4 months, 2 weeks

git:master:70fd2717: lib/ims: added cscf_get_host_from_requri

by Dragos Vingarzan

Module: kamailio Branch: master Commit: 70fd27174952fe6a67f01fca4fdc941b9fdc045a URL: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-12T13:27:21+02:00 lib/ims: added cscf_get_host_from_requri --- Modified: src/lib/ims/ims_getters.c Modified: src/lib/ims/ims_getters.h --- Diff: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… Patch: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… --- diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c index cf2f618d0de..35dbdca405f 100644 --- a/src/lib/ims/ims_getters.c +++ b/src/lib/ims/ims_getters.c @@ -539,6 +539,21 @@ str cscf_get_contact_from_requri(struct sip_msg *msg) return pu; } +/** + * Get the host from the Request URI of the message. + * Useful for example on MT, to get the destination from the Request URI, if P-Called-Party-ID is not present. + */ +str cscf_get_host_from_requri(struct sip_msg *msg) +{ + if(msg->first_line.type != SIP_REQUEST || parse_sip_msg_uri(msg) < 0 + || msg->parsed_uri.type == TEL_URI_T) { + str empty = {0}; + return empty; + } + return msg->parsed_uri.host; +} + + /** * Finds if the message contains the orig parameter in the first Route header * @param msg - the SIP message diff --git a/src/lib/ims/ims_getters.h b/src/lib/ims/ims_getters.h index 77a55a6695b..03ad4bef82b 100644 --- a/src/lib/ims/ims_getters.h +++ b/src/lib/ims/ims_getters.h @@ -206,6 +206,12 @@ str cscf_get_public_identity_from_requri(struct sip_msg *msg); */ str cscf_get_contact_from_requri(struct sip_msg *msg); +/** + * Get the host from the Request URI of the message. + * Useful for example on MT, to get the destination from the Request URI, if P-Called-Party-ID is not present. + */ +str cscf_get_host_from_requri(struct sip_msg *msg); + /** * Looks for the Call-ID header * @param msg - the sip message

4 months, 2 weeks

git:master:fc8bee5b: pua: use long for time value diff operation

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: fc8bee5b87e95e43bda2635e65457b2025eab6f9 URL: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T12:05:40+02:00 pua: use long for time value diff operation --- Modified: src/modules/pua/pua.c --- Diff: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… Patch: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… --- diff --git a/src/modules/pua/pua.c b/src/modules/pua/pua.c index e57183427f3..a53bfd83963 100644 --- a/src/modules/pua/pua.c +++ b/src/modules/pua/pua.c @@ -1121,9 +1121,10 @@ static ua_pres_t *build_uppubl_cbparam(ua_pres_t *p) publ.pres_uri = p->pres_uri; publ.content_type = p->content_type; publ.id = p->id; - publ.expires = (p->desired_expires == 0) - ? -1 - : p->desired_expires - (int)time(NULL); + publ.expires = + (int)((p->desired_expires == 0) + ? -1 + : ((long)p->desired_expires - (long)time(NULL))); publ.flag = UPDATE_TYPE; publ.source_flag = p->flag; publ.event = p->event;

4 months, 2 weeks

git:master:c9714586: rls: remove unnecessary assignment

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c97145862119e9001874cd07de9b20ad8e96ff54 URL: https://github.com/kamailio/kamailio/commit/c97145862119e9001874cd07de9b20a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T11:49:10+02:00 rls: remove unnecessary assignment --- Modified: src/modules/rls/resource_notify.c --- Diff: https://github.com/kamailio/kamailio/commit/c97145862119e9001874cd07de9b20a… Patch: https://github.com/kamailio/kamailio/commit/c97145862119e9001874cd07de9b20a… --- diff --git a/src/modules/rls/resource_notify.c b/src/modules/rls/resource_notify.c index c0b308a76d2..8fd388e463c 100644 --- a/src/modules/rls/resource_notify.c +++ b/src/modules/rls/resource_notify.c @@ -179,8 +179,8 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, str bstr = {0, 0}; subs_t *dialog = NULL; int len_est = 0; - int resource_added = - 0; /* Flag to indicate that we have added at least one resource */ + /* Flag to indicate that we have added at least one resource */ + int resource_added = 0; /* generate the boundary string */ boundary_string = generate_string(BOUNDARY_STRING_LEN); @@ -245,7 +245,6 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, len_est += 2 * strlen(boundary_string) + 4 + 102 + 2 + 50 + strlen(resource_uri) + 20; buf_len = 0; - resource_added = 0; /* !!!! for now I will include the auth state without checking if * it has changed - > in future check if it works */

4 months, 2 weeks

git:master:214eaaa5: rtpengine: check fd before closing

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 214eaaa5b7a0308fd7384a41e97b1204d71c93de URL: https://github.com/kamailio/kamailio/commit/214eaaa5b7a0308fd7384a41e97b120… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T09:45:53+02:00 rtpengine: check fd before closing --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/214eaaa5b7a0308fd7384a41e97b120… Patch: https://github.com/kamailio/kamailio/commit/214eaaa5b7a0308fd7384a41e97b120… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 7b97a2ae1ee..8a2f6a08e8f 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -3770,7 +3770,8 @@ static char *send_rtpp_command( return cp; badproxy: - close(fd); + if(fd >= 0) + close(fd); return NULL; }

4 months, 2 weeks

git:master:87e1a4a7: stun: check message len for response

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 87e1a4a7f5d565a59a362f22e9372697f2f2f2af URL: https://github.com/kamailio/kamailio/commit/87e1a4a7f5d565a59a362f22e937269… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T08:06:36+02:00 stun: check message len for response --- Modified: src/modules/stun/kam_stun.c --- Diff: https://github.com/kamailio/kamailio/commit/87e1a4a7f5d565a59a362f22e937269… Patch: https://github.com/kamailio/kamailio/commit/87e1a4a7f5d565a59a362f22e937269… --- diff --git a/src/modules/stun/kam_stun.c b/src/modules/stun/kam_stun.c index b3c1e7877d3..3ad42ff1636 100644 --- a/src/modules/stun/kam_stun.c +++ b/src/modules/stun/kam_stun.c @@ -512,6 +512,10 @@ static int stun_create_response(struct stun_msg *req, struct stun_msg *res, } } + if(res->msg.buf.len < sizeof(struct stun_hdr)) { + LM_ERR("invalid message\n"); + return FATAL_ERROR; + } res->hdr.len = htons(res->msg.buf.len - sizeof(struct stun_hdr)); memcpy(&res->msg.buf.s[sizeof(USHORT_T)], (void *)&res->hdr.len, sizeof(USHORT_T));

4 months, 2 weeks

← Newer
1
...
10
11
12
13
14
15
16
...
21
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2024