sr-dev July 2024

sr-dev@lists.kamailio.org

16 participants
212 discussions

git:master:97ba5dff: db_redis: change logs on delete
by Stefan Mititelu 03 Jul '24

03 Jul '24

Module: kamailio Branch: master Commit: 97ba5dff468fc309acc9245108a0d7645fe45361 URL: https://github.com/kamailio/kamailio/commit/97ba5dff468fc309acc9245108a0d76… Author: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)govoip.ro> Date: 2024-07-03T18:27:03+03:00 db_redis: change logs on delete --- Modified: src/modules/db_redis/redis_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/97ba5dff468fc309acc9245108a0d76… Patch: https://github.com/kamailio/kamailio/commit/97ba5dff468fc309acc9245108a0d76… --- diff --git a/src/modules/db_redis/redis_dbase.c b/src/modules/db_redis/redis_dbase.c index 84c0c3a9459..b3624975cf4 100644 --- a/src/modules/db_redis/redis_dbase.c +++ b/src/modules/db_redis/redis_dbase.c @@ -1827,13 +1827,13 @@ static int db_redis_perform_delete(const db1_con_t *_h, km_redis_con_t *con, "performing delete\n", CON_TABLE(_h)->len, CON_TABLE(_h)->s); else - LM_WARN("performing table scan on table '%.*s' while performing " - "delete using match key " - "'%.*s' at offset %llx\n", + LM_DBG("performing table scan on table '%.*s' while performing " + "delete using match key " + "'%.*s' at offset %llx\n", CON_TABLE(_h)->len, CON_TABLE(_h)->s, ts_scan_key->len, ts_scan_key->s, (unsigned long long)ts_scan_start); for(i = 0; i < _n; ++i) { - LM_WARN(" scan key %d is '%.*s'\n", i, _k[i]->len, _k[i]->s); + LM_DBG(" scan key %d is '%.*s'\n", i, _k[i]->len, _k[i]->s); } if(db_redis_scan_query_keys(con, CON_TABLE(_h), _n, keys, keys_count, manual_keys, manual_keys_count, ts_scan_start, ts_scan_key,

1 0

Kamailio v5.6.6 Released
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Hello, Kamailio SIP Server v5.6.6 stable release is out. This is a maintenance release of the latest stable branch, 5.6, that includes fixes since the release of v5.6.5. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.6.x. Deployments running previous v5.6.x versions are strongly recommended to be upgraded to v5.6.6. Note that 5.6 is now the third last stable branch, v5.6.6 being the last planned released in 5.5.x series. The latest two stable branch are 5.7 and 5.8, with v5.8.2 being released a while ago. For more details about version 5.6.6 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2024/07/kamailio-v5-6-6-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy and Development Services Kamailio Advanced Training -- asipto.com

1 0

git:5.6:144b61dc: ChangeLog: content updated for v5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: 144b61dc9e66f574e6a32a7dcd3b3e3e1343666f URL: https://github.com/kamailio/kamailio/commit/144b61dc9e66f574e6a32a7dcd3b3e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:51:14+02:00 ChangeLog: content updated for v5.6.6 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/144b61dc9e66f574e6a32a7dcd3b3e3… Patch: https://github.com/kamailio/kamailio/commit/144b61dc9e66f574e6a32a7dcd3b3e3…

1 0

git:5.6:fe1c5b4c: Makefile.defs: version set to 5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: fe1c5b4c42795be5218ddc88a3245ed8be9865c7 URL: https://github.com/kamailio/kamailio/commit/fe1c5b4c42795be5218ddc88a3245ed… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:29:23+02:00 Makefile.defs: version set to 5.6.6 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/fe1c5b4c42795be5218ddc88a3245ed… Patch: https://github.com/kamailio/kamailio/commit/fe1c5b4c42795be5218ddc88a3245ed… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 872c5fc5d90..b3c1c74d135 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 6 -SUBLEVEL = 5 +SUBLEVEL = 6 EXTRAVERSION = # memory manager switcher

1 0

git:5.6:80926422: pkg: deb specs updated for v5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: 80926422b3aa0c98dfb73aa9a87eece98efb1ff8 URL: https://github.com/kamailio/kamailio/commit/80926422b3aa0c98dfb73aa9a87eece… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:28:36+02:00 pkg: deb specs updated for v5.6.6 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/80926422b3aa0c98dfb73aa9a87eece… Patch: https://github.com/kamailio/kamailio/commit/80926422b3aa0c98dfb73aa9a87eece…

1 0

git:5.6:6cea0990: pkg: version set to 5.6.6 for rpms and alpine specs
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: 6cea09909229abe759d2bf860ea93e714699feae URL: https://github.com/kamailio/kamailio/commit/6cea09909229abe759d2bf860ea93e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:27:54+02:00 pkg: version set to 5.6.6 for rpms and alpine specs --- Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/6cea09909229abe759d2bf860ea93e7… Patch: https://github.com/kamailio/kamailio/commit/6cea09909229abe759d2bf860ea93e7… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index a409d8fdde6..9662c1d5873 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -4,7 +4,7 @@ # Maintainer: Nathan Angelacos <nangel(a)alpinelinux.org> pkgname=kamailio -pkgver=5.6.5 +pkgver=5.6.6 pkgrel=0 # If building from a git snapshot, specify the gitcommit diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 075321ec592..eb0e821f76a 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.6.5 +%define ver 5.6.6 %define rel dev1.0%{dist} %if 0%{?fedora}

1 0

Releasing v5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Hello, I am considering to release Kamailio v5.6.6 (out of branch 5.6) later this week (likely on Wednesday, July 3, 2024). If anyone is aware of issues not yet on the bug tracker, report them there asap in order to have a better chance to be fixed. This is going to be the last release out of branch 5.6 to mark the end of official/packaging maintenance. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 1

[kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)
by Oded Arbel 02 Jul '24

02 Jul '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #### Description In `send_rtpp_command()` if socket operations fail with an error other than `EINTR` or `ENOBUFS`, the actual error is not reported - we just get a generic "Can't send command to/read reply from RTPEngine". Other places in the module report `errno` and `strerror(errno)` using the log format "`(%s:%d)`" so added that to the error log. Also fixed `bind_force_send_ip()` error log to use the same semantic as the other places. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3899 -- Commit Summary -- * rtpengine: show errno and error string in more places where it is useful -- File Changes -- M src/modules/rtpengine/rtpengine.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3899.patch https://github.com/kamailio/kamailio/pull/3899.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3899 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3899(a)github.com>

2 9

git:master:fae2a467: rtpengine: show errno and error string in more places where it is useful (#3899)
by GitHub 02 Jul '24

02 Jul '24

Module: kamailio Branch: master Commit: fae2a467cb7b543920cf8bea3ce655ad07b70969 URL: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… Author: Oded Arbel <oded(a)geek.co.il> Committer: GitHub <noreply(a)github.com> Date: 2024-07-02T08:19:11-04:00 rtpengine: show errno and error string in more places where it is useful (#3899) Also fixed bind_force_send_ip() error log to use the same semantic as other places --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… Patch: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 54f22b1843f..7b97a2ae1ee 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -830,7 +830,7 @@ static int bind_force_send_ip(int sock_idx) sizeof(ip6addr))) < 0) { LM_ERR("can't bind socket to required ipv6 interface\n"); - LM_ERR("ret=%d errno=%d\n", ret, errno); + LM_ERR("ret=%d (%s:%d)\n", ret, strerror(errno), errno); return -1; } @@ -3598,7 +3598,7 @@ static char *send_rtpp_command( struct rtpp_node *node, bencode_item_t *dict, int *outlen) { struct sockaddr_un addr; - int fd, len, i, vcnt; + int fd = -1, len, i, vcnt; int rtpengine_retr, rtpengine_tout_ms = 1000; char *cp; static char buf[0x40000]; @@ -3632,8 +3632,8 @@ static char *send_rtpp_command( goto badproxy; } if(connect(fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) { - close(fd); - LM_ERR("can't connect to RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't connect to RTPEngine <%s> (%s:%d)\n", node->rn_url.s, + strerror(errno), errno); goto badproxy; } @@ -3641,18 +3641,19 @@ static char *send_rtpp_command( len = writev(fd, v + 1, vcnt); } while(len == -1 && errno == EINTR); if(len <= 0) { - close(fd); - LM_ERR("can't send command to RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't send command to RTPEngine <%s> (%s:%d)\n", + node->rn_url.s, strerror(errno), errno); goto badproxy; } do { len = read(fd, buf, sizeof(buf) - 1); } while(len == -1 && errno == EINTR); - close(fd); if(len <= 0) { - LM_ERR("can't read reply from RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't read reply from RTPEngine <%s> (%s:%d)\n", + node->rn_url.s, strerror(errno), errno); goto badproxy; } + close(fd); } else if(node->rn_umode == RNU_WS || node->rn_umode == RNU_WSS) { /* assemble full request string, flatten iovec */ v[0].iov_base = gencookie(); @@ -3721,8 +3722,9 @@ static char *send_rtpp_command( } while(len == -1 && (errno == EINTR || errno == ENOBUFS)); if(len <= 0) { bencode_get_str(bencode_dictionary_get(dict, "command"), &cmd); - LM_ERR("can't send command \"%.*s\" to RTPEngine <%s>\n", - cmd.len, cmd.s, node->rn_url.s); + LM_ERR("can't send command \"%.*s\" to RTPEngine <%s> " + "(%s:%d)\n", + cmd.len, cmd.s, node->rn_url.s, strerror(errno), errno); goto badproxy; } while((poll(fds, 1, rtpengine_tout_ms) == 1) @@ -3734,8 +3736,9 @@ static char *send_rtpp_command( bencode_get_str( bencode_dictionary_get(dict, "command"), &cmd); LM_ERR("can't read reply for command \"%.*s\" from " - "RTPEngine <%s>\n", - cmd.len, cmd.s, node->rn_url.s); + "RTPEngine <%s> (%s:%d)\n", + cmd.len, cmd.s, node->rn_url.s, strerror(errno), + errno); goto badproxy; } if(len >= (v[0].iov_len - 1) @@ -3767,6 +3770,7 @@ static char *send_rtpp_command( return cp; badproxy: + close(fd); return NULL; }

1 0

[kamailio/kamailio] misc/examples/ims/icscf: fix bad prefix added on all incoming requests (PR #3900)
by Dragos Vingarzan 02 Jul '24

02 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to PR https://github.com/kamailio/kamailio/pull/3891 - splitting by components #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3900 -- Commit Summary -- * misc/examples/ims/icscf: removed always adding a plus as a prefix on requests arriving to the I-CSCF -- File Changes -- M misc/examples/ims/icscf/kamailio.cfg (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3900.patch https://github.com/kamailio/kamailio/pull/3900.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3900 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3900(a)github.com>

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2024