sr-dev July 2024

sr-dev@lists.kamailio.org

16 participants
210 discussions

[kamailio/kamailio] p-charging-vector bug in siputils with force flag (Issue #3929)

by Michael

### Description I used sip_p_charging_vector() function of siputils with flag f (remove + generate). This function works fine if call is received without a P-Charging-Vector and only generate needs to be done. But if the INVITE already contains a P-Charging-Vector and this vector needs to be removed and replaced by a new generated P-Charging-Vector the output is messed up. The sip_p_charging_vector() function with flag r (remove) works fine too. P-Charging-Vector is removed if INVITE contains one. So for me this looks like an issue with the combination of remove + generate. See SIP Traffic attached. The "old" P-Charging-Vector is not deleted and additionaly instead of a new P-Charging-Vector the "old" P-Charging-Vector is added again above SDP. Also some part of the next line "Session-Exp" is added and "TH: dih". ----- TH: dih icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx Session-Exp ----- ### Troubleshooting #### Reproduction It looks like the issue is triggered always a p-charging-vector is received by kamailio and sip_p_charging_vector() with flag f is called. #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic ``` **This message is received by kamailio (Incoming):** INVITE sip:+49xxxxxxxx;npdi;rn=+49xxxxxxxx@bob.com:5060;user=phone SIP/2.0 Via: SIP/2.0/UDP 213.xxx.xxx.xxx:5060;branch=z9hG4bK08Bf3722bac16f3e05b From: <sip:+43xxxxxxxx@alice.com;user=phone>;tag=gK085abca7 To: <sip:+49xxxxxxxx0@92.xxx.xxx.xxx:5060;user=phone> Call-ID: 168341746_132086108(a)213.xxx.xxx.xxx CSeq: 373279 INVITE Max-Forwards: 67 Allow: INVITE,ACK,CANCEL,BYE,REGISTER,REFER,INFO,SUBSCRIBE,NOTIFY,PRACK,UPDATE,OPTIONS,MESSAGE,PUBLISH Accept: application/sdp, application/isup, application/dtmf, application/dtmf-relay, multipart/mixed Contact: <sip:+43xxxxxxxx@213.xxx.xxx.xxx:5060> P-Asserted-Identity: <sip:+43xxxxxxxx@alice.com:5060;user=phone> Supported: timer,100rel,histinfo P-Charging-Vector: icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx Session-Expires: 1800 Min-SE: 90 Content-Length: 236 Content-Disposition: session; handling=required Content-Type: application/sdp v=0 o=Sonus_UAC 278609 22801 IN IP4 213.xxx.xxx.xxx s=SIP Media Capabilities c=IN IP4 213.xxx.xxx.xxx t=0 0 m=audio 29020 RTP/AVP 8 101 a=rtpmap:8 PCMA/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=sendrecv a=ptime:20 **This message is send out by kamailio (outgoing):** INVITE sip:+49xxxxxxxx;npdi;rn=+49xxxxxxxx@bob.com:5060;user=phone SIP/2.0 Record-Route: <sip:172.xxx.xxx.xxx;r2=on;lr=on;ftag=gK085abca7> Record-Route: <sip:92.xxx.xxx.xxx9;r2=on;lr=on;ftag=gK085abca7> Via: SIP/2.0/UDP 172.xxx.xxx.xxx;branch=z9hG4bKc451.940fa2c220f96c1ef968de3c156db262.0 Via: SIP/2.0/UDP 213.xxx.xxx.xxx:5060;TH=div;branch=z9hG4bK08Bf3722bac16f3e05b From: <sip:+43xxxxxxxx@alice.com;user=phone>;tag=gK085abca7 To: <sip:+49xxxxxxxx@92.xxx.xxx.xxx:5060;user=phone> Call-ID: 168341746_132086108(a)213.xxx.xxx.xxx CSeq: 373279 INVITE Max-Forwards: 66 Allow: INVITE,ACK,CANCEL,BYE,REGISTER,REFER,INFO,SUBSCRIBE,NOTIFY,PRACK,UPDATE,OPTIONS,MESSAGE,PUBLISH Accept: application/sdp, application/isup, application/dtmf, application/dtmf-relay, multipart/mixed Contact: <sip:+43xxxxxxxx@213.xxx.xxx.xxx:5060> P-Asserted-Identity: <sip:+43xxxxxxxx@alice.com:5060;user=phone> Supported: timer,100rel,histinfo P-Charging-Vector: icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx Session-Expires: 1800 Min-SE: 90 Content-Length: 252 Content-Disposition: session; handling=required Content-Type: application/sdp **_TH: dih icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx Session-Exp_** v=0 o=Sonus_UAC 278609 22801 IN IP4 92.xxx.xxx.xxx s=SIP Media Capabilities c=IN IP4 92.xxx.xxx.xxx t=0 0 m=audio 34622 RTP/AVP 8 101 a=rtpmap:8 PCMA/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=sendrecv a=rtcp:34623 a=ptime:20 ``` ### Additional Information ``` version: kamailio 5.8.2 (x86_64/linux) 3fa5f4 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 3fa5f4 compiled on 15:54:29 Jul 22 2024 with gcc 10.2.1 ``` * **Operating System**: ``` Debian GNU/Linux 11 5.10.0-26-amd64 #1 SMP Debian 5.10.197-1 (2023-09-29) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3929 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3929(a)github.com>

3 weeks, 2 days

[kamailio/kamailio] Memory usage increases everytime tls.reload is executed (Issue #3823)

by Sebastian Denz

### Description We are using Kamailio 5.7.4 on Debian 12 (from http://deb.kamailio.org/kamailio57) with rtpengine as an Edgeproxy for our clients. The instance terminates SIP/TLS (with Cliencertificates) and forwards the SIP Traffic to internal systems. After some days we are getting errors like this `tls_complete_init(): tls: ssl bug #1491 workaround: not enough memory for safe operation: shm=7318616 threshold1=8912896` First we thought Kamailio just doesnt have enough memory, so we doubled it.. But after some days the Logmessage (and Userissues) occured again. So we monitored the shmmem statistics and found that used and max_used are constantly growing til it reaches the limit. As i mentioned we are using client-certificates and so we are also using the CRL feature. We do have a systemd-timer which fetches the CRL every hour and runs 'kamcmd tls.reload' when finished. Our tls.cfg looks like this: ``` [server:default] method = TLSv1.2+ private_key = /etc/letsencrypt/live/hostname.de/privkey.pem certificate = /etc/letsencrypt/live/hostname.de/fullchain.pem ca_list = /etc/kamailio/ca_list.pem ca_path = /etc/kamailio/ca_list.pem crl = /etc/kamailio/combined.crl.pem verify_certificate = yes require_certificate = yes [client:default] verify_certificate = yes require_certificate = yes ``` After testing a bit we found that every time tls.reload is executed Kamailio consumes a bit more memory which eventually leads to all the memory being consumed which leads to issues for our users. See following example: ``` [0][root@edgar-dev:~]# while true ; do /usr/sbin/kamcmd tls.reload ; /usr/sbin/kamcmd core.shmmem ; sleep 1 ; done Ok. TLS configuration reloaded. { total: 268435456 free: 223001520 used: 41352552 real_used: 45433936 max_used: 45445968 fragments: 73 } Ok. TLS configuration reloaded. { total: 268435456 free: 222377960 used: 41975592 real_used: 46057496 max_used: 46069232 fragments: 78 } Ok. TLS configuration reloaded. { total: 268435456 free: 221748664 used: 42604992 real_used: 46686792 max_used: 46698080 fragments: 77 } Ok. TLS configuration reloaded. { total: 268435456 free: 221110832 used: 43242408 real_used: 47324624 max_used: 47335608 fragments: 81 } ^C [130][root@edgar-dev:~]# ``` ### Troubleshooting #### Reproduction Everytime tls.reload is called the memory consumptions grows.. #### Debugging Data  ``` If you let me know what would be interesting for tracking this down, i am happy to provide logs/debugging data! ``` #### Log Messages  ``` If you let me know what would be interesting for tracking this down, i am happy to provide logs/debugging data! ``` #### SIP Traffic SIP doesnt seem to be relevant here ### Possible Solutions Calling tls.reload less often or restart kamailio before memory is consumed ;) ### Additional Information ``` version: kamailio 5.7.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: ``` * Debian GNU/Linux 12 (bookworm) * Linux edgar-dev 6.1.0-20-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.85-1 (2024-04-11) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3823 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3823(a)github.com>

3 weeks, 6 days

[kamailio/kamailio] db_redis: compile issues with TLS + redis-cluster (Issue #3893)

by uv-2722

### Description Hello, I am trying to setup db_redis with TLS and redis-cluster support, I get the following errors during installation. ### Troubleshooting #### Reproduction Install hiredis(v1.2.0) and hiredis-cluster(v0.13.0) from source, both with ssl support. Then install kamailio 5.8.1 from source with db_redis module  #### Log Messages  ``` 37.77 CC (gcc) [M db_redis.so] db_redis_mod.o 37.85 CC (gcc) [M db_redis.so] redis_connection.o 37.90 redis_connection.c: In function 'db_redis_connect': 37.90 redis_connection.c:129:9: error: unknown type name 'redisSSLContext'; did you mean 'redisContext'? 37.90 129 | redisSSLContext *ssl = NULL; 37.90 | ^~~~~~~~~~~~~~~ 37.90 | redisContext 37.90 redis_connection.c:166:17: warning: implicit declaration of function 'redisInitOpenSSL' [-Wimplicit-function-declaration] 37.90 166 | redisInitOpenSSL(); 37.90 | ^~~~~~~~~~~~~~~~ 37.90 redis_connection.c:167:23: warning: implicit declaration of function 'redisCreateSSLContext' [-Wimplicit-function-declaration] 37.90 167 | ssl = redisCreateSSLContext( 37.90 | ^~~~~~~~~~~~~~~~~~~~~ 37.90 redis_connection.c:167:21: warning: assignment to 'int *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 37.90 167 | ssl = redisCreateSSLContext( 37.90 | ^ 37.91 redis_connection.c:196:17: warning: implicit declaration of function 'redisClusterSetOptionEnableSSL'; did you mean 'redisClusterSetOptionMaxRetry'? [-Wimplicit-function-declaration] 37.91 196 | redisClusterSetOptionEnableSSL(con->con, ssl); 37.91 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 37.91 | redisClusterSetOptionMaxRetry 37.93 make[2]: *** [../../Makefile.rules:100: redis_connection.o] Error 1 37.93 make[1]: *** [Makefile:508: modules] Error 1 37.93 make[1]: Leaving directory '/root/build/kamailio/src' 37.93 make: *** [Makefile:34: all] Error 2 ``` ### Additional Information * **Kamailio Version**: ``` Kamailio 5.8.1 ``` * **Operating System**:  ``` Debian 12 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3893 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3893(a)github.com>

4 weeks

[kamailio/kamailio] Usrloc keepalive: Not sending OPTIONS to UDP endpoints- 5.8.0 and 5.8.1 (Issue #3844)

by Luke Escudé

Running compiled Kamailio 5.8.1 (previously 5.8.0) on Debian 12 64-bit We're seeing an issue with UDP endpoints (this issue does not happen with TCP and TLS) where usrloc will not send OPTIONS packet keepalives. Here are all of our usrloc parameters: modparam("usrloc", "db_mode", 0) modparam("usrloc", "ka_domain", "SIPDOMAIN") #-- SIPDOMAIN is a fqdn modparam("usrloc", "ka_from", "sip:proxy-ping@SIPDOMAIN") modparam("usrloc", "ka_mode", 1) modparam("usrloc", "timer_interval", 20) #-- How often to qualify endpoints and clean mem tables? modparam("usrloc", "timer_procs", 4) modparam("usrloc", "ka_randomize", 10) modparam("usrloc", "use_domain", 0) modparam("usrloc", "server_id_filter", 1) modparam("usrloc", "ka_filter", 0) modparam("usrloc", "ka_timeout", 60) #-- How quickly to expire a contact if it does not reply to keepalive? modparam("usrloc", "matching_mode", 0) modparam("usrloc", "handle_lost_tcp", 1) modparam("usrloc", "close_expired_tcp", 1) modparam("usrloc", "desc_time_order", 1) modparam("usrloc", "hash_size", 14) It seems usrloc is not actually using timer_interval at all for UDP devices. However, it does seem to be sending OPTIONS every 20 seconds on TCP/TLS. (this is confirmed via packet capture on a SIP phone). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3844 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3844(a)github.com>

1 month

[kamailio/kamailio] topos:added get_callid_mask/get_callid_unmask funtion for handeling Refer-To header (PR #3872)

by Harish S

Topos: Added get_callid_mask functin which will give the masked callID if actual callID is given and get_callid_unmask function which will unmask the given call-ID. This funtion is useful when the client sends a refer methord with refer-to header containing call-id  #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3872 -- Commit Summary -- * add funtion to mask/unmask callID * get_callid_mask /get_callid_unmask Document Update -- File Changes -- M src/modules/topos/doc/topos_admin.xml (87) M src/modules/topos/topos_mod.c (183) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3872.patch https://github.com/kamailio/kamailio/pull/3872.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3872 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3872(a)github.com>

1 month, 1 week

[kamailio/kamailio] kazoo: 'amqp_set_initialize_ssl_library' is deprecated (Issue #3466)

by sergey-safarov

From the build log ``` CC (gcc) [M kazoo.so] kazoo.o CC (gcc) [M kazoo.so] kz_amqp.o kz_amqp.c: In function 'kz_amqp_connection_open_ssl': kz_amqp.c:857:17: warning: 'amqp_set_initialize_ssl_library' is deprecated [-Wdeprecated-declarations] 857 | amqp_set_initialize_ssl_library(1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from kz_amqp.c:37: /usr/include/rabbitmq-c/ssl_socket.h:233:16: note: declared here 233 | void AMQP_CALL amqp_set_initialize_ssl_library(amqp_boolean_t do_initialize); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ CC (gcc) [M kazoo.so] kz_fixup.o CC (gcc) [M kazoo.so] kz_hash.o ``` Functions description in the header file https://github.com/alanxz/rabbitmq-c/blob/v0.13.0/include/rabbitmq-c/ssl_so… ``` /** * Sets whether rabbitmq-c will initialize OpenSSL. * * \deprecated Since v0.13.0 this is a no-op. OpenSSL automatically manages * library initialization and uninitialization. * * OpenSSL requires a one-time initialization across a whole program, this sets * whether or not rabbitmq-c will initialize the SSL library when the first call * to amqp_ssl_socket_new() is made. You should call this function with * do_init = 0 if the underlying SSL library is initialized somewhere else * the program. * * Failing to initialize or double initialization of the SSL library will * result in undefined behavior * * By default rabbitmq-c will initialize the underlying SSL library. * * NOTE: calling this function after the first socket has been opened with * amqp_open_socket() will not have any effect. * * \param [in] do_initialize If 0 rabbitmq-c will not initialize the SSL * library, otherwise rabbitmq-c will initialize the * SSL library * * \since v0.4.0 */ ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3466 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3466(a)github.com>

1 month, 2 weeks

[kamailio/kamailio] Build for el9 without legacy geoip (PR #3886)

by Oded Arbel

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #3592 #### Description The `kamailio-geoip` RPM sub package currently builds both the `geoip` module - based on [the old and out of support MaxMind GeoIP library](https://github.com/maxmind/geoip-api-c) - and the newer `geoip2` module - based on [the currently supported `libmaxminddb`](https://github.com/maxmind/libmaxminddb). The old GeoIP C library had its end of support date at May 2022 but for a while was still shipped for many distributions. At this point though, the EPEL repository that shipped the GeoIP library for RHEL-based operating systems, has removed it from their repositories for "Enterprise Linux 9": ![Screenshot_20240620_144233](https://github.com/kamailio/kamailio/assets/381782/bb1f2481-57f7-48af-b0f1-0ba1c14a3042) Therefor builds using the bundled spec file fail on EL9 installations. The suggested change is to add an RPM build option `--with geoip2` that when specified will build just the `geoip2` module for the `kamailio-geoip` RPM subpackage. This build option is not enabled by default, unless the build is running on a RHEL 9 based OS - in which case it is set as the default, because otherwise trivial builds break. To revert to the older behavior in RHEL 9 based OSs (and assuming you have the required unsupported library installed correctly) one will need to set both `--without geoip2 --with geoip`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3886 -- Commit Summary -- * packaging: RPM build option to build just the geoip2 module * packaging: make 'with geoip2' the default behavior for EL9 -- File Changes -- M pkg/kamailio/obs/kamailio.spec (36) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3886.patch https://github.com/kamailio/kamailio/pull/3886.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3886 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3886(a)github.com>

1 month, 2 weeks

[kamailio/kamailio] IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql (orig. from misc/examples/ims/icscf.sql) (PR #3876)

by markusmonka

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adding sqlfile ims i-cscf to utils/kamctl/mysql copied from misc/examples/ims/icscf so that sql file will be automatically included in kamailio-mysql-module packages in the future You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3876 -- Commit Summary -- * IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql -- File Changes -- A utils/kamctl/mysql/ims-icscf.sql (94) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3876.patch https://github.com/kamailio/kamailio/pull/3876.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3876 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3876(a)github.com>

1 month, 2 weeks

[kamailio/kamailio] The tm.cancel function does not generate a “tm:local-request” event. (Issue #3831)

by JuanPascual2

Hello The tm.t_uac_start function generates a “tm:local-request” event. But the tm.cancel function doesn't generete “tm:local-request” event. Is it possible to activate a parameter in the TM or TMX module to generate the event? Thanks Juan -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3831 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3831(a)github.com>

1 month, 3 weeks

[kamailio/kamailio] siptrace: handle trace_to_database param at runtime (PR #3877)

by Gustavo Almeida

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This change allows to enable/disable the insertion of SIP traces into the DB at runtime (i know we could do this with `siptrace.status`, but this is a different case). This feature is strictly important if you start `Kamailio` with `trace_to_database` parameter disabled, and you want to enable it later and at runtime. Nowadays, if you try to start `Kamailio` with `trace_to_database` enabled, but without a connection to the DB, the service won't start (`child_init` logic). In this type of situation, it makes sense to start `Kamailio` disabling the `trace_to_database` parameter, and when the DB is ok, at runtime, we enable `trace_to_database` parameter. This prevents the need to restart the service, and also we can start `Kamailio` without problems, if DB of SIP Traces is NOK at that time. My PR may need some improvements, especially on the enable side, so feel free to make any changes to improve that. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3877 -- Commit Summary -- * siptrace: handle trace_to_database param at runtime -- File Changes -- M src/modules/siptrace/siptrace.c (100) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3877.patch https://github.com/kamailio/kamailio/pull/3877.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3877 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3877(a)github.com>

1 month, 3 weeks

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2024