sr-dev August 2024

sr-dev@lists.kamailio.org

10 participants
162 discussions

[kamailio/kamailio] Hello, I would like to confirm if our SMS module supports sending long SMS messages ？ (Issue #3822)

by Helloworld1668

### Description  Hello, when I was testing the SMSC SMS business, I found that the SMS could not be forwarded by the SMSC when the characters were too long, approximately 117 characters. The issue was traced back to the smsops module, which has a limit on the length of the SMS, but it seems that it does not handle SMS segmentation. The error message returned is as follows. Could you please provide some suggestions and help? ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages ``` 2024-04-24T05:59:01.837950514Z 3(24) ERROR: <script>: SMS for "" (Valid: 0 ) 2024-04-24T05:59:14.466167796Z 2(23) ERROR: <script>: 3GPP-SMS: MESSAGE (sip:+8618107550088@ims.mnc011.mcc460.3gppnetwork.org (172.22.0.20:6060) to tel:+8613800138000, bnecb4LQJ(a)10.46.2.1) 2024-04-24T05:59:14.466173859Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length! 2024-04-24T05:59:14.466175929Z 2(23) ERROR: smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! 2024-04-24T05:59:14.466191554Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length! 2024-04-24T05:59:14.466194545Z 2(23) ERROR: smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! 2024-04-24T05:59:14.466196517Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length! 2024-04-24T05:59:14.466198406Z 2(23) ERROR: smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! 2024-04-24T05:59:14.466200311Z 2(23) ERROR: <script>: SMS for "" (Valid: ) 2024-04-24T05:59:14.466255812Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length! 2024-04-24T05:59:14.466276249Z 2(23) ERROR: smsops [smsops_impl.c:1903]: isRPDATA(): Error getting/decoding RP-Data from request! ``` #### SIP Traffic  ``` ``` ![image](https://github.com/kamailio/kamailio/assets/152272255/808e65ce-9763-4056-9924-77122f6d9c25) ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 4fb8ac -dirty compiled on 03:11:49 Apr 24 2024 with gcc 9.4.0 ``` version: kamailio 5.9.0-dev0 (x86_64/linux) 4fb8ac-dirty flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB ``` * **Operating System**:  ``` Linux sder 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3822 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3822(a)github.com>

3 months, 1 week

[kamailio/kamailio] secfilter: export functions to KEMI (PR #3945)

by bazrafshan.m.h

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  * All functions are exported to kemi You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3945 -- Commit Summary -- * secfilter is fully KEMIized * secfilter: fix the failed format check -- File Changes -- M src/modules/secfilter/secfilter.c (88) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3945.patch https://github.com/kamailio/kamailio/pull/3945.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3945 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3945(a)github.com>

3 months, 1 week

[kamailio/kamailio] cdp: Functions are exported in KEMI (PR #3942)

by bazrafshan.m.h

- Added `cdp_has_app` function: - Accepts a single parameter: - `application`: The Application ID. - Added `cdp_has_app2` function: - Accepts two parameters: - `vendorid`: The Vendor ID associated with the application. - `application`: The Application ID. - Added cdp_check_peer function: - Accepts one parameter: - `fqdn`: the Fully qualified domain name of the peer, that should be checked. The parameter may contain pseudovariables. NOTE: All parameters are passed as standard strings.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3942 -- Commit Summary -- * cdp: export all functions in KEMI module -- File Changes -- M src/modules/cdp/cdp_mod.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3942.patch https://github.com/kamailio/kamailio/pull/3942.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3942 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3942(a)github.com>

3 months, 1 week

[kamailio/kamailio] cdp: export functions to KEMI (PR #3941)

by bazrafshan.m.h

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  * Exporting all cdp functions to KEMI You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3941 -- Commit Summary -- * secfilter: all functions are exported in KEMI * cdp: ki_cdp_check_peer() KEMIized * cdp: export all functions in KEMI module -- File Changes -- M src/modules/cdp/cdp_mod.c (34) M src/modules/secfilter/secfilter.c (88) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3941.patch https://github.com/kamailio/kamailio/pull/3941.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3941 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3941(a)github.com>

3 months, 1 week

git:master:8361471e: dispatcher: use char for oc distribution array

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8361471e6ec49d3b92443e0ddd728bf665460c02 URL: https://github.com/kamailio/kamailio/commit/8361471e6ec49d3b92443e0ddd728bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-09T16:04:11+02:00 dispatcher: use char for oc distribution array - reduce array size --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatch.h --- Diff: https://github.com/kamailio/kamailio/commit/8361471e6ec49d3b92443e0ddd728bf… Patch: https://github.com/kamailio/kamailio/commit/8361471e6ec49d3b92443e0ddd728bf… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 95f0128f9bd..f17963cc3bf 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -143,6 +143,7 @@ static void ds_run_route( struct sip_msg *msg, str *uri, char *route, ds_rctx_t *rctx); void shuffle_uint100array(unsigned int *arr); +void shuffle_char100array(char *arr); int ds_reinit_rweight_on_state_change( int old_state, int new_state, ds_set_t *dset); @@ -442,12 +443,12 @@ void ds_oc_prepare(ds_dest_t *dp) { int i; for(i = 0; i < dp->ocdata.ocrate; i++) { - dp->ocdata.ocdist[i] = 0; + dp->ocdata.ocdist[i] = '0'; } for(i = dp->ocdata.ocrate; i < 100; i++) { - dp->ocdata.ocdist[i] = 1; + dp->ocdata.ocdist[i] = '1'; } - shuffle_uint100array(dp->ocdata.ocdist); + shuffle_char100array(dp->ocdata.ocdist); } /** @@ -525,7 +526,7 @@ static inline int ds_oc_skip(ds_set_t *dsg, int alg, int n) LM_DBG("time validity not matching\n"); return 0; } - if(dsg->dlist[n].ocdata.ocdist[dsg->dlist[n].ocdata.ocidx] == 1) { + if(dsg->dlist[n].ocdata.ocdist[dsg->dlist[n].ocdata.ocidx] == '1') { /* use it */ ret = 0; } else { @@ -793,6 +794,23 @@ void shuffle_uint100array(unsigned int *arr) } +/* for internal usage; arr must be arr[100] */ +void shuffle_char100array(char *arr) +{ + int k; + int j; + char t; + if(arr == NULL) + return; + for(j = 0; j < 100; j++) { + k = j + (kam_rand() % (100 - j)); + t = arr[j]; + arr[j] = arr[k]; + arr[k] = t; + } +} + + /** * Initialize the relative weight distribution for a destination set * - fill the array of 0..99 elements where to keep the index of the diff --git a/src/modules/dispatcher/dispatch.h b/src/modules/dispatcher/dispatch.h index ed0ceb99978..9c1167d6dbe 100644 --- a/src/modules/dispatcher/dispatch.h +++ b/src/modules/dispatcher/dispatch.h @@ -222,10 +222,11 @@ typedef struct _ds_latency_stats { void latency_stats_init(ds_latency_stats_t *latency_stats, int latency, int count); ds_latency_stats_t *latency_stats_find(int group, str *address); +#define DS_OCDIST_SIZE 104 typedef struct _ds_ocdata { uint32_t ocrate; uint32_t ocidx; - uint32_t ocdist[100]; + char ocdist[DS_OCDIST_SIZE]; struct timeval octime; uint32_t ocseq; uint32_t ocmin;

3 months, 2 weeks

[kamailio/kamailio] Falta atributo de seguridad en Cookie de Sesión / Falta atributo de HttpOnly en Cookie de Sesión (Issue #3938)

by Diego Godoy

Necesito solventar para las instancias de synapsis estos dos vulnerabilidades que comparto a continuación. ![image](https://github.com/user-attachments/assets/39d228bd-d35c-455a-9b6e-bd245870f304) ![image](https://github.com/user-attachments/assets/7b967f7c-433a-404b-85b5-710c38f7034f) Gracias -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3938 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3938(a)github.com>

3 months, 2 weeks

[kamailio/kamailio] [doc] xhttp_rpc module docs, the route should be "rpc" not "http_rpc"。 (Issue #3937)

by gao114882

### Description  <img width="486" alt="企业微信截图_17231113172455" src="https://github.com/user-attachments/assets/2a055290-b200-4954-b902-20997760…"> change this to "rpc" ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: compiled on 09:04:36 Aug 8 2024 with gcc 4.8.5``` * **Operating System**:  ``` ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3937 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3937(a)github.com>

3 months, 2 weeks

git:master:ad312921: dispatcher: print priority in oclist rpc command

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ad31292170f632a381c1f95cbf955ca71f046244 URL: https://github.com/kamailio/kamailio/commit/ad31292170f632a381c1f95cbf955ca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-08T10:15:19+02:00 dispatcher: print priority in oclist rpc command --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/ad31292170f632a381c1f95cbf955ca… Patch: https://github.com/kamailio/kamailio/commit/ad31292170f632a381c1f95cbf955ca… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 50ddd1f4c45..a9744ba2c10 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -2287,8 +2287,9 @@ static void dispatcher_rpc_oclist(rpc_t *rpc, void *ctx) rpc->fault(ctx, 500, "Internal error root reply"); return; } - if(rpc->struct_add(th, "dSduuujjuu", "group", group, "uri", - &node->dlist[i].uri, "flags", node->dlist[i].flags, "ocrate", + if(rpc->struct_add(th, "dSdduuujjuu", "group", group, "uri", + &node->dlist[i].uri, "flags", node->dlist[i].flags, + "priority", node->dlist[i].priority, "ocrate", node->dlist[i].ocdata.ocrate, "ocidx", node->dlist[i].ocdata.ocidx, "ocseq", node->dlist[i].ocdata.ocseq, "octime_sec",

3 months, 2 weeks

git:master:645b34ce: dispatcher: group overload control attributes in a structure

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 645b34cec9ee459ea33cb14d8f66e5c58a7ef975 URL: https://github.com/kamailio/kamailio/commit/645b34cec9ee459ea33cb14d8f66e5c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-07T09:39:27+02:00 dispatcher: group overload control attributes in a structure --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatch.h Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/645b34cec9ee459ea33cb14d8f66e5c… Patch: https://github.com/kamailio/kamailio/commit/645b34cec9ee459ea33cb14d8f66e5c…

3 months, 2 weeks

git:master:398c40ab: modules: readme files regenerated - dispatcher ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 398c40ab7969e738ac92abc8b9c8c557b25ef533 URL: https://github.com/kamailio/kamailio/commit/398c40ab7969e738ac92abc8b9c8c55… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-08-06T11:16:10+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README --- Diff: https://github.com/kamailio/kamailio/commit/398c40ab7969e738ac92abc8b9c8c55… Patch: https://github.com/kamailio/kamailio/commit/398c40ab7969e738ac92abc8b9c8c55… --- diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README index 16c10332df7..2a6148504db 100644 --- a/src/modules/dispatcher/README +++ b/src/modules/dispatcher/README @@ -134,6 +134,7 @@ Federico Cabiddu 5.6. dispatcher.add 5.7. dispatcher.remove 5.8. dispatcher.hash + 5.9. dispatcher.oclist 6. Installation and Running @@ -303,6 +304,7 @@ Chapter 1. Admin Guide 5.6. dispatcher.add 5.7. dispatcher.remove 5.8. dispatcher.hash + 5.9. dispatcher.oclist 6. Installation and Running @@ -1672,6 +1674,7 @@ onreply_route { 5.6. dispatcher.add 5.7. dispatcher.remove 5.8. dispatcher.hash + 5.9. dispatcher.oclist 5.1. dispatcher.set_state @@ -1852,6 +1855,22 @@ kamctl rpc dispatcher.hash 0 alice server.com kamctl rpc dispatcher.hash 4 bob server.com ... +5.9. dispatcher.oclist + + List the overload control attributes for the records in a specific + group. + + Name: dispatcher.oclist + + Parameters: + * _group_: destination group id + + Example: +... +# prototype: kamcli dispatcher.oclist _group_ +kamcli dispatcher.oclist 1 +... + 6. Installation and Running 6.1. Destination List File

3 months, 2 weeks

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2024