#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
#### Description
We are seeing a lot of error messages like:
> ERROR: <null> pua [pua_db.c:895]: get_record_puadb(): Too many rows found (2)
After some investigation I come up with a couple of fixes:
* pua: improve the query to support caller|callee with same pres_id (same dialog)
* pua_dialoginfo: support uuid to generate pres_id to improve randomness
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3955
-- Commit Summary --
* pua: get_record_puadb() add pres_uri to the query
* pua_dialoginfo: use_uuid parameter
* pua_dialoginfo: document use_uuid parameter
-- File Changes --
M src/modules/pua/pua_db.c (18)
M src/modules/pua/pua_db.h (5)
M src/modules/pua/send_publish.c (5)
M src/modules/pua_dialoginfo/doc/pua_dialoginfo.xml (11)
M src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml (25)
M src/modules/pua_dialoginfo/pua_dialoginfo.c (15)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3955.patchhttps://github.com/kamailio/kamailio/pull/3955.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3955
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3955(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
#### Description
This is the first step to merge the functionality that is already used in Sipwise kamailio flavor
* module parameters [from|to]_uri_avp to store
* sca_handle_subscribe() support [from|to_uri] parameters
Add the possibility of define what is the URI value for To and/or From instead of the values from the SIP message
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3930
-- Commit Summary --
* sca: add support custom [to|from]_uri
-- File Changes --
M src/modules/sca/doc/sca.xml (58)
M src/modules/sca/doc/sca_admin.xml (52)
M src/modules/sca/sca.c (115)
M src/modules/sca/sca.h (5)
M src/modules/sca/sca_call_info.c (190)
M src/modules/sca/sca_subscribe.c (96)
M src/modules/sca/sca_subscribe.h (5)
M src/modules/sca/sca_util.c (184)
M src/modules/sca/sca_util.h (19)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3930.patchhttps://github.com/kamailio/kamailio/pull/3930.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3930
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3930(a)github.com>