sr-dev September 2024

sr-dev@lists.kamailio.org

15 participants
173 discussions

[kamailio/kamailio] build: unused-variable (Issue #3974)
by sergey-safarov 13 Sep '24

13 Sep '24

``` ldap_mod.c: In function 'child_init': ldap_mod.c:156:13: warning: unused variable 'ret' [-Wunused-variable] 156 | int ret = 0; | ^~~ LD (gcc) [M ldap.so] ldap.so which: no lua-config in (/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin) which: no lua-config in (/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin) CC (gcc) [M app_lua.so] app_lua_api.o CC (gcc) [M app_lua.so] app_lua_kemi_export.o CC (gcc) [M app_lua.so] app_lua_mod.o LD (gcc) [M app_lua.so] app_lua.so CC (gcc) [M lwsc.so] lwsc_mod.o LD (gcc) [M lwsc.so] lwsc.so ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3974 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3974(a)github.com>

2 1

git:master:a078f140: ldap: remove unused variable in child_init
by Victor Seva 13 Sep '24

13 Sep '24

Module: kamailio Branch: master Commit: a078f14050b6d31bfbcd3562306923c0c4ad73e3 URL: https://github.com/kamailio/kamailio/commit/a078f14050b6d31bfbcd3562306923c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-09-13T22:07:26+02:00 ldap: remove unused variable in child_init fixes #3974 > ldap_mod.c: In function ��child_init��: > ldap_mod.c:156:13: warning: unused variable ��ret�� [-Wunused-variable] > 156 | int ret = 0; --- Modified: src/modules/ldap/ldap_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/a078f14050b6d31bfbcd3562306923c… Patch: https://github.com/kamailio/kamailio/commit/a078f14050b6d31bfbcd3562306923c… --- diff --git a/src/modules/ldap/ldap_mod.c b/src/modules/ldap/ldap_mod.c index de0e25b1545..27d44b9d88b 100644 --- a/src/modules/ldap/ldap_mod.c +++ b/src/modules/ldap/ldap_mod.c @@ -153,7 +153,6 @@ static int child_init(int rank) { int i = 0, ld_count = 0; char *ld_name; - int ret = 0; /* don't do anything for non-worker processes */ if(rank == PROC_INIT || rank == PROC_MAIN || rank == PROC_TCP_MAIN)

1 0

git:master:8257f042: pkg/kamailio: RPM packaged ims_qos_npn
by Sergey Safarov 13 Sep '24

13 Sep '24

Module: kamailio Branch: master Commit: 8257f042f6bc7b59955b3d103cad55f8be4dac26 URL: https://github.com/kamailio/kamailio/commit/8257f042f6bc7b59955b3d103cad55f… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2024-09-13T22:43:43+03:00 pkg/kamailio: RPM packaged ims_qos_npn --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/8257f042f6bc7b59955b3d103cad55f… Patch: https://github.com/kamailio/kamailio/commit/8257f042f6bc7b59955b3d103cad55f… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 8917bf1c045..c182edb28a7 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1980,6 +1980,7 @@ fi %doc %{_docdir}/kamailio/modules/README.ims_isc %doc %{_docdir}/kamailio/modules/README.ims_ocs %doc %{_docdir}/kamailio/modules/README.ims_qos +%doc %{_docdir}/kamailio/modules/README.ims_qos_npn %doc %{_docdir}/kamailio/modules/README.ims_registrar_pcscf %doc %{_docdir}/kamailio/modules/README.ims_registrar_scscf %doc %{_docdir}/kamailio/modules/README.ims_usrloc_pcscf @@ -1995,6 +1996,7 @@ fi %{_libdir}/kamailio/modules/ims_isc.so %{_libdir}/kamailio/modules/ims_ocs.so %{_libdir}/kamailio/modules/ims_qos.so +%{_libdir}/kamailio/modules/ims_qos_npn.so %{_libdir}/kamailio/modules/ims_registrar_pcscf.so %{_libdir}/kamailio/modules/ims_registrar_scscf.so %{_libdir}/kamailio/modules/ims_usrloc_pcscf.so

1 0

git:master:b1c9dac2: pkg/kamailio: fixed python module build on RHEL based dists
by Sergey Safarov 13 Sep '24

13 Sep '24

Module: kamailio Branch: master Commit: b1c9dac2c382a98997d5771921af5aa3235876c0 URL: https://github.com/kamailio/kamailio/commit/b1c9dac2c382a98997d5771921af5aa… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2024-09-13T22:08:17+03:00 pkg/kamailio: fixed python module build on RHEL based dists --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/b1c9dac2c382a98997d5771921af5aa… Patch: https://github.com/kamailio/kamailio/commit/b1c9dac2c382a98997d5771921af5aa… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index f642623b4eb..8917bf1c045 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1325,7 +1325,7 @@ make install-modules-all skip_modules="app_mono db_cassandra db_oracle \ FREERADIUS=1 \ %endif %if 0%{?rhel} >= 8 - PYTHON3=python3.9 \ + PYTHON3=python3.12 \ %endif WOLFSSL_INTERNAL=no \ group_include="kstandard kautheph kberkeley kcarrierroute \

1 0

git:master:86770d20: core: check for incompatible modes for bind_ipv6_link_local
by Daniel-Constantin Mierla 13 Sep '24

13 Sep '24

Module: kamailio Branch: master Commit: 86770d203bde6859284ec8862be66d78efd2715a URL: https://github.com/kamailio/kamailio/commit/86770d203bde6859284ec8862be66d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-13T08:50:35+02:00 core: check for incompatible modes for bind_ipv6_link_local - a few more debug messages --- Modified: src/core/cfg.y Modified: src/core/socket_info.c Modified: src/core/tcp_main.c Modified: src/core/udp_server.c --- Diff: https://github.com/kamailio/kamailio/commit/86770d203bde6859284ec8862be66d7… Patch: https://github.com/kamailio/kamailio/commit/86770d203bde6859284ec8862be66d7… --- diff --git a/src/core/cfg.y b/src/core/cfg.y index a6ad69b3148..ae1c9ec4b0b 100644 --- a/src/core/cfg.y +++ b/src/core/cfg.y @@ -999,7 +999,12 @@ assign_stm: ksr_ipv6_hex_style.len = strlen(ksr_ipv6_hex_style.s); } | IPV6_HEX_STYLE error { yyerror("string value expected"); } - | BIND_IPV6_LINK_LOCAL EQUAL NUMBER {sr_bind_ipv6_link_local = $3;} + | BIND_IPV6_LINK_LOCAL EQUAL NUMBER { + sr_bind_ipv6_link_local = $3; + if(sr_bind_ipv6_link_local && (KSR_IPV6_LINK_LOCAL_BIND|KSR_IPV6_LINK_LOCAL_SKIP)) { + yyerror("incompatible modes set"); + } + } | BIND_IPV6_LINK_LOCAL error { yyerror("number expected"); } | DST_BLST_INIT EQUAL NUMBER { IF_DST_BLOCKLIST(dst_blocklist_init=$3); } | DST_BLST_INIT error { yyerror("boolean value expected"); } diff --git a/src/core/socket_info.c b/src/core/socket_info.c index 4cf1693560a..446878d6b23 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1609,11 +1609,15 @@ static int build_iface_list(void) if(is_link_local) { if(sr_bind_ipv6_link_local & KSR_IPV6_LINK_LOCAL_SKIP) { /* skip - config option */ + LM_DBG("skip binding on '%s' (bind mode: %d)\n", + entry->addr, sr_bind_ipv6_link_local); pkg_free(entry); continue; } if(!(sr_bind_ipv6_link_local & KSR_IPV6_LINK_LOCAL_BIND)) { /* skip - link local addresses are not bindable without scope */ + LM_DBG("not set to on '%s' (bind mode: %d)\n", entry->addr, + sr_bind_ipv6_link_local); pkg_free(entry); continue; } diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index f5ca2d9ad55..9daaf1ce641 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -3148,7 +3148,8 @@ int tcp_init(struct socket_info *sock_info) if((addr->s.sa_family == AF_INET6) && (sr_bind_ipv6_link_local & KSR_IPV6_LINK_LOCAL_SKIP) && IN6_IS_ADDR_LINKLOCAL(&addr->sin6.sin6_addr)) { - LM_DBG("skip binding on %s\n", sock_info->address_str.s); + LM_DBG("skip binding on %s (bind mode: %d)\n", sock_info->address_str.s, + sr_bind_ipv6_link_local); return 0; } /* sock_info->proto=PROTO_TCP; */ @@ -3219,7 +3220,8 @@ int tcp_init(struct socket_info *sock_info) /* continue since this is not critical */ } if(sr_bind_ipv6_link_local & KSR_IPV6_LINK_LOCAL_BIND) { - LM_INFO("setting scope of %s\n", sock_info->address_str.s); + LM_INFO("setting scope of %s (bind mode: %d)\n", + sock_info->address_str.s, sr_bind_ipv6_link_local); addr->sin6.sin6_scope_id = ipv6_get_netif_scope(sock_info->address_str.s); } diff --git a/src/core/udp_server.c b/src/core/udp_server.c index ef7d2894d0d..476ff0fd9e9 100644 --- a/src/core/udp_server.c +++ b/src/core/udp_server.c @@ -418,7 +418,8 @@ int udp_init(struct socket_info *sock_info) if((addr->s.sa_family == AF_INET6) && (sr_bind_ipv6_link_local & KSR_IPV6_LINK_LOCAL_SKIP) && IN6_IS_ADDR_LINKLOCAL(&addr->sin6.sin6_addr)) { - LM_DBG("skip binding on %s\n", sock_info->address_str.s); + LM_DBG("skip binding on %s (mode: %d)\n", sock_info->address_str.s, + sr_bind_ipv6_link_local); return 0; } @@ -465,7 +466,8 @@ int udp_init(struct socket_info *sock_info) /* continue since this is not critical */ } if(sr_bind_ipv6_link_local & KSR_IPV6_LINK_LOCAL_BIND) { - LM_INFO("setting scope of %s\n", sock_info->address_str.s); + LM_INFO("setting scope of %s (bind mode: %d)\n", + sock_info->address_str.s, sr_bind_ipv6_link_local); addr->sin6.sin6_scope_id = ipv6_get_netif_scope(sock_info->address_str.s); }

1 0

git:master:fd95b950: core: socket info - set address also for link local items
by Daniel-Constantin Mierla 12 Sep '24

12 Sep '24

Module: kamailio Branch: master Commit: fd95b95035a7da088a94888132326d463191da83 URL: https://github.com/kamailio/kamailio/commit/fd95b95035a7da088a94888132326d4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-12T16:23:02+02:00 core: socket info - set address also for link local items - updates to log messages --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/fd95b95035a7da088a94888132326d4… Patch: https://github.com/kamailio/kamailio/commit/fd95b95035a7da088a94888132326d4… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index 120f99b1e49..4cf1693560a 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1574,24 +1574,24 @@ static int build_iface_list(void) for(; RTA_OK(rtap, rtl); rtap = RTA_NEXT(rtap, rtl)) { switch(rtap->rta_type) { case IFA_ADDRESS: + inet_ntop(families[i], RTA_DATA(rtap), entry->addr, + MAX_IF_LEN); if((*(int *)RTA_DATA(rtap)) == htons(0xfe80)) { - LM_DBG("Link Local Address, ignoring ...\n"); + LM_DBG("Link Local Address is '%s'\n", entry->addr); is_link_local = 1; - break; } - inet_ntop(families[i], RTA_DATA(rtap), entry->addr, - MAX_IF_LEN); - LM_DBG("iface <IFA_ADDRESS> addr is %s\n", + LM_DBG("iface <IFA_ADDRESS> address is '%s'\n", entry->addr); break; case IFA_LOCAL: + inet_ntop(families[i], RTA_DATA(rtap), entry->addr, + MAX_IF_LEN); if((*(int *)RTA_DATA(rtap)) == htons(0xfe80)) { - LM_DBG("Link Local Address, ignoring ...\n"); + LM_DBG("Link Local Address is '%s'\n", entry->addr); is_link_local = 1; } - inet_ntop(families[i], RTA_DATA(rtap), entry->addr, - MAX_IF_LEN); - LM_DBG("iface <IFA_LOCAL> addr is %s\n", entry->addr); + LM_DBG("iface <IFA_LOCAL> address is '%s'\n", + entry->addr); break; case IFA_LABEL: LM_DBG("iface name is %s\n", (char *)RTA_DATA(rtap)); @@ -1691,7 +1691,7 @@ int add_interfaces_via_netlink(char *if_name, int family, unsigned short port, if(family && family == tmp->family) { /* check if loopback */ if(ifaces[i].flags & IFF_LOOPBACK) { - LM_DBG("INTERFACE '%s' is loopback", ifaces[i].name); + LM_DBG("INTERFACE '%s' is loopback\n", ifaces[i].name); flags |= SI_IS_LO; } /* save the info */

1 0

git:master:bd4c068e: core: check for items with emtpy address when discovering the network interfaces
by Daniel-Constantin Mierla 12 Sep '24

12 Sep '24

Module: kamailio Branch: master Commit: bd4c068ee9c8e18dc76f8154d3fa4c438972b79c URL: https://github.com/kamailio/kamailio/commit/bd4c068ee9c8e18dc76f8154d3fa4c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-12T10:34:55+02:00 core: check for items with emtpy address when discovering the network interfaces - it may be returned on some OSes, preventing to start --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/bd4c068ee9c8e18dc76f8154d3fa4c4… Patch: https://github.com/kamailio/kamailio/commit/bd4c068ee9c8e18dc76f8154d3fa4c4… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index a181e43dad8..120f99b1e49 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -207,6 +207,10 @@ static int init_addr_info(struct addr_info *a, char *name, enum si_flags flags) memset(a, 0, sizeof(*a)); a->name.len = strlen(name); + if(a->name.len <= 0) { + LM_ERR("invalid or empty name value\n"); + return -1; + } a->name.s = pkg_malloc(a->name.len + 1); /* include \0 */ if(a->name.s == 0) goto error; @@ -224,16 +228,15 @@ static inline struct addr_info *new_addr_info(char *name, enum si_flags gf) { struct addr_info *al; - al = pkg_malloc(sizeof(*al)); - if(al == 0) + al = pkg_mallocxz(sizeof(*al)); + if(al == 0) { + PKG_MEM_ERROR; goto error; - al->next = 0; - al->prev = 0; + } if(init_addr_info(al, name, gf) != 0) goto error; return al; error: - PKG_MEM_ERROR; if(al) { if(al->name.s) pkg_free(al->name.s); @@ -1677,13 +1680,18 @@ int add_interfaces_via_netlink(char *if_name, int family, unsigned short port, //if(! (ifaces[i].flags & IFF_UP) ) continue; for(tmp = ifaces[i].addresses; tmp; tmp = tmp->next) { - LM_DBG("in add_iface_via_netlink Name %s Address %s\n", + LM_DBG("in add_iface_via_netlink Name '%s' Address '%s'\n", ifaces[i].name, tmp->addr); + if(strlen(tmp->addr) == 0) { + LM_DBG("interface '%s' - skip item with empty address\n", + ifaces[i].name); + continue; + } /* match family */ if(family && family == tmp->family) { /* check if loopback */ if(ifaces[i].flags & IFF_LOOPBACK) { - LM_DBG("INTERFACE %s is loopback", ifaces[i].name); + LM_DBG("INTERFACE '%s' is loopback", ifaces[i].name); flags |= SI_IS_LO; } /* save the info */

1 0

git:master:15823c3e: core: log message about interface flags made info
by Daniel-Constantin Mierla 12 Sep '24

12 Sep '24

Module: kamailio Branch: master Commit: 15823c3eda3a332d22d9132a873d755aa024892f URL: https://github.com/kamailio/kamailio/commit/15823c3eda3a332d22d9132a873d755… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-12T10:10:33+02:00 core: log message about interface flags made info - small updates to a couple of error messages --- Modified: src/core/resolve.c Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/15823c3eda3a332d22d9132a873d755… Patch: https://github.com/kamailio/kamailio/commit/15823c3eda3a332d22d9132a873d755… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index da247952fd9..19b05db90ff 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -1792,7 +1792,8 @@ int str2ipbuf(str *st, ip_addr_t *ipb) /* just in case that e.g. the VIA parser get confused */ if(unlikely(!st->s || st->len <= 0)) { - LM_ERR("invalid name, no conversion to IP address possible\n"); + LM_ERR("invalid name (%p,%d), no conversion to IP address possible\n", + st->s, st->len); return -1; } s = (unsigned char *)st->s; @@ -1902,7 +1903,8 @@ int str2ip6buf(str *st, ip_addr_t *ipb) /* just in case that e.g. the VIA parser get confused */ if(unlikely(!st->s || st->len <= 0)) { - LM_ERR("invalid name, no conversion to IP address possible\n"); + LM_ERR("invalid name (%p,%d), no conversion to IP address possible\n", + st->s, st->len); return -1; } /* init */ diff --git a/src/core/socket_info.c b/src/core/socket_info.c index a2b3c05c641..a181e43dad8 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1443,7 +1443,7 @@ static int get_flags(int family) if(nlp->nlmsg_len < NLMSG_LENGTH(sizeof(ifi))) goto error; - LM_ERR("Interface with index %d has flags %d\n", ifi->ifi_index, + LM_INFO("Interface with index %d has flags %d\n", ifi->ifi_index, ifi->ifi_flags); if(ifaces == NULL) { LM_ERR("get_flags must not be called on empty interface list"); @@ -1769,7 +1769,7 @@ static int fix_hostname(str *name, struct ip_addr *address, str *address_str, /* get "official hostnames", all the aliases etc. */ he = resolvehost(name->s); if(he == 0) { - LM_ERR("could not resolve %s\n", name->s); + LM_ERR("could not resolve '%s'\n", name->s); goto error; } /* check if we got the official name */

1 0

[kamaillio/kamaillio] Option to create a domain via RPC
by auke＠noppe.nl 12 Sep '24

12 Sep '24

Hi, We want our multi-tenant system to integrate with Kamaillio, and we are trying to use json-rpc to interact with Kamaillio. However, it seems that it is not possible to create a domain using a rpc call, according to the docs it's only possible to issue a reload or dump command. Is it possible to create a domain remotely, preferably using json-RPC? Regards, Auke Noppe

1 0

Service crashed for IMS VoLTE MT call
by Ken Kam 11 Sep '24

11 Sep '24

Dear Kamailio community, ### Description Recently, we are testing IMS VoLTE MT call using a Kamailio release 5.8.2, however the Kamailio service is crashed for several times during handling MT IMS SIP Call. We would like to ask if any idea on why getting the "abort error" in Kamailio (as shown in attached core dump) and also how to solve the issue. Thanks Ken

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
18
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2024