sr-dev September 2024

sr-dev@lists.kamailio.org

15 participants
174 discussions

git:5.8:60423dbe: http_client: clang-format
by Daniel-Constantin Mierla 04 Sep '24

04 Sep '24

Module: kamailio Branch: 5.8 Commit: 60423dbe90d3603fa98e0aaf161b7bef7f8b2a23 URL: https://github.com/kamailio/kamailio/commit/60423dbe90d3603fa98e0aaf161b7be… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-04T09:38:48+02:00 http_client: clang-format (cherry picked from commit fde8bd21dca9c8b45b314b04b21f742363f028b1) --- Modified: src/modules/http_client/curlcon.c --- Diff: https://github.com/kamailio/kamailio/commit/60423dbe90d3603fa98e0aaf161b7be… Patch: https://github.com/kamailio/kamailio/commit/60423dbe90d3603fa98e0aaf161b7be… --- diff --git a/src/modules/http_client/curlcon.c b/src/modules/http_client/curlcon.c index 2b5a69fcddd..16dfb6cc09b 100644 --- a/src/modules/http_client/curlcon.c +++ b/src/modules/http_client/curlcon.c @@ -861,17 +861,16 @@ void curl_conn_list_fixup(void) { curl_con_t *cc; cc = _curl_con_root; - while (cc) { - if (!(timeout_mode == 1 || timeout_mode == 2)) { + while(cc) { + if(!(timeout_mode == 1 || timeout_mode == 2)) { /* Timeout is disabled globally. Set timeout to 0 for all connections to reflect this. */ - if (cc->timeout > 0) { + if(cc->timeout > 0) { LM_WARN("curl connection [%.*s]: configured timeout is ignored " - "because timeouts are disabled (timeout_mode)\n", - cc->name.len, cc->name.s); + "because timeouts are disabled (timeout_mode)\n", + cc->name.len, cc->name.s); cc->timeout = 0; } - } - else if (cc->timeout == 0) { + } else if(cc->timeout == 0) { /* Timeout is not configured for that connection. * Use as default global connection_timeout (which can be seconds or milliseconds). */

1 0

git:5.8:6ee9bc2f: sca: remove function name from log message
by Daniel-Constantin Mierla 04 Sep '24

04 Sep '24

Module: kamailio Branch: 5.8 Commit: 6ee9bc2f34f9b20b576510e2e81a96bbfcc5a3be URL: https://github.com/kamailio/kamailio/commit/6ee9bc2f34f9b20b576510e2e81a96b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-04T09:38:48+02:00 sca: remove function name from log message (cherry picked from commit 4a57efa0f7ed2560420e10d0fe70037a14a12c12) --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/6ee9bc2f34f9b20b576510e2e81a96b… Patch: https://github.com/kamailio/kamailio/commit/6ee9bc2f34f9b20b576510e2e81a96b… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index 895141e1e25..9e212f01e2c 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -1306,8 +1306,7 @@ int ki_sca_handle_subscribe(sip_msg_t *msg) released = sca_appearance_owner_release_all( &req_sub.target_aor, &req_sub.subscriber); if(released) { - LM_INFO("sca_handle_subscribe: released %d appearances " - "for subscriber %.*s\n", + LM_INFO("released %d appearances for subscriber %.*s\n", released, STR_FMT(&req_sub.subscriber)); } }

1 0

Re: [kamailio/kamailio] tls: extend startup information for OpenSSL library (0420809)
by Daniel-Constantin Mierla 04 Sep '24

04 Sep '24

A modparam would be useful in the context of people willing to get more and more details (e.g., available providers, cyphers, ... or whatever else can be extracted from the lib). Otherwise, fine for me. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/04208090638a639cdf03fafb1df161c… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/04208090638a639cdf03fafb1df161cd71f74c7e/146217938(a)github.com>

1 0

git:5.8:d86350ea: pkg/kamailio/deb: set version to 5.8.3
by Victor Seva 04 Sep '24

04 Sep '24

Module: kamailio Branch: 5.8 Commit: d86350ea9078b89677323ac86053b0f37b7d1722 URL: https://github.com/kamailio/kamailio/commit/d86350ea9078b89677323ac86053b0f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-09-04T09:30:26+02:00 pkg/kamailio/deb: set version to 5.8.3 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/d86350ea9078b89677323ac86053b0f… Patch: https://github.com/kamailio/kamailio/commit/d86350ea9078b89677323ac86053b0f…

1 0

Re: [kamailio/kamailio] tls: extend startup information for OpenSSL library (0420809)
by Henning Westerholt 04 Sep '24

04 Sep '24

Sure, I can also output the "number" version, will add another commit. About the FIPS, other projects do it in a similar way (e.g. haproxy). But one simple change would be to have LM_INFO if FIPS is in fact enabled (this is rarely done), and DBG for FIPS mode not enabled, without the need for a new module parameter. Will change it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/04208090638a639cdf03fafb1df161c… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/04208090638a639cdf03fafb1df161cd71f74c7e/146217533(a)github.com>

1 0

Re: [kamailio/kamailio] tls: extend startup information for OpenSSL library (0420809)
by Daniel-Constantin Mierla 04 Sep '24

04 Sep '24

I would prefer to keep logging the OPENSSL_VERSION_NUMBER even for OPENSSL_VERSION_NUMBER >= 0x030000000L, it is something easy to extract by regex/grepping. In addition, the detailed version info can be printed. I am not sure if FIPS logging is commonly used and relevant to be INFO, there will be questions when not enabled. IMO, DEBUG should do it here or a modparam (e.g., `libinfo`) can be introduced to dump exhaustive details about ssl library at startup (e.g., the version text, fips mode, ...). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/04208090638a639cdf03fafb1df161c… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/04208090638a639cdf03fafb1df161cd71f74c7e/146217391(a)github.com>

1 0

Re: [kamailio/kamailio] tls: replace em dash with hyphen (reported from Bastian Triller, GH #3966) (228c598)
by Henning Westerholt 04 Sep '24

04 Sep '24

I found and commited the mistake already before I saw the PR, then I amended the commit message to have it linked to it. I will split it in two lines then if required in the future, sure. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/228c59851878fed15d8b34e43938c28… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/228c59851878fed15d8b34e43938c281729e518d/146217108(a)github.com>

1 0

Re: [kamailio/kamailio] tls: replace em dash with hyphen (reported from Bastian Triller, GH #3966) (228c598)
by Daniel-Constantin Mierla 04 Sep '24

04 Sep '24

Credits and reference to issues or PRs have to be done in the description content of the commit message, not in the first line, as per contributing guidelines. Also, as I could see if I haven't missed something, in this case the PR was proposing exactly the same change, with proper commit message, so it could have just been merged directly, not doing a separate commit and reference the PR. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/228c59851878fed15d8b34e43938c28… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/228c59851878fed15d8b34e43938c281729e518d/146216488(a)github.com>

1 0

[kamailio/kamailio] tls: Replace em dash with hyphen (PR #3966)
by Bastian Triller 04 Sep '24

04 Sep '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3966 -- Commit Summary -- * tls: Replace em dash with hyphen -- File Changes -- M src/modules/tls/tls_mod.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3966.patch https://github.com/kamailio/kamailio/pull/3966.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3966 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3966(a)github.com>

2 2

git:master:228c5985: tls: replace em dash with hyphen (reported from Bastian Triller, GH #3966)
by Henning Westerholt 04 Sep '24

04 Sep '24

Module: kamailio Branch: master Commit: 228c59851878fed15d8b34e43938c281729e518d URL: https://github.com/kamailio/kamailio/commit/228c59851878fed15d8b34e43938c28… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-04T06:53:31Z tls: replace em dash with hyphen (reported from Bastian Triller, GH #3966) --- Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/228c59851878fed15d8b34e43938c28… Patch: https://github.com/kamailio/kamailio/commit/228c59851878fed15d8b34e43938c28… --- diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index f46d4aaddfd..84d9ff33412 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -508,7 +508,7 @@ static int mod_init(void) LM_INFO("OpenSSL supports Diffie-Hellman\n"); #endif #ifndef OPENSSL_NO_ECDH - LM_INFO("OpenSSL supports Elliptic-curve Diffie��Hellman\n"); + LM_INFO("OpenSSL supports Elliptic-curve Diffie-Hellman\n"); #endif if(sr_tls_event_callback.s == NULL || sr_tls_event_callback.len <= 0) { tls_lookup_event_routes();

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2024