<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
##### **Summary**
This update introduces new functionality to the `secfilter` module, enabling the removal of entries from both the Blacklist and Whitelist. It also includes automatic detection and removal of duplicate values from these lists.
##### **Details**
* Users can now remove specific entries from the Blacklist or Whitelist based on type (e.g., IP, domain, user) and a given value.
* Supports removal of single or multiple matching entries in one operation.
##### **Benefits**
- Improves the usability and flexibility of the `secfilter` module by allowing fine-grained control over list management.
- Ensures that the Blacklist and Whitelist are kept clean and free from redundant entries.
- Enhances performance by reducing unnecessary duplication in the lists.
##### Testing
This feature was tested using `kmcmd` commands in various scenarios:
- Removing the **first element** in the list.
- Removing an element from the **middle** of the list.
- Removing the **last element** in the list.
- Removing **all matching elements** in the list.
In all cases, the commands worked correctly, and the lists were updated and cleaned as expected.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4089
-- Commit Summary --
* secfilter: support remove rule in Whitelist and Blacklist
-- File Changes --
M src/modules/secfilter/secfilter.c (8)
M src/modules/secfilter/secfilter.h (3)
M src/modules/secfilter/secfilter_db.c (106)
M src/modules/secfilter/secfilter_rpc.c (95)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4089.patchhttps://github.com/kamailio/kamailio/pull/4089.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4089
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4089(a)github.com>
### Description
`secf_check_sqli_all();` block requests when a single quote is present in From name :
```
From: "O'Reilly" <sip:100@example.net>;tag=abcd
```
Since single quotes are frequent in names.
It makes it difficult to use this function.
### Possible Solutions
A solution would be to skip single quote check in From name.
I'll write the PR if you are OK with this solution
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3984
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3984(a)github.com>
**Description**
The `secfilter` module in `kamcmd` currently allows duplicate entries when adding values to certain lists (e.g., blacklists, whitelists). This can lead to unexpected behavior and potential inconsistencies. Could you clarify the reason behind accepting duplicate values?
Recently, I submitted a pull request to add delete commands to the `secfilter` module #4089. When a user, for example, executes:
`kamcmd secfilter.del_bl user 1005`
I iterate through the entire list to ensure all occurrences of `1005` are removed, as I realized duplicates might exist. This is inefficient and could be avoided by preventing duplicates in the first place.
**Proposed Solutions**
1. **Prevent Duplicates in Existing `add` Commands:**
* I can modify existing `add` commands to directly prevent the addition of duplicate values. This would simplify future operations and improve performance.
2. **Introduce New `add_unique` Commands:**
* I can maintain the current `add` commands for backward compatibility.
* I can introduce new `add_unique` commands (e.g., `secfilter.add_bl_unique`) that explicitly reject duplicate entries.
**Recommendation**
I recommend implementing the first solution (preventing duplicates in existing `add` commands) as it provides the most straightforward and efficient approach.
**Further Considerations**
* Consider adding a check for duplicates during the `add` operation and returning an appropriate error message if a duplicate is encountered.
* Document the behavior of duplicate values in the `secfilter` module's documentation.
**I would appreciate your feedback and guidance on the best course of action.**
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4091
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4091(a)github.com>
Opening this generic issue to track issues when trying to switch deb package generation to cmake:
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4053
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4053(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
I have run in to an issue when sending diameter requests using the ims_diameter_server
module. Shared memory keeps increasing and are not being freed until restart of kamailio.
This leads to all shared memory is being used and no more are able to be allocated.
This only happens when the request is sent synchronously. When sent asynchronously shared
memory is being freed as far as I can see.
Following functions have been used for sending requests.
diameter_request([peer], appid, commandcode, message)
diameter_request_async([peer], appid, commandcode, message)
### Troubleshooting
Sent a bunch of diameter requests and verified that shared memory for the following functions are not freed.
do_receive(600):
AAATranslateMessage(500):
AAACreateAVP(137):
#### Reproduction
It's possible to reproduce by sending sync diameter request and verify shared memory.
Example of diameter request block
```
route[CHECK_LOCATION] {
diameter_request("hss.ims.test.local", "16777217", "306",
"[ " +
"{ \"avpCode\":260, \"vendorId\":0, \"Flags\":64,
\"list\":[ { \"avpCode\":266, \"vendorId\":0,
\"Flags\":64, \"int32\":10415 }, { \"avpCode\":258,
\"vendorId\":0, \"Flags\":64, \"int32\":16777217 } ] },
" +
"{ \"avpCode\":277, \"vendorId\":0, \"Flags\":64,
\"int32\":1 }, " +
"{ \"avpCode\":283, \"vendorId\":0, \"Flags\":64,
\"string\":\"ims.test.local\"}, " +
"{ \"avpCode\":706, \"vendorId\":10415,
\"Flags\":192, \"int32\":0 }, " +
"{ \"avpCode\":700, \"vendorId\":10415,
\"Flags\":192, \"list\": [ { \"avpCode\":601,
\"vendorId\":10415, \"Flags\":192,
\"string\":\"tel:" + $fU + "\" }]}, " +
"{ \"avpCode\":707, \"vendorId\":10415,
\"Flags\":192, \"int32\":0 }, " +
"{ \"avpCode\":703, \"vendorId\":10415,
\"Flags\":192, \"int32\":14 } ]");
xlog("L_INFO", "Sent Diameter request");
}
```
Stats
cdp:replies_received = 343310
shmem:fragments = 142
shmem:free_size = 1221489992
shmem:max_used_size = 948242168
shmem:real_used_size = 925993656
shmem:total_size = 2147483648
shmem:used_size = 558205656
kamcmd mod.stats cdp shm
do_receive(600): 256245808
AAATranslateMessage(500): 64420712
AAACreateAVP(137): 218100320
Total: 538774000
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.7.4 (x86_64/linux) dc393e
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: dc393e
compiled on 13:56:27 Feb 27 2024 with gcc 8.5.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
Linux bmatkamas1 4.18.0-553.16.1.el8_10.x86_64 #1 SMP Thu Aug 1 04:16:12 EDT 2024 x86_64 x86_64 x86_64 GNU/Linux
Red Hat Enterprise Linux release 8.10 (Ootpa)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4116
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4116(a)github.com>
jrozhon created an issue (kamailio/kamailio#4154)
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
I have Kamailio configured to act as a gateway between SIP and XMPP in my lab setup. I only have module configured, no routing is implemented yet. When handshake with XMPP server (Prosody) occurs, Kamailio crashes.
### Troubleshooting
I cannot use newer version of kamailio as it crashes because of presence module. Older versions up to 5.5.7 behave the same.
If i get backtrace right crash is caused by a problem with parsing the incoming xml, but it seems fine to me.
#### Reproduction
Have prosody xmpp server configured to accept component connection from kamailio.
In kamailio have xmpp.so module loaded with following parameters set:
modparam("xmpp", "backend", "component")
modparam("xmpp", "gateway_domain", "kamailio-dns")
modparam("xmpp", "xmpp_domain", "xmpp-dns")
modparam("xmpp", "xmpp_host", "xmpp-dns")
modparam("xmpp", "xmpp_port", 5347)
modparam("xmpp", "xmpp_password", "shared-password")
#### Debugging Data
```
(gdb) bt full
#0 _xode_put_expatattribs (owner=0x13c5480, atts=0x13be6d0) at xstream.c:35
i = 10
#1 0x00007f77df410211 in _xode_stream_startElement (xs=0x13c07f0, name=0x13c0170 "stream:stream", atts=0x13be6d0) at xstream.c:56
p = 0x13be110
#2 0x00007f77df3c2934 in doContent () from /lib64/libexpat.so.1
No symbol table info available.
#3 0x00007f77df3c0fde in doProlog () from /lib64/libexpat.so.1
No symbol table info available.
#4 0x00007f77df3c1eac in prologProcessor () from /lib64/libexpat.so.1
No symbol table info available.
#5 0x00007f77df3b958f in callProcessor () from /lib64/libexpat.so.1
No symbol table info available.
#6 0x00007f77df3c60a7 in XML_ParseBuffer () from /lib64/libexpat.so.1
No symbol table info available.
#7 0x00007f77df410594 in xode_stream_eat (xs=0x13c07f0,
buff=0x7f77df4185e0 <buf> "<?xml version='1.0'?><stream:stream xmlns:stream='http://etherx.jabber.org/streams' xmlns='jabber:component:accept' id='09b989ba-0ba4-4b58-ad8e-53b07fe2f13a' from='sip.xmpp.osk3.lab' xml:lang='en'>", len=197) at xstream.c:176
err = 0x4000000 <error: Cannot access memory at address 0x4000000>
xerr = 0x7f77e4d06ed0 <syslog>
maxerr = "maximum node size reached"
deeperr = "maximum node depth reached"
#8 0x00007f77df404955 in xmpp_component_child_process (data_pipe=9) at xmpp_component.c:237
buf = 0x7f77df4185e0 <buf> "<?xml version='1.0'?><stream:stream xmlns:stream='http://etherx.jabber.org/streams' xmlns='jabber:component:accept' id='09b989ba-0ba4-4b58-ad8e-53b07fe2f13a' from='sip.xmpp.osk3.lab' xml:lang='en'>"
fd = 5
maxfd = 9
rv = 1
fdset = {__fds_bits = {32, 0 <repeats 15 times>}}
pool = 0x13bae50
stream = 0x13c07f0
priv = {fd = 5, running = 1}
cmd = 0xa09250 <main_state+16>
__func__ = "xmpp_component_child_process"
#9 0x00007f77df3fafef in xmpp_process (rank=1) at xmpp.c:280
__func__ = "xmpp_process"
#10 0x00007f77df3fac4b in child_init (rank=0) at xmpp.c:263
pid = 0
#11 0x0000000000650a0c in init_mod_child (m=0x7f77e44b8f90, rank=0) at core/sr_module.c:911
ret = 0
__func__ = "init_mod_child"
#12 0x0000000000650656 in init_mod_child (m=0x7f77e44b93e0, rank=0) at core/sr_module.c:903
ret = 0
__func__ = "init_mod_child"
#13 0x0000000000650656 in init_mod_child (m=0x7f77e44b9b78, rank=0) at core/sr_module.c:903
ret = 0
__func__ = "init_mod_child"
#14 0x0000000000650656 in init_mod_child (m=0x7f77e44ba000, rank=0) at core/sr_module.c:903
ret = 0
__func__ = "init_mod_child"
#15 0x0000000000650656 in init_mod_child (m=0x7f77e44bafa0, rank=0) at core/sr_module.c:903
ret = 32
__func__ = "init_mod_child"
#16 0x0000000000650656 in init_mod_child (m=0x7f77e44bb498, rank=0) at core/sr_module.c:903
ret = 0
__func__ = "init_mod_child"
#17 0x0000000000650656 in init_mod_child (m=0x7f77e44bbe58, rank=0) at core/sr_module.c:903
ret = 0
__func__ = "init_mod_child"
#18 0x0000000000650656 in init_mod_child (m=0x7f77e44bc370, rank=0) at core/sr_module.c:903
ret = 1
__func__ = "init_mod_child"
#19 0x0000000000651207 in init_child (rank=0) at core/sr_module.c:990
ret = -464031792
type = 0x884ffb "PROC_MAIN"
__func__ = "init_child"
#20 0x000000000042fb48 in main_loop () at main.c:1929
i = 8
pid = 450007
si = 0x0
si_desc = "udp receiver child=7 sock=kamailio.osk3.lab:5060\000K\207\362\377\177\000\000\000\000\000\000\000\000\000\000PQ\207\362\377\177\000\000\263\266\204\000\000\000\000\0000\277K\344w\177\000\000\320n\320\344w\177\000\000\000\000\000\004\000\000\000\000jo\320\344w\177\000\0000\000\000\0000\000\000\000\bM\207\362\377\177\000"
nrprocs = 8
woneinit = 1
__func__ = "main_loop"
#21 0x0000000000439d03 in main (argc=11, argv=0x7ffff2875268) at main.c:3213
cfg_stream = 0x130b380
c = -1
r = 0
tmp = 0x7ffff2876ea2 ""
tmp_len = 0
port = 0
proto = 0
ahost = 0x0
aport = 0
options = 0x8373a8 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:"
ret = -1
seed = 863415900
rfd = 4
debug_save = 0
debug_flag = 0
dont_fork_cnt = 2
n_lst = 0x40
p = 0x1000000 <error: Cannot access memory at address 0x1000000>
st = {st_dev = 23, st_ino = 1015, st_nlink = 2, st_mode = 16832, st_uid = 977, st_gid = 976, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096,
st_blocks = 0, st_atim = {tv_sec = 1739449861, tv_nsec = 919999685}, st_mtim = {tv_sec = 1740224132, tv_nsec = 607723775}, st_ctim = {tv_sec = 1740224132,
tv_nsec = 607723775}, __glibc_reserved = {0, 0, 0}}
tbuf = "9M\t\345w\177\000\000\210\n\006\345w\177\000\000\340N\207\362\377\177\000\000\006\000\000\000\000\000\000\000\b\367\005\345w\177\000\000\006\000\000\000\020\000\000\0000Z\t\345w\177\000\000\325\331\006\345w\177\000\000\000\000\000\000\000\000\000\000\240\354\006\345w\177\000\000\370\377\300\344w\177\000\000\000:\005\345w\177\000\000\000\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\260N\207\362\377\177\000\000\240\n\006\345w\177\000\000\240\n\006\345w\177\000\000\000\000\000\000\000\000\000\000`H\005\345w\177\000\000\260N\207\362\377\177\000\000\200e\t\345w\177\000\000\000\360\005\345w\177\000\000\342\373\005\345w\177\000\000v\244\006\345w\177\000\000\334#\300\344w\177\000\000"...
option_index = 12
long_options = {{name = 0x839a46 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x8344f4 "version", has_arg = 0, flag = 0x0, val = 118}, {
name = 0x839a4b "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x839a51 "subst", has_arg = 1, flag = 0x0, val = 1025}, {name = 0x839a57 "substdef",
has_arg = 1, flag = 0x0, val = 1026}, {name = 0x839a60 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0x839a6a "server-id", has_arg = 1,
flag = 0x0, val = 1028}, {name = 0x839a74 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0x839a7f "modparam", has_arg = 1, flag = 0x0,
val = 1030}, {name = 0x839a88 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, {name = 0x839a93 "debug", has_arg = 1, flag = 0x0, val = 1032}, {
name = 0x839a99 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0x839aa3 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {
name = 0x839aaa "all-errors", has_arg = 0, flag = 0x0, val = 1035}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}}
__func__ = "main"
```
```
(gdb) info locals
i = 10
```
```
(gdb) list
30 static void _xode_put_expatattribs(xode owner, const char **atts)
31 {
32 int i = 0;
33 if(atts == NULL)
34 return;
35 while(*(atts[i]) != '\0') {
36 xode_put_attrib(owner, atts[i], atts[i + 1]);
37 i += 2;
38 }
39 }
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
Feb 22 11:39:10 kamailio /usr/sbin/kamailio[445061]: INFO: tls [tls_domain.c:418]: ksr_tls_fill_missing(): TLSc<default>: verify_client=0
Feb 22 11:39:10 kamailio /usr/sbin/kamailio[445061]: INFO: tls [tls_domain.c:781]: set_verification(): TLSc<default>: Server MAY present invalid certificate
Feb 22 11:39:10 kamailio /usr/sbin/kamailio[445109]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 28
Feb 22 11:39:10 kamailio /usr/sbin/kamailio[445066]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 3
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445107]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 15
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445065]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 2
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445088]: INFO: ctl [io_listener.c:214]: io_listen_loop(): using epoll_lt io watch method (config)
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445070]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 4
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445064]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 1
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445074]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 7
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445076]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 8
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445096]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 9
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445085]: INFO: jsonrpcs [jsonrpcs_sock.c:471]: jsonrpc_dgram_process(): a new child 0/445085
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445072]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 6
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445108]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 16
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445061]: ALERT: <core> [main.c:792]: handle_sigs(): child process 445090 exited by a signal 11
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445061]: ALERT: <core> [main.c:796]: handle_sigs(): core was generated
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445061]: INFO: <core> [main.c:819]: handle_sigs(): terminating due to SIGCHLD
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445071]: INFO: tls [tls_mod.c:576]: mod_child(): OpenSSL loaded private keys in child: 5
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445066]: INFO: <core> [main.c:875]: sig_usr(): signal 15 received
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445065]: INFO: <core> [main.c:875]: sig_usr(): signal 15 received
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445076]: INFO: <core> [main.c:875]: sig_usr(): signal 15 received
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445064]: INFO: <core> [main.c:875]: sig_usr(): signal 15 received
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445083]: INFO: <core> [main.c:875]: sig_usr(): signal 15 received
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445089]: INFO: <core> [main.c:875]: sig_usr(): signal 15 received
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445081]: INFO: <core> [main.c:875]: sig_usr(): signal 15 received
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445109]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 25
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445109]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 17
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445109]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 15
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445109]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 8
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445088]: INFO: <core> [main.c:875]: sig_usr(): signal 15 received
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445109]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 26
Feb 22 11:39:11 kamailio /usr/sbin/kamailio[445077]: INFO: <core> [main.c:875]: sig_usr(): signal 15 received
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
no sip traffic, just simple xml exchanged
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.7.5 (x86_64/linux) 58499a
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 58499a
compiled on 00:00:00 Sep 13 2022 with gcc 11.4.1
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
RHEL 9
Linux kamailio 5.14.0-503.15.1.el9_5.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Nov 14 15:45:31 EST 2024 x86_64 x86_64 x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4154
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4154(a)github.com>
### Description
if multiple sip websocket clients are subscribed to some UA and one of the watchers suddenly disappears (e.g. the web page is reloaded), then no NOTIFY is ever sent after issuing a `pres_refresh_watchers()`.
The following error is logged:
```
WARNING: <core> [core/msg_translator.c:3007]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found
ERROR: tm [t_msgbuilder.c:1423]: assemble_via(): via building failed
ERROR: tm [t_msgbuilder.c:1614]: build_uac_req(): error while assembling Via
ERROR: tm [uac.c:552]: t_uac_prepare(): Error while building message
ERROR: presence [notify.c:1734]: send_notify_request(): in function tm t_request_within()
ERROR: presence [notify.c:1829]: notify(): sending Notify not successful
ERROR: presence [notify.c:1585]: query_db_notify(): Could not send notify for [event]=dialog
ERROR: presence [presence.c:739]: pres_refresh_watchers(): sending Notify requests
```
### Troubleshooting
when the client disconnects, the old watcher is not removed from the active_watchers table, instead it coexists with the new one, but the stale connection causes the error above when sending the notify, and then all of the following watchers (even the valid ones) are skipped too.
Looking at the logs, the valid watchers are not notified because the while loop [here](https://github.com/kamailio/kamailio/blob/b96bc11a54f11ec688429c057bf… is skipped because of the `goto done` line in case of errors, which happens because it fails to build the via header for the message relevant to the stale websocket connection.
By breaking out of the while loop, the remaining subs in the `subs_array` are skipped.
#### Reproduction
Just subscribe to a sip client using a websocket-based phone, then abruptly disconnect it (e.g. by reloading the web page) and then issue a `pres_refresh_watchers()` to make it generate a notify.
#### Debugging Data
#### Log Messages
#### SIP Traffic
### Possible Solutions
I tried to use the "websocket:closed" route to purge stale connections, but to my knowledge there are no APIs to clean invalid watchers.
A possible solution could be to automatically remove the watchers on disconnection and maybe skip the invalid ones without exiting from the refresh loop
### Additional Information
kamailio 5.8.2
* **Operating System**:
Rocky Linux 9
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4118
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4118(a)github.com>
### Description
Hi!
We are in the progress of upgrading from Kamailio 5.5 to 5.8. During our testing we have noticed a new error being reported from Kamailio. We don’t see any other errors following it.
```jsx
/usr/sbin/kamailio[201]: CRITICAL: <core> [core/tcp_main.c:5544]: tcp_timer_check_connections(): message processing timeout on connection id: 67896 (state: 3) - closing
```
It does seem to be [new code](https://github.com/kamailio/kamailio/blob/master/src/core/tcp_main.c#… in Kamailio reporting this issue.
Given that this is a fairly expected thing, cleaning up a connection which receives no traffic within the given time, is there a need for it to be reported on CRITICAL?
I’d also expect it to be caught by
```
event_route[tcp:timeout] {
xlog("L_INFO","connection $conid timeouts (unanswered keepalives)");
}
```
given that [the description](https://www.kamailio.org/docs/modules/stable/modules/tcpops.ht… of this one is `Called for connection timeouts (unanswered keepalives).`.
### Troubleshooting
We don't have any way to reproduce it, we are still investigating it to figure out the cause. It happens around every 2 hours, so we think there might some some scheduled test or job running in our test system causing this.
### Additional Information
* **Kamailio Version** - 5.8.3
* **Operating System**: Debian 12 AMI from the AWS Marketplace.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3995
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3995(a)github.com>