ChristianBergerSipgate created an issue (kamailio/kamailio#4168)
We think we have found a potential bug in the path module.
When we call `add_path_received()` we get the following for WSS connections:
`Path: <sip:217.10.77.242;lr;received=sip:217.10.69.93:42612%3Btransport%3Dws>`
We think there should be a `transport%3Dwss` appended instead of ws.
We have looked a bit into the code and think that this is caused by the following definition:
```
in modules/path/path.c
const static char *proto_strings[] = {
[PROTO_TCP] = "%3Btransport%3Dtcp",
[PROTO_TLS] = "%3Btransport%3Dtls",
[PROTO_SCTP] = "%3Btransport%3Dsctp",
[PROTO_WS] = "%3Btransport%3Dws",
[PROTO_WSS] = "%3Btransport%3Dws",
};
```
We think that on the last line, it should read
` [PROTO_WSS] = "%3Btransport%3Dwss",`
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4168
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4168(a)github.com>
ovedeneev created an issue (kamailio/kamailio#4187)
### Description
[tcp_send_timeout](https://www.kamailio.org/wikidocs/cookbooks/5.8.x/core/#t… option does not apply for outbound connections.
#### Reproduction
1. Establish TCP OPTIONS between Kamailio and target node.
2. On target node block incoming traffic from Kamailio node using iptables.
3. Notice on Kamailio node that TCP retransmission packets don't follow tcp_send_timeout settings, instead they fall back to kernel's net.ipv4.tcp_retries2 settings.
### Additional Information
* **Kamailio Version**
```
# kamailio -V
version: kamailio 5.8.2 (aarch64/linux) 446039
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT-NOSMP, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 446039
compiled on 14:32:09 Nov 14 2024 with gcc 8.5.0
```
* **Operating System**:
```
Linux xxx 4.18.0-553.6.1.el8.aarch64 #1 SMP Thu May 30 04:10:32 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4187
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4187(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Some improvements related to DMQ node status:
1. Allow other modules that use DMQ to detect NOT_ACTIVE nodes via default response callback. Note that only internal dmq ping mechanism can set them back to DMQ_NODE_ACTIVE status.
2. Simplify node status and merge DMQ_NODE_PENDING + DMQ_NODE_TIMEOUT into DMQ_NODE_NOT_ACTIVE since those specific states were never used to be compared against.
3. Add new mod parameters which will control after how many fails the node should be moved to DMQ_NODE_NOT_ACTIVE state.
Under testing currently. Will update if any bugs found.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4182
-- Commit Summary --
* dmq: add default response callback
* dmq: simplify node status
* dmq: add two new modparams
-- File Changes --
M src/modules/dialog/dlg_dmq.c (16)
M src/modules/dialog/dlg_dmq.h (3)
M src/modules/dmq/dmq.c (4)
M src/modules/dmq/dmq.h (2)
M src/modules/dmq/dmq_funcs.c (6)
M src/modules/dmq/dmqnode.c (70)
M src/modules/dmq/dmqnode.h (9)
M src/modules/dmq/doc/dmq_admin.xml (64)
M src/modules/dmq/notification_peer.c (80)
M src/modules/dmq/notification_peer.h (3)
M src/modules/dmq_usrloc/usrloc_sync.c (12)
M src/modules/dmq_usrloc/usrloc_sync.h (2)
M src/modules/htable/ht_dmq.c (15)
M src/modules/htable/ht_dmq.h (3)
M src/modules/presence/presence_dmq.c (16)
M src/modules/presence/presence_dmq.h (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4182.patchhttps://github.com/kamailio/kamailio/pull/4182.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4182
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4182(a)github.com>
- add dispatcher modparam `ds_ping_socket`
- add gateway param `ping_socket`
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
could be useful for HA use cases where multiple kamailio nodes share a common Virtual IP (e.g.: managed by the VRRP).
we need to route requests using Virtual IP socket configured with `ds_default_sockname`/`socket` and to perform destinations probing using self-IP socket configured with `ds_ping_socket`/`ping_socket`.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4186
-- Commit Summary --
* dispatcher: added ping socket configuration
-- File Changes --
M src/modules/dispatcher/dispatch.c (32)
M src/modules/dispatcher/dispatch.h (2)
M src/modules/dispatcher/dispatcher.c (25)
M src/modules/dispatcher/doc/dispatcher_admin.xml (20)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4186.patchhttps://github.com/kamailio/kamailio/pull/4186.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4186
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4186(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4166
-- Commit Summary --
* ims_registrar_scscf: fix reg_fetch_contacts call
* ims_registrar_scscf: fix documentation
-- File Changes --
M src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml (6)
M src/modules/ims_registrar_scscf/regpv.c (25)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4166.patchhttps://github.com/kamailio/kamailio/pull/4166.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4166
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4166(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4192
-- Commit Summary --
* cmake: Alter some of cmake-format options
* cmake: Fix formatting according to cmake-format config file.
-- File Changes --
M CMakeLists.txt (18)
M cmake/BuildType.cmake (8)
M cmake/cmake-format.py (4)
M cmake/compiler-specific.cmake (24)
M cmake/defs.cmake (29)
M cmake/groups.cmake (45)
M cmake/modules-docs.cmake (94)
M cmake/modules/FindBerkeleyDB.cmake (60)
M cmake/modules/FindErlang.cmake (52)
M cmake/modules/FindLdap.cmake (32)
M cmake/modules/FindLibev.cmake (4)
M cmake/modules/FindLibfreeradiusClient.cmake (21)
M cmake/modules/FindMariaDBClient.cmake (3)
M cmake/modules/FindMySQL.cmake (114)
M cmake/modules/FindNETSNMP.cmake (15)
M cmake/modules/FindOracle.cmake (11)
M cmake/modules/FindRadius.cmake (6)
M cmake/os-specific/darwin.cmake (38)
M cmake/os-specific/dragonfly.cmake (9)
M cmake/os-specific/freebsd.cmake (3)
M cmake/os-specific/linux.cmake (9)
M src/CMakeLists.txt (44)
M src/core/CMakeLists.txt (16)
M src/modules/CMakeLists.txt (55)
M src/modules/app_perl/CMakeLists.txt (17)
M src/modules/auth_radius/CMakeLists.txt (7)
M src/modules/db2_ldap/CMakeLists.txt (3)
M src/modules/db_berkeley/CMakeLists.txt (3)
M src/modules/dnssec/CMakeLists.txt (5)
M src/modules/kazoo/CMakeLists.txt (3)
M src/modules/nghttp2/CMakeLists.txt (5)
M src/modules/nsq/CMakeLists.txt (5)
M src/modules/phonenum/CMakeLists.txt (16)
M src/modules/ruxc/CMakeLists.txt (3)
M src/modules/sctp/CMakeLists.txt (6)
M src/modules/secsipid_proc/CMakeLists.txt (3)
M src/modules/snmpstats/CMakeLists.txt (3)
M src/modules/tls/CMakeLists.txt (29)
M src/modules/tlsa/CMakeLists.txt (11)
M src/modules/xhttp_pi/CMakeLists.txt (7)
M utils/CMakeLists.txt (6)
M utils/db_berkeley/CMakeLists.txt (3)
M utils/kamcmd/CMakeLists.txt (26)
M utils/kamctl/CMakeLists.txt (161)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4192.patchhttps://github.com/kamailio/kamailio/pull/4192.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4192
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4192(a)github.com>
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
I have refactored the rpm packaging and am now using the GitHub actions.
Now `tar.gz` archive with rpm packages, source rpm and deps rpm files attached to the release message like.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4194
-- Commit Summary --
* generate rpm packages using github actions
-- File Changes --
A .github/workflows/rpm.yml (57)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4194.patchhttps://github.com/kamailio/kamailio/pull/4194.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4194
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4194(a)github.com>
### Description
Let's assume we have a MO call from UE to P-CSCF that's over ipsec. Let's assume the picked ports are like UE(6101) -> P-CSCF(6100)
We have also set tcp_connection_lifetime to be 20 sec.
20 sec after INVITE connection is RST from Kamailio as expected.
Then ( > 20sec later) an INVITE response comes from B side, and must be delivered to the UE.
Kamailio opens a new connection and tries to establish a connection from 5060 (standard port)->6101 instead of 6100(P-CSCF) -> 6101(UE). IPSEC associations are not engaged and UE does not handle the request properly.
### Troubleshooting
#### Reproduction
#### Debugging Data
#### Log Messages
#### SIP Traffic
### Possible Solutions
The IPSEC module should re-open the tcp connection if it sees it's been dropped as core module has no awareness of IPSEC.
* **Operating System**:
All
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4138
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4138(a)github.com>