sr-dev June 2025

sr-dev@lists.kamailio.org

20 participants
219 discussions

git:6.0:c020f76b: tm: invoke tm:local-request on generated ACK messages (#4250)
by Torrey Searle 10 Jun '25

10 Jun '25

Module: kamailio Branch: 6.0 Commit: c020f76b231d554545e14ed1f4e543b942ea769b URL: https://github.com/kamailio/kamailio/commit/c020f76b231d554545e14ed1f4e543b… Author: tsearle <torrey.searle(a)wavecrest.com> Committer: Torrey Searle <torrey.searle(a)wavecrest.com> Date: 2025-06-10T14:06:40+02:00 tm: invoke tm:local-request on generated ACK messages (#4250) --- Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/c020f76b231d554545e14ed1f4e543b… Patch: https://github.com/kamailio/kamailio/commit/c020f76b231d554545e14ed1f4e543b…

1 0

git:master:58057e9c: lib/srdb1: fix schema Makefile after e0dd39618fae2004cd1ab44758ca323376935e2e
by Victor Seva 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 58057e9c78971ee215b508f912e94f79bc57f247 URL: https://github.com/kamailio/kamailio/commit/58057e9c78971ee215b508f912e94f7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-06-10T13:52:34+02:00 lib/srdb1: fix schema Makefile after e0dd39618fae2004cd1ab44758ca323376935e2e > diff --git a/doc/stylesheets/dbschema_k/xsl/mongodb.xsl b/doc/stylesheets/dbschema_k/xsl/db_mongodb.xsl > similarity index 100% > rename from doc/stylesheets/dbschema_k/xsl/mongodb.xsl > rename to doc/stylesheets/dbschema_k/xsl/db_mongodb.xsl > diff --git a/doc/stylesheets/dbschema_k/xsl/mysql.xsl b/doc/stylesheets/dbschema_k/xsl/db_mysql.xsl > similarity index 100% > rename from doc/stylesheets/dbschema_k/xsl/mysql.xsl > rename to doc/stylesheets/dbschema_k/xsl/db_mysql.xsl > diff --git a/doc/stylesheets/dbschema_k/xsl/oracle.xsl b/doc/stylesheets/dbschema_k/xsl/db_oracle.xsl > similarity index 100% > rename from doc/stylesheets/dbschema_k/xsl/oracle.xsl > rename to doc/stylesheets/dbschema_k/xsl/db_oracle.xsl > diff --git a/doc/stylesheets/dbschema_k/xsl/postgres.xsl b/doc/stylesheets/dbschema_k/xsl/db_postgres.xsl > similarity index 100% > rename from doc/stylesheets/dbschema_k/xsl/postgres.xsl > rename to doc/stylesheets/dbschema_k/xsl/db_postgres.xsl > diff --git a/doc/stylesheets/dbschema_k/xsl/dbtext.xsl b/doc/stylesheets/dbschema_k/xsl/db_text.xsl > similarity index 100% > rename from doc/stylesheets/dbschema_k/xsl/dbtext.xsl > rename to doc/stylesheets/dbschema_k/xsl/db_text.xsl --- Modified: src/lib/srdb1/schema/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/58057e9c78971ee215b508f912e94f7… Patch: https://github.com/kamailio/kamailio/commit/58057e9c78971ee215b508f912e94f7… --- diff --git a/src/lib/srdb1/schema/Makefile b/src/lib/srdb1/schema/Makefile index b057387c703..b76b485e402 100644 --- a/src/lib/srdb1/schema/Makefile +++ b/src/lib/srdb1/schema/Makefile @@ -17,13 +17,13 @@ PI_FRAMEWORK_TABLE_XSL = $(STYLESHEETS)/pi_framework_table.xsl PI_FRAMEWORK_MOD_XSL = $(STYLESHEETS)/pi_framework_mod.xsl # Stylesheet used to generate MySQL database schema -MYSQL_XSL = $(STYLESHEETS)/mysql.xsl +MYSQL_XSL = $(STYLESHEETS)/db_mysql.xsl # Stylesheet used to generate Postgres database schema -POSTGRES_XSL = $(STYLESHEETS)/postgres.xsl +POSTGRES_XSL = $(STYLESHEETS)/db_postgres.xsl # Stylesheet used to generate dbtext database schema -DBTEXT_XSL = $(STYLESHEETS)/dbtext.xsl +DBTEXT_XSL = $(STYLESHEETS)/db_text.xsl # Stylesheet used to generate berkeley database schema DB_BERKELEY_XSL = $(STYLESHEETS)/db_berkeley.xsl @@ -32,10 +32,10 @@ DB_BERKELEY_XSL = $(STYLESHEETS)/db_berkeley.xsl DB_SQLITE_XSL = $(STYLESHEETS)/db_sqlite.xsl # Stylesheet used to generate oracle database schema -ORACLE_XSL = $(STYLESHEETS)/oracle.xsl +ORACLE_XSL = $(STYLESHEETS)/db_oracle.xsl # Stylesheet used to generate mongodb database schema -MONGODB_XSL = $(STYLESHEETS)/mongodb.xsl +MONGODB_XSL = $(STYLESHEETS)/db_mongodb.xsl # Stylesheet used to generate Redis database schema DB_REDIS_XSL = $(STYLESHEETS)/db_redis.xsl

1 0

[kamailio/kamailio] invoke tm:local-request on locally generated ACKs (Issue #4249)
by tsearle 10 Jun '25

10 Jun '25

tsearle created an issue (kamailio/kamailio#4249) ### Description I'm trying to make a SIP Rec callflow using t_uac_send to Generate the INVITE and BYE. This automatically generates the ACK in response to the 200 OK. I want to be able to use tm:local-request to do 2 things. * Add a Contact header to the ACK * Save Route/Callid/CSeq etc so I can generate an in-dialog bye afterwards. ### Expected behavior tm:local-request gets called so I can save the relevant headers & modify the outgoing ack #### Actual observed behavior tm:local-request does not get called ### Possible Solutions the associated PR adds this functionality ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (aarch64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT-NOSMP, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 06:24:22 May 22 2025 with gcc 12.2.0 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4249 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4249(a)github.com>

1 1

git:master:3f5b8841: tm: invoke tm:local-request on generated ACK messages (#4250)
by GitHub 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 3f5b8841bc8eda730568891571cc41b551e291d9 URL: https://github.com/kamailio/kamailio/commit/3f5b8841bc8eda730568891571cc41b… Author: tsearle <torrey.searle(a)wavecrest.com> Committer: GitHub <noreply(a)github.com> Date: 2025-06-10T13:05:06+02:00 tm: invoke tm:local-request on generated ACK messages (#4250) --- Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/3f5b8841bc8eda730568891571cc41b… Patch: https://github.com/kamailio/kamailio/commit/3f5b8841bc8eda730568891571cc41b…

1 0

git:6.0:53f721cf: rtpengine: Add check for skipping pings on manually disabled nodes.
by Xenofon Karamanos 10 Jun '25

10 Jun '25

Module: kamailio Branch: 6.0 Commit: 53f721cf7169e163ceab5113ca3296683b88921e URL: https://github.com/kamailio/kamailio/commit/53f721cf7169e163ceab5113ca32966… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-10T10:39:31Z rtpengine: Add check for skipping pings on manually disabled nodes. - Add debug log when trying to ping a node. (cherry picked from commit 3202dc9d8e26620fe642e474e5cf8632ab6bc3a7) --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/53f721cf7169e163ceab5113ca32966… Patch: https://github.com/kamailio/kamailio/commit/53f721cf7169e163ceab5113ca32966… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 2401ad09cbd..36f93dd35aa 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -1744,6 +1744,7 @@ static int rtpp_test_ping(struct rtpp_node *node) char *cp; int ret; + LM_DBG("Sending ping to node %.*s\n", node->rn_url.len, node->rn_url.s); if(bencode_buffer_init(&bencbuf)) { return -1; } @@ -3777,7 +3778,7 @@ static void rtpengine_ping_check_timer(unsigned int ticks, void *param) for(crt_rtpp = rtpp_list->rn_first; crt_rtpp != NULL; crt_rtpp = crt_rtpp->rn_next) { - if(!crt_rtpp->rn_displayed) { + if(!crt_rtpp->rn_displayed || crt_rtpp->rn_disabled) { continue; }

1 0

git:master:ec5ab51a: core: srapi - prototype function names set back for msg env push/pop
by Daniel-Constantin Mierla 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: ec5ab51a7ba1c2a94515b8f28c546c9d7cf58b90 URL: https://github.com/kamailio/kamailio/commit/ec5ab51a7ba1c2a94515b8f28c546c9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-10T11:57:38+02:00 core: srapi - prototype function names set back for msg env push/pop --- Modified: src/core/srapi.h --- Diff: https://github.com/kamailio/kamailio/commit/ec5ab51a7ba1c2a94515b8f28c546c9… Patch: https://github.com/kamailio/kamailio/commit/ec5ab51a7ba1c2a94515b8f28c546c9… --- diff --git a/src/core/srapi.h b/src/core/srapi.h index 0a1593fe93a..0081624b7be 100644 --- a/src/core/srapi.h +++ b/src/core/srapi.h @@ -69,8 +69,8 @@ typedef struct ksr_msg_env_links sr_xavp_t **xavis; } ksr_msg_env_links_t; -int ksr_msg_env_links_push(ksr_msg_env_links_t *menv); -int ksr_msg_env_links_pop(ksr_msg_env_links_t *menv); +int ksr_msg_env_push(ksr_msg_env_links_t *menv); +int ksr_msg_env_pop(ksr_msg_env_links_t *menv); int ksr_msg_env_data_destroy(ksr_msg_env_data_t *denv); #endif

1 0

[kamailio/kamailio] rtpengine: Add check for skipping pings on manually disabled nodes. (PR #4248)
by Xenofon Karamanos 10 Jun '25

10 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4247  - Add debug log when trying to ping a node. Do not ping manually disabled nodes! You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4248 -- Commit Summary -- * rtpengine: Add check for skipping pings on manually disabled nodes. -- File Changes -- M src/modules/rtpengine/rtpengine.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4248.patch https://github.com/kamailio/kamailio/pull/4248.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4248 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4248(a)github.com>

2 4

git:master:3202dc9d: rtpengine: Add check for skipping pings on manually disabled nodes.
by Xenofon Karamanos 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 3202dc9d8e26620fe642e474e5cf8632ab6bc3a7 URL: https://github.com/kamailio/kamailio/commit/3202dc9d8e26620fe642e474e5cf863… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-06-10T12:28:01+03:00 rtpengine: Add check for skipping pings on manually disabled nodes. - Add debug log when trying to ping a node. --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/3202dc9d8e26620fe642e474e5cf863… Patch: https://github.com/kamailio/kamailio/commit/3202dc9d8e26620fe642e474e5cf863… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 828eca4e7a2..f813bd45579 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -1955,6 +1955,7 @@ static int rtpp_test_ping(struct rtpp_node *node) char *cp; int ret; + LM_DBG("Sending ping to node %.*s\n", node->rn_url.len, node->rn_url.s); if(bencode_buffer_init(&bencbuf)) { return -1; } @@ -4078,7 +4079,7 @@ static void rtpengine_ping_check_timer(unsigned int ticks, void *param) for(crt_rtpp = rtpp_list->rn_first; crt_rtpp != NULL; crt_rtpp = crt_rtpp->rn_next) { - if(!crt_rtpp->rn_displayed) { + if(!crt_rtpp->rn_displayed || crt_rtpp->rn_disabled) { continue; }

1 0

[kamailio/kamailio] presence: preserve etag uniqueness when marking presentity for removal (PR #4275)
by Alessio Garzi 10 Jun '25

10 Jun '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #### Description When the `presence` module attempts to clean up records in the `presentity` table, it replaces the `etag` with a static, hardcoded string: ``` "*#-OFFLINE-#*" ``` However, the `presentity` table enforces a uniqueness constraint on the following combination of fields: ``` MariaDB [kamailio]> show create table presentity; | presentity | CREATE TABLE `presentity` ( ... UNIQUE KEY `presentity_idx` (`username`,`domain`,`event`,`etag`), ``` This approach breaks the uniqueness of etag, which is intended to differentiate records , especially in cases such as parallel calls, or when using kamailio as a forking proxy. Instead of overwriting the etag with the static offline marker, this patch appends the marker to the existing etag value. This ensures the offline flag is retained while preserving the uniqueness of the etag. The deletion query was also updated accordingly: it now identifies offline records using a LIKE '%*#-OFFLINE-#*' clause. Based on testing, the duplicate key errors no longer occur, and the cleanup logic now behaves as expected. This patch improves the reliability of presentity cleanup without requiring schema or index changes. Please consider merging into master. Thanks! You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4275 -- Commit Summary -- * presence: preserve etag uniqueness when marking presentity for removal -- File Changes -- M src/modules/presence/presentity.c (90) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4275.patch https://github.com/kamailio/kamailio/pull/4275.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4275 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4275(a)github.com>

3 10

git:master:cdcb570e: core: sdp - check if space is found for extracting session version
by Daniel-Constantin Mierla 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: cdcb570e46101703f4963863c705345c7a3420ac URL: https://github.com/kamailio/kamailio/commit/cdcb570e46101703f4963863c705345… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-10T08:21:44+02:00 core: sdp - check if space is found for extracting session version --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/cdcb570e46101703f4963863c705345… Patch: https://github.com/kamailio/kamailio/commit/cdcb570e46101703f4963863c705345… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 0d18d787242..60613ff8264 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -734,7 +734,7 @@ int extract_sess_version(str *oline, str *sess_version) i++; } while((cp < oline->s + oline->len) && i < 3); - if(cp >= oline->s + oline->len) { + if(cp == NULL || cp0 == NULL || cp >= oline->s + oline->len) { LM_ERR("broken o= line - version field not found\n"); return -1; }

1 0

← Newer
1
...
14
15
16
17
18
19
20
21
22
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2025