sr-dev June 2025

sr-dev@lists.kamailio.org

20 participants
218 discussions

[kamailio/kamailio] Handling Duplicate Values in secfilter Module's kamcmd Commands (Issue #4091)
by AsedMorteza 23 Jun '25

23 Jun '25

**Description** The `secfilter` module in `kamcmd` currently allows duplicate entries when adding values to certain lists (e.g., blacklists, whitelists). This can lead to unexpected behavior and potential inconsistencies. Could you clarify the reason behind accepting duplicate values? Recently, I submitted a pull request to add delete commands to the `secfilter` module #4089. When a user, for example, executes: `kamcmd secfilter.del_bl user 1005` I iterate through the entire list to ensure all occurrences of `1005` are removed, as I realized duplicates might exist. This is inefficient and could be avoided by preventing duplicates in the first place. **Proposed Solutions** 1. **Prevent Duplicates in Existing `add` Commands:** * I can modify existing `add` commands to directly prevent the addition of duplicate values. This would simplify future operations and improve performance. 2. **Introduce New `add_unique` Commands:** * I can maintain the current `add` commands for backward compatibility. * I can introduce new `add_unique` commands (e.g., `secfilter.add_bl_unique`) that explicitly reject duplicate entries. **Recommendation** I recommend implementing the first solution (preventing duplicates in existing `add` commands) as it provides the most straightforward and efficient approach. **Further Considerations** * Consider adding a check for duplicates during the `add` operation and returning an appropriate error message if a duplicate is encountered. * Document the behavior of duplicate values in the `secfilter` module's documentation. **I would appreciate your feedback and guidance on the best course of action.** -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4091 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4091(a)github.com>

6 12

git:6.0:1c2ed9b6: github: added multiarch support for rpm generation [skip ci]
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: 6.0 Commit: 1c2ed9b6c1a4c82bb9fe8a98271bae3db3acee5b URL: https://github.com/kamailio/kamailio/commit/1c2ed9b6c1a4c82bb9fe8a98271bae3… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T20:53:06+03:00 github: added multiarch support for rpm generation [skip ci] (cherry picked from commit 76b6e3b9733d0382348da1a80c3cdeecec44415e) --- Modified: .github/workflows/rpm.yml --- Diff: https://github.com/kamailio/kamailio/commit/1c2ed9b6c1a4c82bb9fe8a98271bae3… Patch: https://github.com/kamailio/kamailio/commit/1c2ed9b6c1a4c82bb9fe8a98271bae3…

1 0

git:6.0:1f305801: github: generate rpm packages
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: 6.0 Commit: 1f3058011f8f45f8d7ad2eb68294a9b9c6e82bcd URL: https://github.com/kamailio/kamailio/commit/1f3058011f8f45f8d7ad2eb68294a9b… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T20:28:27+03:00 github: generate rpm packages (cherry picked from commit afa2d017e3b5a1f5a776935767e485c1158be461) --- Added: .github/workflows/rpm.yml --- Diff: https://github.com/kamailio/kamailio/commit/1f3058011f8f45f8d7ad2eb68294a9b… Patch: https://github.com/kamailio/kamailio/commit/1f3058011f8f45f8d7ad2eb68294a9b… --- diff --git a/.github/workflows/rpm.yml b/.github/workflows/rpm.yml new file mode 100644 index 00000000000..0d890b63a8c --- /dev/null +++ b/.github/workflows/rpm.yml @@ -0,0 +1,89 @@ +--- +name: build_rpm +'on': + schedule: + - cron: '41 6 * * 0' + push: + tags: + - '[0-9]+.[0-9]+.[0-9]+' +jobs: + # is required nightly build? + # More info at https://stackoverflow.com/questions/63014786/how-to-schedule-a-github-actio… + # looking commit_id of the last successful daily build + check: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - uses: octokit/request-action(a)v2.x + id: check_last_run + with: + route: GET /repos/{owner}/{repo}/actions/workflows/rpm.yml/runs?per_page=1&status=success + owner: ${{ github.repository_owner }} + repo: kamailio + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Show last execution info + run: | + echo "Last daily build: ${{ fromJson(steps.check_last_run.outputs.data).workflow_runs[0].head_sha }}" + + outputs: + last_sha: ${{ fromJson(steps.check_last_run.outputs.data).workflow_runs[0].head_sha }} + + native: + needs: [check] + if: needs.check.outputs.last_sha != github.sha + strategy: + matrix: + os: + - centos-10 + - rhel-10 + - centos-9 + - rhel-9 + - centos-8 + - rhel-8 + runner: + - ubuntu-latest + - ubuntu-24.04-arm + runs-on: ${{ matrix.runner }} + permissions: + contents: write + steps: + - name: checkout sources + uses: actions/checkout@v4 + + - name: print commit info and init hosttype var + id: init + run: | + echo ${{ github.sha }} + echo "hosttype=${HOSTTYPE}" >> $GITHUB_OUTPUT + + - name: build rpm files + uses: addnab/docker-run-action@v3 + with: + image: safarov/kamailio-builder:${{ matrix.os }} + options: -v ${{ github.workspace }}:/usr/src/kamailio + run: | + cd /usr/src/kamailio + make cfg + make -C pkg/kamailio src.rpm + rpmbuild -ra /usr/src/kamailio/kamailio*.src.rpm + cp -R /deps ~/rpmbuild/RPMS + mv ~/rpmbuild/SRPMS/* ~/rpmbuild/RPMS + mv ~/rpmbuild/RPMS . + tar czf kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm.tar.gz RPMS + + - name: Push artifacts + uses: actions/upload-artifact@v4 + if: "! startsWith(github.ref, 'refs/tags/')" + with: + name: kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm + path: | + RPMS/* + + - name: Release + uses: softprops/action-gh-release@v2 + if: "startsWith(github.ref, 'refs/tags/')" + with: + files: | + kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm.tar.gz

1 0

git:6.0:3bb3b4ef: pkg/kamailio: use radcli on RHEL based dist [skip ci]
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: 6.0 Commit: 3bb3b4ef8f38e944bbae94ccc51c25b3330d2faa URL: https://github.com/kamailio/kamailio/commit/3bb3b4ef8f38e944bbae94ccc51c25b… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T19:31:02+03:00 pkg/kamailio: use radcli on RHEL based dist [skip ci] (cherry picked from commit c2fc809059e0c70aa4324f5727666989ee8aff05) --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/3bb3b4ef8f38e944bbae94ccc51c25b… Patch: https://github.com/kamailio/kamailio/commit/3bb3b4ef8f38e944bbae94ccc51c25b… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index c6e2f5929ab..68b7c46b90f 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -746,8 +746,8 @@ Summary: RADIUS modules for Kamailio Group: %{PKGGROUP} Requires: kamailio = %ver %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} -Requires: freeradius-client -BuildRequires: freeradius-client-devel +Requires: radcli +BuildRequires: radcli-devel %else Requires: radiusclient-ng BuildRequires: radiusclient-ng-devel @@ -1072,7 +1072,7 @@ rm -f misc/examples/pkg/sipcapture.cfg %build %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 -export FREERADIUS=1 +export RADCLI=1 %endif make cfg prefix=/usr \ basedir=%{buildroot} \ @@ -1084,7 +1084,7 @@ make make every-module skip_modules="app_mono db_cassandra db_oracle iptrtpproxy \ jabber ndb_cassandra osp" \ %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 - FREERADIUS=1 \ + RADCLI=1 \ %endif %if 0%{?rhel} >= 8 PYTHON3=python3.12 \ @@ -1192,7 +1192,7 @@ make install make install-modules-all skip_modules="app_mono db_cassandra db_oracle \ iptrtpproxy jabber osp" \ %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 - FREERADIUS=1 \ + RADCLI=1 \ %endif %if 0%{?rhel} >= 8 PYTHON3=python3.12 \

1 0

git:6.0:b80dd574: pkg/kamailio: removed RHEL 6 and 7 if macros from RPM spec file
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: 6.0 Commit: b80dd57418fa1dad8a333f11f64f5a9df3e65332 URL: https://github.com/kamailio/kamailio/commit/b80dd57418fa1dad8a333f11f64f5a9… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T19:30:46+03:00 pkg/kamailio: removed RHEL 6 and 7 if macros from RPM spec file (cherry picked from commit 701d07df14d0d66125ff0ff3adec3ce424929472) --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/b80dd57418fa1dad8a333f11f64f5a9… Patch: https://github.com/kamailio/kamailio/commit/b80dd57418fa1dad8a333f11f64f5a9…

1 0

git:6.0:6d0c691c: pkg/kamailio: sipcapture remove
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: 6.0 Commit: 6d0c691c379a8798822c5672d3fd515eb01f5394 URL: https://github.com/kamailio/kamailio/commit/6d0c691c379a8798822c5672d3fd515… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T19:30:15+03:00 pkg/kamailio: sipcapture remove (cherry picked from commit a7c4d4003dced50b3f6cbc7c9c6235e6bf894334) --- Modified: pkg/kamailio/obs/kamailio.spec Removed: pkg/kamailio/obs/sipcapture.service Removed: pkg/kamailio/obs/sipcapture.sysconfig Removed: pkg/kamailio/obs/sipcapture.tmpfiles --- Diff: https://github.com/kamailio/kamailio/commit/6d0c691c379a8798822c5672d3fd515… Patch: https://github.com/kamailio/kamailio/commit/6d0c691c379a8798822c5672d3fd515…

1 0

git:master:76b6e3b9: github: added multiarch support for rpm generation [skip ci]
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: master Commit: 76b6e3b9733d0382348da1a80c3cdeecec44415e URL: https://github.com/kamailio/kamailio/commit/76b6e3b9733d0382348da1a80c3cdee… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T20:50:02+03:00 github: added multiarch support for rpm generation [skip ci] --- Modified: .github/workflows/rpm.yml --- Diff: https://github.com/kamailio/kamailio/commit/76b6e3b9733d0382348da1a80c3cdee… Patch: https://github.com/kamailio/kamailio/commit/76b6e3b9733d0382348da1a80c3cdee…

1 0

[kamailio/kamailio] extra bytes should be ignored when Content-Length header present (Issue #4290)
by sergey-safarov 22 Jun '25

22 Jun '25

sergey-safarov created an issue (kamailio/kamailio#4290) ### Description According to [RFC3261](https://www.ietf.org/rfc/rfc3261.html#section-18.3) Section 18.3 ``` In the case of message-oriented transports (such as UDP), if the message has a Content-Length header field, the message body is assumed to contain that many bytes. If there are additional bytes in the transport packet beyond the end of the body, they MUST be discarded. ``` In the current Kamailio implementation, extra bytes are analyzed, and this triggers a failed sanity check. ### Troubleshooting #### Reproduction To reproduce required prepare config file ``` listen=udp:127.0.0.1:5060 loadmodule "xlog.so" loadmodule "sl.so" loadmodule "sanity.so" modparam("sanity", "autodrop", 0) modparam("sanity", "noreply", 1) route{ if(sanity_check()) { sl_send_reply("200", "OK"); exit; } xerr("sanity checks failed\n"); sanity_reply(); drop; } ``` And start using a command like ``` kamailio -DD -E -f kamailio.cfg ``` Then need to send options using a command like ``` cat options-extra.txt | nc -u 127.0.0.1 5060 ``` Where `options-extra.txt` is a file from the attached archive [options.tar.gz](https://github.com/user-attachments/files/20838024/options.… If you remove extra bytes after the OPTIONS message, then Kamailio does not generate an error. This can be tested using the command ``` cat options-normal.txt | nc -u 127.0.0.1 5060 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4290 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4290(a)github.com>

3 6

git:6.0:4e221917: pkg/kamailio/alpine: add missing dependency for jwt module [skip ci]
by Sergey Safarov 21 Jun '25

21 Jun '25

Module: kamailio Branch: 6.0 Commit: 4e221917fc18463e8a7a1a5f6db13e8da6785ed0 URL: https://github.com/kamailio/kamailio/commit/4e221917fc18463e8a7a1a5f6db13e8… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-21T21:17:31+03:00 pkg/kamailio/alpine: add missing dependency for jwt module [skip ci] related #4132 (cherry picked from commit 95d0c1fc38da00dc6bbda19dba1ac4b20535abf5) --- Modified: pkg/kamailio/alpine/APKBUILD --- Diff: https://github.com/kamailio/kamailio/commit/4e221917fc18463e8a7a1a5f6db13e8… Patch: https://github.com/kamailio/kamailio/commit/4e221917fc18463e8a7a1a5f6db13e8… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index fe941ec28e5..2215305313f 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -32,7 +32,7 @@ makedepends="bison db-dev flex freeradius-client-dev expat-dev net-snmp-dev libuuid libev-dev jansson-dev json-c-dev libevent-dev linux-headers libmemcached-dev rabbitmq-c-dev hiredis-dev ruby-dev libmaxminddb-dev libunistring-dev mongo-c-driver-dev - libwebsockets-dev mosquitto-dev librdkafka-dev nghttp2-dev" + libwebsockets-dev mosquitto-dev librdkafka-dev nghttp2-dev libjwt-dev" install="$pkgname.pre-install $pkgname.pre-upgrade"

1 0

git:6.0:6edde708: pkg/kamailio: for dispatcher work required working DNS resolution daemon
by Sergey Safarov 21 Jun '25

21 Jun '25

Module: kamailio Branch: 6.0 Commit: 6edde7080fd5f7fb6a547f6de5c5b7c104cb493a URL: https://github.com/kamailio/kamailio/commit/6edde7080fd5f7fb6a547f6de5c5b7c… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-21T21:17:12+03:00 pkg/kamailio: for dispatcher work required working DNS resolution daemon (cherry picked from commit aa7b2460ff0d8085ddc8ae9232a9fea0fe0db5f8) --- Modified: pkg/kamailio/obs/kamailio.service --- Diff: https://github.com/kamailio/kamailio/commit/6edde7080fd5f7fb6a547f6de5c5b7c… Patch: https://github.com/kamailio/kamailio/commit/6edde7080fd5f7fb6a547f6de5c5b7c… --- diff --git a/pkg/kamailio/obs/kamailio.service b/pkg/kamailio/obs/kamailio.service index 0c4fbc49caf..0a527056f91 100644 --- a/pkg/kamailio/obs/kamailio.service +++ b/pkg/kamailio/obs/kamailio.service @@ -1,8 +1,8 @@ [Unit] Description=Kamailio - the Open Source SIP Server Documentation=man:kamailio(8) -Wants=network-online.target -After=network-online.target +Wants=network-online.target nss-lookup.target +After=network-online.target nss-lookup.target [Service] Type=simple

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
22
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2025