From notifications@github.com Wed Oct 10 22:54:05 2018
From: Julien Chavanton <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: [sr-dev] [kamailio/kamailio] acc: generating duplicates on missed /
 failed calls (#1673)
Date: Wed, 10 Oct 2018 13:53:57 -0700
Message-ID: <kamailio/kamailio/issues/1673@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1965773721=="

--===============1965773721==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable



### Description

I am looking at how to properly handle a problem with duplicate ACC=20

This is when `TMCB_ON_FAILURE` and `TMCB_RESPONSE_OUT` are both called, they =
are not using the same version of the message.
`TMCB_ON_FAILURE` is using the cloned version
`TMCB_RESPONSE_OUT` is using the original version

They are not sharing the message flags and 2 ACC events are generated.

Since this is very sensitive, I want to make sure I can trace the real root c=
ause.
Not sure if this is a regression ...

#### Reproduction

Any failed call

#### Debugging Data


```
 0(4603) NOTICE: acc [acc_logic.c:686]: tmcb_func(): acc callback called for =
t(0x7f768b6dac08) event type 2, reply code 404 reqmsg[0x7f768b6dc840] rplmsg[=
0x7f76d096dee8]
 0(4603) ERROR: acc [acc_logic.c:697]: tmcb_func(): [TMCB_RESPONSE_IN][0x7f76=
8b6dc840][0x7f76d096dee8]

// reply route execution

 0(4603) ERROR: <core> [core/sip_msg_clone.c:504]: sip_msg_shm_clone(): sip_m=
sg_shm_clone[0x7f768b6dc840]>>[0x7f768b6de738]
 0(4603) NOTICE: acc [acc_logic.c:686]: tmcb_func(): acc callback called for =
t(0x7f768b6dac08) event type 128, reply code 404 reqmsg[0x7f768b6de738] rplms=
g[0x7f76d096dee8]
 0(4603) ERROR: acc [acc_logic.c:694]: tmcb_func(): [TMCB_ON_FAILURE] run on_=
missed [0x7f768b6de738][0x7f76d096dee8] // working with the cloned message
 0(4603) ERROR: <core> [core/flags.c:59]: isflagset(): isflagset[0x7f768b6de7=
38]
 0(4603) ERROR: acc_json [acc_json_mod.c:189]: acc_json_send_request(): misse=
d call flag [7] for this transaction [on]

// failure route execution, we are working with the cloned message
 0(4603) NOTICE: <script>: [FAILURE]
 0(4603) ERROR: <core> [core/flags.c:46]: setflag(): setflag[0x7f768b6de738]
// failure

 0(4603) NOTICE: acc [acc_logic.c:686]: tmcb_func(): acc callback called for =
t(0x7f768b6dac08) event type 512, reply code 404 reqmsg[0x7f768b6dc840] rplms=
g[0x7f76d096dee8]
 0(4603) ERROR: acc [acc_logic.c:689]: tmcb_func(): [TMCB_RESPONSE_OUT][0x7f7=
68b6dc840][0x7f76d096dee8] // working with the original message
 0(4603) ERROR: <core> [core/flags.c:59]: isflagset(): isflagset[0x7f768b6dc8=
40]
 0(4603) ERROR: acc_json [acc_json_mod.c:189]: acc_json_send_request(): misse=
d call flag [7] for this transaction [on]
```



--=20
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1673



--===============1965773721==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PGgzPkRlc2NyaXB0aW9uPC9oMz4KPHA+SSBhbSBsb29raW5nIGF0IGhvdyB0byBwcm9wZXJseSBo
YW5kbGUgYSBwcm9ibGVtIHdpdGggZHVwbGljYXRlIEFDQzwvcD4KPHA+VGhpcyBpcyB3aGVuIDxj
b2RlPlRNQ0JfT05fRkFJTFVSRTwvY29kZT4gYW5kIDxjb2RlPlRNQ0JfUkVTUE9OU0VfT1VUPC9j
b2RlPiBhcmUgYm90aCBjYWxsZWQsIHRoZXkgYXJlIG5vdCB1c2luZyB0aGUgc2FtZSB2ZXJzaW9u
IG9mIHRoZSBtZXNzYWdlLjxicj4KPGNvZGU+VE1DQl9PTl9GQUlMVVJFPC9jb2RlPiBpcyB1c2lu
ZyB0aGUgY2xvbmVkIHZlcnNpb248YnI+Cjxjb2RlPlRNQ0JfUkVTUE9OU0VfT1VUPC9jb2RlPiBp
cyB1c2luZyB0aGUgb3JpZ2luYWwgdmVyc2lvbjwvcD4KPHA+VGhleSBhcmUgbm90IHNoYXJpbmcg
dGhlIG1lc3NhZ2UgZmxhZ3MgYW5kIDIgQUNDIGV2ZW50cyBhcmUgZ2VuZXJhdGVkLjwvcD4KPHA+
U2luY2UgdGhpcyBpcyB2ZXJ5IHNlbnNpdGl2ZSwgSSB3YW50IHRvIG1ha2Ugc3VyZSBJIGNhbiB0
cmFjZSB0aGUgcmVhbCByb290IGNhdXNlLjxicj4KTm90IHN1cmUgaWYgdGhpcyBpcyBhIHJlZ3Jl
c3Npb24gLi4uPC9wPgo8aDQ+UmVwcm9kdWN0aW9uPC9oND4KPHA+QW55IGZhaWxlZCBjYWxsPC9w
Pgo8aDQ+RGVidWdnaW5nIERhdGE8L2g0Pgo8cHJlPjxjb2RlPiAwKDQ2MDMpIE5PVElDRTogYWNj
IFthY2NfbG9naWMuYzo2ODZdOiB0bWNiX2Z1bmMoKTogYWNjIGNhbGxiYWNrIGNhbGxlZCBmb3Ig
dCgweDdmNzY4YjZkYWMwOCkgZXZlbnQgdHlwZSAyLCByZXBseSBjb2RlIDQwNCByZXFtc2dbMHg3
Zjc2OGI2ZGM4NDBdIHJwbG1zZ1sweDdmNzZkMDk2ZGVlOF0KIDAoNDYwMykgRVJST1I6IGFjYyBb
YWNjX2xvZ2ljLmM6Njk3XTogdG1jYl9mdW5jKCk6IFtUTUNCX1JFU1BPTlNFX0lOXVsweDdmNzY4
YjZkYzg0MF1bMHg3Zjc2ZDA5NmRlZThdCgovLyByZXBseSByb3V0ZSBleGVjdXRpb24KCiAwKDQ2
MDMpIEVSUk9SOiAmbHQ7Y29yZSZndDsgW2NvcmUvc2lwX21zZ19jbG9uZS5jOjUwNF06IHNpcF9t
c2dfc2htX2Nsb25lKCk6IHNpcF9tc2dfc2htX2Nsb25lWzB4N2Y3NjhiNmRjODQwXSZndDsmZ3Q7
WzB4N2Y3NjhiNmRlNzM4XQogMCg0NjAzKSBOT1RJQ0U6IGFjYyBbYWNjX2xvZ2ljLmM6Njg2XTog
dG1jYl9mdW5jKCk6IGFjYyBjYWxsYmFjayBjYWxsZWQgZm9yIHQoMHg3Zjc2OGI2ZGFjMDgpIGV2
ZW50IHR5cGUgMTI4LCByZXBseSBjb2RlIDQwNCByZXFtc2dbMHg3Zjc2OGI2ZGU3MzhdIHJwbG1z
Z1sweDdmNzZkMDk2ZGVlOF0KIDAoNDYwMykgRVJST1I6IGFjYyBbYWNjX2xvZ2ljLmM6Njk0XTog
dG1jYl9mdW5jKCk6IFtUTUNCX09OX0ZBSUxVUkVdIHJ1biBvbl9taXNzZWQgWzB4N2Y3NjhiNmRl
NzM4XVsweDdmNzZkMDk2ZGVlOF0gLy8gd29ya2luZyB3aXRoIHRoZSBjbG9uZWQgbWVzc2FnZQog
MCg0NjAzKSBFUlJPUjogJmx0O2NvcmUmZ3Q7IFtjb3JlL2ZsYWdzLmM6NTldOiBpc2ZsYWdzZXQo
KTogaXNmbGFnc2V0WzB4N2Y3NjhiNmRlNzM4XQogMCg0NjAzKSBFUlJPUjogYWNjX2pzb24gW2Fj
Y19qc29uX21vZC5jOjE4OV06IGFjY19qc29uX3NlbmRfcmVxdWVzdCgpOiBtaXNzZWQgY2FsbCBm
bGFnIFs3XSBmb3IgdGhpcyB0cmFuc2FjdGlvbiBbb25dCgovLyBmYWlsdXJlIHJvdXRlIGV4ZWN1
dGlvbiwgd2UgYXJlIHdvcmtpbmcgd2l0aCB0aGUgY2xvbmVkIG1lc3NhZ2UKIDAoNDYwMykgTk9U
SUNFOiAmbHQ7c2NyaXB0Jmd0OzogW0ZBSUxVUkVdCiAwKDQ2MDMpIEVSUk9SOiAmbHQ7Y29yZSZn
dDsgW2NvcmUvZmxhZ3MuYzo0Nl06IHNldGZsYWcoKTogc2V0ZmxhZ1sweDdmNzY4YjZkZTczOF0K
Ly8gZmFpbHVyZQoKIDAoNDYwMykgTk9USUNFOiBhY2MgW2FjY19sb2dpYy5jOjY4Nl06IHRtY2Jf
ZnVuYygpOiBhY2MgY2FsbGJhY2sgY2FsbGVkIGZvciB0KDB4N2Y3NjhiNmRhYzA4KSBldmVudCB0
eXBlIDUxMiwgcmVwbHkgY29kZSA0MDQgcmVxbXNnWzB4N2Y3NjhiNmRjODQwXSBycGxtc2dbMHg3
Zjc2ZDA5NmRlZThdCiAwKDQ2MDMpIEVSUk9SOiBhY2MgW2FjY19sb2dpYy5jOjY4OV06IHRtY2Jf
ZnVuYygpOiBbVE1DQl9SRVNQT05TRV9PVVRdWzB4N2Y3NjhiNmRjODQwXVsweDdmNzZkMDk2ZGVl
OF0gLy8gd29ya2luZyB3aXRoIHRoZSBvcmlnaW5hbCBtZXNzYWdlCiAwKDQ2MDMpIEVSUk9SOiAm
bHQ7Y29yZSZndDsgW2NvcmUvZmxhZ3MuYzo1OV06IGlzZmxhZ3NldCgpOiBpc2ZsYWdzZXRbMHg3
Zjc2OGI2ZGM4NDBdCiAwKDQ2MDMpIEVSUk9SOiBhY2NfanNvbiBbYWNjX2pzb25fbW9kLmM6MTg5
XTogYWNjX2pzb25fc2VuZF9yZXF1ZXN0KCk6IG1pc3NlZCBjYWxsIGZsYWcgWzddIGZvciB0aGlz
IHRyYW5zYWN0aW9uIFtvbl0KPC9jb2RlPjwvcHJlPgoKPHAgc3R5bGU9ImZvbnQtc2l6ZTpzbWFs
bDstd2Via2l0LXRleHQtc2l6ZS1hZGp1c3Q6bm9uZTtjb2xvcjojNjY2OyI+Jm1kYXNoOzxiciAv
PllvdSBhcmUgcmVjZWl2aW5nIHRoaXMgYmVjYXVzZSB5b3UgYXJlIHN1YnNjcmliZWQgdG8gdGhp
cyB0aHJlYWQuPGJyIC8+UmVwbHkgdG8gdGhpcyBlbWFpbCBkaXJlY3RseSwgPGEgaHJlZj0iaHR0
cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczIj52aWV3IGl0IG9u
IEdpdEh1YjwvYT4sIG9yIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9ub3RpZmljYXRpb25z
L3Vuc3Vic2NyaWJlLWF1dGgvQUYzNlpiT2phRWktUlN0b3pqd085TlRlU3p5T01BNm9rczV1amw1
bGdhSnBaTTRYV1QzMSI+bXV0ZSB0aGUgdGhyZWFkPC9hPi48aW1nIHNyYz0iaHR0cHM6Ly9naXRo
dWIuY29tL25vdGlmaWNhdGlvbnMvYmVhY29uL0FGMzZaZktsM2ZkY0tUOEk3WWxfcVB3Qk9CN2p4
b3Zxa3M1dWpsNWxnYUpwWk00WFdUMzEuZ2lmIiBoZWlnaHQ9IjEiIHdpZHRoPSIxIiBhbHQ9IiIg
Lz48L3A+CjxzY3JpcHQgdHlwZT0iYXBwbGljYXRpb24vanNvbiIgZGF0YS1zY29wZT0iaW5ib3ht
YXJrdXAiPnsiYXBpX3ZlcnNpb24iOiIxLjAiLCJwdWJsaXNoZXIiOnsiYXBpX2tleSI6IjA1ZGRl
NTBmMWQxYTM4NGRkNzg3NjdjNTU0OTNlNGJiIiwibmFtZSI6IkdpdEh1YiJ9LCJlbnRpdHkiOnsi
ZXh0ZXJuYWxfa2V5IjoiZ2l0aHViL2thbWFpbGlvL2thbWFpbGlvIiwidGl0bGUiOiJrYW1haWxp
by9rYW1haWxpbyIsInN1YnRpdGxlIjoiR2l0SHViIHJlcG9zaXRvcnkiLCJtYWluX2ltYWdlX3Vy
bCI6Imh0dHBzOi8vYXNzZXRzLWNkbi5naXRodWIuY29tL2ltYWdlcy9lbWFpbC9tZXNzYWdlX2Nh
cmRzL2hlYWRlci5wbmciLCJhdmF0YXJfaW1hZ2VfdXJsIjoiaHR0cHM6Ly9hc3NldHMtY2RuLmdp
dGh1Yi5jb20vaW1hZ2VzL2VtYWlsL21lc3NhZ2VfY2FyZHMvYXZhdGFyLnBuZyIsImFjdGlvbiI6
eyJuYW1lIjoiT3BlbiBpbiBHaXRIdWIiLCJ1cmwiOiJodHRwczovL2dpdGh1Yi5jb20va2FtYWls
aW8va2FtYWlsaW8ifX0sInVwZGF0ZXMiOnsic25pcHBldHMiOlt7Imljb24iOiJERVNDUklQVElP
TiIsIm1lc3NhZ2UiOiJhY2M6IGdlbmVyYXRpbmcgZHVwbGljYXRlcyBvbiBtaXNzZWQgLyBmYWls
ZWQgY2FsbHMgKCMxNjczKSJ9XSwiYWN0aW9uIjp7Im5hbWUiOiJWaWV3IElzc3VlIiwidXJsIjoi
aHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczIn19fTwvc2Ny
aXB0Pgo8c2NyaXB0IHR5cGU9ImFwcGxpY2F0aW9uL2xkK2pzb24iPlsKewoiQGNvbnRleHQiOiAi
aHR0cDovL3NjaGVtYS5vcmciLAoiQHR5cGUiOiAiRW1haWxNZXNzYWdlIiwKInBvdGVudGlhbEFj
dGlvbiI6IHsKIkB0eXBlIjogIlZpZXdBY3Rpb24iLAoidGFyZ2V0IjogImh0dHBzOi8vZ2l0aHVi
LmNvbS9rYW1haWxpby9rYW1haWxpby9pc3N1ZXMvMTY3MyIsCiJ1cmwiOiAiaHR0cHM6Ly9naXRo
dWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczIiwKIm5hbWUiOiAiVmlldyBJc3N1
ZSIKfSwKImRlc2NyaXB0aW9uIjogIlZpZXcgdGhpcyBJc3N1ZSBvbiBHaXRIdWIiLAoicHVibGlz
aGVyIjogewoiQHR5cGUiOiAiT3JnYW5pemF0aW9uIiwKIm5hbWUiOiAiR2l0SHViIiwKInVybCI6
ICJodHRwczovL2dpdGh1Yi5jb20iCn0KfSwKewoiQHR5cGUiOiAiTWVzc2FnZUNhcmQiLAoiQGNv
bnRleHQiOiAiaHR0cDovL3NjaGVtYS5vcmcvZXh0ZW5zaW9ucyIsCiJoaWRlT3JpZ2luYWxCb2R5
IjogImZhbHNlIiwKIm9yaWdpbmF0b3IiOiAiQUY2QzVBODYtRTkyMC00MzBDLTlDNTktQTczMjc4
QjVFRkVCIiwKInRpdGxlIjogImFjYzogZ2VuZXJhdGluZyBkdXBsaWNhdGVzIG9uIG1pc3NlZCAv
IGZhaWxlZCBjYWxscyAoIzE2NzMpIiwKInNlY3Rpb25zIjogWwp7CiJ0ZXh0IjogIiIsCiJhY3Rp
dml0eVRpdGxlIjogIioqSnVsaWVuIENoYXZhbnRvbioqIiwKImFjdGl2aXR5SW1hZ2UiOiAiaHR0
cHM6Ly9hc3NldHMtY2RuLmdpdGh1Yi5jb20vaW1hZ2VzL2VtYWlsL21lc3NhZ2VfY2FyZHMvYXZh
dGFyLnBuZyIsCiJhY3Rpdml0eVN1YnRpdGxlIjogIkBqY2hhdmFudG9uIiwKImZhY3RzIjogWwp7
CiJuYW1lIjogIlJlcG9zaXRvcnk6ICIsCiJ2YWx1ZSI6ICJrYW1haWxpby9rYW1haWxpbyIKfSwK
ewoibmFtZSI6ICJJc3N1ZSAjOiAiLAoidmFsdWUiOiAxNjczCn0KXQp9Cl0sCiJwb3RlbnRpYWxB
Y3Rpb24iOiBbCnsKIm5hbWUiOiAiQWRkIGEgY29tbWVudCIsCiJAdHlwZSI6ICJBY3Rpb25DYXJk
IiwKImlucHV0cyI6IFsKewoiaXNNdWx0aUxpbmUiOiB0cnVlLAoiQHR5cGUiOiAiVGV4dElucHV0
IiwKImlkIjogIklzc3VlQ29tbWVudCIsCiJpc1JlcXVpcmVkIjogZmFsc2UKfQpdLAoiYWN0aW9u
cyI6IFsKewoibmFtZSI6ICJDb21tZW50IiwKIkB0eXBlIjogIkh0dHBQT1NUIiwKInRhcmdldCI6
ICJodHRwczovL2FwaS5naXRodWIuY29tIiwKImJvZHkiOiAie1xuXCJjb21tYW5kTmFtZVwiOiBc
Iklzc3VlQ29tbWVudFwiLFxuXCJyZXBvc2l0b3J5RnVsbE5hbWVcIjogXCJrYW1haWxpby9rYW1h
aWxpb1wiLFxuXCJpc3N1ZUlkXCI6IDE2NzMsXG5cIklzc3VlQ29tbWVudFwiOiBcInt7SXNzdWVD
b21tZW50LnZhbHVlfX1cIlxufSIKfQpdCn0sCnsKIm5hbWUiOiAiQ2xvc2UgaXNzdWUiLAoiQHR5
cGUiOiAiSHR0cFBPU1QiLAoidGFyZ2V0IjogImh0dHBzOi8vYXBpLmdpdGh1Yi5jb20iLAoiYm9k
eSI6ICJ7XG5cImNvbW1hbmROYW1lXCI6IFwiSXNzdWVDbG9zZVwiLFxuXCJyZXBvc2l0b3J5RnVs
bE5hbWVcIjogXCJrYW1haWxpby9rYW1haWxpb1wiLFxuXCJpc3N1ZUlkXCI6IDE2NzNcbn0iCn0s
CnsKInRhcmdldHMiOiBbCnsKIm9zIjogImRlZmF1bHQiLAoidXJpIjogImh0dHBzOi8vZ2l0aHVi
LmNvbS9rYW1haWxpby9rYW1haWxpby9pc3N1ZXMvMTY3MyIKfQpdLAoiQHR5cGUiOiAiT3BlblVy
aSIsCiJuYW1lIjogIlZpZXcgb24gR2l0SHViIgp9LAp7CiJuYW1lIjogIlVuc3Vic2NyaWJlIiwK
IkB0eXBlIjogIkh0dHBQT1NUIiwKInRhcmdldCI6ICJodHRwczovL2FwaS5naXRodWIuY29tIiwK
ImJvZHkiOiAie1xuXCJjb21tYW5kTmFtZVwiOiBcIk11dGVOb3RpZmljYXRpb25cIixcblwidGhy
ZWFkSWRcIjogMzkxNzI0NTMzXG59Igp9Cl0sCiJ0aGVtZUNvbG9yIjogIjI2MjkyRSIKfQpdPC9z
Y3JpcHQ+

--===============1965773721==--


From notifications@github.com Thu Oct 11 18:45:19 2018
From: Julien Chavanton <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio/kamailio] acc: generating duplicates on missed
 / failed calls (#1673)
Date: Thu, 11 Oct 2018 09:45:11 -0700
Message-ID: <kamailio/kamailio/issues/1673/429029923@github.com>
In-Reply-To: <kamailio/kamailio/issues/1673@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0195370544=="

--===============0195370544==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

just a little update, I this should be handled properly since the  flags shou=
ld be kept even if modified by a transaction callback, good now I need to fin=
d out why this is not taking place.
```
/* if failure handler changed flag, update transaction context */
shmem_msg->flags =3D faked_req->flags;
```


--=20
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1673#issuecomment-429029923



--===============0195370544==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+anVzdCBhIGxpdHRsZSB1cGRhdGUsIEkgdGhpcyBzaG91bGQgYmUgaGFuZGxlZCBwcm9wZXJs
eSBzaW5jZSB0aGUgIGZsYWdzIHNob3VsZCBiZSBrZXB0IGV2ZW4gaWYgbW9kaWZpZWQgYnkgYSB0
cmFuc2FjdGlvbiBjYWxsYmFjaywgZ29vZCBub3cgSSBuZWVkIHRvIGZpbmQgb3V0IHdoeSB0aGlz
IGlzIG5vdCB0YWtpbmcgcGxhY2UuPC9wPgo8cHJlPjxjb2RlPi8qIGlmIGZhaWx1cmUgaGFuZGxl
ciBjaGFuZ2VkIGZsYWcsIHVwZGF0ZSB0cmFuc2FjdGlvbiBjb250ZXh0ICovCnNobWVtX21zZy0m
Z3Q7ZmxhZ3MgPSBmYWtlZF9yZXEtJmd0O2ZsYWdzOwo8L2NvZGU+PC9wcmU+Cgo8cCBzdHlsZT0i
Zm9udC1zaXplOnNtYWxsOy13ZWJraXQtdGV4dC1zaXplLWFkanVzdDpub25lO2NvbG9yOiM2NjY7
Ij4mbWRhc2g7PGJyIC8+WW91IGFyZSByZWNlaXZpbmcgdGhpcyBiZWNhdXNlIHlvdSBhcmUgc3Vi
c2NyaWJlZCB0byB0aGlzIHRocmVhZC48YnIgLz5SZXBseSB0byB0aGlzIGVtYWlsIGRpcmVjdGx5
LCA8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNzdWVzLzE2
NzMjaXNzdWVjb21tZW50LTQyOTAyOTkyMyI+dmlldyBpdCBvbiBHaXRIdWI8L2E+LCBvciA8YSBo
cmVmPSJodHRwczovL2dpdGh1Yi5jb20vbm90aWZpY2F0aW9ucy91bnN1YnNjcmliZS1hdXRoL0FG
MzZaU3Y5WjZBU2RoR3F4dnZhWUR0SmFVSk1uNk5ja3M1dWozV1hnYUpwWk00WFdUMzEiPm11dGUg
dGhlIHRocmVhZDwvYT4uPGltZyBzcmM9Imh0dHBzOi8vZ2l0aHViLmNvbS9ub3RpZmljYXRpb25z
L2JlYWNvbi9BRjM2WmRoV2JOQUFoTWJ2SXRyZ3F0bFRPS2thT05jdWtzNXVqM1dYZ2FKcFpNNFhX
VDMxLmdpZiIgaGVpZ2h0PSIxIiB3aWR0aD0iMSIgYWx0PSIiIC8+PC9wPgo8c2NyaXB0IHR5cGU9
ImFwcGxpY2F0aW9uL2pzb24iIGRhdGEtc2NvcGU9ImluYm94bWFya3VwIj57ImFwaV92ZXJzaW9u
IjoiMS4wIiwicHVibGlzaGVyIjp7ImFwaV9rZXkiOiIwNWRkZTUwZjFkMWEzODRkZDc4NzY3YzU1
NDkzZTRiYiIsIm5hbWUiOiJHaXRIdWIifSwiZW50aXR5Ijp7ImV4dGVybmFsX2tleSI6ImdpdGh1
Yi9rYW1haWxpby9rYW1haWxpbyIsInRpdGxlIjoia2FtYWlsaW8va2FtYWlsaW8iLCJzdWJ0aXRs
ZSI6IkdpdEh1YiByZXBvc2l0b3J5IiwibWFpbl9pbWFnZV91cmwiOiJodHRwczovL2Fzc2V0cy1j
ZG4uZ2l0aHViLmNvbS9pbWFnZXMvZW1haWwvbWVzc2FnZV9jYXJkcy9oZWFkZXIucG5nIiwiYXZh
dGFyX2ltYWdlX3VybCI6Imh0dHBzOi8vYXNzZXRzLWNkbi5naXRodWIuY29tL2ltYWdlcy9lbWFp
bC9tZXNzYWdlX2NhcmRzL2F2YXRhci5wbmciLCJhY3Rpb24iOnsibmFtZSI6Ik9wZW4gaW4gR2l0
SHViIiwidXJsIjoiaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvIn19LCJ1cGRh
dGVzIjp7InNuaXBwZXRzIjpbeyJpY29uIjoiUEVSU09OIiwibWVzc2FnZSI6IkBqY2hhdmFudG9u
IGluICMxNjczOiBqdXN0IGEgbGl0dGxlIHVwZGF0ZSwgSSB0aGlzIHNob3VsZCBiZSBoYW5kbGVk
IHByb3Blcmx5IHNpbmNlIHRoZSAgZmxhZ3Mgc2hvdWxkIGJlIGtlcHQgZXZlbiBpZiBtb2RpZmll
ZCBieSBhIHRyYW5zYWN0aW9uIGNhbGxiYWNrLCBnb29kIG5vdyBJIG5lZWQgdG8gZmluZCBvdXQg
d2h5IHRoaXMgaXMgbm90IHRha2luZyBwbGFjZS5cclxuYGBgXHJcbi8qIGlmIGZhaWx1cmUgaGFu
ZGxlciBjaGFuZ2VkIGZsYWcsIHVwZGF0ZSB0cmFuc2FjdGlvbiBjb250ZXh0ICovXHJcbnNobWVt
X21zZy1cdTAwM2VmbGFncyA9IGZha2VkX3JlcS1cdTAwM2VmbGFncztcclxuYGBgXHJcbiJ9XSwi
YWN0aW9uIjp7Im5hbWUiOiJWaWV3IElzc3VlIiwidXJsIjoiaHR0cHM6Ly9naXRodWIuY29tL2th
bWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczI2lzc3VlY29tbWVudC00MjkwMjk5MjMifX19PC9z
Y3JpcHQ+CjxzY3JpcHQgdHlwZT0iYXBwbGljYXRpb24vbGQranNvbiI+Wwp7CiJAY29udGV4dCI6
ICJodHRwOi8vc2NoZW1hLm9yZyIsCiJAdHlwZSI6ICJFbWFpbE1lc3NhZ2UiLAoicG90ZW50aWFs
QWN0aW9uIjogewoiQHR5cGUiOiAiVmlld0FjdGlvbiIsCiJ0YXJnZXQiOiAiaHR0cHM6Ly9naXRo
dWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczI2lzc3VlY29tbWVudC00MjkwMjk5
MjMiLAoidXJsIjogImh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9pc3N1ZXMv
MTY3MyNpc3N1ZWNvbW1lbnQtNDI5MDI5OTIzIiwKIm5hbWUiOiAiVmlldyBJc3N1ZSIKfSwKImRl
c2NyaXB0aW9uIjogIlZpZXcgdGhpcyBJc3N1ZSBvbiBHaXRIdWIiLAoicHVibGlzaGVyIjogewoi
QHR5cGUiOiAiT3JnYW5pemF0aW9uIiwKIm5hbWUiOiAiR2l0SHViIiwKInVybCI6ICJodHRwczov
L2dpdGh1Yi5jb20iCn0KfSwKewoiQHR5cGUiOiAiTWVzc2FnZUNhcmQiLAoiQGNvbnRleHQiOiAi
aHR0cDovL3NjaGVtYS5vcmcvZXh0ZW5zaW9ucyIsCiJoaWRlT3JpZ2luYWxCb2R5IjogImZhbHNl
IiwKIm9yaWdpbmF0b3IiOiAiQUY2QzVBODYtRTkyMC00MzBDLTlDNTktQTczMjc4QjVFRkVCIiwK
InRpdGxlIjogIlJlOiBba2FtYWlsaW8va2FtYWlsaW9dIGFjYzogZ2VuZXJhdGluZyBkdXBsaWNh
dGVzIG9uIG1pc3NlZCAvIGZhaWxlZCBjYWxscyAoIzE2NzMpIiwKInNlY3Rpb25zIjogWwp7CiJ0
ZXh0IjogIiIsCiJhY3Rpdml0eVRpdGxlIjogIioqSnVsaWVuIENoYXZhbnRvbioqIiwKImFjdGl2
aXR5SW1hZ2UiOiAiaHR0cHM6Ly9hc3NldHMtY2RuLmdpdGh1Yi5jb20vaW1hZ2VzL2VtYWlsL21l
c3NhZ2VfY2FyZHMvYXZhdGFyLnBuZyIsCiJhY3Rpdml0eVN1YnRpdGxlIjogIkBqY2hhdmFudG9u
IiwKImZhY3RzIjogWwoKXQp9Cl0sCiJwb3RlbnRpYWxBY3Rpb24iOiBbCnsKIm5hbWUiOiAiQWRk
IGEgY29tbWVudCIsCiJAdHlwZSI6ICJBY3Rpb25DYXJkIiwKImlucHV0cyI6IFsKewoiaXNNdWx0
aUxpbmUiOiB0cnVlLAoiQHR5cGUiOiAiVGV4dElucHV0IiwKImlkIjogIklzc3VlQ29tbWVudCIs
CiJpc1JlcXVpcmVkIjogZmFsc2UKfQpdLAoiYWN0aW9ucyI6IFsKewoibmFtZSI6ICJDb21tZW50
IiwKIkB0eXBlIjogIkh0dHBQT1NUIiwKInRhcmdldCI6ICJodHRwczovL2FwaS5naXRodWIuY29t
IiwKImJvZHkiOiAie1xuXCJjb21tYW5kTmFtZVwiOiBcIklzc3VlQ29tbWVudFwiLFxuXCJyZXBv
c2l0b3J5RnVsbE5hbWVcIjogXCJrYW1haWxpby9rYW1haWxpb1wiLFxuXCJpc3N1ZUlkXCI6IDE2
NzMsXG5cIklzc3VlQ29tbWVudFwiOiBcInt7SXNzdWVDb21tZW50LnZhbHVlfX1cIlxufSIKfQpd
Cn0sCnsKIm5hbWUiOiAiQ2xvc2UgaXNzdWUiLAoiQHR5cGUiOiAiSHR0cFBPU1QiLAoidGFyZ2V0
IjogImh0dHBzOi8vYXBpLmdpdGh1Yi5jb20iLAoiYm9keSI6ICJ7XG5cImNvbW1hbmROYW1lXCI6
IFwiSXNzdWVDbG9zZVwiLFxuXCJyZXBvc2l0b3J5RnVsbE5hbWVcIjogXCJrYW1haWxpby9rYW1h
aWxpb1wiLFxuXCJpc3N1ZUlkXCI6IDE2NzNcbn0iCn0sCnsKInRhcmdldHMiOiBbCnsKIm9zIjog
ImRlZmF1bHQiLAoidXJpIjogImh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9p
c3N1ZXMvMTY3MyNpc3N1ZWNvbW1lbnQtNDI5MDI5OTIzIgp9Cl0sCiJAdHlwZSI6ICJPcGVuVXJp
IiwKIm5hbWUiOiAiVmlldyBvbiBHaXRIdWIiCn0sCnsKIm5hbWUiOiAiVW5zdWJzY3JpYmUiLAoi
QHR5cGUiOiAiSHR0cFBPU1QiLAoidGFyZ2V0IjogImh0dHBzOi8vYXBpLmdpdGh1Yi5jb20iLAoi
Ym9keSI6ICJ7XG5cImNvbW1hbmROYW1lXCI6IFwiTXV0ZU5vdGlmaWNhdGlvblwiLFxuXCJ0aHJl
YWRJZFwiOiAzOTE3MjQ1MzNcbn0iCn0KXSwKInRoZW1lQ29sb3IiOiAiMjYyOTJFIgp9Cl08L3Nj
cmlwdD4=

--===============0195370544==--


From notifications@github.com Thu Oct 11 20:22:02 2018
From: Julien Chavanton <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio/kamailio] acc: generating duplicates on missed
 / failed calls (#1673)
Date: Thu, 11 Oct 2018 11:21:55 -0700
Message-ID: <kamailio/kamailio/issues/1673/429066023@github.com>
In-Reply-To: <kamailio/kamailio/issues/1673@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0796516857=="

--===============0796516857==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

I found consufion about using the integer value of the flag when checking it.

acc_run_engines
```
  if((type==1) && (msg->flags&(e->missed_flag))) {
```
and 
is_eng_acc_on 
```
 if(msg->flags & e->missed_flag) {
```

However when we reset it we use the bit position value
```
reset_acc_flag( req, flags_to_reset ); 
#define reset_acc_flag(_rq,_flag)   (resetflag((_rq), (_flag))) 
```

Looking at this further

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1673#issuecomment-429066023



--===============0796516857==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+SSBmb3VuZCBjb25zdWZpb24gYWJvdXQgdXNpbmcgdGhlIGludGVnZXIgdmFsdWUgb2YgdGhl
IGZsYWcgd2hlbiBjaGVja2luZyBpdC48L3A+CjxwPmFjY19ydW5fZW5naW5lczwvcD4KPHByZT48
Y29kZT4gIGlmKCh0eXBlPT0xKSAmYW1wOyZhbXA7IChtc2ctJmd0O2ZsYWdzJmFtcDsoZS0mZ3Q7
bWlzc2VkX2ZsYWcpKSkgewo8L2NvZGU+PC9wcmU+CjxwPmFuZDxicj4KaXNfZW5nX2FjY19vbjwv
cD4KPHByZT48Y29kZT4gaWYobXNnLSZndDtmbGFncyAmYW1wOyBlLSZndDttaXNzZWRfZmxhZykg
ewo8L2NvZGU+PC9wcmU+CjxwPkhvd2V2ZXIgd2hlbiB3ZSByZXNldCBpdCB3ZSB1c2UgdGhlIGJp
dCBwb3NpdGlvbiB2YWx1ZTwvcD4KPHByZT48Y29kZT5yZXNldF9hY2NfZmxhZyggcmVxLCBmbGFn
c190b19yZXNldCApOyAKI2RlZmluZSByZXNldF9hY2NfZmxhZyhfcnEsX2ZsYWcpICAgKHJlc2V0
ZmxhZygoX3JxKSwgKF9mbGFnKSkpIAo8L2NvZGU+PC9wcmU+CjxwPkxvb2tpbmcgYXQgdGhpcyBm
dXJ0aGVyPC9wPgoKPHAgc3R5bGU9ImZvbnQtc2l6ZTpzbWFsbDstd2Via2l0LXRleHQtc2l6ZS1h
ZGp1c3Q6bm9uZTtjb2xvcjojNjY2OyI+Jm1kYXNoOzxiciAvPllvdSBhcmUgcmVjZWl2aW5nIHRo
aXMgYmVjYXVzZSB5b3UgYXJlIHN1YnNjcmliZWQgdG8gdGhpcyB0aHJlYWQuPGJyIC8+UmVwbHkg
dG8gdGhpcyBlbWFpbCBkaXJlY3RseSwgPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2thbWFp
bGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczI2lzc3VlY29tbWVudC00MjkwNjYwMjMiPnZpZXcgaXQg
b24gR2l0SHViPC9hPiwgb3IgPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL25vdGlmaWNhdGlv
bnMvdW5zdWJzY3JpYmUtYXV0aC9BRjM2WlNlVWw0T0N2YTN0RFFmN2luVVZBQy1FY3dEZmtzNXVq
NHhEZ2FKcFpNNFhXVDMxIj5tdXRlIHRoZSB0aHJlYWQ8L2E+LjxpbWcgc3JjPSJodHRwczovL2dp
dGh1Yi5jb20vbm90aWZpY2F0aW9ucy9iZWFjb24vQUYzNlpkMDRKWHNYUUF1bnBYc25xNXJHa2ky
OEdsTjFrczV1ajR4RGdhSnBaTTRYV1QzMS5naWYiIGhlaWdodD0iMSIgd2lkdGg9IjEiIGFsdD0i
IiAvPjwvcD4KPHNjcmlwdCB0eXBlPSJhcHBsaWNhdGlvbi9qc29uIiBkYXRhLXNjb3BlPSJpbmJv
eG1hcmt1cCI+eyJhcGlfdmVyc2lvbiI6IjEuMCIsInB1Ymxpc2hlciI6eyJhcGlfa2V5IjoiMDVk
ZGU1MGYxZDFhMzg0ZGQ3ODc2N2M1NTQ5M2U0YmIiLCJuYW1lIjoiR2l0SHViIn0sImVudGl0eSI6
eyJleHRlcm5hbF9rZXkiOiJnaXRodWIva2FtYWlsaW8va2FtYWlsaW8iLCJ0aXRsZSI6ImthbWFp
bGlvL2thbWFpbGlvIiwic3VidGl0bGUiOiJHaXRIdWIgcmVwb3NpdG9yeSIsIm1haW5faW1hZ2Vf
dXJsIjoiaHR0cHM6Ly9hc3NldHMtY2RuLmdpdGh1Yi5jb20vaW1hZ2VzL2VtYWlsL21lc3NhZ2Vf
Y2FyZHMvaGVhZGVyLnBuZyIsImF2YXRhcl9pbWFnZV91cmwiOiJodHRwczovL2Fzc2V0cy1jZG4u
Z2l0aHViLmNvbS9pbWFnZXMvZW1haWwvbWVzc2FnZV9jYXJkcy9hdmF0YXIucG5nIiwiYWN0aW9u
Ijp7Im5hbWUiOiJPcGVuIGluIEdpdEh1YiIsInVybCI6Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1h
aWxpby9rYW1haWxpbyJ9fSwidXBkYXRlcyI6eyJzbmlwcGV0cyI6W3siaWNvbiI6IlBFUlNPTiIs
Im1lc3NhZ2UiOiJAamNoYXZhbnRvbiBpbiAjMTY3MzogSSBmb3VuZCBjb25zdWZpb24gYWJvdXQg
dXNpbmcgdGhlIGludGVnZXIgdmFsdWUgb2YgdGhlIGZsYWcgd2hlbiBjaGVja2luZyBpdC5cclxu
XHJcbmFjY19ydW5fZW5naW5lc1xyXG5gYGBcclxuICBpZigodHlwZT09MSkgXHUwMDI2XHUwMDI2
IChtc2ctXHUwMDNlZmxhZ3NcdTAwMjYoZS1cdTAwM2VtaXNzZWRfZmxhZykpKSB7XHJcbmBgYFxy
XG5hbmQgXHJcbmlzX2VuZ19hY2Nfb24gXHJcbmBgYFxyXG4gaWYobXNnLVx1MDAzZWZsYWdzIFx1
MDAyNiBlLVx1MDAzZW1pc3NlZF9mbGFnKSB7XHJcbmBgYFxyXG5cclxuSG93ZXZlciB3aGVuIHdl
IHJlc2V0IGl0IHdlIHVzZSB0aGUgYml0IHBvc2l0aW9uIHZhbHVlXHJcbmBgYFxyXG5yZXNldF9h
Y2NfZmxhZyggcmVxLCBmbGFnc190b19yZXNldCApOyBcclxuI2RlZmluZSByZXNldF9hY2NfZmxh
ZyhfcnEsX2ZsYWcpICAgKHJlc2V0ZmxhZygoX3JxKSwgKF9mbGFnKSkpIFxyXG5gYGBcclxuXHJc
bkxvb2tpbmcgYXQgdGhpcyBmdXJ0aGVyIn1dLCJhY3Rpb24iOnsibmFtZSI6IlZpZXcgSXNzdWUi
LCJ1cmwiOiJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNzdWVzLzE2NzMj
aXNzdWVjb21tZW50LTQyOTA2NjAyMyJ9fX08L3NjcmlwdD4KPHNjcmlwdCB0eXBlPSJhcHBsaWNh
dGlvbi9sZCtqc29uIj5bCnsKIkBjb250ZXh0IjogImh0dHA6Ly9zY2hlbWEub3JnIiwKIkB0eXBl
IjogIkVtYWlsTWVzc2FnZSIsCiJwb3RlbnRpYWxBY3Rpb24iOiB7CiJAdHlwZSI6ICJWaWV3QWN0
aW9uIiwKInRhcmdldCI6ICJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNz
dWVzLzE2NzMjaXNzdWVjb21tZW50LTQyOTA2NjAyMyIsCiJ1cmwiOiAiaHR0cHM6Ly9naXRodWIu
Y29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczI2lzc3VlY29tbWVudC00MjkwNjYwMjMi
LAoibmFtZSI6ICJWaWV3IElzc3VlIgp9LAoiZGVzY3JpcHRpb24iOiAiVmlldyB0aGlzIElzc3Vl
IG9uIEdpdEh1YiIsCiJwdWJsaXNoZXIiOiB7CiJAdHlwZSI6ICJPcmdhbml6YXRpb24iLAoibmFt
ZSI6ICJHaXRIdWIiLAoidXJsIjogImh0dHBzOi8vZ2l0aHViLmNvbSIKfQp9LAp7CiJAdHlwZSI6
ICJNZXNzYWdlQ2FyZCIsCiJAY29udGV4dCI6ICJodHRwOi8vc2NoZW1hLm9yZy9leHRlbnNpb25z
IiwKImhpZGVPcmlnaW5hbEJvZHkiOiAiZmFsc2UiLAoib3JpZ2luYXRvciI6ICJBRjZDNUE4Ni1F
OTIwLTQzMEMtOUM1OS1BNzMyNzhCNUVGRUIiLAoidGl0bGUiOiAiUmU6IFtrYW1haWxpby9rYW1h
aWxpb10gYWNjOiBnZW5lcmF0aW5nIGR1cGxpY2F0ZXMgb24gbWlzc2VkIC8gZmFpbGVkIGNhbGxz
ICgjMTY3MykiLAoic2VjdGlvbnMiOiBbCnsKInRleHQiOiAiIiwKImFjdGl2aXR5VGl0bGUiOiAi
KipKdWxpZW4gQ2hhdmFudG9uKioiLAoiYWN0aXZpdHlJbWFnZSI6ICJodHRwczovL2Fzc2V0cy1j
ZG4uZ2l0aHViLmNvbS9pbWFnZXMvZW1haWwvbWVzc2FnZV9jYXJkcy9hdmF0YXIucG5nIiwKImFj
dGl2aXR5U3VidGl0bGUiOiAiQGpjaGF2YW50b24iLAoiZmFjdHMiOiBbCgpdCn0KXSwKInBvdGVu
dGlhbEFjdGlvbiI6IFsKewoibmFtZSI6ICJBZGQgYSBjb21tZW50IiwKIkB0eXBlIjogIkFjdGlv
bkNhcmQiLAoiaW5wdXRzIjogWwp7CiJpc011bHRpTGluZSI6IHRydWUsCiJAdHlwZSI6ICJUZXh0
SW5wdXQiLAoiaWQiOiAiSXNzdWVDb21tZW50IiwKImlzUmVxdWlyZWQiOiBmYWxzZQp9Cl0sCiJh
Y3Rpb25zIjogWwp7CiJuYW1lIjogIkNvbW1lbnQiLAoiQHR5cGUiOiAiSHR0cFBPU1QiLAoidGFy
Z2V0IjogImh0dHBzOi8vYXBpLmdpdGh1Yi5jb20iLAoiYm9keSI6ICJ7XG5cImNvbW1hbmROYW1l
XCI6IFwiSXNzdWVDb21tZW50XCIsXG5cInJlcG9zaXRvcnlGdWxsTmFtZVwiOiBcImthbWFpbGlv
L2thbWFpbGlvXCIsXG5cImlzc3VlSWRcIjogMTY3MyxcblwiSXNzdWVDb21tZW50XCI6IFwie3tJ
c3N1ZUNvbW1lbnQudmFsdWV9fVwiXG59Igp9Cl0KfSwKewoibmFtZSI6ICJDbG9zZSBpc3N1ZSIs
CiJAdHlwZSI6ICJIdHRwUE9TVCIsCiJ0YXJnZXQiOiAiaHR0cHM6Ly9hcGkuZ2l0aHViLmNvbSIs
CiJib2R5IjogIntcblwiY29tbWFuZE5hbWVcIjogXCJJc3N1ZUNsb3NlXCIsXG5cInJlcG9zaXRv
cnlGdWxsTmFtZVwiOiBcImthbWFpbGlvL2thbWFpbGlvXCIsXG5cImlzc3VlSWRcIjogMTY3M1xu
fSIKfSwKewoidGFyZ2V0cyI6IFsKewoib3MiOiAiZGVmYXVsdCIsCiJ1cmkiOiAiaHR0cHM6Ly9n
aXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczI2lzc3VlY29tbWVudC00Mjkw
NjYwMjMiCn0KXSwKIkB0eXBlIjogIk9wZW5VcmkiLAoibmFtZSI6ICJWaWV3IG9uIEdpdEh1YiIK
fSwKewoibmFtZSI6ICJVbnN1YnNjcmliZSIsCiJAdHlwZSI6ICJIdHRwUE9TVCIsCiJ0YXJnZXQi
OiAiaHR0cHM6Ly9hcGkuZ2l0aHViLmNvbSIsCiJib2R5IjogIntcblwiY29tbWFuZE5hbWVcIjog
XCJNdXRlTm90aWZpY2F0aW9uXCIsXG5cInRocmVhZElkXCI6IDM5MTcyNDUzM1xufSIKfQpdLAoi
dGhlbWVDb2xvciI6ICIyNjI5MkUiCn0KXTwvc2NyaXB0Pg==

--===============0796516857==--


From notifications@github.com Fri Oct 12 13:44:50 2018
From: Henning Westerholt <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio/kamailio] acc: generating duplicates on missed
 / failed calls (#1673)
Date: Fri, 12 Oct 2018 04:44:41 -0700
Message-ID: <kamailio/kamailio/issues/1673/429298464@github.com>
In-Reply-To: <kamailio/kamailio/issues/1673@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1932796354=="

--===============1932796354==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Commenting about the third topic directly in this issue. I don't understand t=
his remark:
"However when we reset it we use the (bit position value)"
```
reset_acc_flag( req, flags_to_reset );=20
#define reset_acc_flag(_rq,_flag)   (resetflag((_rq), (_flag)))=20
```
The function resetflag is defined in a similar logic as setflag: struct sip_m=
sg* msg, flag_t flag.
And flag_t is defined (as you correctly identified) as unsigned int.

--=20
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1673#issuecomment-429298464



--===============1932796354==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+Q29tbWVudGluZyBhYm91dCB0aGUgdGhpcmQgdG9waWMgZGlyZWN0bHkgaW4gdGhpcyBpc3N1
ZS4gSSBkb24ndCB1bmRlcnN0YW5kIHRoaXMgcmVtYXJrOjxicj4KIkhvd2V2ZXIgd2hlbiB3ZSBy
ZXNldCBpdCB3ZSB1c2UgdGhlIChiaXQgcG9zaXRpb24gdmFsdWUpIjwvcD4KPHByZT48Y29kZT5y
ZXNldF9hY2NfZmxhZyggcmVxLCBmbGFnc190b19yZXNldCApOyAKI2RlZmluZSByZXNldF9hY2Nf
ZmxhZyhfcnEsX2ZsYWcpICAgKHJlc2V0ZmxhZygoX3JxKSwgKF9mbGFnKSkpIAo8L2NvZGU+PC9w
cmU+CjxwPlRoZSBmdW5jdGlvbiByZXNldGZsYWcgaXMgZGVmaW5lZCBpbiBhIHNpbWlsYXIgbG9n
aWMgYXMgc2V0ZmxhZzogc3RydWN0IHNpcF9tc2cqIG1zZywgZmxhZ190IGZsYWcuPGJyPgpBbmQg
ZmxhZ190IGlzIGRlZmluZWQgKGFzIHlvdSBjb3JyZWN0bHkgaWRlbnRpZmllZCkgYXMgdW5zaWdu
ZWQgaW50LjwvcD4KCjxwIHN0eWxlPSJmb250LXNpemU6c21hbGw7LXdlYmtpdC10ZXh0LXNpemUt
YWRqdXN0Om5vbmU7Y29sb3I6IzY2NjsiPiZtZGFzaDs8YnIgLz5Zb3UgYXJlIHJlY2VpdmluZyB0
aGlzIGJlY2F1c2UgeW91IGFyZSBzdWJzY3JpYmVkIHRvIHRoaXMgdGhyZWFkLjxiciAvPlJlcGx5
IHRvIHRoaXMgZW1haWwgZGlyZWN0bHksIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1h
aWxpby9rYW1haWxpby9pc3N1ZXMvMTY3MyNpc3N1ZWNvbW1lbnQtNDI5Mjk4NDY0Ij52aWV3IGl0
IG9uIEdpdEh1YjwvYT4sIG9yIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9ub3RpZmljYXRp
b25zL3Vuc3Vic2NyaWJlLWF1dGgvQUYzNlpmcEotR0NuSEk3X3lMNko2aDVvMy1sU3dQRnlrczV1
a0lDcGdhSnBaTTRYV1QzMSI+bXV0ZSB0aGUgdGhyZWFkPC9hPi48aW1nIHNyYz0iaHR0cHM6Ly9n
aXRodWIuY29tL25vdGlmaWNhdGlvbnMvYmVhY29uL0FGMzZaVDUxUmlVWjJlLWR3bDRtSi1CV1pC
WG5fQy1Qa3M1dWtJQ3BnYUpwWk00WFdUMzEuZ2lmIiBoZWlnaHQ9IjEiIHdpZHRoPSIxIiBhbHQ9
IiIgLz48L3A+CjxzY3JpcHQgdHlwZT0iYXBwbGljYXRpb24vanNvbiIgZGF0YS1zY29wZT0iaW5i
b3htYXJrdXAiPnsiYXBpX3ZlcnNpb24iOiIxLjAiLCJwdWJsaXNoZXIiOnsiYXBpX2tleSI6IjA1
ZGRlNTBmMWQxYTM4NGRkNzg3NjdjNTU0OTNlNGJiIiwibmFtZSI6IkdpdEh1YiJ9LCJlbnRpdHki
OnsiZXh0ZXJuYWxfa2V5IjoiZ2l0aHViL2thbWFpbGlvL2thbWFpbGlvIiwidGl0bGUiOiJrYW1h
aWxpby9rYW1haWxpbyIsInN1YnRpdGxlIjoiR2l0SHViIHJlcG9zaXRvcnkiLCJtYWluX2ltYWdl
X3VybCI6Imh0dHBzOi8vYXNzZXRzLWNkbi5naXRodWIuY29tL2ltYWdlcy9lbWFpbC9tZXNzYWdl
X2NhcmRzL2hlYWRlci5wbmciLCJhdmF0YXJfaW1hZ2VfdXJsIjoiaHR0cHM6Ly9hc3NldHMtY2Ru
LmdpdGh1Yi5jb20vaW1hZ2VzL2VtYWlsL21lc3NhZ2VfY2FyZHMvYXZhdGFyLnBuZyIsImFjdGlv
biI6eyJuYW1lIjoiT3BlbiBpbiBHaXRIdWIiLCJ1cmwiOiJodHRwczovL2dpdGh1Yi5jb20va2Ft
YWlsaW8va2FtYWlsaW8ifX0sInVwZGF0ZXMiOnsic25pcHBldHMiOlt7Imljb24iOiJQRVJTT04i
LCJtZXNzYWdlIjoiQGhlbm5pbmd3IGluICMxNjczOiBDb21tZW50aW5nIGFib3V0IHRoZSB0aGly
ZCB0b3BpYyBkaXJlY3RseSBpbiB0aGlzIGlzc3VlLiBJIGRvbid0IHVuZGVyc3RhbmQgdGhpcyBy
ZW1hcms6XHJcblwiSG93ZXZlciB3aGVuIHdlIHJlc2V0IGl0IHdlIHVzZSB0aGUgKGJpdCBwb3Np
dGlvbiB2YWx1ZSlcIlxyXG5gYGBcclxucmVzZXRfYWNjX2ZsYWcoIHJlcSwgZmxhZ3NfdG9fcmVz
ZXQgKTsgXHJcbiNkZWZpbmUgcmVzZXRfYWNjX2ZsYWcoX3JxLF9mbGFnKSAgIChyZXNldGZsYWco
KF9ycSksIChfZmxhZykpKSBcclxuYGBgXHJcblRoZSBmdW5jdGlvbiByZXNldGZsYWcgaXMgZGVm
aW5lZCBpbiBhIHNpbWlsYXIgbG9naWMgYXMgc2V0ZmxhZzogc3RydWN0IHNpcF9tc2cqIG1zZywg
ZmxhZ190IGZsYWcuXHJcbkFuZCBmbGFnX3QgaXMgZGVmaW5lZCAoYXMgeW91IGNvcnJlY3RseSBp
ZGVudGlmaWVkKSBhcyB1bnNpZ25lZCBpbnQuIn1dLCJhY3Rpb24iOnsibmFtZSI6IlZpZXcgSXNz
dWUiLCJ1cmwiOiJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNzdWVzLzE2
NzMjaXNzdWVjb21tZW50LTQyOTI5ODQ2NCJ9fX08L3NjcmlwdD4KPHNjcmlwdCB0eXBlPSJhcHBs
aWNhdGlvbi9sZCtqc29uIj5bCnsKIkBjb250ZXh0IjogImh0dHA6Ly9zY2hlbWEub3JnIiwKIkB0
eXBlIjogIkVtYWlsTWVzc2FnZSIsCiJwb3RlbnRpYWxBY3Rpb24iOiB7CiJAdHlwZSI6ICJWaWV3
QWN0aW9uIiwKInRhcmdldCI6ICJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8v
aXNzdWVzLzE2NzMjaXNzdWVjb21tZW50LTQyOTI5ODQ2NCIsCiJ1cmwiOiAiaHR0cHM6Ly9naXRo
dWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczI2lzc3VlY29tbWVudC00MjkyOTg0
NjQiLAoibmFtZSI6ICJWaWV3IElzc3VlIgp9LAoiZGVzY3JpcHRpb24iOiAiVmlldyB0aGlzIElz
c3VlIG9uIEdpdEh1YiIsCiJwdWJsaXNoZXIiOiB7CiJAdHlwZSI6ICJPcmdhbml6YXRpb24iLAoi
bmFtZSI6ICJHaXRIdWIiLAoidXJsIjogImh0dHBzOi8vZ2l0aHViLmNvbSIKfQp9LAp7CiJAdHlw
ZSI6ICJNZXNzYWdlQ2FyZCIsCiJAY29udGV4dCI6ICJodHRwOi8vc2NoZW1hLm9yZy9leHRlbnNp
b25zIiwKImhpZGVPcmlnaW5hbEJvZHkiOiAiZmFsc2UiLAoib3JpZ2luYXRvciI6ICJBRjZDNUE4
Ni1FOTIwLTQzMEMtOUM1OS1BNzMyNzhCNUVGRUIiLAoidGl0bGUiOiAiUmU6IFtrYW1haWxpby9r
YW1haWxpb10gYWNjOiBnZW5lcmF0aW5nIGR1cGxpY2F0ZXMgb24gbWlzc2VkIC8gZmFpbGVkIGNh
bGxzICgjMTY3MykiLAoic2VjdGlvbnMiOiBbCnsKInRleHQiOiAiIiwKImFjdGl2aXR5VGl0bGUi
OiAiKipIZW5uaW5nIFdlc3RlcmhvbHQqKiIsCiJhY3Rpdml0eUltYWdlIjogImh0dHBzOi8vYXNz
ZXRzLWNkbi5naXRodWIuY29tL2ltYWdlcy9lbWFpbC9tZXNzYWdlX2NhcmRzL2F2YXRhci5wbmci
LAoiYWN0aXZpdHlTdWJ0aXRsZSI6ICJAaGVubmluZ3ciLAoiZmFjdHMiOiBbCgpdCn0KXSwKInBv
dGVudGlhbEFjdGlvbiI6IFsKewoibmFtZSI6ICJBZGQgYSBjb21tZW50IiwKIkB0eXBlIjogIkFj
dGlvbkNhcmQiLAoiaW5wdXRzIjogWwp7CiJpc011bHRpTGluZSI6IHRydWUsCiJAdHlwZSI6ICJU
ZXh0SW5wdXQiLAoiaWQiOiAiSXNzdWVDb21tZW50IiwKImlzUmVxdWlyZWQiOiBmYWxzZQp9Cl0s
CiJhY3Rpb25zIjogWwp7CiJuYW1lIjogIkNvbW1lbnQiLAoiQHR5cGUiOiAiSHR0cFBPU1QiLAoi
dGFyZ2V0IjogImh0dHBzOi8vYXBpLmdpdGh1Yi5jb20iLAoiYm9keSI6ICJ7XG5cImNvbW1hbmRO
YW1lXCI6IFwiSXNzdWVDb21tZW50XCIsXG5cInJlcG9zaXRvcnlGdWxsTmFtZVwiOiBcImthbWFp
bGlvL2thbWFpbGlvXCIsXG5cImlzc3VlSWRcIjogMTY3MyxcblwiSXNzdWVDb21tZW50XCI6IFwi
e3tJc3N1ZUNvbW1lbnQudmFsdWV9fVwiXG59Igp9Cl0KfSwKewoibmFtZSI6ICJDbG9zZSBpc3N1
ZSIsCiJAdHlwZSI6ICJIdHRwUE9TVCIsCiJ0YXJnZXQiOiAiaHR0cHM6Ly9hcGkuZ2l0aHViLmNv
bSIsCiJib2R5IjogIntcblwiY29tbWFuZE5hbWVcIjogXCJJc3N1ZUNsb3NlXCIsXG5cInJlcG9z
aXRvcnlGdWxsTmFtZVwiOiBcImthbWFpbGlvL2thbWFpbGlvXCIsXG5cImlzc3VlSWRcIjogMTY3
M1xufSIKfSwKewoidGFyZ2V0cyI6IFsKewoib3MiOiAiZGVmYXVsdCIsCiJ1cmkiOiAiaHR0cHM6
Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczI2lzc3VlY29tbWVudC00
MjkyOTg0NjQiCn0KXSwKIkB0eXBlIjogIk9wZW5VcmkiLAoibmFtZSI6ICJWaWV3IG9uIEdpdEh1
YiIKfSwKewoibmFtZSI6ICJVbnN1YnNjcmliZSIsCiJAdHlwZSI6ICJIdHRwUE9TVCIsCiJ0YXJn
ZXQiOiAiaHR0cHM6Ly9hcGkuZ2l0aHViLmNvbSIsCiJib2R5IjogIntcblwiY29tbWFuZE5hbWVc
IjogXCJNdXRlTm90aWZpY2F0aW9uXCIsXG5cInRocmVhZElkXCI6IDM5MTcyNDUzM1xufSIKfQpd
LAoidGhlbWVDb2xvciI6ICIyNjI5MkUiCn0KXTwvc2NyaXB0Pg==

--===============1932796354==--


From notifications@github.com Thu Nov  1 21:32:17 2018
From: Henning Westerholt <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio/kamailio] acc: generating duplicates on missed
 / failed calls (#1673)
Date: Thu, 01 Nov 2018 13:32:11 -0700
Message-ID: <kamailio/kamailio/issue/1673/issue_event/1941515834@github.com>
In-Reply-To: <kamailio/kamailio/issues/1673@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1596881216=="

--===============1596881216==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Closed #1673.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1673#event-1941515834



--===============1596881216==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+Q2xvc2VkIDxhIGNsYXNzPSJpc3N1ZS1saW5rIGpzLWlzc3VlLWxpbmsiIGRhdGEtZXJyb3It
dGV4dD0iRmFpbGVkIHRvIGxvYWQgaXNzdWUgdGl0bGUiIGRhdGEtaWQ9IjM2ODg0OTUwNyIgZGF0
YS1wZXJtaXNzaW9uLXRleHQ9Iklzc3VlIHRpdGxlIGlzIHByaXZhdGUiIGRhdGEtdXJsPSJodHRw
czovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNzdWVzLzE2NzMiIGRhdGEtaG92ZXJj
YXJkLXR5cGU9Imlzc3VlIiBkYXRhLWhvdmVyY2FyZC11cmw9Ii9rYW1haWxpby9rYW1haWxpby9p
c3N1ZXMvMTY3My9ob3ZlcmNhcmQiIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9r
YW1haWxpby9pc3N1ZXMvMTY3MyI+IzE2NzM8L2E+LjwvcD4KCjxwIHN0eWxlPSJmb250LXNpemU6
c21hbGw7LXdlYmtpdC10ZXh0LXNpemUtYWRqdXN0Om5vbmU7Y29sb3I6IzY2NjsiPiZtZGFzaDs8
YnIgLz5Zb3UgYXJlIHJlY2VpdmluZyB0aGlzIGJlY2F1c2UgeW91IGFyZSBzdWJzY3JpYmVkIHRv
IHRoaXMgdGhyZWFkLjxiciAvPlJlcGx5IHRvIHRoaXMgZW1haWwgZGlyZWN0bHksIDxhIGhyZWY9
Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9pc3N1ZXMvMTY3MyNldmVudC0x
OTQxNTE1ODM0Ij52aWV3IGl0IG9uIEdpdEh1YjwvYT4sIG9yIDxhIGhyZWY9Imh0dHBzOi8vZ2l0
aHViLmNvbS9ub3RpZmljYXRpb25zL3Vuc3Vic2NyaWJlLWF1dGgvQUYzNlpUMU5ndjZ0THpSRzAw
Q21XZkZPNmpYeGpydkhrczV1cTFwTGdhSnBaTTRYV1QzMSI+bXV0ZSB0aGUgdGhyZWFkPC9hPi48
aW1nIHNyYz0iaHR0cHM6Ly9naXRodWIuY29tL25vdGlmaWNhdGlvbnMvYmVhY29uL0FGMzZaVVN3
R2wwQ3RQcTZ2UmRtakc4REhJcVl2UGM4a3M1dXExcExnYUpwWk00WFdUMzEuZ2lmIiBoZWlnaHQ9
IjEiIHdpZHRoPSIxIiBhbHQ9IiIgLz48L3A+CjxzY3JpcHQgdHlwZT0iYXBwbGljYXRpb24vanNv
biIgZGF0YS1zY29wZT0iaW5ib3htYXJrdXAiPnsiYXBpX3ZlcnNpb24iOiIxLjAiLCJwdWJsaXNo
ZXIiOnsiYXBpX2tleSI6IjA1ZGRlNTBmMWQxYTM4NGRkNzg3NjdjNTU0OTNlNGJiIiwibmFtZSI6
IkdpdEh1YiJ9LCJlbnRpdHkiOnsiZXh0ZXJuYWxfa2V5IjoiZ2l0aHViL2thbWFpbGlvL2thbWFp
bGlvIiwidGl0bGUiOiJrYW1haWxpby9rYW1haWxpbyIsInN1YnRpdGxlIjoiR2l0SHViIHJlcG9z
aXRvcnkiLCJtYWluX2ltYWdlX3VybCI6Imh0dHBzOi8vYXNzZXRzLWNkbi5naXRodWIuY29tL2lt
YWdlcy9lbWFpbC9tZXNzYWdlX2NhcmRzL2hlYWRlci5wbmciLCJhdmF0YXJfaW1hZ2VfdXJsIjoi
aHR0cHM6Ly9hc3NldHMtY2RuLmdpdGh1Yi5jb20vaW1hZ2VzL2VtYWlsL21lc3NhZ2VfY2FyZHMv
YXZhdGFyLnBuZyIsImFjdGlvbiI6eyJuYW1lIjoiT3BlbiBpbiBHaXRIdWIiLCJ1cmwiOiJodHRw
czovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8ifX0sInVwZGF0ZXMiOnsic25pcHBldHMi
Olt7Imljb24iOiJERVNDUklQVElPTiIsIm1lc3NhZ2UiOiJDbG9zZWQgIzE2NzMuIn1dLCJhY3Rp
b24iOnsibmFtZSI6IlZpZXcgSXNzdWUiLCJ1cmwiOiJodHRwczovL2dpdGh1Yi5jb20va2FtYWls
aW8va2FtYWlsaW8vaXNzdWVzLzE2NzMjZXZlbnQtMTk0MTUxNTgzNCJ9fX08L3NjcmlwdD4KPHNj
cmlwdCB0eXBlPSJhcHBsaWNhdGlvbi9sZCtqc29uIj5bCnsKIkBjb250ZXh0IjogImh0dHA6Ly9z
Y2hlbWEub3JnIiwKIkB0eXBlIjogIkVtYWlsTWVzc2FnZSIsCiJwb3RlbnRpYWxBY3Rpb24iOiB7
CiJAdHlwZSI6ICJWaWV3QWN0aW9uIiwKInRhcmdldCI6ICJodHRwczovL2dpdGh1Yi5jb20va2Ft
YWlsaW8va2FtYWlsaW8vaXNzdWVzLzE2NzMjZXZlbnQtMTk0MTUxNTgzNCIsCiJ1cmwiOiAiaHR0
cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczI2V2ZW50LTE5NDE1
MTU4MzQiLAoibmFtZSI6ICJWaWV3IElzc3VlIgp9LAoiZGVzY3JpcHRpb24iOiAiVmlldyB0aGlz
IElzc3VlIG9uIEdpdEh1YiIsCiJwdWJsaXNoZXIiOiB7CiJAdHlwZSI6ICJPcmdhbml6YXRpb24i
LAoibmFtZSI6ICJHaXRIdWIiLAoidXJsIjogImh0dHBzOi8vZ2l0aHViLmNvbSIKfQp9LAp7CiJA
dHlwZSI6ICJNZXNzYWdlQ2FyZCIsCiJAY29udGV4dCI6ICJodHRwOi8vc2NoZW1hLm9yZy9leHRl
bnNpb25zIiwKImhpZGVPcmlnaW5hbEJvZHkiOiAiZmFsc2UiLAoib3JpZ2luYXRvciI6ICJBRjZD
NUE4Ni1FOTIwLTQzMEMtOUM1OS1BNzMyNzhCNUVGRUIiLAoidGl0bGUiOiAiUmU6IFtrYW1haWxp
by9rYW1haWxpb10gYWNjOiBnZW5lcmF0aW5nIGR1cGxpY2F0ZXMgb24gbWlzc2VkIC8gZmFpbGVk
IGNhbGxzICgjMTY3MykiLAoic2VjdGlvbnMiOiBbCnsKInRleHQiOiAiIiwKImFjdGl2aXR5VGl0
bGUiOiAiKipIZW5uaW5nIFdlc3RlcmhvbHQqKiIsCiJhY3Rpdml0eUltYWdlIjogImh0dHBzOi8v
YXNzZXRzLWNkbi5naXRodWIuY29tL2ltYWdlcy9lbWFpbC9tZXNzYWdlX2NhcmRzL2F2YXRhci5w
bmciLAoiYWN0aXZpdHlTdWJ0aXRsZSI6ICJAaGVubmluZ3ciLAoiZmFjdHMiOiBbCgpdCn0KXSwK
InBvdGVudGlhbEFjdGlvbiI6IFsKewoidGFyZ2V0cyI6IFsKewoib3MiOiAiZGVmYXVsdCIsCiJ1
cmkiOiAiaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczI2V2
ZW50LTE5NDE1MTU4MzQiCn0KXSwKIkB0eXBlIjogIk9wZW5VcmkiLAoibmFtZSI6ICJWaWV3IG9u
IEdpdEh1YiIKfSwKewoibmFtZSI6ICJVbnN1YnNjcmliZSIsCiJAdHlwZSI6ICJIdHRwUE9TVCIs
CiJ0YXJnZXQiOiAiaHR0cHM6Ly9hcGkuZ2l0aHViLmNvbSIsCiJib2R5IjogIntcblwiY29tbWFu
ZE5hbWVcIjogXCJNdXRlTm90aWZpY2F0aW9uXCIsXG5cInRocmVhZElkXCI6IDM5MTcyNDUzM1xu
fSIKfQpdLAoidGhlbWVDb2xvciI6ICIyNjI5MkUiCn0KXTwvc2NyaXB0Pg==

--===============1596881216==--


From notifications@github.com Thu Nov  1 21:32:18 2018
From: Henning Westerholt <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio/kamailio] acc: generating duplicates on missed
 / failed calls (#1673)
Date: Thu, 01 Nov 2018 13:32:10 -0700
Message-ID: <kamailio/kamailio/issues/1673/435176959@github.com>
In-Reply-To: <kamailio/kamailio/issues/1673@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0629373816=="

--===============0629373816==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Should be fixed by pull request #1674

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1673#issuecomment-435176959



--===============0629373816==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+U2hvdWxkIGJlIGZpeGVkIGJ5IHB1bGwgcmVxdWVzdCA8YSBjbGFzcz0iaXNzdWUtbGluayBq
cy1pc3N1ZS1saW5rIiBkYXRhLWVycm9yLXRleHQ9IkZhaWxlZCB0byBsb2FkIGlzc3VlIHRpdGxl
IiBkYXRhLWlkPSIzNjkyOTc5OTQiIGRhdGEtcGVybWlzc2lvbi10ZXh0PSJJc3N1ZSB0aXRsZSBp
cyBwcml2YXRlIiBkYXRhLXVybD0iaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlv
L2lzc3Vlcy8xNjc0IiBkYXRhLWhvdmVyY2FyZC10eXBlPSJwdWxsX3JlcXVlc3QiIGRhdGEtaG92
ZXJjYXJkLXVybD0iL2thbWFpbGlvL2thbWFpbGlvL3B1bGwvMTY3NC9ob3ZlcmNhcmQiIGhyZWY9
Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9wdWxsLzE2NzQiPiMxNjc0PC9h
PjwvcD4KCjxwIHN0eWxlPSJmb250LXNpemU6c21hbGw7LXdlYmtpdC10ZXh0LXNpemUtYWRqdXN0
Om5vbmU7Y29sb3I6IzY2NjsiPiZtZGFzaDs8YnIgLz5Zb3UgYXJlIHJlY2VpdmluZyB0aGlzIGJl
Y2F1c2UgeW91IGFyZSBzdWJzY3JpYmVkIHRvIHRoaXMgdGhyZWFkLjxiciAvPlJlcGx5IHRvIHRo
aXMgZW1haWwgZGlyZWN0bHksIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9r
YW1haWxpby9pc3N1ZXMvMTY3MyNpc3N1ZWNvbW1lbnQtNDM1MTc2OTU5Ij52aWV3IGl0IG9uIEdp
dEh1YjwvYT4sIG9yIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9ub3RpZmljYXRpb25zL3Vu
c3Vic2NyaWJlLWF1dGgvQUYzNlplT0FBUE1Mbm9aTG9fUTdlZ1lDZ3ZDd1dYdUFrczV1cTFwS2dh
SnBaTTRYV1QzMSI+bXV0ZSB0aGUgdGhyZWFkPC9hPi48aW1nIHNyYz0iaHR0cHM6Ly9naXRodWIu
Y29tL25vdGlmaWNhdGlvbnMvYmVhY29uL0FGMzZaVFkwVmdldkVDUVFWY2tEMGVLTG5JSTE1X0xr
a3M1dXExcEtnYUpwWk00WFdUMzEuZ2lmIiBoZWlnaHQ9IjEiIHdpZHRoPSIxIiBhbHQ9IiIgLz48
L3A+CjxzY3JpcHQgdHlwZT0iYXBwbGljYXRpb24vanNvbiIgZGF0YS1zY29wZT0iaW5ib3htYXJr
dXAiPnsiYXBpX3ZlcnNpb24iOiIxLjAiLCJwdWJsaXNoZXIiOnsiYXBpX2tleSI6IjA1ZGRlNTBm
MWQxYTM4NGRkNzg3NjdjNTU0OTNlNGJiIiwibmFtZSI6IkdpdEh1YiJ9LCJlbnRpdHkiOnsiZXh0
ZXJuYWxfa2V5IjoiZ2l0aHViL2thbWFpbGlvL2thbWFpbGlvIiwidGl0bGUiOiJrYW1haWxpby9r
YW1haWxpbyIsInN1YnRpdGxlIjoiR2l0SHViIHJlcG9zaXRvcnkiLCJtYWluX2ltYWdlX3VybCI6
Imh0dHBzOi8vYXNzZXRzLWNkbi5naXRodWIuY29tL2ltYWdlcy9lbWFpbC9tZXNzYWdlX2NhcmRz
L2hlYWRlci5wbmciLCJhdmF0YXJfaW1hZ2VfdXJsIjoiaHR0cHM6Ly9hc3NldHMtY2RuLmdpdGh1
Yi5jb20vaW1hZ2VzL2VtYWlsL21lc3NhZ2VfY2FyZHMvYXZhdGFyLnBuZyIsImFjdGlvbiI6eyJu
YW1lIjoiT3BlbiBpbiBHaXRIdWIiLCJ1cmwiOiJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8v
a2FtYWlsaW8ifX0sInVwZGF0ZXMiOnsic25pcHBldHMiOlt7Imljb24iOiJQRVJTT04iLCJtZXNz
YWdlIjoiQGhlbm5pbmd3IGluICMxNjczOiBTaG91bGQgYmUgZml4ZWQgYnkgcHVsbCByZXF1ZXN0
ICMxNjc0In1dLCJhY3Rpb24iOnsibmFtZSI6IlZpZXcgSXNzdWUiLCJ1cmwiOiJodHRwczovL2dp
dGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNzdWVzLzE2NzMjaXNzdWVjb21tZW50LTQzNTE3
Njk1OSJ9fX08L3NjcmlwdD4KPHNjcmlwdCB0eXBlPSJhcHBsaWNhdGlvbi9sZCtqc29uIj5bCnsK
IkBjb250ZXh0IjogImh0dHA6Ly9zY2hlbWEub3JnIiwKIkB0eXBlIjogIkVtYWlsTWVzc2FnZSIs
CiJwb3RlbnRpYWxBY3Rpb24iOiB7CiJAdHlwZSI6ICJWaWV3QWN0aW9uIiwKInRhcmdldCI6ICJo
dHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNzdWVzLzE2NzMjaXNzdWVjb21t
ZW50LTQzNTE3Njk1OSIsCiJ1cmwiOiAiaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFp
bGlvL2lzc3Vlcy8xNjczI2lzc3VlY29tbWVudC00MzUxNzY5NTkiLAoibmFtZSI6ICJWaWV3IElz
c3VlIgp9LAoiZGVzY3JpcHRpb24iOiAiVmlldyB0aGlzIElzc3VlIG9uIEdpdEh1YiIsCiJwdWJs
aXNoZXIiOiB7CiJAdHlwZSI6ICJPcmdhbml6YXRpb24iLAoibmFtZSI6ICJHaXRIdWIiLAoidXJs
IjogImh0dHBzOi8vZ2l0aHViLmNvbSIKfQp9LAp7CiJAdHlwZSI6ICJNZXNzYWdlQ2FyZCIsCiJA
Y29udGV4dCI6ICJodHRwOi8vc2NoZW1hLm9yZy9leHRlbnNpb25zIiwKImhpZGVPcmlnaW5hbEJv
ZHkiOiAiZmFsc2UiLAoib3JpZ2luYXRvciI6ICJBRjZDNUE4Ni1FOTIwLTQzMEMtOUM1OS1BNzMy
NzhCNUVGRUIiLAoidGl0bGUiOiAiUmU6IFtrYW1haWxpby9rYW1haWxpb10gYWNjOiBnZW5lcmF0
aW5nIGR1cGxpY2F0ZXMgb24gbWlzc2VkIC8gZmFpbGVkIGNhbGxzICgjMTY3MykiLAoic2VjdGlv
bnMiOiBbCnsKInRleHQiOiAiIiwKImFjdGl2aXR5VGl0bGUiOiAiKipIZW5uaW5nIFdlc3Rlcmhv
bHQqKiIsCiJhY3Rpdml0eUltYWdlIjogImh0dHBzOi8vYXNzZXRzLWNkbi5naXRodWIuY29tL2lt
YWdlcy9lbWFpbC9tZXNzYWdlX2NhcmRzL2F2YXRhci5wbmciLAoiYWN0aXZpdHlTdWJ0aXRsZSI6
ICJAaGVubmluZ3ciLAoiZmFjdHMiOiBbCgpdCn0KXSwKInBvdGVudGlhbEFjdGlvbiI6IFsKewoi
bmFtZSI6ICJBZGQgYSBjb21tZW50IiwKIkB0eXBlIjogIkFjdGlvbkNhcmQiLAoiaW5wdXRzIjog
Wwp7CiJpc011bHRpTGluZSI6IHRydWUsCiJAdHlwZSI6ICJUZXh0SW5wdXQiLAoiaWQiOiAiSXNz
dWVDb21tZW50IiwKImlzUmVxdWlyZWQiOiBmYWxzZQp9Cl0sCiJhY3Rpb25zIjogWwp7CiJuYW1l
IjogIkNvbW1lbnQiLAoiQHR5cGUiOiAiSHR0cFBPU1QiLAoidGFyZ2V0IjogImh0dHBzOi8vYXBp
LmdpdGh1Yi5jb20iLAoiYm9keSI6ICJ7XG5cImNvbW1hbmROYW1lXCI6IFwiSXNzdWVDb21tZW50
XCIsXG5cInJlcG9zaXRvcnlGdWxsTmFtZVwiOiBcImthbWFpbGlvL2thbWFpbGlvXCIsXG5cImlz
c3VlSWRcIjogMTY3MyxcblwiSXNzdWVDb21tZW50XCI6IFwie3tJc3N1ZUNvbW1lbnQudmFsdWV9
fVwiXG59Igp9Cl0KfSwKewoidGFyZ2V0cyI6IFsKewoib3MiOiAiZGVmYXVsdCIsCiJ1cmkiOiAi
aHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8xNjczI2lzc3VlY29t
bWVudC00MzUxNzY5NTkiCn0KXSwKIkB0eXBlIjogIk9wZW5VcmkiLAoibmFtZSI6ICJWaWV3IG9u
IEdpdEh1YiIKfSwKewoibmFtZSI6ICJVbnN1YnNjcmliZSIsCiJAdHlwZSI6ICJIdHRwUE9TVCIs
CiJ0YXJnZXQiOiAiaHR0cHM6Ly9hcGkuZ2l0aHViLmNvbSIsCiJib2R5IjogIntcblwiY29tbWFu
ZE5hbWVcIjogXCJNdXRlTm90aWZpY2F0aW9uXCIsXG5cInRocmVhZElkXCI6IDM5MTcyNDUzM1xu
fSIKfQpdLAoidGhlbWVDb2xvciI6ICIyNjI5MkUiCn0KXTwvc2NyaXB0Pg==

--===============0629373816==--