From notifications@github.com Thu Nov 11 18:00:20 2021 From: =?utf-8?q?Lauren=C8=9Biu?= Nicola To: sr-dev@lists.kamailio.org Subject: [sr-dev] [kamailio/kamailio] presence: return 200 instead of 202 (PR #2930) Date: Thu, 11 Nov 2021 09:00:16 -0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2123178722==" --===============2123178722== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable <!-- Kamailio Pull Request Template --> <!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ..= .' - code is contributed under BSD for core and main components (tm, sl, auth,= tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception --> #### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the che= ckboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guide= lines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on= sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils,= ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook= files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionalit= y) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkbo= xes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description RFC 6665 [says](https://datatracker.ietf.org/doc/html/rfc6665#section-8.3.1): > Implementations conformant with the current specification MUST treat an = incoming 202 response as identical to a 200 response and MUST NOT generate 20= 2 response codes to SUBSCRIBE or NOTIFY requests. I'm not sure if Kamailio is supposed to conform to the older RFC, so this= change might not be _acceptable_. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2930 -- Commit Summary -- * presence: return 200 instead of 202 -- File Changes -- M src/modules/presence/subscribe.c (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2930.patch https://github.com/kamailio/kamailio/pull/2930.diff --=20 You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2930 --===============2123178722== Content-Type: text/html Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.html" MIME-Version: 1.0 Cgo8aDQgZGlyPSJhdXRvIj5QcmUtU3VibWlzc2lvbiBDaGVja2xpc3Q8L2g0PgoKCgo8dWwgY2xh c3M9ImNvbnRhaW5zLXRhc2stbGlzdCI+CjxsaSBjbGFzcz0idGFzay1saXN0LWl0ZW0iPjxpbnB1 dCB0eXBlPSJjaGVja2JveCIgaWQ9IiIgZGlzYWJsZWQ9IiIgY2xhc3M9InRhc2stbGlzdC1pdGVt LWNoZWNrYm94IiBjaGVja2VkPSIiPiBDb21taXQgbWVzc2FnZSBoYXMgdGhlIGZvcm1hdCByZXF1 aXJlZCBieSBDT05UUklCVVRJTkcgZ3VpZGU8L2xpPgo8bGkgY2xhc3M9InRhc2stbGlzdC1pdGVt Ij48aW5wdXQgdHlwZT0iY2hlY2tib3giIGlkPSIiIGRpc2FibGVkPSIiIGNsYXNzPSJ0YXNrLWxp c3QtaXRlbS1jaGVja2JveCIgY2hlY2tlZD0iIj4gQ29tbWl0cyBhcmUgc3BsaXQgcGVyIGNvbXBv bmVudCAoY29yZSwgaW5kaXZpZHVhbCBtb2R1bGVzLCBsaWJzLCB1dGlscywgLi4uKTwvbGk+Cjxs aSBjbGFzcz0idGFzay1saXN0LWl0ZW0iPjxpbnB1dCB0eXBlPSJjaGVja2JveCIgaWQ9IiIgZGlz YWJsZWQ9IiIgY2xhc3M9InRhc2stbGlzdC1pdGVtLWNoZWNrYm94IiBjaGVja2VkPSIiPiBFYWNo IGNvbXBvbmVudCBoYXMgYSBzaW5nbGUgY29tbWl0IChpZiBub3QsIHNxdWFzaCB0aGVtIGludG8g b25lIGNvbW1pdCk8L2xpPgo8bGkgY2xhc3M9InRhc2stbGlzdC1pdGVtIj48aW5wdXQgdHlwZT0i Y2hlY2tib3giIGlkPSIiIGRpc2FibGVkPSIiIGNsYXNzPSJ0YXNrLWxpc3QtaXRlbS1jaGVja2Jv eCIgY2hlY2tlZD0iIj4gTm8gY29tbWl0cyB0byBSRUFETUUgZmlsZXMgZm9yIG1vZHVsZXMgKGNo YW5nZXMgbXVzdCBiZSBkb25lIHRvIGRvY2Jvb2sgZmlsZXM8YnI+CmluIDxjb2RlPmRvYy88L2Nv ZGU+IHN1YmZvbGRlciwgdGhlIFJFQURNRSBmaWxlIGlzIGF1dG9nZW5lcmF0ZWQpPC9saT4KPC91 bD4KPGg0IGRpcj0iYXV0byI+VHlwZSBPZiBDaGFuZ2U8L2g0Pgo8dWwgY2xhc3M9ImNvbnRhaW5z LXRhc2stbGlzdCI+CjxsaSBjbGFzcz0idGFzay1saXN0LWl0ZW0iPjxpbnB1dCB0eXBlPSJjaGVj a2JveCIgaWQ9IiIgZGlzYWJsZWQ9IiIgY2xhc3M9InRhc2stbGlzdC1pdGVtLWNoZWNrYm94Ij4g U21hbGwgYnVnIGZpeCAobm9uLWJyZWFraW5nIGNoYW5nZSB3aGljaCBmaXhlcyBhbiBpc3N1ZSk8 L2xpPgo8bGkgY2xhc3M9InRhc2stbGlzdC1pdGVtIj48aW5wdXQgdHlwZT0iY2hlY2tib3giIGlk PSIiIGRpc2FibGVkPSIiIGNsYXNzPSJ0YXNrLWxpc3QtaXRlbS1jaGVja2JveCI+IE5ldyBmZWF0 dXJlIChub24tYnJlYWtpbmcgY2hhbmdlIHdoaWNoIGFkZHMgbmV3IGZ1bmN0aW9uYWxpdHkpPC9s aT4KPGxpIGNsYXNzPSJ0YXNrLWxpc3QtaXRlbSI+PGlucHV0IHR5cGU9ImNoZWNrYm94IiBpZD0i IiBkaXNhYmxlZD0iIiBjbGFzcz0idGFzay1saXN0LWl0ZW0tY2hlY2tib3giIGNoZWNrZWQ9IiI+ IEJyZWFraW5nIGNoYW5nZSAoZml4IG9yIGZlYXR1cmUgdGhhdCB3b3VsZCBjaGFuZ2UgZXhpc3Rp bmcgZnVuY3Rpb25hbGl0eSk8L2xpPgo8L3VsPgo8aDQgZGlyPSJhdXRvIj5DaGVja2xpc3Q6PC9o ND4KCjx1bCBjbGFzcz0iY29udGFpbnMtdGFzay1saXN0Ij4KPGxpIGNsYXNzPSJ0YXNrLWxpc3Qt aXRlbSI+PGlucHV0IHR5cGU9ImNoZWNrYm94IiBpZD0iIiBkaXNhYmxlZD0iIiBjbGFzcz0idGFz ay1saXN0LWl0ZW0tY2hlY2tib3giPiBQUiBzaG91bGQgYmUgYmFja3BvcnRlZCB0byBzdGFibGUg YnJhbmNoZXM8L2xpPgo8bGkgY2xhc3M9InRhc2stbGlzdC1pdGVtIj48aW5wdXQgdHlwZT0iY2hl Y2tib3giIGlkPSIiIGRpc2FibGVkPSIiIGNsYXNzPSJ0YXNrLWxpc3QtaXRlbS1jaGVja2JveCI+ IFRlc3RlZCBjaGFuZ2VzIGxvY2FsbHk8L2xpPgo8bGkgY2xhc3M9InRhc2stbGlzdC1pdGVtIj48 aW5wdXQgdHlwZT0iY2hlY2tib3giIGlkPSIiIGRpc2FibGVkPSIiIGNsYXNzPSJ0YXNrLWxpc3Qt aXRlbS1jaGVja2JveCI+IFJlbGF0ZWQgdG8gaXNzdWUgI1hYWFggKHJlcGxhY2UgWFhYWCB3aXRo IGFuIG9wZW4gaXNzdWUgbnVtYmVyKTwvbGk+CjwvdWw+CjxoNCBkaXI9ImF1dG8iPkRlc2NyaXB0 aW9uPC9oND4KPHAgZGlyPSJhdXRvIj5SRkMgNjY2NSA8YSBocmVmPSJodHRwczovL2RhdGF0cmFj a2VyLmlldGYub3JnL2RvYy9odG1sL3JmYzY2NjUjc2VjdGlvbi04LjMuMSIgcmVsPSJub2ZvbGxv dyI+c2F5czwvYT46PC9wPgo8YmxvY2txdW90ZT4KPHAgZGlyPSJhdXRvIj5JbXBsZW1lbnRhdGlv bnMgY29uZm9ybWFudCB3aXRoIHRoZSBjdXJyZW50IHNwZWNpZmljYXRpb24gTVVTVCB0cmVhdCBh biBpbmNvbWluZyAyMDIgcmVzcG9uc2UgYXMgaWRlbnRpY2FsIHRvIGEgMjAwIHJlc3BvbnNlIGFu ZCBNVVNUIE5PVCBnZW5lcmF0ZSAyMDIgcmVzcG9uc2UgY29kZXMgdG8gU1VCU0NSSUJFIG9yIE5P VElGWSByZXF1ZXN0cy48L3A+CjwvYmxvY2txdW90ZT4KPHAgZGlyPSJhdXRvIj5JJ20gbm90IHN1 cmUgaWYgS2FtYWlsaW8gaXMgc3VwcG9zZWQgdG8gY29uZm9ybSB0byB0aGUgb2xkZXIgUkZDLCBz byB0aGlzIGNoYW5nZSBtaWdodCBub3QgYmUgPGVtPmFjY2VwdGFibGU8L2VtPi48L3A+Cgo8aHI+ Cgo8aDQ+WW91IGNhbiB2aWV3LCBjb21tZW50IG9uLCBvciBtZXJnZSB0aGlzIHB1bGwgcmVxdWVz dCBvbmxpbmUgYXQ6PC9oND4KPHA+Jm5ic3A7Jm5ic3A7PGEgaHJlZj0naHR0cHM6Ly9naXRodWIu Y29tL2thbWFpbGlvL2thbWFpbGlvL3B1bGwvMjkzMCc+aHR0cHM6Ly9naXRodWIuY29tL2thbWFp bGlvL2thbWFpbGlvL3B1bGwvMjkzMDwvYT48L3A+Cgo8aDQ+Q29tbWl0IFN1bW1hcnk8L2g0Pgo8 dWw+CiAgPGxpPjxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9w dWxsLzI5MzAvY29tbWl0cy8wNGQ1MWY3YzQ4OWJjZTE5ZmRmNTMwOTViY2RlODY5ZDlhYjU1OTA4 Ij5wcmVzZW5jZTogcmV0dXJuIDIwMCBpbnN0ZWFkIG9mIDIwMjwvYT48L2xpPgo8L3VsPgoKPGg0 IHN0eWxlPSJkaXNwbGF5OiBpbmxpbmUtYmxvY2siPkZpbGUgQ2hhbmdlcyA8L2g0PiA8cCBzdHls ZT0iZGlzcGxheTogaW5saW5lLWJsb2NrIj4oPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2th bWFpbGlvL2thbWFpbGlvL3B1bGwvMjkzMC9maWxlcyI+MSZuYnNwO2ZpbGU8L2E+KTwvcD4KPHVs PgogIDxsaT4KICAgIDxzdHJvbmc+TTwvc3Ryb25nPgogICAgPGEgaHJlZj0iaHR0cHM6Ly9naXRo dWIuY29tL2thbWFpbGlvL2thbWFpbGlvL3B1bGwvMjkzMC9maWxlcyNkaWZmLTI5YWFmYjE3Yzkz ZDlkYWQyOTA3MTM5YzZkOGQ2NmMxNzQ2NjI0NjEyZTI1YmRmODgxZDZjODgxYjAzOTZlYzAiPnNy Yy9tb2R1bGVzL3ByZXNlbmNlL3N1YnNjcmliZS5jPC9hPgogICAgKDEyKQogIDwvbGk+CjwvdWw+ Cgo8aDQ+UGF0Y2ggTGlua3M6PC9oND4KPHVsPgogIDxsaT48YSBocmVmPSdodHRwczovL2dpdGh1 Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vcHVsbC8yOTMwLnBhdGNoJz5odHRwczovL2dpdGh1Yi5j b20va2FtYWlsaW8va2FtYWlsaW8vcHVsbC8yOTMwLnBhdGNoPC9hPjwvbGk+CiAgPGxpPjxhIGhy ZWY9J2h0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9wdWxsLzI5MzAuZGlmZic+ aHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL3B1bGwvMjkzMC5kaWZmPC9hPjwv bGk+CjwvdWw+Cgo8cCBzdHlsZT0iZm9udC1zaXplOnNtYWxsOy13ZWJraXQtdGV4dC1zaXplLWFk anVzdDpub25lO2NvbG9yOiM2NjY7Ij4mbWRhc2g7PGJyIC8+WW91IGFyZSByZWNlaXZpbmcgdGhp cyBiZWNhdXNlIHlvdSBhcmUgc3Vic2NyaWJlZCB0byB0aGlzIHRocmVhZC48YnIgLz5SZXBseSB0 byB0aGlzIGVtYWlsIGRpcmVjdGx5LCA8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20va2FtYWls aW8va2FtYWlsaW8vcHVsbC8yOTMwIj52aWV3IGl0IG9uIEdpdEh1YjwvYT4sIG9yIDxhIGhyZWY9 Imh0dHBzOi8vZ2l0aHViLmNvbS9ub3RpZmljYXRpb25zL3Vuc3Vic2NyaWJlLWF1dGgvQUJPN1Va SjM2WDRLWEFYTk5JRkNQWlRVTFBaQ0JBTkNORlNNNUgyNUdVNkEiPnVuc3Vic2NyaWJlPC9hPi48 YnIgLz5UcmlhZ2Ugbm90aWZpY2F0aW9ucyBvbiB0aGUgZ28gd2l0aCBHaXRIdWIgTW9iaWxlIGZv ciA8YSBocmVmPSJodHRwczovL2FwcHMuYXBwbGUuY29tL2FwcC9hcHBsZS1zdG9yZS9pZDE0Nzcz NzY5MDU/Y3Q9bm90aWZpY2F0aW9uLWVtYWlsJmFtcDttdD04JmFtcDtwdD01MjQ2NzUiPmlPUzwv YT4gb3IgPGEgaHJlZj0iaHR0cHM6Ly9wbGF5Lmdvb2dsZS5jb20vc3RvcmUvYXBwcy9kZXRhaWxz P2lkPWNvbS5naXRodWIuYW5kcm9pZCZhbXA7cmVmZXJyZXI9dXRtX2NhbXBhaWduJTNEbm90aWZp Y2F0aW9uLWVtYWlsJTI2dXRtX21lZGl1bSUzRGVtYWlsJTI2dXRtX3NvdXJjZSUzRGdpdGh1YiI+ QW5kcm9pZDwvYT4uCjxpbWcgc3JjPSJodHRwczovL2dpdGh1Yi5jb20vbm90aWZpY2F0aW9ucy9i ZWFjb24vQUJPN1VaT0NKNk1PWlRHNEoyUlpIN0RVTFBaQ0JBNUNORlNNNUgyNUdVNktZWTNQTlZX V0szVFVMNTJIUzRERlVWRVhHNDNWTVdWR0czM05OVlNXNDVDN05GU000UFZIWUlIUS5naWYiIGhl aWdodD0iMSIgd2lkdGg9IjEiIGFsdD0iIiAvPjwvcD4KPHNjcmlwdCB0eXBlPSJhcHBsaWNhdGlv bi9sZCtqc29uIj5bCnsKIkBjb250ZXh0IjogImh0dHA6Ly9zY2hlbWEub3JnIiwKIkB0eXBlIjog IkVtYWlsTWVzc2FnZSIsCiJwb3RlbnRpYWxBY3Rpb24iOiB7CiJAdHlwZSI6ICJWaWV3QWN0aW9u IiwKInRhcmdldCI6ICJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vcHVsbC8y OTMwIiwKInVybCI6ICJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vcHVsbC8y OTMwIiwKIm5hbWUiOiAiVmlldyBQdWxsIFJlcXVlc3QiCn0sCiJkZXNjcmlwdGlvbiI6ICJWaWV3 IHRoaXMgUHVsbCBSZXF1ZXN0IG9uIEdpdEh1YiIsCiJwdWJsaXNoZXIiOiB7CiJAdHlwZSI6ICJP cmdhbml6YXRpb24iLAoibmFtZSI6ICJHaXRIdWIiLAoidXJsIjogImh0dHBzOi8vZ2l0aHViLmNv bSIKfQp9Cl08L3NjcmlwdD4K --===============2123178722==--