From hw@skalatan.de Sun Jun 14 17:30:57 2020
From: Henning Westerholt <hw@skalatan.de>
To: sr-dev@lists.kamailio.org
Subject:
 Re: [sr-dev] dialog: reason behind not storing early state dialogs in db
Date: Sun, 14 Jun 2020 15:30:51 +0000
Message-ID: <AM0PR05MB65956F376F532EF968505077C59F0@AM0PR05MB6595.eurprd05.prod.outlook.com>
In-Reply-To:
 <CAND0LktGACKRkBCUFoK+3rSxaP+FsdGxoUvQrpjJSFR0uAv8Cg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1705496421=="

--===============1705496421==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

yes - this is some concern I also had. In some cases you might be come around=
 by just registering the proper call-back (like the uac module does). But of =
course, you don't have the transaction anymore.

I also found some more issues in the code related to this change. The DB inse=
rt/update code holds some assumption on the dialog flags and therefore it doe=
s not work without modification of this path. And this needs some more refact=
oring, therefore I reverted the patch for now in git master.

Cheers,

Henning

-----Original Message-----
From: sr-dev <sr-dev-bounces(a)lists.kamailio.org> On Behalf Of Ovidiu Sas
Sent: Saturday, June 13, 2020 9:04 PM
To: Kamailio (SER) - Development Mailing List <sr-dev(a)lists.kamailio.org>
Subject: Re: [sr-dev] dialog: reason behind not storing early state dialogs i=
n db

One observation here: early dialogs are bound to the initial INVITE transacti=
on. For this reason, early dialogs should not be restored from db because the=
 transaction is no longer present (during failover or restart).

Thanks,
Ovidiu

On Fri, Jun 12, 2020 at 3:35 PM Henning Westerholt <hw(a)skalatan.de> wrote:
>
> Hi Victor,
>
> thanks for the feedback, I will also do some more tests.
>
> Cheers,
>
> Henning
>
> -----Original Message-----
> From: sr-dev <sr-dev-bounces(a)lists.kamailio.org> On Behalf Of Victor=20
> Seva
> Sent: Friday, June 12, 2020 2:34 PM
> To: Kamailio (SER) - Development Mailing List=20
> <sr-dev(a)lists.kamailio.org>
> Subject: Re: [sr-dev] dialog: reason behind not storing early state=20
> dialogs in db
>
> Hi Henning,
>
> On 6/12/20 10:31 AM, Henning Westerholt wrote:
> > added with 37d83a5838a50350. Feedback and additional testing are of=20
> > course welcome.
>
> Applied 37d83a5838a50350 but I don't see any insert to the db until dialog =
is confirmed.
>
> ``modparam("dialog","db_mode", 1)`` is in the config
>
> ```
> Jun 12 13:47:01 sp1 proxy[31630]: NOTICE: DEFAULT_ROUTE <script>: New reque=
st on proxy - M=3DINVITE R=3D=C2=ABsip:43993002(a)192.168.1.102=C2=BB F=3D=C2=
=ABsip:43993003(a)192.168.1.102=C2=BB T=3D=C2=ABsip:43993002(a)192.168.1.102=
=C2=BB IP=3D=C2=AB192.168.1.123=C2=BB:=C2=AB5068=C2=BB (=C2=AB127.0.0.1=C2=BB=
:=C2=AB5060=C2=BB) ID=3D=C2=ABephgtzmqykl gppz(a)debrock.torreviejawireless.o=
rg=C2=BB UA=3D'Twinkle/1.10.1' DESTIP=3D=C2=AB127.0.0.1=C2=BB:=C2=AB5062=C2=
=BB Jun 12 13:47:01 sp1 proxy[31630]: NOTICE: DEFAULT_ROUTE <script>: Sending=
 reply S=3D100 Trying M=3DINVITE fs=3D'=C2=AB127.0.0.1=C2=BB:=C2=AB5062=C2=BB=
' du=3D'=C2=AB127.0.0.1=C2=BB:=C2=AB5060=C2=BB' - R=3D=C2=ABsip:43993002(a)19=
2.168.1.102=C2=BB ID=3D=C2=ABephgtzmqyklgppz(a)debrock.torreviejawireless.org=
=C2=BB UA=3D'Twinkle/1.10.1 '
> ...
> Jun 12 13:47:01 sp1 proxy[31630]: DEBUG: ROUTE_DLG_MANAGE dialog [dlg_hash.=
c:480]: build_new_dlg(): new dialog on hash 380 ...
> Jun 12 13:47:01 sp1 proxy[31630]: DEBUG: ROUTE_DLG_MANAGE dialog [dlg_db_ha=
ndler.c:835]: update_dialog_dbinfo_unsafe(): updated 4 vars for dlg [380:4617=
] ...
> Jun 12 13:47:01 sp1 proxy[31630]: DEBUG: ROUTE_DLG_MANAGE dialog [dlg_profi=
le.c:536]: set_current_dialog(): setting current dialog [380:4617] ...
> Jun 12 13:47:01 sp1 proxy[31630]: NOTICE: DEFAULT_ROUTE <script>: Sending r=
eply S=3D100 Trying M=3DINVITE fs=3D'=C2=AB127.0.0.1=C2=BB:=C2=AB5062=C2=BB' =
du=3D'=C2=AB127.0.0.1=C2=BB:=C2=AB5060=C2=BB' - R=3D=C2=ABsip:43993002(a)192.=
168.1.102=C2=BB ID=3D=C2=ABephgtzmqyklgppz(a)debrock.torreviejawireless.org=
=C2=BB UA=3D'Twinkle/1.10.1'
> ...
> Jun 12 13:47:01 sp1 proxy[31634]: NOTICE: REPLY_ROUTE_NAT <script>: NAT-Rep=
ly - S=3D180 - Ringing M=3DINVITE IP=3D=C2=AB192.168.1.123=C2=BB:=C2=AB5068=
=C2=BB (=C2=AB127.0.0.1=C2=BB:=C2=AB5080=C2=BB) ID=3D=C2=ABephgtzmqyklgppz(a)=
debrock.torreviejawireless.org=C2=BB UA=3D'<null>' DESTIP=3D=C2=AB127.0.0.1=
=C2=BB:=C2=AB5062=C2=BB ...
> Jun 12 13:47:01 sp1 proxy[31634]: DEBUG: REPLY_ROUTE_NAT tmx [t_var.c:539]:=
 pv_get_tm_reply_code(): reply code is <180> ...
> Jun 12 13:47:01 sp1 proxy[31634]: DEBUG: REPLY_ROUTE_NAT dialog [dlg_hash.c=
:789]: dlg_lookup_mode(): dialog id=3D4617 found on entry 380 ...
> Jun 12 13:47:01 sp1 proxy[31634]: DEBUG: <null> dialog=20
> [dlg_hash.c:1264]: next_state_dlg(): dialog 0x7fd87d250e88 changed=20
> from state 1 to state 2, due event 2 (ref 2) Jun 12 13:47:01 sp1=20
> proxy[31634]: DEBUG: <null> dialog [dlg_cb.c:271]:=20
> run_dlg_callbacks(): dialog=3D0x7fd87d250e88, type=3D256 ```
>
> Nothing gets written in the dialog table until
>
> ```
> Jun 12 13:47:25 sp1 proxy[31634]: NOTICE: REPLY_ROUTE_NAT <script>: NAT-Rep=
ly - S=3D200 - Answering M=3DINVITE IP=3D=C2=AB192.168.1.123=C2=BB:=C2=AB5068=
=C2=BB (=C2=AB127.0.0.1=C2=BB:=C2=AB5080=C2=BB) ID=3D=C2=ABephgtzmqyklgppz(a)=
debrock.torreviejawireless.org=C2=BB UA=3D'<null>' DESTIP=3D=C2=AB127.0.0.1=
=C2=BB:=C2=AB5062=C2=BB ...
> Jun 12 13:47:25 sp1 proxy[31634]: DEBUG: <null> dialog [dlg_hash.c:1264]: n=
ext_state_dlg(): dialog 0x7fd87d250e88 changed from state 2 to state 3, due e=
vent 3 (ref 2) ...
> Jun 12 13:47:25 sp1 proxy[31634]: NOTICE: dialog:start <script>: [dialog:st=
art] lua_dlg_callid:[=C2=ABephgtzmqyklgppz(a)debrock.torreviejawireless.org=
=C2=BB]  - R=3D=C2=AB<null>=C2=BB ID=3D=C2=ABephgtzmqyklgppz(a)debrock.torrev=
iejawireless.org=C2=BB UA=3D'<null>'
> ...
> Jun 12 13:47:25 sp1 proxy[31634]: DEBUG: <null> dialog=20
> [dlg_handlers.c:512]: dlg_onreply(): dialog 0x7fd87d250e88 confirmed=20
> (ACK pending) Jun 12 13:47:25 sp1 proxy[31634]: DEBUG: <null> dialog=20
> [dlg_handlers.c:259]: populate_leg_info(): leg(1) route_set [],=20
> contact [sip:127.0.0.1:5080;transport=3Dudp], cseq [] and bind_addr=20
> [udp:127.0.0.1:5062] Jun 12 13:47:25 sp1 proxy[31634]: DEBUG: <null>=20
> dialog [dlg_db_handler.c:835]: update_dialog_dbinfo_unsafe(): updated=20
> 19 vars for dlg [380:4617] Jun 12 13:47:25 sp1 proxy[31634]: DEBUG:=20
> <null> dialog [dlg_db_handler.c:874]: update_dialog_dbinfo_unsafe():=20
> sock_info is udp:127.0.0.1:5062 ```
>
>
> Cheers,
> Victor
>
> _______________________________________________
> Kamailio (SER) - Development Mailing List sr-dev(a)lists.kamailio.org=20
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev



--=20
VoIP Embedded, Inc.
http://www.voipembedded.com

_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev(a)lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

--===============1705496421==--