From notifications@github.com Wed Feb 15 02:16:35 2023
From: shaneqld <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: [sr-dev] Re: [kamailio/kamailio] rtpengine: queried_nodes_limit
 incorrectly applies to delete commands which can cause all processes to be
 blocked (Issue #3370)
Date: Tue, 14 Feb 2023 18:16:26 -0800
Message-ID: <kamailio/kamailio/issues/3370/1430656250@github.com>
In-Reply-To: <kamailio/kamailio/issues/3370@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1580084490=="

--===============1580084490==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

@rfuchs Thank you for this. I can confirm that this fixes the issue.

```
Feb 14 20:33:51 debian-kamailio kamailio[5066]: INFO: {1 63658613 INVITE 98db=
b579-2773-123c-48af-80fa5d718101} <script>: failure_route: calling RTPMANAGE
Feb 14 20:33:56 debian-kamailio kamailio[5066]: ERROR: {1 63658613 INVITE 98d=
bb579-2773-123c-48af-80fa5d718101} rtpengine [rtpengine.c:3129]: send_rtpp_co=
mmand(): timeout waiting reply for command "delete" from RTPEngine <udp:192.1=
68.X.X:2223>
Feb 14 20:33:56 debian-kamailio kamailio[5066]: ERROR: {1 63658613 INVITE 98d=
bb579-2773-123c-48af-80fa5d718101} rtpengine [rtpengine.c:3382]: select_rtpp_=
node(): rtpengine node for callid=3D98dbb579-2773-123c-48af-80fa5d718101 is k=
nown (udp:192.168.X.X:2223) but it has already been queried, therefore not re=
turning it
Feb 14 20:33:56 debian-kamailio kamailio[5066]: ERROR: {1 63658613 INVITE 98d=
bb579-2773-123c-48af-80fa5d718101} rtpengine [rtpengine.c:2735]: rtpp_functio=
n_call(): no available proxies
Feb 14 20:33:56 debian-kamailio kamailio[5066]: INFO: {1 63658613 INVITE 98db=
b579-2773-123c-48af-80fa5d718101} <script>: failure_route: completed calling =
RTPMANAGE
```

I can also confirm everything still works normally when rtpengine is up; and =
when there are multiple rtpengine instances and one is unavailable (ie initia=
l node selection works as normal).

The only very minor observation I have is that the call remains in the hash t=
able until `hash_table_tout` as observed with `kamcmd rtpengine.get_hash_tota=
l`. I assume this happened before, and it's very minor, but thought I'd menti=
on it.

Apologies if info on release cycles is somewhere already & my eagerness, but =
can I ask when I should look out for a release with this patch?

--=20
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3370#issuecomment-1430656250
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/issues/3370/1430656250(a)github.com>



--===============1580084490==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+PC9wPgo8cCBkaXI9ImF1dG8iPjxhIGNsYXNzPSJ1c2VyLW1lbnRpb24gbm90cmFuc2xhdGUi
IGRhdGEtaG92ZXJjYXJkLXR5cGU9InVzZXIiIGRhdGEtaG92ZXJjYXJkLXVybD0iL3VzZXJzL3Jm
dWNocy9ob3ZlcmNhcmQiIGRhdGEtb2N0by1jbGljaz0iaG92ZXJjYXJkLWxpbmstY2xpY2siIGRh
dGEtb2N0by1kaW1lbnNpb25zPSJsaW5rX3R5cGU6c2VsZiIgaHJlZj0iaHR0cHM6Ly9naXRodWIu
Y29tL3JmdWNocyI+QHJmdWNoczwvYT4gVGhhbmsgeW91IGZvciB0aGlzLiBJIGNhbiBjb25maXJt
IHRoYXQgdGhpcyBmaXhlcyB0aGUgaXNzdWUuPC9wPgo8cHJlIGNsYXNzPSJub3RyYW5zbGF0ZSI+
PGNvZGUgY2xhc3M9Im5vdHJhbnNsYXRlIj5GZWIgMTQgMjA6MzM6NTEgZGViaWFuLWthbWFpbGlv
IGthbWFpbGlvWzUwNjZdOiBJTkZPOiB7MSA2MzY1ODYxMyBJTlZJVEUgOThkYmI1NzktMjc3My0x
MjNjLTQ4YWYtODBmYTVkNzE4MTAxfSAmbHQ7c2NyaXB0Jmd0OzogZmFpbHVyZV9yb3V0ZTogY2Fs
bGluZyBSVFBNQU5BR0UKRmViIDE0IDIwOjMzOjU2IGRlYmlhbi1rYW1haWxpbyBrYW1haWxpb1s1
MDY2XTogRVJST1I6IHsxIDYzNjU4NjEzIElOVklURSA5OGRiYjU3OS0yNzczLTEyM2MtNDhhZi04
MGZhNWQ3MTgxMDF9IHJ0cGVuZ2luZSBbcnRwZW5naW5lLmM6MzEyOV06IHNlbmRfcnRwcF9jb21t
YW5kKCk6IHRpbWVvdXQgd2FpdGluZyByZXBseSBmb3IgY29tbWFuZCAiZGVsZXRlIiBmcm9tIFJU
UEVuZ2luZSAmbHQ7dWRwOjE5Mi4xNjguWC5YOjIyMjMmZ3Q7CkZlYiAxNCAyMDozMzo1NiBkZWJp
YW4ta2FtYWlsaW8ga2FtYWlsaW9bNTA2Nl06IEVSUk9SOiB7MSA2MzY1ODYxMyBJTlZJVEUgOThk
YmI1NzktMjc3My0xMjNjLTQ4YWYtODBmYTVkNzE4MTAxfSBydHBlbmdpbmUgW3J0cGVuZ2luZS5j
OjMzODJdOiBzZWxlY3RfcnRwcF9ub2RlKCk6IHJ0cGVuZ2luZSBub2RlIGZvciBjYWxsaWQ9OThk
YmI1NzktMjc3My0xMjNjLTQ4YWYtODBmYTVkNzE4MTAxIGlzIGtub3duICh1ZHA6MTkyLjE2OC5Y
Llg6MjIyMykgYnV0IGl0IGhhcyBhbHJlYWR5IGJlZW4gcXVlcmllZCwgdGhlcmVmb3JlIG5vdCBy
ZXR1cm5pbmcgaXQKRmViIDE0IDIwOjMzOjU2IGRlYmlhbi1rYW1haWxpbyBrYW1haWxpb1s1MDY2
XTogRVJST1I6IHsxIDYzNjU4NjEzIElOVklURSA5OGRiYjU3OS0yNzczLTEyM2MtNDhhZi04MGZh
NWQ3MTgxMDF9IHJ0cGVuZ2luZSBbcnRwZW5naW5lLmM6MjczNV06IHJ0cHBfZnVuY3Rpb25fY2Fs
bCgpOiBubyBhdmFpbGFibGUgcHJveGllcwpGZWIgMTQgMjA6MzM6NTYgZGViaWFuLWthbWFpbGlv
IGthbWFpbGlvWzUwNjZdOiBJTkZPOiB7MSA2MzY1ODYxMyBJTlZJVEUgOThkYmI1NzktMjc3My0x
MjNjLTQ4YWYtODBmYTVkNzE4MTAxfSAmbHQ7c2NyaXB0Jmd0OzogZmFpbHVyZV9yb3V0ZTogY29t
cGxldGVkIGNhbGxpbmcgUlRQTUFOQUdFCjwvY29kZT48L3ByZT4KPHAgZGlyPSJhdXRvIj5JIGNh
biBhbHNvIGNvbmZpcm0gZXZlcnl0aGluZyBzdGlsbCB3b3JrcyBub3JtYWxseSB3aGVuIHJ0cGVu
Z2luZSBpcyB1cDsgYW5kIHdoZW4gdGhlcmUgYXJlIG11bHRpcGxlIHJ0cGVuZ2luZSBpbnN0YW5j
ZXMgYW5kIG9uZSBpcyB1bmF2YWlsYWJsZSAoaWUgaW5pdGlhbCBub2RlIHNlbGVjdGlvbiB3b3Jr
cyBhcyBub3JtYWwpLjwvcD4KPHAgZGlyPSJhdXRvIj5UaGUgb25seSB2ZXJ5IG1pbm9yIG9ic2Vy
dmF0aW9uIEkgaGF2ZSBpcyB0aGF0IHRoZSBjYWxsIHJlbWFpbnMgaW4gdGhlIGhhc2ggdGFibGUg
dW50aWwgPGNvZGUgY2xhc3M9Im5vdHJhbnNsYXRlIj5oYXNoX3RhYmxlX3RvdXQ8L2NvZGU+IGFz
IG9ic2VydmVkIHdpdGggPGNvZGUgY2xhc3M9Im5vdHJhbnNsYXRlIj5rYW1jbWQgcnRwZW5naW5l
LmdldF9oYXNoX3RvdGFsPC9jb2RlPi4gSSBhc3N1bWUgdGhpcyBoYXBwZW5lZCBiZWZvcmUsIGFu
ZCBpdCdzIHZlcnkgbWlub3IsIGJ1dCB0aG91Z2h0IEknZCBtZW50aW9uIGl0LjwvcD4KPHAgZGly
PSJhdXRvIj5BcG9sb2dpZXMgaWYgaW5mbyBvbiByZWxlYXNlIGN5Y2xlcyBpcyBzb21ld2hlcmUg
YWxyZWFkeSAmYW1wOyBteSBlYWdlcm5lc3MsIGJ1dCBjYW4gSSBhc2sgd2hlbiBJIHNob3VsZCBs
b29rIG91dCBmb3IgYSByZWxlYXNlIHdpdGggdGhpcyBwYXRjaD88L3A+Cgo8cCBzdHlsZT0iZm9u
dC1zaXplOnNtYWxsOy13ZWJraXQtdGV4dC1zaXplLWFkanVzdDpub25lO2NvbG9yOiM2NjY7Ij4m
bWRhc2g7PGJyIC8+UmVwbHkgdG8gdGhpcyBlbWFpbCBkaXJlY3RseSwgPGEgaHJlZj0iaHR0cHM6
Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8zMzcwI2lzc3VlY29tbWVudC0x
NDMwNjU2MjUwIj52aWV3IGl0IG9uIEdpdEh1YjwvYT4sIG9yIDxhIGhyZWY9Imh0dHBzOi8vZ2l0
aHViLmNvbS9ub3RpZmljYXRpb25zL3Vuc3Vic2NyaWJlLWF1dGgvQUJPN1VaTDM1RVdXRzdYUFoz
UEZON1RXWFEzN1ZBTkNORlNNNkFBQUFBQVVaMjJVQk0iPnVuc3Vic2NyaWJlPC9hPi48YnIgLz5Z
b3UgYXJlIHJlY2VpdmluZyB0aGlzIGJlY2F1c2UgeW91IGFyZSBzdWJzY3JpYmVkIHRvIHRoaXMg
dGhyZWFkLjxpbWcgc3JjPSJodHRwczovL2dpdGh1Yi5jb20vbm90aWZpY2F0aW9ucy9iZWFjb24v
QUJPN1VaSVFaVlNXUzZMVlRMNFQyT0RXWFEzN1ZBNUNORlNNNkFBQUFBQVVaMjJVQk9XR0czM05O
VlNXNDVDN09SNFhBWk5NSkZaWEc1TEZJTlhXMjNMRk5aMktVWTNQTlZXV0szVFVMNVVXSlRTVklZ
S1BVLmdpZiIgaGVpZ2h0PSIxIiB3aWR0aD0iMSIgYWx0PSIiIC8+PHNwYW4gc3R5bGU9ImNvbG9y
OiB0cmFuc3BhcmVudDsgZm9udC1zaXplOiAwOyBkaXNwbGF5OiBub25lOyB2aXNpYmlsaXR5OiBo
aWRkZW47IG92ZXJmbG93OiBoaWRkZW47IG9wYWNpdHk6IDA7IHdpZHRoOiAwOyBoZWlnaHQ6IDA7
IG1heC13aWR0aDogMDsgbWF4LWhlaWdodDogMDsgbXNvLWhpZGU6IGFsbCI+TWVzc2FnZSBJRDog
PHNwYW4+Jmx0O2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8zMzcwLzE0MzA2NTYyNTA8L3NwYW4+
PHNwYW4+QDwvc3Bhbj48c3Bhbj5naXRodWI8L3NwYW4+PHNwYW4+Ljwvc3Bhbj48c3Bhbj5jb20m
Z3Q7PC9zcGFuPjwvc3Bhbj48L3A+CjxzY3JpcHQgdHlwZT0iYXBwbGljYXRpb24vbGQranNvbiI+
Wwp7CiJAY29udGV4dCI6ICJodHRwOi8vc2NoZW1hLm9yZyIsCiJAdHlwZSI6ICJFbWFpbE1lc3Nh
Z2UiLAoicG90ZW50aWFsQWN0aW9uIjogewoiQHR5cGUiOiAiVmlld0FjdGlvbiIsCiJ0YXJnZXQi
OiAiaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8zMzcwI2lzc3Vl
Y29tbWVudC0xNDMwNjU2MjUwIiwKInVybCI6ICJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8v
a2FtYWlsaW8vaXNzdWVzLzMzNzAjaXNzdWVjb21tZW50LTE0MzA2NTYyNTAiLAoibmFtZSI6ICJW
aWV3IElzc3VlIgp9LAoiZGVzY3JpcHRpb24iOiAiVmlldyB0aGlzIElzc3VlIG9uIEdpdEh1YiIs
CiJwdWJsaXNoZXIiOiB7CiJAdHlwZSI6ICJPcmdhbml6YXRpb24iLAoibmFtZSI6ICJHaXRIdWIi
LAoidXJsIjogImh0dHBzOi8vZ2l0aHViLmNvbSIKfQp9Cl08L3NjcmlwdD4=

--===============1580084490==--