From notifications@github.com Wed Jun 12 07:58:40 2024
From: Henning Westerholt <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: [sr-dev] Re: [kamailio/kamailio] ims_icscf: add missing documents for
 database params (PR #3874)
Date: Wed, 12 Jun 2024 00:58:36 -0700
Message-ID: <kamailio/kamailio/pull/3874/review/2112231440@github.com>
In-Reply-To: <kamailio/kamailio/pull/3874@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2017993211=="

--===============2017993211==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

@henningw commented on this pull request.

Thanks for the PR, I have added two comments related to the usage of database=
 URLs.

> @@ -71,7 +71,7 @@ stat_var *uar_replies_response_time =3D NULL;
 stat_var *lir_replies_response_time =3D NULL;
=20
 //module parameters
-char *ims_icscf_db_url =3D "mysql://icscf:heslo(a)localhost/hssdata"; /**< D=
B URL */
+char *ims_icscf_db_url =3D "mysql://kamailio:kamailiorw(a)localhost/kamailio=
"; /**< DB URL */

Consider using the correct define for it: DEFAULT_RODB_URL


> +      <para>
+          If the db_url string is empty, the default database URL
+          will be used.
+      </para>
+
+      <para>
+        <emphasis>
+            Default value is <quote>&defaultrodb;</quote>.
+        </emphasis>
+      </para>
+
+      <example>
+        <title>Set <varname>db_url</varname> parameter</title>
+        <programlisting format=3D"linespecific">
+...
+modparam("ims_icscf", "db_url", "mysql://username:password(a)localhost/kamai=
lio")

You could use also here the definition "&exampledb;

--=20
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3874#pullrequestreview-2112231440
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3874/review/2112231440(a)github.com>



--===============2017993211==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+PC9wPgo8cD48Yj5AaGVubmluZ3c8L2I+IGNvbW1lbnRlZCBvbiB0aGlzIHB1bGwgcmVxdWVz
dC48L3A+Cgo8cCBkaXI9ImF1dG8iPlRoYW5rcyBmb3IgdGhlIFBSLCBJIGhhdmUgYWRkZWQgdHdv
IGNvbW1lbnRzIHJlbGF0ZWQgdG8gdGhlIHVzYWdlIG9mIGRhdGFiYXNlIFVSTHMuPC9wPjxocj4K
CjxwPkluIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9wdWxs
LzM4NzQjZGlzY3Vzc2lvbl9yMTYzNTk4OTAzMSI+c3JjL21vZHVsZXMvaW1zX2ljc2NmL2ltc19p
Y3NjZl9tb2QuYzwvYT46PC9wPgo8cHJlIHN0eWxlPSdjb2xvcjojNTU1Jz4mZ3Q7IEBAIC03MSw3
ICs3MSw3IEBAIHN0YXRfdmFyICp1YXJfcmVwbGllc19yZXNwb25zZV90aW1lID0gTlVMTDsKIHN0
YXRfdmFyICpsaXJfcmVwbGllc19yZXNwb25zZV90aW1lID0gTlVMTDsKIAogLy9tb2R1bGUgcGFy
YW1ldGVycwotY2hhciAqaW1zX2ljc2NmX2RiX3VybCA9ICZxdW90O215c3FsOi8vaWNzY2Y6aGVz
bG9AbG9jYWxob3N0L2hzc2RhdGEmcXVvdDs7IC8qKiZsdDsgREIgVVJMICovCitjaGFyICppbXNf
aWNzY2ZfZGJfdXJsID0gJnF1b3Q7bXlzcWw6Ly9rYW1haWxpbzprYW1haWxpb3J3QGxvY2FsaG9z
dC9rYW1haWxpbyZxdW90OzsgLyoqJmx0OyBEQiBVUkwgKi8KPC9wcmU+CjxwIGRpcj0iYXV0byI+
Q29uc2lkZXIgdXNpbmcgdGhlIGNvcnJlY3QgZGVmaW5lIGZvciBpdDogREVGQVVMVF9ST0RCX1VS
TDwvcD4KCjxocj4KCjxwPkluIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9r
YW1haWxpby9wdWxsLzM4NzQjZGlzY3Vzc2lvbl9yMTYzNjAwMDQ4NyI+c3JjL21vZHVsZXMvaW1z
X2ljc2NmL2RvYy9pbXNfaWNzY2ZfYWRtaW4ueG1sPC9hPjo8L3A+CjxwcmUgc3R5bGU9J2NvbG9y
OiM1NTUnPiZndDsgKyAgICAgICZsdDtwYXJhJmd0OworICAgICAgICAgIElmIHRoZSBkYl91cmwg
c3RyaW5nIGlzIGVtcHR5LCB0aGUgZGVmYXVsdCBkYXRhYmFzZSBVUkwKKyAgICAgICAgICB3aWxs
IGJlIHVzZWQuCisgICAgICAmbHQ7L3BhcmEmZ3Q7CisKKyAgICAgICZsdDtwYXJhJmd0OworICAg
ICAgICAmbHQ7ZW1waGFzaXMmZ3Q7CisgICAgICAgICAgICBEZWZhdWx0IHZhbHVlIGlzICZsdDtx
dW90ZSZndDsmYW1wO2RlZmF1bHRyb2RiOyZsdDsvcXVvdGUmZ3Q7LgorICAgICAgICAmbHQ7L2Vt
cGhhc2lzJmd0OworICAgICAgJmx0Oy9wYXJhJmd0OworCisgICAgICAmbHQ7ZXhhbXBsZSZndDsK
KyAgICAgICAgJmx0O3RpdGxlJmd0O1NldCAmbHQ7dmFybmFtZSZndDtkYl91cmwmbHQ7L3Zhcm5h
bWUmZ3Q7IHBhcmFtZXRlciZsdDsvdGl0bGUmZ3Q7CisgICAgICAgICZsdDtwcm9ncmFtbGlzdGlu
ZyBmb3JtYXQ9JnF1b3Q7bGluZXNwZWNpZmljJnF1b3Q7Jmd0OworLi4uCittb2RwYXJhbSgmcXVv
dDtpbXNfaWNzY2YmcXVvdDssICZxdW90O2RiX3VybCZxdW90OywgJnF1b3Q7bXlzcWw6Ly91c2Vy
bmFtZTpwYXNzd29yZEBsb2NhbGhvc3Qva2FtYWlsaW8mcXVvdDspCjwvcHJlPgo8cCBkaXI9ImF1
dG8iPllvdSBjb3VsZCB1c2UgYWxzbyBoZXJlIHRoZSBkZWZpbml0aW9uICImYW1wO2V4YW1wbGVk
Yjs8L3A+Cgo8cCBzdHlsZT0iZm9udC1zaXplOnNtYWxsOy13ZWJraXQtdGV4dC1zaXplLWFkanVz
dDpub25lO2NvbG9yOiM2NjY7Ij4mbWRhc2g7PGJyIC8+UmVwbHkgdG8gdGhpcyBlbWFpbCBkaXJl
Y3RseSwgPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL3B1bGwv
Mzg3NCNwdWxscmVxdWVzdHJldmlldy0yMTEyMjMxNDQwIj52aWV3IGl0IG9uIEdpdEh1YjwvYT4s
IG9yIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9ub3RpZmljYXRpb25zL3Vuc3Vic2NyaWJl
LWF1dGgvQUJPN1VaSTdUWFFBUEIzWkZTRU5KM0RaRzc1U1pBVkNORlNNNkFBQUFBQkpGQVBXUENW
SEkyRFNNVlFXSVgzTE1WNDNZVURWTlJXRkVaTFJPVlNYRzVDU01WM0dTWkxYSE1aRENNSlNHSVpU
Q05CVUdBIj51bnN1YnNjcmliZTwvYT4uPGJyIC8+WW91IGFyZSByZWNlaXZpbmcgdGhpcyBiZWNh
dXNlIHlvdSBhcmUgc3Vic2NyaWJlZCB0byB0aGlzIHRocmVhZC48aW1nIHNyYz0iaHR0cHM6Ly9n
aXRodWIuY29tL25vdGlmaWNhdGlvbnMvYmVhY29uL0FCTzdVWkxISjc3UE01WlFCVVhWSUszWkc3
NVNaQTVDTkZTTTZBQUFBQUJKRkFQV1BDV0dHMzNOTlZTVzQ1QzdPUjRYQVpOUktCMldZM0NTTVZZ
WEtaTFRPUkpHSzVUSk1WMzJVWTNQTlZXV0szVFVMNVVXSlRUNTRZTUJBLmdpZiIgaGVpZ2h0PSIx
IiB3aWR0aD0iMSIgYWx0PSIiIC8+PHNwYW4gc3R5bGU9ImNvbG9yOiB0cmFuc3BhcmVudDsgZm9u
dC1zaXplOiAwOyBkaXNwbGF5OiBub25lOyB2aXNpYmlsaXR5OiBoaWRkZW47IG92ZXJmbG93OiBo
aWRkZW47IG9wYWNpdHk6IDA7IHdpZHRoOiAwOyBoZWlnaHQ6IDA7IG1heC13aWR0aDogMDsgbWF4
LWhlaWdodDogMDsgbXNvLWhpZGU6IGFsbCI+TWVzc2FnZSBJRDogPHNwYW4+Jmx0O2thbWFpbGlv
L2thbWFpbGlvL3B1bGwvMzg3NC9yZXZpZXcvMjExMjIzMTQ0MDwvc3Bhbj48c3Bhbj5APC9zcGFu
PjxzcGFuPmdpdGh1Yjwvc3Bhbj48c3Bhbj4uPC9zcGFuPjxzcGFuPmNvbSZndDs8L3NwYW4+PC9z
cGFuPjwvcD4KPHNjcmlwdCB0eXBlPSJhcHBsaWNhdGlvbi9sZCtqc29uIj5bCnsKIkBjb250ZXh0
IjogImh0dHA6Ly9zY2hlbWEub3JnIiwKIkB0eXBlIjogIkVtYWlsTWVzc2FnZSIsCiJwb3RlbnRp
YWxBY3Rpb24iOiB7CiJAdHlwZSI6ICJWaWV3QWN0aW9uIiwKInRhcmdldCI6ICJodHRwczovL2dp
dGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vcHVsbC8zODc0I3B1bGxyZXF1ZXN0cmV2aWV3LTIx
MTIyMzE0NDAiLAoidXJsIjogImh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9w
dWxsLzM4NzQjcHVsbHJlcXVlc3RyZXZpZXctMjExMjIzMTQ0MCIsCiJuYW1lIjogIlZpZXcgUHVs
bCBSZXF1ZXN0Igp9LAoiZGVzY3JpcHRpb24iOiAiVmlldyB0aGlzIFB1bGwgUmVxdWVzdCBvbiBH
aXRIdWIiLAoicHVibGlzaGVyIjogewoiQHR5cGUiOiAiT3JnYW5pemF0aW9uIiwKIm5hbWUiOiAi
R2l0SHViIiwKInVybCI6ICJodHRwczovL2dpdGh1Yi5jb20iCn0KfQpdPC9zY3JpcHQ+

--===============2017993211==--