sr-dev

sr-dev@lists.kamailio.org

17 participants
45448 discussions

git:5.3:2a3b8d43: pkg: add CAP_CHOWN capability to Kamailio systemd service files to allow chown (#2391)
by Henning Westerholt 30 Oct '20

30 Oct '20

Module: kamailio Branch: 5.3 Commit: 2a3b8d43923fc49fa9095e20c6e3cfb6cf5516e1 URL: https://github.com/kamailio/kamailio/commit/2a3b8d43923fc49fa9095e20c6e3cfb… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-30T11:27:25Z pkg: add CAP_CHOWN capability to Kamailio systemd service files to allow chown (#2391) - add CAP_CHOWN capability to Kamailio systemd service files to allow chown - needed e.g. for user and group setting from jsonrpcs and ctl modules - related to github issue #2391 (cherry picked from commit 8b72f462deb4b66fb55f754abc93bf7295278afa) --- Modified: pkg/kamailio/deb/bionic/kamailio.service Modified: pkg/kamailio/deb/buster/kamailio.service Modified: pkg/kamailio/deb/debian/kamailio.service Modified: pkg/kamailio/deb/jessie/kamailio.service Modified: pkg/kamailio/deb/sid/kamailio.service Modified: pkg/kamailio/deb/stretch/kamailio.service Modified: pkg/kamailio/deb/xenial/kamailio.service Modified: pkg/kamailio/obs/kamailio.service --- Diff: https://github.com/kamailio/kamailio/commit/2a3b8d43923fc49fa9095e20c6e3cfb… Patch: https://github.com/kamailio/kamailio/commit/2a3b8d43923fc49fa9095e20c6e3cfb… --- diff --git a/pkg/kamailio/deb/bionic/kamailio.service b/pkg/kamailio/deb/bionic/kamailio.service index a411114db9..91f804dbb9 100644 --- a/pkg/kamailio/deb/bionic/kamailio.service +++ b/pkg/kamailio/deb/bionic/kamailio.service @@ -20,6 +20,8 @@ Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio RuntimeDirectoryMode=0770 +# necessary for chown of control files e.g. for jsonrpcs and ctl modules +AmbientCapabilities=CAP_CHOWN [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/buster/kamailio.service b/pkg/kamailio/deb/buster/kamailio.service index a411114db9..91f804dbb9 100644 --- a/pkg/kamailio/deb/buster/kamailio.service +++ b/pkg/kamailio/deb/buster/kamailio.service @@ -20,6 +20,8 @@ Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio RuntimeDirectoryMode=0770 +# necessary for chown of control files e.g. for jsonrpcs and ctl modules +AmbientCapabilities=CAP_CHOWN [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/debian/kamailio.service b/pkg/kamailio/deb/debian/kamailio.service index a411114db9..91f804dbb9 100644 --- a/pkg/kamailio/deb/debian/kamailio.service +++ b/pkg/kamailio/deb/debian/kamailio.service @@ -20,6 +20,8 @@ Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio RuntimeDirectoryMode=0770 +# necessary for chown of control files e.g. for jsonrpcs and ctl modules +AmbientCapabilities=CAP_CHOWN [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/jessie/kamailio.service b/pkg/kamailio/deb/jessie/kamailio.service index a411114db9..91f804dbb9 100644 --- a/pkg/kamailio/deb/jessie/kamailio.service +++ b/pkg/kamailio/deb/jessie/kamailio.service @@ -20,6 +20,8 @@ Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio RuntimeDirectoryMode=0770 +# necessary for chown of control files e.g. for jsonrpcs and ctl modules +AmbientCapabilities=CAP_CHOWN [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/sid/kamailio.service b/pkg/kamailio/deb/sid/kamailio.service index a411114db9..91f804dbb9 100644 --- a/pkg/kamailio/deb/sid/kamailio.service +++ b/pkg/kamailio/deb/sid/kamailio.service @@ -20,6 +20,8 @@ Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio RuntimeDirectoryMode=0770 +# necessary for chown of control files e.g. for jsonrpcs and ctl modules +AmbientCapabilities=CAP_CHOWN [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/stretch/kamailio.service b/pkg/kamailio/deb/stretch/kamailio.service index a411114db9..91f804dbb9 100644 --- a/pkg/kamailio/deb/stretch/kamailio.service +++ b/pkg/kamailio/deb/stretch/kamailio.service @@ -20,6 +20,8 @@ Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio RuntimeDirectoryMode=0770 +# necessary for chown of control files e.g. for jsonrpcs and ctl modules +AmbientCapabilities=CAP_CHOWN [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/xenial/kamailio.service b/pkg/kamailio/deb/xenial/kamailio.service index a411114db9..91f804dbb9 100644 --- a/pkg/kamailio/deb/xenial/kamailio.service +++ b/pkg/kamailio/deb/xenial/kamailio.service @@ -20,6 +20,8 @@ Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio RuntimeDirectoryMode=0770 +# necessary for chown of control files e.g. for jsonrpcs and ctl modules +AmbientCapabilities=CAP_CHOWN [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/obs/kamailio.service b/pkg/kamailio/obs/kamailio.service index c14d6cb2f2..56d8339939 100644 --- a/pkg/kamailio/obs/kamailio.service +++ b/pkg/kamailio/obs/kamailio.service @@ -13,6 +13,8 @@ Environment='PKG_MEMORY=4' EnvironmentFile=-/etc/sysconfig/kamailio ExecStart=/usr/sbin/kamailio -DD -P /var/run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_MEMORY -M $PKG_MEMORY Restart=on-failure +# necessary for chown of control files e.g. for jsonrpcs and ctl modules +AmbientCapabilities=CAP_CHOWN [Install] WantedBy=multi-user.target

1 0

git:5.4:f76216bb: pkg: add CAP_CHOWN capability to Kamailio systemd service files to allow chown (#2391)
by Henning Westerholt 30 Oct '20

30 Oct '20

Module: kamailio Branch: 5.4 Commit: f76216bb1fab2dd39413915bc2db88d9c588a56e URL: https://github.com/kamailio/kamailio/commit/f76216bb1fab2dd39413915bc2db88d… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-30T11:22:26Z pkg: add CAP_CHOWN capability to Kamailio systemd service files to allow chown (#2391) - add CAP_CHOWN capability to Kamailio systemd service files to allow chown - needed e.g. for user and group setting from jsonrpcs and ctl modules - related to github issue #2391 (cherry picked from commit 8b72f462deb4b66fb55f754abc93bf7295278afa) --- Modified: pkg/kamailio/deb/bionic/kamailio.service Modified: pkg/kamailio/deb/buster/kamailio.service Modified: pkg/kamailio/deb/debian/kamailio.service Modified: pkg/kamailio/deb/focal/kamailio.service Modified: pkg/kamailio/deb/jessie/kamailio.service Modified: pkg/kamailio/deb/sid/kamailio.service Modified: pkg/kamailio/deb/stretch/kamailio.service Modified: pkg/kamailio/deb/xenial/kamailio.service Modified: pkg/kamailio/obs/kamailio.service --- Diff: https://github.com/kamailio/kamailio/commit/f76216bb1fab2dd39413915bc2db88d… Patch: https://github.com/kamailio/kamailio/commit/f76216bb1fab2dd39413915bc2db88d…

1 0

www.kamailio.org maintenance on 29th October 2020, 10:00 CET
by Henning Westerholt 29 Oct '20

29 Oct '20

Hello, there will be a short planned maintenance on www.kamailio.org<http://www.kamailio.org> on 29th October 2020 at 10:00 CET. Relevant services including main homepage and documentation wiki will be unavailable for about 10-15 minutes. Best regards, Henning -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.com<https://gilawa.com/>

1 1

[kamailio/kamailio] ndb_redis: Fix leaks from PV parsing (#2536)
by weili-jiang 29 Oct '20

29 Oct '20

- Add missing pkg_free for the dynamic PV name created during PV parsing - Add missing pkg_free for any GPARAM_TYPE_PVS created during PV parsing #### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description We are using NDB_REDIS in anger, fetching data from changing hash structures. NDB_REDIS creates dynamic PVs, and in order to do so it has a custom parser that allocates a dynamic PV structure as well as potentially multiple nested parameter structures. We very quickly found that we were running out of package memory, and enabling Kamailio's own memory debug logging quickly revealed that every `$redis(...)` query was leaking. It appears that the allocated structures are only used within the subsequent handler to fetch the data. Therefore, to resolve the leak, the allocated structures are freed after the data for the PV in question has been fetched. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2536 -- Commit Summary -- * ndb_redis: Fix leaks from PV parsing -- File Changes -- M src/modules/ndb_redis/ndb_redis_mod.c (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2536.patch https://github.com/kamailio/kamailio/pull/2536.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2536

2 9

[kamailio/kamailio] app_python3.so undefined symbol: PyExc_SystemExit on Ubuntu 20.04 (#2534)
by Dylan 28 Oct '20

28 Oct '20

# Description We installed kamailio from the ubuntu package manager along with several of the modules, including `kamailio-python3-modules`, which gives us the app_python3 module. We edited the default, provided config to add the lines ``` loadmodule "app_python3.so" ... modparam("app_python3", "load", "my_cool_python_file.py") ``` Restarted kamailio and found the log messages below. #### Log Messages ``` Oct 27 20:05:19 kamailio-stage-1 systemd[1]: Starting Kamailio SIP Server... Oct 27 20:05:19 kamailio-stage-1 kamailio[2243329]: 0(2243329) ERROR: <core> [core/sr_module.c:512]: load_module(): could not open module </usr/lib/x86_64-linux-gnu/kamailio/modules/app_python3.so>: /usr/lib/x86_64-linux-gnu/kamailio/modules/app_python3.so: undefined symbol: PyExc_SystemExit Oct 27 20:05:19 kamailio-stage-1 kamailio[2243329]: 0(2243329) CRITICAL: <core> [core/cfg.y:3536]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 266, column 12-27: failed to load module Oct 27 20:05:19 kamailio-stage-1 kamailio[2243329]: 0(2243329) ERROR: <core> [core/modparam.c:176]: set_mod_param_regex(): No module matching <app_python3> found Oct 27 20:05:19 kamailio-stage-1 kamailio[2243329]: 0(2243329) CRITICAL: <core> [core/cfg.y:3539]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 496, column 64: Can't set module parameter ``` ### Additional Information ``` version: kamailio 5.3.2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 9.2.1 ``` * **Operating System**: ``` Linux kamailio-stage-1 5.4.0-1024-aws #24-Ubuntu SMP Sat Sep 5 06:19:55 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux ``` `lsb_release -a` ``` No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.1 LTS Release: 20.04 Codename: focal ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2534

2 4

git:5.3:5203503b: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 28 Oct '20

28 Oct '20

Module: kamailio Branch: 5.3 Commit: 5203503bad2f035012c47887bf35d6b3eeef1873 URL: https://github.com/kamailio/kamailio/commit/5203503bad2f035012c47887bf35d6b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-10-28T20:31:33+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/uac/README --- Diff: https://github.com/kamailio/kamailio/commit/5203503bad2f035012c47887bf35d6b… Patch: https://github.com/kamailio/kamailio/commit/5203503bad2f035012c47887bf35d6b… --- diff --git a/src/modules/uac/README b/src/modules/uac/README index 7e21cccbb7..42eeabd542 100644 --- a/src/modules/uac/README +++ b/src/modules/uac/README @@ -776,8 +776,9 @@ failure_route[TRUNKAUTH] { if(t_check_status("401|407")) { $avp(auser) = "test"; $avp(apass) = "test"; - uac_auth(); - t_relay(); + if (uac_auth()) { + t_relay(); + } exit; } }

1 0

git:master:fe195800: modules: readme files regenerated - uac ... [skip ci]
by Kamailio Dev 28 Oct '20

28 Oct '20

Module: kamailio Branch: master Commit: fe1958005feb2584d3d382ca2e7644ab388e4a8b URL: https://github.com/kamailio/kamailio/commit/fe1958005feb2584d3d382ca2e7644a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-10-28T20:31:10+01:00 modules: readme files regenerated - uac ... [skip ci] --- Modified: src/modules/uac/README --- Diff: https://github.com/kamailio/kamailio/commit/fe1958005feb2584d3d382ca2e7644a… Patch: https://github.com/kamailio/kamailio/commit/fe1958005feb2584d3d382ca2e7644a… --- diff --git a/src/modules/uac/README b/src/modules/uac/README index 07ee88484b..52d98d3d65 100644 --- a/src/modules/uac/README +++ b/src/modules/uac/README @@ -809,6 +809,7 @@ failure_route[TRUNKAUTH] { $avp(auser) = "test"; $avp(apass) = "test"; # $avp(apass) = "36d0a02793542b4961e8348347236dbf"; + # if (uac_auth("1")) { if (uac_auth()) { t_relay(); }

1 0

git:master:f4a2e75b: uac: add small commented out mode 1 back for uac_auth() function
by Henning Westerholt 28 Oct '20

28 Oct '20

Module: kamailio Branch: master Commit: f4a2e75b90e87dc86c638c77ff12414b9d3469dd URL: https://github.com/kamailio/kamailio/commit/f4a2e75b90e87dc86c638c77ff12414… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-28T19:20:23Z uac: add small commented out mode 1 back for uac_auth() function --- Modified: src/modules/uac/doc/uac_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/f4a2e75b90e87dc86c638c77ff12414… Patch: https://github.com/kamailio/kamailio/commit/f4a2e75b90e87dc86c638c77ff12414… --- diff --git a/src/modules/uac/doc/uac_admin.xml b/src/modules/uac/doc/uac_admin.xml index 02dd513d27..42fe2d9148 100644 --- a/src/modules/uac/doc/uac_admin.xml +++ b/src/modules/uac/doc/uac_admin.xml @@ -877,6 +877,7 @@ failure_route[TRUNKAUTH] { $avp(auser) = "test"; $avp(apass) = "test"; # $avp(apass) = "36d0a02793542b4961e8348347236dbf"; + # if (uac_auth("1")) { if (uac_auth()) { t_relay(); }

1 0

git:5.3:a38403ca: uac: extend docs for uac_auth() example, only t_relay() on success
by Henning Westerholt 28 Oct '20

28 Oct '20

Module: kamailio Branch: 5.3 Commit: a38403ca6633b5944acebca245d5d64511a4cbca URL: https://github.com/kamailio/kamailio/commit/a38403ca6633b5944acebca245d5d64… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-28T19:17:37Z uac: extend docs for uac_auth() example, only t_relay() on success - extend docs for uac_auth() example, only t_relay() on success - otherwise you will get a 'no branches for forwarding' error from tm (cherry picked from commit 668402e77c19ba4b5b8fc5b6c869ffbf34ea622d) --- Modified: src/modules/uac/doc/uac_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/a38403ca6633b5944acebca245d5d64… Patch: https://github.com/kamailio/kamailio/commit/a38403ca6633b5944acebca245d5d64… --- diff --git a/src/modules/uac/doc/uac_admin.xml b/src/modules/uac/doc/uac_admin.xml index ba29c42022..de121a61b8 100644 --- a/src/modules/uac/doc/uac_admin.xml +++ b/src/modules/uac/doc/uac_admin.xml @@ -836,8 +836,9 @@ failure_route[TRUNKAUTH] { if(t_check_status("401|407")) { $avp(auser) = "test"; $avp(apass) = "test"; - uac_auth(); - t_relay(); + if (uac_auth()) { + t_relay(); + } exit; } }

1 0

git:5.3:d23bbb59: uac: do not silently fail on realm lookup error, at least log with INFO
by Henning Westerholt 28 Oct '20

28 Oct '20

Module: kamailio Branch: 5.3 Commit: d23bbb5917fcd7ca51990e7dfe31dcf55d674247 URL: https://github.com/kamailio/kamailio/commit/d23bbb5917fcd7ca51990e7dfe31dcf… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-28T19:13:12Z uac: do not silently fail on realm lookup error, at least log with INFO (cherry picked from commit b6c10c8181d670a81a7d1216c7e6ec81c0963e9c) --- Modified: src/modules/uac/auth.c --- Diff: https://github.com/kamailio/kamailio/commit/d23bbb5917fcd7ca51990e7dfe31dcf… Patch: https://github.com/kamailio/kamailio/commit/d23bbb5917fcd7ca51990e7dfe31dcf… --- diff --git a/src/modules/uac/auth.c b/src/modules/uac/auth.c index a412dae975..f68c1cafc9 100644 --- a/src/modules/uac/auth.c +++ b/src/modules/uac/auth.c @@ -446,7 +446,7 @@ int uac_auth(sip_msg_t *msg) /* found? */ if (crd==0) { - LM_DBG("no credential for realm \"%.*s\"\n", + LM_INFO("no credential for realm \"%.*s\"\n", auth.realm.len, auth.realm.s); goto error; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev