sr-dev

sr-dev@lists.kamailio.org

22 participants
45189 discussions

[kamailio/kamailio] TOPOS not handling change of to-tag in provisional responses (#2489)
by James Brown 01 Oct '20

01 Oct '20

### Description TOPOS Module is not handling change of to-tags in provisional responses. When the B party sends two provisional responses (to an INVITE) with different to tags, a subsequent PRACK does not get handled/routed correctly. In this deployment, dbtext is used. ### Troubleshooting The TOPOS module is enabled in kamailio 5.3.6. ``` A1 Kamailio B1 INVITE --> <-- 100 INVITE --> <-- 100 <-- 180 (to-tag = randomtag20354) <-- 180 (to-tag = randomtag20354) <-- 183 (to-tag = randomtag20354DAE) <-- 183 (to-tag = randomtag20354DAE) PRACK (to-tag = randomtag20354DAE) --> <-- 403 PRACK ``` The 180-Ringing response does not have a Require header field with 100rel, but the 183-Session-Progress response does have `Require:100rel` in it. When the A1 sends the PRACK request, the to-tag matches that in the 183-Session-Progress response, but the TOPOS module does not decode the message. Then, when kamailio processes this PRACK request, it does not have the expected Route header fields or expected RURI and cannot be routed to B1 (so a 403 response happens). #### Reproduction - enable TOPOS module with text database and apply it to all transactions - make an INVITE through the proxy, with `Supported:100rel` - send a 180-Ringing response from the B party - send a 183-Session-Progress response from the B party, with `Require:100rel` and a different to-tag - watch the PRACK request fail #### Debugging Data ``` I can provide debugging data later. ``` #### Log Messages ``` I can provide logging data later. ``` #### SIP Traffic  ``` https://pastebin.com/XEf2Ndh2 ``` ### Possible Solutions Unknown  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.6 (x86_64/linux) bf6c08 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: bf6c08 compiled on 09:57:03 Sep 10 2020 with gcc 8.3.0 ``` * **Operating System**: ``` Debian 10.4 in docker 4.15.0-51-generic Client: Docker Engine - Community Version: 19.03.5 API version: 1.40 Go version: go1.12.12 Git commit: 633a0ea838 Built: Wed Nov 13 07:29:52 2019 OS/Arch: linux/amd64 Experimental: false Server: Docker Engine - Community Engine: Version: 19.03.5 API version: 1.40 (minimum version 1.12) Go version: go1.12.12 Git commit: 633a0ea838 Built: Wed Nov 13 07:28:22 2019 OS/Arch: linux/amd64 Experimental: false containerd: Version: 1.2.10 GitCommit: b34a5c8af56e510852c35414db4c1f4fa6172339 runc: Version: 1.0.0-rc8+dev GitCommit: 3e425f80a8c931f88e6d94a8c831b9d5aa481657 docker-init: Version: 0.18.0 GitCommit: fec3683 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2489

3 4

git:5.2:2e4fce40: topos: update to-tag and rr on reply even to-tag is already set
by Henning Westerholt 01 Oct '20

01 Oct '20

Module: kamailio Branch: 5.2 Commit: 2e4fce406eab4b4ee780381755af17005b172c4e URL: https://github.com/kamailio/kamailio/commit/2e4fce406eab4b4ee780381755af170… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-01T17:21:37Z topos: update to-tag and rr on reply even to-tag is already set - GH #2489 (cherry picked from commit acd7f6f1703d12aa8f2dce87e1b8e4b74d6b4d96) --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/2e4fce406eab4b4ee780381755af170… Patch: https://github.com/kamailio/kamailio/commit/2e4fce406eab4b4ee780381755af170… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 3bae45ec13..a4e6a6802b 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -1226,7 +1226,7 @@ int tps_db_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, nr_keys = 0; nr_ucols = 0; - db_keys[nr_keys]=&td_col_a_uuid; + db_keys[nr_keys]=&tt_col_a_uuid; db_ops[nr_keys]=OP_EQ; db_vals[nr_keys].type = DB1_STR; db_vals[nr_keys].nul = 0; @@ -1249,8 +1249,7 @@ int tps_db_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, } if((mode & TPS_DBU_RPLATTRS) && msg->first_line.type==SIP_REPLY) { - if(sd->b_tag.len<=0 - && msg->first_line.u.reply.statuscode>=180 + if(msg->first_line.u.reply.statuscode>=180 && msg->first_line.u.reply.statuscode<200) { db_ucols[nr_ucols] = &tt_col_y_rr;

1 0

git:5.3:0f8f2f52: topos: update to-tag and rr on reply even to-tag is already set
by Henning Westerholt 01 Oct '20

01 Oct '20

Module: kamailio Branch: 5.3 Commit: 0f8f2f523ecd282df260f83c8cd2e2ab193b543b URL: https://github.com/kamailio/kamailio/commit/0f8f2f523ecd282df260f83c8cd2e2a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-01T17:21:23Z topos: update to-tag and rr on reply even to-tag is already set - GH #2489 (cherry picked from commit acd7f6f1703d12aa8f2dce87e1b8e4b74d6b4d96) --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/0f8f2f523ecd282df260f83c8cd2e2a… Patch: https://github.com/kamailio/kamailio/commit/0f8f2f523ecd282df260f83c8cd2e2a… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 3bae45ec13..a4e6a6802b 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -1226,7 +1226,7 @@ int tps_db_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, nr_keys = 0; nr_ucols = 0; - db_keys[nr_keys]=&td_col_a_uuid; + db_keys[nr_keys]=&tt_col_a_uuid; db_ops[nr_keys]=OP_EQ; db_vals[nr_keys].type = DB1_STR; db_vals[nr_keys].nul = 0; @@ -1249,8 +1249,7 @@ int tps_db_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, } if((mode & TPS_DBU_RPLATTRS) && msg->first_line.type==SIP_REPLY) { - if(sd->b_tag.len<=0 - && msg->first_line.u.reply.statuscode>=180 + if(msg->first_line.u.reply.statuscode>=180 && msg->first_line.u.reply.statuscode<200) { db_ucols[nr_ucols] = &tt_col_y_rr;

1 0

git:5.4:8006da08: topos: update to-tag and rr on reply even to-tag is already set
by Henning Westerholt 01 Oct '20

01 Oct '20

Module: kamailio Branch: 5.4 Commit: 8006da08a44d15c37b07e20ea95e03b07ae1e66a URL: https://github.com/kamailio/kamailio/commit/8006da08a44d15c37b07e20ea95e03b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-01T17:20:58Z topos: update to-tag and rr on reply even to-tag is already set - GH #2489 (cherry picked from commit acd7f6f1703d12aa8f2dce87e1b8e4b74d6b4d96) --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/8006da08a44d15c37b07e20ea95e03b… Patch: https://github.com/kamailio/kamailio/commit/8006da08a44d15c37b07e20ea95e03b… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 9cdd9ff3d5..c08304d1ec 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -1226,7 +1226,7 @@ int tps_db_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, nr_keys = 0; nr_ucols = 0; - db_keys[nr_keys]=&td_col_a_uuid; + db_keys[nr_keys]=&tt_col_a_uuid; db_ops[nr_keys]=OP_EQ; db_vals[nr_keys].type = DB1_STR; db_vals[nr_keys].nul = 0; @@ -1249,8 +1249,7 @@ int tps_db_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, } if((mode & TPS_DBU_RPLATTRS) && msg->first_line.type==SIP_REPLY) { - if(sd->b_tag.len<=0 - && msg->first_line.u.reply.statuscode>=180 + if(msg->first_line.u.reply.statuscode>=180 && msg->first_line.u.reply.statuscode<200) { db_ucols[nr_ucols] = &tt_col_y_rr;

1 0

[kamailio/kamailio] Run your own SIP VoIP service on both IPv4 and IPv6 (RTPproxy) (#2490)
by amen160 01 Oct '20

01 Oct '20

Hi Everybody. I try setup call from one Device Ipv6 to device Ipv4, but the audio is one way. I use the example here (it quite old) http://kb.asipto.com/kamailio:kamailio-mixed-ipv4-ipv6. Does anyone see the error or can someone give me a tip? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2490

2 2

git:master:757d34ed: .github/CONTRIBUTING.md: link to github docs for pull requests
by Daniel-Constantin Mierla 01 Oct '20

01 Oct '20

Module: kamailio Branch: master Commit: 757d34ed5baf2f5f002f95a386579fe95621098d URL: https://github.com/kamailio/kamailio/commit/757d34ed5baf2f5f002f95a386579fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-01T11:10:01+02:00 .github/CONTRIBUTING.md: link to github docs for pull requests --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/757d34ed5baf2f5f002f95a386579fe… Patch: https://github.com/kamailio/kamailio/commit/757d34ed5baf2f5f002f95a386579fe… --- diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 68fa7f5e4d..9289eec2de 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -37,7 +37,10 @@ and commit history, there are several *rules* required for each contribution. ### Basic Rules ### * github pull request is the favorited mechanism to submit contributions - (patches) + (patches). See more about at: + * [Github Docs On Proposing Changes With Pull Requests](https://docs.github.com/en/free-pro-team@latest/github/collaborat… + * the URL to Kamailio project pull requests portal: + * https://github.com/kamailio/kamailio/pulls * make a pull request against **master branch** * commit can be later backported to stable branch(es) * make a pull request for each new feature

1 0

git:master:acd7f6f1: topos: update to-tag and rr on reply even to-tag is already set
by Daniel-Constantin Mierla 01 Oct '20

01 Oct '20

Module: kamailio Branch: master Commit: acd7f6f1703d12aa8f2dce87e1b8e4b74d6b4d96 URL: https://github.com/kamailio/kamailio/commit/acd7f6f1703d12aa8f2dce87e1b8e4b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-01T10:04:50+02:00 topos: update to-tag and rr on reply even to-tag is already set - GH #2489 --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/acd7f6f1703d12aa8f2dce87e1b8e4b… Patch: https://github.com/kamailio/kamailio/commit/acd7f6f1703d12aa8f2dce87e1b8e4b… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index ae7a4ec2c1..b506a94b97 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -1343,7 +1343,7 @@ int tps_db_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, nr_keys = 0; nr_ucols = 0; - db_keys[nr_keys]=&td_col_a_uuid; + db_keys[nr_keys]=&tt_col_a_uuid; db_ops[nr_keys]=OP_EQ; db_vals[nr_keys].type = DB1_STR; db_vals[nr_keys].nul = 0; @@ -1366,8 +1366,7 @@ int tps_db_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, } if((mode & TPS_DBU_RPLATTRS) && msg->first_line.type==SIP_REPLY) { - if(sd->b_tag.len<=0 - && msg->first_line.u.reply.statuscode>=180 + if(msg->first_line.u.reply.statuscode>=180 && msg->first_line.u.reply.statuscode<200) { db_ucols[nr_ucols] = &tt_col_y_rr;

1 0

git:master:8301f366: topos: store branch record before dialog record
by Daniel-Constantin Mierla 01 Oct '20

01 Oct '20

Module: kamailio Branch: master Commit: 8301f366538ef7e63096d9fe10fa5c2aee780e81 URL: https://github.com/kamailio/kamailio/commit/8301f366538ef7e63096d9fe10fa5c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-01T09:44:59+02:00 topos: store branch record before dialog record --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/8301f366538ef7e63096d9fe10fa5c2… Patch: https://github.com/kamailio/kamailio/commit/8301f366538ef7e63096d9fe10fa5c2… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index ae4a635c1f..ae7a4ec2c1 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -545,6 +545,8 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) ret = tps_storage_link_msg(msg, td, dir); if(ret<0) goto error; + ret = _tps_storage_api.insert_branch(td); + if(ret<0) goto error; if(dialog==0) { if(td->as_contact.len <= 0 && td->bs_contact.len <= 0) { LM_WARN("no local address - do record routing for all initial requests\n"); @@ -552,8 +554,6 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) ret = _tps_storage_api.insert_dialog(td); if(ret<0) goto error; } - ret = _tps_storage_api.insert_branch(td); - if(ret<0) goto error; return 0;

1 0

Re: [sr-dev] [kamailio/kamailio] cfgt: crash trying to get $T_rpl() value using pv_get_spec_value() (#2479)
by Daniel-Constantin Mierla 30 Sep '20

30 Sep '20

Closed #2479. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2479#event-3824129189

1 0

Re: [sr-dev] [kamailio/kamailio] cfgt: crash trying to get $T_rpl() value using pv_get_spec_value() (#2479)
by Daniel-Constantin Mierla 30 Sep '20

30 Sep '20

@linuxmaniac - closing this one, 2e7710e should fix it. Once you test and it is ok, then you can backport as needed. If still an issues, then reopen. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2479#issuecomment-701344668

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev