sr-dev

sr-dev@lists.kamailio.org

20 participants
45159 discussions

git:master:cb58e78e: Revert "core: io wait - unhash in case delete operation fails because of EBADF"
by Daniel-Constantin Mierla 07 Jul '20

07 Jul '20

Module: kamailio Branch: master Commit: cb58e78eaac941cc042a71e049568b2dae611e4b URL: https://github.com/kamailio/kamailio/commit/cb58e78eaac941cc042a71e049568b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-07-07T17:36:22+02:00 Revert "core: io wait - unhash in case delete operation fails because of EBADF" This reverts commit 60119faef5282b135ef7c972d15e1017ca26815a. --- Modified: src/core/io_wait.h --- Diff: https://github.com/kamailio/kamailio/commit/cb58e78eaac941cc042a71e049568b2… Patch: https://github.com/kamailio/kamailio/commit/cb58e78eaac941cc042a71e049568b2… --- diff --git a/src/core/io_wait.h b/src/core/io_wait.h index ddc7e80324..251c65fdff 100644 --- a/src/core/io_wait.h +++ b/src/core/io_wait.h @@ -669,12 +669,6 @@ inline static int io_watch_del(io_wait_h* h, int fd, int idx, int flags) if (errno==EAGAIN) goto again_epoll; LM_ERR("removing fd %d from epoll list failed: %s [%d]\n", fd, strerror(errno), errno); - if (unlikely(errno==EBADF)) { - LM_ERR("unhashing of invalid fd - %d (epfd %d)\n", fd, - h->h->epfd); - unhash_fd_map(e); - h->fd_no--; - } goto error; } #ifdef EPOLL_NO_CLOSE_BUG

1 0

git:master:846cc5b9: core: io wait - unhash in case delete operation fails because of EBADF
by Daniel-Constantin Mierla 07 Jul '20

07 Jul '20

Module: kamailio Branch: master Commit: 846cc5b97a907b5314ccf03772776e0d23434042 URL: https://github.com/kamailio/kamailio/commit/846cc5b97a907b5314ccf03772776e0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-07-07T17:37:00+02:00 core: io wait - unhash in case delete operation fails because of EBADF - EBADF: epfd or fd is not a valid file descriptor --- Modified: src/core/io_wait.h --- Diff: https://github.com/kamailio/kamailio/commit/846cc5b97a907b5314ccf03772776e0… Patch: https://github.com/kamailio/kamailio/commit/846cc5b97a907b5314ccf03772776e0… --- diff --git a/src/core/io_wait.h b/src/core/io_wait.h index 251c65fdff..04186c72ad 100644 --- a/src/core/io_wait.h +++ b/src/core/io_wait.h @@ -669,6 +669,13 @@ inline static int io_watch_del(io_wait_h* h, int fd, int idx, int flags) if (errno==EAGAIN) goto again_epoll; LM_ERR("removing fd %d from epoll list failed: %s [%d]\n", fd, strerror(errno), errno); + if (unlikely(errno==EBADF)) { + LM_ERR("unhashing of invalid fd - %d (epfd %d)\n", fd, + h->epfd); + unhash_fd_map(e); + h->fd_no--; + } + goto error; } #ifdef EPOLL_NO_CLOSE_BUG

1 0

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)
by Richard Fuchs 07 Jul '20

07 Jul '20

@miconda it happens on every delete. Our "table definitions" use Redis sets to simulate non-unique database indexes. For example if we have a key `entry:foobar` that is a hash and includes a key "test = blah" (so, `HMSET entry:foobar test blah`) and we use the "test" key as a non-unique index, then we'd have a set `index:test:blah` that includes `entry:foobar` as member (`SADD index:test:blah entry:foobar`). So when deleting `entry:foobar` we need to delete that from the `index:test:blah` set (`SREM ...`). This requires fetching the contents of the `entry:foobar` hash when deleting it. So with this commit, when `entry:foobar` is deleted directly by name, there will be no "manual keys" and so the HMGET is skipped and so the SREM fails. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…

1 0

Broken: kamailio/kamailio#9117 (master - 60119fa)
by Travis CI 07 Jul '20

07 Jul '20

Build Update for kamailio/kamailio ------------------------------------- Build: #9117 Status: Broken Duration: 2 mins and 2 secs Commit: 60119fa (master) Author: Daniel-Constantin Mierla Message: core: io wait - unhash in case delete operation fails because of EBADF - EBADF: epfd or fd is not a valid file descriptor View the changeset: https://github.com/kamailio/kamailio/compare/65159728a442...60119faef528 View the full build log and details: https://travis-ci.org/github/kamailio/kamailio/builds/705832405?utm_medium=… -- You can unsubscribe from build emails from the kamailio/kamailio repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3596148&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

git:master:60119fae: core: io wait - unhash in case delete operation fails because of EBADF
by Daniel-Constantin Mierla 07 Jul '20

07 Jul '20

Module: kamailio Branch: master Commit: 60119faef5282b135ef7c972d15e1017ca26815a URL: https://github.com/kamailio/kamailio/commit/60119faef5282b135ef7c972d15e101… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-07-07T17:25:00+02:00 core: io wait - unhash in case delete operation fails because of EBADF - EBADF: epfd or fd is not a valid file descriptor --- Modified: src/core/io_wait.h --- Diff: https://github.com/kamailio/kamailio/commit/60119faef5282b135ef7c972d15e101… Patch: https://github.com/kamailio/kamailio/commit/60119faef5282b135ef7c972d15e101… --- diff --git a/src/core/io_wait.h b/src/core/io_wait.h index 251c65fdff..ddc7e80324 100644 --- a/src/core/io_wait.h +++ b/src/core/io_wait.h @@ -669,6 +669,12 @@ inline static int io_watch_del(io_wait_h* h, int fd, int idx, int flags) if (errno==EAGAIN) goto again_epoll; LM_ERR("removing fd %d from epoll list failed: %s [%d]\n", fd, strerror(errno), errno); + if (unlikely(errno==EBADF)) { + LM_ERR("unhashing of invalid fd - %d (epfd %d)\n", fd, + h->h->epfd); + unhash_fd_map(e); + h->fd_no--; + } goto error; } #ifdef EPOLL_NO_CLOSE_BUG

1 0

git:master:331a5f99: dlgs: filled tags add and count functions
by Daniel-Constantin Mierla 07 Jul '20

07 Jul '20

Module: kamailio Branch: master Commit: 331a5f999b9aa4ddd112b837bb3d350507de2a12 URL: https://github.com/kamailio/kamailio/commit/331a5f999b9aa4ddd112b837bb3d350… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-07-07T09:26:22+02:00 dlgs: filled tags add and count functions --- Modified: src/modules/dlgs/dlgs_mod.c Modified: src/modules/dlgs/dlgs_records.c Modified: src/modules/dlgs/dlgs_records.h --- Diff: https://github.com/kamailio/kamailio/commit/331a5f999b9aa4ddd112b837bb3d350… Patch: https://github.com/kamailio/kamailio/commit/331a5f999b9aa4ddd112b837bb3d350…

1 0

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)
by Daniel-Constantin Mierla 07 Jul '20

07 Jul '20

@rfuchs - apparently the patch was supposed to delete all entries, without a need to match on filters, according to PR #2140. Like the sql `delete from table` without `where` clause. Now I understand that the sets keeping indexes are left. Does it happen for every type of `delete`, even when it has filters (i.e., `where` conditions)? Or only in the case of `delete all`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…

1 0

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)
by Richard Fuchs 07 Jul '20

07 Jul '20

Hello @rdboisvert and @henningw We bumped into this commit on our deployments because it was causing some issues. In particular it makes the Redis SETs that we use a pseudo-indexes being left over in the Redis DB after a delete operation. The reason is that even for deletes that can be done directly (no/empty "manual keys") the contents of the entry still need to be fetched because the contents are part of the key names used for pseudo-index SETs. The patch we came up with is exactly the reversal of this commit, so obviously I need to ask about the intentions behind it, since I'm sure you had a good reason to do it :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…

1 0

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.1.10 crash in EVP_DecryptUpdate() (#2394)
by Henning Westerholt 07 Jul '20

07 Jul '20

Confirmed, close this one. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2394#issuecomment-654838357

1 0

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.1.10 crash in EVP_DecryptUpdate() (#2394)
by Henning Westerholt 07 Jul '20

07 Jul '20

Closed #2394. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2394#event-3520292045

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev