sr-dev

sr-dev@lists.kamailio.org

20 participants
45178 discussions

git:master:9d9bb4c0: dlgs: fill in the totag on answer response
by Daniel-Constantin Mierla 25 Jun '20

25 Jun '20

Module: kamailio Branch: master Commit: 9d9bb4c02e8dc870e5a65a5fb87ec28c825738d1 URL: https://github.com/kamailio/kamailio/commit/9d9bb4c02e8dc870e5a65a5fb87ec28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-25T09:17:38+02:00 dlgs: fill in the totag on answer response --- Modified: src/modules/dlgs/dlgs_records.c --- Diff: https://github.com/kamailio/kamailio/commit/9d9bb4c02e8dc870e5a65a5fb87ec28… Patch: https://github.com/kamailio/kamailio/commit/9d9bb4c02e8dc870e5a65a5fb87ec28… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index 08b0ab4bad..1a21f355db 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -570,6 +570,15 @@ int dlgs_update_item(sip_msg_t *msg) || it->state==DLGS_STATE_PROGRESS) { it->state = DLGS_STATE_ANSWERED; it->ts_answer = tnow; + if(it->ttag.len<=0) { + to_body_t *tb; + tb = get_to(msg); + if(tb!=NULL && tb->tag_value.len>0 + && (tb->tag_value.len<DLGS_TOTAG_SIZE-1)) { + it->ttag.len = tb->tag_value.len; + memcpy(it->ttag.s, tb->tag_value.s, tb->tag_value.len); + } + } } } else if(rcode>=300) { if(it->state==DLGS_STATE_INIT

1 0

git:master:edd35d35: modules: readme files regenerated - pua ... [skip ci]
by Kamailio Dev 24 Jun '20

24 Jun '20

Module: kamailio Branch: master Commit: edd35d35e4a0bffc0d68decb6a7895b4d47823dc URL: https://github.com/kamailio/kamailio/commit/edd35d35e4a0bffc0d68decb6a7895b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-06-24T21:16:15+02:00 modules: readme files regenerated - pua ... [skip ci] --- Modified: src/modules/pua/README --- Diff: https://github.com/kamailio/kamailio/commit/edd35d35e4a0bffc0d68decb6a7895b… Patch: https://github.com/kamailio/kamailio/commit/edd35d35e4a0bffc0d68decb6a7895b… --- diff --git a/src/modules/pua/README b/src/modules/pua/README index e232590207..3079312646 100644 --- a/src/modules/pua/README +++ b/src/modules/pua/README @@ -193,7 +193,7 @@ modparam("pua", "hash_size", 11) Example 1.2. Set db_url parameter ... -modparam("pua", "db_url" "dbdriver://username:password@dbhost/dbname") +modparam("pua", "db_url", "dbdriver://username:password@dbhost/dbname") ... 3.3. db_table (str)

1 0

[kamailio/kamailio] pua readme : small typo (#2371)
by ThomasSevestre 24 Jun '20

24 Jun '20

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2371 -- Commit Summary -- * pua readme : small typo -- File Changes -- M src/modules/pua/README (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2371.patch https://github.com/kamailio/kamailio/pull/2371.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2371

2 4

git:master:9adccda3: pua: docs - fixed missing comma in example
by GitHub 24 Jun '20

24 Jun '20

Module: kamailio Branch: master Commit: 9adccda325d258fe539b54ec67d4389d3a2fc72c URL: https://github.com/kamailio/kamailio/commit/9adccda325d258fe539b54ec67d4389… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2020-06-24T21:05:56+02:00 pua: docs - fixed missing comma in example - picked from #2371 --- Modified: src/modules/pua/doc/pua_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/9adccda325d258fe539b54ec67d4389… Patch: https://github.com/kamailio/kamailio/commit/9adccda325d258fe539b54ec67d4389… --- diff --git a/src/modules/pua/doc/pua_admin.xml b/src/modules/pua/doc/pua_admin.xml index 51d0fa3794..c4d6ab7c29 100644 --- a/src/modules/pua/doc/pua_admin.xml +++ b/src/modules/pua/doc/pua_admin.xml @@ -112,7 +112,7 @@ modparam("pua", "hash_size", 11) <title>Set <varname>db_url</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("pua", "db_url" "&exampledb;") +modparam("pua", "db_url", "&exampledb;") ... </programlisting> </example>

1 0

[kamailio/kamailio] keepalive: manage the `ping_from` config value as str. (#2372)
by Daniel Martínez Ruiz 24 Jun '20

24 Jun '20

Managing the config value as a string (`char*`) doesn't change the string size, so the value is cut off to the default value size (26 chars).   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2372 -- Commit Summary -- * keepalive: manage the `ping_from` config value as str. -- File Changes -- M src/modules/keepalive/keepalive_mod.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2372.patch https://github.com/kamailio/kamailio/pull/2372.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2372

2 2

[kamailio/kamailio] MOHQUEUE: Crash on procesing ACK (#2370)
by Alexander Butenko 24 Jun '20

24 Jun '20

### Description Kamailio is crashing every 2-3 calls with this sample config. I dont mind paying for a paid support. Please help :) Ive used asterisk server to generate calls like ``` for i in `seq 1 4`;do asterisk -rx'originate Local/1@test application MusicOnHold';done extensions.conf: [test] exten => 1,1,Set(CALLERID(all)=12345) same=n,Dial(SIP/q_1_Test_Queue@1.1.1.1:5060) request_route { # MOH queue? if ($rU=~"c_" || $rU=~"q_") { if (mohq_process ()) { if (is_method("INVITE")) { route(ACCSTART); xlog("L_INFO", "QUEUE JOIN: $ci $rm from $fu to $rU/$ruri (IP:$si:$sp)\n"); } exit; } } } route[ACCPREPARE] { $var(callid) = "$ci"; $var(referCallid) = ""; $var(did) = "$rU"; $var(clid) = "$fU"; } route[ACCSTART] { route(ACCPREPARE); xlog("L_INFO", "ACC START: did $var(did) didid $var(didid) action $var(action)-$var(value) valueid $var(valueid) trunk $si:$sp\n refered-by $(hdr(Referred-By))"); } ``` ### Troubleshooting ``` Jun 23 22:33:38 dialer-gw-qa kamailio: INFO: <script>: ACC START: did $rU didid 0 action 0-0 valueid 0 trunk 45.55.203.176:5060#012 refered-by <null> Jun 23 22:33:38 dialer-gw-qa kamailio: INFO: <script>: QUEUE JOIN: 42c9d48d39329106158a600b6c4b059e@xxxx:5060 INVITE from sip:12345@xxxxx to q_1_Test_Queue/sip:q_1_Test_Queue@xxxxx:5060 Program received signal SIGSEGV, Segmentation fault. 0x00007ffff6825ad5 in t_check_msg (p_msg=0x7ffff76941a0, param_branch=0x0) at t_lookup.c:1086 1086 t_lookup.c: No such file or directory. (gdb) (gdb) (gdb) bt #0 0x00007ffff6825ad5 in t_check_msg (p_msg=0x7ffff76941a0, param_branch=0x0) at t_lookup.c:1086 #1 0x00007ffff6826997 in t_check (p_msg=0x7ffff76941a0, param_branch=0x0) at t_lookup.c:1137 #2 0x00007ffff68d1b94 in t_release (msg=0x7ffff76941a0) at tm.c:1528 #3 0x00007ffff68d1c0b in w_t_release (msg=0x7ffff76941a0, str=0x2 <error: Cannot access memory at address 0x2>, str2=0x7ffff76941a0 "\b") at tm.c:1540 #4 0x00007ffff64ce57f in ack_msg (pmsg=0x7ffff7695d38, pcall=0x7ffff2301050) at mohq_funcs.c:218 #5 0x00007ffff64e9431 in mohq_process (pmsg=0x7ffff7695d38) at mohq_funcs.c:2733 #6 0x0000555555731e23 in do_action (h=0x7fffffffcc90, a=0x7ffff76703b0, msg=0x7ffff7695d38) at core/action.c:1071 #7 0x000055555573fe86 in run_actions (h=0x7fffffffcc90, a=0x7ffff76703b0, msg=0x7ffff7695d38) at core/action.c:1576 #8 0x000055555574058c in run_actions_safe (h=0x7fffffffde80, a=0x7ffff76703b0, msg=0x7ffff7695d38) at core/action.c:1640 #9 0x0000555555593f30 in rval_get_int (h=0x7fffffffde80, msg=0x7ffff7695d38, i=0x7fffffffd000, rv=0x7ffff7670508, cache=0x0) at core/rvalue.c:915 #10 0x0000555555598a80 in rval_expr_eval_int (h=0x7fffffffde80, msg=0x7ffff7695d38, res=0x7fffffffd000, rve=0x7ffff7670500) at core/rvalue.c:1913 #11 0x0000555555731890 in do_action (h=0x7fffffffde80, a=0x7ffff7671ff8, msg=0x7ffff7695d38) at core/action.c:1047 #12 0x000055555573fe86 in run_actions (h=0x7fffffffde80, a=0x7ffff7671ff8, msg=0x7ffff7695d38) at core/action.c:1576 #13 0x0000555555731d8f in do_action (h=0x7fffffffde80, a=0x7ffff7672148, msg=0x7ffff7695d38) at core/action.c:1062 #14 0x000055555573fe86 in run_actions (h=0x7fffffffde80, a=0x7ffff7672148, msg=0x7ffff7695d38) at core/action.c:1576 #15 0x0000555555740698 in run_top_route (a=0x7ffff7672148, msg=0x7ffff7695d38, c=0x0) at core/action.c:1661 #16 0x0000555555747718 in receive_msg ( buf=0x555555a31820 <buf> "ACK sip:q_1_Test_Queue@xxxx:5060 SIP/2.0\r\nVia: SIP/2.0/UDP xxxx:5060;branch=z9hG4bK1415e654\r\nMax-Forwards: 70\r\nFrom: <sip:12345@xxx>;tag=as2aeac8b5\r\nTo: <sip:q_1_Test_Queu"..., len=429, rcv_info=0x7fffffffe270) at core/receive.c:423 #17 0x0000555555613318 in udp_rcv_loop () at core/udp_server.c:554 #18 0x00005555555857a5 in main_loop () at main.c:1471 #19 0x000055555559043b in main (argc=2, argv=0x7fffffffebb8) at main.c:2802 (gdb) ``` #### SIP Traffic there is nothing special in the SIP dialog. everything looks correct. ### Possible Solutions no solution yet. ### Additional Information ```` Happens with all versions of kamailio 5.2.1,5.3.1-5.3.5 version: kamailio 5.3.5 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` * **Operating System**: debian 10 latest updates ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2370

2 1

git:master:6e3a8aea: Merge pull request #2372 from danielmartinezruiz/keepalive_config_ka_ping_from_value_cut_off
by GitHub 24 Jun '20

24 Jun '20

Module: kamailio Branch: master Commit: 6e3a8aea7f9f6dde462c86dfd8cd3027c2751e98 URL: https://github.com/kamailio/kamailio/commit/6e3a8aea7f9f6dde462c86dfd8cd302… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2020-06-24T21:00:11+02:00 Merge pull request #2372 from danielmartinezruiz/keepalive_config_ka_ping_from_value_cut_off keepalive: manage the `ping_from` config value as str. --- Modified: src/modules/keepalive/keepalive_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/6e3a8aea7f9f6dde462c86dfd8cd302… Patch: https://github.com/kamailio/kamailio/commit/6e3a8aea7f9f6dde462c86dfd8cd302… --- diff --git a/src/modules/keepalive/keepalive_mod.c b/src/modules/keepalive/keepalive_mod.c index e1da2e9db2..bcf021d461 100644 --- a/src/modules/keepalive/keepalive_mod.c +++ b/src/modules/keepalive/keepalive_mod.c @@ -83,8 +83,8 @@ static param_export_t params[] = { {"ping_interval", PARAM_INT, &ka_ping_interval}, {"destination", PARAM_STRING | USE_FUNC_PARAM, (void *)ka_mod_add_destination}, - {"ping_from", PARAM_STRING, &ka_ping_from}, - {"delete_counter", PARAM_INT, &ka_counter_del}, + {"ping_from", PARAM_STR, &ka_ping_from}, + {"delete_counter", PARAM_INT, &ka_counter_del}, {0, 0, 0} };

1 0

git:master:1b4afb70: keepalive: manage the `ping_from` config value as str.
by Daniel MartÃnez Ruiz 24 Jun '20

24 Jun '20

Module: kamailio Branch: master Commit: 1b4afb70c1c8228bc4dbae6e7ab433c4187b9867 URL: https://github.com/kamailio/kamailio/commit/1b4afb70c1c8228bc4dbae6e7ab433c… Author: Daniel MartÃnez Ruiz <d.martinez(a)zaleos.net> Committer: Daniel MartÃnez Ruiz <d.martinez(a)zaleos.net> Date: 2020-06-24T10:38:36+02:00 keepalive: manage the `ping_from` config value as str. Managing the config value as a string (`char*`) doesn't change the string size, so the value is cut off to the default value size (26 chars). --- Modified: src/modules/keepalive/keepalive_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1b4afb70c1c8228bc4dbae6e7ab433c… Patch: https://github.com/kamailio/kamailio/commit/1b4afb70c1c8228bc4dbae6e7ab433c… --- diff --git a/src/modules/keepalive/keepalive_mod.c b/src/modules/keepalive/keepalive_mod.c index e1da2e9db2..bcf021d461 100644 --- a/src/modules/keepalive/keepalive_mod.c +++ b/src/modules/keepalive/keepalive_mod.c @@ -83,8 +83,8 @@ static param_export_t params[] = { {"ping_interval", PARAM_INT, &ka_ping_interval}, {"destination", PARAM_STRING | USE_FUNC_PARAM, (void *)ka_mod_add_destination}, - {"ping_from", PARAM_STRING, &ka_ping_from}, - {"delete_counter", PARAM_INT, &ka_counter_del}, + {"ping_from", PARAM_STR, &ka_ping_from}, + {"delete_counter", PARAM_INT, &ka_counter_del}, {0, 0, 0} };

1 0

[kamailio/kamailio] mohqueue: use t_newtran() if transaction does not exist (#2373)
by Emmanuel Schmidbauer 24 Jun '20

24 Jun '20

#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #2370 #### Description make sure transaction exists with `t_newtran()` and use `t_release_transaction()` instead of `t_release()` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2373 -- Commit Summary -- * mohqueue: use t_newtran() if transaction does not exist -- File Changes -- M src/modules/mohqueue/mohq_funcs.c (20) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2373.patch https://github.com/kamailio/kamailio/pull/2373.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2373

2 3

git:master:6b708e93: mohqueue: use t_newtran() if transaction does not exist
by Emmanuel Schmidbauer 24 Jun '20

24 Jun '20

Module: kamailio Branch: master Commit: 6b708e937d161101adc91a4de5a527bf190b55c0 URL: https://github.com/kamailio/kamailio/commit/6b708e937d161101adc91a4de5a527b… Author: Emmanuel Schmidbauer <eschmidbauer(a)gmail.com> Committer: Emmanuel Schmidbauer <eschmidbauer(a)gmail.com> Date: 2020-06-24T14:32:15-04:00 mohqueue: use t_newtran() if transaction does not exist --- Modified: src/modules/mohqueue/mohq_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/6b708e937d161101adc91a4de5a527b… Patch: https://github.com/kamailio/kamailio/commit/6b708e937d161101adc91a4de5a527b… --- diff --git a/src/modules/mohqueue/mohq_funcs.c b/src/modules/mohqueue/mohq_funcs.c index 384be185d3..54ee87486c 100644 --- a/src/modules/mohqueue/mohq_funcs.c +++ b/src/modules/mohqueue/mohq_funcs.c @@ -185,6 +185,7 @@ void ack_msg (sip_msg_t *pmsg, call_lst *pcall) char *pfncname = "ack_msg: "; struct cell *ptrans; tm_api_t *ptm = pmod_data->ptm; +tm_cell_t *t = 0; if (pcall->call_state != CLSTA_INVITED) { /********** @@ -215,7 +216,22 @@ if (ptm->t_lookup_ident (&ptrans, pcall->call_hash, pcall->call_label) < 0) } else { - if (ptm->t_release (pcall->call_pmsg) < 0) + t = ptm->t_gett(); + if (t==NULL || t==T_UNDEFINED) + { + if (ptm->t_newtran(pmsg)<0) + { + LM_ERR("cannot create the transaction\n"); + return; + } + t = ptm->t_gett(); + if (t==NULL || t==T_UNDEFINED) + { + LM_ERR("cannot lookup the transaction\n"); + return; + } + } + if (ptm->t_release_transaction(t) < 0) { LM_ERR ("%sRelease transaction failed for call (%s)!\n", pfncname, pcall->call_from); @@ -2945,4 +2961,4 @@ if (pmod_data->ptm->t_relay (pmsg, 0, 0) < 0) return -1; } return 1; -} \ No newline at end of file +}

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev