sr-dev

sr-dev@lists.kamailio.org

22 participants
45186 discussions

[kamailio/kamailio] core: PV_IDX_NONE to point that pv had no index (#2341)
by Victor Seva 05 Jun '20

05 Jun '20

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally #### Description  if index is 0 there were no way to know if the index was there $x_hdr(A) = "value" needs to append a value $(x_hdr(A)[0]) = "value" needs to set the value pv_parse_spec(str *s, pv_spec_p p) was always setting p->pvp.pvi.type to 0 == PV_IDX_INT You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2341 -- Commit Summary -- * core: PV_IDX_NONE to point that pv had no index -- File Changes -- M src/core/pvapi.c (7) M src/core/pvar.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2341.patch https://github.com/kamailio/kamailio/pull/2341.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2341

2 6

git:master:6e96e8a9: pv: fix for new PV_IDX_NONE value
by Victor Seva 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: 6e96e8a9134ed204f4fcf3cd42f6f9f274ea7851 URL: https://github.com/kamailio/kamailio/commit/6e96e8a9134ed204f4fcf3cd42f6f9f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-06-05T08:54:17+02:00 pv: fix for new PV_IDX_NONE value --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/6e96e8a9134ed204f4fcf3cd42f6f9f… Patch: https://github.com/kamailio/kamailio/commit/6e96e8a9134ed204f4fcf3cd42f6f9f… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index e53db70c25..ae91aa9d82 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -1823,7 +1823,7 @@ int pv_get_avp(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) if ((avp=search_first_avp(name_type, avp_name, &avp_value, &state))==0) return pv_get_null(msg, param, res); res->flags = PV_VAL_STR; - if(idxf==0 && idx==0) + if(idx==0 && (idxf==PV_IDX_INT || idxf==PV_IDX_NONE)) { if(avp->flags & AVP_VAL_STR) { @@ -1981,7 +1981,7 @@ int pv_get_hdr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) /* get the value */ res->flags = PV_VAL_STR; - if(idxf==0 && idx==0) + if(idx==0 && (idxf==PV_IDX_INT || idxf==PV_IDX_NONE)) { res->rs = hf->body; return 0;

1 0

git:master:7bb26695: core: PV_IDX_NONE to point that pv had no index
by Victor Seva 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: 7bb2669528a819ec29a8193eebc9c641edd69993 URL: https://github.com/kamailio/kamailio/commit/7bb2669528a819ec29a8193eebc9c64… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-06-05T08:54:17+02:00 core: PV_IDX_NONE to point that pv had no index if index is 0 there were no way to know if the index was there $x_hdr(A) = "value" needs to append a value $(x_hdr(A)[0]) = "value" needs to set the value pv_parse_spec(str *s, pv_spec_p p) was always setting p->pvp.pvi.type to 0 == PV_IDX_INT --- Modified: src/core/pvapi.c Modified: src/core/pvar.h --- Diff: https://github.com/kamailio/kamailio/commit/7bb2669528a819ec29a8193eebc9c64… Patch: https://github.com/kamailio/kamailio/commit/7bb2669528a819ec29a8193eebc9c64… --- diff --git a/src/core/pvapi.c b/src/core/pvapi.c index 0148578315..30b2a7cdfe 100644 --- a/src/core/pvapi.c +++ b/src/core/pvapi.c @@ -857,6 +857,7 @@ char* pv_parse_spec2(str *in, pv_spec_p e, int silent) tr = 0; pvstate = 0; memset(e, 0, sizeof(pv_spec_t)); + e->pvp.pvi.type = PV_IDX_NONE; p = in->s; p++; if(*p==PV_LNBRACKET) @@ -1369,6 +1370,12 @@ int pv_get_spec_index(struct sip_msg* msg, pv_param_p ip, int *idx, int *flags) *idx = ip->pvi.u.ival; return 0; } + if(ip->pvi.type == PV_IDX_NONE) + { + *flags = PV_IDX_NONE; + *idx = ip->pvi.u.ival; + return 0; + } /* pvar */ if(pv_get_spec_value(msg, (pv_spec_p)ip->pvi.u.dval, &tv)!=0) diff --git a/src/core/pvar.h b/src/core/pvar.h index 1415f84af0..155b0125fb 100644 --- a/src/core/pvar.h +++ b/src/core/pvar.h @@ -61,6 +61,7 @@ #define PV_IDX_PVAR 1 #define PV_IDX_ALL 2 #define PV_IDX_ITR 3 +#define PV_IDX_NONE 4 /*! if PV name is dynamic, integer, or str */ #define pv_has_dname(pv) ((pv)->pvp.pvn.type==PV_NAME_PVAR)

1 0

git:master:dd28ea04: app_jsdt: duktape interpreter upgraded to v2.5.0
by Daniel-Constantin Mierla 04 Jun '20

04 Jun '20

Module: kamailio Branch: master Commit: dd28ea040b78bf972a9b54177a8025eb8e885683 URL: https://github.com/kamailio/kamailio/commit/dd28ea040b78bf972a9b54177a8025e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-04T19:26:09+02:00 app_jsdt: duktape interpreter upgraded to v2.5.0 --- Modified: src/modules/app_jsdt/duk_config.h Modified: src/modules/app_jsdt/duktape.c Modified: src/modules/app_jsdt/duktape.h --- Diff: https://github.com/kamailio/kamailio/commit/dd28ea040b78bf972a9b54177a8025e… Patch: https://github.com/kamailio/kamailio/commit/dd28ea040b78bf972a9b54177a8025e…

1 0

git:master:2b3c4130: corex: exported file read/write functions to kemi
by Daniel-Constantin Mierla 04 Jun '20

04 Jun '20

Module: kamailio Branch: master Commit: 2b3c4130e717f1b92eeb351e3bfe72e189138136 URL: https://github.com/kamailio/kamailio/commit/2b3c4130e717f1b92eeb351e3bfe72e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-04T19:15:22+02:00 corex: exported file read/write functions to kemi --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/2b3c4130e717f1b92eeb351e3bfe72e… Patch: https://github.com/kamailio/kamailio/commit/2b3c4130e717f1b92eeb351e3bfe72e…

1 0

git:master:d581418b: crypto: check if netio crypto key is set if callbacks are enabled
by Daniel-Constantin Mierla 04 Jun '20

04 Jun '20

Module: kamailio Branch: master Commit: d581418bcc49ad30bd35910f988ac78c8d9047e0 URL: https://github.com/kamailio/kamailio/commit/d581418bcc49ad30bd35910f988ac78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-04T18:32:14+02:00 crypto: check if netio crypto key is set if callbacks are enabled --- Modified: src/modules/crypto/crypto_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/d581418bcc49ad30bd35910f988ac78… Patch: https://github.com/kamailio/kamailio/commit/d581418bcc49ad30bd35910f988ac78… --- diff --git a/src/modules/crypto/crypto_mod.c b/src/modules/crypto/crypto_mod.c index c2f7fe61e4..720042792b 100644 --- a/src/modules/crypto/crypto_mod.c +++ b/src/modules/crypto/crypto_mod.c @@ -137,6 +137,10 @@ static int mod_init(void) } if(_crypto_register_evcb!=0) { + if(_crypto_netio_key.s==NULL || _crypto_netio_key.len<=0) { + LM_ERR("crypto netio key parameter is not set\n"); + return -1; + } crypto_evcb_enable(); }

1 0

missing SAR messages
by Georgi Rosenov Stefanov 04 Jun '20

04 Jun '20

Hi Henning, At first I want to thanks you for reading my post :) Actually I tried to use DEBUG logs, but nothing ..... So I put an "abort()" :) into cxdx_send_sar, so I am able to track one successful test case. Here is the backtrace: #2 0x00007fcb469c12f7 in cxdx_send_sar (msg=0x7fcb4d66a968, public_identity=..., private_identity=..., server_name=..., assignment_type=1, data_available=0, transaction_data=0x7fcb3e455610) at cxdx_sar.c:328 #3 0x00007fcb469c3815 in scscf_assign_server (msg=0x7fcb4d66a968, public_identity=..., private_identity=..., assignment_type=1, data_available=0, transaction_data=0x7fcb3e455610) at server_assignment.c:88 #4 0x00007fcb469ba42f in save (msg=0x7fcb4d66a968, str1=0x7fcb3e423158 "X0B>\313\177", route=0x7fcb4d6656e0 " 3]M\313\177") at save.c:1438 #5 0x00007fcb469cce2a in w_save (_m=0x7fcb4d66a968, _route=0x7fcb4d6656e0 " 3]M\313\177", _d=0x7fcb3e423158 "X0B>\313\177", mode=0x7fcb4d66a968 "\001", _cflags=0x0) at ims_registrar_scscf_mod.c:623 #6 0x000000000047c5c9 in do_action (h=0x7ffd2e6d7e50, a=0x7fcb4d5d2f80, msg=0x7fcb4d66a968) at core/action.c:1085 #7 0x000000000048907a in run_actions (h=0x7ffd2e6d7e50, a=0x7fcb4d5d2be8, msg=0x7fcb4d66a968) at core/action.c:1578 #8 0x000000000047c422 in do_action (h=0x7ffd2e6d7e50, a=0x7fcb4d5d4010, msg=0x7fcb4d66a968) at core/action.c:1064 #9 0x000000000048907a in run_actions (h=0x7ffd2e6d7e50, a=0x7fcb4d5d4010, msg=0x7fcb4d66a968) at core/action.c:1578 #10 0x000000000047c470 in do_action (h=0x7ffd2e6d7e50, a=0x7fcb4d5d4160, msg=0x7fcb4d66a968) at core/action.c:1068 #11 0x000000000048907a in run_actions (h=0x7ffd2e6d7e50, a=0x7fcb4d5c4d00, msg=0x7fcb4d66a968) at core/action.c:1578 #12 0x0000000000478ed9 in do_action (h=0x7ffd2e6d7e50, a=0x7fcb4d573058, msg=0x7fcb4d66a968) at core/action.c:697 #13 0x000000000048907a in run_actions (h=0x7ffd2e6d7e50, a=0x7fcb4d573058, msg=0x7fcb4d66a968) at core/action.c:1578 #14 0x000000000047c422 in do_action (h=0x7ffd2e6d7e50, a=0x7fcb4d5732f8, msg=0x7fcb4d66a968) at core/action.c:1064 #15 0x000000000048907a in run_actions (h=0x7ffd2e6d7e50, a=0x7fcb4d571ea0, msg=0x7fcb4d66a968) at core/action.c:1578 #16 0x0000000000489803 in run_top_route (a=0x7fcb4d571ea0, msg=0x7fcb4d66a968, c=0x0) at core/action.c:1663 #17 0x00000000005b510e in receive_msg ( buf=0xa95500 <buf.6971> "REGISTER sip: scscf.mnc001.mcc001.3gppnetwork.org:6060 SIP/2.0\r\nVia: SIP/2.0/UDP 10.82.10.145:4060;branch=z9hG4bKe025.079fd766789513e3068d0dce7e1853f3.0\r\nVia: SIP/2.0/UDP 10.82.10.145;branch=z9hG4bKe02"..., len=1085, rcv_info=0x7ffd2e6d8490) at core/receive.c:424 #18 0x00000000004bc624 in udp_rcv_loop () at core/udp_server.c:548 So w_save is called from pcscf_save("location") from /usr/local/etc/kamailio/pcscf/route/register.cfg and save("PRE_REG_SAR_REPLY","location") or save("REG_SAR_REPLY","location"); from /usr/local/etc/kamailio/scscf/kamailio.cfg So I put err log messages(err to be clearly visible ) and then using "journal | grep "my string" -c I count how many times the SAR is triggered Then I count how many SAR messages a sent and the numbers mismatch

2 1

[kamailio/kamailio] cnxcc: when credit reach the limit non confirmed calls of the same customer fail to terminate (#2346)
by Victor Seva 04 Jun '20

04 Jun '20

### Description when credit reach the limit non confirmed calls of the same customer fail to terminate #### Reproduction Sending a call of the same customer while there's another call of the same customer consuming all the quota assigned to it. #### Log Messages first call ``[450708880-22683-45(a)BAA.BAE.BJF.BDF]`` established: ``` Jun 3 12:05:39 kamailio[21658]: DEBUG: cnxcc [cnxcc_mod.c:446]: __dialog_created_callback(): Flag is not set for this message. Ignoring Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:1583]: ki_set_max_credit(): Setting up new call for client [zs_00000], max-credit[1.000000], connect-cost[0.000000], cost-per-sec[0.100000], initial-pulse [1], final-pulse [1], call-id[450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:1521]: set_ctrl_flag(): Flag set! Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:1183]: __get_or_create_credit_data_entry(): Credit entry didn't exist. Allocated new entry [0x7f508161ed40] Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:1312]: __alloc_new_call_by_money(): New call allocated for client [zs_00000] Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:450]: __dialog_created_callback(): Dialog created for CID [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:758]: __setup_billing(): Creating dialog for [450708880-22683-45(a)BAA.BAE.BJF.BDF], h_id [4406], h_entry [1215] Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:797]: __setup_billing(): Call [450708880-22683-45(a)BAA.BAE.BJF.BDF] from client [zs_00000], created Jun 3 12:05:48 kamailio[21657]: DEBUG: cnxcc [cnxcc_mod.c:464]: __dialog_confirmed_callback(): Dialog confirmed for CID [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:48 kamailio[21657]: DEBUG: cnxcc [cnxcc_mod.c:811]: __start_billing(): Billing started for call [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:48 kamailio[21657]: DEBUG: cnxcc [cnxcc_mod.c:927]: __start_billing(): Call [450708880-22683-45(a)BAA.BAE.BJF.BDF] from client [zs_00000], confirmed. from=<sip:zs_pruebas201@pepelux.zoonsuite.com>;tag=1931637637, to=<sip:anonymous@pepelux.zoonsuite.com>;tag=as7138b4b8 Jun 3 12:05:48 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [0], consumed credit [0.100000] Jun 3 12:05:48 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.100000/1.000000 Jun 3 12:05:49 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [1], consumed credit [0.100000] Jun 3 12:05:49 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.100000/1.000000 Jun 3 12:05:50 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [2], consumed credit [0.300000] Jun 3 12:05:50 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.300000/1.000000 ``` Second call ``[d85f4ff9c923c9ea]``, first one is alive and consuming: ``` Jun 3 12:05:50 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:446]: __dialog_created_callback(): Flag is not set for this message. Ignoring Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:1583]: ki_set_max_credit(): Setting up new call for client [zs_00000], max-credit[1.000000], connect-cost[0.000000], cost-per-sec[0.100000], initial-pulse [1], final-pulse [1], call-id[d85f4ff9c923c9ea] Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:1521]: set_ctrl_flag(): Flag set! Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:1164]: __get_or_create_credit_data_entry(): Found key zs_00000 in hash table Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:1312]: __alloc_new_call_by_money(): New call allocated for client [zs_00000] Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:450]: __dialog_created_callback(): Dialog created for CID [d85f4ff9c923c9ea] Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:758]: __setup_billing(): Creating dialog for [d85f4ff9c923c9ea], h_id [1000], h_entry [1526] Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:797]: __setup_billing(): Call [d85f4ff9c923c9ea] from client [zs_00000], created ``` first call ``[450708880-22683-45(a)BAA.BAE.BJF.BDF]`` will consume all the customer credit and trigger ``terminate_all_calls`` : ``` Jun 3 12:05:51 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [3], consumed credit [0.400000] Jun 3 12:05:51 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.400000/1.000000 Jun 3 12:05:52 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [4], consumed credit [0.500000] Jun 3 12:05:52 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.500000/1.000000 Jun 3 12:05:53 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [5], consumed credit [0.600000] Jun 3 12:05:53 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.600000/1.000000 Jun 3 12:05:54 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [6], consumed credit [0.700000] Jun 3 12:05:54 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.700000/1.000000 Jun 3 12:05:55 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [7], consumed credit [0.800000] Jun 3 12:05:55 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.800000/1.000000 Jun 3 12:05:56 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [8], consumed credit [0.900000] Jun 3 12:05:56 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.900000/1.000000 Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [9], consumed credit [1.000000] Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 1.000000/1.000000 Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:974]: terminate_all_calls(): Killing call with CID [d85f4ff9c923c9ea] ``` second ``[d85f4ff9c923c9ea]`` non-confirmed call doesn't have call->from_uri, call->from_tag, call->to_uri, call->to_tag so...: ``` Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:1095]: terminate_call(): Got kill signal for call [d85f4ff9c923c9ea] client [zs_00000] h_id [1000] h_entry [1526]. Dropping it now Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_sip_msg_faker.c:48]: cnxcc_faked_msg_init_with_dlg_info(): fake msg:#012OPTIONS sip:you@kamailio.org SIP/2.0#015#012Via: SIP/2.0/UDP 127.0.0.1#015#012From: <>;tag=#015#012To: <>;tag=#015#012Call-ID: d85f4ff9c923c9ea#015#012CSeq: 1 OPTIONS#015#012Content-Length: 0 Jun 3 12:05:57 kamailio[21673]: ERROR: <core> [core/parser/parse_addr_spec.c:739]: parse_addr_spec(): unexpected char [>] in status 5: [<] . Jun 3 12:05:57 kamailio[21673]: ERROR: <core> [core/parser/msg_parser.c:164]: get_hdr_field(): bad to header Jun 3 12:05:57 kamailio[21673]: ERROR: <core> [core/parser/msg_parser.c:337]: parse_headers(): bad header field [To: <>;tag=#015#012Call-ID: d85f4ff9c923c9ea#015#012CSeq: 1 OPTIONS#015#012Content-Length: 0#015#012#015#012] Jun 3 12:05:57 kamailio[21673]: ERROR: dialog [dlg_handlers.c:709]: pre_match_parse(): bad request or missing CALLID/TO hdr :-/ Jun 3 12:05:57 kamailio[21673]: ERROR: cnxcc [cnxcc_mod.c:1112]: terminate_call(): [d85f4ff9c923c9ea]: cannot get dialog Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:1029]: __free_call(): Freeing call [d85f4ff9c923c9ea] ``` but the call ``[d85f4ff9c923c9ea]`` is been freed. The first call ``[450708880-22683-45(a)BAA.BAE.BJF.BDF]`` is been terminated properly and freed ``` Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:974]: terminate_all_calls(): Killing call with CID [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:1095]: terminate_call(): Got kill signal for call [450708880-22683-45(a)BAA.BAE.BJF.BDF] client [zs_00000] h_id [4406] h_entry [1215]. Dropping it now Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_sip_msg_faker.c:48]: cnxcc_faked_msg_init_with_dlg_info(): fake msg:#012OPTIONS sip:you@kamailio.org SIP/2.0#015#012Via: SIP/2.0/UDP 127.0.0.1#015#012From: <sip:zs_pruebas201@pepelux.zoonsuite.com>;tag=1931637637#015#012To: <sip:anonymous@pepelux.zoonsuite.com>;tag=as7138b4b8#015#012Call-ID: 450708880-22683-45(a)BAA.BAE.BJF.BDF#015#012CSeq: 1 OPTIONS#015#012Content-Length: 0 Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:473]: __dialog_terminated_callback(): Dialog terminated for CID [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:656]: __stop_billing(): Call [450708880-22683-45(a)BAA.BAE.BJF.BDF] of client-ID [zs_00000], ended Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:1117]: terminate_call(): dlg_end_dlg sent to call [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:57 kamailio[21673]: INFO: <script>: [450708880-22683-45(a)BAA.BAE.BJF.BDF]: call killed zs_pruebas201->anonymous ... No credit available Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:1029]: __free_call(): Freeing call [450708880-22683-45(a)BAA.BAE.BJF.BDF] ``` second call ``[d85f4ff9c923c9ea]`` is confirmed but call info was already freed ``` Jun 3 12:06:03 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:464]: __dialog_confirmed_callback(): Dialog confirmed for CID [d85f4ff9c923c9ea] Jun 3 12:06:03 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:811]: __start_billing(): Billing started for call [d85f4ff9c923c9ea] Jun 3 12:06:03 kamailio[21660]: ERROR: cnxcc [cnxcc_mod.c:819]: __start_billing(): Call [d85f4ff9c923c9ea] not found ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` kamailio master with #2343 applied -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2346

1 1

[kamailio/kamailio] cnxcc: don't terminate non confirmed calls (#2347)
by Victor Seva 04 Jun '20

04 Jun '20

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2346 #### Description * non confirmed calls can't be terminated via dialog.terminate_dlg() API * set call.max_amount to 0 to terminate the call if gets confirmed You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2347 -- Commit Summary -- * cnxcc: don't terminate non confirmed calls -- File Changes -- M src/modules/cnxcc/cnxcc_mod.c (249) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2347.patch https://github.com/kamailio/kamailio/pull/2347.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2347

1 1

git:master:ca0fc18e: cnxcc: don't terminate non confirmed calls
by Victor Seva 04 Jun '20

04 Jun '20

Module: kamailio Branch: master Commit: ca0fc18e1cfad86ed6b7530d6c520b680e5d6a4f URL: https://github.com/kamailio/kamailio/commit/ca0fc18e1cfad86ed6b7530d6c520b6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-06-04T11:12:13+02:00 cnxcc: don't terminate non confirmed calls * non confirmed calls can't be terminated via dialog.terminate_dlg() API * set call.max_amount to 0 to terminate the call if gets confirmed fix #2346 --- Modified: src/modules/cnxcc/cnxcc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ca0fc18e1cfad86ed6b7530d6c520b6… Patch: https://github.com/kamailio/kamailio/commit/ca0fc18e1cfad86ed6b7530d6c520b6…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev