sr-dev

sr-dev@lists.kamailio.org

16 participants
45365 discussions

git:master:0e0ab855: dispatcher: docs for algprithm 14 (round-robin or serial)
by Daniel-Constantin Mierla 03 Jul '25

03 Jul '25

Module: kamailio Branch: master Commit: 0e0ab85583241533e21bbea317a1fb9dbf8a8f72 URL: https://github.com/kamailio/kamailio/commit/0e0ab85583241533e21bbea317a1fb9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-03T08:20:48+02:00 dispatcher: docs for algprithm 14 (round-robin or serial) --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/0e0ab85583241533e21bbea317a1fb9… Patch: https://github.com/kamailio/kamailio/commit/0e0ab85583241533e21bbea317a1fb9… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index 126ad986724..1f897f8335b 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -1466,6 +1466,13 @@ With congestion control the formula becomes : load control rate). </para> </listitem> + <listitem> + <para> + <quote>14</quote> - round-robin (4) if all the destinations + in the group have the same priority and the priority is greater + than 0, otherise serial dispatching (8). + </para> + </listitem> <listitem> <para> <quote>X</quote> - if the algorithm is not implemented, the

1 0

git:master:883f9cd0: dispatcher: new dispatching algorithm 14
by Daniel-Constantin Mierla 03 Jul '25

03 Jul '25

Module: kamailio Branch: master Commit: 883f9cd0bf5a16dbc94556dfb84b806bbc2cba7e URL: https://github.com/kamailio/kamailio/commit/883f9cd0bf5a16dbc94556dfb84b806… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-03T08:05:56+02:00 dispatcher: new dispatching algorithm 14 - serial or round-robin if the priority is the same for all destinations in the group and it is greater than 0 --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatch.h --- Diff: https://github.com/kamailio/kamailio/commit/883f9cd0bf5a16dbc94556dfb84b806… Patch: https://github.com/kamailio/kamailio/commit/883f9cd0bf5a16dbc94556dfb84b806… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 4a5c2d90cf8..50865a0d1f6 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -82,6 +82,7 @@ #define DS_ALG_RELWEIGHT 11 #define DS_ALG_PARALLEL 12 #define DS_ALG_LATENCY 13 +#define DS_ALG_RRSERIAL 14 #define DS_ALG_OVERLOAD 64 /* 2^6 - can be also used as a flag */ #define DS_HN_SIZE 256 @@ -778,7 +779,13 @@ ds_dest_t *add_dest2list(int id, str uri, int flags, int priority, str *attrs, if(sp->dlist == NULL) { sp->dlist = dp; + if(priority > 0) { + sp->rrserial = priority; + } } else { + if(sp->rrserial > 0 && sp->rrserial != priority) { + sp->rrserial = 0; + } dp1 = NULL; dp0 = sp->dlist; /* highest priority last -> reindex will copy backwards */ @@ -2563,6 +2570,7 @@ int ds_manage_routes(sip_msg_t *msg, ds_select_state_t *rstate) ds_set_t *idx = NULL; int ulast = 0; int vlast = 0; + int valg = 0; int xavp_filled = 0; if(msg == NULL) { @@ -2589,10 +2597,20 @@ int ds_manage_routes(sip_msg_t *msg, ds_select_state_t *rstate) return -1; } + if(rstate->alg == DS_ALG_RRSERIAL) { + /* decide on round-robin or serial dispatching */ + if(idx->rrserial != 0) { + valg = DS_ALG_ROUNDROBIN; + } else { + valg = DS_ALG_SERIAL; + } + } else { + valg = rstate->alg; + } LM_DBG("set [%d]\n", rstate->setid); hash = 0; - switch(rstate->alg) { + switch(valg) { case DS_ALG_HASHCALLID: /* 0 - hash call-id */ if(ds_hash_callid(msg, &hash) != 0) { LM_ERR("can't get callid hash\n"); @@ -2707,6 +2725,7 @@ int ds_manage_routes(sip_msg_t *msg, ds_select_state_t *rstate) return -1; xavp_filled = 1; break; + /* case DS_ALG_RRSERIAL: // 14 - round-robin or serial decided above */ case DS_ALG_OVERLOAD: /* 64 - round robin with overload control */ lock_get(&idx->lock); hash = idx->last; diff --git a/src/modules/dispatcher/dispatch.h b/src/modules/dispatcher/dispatch.h index ffaab7cb7e8..d48b6347d45 100644 --- a/src/modules/dispatcher/dispatch.h +++ b/src/modules/dispatcher/dispatch.h @@ -270,6 +270,7 @@ typedef struct _ds_set { unsigned int rwlist[100]; struct _ds_set *next[2]; int longer; + int rrserial; /*!< round-robin or serial flag */ gen_lock_t lock; } ds_set_t;

1 0

[kamailio/kamailio] rtpengine: timer ping nodes outside locks (PR #4305)
by Stefan Mititelu 02 Jul '25

02 Jul '25

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Move pinging of rtpengines outside locks, by making a pkg copy of the list. Update shm list afterwards, under locks. Basically tested by doing "kamcmd rtpengine.reload" while the timer was pinging the rtpengines. More testing will come. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4305 -- Commit Summary -- * rtpengine: timer ping nodes outside locks -- File Changes -- M src/modules/rtpengine/rtpengine.c (121) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4305.patch https://github.com/kamailio/kamailio/pull/4305.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4305 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4305(a)github.com>

1 1

git:master:a83bd94d: etc/kamailio.cfg: updated comment when blocking 401/407 from downstream
by Daniel-Constantin Mierla 02 Jul '25

02 Jul '25

Module: kamailio Branch: master Commit: a83bd94d8304bc961b468ba5f1e073ef73b9233c URL: https://github.com/kamailio/kamailio/commit/a83bd94d8304bc961b468ba5f1e073e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-02T11:43:19+02:00 etc/kamailio.cfg: updated comment when blocking 401/407 from downstream --- Modified: etc/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/a83bd94d8304bc961b468ba5f1e073e… Patch: https://github.com/kamailio/kamailio/commit/a83bd94d8304bc961b468ba5f1e073e… --- diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index 43c16b796b2..c8ea4f209d1 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -1092,7 +1092,7 @@ failure_route[MANAGE_FAILURE] { #!endif #!ifdef WITH_BLOCK401407 - # block call redirect based on 401, 407 replies. + # block downstream auth based on 401, 407 replies. if (t_check_status("401|407")) { t_reply("404", "Not found"); exit;

1 0

[kamailio/kamailio] SIP Race condition when using dlg.end_dlg (Issue #4268)
by IgorG 02 Jul '25

02 Jul '25

IgorrG created an issue (kamailio/kamailio#4268) ### Description We use RPC dlg.end_dlg command to terminate dialog. In most cases it does operate properly and send BYE from kamailio to both sides of dialog (as show on screenshot). ![Image](https://github.com/user-attachments/assets/b49164a5-6442-4c66-bd4d-f5412678247f) We found that in some cases we have only first BYE sent to calling party. Second BYE never sent, when called party tries to terminate call by timeout it get responded with 481. ![Image](https://github.com/user-attachments/assets/10c90b4c-30a3-4123-8e2b-2ca64cdec3c3) ![Image](https://github.com/user-attachments/assets/f0facce8-3acf-4049-8a23-ad559874af7b) In logs we have such warning: мая 27 15:11:46 service-proxy.iqtek.ru kamailio[3518388]: 2(3518388) WARNING: {1 1 BYE 541d3f2c-43fd-43b6-af24-bad1fbf85eb6} dialog [dlg_handlers.c:1343]: dlg_onroute(): unable to find dialog for BYE with route param 'e1e.4f22' [3614:8948] and call-id '541d3f2c-43fd-43b6-af24-bad1fbf85eb6' We also found that in this case this warning shown in logs 0.04 seconds after kamailio receive 200ok. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # ./kamailio -V version: kamailio 5.8.6 (x86_64/linux) fb71db flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fb71db compiled on 17:38:27 May 26 2025 with gcc 12.2.0 ``` * **Operating System**: ``` # lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm # uname -a Linux rtp-kamailio2 6.1.0-32-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.129-1 (2025-03-06) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4268 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4268(a)github.com>

2 1

[kamailio/kamailio] "dns_hash_put(): unlinked item" downgrade of the WARN messages to INFO (Issue #4287)
by hubgurujr 01 Jul '25

01 Jul '25

hubgurujr created an issue (kamailio/kamailio#4287) Seeing a lot of warning messages in logs, running version: kamailio 5.8.4 (x86_64/linux) 1e6738, but I think this is false positive and should be informational, not a warning. Jun 10 14:14:17 siprouter1-pve186 /usr/local/sbin/kamailio[8111]:WARNING: <core> [core/dns_cache.c:170]: dns_hash_put(): unlinked item 0x7fa0f9b9fcc0 Jun 10 14:14:19 siprouter1-pve186 /usr/local/sbin/kamailio[8122]:WARNING: <core> [core/dns_cache.c:185]: dns_hash_put_shm_unsafe():unlinked item 0x7fa0f9b9fcc0 This is occurring when a DNS URL changes IP but I see no processing issues with SIP Messages. [emal-thread.txt](https://github.com/user-attachments/files/20776557/emal-th… -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4287 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4287(a)github.com>

2 16

[kamailio/kamailio] branch_failure_route does not handle reply while wt_timer period (Issue #4266)
by IgorG 01 Jul '25

01 Jul '25

IgorrG created an issue (kamailio/kamailio#4266) ### Description While implementing mid-register inspired by pull request (https://github.com/kamailio/kamailio/pull/3360) we found the case when it goes impossible to handle responses for registrar servers. In case some of registrars busy and respond with 401 after 200ok received - it is not possible using any routes and configuration options to handle responses received in branch transactions. According to documentation I think that setting wt_timer should allow to absorb and handle responses on failure-route while transaction kept in memory. In fact wt_timer does not affect handling responses in any way. ![Image](https://github.com/user-attachments/assets/14feb472-91ea-4028-8780-1fee1d4ee0e8) ### Troubleshooting To reproduce this case we have configured sipp to response instant with 200ok on registration request. #### Reproduction To reproduce issue SIPP could be setup as one of the dispatcher nodes with instant 200ok reply to register. Kamailio should use following configuration snippet: https://github.com/ovoshlook/kamailio-mid-registrar-config-snippets/blob/ma… #### Log Messages REGISTER|401tm [t_lookup.c:912]: t_reply_matching(): t_reply_matching: hash 12337 label 0 branch 1 REGISTER|401tm [t_lookup.c:986]: t_reply_matching(): reply (0x7f1fc67f83a8) matched an active transaction (T=0x7f1fc0f0f740)! REGISTER|401tm [t_lookup.c:1122]: t_check_msg(): msg (0x7f1fc67f83a8) id=13/1915035 global id=13/1915035 T end=0x7f1fc0f0f740 REGISTER|401tm [t_reply.c:2363]: reply_received(): transaction found - T:0x7f1fc0f0f740 branch:1 REGISTER|401tm [t_reply.c:2376]: reply_received(): original status uas=200, uac[1]=0 local=0 is_invite=0) REGISTER|401tm [t_reply.c:1363]: t_should_relay_response(): ->>>>>>>>> T_code=200, new_code=401 REGISTER|401tm [t_reply.c:1374]: t_should_relay_response(): final reply already sent REGISTER|401tm [t_reply.c:1625]: t_should_relay_response(): finished with rps discarded - uas status: 200 ### Possible Solutions  ### Additional Information * **Kamailio Version** ``` version: kamailio 5.6.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 16:35:08 Jun 5 2023 with gcc 10.2.1 ``` * **Operating System**: ``` No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye Linux pbxKamaTest 5.10.0-23-amd64 #1 SMP Debian 5.10.179-1 (2023-05-12) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4266 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4266(a)github.com>

3 2

git:master:fee83561: core: dns cache - destroy the item directly on remove
by Daniel-Constantin Mierla 01 Jul '25

01 Jul '25

Module: kamailio Branch: master Commit: fee835616425723f81b433b561aba54fbfd17045 URL: https://github.com/kamailio/kamailio/commit/fee835616425723f81b433b561aba54… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-01T14:43:01+02:00 core: dns cache - destroy the item directly on remove --- Modified: src/core/dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/fee835616425723f81b433b561aba54… Patch: https://github.com/kamailio/kamailio/commit/fee835616425723f81b433b561aba54… --- diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c index 2ed1b21f143..cb343a81184 100644 --- a/src/core/dns_cache.c +++ b/src/core/dns_cache.c @@ -508,7 +508,8 @@ inline static void _dns_hash_remove_entry( LM_DBG("item %p with high refcnt %d (%s:%u)\n", e, atomic_get_int(&e->refcnt), fpath, line); } - dns_hash_put(e); + /* item unlinked - destroy it */ + dns_destroy_entry(e); } #define _dns_hash_remove(e) _dns_hash_remove_entry(e, __FILE__, __LINE__)

1 0

git:master:5108e3c5: core: dns cache - lower the log levels for put and remove operations
by Daniel-Constantin Mierla 01 Jul '25

01 Jul '25

Module: kamailio Branch: master Commit: 5108e3c529790b1bc97e160ae841f238aa1bda4a URL: https://github.com/kamailio/kamailio/commit/5108e3c529790b1bc97e160ae841f23… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-01T13:11:22+02:00 core: dns cache - lower the log levels for put and remove operations --- Modified: src/core/dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/5108e3c529790b1bc97e160ae841f23… Patch: https://github.com/kamailio/kamailio/commit/5108e3c529790b1bc97e160ae841f23… --- diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c index 6c5f8c38e1b..2ed1b21f143 100644 --- a/src/core/dns_cache.c +++ b/src/core/dns_cache.c @@ -180,7 +180,7 @@ void dns_hash_put_entry( /* atomic_sub_long(dns_cache_total_used, e->total_size); */ dns_destroy_entry(e); } else if(e->next == NULL && e->prev == NULL) { - LM_WARN("unlinked item %p rc %d (%s:%u)\n", e, + LM_INFO("unlinked item %p rc %d (%s:%u)\n", e, atomic_get_int(&e->refcnt), fpath, line); } } @@ -505,7 +505,7 @@ inline static void _dns_hash_remove_entry( e->last_used_lst.next = e->last_used_lst.prev = 0; *dns_cache_mem_used -= e->total_size; if(atomic_get_int(&e->refcnt) > 1) { - LM_INFO("item %p with high refcnt %d (%s:%u)\n", e, + LM_DBG("item %p with high refcnt %d (%s:%u)\n", e, atomic_get_int(&e->refcnt), fpath, line); } dns_hash_put(e);

1 0

git:master:40837145: microhttpd: rework resetting the data field
by Daniel-Constantin Mierla 01 Jul '25

01 Jul '25

Module: kamailio Branch: master Commit: 4083714575e2cb7500c67fb8a0b99ff371bf8576 URL: https://github.com/kamailio/kamailio/commit/4083714575e2cb7500c67fb8a0b99ff… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-01T13:05:43+02:00 microhttpd: rework resetting the data field --- Modified: src/modules/microhttpd/microhttpd_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/4083714575e2cb7500c67fb8a0b99ff… Patch: https://github.com/kamailio/kamailio/commit/4083714575e2cb7500c67fb8a0b99ff… --- diff --git a/src/modules/microhttpd/microhttpd_mod.c b/src/modules/microhttpd/microhttpd_mod.c index ff486ac7dd6..7bc6586aaf3 100644 --- a/src/modules/microhttpd/microhttpd_mod.c +++ b/src/modules/microhttpd/microhttpd_mod.c @@ -535,14 +535,10 @@ static enum MHD_Result ksr_microhttpd_request(void *cls, if(_ksr_mhttpd_ctx.data.s != NULL) { free(_ksr_mhttpd_ctx.data.s); } + _ksr_mhttpd_ctx.data.s = NULL; + _ksr_mhttpd_ctx.data.len = 0; if(cstream->data.len > 0) { - if(_ksr_mhttpd_ctx.data.s != NULL) { - free(_ksr_mhttpd_ctx.data.s); - } _ksr_mhttpd_ctx.data = cstream->data; - } else { - _ksr_mhttpd_ctx.data.s = NULL; - _ksr_mhttpd_ctx.data.len = 0; } free(cstream); _ksr_mhttpd_ctx.cinfo = MHD_get_connection_info(

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev