sr-dev

sr-dev@lists.kamailio.org

16 participants
45365 discussions

git:5.7:8e7df134: tls_wolfssl: use shared WOLFSSL_CTX
by S-P Chan 24 Jan '24

24 Jan '24

Module: kamailio Branch: 5.7 Commit: 8e7df1345c828eeb6b999c30069e75ccdd440200 URL: https://github.com/kamailio/kamailio/commit/8e7df1345c828eeb6b999c30069e75c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-24T15:52:22+08:00 tls_wolfssl: use shared WOLFSSL_CTX (cherry-pick from 88f27e2b89142652ea1b8f133df1ff403f9f61b2) --- Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/8e7df1345c828eeb6b999c30069e75c… Patch: https://github.com/kamailio/kamailio/commit/8e7df1345c828eeb6b999c30069e75c…

1 0

git:5.7:0a481501: tls_wolfssl: clean-up OpenSSL compatibility
by S-P Chan 24 Jan '24

24 Jan '24

Module: kamailio Branch: 5.7 Commit: 0a481501024b0e85bde8fa74cde1df2bebaa167b URL: https://github.com/kamailio/kamailio/commit/0a481501024b0e85bde8fa74cde1df2… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-24T15:52:08+08:00 tls_wolfssl: clean-up OpenSSL compatibility - remove unneeded OpenSSL-isms (cherry-pick from 255e563e94e9536f0e541c3baeec45cbc68fac5b) --- Modified: src/modules/tls_wolfssl/tls_config.h Modified: src/modules/tls_wolfssl/tls_ct_wrq.h Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_init.h Modified: src/modules/tls_wolfssl/tls_util.h Modified: src/modules/tls_wolfssl/tls_verify.c Modified: src/modules/tls_wolfssl/tls_verify.h Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c Removed: src/modules/tls_wolfssl/tls_rand.c Removed: src/modules/tls_wolfssl/tls_rand.h --- Diff: https://github.com/kamailio/kamailio/commit/0a481501024b0e85bde8fa74cde1df2… Patch: https://github.com/kamailio/kamailio/commit/0a481501024b0e85bde8fa74cde1df2…

1 0

git:master:3d0e7521: tls_wolfssl: clean-up; remove OpenSSL-isms
by S-P Chan 24 Jan '24

24 Jan '24

Module: kamailio Branch: master Commit: 3d0e7521c6de4023b6595685fc306129ef57b8ac URL: https://github.com/kamailio/kamailio/commit/3d0e7521c6de4023b6595685fc30612… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-24T15:32:26+08:00 tls_wolfssl: clean-up; remove OpenSSL-isms --- Modified: src/modules/tls_wolfssl/tls_cfg.c Modified: src/modules/tls_wolfssl/tls_cfg.h Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_init.c Modified: src/modules/tls_wolfssl/tls_init.h Modified: src/modules/tls_wolfssl/tls_rpc.c Modified: src/modules/tls_wolfssl/tls_server.c Modified: src/modules/tls_wolfssl/tls_util.c Modified: src/modules/tls_wolfssl/tls_util.h Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c Removed: src/modules/tls_wolfssl/tls_dump_vf.c Removed: src/modules/tls_wolfssl/tls_dump_vf.h Removed: src/modules/tls_wolfssl/tls_map.c Removed: src/modules/tls_wolfssl/tls_map.h --- Diff: https://github.com/kamailio/kamailio/commit/3d0e7521c6de4023b6595685fc30612… Patch: https://github.com/kamailio/kamailio/commit/3d0e7521c6de4023b6595685fc30612…

1 0

git:master:33b2e513: tm: release transaction on kill if a final response was sent
by Daniel-Constantin Mierla 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: 33b2e513aefe00bf166cdcae360e305615b223da URL: https://github.com/kamailio/kamailio/commit/33b2e513aefe00bf166cdcae360e305… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-23T21:05:41+01:00 tm: release transaction on kill if a final response was sent - do not send another final response for error cases --- Modified: src/modules/tm/t_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/33b2e513aefe00bf166cdcae360e305… Patch: https://github.com/kamailio/kamailio/commit/33b2e513aefe00bf166cdcae360e305… --- diff --git a/src/modules/tm/t_funcs.c b/src/modules/tm/t_funcs.c index b9f9949d0fb..5515a4aba6f 100644 --- a/src/modules/tm/t_funcs.c +++ b/src/modules/tm/t_funcs.c @@ -177,6 +177,11 @@ int kill_transaction(struct cell *trans, int error) int reply_ret; int ret; + if((trans->uas.request != NULL) + && (trans->uas.request->msg_flags & FL_FINAL_REPLY)) { + return t_release_transaction(trans); + } + /* we reply statefully and enter WAIT state since error might have occurred in middle of forking and we do not want to put the forking burden on upstream client; @@ -205,6 +210,11 @@ int kill_transaction_unsafe(struct cell *trans, int error) int reply_ret; int ret; + if((trans->uas.request != NULL) + && (trans->uas.request->msg_flags & FL_FINAL_REPLY)) { + return t_release_transaction(trans); + } + /* we reply statefully and enter WAIT state since error might have occurred in middle of forking and we do not want to put the forking burden on upstream client;

1 0

git:master:0f8f4d69: auth: reformat exported structures
by Daniel-Constantin Mierla 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: 0f8f4d6926e53ca5e526a11729f6ee6277b185b9 URL: https://github.com/kamailio/kamailio/commit/0f8f4d6926e53ca5e526a11729f6ee6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-23T14:25:09+01:00 auth: reformat exported structures --- Modified: src/modules/auth/auth_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0f8f4d6926e53ca5e526a11729f6ee6… Patch: https://github.com/kamailio/kamailio/commit/0f8f4d6926e53ca5e526a11729f6ee6…

1 0

git:master:aa167c41: auth: removed commented code and prefixed short global variable
by Daniel-Constantin Mierla 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: aa167c410860732918061106c4a84a7c6b030d69 URL: https://github.com/kamailio/kamailio/commit/aa167c410860732918061106c4a84a7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-23T14:25:09+01:00 auth: removed commented code and prefixed short global variable --- Modified: src/modules/auth/auth_mod.c Modified: src/modules/auth/auth_mod.h Modified: src/modules/auth/nid.c Modified: src/modules/auth/nonce.c --- Diff: https://github.com/kamailio/kamailio/commit/aa167c410860732918061106c4a84a7… Patch: https://github.com/kamailio/kamailio/commit/aa167c410860732918061106c4a84a7… --- diff --git a/src/modules/auth/auth_mod.c b/src/modules/auth/auth_mod.c index fb633a10259..9bf4ac2923a 100644 --- a/src/modules/auth/auth_mod.c +++ b/src/modules/auth/auth_mod.c @@ -138,7 +138,7 @@ calc_response_t calc_response; /*! SL API structure */ -sl_api_t slb; +sl_api_t _auth_slb; /* * Exported functions @@ -248,8 +248,6 @@ static inline int generate_random_secret(void) secret2.s = sec_rand2; secret2.len = RAND_SECRET_LEN; - /* DBG("Generated secret: '%.*s'\n", secret.len, secret.s); */ - return 0; } @@ -263,7 +261,7 @@ static int mod_init(void) auth_realm_prefix.len = strlen(auth_realm_prefix.s); /* bind the SL API */ - if(sl_load_api(&slb) != 0) { + if(sl_load_api(&_auth_slb) != 0) { LM_ERR("cannot bind to SL API\n"); return -1; } @@ -949,8 +947,8 @@ static int auth_send_reply( reason_str.s = reason; reason_str.len = strlen(reason); - return force_stateless_reply ? slb.sreply(msg, code, &reason_str) - : slb.freply(msg, code, &reason_str); + return force_stateless_reply ? _auth_slb.sreply(msg, code, &reason_str) + : _auth_slb.freply(msg, code, &reason_str); } /** diff --git a/src/modules/auth/auth_mod.h b/src/modules/auth/auth_mod.h index ea3617e3d5e..48066750d2d 100644 --- a/src/modules/auth/auth_mod.h +++ b/src/modules/auth/auth_mod.h @@ -38,7 +38,6 @@ extern str secret1; /* secret phrase used to generate nonce */ extern str secret2; /* secret phrase used to generate nonce */ extern int nonce_expire; /* nonce expire interval */ extern int protect_contacts; /* Enable/disable contact hashing in nonce */ -extern sl_api_t sl; extern avp_ident_t challenge_avpid; extern str proxy_challenge_header; extern str www_challenge_header; diff --git a/src/modules/auth/nid.c b/src/modules/auth/nid.c index 408e6ab3e14..3aee167c633 100644 --- a/src/modules/auth/nid.c +++ b/src/modules/auth/nid.c @@ -77,11 +77,6 @@ int init_nonce_id() for(r = 0; r < nid_pool_no; r++) atomic_set(&nid_crt[r].id, random()); return 0; - /* -error: - destroy_nonce_id(); - return -1; -*/ } diff --git a/src/modules/auth/nonce.c b/src/modules/auth/nonce.c index 0304b394bd7..56cd49b7ec2 100644 --- a/src/modules/auth/nonce.c +++ b/src/modules/auth/nonce.c @@ -223,7 +223,7 @@ int calc_nonce(char *nonce, int *nonce_len, int cfg, unsigned int since, len = calc_bin_nonce_md5(&b_nonce, cfg, secret1, secret2, msg); *nonce_len = base64_enc( &b_nonce.raw[0], len, (unsigned char *)nonce, *nonce_len); - assert(*nonce_len >= 0); /*FIXME*/ + assert(*nonce_len >= 0); return 0; }

1 0

git:master:32089e13: tls_wolfssl: refactor custom BIO
by S-P Chan 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: 32089e134413200bf5d1a97f207378b7d10e65a2 URL: https://github.com/kamailio/kamailio/commit/32089e134413200bf5d1a97f207378b… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-23T21:02:57+08:00 tls_wolfssl: refactor custom BIO - remove use of custom BIO at the expense of some memory copies --- Modified: src/modules/tls_wolfssl/tls_rpc.c Modified: src/modules/tls_wolfssl/tls_server.c Modified: src/modules/tls_wolfssl/tls_server.h Removed: src/modules/tls_wolfssl/tls_bio.c Removed: src/modules/tls_wolfssl/tls_bio.h --- Diff: https://github.com/kamailio/kamailio/commit/32089e134413200bf5d1a97f207378b… Patch: https://github.com/kamailio/kamailio/commit/32089e134413200bf5d1a97f207378b…

1 0

git:master:88f27e2b: tls_wolfssl: use shared WOLFSSL_CTX
by S-P Chan 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: 88f27e2b89142652ea1b8f133df1ff403f9f61b2 URL: https://github.com/kamailio/kamailio/commit/88f27e2b89142652ea1b8f133df1ff4… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-23T10:51:37+08:00 tls_wolfssl: use shared WOLFSSL_CTX --- Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/88f27e2b89142652ea1b8f133df1ff4… Patch: https://github.com/kamailio/kamailio/commit/88f27e2b89142652ea1b8f133df1ff4…

1 0

git:master:255e563e: tls_wolfssl: clean-up OpenSSL compatibility
by S-P Chan 23 Jan '24

23 Jan '24

Module: kamailio Branch: master Commit: 255e563e94e9536f0e541c3baeec45cbc68fac5b URL: https://github.com/kamailio/kamailio/commit/255e563e94e9536f0e541c3baeec45c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-23T10:51:37+08:00 tls_wolfssl: clean-up OpenSSL compatibility - remove unneeded OpenSSL-isms --- Modified: src/modules/tls_wolfssl/tls_config.h Modified: src/modules/tls_wolfssl/tls_ct_wrq.h Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_init.h Modified: src/modules/tls_wolfssl/tls_util.h Modified: src/modules/tls_wolfssl/tls_verify.c Modified: src/modules/tls_wolfssl/tls_verify.h Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c Removed: src/modules/tls_wolfssl/tls_rand.c Removed: src/modules/tls_wolfssl/tls_rand.h --- Diff: https://github.com/kamailio/kamailio/commit/255e563e94e9536f0e541c3baeec45c… Patch: https://github.com/kamailio/kamailio/commit/255e563e94e9536f0e541c3baeec45c…

1 0

[kamailio/kamailio] Silence “make: --libs: No such file or directory” warnings (PR #3475)
by Дилян Палаузов 23 Jan '24

23 Jan '24

With GNU make 4.4 building Kamailio prints many “make: --libs: No such file or directory” and similar warnings. This changeset utilizes immediate variables and silences the warnings on my systems. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3475 -- Commit Summary -- * lib/ims: Aviod “make: --libs: No such file or directory” warnings * auth_identity: Aviod “make: --libs: No such file or directory” warnings * auth_ephemeral: Aviod “make: --libs: No such file or directory” warnings * app_python3: Avoid “/bin/sh: line 1: --ldflags: command not found” warnings * app_python3s: Avoid “/bin/sh: line 1: --ldflags: command not found” warnings * cdp: Aviod “make: --libs: No such file or directory” warnings * cnxcc: Avoid “make: --libs-only-L: No such file or directory” warnings * cplc: Avoid “make: --libs-only-L: No such file or directory” warnings * crypto: Aviod “make: --libs: No such file or directory” warnings * db_postgres: Avoid “make: --libs-only-L: No such file or directory” warnings * db_redis: Avoid “make: --libs-only-L: No such file or directory” warning * dialplan: Avoid “make: --libs-only-L: No such file or directory” warning * gzcompress: Aviod “make: --libs: No such file or directory” warnings * http_async_client: Aviod “make: --libs: No such file or directory” warnings * http_client: Aviod “make: --libs: No such file or directory” warning * ims_auth: Avoid “make: --libs-only-L: No such file or directory” warning * ims_icscf: Aviod “make: --libs: No such file or directory” warning * ims_registrar_scscf: Avoid “make: --libs-only-L: No such file or directory” warnings * ims_registrar_pcscf: Aviod “make: --libs: No such file or directory” warning * ims_isc: Avoid “make: --libs-only-L: No such file or directory” warnings * jansson: Aviod “make: --libs: No such file or directory” warning * kazoo: Avoid “make: --libs: No such file or directory’ warning * lcr: Aviod “make: --libs: No such file or directory” warning * log_systemd: Aviod “make: --libs: No such file or directory” warning * lost: Aviod “make: --libs: No such file or directory” warnings * lwsc: Aviod “make: --libs: No such file or directory” warning * ndb_redis: Aviod “make: --libs: No such file or directory” warning * osp: Avoid “make: --libs: No such file or directory’ warning * outbound: Aviod “make: --libs: No such file or directory” warnings * presence: Avoid “make: --libs-only-L: No such file or directory” warnings * presence_conference: Aviod “make: --libs: No such file or directory” warning * presence_dialog: Aviod “make: --libs: No such file or directory” warning * presence_reginfo: Aviod “make: --libs: No such file or directory” warning * presence_xml: Avoid “make: --libs-only-L: No such file or directory” warnings * pua: Avoid “make: --libs-only-L: No such file or directory” warnings * pua_bla: Aviod “make: --libs: No such file or directory” warning * pua_dialoginfo: Aviod “make: --libs: No such file or directory” warning * pua_reginfo: Aviod “make: --libs: No such file or directory” warning * pua_usrloc: Aviod “make: --libs: No such file or directory” warning * pua_xmpp: Aviod “make: --libs: No such file or directory” warning * regex: Aviod “make: --libs: No such file or directory” warning * rls: Avoid “make: --libs-only-L: No such file or directory” warnings * slack: Aviod “make: --libs: No such file or directory” warning * systemdops: Avoid “make: --libs-only-L: No such file or directory” warning * tls: Aviod “make: --libs: No such file or directory” warnings * tlsa: Avoid “make: --libs-only-L: No such file or directory” warning * topos_redis: Aviod “make: --libs: No such file or directory” warning * utils: Avoid “make: --libs-only-L: No such file or directory” warnings * uuid: Aviod “make: --libs: No such file or directory” warning * websocket: Aviod “make: --libs: No such file or directory” warnings * xcap_server: Avoid “make: --libs-only-L: No such file or directory” warnings * xhttp_pi: Avoid “make: --libs-only-L: No such file or directory” warnings * xmlops: Aviod “make: --libs: No such file or directory” warning * xmlrpc: Aviod “make: --libs: No such file or directory” warning -- File Changes -- M src/lib/ims/Makefile (4) M src/modules/app_python3/Makefile (6) M src/modules/app_python3s/Makefile (6) M src/modules/auth_ephemeral/Makefile (2) M src/modules/auth_identity/Makefile (4) M src/modules/cdp/Makefile (4) M src/modules/cnxcc/Makefile (4) M src/modules/cplc/Makefile (4) M src/modules/crypto/Makefile (2) M src/modules/db_postgres/Makefile (2) M src/modules/db_redis/Makefile (2) M src/modules/dialplan/Makefile (2) M src/modules/gzcompress/Makefile (2) M src/modules/http_async_client/Makefile (6) M src/modules/http_client/Makefile (2) M src/modules/ims_auth/Makefile (4) M src/modules/ims_icscf/Makefile (4) M src/modules/ims_isc/Makefile (4) M src/modules/ims_registrar_pcscf/Makefile (4) M src/modules/ims_registrar_scscf/Makefile (4) M src/modules/jansson/Makefile (2) M src/modules/kazoo/Makefile (2) M src/modules/lcr/Makefile (2) M src/modules/log_systemd/Makefile (2) M src/modules/lost/Makefile (6) M src/modules/lwsc/Makefile (2) M src/modules/ndb_redis/Makefile (2) M src/modules/osp/Makefile (2) M src/modules/outbound/Makefile (7) M src/modules/presence/Makefile (4) M src/modules/presence_conference/Makefile (4) M src/modules/presence_dialoginfo/Makefile (4) M src/modules/presence_reginfo/Makefile (4) M src/modules/presence_xml/Makefile (4) M src/modules/pua/Makefile (4) M src/modules/pua_bla/Makefile (4) M src/modules/pua_dialoginfo/Makefile (4) M src/modules/pua_reginfo/Makefile (4) M src/modules/pua_usrloc/Makefile (4) M src/modules/pua_xmpp/Makefile (4) M src/modules/regex/Makefile (2) M src/modules/rls/Makefile (4) M src/modules/slack/Makefile (2) M src/modules/systemdops/Makefile (2) M src/modules/tls/Makefile (4) M src/modules/tlsa/Makefile (4) M src/modules/topos_redis/Makefile (2) M src/modules/utils/Makefile (4) M src/modules/uuid/Makefile (2) M src/modules/websocket/Makefile (2) M src/modules/xcap_server/Makefile (4) M src/modules/xhttp_pi/Makefile (4) M src/modules/xmlops/Makefile (4) M src/modules/xmlrpc/Makefile (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3475.patch https://github.com/kamailio/kamailio/pull/3475.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3475 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3475(a)github.com>

4 16

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev