sr-dev

sr-dev@lists.kamailio.org

22 participants
45186 discussions

Releasing Kamailio v5.5.6
by Daniel-Constantin Mierla 02 Mar '23

02 Mar '23

Hello, I am considering to release Kamailio v5.5.6 soon, branch on branch 5.5, likely on Thursday or Wednesday next week (Mar 2/3, 2023). This is the usual heads up notification to see if anyone is aware of issues not yet reported to bug tracker and if yes, do it as soon as possible to give them a chance to be fixed. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - June 5-7, 2023 - www.kamailioworld.com Kamailio Advanced Training - Online - March 27-30, 2023 - www.asipto.com

1 1

Re: [kamailio/kamailio] rtpengine: doc add codec-accept with an example (e8c294f)
by Ihor Olkhovskyi 01 Mar '23

01 Mar '23

Small typo here `codec-accept=opus` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/e8c294f33f8b867b0f67d78c14b7327… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/e8c294f33f8b867b0f67d78c14b7327dc22dd726/102410069(a)github.com>

2 1

git:master:212675d3: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 01 Mar '23

01 Mar '23

Module: kamailio Branch: master Commit: 212675d350b64b5c9abb6a6eb844f41b6efb8693 URL: https://github.com/kamailio/kamailio/commit/212675d350b64b5c9abb6a6eb844f41… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-03-01T13:46:32+01:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/212675d350b64b5c9abb6a6eb844f41… Patch: https://github.com/kamailio/kamailio/commit/212675d350b64b5c9abb6a6eb844f41…

1 0

[kamailio/kamailio] rtpengine: document options SDES-pad and SDES-nonew (PR #3369)
by Дилян Палаузов 01 Mar '23

01 Mar '23

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3369 -- Commit Summary -- * rtpengine: document options SDES-pad and SDES-nonew -- File Changes -- M src/modules/rtpengine/bencode.h (2) M src/modules/rtpengine/doc/rtpengine_admin.xml (36) M src/modules/rtpengine/rtpengine.c (4) M src/modules/rtpengine/rtpengine_funcs.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3369.patch https://github.com/kamailio/kamailio/pull/3369.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3369 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3369(a)github.com>

3 3

git:master:5a9d8634: rtpengine: docs for SDES-nonew and SDES-pad flags
by Daniel-Constantin Mierla 01 Mar '23

01 Mar '23

Module: kamailio Branch: master Commit: 5a9d8634e742fe28b3b5c733b9e727b1dc7917ce URL: https://github.com/kamailio/kamailio/commit/5a9d8634e742fe28b3b5c733b9e727b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-01T13:29:47+01:00 rtpengine: docs for SDES-nonew and SDES-pad flags - spell fixes --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/5a9d8634e742fe28b3b5c733b9e727b… Patch: https://github.com/kamailio/kamailio/commit/5a9d8634e742fe28b3b5c733b9e727b…

1 0

git:master:bd497411: rtpengine: spell fixes in the comments
by Daniel-Constantin Mierla 01 Mar '23

01 Mar '23

Module: kamailio Branch: master Commit: bd497411f2e8e9ee6bd7e47d838add607019e761 URL: https://github.com/kamailio/kamailio/commit/bd497411f2e8e9ee6bd7e47d838add6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-01T13:31:12+01:00 rtpengine: spell fixes in the comments --- Modified: src/modules/rtpengine/bencode.h Modified: src/modules/rtpengine/rtpengine.c Modified: src/modules/rtpengine/rtpengine_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/bd497411f2e8e9ee6bd7e47d838add6… Patch: https://github.com/kamailio/kamailio/commit/bd497411f2e8e9ee6bd7e47d838add6… --- diff --git a/src/modules/rtpengine/bencode.h b/src/modules/rtpengine/bencode.h index f2efb742cc..df7fa8be66 100644 --- a/src/modules/rtpengine/bencode.h +++ b/src/modules/rtpengine/bencode.h @@ -220,7 +220,7 @@ struct iovec *bencode_iovec(bencode_item_t *root, int *cnt, unsigned int head, u /* Similar to bencode_iovec(), but instead returns the encoded document as a null-terminated string. * Memory for the string is allocated from the same bencode_buffer_t object as the "root" object - * was allocated from. If "len" is a non-NULL pointer, the length of the genrated string is returned + * was allocated from. If "len" is a non-NULL pointer, the length of the generated string is returned * in *len. This is important if the encoded document contains binary data, in which case null * termination cannot be trusted. The returned string is freed when the corresponding * bencode_buffer_t object is destroyed. */ diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 46640a5d3d..d0199ec04f 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -1147,8 +1147,8 @@ int add_rtpengine_socks(struct rtpp_set *rtpp_list, char *rtpengine, } -/* 0 - succes - * -1 - erorr +/* 0 - success + * -1 - error * */ static int rtpengine_add_rtpengine_set(char * rtp_proxies, unsigned int weight, int disabled, unsigned int ticks) { diff --git a/src/modules/rtpengine/rtpengine_funcs.c b/src/modules/rtpengine/rtpengine_funcs.c index 598af6360e..4863ec662c 100644 --- a/src/modules/rtpengine/rtpengine_funcs.c +++ b/src/modules/rtpengine/rtpengine_funcs.c @@ -178,8 +178,8 @@ int extract_body(struct sip_msg *msg, str *body ) /* * Better use the content-len value - no need of any explicit - * parcing as get_body() parsed all headers and Conten-Length - * body header is automaticaly parsed when found. + * parsing as get_body() parsed all headers and Content-Length + * body header is automatically parsed when found. */ if (msg->content_length==0) { LM_ERR("failed to get the content length in message\n");

1 0

[kamailio/kamailio] RPC command sl.stats does not work correctly with large values (exceeding 4 bytes) (Issue #3386)
by Nicolas C 01 Mar '23

01 Mar '23

### Description Using kamcmd to obtain statistics of SIP replies, for large values (exceeding 4 bytes) : Example : ``` kamcmd> sl.stats { (...) 302: -1294967293 } ``` The variable is an unsigned long, it can store values up to 2^64-1. But RPC command **sl.stats** does not support this. ### Possible Solutions I think the fix is simple, we should just replace "d" by "j" when using "rpc->struct_add" (function "rpc_stats" in file src/modules/sl/sl_stats.c). E.g. : ``` rpc->struct_add(st, "jjjj", "300", total.err[RT_300], "301", total.err[RT_301], "302", total.err[RT_302], "3xx", total.err[RT_3xx]); ``` I found a commit that did something similar with the shared memory stats : https://github.com/kamailio/kamailio/commit/f619cae55ffeb4596da852d9ed75773… ### Additional Information Kamailio 5.6.4 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3386 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3386(a)github.com>

2 2

git:master:1f2622fc: sl: print rpc result fields as unsigned long
by Daniel-Constantin Mierla 01 Mar '23

01 Mar '23

Module: kamailio Branch: master Commit: 1f2622fc7e0d7b81bab311728b1b3b6856790ace URL: https://github.com/kamailio/kamailio/commit/1f2622fc7e0d7b81bab311728b1b3b6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-01T13:20:41+01:00 sl: print rpc result fields as unsigned long - GH #3386 --- Modified: src/modules/sl/sl_stats.c --- Diff: https://github.com/kamailio/kamailio/commit/1f2622fc7e0d7b81bab311728b1b3b6… Patch: https://github.com/kamailio/kamailio/commit/1f2622fc7e0d7b81bab311728b1b3b6… --- diff --git a/src/modules/sl/sl_stats.c b/src/modules/sl/sl_stats.c index 079786aade..9b7cf51259 100644 --- a/src/modules/sl/sl_stats.c +++ b/src/modules/sl/sl_stats.c @@ -36,7 +36,7 @@ static void add_sl_stats( struct sl_stats *t, struct sl_stats *i) { enum reply_type rt; - for (rt=0; rt<RT_END; rt++) { + for (rt=0; rt<RT_END; rt++) { t->err[rt]+=i->err[rt]; t->all_replies+=i->err[rt]; } @@ -67,19 +67,19 @@ static void rpc_stats(rpc_t* rpc, void* c) } if (rpc->add(c, "{", &st) < 0) return; - - rpc->struct_add(st, "ddd", + + rpc->struct_add(st, "jjj", "200", total.err[RT_200], "202", total.err[RT_202], "2xx", total.err[RT_2xx]); - rpc->struct_add(st, "dddd", + rpc->struct_add(st, "jjjj", "300", total.err[RT_300], "301", total.err[RT_301], "302", total.err[RT_302], "3xx", total.err[RT_3xx]); - rpc->struct_add(st, "dddddddd", + rpc->struct_add(st, "jjjjjjjj", "400", total.err[RT_400], "401", total.err[RT_401], "403", total.err[RT_403], @@ -89,12 +89,12 @@ static void rpc_stats(rpc_t* rpc, void* c) "483", total.err[RT_483], "4xx", total.err[RT_4xx]); - rpc->struct_add(st, "dd", + rpc->struct_add(st, "jj", "500", total.err[RT_500], "5xx", total.err[RT_5xx]); - rpc->struct_add(st, "d", "6xx", total.err[RT_6xx]); - rpc->struct_add(st, "d", "xxx", total.err[RT_xxx]); + rpc->struct_add(st, "j", "6xx", total.err[RT_6xx]); + rpc->struct_add(st, "j", "xxx", total.err[RT_xxx]); } @@ -105,7 +105,7 @@ void sl_stats_destroy(void) shm_free(sl_stats); } -int init_sl_stats(void) +int init_sl_stats(void) { sl_stats = (struct sl_stats**)shm_malloc(sizeof(struct sl_stats*)); if (!sl_stats) { @@ -148,7 +148,7 @@ void update_sl_filtered_acks( void ) (*sl_stats)[process_no].filtered_acks++; } -void update_sl_stats( int code ) +void update_sl_stats( int code ) { struct sl_stats *my_stats; @@ -206,7 +206,7 @@ void update_sl_stats( int code ) break; } } - + } rpc_export_t sl_rpc[] = {

1 0

git:master:9a7c4025: modules: readme files regenerated - htable ... [skip ci]
by Kamailio Dev 01 Mar '23

01 Mar '23

Module: kamailio Branch: master Commit: 9a7c4025b6a4b90125c1c30dfd1d994100ae965e URL: https://github.com/kamailio/kamailio/commit/9a7c4025b6a4b90125c1c30dfd1d994… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-03-01T08:46:34+01:00 modules: readme files regenerated - htable ... [skip ci] --- Modified: src/modules/htable/README Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/9a7c4025b6a4b90125c1c30dfd1d994… Patch: https://github.com/kamailio/kamailio/commit/9a7c4025b6a4b90125c1c30dfd1d994…

1 0

git:master:714c9eb9: rtpengine: small spelling fix related to codec-mask example, related to e8c294f33f8b
by Henning Westerholt 01 Mar '23

01 Mar '23

Module: kamailio Branch: master Commit: 714c9eb99e6ba73e05a98df2bc6f4b339e9a97c9 URL: https://github.com/kamailio/kamailio/commit/714c9eb99e6ba73e05a98df2bc6f4b3… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-01T07:37:53Z rtpengine: small spelling fix related to codec-mask example, related to e8c294f33f8b --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/714c9eb99e6ba73e05a98df2bc6f4b3… Patch: https://github.com/kamailio/kamailio/commit/714c9eb99e6ba73e05a98df2bc6f4b3… --- diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index 99f97305c2..1d5ad12477 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -2715,7 +2715,7 @@ route { ... if (is_method("INVITE")) { if (has_body("application/sdp")) { - if (rtpengine_offer("codec-mask=opus codec-accept-opus codec-strip=PCMU codec-transcode=PCMU")) + if (rtpengine_offer("codec-mask=opus codec-accept=opus codec-strip=PCMU codec-transcode=PCMU")) t_on_reply("1"); } }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev