sr-dev

sr-dev@lists.kamailio.org

20 participants
45178 discussions

git:master:8f5a1c20: dispatcher: cast to uint64_t when using time_t value
by Daniel-Constantin Mierla 10 Feb '23

10 Feb '23

Module: kamailio Branch: master Commit: 8f5a1c20a6816e18f9f08f3b0273691dc5f8cc2c URL: https://github.com/kamailio/kamailio/commit/8f5a1c20a6816e18f9f08f3b0273691… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-09T17:16:43+01:00 dispatcher: cast to uint64_t when using time_t value --- Modified: src/modules/dispatcher/ds_ht.c --- Diff: https://github.com/kamailio/kamailio/commit/8f5a1c20a6816e18f9f08f3b0273691… Patch: https://github.com/kamailio/kamailio/commit/8f5a1c20a6816e18f9f08f3b0273691… --- diff --git a/src/modules/dispatcher/ds_ht.c b/src/modules/dispatcher/ds_ht.c index 540d0b5fdad..87eaf5e7544 100644 --- a/src/modules/dispatcher/ds_ht.c +++ b/src/modules/dispatcher/ds_ht.c @@ -19,6 +19,7 @@ */ #include <stddef.h> +#include <stdint.h> #include <regex.h> #include "../../core/mem/shm_mem.h" @@ -333,8 +334,8 @@ int ds_ht_dbg(ds_ht_t *dsht) while(it) { LM_ERR("\tcell: %.*s\n", it->callid.len, it->callid.s); LM_ERR("\tduid: %.*s\n", it->duid.len, it->duid.s); - LM_ERR("\thid: %u expire: %u initexpire: %u\n", it->cellid, - (unsigned int)it->expire, (unsigned int)it->initexpire); + LM_ERR("\thid: %u expire: %llu initexpire: %llu\n", it->cellid, + (uint64_t)it->expire, (uint64_t)it->initexpire); LM_ERR("\tdset:%d\n", it->dset); it = it->next; }

1 0

git:master:dd6339f8: core: tmrec - cast to 64b types when using time_t value
by Daniel-Constantin Mierla 09 Feb '23

09 Feb '23

Module: kamailio Branch: master Commit: dd6339f817822cd0590aec2a9a467330bde499dd URL: https://github.com/kamailio/kamailio/commit/dd6339f817822cd0590aec2a9a46733… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-09T12:38:53+01:00 core: tmrec - cast to 64b types when using time_t value --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/dd6339f817822cd0590aec2a9a46733… Patch: https://github.com/kamailio/kamailio/commit/dd6339f817822cd0590aec2a9a46733… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index 29366fe0b2..adae68edbf 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -31,6 +31,7 @@ #include <stdio.h> #include <string.h> #include <time.h> +#include <stdint.h> #include "../../core/mem/mem.h" #include "tmrec.h" @@ -271,7 +272,7 @@ int ac_print(ac_tm_t *_atp) return -1; } - printf("\nSys time: %d\nTime: %02d:%02d:%02d\n", (int)_atp->time, + printf("\nSys time: %llu\nTime: %02d:%02d:%02d\n", (uint64_t)_atp->time, _atp->t.tm_hour, _atp->t.tm_min, _atp->t.tm_sec); printf("Date: %s, %04d-%02d-%02d\n", _wdays[_atp->t.tm_wday], _atp->t.tm_year+1900, _atp->t.tm_mon+1, _atp->t.tm_mday); @@ -511,15 +512,15 @@ int tr_print(tmrec_t *_trp) return -1; } printf("Recurrence definition\n-- start time ---\n"); - printf("Sys time: %d\n", (int)_trp->dtstart); + printf("Sys time: %llu\n", (uint64_t)_trp->dtstart); printf("Time: %02d:%02d:%02d\n", _trp->ts.tm_hour, _trp->ts.tm_min, _trp->ts.tm_sec); printf("Date: %s, %04d-%02d-%02d\n", _wdays[_trp->ts.tm_wday], _trp->ts.tm_year+1900, _trp->ts.tm_mon+1, _trp->ts.tm_mday); printf("---\n"); - printf("End time: %d\n", (int)_trp->dtend); - printf("Duration: %d\n", (int)_trp->duration); - printf("Until: %d\n", (int)_trp->until); + printf("End time: %llu\n", (uint64_t)_trp->dtend); + printf("Duration: %llu\n", (uint64_t)_trp->duration); + printf("Until: %llu\n", (uint64_t)_trp->until); printf("Freq: %d\n", (int)_trp->freq); printf("Interval: %d\n", (int)_trp->interval); if(_trp->byday) @@ -997,7 +998,7 @@ int tr_check_recurrence(tmrec_t *_trp, ac_tm_t *_atp, tr_res_t *_tsw) int check_freq_interval(tmrec_t *_trp, ac_tm_t *_atp) { - int _t0, _t1; + uint64_t _t0, _t1; struct tm _tm; if(!_trp || !_atp) return REC_ERR; @@ -1016,12 +1017,12 @@ int check_freq_interval(tmrec_t *_trp, ac_tm_t *_atp) _tm.tm_year = _trp->ts.tm_year; _tm.tm_mon = _trp->ts.tm_mon; _tm.tm_mday = _trp->ts.tm_mday; - _t0 = (int)mktime(&_tm); + _t0 = (uint64_t)mktime(&_tm); memset(&_tm, 0, sizeof(struct tm)); _tm.tm_year = _atp->t.tm_year; _tm.tm_mon = _atp->t.tm_mon; _tm.tm_mday = _atp->t.tm_mday; - _t1 = (int)mktime(&_tm); + _t1 = (uint64_t)mktime(&_tm); if(_trp->freq == FREQ_DAILY) return (((_t1-_t0)/(24*3600))%_trp->interval==0)? REC_MATCH:REC_NOMATCH;

1 0

git:master:0a3c1523: async: catch up on possible skipped slots due to slow tasks
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: 0a3c15239a620474bbbc7f4d2f57dda0e9aa0f58 URL: https://github.com/kamailio/kamailio/commit/0a3c15239a620474bbbc7f4d2f57dda… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T15:51:37+01:00 async: catch up on possible skipped slots due to slow tasks --- Modified: src/modules/async/async_sleep.c --- Diff: https://github.com/kamailio/kamailio/commit/0a3c15239a620474bbbc7f4d2f57dda… Patch: https://github.com/kamailio/kamailio/commit/0a3c15239a620474bbbc7f4d2f57dda… --- diff --git a/src/modules/async/async_sleep.c b/src/modules/async/async_sleep.c index 02c3b8d488..d6dd41d3f1 100644 --- a/src/modules/async/async_sleep.c +++ b/src/modules/async/async_sleep.c @@ -271,9 +271,12 @@ int async_sleep(sip_msg_t *msg, int seconds, cfg_action_t *act, str *cbname) return 0; } +static unsigned int _async_timer_exec_last_slot = -1; + void async_timer_exec(unsigned int ticks, void *param) { - int slot; + unsigned int idx; + unsigned int slot; async_item_t *ai; sr_kemi_eng_t *keng = NULL; str cbname = STR_NULL; @@ -282,33 +285,55 @@ void async_timer_exec(unsigned int ticks, void *param) if(_async_list_head == NULL) return; - slot = ticks % ASYNC_RING_SIZE; + idx = ticks % ASYNC_RING_SIZE; - while(1) { - lock_get(&_async_list_head->ring[slot].lock); - ai = _async_list_head->ring[slot].lstart; - if(ai != NULL) - _async_list_head->ring[slot].lstart = ai->next; - lock_release(&_async_list_head->ring[slot].lock); + if(idx == _async_timer_exec_last_slot) { + /* timer faster than 1sec */ + return; + } - if(ai == NULL) - break; - if(ai->ract != NULL) { - tmb.t_continue(ai->tindex, ai->tlabel, ai->ract); - ksr_msg_env_reset(); - } else { - keng = sr_kemi_eng_get(); - if(keng != NULL && ai->cbname_len>0) { - cbname.s = ai->cbname; - cbname.len = ai->cbname_len; - tmb.t_continue_cb(ai->tindex, ai->tlabel, &cbname, &evname); + if(_async_timer_exec_last_slot < 0) { + _async_timer_exec_last_slot = idx; + } + slot = (_async_timer_exec_last_slot + 1) % ASYNC_RING_SIZE; + if(slot != idx) { + LM_DBG("need to catch up from slot %u to %u (slots: %u)\n", slot, idx, + ASYNC_RING_SIZE); + } + + do { + while(1) { + lock_get(&_async_list_head->ring[slot].lock); + ai = _async_list_head->ring[slot].lstart; + if(ai != NULL) + _async_list_head->ring[slot].lstart = ai->next; + lock_release(&_async_list_head->ring[slot].lock); + + if(ai == NULL) + break; + if(ai->ract != NULL) { + tmb.t_continue(ai->tindex, ai->tlabel, ai->ract); ksr_msg_env_reset(); } else { - LM_WARN("no callback to be executed\n"); + keng = sr_kemi_eng_get(); + if(keng != NULL && ai->cbname_len>0) { + cbname.s = ai->cbname; + cbname.len = ai->cbname_len; + tmb.t_continue_cb(ai->tindex, ai->tlabel, &cbname, &evname); + ksr_msg_env_reset(); + } else { + LM_WARN("no callback to be executed\n"); + } } + shm_free(ai); } - shm_free(ai); - } + if(slot == idx) { + break; + } + slot = (slot + 1) % ASYNC_RING_SIZE; + } while(1); + + _async_timer_exec_last_slot = idx; } void async_mstimer_exec(unsigned int ticks, void *param)

1 0

git:master:6be85c8a: modules: readme files regenerated - seas ... [skip ci]
by Kamailio Dev 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: 6be85c8a72bc37b2bb4b1f4be59c5d0c20996850 URL: https://github.com/kamailio/kamailio/commit/6be85c8a72bc37b2bb4b1f4be59c5d0… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-02-08T14:16:31+01:00 modules: readme files regenerated - seas ... [skip ci] --- Modified: src/modules/seas/README Modified: src/modules/siputils/README Modified: src/modules/tls/README Modified: src/modules/tls_wolfssl/README Modified: src/modules/xcap_client/README --- Diff: https://github.com/kamailio/kamailio/commit/6be85c8a72bc37b2bb4b1f4be59c5d0… Patch: https://github.com/kamailio/kamailio/commit/6be85c8a72bc37b2bb4b1f4be59c5d0…

1 0

[kamailio/kamailio] Typos (PR #3362)
by Дилян Палаузов 08 Feb '23

08 Feb '23

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3362 -- Commit Summary -- * doc/scripts: typos * seas: typos * siputis: typos * tls: typos * tls_wolfssl: typos * xcap_client: typos * xcap_server: typos * xhttp: typo * xhttp_pi: typos * xhttp_prom: typo * xhttp_rpc: typos * xmlrpc: typos * xprint: typos -- File Changes -- M doc/scripts/cdefs2doc/dump_cfg_defs.pl (4) M doc/scripts/cdefs2doc/dump_counters.pl (2) M doc/scripts/cdefs2doc/dump_rpcs.pl (2) M doc/scripts/cdefs2doc/dump_selects.pl (2) M src/modules/seas/doc/seas_admin.xml (2) M src/modules/seas/encode_content_length.c (2) M src/modules/seas/encode_content_length.h (4) M src/modules/seas/encode_msg.c (6) M src/modules/seas/encode_parameters.c (2) M src/modules/seas/encode_to_body.c (2) M src/modules/seas/encode_uri.c (2) M src/modules/seas/event_dispatcher.c (12) M src/modules/seas/seas.c (4) M src/modules/seas/seas_action.c (10) M src/modules/seas/statistics.c (6) M src/modules/siputils/chargingvector.c (2) M src/modules/siputils/checks.c (2) M src/modules/siputils/checks.h (2) M src/modules/siputils/contact_ops.c (2) M src/modules/siputils/doc/siputils_admin.xml (2) M src/modules/siputils/siputils.c (2) M src/modules/tls/doc/params.xml (12) M src/modules/tls/doc/tls.xml (2) M src/modules/tls/sbufq.h (2) M src/modules/tls/tls_cfg.h (2) M src/modules/tls/tls_ct_q.h (2) M src/modules/tls/tls_domain.c (8) M src/modules/tls/tls_init.c (18) M src/modules/tls/tls_init.h (6) M src/modules/tls/tls_server.c (10) M src/modules/tls_wolfssl/doc/tls_wolfssl.xml (2) M src/modules/tls_wolfssl/sbufq.h (2) M src/modules/tls_wolfssl/tls_cfg.h (2) M src/modules/tls_wolfssl/tls_ct_q.h (2) M src/modules/tls_wolfssl/tls_domain.c (6) M src/modules/tls_wolfssl/tls_init.c (4) M src/modules/tls_wolfssl/tls_server.c (4) M src/modules/xcap_client/doc/xcap_client_devel.xml (2) M src/modules/xcap_client/xcap_functions.c (2) M src/modules/xcap_server/xcap_misc.c (2) M src/modules/xcap_server/xcap_misc.h (2) M src/modules/xhttp/xhttp_mod.c (2) M src/modules/xhttp_pi/Makefile (4) M src/modules/xhttp_pi/xhttp_pi.c (2) M src/modules/xhttp_pi/xhttp_pi_fnc.c (12) M src/modules/xhttp_prom/xhttp_prom.c (2) M src/modules/xhttp_rpc/xhttp_rpc.c (6) M src/modules/xhttp_rpc/xhttp_rpc_fnc.c (6) M src/modules/xmlrpc/xmlrpc.c (16) M src/modules/xprint/xp_lib.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3362.patch https://github.com/kamailio/kamailio/pull/3362.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3362 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3362(a)github.com>

2 1

git:master:c86b5d85: xmlrpc: typos
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: c86b5d85a8aa86c1c59b5eed2ded87aee4fd1682 URL: https://github.com/kamailio/kamailio/commit/c86b5d85a8aa86c1c59b5eed2ded87a… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T14:05:32+01:00 xmlrpc: typos --- Modified: src/modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/c86b5d85a8aa86c1c59b5eed2ded87a… Patch: https://github.com/kamailio/kamailio/commit/c86b5d85a8aa86c1c59b5eed2ded87a… --- diff --git a/src/modules/xmlrpc/xmlrpc.c b/src/modules/xmlrpc/xmlrpc.c index 898099df30e..7cfb8567748 100644 --- a/src/modules/xmlrpc/xmlrpc.c +++ b/src/modules/xmlrpc/xmlrpc.c @@ -691,7 +691,7 @@ static void clean_xmlrpc_reply(struct xmlrpc_reply* reply) /** Create XML-RPC reply that indicates an error to the caller. * * This function is used to build the XML-RPC reply body that indicates that - * an error ocurred on the server. It is called when a management function in + * an error occurred on the server. It is called when a management function in * SER reports an error. The reply will contain the reason code and reason * phrase text provided by the management function that indicated the error. */ @@ -712,7 +712,7 @@ static int build_fault_reply(struct xmlrpc_reply* reply) } -/** Add a memory registion to the list of memory blocks that +/** Add a memory registration to the list of memory blocks that * need to be re-claimed later. * * @param type The type of the memory block (ordinary text or structure). @@ -868,7 +868,7 @@ static int print_structures(struct xmlrpc_reply* reply, * SER asks the management interface to send the reply to the client. The * function will generate the XML-RPC document, put it in body of a SIP * response and send the response to the client. The SIP/HTTP reply sent to - * the client will be always 200 OK, if an error ocurred on the server then it + * the client will be always 200 OK, if an error occurred on the server then it * will be indicated in the XML document in body. * * @param ctx A pointer to the context structure of the XML-RPC request that @@ -916,7 +916,7 @@ static void set_fault(struct xmlrpc_reply* reply, int code, char* fmt, ...) * SER. * * This function will be called whenever a management function in SER - * indicates that an error ocurred while it was processing the request. The + * indicates that an error occurred while it was processing the request. The * function takes the reply code and reason phrase as parameters, these will * be put in the body of the reply. * @@ -1264,7 +1264,7 @@ static enum xmlrpc_val_type xml_get_type(xmlNodePtr value) * This function receives a pointer to a parameter encoded in XML-RPC format * and tries to convert the value of the parameter into integer. Only * <i4>, <int>, <boolean>, <dateTime.iso8601> XML-RPC - * parameters can be converted to integer, attempts to conver other types will + * parameters can be converted to integer, attempts to convert other types will * fail. * @param val A pointer to an integer variable where the result will be * stored. @@ -1360,7 +1360,7 @@ static int get_int(int* val, struct xmlrpc_reply* reply, * This function receives a pointer to a parameter encoded in XML-RPC format * and tries to convert the value of the parameter into double. Only * <i4>, <int>, <double> XML-RPC parameters can be converted - * to double, attempts to conver other types will fail. + * to double, attempts to convert other types will fail. * @param val A pointer to an integer variable where the result will be * stored. * @param reply A pointer to XML-RPC reply being constructed (used to indicate @@ -1487,7 +1487,7 @@ static int get_string(char** val, struct xmlrpc_reply* reply, return -1; } type=xml_get_type(dbl); - LM_DBG("xmrpc parameter type: %d\n", type); + LM_DBG("xmlrpc parameter type: %d\n", type); switch(type){ case XML_T_STR: case XML_T_TXT: @@ -2235,7 +2235,7 @@ static void rpc_delayed_ctx_close(struct rpc_delayed_ctx* dctx) (hdr->parsed<(void*)r_ctx->msg || hdr->parsed>=(void*)(r_ctx->msg+r_ctx->msg_shm_block_size))) { /* header parsed filed doesn't point inside uas.request memory - * chunck -> it was added by failure funcs.-> free it as pkg */ + * chunk -> it was added by failure funcs.-> free it as pkg */ DBG("DBG:free_faked_req: removing hdr->parsed %d\n", hdr->type); clean_hdr_field(hdr);

1 0

git:master:ec6f3b12: xprint: typos
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: ec6f3b122f9c41b437ccfcb07b0952e2ffcc2719 URL: https://github.com/kamailio/kamailio/commit/ec6f3b122f9c41b437ccfcb07b0952e… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T14:05:32+01:00 xprint: typos --- Modified: src/modules/xprint/xp_lib.c --- Diff: https://github.com/kamailio/kamailio/commit/ec6f3b122f9c41b437ccfcb07b0952e… Patch: https://github.com/kamailio/kamailio/commit/ec6f3b122f9c41b437ccfcb07b0952e… --- diff --git a/src/modules/xprint/xp_lib.c b/src/modules/xprint/xp_lib.c index 89d53d59fc2..06b744fe92d 100644 --- a/src/modules/xprint/xp_lib.c +++ b/src/modules/xprint/xp_lib.c @@ -239,7 +239,7 @@ static int xl_get_ruri(struct sip_msg *msg, str *res, str *hp, int hi, int hf) if(msg==NULL || res==NULL) return -1; - if(msg->first_line.type == SIP_REPLY) /* REPLY doesnt have a ruri */ + if(msg->first_line.type == SIP_REPLY) /* REPLY doesn't have a ruri */ return xl_get_null(msg, res, hp, hi, hf); if(msg->parsed_uri_ok==0 /* R-URI not parsed*/ && parse_sip_msg_uri(msg)<0) @@ -580,7 +580,7 @@ static int xl_get_color(struct sip_msg *msg, str *res, str *hp, int hi, int hf) p = color; end = p + COL_BUF; - /* excape sequenz */ + /* escape sequence */ append_sstring(p, end, "\033["); if(hp->s[0]!='_')

1 0

git:master:d9445d60: xhttp_prom: typo
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: d9445d60ea6432664447858dff3852be94c04196 URL: https://github.com/kamailio/kamailio/commit/d9445d60ea6432664447858dff3852b… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T14:05:32+01:00 xhttp_prom: typo --- Modified: src/modules/xhttp_prom/xhttp_prom.c --- Diff: https://github.com/kamailio/kamailio/commit/d9445d60ea6432664447858dff3852b… Patch: https://github.com/kamailio/kamailio/commit/d9445d60ea6432664447858dff3852b… --- diff --git a/src/modules/xhttp_prom/xhttp_prom.c b/src/modules/xhttp_prom/xhttp_prom.c index 74f83dce87..1c471d4b11 100644 --- a/src/modules/xhttp_prom/xhttp_prom.c +++ b/src/modules/xhttp_prom/xhttp_prom.c @@ -198,7 +198,7 @@ struct module_exports exports = { * @brief Implementation of prom_fault function required by the management API. * * This function will be called whenever a management function - * indicates that an error ocurred while it was processing the request. The + * indicates that an error occurred while it was processing the request. The * function takes the reply code and reason phrase as parameters, these will * be put in the body of the reply. *

1 0

git:master:e07960d7: xhttp_rpc: typos
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: e07960d74570aa9a94075e83b5bf4fc9cf418864 URL: https://github.com/kamailio/kamailio/commit/e07960d74570aa9a94075e83b5bf4fc… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T14:05:32+01:00 xhttp_rpc: typos --- Modified: src/modules/xhttp_rpc/xhttp_rpc.c Modified: src/modules/xhttp_rpc/xhttp_rpc_fnc.c --- Diff: https://github.com/kamailio/kamailio/commit/e07960d74570aa9a94075e83b5bf4fc… Patch: https://github.com/kamailio/kamailio/commit/e07960d74570aa9a94075e83b5bf4fc… --- diff --git a/src/modules/xhttp_rpc/xhttp_rpc.c b/src/modules/xhttp_rpc/xhttp_rpc.c index 8db886dbdc..d2c72bbf87 100644 --- a/src/modules/xhttp_rpc/xhttp_rpc.c +++ b/src/modules/xhttp_rpc/xhttp_rpc.c @@ -115,7 +115,7 @@ struct module_exports exports= { /** Implementation of rpc_fault function required by the management API. * * This function will be called whenever a management function - * indicates that an error ocurred while it was processing the request. The + * indicates that an error occurred while it was processing the request. The * function takes the reply code and reason phrase as parameters, these will * be put in the body of the reply. * @@ -149,7 +149,7 @@ static void free_data_struct(struct rpc_data_struct *rpc_d) struct rpc_data_struct *ds; if (!rpc_d) { - LM_ERR("Atempting to free NULL rpc_data_struct\n"); + LM_ERR("Attempting to free NULL rpc_data_struct\n"); return; } while (rpc_d) { @@ -213,7 +213,7 @@ static int init_xhttp_rpc_reply(rpc_ctx_t *ctx) * This is the function that will be called whenever a management function * asks the management interface to send the reply to the client. * The SIP/HTTP reply sent to - * the client will be always 200 OK, if an error ocurred on the server then it + * the client will be always 200 OK, if an error occurred on the server then it * will be indicated in the html document in body. * * @param ctx A pointer to the context structure of the xhttp_rpc request that diff --git a/src/modules/xhttp_rpc/xhttp_rpc_fnc.c b/src/modules/xhttp_rpc/xhttp_rpc_fnc.c index 71e28aee5b..a468d4770a 100644 --- a/src/modules/xhttp_rpc/xhttp_rpc_fnc.c +++ b/src/modules/xhttp_rpc/xhttp_rpc_fnc.c @@ -186,7 +186,7 @@ static const str XHTTP_RPC_Response_Foot = str_init(\ "\n</center>\n<div align=\"center\" class=\"foot\" style=\"margin:20px auto\">"\ "<span style='margin-left:5px;'></span>"\ "<a href=\"http://sip-router.org\">SIP Router web site</a> .:. "\ - "<a href=\"http://www.kamailio.org\">Kamailio web site</a><br/>"\ + "<a href=\"https://www.kamailio.org\">Kamailio web site</a><br/>"\ "Copyright © 2011-2013 <a href=\"http://www.voipembedded.com/\">VoIP Embedded</a>"\ ". All rights reserved."\ "</div></body></html>"); @@ -375,7 +375,7 @@ int xhttp_rpc_build_header(rpc_ctx_t *ctx) name.s = (char*)rpc_sarray[xhttp_rpc_mod_cmds[mod].rpc_e_index+cmd]->r.name; name.len = strlen(name.s); - /* Print comand name */ + /* Print command name */ XHTTP_RPC_COPY_4(p,XHTTP_RPC_Response_Menu_Cmd_Table_1, XHTTP_RPC_Response_Menu_Cmd_tr_1, XHTTP_RPC_Response_Menu_Cmd_td_1a, @@ -414,7 +414,7 @@ int xhttp_rpc_build_header(rpc_ctx_t *ctx) name.s = (char*)rpc_sarray[xhttp_rpc_mod_cmds[mod].rpc_e_index]->r.name; name.len = strlen(name.s); - /* Build the list of comands for the selected module */ + /* Build the list of commands for the selected module */ XHTTP_RPC_COPY_4(p,XHTTP_RPC_Response_Menu_Cmd_Table_1, XHTTP_RPC_Response_Menu_Cmd_tr_1, XHTTP_RPC_Response_Menu_Cmd_td_1a,

1 0

git:master:44c1c181: xhttp: typo
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: 44c1c181bd250c0f81ffe0bb6b6566b4148b8b0f URL: https://github.com/kamailio/kamailio/commit/44c1c181bd250c0f81ffe0bb6b6566b… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T14:05:32+01:00 xhttp: typo --- Modified: src/modules/xhttp/xhttp_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/44c1c181bd250c0f81ffe0bb6b6566b… Patch: https://github.com/kamailio/kamailio/commit/44c1c181bd250c0f81ffe0bb6b6566b… --- diff --git a/src/modules/xhttp/xhttp_mod.c b/src/modules/xhttp/xhttp_mod.c index 31b2efb4d6e..ec53f75f40c 100644 --- a/src/modules/xhttp/xhttp_mod.c +++ b/src/modules/xhttp/xhttp_mod.c @@ -333,7 +333,7 @@ static int xhttp_handler(sip_msg_t *msg) ret = NONSIP_MSG_DROP; if(!IS_HTTP(msg)) { - /* oly http msg type */ + /* only http msg type */ return NONSIP_MSG_PASS; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev