sr-dev

sr-dev@lists.kamailio.org

11 participants
45226 discussions

[kamailio/kamailio] exec: docs - added security warning (PR #3338)
by Sandro Gauci 26 Jan '23

26 Jan '23

- Added warning about potential for OS Command Injection - Updated invalid examples previous example gives the following error: pv_parse_spec2(): error searching pvar "rU.txt"   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Misuse of the exec module functions is a security concern. This PR updates the documentation to help Kamailio administrators use these functions securely. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3338 -- Commit Summary -- * exec: docs - added security warning -- File Changes -- M src/modules/exec/doc/exec_admin.xml (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3338.patch https://github.com/kamailio/kamailio/pull/3338.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3338 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3338(a)github.com> [View Less]

4 7

[kamailio/kamailio] Sorry I am not sur (Issue #3342)
by Jonnypleasehelp 25 Jan '23

25 Jan '23

<!-- Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for feature requests. If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list: * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list: * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev … [View More]

2 1

Re: [kamailio/kamailio] Run failed: build - master (6c372bf)
by Henning Westerholt 25 Jan '23

25 Jan '23

Hello, this is probably caused from microsoft, they are having some global WAN issues. Cheers, Henning From: Henning Westerholt <notifications(a)github.com> Sent: Wednesday, January 25, 2023 9:52 AM To: Kamailio Devel List <sr-dev(a)lists.kamailio.org> Cc: Ci activity <ci_activity(a)noreply.github.com> Subject: [kamailio/kamailio] Run failed: build - master (6c372bf) [GitHub] [kamailio/kamailio] build workflow run [https://github.githubassets.com/images/email/icons/… [View More]

1 0

git:5.5:f7ee24dc: core: fix memory leak related to Require header parsing, this header also need to be freed
by Henning Westerholt 25 Jan '23

25 Jan '23

Module: kamailio Branch: 5.5 Commit: f7ee24dc4fc3ffb1b6f9e4f73b63f249acd979e3 URL: https://github.com/kamailio/kamailio/commit/f7ee24dc4fc3ffb1b6f9e4f73b63f24… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-01-25T08:02:01Z core: fix memory leak related to Require header parsing, this header also need to be freed (cherry picked from commit 6c372bf644e1c9afa867433e5992e347c8fc4ff6) (cherry picked from commit … [View More]

1 0

git:5.6:3cc09ff6: core: fix memory leak related to Require header parsing, this header also need to be freed
by Henning Westerholt 25 Jan '23

25 Jan '23

Module: kamailio Branch: 5.6 Commit: 3cc09ff6045c35feef5902e3cea6b313c49e8a77 URL: https://github.com/kamailio/kamailio/commit/3cc09ff6045c35feef5902e3cea6b31… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-01-25T08:01:33Z core: fix memory leak related to Require header parsing, this header also need to be freed (cherry picked from commit 6c372bf644e1c9afa867433e5992e347c8fc4ff6) --- Modified: src/core/parser/hf.h --- … [View More]

1 0

git:master:6c372bf6: core: fix memory leak related to Require header parsing, this header also need to be freed
by Henning Westerholt 25 Jan '23

25 Jan '23

Module: kamailio Branch: master Commit: 6c372bf644e1c9afa867433e5992e347c8fc4ff6 URL: https://github.com/kamailio/kamailio/commit/6c372bf644e1c9afa867433e5992e34… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-01-25T08:00:34Z core: fix memory leak related to Require header parsing, this header also need to be freed --- Modified: src/core/parser/hf.h --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:5dabd1e7: modules: readme files regenerated - tls ... [skip ci]
by Kamailio Dev 25 Jan '23

25 Jan '23

Module: kamailio Branch: master Commit: 5dabd1e7aa3574a41fc30ead60f9e3f68de0f471 URL: https://github.com/kamailio/kamailio/commit/5dabd1e7aa3574a41fc30ead60f9e3f… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-01-25T08:31:17+01:00 modules: readme files regenerated - tls ... [skip ci] --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/5dabd1e7aa3574a41fc30ead60f9e3f… … [View More]

1 0

git:master:331aa575: tls: update docs for init_mode with details about fork prepare option
by Daniel-Constantin Mierla 25 Jan '23

25 Jan '23

Module: kamailio Branch: master Commit: 331aa5753beccd3ddb241219cf1988a506fa2de3 URL: https://github.com/kamailio/kamailio/commit/331aa5753beccd3ddb241219cf1988a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-25T08:26:09+01:00 tls: update docs for init_mode with details about fork prepare option --- Modified: src/modules/tls/doc/params.xml --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:cb424135: tls: new option for init_mode to use openssl api for fork prepare
by Daniel-Constantin Mierla 25 Jan '23

25 Jan '23

Module: kamailio Branch: master Commit: cb424135c4164be10dd3c12086b548b8fec0d830 URL: https://github.com/kamailio/kamailio/commit/cb424135c4164be10dd3c12086b548b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-25T08:19:52+01:00 tls: new option for init_mode to use openssl api for fork prepare - flag 2 (value 2) has to be set --- Modified: src/modules/tls/tls_init.h Modified: src/modules/tls/tls_mod.… [View More]c --- Diff: https://github.com/kamailio/kamailio/commit/cb424135c4164be10dd3c12086b548b… Patch: https://github.com/kamailio/kamailio/commit/cb424135c4164be10dd3c12086b548b… --- diff --git a/src/modules/tls/tls_init.h b/src/modules/tls/tls_init.h index c0fecc6b17..c3fe829f00 100644 --- a/src/modules/tls/tls_init.h +++ b/src/modules/tls/tls_init.h @@ -57,6 +57,7 @@ extern sr_tls_methods_t sr_tls_methods[]; #endif #define TLS_MODE_PTHREAD_LOCK_SHM (1) +#define TLS_MODE_FORK_PREPARE (1<<1) /* * just once, pre-initialize the tls subsystem diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index e41c7d7d0f..466e2fcdbb 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -412,6 +412,15 @@ static int mod_init(void) if(sr_tls_event_callback.s==NULL || sr_tls_event_callback.len<=0) { tls_lookup_event_routes(); } +#if OPENSSL_VERSION_NUMBER >= 0x010101000L + /* + * register the need to be called post-fork of all children + * with the special rank PROC_POSTCHILDINIT + */ + if(ksr_tls_init_mode&TLS_MODE_FORK_PREPARE) { + ksr_module_set_flag(KSRMOD_FLAG_POSTCHILDINIT); + } +#endif return 0; error: tls_h_mod_destroy_f(); @@ -423,6 +432,7 @@ static int mod_init(void) static int tls_engine_init(); int tls_fix_engine_keys(tls_domains_cfg_t*, tls_domain_t*, tls_domain_t*); #endif + static int mod_child(int rank) { if (tls_disable || (tls_domains_cfg==0)) @@ -440,7 +450,29 @@ static int mod_child(int rank) &mod_params, &mod_params) < 0) return -1; } +#if OPENSSL_VERSION_NUMBER >= 0x010101000L + if(ksr_tls_init_mode&TLS_MODE_FORK_PREPARE) { + OPENSSL_fork_prepare(); + } +#endif + return 0; + } + +#if OPENSSL_VERSION_NUMBER >= 0x010101000L + if(ksr_tls_init_mode&TLS_MODE_FORK_PREPARE) { + if(rank==PROC_POSTCHILDINIT) { + /* + * this is called after forking of all child processes + */ + OPENSSL_fork_parent(); + return 0; + } + if (!_ksr_is_main) { + OPENSSL_fork_child(); + } } +#endif + #ifndef OPENSSL_NO_ENGINE /* * after the child is fork()ed we go through the TLS domains [View Less]

1 0

[kamailio/kamailio] "kamdbctl create" creates the same user twice which fails (Issue #3280)
by Tommy Falgout 24 Jan '23

24 Jan '23

### Description When running kamdbctl for the first time with `DBENGINE=MYSQL` , it will try to create the same user twice which causes a failure. Because the user is already there, the create fails and the install script fails As a new user this is very confusing as it leads you to believe that you're blocked. However, if you enable prompt and run it twice and then skip adding access the second time, you can continue. ``` root@924dfe238957:/# /usr/sbin/kamdbctl create Create the database … [View More]'kamailio'? (y/n): y -e \E[37;33mINFO: creating database kamailio ... Create database users with access privileges? (y/n): y -e \E[37;33mINFO: granting privileges to database kamailio ... ERROR 1396 (HY000) at line 1: Operation CREATE USER failed for 'kamailio'@'mariadb' ERROR 1396 (HY000) at line 1: Operation CREATE USER failed for 'kamailioro'@'mariadb' ``` ### Troubleshooting If you modify `./usr/lib/x86_64-linux-gnu/kamailio/kamctl/kamdbctl.mysql` to echo the command instead, then you get the following debugging info. ``` root@924dfe238957:/# /usr/sbin/kamdbctl create Create the database 'kamailio'? (y/n): y -e \E[37;33mINFO: creating database kamailio ... mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE DATABASE kamailio CHARACTER SET latin1; Create database users with access privileges? (y/n): y -e \E[37;33mINFO: granting privileges to database kamailio ... mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailio'@'mariadb' IDENTIFIED BY 'kamailiorw'; GRANT ALL PRIVILEGES ON kamailio.* TO 'kamailio'@'mariadb'; mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailioro'@'mariadb' IDENTIFIED BY 'kamailioro'; GRANT SELECT ON kamailio.* TO 'kamailioro'@'mariadb'; mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailio'@'localhost' IDENTIFIED BY 'kamailiorw'; GRANT ALL PRIVILEGES ON kamailio.* TO 'kamailio'@'localhost'; mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailioro'@'localhost' IDENTIFIED BY 'kamailioro'; GRANT SELECT ON kamailio.* TO 'kamailioro'@'localhost'; mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailio'@'mariadb' IDENTIFIED BY 'kamailiorw'; GRANT ALL PRIVILEGES ON kamailio.* TO 'kamailio'@'mariadb'; mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailioro'@'mariadb' IDENTIFIED BY 'kamailioro'; GRANT SELECT ON kamailio.* TO 'kamailioro'@'mariadb'; ``` As you can see ` 'kamailioro'@'mariadb'` and ` 'kamailioro'@'mariadb'` are added twice which creates a 1396 error. #### Reproduction ``` ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3280 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3280(a)github.com> [View Less]

4 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev