sr-dev

sr-dev@lists.kamailio.org

22 participants
45186 discussions

[kamailio/kamailio] dialog: set $rs when failed TCP send (#2867)
by sergey-safarov 26 Aug '22

26 Aug '22

### Description I use TCP transport to relay SIP messages. When Kamailio cannot connect to another server then Kamailio generates response `408 Request Timeout`. inside `event_route[dialog:failed]` route block I check error code `$rs` but this value is `null`. This happens because Kamailio does not able to relay SIP messages and is not able to receive responses. But `tm` module generates a response `408 Request Timeout` and will be fine to init `$rs` pseudo-variable using tm module response. ### Expected behavior `$rs` pseudo-variable contains `tm` module response when kamailio does not receive a response from another server. #### Actual observed behavior `$rs` pseudo-variable contains `null` value when kamailio does not receive a response from another server. To check you can use ``` event_route[dialog:failed] { $var(code_xxx) = $(rs{re.subst,/([0-9])[0-9]{2}/\1xx/}); xlog("L_INFO", "websocket|log|dialog failed $rs; $var(code_xxx)\n"); } ``` And relay SIP message to host that reachable. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2867

3 4

[kamailio/kamailio] Path MTU handling; implicit IPv4 assumption, suggested solution for IPv6 (Issue #3119)
by vanrein 26 Aug '22

26 Aug '22

### Description Larger SIP frames get dropped when sent over UDP and IPv6. The sending side has MTU 1500 and the receiving side has MTU 1492. This is an IPv6-only setup, so this is problematic. Also, pulling down the MTU of a general server for a tunneled peer would smear like an oil stain. The suggestion to fallback on TCP feels like a hack. ### Troubleshooting #### Reproduction Send a SIP message to a network interface with a lower MTU than the submitted frame size. #### Debugging Data None, transmission works fine. #### Log Messages None, transmission works fine. #### SIP Traffic Irrelevant. #### Code Investigation I explored the Kamailio source code for MTU handling. https://github.com/kamailio/kamailio/blob/81265e41b52cfda9a284233c93683522a… * This defaults to switching off the Don't Fragment bit on IPv4 frames, to allow them to be broken up downstream. * This should check for an IPv4 socket, because (at least) Linux has a separate symbolic value `IPV6_MTU_DISCOVER` * Note that IPv6 is never broken up by routers; they always return ICMPv6 message Packet Too Big * Note that IPv6 Path MTU discovery by the kernel is automatic only for connected UDP sockets * Since Kamailio uses unconnected UDP sockets, Path MTU issues cause packets to be dropped * Note that such packet drops depend on a somewhat dynamic SIP message size, causing random behaviour * I therefore suggest that Kamailio is lacking in some of its IPv6 logic https://github.com/kamailio/kamailio/blob/81265e41b52cfda9a284233c93683522a… * This enables the reporting of ICMP errors, including Path MTU but also other useful things like Host Not Found * This should check for an IPv4 socket, because (at least) Linux has a separate symbolic value `IPV6_RECVERR` * Note that the same behaviour is available on BSD, so it need not be specific to Linux * Note that handling errors is done with `recvmsg()` with a flag `MSG_ERRQUEUE`, which is not used in Kamailio * Note that the ancillary data from `recvmsg()` holds data to cleverly handle ICMP or ICMPv6 responses * I therefore suggest that Kamailio is lacking a fair chunk of its ICMP and ICMPv6 logic * I expect that this may bring efficiency gains due to faster closing of transactions ### Possible Solutions I have been thinking about ways to lower MTU values only for some peers. 1. Using connected sockets might work, possibly as an alternative when Path MTU problems arise. It might not scale however. 2. Every socket could have an extra sending socket set to a lower MTU. The use of `SO_REUSEADDR` seems to allow for that. 3. Before falling back on an extra socket, the desired MTU could be set. Alternatively, as for IPv6, an MTU of 1280 might be considered in many cases: - *If you can carry 6 out of 8 coffee mugs from the kitchen, you need to walk twice, and 4+4 is easier than 6+2* - Anything over the MTU splits into at least 2 frames - The headers added are 40 bytes IPv6 header and 8 bytes Fragment Extension Header - 2 frames can hold a single frame of 2*1280-40-8 = 2512 bytes - Up to 2512 bytes original MTU, breakup in 1280 byte frames will be fine - 3 frames are going to be useful for larger frames, then a similar style can be used - This might help to decide whether 1280 or a higher MTU is most desirable ### Additional Information ``` Kamailio 5.2.1 from Debian stable ``` * **Operating System**: ``` Linux Debian stable on kernel 4.19.0 ``` (I don't suppose it matters, this code has been around for ages. I used permalinks for stable reference). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3119 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3119(a)github.com>

3 12

[kamailio/kamailio] dispatcher: socket atribute usage for initial OPTIONS (#2853)
by sergey-safarov 26 Aug '22

26 Aug '22

### Description I use TCP sockets to relay calls to backend servers. Also, I have enabled `tcp_reuse_port` and enabled `socket` attribute in dispatcher settings. INVITE messages to backend servers are now properly send from port 5060. ### Expected behavior For all messages are used the same TCP socket and same source port for all messages (including OPTIONS). #### Actual observed behavior But initial OPTIONS (before the first call send) uses a random source port. ### Additional Information * **Kamailio Version** - output of `kamailio -v` used current c503d2bd31a580138a67f1d4a265ccde5791d271 with small customization. * **Operating System**: aarch64 ``` [root@sbc-a0 ~]# cat /etc/os-release NAME="CentOS Linux" VERSION="8" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="8" PLATFORM_ID="platform:el8" PRETTY_NAME="CentOS Linux 8" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:8" HOME_URL="https://centos.org/" BUG_REPORT_URL="https://bugs.centos.org/" CENTOS_MANTISBT_PROJECT="CentOS-8" CENTOS_MANTISBT_PROJECT_VERSION="8" ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2853

2 2

[kamailio/kamailio] dialog: set context iuid for CANCEL requests (PR #3096)
by descartin 26 Aug '22

26 Aug '22

set context iuid for CANCEL requests to let isflagset function return the right value in case a dialog flag was previously set on the call   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Using kamailio 5.4 version, we have seen that dlg_isflagset is not detecting a dialog flag set in the request route for the initial INVITE, when a CANCEL request arrives. We have applied this change to set the dialog context unique ide for this request. Since it's done on dlg_onreply, dlg_onroute and dlg_ontimeout functions. This way, dlg_get_by_iuid(&dctx->iuid) in the function ki_dlg_isflagset is not NULL and dialog flags are detected. Is this change correct? Or can it generate any kind of issues? thanks a lot and regards David You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3096 -- Commit Summary -- * dialog: set context iuid for CANCEL requests to let isflagset function return the right value in case a dialog flag was previously set on the call -- File Changes -- M src/modules/dialog/dlg_handlers.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3096.patch https://github.com/kamailio/kamailio/pull/3096.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3096 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3096(a)github.com>

3 6

git:master:c5d48f8e: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 26 Aug '22

26 Aug '22

Module: kamailio Branch: master Commit: c5d48f8ee3884934bd8b910a2dae1888fead3cf1 URL: https://github.com/kamailio/kamailio/commit/c5d48f8ee3884934bd8b910a2dae188… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-08-26T12:16:27+02:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/c5d48f8ee3884934bd8b910a2dae188… Patch: https://github.com/kamailio/kamailio/commit/c5d48f8ee3884934bd8b910a2dae188…

1 0

git:master:353aa1c8: dialog: docs for dlg_ctxiuid_mode params
by Daniel-Constantin Mierla 26 Aug '22

26 Aug '22

Module: kamailio Branch: master Commit: 353aa1c821f2889c0a6dbadf9b1b1c1ed039deb6 URL: https://github.com/kamailio/kamailio/commit/353aa1c821f2889c0a6dbadf9b1b1c1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-26T12:11:08+02:00 dialog: docs for dlg_ctxiuid_mode params --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/353aa1c821f2889c0a6dbadf9b1b1c1… Patch: https://github.com/kamailio/kamailio/commit/353aa1c821f2889c0a6dbadf9b1b1c1… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index 00c1d4f9775..162ad965331 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -1707,6 +1707,32 @@ modparam("dialog", "bye_early_reason", "Call terminated") </example> </section> + <section id="dialog.p.dlg_ctxiuid_mode"> + <title><varname>dlg_ctxiuid_mode</varname> (int)</title> + <para> + Set dialog context iuid mode, which can specify additional cases + when the internal unique id should be set: + </para> + <itemizedlist> + <listitem><para> + <emphasis>1</emphasis> - set it when processing CANCEL requests. + </para></listitem> + </itemizedlist> + <para> + <emphasis> + Default value is <quote>0</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>dlg_ctxiuid_mode</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dialog", "dlg_ctxiuid_mode", 1) +... +</programlisting> + </example> + </section> + </section> <section>

1 0

git:master:02b960d8: core: parse - added IS_SIP_MSG() macro to check if message type is SIP
by Daniel-Constantin Mierla 26 Aug '22

26 Aug '22

Module: kamailio Branch: master Commit: 02b960d84d479b001cf94b2b53063deca1d7256d URL: https://github.com/kamailio/kamailio/commit/02b960d84d479b001cf94b2b53063de… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-26T10:15:22+02:00 core: parse - added IS_SIP_MSG() macro to check if message type is SIP - defined also IS_SIP_REQUEST() same as IS_SIP() but with more explicit name for detecting SIP requests --- Modified: src/core/parser/msg_parser.h --- Diff: https://github.com/kamailio/kamailio/commit/02b960d84d479b001cf94b2b53063de… Patch: https://github.com/kamailio/kamailio/commit/02b960d84d479b001cf94b2b53063de… --- diff --git a/src/core/parser/msg_parser.h b/src/core/parser/msg_parser.h index 8b44ce4159..595c1be895 100644 --- a/src/core/parser/msg_parser.h +++ b/src/core/parser/msg_parser.h @@ -147,11 +147,20 @@ if ( (*tmp==(firstchar) || *tmp==((firstchar) | 32)) && \ (((req)->first_line.type == SIP_REQUEST) && \ ((req)->first_line.flags & FLINE_FLAG_PROTO_SIP)) +/* sip request */ +#define IS_SIP_REQUEST(req) \ + (((req)->first_line.type == SIP_REQUEST) && \ + ((req)->first_line.flags & FLINE_FLAG_PROTO_SIP)) + /* sip reply */ #define IS_SIP_REPLY(rpl) \ (((rpl)->first_line.type == SIP_REPLY) && \ ((rpl)->first_line.flags & FLINE_FLAG_PROTO_SIP)) +/* sip message */ +#define IS_SIP_MSG(req) \ + ((req)->first_line.flags & FLINE_FLAG_PROTO_SIP) + /* http request */ #define IS_HTTP(req) \ (((req)->first_line.type == SIP_REQUEST) && \

1 0

git:master:d7e8ae72: core: dprint - simplified sip msg check
by Daniel-Constantin Mierla 26 Aug '22

26 Aug '22

Module: kamailio Branch: master Commit: d7e8ae72a0258aa6c3bcf850ea410a929da003cb URL: https://github.com/kamailio/kamailio/commit/d7e8ae72a0258aa6c3bcf850ea410a9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-26T10:15:58+02:00 core: dprint - simplified sip msg check --- Modified: src/core/dprint.c --- Diff: https://github.com/kamailio/kamailio/commit/d7e8ae72a0258aa6c3bcf850ea410a9… Patch: https://github.com/kamailio/kamailio/commit/d7e8ae72a0258aa6c3bcf850ea410a9… --- diff --git a/src/core/dprint.c b/src/core/dprint.c index f4780bb4d4..ff63fd9ff1 100644 --- a/src/core/dprint.c +++ b/src/core/dprint.c @@ -504,7 +504,7 @@ void log_prefix_set(sip_msg_t *msg) log_callid_set(msg); if(log_prefix_pvs == NULL) return; - if(msg==NULL || !(IS_SIP(msg) || IS_SIP_REPLY(msg))) { + if(msg==NULL || !IS_SIP_MSG(msg)) { log_prefix_val = NULL; return; }

1 0

git:master:a770c495: dialog: added modparam dlg_ctxiuid_mode to control when iuid is set
by Daniel-Constantin Mierla 26 Aug '22

26 Aug '22

Module: kamailio Branch: master Commit: a770c4957a31c143a29c68cb71e705c3f9cfcbad URL: https://github.com/kamailio/kamailio/commit/a770c4957a31c143a29c68cb71e705c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-26T11:24:30+02:00 dialog: added modparam dlg_ctxiuid_mode to control when iuid is set --- Modified: src/modules/dialog/dialog.c Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/a770c4957a31c143a29c68cb71e705c… Patch: https://github.com/kamailio/kamailio/commit/a770c4957a31c143a29c68cb71e705c… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 8eb9f78eec..83a10b3b56 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -154,6 +154,7 @@ str dlg_xavp_cfg = {0}; int dlg_ka_timer = 0; int dlg_ka_interval = 0; int dlg_clean_timer = 90; +int dlg_ctxiuid_mode = 0; str dlg_lreq_callee_headers = {0}; @@ -361,6 +362,8 @@ static param_export_t mod_params[]={ { "dlg_filter_mode", INT_PARAM, &dlg_filter_mode }, { "bye_early_code", PARAM_INT, &bye_early_code }, { "bye_early_reason", PARAM_STR, &bye_early_reason }, + { "dlg_ctxiuid_mode", PARAM_INT, &dlg_ctxiuid_mode }, + { 0,0,0 } }; diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 794aa7c7d2..81525de21b 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -72,6 +72,7 @@ extern int dlg_event_rt[DLG_EVENTRT_MAX]; extern int dlg_wait_ack; extern int dlg_enable_dmq; extern int dlg_filter_mode; +extern int dlg_ctxiuid_mode; int spiral_detected = -1; extern struct rr_binds d_rrb; /*!< binding to record-routing module */ @@ -91,6 +92,9 @@ static unsigned int CURR_DLG_ID = 0xffffffff; /*!< current dialog id */ /*! separator inside the record-route paramter */ #define DLG_SEPARATOR '.' +/*! flags for dlg_ctxiuid */ +#define DLG_CTXIUID_MODE_CANCEL 1 + int dlg_set_tm_callbacks(tm_cell_t *t, sip_msg_t *req, dlg_cell_t *dlg, int mode); int dlg_set_tm_waitack(tm_cell_t *t, dlg_cell_t *dlg); @@ -1258,9 +1262,10 @@ dlg_cell_t *dlg_lookup_msg_dialog(sip_msg_t *msg, unsigned int *dir) msg->callid->body.len, msg->callid->body.s); return NULL; } - if(msg->first_line.u.request.method_value == METHOD_CANCEL) { - dlg_set_ctx_iuid(dlg); - } + if((dlg_ctxiuid_mode & DLG_CTXIUID_MODE_CANCEL) && IS_SIP_REQUEST(msg) + && (msg->first_line.u.request.method_value == METHOD_CANCEL)) { + dlg_set_ctx_iuid(dlg); + } if(dir) *dir = vdir; return dlg; }

1 0

git:master:654f22a0: dialog: set context iuid for CANCEL requests to let isflagset function return the right value in case a dialog flag was previously set on the call
by Daniel-Constantin Mierla 26 Aug '22

26 Aug '22

Module: kamailio Branch: master Commit: 654f22a03e874f86c4b2b2d29eb969a1be3bb25e URL: https://github.com/kamailio/kamailio/commit/654f22a03e874f86c4b2b2d29eb969a… Author: David Escartin <descartin(a)sonoc.io> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-26T09:49:42+02:00 dialog: set context iuid for CANCEL requests to let isflagset function return the right value in case a dialog flag was previously set on the call --- Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/654f22a03e874f86c4b2b2d29eb969a… Patch: https://github.com/kamailio/kamailio/commit/654f22a03e874f86c4b2b2d29eb969a… --- diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 39f1f83dd7..794aa7c7d2 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -1258,6 +1258,9 @@ dlg_cell_t *dlg_lookup_msg_dialog(sip_msg_t *msg, unsigned int *dir) msg->callid->body.len, msg->callid->body.s); return NULL; } + if(msg->first_line.u.request.method_value == METHOD_CANCEL) { + dlg_set_ctx_iuid(dlg); + } if(dir) *dir = vdir; return dlg; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev