sr-dev

sr-dev@lists.kamailio.org

21 participants
45185 discussions

git:5.6:f1bd6bb8: nathelper: docs - rephrased the remarks about set_contact_alias()
by Daniel-Constantin Mierla 16 Aug '22

16 Aug '22

Module: kamailio Branch: 5.6 Commit: f1bd6bb8dec9db76acf697a7b1d177a2bfcfd7c1 URL: https://github.com/kamailio/kamailio/commit/f1bd6bb8dec9db76acf697a7b1d177a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-16T11:58:14+02:00 nathelper: docs - rephrased the remarks about set_contact_alias() (cherry picked from commit c009f27578e8df9aa77ab852325dad8dc710d6c8) --- Modified: src/modules/nathelper/doc/nathelper_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/f1bd6bb8dec9db76acf697a7b1d177a… Patch: https://github.com/kamailio/kamailio/commit/f1bd6bb8dec9db76acf697a7b1d177a… --- diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml index d0e8a18ea4c..a8828baa74f 100644 --- a/src/modules/nathelper/doc/nathelper_admin.xml +++ b/src/modules/nathelper/doc/nathelper_admin.xml @@ -878,8 +878,10 @@ if(is_rfc1918("$rd")) { <para> Adds an <quote>;alias=ip~port~transport</quote> parameter to the contact URI containing the received ip, port, and transport protocol. - The new contact URI is immediately visible to other modules in the - way the <function>fix_nated_contact()</function> does it. + The update of contact URI is signaled to a few other modules in the + way the <function>fix_nated_contact()</function> does it by using the + internal flags. The new value is not visible to pseudo-variables and it + does not change the SIP message buffer. </para> <para>Meaning of parameters:</para> <itemizedlist>

1 0

git:5.6:ca1e61ec: core: use memcpy and set end of string
by Daniel-Constantin Mierla 16 Aug '22

16 Aug '22

Module: kamailio Branch: 5.6 Commit: ca1e61ec0453b9a4797ac7af88ac179d27e53685 URL: https://github.com/kamailio/kamailio/commit/ca1e61ec0453b9a4797ac7af88ac179… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-16T11:54:38+02:00 core: use memcpy and set end of string (cherry picked from commit 5cd4e817a24308b82fc3f631fb18f354dadf2b7e) --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/ca1e61ec0453b9a4797ac7af88ac179… Patch: https://github.com/kamailio/kamailio/commit/ca1e61ec0453b9a4797ac7af88ac179… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index c9dd89118d8..e3ae29bc147 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1502,7 +1502,8 @@ static int build_iface_list(void) } if(strlen(ifaces[index].name)==0 && strlen(name)>0) { - strncpy(ifaces[index].name, name, MAX_IF_LEN-1); + memcpy(ifaces[index].name, name, MAX_IF_LEN-1); + ifaces[index].name[MAX_IF_LEN-1] = '\0'; } ifaces[index].index = index;

1 0

git:master:1e4bf1dd: msrp: proper cmap insert when last item has greater citemid
by Daniel-Constantin Mierla 16 Aug '22

16 Aug '22

Module: kamailio Branch: master Commit: 1e4bf1dd7fbfc9d51f0e56e98472a42de781cdbd URL: https://github.com/kamailio/kamailio/commit/1e4bf1dd7fbfc9d51f0e56e98472a42… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-16T09:09:45+02:00 msrp: proper cmap insert when last item has greater citemid - condition for last item was processed first, resulting in improper order of items, GH #3215 --- Modified: src/modules/msrp/msrp_cmap.c --- Diff: https://github.com/kamailio/kamailio/commit/1e4bf1dd7fbfc9d51f0e56e98472a42… Patch: https://github.com/kamailio/kamailio/commit/1e4bf1dd7fbfc9d51f0e56e98472a42… --- diff --git a/src/modules/msrp/msrp_cmap.c b/src/modules/msrp/msrp_cmap.c index 9764c0903f5..2fc6a8d740b 100644 --- a/src/modules/msrp/msrp_cmap.c +++ b/src/modules/msrp/msrp_cmap.c @@ -270,20 +270,21 @@ int msrp_cmap_save(msrp_frame_t *mf) } else { for(itb=_msrp_cmap_head->cslots[idx].first; itb; itb=itb->next) { - if(itb->citemid>it->citemid || itb->next==NULL) { - if(itb->next==NULL) { - itb->next=it; - it->prev = itb; + if(itb->citemid>it->citemid) { + /* insert before current item */ + it->next = itb; + if(itb->prev==NULL) { + _msrp_cmap_head->cslots[idx].first = it; } else { - it->next = itb; - if(itb->prev==NULL) { - _msrp_cmap_head->cslots[idx].first = it; - } else { - itb->prev->next = it; - } - it->prev = itb->prev; - itb->prev = it; + itb->prev->next = it; } + it->prev = itb->prev; + itb->prev = it; + break; + } else if(itb->next==NULL) { + /* insert after last item */ + itb->next=it; + it->prev = itb; break; } }

1 0

git:master:f1dcb649: modules: readme files regenerated - secfilter ... [skip ci]
by Kamailio Dev 15 Aug '22

15 Aug '22

Module: kamailio Branch: master Commit: f1dcb649cb779b2ccd14d18cad441d29653ffabd URL: https://github.com/kamailio/kamailio/commit/f1dcb649cb779b2ccd14d18cad441d2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-08-15T20:46:09+02:00 modules: readme files regenerated - secfilter ... [skip ci] --- Modified: src/modules/secfilter/README --- Diff: https://github.com/kamailio/kamailio/commit/f1dcb649cb779b2ccd14d18cad441d2… Patch: https://github.com/kamailio/kamailio/commit/f1dcb649cb779b2ccd14d18cad441d2… --- diff --git a/src/modules/secfilter/README b/src/modules/secfilter/README index 435db783fa..345b639e91 100644 --- a/src/modules/secfilter/README +++ b/src/modules/secfilter/README @@ -661,8 +661,6 @@ d in the user-agent header ($ua)"); Example 1.24. kamcmd secfilter.print ua ... -User-agent -========== { User-Agent: { Blacklisted: {

1 0

[kamailio/kamailio] Pepelux/secfilter (PR #3217)
by Jose Luis Verdeguer 15 Aug '22

15 Aug '22

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Fixed an error in an example in the docfile You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3217 -- Commit Summary -- * secfilter: machine-parsable data structure for RPC printing data * secfilter: updated samples [skip ci] * secfilter: fix examples [skip ci] -- File Changes -- M src/modules/secfilter/doc/secfilter_admin.xml (121) M src/modules/secfilter/secfilter_rpc.c (383) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3217.patch https://github.com/kamailio/kamailio/pull/3217.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3217 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3217(a)github.com>

1 1

git:master:8f30f438: secfilter: fix examples [skip ci]
by Jose Luis Verdeguer 15 Aug '22

15 Aug '22

Module: kamailio Branch: master Commit: 8f30f438f9ba6ab9a2d7bde1cfa4d186e2fe0d6f URL: https://github.com/kamailio/kamailio/commit/8f30f438f9ba6ab9a2d7bde1cfa4d18… Author: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2022-08-15T20:33:29+02:00 secfilter: fix examples [skip ci] --- Modified: src/modules/secfilter/doc/secfilter_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/8f30f438f9ba6ab9a2d7bde1cfa4d18… Patch: https://github.com/kamailio/kamailio/commit/8f30f438f9ba6ab9a2d7bde1cfa4d18… --- diff --git a/src/modules/secfilter/doc/secfilter_admin.xml b/src/modules/secfilter/doc/secfilter_admin.xml index 9daa67d952..fff4ca3b2c 100644 --- a/src/modules/secfilter/doc/secfilter_admin.xml +++ b/src/modules/secfilter/doc/secfilter_admin.xml @@ -812,8 +812,6 @@ <programlisting format="linespecific"> ... -User-agent -========== { User-Agent: { Blacklisted: {

1 0

git:master:252562b8: modules: readme files regenerated - xhttp ... [skip ci]
by Kamailio Dev 15 Aug '22

15 Aug '22

Module: kamailio Branch: master Commit: 252562b8fce76cb01cde993b530509e89baae95a URL: https://github.com/kamailio/kamailio/commit/252562b8fce76cb01cde993b530509e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-08-15T20:31:14+02:00 modules: readme files regenerated - xhttp ... [skip ci] --- Modified: src/modules/xhttp/README --- Diff: https://github.com/kamailio/kamailio/commit/252562b8fce76cb01cde993b530509e… Patch: https://github.com/kamailio/kamailio/commit/252562b8fce76cb01cde993b530509e… --- diff --git a/src/modules/xhttp/README b/src/modules/xhttp/README index 781ac41392..9a59c839aa 100644 --- a/src/modules/xhttp/README +++ b/src/modules/xhttp/README @@ -131,11 +131,15 @@ Chapter 1. Admin Guide 3.2. Kamailio Core Settings - SIP requires a Content-Length header for TCP transport. But most HTTP - clients do not set the content length for normal GET requests. - Therefore, the core must be configured to allow incoming requests - without content length header: - * tcp_accept_no_cl=yes + Related core settings: + * tcp_accept_no_cl=yes - SIP requires the Content-Length header for + TCP transport. But most HTTP clients do not set the content length + for normal GET requests. Therefore, the core must be configured to + allow incoming requests without content length header. + * http_reply_parse=yes - various Kamailio modules may parse what it + is sent out (e.g., for replication, topology management). In such + case errors are printed if the outgoing message is not SIP and this + parameter is not set. 3.3. External Libraries or Applications

1 0

git:master:36b0da00: xhttp: docs - listed http_reply_parse core setting
by Daniel-Constantin Mierla 15 Aug '22

15 Aug '22

Module: kamailio Branch: master Commit: 36b0da00b9fc08be9e855d5dd4cc878b6e3c88bf URL: https://github.com/kamailio/kamailio/commit/36b0da00b9fc08be9e855d5dd4cc878… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-15T20:18:02+02:00 xhttp: docs - listed http_reply_parse core setting --- Modified: src/modules/xhttp/doc/xhttp_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/36b0da00b9fc08be9e855d5dd4cc878… Patch: https://github.com/kamailio/kamailio/commit/36b0da00b9fc08be9e855d5dd4cc878… --- diff --git a/src/modules/xhttp/doc/xhttp_admin.xml b/src/modules/xhttp/doc/xhttp_admin.xml index 507283b90f4..f0e6d3fdeb8 100644 --- a/src/modules/xhttp/doc/xhttp_admin.xml +++ b/src/modules/xhttp/doc/xhttp_admin.xml @@ -85,13 +85,23 @@ <section> <title>&kamailio; Core Settings</title> <para> - SIP requires a Content-Length header for TCP transport. But most HTTP clients do not - set the content length for normal GET requests. Therefore, the core must be configured - to allow incoming requests without content length header: + Related core settings: <itemizedlist> <listitem> <para> - <emphasis>tcp_accept_no_cl=yes</emphasis> + <emphasis>tcp_accept_no_cl=yes</emphasis> - SIP requires the + Content-Length header for TCP transport. But most HTTP clients + do not set the content length for normal GET requests. Therefore, + the core must be configured to allow incoming requests without + content length header. + </para> + </listitem> + <listitem> + <para> + <emphasis>http_reply_parse=yes</emphasis> - various Kamailio + modules may parse what it is sent out (e.g., for replication, + topology management). In such case errors are printed if the + outgoing message is not SIP and this parameter is not set. </para> </listitem> </itemizedlist>

1 0

db_postgres / DB1_BLOB / sipcapture HOMER issue
by Daniel Pocock 15 Aug '22

15 Aug '22

Hi all, I was doing some tests with HOMER and a PostgreSQL backend The HOMER schema creates the msg column as varchar(1500) CREATE TABLE IF NOT EXISTS rtcp_capture ( id BIGSERIAL NOT NULL, date timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, micro_ts bigint NOT NULL DEFAULT '0', correlation_id varchar(256) NOT NULL DEFAULT '', source_ip varchar(60) NOT NULL DEFAULT '', source_port integer NOT NULL DEFAULT 0, destination_ip varchar(60) NOT NULL DEFAULT '', destination_port integer NOT NULL DEFAULT 0, proto integer NOT NULL DEFAULT 0, family smallint DEFAULT NULL, type integer NOT NULL DEFAULT 0, node varchar(125) NOT NULL DEFAULT '', msg varchar(1500) NOT NULL DEFAULT '', PRIMARY KEY (id,date) ); The sipcapture.c source code says that msg is DB1_BLOB https://github.com/kamailio/kamailio/blob/master/src/modules/sipcapture/sip… db_keys[11] = &msg_column; db_vals[11].type = DB1_BLOB; db_vals[11].nul = 0; When the Kamailio PostgreSQL module db_postgres tries to store DB1_BLOB, it converts the message text into a hex string and stores that string like this: '0x7b2273656e6465725f696e666f726d6174696f6e223a7b226e74705f74696d657374616d705f736563223a3338333033312c226e74705f74696d657374616d705f75736563223a32333237332c226f6374657473223a3136343030302c227274705f74696d657374616d70223a323132353238323231342c227061636b657473223a313032357d2c2273737263223a323330343334323235382c2274797065223a3230302c227265706f72745f626c6f636b73223a5b7b22736f757263655f73737263223a333737363636373030392c22686967686573745f7365715f6e6f223a31363739332c226672616374696f6e5f6c6f7374223a302c2269615f6a6974746572223a31372c227061636b6574735f6c6f7374223a302c226c7372223a3837363937393735352c22646c7372223a35303234397d5d2c227265706f72745f636f756e74223a317d' I tried changing the msg column type to bytea (blob) and Kamailio is still doing the same thing, storing a hex string into the column. Then I changed the column back to varchar(1500) and I modified sipcapture.c to use DB1_STR. With this change it is working OK. However, I suspect that the support for DB1_BLOB conversions may need to be reviewed in src/modules/db_postgres/km_val.c Regards, Daniel -- https://danielpocock.com Follow with RSS: https://danielpocock.com/rss.xml

3 2

[kamailio/kamailio] [stirshaken] add identity header in reply messages or to a separate variable (#2770)
by sergei lavrov 14 Aug '22

14 Aug '22

### Description I'm unable to add the generated `Identity` value to reply message when `kamailio` acts as a redirect server and replies with `302 Moved Temporarily` instead of relaying `INVITE`. This code doesn't work, i.e. no `Identity` header in `302 Moved Temporarily` message: ``` if (stirshaken_add_identity($var(x5u), $var(attest), $var(origtn_val), $var(desttn_val), $var(origid)) == 1) { append_branch("sip:$rU@127.0.0.1:6060"); sl_send_reply("302", "Moved Temporarily"); exit; } ``` ### Expected behavior It would be nice if the `stirshaken_add_identity_*` functions would add the generated `Identity` header to the reply messages too, or store the generated `Identity` header in a separate variable, like `$identity`, for the future processing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2770

4 10

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev