sr-dev

sr-dev@lists.kamailio.org

22 participants
45186 discussions

git:master:89495b85: db_redis: free db vals on error
by Daniel-Constantin Mierla 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: 89495b8595d37f4d24e10e5ed1177614b2979d82 URL: https://github.com/kamailio/kamailio/commit/89495b8595d37f4d24e10e5ed117761… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T14:09:13+02:00 db_redis: free db vals on error --- Modified: src/modules/db_redis/redis_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/89495b8595d37f4d24e10e5ed117761… Patch: https://github.com/kamailio/kamailio/commit/89495b8595d37f4d24e10e5ed117761… --- diff --git a/src/modules/db_redis/redis_dbase.c b/src/modules/db_redis/redis_dbase.c index 68536816a8..254e0f6b3e 100644 --- a/src/modules/db_redis/redis_dbase.c +++ b/src/modules/db_redis/redis_dbase.c @@ -2164,6 +2164,8 @@ static int db_redis_perform_update(const db1_con_t* _h, km_redis_con_t *con, con if (db_redis_build_type_keys(con, CON_TABLE(_h), db_keys, db_vals, all_type_keys_count, &type_keys, &set_keys, &type_keys_count) != 0) { LM_ERR("failed to build type keys\n"); + pkg_free(db_vals); + db_vals = NULL; goto error; } pkg_free(db_keys); @@ -2306,7 +2308,7 @@ static int db_redis_perform_update(const db1_con_t* _h, km_redis_con_t *con, con if (scard != 0) continue; - + if (db_redis_key_add_string(&query_v, "SREM", 4) != 0) { LM_ERR("Failed to add srem command to post-delete query\n"); goto error;

1 0

git:master:eba6c7d7: presence_xml: free uri for http xcap auth
by Daniel-Constantin Mierla 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: eba6c7d78088cde411f5cd1b7730ba458e62a69e URL: https://github.com/kamailio/kamailio/commit/eba6c7d78088cde411f5cd1b7730ba4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T14:03:55+02:00 presence_xml: free uri for http xcap auth --- Modified: src/modules/presence_xml/xcap_auth.c --- Diff: https://github.com/kamailio/kamailio/commit/eba6c7d78088cde411f5cd1b7730ba4… Patch: https://github.com/kamailio/kamailio/commit/eba6c7d78088cde411f5cd1b7730ba4… --- diff --git a/src/modules/presence_xml/xcap_auth.c b/src/modules/presence_xml/xcap_auth.c index 0cf0669ca1..c40f0a899e 100644 --- a/src/modules/presence_xml/xcap_auth.c +++ b/src/modules/presence_xml/xcap_auth.c @@ -521,7 +521,7 @@ int get_rules_doc( int http_get_rules_doc(str user, str domain, str *rules_doc) { - str uri; + str uri = STR_NULL; xcap_doc_sel_t doc_sel; char *doc = NULL; xcap_serv_t *xs; @@ -559,6 +559,8 @@ int http_get_rules_doc(str user, str domain, str *rules_doc) rules_doc->s = doc; rules_doc->len = doc ? strlen(doc) : 0; + pkg_free(uri.s); + return 0; error:

1 0

git:master:33921b79: cfgt: free dest.s before return on error
by Daniel-Constantin Mierla 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: 33921b79a4f5849f85a588332fe8debfb4d27c0e URL: https://github.com/kamailio/kamailio/commit/33921b79a4f5849f85a588332fe8deb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T13:42:21+02:00 cfgt: free dest.s before return on error --- Modified: src/modules/cfgt/cfgt_int.c --- Diff: https://github.com/kamailio/kamailio/commit/33921b79a4f5849f85a588332fe8deb… Patch: https://github.com/kamailio/kamailio/commit/33921b79a4f5849f85a588332fe8deb… --- diff --git a/src/modules/cfgt/cfgt_int.c b/src/modules/cfgt/cfgt_int.c index b8345b4565..489fdfe445 100644 --- a/src/modules/cfgt/cfgt_int.c +++ b/src/modules/cfgt/cfgt_int.c @@ -394,6 +394,7 @@ void cfgt_save_node(cfgt_node_p node) LM_DBG("dir [%s] already exists\n", dest.s); } else if(mkdir(dest.s, S_IRWXO | S_IXGRP | S_IRWXU) < 0) { LM_ERR("failed to make directory: %s\n", strerror(errno)); + pkg_free(dest.s); return; } dest.s[dir] = '/';

1 0

git:master:cacae7fc: sms: use unsigned int for bit shifting for compiler warnings
by Daniel-Constantin Mierla 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: cacae7fc5db5418a67d543995273280d57f027c6 URL: https://github.com/kamailio/kamailio/commit/cacae7fc5db5418a67d543995273280… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T13:31:41+02:00 sms: use unsigned int for bit shifting for compiler warnings --- Modified: src/modules/sms/libsms_getsms.c --- Diff: https://github.com/kamailio/kamailio/commit/cacae7fc5db5418a67d543995273280… Patch: https://github.com/kamailio/kamailio/commit/cacae7fc5db5418a67d543995273280… --- diff --git a/src/modules/sms/libsms_getsms.c b/src/modules/sms/libsms_getsms.c index e8c7590456..a98cfd80d8 100644 --- a/src/modules/sms/libsms_getsms.c +++ b/src/modules/sms/libsms_getsms.c @@ -55,7 +55,7 @@ mailto:s.frings@mail.isis.de /* converts an octet to a 8-Bit value */ static inline int octet2bin(char* octet) { - int result=0; + unsigned int result=0; if (octet[0]>57) result=octet[0]-55; @@ -66,7 +66,7 @@ static inline int octet2bin(char* octet) result+=octet[1]-55; else result+=octet[1]-48; - return result; + return (int)result; }

1 0

git:master:9fd0cae9: lrkproxy: init value for compiler warning
by Daniel-Constantin Mierla 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: 9fd0cae960b0795a5e511c37f768f0962b7a15c1 URL: https://github.com/kamailio/kamailio/commit/9fd0cae960b0795a5e511c37f768f09… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T13:10:23+02:00 lrkproxy: init value for compiler warning --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/9fd0cae960b0795a5e511c37f768f09… Patch: https://github.com/kamailio/kamailio/commit/9fd0cae960b0795a5e511c37f768f09… --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index e30f4e976b..157048c350 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -1284,7 +1284,7 @@ static int change_media_sdp(sip_msg_t *msg, struct lrkproxy_hash_entry *e, const e->snat_ipv4.len = strlen(e->snat_ipv4.s); str current_port; - unsigned int snat_port; + unsigned int snat_port = 0; str2int(&e->dst_port, &snat_port);

1 0

git:master:cfb50124: xcap_client: init structure
by Daniel-Constantin Mierla 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: cfb50124e67b68552520e418a20ad2dfec96117b URL: https://github.com/kamailio/kamailio/commit/cfb50124e67b68552520e418a20ad2d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T13:04:37+02:00 xcap_client: init structure --- Modified: src/modules/xcap_client/xcap_client.c --- Diff: https://github.com/kamailio/kamailio/commit/cfb50124e67b68552520e418a20ad2d… Patch: https://github.com/kamailio/kamailio/commit/cfb50124e67b68552520e418a20ad2d… --- diff --git a/src/modules/xcap_client/xcap_client.c b/src/modules/xcap_client/xcap_client.c index 607628dbb4..efd434c2ab 100644 --- a/src/modules/xcap_client/xcap_client.c +++ b/src/modules/xcap_client/xcap_client.c @@ -309,6 +309,7 @@ int parse_doc_url(str doc_url, char** serv_addr, xcap_doc_sel_t* doc_sel) { char* sl, *str_type; + memset(doc_sel, 0, sizeof(xcap_doc_sel_t)); sl= strchr(doc_url.s, '/'); if(sl==NULL) { return -1;

1 0

git:master:b5aae4f5: rls: safety check for dialog structur
by Daniel-Constantin Mierla 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: b5aae4f5afd07db114c3ff7712b484f743663b26 URL: https://github.com/kamailio/kamailio/commit/b5aae4f5afd07db114c3ff7712b484f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T12:15:12+02:00 rls: safety check for dialog structur --- Modified: src/modules/rls/resource_notify.c --- Diff: https://github.com/kamailio/kamailio/commit/b5aae4f5afd07db114c3ff7712b484f… Patch: https://github.com/kamailio/kamailio/commit/b5aae4f5afd07db114c3ff7712b484f… --- diff --git a/src/modules/rls/resource_notify.c b/src/modules/rls/resource_notify.c index d3ad4fd1fc..0343a5c665 100644 --- a/src/modules/rls/resource_notify.c +++ b/src/modules/rls/resource_notify.c @@ -420,8 +420,9 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, if(rlmi_doc) { - LM_DBG("timer_send_notify at end len_est = %d resource_added = %d\n", len_est, resource_added); - if (resource_added == 1) + LM_DBG("timer notify at end len_est = %d resource_added = %d dlg = %p\n", + len_est, resource_added, dialog); + if (resource_added == 1 && dialog != NULL) { send_notify(&rlmi_doc, buf, buf_len, bstr, dialog, hash_code); }

1 0

git:master:f6620aa5: pkg/kamailio/deb: set version 5.6.0~pre1
by Victor Seva 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: f6620aa5fe7ef65ddd7fa232829ea9cfb3f0f774 URL: https://github.com/kamailio/kamailio/commit/f6620aa5fe7ef65ddd7fa232829ea9c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-28T09:46:31+02:00 pkg/kamailio/deb: set version 5.6.0~pre1 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/f6620aa5fe7ef65ddd7fa232829ea9c… Patch: https://github.com/kamailio/kamailio/commit/f6620aa5fe7ef65ddd7fa232829ea9c…

1 0

git:master:67da7301: topos: catch INFO requests during early dialog phase
by Daniel-Constantin Mierla 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: 67da7301f1eb74b6fff9e6e73b43f08dbc9c53bf URL: https://github.com/kamailio/kamailio/commit/67da7301f1eb74b6fff9e6e73b43f08… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T09:36:09+02:00 topos: catch INFO requests during early dialog phase --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/67da7301f1eb74b6fff9e6e73b43f08… Patch: https://github.com/kamailio/kamailio/commit/67da7301f1eb74b6fff9e6e73b43f08… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index cd781328e5..83d5f5fddf 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -837,7 +837,7 @@ int tps_request_received(sip_msg_t *msg, int dialog) goto error; } metid = get_cseq(msg)->method_id; - if((metid & (METHOD_BYE|METHOD_PRACK|METHOD_UPDATE)) + if((metid & (METHOD_BYE|METHOD_INFO|METHOD_PRACK|METHOD_UPDATE)) && stsd.b_contact.len <= 0) { /* no B-side contact, look for INVITE transaction record */ if(metid & (METHOD_BYE|METHOD_UPDATE)) {

1 0

git:master:dc2ef8ed: async: proper pv function name
by Daniel-Constantin Mierla 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: dc2ef8edaacb6947019cbde0a4c3ca238bee56c2 URL: https://github.com/kamailio/kamailio/commit/dc2ef8edaacb6947019cbde0a4c3ca2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T09:20:08+02:00 async: proper pv function name --- Modified: src/modules/async/async_sleep.c --- Diff: https://github.com/kamailio/kamailio/commit/dc2ef8edaacb6947019cbde0a4c3ca2… Patch: https://github.com/kamailio/kamailio/commit/dc2ef8edaacb6947019cbde0a4c3ca2… --- diff --git a/src/modules/async/async_sleep.c b/src/modules/async/async_sleep.c index b51887e351..02c3b8d488 100644 --- a/src/modules/async/async_sleep.c +++ b/src/modules/async/async_sleep.c @@ -649,7 +649,7 @@ int pv_get_async(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) /** * */ -int pv_parse_geoip_name(pv_spec_t *sp, str *in) +int pv_parse_async_name(pv_spec_t *sp, str *in) { if(sp==NULL || in==NULL || in->len<=0) return -1;

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev