sr-dev

sr-dev@lists.kamailio.org

22 participants
45186 discussions

git:master:bd71add6: Makefile.defs: version set to 5.6.0-pre1
by Daniel-Constantin Mierla 28 Apr '22

28 Apr '22

Module: kamailio Branch: master Commit: bd71add6616e283f9f60a28785170c41c439f905 URL: https://github.com/kamailio/kamailio/commit/bd71add6616e283f9f60a28785170c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T09:02:07+02:00 Makefile.defs: version set to 5.6.0-pre1 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/bd71add6616e283f9f60a28785170c4… Patch: https://github.com/kamailio/kamailio/commit/bd71add6616e283f9f60a28785170c4… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 90aa777782..41c7b31652 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 6 SUBLEVEL = 0 -EXTRAVERSION = -pre0 +EXTRAVERSION = -pre1 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

dlg_isflagset not working on CANCEL request
by David Escartín 27 Apr '22

27 Apr '22

hello all Using kamailio 5.4 version, we have seen that dlg_isflagset is not detecting a dialog flag set in the request route for the initial INVITE, when a CANCEL request arrives. We have applied this change to set the dialog context unique ide for this request. Since it's done on dlg_onreply, dlg_onroute and dlg_ontimeout functions. This way, dlg_get_by_iuid(&dctx->iuid) in the function ki_dlg_isflagset is not NULL and dialog flags are detected. Is this change correct? Or can it generate any kind of issues? diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 3f8adefb79..f1df4a76c5 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -1255,6 +1255,9 @@ dlg_cell_t *dlg_lookup_msg_dialog(sip_msg_t *msg, unsigned int *dir) msg->callid->body.len, msg->callid->body.s); return NULL; } + if(msg->first_line.u.request.method_value == METHOD_CANCEL) { + dlg_set_ctx_iuid(dlg); + } if(dir) *dir = vdir; return dlg; } thanks a lot and regards David -- <http://www.sonoc.io/> David Escartín NOC engineer *www.sonoc.io* <http://www.sonoc.io/> [image: LinkedIn] <https://www.linkedin.com/company/sonoc> [image: Twitter] <https://twitter.com/sonoc_> [image: Facebook] <https://www.facebook.com/SONOCio/> This e-mail is for the exclusive use of its recipients and may contain business secrets or other confidential or privileged information. Any unauthorised use, copying, publication or distribution of this e-mail is strictly prohibited. If you are not the intended recipient, please inform us immediately by replying to this e-mail and delete it, including any attachments or copies on your system. In accordance with the GDPR (EU) 2016/679 and the LOPDGDD 3/2018, we inform you that this e-mail address and/or any other personal data you have provided us with will be treated by SONOC with absolute confidentiality and with the only purpose of providing you with the requested services, due to your condition as a client, supplier or because you have requested information from us at any time. These data will only be kept for as long as required to comply with legal obligations. You can exercise your rights at any time by sending an e-mail to: *dataprotection(a)sonoc.io* <dataprotection(a)sonoc.io>*.* <dataprotection(a)sonoc.io>

2 1

git:master:cfca8106: cfgt: improve detection of dynamic format
by Victor Seva 27 Apr '22

27 Apr '22

Module: kamailio Branch: master Commit: cfca81063c36ff2f1fe5578f89ccf9c0701e818a URL: https://github.com/kamailio/kamailio/commit/cfca81063c36ff2f1fe5578f89ccf9c… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-27T15:59:43+02:00 cfgt: improve detection of dynamic format * skip tm vars $T_* --- Modified: src/modules/cfgt/cfgt_json.c --- Diff: https://github.com/kamailio/kamailio/commit/cfca81063c36ff2f1fe5578f89ccf9c… Patch: https://github.com/kamailio/kamailio/commit/cfca81063c36ff2f1fe5578f89ccf9c… --- diff --git a/src/modules/cfgt/cfgt_json.c b/src/modules/cfgt/cfgt_json.c index b3dea63de4..d3aca8d305 100644 --- a/src/modules/cfgt/cfgt_json.c +++ b/src/modules/cfgt/cfgt_json.c @@ -43,6 +43,10 @@ int _cfgt_get_array_avp_vals(struct sip_msg *msg, pv_param_t *param, LM_ERR("invalid name\n"); return -1; } + if(name_type == 0 && avp_name.n == 0) { + LM_DBG("skip name_type:%d avp_name:%d\n", name_type, avp_name.n); + return 0; + } *jobj = srjson_CreateArray(jdoc); if(*jobj == NULL) { LM_ERR("cannot create json object\n"); @@ -286,8 +290,8 @@ int cfgt_get_json(struct sip_msg *msg, unsigned int mask, srjson_doc_t *jdoc, el = el->next; continue; } - if(srjson_GetArraySize(jdoc, jobj) == 0 - && !(mask & CFGT_DP_NULL)) { + if(jobj == NULL || (srjson_GetArraySize(jdoc, jobj) == 0 + && !(mask & CFGT_DP_NULL))) { el = el->next; continue; } @@ -314,6 +318,16 @@ int cfgt_get_json(struct sip_msg *msg, unsigned int mask, srjson_doc_t *jdoc, } snprintf(iname, 128, "$xavp(%.*s)", item_name.len, item_name.s); } else { + if(el->pvname.len > 3 && strncmp("$T_", el->pvname.s, 3) == 0) { + LM_DBG("skip tm var[%.*s]\n", el->pvname.len, el->pvname.s); + el = el->next; + continue; + } + if(strchr(el->pvname.s + 1, 36) != NULL) { + LM_DBG("skip dynamic format [%.*s]\n", el->pvname.len, el->pvname.s); + el = el->next; + continue; + } if(pv_get_spec_value(msg, &el->spec, &value) != 0) { LM_WARN("can't get value[%.*s]\n", el->pvname.len, el->pvname.s);

1 0

git:master:a49a0177: cfgt: fix memory leaks
by Victor Seva 27 Apr '22

27 Apr '22

Module: kamailio Branch: master Commit: a49a017764bf7a6cdb3ff4ecd885b0a51c87dc15 URL: https://github.com/kamailio/kamailio/commit/a49a017764bf7a6cdb3ff4ecd885b0a… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-27T15:59:44+02:00 cfgt: fix memory leaks - free parsed message - free srjson object left behind + remove unused headers + remove unused function + parse only HDR_CALLID_F --- Modified: src/modules/cfgt/cfgt_int.c Modified: src/modules/cfgt/cfgt_json.c --- Diff: https://github.com/kamailio/kamailio/commit/a49a017764bf7a6cdb3ff4ecd885b0a… Patch: https://github.com/kamailio/kamailio/commit/a49a017764bf7a6cdb3ff4ecd885b0a…

1 0

git:master:563ea056: siprepo: removed sip msg parameter when not used
by Daniel-Constantin Mierla 27 Apr '22

27 Apr '22

Module: kamailio Branch: master Commit: 563ea05637da475bdaed789d9530e3221e2e7296 URL: https://github.com/kamailio/kamailio/commit/563ea05637da475bdaed789d9530e32… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-27T15:22:39+02:00 siprepo: removed sip msg parameter when not used - filled async pull --- Modified: src/modules/siprepo/siprepo_data.c Modified: src/modules/siprepo/siprepo_data.h Modified: src/modules/siprepo/siprepo_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/563ea05637da475bdaed789d9530e32… Patch: https://github.com/kamailio/kamailio/commit/563ea05637da475bdaed789d9530e32…

1 0

git:master:1465a9b6: Revert "dialog: Terminate dialogs in Early stage and add functionality to send messages within a dialog"
by Carsten Bock 27 Apr '22

27 Apr '22

Module: kamailio Branch: master Commit: 1465a9b6e9fda36617b7b198ae051f0957803550 URL: https://github.com/kamailio/kamailio/commit/1465a9b6e9fda36617b7b198ae051f0… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2022-04-27T14:43:55+02:00 Revert "dialog: Terminate dialogs in Early stage and add functionality to send messages within a dialog" This reverts commit 26ef622ff3621c8a82c1c3560a32e8d735e30c4e. --- Modified: src/modules/dialog/dialog.c Modified: src/modules/dialog/dlg_handlers.c Modified: src/modules/dialog/dlg_hash.h Modified: src/modules/dialog/dlg_req_within.c Modified: src/modules/dialog/dlg_req_within.h Modified: src/modules/dialog/doc/dialog.xml Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1465a9b6e9fda36617b7b198ae051f0… Patch: https://github.com/kamailio/kamailio/commit/1465a9b6e9fda36617b7b198ae051f0…

1 0

git:master:d3ec6057: Revert "modules: readme files regenerated - dialog ... [skip ci]"
by Carsten Bock 27 Apr '22

27 Apr '22

Module: kamailio Branch: master Commit: d3ec6057d8ab2875476f7b87d2b64265fd3c31f2 URL: https://github.com/kamailio/kamailio/commit/d3ec6057d8ab2875476f7b87d2b6426… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2022-04-27T14:43:01+02:00 Revert "modules: readme files regenerated - dialog ... [skip ci]" This reverts commit 4704f53593d3e810c159a2825df61b47143ce1f7. --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/d3ec6057d8ab2875476f7b87d2b6426… Patch: https://github.com/kamailio/kamailio/commit/d3ec6057d8ab2875476f7b87d2b6426…

1 0

git:master:4704f535: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 27 Apr '22

27 Apr '22

Module: kamailio Branch: master Commit: 4704f53593d3e810c159a2825df61b47143ce1f7 URL: https://github.com/kamailio/kamailio/commit/4704f53593d3e810c159a2825df61b4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-27T11:46:20+02:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/4704f53593d3e810c159a2825df61b4… Patch: https://github.com/kamailio/kamailio/commit/4704f53593d3e810c159a2825df61b4…

1 0

git:master:cd201b8a: siprepo: removed extra empty comment header lines
by Daniel-Constantin Mierla 26 Apr '22

26 Apr '22

Module: kamailio Branch: master Commit: cd201b8a8e6c059fdac599c8498873395f8e89e6 URL: https://github.com/kamailio/kamailio/commit/cd201b8a8e6c059fdac599c84988733… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-26T14:16:28+02:00 siprepo: removed extra empty comment header lines --- Modified: src/modules/sworker/sworker_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/cd201b8a8e6c059fdac599c84988733… Patch: https://github.com/kamailio/kamailio/commit/cd201b8a8e6c059fdac599c84988733… --- diff --git a/src/modules/sworker/sworker_mod.c b/src/modules/sworker/sworker_mod.c index aedc3cc735..6a151caa44 100644 --- a/src/modules/sworker/sworker_mod.c +++ b/src/modules/sworker/sworker_mod.c @@ -119,9 +119,6 @@ static void mod_destroy(void) { } -/** - * - */ /** * */

1 0

git:master:d3ba4209: core: async task - fix typo in log message
by Daniel-Constantin Mierla 26 Apr '22

26 Apr '22

Module: kamailio Branch: master Commit: d3ba42097af410b5395f03edd1f8a95c61f7b041 URL: https://github.com/kamailio/kamailio/commit/d3ba42097af410b5395f03edd1f8a95… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-26T14:21:28+02:00 core: async task - fix typo in log message --- Modified: src/core/async_task.c --- Diff: https://github.com/kamailio/kamailio/commit/d3ba42097af410b5395f03edd1f8a95… Patch: https://github.com/kamailio/kamailio/commit/d3ba42097af410b5395f03edd1f8a95… --- diff --git a/src/core/async_task.c b/src/core/async_task.c index a96eb90286..bacb9ce994 100644 --- a/src/core/async_task.c +++ b/src/core/async_task.c @@ -440,7 +440,7 @@ int async_task_group_push(str *gname, async_task_t *task) gname->len, gname->s); return -1; } - LM_DBG("task [%p] sent to groupt [%.*s]\n", task, gname->len, gname->s); + LM_DBG("task [%p] sent to group [%.*s]\n", task, gname->len, gname->s); return 0; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev