sr-dev

sr-dev@lists.kamailio.org

22 participants
45186 discussions

[kamailio/kamailio] dead lock of dialog module (Issue #3084)
by progromm 13 Apr '22

13 Apr '22

### Description See `internal_get_dlg`: ```C static inline struct dlg_cell* internal_get_dlg(unsigned int h_entry, str* callid, str* ftag, str* ttag, unsigned int* dir, int mode) { struct dlg_cell* dlg; struct dlg_entry* d_entry; d_entry = &(d_table->entries[h_entry]); dlg_lock(d_table, d_entry); for (dlg = d_entry->first ; dlg ; dlg = dlg->next) { /* Check callid / fromtag / totag */ if (match_dialog(dlg, callid, ftag, ttag, dir) == 1) { ref_dlg_unsafe(dlg, 1); if (likely(mode == 0)) { dlg_unlock(d_table, d_entry); } LM_DBG("dialog callid='%.*s' found on entry %u, dir=%d\n", callid->len, callid->s, h_entry, *dir); return dlg; } } if (likely(mode == 0)) { dlg_unlock(d_table, d_entry); } LM_DBG("no dialog callid='%.*s' found\n", callid->len, callid->s); return 0; } ``` Should judge whether `mode` is 0 before `dlg_lock` . -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3084 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3084(a)github.com>

3 4

(no subject)
by 王斌 13 Apr '22

13 Apr '22

1 0

Memleak and deadlock abount dlg_search?
by 王斌 13 Apr '22

13 Apr '22

Hi： See dlg_new_dialog in dlg_handlers.c. After dlg_search, the dlg has locked and referenced, but there is no dlg_hash_release/dlg_release in some places ? Best Regards!

1 0

[kamailio/kamailio] the recursive lock of tm module is not safe? (Issue #3083)
by progromm 13 Apr '22

13 Apr '22

### Description See `lock_hash` in `h_table.c`: ```C void lock_hash(int i) { int mypid; mypid = my_pid(); if (likely(atomic_get(&_tm_table->entries[i].locker_pid) != mypid)) { lock(&_tm_table->entries[i].mutex); atomic_set(&_tm_table->entries[i].locker_pid, mypid); } else { /* locked within the same process that called us*/ _tm_table->entries[i].rec_lock_level++; } } ``` Flowing lines of code do not guarantee atomicity and I think it is not safe: * atomic_get(&_tm_table->entries[i].locker_pid) != mypid * lock(&_tm_table->entries[i].mutex) * atomic_set(&_tm_table->entries[i].locker_pid, mypid) Would you mind solving my confusion? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3083 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3083(a)github.com>

2 2

git:master:bf69b85f: modules: readme files regenerated - geoip2 ... [skip ci]
by Kamailio Dev 13 Apr '22

13 Apr '22

Module: kamailio Branch: master Commit: bf69b85fe9f383debcae6420c5d2d53a2ba452e9 URL: https://github.com/kamailio/kamailio/commit/bf69b85fe9f383debcae6420c5d2d53… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-13T12:01:10+02:00 modules: readme files regenerated - geoip2 ... [skip ci] --- Modified: src/modules/geoip2/README --- Diff: https://github.com/kamailio/kamailio/commit/bf69b85fe9f383debcae6420c5d2d53… Patch: https://github.com/kamailio/kamailio/commit/bf69b85fe9f383debcae6420c5d2d53… --- diff --git a/src/modules/geoip2/README b/src/modules/geoip2/README index 98d8d97f5c..80691c5516 100644 --- a/src/modules/geoip2/README +++ b/src/modules/geoip2/README @@ -37,7 +37,7 @@ Henning Westerholt 5. RPC Commands - 5.1. userblocklist.reload_blocklist + 5.1. geoip2.reload 6. Exported pseudo-variables @@ -67,7 +67,7 @@ Chapter 1. Admin Guide 5. RPC Commands - 5.1. userblocklist.reload_blocklist + 5.1. geoip2.reload 6. Exported pseudo-variables @@ -144,9 +144,9 @@ if(geoip2_match("$si", "src")) 5. RPC Commands - 5.1. userblocklist.reload_blocklist + 5.1. geoip2.reload -5.1. userblocklist.reload_blocklist +5.1. geoip2.reload Reload the internal GeoIP database. This is necessary after the database file has been changed on the disk.

1 0

git:master:282bbf18: geoip2: docs - fixed the rpc command geoip2.reload title
by Daniel-Constantin Mierla 13 Apr '22

13 Apr '22

Module: kamailio Branch: master Commit: 282bbf188831bf9b4187fa2aa54fd9b2412e066c URL: https://github.com/kamailio/kamailio/commit/282bbf188831bf9b4187fa2aa54fd9b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-13T11:58:01+02:00 geoip2: docs - fixed the rpc command geoip2.reload title --- Modified: src/modules/geoip2/doc/geoip2_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/282bbf188831bf9b4187fa2aa54fd9b… Patch: https://github.com/kamailio/kamailio/commit/282bbf188831bf9b4187fa2aa54fd9b… --- diff --git a/src/modules/geoip2/doc/geoip2_admin.xml b/src/modules/geoip2/doc/geoip2_admin.xml index cbcc2d8c79..8c5a96caa8 100644 --- a/src/modules/geoip2/doc/geoip2_admin.xml +++ b/src/modules/geoip2/doc/geoip2_admin.xml @@ -128,9 +128,9 @@ if(geoip2_match("$si", "src")) <section> <title>RPC Commands</title> - <section id="userblocklist.r.reload_blocklist"> + <section id="geoip2.r.reload"> <title> - <function moreinfo="none">userblocklist.reload_blocklist</function> + <function moreinfo="none">geoip2.reload</function> </title> <para> Reload the internal GeoIP database. This is necessary after

1 0

[kamailio/kamailio] The I-CSCF does not send Ringing under heavy load. (Issue #3071)
by Eugeniy 13 Apr '22

13 Apr '22

### Description  I set up Kamailio IMS , in the end everything turned out great, calls are made, and I decided to check how Kamailio copes with the load. I am creating load using sipp application. There is no problem with a low call generation rate, but if you raise the call generation to more than 20 calls per second, some of the calls fail. ### Troubleshooting Challenges are always dropped sequentially ![image](https://user-images.githubusercontent.com/92918808/161745286-264d6e9b-47bb-4fcb-923a-1f5ded4cd999.png) I compared the calls and saw that the ICSCF does not send a 180 Ringing message towards the SCSCF. ![image](https://user-images.githubusercontent.com/92918808/161745354-2f97f8d1-2eb4-4a53-a9b0-2cb9d9d536d6.png) Below is an example of a successful call. ![image](https://user-images.githubusercontent.com/92918808/161745412-20f0ecc6-3952-4e01-9c74-4f6fa6cfd3c8.png) CPU, MEM indicators are normal. I increased the shr_mem and pkg_mem parameters. S-CSCF and I-CSCF communicate over UDP, but reside on the same server. It doesn't look like the packets are dropping or suffering from collisions. 10.21.4.226 external IP P-CSCF 10.10.0.1 IP P-CSCF 10.10.0.2 IP S/I-CSCF #### Reproduction  Using the sipp application, generate 100 calls at a generation rate greater than 20 calls per second. #### Debugging Data  ``` none ``` #### Log Messages  ``` attached below ``` [logs.zip](https://github.com/kamailio/kamailio/files/8417659/logs.zip) #### SIP Traffic  ``` attached below ``` [call_rejected.zip](https://github.com/kamailio/kamailio/files/8417640/call_… ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.2 (x86_64/linux) 42be5d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 42be5d compiled on 10:39:53 Dec 27 2021 with gcc 9.3.0 ``` * **Operating System**:  ``` Ubuntu 20.04.3 LTS Linux ims-core 5.4.0-104-generic #118-Ubuntu SMP Wed Mar 2 19:02:41 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3071 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3071(a)github.com>

2 12

git:master:c43432e6: modules: readme files regenerated - geoip2 ... [skip ci]
by Kamailio Dev 13 Apr '22

13 Apr '22

Module: kamailio Branch: master Commit: c43432e6fda8db527ffca3442d7cea8e601a211e URL: https://github.com/kamailio/kamailio/commit/c43432e6fda8db527ffca3442d7cea8… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-13T11:16:09+02:00 modules: readme files regenerated - geoip2 ... [skip ci] --- Modified: src/modules/geoip2/README --- Diff: https://github.com/kamailio/kamailio/commit/c43432e6fda8db527ffca3442d7cea8… Patch: https://github.com/kamailio/kamailio/commit/c43432e6fda8db527ffca3442d7cea8… --- diff --git a/src/modules/geoip2/README b/src/modules/geoip2/README index 0362750258..98d8d97f5c 100644 --- a/src/modules/geoip2/README +++ b/src/modules/geoip2/README @@ -91,7 +91,10 @@ Chapter 1. Admin Guide to enable access to the results of a query to the database. Many queries can be done and store results in different containers to - be able to use in parallel. Database is loaded at startup in cache. + be able to use in parallel. Database is loaded at startup in cache. The + cache can be reloaded with an RPC command. In this case make sure that + you do not overwrite the file in place, but replace it, e.g. with a + “move” command. 2. Dependencies

1 0

git:master:166edc37: geoip2: add a note about db replacement recommendations
by Henning Westerholt 13 Apr '22

13 Apr '22

Module: kamailio Branch: master Commit: 166edc37177c2a92f57a31591ca781b15202a57f URL: https://github.com/kamailio/kamailio/commit/166edc37177c2a92f57a31591ca781b… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-04-13T09:04:31Z geoip2: add a note about db replacement recommendations --- Modified: src/modules/geoip2/doc/geoip2_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/166edc37177c2a92f57a31591ca781b… Patch: https://github.com/kamailio/kamailio/commit/166edc37177c2a92f57a31591ca781b… --- diff --git a/src/modules/geoip2/doc/geoip2_admin.xml b/src/modules/geoip2/doc/geoip2_admin.xml index d3d0228946..cbcc2d8c79 100644 --- a/src/modules/geoip2/doc/geoip2_admin.xml +++ b/src/modules/geoip2/doc/geoip2_admin.xml @@ -44,6 +44,9 @@ <para> Many queries can be done and store results in different containers to be able to use in parallel. Database is loaded at startup in cache. + The cache can be reloaded with an RPC command. In this case make sure + that you do not overwrite the file in place, but replace it, e.g. with + a <quote>move</quote> command. </para> </section> <section>

1 0

git:master:6a001d3f: geoip2: fix logging for reload failures, initialize memory for db
by Henning Westerholt 13 Apr '22

13 Apr '22

Module: kamailio Branch: master Commit: 6a001d3f90a8cfa2514b5b2781fc61dec50fc0c4 URL: https://github.com/kamailio/kamailio/commit/6a001d3f90a8cfa2514b5b2781fc61d… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-04-13T08:20:54Z geoip2: fix logging for reload failures, initialize memory for db --- Modified: src/modules/geoip2/geoip2_pv.c --- Diff: https://github.com/kamailio/kamailio/commit/6a001d3f90a8cfa2514b5b2781fc61d… Patch: https://github.com/kamailio/kamailio/commit/6a001d3f90a8cfa2514b5b2781fc61d… --- diff --git a/src/modules/geoip2/geoip2_pv.c b/src/modules/geoip2/geoip2_pv.c index 0b50fd4447..0995ae2d25 100644 --- a/src/modules/geoip2/geoip2_pv.c +++ b/src/modules/geoip2/geoip2_pv.c @@ -490,6 +490,8 @@ int geoip2_init_pv(char *path) { int status; _handle_GeoIP = shm_malloc(sizeof(struct MMDB_s)); + memset(_handle_GeoIP, 0, sizeof(struct MMDB_s)); + if (_handle_GeoIP == NULL) { SHM_MEM_ERROR; @@ -522,9 +524,13 @@ int geoip2_reload_pv(char *path) if(MMDB_SUCCESS != status) { LM_ERR("cannot reload GeoIP database file at: %s\n", path); + + } + else + { + LM_INFO("reloaded GeoIP database file at: %s\n", path); } lock_release(lock); - LM_INFO("reloaded GeoIP database file at: %s\n", path); return status; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev