- sr-dev - kamailio.org

Re: [kamailio/kamailio] rtpengine: export API for other modules (GH #3949) (3d002d5)
by Farzaneh Soltanzadeh 19 Aug '24

19 Aug '24

Thanks for merging the PR. It seems that the referenced PR is wrong. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd9ce504335/145516854(a)github.com>

1 0

git:master:3d002d56: rtpengine: export API for other modules (GH #3949)
by Henning Westerholt 19 Aug '24

19 Aug '24

Module: kamailio Branch: master Commit: 3d002d561e82b8bb71b225da708bdfd9ce504335 URL: https://github.com/kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd… Author: Farzaneh Soltanzadeh <fr.soltanzadeh(a)resaa.net> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-08-19T12:30:29Z rtpengine: export API for other modules (GH #3949) --- Added: src/modules/rtpengine/api.h Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd… Patch: https://github.com/kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd… --- diff --git a/src/modules/rtpengine/api.h b/src/modules/rtpengine/api.h new file mode 100644 index 00000000000..fa499916238 --- /dev/null +++ b/src/modules/rtpengine/api.h @@ -0,0 +1,66 @@ +/* + * Rtpengine Module + * + * Copyright (C) 2003-2008 Sippy Software, Inc., http://www.sippysoft.com + * Copyright (C) 2014-2015 Sipwise GmbH, http://www.sipwise.com + * + * This file is part of Kamailio, a free SIP server. + * + * Kamailio is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version + * + * Kamailio is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef _RTPENGINE_API_H_ +#define _RTPENGINE_API_H_ + +#include "../../core/parser/msg_parser.h" + +typedef int (*rtpengine_start_recording_f)( + struct sip_msg *msg, char *str1, char *str2); +typedef int (*rtpengine_answer_f)(struct sip_msg *msg, char *str1, char *str2); +typedef int (*rtpengine_offer_f)(struct sip_msg *msg, char *str1, char *str2); +typedef int (*rtpengine_delete_f)(struct sip_msg *msg, char *str1, char *str2); + +typedef struct rtpengine_api +{ + rtpengine_start_recording_f start_recording; + rtpengine_answer_f answer; + rtpengine_offer_f offer; + rtpengine_delete_f delete; +} rtpengine_api_t; + +typedef int (*bind_rtpengine_f)(rtpengine_api_t *api); + +/** + * @brief Load the RTPENGINE API + */ +static inline int rtpengine_load_api(rtpengine_api_t *api) +{ + bind_rtpengine_f bindrtpengine; + + bindrtpengine = (bind_rtpengine_f)find_export("bind_rtpengine", 0, 0); + if(bindrtpengine == 0) { + LM_ERR("cannot find bind_rtpengine\n"); + return -1; + } + if(bindrtpengine(api) < 0) { + LM_ERR("cannot bind rtpengine api\n"); + return -1; + } + + return 0; +} + + +#endif /* _RTPENGINE_API_H_ */ diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index aefdc7c7d6e..84bf5951752 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -89,6 +89,7 @@ #include "rtpengine_hash.h" #include "bencode.h" #include "config.h" +#include "api.h" MODULE_VERSION @@ -241,6 +242,8 @@ static int parse_viabranch(struct ng_flags_parse *ng_flags, struct sip_msg *msg, static int parse_from_to_tags(struct ng_flags_parse *ng_flags, enum rtpe_operation op, struct sip_msg *msg); +static int bind_rtpengine(rtpengine_api_t *api); + static int rtpengine_offer_answer( struct sip_msg *msg, void *d, enum rtpe_operation op, int more); static int fixup_set_id(void **param, int param_no); @@ -468,6 +471,7 @@ static cmd_export_t cmds[] = { {"rtpengine_query_v", (cmd_function)w_rtpengine_query_v, 2, fixup_rtpengine_query_v, fixup_free_rtpengine_query_v, ANY_ROUTE}, + {"bind_rtpengine", (cmd_function)bind_rtpengine, 0, 0, 0, 0}, {0, 0, 0, 0, 0, 0} }; @@ -5779,3 +5783,21 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) sr_kemi_modules_add(sr_kemi_rtpengine_exports); return 0; } + + +/** + * load rtpengine module API + */ +static int bind_rtpengine(rtpengine_api_t *api) +{ + if(!api) { + LM_ERR("Invalid parameter value\n"); + return -1; + } + api->start_recording = start_recording_f; + api->answer = rtpengine_answer1_f; + api->offer = rtpengine_offer1_f; + api->delete = rtpengine_delete1_f; + + return 0; +} \ No newline at end of file

1 0

[kamailio/kamailio] secfilter: all functions are exported in KEMI (PR #3940)
by bazrafshan.m.h 19 Aug '24

19 Aug '24

- All `secfilter` functions are now accessible in KEMI. For example, you can use KSR.secf_check_ip() directly by importing the KSR module in Python.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  * Exporting all secfilter functions to KEMI. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3940 -- Commit Summary -- * secfilter is fully KEMIized -- File Changes -- M src/modules/secfilter/secfilter.c (99) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3940.patch https://github.com/kamailio/kamailio/pull/3940.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3940 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3940(a)github.com>

2 5

[kamailio/kamailio] cdp: export all functions in KEMI module (PR #3943)
by bazrafshan.m.h 19 Aug '24

19 Aug '24

- Added `cdp_has_app` function: - Accepts a single parameter: - `application`: The Application ID. - Added `cdp_has_app2` function: - Accepts two parameters: - `vendorid`: The Vendor ID associated with the application. - `application`: The Application ID. - Added cdp_check_peer function: - Accepts one parameter: - `fqdn`: the Fully qualified domain name of the peer, that should be checked. The parameter may contain pseudovariables. NOTE: All parameters are passed as standard strings.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  * Exporting all cdp functions to KEMI You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3943 -- Commit Summary -- * cdp: export all functions in KEMI module -- File Changes -- M src/modules/cdp/cdp_mod.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3943.patch https://github.com/kamailio/kamailio/pull/3943.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3943 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3943(a)github.com>

2 3

git:master:b712ddc4: msilo: removed duplicatred exported function
by Daniel-Constantin Mierla 17 Aug '24

17 Aug '24

Module: kamailio Branch: master Commit: b712ddc4db9a9c1bb30b236a0a86082108b23f07 URL: https://github.com/kamailio/kamailio/commit/b712ddc4db9a9c1bb30b236a0a86082… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-17T17:08:31+02:00 msilo: removed duplicatred exported function --- Modified: src/modules/msilo/msilo.c --- Diff: https://github.com/kamailio/kamailio/commit/b712ddc4db9a9c1bb30b236a0a86082… Patch: https://github.com/kamailio/kamailio/commit/b712ddc4db9a9c1bb30b236a0a86082… --- diff --git a/src/modules/msilo/msilo.c b/src/modules/msilo/msilo.c index 9baa1e4c185..fe2bd8cb53a 100644 --- a/src/modules/msilo/msilo.c +++ b/src/modules/msilo/msilo.c @@ -185,7 +185,6 @@ static cmd_export_t cmds[] = { {"m_store_addrs", (cmd_function)m_store3, 3, fixup_spve_all, fixup_free_spve_all, REQUEST_ROUTE | FAILURE_ROUTE}, {"m_dump", (cmd_function)m_dump_2, 0, 0, 0, REQUEST_ROUTE}, - {"m_dump", (cmd_function)m_dump_2, 0, 0, 0, REQUEST_ROUTE}, {"m_dump", (cmd_function)m_dump_2, 1, fixup_spve_null, fixup_free_spve_null, REQUEST_ROUTE}, {"bind_msilo", (cmd_function)bind_msilo, 1, 0, 0, ANY_ROUTE},

1 0

git:master:b6dea98a: msilo: added fixup free functions to exports structure
by Daniel-Constantin Mierla 17 Aug '24

17 Aug '24

Module: kamailio Branch: master Commit: b6dea98ada293a3bbad004aa1b194d4bf44a60ab URL: https://github.com/kamailio/kamailio/commit/b6dea98ada293a3bbad004aa1b194d4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-17T16:30:21+02:00 msilo: added fixup free functions to exports structure --- Modified: src/modules/msilo/msilo.c --- Diff: https://github.com/kamailio/kamailio/commit/b6dea98ada293a3bbad004aa1b194d4… Patch: https://github.com/kamailio/kamailio/commit/b6dea98ada293a3bbad004aa1b194d4… --- diff --git a/src/modules/msilo/msilo.c b/src/modules/msilo/msilo.c index 91b6a8892a9..9baa1e4c185 100644 --- a/src/modules/msilo/msilo.c +++ b/src/modules/msilo/msilo.c @@ -181,13 +181,13 @@ static cmd_export_t cmds[] = { {"m_store", (cmd_function)m_store1, 0, 0, 0, REQUEST_ROUTE | FAILURE_ROUTE}, {"m_store", (cmd_function)m_store1, 1, fixup_spve_null, - 0, REQUEST_ROUTE | FAILURE_ROUTE}, + fixup_free_spve_null, REQUEST_ROUTE | FAILURE_ROUTE}, {"m_store_addrs", (cmd_function)m_store3, 3, fixup_spve_all, fixup_free_spve_all, REQUEST_ROUTE | FAILURE_ROUTE}, {"m_dump", (cmd_function)m_dump_2, 0, 0, 0, REQUEST_ROUTE}, {"m_dump", (cmd_function)m_dump_2, 0, 0, 0, REQUEST_ROUTE}, {"m_dump", (cmd_function)m_dump_2, 1, fixup_spve_null, - 0, REQUEST_ROUTE}, + fixup_free_spve_null, REQUEST_ROUTE}, {"bind_msilo", (cmd_function)bind_msilo, 1, 0, 0, ANY_ROUTE}, {0, 0, 0, 0, 0, 0} };

1 0

git:master:f5f7c913: uac: added fixup free functions to exports structure
by Daniel-Constantin Mierla 16 Aug '24

16 Aug '24

Module: kamailio Branch: master Commit: f5f7c913d4f008b9937677ae2c2d66baa01dcf0e URL: https://github.com/kamailio/kamailio/commit/f5f7c913d4f008b9937677ae2c2d66b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-16T18:03:46+02:00 uac: added fixup free functions to exports structure --- Modified: src/modules/uac/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/f5f7c913d4f008b9937677ae2c2d66b… Patch: https://github.com/kamailio/kamailio/commit/f5f7c913d4f008b9937677ae2c2d66b… --- diff --git a/src/modules/uac/uac.c b/src/modules/uac/uac.c index 90d434ac64d..aabd6c753ed 100644 --- a/src/modules/uac/uac.c +++ b/src/modules/uac/uac.c @@ -128,15 +128,15 @@ static pv_export_t mod_pvs[] = { /* Exported functions */ static cmd_export_t cmds[] = { {"uac_replace_from", (cmd_function)w_replace_from, 2, fixup_spve_spve, - 0, REQUEST_ROUTE | BRANCH_ROUTE}, + fixup_free_spve_spve, REQUEST_ROUTE | BRANCH_ROUTE}, {"uac_replace_from", (cmd_function)w_replace_from, 1, fixup_spve_spve, - 0, REQUEST_ROUTE | BRANCH_ROUTE}, + fixup_free_spve_spve, REQUEST_ROUTE | BRANCH_ROUTE}, {"uac_restore_from", (cmd_function)w_restore_from, 0, 0, 0, REQUEST_ROUTE}, - {"uac_replace_to", (cmd_function)w_replace_to, 2, fixup_spve_spve, 0, - REQUEST_ROUTE | BRANCH_ROUTE}, - {"uac_replace_to", (cmd_function)w_replace_to, 1, fixup_spve_spve, 0, - REQUEST_ROUTE | BRANCH_ROUTE}, + {"uac_replace_to", (cmd_function)w_replace_to, 2, fixup_spve_spve, + fixup_free_spve_spve, REQUEST_ROUTE | BRANCH_ROUTE}, + {"uac_replace_to", (cmd_function)w_replace_to, 1, fixup_spve_spve, + fixup_free_spve_spve, REQUEST_ROUTE | BRANCH_ROUTE}, {"uac_restore_to", (cmd_function)w_restore_to, 0, 0, 0, REQUEST_ROUTE}, {"uac_auth", (cmd_function)w_uac_auth, 0, 0, 0, FAILURE_ROUTE | BRANCH_FAILURE_ROUTE | EVENT_ROUTE}, @@ -152,7 +152,7 @@ static cmd_export_t cmds[] = { {"uac_reg_lookup_uri", (cmd_function)w_uac_reg_lookup_uri, 2, fixup_spve_pvar, fixup_free_spve_pvar, ANY_ROUTE}, {"uac_reg_status", (cmd_function)w_uac_reg_status, 1, fixup_spve_null, - 0, ANY_ROUTE}, + fixup_free_spve_null, ANY_ROUTE}, {"uac_reg_request_to", (cmd_function)w_uac_reg_request_to, 2, fixup_spve_igp, fixup_free_spve_igp, REQUEST_ROUTE | FAILURE_ROUTE | BRANCH_ROUTE},

1 0

git:master:36ae41d5: uac: added field for cseq number for $uac_req(...)
by Daniel-Constantin Mierla 15 Aug '24

15 Aug '24

Module: kamailio Branch: master Commit: 36ae41d5d3efce9c336cf2f675a0cb4fe01933a1 URL: https://github.com/kamailio/kamailio/commit/36ae41d5d3efce9c336cf2f675a0cb4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-15T14:46:39+02:00 uac: added field for cseq number for $uac_req(...) --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/36ae41d5d3efce9c336cf2f675a0cb4… Patch: https://github.com/kamailio/kamailio/commit/36ae41d5d3efce9c336cf2f675a0cb4… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index f91a0c75b4f..8fc88b3858d 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -79,6 +79,7 @@ typedef struct _uac_send_info str s_apasswd; char b_evparam[MAX_UACD_SIZE]; str s_evparam; + unsigned int cseqno; unsigned int evroute; unsigned int evcode; unsigned int evtype; @@ -180,6 +181,10 @@ int pv_get_uac_req(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) return pv_get_uintval(msg, param, res, _uac_req.evcode); case 16: return pv_get_uintval(msg, param, res, _uac_req.evtype); + case 17: + return pv_get_uintval(msg, param, res, _uac_req.flags); + case 18: + return pv_get_uintval(msg, param, res, _uac_req.cseqno); default: return pv_get_uintval(msg, param, res, _uac_req.flags); } @@ -214,6 +219,7 @@ int pv_set_uac_req( _uac_req.evroute = 0; _uac_req.evtype = 0; _uac_req.evcode = 0; + _uac_req.cseqno = 0; _uac_req.s_evparam.len = 0; } break; @@ -465,6 +471,17 @@ int pv_set_uac_req( } _uac_req.flags = tval->ri; break; + case 18: + if(tval == NULL) { + _uac_req.cseqno = 0; + return 0; + } + if(!(tval->flags & PV_VAL_INT)) { + LM_ERR("Invalid value type\n"); + return -1; + } + _uac_req.cseqno = tval->ri; + break; } return 0; } @@ -516,6 +533,8 @@ int pv_parse_uac_req_name(pv_spec_p sp, str *in) sp->pvp.pvn.u.isname.name.n = 15; else if(strncmp(in->s, "evtype", 6) == 0) sp->pvp.pvn.u.isname.name.n = 16; + else if(strncmp(in->s, "cseqno", 6) == 0) + sp->pvp.pvn.u.isname.name.n = 18; else goto error; break; @@ -861,6 +880,7 @@ int uac_req_send(void) uac_r.cbp = (void *)tp; } uac_r.callid = (_uac_req.s_callid.len <= 0) ? NULL : &_uac_req.s_callid; + uac_r.cseqno = _uac_req.cseqno; ret = _uac_send_tmb.t_request(&uac_r, /* UAC Req */ &_uac_req.s_ruri, /* Request-URI */ (_uac_req.s_turi.len <= 0) ? &_uac_req.s_ruri

1 0

git:master:4a468936: tm: added cseq number field to uac_req structure
by Daniel-Constantin Mierla 15 Aug '24

15 Aug '24

Module: kamailio Branch: master Commit: 4a4689366aee9517ed90cf2df1a4e90018b9948d URL: https://github.com/kamailio/kamailio/commit/4a4689366aee9517ed90cf2df1a4e90… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-15T14:41:12+02:00 tm: added cseq number field to uac_req structure --- Modified: src/modules/tm/uac.c Modified: src/modules/tm/uac.h --- Diff: https://github.com/kamailio/kamailio/commit/4a4689366aee9517ed90cf2df1a4e90… Patch: https://github.com/kamailio/kamailio/commit/4a4689366aee9517ed90cf2df1a4e90… --- diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index 5384d826dd8..b40a1e74d09 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -1086,6 +1086,7 @@ int request(uac_req_t *uac_r, str *ruri, str *to, str *from, str *next_hop) str callid, fromtag; dlg_t *dialog; int res; + unsigned int cseqno; if(check_params(uac_r, to, from) < 0) goto err; @@ -1094,9 +1095,10 @@ int request(uac_req_t *uac_r, str *ruri, str *to, str *from, str *next_hop) generate_callid(&callid); else callid = *uac_r->callid; + cseqno = (uac_r->cseqno > 0) ? uac_r->cseqno : DEFAULT_CSEQ; generate_fromtag(&fromtag, &callid, ruri); - if(new_dlg_uac(&callid, &fromtag, DEFAULT_CSEQ, from, to, &dialog) < 0) { + if(new_dlg_uac(&callid, &fromtag, cseqno, from, to, &dialog) < 0) { LM_ERR("Error while creating temporary dialog\n"); goto err; } diff --git a/src/modules/tm/uac.h b/src/modules/tm/uac.h index 6fad3380cd8..05a8614d8f8 100644 --- a/src/modules/tm/uac.h +++ b/src/modules/tm/uac.h @@ -51,6 +51,7 @@ typedef struct uac_req transaction_cb *cb; void *cbp; str *callid; + unsigned int cseqno; } uac_req_t; /* macro for setting the values of uac_req_t struct */

1 0

git:master:7d2fd091: phonenum: add fixup free functions to exports structure
by Daniel-Constantin Mierla 14 Aug '24

14 Aug '24

Module: kamailio Branch: master Commit: 7d2fd09103680454aaaba30f5e46f83b362513eb URL: https://github.com/kamailio/kamailio/commit/7d2fd09103680454aaaba30f5e46f83… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-14T18:37:06+02:00 phonenum: add fixup free functions to exports structure --- Modified: src/modules/phonenum/phonenum_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/7d2fd09103680454aaaba30f5e46f83… Patch: https://github.com/kamailio/kamailio/commit/7d2fd09103680454aaaba30f5e46f83… --- diff --git a/src/modules/phonenum/phonenum_mod.c b/src/modules/phonenum/phonenum_mod.c index 665fa9b2772..c5eda4bdc35 100644 --- a/src/modules/phonenum/phonenum_mod.c +++ b/src/modules/phonenum/phonenum_mod.c @@ -58,9 +58,9 @@ static pv_export_t mod_pvs[] = { static cmd_export_t cmds[]={ {"phonenum_match", (cmd_function)w_phonenum_match, 2, fixup_spve_spve, - 0, ANY_ROUTE}, + fixup_free_spve_spve, ANY_ROUTE}, {"phonenum_match_cn", (cmd_function)w_phonenum_match_cn, 3, fixup_spve_all, - 0, ANY_ROUTE}, + fixup_free_spve_all, ANY_ROUTE}, {0, 0, 0, 0, 0, 0} };

1 0

git:master:e9dd041c: phonenum: export match_cn() to kemi
by Daniel-Constantin Mierla 13 Aug '24

13 Aug '24

Module: kamailio Branch: master Commit: e9dd041ce6af9ee4b9cc2e29b4417787a8056776 URL: https://github.com/kamailio/kamailio/commit/e9dd041ce6af9ee4b9cc2e29b441778… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-13T21:01:51+02:00 phonenum: export match_cn() to kemi --- Modified: src/modules/phonenum/phonenum_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/e9dd041ce6af9ee4b9cc2e29b441778… Patch: https://github.com/kamailio/kamailio/commit/e9dd041ce6af9ee4b9cc2e29b441778… --- diff --git a/src/modules/phonenum/phonenum_mod.c b/src/modules/phonenum/phonenum_mod.c index 5f07635099c..665fa9b2772 100644 --- a/src/modules/phonenum/phonenum_mod.c +++ b/src/modules/phonenum/phonenum_mod.c @@ -196,6 +196,11 @@ static sr_kemi_t sr_kemi_phonenum_exports[] = { { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("phonenum"), str_init("match_cn"), + SR_KEMIP_INT, phonenum_match_cn, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

[kamailio/kamailio] K crash v5.5.6 with dlg_profile (Issue #3878)
by Olli Attila 13 Aug '24

13 Aug '24

### Description Yesterday we noticed that Kamailio crashed suddenly. There was no major call load on the node, but we did found out that multiple calls were tried to initiate though the node ending with "486 busy here" when the crash happened. User/users tried over and over to make the call happen even though busy was signaled. Our Kamailio is configured to keep count of the dialogs using dialog profiles. ### Troubleshooting Searched logs, what kind of calls were tried to place on the network though the node at the time of the crash and collected the backtrace. #### Debugging Data ``` Kamailio version: kamailio 5.5.6 (x86_64/linux) 72dbb0 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 72dbb0 compiled on 00:00:00 Sep 13 2022 with gcc 11.3.1 OS: Red Hat Enterprise Linux release 9.3 (Plow) Kamailio log when the crash happened: Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417559]: CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 13 Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417541]: ALERT: <core> [main.c:788]: handle_sigs(): child process 3417545 exited by a signal 11 Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417541]: ALERT: <core> [main.c:791]: handle_sigs(): core was generated Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417541]: INFO: <core> [main.c:813]: handle_sigs(): terminating due to SIGCHLD Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417543]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417551]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417553]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417557]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417544]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417559]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417547]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417548]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417542]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417552]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417554]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417555]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417558]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417556]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Jun 16 19:33:36 voip-proxy3 /usr/sbin/kamailio[3417546]: INFO: <core> [main.c:868]: sig_usr(): signal 15 received Core dump bt full trace: GNU gdb (GDB) Red Hat Enterprise Linux 10.2-11.1.el9_3 Copyright (C) 2021 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-redhat-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <https://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/sbin/kamailio... Reading symbols from /usr/lib/debug/usr/sbin/kamailio-5.5.6-0.el9.centos.x86_64.debug... warning: Can't open file /dev/zero (deleted) during file-backed mapping note processing [New LWP 3417545] Missing separate debuginfo for /usr/lib64/kamailio/modules/tls.so Try: dnf --enablerepo='*debug*' install /usr/lib/debug/.build-id/08/23cd55ae0236655930f83c342c2b76bc3215c5.debug Missing separate debuginfo for /usr/lib64/kamailio/modules/snmpstats.so Try: dnf --enablerepo='*debug*' install /usr/lib/debug/.build-id/bd/ff4c3b08c64459c940abc2fc0f55abd5518619.debug Missing separate debuginfo for /usr/lib64/kamailio/modules/db_mysql.so Try: dnf --enablerepo='*debug*' install /usr/lib/debug/.build-id/d1/e37f2e0a33abb8554b3f082e8e0a9aefc0bd76.debug Missing separate debuginfo for /usr/lib64/kamailio/modules/dialplan.so Try: dnf --enablerepo='*debug*' install /usr/lib/debug/.build-id/31/e195cc97b19103a6d71de3feff763dc9b21d6d.debug [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio --atexit=no -DD -P /run/kamailio/kamailio.pid -f /etc/kamail'. Program terminated with signal SIGSEGV, Segmentation fault. #0 link_profile (linker=0x7f73efb2d3d8, vkey=0x7f73ef18ecb8) at dlg_profile.c:486 486 p_entry->first->prev->next = &linker->hash_linker; Missing separate debuginfos, use: dnf debuginfo-install audit-libs-3.0.7-104.el9.x86_64 bzip2-libs-1.0.8-8.el9.x86_64 glibc-2.34-83.el9_3.12.x86_64 libacl-2.3.1-3.el9.x86_64 libattr-2.5.1-3.el9.x86_64 libcap-2.48-9.el9_2.x86_64 libcap-ng-0.8.2-7.el9.x86_64 libxcrypt-4.4.18-3.el9.x86_64 libzstd-1.5.1-2.el9.x86_64 lm_sensors-libs-3.6.0-10.el9.x86_64 lua-libs-5.4.4-4.el9.x86_64 mariadb-connector-c-3.2.6-1.el9_0.x86_64 net-snmp-agent-libs-5.9.1-11.el9_3.1.x86_64 net-snmp-libs-5.9.1-11.el9_3.1.x86_64 openssl-libs-3.0.7-25.el9_3.x86_64 pcre-8.44-3.el9.3.x86_64 perl-libs-5.32.1-480.el9.x86_64 popt-1.18-8.el9.x86_64 rpm-libs-4.16.1.3-27.el9_3.x86_64 sqlite-libs-3.34.1-7.el9_3.x86_64 xz-libs-5.2.5-8.el9_0.x86_64 zlib-1.2.11-40.el9.x86_64 (gdb) bt full #0 link_profile (linker=0x7f73efb2d3d8, vkey=0x7f73ef18ecb8) at dlg_profile.c:486 hash = 14 p_entry = 0x7f73eee13730 #1 0x00007f73ed45e4f7 in link_dlg_profile (linker=0x7f73efb2d3d8, dlg=0x7f73ef18ec40) at dlg_profile.c:522 d_entry = 0x7f73eee18ea8 #2 0x00007f73ed45f5d6 in set_dlg_profile (msg=0x7f73f30c3230, value=0x7ffcbf7094f0, profile=0x7f73eee13620) at dlg_profile.c:609 dlg = 0x7f73ef18ec40 linker = 0x7f73efb2d3d8 __func__ = "set_dlg_profile" #3 0x00007f73ed3e089a in w_set_dlg_profile_helper (msg=0x7f73f30c3230, profile=0x7f73eee13620, value=0x7ffcbf7094f0) at dialog.c:825 __func__ = "w_set_dlg_profile_helper" #4 0x00007f73ed3e138b in w_set_dlg_profile (msg=0x7f73f30c3230, profile=0x7f73eee13620 "P7\341\356s\177", value=0x7f73f2f6aa88 "`\327\371\362s\177") at dialog.c:852 pve = 0x7f73f2f6aa88 val_s = {s = 0x7f73f2e6dc30 "xxx", len = 31} __func__ = "w_set_dlg_profile" #5 0x00000000004416f6 in do_action (h=0x7ffcbf70ae60, a=0x7f73f2f9edb0, msg=0x7f73f30c3230) at core/action.c:1091 ret = -5 v = 1 dst = {send_sock = 0x817213, to = {s = {sa_family = 18, sa_data = "\000\000\000\000\000\000\320zt\363s\177\000"}, sin = {sin_family = 18, sin_port = 0, sin_addr = {s_addr = 0}, sin_zero = "\320zt\363s\177\000"}, sin6 = {sin6_family = 18, sin6_port = 0, sin6_flowinfo = 0, sin6_addr = {__in6_u = {__u6_addr8 = "\320zt\363s\177\000\000\000\000\000\000\000\000\000", __u6_addr16 = {31440, 62324, 32627, 0, 0, 0, 0, 0}, __u6_addr32 = {4084497104, 32627, 0, 0}}}, sin6_scope_id = 4075568768}, sas = {ss_family = 18, __ss_padding = "\000\000\000\000\000\000\320zt\363s\177\000\000\000\000\000\000\000\000\000\000\200>\354\362s\177\000\000@\235p\277\374\177\000\000\060\062\f\363s\177\000\000`\256p\277\374\177\000\000P7\354\362s\177\000\000D\235p\277\374\177\000\000\060\062\f\363s\177\000\000`\256p\277\374\177\000\000\320zt\363s\177\000\000\000\000\000\004\000\000\000\000\260\232p\277\374\177\000\000\200\263\240\355s\177\000", __ss_align = 0}}, id = -1083139152, send_flags = {f = 32764, blst_imask = 0}, proto = 0 '\000', proto_pad0 = 0 '\000', proto_pad1 = 0} tmp = 0x1f2dff010 <error: Cannot access memory at address 0x1f2dff010> new_uri = 0x5d23df <rval_expr_eval_int+131> "\211E̋E\314\301\350\037\017\266\300H\205\300\017\204p\036" end = 0x7ffcbf709c20 "\220\235p\277\374\177" crt = 0x7ffcbf709c00 "\220\235p\277\374\177" cmd = 0x7f73f2eb0db0 len = 32627 user = -219400368 uri = {user = {s = 0x7f73f2ec3770 "\002", len = -217304528}, passwd = {s = 0x1f3747ad0 <error: Cannot access memory at address 0x1f3747ad0>, len = 10194964}, host = {s = 0x7ffcbf709900 "\260\231p\277\374\177", len = -311958360}, port = {s = 0x7f73f2ef7a88 "\004", len = -1083138808}, params = {s = 0x7f73f2ec3770 "\002", len = -217304528}, sip_params = { --Type <RET> for more, q to quit, c to continue without paging-- s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 67108864}, headers = { s = 0x7ffcbf709980 "02\f\363s\177", len = 4519307}, port_no = 0, proto = 0, type = ERROR_URI_T, flags = (unknown: 0xf30c3230), transport = { s = 0x7f73f2ef6ee0 <incomplete sequence \344>, len = -1083134368}, ttl = { s = 0x7f73f2e63a28 "SDj4oqe01-38b51cd5c133af2f2994e7b7149891fe-v300g00030::re_analyse_customer", len = 74}, user_param = { s = 0x100000000 <error: Cannot access memory at address 0x100000000>, len = 139952309}, maddr = {s = 0x7f73f2ec0ff0 "e\017\354\362s\177", len = -217679816}, method = {s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 0}, lr = { s = 0x817213 "INFO", len = 18}, r2 = {s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 67108864}, gr = {s = 0x7ffcbf7099b0 "\200>\354\362s\177", len = 5686778}, transport_val = {s = 0x1 <error: Cannot access memory at address 0x1>, len = -1083138808}, ttl_val = {s = 0x7f73f2ec3758 "\026", len = -217304528}, user_param_val = { s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 67108864}, maddr_val = { s = 0x7ffcbf709ab0 " \234p\277\374\177", len = 6104031}, method_val = {s = 0x7ffcbf709a00 "\260\232p\277\374\177", len = -308238037}, lr_val = {s = 0x7ffcbf709bb0 "\005", len = -219195016}, r2_val = {s = 0x7f73f2ef7a80 "\001", len = -1083139116}, gr_val = { s = 0x7f73f30c3230 "\236\235\177", len = 0}} next_hop = {user = {s = 0x0, len = 0}, passwd = {s = 0x0, len = 0}, host = {s = 0x817213 "INFO", len = 18}, port = { s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 67108864}, params = { s = 0x7ffcbf7097d0 "\360\227p\277\374\177", len = 5688750}, sip_params = {s = 0x7ffcbf7097bc "\001", len = -287473952}, headers = { s = 0x9b9000 <ut_buf_int2str> "", len = 0}, port_no = 38720, proto = 49008, type = 32764, flags = (URI_USER_NORMALIZE | URI_SIP_USER_PHONE | unknown: 0xed64fae8), transport = { s = 0x10091dc88 <error: Cannot access memory at address 0x10091dc88>, len = -287473952}, ttl = {s = 0x7ffcbf709750 "p\227p\277\374\177", len = -312148998}, user_param = {s = 0x7f73f2ebe4d8 "(", len = -287473952}, maddr = {s = 0x7ffcbf709770 "\320zt\363s\177", len = -312143558}, method = {s = 0x7ffcbf709770 "\320zt\363s\177", len = 0}, lr = {s = 0x817213 "INFO", len = 18}, r2 = { s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 67108864}, gr = { s = 0x7ffcbf7097d0 "\360\227p\277\374\177", len = 5628632}, transport_val = {s = 0x7ffcbf709824 "\001", len = -293364992}, ttl_val = { s = 0x9b9000 <ut_buf_int2str> "", len = 1}, user_param_val = {s = 0x817213 "INFO", len = 18}, maddr_val = { s = 0x9b9014 <ut_buf_int2str+20> "1", len = 67108864}, method_val = {s = 0x7ffcbf7097f0 "0\230p\277\374\177", len = 5628752}, lr_val = { s = 0x7ffcbf709824 "\001", len = 1}, r2_val = {s = 0x7ffcbf709830 "", len = 5651808}, gr_val = { s = 0x1bf709830 <error: Cannot access memory at address 0x1bf709830>, len = -1083138808}} u = 0x5 port = 0 dst_host = 0x4000000 i = 4 flags = 0 avp = 0x41c9b8 <dlsym@plt+8> st = {flags = 4077761328, id = 32627, name = {n = 0, s = {s = 0x0, len = -219425232}, re = 0x0}, avp = 0x7f73f30c3230} sct = 0x7f73f2ec3e78 sjt = 0x5d603b <rval_expr_eval_rvint+7593> rve = 0x7f73f2f84a70 --Type <RET> for more, q to quit, c to continue without paging-- mct = 0x7ffcbf709d40 rv = 0x7f73ed5d3474 <w_ds_is_from_list1+946> rv1 = 0x7ffcbf70a284 c1 = {cache_type = 3211826896, val_type = 32764, c = {avp_val = {n = 5686778, s = { s = 0x56c5fa <pv_get_spec_value+879> "\211Ẽ", <incomplete sequence \314>, len = -1083140528}, re = 0x56c5fa <pv_get_spec_value+879>}, pval = {rs = {s = 0x56c5fa <pv_get_spec_value+879> "\211Ẽ", <incomplete sequence \314>, len = -1083140528}, ri = -1083140272, flags = 32764}}, i2s = "\030\021\354\362s\177\000\000\060\062\f\363s\177\000\000\000\227p\277\374\177"} s = {s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 67108864} srevp = {0x817213, 0x12} evp = {data = 0x0, obuf = {s = 0x0, len = 0}, rcv = 0x0, dst = 0x0, req = 0x0, rpl = 0x0, rplcode = 0, mode = 0} mod_f_params = {{type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, { type = NUMBER_ST, u = {number = 2, string = 0x2 <error: Cannot access memory at address 0x2>, str = { s = 0x2 <error: Cannot access memory at address 0x2>, len = 0}, data = 0x2, attr = 0x2, select = 0x2}}, {type = RVE_FREE_FIXUP_ST, u = { number = 0, string = 0x0, str = {s = 0x0, len = 1}, data = 0x0, attr = 0x0, select = 0x0}}, {type = MODFIXUP_ST, u = { number = 140135975607040, string = 0x7f73f30bdb00 "\220\332\v\363s\177", str = {s = 0x7f73f30bdb00 "\220\332\v\363s\177", len = 2}, data = 0x7f73f30bdb00, attr = 0x7f73f30bdb00, select = 0x7f73f30bdb00}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = { s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}} __func__ = "do_action" #6 0x000000000044eee9 in run_actions (h=0x7ffcbf70ae60, a=0x7f73f2f27bf8, msg=0x7f73f30c3230) at core/action.c:1584 t = 0x7f73f2f9edb0 ret = 1 tvb = {tv_sec = 0, tv_usec = 0} tve = {tv_sec = 0, tv_usec = 0} tz = {tz_minuteswest = 0, tz_dsttime = 0} tdiff = 5628752 __func__ = "run_actions" #7 0x000000000043daae in do_action (h=0x7ffcbf70ae60, a=0x7f73f2ec7fc0, msg=0x7f73f30c3230) at core/action.c:703 ret = -5 v = 1 dst = {send_sock = 0x7ffcbf70a290, to = {s = {sa_family = 50682, sa_data = "V\000\v\000\000\000\a\000\000\000\000\000\000"}, sin = { sin_family = 50682, sin_port = 86, sin_addr = {s_addr = 11}, sin_zero = "\a\000\000\000\000\000\000"}, sin6 = {sin6_family = 50682, sin6_port = 86, sin6_flowinfo = 11, sin6_addr = {__in6_u = {__u6_addr8 = "\a\000\000\000\000\000\000\000\337\023of\000\000\000", __u6_addr16 = {7, 0, 0, 0, 5087, 26223, 0, 0}, __u6_addr32 = {7, 0, 1718555615, 0}}}, sin6_scope_id = 33089760}, sas = { ss_family = 50682, --Type <RET> for more, q to quit, c to continue without paging-- __ss_padding = "V\000\v\000\000\000\a\000\000\000\000\000\000\000\337\023of\000\000\000\000\340\350\370\001\000\000\000\000X\000\000\000\000\000\000\000\337\023of\000\000\000\000\261\071\344-\000\000\000\000#\000\000\000!", '\000' <repeats 11 times>, "\005\000\000\000|\000\000\000\000\000\000\000\247\000\000\000\001\000\000\000\374\177\000\000\060*\000\000\000\000\000\000p\033\306\001\000\000\000\000Ȗ\203\356\000\000\000", __ss_align = 140135982463696}}, id = 0, send_flags = {f = 1, blst_imask = 0}, proto = 0 '\000', proto_pad0 = 0 '\000', proto_pad1 = 0} tmp = 0x7f73f2ebc8f0 "\002" new_uri = 0x5d29a4 <rval_expr_eval_int+1608> "\211E̋E\314\301\350\037\017\266\300H\205\300\017\205\272\030" end = 0x7ffcbf70a470 "\340\245p\277\374\177" crt = 0x7f73f2ebc988 "\001" cmd = 0x7f73f315ca68 len = 0 user = 5268014 uri = {user = {s = 0x7f73f30c3230 "\236\235\177", len = -1083134368}, passwd = {s = 0x7ffcbf70a270 "", len = -219409808}, host = { s = 0x7ffcbf70a2b4 "\001", len = -1083137496}, port = {s = 0x7f73f30c3230 "\236\235\177", len = -1083134368}, params = { s = 0x7f73f30c3230 "\236\235\177", len = -1083134368}, sip_params = { s = 0x35343537313433fb <error: Cannot access memory at address 0x35343537313433fb>, len = -994177024}, headers = { s = 0x7f73f37f7dc0 <_nl_C_LC_TIME> "\235\234{\363s\177", len = -994177024}, port_no = 42480, proto = 500, type = ERROR_URI_T, flags = (unknown: 0x2010), transport = {s = 0x71 <error: Cannot access memory at address 0x71>, len = 33089744}, ttl = { s = 0x7f73f37fac80 <main_arena> "", len = 33097952}, user_param = {s = 0x1900000001 <error: Cannot access memory at address 0x1900000001>, len = -1083136992}, maddr = {s = 0x7ffcbf70a120 "\340\350\370\001", len = -1083137536}, method = { s = 0x1f8e8e0 "<134>Jun 16 19:33:35 /usr/sbin/kamailio[3417545]: INFO: <script>: [j4oqe] A_PROFILE = S=hel-sbc;FMTIN=SUBABR;SOTEAC=104;DLGLIMIT=1000", len = -219409800}, lr = {s = 0x1 <error: Cannot access memory at address 0x1>, len = 33089744}, r2 = {s = 0x7f73f37fac80 <main_arena> "", len = -994177024}, gr = {s = 0x0, len = 5697090}, transport_val = {s = 0xb <error: Cannot access memory at address 0xb>, len = 0}, ttl_val = {s = 0x817213 "INFO", len = 18}, user_param_val = { s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 67108864}, maddr_val = { s = 0x7ffcbf70a300 "p\244p\277\374\177", len = 6106005}, method_val = {s = 0x7ffcbf70a300 "p\244p\277\374\177", len = -211093163}, lr_val = {s = 0x1f4a5f0 ":j\346\001", len = -211240841}, r2_val = {s = 0x7f73f2ec20d0 "\031", len = -1083136992}, gr_val = { s = 0x7f73f30c3230 "\236\235\177", len = -1083134368}} next_hop = {user = {s = 0x0, len = 0}, passwd = {s = 0x0, len = 0}, host = {s = 0x817213 "INFO", len = 18}, port = { s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 0}, params = {s = 0x7f73f2ec19a8 "\001", len = -1083137360}, sip_params = {s = 0x7f73f30c3230 "\236\235\177", len = -1083134368}, headers = {s = 0x7f73f2ec1278 "\a", len = -1083137356}, port_no = 12848, proto = 62220, type = 32627, flags = (unknown: 0xbf70ae60), transport = { s = 0x7ffcbf70a010 "\320zt\363s\177", len = -217304528}, ttl = {s = 0x7f73f2ebe4d8 "(", len = -1083134368}, user_param = {s = 0x0, len = 0}, maddr = {s = 0x100817213 <error: Cannot access memory at address 0x100817213>, len = 0}, method = { s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 67108864}, lr = { s = 0x7ffcbf70a060 "02\f\363s\177", len = 5968374}, r2 = { s = 0xecb1845e031780b5 <error: Cannot access memory at address 0xecb1845e031780b5>, len = -217304528}, gr = {s = 0x7f73f2ec0638 "\002", len = -1083134368}, transport_val = {s = 0x0, len = 0}, ttl_val = {s = 0x817213 "INFO", len = 0}, user_param_val = {s = 0x817213 "INFO", --Type <RET> for more, q to quit, c to continue without paging-- len = 18}, maddr_val = {s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 67108864}, method_val = { s = 0x7ffcbf70a190 "", len = 6104031}, lr_val = {s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 0}, r2_val = {s = 0x7ffcbf70a190 "", len = 6119483}, gr_val = {s = 0x7f73f2ec19a0 "\001", len = -1083137360}} u = 0x7ffcbf70a500 port = 0 dst_host = 0x56cdae <pv_printf_mode+1759> i = 5 flags = -1 avp = 0x7f73f3747ad0 <syslog> st = {flags = 3211829568, id = 32764, name = {n = -1083137792, s = {s = 0x7ffcbf70a100 "\001", len = -209736576}, re = 0x7ffcbf70a100}, avp = 0xc06abc75c4be1000} sct = 0x7f73f2ec2800 sjt = 0x4000000 rve = 0x7f73f2ec45a8 mct = 0x7ffcbf70a590 rv = 0x6cbf77 <search_next_avp+1782> rv1 = 0x12 c1 = {cache_type = 3211829024, val_type = 32764, c = {avp_val = {n = 5686778, s = { s = 0x56c5fa <pv_get_spec_value+879> "\211Ẽ", <incomplete sequence \314>, len = 0}, re = 0x56c5fa <pv_get_spec_value+879>}, pval = { rs = {s = 0x56c5fa <pv_get_spec_value+879> "\211Ẽ", <incomplete sequence \314>, len = 0}, ri = -1083137416, flags = 32764}}, i2s = "\200\022\354\362s\177\000\000\060\062\f\363s\177\000\000`\237p\277\374\177"} s = {s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = 67108864} srevp = {0x817213, 0x12} evp = {data = 0x0, obuf = {s = 0x0, len = 0}, rcv = 0x0, dst = 0x0, req = 0x0, rpl = 0x0, rplcode = 0, mode = 0} mod_f_params = {{type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, { type = NUMBER_ST, u = {number = 2, string = 0x2 <error: Cannot access memory at address 0x2>, str = { s = 0x2 <error: Cannot access memory at address 0x2>, len = 0}, data = 0x2, attr = 0x2, select = 0x2}}, {type = RVE_FREE_FIXUP_ST, u = { number = 0, string = 0x0, str = {s = 0x0, len = 1}, data = 0x0, attr = 0x0, select = 0x0}}, {type = MODFIXUP_ST, u = { number = 140135975607040, string = 0x7f73f30bdb00 "\220\332\v\363s\177", str = {s = 0x7f73f30bdb00 "\220\332\v\363s\177", len = 2}, data = 0x7f73f30bdb00, attr = 0x7f73f30bdb00, select = 0x7f73f30bdb00}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = { s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}} __func__ = "do_action" #8 0x000000000044eee9 in run_actions (h=0x7ffcbf70ae60, a=0x7f73f2ec7180, msg=0x7f73f30c3230) at core/action.c:1584 t = 0x7f73f2ec7fc0 --Type <RET> for more, q to quit, c to continue without paging-- ret = 1 tvb = {tv_sec = 0, tv_usec = 0} tve = {tv_sec = 0, tv_usec = 0} tz = {tz_minuteswest = 0, tz_dsttime = 0} tdiff = 18 __func__ = "run_actions" #9 0x0000000000441544 in do_action (h=0x7ffcbf70ae60, a=0x7f73f2edb190, msg=0x7f73f30c3230) at core/action.c:1070 ret = 1 v = 1 dst = {send_sock = 0x7ffcbf70ab30, to = {s = {sa_family = 12309, sa_data = "o\000\000\000\000\000\030q\006\363s\177\000"}, sin = { sin_family = 12309, sin_port = 111, sin_addr = {s_addr = 0}, sin_zero = "\030q\006\363s\177\000"}, sin6 = {sin6_family = 12309, sin6_port = 111, sin6_flowinfo = 0, sin6_addr = {__in6_u = {__u6_addr8 = "\030q\006\363s\177\000\000ȴ\r\363s\177\000", __u6_addr16 = { 28952, 62214, 32627, 0, 46280, 62221, 32627, 0}, __u6_addr32 = {4077285656, 32627, 4077761736, 32627}}}, sin6_scope_id = 3211832254}, sas = {ss_family = 12309, __ss_padding = "o\000\000\000\000\000\030q\006\363s\177\000\000ȴ\r\363s\177\000\000\276\253p\277\374\177\000\000\277\253p\277\374\177\000\000ג\232\000\000\000\000\000\207\217\232\000\000\000\000\000\070\204\210\000\000\000\000\000X\222\210\000\000\000\000\000@\000\000\000\000\000\000\000\020\360\337\362s\177\000\000\317v\331\362s\177", '\000' <repeats 12 times>, "\200\000\000\000\000\000`\333H\000\000\000\000", __ss_align = 2564280}}, id = 3613856, send_flags = {f = 0, blst_imask = 1285}, proto = -72 '\270', proto_pad0 = -55 '\311', proto_pad1 = 65} tmp = 0x6f347e <qm_malloc+2449> "H\213E\270H\203\300\070\351Q\003" new_uri = 0x6fc5e1 <qm_info+46> "H\213E\370H\213P\bH\213E\340H\211\020H\213E\340H\307@(\b" end = 0xe8 <error: Cannot access memory at address 0xe8> crt = 0x7ffcbf70ad50 "P\256p\277\374\177" cmd = 0x7f73f2ea8a48 len = 0 user = 10129593 uri = {user = {s = 0x7ffcbf70a910 "@\251p\277\374\177", len = -306704723}, passwd = { s = 0xcf3747ad0 <error: Cannot access memory at address 0xcf3747ad0>, len = 0}, host = {s = 0x800000 <_IO_stdin_used> "\001", len = 4774584}, port = {s = 0x4002720f8 <error: Cannot access memory at address 0x4002720f8>, len = 8943776}, params = { s = 0x41c9b8 <dlsym@plt+8> "", len = 8}, sip_params = {s = 0x7ffcbf70aa30 "0\253p\277\374\177", len = 7759464}, headers = { s = 0x7ffcbf70a940 "\220\256\r\363s\177", len = 4964313}, port_no = 0, proto = 0, type = ERROR_URI_T, flags = (unknown: 0x86f0d4), transport = {s = 0x7ffcbf70aa30 "0\253p\277\374\177", len = 7286805}, ttl = {s = 0x7f73f30dae90 "\001", len = -217682128}, user_param = { s = 0x7ffcbf70aabe "\005\005\270\311A", len = -1083135297}, maddr = {s = 0x9a92d7 <buf+1079> "", len = 10129198}, method = { s = 0x888438 <__func__.3> "parse_via", len = 8950360}, lr = {s = 0x40 <error: Cannot access memory at address 0x40>, len = 7325153}, r2 = { s = 0x7ffcbf70a9d0 "", len = -220205040}, gr = {s = 0x7f73f30db538 "p", len = -220205040}, transport_val = { s = 0x7ffcbf70aa10 "@\252p\277\374\177", len = -306704723}, ttl_val = { s = 0xe00000030 <error: Cannot access memory at address 0xe00000030>, len = 0}, user_param_val = {s = 0x800000 <_IO_stdin_used> "\001", len = 4774048}, maddr_val = {s = 0x4002722a8 <error: Cannot access memory at address 0x4002722a8>, len = 8943776}, method_val = { --Type <RET> for more, q to quit, c to continue without paging-- s = 0x41c9b8 <dlsym@plt+8> "", len = 8}, lr_val = {s = 0x7ffcbf70ab30 "", len = 7759464}, r2_val = { s = 0x7ffcbf70aa40 "\030q\006\363s\177", len = 4964313}, gr_val = {s = 0x0, len = 8843476}} next_hop = {user = {s = 0x400bf70a760 <error: Cannot access memory at address 0x400bf70a760>, len = -274094048}, passwd = { s = 0x7ffcbf70a860 "\030\220\233", len = -291376120}, host = {s = 0x7ffcbf70a770 "\240\247p\277\374\177", len = -221810361}, port = { s = 0x7ffcbf70a780 "\240\247p\277\002", len = -221810334}, params = {s = 0x7ffcbf70a7a0 "", len = -291376120}, sip_params = { s = 0x2bf70a7a0 <error: Cannot access memory at address 0x2bf70a7a0>, len = -220676760}, headers = { s = 0x9a8f04 <buf+100> "=a92.6fd>\r\nVia: SIP/2.0/UDP 172.19.194.20;branch=z9hG4bKa617.ff0b5b66aa6563c47d53617f4dbe74b8.0\r\nVia: SIP/2.0/UDP 172.20.14.4:5060;branch=z9hG4bK87n3qi108gc8rbe9pi50.1\r\nMax-Forwards: 67\r\nFrom: \"HUONE_"..., len = -282320808}, port_no = 43264, proto = 49008, type = 32764, flags = 0, transport = {s = 0x9b8ec0 <def_list> "\210\237\024\357s\177", len = 10194984}, ttl = { s = 0x7f73f3747ad0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330>, len = -274093472}, user_param = { s = 0x7ffcbf70a8d0 "", len = -221447870}, maddr = {s = 0x7ffcbf70a900 "0\252p\277\374\177", len = -274094048}, method = { s = 0x400bf70ac60 <error: Cannot access memory at address 0x400bf70ac60>, len = -274093928}, lr = { s = 0xffffffffbf70a830 <error: Cannot access memory at address 0xffffffffbf70a830>, len = 1}, r2 = { s = 0x50bf70a930 <error: Cannot access memory at address 0x50bf70a930>, len = -274093912}, gr = { s = 0x7f73efb402f0 "KDMQ sip:dialog@172.19.194.28:5060 SIP/2.0\r\nVia: SIP/2.0/UDP 172.19.194.20;branch=z9hG4bK5d89.f6002b35", '0' <repeats 24 times>, ".0\r\nTo: <sip:dialog@172.19.194.28:5060>\r\nFrom: <sip:dialog@172.19.194.20:5"..., len = -1083134880}, transport_val = { s = 0x7ffcbf70a9c8 "", len = -1083135540}, ttl_val = {s = 0xc800000000 <error: Cannot access memory at address 0xc800000000>, len = -274094048}, user_param_val = {s = 0x9b9028 <_xavi_list_head> "", len = 10194976}, maddr_val = {s = 0x9b9018 <_xavp_list_head> "", len = 10194664}, method_val = {s = 0x1 <error: Cannot access memory at address 0x1>, len = 0}, lr_val = {s = 0x817213 "INFO", len = 7325153}, r2_val = {s = 0x7ffcbf70a8d0 "", len = -220205040}, gr_val = {s = 0x7f73f3066fa0 "`", len = -220205040}} u = 0x9a92d7 <buf+1079> port = 0 dst_host = 0x7f73f30db490 i = 2 flags = 32764 avp = 0x875a18 <__func__.21> st = {flags = 4012646488, id = 32627, name = {n = -293601280, s = {s = 0x7f73ee800000 "", len = -1083136048}, re = 0x7f73ee800000}, avp = 0x7f73ed4b0c06 <dmq_tm_callback+2807>} sct = 0x7ffcbf70abe0 sjt = 0x7f73f2dff010 rve = 0x7f73f2ec2f30 mct = 0x7f73edb80ead <pkg_proc_update_stats+115> rv = 0x7f73ed4d8a9c rv1 = 0x72eeb1 <parse_cseq+2542> c1 = {cache_type = 4084497104, val_type = 32627, c = {avp_val = {n = 67108864, s = { s = 0x104000000 <error: Cannot access memory at address 0x104000000>, len = -1083136240}, re = 0x104000000}, pval = {rs = { s = 0x104000000 <error: Cannot access memory at address 0x104000000>, len = -1083136240}, ri = 7335103, flags = 0}}, --Type <RET> for more, q to quit, c to continue without paging-- i2s = "\242\207M\355s\177\000\000\000\000\200\356G\000\000\000\360\210M\355s\177"} s = {s = 0x817213 "INFO", len = -293366072} srevp = {0x7ffcbf70a6d0, 0x6eff50 <futex_release+29>} evp = {data = 0x0, obuf = {s = 0x0, len = 0}, rcv = 0x0, dst = 0x0, req = 0x0, rpl = 0x0, rplcode = 0, mode = 0} mod_f_params = {{type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, { type = NUMBER_ST, u = {number = 2, string = 0x2 <error: Cannot access memory at address 0x2>, str = { s = 0x2 <error: Cannot access memory at address 0x2>, len = 0}, data = 0x2, attr = 0x2, select = 0x2}}, {type = RVE_FREE_FIXUP_ST, u = { number = 0, string = 0x0, str = {s = 0x0, len = 1}, data = 0x0, attr = 0x0, select = 0x0}}, {type = MODFIXUP_ST, u = { number = 140135975607040, string = 0x7f73f30bdb00 "\220\332\v\363s\177", str = {s = 0x7f73f30bdb00 "\220\332\v\363s\177", len = 2}, data = 0x7f73f30bdb00, attr = 0x7f73f30bdb00, select = 0x7f73f30bdb00}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = { s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}} __func__ = "do_action" #10 0x000000000044eee9 in run_actions (h=0x7ffcbf70ae60, a=0x7f73f2eb81c0, msg=0x7f73f30c3230) at core/action.c:1584 t = 0x7f73f2edb190 ret = 1 tvb = {tv_sec = 0, tv_usec = 0} tve = {tv_sec = 0, tv_usec = 0} tz = {tz_minuteswest = -217304528, tz_dsttime = 32627} tdiff = 4077287896 __func__ = "run_actions" #11 0x000000000044f653 in run_top_route (a=0x7f73f2eb81c0, msg=0x7f73f30c3230, c=0x0) at core/action.c:1669 ctx = {rec_lev = 3, run_flags = 0, last_retcode = 1, jmp_env = {{__jmpbuf = {4294967296, -1391185268927135563, 8483347, 18, 140135982463696, 67108864, -1391185268977467211, 1389635598856192181}, __mask_was_saved = 0, __saved_mask = {__val = {6227793, 4294967752, 140135975629360, 8483347, 18, 140135982463696, 67108864, 140135975632848, 10129605, 140135975252904, 0, 4611686022722355200, 0, 4294967296, 4294967296, 8483347}}}}} p = 0x7ffcbf70ae60 ret = -210470192 sfbk = 0 #12 0x000000000058652e in receive_msg ( buf=0x9a8ea0 <buf> "INVITE sip:yyy@hostname:5060 SIP/2.0\r\nRecord-Route: <sip:172.19.194.20;lr;did=a92.6fd>\r\nVia: SIP/2.0/UDP 172.19.194.20;branch=z9hG4bKa617.ff0b5b66aa6563c47d53617f4dbe74b8.0\r\nVia"..., len=1079, rcv_info=0x7ffcbf70b4d0) at core/receive.c:501 msg = 0x7f73f30c3230 ctx = {rec_lev = 0, run_flags = 0, last_retcode = 0, jmp_env = {{__jmpbuf = {4702111234474983745, 4702111234474983745, 4702111234474983745, 4702111234474983745, 0, 0, 0, 0}, __mask_was_saved = 437918234, __saved_mask = {__val = {1880844493789993498, 1880844493789993498, --Type <RET> for more, q to quit, c to continue without paging-- 1880844493789993498, 0, 0, 0, 0, 2314885530818453536, 2314885530818453536, 2314885530818453536, 2314885530818453536, 0, 0, 0, 0, 4702111234474983745}}}}} bctx = 0x0 ret = 0 tvb = {tv_sec = 0, tv_usec = 0} tve = {tv_sec = 0, tv_usec = 0} diff = 0 inb = { s = 0x9a8ea0 <buf> "INVITE sip:yyy@hostname:5060 SIP/2.0\r\nRecord-Route: <sip:172.19.194.20;lr;did=a92.6fd>\r\nVia: SIP/2.0/UDP 172.19.194.20;branch=z9hG4bKa617.ff0b5b66aa6563c47d53617f4dbe74b8.0\r\nVia"..., len = 1079} netinfo = {data = {s = 0x0, len = 0}, rcv = 0x0, dst = 0x0} keng = 0x0 evp = {data = 0x7ffcbf70b040, obuf = {s = 0x0, len = 0}, rcv = 0x7ffcbf70b4d0, dst = 0x0, req = 0x0, rpl = 0x0, rplcode = 0, mode = 0} cidlockidx = 0 cidlockset = 0 errsipmsg = 0 exectime = 0 __func__ = "receive_msg" #13 0x00000000006c860a in udp_rcv_loop () at core/udp_server.c:543 len = 1079 buf = "INVITE sip:yyy@hostname:5060 SIP/2.0\r\nRecord-Route: <sip:172.19.194.20;lr;did=a92.6fd>\r\nVia: SIP/2.0/UDP 172.19.194.20;branch=z9hG4bKa617.ff0b5b66aa6563c47d53617f4dbe74b8.0\r\nVia"... tmp = 0x1eee34928 <error: Cannot access memory at address 0x1eee34928> fromaddr = 0x7f73f30d68d8 fromaddrlen = 16 rcvi = {src_ip = {af = 2, len = 4, u = {addrl = {348263340, 0}, addr32 = {348263340, 0, 0, 0}, addr16 = {5036, 5314, 0, 0, 0, 0, 0, 0}, addr = "\254\023\302\024", '\000' <repeats 11 times>}}, dst_ip = {af = 2, len = 4, u = {addrl = {348263340, 0}, addr32 = {348263340, 0, 0, 0}, addr16 = {5036, 5314, 0, 0, 0, 0, 0, 0}, addr = "\254\023\302\024", '\000' <repeats 11 times>}}, src_port = 5060, dst_port = 5060, proto_reserved1 = 0, proto_reserved2 = 0, src_su = {s = {sa_family = 2, sa_data = "\023Ĭ\023\302\024\000\000\000\000\000\000\000"}, sin = {sin_family = 2, sin_port = 50195, sin_addr = {s_addr = 348263340}, sin_zero = "\000\000\000\000\000\000\000"}, sin6 = {sin6_family = 2, sin6_port = 50195, sin6_flowinfo = 348263340, sin6_addr = { __in6_u = {__u6_addr8 = '\000' <repeats 15 times>, __u6_addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}, sas = {ss_family = 2, __ss_padding = "\023Ĭ\023\302\024", '\000' <repeats 111 times>, __ss_align = 0}}, bind_address = 0x7f73f2e91490, rflags = 0, proto = 1 '\001', proto_pad0 = 0 '\000', proto_pad1 = 0} evp = {data = 0x0, obuf = {s = 0x0, len = 0}, rcv = 0x0, dst = 0x0, req = 0x0, rpl = 0x0, rplcode = 0, mode = 0} printbuf = '\000' <repeats 88 times>, "\320>\343\356s\177\000\000\023r\201\000\000\000\000\000\022\000\000\000\000\000\000\000\320zt\363s\177\000\000\000\000\000\004\000\000\000\000гp\277\374\177\000\000m\301b", '\000' <repeats 41 times>, "\004\000\000\000\350\006\353\362\004", '\000' <repeats 91--Type <RET> for more, q to quit, c to continue without paging-- times>... i = -1 j = 43776 l = 4 __func__ = "udp_rcv_loop" #14 0x000000000042c56a in main_loop () at main.c:1730 i = 3 pid = 0 si = 0x7f73f2e91490 si_desc = "udp receiver child=3 sock=172.19.194.20:5060\000\000\000\000@\274p\277\374\177\000\000\023r\201\000\000\000\000\000\022\000\000\000\000\000\000\000\320zt\363s\177\000\000H\212\352\362s\177\000\000j{t\363s\177\000\000\060\000\000\000\060\000\000\000\370\267p\277\374\177\000\000\020\267p\277\374\177\000\000\000\020\276\304u\274j\300" nrprocs = 4 woneinit = 1 __func__ = "main_loop" #15 0x0000000000438191 in main (argc=11, argv=0x7ffcbf70bd58) at main.c:3061 cfg_stream = 0x1b9a2d0 c = -1 r = 0 tmp = 0x7ffcbf70deb7 "" tmp_len = 0 port = 0 proto = 0 ahost = 0x0 aport = 0 options = 0x803128 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 2043858912 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 2 n_lst = 0x40 p = 0x1600000 <error: Cannot access memory at address 0x1600000> st = {st_dev = 25, st_ino = 179668, st_nlink = 2, st_mode = 16832, st_uid = 978, st_gid = 978, __pad0 = 0, st_rdev = 0, st_size = 100, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1717103055, tv_nsec = 713677547}, st_mtim = {tv_sec = 1717103910, tv_nsec = 470641633}, st_ctim = {tv_sec = 1717103910, tv_nsec = 470641633}, __glibc_reserved = {0, 0, 0}} --Type <RET> for more, q to quit, c to continue without paging-- tbuf = "\342\\\256\363s\177\000\000\070\033\253\363s\177\000\000йp\277\374\177\000\000\a\000\000\000\000\000\000\000\330\b\253\363s\177\000\000\a\000\000\000#\000\000\000\060j\256\363s\177\000\000\005\067\254\363s\177\000\000\000\000\000\000\000\000\000\000\320I\254\363s\177\000\000\070\000a\363s\177\000\000\020\353\252\363s\177\000\000\000\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\240\271p\277\374\177\000\000\330\032\253\363s\177\000\000\330\032\253\363s\177\000\000\000\000\000\000\000\000\000\000\270\371\252\363s\177\000\000\240\271p\277\374\177\000\000\220u\256\363s\177\000\000\000\000\253\363s\177\000\000\022\f\253\363s\177\000\000F\001\254\363s\177\000\000\344#`\363s\177\000\000\232"... option_index = 12 long_options = {{name = 0x805796 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x8004f4 "version", has_arg = 0, flag = 0x0, val = 118}, { name = 0x80579b "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x8057a1 "subst", has_arg = 1, flag = 0x0, val = 1025}, { name = 0x8057a7 "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x8057b0 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, { name = 0x8057ba "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x8057c4 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, { name = 0x8057cf "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0x8057d8 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, { name = 0x8057e3 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0x8057e9 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, { name = 0x8057f3 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" (gdb) (gdb) info locals hash = 14 p_entry = 0x7f73eee13730 (gdb) list 481 p_entry = &linker->profile->entries[hash]; 482 lock_get( &linker->profile->lock ); 483 if (p_entry->first) { 484 linker->hash_linker.prev = p_entry->first->prev; 485 linker->hash_linker.next = p_entry->first; 486 p_entry->first->prev->next = &linker->hash_linker; 487 p_entry->first->prev = &linker->hash_linker; 488 } else { 489 p_entry->first = linker->hash_linker.next 490 = linker->hash_linker.prev = &linker->hash_linker; ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3878 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3878(a)github.com>

3 4

[kamailio/kamailio] Hello, I would like to confirm if our SMS module supports sending long SMS messages ？ (Issue #3822)
by Helloworld1668 13 Aug '24

13 Aug '24

### Description  Hello, when I was testing the SMSC SMS business, I found that the SMS could not be forwarded by the SMSC when the characters were too long, approximately 117 characters. The issue was traced back to the smsops module, which has a limit on the length of the SMS, but it seems that it does not handle SMS segmentation. The error message returned is as follows. Could you please provide some suggestions and help? ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages ``` 2024-04-24T05:59:01.837950514Z 3(24) ERROR: <script>: SMS for "" (Valid: 0 ) 2024-04-24T05:59:14.466167796Z 2(23) ERROR: <script>: 3GPP-SMS: MESSAGE (sip:+8618107550088@ims.mnc011.mcc460.3gppnetwork.org (172.22.0.20:6060) to tel:+8613800138000, bnecb4LQJ(a)10.46.2.1) 2024-04-24T05:59:14.466173859Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length! 2024-04-24T05:59:14.466175929Z 2(23) ERROR: smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! 2024-04-24T05:59:14.466191554Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length! 2024-04-24T05:59:14.466194545Z 2(23) ERROR: smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! 2024-04-24T05:59:14.466196517Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length! 2024-04-24T05:59:14.466198406Z 2(23) ERROR: smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! 2024-04-24T05:59:14.466200311Z 2(23) ERROR: <script>: SMS for "" (Valid: ) 2024-04-24T05:59:14.466255812Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length! 2024-04-24T05:59:14.466276249Z 2(23) ERROR: smsops [smsops_impl.c:1903]: isRPDATA(): Error getting/decoding RP-Data from request! ``` #### SIP Traffic  ``` ``` ![image](https://github.com/kamailio/kamailio/assets/152272255/808e65ce-9763-4056-9924-77122f6d9c25) ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 4fb8ac -dirty compiled on 03:11:49 Apr 24 2024 with gcc 9.4.0 ``` version: kamailio 5.9.0-dev0 (x86_64/linux) 4fb8ac-dirty flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB ``` * **Operating System**:  ``` Linux sder 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3822 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3822(a)github.com>

3 5

[kamailio/kamailio] secfilter: export functions to KEMI (PR #3945)
by bazrafshan.m.h 12 Aug '24

12 Aug '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  * All functions are exported to kemi You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3945 -- Commit Summary -- * secfilter is fully KEMIized * secfilter: fix the failed format check -- File Changes -- M src/modules/secfilter/secfilter.c (88) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3945.patch https://github.com/kamailio/kamailio/pull/3945.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3945 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3945(a)github.com>

2 6

[kamailio/kamailio] cdp: Functions are exported in KEMI (PR #3942)
by bazrafshan.m.h 11 Aug '24

11 Aug '24

- Added `cdp_has_app` function: - Accepts a single parameter: - `application`: The Application ID. - Added `cdp_has_app2` function: - Accepts two parameters: - `vendorid`: The Vendor ID associated with the application. - `application`: The Application ID. - Added cdp_check_peer function: - Accepts one parameter: - `fqdn`: the Fully qualified domain name of the peer, that should be checked. The parameter may contain pseudovariables. NOTE: All parameters are passed as standard strings.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3942 -- Commit Summary -- * cdp: export all functions in KEMI module -- File Changes -- M src/modules/cdp/cdp_mod.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3942.patch https://github.com/kamailio/kamailio/pull/3942.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3942 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3942(a)github.com>

1 1

[kamailio/kamailio] cdp: export functions to KEMI (PR #3941)
by bazrafshan.m.h 11 Aug '24

11 Aug '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  * Exporting all cdp functions to KEMI You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3941 -- Commit Summary -- * secfilter: all functions are exported in KEMI * cdp: ki_cdp_check_peer() KEMIized * cdp: export all functions in KEMI module -- File Changes -- M src/modules/cdp/cdp_mod.c (34) M src/modules/secfilter/secfilter.c (88) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3941.patch https://github.com/kamailio/kamailio/pull/3941.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3941 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3941(a)github.com>

1 1

git:master:8361471e: dispatcher: use char for oc distribution array
by Daniel-Constantin Mierla 10 Aug '24

10 Aug '24

Module: kamailio Branch: master Commit: 8361471e6ec49d3b92443e0ddd728bf665460c02 URL: https://github.com/kamailio/kamailio/commit/8361471e6ec49d3b92443e0ddd728bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-09T16:04:11+02:00 dispatcher: use char for oc distribution array - reduce array size --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatch.h --- Diff: https://github.com/kamailio/kamailio/commit/8361471e6ec49d3b92443e0ddd728bf… Patch: https://github.com/kamailio/kamailio/commit/8361471e6ec49d3b92443e0ddd728bf… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 95f0128f9bd..f17963cc3bf 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -143,6 +143,7 @@ static void ds_run_route( struct sip_msg *msg, str *uri, char *route, ds_rctx_t *rctx); void shuffle_uint100array(unsigned int *arr); +void shuffle_char100array(char *arr); int ds_reinit_rweight_on_state_change( int old_state, int new_state, ds_set_t *dset); @@ -442,12 +443,12 @@ void ds_oc_prepare(ds_dest_t *dp) { int i; for(i = 0; i < dp->ocdata.ocrate; i++) { - dp->ocdata.ocdist[i] = 0; + dp->ocdata.ocdist[i] = '0'; } for(i = dp->ocdata.ocrate; i < 100; i++) { - dp->ocdata.ocdist[i] = 1; + dp->ocdata.ocdist[i] = '1'; } - shuffle_uint100array(dp->ocdata.ocdist); + shuffle_char100array(dp->ocdata.ocdist); } /** @@ -525,7 +526,7 @@ static inline int ds_oc_skip(ds_set_t *dsg, int alg, int n) LM_DBG("time validity not matching\n"); return 0; } - if(dsg->dlist[n].ocdata.ocdist[dsg->dlist[n].ocdata.ocidx] == 1) { + if(dsg->dlist[n].ocdata.ocdist[dsg->dlist[n].ocdata.ocidx] == '1') { /* use it */ ret = 0; } else { @@ -793,6 +794,23 @@ void shuffle_uint100array(unsigned int *arr) } +/* for internal usage; arr must be arr[100] */ +void shuffle_char100array(char *arr) +{ + int k; + int j; + char t; + if(arr == NULL) + return; + for(j = 0; j < 100; j++) { + k = j + (kam_rand() % (100 - j)); + t = arr[j]; + arr[j] = arr[k]; + arr[k] = t; + } +} + + /** * Initialize the relative weight distribution for a destination set * - fill the array of 0..99 elements where to keep the index of the diff --git a/src/modules/dispatcher/dispatch.h b/src/modules/dispatcher/dispatch.h index ed0ceb99978..9c1167d6dbe 100644 --- a/src/modules/dispatcher/dispatch.h +++ b/src/modules/dispatcher/dispatch.h @@ -222,10 +222,11 @@ typedef struct _ds_latency_stats { void latency_stats_init(ds_latency_stats_t *latency_stats, int latency, int count); ds_latency_stats_t *latency_stats_find(int group, str *address); +#define DS_OCDIST_SIZE 104 typedef struct _ds_ocdata { uint32_t ocrate; uint32_t ocidx; - uint32_t ocdist[100]; + char ocdist[DS_OCDIST_SIZE]; struct timeval octime; uint32_t ocseq; uint32_t ocmin;

1 0

[kamailio/kamailio] Falta atributo de seguridad en Cookie de Sesión / Falta atributo de HttpOnly en Cookie de Sesión (Issue #3938)
by Diego Godoy 09 Aug '24

09 Aug '24

Necesito solventar para las instancias de synapsis estos dos vulnerabilidades que comparto a continuación. ![image](https://github.com/user-attachments/assets/39d228bd-d35c-455a-9b6e-bd245870f304) ![image](https://github.com/user-attachments/assets/7b967f7c-433a-404b-85b5-710c38f7034f) Gracias -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3938 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3938(a)github.com>

1 1

[kamailio/kamailio] [doc] xhttp_rpc module docs, the route should be "rpc" not "http_rpc"。 (Issue #3937)
by gao114882 08 Aug '24

08 Aug '24

### Description  <img width="486" alt="企业微信截图_17231113172455" src="https://github.com/user-attachments/assets/2a055290-b200-4954-b902-20997760…"> change this to "rpc" ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: compiled on 09:04:36 Aug 8 2024 with gcc 4.8.5``` * **Operating System**:  ``` ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3937 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3937(a)github.com>

1 1

git:master:ad312921: dispatcher: print priority in oclist rpc command
by Daniel-Constantin Mierla 08 Aug '24

08 Aug '24

Module: kamailio Branch: master Commit: ad31292170f632a381c1f95cbf955ca71f046244 URL: https://github.com/kamailio/kamailio/commit/ad31292170f632a381c1f95cbf955ca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-08T10:15:19+02:00 dispatcher: print priority in oclist rpc command --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/ad31292170f632a381c1f95cbf955ca… Patch: https://github.com/kamailio/kamailio/commit/ad31292170f632a381c1f95cbf955ca… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 50ddd1f4c45..a9744ba2c10 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -2287,8 +2287,9 @@ static void dispatcher_rpc_oclist(rpc_t *rpc, void *ctx) rpc->fault(ctx, 500, "Internal error root reply"); return; } - if(rpc->struct_add(th, "dSduuujjuu", "group", group, "uri", - &node->dlist[i].uri, "flags", node->dlist[i].flags, "ocrate", + if(rpc->struct_add(th, "dSdduuujjuu", "group", group, "uri", + &node->dlist[i].uri, "flags", node->dlist[i].flags, + "priority", node->dlist[i].priority, "ocrate", node->dlist[i].ocdata.ocrate, "ocidx", node->dlist[i].ocdata.ocidx, "ocseq", node->dlist[i].ocdata.ocseq, "octime_sec",

1 0

git:master:645b34ce: dispatcher: group overload control attributes in a structure
by Daniel-Constantin Mierla 07 Aug '24

07 Aug '24

Module: kamailio Branch: master Commit: 645b34cec9ee459ea33cb14d8f66e5c58a7ef975 URL: https://github.com/kamailio/kamailio/commit/645b34cec9ee459ea33cb14d8f66e5c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-07T09:39:27+02:00 dispatcher: group overload control attributes in a structure --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatch.h Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/645b34cec9ee459ea33cb14d8f66e5c… Patch: https://github.com/kamailio/kamailio/commit/645b34cec9ee459ea33cb14d8f66e5c…

1 0

git:master:398c40ab: modules: readme files regenerated - dispatcher ... [skip ci]
by Kamailio Dev 06 Aug '24

06 Aug '24

Module: kamailio Branch: master Commit: 398c40ab7969e738ac92abc8b9c8c557b25ef533 URL: https://github.com/kamailio/kamailio/commit/398c40ab7969e738ac92abc8b9c8c55… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-08-06T11:16:10+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README --- Diff: https://github.com/kamailio/kamailio/commit/398c40ab7969e738ac92abc8b9c8c55… Patch: https://github.com/kamailio/kamailio/commit/398c40ab7969e738ac92abc8b9c8c55… --- diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README index 16c10332df7..2a6148504db 100644 --- a/src/modules/dispatcher/README +++ b/src/modules/dispatcher/README @@ -134,6 +134,7 @@ Federico Cabiddu 5.6. dispatcher.add 5.7. dispatcher.remove 5.8. dispatcher.hash + 5.9. dispatcher.oclist 6. Installation and Running @@ -303,6 +304,7 @@ Chapter 1. Admin Guide 5.6. dispatcher.add 5.7. dispatcher.remove 5.8. dispatcher.hash + 5.9. dispatcher.oclist 6. Installation and Running @@ -1672,6 +1674,7 @@ onreply_route { 5.6. dispatcher.add 5.7. dispatcher.remove 5.8. dispatcher.hash + 5.9. dispatcher.oclist 5.1. dispatcher.set_state @@ -1852,6 +1855,22 @@ kamctl rpc dispatcher.hash 0 alice server.com kamctl rpc dispatcher.hash 4 bob server.com ... +5.9. dispatcher.oclist + + List the overload control attributes for the records in a specific + group. + + Name: dispatcher.oclist + + Parameters: + * _group_: destination group id + + Example: +... +# prototype: kamcli dispatcher.oclist _group_ +kamcli dispatcher.oclist 1 +... + 6. Installation and Running 6.1. Destination List File

1 0

git:master:1a56ff54: dispatcher: docs for dispatcher.oclist rpc command
by Daniel-Constantin Mierla 06 Aug '24

06 Aug '24

Module: kamailio Branch: master Commit: 1a56ff54ec1898b8bbc2aae4ab5f4b19eff6ecf5 URL: https://github.com/kamailio/kamailio/commit/1a56ff54ec1898b8bbc2aae4ab5f4b1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-06T11:03:41+02:00 dispatcher: docs for dispatcher.oclist rpc command --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1a56ff54ec1898b8bbc2aae4ab5f4b1… Patch: https://github.com/kamailio/kamailio/commit/1a56ff54ec1898b8bbc2aae4ab5f4b1… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index a17e87f68e7..81d5b19cd00 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -2334,6 +2334,30 @@ DEST: { kamctl rpc dispatcher.hash 0 alice server.com kamctl rpc dispatcher.hash 4 bob server.com ... +</programlisting> + </section> + <section id="dispatcher.r.oclist"> + <title> + <function moreinfo="none">dispatcher.oclist</function> + </title> + <para> + List the overload control attributes for the records in a specific group. + </para> + <para> + Name: <emphasis>dispatcher.oclist</emphasis> + </para> + <para>Parameters:</para> + <itemizedlist> + <listitem><para>_group_: destination group id</para></listitem> + </itemizedlist> + <para> + Example: + </para> +<programlisting format="linespecific"> +... +# prototype: kamcli dispatcher.oclist _group_ +kamcli dispatcher.oclist 1 +... </programlisting> </section>

1 0

git:master:583ab9f2: dispatcher: variables declared at beginning of block
by Daniel-Constantin Mierla 06 Aug '24

06 Aug '24

Module: kamailio Branch: master Commit: 583ab9f29cd7d5c472de2e12087a4c619bc1897f URL: https://github.com/kamailio/kamailio/commit/583ab9f29cd7d5c472de2e12087a4c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-06T10:23:27+02:00 dispatcher: variables declared at beginning of block --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/583ab9f29cd7d5c472de2e12087a4c6… Patch: https://github.com/kamailio/kamailio/commit/583ab9f29cd7d5c472de2e12087a4c6… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 4eefbff1ce3..42fb1e45d68 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1962,6 +1962,8 @@ static void dispatcher_rpc_list(rpc_t *rpc, void *ctx) int n; str smode; int vmode = DS_RPC_PRINT_NORMAL; + ds_set_t *dslist = NULL; + int dslistnr = 0; n = rpc->scan(ctx, "*S", &smode); if(n == 1) { @@ -1972,8 +1974,8 @@ static void dispatcher_rpc_list(rpc_t *rpc, void *ctx) } } - ds_set_t *dslist = ds_get_list(); - int dslistnr = ds_get_list_nr(); + dslist = ds_get_list(); + dslistnr = ds_get_list_nr(); if(dslist == NULL || dslistnr <= 0) { LM_DBG("no destination sets\n");

1 0

git:master:4c481dc9: dispatcher: new rpc command dispatcher.oclist
by Daniel-Constantin Mierla 06 Aug '24

06 Aug '24

Module: kamailio Branch: master Commit: 4c481dc95338d9bb814730d3d4f84ce9670a0ed0 URL: https://github.com/kamailio/kamailio/commit/4c481dc95338d9bb814730d3d4f84ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-06T10:16:04+02:00 dispatcher: new rpc command dispatcher.oclist - list overload control attributes for a specific dispatcher group --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/4c481dc95338d9bb814730d3d4f84ce… Patch: https://github.com/kamailio/kamailio/commit/4c481dc95338d9bb814730d3d4f84ce… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 831bfef7e1a..4eefbff1ce3 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -2253,6 +2253,53 @@ static void dispatcher_rpc_hash(rpc_t *rpc, void *ctx) return; } +static const char *dispatcher_rpc_oclist_doc[2] = { + "List overload control details for a group", 0}; + +/* + * RPC command to set the state of a destination address + */ +static void dispatcher_rpc_oclist(rpc_t *rpc, void *ctx) +{ + int group = 0; + int i = 0; + ds_set_t *node = NULL; + void *th = NULL; + + if(rpc->scan(ctx, "d", &group) != 1) { + rpc->fault(ctx, 500, "Invalid Parameters"); + return; + } + + /* get the index of the set */ + node = ds_list_lookup(group); + if(node == NULL) { + LM_ERR("destination set [%d] not found\n", group); + rpc->fault(ctx, 404, "Destination Group Not Found"); + return; + } + + for(i = 0; i < node->nr; i++) { + /* add entry node */ + if(rpc->add(ctx, "{", &th) < 0) { + rpc->fault(ctx, 500, "Internal error root reply"); + return; + } + if(rpc->struct_add(th, "dSduuujjuu", "group", group, "uri", + &node->dlist[i].uri, "flags", node->dlist[i].flags, "ocrate", + node->dlist[i].attrs.ocrate, "ocidx", node->dlist[i].ocidx, + "ocseq", node->dlist[i].ocseq, "octime_sec", + (unsigned long)node->dlist[i].octime.tv_sec, "octime_usec", + (unsigned long)node->dlist[i].octime.tv_usec, "ocmin", + node->dlist[i].attrs.ocmin, "ocmax", + node->dlist[i].attrs.ocmax) + < 0) { + rpc->fault(ctx, 500, "Internal error main structure"); + return; + } + } +} + /* clang-format off */ rpc_export_t dispatcher_rpc_cmds[] = { {"dispatcher.reload", dispatcher_rpc_reload, @@ -2271,6 +2318,8 @@ rpc_export_t dispatcher_rpc_cmds[] = { dispatcher_rpc_remove_doc, 0}, {"dispatcher.hash", dispatcher_rpc_hash, dispatcher_rpc_hash_doc, 0}, + {"dispatcher.oclist", dispatcher_rpc_oclist, + dispatcher_rpc_oclist_doc, RPC_RET_ARRAY}, {0, 0, 0, 0} }; /* clang-format on */

1 0

[kamailio/kamailio] permissions address failure during checks (Issue #3922)
by Mariah Yang 06 Aug '24

06 Aug '24

r2val(): converting STRING [test] 8(18) DEBUG: permissions [address.c:179]: reload_address_db_table(): Number of rows in address table: 3 8(18) DEBUG: permissions [address.c:191]: reload_address_db_table(): failure during checks of database value 1 (group) in address table 8(18) ERROR: permissions [address.c:233]: reload_address_db_table(): database problem - invalid record mysql> desc ka_address; +---------+-------------+------+-----+---------+-------+ | Field | Type | Null | Key | Default | Extra | +---------+-------------+------+-----+---------+-------+ | id | double | NO | | 0 | | | grp | bigint | NO | | 0 | | | ip_addr | varchar(64) | YES | | NULL | | | mask | bigint | NO | | 0 | | | port | bigint | NO | | 0 | | | tag | varchar(4) | NO | | | | +---------+-------------+------+-----+---------+-------+ when address table use bigint for grp，error happened when load address data -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3922 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3922(a)github.com>

1 4

[kamailio/kamailio] allow address 'grd' 'mask' 'port' fields to be a mysql BIGINT (PR #3923)
by Mariah Yang 06 Aug '24

06 Aug '24

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3923 -- Commit Summary -- * allow address 'grd' 'mask' 'port' fields to be a mysql BIGINT -- File Changes -- M src/modules/permissions/address.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3923.patch https://github.com/kamailio/kamailio/pull/3923.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3923 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3923(a)github.com>

2 6

git:master:4aaaca60: cdp: Error log caused crash
by Morten Tryfoss 05 Aug '24

05 Aug '24

Module: kamailio Branch: master Commit: 4aaaca60ef2207100dd3f4e16ae63428aadc7dc5 URL: https://github.com/kamailio/kamailio/commit/4aaaca60ef2207100dd3f4e16ae6342… Author: Morten Tryfoss <morten(a)tryfoss.no> Committer: Morten Tryfoss <morten(a)tryfoss.no> Date: 2024-08-05T12:14:04+02:00 cdp: Error log caused crash --- Modified: src/modules/cdp/receiver.c --- Diff: https://github.com/kamailio/kamailio/commit/4aaaca60ef2207100dd3f4e16ae6342… Patch: https://github.com/kamailio/kamailio/commit/4aaaca60ef2207100dd3f4e16ae6342… --- diff --git a/src/modules/cdp/receiver.c b/src/modules/cdp/receiver.c index e03307c5e84..67a3a8e6feb 100644 --- a/src/modules/cdp/receiver.c +++ b/src/modules/cdp/receiver.c @@ -605,7 +605,7 @@ static inline int do_receive(serviced_peer_t *sp) version = (unsigned char)(sp->buf[0]); if(version != 1) { LM_ERR("do_receive(): [%.*s] Received Unknown version [%d]\n", - sp->p->fqdn.len, sp->p->fqdn.s, + sp->p ? sp->p->fqdn.len : 0, sp->p ? sp->p->fqdn.s : 0, (unsigned char)sp->buf[0]); goto error_and_reset; } else {

1 0

git:master:14fb25a5: dispatcher: print no-probing flag in the rpc list
by Daniel-Constantin Mierla 05 Aug '24

05 Aug '24

Module: kamailio Branch: master Commit: 14fb25a5d39748e52224225667bae4ab2b428c9b URL: https://github.com/kamailio/kamailio/commit/14fb25a5d39748e52224225667bae4a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-05T10:21:08+02:00 dispatcher: print no-probing flag in the rpc list --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/14fb25a5d39748e52224225667bae4a… Patch: https://github.com/kamailio/kamailio/commit/14fb25a5d39748e52224225667bae4a… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 440b4b96030..831bfef7e1a 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1855,6 +1855,8 @@ int ds_rpc_print_set( if(node->dlist[j].flags & DS_PROBING_DST) c[1] = 'P'; + else if(node->dlist[j].flags & DS_NOPING_DST) + c[1] = 'N'; else c[1] = 'X';

1 0

git:master:1243755d: modules: readme files regenerated - textops ... [skip ci]
by Kamailio Dev 02 Aug '24

02 Aug '24

Module: kamailio Branch: master Commit: 1243755d20192e7d5d1c492462a0f9f66521abac URL: https://github.com/kamailio/kamailio/commit/1243755d20192e7d5d1c492462a0f9f… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-08-02T12:31:10+02:00 modules: readme files regenerated - textops ... [skip ci] --- Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/1243755d20192e7d5d1c492462a0f9f… Patch: https://github.com/kamailio/kamailio/commit/1243755d20192e7d5d1c492462a0f9f… --- diff --git a/src/modules/textops/README b/src/modules/textops/README index c19d629085f..60d805706fb 100644 --- a/src/modules/textops/README +++ b/src/modules/textops/README @@ -59,7 +59,7 @@ Ovidiu Sas 4.18. subst_user('/re/repl/flags') 4.19. subst_body('/re/repl/flags') 4.20. subst_hf(hf, subexp, flags) - 4.21. subst_hf(itext, subexp, ovp) + 4.21. subst_v(itext, subexp, ovp) 4.22. set_body(txt, content_type) 4.23. set_reply_body(txt, content_type) 4.24. filter_body(content_type) @@ -213,7 +213,7 @@ Chapter 1. Admin Guide 4.18. subst_user('/re/repl/flags') 4.19. subst_body('/re/repl/flags') 4.20. subst_hf(hf, subexp, flags) - 4.21. subst_hf(itext, subexp, ovp) + 4.21. subst_v(itext, subexp, ovp) 4.22. set_body(txt, content_type) 4.23. set_reply_body(txt, content_type) 4.24. filter_body(content_type) @@ -320,7 +320,7 @@ From: medabeda 4.18. subst_user('/re/repl/flags') 4.19. subst_body('/re/repl/flags') 4.20. subst_hf(hf, subexp, flags) - 4.21. subst_hf(itext, subexp, ovp) + 4.21. subst_v(itext, subexp, ovp) 4.22. set_body(txt, content_type) 4.23. set_reply_body(txt, content_type) 4.24. filter_body(content_type) @@ -742,7 +742,7 @@ if ( subst_body('/^o=(.*) /o=$fU /') ) {}; if ( subst_hf("From", "/:test@/:best@/", "a") ) { /*....*/ }; ... -4.21. subst_hf(itext, subexp, ovp) +4.21. subst_v(itext, subexp, ovp) Sed-like substitution subexp applied to itext, with result stored in opv.

1 0

git:master:40238581: textops: docs - fixed typo in subst_v() function name
by Daniel-Constantin Mierla 02 Aug '24

02 Aug '24

Module: kamailio Branch: master Commit: 40238581af0eea0787547bdacc2ff0fccf19cbba URL: https://github.com/kamailio/kamailio/commit/40238581af0eea0787547bdacc2ff0f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-02T12:28:19+02:00 textops: docs - fixed typo in subst_v() function name - unnoticed after copy and paste --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/40238581af0eea0787547bdacc2ff0f… Patch: https://github.com/kamailio/kamailio/commit/40238581af0eea0787547bdacc2ff0f… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index 57414c05e81..86f02b97336 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -811,7 +811,7 @@ if ( subst_hf("From", "/:test@/:best@/", "a") ) { /*....*/ }; <section id="textops.f.subst_v"> <title> - <function moreinfo="none">subst_hf(itext, subexp, ovp)</function> + <function moreinfo="none">subst_v(itext, subexp, ovp)</function> </title> <para> Sed-like substitution subexp applied to itext, with result stored in opv.

1 0

git:master:e92375c9: modules: readme files regenerated - textops ... [skip ci]
by Kamailio Dev 02 Aug '24

02 Aug '24

Module: kamailio Branch: master Commit: e92375c96eace6340e42bca622e9835df6b5d17f URL: https://github.com/kamailio/kamailio/commit/e92375c96eace6340e42bca622e9835… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-08-02T11:46:11+02:00 modules: readme files regenerated - textops ... [skip ci] --- Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/e92375c96eace6340e42bca622e9835… Patch: https://github.com/kamailio/kamailio/commit/e92375c96eace6340e42bca622e9835…

1 0

git:master:ab59aace: textops: docs for subst_v(...) function
by Daniel-Constantin Mierla 02 Aug '24

02 Aug '24

Module: kamailio Branch: master Commit: ab59aace74cca90be6d341a3f96e72693e939992 URL: https://github.com/kamailio/kamailio/commit/ab59aace74cca90be6d341a3f96e726… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-02T11:42:07+02:00 textops: docs for subst_v(...) function --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ab59aace74cca90be6d341a3f96e726… Patch: https://github.com/kamailio/kamailio/commit/ab59aace74cca90be6d341a3f96e726… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index 9c121e51c70..57414c05e81 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -809,6 +809,44 @@ if ( subst_hf("From", "/:test@/:best@/", "a") ) { /*....*/ }; </example> </section> + <section id="textops.f.subst_v"> + <title> + <function moreinfo="none">subst_hf(itext, subexp, ovp)</function> + </title> + <para> + Sed-like substitution subexp applied to itext, with result stored in opv. + </para> + <para>Meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem> + <para><emphasis>itext</emphasis> - input text, it can contain variables. + </para> + </listitem> + <listitem> + <para><emphasis>subexp</emphasis> - substitution expression + in the same format as of the 'subst' function parameter, it can + contain variables. + </para> + </listitem> + <listitem> + <para><emphasis>opv</emphasis> - variable name where to store the + result. + </para> + </listitem> + </itemizedlist> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>subst_v</function> usage</title> + <programlisting format="linespecific"> +... +subst_v("$var(x)", "/:test@/:best@/", "$var(r)"); +... +</programlisting> + </example> + </section> + <section id="textops.f.set_body"> <title> <function moreinfo="none">set_body(txt, content_type)</function>

1 0

git:master:e1954d76: textops: new function subst_v(...)
by Daniel-Constantin Mierla 02 Aug '24

02 Aug '24

Module: kamailio Branch: master Commit: e1954d7624eecdc33137d224c248240e2df90703 URL: https://github.com/kamailio/kamailio/commit/e1954d7624eecdc33137d224c248240… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-02T11:36:25+02:00 textops: new function subst_v(...) - perform sed-like substituion over input text and store in a variable --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/e1954d7624eecdc33137d224c248240… Patch: https://github.com/kamailio/kamailio/commit/e1954d7624eecdc33137d224c248240… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index 6baf40de6ad..d28d7f508cf 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -100,6 +100,7 @@ static int subst_uri_f(struct sip_msg *, char *, char *); static int subst_user_f(struct sip_msg *, char *, char *); static int subst_body_f(struct sip_msg *, char *, char *); static int subst_hf_f(struct sip_msg *, char *, char *, char *); +static int subst_v_f(struct sip_msg *, char *, char *, char *); static int filter_body_f(struct sip_msg *, char *, char *); static int is_present_hf_f(struct sip_msg *msg, char *str_hf, char *foo); static int search_append_body_f(struct sip_msg *, char *, char *); @@ -252,6 +253,8 @@ static cmd_export_t cmds[] = { {"subst_body", (cmd_function)subst_body_f, 1, fixup_substre, 0, ANY_ROUTE}, {"subst_hf", (cmd_function)subst_hf_f, 3, fixup_subst_hf, 0, ANY_ROUTE}, + {"subst_v", (cmd_function)subst_v_f, 3, fixup_spve2_pvar, + fixup_free_spve2_pvar, ANY_ROUTE}, {"filter_body", (cmd_function)filter_body_f, 1, fixup_str_null, 0, ANY_ROUTE}, {"append_time", (cmd_function)append_time_f, 0, 0, 0, @@ -1527,6 +1530,76 @@ static int subst_body_f(struct sip_msg *msg, char *subst, char *ignored) return subst_body_helper_f(msg, (struct subst_expr *)subst); } +/* sed-perl style re: s/regular expression/replacement/flags, like + * subst but with variables */ +static int subst_v_helper_f( + sip_msg_t *msg, str *itext, str *subex, pv_spec_t *pvd) +{ + str *result; + int nmatches; + struct subst_expr *se; + pv_value_t val; + + if(pvd->setf == NULL) { + LM_ERR("the variable is read only\n"); + return -1; + } + se = subst_parser(subex); + if(se == 0) { + LM_ERR("bad subst re: %.*s\n", subex->len, subex->s); + return -1; + } + /* pkg malloc'ed result */ + result = subst_str(itext->s, msg, se, &nmatches); + if(result == NULL) { + if(nmatches < 0) { + LM_ERR("substitution failed\n"); + } + return -1; + } + memset(&val, 0, sizeof(pv_value_t)); + val.rs.s = result->s; + val.rs.len = result->len; + val.flags = PV_VAL_STR; + pvd->setf(msg, &pvd->pvp, (int)EQ_T, &val); + + pkg_free(result->s); + pkg_free(result); + return 1; +} + +/* sed-perl style re: s/regular expression/replacement/flags, like + * subst but with variables */ +static int ki_subst_v(sip_msg_t *msg, str *itext, str *subex, str *opv) +{ + pv_spec_t *pvd = NULL; + + pvd = pv_cache_get(opv); + if(pvd == NULL) { + LM_ERR("failed to get pv spec\n"); + return -1; + } + return subst_v_helper_f(msg, itext, subex, pvd); +} + +static int subst_v_f(sip_msg_t *msg, char *pitext, char *psubex, char *popv) +{ + str itext = STR_NULL; + str subex = STR_NULL; + + if(fixup_get_svalue(msg, (gparam_t *)pitext, &itext) < 0) { + LM_ERR("failed to get header name\n"); + return -1; + } + if(fixup_get_svalue(msg, (gparam_t *)psubex, &subex) < 0) { + LM_ERR("failed to get header name\n"); + return -1; + } + + return subst_v_helper_f(msg, &itext, &subex, (pv_spec_t *)popv); +} + + static inline int find_line_start( char *text, unsigned int text_len, char **buf, unsigned int *buf_len) { @@ -5282,6 +5355,11 @@ static sr_kemi_t sr_kemi_textops_exports[] = { { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("textops"), str_init("subst_v"), + SR_KEMIP_INT, ki_subst_v, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("textops"), str_init("remove_hf"), SR_KEMIP_INT, ki_remove_hf, { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE,

1 0

[kamailio/kamailio] Mem leak in smsops which leads to the udp receiver process leak memory continuously (Issue #3833)
by paresh-panda 02 Aug '24

02 Aug '24

Hi, I am using Kamailio 5.8.1 ( ubuntu 22.04 Jammy 64 Bit),. Below are the observations. I am running a load of 500 3GPP IMS SMS which kamailio decodes and sends to another application over Rabbit MQ (Kazoo Module). **-m 512 -M 256** , using 512 MB Shared memory and 256MB Package Memory. When the load for 20 mins the available Memory drops from **80% to 25%** And I see below error logs > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/mem/q_malloc.c:324]: qm_find_free(): qm_find_free(0x7ff912e21010, 192); Free fragment not found! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/mem/q_malloc.c:463]: qm_malloc(): qm_malloc(0x7ff912e21010, 192) called from smsops: smsops_impl.c: decode_3gpp_sms(813), module: smsops; Free fragment not found! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:815]: decode_3gpp_sms(): Error allocating 192 bytes! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/mem/q_malloc.c:324]: qm_find_free(): qm_find_free(0x7ff912e21010, 192); Free fragment not found! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/mem/q_malloc.c:463]: qm_malloc(): qm_malloc(0x7ff912e21010, 192) called from smsops: smsops_impl.c: decode_3gpp_sms(813), module: smsops; Free fragment not found! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:815]: decode_3gpp_sms(): Error allocating 192 bytes! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/pvapi.c:1136]: pv_parse_format(): could not allocate private memory from pkg pool > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/sr_module.c:1318]: fix_param(): bad PVE format: "PRD-IR92/11 term-Motorola/XT2205-1-T2STS33.105-51-11-1-2-2 device-type/smart-phone" > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/mod_fix.c:601]: fixup_spve_null(): Cannot convert function parameter 1 to spve > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1178]: do_action(): runtime fixup failed for jansson_set param 3 > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1566]: do_action(): run action error at: /etc/kamailio/kamailio.cfg:539 > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/sr_module.c:1208]: fix_param(): could not allocate private memory from pkg pool > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/mod_fix.c:601]: fixup_spve_null(): Cannot convert function parameter 1 to spve > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1178]: do_action(): runtime fixup failed for jansson_set param 3 > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1566]: do_action(): run action error at: /etc/kamailio/kamailio.cfg:540 > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/sr_module.c:1208]: fix_param(): could not allocate private memory from pkg pool > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/mod_fix.c:601]: fixup_spve_null(): Cannot convert function parameter 1 to spve > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1178]: do_action(): runtime fixup failed for jansson_set param 3 > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1566]: do_action(): run action error at: /etc/kamailio/kamailio.cfg:541 > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/rvalue.c:1321]: rval_get_str(): could not allocate private memory from pkg pool > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1178]: do_action(): failed to convert RVE to string > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1566]: do_action(): run action error at: /etc/kamailio/kamailio.cfg:542 > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/rvalue.c:1321]: rval_get_str(): could not allocate private memory from pkg pool > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1178]: do_action(): failed to convert RVE to string > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1566]: do_action(): run action error at: /etc/kamailio/kamailio.cfg:543 > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:815]: decode_3gpp_sms(): Error allocating 192 bytes! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:815]: decode_3gpp_sms(): Error allocating 192 bytes! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:815]: decode_3gpp_sms(): Error allocating 192 bytes! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:815]: decode_3gpp_sms(): Error allocating 192 bytes! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request! > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/rvalue.c:1321]: rval_get_str(): could not allocate private memory from pkg pool > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1178]: do_action(): failed to convert RVE to string > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1566]: do_action(): run action error at: /etc/kamailio/kamailio.cfg:555 > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/rvalue.c:1321]: rval_get_str(): could not allocate private memory from pkg pool > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1178]: do_action(): failed to convert RVE to string > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1566]: do_action(): run action error at: /etc/kamailio/kamailio.cfg:556 > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/rvalue.c:1321]: rval_get_str(): could not allocate private memory from pkg pool > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1171]: do_action(): failed to convert RVE to string > Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 1 MESSAGE 739708-3401(a)192.168.136.152} <core> [core/action.c:1566]: do_action(): run action error at: /etc/kamailio/kamailio.cfg:559 > I am attaching the configuration for reference. Help on this is much appreciated [configfiles.tar.gz](https://github.com/kamailio/kamailio/files/15148792/con… , I am looking into this issue for quite a long time. Thank you! Regards Paresh -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3833 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3833(a)github.com>

5 7

git:master:5b2e4d38: Makefile.defs: set -pthread flag always
by Daniel-Constantin Mierla 01 Aug '24

01 Aug '24

Module: kamailio Branch: master Commit: 5b2e4d38ac3da8693044aa64c1d4e73595d061cf URL: https://github.com/kamailio/kamailio/commit/5b2e4d38ac3da8693044aa64c1d4e73… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-01T12:28:01+02:00 Makefile.defs: set -pthread flag always - needed by the multi-thread udp receiving mode - it was almost always set for libssl tls multi-process mutexes --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/5b2e4d38ac3da8693044aa64c1d4e73… Patch: https://github.com/kamailio/kamailio/commit/5b2e4d38ac3da8693044aa64c1d4e73… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 99157d2c017..1f3e0e81606 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -220,8 +220,8 @@ LIBDL="-ldl" endif ifeq ($(LIBSSL_SET_MUTEX_SHARED), 1) -CC_PMUTEX_OPTS = -pthread -DKSR_PTHREAD_MUTEX_SHARED -LD_PMUTEX_OPTS = -pthread -rdynamic $(LIBDL) -Wl,-Bsymbolic-functions +CC_PMUTEX_OPTS = -DKSR_PTHREAD_MUTEX_SHARED +LD_PMUTEX_OPTS = -rdynamic $(LIBDL) -Wl,-Bsymbolic-functions else CC_PMUTEX_OPTS = LD_PMUTEX_OPTS = @@ -922,8 +922,8 @@ ifeq ($(use_fast_lock), yes) found_lock_method=yes endif -CFLAGS=-g -LDFLAGS=-g +CFLAGS=-g -pthread +LDFLAGS=-g -pthread C_INCLUDES= # setting CFLAGS ifeq ($(mode), release) @@ -1995,7 +1995,6 @@ ifeq ($(OS), freebsd) ifneq ($(found_lock_method), yes) C_DEFS+= -DUSE_PTHREAD_MUTEX # try pthread sems found_lock_method=yes - LIBS+= -pthread endif # check for ver >= 4.1 ifeq ($(shell [ $(OSREL_N) -gt 4001 ] && echo has_kqueue), has_kqueue) @@ -2017,7 +2016,6 @@ ifeq ($(OS), dragonfly) ifneq ($(found_lock_method), yes) C_DEFS+= -DUSE_PTHREAD_MUTEX # try pthread sems found_lock_method=yes - LIBS+= -pthread #dlopen is in libc else LIBS= #dlopen is in libc endif

1 0

git:master:6b413cc8: permissions: reworked condition checking group id on db load
by Daniel-Constantin Mierla 01 Aug '24

01 Aug '24

Module: kamailio Branch: master Commit: 6b413cc8c7f9c6db019c98a28ab07cf902ef505e URL: https://github.com/kamailio/kamailio/commit/6b413cc8c7f9c6db019c98a28ab07cf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-01T08:09:34+02:00 permissions: reworked condition checking group id on db load - ensure it is not null and greater than 0 for both types - update of 6afab49 --- Modified: src/modules/permissions/address.c --- Diff: https://github.com/kamailio/kamailio/commit/6b413cc8c7f9c6db019c98a28ab07cf… Patch: https://github.com/kamailio/kamailio/commit/6b413cc8c7f9c6db019c98a28ab07cf… --- diff --git a/src/modules/permissions/address.c b/src/modules/permissions/address.c index 3f825fba010..05f56d3dc68 100644 --- a/src/modules/permissions/address.c +++ b/src/modules/permissions/address.c @@ -192,8 +192,13 @@ int reload_address_db_table(address_tables_group_t *atg) ROW_N(row + i)); goto dberror; } - if((VAL_TYPE(val) != DB1_INT && VAL_TYPE(val) != DB1_UINT) - || VAL_NULL(val) || (VAL_INT(val) <= 0)) { + if(VAL_NULL(val)) { + LM_DBG("failure during checks of database value 1 (group) in " + "address table\n"); + goto dberror; + } + if(!((VAL_TYPE(val) == DB1_INT && VAL_INT(val) > 0) + || (VAL_TYPE(val) == DB1_UINT && VAL_UINT(val) > 0))) { LM_DBG("failure during checks of database value 1 (group) in " "address table\n"); goto dberror;

1 0

[kamailio/kamailio] Uint fixes (PR #3828)
by Tyler Moore 01 Aug '24

01 Aug '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Adding support for converting unsigned integers from database tables into kamailio pseudo variables usable in the routing config. This is quite useful when pulling `int unsigned` fields from a database, in modules that support "extra fields" in their module parameters. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3828 -- Commit Summary -- * permissions: fixup uint support in address table reload * htable: add uint support when packing an htable * lib/srdb1: add uint support for db->pv conversions -- File Changes -- M src/lib/srdb1/db_ut.c (4) M src/modules/htable/ht_db.c (6) M src/modules/permissions/address.c (35) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3828.patch https://github.com/kamailio/kamailio/pull/3828.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3828 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3828(a)github.com>

4 9

git:master:d90101e1: lib/srdb1: add uint support for db->pv conversions
by Daniel-Constantin Mierla 01 Aug '24

01 Aug '24

Module: kamailio Branch: master Commit: d90101e1a50ef0c958e8e8a2f361198a28ea336a URL: https://github.com/kamailio/kamailio/commit/d90101e1a50ef0c958e8e8a2f361198… Author: Tyler Moore <tmoore(a)goflyball.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-01T08:02:09+02:00 lib/srdb1: add uint support for db->pv conversions - add support for converting unsigned integers into PVs. --- Modified: src/lib/srdb1/db_ut.c --- Diff: https://github.com/kamailio/kamailio/commit/d90101e1a50ef0c958e8e8a2f361198… Patch: https://github.com/kamailio/kamailio/commit/d90101e1a50ef0c958e8e8a2f361198… --- diff --git a/src/lib/srdb1/db_ut.c b/src/lib/srdb1/db_ut.c index 9975672aeea..76210d5691e 100644 --- a/src/lib/srdb1/db_ut.c +++ b/src/lib/srdb1/db_ut.c @@ -596,6 +596,10 @@ int db_val2pv_spec(struct sip_msg *msg, db_val_t *dbval, pv_spec_t *pvs) pv.flags = PV_VAL_INT | PV_TYPE_INT; pv.ri = (long)dbval->val.int_val; break; + case DB1_UINT: + pv.flags = PV_VAL_INT | PV_TYPE_INT; + pv.ri = (long)dbval->val.uint_val; + break; case DB1_DATETIME: pv.flags = PV_VAL_INT | PV_TYPE_INT; pv.ri = (long)dbval->val.time_val;

1 0

git:master:772f261f: htable: add uint support when packing an htable
by Daniel-Constantin Mierla 01 Aug '24

01 Aug '24

Module: kamailio Branch: master Commit: 772f261f91685583af3db7cee2c227336eef7c42 URL: https://github.com/kamailio/kamailio/commit/772f261f91685583af3db7cee2c2273… Author: Tyler Moore <tmoore(a)goflyball.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-01T08:02:09+02:00 htable: add uint support when packing an htable - add support for packing unsigned integer values from DB, into hash tables. --- Modified: src/modules/htable/ht_db.c --- Diff: https://github.com/kamailio/kamailio/commit/772f261f91685583af3db7cee2c2273… Patch: https://github.com/kamailio/kamailio/commit/772f261f91685583af3db7cee2c2273… --- diff --git a/src/modules/htable/ht_db.c b/src/modules/htable/ht_db.c index 7a22ff6c484..8b0c667411d 100644 --- a/src/modules/htable/ht_db.c +++ b/src/modules/htable/ht_db.c @@ -132,6 +132,8 @@ static int ht_pack_values( len += RES_ROWS(db_res)[row].values[c].val.blob_val.len; } else if(RES_ROWS(db_res)[row].values[c].type == DB1_INT) { len += 12; + } else if(RES_ROWS(db_res)[row].values[c].type == DB1_UINT) { + len += 12; } else { LM_ERR("unsupported data type for column %d\n", c); return -1; @@ -165,6 +167,11 @@ static int ht_pack_values( RES_ROWS(db_res)[row].values[c].val.int_val, &iv.len); strncpy(p, iv.s, iv.len); p += iv.len; + } else if(RES_ROWS(db_res)[row].values[c].type == DB1_UINT) { + iv.s = int2str( + RES_ROWS(db_res)[row].values[c].val.uint_val, &iv.len); + strncpy(p, iv.s, iv.len); + p += iv.len; } if(c + 1 < cols) { *p = ht->pack[1];

1 0

git:master:5f4f1f02: permissions: fixup uint support in address table reload
by Daniel-Constantin Mierla 01 Aug '24

01 Aug '24

Module: kamailio Branch: master Commit: 5f4f1f027132a1e4cdc2528a0d65e777a0a01da7 URL: https://github.com/kamailio/kamailio/commit/5f4f1f027132a1e4cdc2528a0d65e77… Author: Tyler Moore <tmoore(a)goflyball.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-01T08:02:09+02:00 permissions: fixup uint support in address table reload - add support for converting unsigned integer values directly, in address table rpc reload. --- Modified: src/modules/permissions/address.c --- Diff: https://github.com/kamailio/kamailio/commit/5f4f1f027132a1e4cdc2528a0d65e77… Patch: https://github.com/kamailio/kamailio/commit/5f4f1f027132a1e4cdc2528a0d65e77… --- diff --git a/src/modules/permissions/address.c b/src/modules/permissions/address.c index c05811f73f9..3f825fba010 100644 --- a/src/modules/permissions/address.c +++ b/src/modules/permissions/address.c @@ -192,41 +192,49 @@ int reload_address_db_table(address_tables_group_t *atg) ROW_N(row + i)); goto dberror; } - if((VAL_TYPE(val) != DB1_INT) || VAL_NULL(val) || (VAL_INT(val) <= 0)) { + if((VAL_TYPE(val) != DB1_INT && VAL_TYPE(val) != DB1_UINT) + || VAL_NULL(val) || (VAL_INT(val) <= 0)) { LM_DBG("failure during checks of database value 1 (group) in " "address table\n"); goto dberror; } - if((VAL_TYPE(val + 1) != DB1_STRING) - && (VAL_TYPE(val + 1) != DB1_STR)) { + if((VAL_TYPE(val + 1) != DB1_STRING && VAL_TYPE(val + 1) != DB1_STR) + || VAL_NULL(val + 1)) { LM_DBG("failure during checks of database value 2 (IP address) in " - "address table - not a string value\n"); - goto dberror; - } - if(VAL_NULL(val + 1)) { - LM_DBG("failure during checks of database value 2 (IP address) in " - "address table - NULL value not permitted\n"); + "address table\n"); goto dberror; } - if((VAL_TYPE(val + 2) != DB1_INT) || VAL_NULL(val + 2)) { + if((VAL_TYPE(val + 2) != DB1_INT && VAL_TYPE(val + 2) != DB1_UINT) + || VAL_NULL(val + 2)) { LM_DBG("failure during checks of database value 3 (subnet " "size/CIDR) in address table\n"); goto dberror; } - if((VAL_TYPE(val + 3) != DB1_INT) || VAL_NULL(val + 3)) { + if((VAL_TYPE(val + 3) != DB1_INT && VAL_TYPE(val + 3) != DB1_UINT) + || VAL_NULL(val + 3)) { LM_DBG("failure during checks of database value 4 (port) in " "address table\n"); goto dberror; } + if(VAL_TYPE(val + 4) != DB1_STRING && VAL_TYPE(val + 4) != DB1_STR) { + LM_DBG("failure during checks of database value 5 (tag) in address " + "table\n"); + goto dberror; + } + gid = VAL_UINT(val); ips.s = (char *)VAL_STRING(val + 1); ips.len = strlen(ips.s); mask = VAL_UINT(val + 2); port = VAL_UINT(val + 3); - tagv.s = VAL_NULL(val + 4) ? NULL : (char *)VAL_STRING(val + 4); - if(tagv.s != NULL) { + if(VAL_NULL(val + 4)) { + tagv.s = NULL; + tagv.len = 0; + } else { + tagv.s = (char *)VAL_STRING(val + 4); tagv.len = strlen(tagv.s); } + if(reload_address_insert(atg, gid, &ips, mask, port, &tagv) < 0) { goto dberror; }

1 0

git:master:e273fc10: modules: readme files regenerated - msrp ... [skip ci]
by Kamailio Dev 01 Aug '24

01 Aug '24

Module: kamailio Branch: master Commit: e273fc10d65b41a407797fef0f9953c1615a88a2 URL: https://github.com/kamailio/kamailio/commit/e273fc10d65b41a407797fef0f9953c… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-08-01T07:31:11+02:00 modules: readme files regenerated - msrp ... [skip ci] --- Modified: src/modules/msrp/README --- Diff: https://github.com/kamailio/kamailio/commit/e273fc10d65b41a407797fef0f9953c… Patch: https://github.com/kamailio/kamailio/commit/e273fc10d65b41a407797fef0f9953c…

1 0

[kamailio/kamailio] msrp: add frame forward (PR #3934)
by Bruno Santos 01 Aug '24

01 Aug '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Add a new forward function to the MSRP module that adds the ability to perform MSRP proxying. The forward function allows frame replaying without multi-path. The frame can be relayed unmodified, or with a custom To/From-Path. If a replacement To-Path is provided, then the From-Path is replace either by the original To-Path or the replacement From-Path. Either the destination must be set prior or a replacement To-Path must be provided. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3934 -- Commit Summary -- * msrp: add forward support with path replacement -- File Changes -- M src/modules/msrp/doc/msrp_admin.xml (38) M src/modules/msrp/msrp_mod.c (72) M src/modules/msrp/msrp_netio.c (129) M src/modules/msrp/msrp_netio.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3934.patch https://github.com/kamailio/kamailio/pull/3934.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3934 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3934(a)github.com>

3 5

git:master:aa417aca: msrp: add forward support with path replacement
by Daniel-Constantin Mierla 01 Aug '24

01 Aug '24

Module: kamailio Branch: master Commit: aa417aca610b1c8a623847c22d9becba9a343241 URL: https://github.com/kamailio/kamailio/commit/aa417aca610b1c8a623847c22d9becb… Author: Bruno Santos <bsantos(a)cppdev.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-08-01T07:25:21+02:00 msrp: add forward support with path replacement - add function to allow forwarding of MSRP frames with optional To/From-Path replacement --- Modified: src/modules/msrp/doc/msrp_admin.xml Modified: src/modules/msrp/msrp_mod.c Modified: src/modules/msrp/msrp_netio.c Modified: src/modules/msrp/msrp_netio.h --- Diff: https://github.com/kamailio/kamailio/commit/aa417aca610b1c8a623847c22d9becb… Patch: https://github.com/kamailio/kamailio/commit/aa417aca610b1c8a623847c22d9becb…

1 0

git:master:83f2dd24: dispatcher: return oc seq, min and max attrs in rpc list
by Daniel-Constantin Mierla 31 Jul '24

31 Jul '24

Module: kamailio Branch: master Commit: 83f2dd24e404eead32361079fca1fd68976e81c8 URL: https://github.com/kamailio/kamailio/commit/83f2dd24e404eead32361079fca1fd6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-31T16:07:17+02:00 dispatcher: return oc seq, min and max attrs in rpc list --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/83f2dd24e404eead32361079fca1fd6… Patch: https://github.com/kamailio/kamailio/commit/83f2dd24e404eead32361079fca1fd6… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 5d61d00ffd8..440b4b96030 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1869,14 +1869,15 @@ int ds_rpc_print_set( ipbuf[0] = '\0'; ip_addr2sbufz( &node->dlist[j].ip_address, ipbuf, IP_ADDR_MAX_STRZ_SIZE); - if(rpc->struct_add(vh, "Ssddjjujjj", "HOST", &node->dlist[j].host, + if(rpc->struct_add(vh, "Ssddjjujjjj", "HOST", &node->dlist[j].host, "IPADDR", ipbuf, "PORT", (int)node->dlist[j].port, "PROTOID", (int)node->dlist[j].proto, "DNSTIME_SEC", (unsigned long)node->dlist[j].dnstime.tv_sec, "DNSTIME_USEC", (unsigned long)node->dlist[j].dnstime.tv_usec, "OCRATE", node->dlist[j].attrs.ocrate, "OCIDX", - (unsigned long)node->dlist[j].ocidx, "OCTIME_SEC", + (unsigned long)node->dlist[j].ocidx, "OCSEQ", + (unsigned long)node->dlist[j].ocseq, "OCTIME_SEC", (unsigned long)node->dlist[j].octime.tv_sec, "OCTIME_USEC", (unsigned long)node->dlist[j].octime.tv_usec) @@ -1892,7 +1893,7 @@ int ds_rpc_print_set( rpc->fault(ctx, 500, "Internal error creating dest struct"); return -1; } - if(rpc->struct_add(wh, "SSdddSSS", "BODY", + if(rpc->struct_add(wh, "SSdddSSSjj", "BODY", &(node->dlist[j].attrs.body), "DUID", (node->dlist[j].attrs.duid.s) ? &(node->dlist[j].attrs.duid) @@ -1910,7 +1911,9 @@ int ds_rpc_print_set( "OBPROXY", (node->dlist[j].attrs.obproxy.s) ? &(node->dlist[j].attrs.obproxy) - : &data) + : &data, + "OCMIN", node->dlist[j].attrs.ocmin, "OCMAX", + node->dlist[j].attrs.ocmax) < 0) { rpc->fault(ctx, 500, "Internal error creating attrs struct"); return -1;

1 0

git:master:604fd278: dispatcher: always return attrs in rpc list full mode
by Daniel-Constantin Mierla 31 Jul '24

31 Jul '24

Module: kamailio Branch: master Commit: 604fd2787620de87585ba17fb6a6961b3b999331 URL: https://github.com/kamailio/kamailio/commit/604fd2787620de87585ba17fb6a6961… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-31T16:01:38+02:00 dispatcher: always return attrs in rpc list full mode --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/604fd2787620de87585ba17fb6a6961… Patch: https://github.com/kamailio/kamailio/commit/604fd2787620de87585ba17fb6a6961… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 74ee7cc8e8d..5d61d00ffd8 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1886,7 +1886,8 @@ int ds_rpc_print_set( } } - if(mode != DS_RPC_PRINT_SHORT && node->dlist[j].attrs.body.s != NULL) { + if((mode != DS_RPC_PRINT_SHORT && node->dlist[j].attrs.body.s != NULL) + || (mode == DS_RPC_PRINT_FULL)) { if(rpc->struct_add(vh, "{", "ATTRS", &wh) < 0) { rpc->fault(ctx, 500, "Internal error creating dest struct"); return -1;

1 0

git:master:41016d18: dispatcher: range checks for oc rate min/max limits
by Daniel-Constantin Mierla 31 Jul '24

31 Jul '24

Module: kamailio Branch: master Commit: 41016d1835c1ab62b7d3c0f6299fae727a6f7ed3 URL: https://github.com/kamailio/kamailio/commit/41016d1835c1ab62b7d3c0f6299fae7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-31T15:57:01+02:00 dispatcher: range checks for oc rate min/max limits --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/41016d1835c1ab62b7d3c0f6299fae7… Patch: https://github.com/kamailio/kamailio/commit/41016d1835c1ab62b7d3c0f6299fae7… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 8295145da0f..5e6f7da8926 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -411,9 +411,15 @@ int ds_set_attrs(ds_dest_t *dest, str *vattrs) if(dest->attrs.ocmax > 100) { dest->attrs.ocmax = 100; } + if(dest->attrs.ocmax <= 0) { + dest->attrs.ocmax = 100; + } if(dest->attrs.ocmin > 100) { dest->attrs.ocmin = 0; } + if(dest->attrs.ocmin < 0) { + dest->attrs.ocmin = 0; + } if(dest->attrs.ocrate > 100) { dest->attrs.ocrate = 0; }

1 0

git:master:08ee7330: dispatcher: intit oc rate max limit
by Daniel-Constantin Mierla 31 Jul '24

31 Jul '24

Module: kamailio Branch: master Commit: 08ee7330922e9e2b4d8fd8d5f63f596c84e2c81c URL: https://github.com/kamailio/kamailio/commit/08ee7330922e9e2b4d8fd8d5f63f596… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-31T15:50:45+02:00 dispatcher: intit oc rate max limit --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/08ee7330922e9e2b4d8fd8d5f63f596… Patch: https://github.com/kamailio/kamailio/commit/08ee7330922e9e2b4d8fd8d5f63f596… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index bdb615ad3ea..8295145da0f 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -603,6 +603,7 @@ ds_dest_t *pack_dest(str iuri, int flags, int priority, str *attrs, int dload) dp->flags = flags; dp->priority = priority; dp->dload = dload; + dp->attrs.ocmax = 100; if(ds_set_attrs(dp, attrs) < 0) { LM_ERR("cannot set attributes!\n");

1 0

git:master:629a5189: modules: readme files regenerated - corex ... [skip ci]
by Kamailio Dev 31 Jul '24

31 Jul '24

Module: kamailio Branch: master Commit: 629a518991ab204a45f625d82fbe8a0ccd247cd6 URL: https://github.com/kamailio/kamailio/commit/629a518991ab204a45f625d82fbe8a0… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-31T07:46:11+02:00 modules: readme files regenerated - corex ... [skip ci] --- Modified: src/modules/corex/README --- Diff: https://github.com/kamailio/kamailio/commit/629a518991ab204a45f625d82fbe8a0… Patch: https://github.com/kamailio/kamailio/commit/629a518991ab204a45f625d82fbe8a0… --- diff --git a/src/modules/corex/README b/src/modules/corex/README index 6a5e0663bdf..8986ee4df23 100644 --- a/src/modules/corex/README +++ b/src/modules/corex/README @@ -503,12 +503,14 @@ event_route[network:msg] { 4.7. msg_iflag_set(flagname) Set internal SIP message flag. The parameter flagname can be: - USE_UAC_FROM, USE_UAC_TO or UAC_AUTH. + USE_UAC_FROM, USE_UAC_TO, UAC_AUTH or a number from 0 to 64 (the + meaning of each value can be found in source code). This functions should not be used in configuration file for (re)setting the internal flags, those are done by various functions internally, however, in very particular cases they might be useful (e.g., changing - From/To via textops functions). + From/To via textops functions, or during testing of C code + development). This function can be used from ANY_ROUTE.

1 0

git:master:37e971f7: corex: docs updated for msg_iflag_set()
by Daniel-Constantin Mierla 31 Jul '24

31 Jul '24

Module: kamailio Branch: master Commit: 37e971f72c1783266ee29c02434361aaf2c819ed URL: https://github.com/kamailio/kamailio/commit/37e971f72c1783266ee29c02434361a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-31T07:41:43+02:00 corex: docs updated for msg_iflag_set() --- Modified: src/modules/corex/doc/corex_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/37e971f72c1783266ee29c02434361a… Patch: https://github.com/kamailio/kamailio/commit/37e971f72c1783266ee29c02434361a… --- diff --git a/src/modules/corex/doc/corex_admin.xml b/src/modules/corex/doc/corex_admin.xml index 3cdad0aa2a5..3d6ff893808 100644 --- a/src/modules/corex/doc/corex_admin.xml +++ b/src/modules/corex/doc/corex_admin.xml @@ -469,13 +469,15 @@ event_route[network:msg] { </title> <para> Set internal SIP message flag. The parameter flagname can be: - USE_UAC_FROM, USE_UAC_TO or UAC_AUTH. + USE_UAC_FROM, USE_UAC_TO, UAC_AUTH or a number from 0 to 64 + (the meaning of each value can be found in source code). </para> <para> This functions should not be used in configuration file for (re)setting the internal flags, those are done by various functions internally, however, in very particular cases they - might be useful (e.g., changing From/To via textops functions). + might be useful (e.g., changing From/To via textops functions, + or during testing of C code development). </para> <para> This function can be used from ANY_ROUTE.

1 0

git:master:82c786fd: corex: functions to manage iflags can get 0..63 parameter value
by Daniel-Constantin Mierla 31 Jul '24

31 Jul '24

Module: kamailio Branch: master Commit: 82c786fde7a635738c905899fb6edc9b7d1a2b67 URL: https://github.com/kamailio/kamailio/commit/82c786fde7a635738c905899fb6edc9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-31T07:41:43+02:00 corex: functions to manage iflags can get 0..63 parameter value --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/82c786fde7a635738c905899fb6edc9… Patch: https://github.com/kamailio/kamailio/commit/82c786fde7a635738c905899fb6edc9… --- diff --git a/src/modules/corex/corex_mod.c b/src/modules/corex/corex_mod.c index e853032cd7f..de2fb03b5fd 100644 --- a/src/modules/corex/corex_mod.c +++ b/src/modules/corex/corex_mod.c @@ -587,6 +587,7 @@ static msg_iflag_name_t _msg_iflag_list[] = { static unsigned long long msg_lookup_flag(str *fname) { int i; + for(i = 0; _msg_iflag_list[i].name.len > 0; i++) { if(fname->len == _msg_iflag_list[i].name.len && strncasecmp(_msg_iflag_list[i].name.s, fname->s, fname->len) @@ -594,7 +595,22 @@ static unsigned long long msg_lookup_flag(str *fname) return _msg_iflag_list[i].value; } } - return 0; + if(fname->len < 1 || fname->len > 2) { + return 0; + } + if(!(fname->s[0] >= '0' && fname->s[0] <= '9')) { + return 0; + } + if(fname->len == 1) { + return 1ULL << (fname->s[0] - '0'); + } + if(!(fname->s[1] >= '0' && fname->s[1] <= '9')) { + return 0; + } + if((10 * (fname->s[0] - '0') - (fname->s[1] - '0')) > 63) { + return 0; + } + return 1ULL << (10 * (fname->s[0] - '0') - (fname->s[1] - '0')); } /**

1 0

[kamailio/kamailio] Kamailio crash with DMQ!? (Issue #3905)
by Benjamin 30 Jul '24

30 Jul '24

### Description Kamailio version 5.7.4 crashed with a core file. Maybe it's related to the dmq module. #### Debugging Data ``` (gdb) bt full #0 atomic_inc_int (var=0x7f5700000000) at ../../core/parser/../mem/../atomic/atomic_x86.h:236 No locals. #1 cfg_update_local (no_cbs=<optimized out>) at ../../core/cfg/cfg_struct.h:381 group = <optimized out> last_cb = 0x7f57c99545e0 prev_cb = <optimized out> group = <optimized out> last_cb = <optimized out> prev_cb = <optimized out> __func__ = "cfg_update_local" #2 worker_loop (id=id@entry=2) at worker.c:57 worker = <optimized out> current_job = <optimized out> peer_response = {resp_code = 1, content_type = {s = 0x55ea7b42cfca <init_mod_child+90> "\205\300\017\210\r\002", len = 15}, reason = {s = 0x0, len = 2}, body = { s = 0x7ffcf6347c30 "\001", len = 2069833640}} ret_value = <optimized out> not_parsed = <optimized out> dmq_node = 0x0 __func__ = "worker_loop" #3 0x00007f57d9426a11 in child_init (rank=<optimized out>) at dmq.c:321 i = 2 newpid = <optimized out> __func__ = "child_init" #4 0x000055ea7b42cfca in init_mod_child (m=0x7f57dd005640, rank=rank@entry=0) at core/sr_module.c:911 ret = 0 __func__ = "init_mod_child" #5 0x000055ea7b42cfa4 in init_mod_child (m=0x7f57dd005b90, rank=rank@entry=0) at core/sr_module.c:903 ret = <optimized out> __func__ = "init_mod_child" #6 0x000055ea7b42cfa4 in init_mod_child (m=0x7f57dd006910, rank=rank@entry=0) at core/sr_module.c:903 ret = <optimized out> __func__ = "init_mod_child" #7 0x000055ea7b42cfa4 in init_mod_child (m=0x7f57dd006e70, rank=rank@entry=0) at core/sr_module.c:903 ret = <optimized out> __func__ = "init_mod_child" #8 0x000055ea7b42cfa4 in init_mod_child (m=0x7f57dd008660, rank=rank@entry=0) at core/sr_module.c:903 ret = <optimized out> __func__ = "init_mod_child" #9 0x000055ea7b42cfa4 in init_mod_child (m=0x7f57dd0089d0, rank=rank@entry=0) at core/sr_module.c:903 ret = <optimized out> __func__ = "init_mod_child" #10 0x000055ea7b42cfa4 in init_mod_child (m=0x7f57dd008d70, rank=rank@entry=0) at core/sr_module.c:903 ret = <optimized out> __func__ = "init_mod_child" #11 0x000055ea7b43239e in init_child (rank=rank@entry=0) at core/sr_module.c:990 ret = <optimized out> type = <optimized out> __func__ = "init_child" #12 0x000055ea7b288365 in main_loop () at main.c:1929 i = <optimized out> pid = <optimized out> si = 0x0 si_desc = "udp receiver child=15 sock=172.20.21.4:5060\000\000\000\000\000H\211\064\366\374\177\000\000\301'C{\352U\000\000\276\000\000\000\002\000\000\000\017\247`{\352U\000\000\062\323b{\352U\000\000U\024\000\000\000\000\000\000\004\000_{\352U\000\000\000\272\030D\344\223ԃ\270Rc{\352U\000\000\004\000\000\000\000\000\000" nrprocs = <optimized out> woneinit = 1 __func__ = "main_loop" error = <optimized out> #13 0x000055ea7b27be9e in main (argc=<optimized out>, argv=<optimized out>) at main.c:3213 cfg_stream = <optimized out> c = <optimized out> r = <optimized out> tmp = 0x7ffcf6349e4e "" tmp_len = -554008000 port = 32599 proto = 0 ahost = 0x0 aport = 0 options = 0x55ea7b5f2cc8 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 1892320457 rfd = <optimized out> debug_save = <optimized out> debug_flag = <optimized out> dont_fork_cnt = <optimized out> n_lst = <optimized out> p = <optimized out> st = {st_dev = 0, st_ino = 0, st_nlink = 0, st_mode = 0, st_uid = 0, st_gid = 0, __pad0 = 0, st_rdev = 0, st_size = 0, st_blksize = 0, st_blocks = 0, st_atim = {tv_sec = 0, tv_nsec = 0}, st_mtim = {tv_sec = 0, tv_nsec = 0}, st_ctim = {tv_sec = 0, tv_nsec = 0}, __glibc_reserved = {0, 0, 0}} tbuf = '\000' <repeats 20 times>, " ", '\000' <repeats 35 times>, "\006\000\000\000\000\000\000\200", '\000' <repeats 56 times>, "\006\000\000\000\000\000\000\200", '\000' <repeats 168 times>... option_index = 9 long_options = {{name = 0x55ea7b5f12ea "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x55ea7b5fa98e "version", has_arg = 0, flag = 0x0, val = 118}, { name = 0x55ea7b60a690 "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x55ea7b5f12ef "subst", has_arg = 1, flag = 0x0, val = 1025}, {name = 0x55ea7b5f12f5 "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x55ea7b5f12fe "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0x55ea7b5f1308 "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x55ea7b5f1312 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0x55ea7b5f131d "modparam", has_arg = 1, flag = 0x0, val = 1030}, { name = 0x55ea7b5f1326 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, {name = 0x55ea7b5faaab "debug", has_arg = 1, flag = 0x0, val = 1032}, { name = 0x55ea7b5f1331 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0x55ea7b5f133b "atexit", has_arg = 1, flag = 0x0, val = 1034}, { name = 0x55ea7b5f1342 "all-errors", has_arg = 0, flag = 0x0, val = 1035}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" (gdb) info locals No locals. (gdb) list 231 in ../../core/parser/../mem/../atomic/atomic_x86.h ``` #### Log Messages ``` Jul 2 15:24:44 hostname kernel: kamailio[1098]: segfault at 7f5700000000 ip 00007f57d94467a0 sp 00007ffcf6347b00 error 6 in dmq.so[7f57d9426000+23000] ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: compiled with gcc 10.2.1 ``` * **Operating System**: ``` Debian: 11.10 - Bullseye Linux 5.10.0-30-amd64 #1 SMP Debian 5.10.218-1 (2024-06-01) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3905 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3905(a)github.com>

3 14

[kamailio/kamailio] Suspected mem leak in the pua and request for ideas (Issue #3928)
by Andrew Pogrebennyk 30 Jul '24

30 Jul '24

Hi! it seems the pua module in send_subscribe ( ) is leaking some memory because the hentity is not released. According to memory allocations the shmem allocated for hentity is not cleaned. ``` 1454582 file = 0x70e59fd30209 "usrloc: ../../core/ut.h", func = 0x70e59fd326c8 <__func__.16> "shm_str_dup", mname = 0x70e59fd2fdf0 "usrloc", line = 722 698090 file = 0x604218f2fcd5 "core: core/xavp.c", func = 0x604218f31988 <__func__.9> "xavp_new_value", mname = 0x604218f2fcd0 "core", line = 100 360187 file = 0x70e59fd30663 "usrloc: ucontact.c", func = 0x70e59fd326b8 <__func__.17> "new_ucontact", mname = 0x70e59fd2fdf0 "usrloc", line = 94 34208 file = 0x70e59fc91ae9 "pua: send_subscribe.c", func = 0x70e59fc94c80 <__func__.2> "subscribe_cbparam", mname = 0x70e59fc917e0 "pua", line = 773 5569 file = 0x70e59fc91ae9 "pua: send_subscribe.c", func = 0x70e59fc94ca0 <__func__.1> "subs_cbparam_indlg", mname = 0x70e59fc917e0 "pua", line = 861 64 file = 0x70e5a231f424 "tmx: tmx_pretran.c", func = 0x70e5a2320230 <__func__.0> "tmx_check_pretran", mname = 0x70e5a231f420 "tmx", line = 271 64 file = 0x70e5a231f424 "tmx: tmx_pretran.c", func = 0x70e5a2320230 <__func__.0> "tmx_check_pretran", mname = 0x70e5a231f420 "tmx", line = 250 7 file = 0x70e59fc86854 "pua: event_list.c", func = 0x70e59fc86ad0 <__func__.1> "add_pua_event", mname = 0x70e59fc86850 "pua", line = 72 3 file = 0x70e5a297c249 "license: ../../core/ut.h", func = 0x70e5a297d4f8 <__func__.3> "shm_str_dup", mname = 0x70e5a297c000 "license", line = 722 3 file = 0x70e59fd329d4 "usrloc: udomain.c", func = 0x70e59fd35660 <__func__.22> "build_stat_name", mname = 0x70e59fd328a0 "usrloc", line = 56 ``` According to mod_stats for shmem over RPC the pua module was taking double as much memory as usrloc on the busy system. I have tried to address the issue shown on lines 773 and 861 and added clearing of hentity at the end of send_subscribe () : but it had caused the subscribe_200 outside of dialog to crash kamailio because of running the tm callback that accesses the hentity which is already free'd So I thought perhaps another approach is required and the tm callback should clean it, while I must say i do not 100% clear understand why this needs to be so complicated compared to other modules. Perhaps i have missed another bug and overcomplicated things because the uac_r seems to be cleaned just fine. The issue around the hentity does not seem to be solved in the latest releases while this is 5.3-something custom build. Anyway my last resort that could help is convert to use tm to clear memory once it is done, in tm/uac.c : t_uac_prepare() is registering a callback with release function ``` if(uac_r->cb && insert_tmcb(&(new_cell->tmcb_hl), uac_r->cb_flags, *(uac_r->cb), uac_r->cbp, NULL)!=1){ ret=E_OUT_OF_MEM; LM_ERR("short of tmcb shmem\n"); goto error1; } int insert_tmcb(struct tmcb_head_list *cb_list, int types, transaction_cb f, void *param, release_tmcb_param rel_func) { ``` is there any example of using such a relfunc in the other modules? Or anyone else has see the pua causing a mem leak when it is subscribed to reginfo from the config? I would appreciate some ideas what could be the issue and the solution. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3928 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3928(a)github.com>

4 8

git:master:fe56aa38: tls_wolfssl: legacy clean-up
by S-P Chan 30 Jul '24

30 Jul '24

Module: kamailio Branch: master Commit: fe56aa38a88a9961141bbcc2fc26d384af63734e URL: https://github.com/kamailio/kamailio/commit/fe56aa38a88a9961141bbcc2fc26d38… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-30T19:47:06+08:00 tls_wolfssl: legacy clean-up --- Modified: src/modules/tls_wolfssl/tls_init.c Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fe56aa38a88a9961141bbcc2fc26d38… Patch: https://github.com/kamailio/kamailio/commit/fe56aa38a88a9961141bbcc2fc26d38… --- diff --git a/src/modules/tls_wolfssl/tls_init.c b/src/modules/tls_wolfssl/tls_init.c index 2c8c4a4965c..8f2f994e961 100644 --- a/src/modules/tls_wolfssl/tls_init.c +++ b/src/modules/tls_wolfssl/tls_init.c @@ -221,7 +221,6 @@ static void *ser_realloc(void *ptr, size_t size, const char *file, int line) #endif return p; } - #else /*TLS_MALLOC_DBG */ static void *ser_malloc(size_t size) { @@ -234,6 +233,7 @@ static void *ser_realloc(void *ptr, size_t size) } #endif + static void ser_free(void *ptr) { if(ptr) { @@ -241,45 +241,6 @@ static void ser_free(void *ptr) } } -#if 0 -// up align memory allocations to 16 bytes for -// wolfSSL --enable-aligndata=yes (the default) -static const int MAX_ALIGN = __alignof__(max_align_t); - -static void* ser_malloc(size_t size) -{ - char* ptr = shm_malloc(size + MAX_ALIGN); - int pad = MAX_ALIGN - ((long) ptr % MAX_ALIGN); // 8 or 16 bytes - - memset(ptr, pad, pad); - return ptr + pad; -} - -static void* ser_realloc(void *ptr, size_t new_size) -{ - if(!ptr) return ser_malloc(new_size); - - int pad = *((char*)ptr - 1); // 8 or 16 bytes - char *real_ptr = (char*)ptr - pad; - - char *new_ptr = shm_realloc(real_ptr, new_size+MAX_ALIGN); - int new_pad = MAX_ALIGN - ((long) new_ptr % MAX_ALIGN); - if (new_pad != pad) { - memmove(new_ptr + new_pad, new_ptr + pad, new_size); - memset(new_ptr, new_pad, new_pad); - } - - return new_ptr + new_pad; -} - -static void ser_free(void *ptr) -{ - if (ptr) { - int pad = *((unsigned char *)ptr - 1); - shm_free((unsigned char*)ptr - pad); - } -} -#endif /* * Initialize TLS socket diff --git a/src/modules/tls_wolfssl/tls_wolfssl_mod.c b/src/modules/tls_wolfssl/tls_wolfssl_mod.c index e95cecb7be5..9a195b76b39 100644 --- a/src/modules/tls_wolfssl/tls_wolfssl_mod.c +++ b/src/modules/tls_wolfssl/tls_wolfssl_mod.c @@ -262,22 +262,6 @@ static struct tls_hooks tls_h = { }; -#if 0 -/* - * Create TLS configuration from modparams - */ -static tls_domains_cfg_t* tls_use_modparams(void) -{ - tls_domains_cfg_t* ret; - - ret = tls_new_cfg(); - if (!ret) return; - - -} -#endif - - static int mod_init(void) { int method;

1 0

git:master:072c4433: corex: switch to unsigned long long for iflag lookup
by Daniel-Constantin Mierla 30 Jul '24

30 Jul '24

Module: kamailio Branch: master Commit: 072c44330297c653675b5078fb0facdc399a5ab4 URL: https://github.com/kamailio/kamailio/commit/072c44330297c653675b5078fb0facd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-30T09:07:36+02:00 corex: switch to unsigned long long for iflag lookup --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/072c44330297c653675b5078fb0facd… Patch: https://github.com/kamailio/kamailio/commit/072c44330297c653675b5078fb0facd… --- diff --git a/src/modules/corex/corex_mod.c b/src/modules/corex/corex_mod.c index f055af88c8d..e853032cd7f 100644 --- a/src/modules/corex/corex_mod.c +++ b/src/modules/corex/corex_mod.c @@ -584,7 +584,7 @@ static msg_iflag_name_t _msg_iflag_list[] = { /** * */ -static int msg_lookup_flag(str *fname) +static unsigned long long msg_lookup_flag(str *fname) { int i; for(i = 0; _msg_iflag_list[i].name.len > 0; i++) { @@ -594,21 +594,22 @@ static int msg_lookup_flag(str *fname) return _msg_iflag_list[i].value; } } - return -1; + return 0; } + /** * */ static int w_msg_iflag_set(sip_msg_t *msg, char *pflag, char *p2) { - int fv; + unsigned long long fv; str fname; if(fixup_get_svalue(msg, (gparam_t *)pflag, &fname)) { LM_ERR("cannot get the msg flag name parameter\n"); return -1; } fv = msg_lookup_flag(&fname); - if(fv == -1) { + if(fv == 0) { LM_ERR("unsupported flag name [%.*s]\n", fname.len, fname.s); return -1; } @@ -621,14 +622,14 @@ static int w_msg_iflag_set(sip_msg_t *msg, char *pflag, char *p2) */ static int w_msg_iflag_reset(sip_msg_t *msg, char *pflag, char *p2) { - int fv; + unsigned long long fv; str fname; if(fixup_get_svalue(msg, (gparam_t *)pflag, &fname)) { LM_ERR("cannot get the msg flag name parameter\n"); return -1; } fv = msg_lookup_flag(&fname); - if(fv == -1) { + if(fv == 0) { LM_ERR("unsupported flag name [%.*s]\n", fname.len, fname.s); return -1; } @@ -641,14 +642,14 @@ static int w_msg_iflag_reset(sip_msg_t *msg, char *pflag, char *p2) */ static int w_msg_iflag_is_set(sip_msg_t *msg, char *pflag, char *p2) { - int fv; + unsigned long long fv; str fname; if(fixup_get_svalue(msg, (gparam_t *)pflag, &fname)) { LM_ERR("cannot get the msg flag name parameter\n"); return -1; } fv = msg_lookup_flag(&fname); - if(fv == -1) { + if(fv == 0) { LM_ERR("unsupported flag name [%.*s]\n", fname.len, fname.s); return -1; }

1 0

git:master:fdb0ef98: corex: proper check for iflag lookup return code
by Daniel-Constantin Mierla 30 Jul '24

30 Jul '24

Module: kamailio Branch: master Commit: fdb0ef987ca2b013104b06ece006f67bf8ae07d3 URL: https://github.com/kamailio/kamailio/commit/fdb0ef987ca2b013104b06ece006f67… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-30T08:55:08+02:00 corex: proper check for iflag lookup return code --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fdb0ef987ca2b013104b06ece006f67… Patch: https://github.com/kamailio/kamailio/commit/fdb0ef987ca2b013104b06ece006f67… --- diff --git a/src/modules/corex/corex_mod.c b/src/modules/corex/corex_mod.c index 4f3214049b6..f055af88c8d 100644 --- a/src/modules/corex/corex_mod.c +++ b/src/modules/corex/corex_mod.c @@ -608,7 +608,7 @@ static int w_msg_iflag_set(sip_msg_t *msg, char *pflag, char *p2) return -1; } fv = msg_lookup_flag(&fname); - if(fv == 1) { + if(fv == -1) { LM_ERR("unsupported flag name [%.*s]\n", fname.len, fname.s); return -1; } @@ -628,7 +628,7 @@ static int w_msg_iflag_reset(sip_msg_t *msg, char *pflag, char *p2) return -1; } fv = msg_lookup_flag(&fname); - if(fv < 0) { + if(fv == -1) { LM_ERR("unsupported flag name [%.*s]\n", fname.len, fname.s); return -1; } @@ -648,7 +648,7 @@ static int w_msg_iflag_is_set(sip_msg_t *msg, char *pflag, char *p2) return -1; } fv = msg_lookup_flag(&fname); - if(fv < 0) { + if(fv == -1) { LM_ERR("unsupported flag name [%.*s]\n", fname.len, fname.s); return -1; }

1 0

git:master:70606e3e: corex: small formatting of iflag list
by Daniel-Constantin Mierla 30 Jul '24

30 Jul '24

Module: kamailio Branch: master Commit: 70606e3ea575228b3ccc662d6f9048aa0eb899ce URL: https://github.com/kamailio/kamailio/commit/70606e3ea575228b3ccc662d6f9048a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-30T08:44:03+02:00 corex: small formatting of iflag list --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/70606e3ea575228b3ccc662d6f9048a… Patch: https://github.com/kamailio/kamailio/commit/70606e3ea575228b3ccc662d6f9048a… --- diff --git a/src/modules/corex/corex_mod.c b/src/modules/corex/corex_mod.c index 6739e4cee16..4f3214049b6 100644 --- a/src/modules/corex/corex_mod.c +++ b/src/modules/corex/corex_mod.c @@ -571,10 +571,14 @@ typedef struct _msg_iflag_name int value; } msg_iflag_name_t; +/* clang-format off */ static msg_iflag_name_t _msg_iflag_list[] = { - {str_init("USE_UAC_FROM"), FL_USE_UAC_FROM}, - {str_init("USE_UAC_TO"), FL_USE_UAC_TO}, - {str_init("UAC_AUTH"), FL_UAC_AUTH}, {{0, 0}, 0}}; + {str_init("USE_UAC_FROM"), FL_USE_UAC_FROM}, + {str_init("USE_UAC_TO"), FL_USE_UAC_TO}, + {str_init("UAC_AUTH"), FL_UAC_AUTH}, + {{0, 0}, 0} +}; +/* clang-format on */ /**

1 0

git:master:f4e14a94: tls_wolfssl: upstream v5.7.2-stable
by S-P Chan 29 Jul '24

29 Jul '24

Module: kamailio Branch: master Commit: f4e14a945d69e1555aa76431202693f0c855c916 URL: https://github.com/kamailio/kamailio/commit/f4e14a945d69e1555aa76431202693f… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-30T07:43:14+08:00 tls_wolfssl: upstream v5.7.2-stable --- Modified: misc/external/wolfssl/wolfssl --- Diff: https://github.com/kamailio/kamailio/commit/f4e14a945d69e1555aa76431202693f… Patch: https://github.com/kamailio/kamailio/commit/f4e14a945d69e1555aa76431202693f… --- diff --git a/misc/external/wolfssl/wolfssl b/misc/external/wolfssl/wolfssl index 66596ad9e1d..00e42151ca0 160000 --- a/misc/external/wolfssl/wolfssl +++ b/misc/external/wolfssl/wolfssl @@ -1 +1 @@ -Subproject commit 66596ad9e1d7efa8479656872cf09c9c1870a02e +Subproject commit 00e42151ca061463ba6a95adb2290f678cbca472

1 0

git:master:280c6cd0: tls_wolfssl: Makefile logging: reduce to info level
by S-P Chan 29 Jul '24

29 Jul '24

Module: kamailio Branch: master Commit: 280c6cd0fac7be75dede54c8e4a96ccf03312371 URL: https://github.com/kamailio/kamailio/commit/280c6cd0fac7be75dede54c8e4a96cc… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-30T07:39:57+08:00 tls_wolfssl: Makefile logging: reduce to info level --- Modified: src/modules/tls_wolfssl/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/280c6cd0fac7be75dede54c8e4a96cc… Patch: https://github.com/kamailio/kamailio/commit/280c6cd0fac7be75dede54c8e4a96cc… --- diff --git a/src/modules/tls_wolfssl/Makefile b/src/modules/tls_wolfssl/Makefile index dda5ad4779e..e327def77c1 100644 --- a/src/modules/tls_wolfssl/Makefile +++ b/src/modules/tls_wolfssl/Makefile @@ -62,4 +62,4 @@ clean-all: clean-wolfssl clean-module .PHONY: clean-wolfssl clean-module clean-all # debugging for dependency on lib/wolfssl -$(warning sources = $(sources), auto_gen = $(auto_gen), objs = $(objs)) +$(info sources = $(sources), auto_gen = $(auto_gen), objs = $(objs))

1 0

[kamailio/kamailio] pkg: Add systemd template for starting multiple kamailio services (PR #3904)
by Xenofon Karamanos 29 Jul '24

29 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR aims to allow multiple kamailio instances with different configs to be managed by systemd. The new `kamailio@.service` is the systemd template file, where one can provide an instance name after `systemctl start kamailio@dev`, to start a new kamailio instance with name `kamailio-dev` and use config file found in `/etc/kamailio/kamailio-dev.cfg`. I tested that this file and its content can work by placing the file in `/etc/systemd/system/kamailio@.service` and using the above `dev` instance name as an example. Kamailio loads and handles any new messages along with the default kamailio service. My question right now, as I am not really familiar with the packaging workflow, is this an appropriate way to accomplish it. If yes what should be modified to install this alongside the normal `kamailio.service`. Any feedback and review is appreciated and greatly needed! Thanks! You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3904 -- Commit Summary -- * pkg: Add systemd template for starting multiple kamailio services -- File Changes -- A pkg/kamailio/deb/debian/kamailio@.service (26) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3904.patch https://github.com/kamailio/kamailio/pull/3904.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3904 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3904(a)github.com>

3 21

git:master:097cd735: pkg/kamailio/deb: refresh after service template added
by Victor Seva 29 Jul '24

29 Jul '24

Module: kamailio Branch: master Commit: 097cd7353efc251fb764e6f7c88e3330c794d369 URL: https://github.com/kamailio/kamailio/commit/097cd7353efc251fb764e6f7c88e333… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-29T12:31:10+02:00 pkg/kamailio/deb: refresh after service template added at a8cb23903b271a1b78456fed5da8e10474aee405 --- Added: pkg/kamailio/deb/bionic/kamailio@.service Added: pkg/kamailio/deb/bookworm/kamailio@.service Added: pkg/kamailio/deb/bullseye/kamailio@.service Added: pkg/kamailio/deb/buster/kamailio@.service Added: pkg/kamailio/deb/focal/kamailio@.service Added: pkg/kamailio/deb/jammy/kamailio@.service Added: pkg/kamailio/deb/jessie/kamailio@.service Added: pkg/kamailio/deb/precise/kamailio@.service Added: pkg/kamailio/deb/sid/kamailio@.service Added: pkg/kamailio/deb/stretch/kamailio@.service Added: pkg/kamailio/deb/trusty/kamailio@.service Added: pkg/kamailio/deb/wheezy/kamailio@.service Added: pkg/kamailio/deb/xenial/kamailio@.service --- Diff: https://github.com/kamailio/kamailio/commit/097cd7353efc251fb764e6f7c88e333… Patch: https://github.com/kamailio/kamailio/commit/097cd7353efc251fb764e6f7c88e333…

1 0

git:master:add65a47: sdpops: use proper include guard for the file
by Daniel-Constantin Mierla 29 Jul '24

29 Jul '24

Module: kamailio Branch: master Commit: add65a4799c1650ea36c657d190fa0027e798404 URL: https://github.com/kamailio/kamailio/commit/add65a4799c1650ea36c657d190fa00… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-29T11:24:00+02:00 sdpops: use proper include guard for the file --- Modified: src/modules/sdpops/sdpops_path.h --- Diff: https://github.com/kamailio/kamailio/commit/add65a4799c1650ea36c657d190fa00… Patch: https://github.com/kamailio/kamailio/commit/add65a4799c1650ea36c657d190fa00… --- diff --git a/src/modules/sdpops/sdpops_path.h b/src/modules/sdpops/sdpops_path.h index 0e7d7088a97..620d9981a00 100644 --- a/src/modules/sdpops/sdpops_path.h +++ b/src/modules/sdpops/sdpops_path.h @@ -20,8 +20,8 @@ */ -#ifndef _SDPOPS_DATA_H_ -#define _SDPOPS_DATA_H_ +#ifndef _SDPOPS_PATH_H_ +#define _SDPOPS_PATH_H_ #include "../../core/str.h" #include "../../core/parser/sdp/sdp.h"

1 0

git:master:49a9c0a0: cplc: use long long constants for operations
by Daniel-Constantin Mierla 29 Jul '24

29 Jul '24

Module: kamailio Branch: master Commit: 49a9c0a0f391c2e9fc45dff7c37a087dde0f7ba3 URL: https://github.com/kamailio/kamailio/commit/49a9c0a0f391c2e9fc45dff7c37a087… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-29T10:07:43+02:00 cplc: use long long constants for operations --- Modified: src/modules/cplc/cpl_time.c --- Diff: https://github.com/kamailio/kamailio/commit/49a9c0a0f391c2e9fc45dff7c37a087… Patch: https://github.com/kamailio/kamailio/commit/49a9c0a0f391c2e9fc45dff7c37a087… --- diff --git a/src/modules/cplc/cpl_time.c b/src/modules/cplc/cpl_time.c index b22fe5e8cf9..aea3265d8e8 100644 --- a/src/modules/cplc/cpl_time.c +++ b/src/modules/cplc/cpl_time.c @@ -264,8 +264,9 @@ int cpl_ac_print(cpl_ac_tm_p _atp) return -1; } - printf("\nSys time: %llu\nTime: %02d:%02d:%02d\n", (unsigned long long)_atp->time, - _atp->t.tm_hour, _atp->t.tm_min, _atp->t.tm_sec); + printf("\nSys time: %llu\nTime: %02d:%02d:%02d\n", + (unsigned long long)_atp->time, _atp->t.tm_hour, _atp->t.tm_min, + _atp->t.tm_sec); printf("Date: %s, %04d-%02d-%02d\n", _wdays[_atp->t.tm_wday], _atp->t.tm_year + 1900, _atp->t.tm_mon + 1, _atp->t.tm_mday); printf("Year day: %d\nYear week-day: %d\nYear week: %d\n", _atp->t.tm_yday, @@ -994,8 +995,8 @@ int cpl_check_freq_interval(cpl_tmrec_p _trp, cpl_ac_tm_p _atp) ? REC_MATCH : REC_NOMATCH; #ifdef USE_YWEEK_U - _t0 -= _trp->ts.tm_wday * 24 * 3600; - _t1 -= _atp->t.tm_wday * 24 * 3600; + _t0 -= 24ULL * _trp->ts.tm_wday * 3600; + _t1 -= 24ULL * _atp->t.tm_wday * 3600; #else _t0 -= ((_trp->ts.tm_wday + 6) % 7) * 24 * 3600; _t1 -= ((_atp->t.tm_wday + 6) % 7) * 24 * 3600; @@ -1004,7 +1005,7 @@ int cpl_check_freq_interval(cpl_tmrec_p _trp, cpl_ac_tm_p _atp) ? REC_MATCH : REC_NOMATCH; case FREQ_MONTHLY: - _t0 = (_atp->t.tm_year - _trp->ts.tm_year) * 12 + _atp->t.tm_mon + _t0 = 12ULL * (_atp->t.tm_year - _trp->ts.tm_year) + _atp->t.tm_mon - _trp->ts.tm_mon; return (_t0 % _trp->interval == 0) ? REC_MATCH : REC_NOMATCH; case FREQ_YEARLY:

1 0

git:master:fc2f34e8: core: tcp - use long long constants for operations
by Daniel-Constantin Mierla 29 Jul '24

29 Jul '24

Module: kamailio Branch: master Commit: fc2f34e8bab022b0c99e8313aee3e4a87c1f2e52 URL: https://github.com/kamailio/kamailio/commit/fc2f34e8bab022b0c99e8313aee3e4a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-29T09:44:47+02:00 core: tcp - use long long constants for operations --- Modified: src/core/tcp_read.c --- Diff: https://github.com/kamailio/kamailio/commit/fc2f34e8bab022b0c99e8313aee3e4a… Patch: https://github.com/kamailio/kamailio/commit/fc2f34e8bab022b0c99e8313aee3e4a… --- diff --git a/src/core/tcp_read.c b/src/core/tcp_read.c index 8fa6566c14b..fd60918fe34 100644 --- a/src/core/tcp_read.c +++ b/src/core/tcp_read.c @@ -449,9 +449,9 @@ int tcp_read_headers(struct tcp_connection *c, rd_conn_flags_t *read_flags) if(bytes <= 0) return bytes; gettimeofday(&tvnow, NULL); - tvdiff = 1000000 * (tvnow.tv_sec - r->tvrstart.tv_sec) + tvdiff = 1000000LL * (tvnow.tv_sec - r->tvrstart.tv_sec) + (tvnow.tv_usec - r->tvrstart.tv_usec); - if(tvdiff >= ksr_tcp_msg_read_timeout * 1000000) { + if(tvdiff >= 1000000LL * ksr_tcp_msg_read_timeout) { LM_ERR("message reading timeout after %lld usec\n", tvdiff); r->parsed = r->buf; r->content_len = 0;

1 0

Contribute with AUR package
by Nikos Toutountzoglou 29 Jul '24

29 Jul '24

Dear Sirs, I have adopted an orphaned AUR package and tried to fine tune it to be used with Your great Kamailio open source project. I can continue to maintain it in the AUR space. If anything needs to be modified in the package please let me know. Link to the package: https://aur.archlinux.org/packages/kamailio or web search !aur kamailio Regards, Nikos

2 1

git:master:e86d6ee3: db_berkeley: buffer size set to the argument of strftime()
by Daniel-Constantin Mierla 27 Jul '24

27 Jul '24

Module: kamailio Branch: master Commit: e86d6ee30227a3fc5cff98e7983d4a80f0c42c4b URL: https://github.com/kamailio/kamailio/commit/e86d6ee30227a3fc5cff98e7983d4a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-27T18:16:40+02:00 db_berkeley: buffer size set to the argument of strftime() --- Modified: src/modules/db_berkeley/km_bdb_lib.c --- Diff: https://github.com/kamailio/kamailio/commit/e86d6ee30227a3fc5cff98e7983d4a8… Patch: https://github.com/kamailio/kamailio/commit/e86d6ee30227a3fc5cff98e7983d4a8… --- diff --git a/src/modules/db_berkeley/km_bdb_lib.c b/src/modules/db_berkeley/km_bdb_lib.c index 06feb6e4bac..4761084c974 100644 --- a/src/modules/db_berkeley/km_bdb_lib.c +++ b/src/modules/db_berkeley/km_bdb_lib.c @@ -676,7 +676,7 @@ int km_bdblib_create_journal(table_p _tp) { char *s; char fn[1024]; - char d[64]; + char d[128]; FILE *fp = NULL; struct tm *t; int bl;

1 0

git:master:3333611a: core: cfg select - check res when getting the variable
by Daniel-Constantin Mierla 26 Jul '24

26 Jul '24

Module: kamailio Branch: master Commit: 3333611a3ef9078cbcb9867db88921f0c48fce1b URL: https://github.com/kamailio/kamailio/commit/3333611a3ef9078cbcb9867db88921f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-26T19:50:40+02:00 core: cfg select - check res when getting the variable --- Modified: src/core/cfg/cfg_select.c --- Diff: https://github.com/kamailio/kamailio/commit/3333611a3ef9078cbcb9867db88921f… Patch: https://github.com/kamailio/kamailio/commit/3333611a3ef9078cbcb9867db88921f… --- diff --git a/src/core/cfg/cfg_select.c b/src/core/cfg/cfg_select.c index e6c599a204e..b4e9e6ebef7 100644 --- a/src/core/cfg/cfg_select.c +++ b/src/core/cfg/cfg_select.c @@ -212,7 +212,7 @@ int select_cfg_var(str *res, select_t *s, struct sip_msg *msg) group = (cfg_group_t *)s->params[1].v.p; var = (cfg_mapping_t *)s->params[2].v.p; - if(!group || !var) + if(!group || !var || !res) return -1; /* use the module's handle to access the variable, so the variables

1 0

git:master:660a0192: xprint: return on mod init error case
by Daniel-Constantin Mierla 26 Jul '24

26 Jul '24

Module: kamailio Branch: master Commit: 660a019263b81d318700c205531bf4e042c912cf URL: https://github.com/kamailio/kamailio/commit/660a019263b81d318700c205531bf4e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-26T19:50:40+02:00 xprint: return on mod init error case --- Modified: src/modules/xprint/xp_lib.c --- Diff: https://github.com/kamailio/kamailio/commit/660a019263b81d318700c205531bf4e… Patch: https://github.com/kamailio/kamailio/commit/660a019263b81d318700c205531bf4e… --- diff --git a/src/modules/xprint/xp_lib.c b/src/modules/xprint/xp_lib.c index b6fc5066556..fda12a82fc3 100644 --- a/src/modules/xprint/xp_lib.c +++ b/src/modules/xprint/xp_lib.c @@ -1899,6 +1899,7 @@ int xl_mod_init() s = NULL; str_ipaddr.len = 0; PKG_MEM_ERROR_FMT("for str_ipaddr\n"); + return -1; } } else if(strncmp(str_ipaddr.s, s, str_ipaddr.len) != 0) {

1 0

[kamailio/kamailio] Advertise in listen directive doesn't let to use hostname without port (Issue #3932)
by Evgenii Buchnev 26 Jul '24

26 Jul '24

Hey Team, Thank you for the awesome software ### Description Neither option work: `listen=... advertise some.custom.hostname.io` `listen=... advertise some.custom.hostname.io:0` to make Kamailio present only hostname(without port) in Record-Route headers, affects NAPTR/SRV. ### Troubleshooting ============ _Hostname without port - still gives port 5081 in Record-Route_ **kamailio.cfg** ... `listen=tls:KAM_LOC_IP:5081 advertise some.custom.io name "provider_socket_tls"` ... **sngrep, 200 OK for INVITE** ... `Record-Route: <sip:some.custom.io:5081;transport=tls;r2=on;lr;did=494.6e51>` ... **kamcmd corex.list_sockets** ... ``` { af: IPv4 proto: tls name: 172.17.57.164 addrlist: { addr: 172.17.57.164 } port: 5081 sockstr: tls:172.17.57.164:5081 mcast: no mhomed: no virtual: no sockname: provider_socket_tls advertise: tls:some.custom.io:0 } ``` ... ======== _Hostname with port 0 - still gives port 5081 in Record-Route_ kamailio.cfg ... `listen=tls:KAM_LOC_IP:5081 advertise some.custom.io:0 name "provider_socket_tls"` ... sngrep, 200 OK for INVITE ... `Record-Route: <sip:some.custom.io:5081;transport=tls;r2=on;lr;did=042.7721>` ... kamcmd corex.list_sockets ... ``` { af: IPv4 proto: tls name: 172.17.57.164 addrlist: { addr: 172.17.57.164 } port: 5081 sockstr: tls:172.17.57.164:5081 mcast: no mhomed: no virtual: no sockname: provider_socket_tls advertise: tls:some.custom.io:0 } ``` ... ============ _Hostname with explicit different port 8888 - gives that port 8888 in Record-Route (to confirm config works)_ kamailio.cfg ... `listen=tls:KAM_LOC_IP:5081 advertise some.custom.io:8888 name "provider_socket_tls"` ... sngrep, 200 OK for INVITE ... `Record-Route: <sip:some.custom.io:8888;transport=tls;r2=on;lr;did=dae.ac31>` ... kamcmd corex.list_sockets ... ``` { af: IPv4 proto: tls name: 172.17.57.164 addrlist: { addr: 172.17.57.164 } port: 5081 sockstr: tls:172.17.57.164:5081 mcast: no mhomed: no virtual: no sockname: provider_socket_tls advertise: tls:some.custom.io:8888 } ``` ... #### Reproduction Please see Troubleshooting section #### Debugging Data Please see Troubleshooting section #### Log Messages N/A #### SIP Traffic Please see Troubleshooting section ### Possible Solutions N/A ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.2 (x86_64/linux) dbe51d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: dbe51d compiled on 07:13:22 Jul 17 2024 with gcc 12.2.0) ``` * **Operating System**: ``` [dev]root@[voiceproxy]:~# lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm [dev]root@[voiceproxy]:~# uname -a Linux i-0875d7720d6152612 6.1.0-23-cloud-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.99-1 (2024-07-15) x86_64 GNU/Linux [dev]root@[voiceproxy]:~# cat /etc/*relea* ID=ec2 VERSION="20240702-1796" PRETTY_NAME="Debian GNU/Linux 12 (bookworm)" NAME="Debian GNU/Linux" VERSION_ID="12" VERSION="12 (bookworm)" VERSION_CODENAME=bookworm ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/" ``` * **Might be related** : https://github.com/kamailio/kamailio/issues/1884 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3932 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3932(a)github.com>

2 4

[kamailio/kamailio] cdp: fix use after free in transaction call backs (PR #3931)
by Rick Barenthin 25 Jul '24

25 Jul '24

If the traction is set to auto drop, the memory will be freed and with it the next pointer.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  The use after free caused on a Load tested system crashes. Now the next pointer is saved before executing the callback and handle the auto drop. Then the stored next pointer is used to continue the iteration over the callbacks. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3931 -- Commit Summary -- * cdp: fix use after free in transaction call backs -- File Changes -- M src/modules/cdp/transaction.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3931.patch https://github.com/kamailio/kamailio/pull/3931.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3931 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3931(a)github.com>

3 2

git:master:a71bd9d9: cdp: fix use after free in transaction call backs
by Daniel-Constantin Mierla 25 Jul '24

25 Jul '24

Module: kamailio Branch: master Commit: a71bd9d9424456ef1167468c5bbbfd38b1099e89 URL: https://github.com/kamailio/kamailio/commit/a71bd9d9424456ef1167468c5bbbfd3… Author: Rick Barenthin <rick(a)ng-voice.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-25T12:20:59+02:00 cdp: fix use after free in transaction call backs If the traction is set to auto drop, the memory will be freed and with it the next pointer. --- Modified: src/modules/cdp/transaction.c --- Diff: https://github.com/kamailio/kamailio/commit/a71bd9d9424456ef1167468c5bbbfd3… Patch: https://github.com/kamailio/kamailio/commit/a71bd9d9424456ef1167468c5bbbfd3… --- diff --git a/src/modules/cdp/transaction.c b/src/modules/cdp/transaction.c index f1445ff15be..a2b97654dd0 100644 --- a/src/modules/cdp/transaction.c +++ b/src/modules/cdp/transaction.c @@ -256,10 +256,11 @@ int cdp_trans_timer(time_t now, void *ptr) /* do all queued callbacks */ x = cb_queue->head; while(x) { + n = x->next; (x->cb)(1, *(x->ptr), 0, (now - x->expires)); if(x->auto_drop) cdp_free_trans(x); - x = x->next; + x = n; } pkg_free(cb_queue);

1 0

[kamailio/kamailio] ims_qos_npn: fixed issues discovered by coverity (PR #3926)
by Dragos Vingarzan 25 Jul '24

25 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Fixing issues discovered by Coverity You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3926 -- Commit Summary -- * ims_qos_npn: fixed issues discovered by coverity -- File Changes -- M src/modules/ims_qos_npn/rx_aar.c (12) M src/modules/ims_qos_npn/rx_avp.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3926.patch https://github.com/kamailio/kamailio/pull/3926.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3926 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3926(a)github.com>

2 2

git:master:79433959: ims_qos_npn: fixed missing breaks in switch and checks for null pointers
by Dragos Vingarzan 25 Jul '24

25 Jul '24

Module: kamailio Branch: master Commit: 7943395957c070a16553b16536e5be59b4719d9b URL: https://github.com/kamailio/kamailio/commit/7943395957c070a16553b16536e5be5… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-25T11:47:24+02:00 ims_qos_npn: fixed missing breaks in switch and checks for null pointers --- Modified: src/modules/ims_qos_npn/rx_aar.c Modified: src/modules/ims_qos_npn/rx_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/7943395957c070a16553b16536e5be5… Patch: https://github.com/kamailio/kamailio/commit/7943395957c070a16553b16536e5be5… --- diff --git a/src/modules/ims_qos_npn/rx_aar.c b/src/modules/ims_qos_npn/rx_aar.c index fc99344c2c6..4423a0561b2 100644 --- a/src/modules/ims_qos_npn/rx_aar.c +++ b/src/modules/ims_qos_npn/rx_aar.c @@ -615,7 +615,7 @@ int add_media_components(AAAMessage *aar, struct sip_msg *req, //check if the src or dst port is 0 and if so then don't add to rx intportA = atoi(req_sdp_stream->port.s); - if(rpl) { + if(rpl_sdp_stream) { intportB = atoi(rpl_sdp_stream->port.s); } if(intportA != 0 && (rpl && intportB != 0)) { @@ -719,18 +719,20 @@ int add_media_components(AAAMessage *aar, struct sip_msg *req, auth->u.auth.generic_data, sdp_stream_num + 1, &req_sdp_stream->media, &ipA, &portA, &ipB, &portB, - rpl ? &rpl_sdp_stream->transport : 0, + rpl_sdp_stream ? &rpl_sdp_stream->transport : 0, &req_sdp_stream->raw_stream, - rpl ? &rpl_sdp_stream->raw_stream : 0, + rpl_sdp_stream ? &rpl_sdp_stream->raw_stream + : 0, direction, 0 /*This is a new mcd, we are not setting it as active*/); rx_add_media_component_description_avp(aar, sdp_stream_num + 1, &req_sdp_stream->media, &ipA, &portA, &ipB, &portB, - rpl ? &rpl_sdp_stream->transport : 0, + rpl_sdp_stream ? &rpl_sdp_stream->transport : 0, &req_sdp_stream->raw_stream, - rpl ? &rpl_sdp_stream->raw_stream : 0, + rpl_sdp_stream ? &rpl_sdp_stream->raw_stream + : 0, direction, AVP_EPC_Flow_Usage_No_Information); } add_flow = 1; diff --git a/src/modules/ims_qos_npn/rx_avp.c b/src/modules/ims_qos_npn/rx_avp.c index a0053138b4f..a2fd3188efe 100644 --- a/src/modules/ims_qos_npn/rx_avp.c +++ b/src/modules/ims_qos_npn/rx_avp.c @@ -1402,7 +1402,7 @@ int rx_mcc_mnc_to_sip_visited(str *dst, str src) } mcc = (100 * (src.s[0] - '0') + (10 * (src.s[1] - '0')) + ((src.s[2] - '0'))); - if(mcc < 0 || mcc >= 999) { + if(mcc >= 999) { LOG(L_ERR, "Invalid MCC value\n"); return 0; } @@ -1699,6 +1699,7 @@ int rx_avp_process_3gpp_user_location_information(AAAMessage *rar, str *dst) p += 7; length -= 7; } + break; case 1: // SAI if(length >= 7) { @@ -1707,6 +1708,7 @@ int rx_avp_process_3gpp_user_location_information(AAAMessage *rar, str *dst) p += 7; length -= 7; } + break; case 2: // RAI if(length >= 7) { @@ -1715,6 +1717,7 @@ int rx_avp_process_3gpp_user_location_information(AAAMessage *rar, str *dst) p += 7; length -= 7; } + break; case 3 ... 127: // spare for future use break;

1 0

git:master:b4efe772: janssonrpcc: free new servers list on error
by Daniel-Constantin Mierla 25 Jul '24

25 Jul '24

Module: kamailio Branch: master Commit: b4efe7725728392d0c8921c006d6fbc6455e9b8f URL: https://github.com/kamailio/kamailio/commit/b4efe7725728392d0c8921c006d6fbc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-25T10:59:15+02:00 janssonrpcc: free new servers list on error --- Modified: src/modules/janssonrpcc/janssonrpc_srv.c --- Diff: https://github.com/kamailio/kamailio/commit/b4efe7725728392d0c8921c006d6fbc… Patch: https://github.com/kamailio/kamailio/commit/b4efe7725728392d0c8921c006d6fbc… --- diff --git a/src/modules/janssonrpcc/janssonrpc_srv.c b/src/modules/janssonrpcc/janssonrpc_srv.c index 73eb25ce62d..9b7ac31c084 100644 --- a/src/modules/janssonrpcc/janssonrpc_srv.c +++ b/src/modules/janssonrpcc/janssonrpc_srv.c @@ -90,6 +90,7 @@ int refresh_srv(jsonrpc_srv_t *srv_obj) srv_record = (struct srv_rdata *)l->rdata; if(srv_record == NULL) { free_rdata_list(head); + free_server_list(new_servers); ERR("BUG: null rdata\n"); return -1; }

1 0

git:master:a8cb2390: pkg: Add systemd template for starting multiple kamailio services
by Xenofon Karamanos 25 Jul '24

25 Jul '24

Module: kamailio Branch: master Commit: a8cb23903b271a1b78456fed5da8e10474aee405 URL: https://github.com/kamailio/kamailio/commit/a8cb23903b271a1b78456fed5da8e10… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-07-25T11:11:36+03:00 pkg: Add systemd template for starting multiple kamailio services --- Added: pkg/kamailio/deb/debian/kamailio@.service --- Diff: https://github.com/kamailio/kamailio/commit/a8cb23903b271a1b78456fed5da8e10… Patch: https://github.com/kamailio/kamailio/commit/a8cb23903b271a1b78456fed5da8e10… --- diff --git a/pkg/kamailio/deb/debian/kamailio@.service b/pkg/kamailio/deb/debian/kamailio@.service new file mode 100644 index 00000000000..81c06394d17 --- /dev/null +++ b/pkg/kamailio/deb/debian/kamailio@.service @@ -0,0 +1,26 @@ +[Unit] +Description=Kamailio - the Open Source SIP Server (instance %i) +Documentation=man:kamailio(8) +Wants=network-online.target +After=network-online.target + +[Service] +Type=forking +User=kamailio +Group=kamailio +Environment='CFGFILE=/etc/kamailio/kamailio-%i.cfg' +Environment='SHM_MEMORY=64' +Environment='PKG_MEMORY=8' +EnvironmentFile=-/etc/default/kamailio-%i +EnvironmentFile=-/etc/default/kamailio-%i.d/* +# PIDFile requires a full absolute path +PIDFile=/run/kamailio-%i/kamailio.pid +# ExecStart requires a full absolute path +ExecStart=/usr/sbin/kamailio -P /run/kamailio-%i/kamailio.pid -Y /run/kamailio-%i -f $CFGFILE -m $SHM_MEMORY -M $PKG_MEMORY +Restart=on-failure +# /run/kamailio in tmpfs +RuntimeDirectory=kamailio-%i +RuntimeDirectoryMode=0770 + +[Install] +WantedBy=multi-user.target

1 0

git:master:a6c41571: core: cfg select - check res before initializing
by Daniel-Constantin Mierla 25 Jul '24

25 Jul '24

Module: kamailio Branch: master Commit: a6c415713bb209b03ff110d4ae891173d04ac471 URL: https://github.com/kamailio/kamailio/commit/a6c415713bb209b03ff110d4ae89117… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-25T08:44:15+02:00 core: cfg select - check res before initializing --- Modified: src/core/cfg/cfg_select.c --- Diff: https://github.com/kamailio/kamailio/commit/a6c415713bb209b03ff110d4ae89117… Patch: https://github.com/kamailio/kamailio/commit/a6c415713bb209b03ff110d4ae89117… --- diff --git a/src/core/cfg/cfg_select.c b/src/core/cfg/cfg_select.c index f3b2d681d3e..e6c599a204e 100644 --- a/src/core/cfg/cfg_select.c +++ b/src/core/cfg/cfg_select.c @@ -147,8 +147,10 @@ int select_cfg_var(str *res, select_t *s, struct sip_msg *msg) int i; static char buf[INT2STR_MAX_LEN]; - res->s = 0; - res->len = 0; + if(res != NULL) { + res->s = 0; + res->len = 0; + } if(msg == NULL) { /* fixup call */

1 0

[kamailio/kamailio] t_uac_send parser does not like exclamation or other non alphabetic characters in Contact header (Issue #3682)
by xaled1 24 Jul '24

24 Jul '24

Hi there is an issue with the SIP parser for the t_uac_send function https://www.kamailio.org/docs/modules/devel/modules/tm.html#tm.f.t_uac_send If I call this function for example: t_uac_send("INVITE", "sip:test@123.123.123.123:5060", "", "" ,"Content-Type: text/plain\r\nContact: <sip:85951b3d-096c-95d6-5f05-4f38095aca9f@172.17.64.120:5060;transport=tcp>;+u.sip!devicename.ccm.cisco.com=\"SEP5486BC7F2BBC\"", "Testbody") Then the resulting request is broken - it's probably due to a character (exclamation mark?) in the Contact header.... I tested it with a call from kemi, but it probably also occurs when you run it with a normal kamailio -script tests -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3682 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3682(a)github.com>

3 4

git:master:7ba313f6: jsonrpcc: declare variables are the beginning of function
by Daniel-Constantin Mierla 24 Jul '24

24 Jul '24

Module: kamailio Branch: master Commit: 7ba313f6f96ffa6042c163027c0c7bb65106fef7 URL: https://github.com/kamailio/kamailio/commit/7ba313f6f96ffa6042c163027c0c7bb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-24T10:43:18+02:00 jsonrpcc: declare variables are the beginning of function --- Modified: src/modules/jsonrpcc/netstring.c --- Diff: https://github.com/kamailio/kamailio/commit/7ba313f6f96ffa6042c163027c0c7bb… Patch: https://github.com/kamailio/kamailio/commit/7ba313f6f96ffa6042c163027c0c7bb… --- diff --git a/src/modules/jsonrpcc/netstring.c b/src/modules/jsonrpcc/netstring.c index be7a5de8108..9328a46215e 100644 --- a/src/modules/jsonrpcc/netstring.c +++ b/src/modules/jsonrpcc/netstring.c @@ -35,11 +35,13 @@ int netstring_read_fd(int fd, char **netstring) { int i, bytes; size_t len = 0; + size_t read_len = 0; + char buffer[10] = {0}; + char *buffer2 = NULL; + int x; *netstring = NULL; - char buffer[10] = {0}; - /* Peek at first 10 bytes, to get length and colon */ bytes = recv(fd, buffer, 10, MSG_PEEK); @@ -68,8 +70,8 @@ int netstring_read_fd(int fd, char **netstring) return NETSTRING_ERROR_NO_COLON; /* Read the whole string from the buffer */ - size_t read_len = i + len + 1; - char *buffer2 = pkg_malloc(read_len); + read_len = i + len + 1; + buffer2 = pkg_malloc(read_len); if(!buffer2) { LM_ERR("Out of memory!"); return -1; @@ -90,8 +92,6 @@ int netstring_read_fd(int fd, char **netstring) buffer2[read_len - 1] = '\0'; - int x; - for(x = 0; x <= read_len - i - 1; x++) { buffer2[x] = buffer2[x + i]; }

1 0

git:master:796bcc03: jsonrpcc: free allocated pkg buffer on error
by Daniel-Constantin Mierla 24 Jul '24

24 Jul '24

Module: kamailio Branch: master Commit: 796bcc038d7885e01dbad34abc68bf612062c533 URL: https://github.com/kamailio/kamailio/commit/796bcc038d7885e01dbad34abc68bf6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-24T10:37:21+02:00 jsonrpcc: free allocated pkg buffer on error --- Modified: src/modules/jsonrpcc/netstring.c --- Diff: https://github.com/kamailio/kamailio/commit/796bcc038d7885e01dbad34abc68bf6… Patch: https://github.com/kamailio/kamailio/commit/796bcc038d7885e01dbad34abc68bf6… --- diff --git a/src/modules/jsonrpcc/netstring.c b/src/modules/jsonrpcc/netstring.c index bf7294ceb41..be7a5de8108 100644 --- a/src/modules/jsonrpcc/netstring.c +++ b/src/modules/jsonrpcc/netstring.c @@ -77,12 +77,16 @@ int netstring_read_fd(int fd, char **netstring) bytes = recv(fd, buffer2, read_len, 0); /* Make sure we got the whole netstring */ - if(read_len > bytes) + if(read_len > bytes) { + pkg_free(buffer2); return NETSTRING_ERROR_TOO_SHORT; + } /* Test for the trailing comma */ - if(buffer2[read_len - 1] != ',') + if(buffer2[read_len - 1] != ',') { + pkg_free(buffer2); return NETSTRING_ERROR_NO_COMMA; + } buffer2[read_len - 1] = '\0';

1 0

git:master:e9684113: Makefile.groups: removed osp module
by Daniel-Constantin Mierla 23 Jul '24

23 Jul '24

Module: kamailio Branch: master Commit: e96841130fd4d3a1e362170beef6b83e7a84f1cc URL: https://github.com/kamailio/kamailio/commit/e96841130fd4d3a1e362170beef6b83… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-23T12:56:32+02:00 Makefile.groups: removed osp module --- Modified: src/Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/e96841130fd4d3a1e362170beef6b83… Patch: https://github.com/kamailio/kamailio/commit/e96841130fd4d3a1e362170beef6b83… --- diff --git a/src/Makefile.groups b/src/Makefile.groups index b40781bf5cd..bda4f36a258 100644 --- a/src/Makefile.groups +++ b/src/Makefile.groups @@ -172,9 +172,6 @@ mod_list_ims=cdp cdp_avp ims_dialog ims_auth ims_isc ims_icscf ims_qos ims_qos_n ims_usrloc_scscf ims_charging ims_ocs ims_diameter_server \ ims_ipsec_pcscf -# - modules depending on osp toolkit library -mod_list_osp=osp - # - modules depending on java library mod_list_java=app_java @@ -268,7 +265,7 @@ mod_list_all=$(sort $(mod_list_basic) $(mod_list_extra) \ $(mod_list_redis) \ $(mod_list_mono) $(mod_list_ims) \ $(mod_list_cassandra) $(mod_list_oracle) \ - $(mod_list_outbound) $(mod_list_osp) \ + $(mod_list_outbound) \ $(mod_list_java) $(mod_list_dnssec) \ $(mod_list_sctp) $(mod_list_autheph) \ $(mod_list_gzcompress) $(mod_list_uuid) \

1 0

git:master:193a8457: osp: module relocated to archive
by Daniel-Constantin Mierla 23 Jul '24

23 Jul '24

Module: kamailio Branch: master Commit: 193a8457af56dea6e7a1320df1d77d52e0951584 URL: https://github.com/kamailio/kamailio/commit/193a8457af56dea6e7a1320df1d77d5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-23T12:54:27+02:00 osp: module relocated to archive --- Removed: src/modules/osp/Makefile Removed: src/modules/osp/README Removed: src/modules/osp/RELEASE-NOTES.txt Removed: src/modules/osp/destination.c Removed: src/modules/osp/destination.h Removed: src/modules/osp/doc/Makefile Removed: src/modules/osp/doc/osp.xml Removed: src/modules/osp/doc/osp_admin.xml Removed: src/modules/osp/doc/osp_devel.xml Removed: src/modules/osp/etc/cacert_0.pem Removed: src/modules/osp/etc/localcert.pem Removed: src/modules/osp/etc/pkey.pem Removed: src/modules/osp/etc/sample-osp-kamailio.cfg Removed: src/modules/osp/globals.c Removed: src/modules/osp/orig_transaction.c Removed: src/modules/osp/orig_transaction.h Removed: src/modules/osp/osp_mod.c Removed: src/modules/osp/osp_mod.h Removed: src/modules/osp/osptoolkit.c Removed: src/modules/osp/osptoolkit.h Removed: src/modules/osp/provider.c Removed: src/modules/osp/provider.h Removed: src/modules/osp/sipheader.c Removed: src/modules/osp/sipheader.h Removed: src/modules/osp/term_transaction.c Removed: src/modules/osp/term_transaction.h Removed: src/modules/osp/tm.c Removed: src/modules/osp/tm.h Removed: src/modules/osp/usage.c Removed: src/modules/osp/usage.h --- Diff: https://github.com/kamailio/kamailio/commit/193a8457af56dea6e7a1320df1d77d5… Patch: https://github.com/kamailio/kamailio/commit/193a8457af56dea6e7a1320df1d77d5…

1 0

git:master:29510872: erlang: init xavps for safety destroy on error
by Daniel-Constantin Mierla 23 Jul '24

23 Jul '24

Module: kamailio Branch: master Commit: 29510872607deb3238411b358c422d004fb307b7 URL: https://github.com/kamailio/kamailio/commit/29510872607deb3238411b358c422d0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-23T11:57:48+02:00 erlang: init xavps for safety destroy on error --- Modified: src/modules/erlang/pv_tuple.c --- Diff: https://github.com/kamailio/kamailio/commit/29510872607deb3238411b358c422d0… Patch: https://github.com/kamailio/kamailio/commit/29510872607deb3238411b358c422d0… --- diff --git a/src/modules/erlang/pv_tuple.c b/src/modules/erlang/pv_tuple.c index d25b98caea9..22fc7863dfe 100644 --- a/src/modules/erlang/pv_tuple.c +++ b/src/modules/erlang/pv_tuple.c @@ -56,8 +56,8 @@ int pv_tuple_set( sr_xavp_t *tuples_root; sr_xavp_t *tuple; sr_xavp_t *th, *new, *old, *prv = NULL; - sr_xavp_t *tuple_xavp; - sr_xavp_t *elem_xavp; + sr_xavp_t *tuple_xavp = NULL; + sr_xavp_t *elem_xavp = NULL; sr_xval_t tuple_val; pv_param_t p; pv_value_t empty;

1 0

Build failed in Jenkins: kamailiodev-nightly-binaries » amd64,bullseye #2722
by kamailio＠sipwise.com 23 Jul '24

23 Jul '24

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> Changes: ------------------------------------------ [...truncated 153.38 KiB...] rm -f TAGS tags *.dbg .*.swp rm -f rtpengine.d rtpengine.d rtpengine.d *~ rm -f TAGS tags *.dbg .*.swp rm -f rtpproxy.d rtpproxy.d rtpproxy.d *~ rm -f TAGS tags *.dbg .*.swp rm -f ruxc.d ruxc.d ruxc.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sanity.d sanity.d sanity.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sca.d sca.d sca.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sctp.d sctp.d sctp.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sdpops.d sdpops.d sdpops.d *~ rm -f TAGS tags *.dbg .*.swp rm -f seas.d seas.d seas.d *~ rm -f TAGS tags *.dbg .*.swp rm -f secfilter.d secfilter.d secfilter.d *~ rm -f TAGS tags *.dbg .*.swp rm -f secsipid.d secsipid.d secsipid.d *~ rm -f TAGS tags *.dbg .*.swp rm -f secsipid_proc.d secsipid_proc.d secsipid_proc.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sipcapture.d sipcapture.d sipcapture.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sipdump.d sipdump.d sipdump.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sipjson.d sipjson.d sipjson.d *~ rm -f TAGS tags *.dbg .*.swp rm -f siprepo.d siprepo.d siprepo.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sipt.d sipt.d sipt.d *~ rm -f TAGS tags *.dbg .*.swp rm -f siptrace.d siptrace.d siptrace.d *~ rm -f TAGS tags *.dbg .*.swp rm -f siputils.d siputils.d siputils.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sl.d sl.d sl.d *~ rm -f TAGS tags *.dbg .*.swp rm -f slack.d slack.d slack.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sms.d sms.d sms.d *~ rm -f TAGS tags *.dbg .*.swp rm -f smsops.d smsops.d smsops.d *~ rm -f TAGS tags *.dbg .*.swp rm -f snmpstats.d snmpstats.d snmpstats.d *~ rm -f TAGS tags *.dbg .*.swp rm -f speeddial.d speeddial.d speeddial.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sqlops.d sqlops.d sqlops.d *~ rm -f TAGS tags *.dbg .*.swp rm -f ss7ops.d ss7ops.d ss7ops.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sst.d sst.d sst.d *~ rm -f TAGS tags *.dbg .*.swp rm -f statistics.d statistics.d statistics.d *~ rm -f TAGS tags *.dbg .*.swp rm -f statsc.d statsc.d statsc.d *~ rm -f TAGS tags *.dbg .*.swp rm -f statsd.d statsd.d statsd.d *~ rm -f TAGS tags *.dbg .*.swp rm -f stirshaken.d stirshaken.d stirshaken.d *~ rm -f TAGS tags *.dbg .*.swp rm -f stun.d stun.d stun.d *~ rm -f TAGS tags *.dbg .*.swp rm -f sworker.d sworker.d sworker.d *~ rm -f TAGS tags *.dbg .*.swp rm -f systemdops.d systemdops.d systemdops.d *~ rm -f TAGS tags *.dbg .*.swp rm -f tcpops.d tcpops.d tcpops.d *~ rm -f TAGS tags *.dbg .*.swp rm -f textops.d textops.d textops.d *~ rm -f TAGS tags *.dbg .*.swp rm -f textopsx.d textopsx.d textopsx.d *~ rm -f TAGS tags *.dbg .*.swp rm -f timer.d timer.d timer.d *~ rm -f TAGS tags *.dbg .*.swp rm -f tls.d tls.d tls.d *~ Package wolfssl was not found in the pkg-config search path. Perhaps you should add the directory containing `wolfssl.pc' to the PKG_CONFIG_PATH environment variable No package 'wolfssl' found Makefile:65: sources = tls_cfg.c tls_config.c tls_ct_wrq.c tls_domain.c tls_init.c tls_rpc.c tls_select.c tls_server.c tls_util.c tls_verify.c tls_wolfssl_mod.c , auto_gen = , objs = tls_cfg.o tls_config.o tls_ct_wrq.o tls_domain.o tls_init.o tls_rpc.o tls_select.o tls_server.o tls_util.o tls_verify.o tls_wolfssl_mod.o rm -f TAGS tags *.dbg .*.swp rm -f tls_wolfssl.d tls_wolfssl.d tls_wolfssl.d *~ rm -f TAGS tags *.dbg .*.swp rm -f tlsa.d tlsa.d tlsa.d *~ rm -f TAGS tags *.dbg .*.swp rm -f tm.d tm.d tm.d *~ rm -f TAGS tags *.dbg .*.swp rm -f tmrec.d tmrec.d tmrec.d *~ rm -f TAGS tags *.dbg .*.swp rm -f tmx.d tmx.d tmx.d *~ rm -f TAGS tags *.dbg .*.swp rm -f topoh.d topoh.d topoh.d *~ rm -f TAGS tags *.dbg .*.swp rm -f topos.d topos.d topos.d *~ rm -f TAGS tags *.dbg .*.swp rm -f topos_redis.d topos_redis.d topos_redis.d *~ rm -f TAGS tags *.dbg .*.swp rm -f tsilo.d tsilo.d tsilo.d *~ rm -f TAGS tags *.dbg .*.swp rm -f uac.d uac.d uac.d *~ rm -f TAGS tags *.dbg .*.swp rm -f uac_redirect.d uac_redirect.d uac_redirect.d *~ rm -f TAGS tags *.dbg .*.swp rm -f uid_auth_db.d uid_auth_db.d uid_auth_db.d *~ rm -f TAGS tags *.dbg .*.swp rm -f uid_avp_db.d uid_avp_db.d uid_avp_db.d *~ rm -f TAGS tags *.dbg .*.swp rm -f uid_domain.d uid_domain.d uid_domain.d *~ rm -f TAGS tags *.dbg .*.swp rm -f uid_gflags.d uid_gflags.d uid_gflags.d *~ rm -f TAGS tags *.dbg .*.swp rm -f uid_uri_db.d uid_uri_db.d uid_uri_db.d *~ rm -f TAGS tags *.dbg .*.swp rm -f uri_db.d uri_db.d uri_db.d *~ rm -f TAGS tags *.dbg .*.swp rm -f userblocklist.d userblocklist.d userblocklist.d *~ rm -f TAGS tags *.dbg .*.swp rm -f usrloc.d usrloc.d usrloc.d *~ rm -f TAGS tags *.dbg .*.swp rm -f utils.d utils.d utils.d *~ rm -f TAGS tags *.dbg .*.swp rm -f uuid.d uuid.d uuid.d *~ rm -f TAGS tags *.dbg .*.swp rm -f websocket.d websocket.d websocket.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xcap_client.d xcap_client.d xcap_client.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xcap_server.d xcap_server.d xcap_server.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xhttp.d xhttp.d xhttp.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xhttp_pi.d xhttp_pi.d xhttp_pi.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xhttp_prom.d xhttp_prom.d xhttp_prom.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xhttp_rpc.d xhttp_rpc.d xhttp_rpc.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xlog.d xlog.d xlog.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xmlops.d xmlops.d xmlops.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xmlrpc.d xmlrpc.d xmlrpc.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xmpp.d xmpp.d xmpp.d *~ rm -f TAGS tags *.dbg .*.swp rm -f xprint.d xprint.d xprint.d *~ make[2]: Leaving directory '/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745/src' make[1]: Leaving directory '/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745' dh_clean dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use) dpkg-source -b . dpkg-source: info: using source format '3.0 (native)' dpkg-source: info: building kamailio in kamailio_6.0.0~dev2+bpo11.20240720005440.2745.tar.xz dpkg-source: info: building kamailio in kamailio_6.0.0~dev2+bpo11.20240720005440.2745.dsc debian/rules binary dh_testdir # Add here commands to configure the package. /usr/bin/make FLAVOUR=kamailio cfg prefix=/usr cfg_prefix=/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745/debian/kamailio \ cfg_target=/etc/kamailio/ \ BASEDIR=/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745/debian/kamailio \ skip_modules=" bdb dbtext oracle pa iptrtpproxy dnssec java nats tls_wolfssl" \ CC_EXTRA_OPTS="-Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745=. -fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE" \ LD_EXTRA_OPTS="-Wl,-z,relro" \ group_include="kstandard" quiet=verbose make[1]: Entering directory '/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745' /usr/bin/make -C src/ cfg make[2]: Entering directory '/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745/src' normal Makefile.defs exec target architecture <x86_64>, host architecture <x86_64> rm -f modules.lst making config... /usr/bin/make --no-print-directory modules.lst config.mak loaded Makefile.defs defs skipped /usr/bin/make --no-print-directory -wC . cfg-defs normal Makefile.defs exec target architecture <x86_64>, host architecture <x86_64> make[4]: Nothing to be done for 'cfg-defs'. config.mak loaded Makefile.defs defs skipped saving modules list... make[2]: Leaving directory '/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745/src' make[1]: Leaving directory '/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745' touch configure-stamp dh_testdir /usr/bin/make all quiet=verbose make[1]: Entering directory '/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745' /usr/bin/make -C src/ all make[2]: Entering directory '/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745/src' config.mak loaded Makefile:116: *** "bad config.mak, try re-running make cfg". Stop. make[2]: Leaving directory '/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745/src' make[1]: *** [Makefile:34: all] Error 2 make[1]: Leaving directory '/build/kamailio-6.0.0~dev2+bpo11.20240720005440.2745' make: *** [debian/rules:130: test_build_all] Error 2 dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 I: copying local configuration E: Failed autobuilding of package I: user script /var/cache/pbuilder/build/cow.16366/tmp/hooks/C10shell starting ┌──────────────────────────────────────────────────────────────────────────────┐ │ FTBFS - problem with building Debian package │ └──────────────────────────────────────────────────────────────────────────────┘ ┌──────────────────────────────────────────────────────────────────────────────┐ │ DEB_KEEP_BUILD_ENV is not set to 'true', not keeping build environment │ └──────────────────────────────────────────────────────────────────────────────┘ I: user script /var/cache/pbuilder/build/cow.16366/tmp/hooks/C10shell finished I: unmounting /tmp/apt-jdg_kJGwZY filesystem I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: Cleaning COW directory I: forking: rm -rf /var/cache/pbuilder/build/cow.16366 + '[' 1 -eq 0 ']' + bailout 1 'Error: Failed to build with cowbuilder.' + '[' -n 1 ']' + EXIT=1 + '[' -n 'Error: Failed to build with cowbuilder.' ']' + echo 'Error: Failed to build with cowbuilder.' Error: Failed to build with cowbuilder. + rm -f /run/lock/bullseye-amd64.building.16033 + '[' -r /run/lock/bullseye-amd64.update.16033 ']' + '[' '' = true ']' + echo '*** Getting rid of files in <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> to avoid problems in next run. ***' *** Getting rid of files in <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> to avoid problems in next run. *** + rm -f '<https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…'> + '[' -n /tmp/tmp.gTX97Iau9L ']' + rm -rf /tmp/tmp.gTX97Iau9L + '[' -n /tmp/apt-jdg_kJGwZY ']' + sudo rm -rf /tmp/apt-jdg_kJGwZY + '[' -n 292 ']' ++ sed -e 's/^$[0-9]*$.*/\1/' + SECONDS=102 ++ date + echo '*** Finished execution of /usr/bin/build-and-provide-package at Sat Jul 20 01:04:44 UTC 2024 [running 102 seconds] ***' *** Finished execution of /usr/bin/build-and-provide-package at Sat Jul 20 01:04:44 UTC 2024 [running 102 seconds] *** + exit 1 Build step 'Execute shell' marked build as failure Archiving artifacts Recording fingerprints TAP Reports Processing: START Looking for TAP results report in workspace using pattern: report/*.tap Did not find any matching files. Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

1 1

[kamailio/kamailio] nghttp2 module causing Kamailio P-CSCF to crash on connect (Issue #3917)
by NUCLEAR-WAR 22 Jul '24

22 Jul '24

### Description I am doing some experiments with NGHTTP2 Module to make use of it in some scenarios, where Kamailio receives HTTP2 requests and has t react on them, unfortunately the module is causing Kamailio to crash upon receiving a request and need to be restarted. Also the Docs for the module need some correction : https://www.kamailio.org/docs/modules/5.9.x/modules/nghttp2.html Missing required Parameters : modparam("nghttp2", "tls_private_key", "key_in_PEM_Format") modparam("nghttp2", "tls_public_key", "certificate_in_PEM_Format") also $nghttp2(url) is wrong, $nghttp2(path) or $nghttp2(pathfull) is the correct ones. its also annoying to have it only working in TLS, would it possible to make it also works without TLS ? #### Reproduction the fastest way it to connect to NGHTTP2 server with curl : curl --http2-prior-knowledge -v -k https://server_ip:port/ #### Debugging Data ``` 92(132) DEBUG: nghttp2 [nghttp2_server.c:717]: eventcb(): 172.22.0.1 connected 92(132) DEBUG: nghttp2 [nghttp2_server.c:507]: on_request_recv(): 172.22.0.1 GET / 92(132) DEBUG: nghttp2 [nghttp2_mod.c:522]: ksr_event_route(): executing event_route[nghttp2:request] (1) free(): invalid pointer 102(142) CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 7 102(142) DEBUG: <core> [core/tcp_main.c:3984]: handle_ser_child(): dead child 92, pid 132 (shutting down?) 102(142) DEBUG: <core> [core/io_wait.h:599]: io_watch_del(): DBG: io_watch_del (0x5b85ddc10ae0, 7, -1, 0x0) fd_no=130 called 0(40) ALERT: <core> [main.c:806]: handle_sigs(): child process 132 exited by a signal 6 0(40) ALERT: <core> [main.c:810]: handle_sigs(): core was generated ``` #### Log Messages  ``` https://pastebin.com/MQe4F5sv ``` ### Additional Information * **Kamailio Version** 5.8 * **Operating System**: Ubuntu 24.04 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3917 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3917(a)github.com>

3 14

git:master:7350a80a: nghttp2: duplicate reply status code in nghttp2_send_reply()
by Daniel-Constantin Mierla 22 Jul '24

22 Jul '24

Module: kamailio Branch: master Commit: 7350a80a1d4d121a75e12529553191c4a9038f56 URL: https://github.com/kamailio/kamailio/commit/7350a80a1d4d121a75e12529553191c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-22T14:44:42+02:00 nghttp2: duplicate reply status code in nghttp2_send_reply() - expected to be freed later - GH #3917 --- Modified: src/modules/nghttp2/nghttp2_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/7350a80a1d4d121a75e12529553191c… Patch: https://github.com/kamailio/kamailio/commit/7350a80a1d4d121a75e12529553191c… --- diff --git a/src/modules/nghttp2/nghttp2_mod.c b/src/modules/nghttp2/nghttp2_mod.c index a6b63b56e84..28b80544107 100644 --- a/src/modules/nghttp2/nghttp2_mod.c +++ b/src/modules/nghttp2/nghttp2_mod.c @@ -299,8 +299,14 @@ static int ksr_nghttp2_send_reply(sip_msg_t *msg, str *rcode, str *sbody) int rv; ssize_t writelen; int pipefd[2]; + char *p; - _ksr_nghttp2_ctx.rplhdrs_v[0].value = (uint8_t *)rcode->s; + p = strndup(rcode->s, rcode->len); + if(p == NULL) { + SYS_MEM_ERROR; + return -1; + } + _ksr_nghttp2_ctx.rplhdrs_v[0].value = (uint8_t *)p; _ksr_nghttp2_ctx.rplhdrs_v[0].valuelen = rcode->len; if(_ksr_nghttp2_ctx.rplhdrs_n == 0) {

1 0

[kamailio/kamailio] Warnings emitted when calling functions from dialplan module (Issue #3851)
by Ben Kaufman 22 Jul '24

22 Jul '24

### Description Calling functions from the `dialplan` module in 5.8 (`dp_translate()`, `dp_match()`) results in the following line being logged: ``` WARNING: <core> [core/mem/q_malloc.c:520]: qm_free(): WARNING: free(0) called from dialplan: dp_db.c: pcre2_free(206) ``` Is this a functional problem, or just a case of overly aggressive logging? ### Troubleshooting #### Reproduction Reproducible with the following kamailio config: ``` #!KAMAILIO loadmodule "pv" loadmodule "db_sqlite" loadmodule "xlog" loadmodule "dialplan" disable_tcp = true force_rport = true !!define DBFILE /etc/kamailio/kamailio.sqlite modparamx("db_sqlite","db_set_readonly", "$def(DBFILE)") modparamx("dialplan","db_url", "sqlite:///$def(DBFILE)") modparam("dialplan", "attrs_pvar", "$avp(dp_attrs)") request_route { if ( $rm == "ACK" ) { exit; } xinfo("$ci New request\n"); dp_match("1", "$rU"); exit; } ``` The warning log is issued in 5.8 but not 5.7. Reproduced by sending a request with SIPp: ``` sipp -sn uac -m 1 -s 15554445555 localhost ``` ### Possible Solutions Not sure if this is just a case of logging being overly aggressive, or an issue with the module's memory management. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.1 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` Tested using docker `debian:12-slim` using the official packages from `http://deb.kamailio.org/kamailio58` * **Operating System**: Docker debian:12-slim, but also observed in Alpine Linux/ -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3851 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3851(a)github.com>

6 13

git:master:34749ab1: utils: jump to error on pkg allocation failure
by Daniel-Constantin Mierla 22 Jul '24

22 Jul '24

Module: kamailio Branch: master Commit: 34749ab13b31504358761c964f794b283931394c URL: https://github.com/kamailio/kamailio/commit/34749ab13b31504358761c964f794b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-22T11:01:16+02:00 utils: jump to error on pkg allocation failure --- Modified: src/modules/utils/xcap_auth.c --- Diff: https://github.com/kamailio/kamailio/commit/34749ab13b31504358761c964f794b2… Patch: https://github.com/kamailio/kamailio/commit/34749ab13b31504358761c964f794b2… --- diff --git a/src/modules/utils/xcap_auth.c b/src/modules/utils/xcap_auth.c index 3824b2d484a..5c986a18cd3 100644 --- a/src/modules/utils/xcap_auth.c +++ b/src/modules/utils/xcap_auth.c @@ -418,11 +418,13 @@ int get_rules_doc(str *user, str *domain, int type, str **rules_doc) doc = (str *)pkg_malloc(sizeof(str)); if(doc == NULL) { PKG_MEM_ERROR; + goto error; } doc->s = (char *)pkg_malloc(body.len * sizeof(char)); if(doc->s == NULL) { pkg_free(doc); PKG_MEM_ERROR; + goto error; } memcpy(doc->s, body.s, body.len); doc->len = body.len; @@ -514,4 +516,4 @@ int w_xcap_auth_status(struct sip_msg *_msg, char *_sp1, char *_sp2) } return ki_xcap_auth_status(_msg, &watcher_uri, &presentity_uri); -} \ No newline at end of file +}

1 0

git:master:79a668b8: tls: check lenght when parsing pv alt name
by Daniel-Constantin Mierla 22 Jul '24

22 Jul '24

Module: kamailio Branch: master Commit: 79a668b8bdb0e085adb3581d718e5fd5ae73e2e4 URL: https://github.com/kamailio/kamailio/commit/79a668b8bdb0e085adb3581d718e5fd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-22T10:41:47+02:00 tls: check lenght when parsing pv alt name --- Modified: src/modules/tls/tls_select.c --- Diff: https://github.com/kamailio/kamailio/commit/79a668b8bdb0e085adb3581d718e5fd… Patch: https://github.com/kamailio/kamailio/commit/79a668b8bdb0e085adb3581d718e5fd… --- diff --git a/src/modules/tls/tls_select.c b/src/modules/tls/tls_select.c index c788eabcd63..8b1a0457c0a 100644 --- a/src/modules/tls/tls_select.c +++ b/src/modules/tls/tls_select.c @@ -1190,13 +1190,13 @@ int pv_parse_alt_name(pv_spec_p sp, str *in) if(in->s == NULL || in->len <= 0) return -1; - if(strncmp(in->s, "DNS", 3) == 0) { + if(in->len == 3 && strncmp(in->s, "DNS", 3) == 0) { sp->pvp.pvn.u.isname.name.n = PV_COMP_HOST; - } else if(strncmp(in->s, "URI", 3) == 0) { + } else if(in->len == 3 && strncmp(in->s, "URI", 3) == 0) { sp->pvp.pvn.u.isname.name.n = PV_COMP_URI; - } else if(strncmp(in->s, "EMAIL", 5) == 0) { + } else if(in->len == 5 && strncmp(in->s, "EMAIL", 5) == 0) { sp->pvp.pvn.u.isname.name.n = PV_COMP_E; - } else if(strncmp(in->s, "IP", 2) == 0) { + } else if(in->len == 2 && strncmp(in->s, "IP", 2) == 0) { sp->pvp.pvn.u.isname.name.n = PV_COMP_IP; } else { LM_ERR("Unsupported alt name %s\n", in->s);

1 0

git:master:7c06997a: tls: remove uselss pv format parsing in pv_parse_alt_name()
by Daniel-Constantin Mierla 22 Jul '24

22 Jul '24

Module: kamailio Branch: master Commit: 7c06997a1b6e77ae0642d369f532219dc35ef8e0 URL: https://github.com/kamailio/kamailio/commit/7c06997a1b6e77ae0642d369f532219… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-22T10:23:31+02:00 tls: remove uselss pv format parsing in pv_parse_alt_name() --- Modified: src/modules/tls/tls_select.c --- Diff: https://github.com/kamailio/kamailio/commit/7c06997a1b6e77ae0642d369f532219… Patch: https://github.com/kamailio/kamailio/commit/7c06997a1b6e77ae0642d369f532219… --- diff --git a/src/modules/tls/tls_select.c b/src/modules/tls/tls_select.c index c7eb96bd9fa..c788eabcd63 100644 --- a/src/modules/tls/tls_select.c +++ b/src/modules/tls/tls_select.c @@ -1187,14 +1187,9 @@ static int pv_comp(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) int pv_parse_alt_name(pv_spec_p sp, str *in) { - pv_elem_t *fmt = NULL; - if(in->s == NULL || in->len <= 0) return -1; - if(pv_parse_format(in, &fmt) < 0 || fmt == NULL) { - LM_ERR("wrong format[%.*s]\n", in->len, in->s); - return -1; - } + if(strncmp(in->s, "DNS", 3) == 0) { sp->pvp.pvn.u.isname.name.n = PV_COMP_HOST; } else if(strncmp(in->s, "URI", 3) == 0) {

1 0

git:master:5a1f80f2: xprint: check to avoid double free
by Daniel-Constantin Mierla 22 Jul '24

22 Jul '24

Module: kamailio Branch: master Commit: 5a1f80f266069dbc453b44a856f225c254e7c050 URL: https://github.com/kamailio/kamailio/commit/5a1f80f266069dbc453b44a856f225c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-22T10:02:09+02:00 xprint: check to avoid double free --- Modified: src/modules/xprint/xp_lib.c --- Diff: https://github.com/kamailio/kamailio/commit/5a1f80f266069dbc453b44a856f225c… Patch: https://github.com/kamailio/kamailio/commit/5a1f80f266069dbc453b44a856f225c… --- diff --git a/src/modules/xprint/xp_lib.c b/src/modules/xprint/xp_lib.c index e4442ba87f4..b6fc5066556 100644 --- a/src/modules/xprint/xp_lib.c +++ b/src/modules/xprint/xp_lib.c @@ -1896,6 +1896,7 @@ int xl_mod_init() str_ipaddr.s[str_ipaddr.len] = '\0'; } else { pkg_free(s); + s = NULL; str_ipaddr.len = 0; PKG_MEM_ERROR_FMT("for str_ipaddr\n"); } @@ -1914,7 +1915,8 @@ int xl_mod_init() } } } - pkg_free(s); + if(s != NULL) + pkg_free(s); DBG("Hostname: %.*s\n", str_hostname.len, ZSW(str_hostname.s)); DBG("Domainname: %.*s\n", str_domainname.len, ZSW(str_domainname.s));

1 0

git:master:dc71c0a5: topoh: 0-init alocated structures
by Daniel-Constantin Mierla 19 Jul '24

19 Jul '24

Module: kamailio Branch: master Commit: dc71c0a5791ebc1306648b5ed338613050e32f5c URL: https://github.com/kamailio/kamailio/commit/dc71c0a5791ebc1306648b5ed338613… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-19T20:00:12+02:00 topoh: 0-init alocated structures --- Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/dc71c0a5791ebc1306648b5ed338613… Patch: https://github.com/kamailio/kamailio/commit/dc71c0a5791ebc1306648b5ed338613… --- diff --git a/src/modules/topoh/topoh_mod.c b/src/modules/topoh/topoh_mod.c index fe63bf88c7f..7dffa829504 100644 --- a/src/modules/topoh/topoh_mod.c +++ b/src/modules/topoh/topoh_mod.c @@ -321,12 +321,12 @@ int th_build_socket_strings(socket_info_t *socket) != 0) return 0; - socket_strings = pkg_malloc(sizeof(struct th_socket_strings)); + socket_strings = pkg_mallocxz(sizeof(struct th_socket_strings)); if(socket_strings == NULL) { PKG_MEM_ERROR_FMT("socket_strings\n"); goto error; } - table_entry = pkg_malloc(sizeof(struct str_hash_entry)); + table_entry = pkg_mallocxz(sizeof(struct str_hash_entry)); if(table_entry == NULL) { PKG_MEM_ERROR_FMT("table_entry\n"); goto error;

1 0

git:master:20f2096d: core: removed unnecessary destroy
by Daniel-Constantin Mierla 19 Jul '24

19 Jul '24

Module: kamailio Branch: master Commit: 20f2096d314253e7e74688da664de2830289a276 URL: https://github.com/kamailio/kamailio/commit/20f2096d314253e7e74688da664de28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-19T20:00:12+02:00 core: removed unnecessary destroy --- Modified: src/core/rvalue.c --- Diff: https://github.com/kamailio/kamailio/commit/20f2096d314253e7e74688da664de28… Patch: https://github.com/kamailio/kamailio/commit/20f2096d314253e7e74688da664de28… --- diff --git a/src/core/rvalue.c b/src/core/rvalue.c index 9cc1812c294..4c0137060ad 100644 --- a/src/core/rvalue.c +++ b/src/core/rvalue.c @@ -1085,8 +1085,6 @@ long rval_get_long(struct run_act_ctx *h, struct sip_msg *msg, long *i, LM_BUG("invalid cached value:cache type %d, value type %d\n", cache ? cache->cache_type : 0, cache ? cache->val_type : 0); error: - if(destroy_pval) - pv_value_destroy(&pval); *i = 0; return -1; }

1 0

git:5.7:2deec6b4: sipcapture: add missing headers for inet_ntop()
by Victor Seva 18 Jul '24

18 Jul '24

Module: kamailio Branch: 5.7 Commit: 2deec6b43b8149ebb8c027a68709c2a708f01be9 URL: https://github.com/kamailio/kamailio/commit/2deec6b43b8149ebb8c027a68709c2a… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T17:36:34+02:00 sipcapture: add missing headers for inet_ntop() fixes #3927 (cherry picked from commit fe505c9654541ec60f14e5a50896bb11751e61e4) (cherry picked from commit 164d1ecca7e94beba24013f31276bdc1f2ee04a1) --- Modified: src/modules/sipcapture/hep.c --- Diff: https://github.com/kamailio/kamailio/commit/2deec6b43b8149ebb8c027a68709c2a… Patch: https://github.com/kamailio/kamailio/commit/2deec6b43b8149ebb8c027a68709c2a… --- diff --git a/src/modules/sipcapture/hep.c b/src/modules/sipcapture/hep.c index db7ea912e11..3485f330a45 100644 --- a/src/modules/sipcapture/hep.c +++ b/src/modules/sipcapture/hep.c @@ -21,6 +21,8 @@ * */ +#include <arpa/inet.h> + #include "../../core/sr_module.h" #include "../../core/dprint.h" #include "../../core/events.h"

1 0

git:5.8:164d1ecc: sipcapture: add missing headers for inet_ntop()
by Victor Seva 18 Jul '24

18 Jul '24

Module: kamailio Branch: 5.8 Commit: 164d1ecca7e94beba24013f31276bdc1f2ee04a1 URL: https://github.com/kamailio/kamailio/commit/164d1ecca7e94beba24013f31276bdc… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T17:35:29+02:00 sipcapture: add missing headers for inet_ntop() fixes #3927 (cherry picked from commit fe505c9654541ec60f14e5a50896bb11751e61e4) --- Modified: src/modules/sipcapture/hep.c --- Diff: https://github.com/kamailio/kamailio/commit/164d1ecca7e94beba24013f31276bdc… Patch: https://github.com/kamailio/kamailio/commit/164d1ecca7e94beba24013f31276bdc… --- diff --git a/src/modules/sipcapture/hep.c b/src/modules/sipcapture/hep.c index db7ea912e11..3485f330a45 100644 --- a/src/modules/sipcapture/hep.c +++ b/src/modules/sipcapture/hep.c @@ -21,6 +21,8 @@ * */ +#include <arpa/inet.h> + #include "../../core/sr_module.h" #include "../../core/dprint.h" #include "../../core/events.h"

1 0

[kamailio/kamailio] hep.c:985:41: error: implicit declaration of function ‘inet_ntop’ (Issue #3927)
by Victor Seva 18 Jul '24

18 Jul '24

From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1075961 ``` kamailio currently FTBFS on s390x, but built there before. The same problem can be observed on ppc64: https://buildd.debian.org/status/fetch.php?pkg=kamailio&arch=s390x&ver=5.8.… hep.c: In function ‘hepv3_get_chunk’: hep.c:985:41: error: implicit declaration of function ‘inet_ntop’ [-Werror=implicit-function-declaration] 985 | inet_ntop(AF_INET, &(hg->hep_src_ip4->data), ipstr, | ^~~~~~~~~ gcc -fPIC -DPIC -pthread -DKSR_PTHREAD_MUTEX_SHARED -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE -DNAME='"kamailio"' -DVERSION='"5.8.2"' -DARCH='"s390x"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 13.3.0"' -D__CPU_s390x -D__OS_linux -DVERSIONVAL=5008002 -DCFG_DIR='"/etc/kamailio/"' -DSHARE_DIR='"/usr/share/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DUSE_PTHREAD_MUTEX -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKAROUND -DUSE_FUTEX -DHAVE_SELECT -DMOD_NAME='"sipcapture"' -DMOD_NAMEID='sipcapture' -c sipcapture.c -o sipcapture.o -MMD -MP In file included from ../../core/atomic_ops.h:180, from ../../core/locking.h:72, from ../../core/rpc.h:34, from ../../core/sr_module.h:36, from sipcapture.c:54: ... make[4]: *** [../../Makefile.rules:100: hep.o] Error 1 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3927 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3927(a)github.com>

1 1

git:master:fe505c96: sipcapture: add missing headers for inet_ntop()
by Victor Seva 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: fe505c9654541ec60f14e5a50896bb11751e61e4 URL: https://github.com/kamailio/kamailio/commit/fe505c9654541ec60f14e5a50896bb1… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T17:30:52+02:00 sipcapture: add missing headers for inet_ntop() fixes #3927 --- Modified: src/modules/sipcapture/hep.c --- Diff: https://github.com/kamailio/kamailio/commit/fe505c9654541ec60f14e5a50896bb1… Patch: https://github.com/kamailio/kamailio/commit/fe505c9654541ec60f14e5a50896bb1… --- diff --git a/src/modules/sipcapture/hep.c b/src/modules/sipcapture/hep.c index db7ea912e11..3485f330a45 100644 --- a/src/modules/sipcapture/hep.c +++ b/src/modules/sipcapture/hep.c @@ -21,6 +21,8 @@ * */ +#include <arpa/inet.h> + #include "../../core/sr_module.h" #include "../../core/dprint.h" #include "../../core/events.h"

1 0

git:master:b6de4b92: modules: readme files regenerated - sqlops ... [skip ci]
by Kamailio Dev 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: b6de4b92fd18d541c745e07cfaefaf7c56c45f18 URL: https://github.com/kamailio/kamailio/commit/b6de4b92fd18d541c745e07cfaefaf7… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-18T15:46:10+02:00 modules: readme files regenerated - sqlops ... [skip ci] --- Modified: src/modules/sqlops/README --- Diff: https://github.com/kamailio/kamailio/commit/b6de4b92fd18d541c745e07cfaefaf7… Patch: https://github.com/kamailio/kamailio/commit/b6de4b92fd18d541c745e07cfaefaf7…

1 0

[kamailio/kamailio] sqlops: Don't truncated sql command when logging. (PR #3903)
by Xenofon Karamanos 18 Jul '24

18 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR Fixes a bug where logging shows a truncated command instead of the original one. Original query in .cfg: `sql_query("ca", "UPDATE dialog SET timeout = timeout + 1 WHERE callid = '$ci' AND timeout > 0;` logged error before fix: sql_do_query(): cannot do the query [UPDATE dialog SET timeout = timeout + 1 WHERE callid = 'al@there] logged error after fix: sql_do_query(): cannot do the query [UPDATE dialog SET timeout = timeout + 1 WHERE callid = 'al(a)there.com AND timeout > 0;] You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3903 -- Commit Summary -- * sqlops: Don't truncated sql command when logging. -- File Changes -- M src/modules/sqlops/sql_api.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3903.patch https://github.com/kamailio/kamailio/pull/3903.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3903 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3903(a)github.com>

2 6

git:master:e5407c05: sqlops: Add log_buf_size param for logging raw queries.
by Xenofon Karamanos 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: e5407c058f88fe06be2ee5da468ce2929748e31f URL: https://github.com/kamailio/kamailio/commit/e5407c058f88fe06be2ee5da468ce29… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-07-18T16:37:15+03:00 sqlops: Add log_buf_size param for logging raw queries. --- Modified: src/modules/sqlops/doc/sqlops_admin.xml Modified: src/modules/sqlops/sql_api.c Modified: src/modules/sqlops/sqlops.c --- Diff: https://github.com/kamailio/kamailio/commit/e5407c058f88fe06be2ee5da468ce29… Patch: https://github.com/kamailio/kamailio/commit/e5407c058f88fe06be2ee5da468ce29… --- diff --git a/src/modules/sqlops/doc/sqlops_admin.xml b/src/modules/sqlops/doc/sqlops_admin.xml index aeaa54ef0ff..c26c63ebcd4 100644 --- a/src/modules/sqlops/doc/sqlops_admin.xml +++ b/src/modules/sqlops/doc/sqlops_admin.xml @@ -191,6 +191,28 @@ modparam("sqlops", "sqlres", "ra") ... modparam("sqlops", "tr_buf_size", 4096) ... +</programlisting> + </example> + </section> + <section id="sqlops.p.log_buf_size"> + <title><varname>log_buf_size</varname> (int)</title> + <para> + The size of the buffer (characters) when logging raw SQL operations. + </para> + <para> + Note: When the buffer is smaller than the SQL operation, the operation is logged truncated up to log_buf_size. + </para> + <para> + <emphasis> + Default value is 128. + </emphasis> + </para> + <example> + <title>Set <varname>log_buf_size</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("sqlops", "log_buf_size", 4096) +... </programlisting> </example> </section> @@ -607,4 +629,3 @@ xlog("Affected rows: $sqlrows(ca)\n"); </section> </section> </chapter> - diff --git a/src/modules/sqlops/sql_api.c b/src/modules/sqlops/sql_api.c index b76edbd480e..255121dd87d 100644 --- a/src/modules/sqlops/sql_api.c +++ b/src/modules/sqlops/sql_api.c @@ -36,6 +36,7 @@ #include "sql_api.h" extern int sqlops_results_maxsize; +extern int sqlops_log_buf_size; sql_con_t *_sql_con_root = NULL; sql_result_t *_sql_result_root = NULL; @@ -276,7 +277,9 @@ int sql_do_query(sql_con_t *con, str *query, sql_result_t *res) } if(con->dbf.raw_query(con->dbh, query, &db_res) != 0) { LM_ERR("cannot do the query [%.*s]\n", - (query->len > 64) ? 64 : query->len, query->s); + (query->len > sqlops_log_buf_size) ? sqlops_log_buf_size + : query->len, + query->s); return -1; } diff --git a/src/modules/sqlops/sqlops.c b/src/modules/sqlops/sqlops.c index 1b0859b1ca5..900dcacb371 100644 --- a/src/modules/sqlops/sqlops.c +++ b/src/modules/sqlops/sqlops.c @@ -77,6 +77,7 @@ static int sql_res_param(modparam_t type, void *val); extern int sqlops_tr_buf_size; int sqlops_results_maxsize = 32; +int sqlops_log_buf_size = 128; static int sqlops_connect_mode = 0; @@ -106,6 +107,7 @@ static param_export_t params[] = { {"sqlcon", PARAM_STRING | USE_FUNC_PARAM, (void *)sql_con_param}, {"sqlres", PARAM_STRING | USE_FUNC_PARAM, (void *)sql_res_param}, {"tr_buf_size", PARAM_INT, &sqlops_tr_buf_size}, + {"log_buf_size", PARAM_INT, &sqlops_log_buf_size}, {"connect_mode", PARAM_INT, &sqlops_connect_mode}, {"results_maxsize", PARAM_INT, &sqlops_results_maxsize}, {0, 0, 0}};

1 0

git:5.8:685f45c4: dialplan: remove pcre2_free() warning
by Victor Seva 18 Jul '24

18 Jul '24

Module: kamailio Branch: 5.8 Commit: 685f45c4adf911ac41c14b55ad36dd4b8b51897c URL: https://github.com/kamailio/kamailio/commit/685f45c4adf911ac41c14b55ad36dd4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T13:42:31+02:00 dialplan: remove pcre2_free() warning related to #3851 (cherry picked from commit 70563ca0629a8de5aa5427b003f441e6c3a40c6a) --- Modified: src/modules/dialplan/dp_db.c --- Diff: https://github.com/kamailio/kamailio/commit/685f45c4adf911ac41c14b55ad36dd4… Patch: https://github.com/kamailio/kamailio/commit/685f45c4adf911ac41c14b55ad36dd4… --- diff --git a/src/modules/dialplan/dp_db.c b/src/modules/dialplan/dp_db.c index 857a2e43e75..64d2a4f3b12 100644 --- a/src/modules/dialplan/dp_db.c +++ b/src/modules/dialplan/dp_db.c @@ -203,8 +203,10 @@ static void *pcre2_malloc(size_t size, void *ext) static void pcre2_free(void *ptr, void *ext) { - shm_free(ptr); - ptr = NULL; + if(ptr) { + shm_free(ptr); + ptr = NULL; + } } int init_data(void)

1 0

git:5.8:64a01ebe: lcr: remove pcre2_free() warning
by Victor Seva 18 Jul '24

18 Jul '24

Module: kamailio Branch: 5.8 Commit: 64a01ebec255ece59be3683bab421b35505d745d URL: https://github.com/kamailio/kamailio/commit/64a01ebec255ece59be3683bab421b3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T13:42:31+02:00 lcr: remove pcre2_free() warning related to #3851 (cherry picked from commit 310b631007082f553117d126b6b9bd915be596ac) --- Modified: src/modules/lcr/lcr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/64a01ebec255ece59be3683bab421b3… Patch: https://github.com/kamailio/kamailio/commit/64a01ebec255ece59be3683bab421b3… --- diff --git a/src/modules/lcr/lcr_mod.c b/src/modules/lcr/lcr_mod.c index dac215a9eb5..bbd397d5186 100644 --- a/src/modules/lcr/lcr_mod.c +++ b/src/modules/lcr/lcr_mod.c @@ -433,8 +433,10 @@ static void *pcre2_malloc(size_t size, void *ext) static void pcre2_free(void *ptr, void *ext) { - shm_free(ptr); - ptr = NULL; + if(ptr) { + shm_free(ptr); + ptr = NULL; + } } /*

1 0

git:5.8:1946e35c: regex: remove pcre2_free() warning
by Victor Seva 18 Jul '24

18 Jul '24

Module: kamailio Branch: 5.8 Commit: 1946e35c4d144fba3067d3fee5d1bd030dc4a609 URL: https://github.com/kamailio/kamailio/commit/1946e35c4d144fba3067d3fee5d1bd0… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T13:42:31+02:00 regex: remove pcre2_free() warning related to #3851 (cherry picked from commit b86030cfbd66ba95f33f312595edae29e2b5cde0) --- Modified: src/modules/regex/regex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1946e35c4d144fba3067d3fee5d1bd0… Patch: https://github.com/kamailio/kamailio/commit/1946e35c4d144fba3067d3fee5d1bd0… --- diff --git a/src/modules/regex/regex_mod.c b/src/modules/regex/regex_mod.c index 52ed60b295c..f4e93e48a3e 100644 --- a/src/modules/regex/regex_mod.c +++ b/src/modules/regex/regex_mod.c @@ -170,8 +170,10 @@ static void *pcre2_malloc(size_t size, void *ext) static void pcre2_free(void *ptr, void *ext) { - shm_free(ptr); - ptr = NULL; + if(ptr) { + shm_free(ptr); + ptr = NULL; + } } /*! \brief

1 0

git:master:70563ca0: dialplan: remove pcre2_free() warning
by Victor Seva 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: 70563ca0629a8de5aa5427b003f441e6c3a40c6a URL: https://github.com/kamailio/kamailio/commit/70563ca0629a8de5aa5427b003f441e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T13:41:16+02:00 dialplan: remove pcre2_free() warning related to #3851 --- Modified: src/modules/dialplan/dp_db.c --- Diff: https://github.com/kamailio/kamailio/commit/70563ca0629a8de5aa5427b003f441e… Patch: https://github.com/kamailio/kamailio/commit/70563ca0629a8de5aa5427b003f441e… --- diff --git a/src/modules/dialplan/dp_db.c b/src/modules/dialplan/dp_db.c index 857a2e43e75..64d2a4f3b12 100644 --- a/src/modules/dialplan/dp_db.c +++ b/src/modules/dialplan/dp_db.c @@ -203,8 +203,10 @@ static void *pcre2_malloc(size_t size, void *ext) static void pcre2_free(void *ptr, void *ext) { - shm_free(ptr); - ptr = NULL; + if(ptr) { + shm_free(ptr); + ptr = NULL; + } } int init_data(void)

1 0

git:master:310b6310: lcr: remove pcre2_free() warning
by Victor Seva 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: 310b631007082f553117d126b6b9bd915be596ac URL: https://github.com/kamailio/kamailio/commit/310b631007082f553117d126b6b9bd9… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T13:41:15+02:00 lcr: remove pcre2_free() warning related to #3851 --- Modified: src/modules/lcr/lcr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/310b631007082f553117d126b6b9bd9… Patch: https://github.com/kamailio/kamailio/commit/310b631007082f553117d126b6b9bd9… --- diff --git a/src/modules/lcr/lcr_mod.c b/src/modules/lcr/lcr_mod.c index 6cad2830fb6..f53de3b3668 100644 --- a/src/modules/lcr/lcr_mod.c +++ b/src/modules/lcr/lcr_mod.c @@ -433,8 +433,10 @@ static void *pcre2_malloc(size_t size, void *ext) static void pcre2_free(void *ptr, void *ext) { - shm_free(ptr); - ptr = NULL; + if(ptr) { + shm_free(ptr); + ptr = NULL; + } } /*

1 0

git:master:b86030cf: regex: remove pcre2_free() warning
by Victor Seva 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: b86030cfbd66ba95f33f312595edae29e2b5cde0 URL: https://github.com/kamailio/kamailio/commit/b86030cfbd66ba95f33f312595edae2… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T13:41:15+02:00 regex: remove pcre2_free() warning related to #3851 --- Modified: src/modules/regex/regex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b86030cfbd66ba95f33f312595edae2… Patch: https://github.com/kamailio/kamailio/commit/b86030cfbd66ba95f33f312595edae2… --- diff --git a/src/modules/regex/regex_mod.c b/src/modules/regex/regex_mod.c index 52ed60b295c..f4e93e48a3e 100644 --- a/src/modules/regex/regex_mod.c +++ b/src/modules/regex/regex_mod.c @@ -170,8 +170,10 @@ static void *pcre2_malloc(size_t size, void *ext) static void pcre2_free(void *ptr, void *ext) { - shm_free(ptr); - ptr = NULL; + if(ptr) { + shm_free(ptr); + ptr = NULL; + } } /*! \brief

1 0

[kamailio/kamailio] tcpops: fix memory leak in $tcp(conid) (PR #3924)
by Dennis 18 Jul '24

18 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Reference counter to tcp session not decremented after use $tcp(conid), so shm for session never free. Can be releated to: https://www.mail-archive.com/sr-users@lists.kamailio.org/msg21294.html You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3924 -- Commit Summary -- * tcpops: fix memory leak in $tcp(conid) -- File Changes -- M src/modules/tcpops/tcpops_mod.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3924.patch https://github.com/kamailio/kamailio/pull/3924.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3924 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3924(a)github.com>

2 2

git:master:acf50d86: tcpops: fix memory leak in $tcp(conid)
by Daniel-Constantin Mierla 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: acf50d86b502af36e3635d61745feaa5c577231d URL: https://github.com/kamailio/kamailio/commit/acf50d86b502af36e3635d61745feaa… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-18T13:31:26+02:00 tcpops: fix memory leak in $tcp(conid) - reference counter to tcp session not decremented, so shm for session never free --- Modified: src/modules/tcpops/tcpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/acf50d86b502af36e3635d61745feaa… Patch: https://github.com/kamailio/kamailio/commit/acf50d86b502af36e3635d61745feaa… --- diff --git a/src/modules/tcpops/tcpops_mod.c b/src/modules/tcpops/tcpops_mod.c index 6b648230894..a89a18992aa 100644 --- a/src/modules/tcpops/tcpops_mod.c +++ b/src/modules/tcpops/tcpops_mod.c @@ -811,6 +811,9 @@ static int pv_get_tcp(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) tcpconn_put(con); return pv_get_sintval(msg, param, res, ival); default: /* conid */ + if(con) { + tcpconn_put(con); + } return pv_get_sintval(msg, param, res, msg->rcv.proto_reserved1); } }

1 0

git:master:84ea36b4: core: remove unnecessary check after using the structure
by Daniel-Constantin Mierla 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: 84ea36b4b79c07c4fc0a8c9e119184433353764e URL: https://github.com/kamailio/kamailio/commit/84ea36b4b79c07c4fc0a8c9e1191844… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-18T12:29:05+02:00 core: remove unnecessary check after using the structure --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/84ea36b4b79c07c4fc0a8c9e1191844… Patch: https://github.com/kamailio/kamailio/commit/84ea36b4b79c07c4fc0a8c9e1191844… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index ab02fb7c47c..f26abd2e79d 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -2384,7 +2384,7 @@ char *generate_res_buf_from_sip_res( } /* test and add xavp via reply params */ - if(msg && msg->via2 && (msg->msg_flags & FL_ADD_XAVP_VIA_REPLY_PARAMS) + if(msg->via2 && (msg->msg_flags & FL_ADD_XAVP_VIA_REPLY_PARAMS) && _ksr_xavp_via_reply_params.len > 0) { xparams.s = pv_get_buffer(); xparams.len = xavp_serialize_fields_style(&_ksr_xavp_via_reply_params,

1 0

git:master:15b2a546: core: set digit 0 in the md5 buffer in case of error inside char_msg_val()
by Daniel-Constantin Mierla 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: 15b2a5467f11e009ae4efad1ee29af860326095f URL: https://github.com/kamailio/kamailio/commit/15b2a5467f11e009ae4efad1ee29af8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-18T12:17:10+02:00 core: set digit 0 in the md5 buffer in case of error inside char_msg_val() --- Modified: src/core/char_msg_val.h --- Diff: https://github.com/kamailio/kamailio/commit/15b2a5467f11e009ae4efad1ee29af8… Patch: https://github.com/kamailio/kamailio/commit/15b2a5467f11e009ae4efad1ee29af8… --- diff --git a/src/core/char_msg_val.h b/src/core/char_msg_val.h index b3d7e4a1bea..bcdea56b85e 100644 --- a/src/core/char_msg_val.h +++ b/src/core/char_msg_val.h @@ -41,8 +41,11 @@ inline static int char_msg_val(struct sip_msg *msg, char *cv) str sempty = str_init(""); if(unlikely(!check_transaction_quadruple(msg))) { - LM_ERR("can't calculate char_value due to a parsing error\n"); - memset(cv, '0', MD5_LEN); + int i; + for(i = 0; i < MD5_LEN; i++) { + cv[i] = '0'; + } + LM_ERR("cannot calculate char_value due to a parsing error\n"); return 0; } /* to body is automatically parsed (via check_transactionquadruple /

1 0

git:master:a471d34d: core: init res inside select_cfg_var()
by Daniel-Constantin Mierla 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: a471d34d6162387a1427f5d0c5b3c6079a2b0bdc URL: https://github.com/kamailio/kamailio/commit/a471d34d6162387a1427f5d0c5b3c60… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-18T12:00:47+02:00 core: init res inside select_cfg_var() --- Modified: src/core/cfg/cfg_select.c --- Diff: https://github.com/kamailio/kamailio/commit/a471d34d6162387a1427f5d0c5b3c60… Patch: https://github.com/kamailio/kamailio/commit/a471d34d6162387a1427f5d0c5b3c60… --- diff --git a/src/core/cfg/cfg_select.c b/src/core/cfg/cfg_select.c index f948dd4ab4c..f3b2d681d3e 100644 --- a/src/core/cfg/cfg_select.c +++ b/src/core/cfg/cfg_select.c @@ -147,6 +147,9 @@ int select_cfg_var(str *res, select_t *s, struct sip_msg *msg) int i; static char buf[INT2STR_MAX_LEN]; + res->s = 0; + res->len = 0; + if(msg == NULL) { /* fixup call */ @@ -228,12 +231,7 @@ int select_cfg_var(str *res, select_t *s, struct sip_msg *msg) break; case CFG_VAR_STR: - if(p) { - memcpy(res, p, sizeof(str)); - } else { - res->s = 0; - res->len = 0; - } + memcpy(res, p, sizeof(str)); break; default:

1 0

[kamailio/kamailio] ims_qos_npn: forked module from ims_qos, for better rx support (PR #3921)
by Dragos Vingarzan 18 Jul '24

18 Jul '24

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  The `ims_qos` module had a few limitations. This fork of that module adds: - AAR for the registration (signaling path monitoring) - subsequent AARs in calls - support for STR - extra event_routes on Rx authorization session events - extra AVPs decoding and use The dependency and use of the `ims_dialog` was removed. We think that the respective module has fallen behind `dialog` (although it should've replaced it? don't know...). Cleaning/upgrading that module too might be too much effort. Since these changes might be breaking things for other folks using IMS, we are pushing these as an alternative module. We hope that we'll find though consensus in the future and either remove or merge with the older `ims_qos` module. Same would be valid for `ims_dialog` and `dialog`, yet those also might need some upgrades. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3921 -- Commit Summary -- * ims_qos_npn: imported modified module * src: added ims_qos_npn to Makefile.groups -- File Changes -- M src/Makefile.groups (2) A src/modules/ims_qos_npn/Makefile (19) A src/modules/ims_qos_npn/README (781) A src/modules/ims_qos_npn/cdpeventprocessor.c (382) A src/modules/ims_qos_npn/cdpeventprocessor.h (87) A src/modules/ims_qos_npn/doc/Makefile (4) A src/modules/ims_qos_npn/doc/ims_qos.xml (113) A src/modules/ims_qos_npn/doc/ims_qos_admin.xml (882) A src/modules/ims_qos_npn/ims_qos_mod.c (2173) A src/modules/ims_qos_npn/ims_qos_mod.h (85) A src/modules/ims_qos_npn/ims_qos_stats.c (156) A src/modules/ims_qos_npn/ims_qos_stats.h (38) A src/modules/ims_qos_npn/rx_aar.c (1296) A src/modules/ims_qos_npn/rx_aar.h (131) A src/modules/ims_qos_npn/rx_asr.c (124) A src/modules/ims_qos_npn/rx_asr.h (59) A src/modules/ims_qos_npn/rx_authdata.c (494) A src/modules/ims_qos_npn/rx_authdata.h (125) A src/modules/ims_qos_npn/rx_avp.c (2144) A src/modules/ims_qos_npn/rx_avp.h (118) A src/modules/ims_qos_npn/rx_rar.c (160) A src/modules/ims_qos_npn/rx_rar.h (34) A src/modules/ims_qos_npn/rx_str.c (184) A src/modules/ims_qos_npn/rx_str.h (61) A src/modules/ims_qos_npn/sem.h (90) A src/modules/ims_qos_npn/stats.c (79) A src/modules/ims_qos_npn/stats.h (61) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3921.patch https://github.com/kamailio/kamailio/pull/3921.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3921 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3921(a)github.com>

2 4

[kamailio/kamailio] siprepo: fix int params and wrong copy data in siprepo_msg_async_pull (PR #3919)
by emvondo 18 Jul '24

18 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3919 -- Commit Summary -- * siprepo: fix int params and wrong copy data in siprepo_msg_async_pull -- File Changes -- M src/modules/siprepo/siprepo_data.c (6) M src/modules/siprepo/siprepo_mod.c (19) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3919.patch https://github.com/kamailio/kamailio/pull/3919.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3919 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3919(a)github.com>

2 3

git:master:a3a63655: siprepo: fix int params and wrong copy data in siprepo_msg_async_pull (#3919)
by GitHub 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: a3a63655dbcbf1bc8067f34c36f4a7295b2a1745 URL: https://github.com/kamailio/kamailio/commit/a3a63655dbcbf1bc8067f34c36f4a72… Author: emvondo <106535097+emvondo(a)users.noreply.github.com> Committer: GitHub <noreply(a)github.com> Date: 2024-07-18T10:10:33+02:00 siprepo: fix int params and wrong copy data in siprepo_msg_async_pull (#3919) * siprepo: fix int params and wrong copy data in siprepo_msg_async_pull --------- Co-authored-by: emvondo <bycl2332(a)orange.com> --- Modified: src/modules/siprepo/siprepo_data.c Modified: src/modules/siprepo/siprepo_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/a3a63655dbcbf1bc8067f34c36f4a72… Patch: https://github.com/kamailio/kamailio/commit/a3a63655dbcbf1bc8067f34c36f4a72… --- diff --git a/src/modules/siprepo/siprepo_data.c b/src/modules/siprepo/siprepo_data.c index 397def720fb..2720c50c2c0 100644 --- a/src/modules/siprepo/siprepo_data.c +++ b/src/modules/siprepo/siprepo_data.c @@ -496,15 +496,15 @@ int siprepo_msg_async_pull(str *callid, str *msgid, str *gname, str *rname, return -1; } stp->callid.s = (char*)stp + ROUND_POINTER(sizeof(siprepo_task_param_t)); - memcpy(callid->s, stp->callid.s, callid->len); + memcpy(stp->callid.s, callid->s, callid->len); stp->callid.len = callid->len; stp->msgid.s = stp->callid.s + ROUND_POINTER(callid->len + 1); - memcpy(msgid->s, stp->msgid.s, msgid->len); + memcpy(stp->msgid.s, msgid->s, msgid->len); stp->msgid.len = msgid->len; stp->rname.s = stp->msgid.s + ROUND_POINTER(msgid->len + 1); - memcpy(rname->s, stp->rname.s, rname->len); + memcpy(stp->rname.s, rname->s, rname->len); stp->rname.len = rname->len; stp->rmode = rmode; diff --git a/src/modules/siprepo/siprepo_mod.c b/src/modules/siprepo/siprepo_mod.c index d8f8b02c5ad..e6acc23368e 100644 --- a/src/modules/siprepo/siprepo_mod.c +++ b/src/modules/siprepo/siprepo_mod.c @@ -58,6 +58,8 @@ static int w_sr_msg_check(sip_msg_t *msg, char *p1, char *p2); static void siprepo_timer_exec(unsigned int ticks, int worker, void *param); +static int fixup_sr_msg_async_pull(void **param, int param_no); + /* clang-format off */ typedef struct sworker_task_param { char *buf; @@ -69,10 +71,10 @@ typedef struct sworker_task_param { static cmd_export_t cmds[]={ {"sr_msg_push", (cmd_function)w_sr_msg_push, 2, fixup_spve_igp, fixup_free_spve_null, REQUEST_ROUTE|CORE_ONREPLY_ROUTE}, - {"sr_msg_pull", (cmd_function)w_sr_msg_pull, 3, fixup_spve_all, - fixup_free_spve_all, REQUEST_ROUTE|CORE_ONREPLY_ROUTE}, - {"sr_msg_async_pull", (cmd_function)w_sr_msg_async_pull, 5, fixup_spve_all, - fixup_free_spve_all, ANY_ROUTE}, + {"sr_msg_pull", (cmd_function)w_sr_msg_pull, 4, fixup_sssi, + fixup_free_sssi, REQUEST_ROUTE|CORE_ONREPLY_ROUTE}, + {"sr_msg_async_pull", (cmd_function)w_sr_msg_async_pull, 5, fixup_sr_msg_async_pull, + 0, ANY_ROUTE}, {"sr_msg_rm", (cmd_function)w_sr_msg_rm, 2, fixup_spve_spve, fixup_free_spve_spve, REQUEST_ROUTE|CORE_ONREPLY_ROUTE}, {"sr_msg_check", (cmd_function)w_sr_msg_check, 0, 0, @@ -282,6 +284,15 @@ static int w_sr_msg_async_pull(sip_msg_t *msg, char *pcallid, char *pmsgid, } +static int fixup_sr_msg_async_pull(void **param, int param_no) +{ + if(param_no >= 1 && param_no <= 4) + return fixup_spve_null(param, 1); + if(param_no == 5) + return fixup_igp_null(param, 1); + return 0; +} + /** * */

1 0

git:master:aa79588c: dispatcher: added ocidx to the rpc response
by Daniel-Constantin Mierla 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: aa79588ceacaaae118230bd06b0eb7aadf9b31f3 URL: https://github.com/kamailio/kamailio/commit/aa79588ceacaaae118230bd06b0eb7a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-18T09:09:01+02:00 dispatcher: added ocidx to the rpc response --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/aa79588ceacaaae118230bd06b0eb7a… Patch: https://github.com/kamailio/kamailio/commit/aa79588ceacaaae118230bd06b0eb7a… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 3fd941c21c4..74ee7cc8e8d 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1869,13 +1869,14 @@ int ds_rpc_print_set( ipbuf[0] = '\0'; ip_addr2sbufz( &node->dlist[j].ip_address, ipbuf, IP_ADDR_MAX_STRZ_SIZE); - if(rpc->struct_add(vh, "Ssddjjujj", "HOST", &node->dlist[j].host, + if(rpc->struct_add(vh, "Ssddjjujjj", "HOST", &node->dlist[j].host, "IPADDR", ipbuf, "PORT", (int)node->dlist[j].port, "PROTOID", (int)node->dlist[j].proto, "DNSTIME_SEC", (unsigned long)node->dlist[j].dnstime.tv_sec, "DNSTIME_USEC", (unsigned long)node->dlist[j].dnstime.tv_usec, "OCRATE", - node->dlist[j].attrs.ocrate, "OCTIME_SEC", + node->dlist[j].attrs.ocrate, "OCIDX", + (unsigned long)node->dlist[j].ocidx, "OCTIME_SEC", (unsigned long)node->dlist[j].octime.tv_sec, "OCTIME_USEC", (unsigned long)node->dlist[j].octime.tv_usec)

1 0

git:master:8c3b5ab3: dispatcher: remove reference to MI in comments
by Daniel-Constantin Mierla 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: 8c3b5ab3818c86b90b02e20aa4631654e0b51745 URL: https://github.com/kamailio/kamailio/commit/8c3b5ab3818c86b90b02e20aa463165… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-18T09:09:01+02:00 dispatcher: remove reference to MI in comments --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/8c3b5ab3818c86b90b02e20aa463165… Patch: https://github.com/kamailio/kamailio/commit/8c3b5ab3818c86b90b02e20aa463165… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 287164f829d..bdb615ad3ea 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -3982,14 +3982,14 @@ static void ds_options_callback( } } - /* Check if in the meantime someone disabled probing of the target through RPC, MI or reload */ + /* Check if in the meantime someone disabled probing of the target + * through RPC or reload */ if(ds_probing_mode == DS_PROBE_ONLYFLAGGED && !(ds_get_state(group, &uri) & DS_PROBING_DST)) { return; } /* ps->code contains the result-code of the request. - * * We accept both a "200 OK" or the configured reply as a valid response */ if((ps->code >= 200 && ps->code <= 299) || ds_ping_check_rplcode(ps->code)) { @@ -4000,7 +4000,7 @@ static void ds_options_callback( && (ds_get_state(group, &uri) & DS_PROBING_DST))) state |= DS_PROBING_DST; - /* Check if in the meantime someone disabled the target through RPC or MI */ + /* Check if in the meantime someone disabled the target through RPC */ if(!(ds_get_state(group, &uri) & DS_DISABLED_DST) && ds_update_state(fmsg, group, &uri, state, &rctx) != 0) { LM_ERR("Setting the state failed (%.*s, group %d)\n", uri.len, @@ -4010,7 +4010,7 @@ static void ds_options_callback( state = DS_TRYING_DST; if(ds_probing_mode != DS_PROBE_NONE) state |= DS_PROBING_DST; - /* Check if in the meantime someone disabled the target through RPC or MI */ + /* Check if in the meantime someone disabled the target through RPC */ if(!(ds_get_state(group, &uri) & DS_DISABLED_DST) && ds_update_state(fmsg, group, &uri, state, &rctx) != 0) { LM_ERR("Setting the probing state failed (%.*s, group %d)\n",

1 0

git:master:39be7eb5: src: added ims_qos_npn to Makefile.groups
by Dragos Vingarzan 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: 39be7eb53773a1e3776d185f47d13a41e95408c3 URL: https://github.com/kamailio/kamailio/commit/39be7eb53773a1e3776d185f47d13a4… Author: Dragos Vingarzan <dragos(a)neatpath.net> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-18T09:02:17+02:00 src: added ims_qos_npn to Makefile.groups --- Modified: src/Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/39be7eb53773a1e3776d185f47d13a4… Patch: https://github.com/kamailio/kamailio/commit/39be7eb53773a1e3776d185f47d13a4… --- diff --git a/src/Makefile.groups b/src/Makefile.groups index 909abc7541b..b40781bf5cd 100644 --- a/src/Makefile.groups +++ b/src/Makefile.groups @@ -167,7 +167,7 @@ mod_list_redis=db_redis ndb_redis topos_redis mod_list_mono=app_mono # - modules related to IMS extensions -mod_list_ims=cdp cdp_avp ims_dialog ims_auth ims_isc ims_icscf ims_qos \ +mod_list_ims=cdp cdp_avp ims_dialog ims_auth ims_isc ims_icscf ims_qos ims_qos_npn \ ims_registrar_pcscf ims_registrar_scscf ims_usrloc_pcscf \ ims_usrloc_scscf ims_charging ims_ocs ims_diameter_server \ ims_ipsec_pcscf

1 0

git:master:5ee7d35c: ims_qos_npn: imported modified module
by Dragos Vingarzan 18 Jul '24

18 Jul '24

Module: kamailio Branch: master Commit: 5ee7d35cfd9839230efbb163bac81ecbd461d6b5 URL: https://github.com/kamailio/kamailio/commit/5ee7d35cfd9839230efbb163bac81ec… Author: Dragos Vingarzan <dragos(a)neatpath.net> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-18T09:02:17+02:00 ims_qos_npn: imported modified module --- Added: src/modules/ims_qos_npn/Makefile Added: src/modules/ims_qos_npn/README Added: src/modules/ims_qos_npn/cdpeventprocessor.c Added: src/modules/ims_qos_npn/cdpeventprocessor.h Added: src/modules/ims_qos_npn/doc/Makefile Added: src/modules/ims_qos_npn/doc/ims_qos.xml Added: src/modules/ims_qos_npn/doc/ims_qos_admin.xml Added: src/modules/ims_qos_npn/ims_qos_mod.c Added: src/modules/ims_qos_npn/ims_qos_mod.h Added: src/modules/ims_qos_npn/ims_qos_stats.c Added: src/modules/ims_qos_npn/ims_qos_stats.h Added: src/modules/ims_qos_npn/rx_aar.c Added: src/modules/ims_qos_npn/rx_aar.h Added: src/modules/ims_qos_npn/rx_asr.c Added: src/modules/ims_qos_npn/rx_asr.h Added: src/modules/ims_qos_npn/rx_authdata.c Added: src/modules/ims_qos_npn/rx_authdata.h Added: src/modules/ims_qos_npn/rx_avp.c Added: src/modules/ims_qos_npn/rx_avp.h Added: src/modules/ims_qos_npn/rx_rar.c Added: src/modules/ims_qos_npn/rx_rar.h Added: src/modules/ims_qos_npn/rx_str.c Added: src/modules/ims_qos_npn/rx_str.h Added: src/modules/ims_qos_npn/sem.h Added: src/modules/ims_qos_npn/stats.c Added: src/modules/ims_qos_npn/stats.h --- Diff: https://github.com/kamailio/kamailio/commit/5ee7d35cfd9839230efbb163bac81ec… Patch: https://github.com/kamailio/kamailio/commit/5ee7d35cfd9839230efbb163bac81ec…

1 0

git: new commits in branch master
by Daniel-Constantin Mierla 17 Jul '24

17 Jul '24

- URL: https://github.com/kamailio/kamailio/commit/fa792054a58126b57797675aadc4f0e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-16T20:27:27+02:00 core: pvapi - use defined types for pv_get_avp_name() name and flags - URL: https://github.com/kamailio/kamailio/commit/4b35f78c57a679723ec77c10c1a2f03… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-16T20:33:01+02:00 corex: use defined types for avp name and flags - URL: https://github.com/kamailio/kamailio/commit/ac9417cb0db60f9a4a0ff9f532edd07… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-16T20:36:30+02:00 corex: destroy all msg avps after nio event route - URL: https://github.com/kamailio/kamailio/commit/07e5c94cad90474f8e2f2918ca28741… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-16T20:55:52+02:00 core: pvar - use defined types for avp type and name - URL: https://github.com/kamailio/kamailio/commit/dedba13bf159d780c3c0ae4dd524e92… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-16T20:57:24+02:00 core: avp - coherent use of defined types for name and type - URL: https://github.com/kamailio/kamailio/commit/bdd8619d4389b3a84b3ca601d5fe02a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:44:51+02:00 core: cfg.y - use avp flags type - URL: https://github.com/kamailio/kamailio/commit/f8782d7f7522c83ca5490d133a6f696… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:01+02:00 acc: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/b7de3f755d7f613cb324768466d3122… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:04+02:00 avpops: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/4f61b76640f3bca27642a4e0e973b3b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:07+02:00 call_control: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/d1bca3506b931164fb7993936107a42… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:10+02:00 cfgt: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/dcce0b7f9c742ce2fdc512da87f5b12… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:13+02:00 cplc: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/e1e2ad2fc278a05a1ad82e7cb18511d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:16+02:00 debugger: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/a6a191be5aa389f82f4f6d56b48eb9b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:19+02:00 dialplan: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/896fc467901da9e99426866ce6348fd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:22+02:00 drouting: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/ee07ab29297a7ac86fe975d692f2bf5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:25+02:00 exec: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/308246a76a268980038d2435ad7c259… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:28+02:00 h350: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/98504b4f7557299cd5c52e95aeb307e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:31+02:00 ims_registrar_pcscf: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/604f900ca8a0e64757ff123c2f0b6a0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:34+02:00 ims_registrar_scscf: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/e67ad97d3da4e3b5149ea0de31f0930… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:37+02:00 json: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/2ac3e5daafe8c48835aaf8c488e5aa1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:39+02:00 kazoo: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/b523f5e4f4a4f5b8c2f40717c57d093… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:42+02:00 lcr: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/def2e8fcd09ba4bceb21169410da4bc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:44+02:00 ldap: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/3bc58f2a3cdf1db930b3836d2d19614… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:48+02:00 matrix: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/be98520dd9366d30be74ec9078212f8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:50+02:00 mediaproxy: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/b7ae09d3b311a7e5cc6d7ded81fc034… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:53+02:00 msilo: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/bf996241f712a8645ffb28906aeb849… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:55+02:00 mtree: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/cb7ad3e8cfeb2bfc3b8d092d3b03073… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:54:59+02:00 nathelper: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/11ac3d05d5d1f1222bf025d26f92f43… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:01+02:00 osp: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/dda660bdb3fc3f9257e9291cf38182d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:04+02:00 pdb: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/594a4b39b15a2d4db361554d091e14e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:06+02:00 permissions: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/456608939cf5970eaa3df0919088308… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:09+02:00 pua_dialoginfo: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/53f9a571315c151bdd1bf4a6bd5e21f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:11+02:00 pv: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/59c2ebad7d030fd8b2d2e675e3f481f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:14+02:00 registrar: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/0483f1c74e9f3f48e573b445655a622… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:16+02:00 rtpengine: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/e14e80a29a8d6edcef955a66b696c3c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:19+02:00 rtpproxy: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/44654f476a7ebc3b8531e3dc0455ccd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:21+02:00 sdpops: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/e703f9454f8d2b48562e254d79d6102… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:23+02:00 siptrace: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/72e8f2a201c9084c3ac86f7921c7787… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:25+02:00 siputils: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/32963fa84244fb0b6b80a50101866c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:27+02:00 tm: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/61ed552911e5ac633cdfdabd9ed2a26… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:28+02:00 uac: coherent use of defined types for avp flags, name and value - URL: https://github.com/kamailio/kamailio/commit/72b80c120c28fbc910c946c9a075e87… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-17T08:55:31+02:00 xprint: coherent use of defined types for avp flags, name and value

1 0

[kamailio/kamailio] Dialog DMQ sync: Timer needs fixing, firing on wrong node! (Issue #3656)
by Benoît Panizzon 17 Jul '24

17 Jul '24

Situation: Two Kamailio nodes syncing dialog profiles via DMQ Observation: When a dialog timeout is encountered, about half of the time, the timeout is triggered on the peer node not handling the dialog preventing the call to be correctly terminated and also leaving entries in the dialog database which never get deleted. https://kamailio.org/docs/modules/5.7.x/modules/dialog.html#dialog.p.enable… Makes clear, that only the node which is handling the dialog in question, can make changes not related to the dialog profiles. So when a dialog times out, it is this node which has to trigger the timeout, not any other one. When looking at the source code, it is clear, that the 'lifetime' is transmitted via DMQ dialog message to the peer nodes, which in turn arm a timer. So it is obvious, this time will trigger, sometimes before the instance handling the dialog itself triggers that timer. With some assistance of @oej I found a way to alter the JSON payload to extend the lifetime on the peer nodes: ``` route[DMQ_CAPTURE] { if(is_method("KDMQ")) { if(has_body("application/json") && $fU == 'dialog') { if (jansson_get("lifetime", $rb, "$var(lifetime)")) { $var(new_lifetime) = $var(lifetime) + 60; # Add 60 seconds on DMQ peer to make sure it expires AFTER main node. $var(newrb) = $rb; jansson_set("integer", "lifetime", $var(new_lifetime), "$var(newrb)"); set_body("$var(newrb)","application/json"); msg_apply_changes(); } } dmq_handle_message(); exit; } } ``` Testing with this config fixed the issue of the timeout firing on a peer node instead of the node handling the dialog. Issue is present in 5.5, 5.6 and after looking at the code, I assume also on 5.7 -Benoît -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3656 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3656(a)github.com>

6 15

git:master:ba31a006: modules: readme files regenerated - dispatcher ... [skip ci]
by Kamailio Dev 16 Jul '24

16 Jul '24

Module: kamailio Branch: master Commit: ba31a0065af34490650a205738328f52b95a784b URL: https://github.com/kamailio/kamailio/commit/ba31a0065af34490650a205738328f5… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-16T10:31:11+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README --- Diff: https://github.com/kamailio/kamailio/commit/ba31a0065af34490650a205738328f5… Patch: https://github.com/kamailio/kamailio/commit/ba31a0065af34490650a205738328f5… --- diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README index 41f9d7bb812..16c10332df7 100644 --- a/src/modules/dispatcher/README +++ b/src/modules/dispatcher/README @@ -1883,6 +1883,7 @@ kamctl rpc dispatcher.hash 4 bob server.com startup, useful when the hostname of the destination address is a NAPTR or SRV record only. Such addresses cannot be matched anymore with ds_is_from_list(...). + + 32 (bit at index 5 - 1 <<5) - no ping to destination * priority: sets the priority in destination list (based on it is done the initial ordering inside the set) * attributes: extra fields in form of name1=value1;...;nameN=valueN.

1 0

git:master:2ce75082: dispatcher: docs - listed flag 32
by Daniel-Constantin Mierla 16 Jul '24

16 Jul '24

Module: kamailio Branch: master Commit: 2ce75082134a7e03c29e3096316cee5ad455d9af URL: https://github.com/kamailio/kamailio/commit/2ce75082134a7e03c29e3096316cee5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-16T10:20:17+02:00 dispatcher: docs - listed flag 32 --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/2ce75082134a7e03c29e3096316cee5… Patch: https://github.com/kamailio/kamailio/commit/2ce75082134a7e03c29e3096316cee5… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index e50ea26f518..a17e87f68e7 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -2372,6 +2372,8 @@ kamctl rpc dispatcher.hash 4 bob server.com useful when the hostname of the destination address is a NAPTR or SRV record only. Such addresses cannot be matched anymore with ds_is_from_list(...).</para> </listitem> + <listitem><para>32 (bit at index 5 - 1 <<5) - no ping to destination</para> + </listitem> </itemizedlist> </para> </listitem>

1 0

git:master:abdd0bfa: dispatcher: new flag 32 to not send ping to destination
by Daniel-Constantin Mierla 16 Jul '24

16 Jul '24

Module: kamailio Branch: master Commit: abdd0bfaf6a2e50fb96e2f522f03a65f331b57b5 URL: https://github.com/kamailio/kamailio/commit/abdd0bfaf6a2e50fb96e2f522f03a65… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-16T10:10:06+02:00 dispatcher: new flag 32 to not send ping to destination --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatch.h --- Diff: https://github.com/kamailio/kamailio/commit/abdd0bfaf6a2e50fb96e2f522f03a65… Patch: https://github.com/kamailio/kamailio/commit/abdd0bfaf6a2e50fb96e2f522f03a65… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index d36141bbafd..287164f829d 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -4069,6 +4069,9 @@ void ds_ping_set(ds_set_t *node) /* skip addresses set in disabled state by admin */ if((node->dlist[j].flags & DS_DISABLED_DST) != 0) continue; + /* skip addresses with no-ping flag */ + if((node->dlist[j].flags & DS_NOPING_DST) != 0) + continue; /* If the Flag of the entry has "Probing set, send a probe: */ if(ds_ping_result_helper(node, j)) { LM_DBG("probing set #%d, URI %.*s\n", node->id, diff --git a/src/modules/dispatcher/dispatch.h b/src/modules/dispatcher/dispatch.h index 06410225a62..cf1842aeb47 100644 --- a/src/modules/dispatcher/dispatch.h +++ b/src/modules/dispatcher/dispatch.h @@ -46,7 +46,8 @@ #define DS_DISABLED_DST 4 /*!< admin disabled destination */ #define DS_PROBING_DST 8 /*!< checking destination */ #define DS_NODNSARES_DST 16 /*!< no DNS A/AAAA resolve for host in uri */ -#define DS_STATES_ALL 31 /*!< all bits for the states of destination */ +#define DS_NOPING_DST 32 /*!< no ping to destination */ +#define DS_STATES_ALL 63 /*!< all bits for the states of destination */ #define ds_skip_dst(flags) ((flags) & (DS_INACTIVE_DST|DS_DISABLED_DST))

1 0

git:master:eda03789: core: remove unnecessary cleanup when locating a module
by Daniel-Constantin Mierla 16 Jul '24

16 Jul '24

Module: kamailio Branch: master Commit: eda03789f693bb72ec4ee05a8b2b4723e5080504 URL: https://github.com/kamailio/kamailio/commit/eda03789f693bb72ec4ee05a8b2b472… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-16T08:27:42+02:00 core: remove unnecessary cleanup when locating a module --- Modified: src/core/sr_module.c --- Diff: https://github.com/kamailio/kamailio/commit/eda03789f693bb72ec4ee05a8b2b472… Patch: https://github.com/kamailio/kamailio/commit/eda03789f693bb72ec4ee05a8b2b472… --- diff --git a/src/core/sr_module.c b/src/core/sr_module.c index d67e7e44af3..5db20255874 100644 --- a/src/core/sr_module.c +++ b/src/core/sr_module.c @@ -535,9 +535,6 @@ int ksr_locate_module(char *mod_path, char **new_path) return 0; error: - if(path != NULL && path != mod_path) { - pkg_free(path); - } return -1; }

1 0

[kamailio/kamailio] nathelper: fixed handle_ruri_alias() for alias being an IPv6 (PR #3913)
by Dragos Vingarzan 15 Jul '24

15 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  `handle_ruri_alias()` wasn't handling correctly the IP address in the alias, in case it was an IPv6. This adds `[` and `]` around the IP if v6 when composing a destination SIP URI, such that the downstream functions will handle it correctly and not be confused by the `:` before the port. Arguably, nathelper is not needed in IPv6. Yet I have discovered a scenario where it could be quite helpful as a way to force some UE routing through an intermediary proxy. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3913 -- Commit Summary -- * nathelper: fixed handle_ruri_alias() for alias being an IPv6 -- File Changes -- M src/modules/nathelper/nathelper.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3913.patch https://github.com/kamailio/kamailio/pull/3913.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3913 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3913(a)github.com>

2 5

git:master:52ab6f3d: nathelper: fixed handle_ruri_alias() for alias being an IPv6
by Dragos Vingarzan 15 Jul '24

15 Jul '24

Module: kamailio Branch: master Commit: 52ab6f3dcf5ad8d967be8bdecaa64ef31cbfbe33 URL: https://github.com/kamailio/kamailio/commit/52ab6f3dcf5ad8d967be8bdecaa64ef… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-15T21:50:48+02:00 nathelper: fixed handle_ruri_alias() for alias being an IPv6 --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/52ab6f3dcf5ad8d967be8bdecaa64ef… Patch: https://github.com/kamailio/kamailio/commit/52ab6f3dcf5ad8d967be8bdecaa64ef… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index 6e6d44ad7ed..9c0bebad3a7 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -1139,7 +1139,7 @@ static int ki_handle_ruri_alias_mode(struct sip_msg *msg, int mode) char buf[MAX_URI_SIZE], *val, *sep, *at, *next, *cur_uri, *rest, *port, *trans, *start; unsigned int len, rest_len, val_len, alias_len, proto_type, cur_uri_len, - ip_port_len; + ip_len, ip_port_len, port_len, i; if(parse_sip_msg_uri(msg) < 0) { LM_ERR("while parsing Request-URI\n"); @@ -1185,18 +1185,46 @@ static int ki_handle_ruri_alias_mode(struct sip_msg *msg, int mode) LM_ERR("no '~' in alias param value\n"); return -1; } + // IPv6 needs some [] added when composing a SIP URI, which further + // complicates this code. + ip_len = port - val; + int is_ipv6 = 0; + for(i = 0; i < ip_len; i++) { + if(val[i] == ':') { + is_ipv6 = 1; + break; + } + } *(port++) = ':'; trans = memchr(port, 126 /* ~ */, val_len - (port - val)); if(trans == NULL) { LM_ERR("no second '~' in alias param value\n"); return -1; } + // Compose the URI in a buffer at = &(buf[0]); append_str(at, "sip:", 4); ip_port_len = trans - val; alias_len = _ksr_contact_salias.len + ip_port_len + 2 /* ~n */; - memcpy(at, val, ip_port_len); - at = at + ip_port_len; + if(is_ipv6) { + // IPv6 - add '[' ']' around IP + // then append ':' and copy the port + append_chr(at, '['); + memcpy(at, val, ip_len); + at = at + ip_len; + append_chr(at, ']'); + port_len = trans - port; + if(port_len > 0) { + append_chr(at, ':'); + memcpy(at, port, port_len); + at = at + port_len; + } + } else { + // IPv4 - copy directly as is + // separator '~' between IP and port was changed to ':' + memcpy(at, val, ip_port_len); + at = at + ip_port_len; + } trans = trans + 1; if((ip_port_len + 2 > val_len) || (*trans == ';') || (*trans == '?')) { LM_ERR("no proto in alias param\n");

1 0

[kamailio/kamailio] Debian package build fails for Kamailio 5.7.4 (Issue #3722)
by Alexander Bakker 15 Jul '24

15 Jul '24

### Description The Debian package build fails for Kamailio 5.7.4 because it can't find static libssl. This happens because ``LIBSSL_STATIC_SRCPATH`` is set to the wrong location in the rules file. ### Troubleshooting #### Reproduction 1. Run ``ln -s pkg/kamailio/deb/bookworm debian`` 2. Run ``make deb`` #### Output ``` gcc -shared -g -m64 -Wl,-O2 -Wl,-E -Wl,-z,relro -pthread -rdynamic "-ldl" -Wl,-Bsymbolic-functions tls_bio.o tls_cfg.o tls_config.o tls_ct_wrq.o tls_domain.o tls_dump_vf.o tls_init.o tls_locking.o tls_map.o tls_rand.o tls_rpc.o tls_select.o tls_server.o tls_util.o tls_verify.o tlsa_mod.o -lm /usr/lib64/libssl.a /usr/lib64/libcrypto.a -o tlsa.so /usr/bin/ld: cannot find /usr/lib64/libssl.a: No such file or directory /usr/bin/ld: cannot find /usr/lib64/libcrypto.a: No such file or directory collect2: error: ld returned 1 exit status make[5]: *** [../../Makefile.rules:191: tlsa.so] Error 1 ``` ### Possible Solutions An extremely hacky workaround is to patch the rules file to point ``LIBSSL_STATIC_SRCPATH`` to the right location: ``` sed -i -e "/LIBSSL_STATIC_SRCPATH/a export\\ LIBSSL_STATIC_SRCPATH=\\/usr\\/lib\\/$(uname -m)-linux-gnu" pkg/kamailio/deb/bookworm/rules ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: ``` Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm ``` ``` Linux 6.5.0-14-generic #14-Ubuntu SMP PREEMPT_DYNAMIC Tue Nov 14 14:59:49 UTC 2023 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3722 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3722(a)github.com>

3 10

[kamailio/kamailio] No CDR is written on failover (Issue #3254)
by Earn330 15 Jul '24

15 Jul '24

Hi, I think there is an issue with writing CDRs on failover scenarios. I have two servers with Kamailio. Both server running Debian 11 (bulleye) and latest Kamailio 5.6.1 from git. I'm using DMQ to sync dialogs and htable between these servers, so both servers have the same knowledge of dialog state. Both Kamailio uses nobind option, so I can switch a VIP from one server to the other one. This is managed with keepalived. Switching the VIP from one server the other one works fine an while a call is running I can switch the VIP. I can see that the BYE Message is handled OK after I made a switch. I can see that acc is triggered but what is missing is acc_cdr in this case. I'm using htable to fill all necessary variables to complete the CDR an I can see that all values are synced correctly. The acc_cdr is created fine if there is no failover so i think it can't be an configuration issue. Both server holds the same Kamailio configuration except the IP. `version: kamailio 5.6.1 (x86_64/linux) bfc5c2-dirty flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: bfc5c2 -dirty compiled with gcc 10.2.1` `root@voip-lab-proxy01:~# lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye` `root@voip-lab-proxy01:~# lscpu Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 38 bits physical, 48 bits virtual CPU(s): 4 On-line CPU(s) list: 0-3 Thread(s) per core: 1 Core(s) per socket: 4 Socket(s): 1 NUMA node(s): 1 Vendor ID: GenuineIntel CPU family: 6 Model: 23 Model name: Intel(R) Xeon(R) CPU E5420 @ 2.50GHz Stepping: 10 CPU MHz: 2500.088 BogoMIPS: 5000.17 Virtualization: VT-x Hypervisor vendor: KVM Virtualization type: full L1d cache: 128 KiB L1i cache: 128 KiB L2 cache: 16 MiB L3 cache: 16 MiB NUMA node0 CPU(s): 0-3 Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Mitigation; PTE Inversion; VMX EPT disabled Vulnerability Mds: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown Vulnerability Meltdown: Mitigation; PTI Vulnerability Mmio stale data: Unknown: No mitigations Vulnerability Retbleed: Not affected Vulnerability Spec store bypass: Vulnerable Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx pdpe1gb lm constant_tsc arch_perfmon rep_good nopl xtopology cpuid tsc_known_freq pni vmx ssse3 cx16 pdcm sse4_1 x2apic tsc_deadline_timer xsave hypervisor lahf_lm cpuid_fault pti tpr_shadow vnmi flexpriority vpid tsc_adjust arat arch_capabilit ies` If you need more information, please let me know. As I'm running this on a test system I can reproduce the issue at any time. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3254 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3254(a)github.com>

5 9

[kamailio/kamailio] test (Issue #3918)
by ale5kamailio 15 Jul '24

15 Jul '24

test posting issue -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3918 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3918(a)github.com>

1 1

git:master:f92fe42d: nghttp2: free the addr info on listen failure
by Daniel-Constantin Mierla 15 Jul '24

15 Jul '24

Module: kamailio Branch: master Commit: f92fe42dc6c8d3d5b79cf6543b387501a41c09b3 URL: https://github.com/kamailio/kamailio/commit/f92fe42dc6c8d3d5b79cf6543b38750… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-15T08:24:59+02:00 nghttp2: free the addr info on listen failure --- Modified: src/modules/nghttp2/nghttp2_server.c --- Diff: https://github.com/kamailio/kamailio/commit/f92fe42dc6c8d3d5b79cf6543b38750… Patch: https://github.com/kamailio/kamailio/commit/f92fe42dc6c8d3d5b79cf6543b38750… --- diff --git a/src/modules/nghttp2/nghttp2_server.c b/src/modules/nghttp2/nghttp2_server.c index 6f5faf02ad6..ba0290bc4ac 100644 --- a/src/modules/nghttp2/nghttp2_server.c +++ b/src/modules/nghttp2/nghttp2_server.c @@ -793,11 +793,11 @@ static void start_listen(struct event_base *evbase, app_context *app_ctx) (int)rp->ai_addrlen); if(listener) { freeaddrinfo(res); - return; } } LM_ERR("Could not start listener"); + freeaddrinfo(res); } static void initialize_app_context(

1 0

git:master:d5076b55: evrexec: remove unnecessary safety exit loop
by Daniel-Constantin Mierla 15 Jul '24

15 Jul '24

Module: kamailio Branch: master Commit: d5076b557728b3f9d80df391ae71e2eab2c896dc URL: https://github.com/kamailio/kamailio/commit/d5076b557728b3f9d80df391ae71e2e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-14T18:56:20+02:00 evrexec: remove unnecessary safety exit loop --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/d5076b557728b3f9d80df391ae71e2e… Patch: https://github.com/kamailio/kamailio/commit/d5076b557728b3f9d80df391ae71e2e… --- diff --git a/src/modules/evrexec/evrexec_mod.c b/src/modules/evrexec/evrexec_mod.c index 3fb99535a0a..7df75654aa0 100644 --- a/src/modules/evrexec/evrexec_mod.c +++ b/src/modules/evrexec/evrexec_mod.c @@ -325,10 +325,6 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) } memset(&_evrexec_info, 0, sizeof(evrexec_info_t)); } - /* avoid exiting the process */ - while(1) { - sleep(3600); - } } /**

1 0

git:master:f2a7a3c0: dispatcher: remove unnecessary comparisons for unsigned
by Daniel-Constantin Mierla 15 Jul '24

15 Jul '24

Module: kamailio Branch: master Commit: f2a7a3c09ee881247c8a6641ec8d3b1e0e0eb812 URL: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-14T18:56:20+02:00 dispatcher: remove unnecessary comparisons for unsigned --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… Patch: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index ecd0f3a0c9d..d36141bbafd 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -408,13 +408,13 @@ int ds_set_attrs(ds_dest_t *dest, str *vattrs) str2int(&pit->body, &dest->attrs.ocrate); } } - if(dest->attrs.ocmax < 0 || dest->attrs.ocmax > 100) { + if(dest->attrs.ocmax > 100) { dest->attrs.ocmax = 100; } - if(dest->attrs.ocmin < 0 || dest->attrs.ocmin > 100) { + if(dest->attrs.ocmin > 100) { dest->attrs.ocmin = 0; } - if(dest->attrs.ocrate <= 0 || dest->attrs.ocrate > 100) { + if(dest->attrs.ocrate > 100) { dest->attrs.ocrate = 0; } if(dest->attrs.ocrate < dest->attrs.ocmin) {

1 0

[kamailio/kamailio] cdp: improved routing and removed useless warning/errors in authstatemachine (PR #3914)
by Dragos Vingarzan 14 Jul '24

14 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Diameter requests could contain Application-Ids in multiple AVPs. This fix iterates through them, instead of giving up if the first one does not match. This solves some issues when peers don't always declare support for vendor-specific/non-specific application ids, so routing should be easier. Also fixed: - auth state machine being too verbose on regular messages being received or sent while in the Open state - add Destination-Host from auth state to requests (next-hop immediate routing) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3914 -- Commit Summary -- * cdp: improved routing and removed useless warning/errors in authstatemachine -- File Changes -- M src/modules/cdp/authstatemachine.c (42) M src/modules/cdp/routing.c (176) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3914.patch https://github.com/kamailio/kamailio/pull/3914.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3914 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3914(a)github.com>

2 8

git:master:0da3eb3f: cdp: improved routing and removed useless warning/errors in authstatemachine
by Dragos Vingarzan 14 Jul '24

14 Jul '24

Module: kamailio Branch: master Commit: 0da3eb3f94c087b272ebbe19c42fd933146482f8 URL: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-14T11:46:17+02:00 cdp: improved routing and removed useless warning/errors in authstatemachine --- Modified: src/modules/cdp/authstatemachine.c Modified: src/modules/cdp/routing.c --- Diff: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93… Patch: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93…

1 0

[kamailio/kamailio] Outdated OpenSIPS Sources in Kamailio Project Lack Security Fixes (CVE-2023-28098) (Issue #3911)
by Garnik Khroyan 12 Jul '24

12 Jul '24

### Description The master branch of the Kamailio project contains unpatched sources from OpenSIPS, in which [CVE-2023-28098](https://github.com/OpenSIPS/opensips/security/advisories/GH… was reported. The function `parse_param_name()` from `kamailio/src/core/parser/digest/param_parser.c` does not include security patches and updates available in newer versions of OpenSIPS. The fix for CVE can be found in this commit: [OpenSIPS Commit dd9141b6](https://github.com/OpenSIPS/opensips/commit/dd9141b6f67d7df4072f3… ### Possible Solutions I strongly recommend updating the sources from OpenSIPS to the latest version available. ### Report Origin The bug is detected by a tool developed at [CAST](https://castech.am/). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3911 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3911(a)github.com>

2 4

[kamailio/kamailio] lib/ims: added cscf_get_host_from_requri (PR #3912)
by Dragos Vingarzan 12 Jul '24

12 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  On Mobile-Terminating, if the P-Called-Party-ID header is missing, getting the host (should also be an IP) from the Request-URI can help the P-CSCF when doing AAR for QoS. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3912 -- Commit Summary -- * lib/ims: added cscf_get_host_from_requri -- File Changes -- M src/lib/ims/ims_getters.c (15) M src/lib/ims/ims_getters.h (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3912.patch https://github.com/kamailio/kamailio/pull/3912.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3912 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3912(a)github.com>

1 1

git:master:70fd2717: lib/ims: added cscf_get_host_from_requri
by Dragos Vingarzan 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: 70fd27174952fe6a67f01fca4fdc941b9fdc045a URL: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-12T13:27:21+02:00 lib/ims: added cscf_get_host_from_requri --- Modified: src/lib/ims/ims_getters.c Modified: src/lib/ims/ims_getters.h --- Diff: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… Patch: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… --- diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c index cf2f618d0de..35dbdca405f 100644 --- a/src/lib/ims/ims_getters.c +++ b/src/lib/ims/ims_getters.c @@ -539,6 +539,21 @@ str cscf_get_contact_from_requri(struct sip_msg *msg) return pu; } +/** + * Get the host from the Request URI of the message. + * Useful for example on MT, to get the destination from the Request URI, if P-Called-Party-ID is not present. + */ +str cscf_get_host_from_requri(struct sip_msg *msg) +{ + if(msg->first_line.type != SIP_REQUEST || parse_sip_msg_uri(msg) < 0 + || msg->parsed_uri.type == TEL_URI_T) { + str empty = {0}; + return empty; + } + return msg->parsed_uri.host; +} + + /** * Finds if the message contains the orig parameter in the first Route header * @param msg - the SIP message diff --git a/src/lib/ims/ims_getters.h b/src/lib/ims/ims_getters.h index 77a55a6695b..03ad4bef82b 100644 --- a/src/lib/ims/ims_getters.h +++ b/src/lib/ims/ims_getters.h @@ -206,6 +206,12 @@ str cscf_get_public_identity_from_requri(struct sip_msg *msg); */ str cscf_get_contact_from_requri(struct sip_msg *msg); +/** + * Get the host from the Request URI of the message. + * Useful for example on MT, to get the destination from the Request URI, if P-Called-Party-ID is not present. + */ +str cscf_get_host_from_requri(struct sip_msg *msg); + /** * Looks for the Call-ID header * @param msg - the sip message

1 0

git:master:fc8bee5b: pua: use long for time value diff operation
by Daniel-Constantin Mierla 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: fc8bee5b87e95e43bda2635e65457b2025eab6f9 URL: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T12:05:40+02:00 pua: use long for time value diff operation --- Modified: src/modules/pua/pua.c --- Diff: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… Patch: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… --- diff --git a/src/modules/pua/pua.c b/src/modules/pua/pua.c index e57183427f3..a53bfd83963 100644 --- a/src/modules/pua/pua.c +++ b/src/modules/pua/pua.c @@ -1121,9 +1121,10 @@ static ua_pres_t *build_uppubl_cbparam(ua_pres_t *p) publ.pres_uri = p->pres_uri; publ.content_type = p->content_type; publ.id = p->id; - publ.expires = (p->desired_expires == 0) - ? -1 - : p->desired_expires - (int)time(NULL); + publ.expires = + (int)((p->desired_expires == 0) + ? -1 + : ((long)p->desired_expires - (long)time(NULL))); publ.flag = UPDATE_TYPE; publ.source_flag = p->flag; publ.event = p->event;

1 0

git:master:c9714586: rls: remove unnecessary assignment
by Daniel-Constantin Mierla 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: c97145862119e9001874cd07de9b20ad8e96ff54 URL: https://github.com/kamailio/kamailio/commit/c97145862119e9001874cd07de9b20a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T11:49:10+02:00 rls: remove unnecessary assignment --- Modified: src/modules/rls/resource_notify.c --- Diff: https://github.com/kamailio/kamailio/commit/c97145862119e9001874cd07de9b20a… Patch: https://github.com/kamailio/kamailio/commit/c97145862119e9001874cd07de9b20a… --- diff --git a/src/modules/rls/resource_notify.c b/src/modules/rls/resource_notify.c index c0b308a76d2..8fd388e463c 100644 --- a/src/modules/rls/resource_notify.c +++ b/src/modules/rls/resource_notify.c @@ -179,8 +179,8 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, str bstr = {0, 0}; subs_t *dialog = NULL; int len_est = 0; - int resource_added = - 0; /* Flag to indicate that we have added at least one resource */ + /* Flag to indicate that we have added at least one resource */ + int resource_added = 0; /* generate the boundary string */ boundary_string = generate_string(BOUNDARY_STRING_LEN); @@ -245,7 +245,6 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, len_est += 2 * strlen(boundary_string) + 4 + 102 + 2 + 50 + strlen(resource_uri) + 20; buf_len = 0; - resource_added = 0; /* !!!! for now I will include the auth state without checking if * it has changed - > in future check if it works */

1 0

git:master:214eaaa5: rtpengine: check fd before closing
by Daniel-Constantin Mierla 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: 214eaaa5b7a0308fd7384a41e97b1204d71c93de URL: https://github.com/kamailio/kamailio/commit/214eaaa5b7a0308fd7384a41e97b120… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T09:45:53+02:00 rtpengine: check fd before closing --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/214eaaa5b7a0308fd7384a41e97b120… Patch: https://github.com/kamailio/kamailio/commit/214eaaa5b7a0308fd7384a41e97b120… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 7b97a2ae1ee..8a2f6a08e8f 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -3770,7 +3770,8 @@ static char *send_rtpp_command( return cp; badproxy: - close(fd); + if(fd >= 0) + close(fd); return NULL; }

1 0

git:master:87e1a4a7: stun: check message len for response
by Daniel-Constantin Mierla 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: 87e1a4a7f5d565a59a362f22e9372697f2f2f2af URL: https://github.com/kamailio/kamailio/commit/87e1a4a7f5d565a59a362f22e937269… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T08:06:36+02:00 stun: check message len for response --- Modified: src/modules/stun/kam_stun.c --- Diff: https://github.com/kamailio/kamailio/commit/87e1a4a7f5d565a59a362f22e937269… Patch: https://github.com/kamailio/kamailio/commit/87e1a4a7f5d565a59a362f22e937269… --- diff --git a/src/modules/stun/kam_stun.c b/src/modules/stun/kam_stun.c index b3c1e7877d3..3ad42ff1636 100644 --- a/src/modules/stun/kam_stun.c +++ b/src/modules/stun/kam_stun.c @@ -512,6 +512,10 @@ static int stun_create_response(struct stun_msg *req, struct stun_msg *res, } } + if(res->msg.buf.len < sizeof(struct stun_hdr)) { + LM_ERR("invalid message\n"); + return FATAL_ERROR; + } res->hdr.len = htons(res->msg.buf.len - sizeof(struct stun_hdr)); memcpy(&res->msg.buf.s[sizeof(USHORT_T)], (void *)&res->hdr.len, sizeof(USHORT_T));

1 0

git:master:1e1ad4e7: sdpops: proper detect CR or LF
by Daniel-Constantin Mierla 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: 1e1ad4e74822881bb4d9cc2e9bd0f53e845bb48b URL: https://github.com/kamailio/kamailio/commit/1e1ad4e74822881bb4d9cc2e9bd0f53… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T08:01:37+02:00 sdpops: proper detect CR or LF --- Modified: src/modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1e1ad4e74822881bb4d9cc2e9bd0f53… Patch: https://github.com/kamailio/kamailio/commit/1e1ad4e74822881bb4d9cc2e9bd0f53… --- diff --git a/src/modules/sdpops/sdpops_mod.c b/src/modules/sdpops/sdpops_mod.c index f40062420a7..fb9abde6be5 100644 --- a/src/modules/sdpops/sdpops_mod.c +++ b/src/modules/sdpops/sdpops_mod.c @@ -2075,7 +2075,7 @@ int sdpops_attr_val(str *payload, str *attr, str *val) /* find EoL or EoData */ eline = sline; while(eline < payload->s + payload->len) { - if(*eline == '\r' || *eline == '\r') { + if(*eline == '\r' || *eline == '\n') { break; } eline++;

1 0

[kamailio/kamailio] ims_registrar_scscf: cannot build on Fedora 40 (Issue #3855)
by sergey-safarov 12 Jul '24

12 Jul '24

### Description "ims_registrar_scscf" cannot be compiled on Fedora 40 dist. ``` CC (gcc) [M ims_registrar_scscf.so] reply.o CC (gcc) [M ims_registrar_scscf.so] rerrno.o CC (gcc) [M ims_registrar_scscf.so] save.o CC (gcc) [M ims_registrar_scscf.so] server_assignment.o CC (gcc) [M ims_registrar_scscf.so] sip_msg.o CC (gcc) [M ims_registrar_scscf.so] stats.o CC (gcc) [M ims_registrar_scscf.so] userdata_parser.o userdata_parser.c: In function ‘ifc_tDefaultHandling2char’: userdata_parser.c:126:13: error: implicit declaration of function ‘strtol’; did you mean ‘strtok’? [-Wimplicit-function-declaration] 126 | r = strtol((char *)x, (char **)NULL, 10); | ^~~~~~ | strtok userdata_parser.c: In function ‘parse_spt_extension’: userdata_parser.c:411:32: error: implicit declaration of function ‘atoi’ [-Wimplicit-function-declaration] 411 | switch(atoi((char *)x)) { | ^~~~ make[2]: *** [../../Makefile.rules:100: userdata_parser.o] Error 1 make[1]: *** [Makefile:508: modules] Error 1 make[1]: Leaving directory '/root/rpmbuild/BUILD/kamailio-5.8.1/src' make: *** [Makefile:34: every-module] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.tyeQgK (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.tyeQgK (%build) ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` used modified 5.8.1 version ``` * **Operating System**: ``` [root@sbc-stage-a0 SPECS]# cat /etc/os-release NAME="Fedora Linux" VERSION="40 (Container Image)" ID=fedora VERSION_ID=40 VERSION_CODENAME="" PLATFORM_ID="platform:f40" PRETTY_NAME="Fedora Linux 40 (Container Image)" ANSI_COLOR="0;38;2;60;110;180" LOGO=fedora-logo-icon CPE_NAME="cpe:/o:fedoraproject:fedora:40" DEFAULT_HOSTNAME="fedora" HOME_URL="https://fedoraproject.org/" DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f40/system-administrators-guide/" SUPPORT_URL="https://ask.fedoraproject.org/" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_BUGZILLA_PRODUCT="Fedora" REDHAT_BUGZILLA_PRODUCT_VERSION=40 REDHAT_SUPPORT_PRODUCT="Fedora" REDHAT_SUPPORT_PRODUCT_VERSION=40 SUPPORT_END=2025-05-13 VARIANT="Container Image" VARIANT_ID=container ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3855 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3855(a)github.com>

2 3

[kamailio/kamailio] extented haproxy protocol support (PR #3731)
by sergey-safarov 12 Jul '24

12 Jul '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3667 #### Description Allow creating Record-Route and Via header using destination address and port in the haproxy protocol header. PR created behalf @ivanuschak You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3731 -- Commit Summary -- * core: extented haproxy protocol parser * rr: extented haproxy protocol suppport * path: extented haproxy protocol suppport * websocket: extented haproxy protocol suppport * siptrace: extented haproxy protocol suppport -- File Changes -- M src/core/forward.h (4) M src/core/msg_translator.c (137) M src/core/parser/msg_parser.h (1) M src/core/receive.c (6) M src/core/receive.h (3) M src/core/tcp_conn.h (1) M src/core/tcp_main.c (22) M src/core/tcp_read.c (20) M src/modules/path/path.c (2) M src/modules/rr/loose.c (4) M src/modules/rr/record.c (6) M src/modules/siptrace/siptrace.c (89) M src/modules/websocket/ws_frame.c (9) M src/modules/websocket/ws_handshake.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3731.patch https://github.com/kamailio/kamailio/pull/3731.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3731 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3731(a)github.com>

6 22

git:master:1c2b3361: tmx: t_precheck_trans() - explicit catch of internal return 0
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: 1c2b33615888dede0ea8abc098f6f910f810366b URL: https://github.com/kamailio/kamailio/commit/1c2b33615888dede0ea8abc098f6f91… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T21:30:33+02:00 tmx: t_precheck_trans() - explicit catch of internal return 0 --- Modified: src/modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1c2b33615888dede0ea8abc098f6f91… Patch: https://github.com/kamailio/kamailio/commit/1c2b33615888dede0ea8abc098f6f91… --- diff --git a/src/modules/tmx/tmx_mod.c b/src/modules/tmx/tmx_mod.c index 68b1e418c66..2e46c82a99a 100644 --- a/src/modules/tmx/tmx_mod.c +++ b/src/modules/tmx/tmx_mod.c @@ -921,7 +921,7 @@ static int t_precheck_trans(sip_msg_t *msg) ret = tmx_check_pretran(msg); if(ret > 0) return 1; - return (ret - 1); + return (ret == 0) ? -1 : ret; } /**

1 0

git:master:e2193b9c: htable: do not print item name before is computed
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: e2193b9cd7f59377c54e0424c0d4a1628a5a60de URL: https://github.com/kamailio/kamailio/commit/e2193b9cd7f59377c54e0424c0d4a16… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T19:38:24+02:00 htable: do not print item name before is computed --- Modified: src/modules/htable/ht_var.c --- Diff: https://github.com/kamailio/kamailio/commit/e2193b9cd7f59377c54e0424c0d4a16… Patch: https://github.com/kamailio/kamailio/commit/e2193b9cd7f59377c54e0424c0d4a16… --- diff --git a/src/modules/htable/ht_var.c b/src/modules/htable/ht_var.c index e79c7869ee5..4d7707f958b 100644 --- a/src/modules/htable/ht_var.c +++ b/src/modules/htable/ht_var.c @@ -38,8 +38,8 @@ int pv_get_ht_cell(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) if(hpv->ht == NULL) { hpv->ht = ht_get_table(&hpv->htname); if(hpv->ht == NULL) { - LM_ERR("htable not found for getting $sht(%.*s=>%.*s)\n", - hpv->htname.len, hpv->htname.s, htname.len, htname.s); + LM_ERR("htable not found for getting $sht(%.*s=>...)\n", + hpv->htname.len, hpv->htname.s); return pv_get_null(msg, param, res); } } @@ -77,8 +77,8 @@ int pv_set_ht_cell( if(hpv->ht == NULL) hpv->ht = ht_get_table(&hpv->htname); if(hpv->ht == NULL) { - LM_ERR("htable not found for setting $sht(%.*s=>%.*s)\n", - hpv->htname.len, hpv->htname.s, htname.len, htname.s); + LM_ERR("htable not found for setting $sht(%.*s=>...)\n", + hpv->htname.len, hpv->htname.s); return -1; }

1 0

git:master:0a9cb4bf: htable: updated duplicated rm op id
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: 0a9cb4bf74bf11af88e93c1512053008d94aff13 URL: https://github.com/kamailio/kamailio/commit/0a9cb4bf74bf11af88e93c151205300… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T19:31:23+02:00 htable: updated duplicated rm op id --- Modified: src/modules/htable/ht_api.h --- Diff: https://github.com/kamailio/kamailio/commit/0a9cb4bf74bf11af88e93c151205300… Patch: https://github.com/kamailio/kamailio/commit/0a9cb4bf74bf11af88e93c151205300… --- diff --git a/src/modules/htable/ht_api.h b/src/modules/htable/ht_api.h index f7bd8ed42c0..5ac11b9bb00 100644 --- a/src/modules/htable/ht_api.h +++ b/src/modules/htable/ht_api.h @@ -124,9 +124,9 @@ int ht_reset_content(ht_t *ht); #define HT_RM_OP_EQ 1 #define HT_RM_OP_NE 2 #define HT_RM_OP_SW 3 -#define HT_RM_OP_EW 3 -#define HT_RM_OP_RE 4 -#define HT_RM_OP_IN 5 +#define HT_RM_OP_EW 4 +#define HT_RM_OP_RE 5 +#define HT_RM_OP_IN 6 int ht_rm_cell_op(str *sre, ht_t *ht, int mode, int op); int ht_match_cell_op_str(str *sre, ht_t *ht, int mode, int op);

1 0

git:master:fffe7aae: core: counters - declare global cnts_no as unsigned short
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: fffe7aaecc41b8986eae342ce693bde87cdc20bc URL: https://github.com/kamailio/kamailio/commit/fffe7aaecc41b8986eae342ce693bde… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T15:50:48+02:00 core: counters - declare global cnts_no as unsigned short - it is used for counters h.id which is unsigned short --- Modified: src/core/counters.c --- Diff: https://github.com/kamailio/kamailio/commit/fffe7aaecc41b8986eae342ce693bde… Patch: https://github.com/kamailio/kamailio/commit/fffe7aaecc41b8986eae342ce693bde… --- diff --git a/src/core/counters.c b/src/core/counters.c index 5d9f26e5bce..dcf7ab7895e 100644 --- a/src/core/counters.c +++ b/src/core/counters.c @@ -83,9 +83,9 @@ static int grp_no = 0; /* number of groups */ /** counters array. a[proc_no][counter_id] => _cnst_vals[proc_no*cnts_no+counter_id] */ counter_array_t *_cnts_vals = 0; -int _cnts_row_len = 0; /* number of elements per row */ -static int cnts_no = 0; /* number of registered counters */ -static int cnts_max_rows = 0; /* set to 0 if not yet fully init */ +int _cnts_row_len = 0; /* number of elements per row */ +static unsigned short cnts_no = 0; /* number of registered counters */ +static int cnts_max_rows = 0; /* set to 0 if not yet fully init */ char *ksr_stats_namesep = KSR_STATS_NAMESEP;

1 0

git:master:d7466474: core: counters - init local global variables
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: d7466474bdc86b2b0d0872c5fd41d743ec1c7d66 URL: https://github.com/kamailio/kamailio/commit/d7466474bdc86b2b0d0872c5fd41d74… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T15:44:07+02:00 core: counters - init local global variables --- Modified: src/core/counters.c --- Diff: https://github.com/kamailio/kamailio/commit/d7466474bdc86b2b0d0872c5fd41d74… Patch: https://github.com/kamailio/kamailio/commit/d7466474bdc86b2b0d0872c5fd41d74… --- diff --git a/src/core/counters.c b/src/core/counters.c index 1a7d6637c17..5d9f26e5bce 100644 --- a/src/core/counters.c +++ b/src/core/counters.c @@ -70,22 +70,22 @@ struct grp_record /** hash table mapping a counter name to an id */ static struct str_hash_table cnts_hash_table; /** array mapping id 2 record */ -struct counter_record **cnt_id2record; -static int cnt_id2record_size; +struct counter_record **cnt_id2record = NULL; +static int cnt_id2record_size = 0; /** hash table for groups (maps a group name to a counter list) */ static struct str_hash_table grp_hash_table; /** array of groups, sorted */ -static struct grp_record **grp_sorted; -static int grp_sorted_max_size; -static int grp_sorted_crt_size; -static int grp_no; /* number of groups */ +static struct grp_record **grp_sorted = NULL; +static int grp_sorted_max_size = 0; +static int grp_sorted_crt_size = 0; +static int grp_no = 0; /* number of groups */ /** counters array. a[proc_no][counter_id] => _cnst_vals[proc_no*cnts_no+counter_id] */ counter_array_t *_cnts_vals = 0; -int _cnts_row_len; /* number of elements per row */ -static int cnts_no; /* number of registered counters */ -static int cnts_max_rows; /* set to 0 if not yet fully init */ +int _cnts_row_len = 0; /* number of elements per row */ +static int cnts_no = 0; /* number of registered counters */ +static int cnts_max_rows = 0; /* set to 0 if not yet fully init */ char *ksr_stats_namesep = KSR_STATS_NAMESEP;

1 0

git:master:48730820: core: action - logical OR for log() parameter types check
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: 487308204d2674368a16ea913137a368761dd0b2 URL: https://github.com/kamailio/kamailio/commit/487308204d2674368a16ea913137a36… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T15:27:37+02:00 core: action - logical OR for log() parameter types check --- Modified: src/core/action.c --- Diff: https://github.com/kamailio/kamailio/commit/487308204d2674368a16ea913137a36… Patch: https://github.com/kamailio/kamailio/commit/487308204d2674368a16ea913137a36… --- diff --git a/src/core/action.c b/src/core/action.c index bd75eacec33..62f2910d09b 100644 --- a/src/core/action.c +++ b/src/core/action.c @@ -511,8 +511,8 @@ int do_action(struct run_act_ctx *h, struct action *a, struct sip_msg *msg) } break; case LOG_T: - if((a->val[0].type != NUMBER_ST) | (a->val[1].type != STRING_ST)) { - LM_CRIT("bad log() types %d, %d\n", a->val[0].type, + if((a->val[0].type != NUMBER_ST) || (a->val[1].type != STRING_ST)) { + LM_CRIT("bad log() parameter types %d, %d\n", a->val[0].type, a->val[1].type); ret = E_BUG; goto error;

1 0

[kamailio/kamailio] core: Improved URN parsing according to RFC8141 (PR #3909)
by Nirv.Ana 11 Jul '24

11 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Improved URN parsing according to [RFC8141](https://datatracker.ietf.org/doc/html/rfc8141#section-2) that allows an arbitrary number of colons to be present in the URN value. Entire URN NID and NSS parts (except for `urn:` scheme) are stored in the `uri.host` struct field. `rq-components` are not supported. Example of the parse error when parsing "urn:emergency:service:sos" ``` parse_uri(): bad char ':' in state 3 parsed: urn:emergency:service (21) / urn:emergency:service:sos (25) ``` URN values that have been tested to work: - `urn:emergency:service:sos` - `urn:emergency:responder.fire` - `urn:emergency:media-feature` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3909 -- Commit Summary -- * core: Improved URN parsing according to RFC8141 -- File Changes -- M src/core/parser/parse_uri.c (48) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3909.patch https://github.com/kamailio/kamailio/pull/3909.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3909 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3909(a)github.com>

4 4

git:master:6cdd56bb: core: Improved URN parsing according to RFC8141
by Henning Westerholt 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: 6cdd56bb85e1a10ebbb29c2633fb47bf7b56585e URL: https://github.com/kamailio/kamailio/commit/6cdd56bb85e1a10ebbb29c2633fb47b… Author: anmartan <a.martin(a)zaleos.net> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-07-11T10:23:21+02:00 core: Improved URN parsing according to RFC8141 - Improved URN parsing to allow consuming URNs that contain 3 or more colons. Previosly URI parser treated some of the colons as separator between host and port causing the URN parsing to fail. --- Modified: src/core/parser/parse_uri.c --- Diff: https://github.com/kamailio/kamailio/commit/6cdd56bb85e1a10ebbb29c2633fb47b… Patch: https://github.com/kamailio/kamailio/commit/6cdd56bb85e1a10ebbb29c2633fb47b… --- diff --git a/src/core/parser/parse_uri.c b/src/core/parser/parse_uri.c index 9ccb62ee51e..4150c1598d6 100644 --- a/src/core/parser/parse_uri.c +++ b/src/core/parser/parse_uri.c @@ -237,28 +237,30 @@ int parse_uri(char *buf, int len, struct sip_uri *uri) } else \ goto error_bad_char -#define check_host_end \ - case ':': \ - /* found the host */ \ - uri->host.s = s; \ - uri->host.len = p - s; \ - state = URI_PORT; \ - s = p + 1; \ - break; \ - case ';': \ - uri->host.s = s; \ - uri->host.len = p - s; \ - state = URI_PARAM; \ - s = p + 1; \ - break; \ - case '?': \ - uri->host.s = s; \ - uri->host.len = p - s; \ - state = URI_HEADERS; \ - s = p + 1; \ - break; \ - case '&': \ - case '@': \ +#define check_host_end \ + case ':': \ + /* found the host */ \ + if(scheme != URN_SCH) { \ + uri->host.s = s; \ + uri->host.len = p - s; \ + state = URI_PORT; \ + s = p + 1; \ + } \ + break; \ + case ';': \ + uri->host.s = s; \ + uri->host.len = p - s; \ + state = URI_PARAM; \ + s = p + 1; \ + break; \ + case '?': \ + uri->host.s = s; \ + uri->host.len = p - s; \ + state = URI_HEADERS; \ + s = p + 1; \ + break; \ + case '&': \ + case '@': \ goto error_bad_char @@ -493,7 +495,7 @@ int parse_uri(char *buf, int len, struct sip_uri *uri) case '@': /* error no user part, or * be forgiving and accept it ? */ default: - state = URI_USER; + state = (scheme == URN_SCH) ? URI_HOST : URI_USER; } break; case URI_USER:

1 0

git:master:22880dbb: core: log message that #!endif requires EoL after it
by Daniel-Constantin Mierla 10 Jul '24

10 Jul '24

Module: kamailio Branch: master Commit: 22880dbb2171c2763b4df2731be49f208fde7e8c URL: https://github.com/kamailio/kamailio/commit/22880dbb2171c2763b4df2731be49f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-10T14:18:30+02:00 core: log message that #!endif requires EoL after it --- Modified: src/core/ppcfg.c --- Diff: https://github.com/kamailio/kamailio/commit/22880dbb2171c2763b4df2731be49f2… Patch: https://github.com/kamailio/kamailio/commit/22880dbb2171c2763b4df2731be49f2… --- diff --git a/src/core/ppcfg.c b/src/core/ppcfg.c index d77a237882b..407918aca72 100644 --- a/src/core/ppcfg.c +++ b/src/core/ppcfg.c @@ -281,6 +281,7 @@ void pp_ifdef_level_error(void) " %d more #!endif as #!if[n]def\n", (_pp_ifdef_level) * -1); } + LM_ERR("note: #!endif requires EoL after it, even before EoF\n"); } }

1 0

git:master:bd98aadf: corex: destroy nio_msg_avp avp after event_route[network:msg]
by Daniel-Constantin Mierla 10 Jul '24

10 Jul '24

Module: kamailio Branch: master Commit: bd98aadf9803c0c0789680d5ca781e86499f55cd URL: https://github.com/kamailio/kamailio/commit/bd98aadf9803c0c0789680d5ca781e8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-10T14:01:23+02:00 corex: destroy nio_msg_avp avp after event_route[network:msg] --- Modified: src/modules/corex/corex_nio.c --- Diff: https://github.com/kamailio/kamailio/commit/bd98aadf9803c0c0789680d5ca781e8… Patch: https://github.com/kamailio/kamailio/commit/bd98aadf9803c0c0789680d5ca781e8… --- diff --git a/src/modules/corex/corex_nio.c b/src/modules/corex/corex_nio.c index 03175926753..4069565b892 100644 --- a/src/modules/corex/corex_nio.c +++ b/src/modules/corex/corex_nio.c @@ -111,17 +111,24 @@ int nio_msg_received(sr_event_param_t *evp) avp = NULL; avp = search_first_avp( nio_msg_avp_type, nio_msg_avp_name, &avp_value, 0); - if(avp != NULL && is_avp_str_val(avp)) { - msg.buf = avp_value.s.s; - msg.len = avp_value.s.len; - nbuf = nio_msg_update(&msg, (unsigned int *)&obuf->len); - if(obuf->len >= BUF_SIZE) { - LM_ERR("new buffer overflow (%d)\n", obuf->len); - pkg_free(nbuf); - return -1; + if(avp != NULL) { + if(is_avp_str_val(avp)) { + msg.buf = avp_value.s.s; + msg.len = avp_value.s.len; + nbuf = nio_msg_update(&msg, (unsigned int *)&obuf->len); + if(obuf->len >= BUF_SIZE) { + LM_ERR("new buffer overflow (%d)\n", obuf->len); + pkg_free(nbuf); + return -1; + } + memcpy(obuf->s, nbuf, obuf->len); + obuf->s[obuf->len] = '\0'; + } else { + LM_WARN("invalid value tyoe for AVP %.*s, using unmodified " + "message\n", + nio_msg_avp_param.len, nio_msg_avp_param.s); } - memcpy(obuf->s, nbuf, obuf->len); - obuf->s[obuf->len] = '\0'; + destroy_avp(avp); } else { LM_WARN("no value set for AVP %.*s, using unmodified message\n", nio_msg_avp_param.len, nio_msg_avp_param.s); @@ -164,18 +171,25 @@ int nio_msg_sent(sr_event_param_t *evp) avp = NULL; avp = search_first_avp( nio_msg_avp_type, nio_msg_avp_name, &avp_value, 0); - if(avp != NULL && is_avp_str_val(avp)) { - msg.buf = avp_value.s.s; - msg.len = avp_value.s.len; - nbuf.s = nio_msg_update(&msg, (unsigned int *)&nbuf.len); - if(nbuf.s != NULL) { - LM_DBG("new outbound buffer generated\n"); - pkg_free(obuf->s); - obuf->s = nbuf.s; - obuf->len = nbuf.len; + if(avp != NULL) { + if(is_avp_str_val(avp)) { + msg.buf = avp_value.s.s; + msg.len = avp_value.s.len; + nbuf.s = nio_msg_update(&msg, (unsigned int *)&nbuf.len); + if(nbuf.s != NULL) { + LM_DBG("new outbound buffer generated\n"); + pkg_free(obuf->s); + obuf->s = nbuf.s; + obuf->len = nbuf.len; + } else { + LM_ERR("failed to generate new outbound buffer\n"); + } } else { - LM_ERR("failed to generate new outbound buffer\n"); + LM_WARN("invalid value type for AVP %.*s, using unmodified " + "message\n", + nio_msg_avp_param.len, nio_msg_avp_param.s); } + destroy_avp(avp); } else { LM_WARN("no value set for AVP %.*s, using unmodified message\n", nio_msg_avp_param.len, nio_msg_avp_param.s);

1 0

git:master:5697cb17: modules: readme files regenerated - ndb_redis ... [skip ci]
by Kamailio Dev 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 5697cb17d4d3dcb346b49c66cd3de265681051de URL: https://github.com/kamailio/kamailio/commit/5697cb17d4d3dcb346b49c66cd3de26… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-09T13:46:10+02:00 modules: readme files regenerated - ndb_redis ... [skip ci] --- Modified: src/modules/ndb_redis/README --- Diff: https://github.com/kamailio/kamailio/commit/5697cb17d4d3dcb346b49c66cd3de26… Patch: https://github.com/kamailio/kamailio/commit/5697cb17d4d3dcb346b49c66cd3de26… --- diff --git a/src/modules/ndb_redis/README b/src/modules/ndb_redis/README index 90071f5e3f0..3f180a1168e 100644 --- a/src/modules/ndb_redis/README +++ b/src/modules/ndb_redis/README @@ -135,7 +135,7 @@ Chapter 1. Admin Guide The following libraries or applications must be installed before running Kamailio with this module loaded: - * hiredis - available at https://github.com/antirez/hiredis . + * hiredis - available at https://github.com/redis/hiredis. 3. Parameters

1 0

git:master:501b7da6: ndb_redis: dpcs - updated link to hiredis library
by Daniel-Constantin Mierla 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 501b7da6daaff354b000837b54bdb591947ac80a URL: https://github.com/kamailio/kamailio/commit/501b7da6daaff354b000837b54bdb59… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-09T13:41:57+02:00 ndb_redis: dpcs - updated link to hiredis library --- Modified: src/modules/ndb_redis/doc/ndb_redis_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/501b7da6daaff354b000837b54bdb59… Patch: https://github.com/kamailio/kamailio/commit/501b7da6daaff354b000837b54bdb59… --- diff --git a/src/modules/ndb_redis/doc/ndb_redis_admin.xml b/src/modules/ndb_redis/doc/ndb_redis_admin.xml index 024b01315ac..85287118725 100644 --- a/src/modules/ndb_redis/doc/ndb_redis_admin.xml +++ b/src/modules/ndb_redis/doc/ndb_redis_admin.xml @@ -50,7 +50,7 @@ <listitem> <para> <emphasis>hiredis</emphasis> - available at - https://github.com/antirez/hiredis . + <ulink url="https://github.com/redis/hiredis">https://github.com/redis/hiredis</ulink>. </para> </listitem> </itemizedlist>

1 0

[kamailio/kamailio] WIP pkg: RPM packaging add kamailio-tls_wolfssl subpackage (PR #3592)
by space88man 09 Jul '24

09 Jul '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Not for merging yet. Package tls_wolfssl as an alternative to OpenSSL 3.x. Depends on PR https://github.com/kamailio/kamailio/pull/3590 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3592 -- Commit Summary -- * pkg: RPM packaging add kamailio-tls_wolfssl subpackage -- File Changes -- M pkg/kamailio/obs/kamailio.spec (18) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3592.patch https://github.com/kamailio/kamailio/pull/3592.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3592 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3592(a)github.com>

5 27

git:master:dc2008b2: modules: readme files regenerated - ims_qos ... [skip ci]
by Kamailio Dev 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: dc2008b29395f5e45dffd270b6aa74f0c0a9a0d2 URL: https://github.com/kamailio/kamailio/commit/dc2008b29395f5e45dffd270b6aa74f… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-09T09:31:10+02:00 modules: readme files regenerated - ims_qos ... [skip ci] --- Modified: src/modules/ims_qos/README Modified: src/modules/ims_registrar_pcscf/README --- Diff: https://github.com/kamailio/kamailio/commit/dc2008b29395f5e45dffd270b6aa74f… Patch: https://github.com/kamailio/kamailio/commit/dc2008b29395f5e45dffd270b6aa74f…

1 0

[kamailio/kamailio] ims_registrar_pcscf,ims_qos: support for trusting bottom via (PR #3901)
by Dragos Vingarzan 09 Jul '24

09 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to PR https://github.com/kamailio/kamailio/pull/3891 #### Description  Normally, the IMS P-CSCF should identify the clients (UEs) by the received IP address and ports on Rx. The current code is using a mix of that, plus using Contact and Via headers, with arguable potential security issues. This patch adds a new parameter to `ims_registrar_pcscf` and `ims_qos` modules, allowing for an optional outsource of the IPsec functionality to another element, which is also in charge of checking/enforcing correct UE Via header. The existing code is allowed to work as before, with the default value of the flag being towards that. List of functional changes: - `ims_qos` - added `trust_bottom_via` parameter - used it on `w_rx_aar_register()` - `ims_registrar_pcscf` - added `trust_bottom_via` parameter - used it on `update_contacts()`, `save_pending()`, `check_contact()`, `getContactP()`, `check_service_routes()`, `enforce_service_routes()` - made `ims_ipsec_pcscf` dependency optional, with checks when used - skipped checks of `port-uc` in `checkcontact()` if the `ims_ipsec_pcscf` module was not loaded - added `ignore_contact_rxproto_check` parameter - IMS devices open IPsec Security Associations just between IPs and ports, with both UDP and TCP protocols allowed. The default then was set here to always ignore protocol checks. Before, the `ignore_contact_rxport_check` was used to skip this and still make it work, but that seemed like a typo/mistake with hidden effects. List of indirect changes: - `core/ut.h`: added a `str2ushort()` macro, since code was using some dangerous casting and macros with a larger type - `ims_registrar_pcscf`: added `Route` headers in `SUBSCRIBE` to `reginfo`, with values from `Service-Route`s, as per 3GPP specs. - `ims_usrloc_pcscf`: small log fixes You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3901 -- Commit Summary -- * core: added str2ushort() to avoid some questionable casting in ims_qos * lib/ims: fixed a typo in a log message * ims_usrloc_pcscf: small log fixes * ims_qos: added trust_bottom_via parameter * ims_registrar_pcscf: added trust_bottom_via parameter, added ignore_contact_rxproto_check, fixes for logging, fixes for SUBSCRIBE to reginfo for including Service-Route, allow use without ims_ipsec_pcscf -- File Changes -- M src/core/ut.h (8) M src/lib/ims/ims_getters.c (2) M src/modules/ims_qos/doc/ims_qos.xml (6) M src/modules/ims_qos/doc/ims_qos_admin.xml (41) M src/modules/ims_qos/ims_qos_mod.c (27) M src/modules/ims_qos/rx_aar.h (4) M src/modules/ims_qos/rx_authdata.h (2) M src/modules/ims_qos/rx_avp.c (2) M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf.xml (6) M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml (73) M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (26) M src/modules/ims_registrar_pcscf/notify.c (2) M src/modules/ims_registrar_pcscf/save.c (80) M src/modules/ims_registrar_pcscf/service_routes.c (136) M src/modules/ims_registrar_pcscf/subscribe.c (74) M src/modules/ims_registrar_pcscf/subscribe.h (4) M src/modules/ims_usrloc_pcscf/udomain.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3901.patch https://github.com/kamailio/kamailio/pull/3901.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3901 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3901(a)github.com>

2 4

git:master:89830833: ims_registrar_pcscf: added trust_bottom_via parameter, added ignore_contact_rxproto_check, fixes for logging, fixes for SUBSCRIBE to reginfo for including Service-Route, allow use without ims_ipsec_pcscf
by Dragos Vingarzan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 898308334982b39d668410b51b90835b57b8a4c2 URL: https://github.com/kamailio/kamailio/commit/898308334982b39d668410b51b90835… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-09T09:22:36+02:00 ims_registrar_pcscf: added trust_bottom_via parameter, added ignore_contact_rxproto_check, fixes for logging, fixes for SUBSCRIBE to reginfo for including Service-Route, allow use without ims_ipsec_pcscf --- Modified: src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf.xml Modified: src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml Modified: src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c Modified: src/modules/ims_registrar_pcscf/notify.c Modified: src/modules/ims_registrar_pcscf/save.c Modified: src/modules/ims_registrar_pcscf/service_routes.c Modified: src/modules/ims_registrar_pcscf/subscribe.c Modified: src/modules/ims_registrar_pcscf/subscribe.h --- Diff: https://github.com/kamailio/kamailio/commit/898308334982b39d668410b51b90835… Patch: https://github.com/kamailio/kamailio/commit/898308334982b39d668410b51b90835…

1 0

git:master:d87d0328: ims_qos: added trust_bottom_via parameter
by Dragos Vingarzan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: d87d03285c83cded13a873338ec9cc6c2c55be30 URL: https://github.com/kamailio/kamailio/commit/d87d03285c83cded13a873338ec9cc6… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-09T09:22:36+02:00 ims_qos: added trust_bottom_via parameter --- Modified: src/modules/ims_qos/doc/ims_qos.xml Modified: src/modules/ims_qos/doc/ims_qos_admin.xml Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.h Modified: src/modules/ims_qos/rx_authdata.h Modified: src/modules/ims_qos/rx_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/d87d03285c83cded13a873338ec9cc6… Patch: https://github.com/kamailio/kamailio/commit/d87d03285c83cded13a873338ec9cc6…

1 0

git:master:9a87ec98: ims_usrloc_pcscf: small log fixes
by Dragos Vingarzan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 9a87ec98cf8aacc73b87846570202cbe69ebe837 URL: https://github.com/kamailio/kamailio/commit/9a87ec98cf8aacc73b87846570202cb… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-09T09:22:36+02:00 ims_usrloc_pcscf: small log fixes --- Modified: src/modules/ims_usrloc_pcscf/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/9a87ec98cf8aacc73b87846570202cb… Patch: https://github.com/kamailio/kamailio/commit/9a87ec98cf8aacc73b87846570202cb… --- diff --git a/src/modules/ims_usrloc_pcscf/udomain.c b/src/modules/ims_usrloc_pcscf/udomain.c index 5a4c5ba659e..248684cb00b 100644 --- a/src/modules/ims_usrloc_pcscf/udomain.c +++ b/src/modules/ims_usrloc_pcscf/udomain.c @@ -496,7 +496,7 @@ int get_pcontact_from_cache(udomain_t *_d, pcontact_info_t *contact_info, contact_info->aor.len, contact_info->aor.s); return 1; } - LM_DBG("checking for rinstance"); + LM_DBG("checking for rinstance\n"); /*check for alias - NAT */ params = needle_uri.sip_params.s; params_len = needle_uri.sip_params.len; @@ -548,7 +548,7 @@ int get_pcontact_from_cache(udomain_t *_d, pcontact_info_t *contact_info, int check2_passed = 0; ip_addr_t c_ip_addr; ip_addr_t ci_ip_addr; - LM_DBG("mached a record by aorhash: %u\n", aorhash); + LM_DBG("matched a record by aorhash: %u\n", aorhash); // convert 'contact->contact host' ip string to ip_addr_t if(str2ipxbuf(&c->contact_host, &c_ip_addr) < 0) {

1 0

git:master:f105bc50: lib/ims: fixed a typo in a log message
by Dragos Vingarzan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: f105bc507a8e63fd7f6e493265a39ab4b2cdf9b4 URL: https://github.com/kamailio/kamailio/commit/f105bc507a8e63fd7f6e493265a39ab… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-09T09:22:36+02:00 lib/ims: fixed a typo in a log message --- Modified: src/lib/ims/ims_getters.c --- Diff: https://github.com/kamailio/kamailio/commit/f105bc507a8e63fd7f6e493265a39ab… Patch: https://github.com/kamailio/kamailio/commit/f105bc507a8e63fd7f6e493265a39ab… --- diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c index c752f08eef1..cf2f618d0de 100644 --- a/src/lib/ims/ims_getters.c +++ b/src/lib/ims/ims_getters.c @@ -1638,7 +1638,7 @@ str *cscf_get_service_route(struct sip_msg *msg, int *size, int is_shm) } x = pkg_reallocxf(x, (*size + k) * sizeof(str)); if(!x) { - LM_ERR("Error our of pkg memory"); + LM_ERR("Error out of pkg memory"); return 0; } r2 = r;

1 0

git:master:cc376804: core: added str2ushort() to avoid some questionable casting in ims_qos
by Dragos Vingarzan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: cc376804ef2bb5064bbff9e3c963a5d9222568b3 URL: https://github.com/kamailio/kamailio/commit/cc376804ef2bb5064bbff9e3c963a5d… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-09T09:22:36+02:00 core: added str2ushort() to avoid some questionable casting in ims_qos --- Modified: src/core/ut.h --- Diff: https://github.com/kamailio/kamailio/commit/cc376804ef2bb5064bbff9e3c963a5d… Patch: https://github.com/kamailio/kamailio/commit/cc376804ef2bb5064bbff9e3c963a5d… --- diff --git a/src/core/ut.h b/src/core/ut.h index 1efd7abd242..aa51108229b 100644 --- a/src/core/ut.h +++ b/src/core/ut.h @@ -700,6 +700,14 @@ static inline int str2int(str *_s, unsigned int *_r) str2unval(_s, _r, int, UINT_MAX); } +/* + * Convert a str to unsigned short + */ +static inline int str2ushort(str *_s, unsigned short *_r) +{ + str2unval(_s, _r, short, USHRT_MAX); +} + #define str2snval(_s, _r, _vtype, _vmin, _vmax) \ do { \

1 0

git:5.8:dbe51dc4: db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x
by S-P Chan 09 Jul '24

09 Jul '24

Module: kamailio Branch: 5.8 Commit: dbe51dc4ee53f6e4f00450745db709a9d741c481 URL: https://github.com/kamailio/kamailio/commit/dbe51dc4ee53f6e4f00450745db709a… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-09T13:40:05+08:00 db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x - MYSQL_OPT_SSL_CA is an enum not a macro - base check on MYSQL_VERSION_ID - 50568 used in CentOS 7 Addresses #3910 (cherry-picked from commit 92cfedaaffb034db536f3bcf68695b433db92706) --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/dbe51dc4ee53f6e4f00450745db709a… Patch: https://github.com/kamailio/kamailio/commit/dbe51dc4ee53f6e4f00450745db709a… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 240d3f59a76..37508ce24c0 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -179,14 +179,14 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #endif /* MYSQL_VERSION_ID */ #endif /* MARIADB_BASE_VERSION */ -#ifdef MYSQL_OPT_SSL_CA +#if(MYSQL_VERSION_ID >= 50600) if(db_mysql_opt_ssl_ca) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " + LM_DBG("opt_ssl_ca option not supported by mysql version (value %d) - " "ignoring\n", - db_mysql_opt_ssl_ca); + MYSQL_VERSION_ID); #endif /* MYSQL_OPT_SSL_CA */ #ifdef KSR_MYSQL_OPT_RECONNECT

1 0

git:master:92cfedaa: db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x
by S-P Chan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 92cfedaaffb034db536f3bcf68695b433db92706 URL: https://github.com/kamailio/kamailio/commit/92cfedaaffb034db536f3bcf68695b4… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-09T10:53:07+08:00 db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x - MYSQL_OPT_SSL_CA is an enum not a macro - base check on MYSQL_VERSION_ID - 50568 used in CentOS 7 Addresses #3910 --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/92cfedaaffb034db536f3bcf68695b4… Patch: https://github.com/kamailio/kamailio/commit/92cfedaaffb034db536f3bcf68695b4… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 240d3f59a76..37508ce24c0 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -179,14 +179,14 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #endif /* MYSQL_VERSION_ID */ #endif /* MARIADB_BASE_VERSION */ -#ifdef MYSQL_OPT_SSL_CA +#if(MYSQL_VERSION_ID >= 50600) if(db_mysql_opt_ssl_ca) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " + LM_DBG("opt_ssl_ca option not supported by mysql version (value %d) - " "ignoring\n", - db_mysql_opt_ssl_ca); + MYSQL_VERSION_ID); #endif /* MYSQL_OPT_SSL_CA */ #ifdef KSR_MYSQL_OPT_RECONNECT

1 0

git:master:0fc0c7b3: Revert "db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x"
by S-P Chan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 0fc0c7b3d3d6ded300c46f504406447670fee4e8 URL: https://github.com/kamailio/kamailio/commit/0fc0c7b3d3d6ded300c46f504406447… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-09T10:50:14+08:00 Revert "db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x" This reverts commit 5b2be5e2c716ad8f8502b3be3db5194eb8474d39. The commit should check >= not < --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/0fc0c7b3d3d6ded300c46f504406447… Patch: https://github.com/kamailio/kamailio/commit/0fc0c7b3d3d6ded300c46f504406447… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 21ac5023c81..240d3f59a76 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -179,15 +179,15 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #endif /* MYSQL_VERSION_ID */ #endif /* MARIADB_BASE_VERSION */ -#if(MYSQL_VERSION_ID < 50600) +#ifdef MYSQL_OPT_SSL_CA if(db_mysql_opt_ssl_ca) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_DBG("opt_ssl_ca option not supported by mysql version (value %s:%d) - " + LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " "ignoring\n", - MYSQL_SERVER_VERSION, MYSQL_VERSION_ID); -#endif /* MYSQL_VERSION_ID */ + db_mysql_opt_ssl_ca); +#endif /* MYSQL_OPT_SSL_CA */ #ifdef KSR_MYSQL_OPT_RECONNECT /* set reconnect flag if enabled */

1 0

[kamailio/kamailio] [db_mysql] MYSQL_OPT_SSL_CA is an enum not a macro (Issue #3910)
by space88man 09 Jul '24

09 Jul '24

### Description Recent commit ``` d53843c75da src/modules/db_mysql/km_my_con.c (Sergey Safarov 2024-05-11 17:45:08 +0300 182) #ifdef MYSQL_OPT_SSL_CA ``` breaks db_mysql on 5.8.2 ``` Jul 09 08:40:31 voip-ssl3.voip.test /usr/local/kamailio/sbin/kamailio[10982]: WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value /etc/pki/tls/certs/ca-cert.pem) - ignoring Jul 09 08:40:31 voip-ssl3.voip.test /usr/local/kamailio/sbin/kamailio[10982]: ERROR: db_mysql [km_my_con.c:217]: db_mysql_new_connection(): driver error: SSL connection error: CA certificate is required if ssl-mode is VERIFY_CA or VERIFY_IDENTITY ``` Ping @sergey-safarov ### Troubleshooting #### Reproduction * use 5.8.2 * configure `db_mysql` to use TLS with verification #### Debugging Data #### Log Messages ``` Jul 09 08:40:31 voip-ssl3.voip.test /usr/local/kamailio/sbin/kamailio[10982]: WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value /etc/pki/tls/certs/ca-cert.pem) - ignoring Jul 09 08:40:31 voip-ssl3.voip.test /usr/local/kamailio/sbin/kamailio[10982]: ERROR: db_mysql [km_my_con.c:217]: db_mysql_new_connection(): driver error: SSL connection error: CA certificate is required if ssl-mode is VERIFY_CA or VERIFY_IDENTITY ``` ### Additional Information * **Kamailio Version** - 5.8.2 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3910 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3910(a)github.com>

1 2

git:master:5b2be5e2: db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x
by S-P Chan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 5b2be5e2c716ad8f8502b3be3db5194eb8474d39 URL: https://github.com/kamailio/kamailio/commit/5b2be5e2c716ad8f8502b3be3db5194… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-09T10:38:44+08:00 db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x - MYSQL_OPT_SSL_CA is an enum not a macro - base check on MYSQL_VERSION_ID - 50568 used in CentOS 7 Addresses #3910 --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/5b2be5e2c716ad8f8502b3be3db5194… Patch: https://github.com/kamailio/kamailio/commit/5b2be5e2c716ad8f8502b3be3db5194… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 240d3f59a76..21ac5023c81 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -179,15 +179,15 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #endif /* MYSQL_VERSION_ID */ #endif /* MARIADB_BASE_VERSION */ -#ifdef MYSQL_OPT_SSL_CA +#if(MYSQL_VERSION_ID < 50600) if(db_mysql_opt_ssl_ca) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " + LM_DBG("opt_ssl_ca option not supported by mysql version (value %s:%d) - " "ignoring\n", - db_mysql_opt_ssl_ca); -#endif /* MYSQL_OPT_SSL_CA */ + MYSQL_SERVER_VERSION, MYSQL_VERSION_ID); +#endif /* MYSQL_VERSION_ID */ #ifdef KSR_MYSQL_OPT_RECONNECT /* set reconnect flag if enabled */

1 0

[kamailio/kamailio] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)
by Dragos Vingarzan 08 Jul '24

08 Jul '24

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - Not yet - first let's see if the work is valid, then I'll recompose the whole work to satisfy this. Otherwise... if I need to fix something, it's too hard to work like this... - [ ] Each component has a single commit (if not, squash them into one commit) - ditto - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Normally, the IMS P-CSCF should identify the clients (UEs) by the received IP address and ports on Rx. The current code is using a mix of that, plus using Contact and Via headers, with arguable potential security issues. This patch adds a new parameter to `ims_registrar_pcscf` and `ims_qos` modules, allowing for an optional outsource of the IPsec functionality to another element, which is also in charge of checking/enforcing correct UE Via header. The existing code is allowed to work as before, with the default value of the flag being towards that. List of functional changes: - `ims_qos` - added `trust_bottom_via` parameter - List of indirect changes: - default I-CSCF config example contained a questionable line which adds a `+` as a prefix in Request-URI. After way too much time wasted to figure out why the Diameter LIR has bogus SIP or TEL URI values in UserName AVP, I have discovered this. Seems like someone had just tel-URIs in their network, but otherwise the blind addition of this prefix makes no sense to me. - added a `str2ushort()` macro, since code was using some dangerous casting and macros with a larger type - List of non-functional fixes: - spelling in comments - comments at the end of line moved above the line they refer to; with just 80 columns code-formatting, commenting on the same line provides for some super weird and hard to read code, so IMHO should not be allowed (or ... much harder now... increase to 120 columns) - You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3891 -- Commit Summary -- * squashed work -- File Changes -- M misc/examples/ims/icscf/kamailio.cfg (4) M src/core/ut.h (36) M src/lib/ims/ims_getters.c (2) M src/modules/ims_icscf/location.c (10) M src/modules/ims_qos/ims_qos_mod.c (27) M src/modules/ims_qos/ims_qos_mod.h (1) M src/modules/ims_qos/rx_aar.h (4) M src/modules/ims_qos/rx_authdata.h (2) M src/modules/ims_qos/rx_avp.c (2) M src/modules/ims_qos/rx_avp.h (1) M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml (39) M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (18) M src/modules/ims_registrar_pcscf/notify.c (2) M src/modules/ims_registrar_pcscf/save.c (78) M src/modules/ims_registrar_pcscf/service_routes.c (125) M src/modules/ims_registrar_pcscf/subscribe.c (75) M src/modules/ims_registrar_pcscf/subscribe.h (4) M src/modules/ims_usrloc_pcscf/udomain.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3891.patch https://github.com/kamailio/kamailio/pull/3891.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3891 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3891(a)github.com>

2 20

[kamailio/kamailio] Base58 not decoding correctly (Issue #3907)
by duarterocha91 08 Jul '24

08 Jul '24

### Description When doing base58 encoding and decoding there is some issue with the decoded string. Here is my code to ilustrate the issue : $var(Test) = "test_string"; $var(Test) = $(var(Test){s.encode.base58}); xerr("Test String encoded = STRING_BEGIN$var(Test)STRING_END"); $var(Test) = $(var(Test){s.decode.base58}); xerr("Test String decoded = STRING_BEGIN$var(Test)STRING_END"); It has the following output : ![image](https://github.com/kamailio/kamailio/assets/28625449/f9b10fd3-6e75-4368-9abd-005d44cc1235) I've inserted STRING_BEGIN and STRING_END in the log to be able to know when string ends. After this i've tried to user {s.trim} method with no success. I've noticed that despite not printing correctly, the string's length is calculated correctly, so i did a manual substring and was able to fix it. xerr("Test Base58"); $var(Test) = "test_string"; $var(Test) = $(var(Test){s.encode.base58}); xerr("Test String encoded = STRING_BEGIN$var(Test)STRING_END"); $var(Test) = $(var(Test){s.decode.base58}); xerr("Test String decoded = STRING_BEGIN$var(Test)STRING_END"); $var(Test) = $(var(Test){s.trim}); xerr("Test String decoded and trimmed = STRING_BEGIN$var(Test)STRING_END"); $var(substring_length) = $(var(Test){s.len}) - 1; $var(Test) = $(var(Test){s.substr,0,$var(substring_length)}); xerr("Test String decoded and fixed = STRING_BEGIN$var(Test)STRING_END"); Output : ![image](https://github.com/kamailio/kamailio/assets/28625449/9a100c45-4671-4381-9ddf-3a1c8c9404ee) All of this doesn't happen with method for base64 for example ### Additional Information version: kamailio 5.7.1 (x86_64/linux) 4238e4 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 4238e4 compiled on 12:39:30 Jun 29 2023 with gcc 4.8.5 * **Operating System**: CentOS 7 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3907 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3907(a)github.com>

2 2

git:master:9d923764: core: basex - compute lenght for base58 decode
by Daniel-Constantin Mierla 08 Jul '24

08 Jul '24

Module: kamailio Branch: master Commit: 9d923764747ff36152fc930da66e972201516b7b URL: https://github.com/kamailio/kamailio/commit/9d923764747ff36152fc930da66e972… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-08T12:08:13+02:00 core: basex - compute lenght for base58 decode - GH #3907 --- Modified: src/core/basex.c --- Diff: https://github.com/kamailio/kamailio/commit/9d923764747ff36152fc930da66e972… Patch: https://github.com/kamailio/kamailio/commit/9d923764747ff36152fc930da66e972… --- diff --git a/src/core/basex.c b/src/core/basex.c index a112ce77adb..2871afa22ee 100644 --- a/src/core/basex.c +++ b/src/core/basex.c @@ -412,7 +412,7 @@ char *b58_decode(char *outb, int *outbszp, char *b58, int b58sz) break; --*outbszp; } - *outbszp += zerocount; + *outbszp = strlen(outb + i); return outb + i; }

1 0

[kamailio/kamailio] kamailio 5.7.6 startup (Issue #3908)
by alekamailio 08 Jul '24

08 Jul '24

Hello, Upgraded the kamailio version from 5.7.5 to 5.7.6 and after restart the service got the follow WARNING, WARNING: db_mysql [km_my_con.c:179]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value (null)) - ignoring, when downgrade to 5.7.5 dindt happend. Thanks -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3908 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3908(a)github.com>

2 2

git:5.7:184aaf99: db_mysql: switch warn to dbg for log messages for opt_ssl_ca option
by Daniel-Constantin Mierla 08 Jul '24

08 Jul '24

Module: kamailio Branch: 5.7 Commit: 184aaf991b6ad74b63a7f8724058cd4066f3bbd3 URL: https://github.com/kamailio/kamailio/commit/184aaf991b6ad74b63a7f8724058cd4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-07T09:35:36+02:00 db_mysql: switch warn to dbg for log messages for opt_ssl_ca option fixes #3884 (cherry picked from commit be5172a84b02a1ab4fc7e97e7dc0813056302bdd) (cherry picked from commit 4c75991aa662bddc1bbe65c83f7861cb72a65a61) --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/184aaf991b6ad74b63a7f8724058cd4… Patch: https://github.com/kamailio/kamailio/commit/184aaf991b6ad74b63a7f8724058cd4… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 8534ac0a156..d6c7a43bdac 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -174,8 +174,8 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_WARN("opt_ssl_ca option not supported by mysql version (value %s) - " - "ignoring\n", + LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " + "ignoring\n", db_mysql_opt_ssl_ca); #endif /* MYSQL_OPT_SSL_CA */

1 0

git:5.7:64f0c3f3: db_mysql: switch warn to dbg for log messages for opt_ssl_mode
by Daniel-Constantin Mierla 08 Jul '24

08 Jul '24

Module: kamailio Branch: 5.7 Commit: 64f0c3f3979de7a40732067792d89c6d3b1c23d4 URL: https://github.com/kamailio/kamailio/commit/64f0c3f3979de7a40732067792d89c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-07T09:35:27+02:00 db_mysql: switch warn to dbg for log messages for opt_ssl_mode - GH #3884 (cherry picked from commit 8f98317e92da61160a1c416e0da45938a205d358) (cherry picked from commit 7360ab7fbe672259c7433b1a5199467d24183d79) --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/64f0c3f3979de7a40732067792d89c6… Patch: https://github.com/kamailio/kamailio/commit/64f0c3f3979de7a40732067792d89c6… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 04982292673..8534ac0a156 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -133,7 +133,7 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #if MYSQL_VERSION_ID >= 100339 mysql_options(ptr->con, MYSQL_OPT_SSL_ENFORCE, (void *)&(int){1}); #else - LM_WARN("ssl mode not supported by %s\n", MARIADB_BASE_VERSION); + LM_DBG("ssl mode not supported by %s\n", MARIADB_BASE_VERSION); #endif break; case 5: /* SSL_MODE_VERIFY_IDENTITY */ @@ -141,7 +141,7 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) (void *)&(int){1}); break; default: - LM_WARN("opt_ssl_mode = %d not supported by MariaDB Connector/C\n", + LM_DBG("opt_ssl_mode = %d not supported by MariaDB Connector/C\n", db_mysql_opt_ssl_mode); break; }

1 0

[kamailio/kamailio] performance regression related to new TCP connection tracking feature with a high number of connections (Issue #3759)
by Henning Westerholt 05 Jul '24

05 Jul '24

### Description On systems with a high number of TCP sessions there can be a significant performance regression observed, probably related to the newly added TCP connection tracking feature. ### Troubleshooting #### Reproduction No special configuration is necessary, just install the latest 5.7.x release, e.g. 5.7.3 on a production system with a lot of clients connected over TCP or TLS. You need to have a large number of clients connected to be able to observe the regression. For a high number of connections (e.g. more then 20.000 up to 30.000 connections) the Kamailio servers uses about 30% to 50% more CPU as with the old version. #### Debugging Data Two graphs were attached to this issue. The first shows the CPU load before (less load) and after the upgrade (increased load). The second is a flamegraph that shows that over 80% of the CPU time is spent in the newly added function tcp_connection_limit_srcip(). <img width="372" alt="cpu-load-before-after" src="https://github.com/kamailio/kamailio/assets/6481937/ec92c41b-25e2-4847-a4bc…"> ![flamegraph](https://github.com/kamailio/kamailio/assets/6481937/5c2e3982-2d5b-4acd-a774-bad8fa64bd0a) Most of the CPU time is spend in the TCP main process, as expected. #### Log Messages No special log messages could be observed. #### SIP Traffic ### Possible Solutions The TCP limit feature should probably be optimized to not cause such a large performance regression. It should be also possible to deactivate it completly and therefore getting a comparable performance as before the feature addition. ### Additional Information Kamailio 5.7.3 and probably also git master version. * **Operating System**: Debian 11, Debian 12 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3759 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3759(a)github.com>

2 6

[kamailio/kamailio] tcpops module event_route[tcp:closed] route block $conid is null (Issue #3767)
by liangbaolin 05 Jul '24

05 Jul '24

### Description During the process of using version 5.7.4 of Kamailio, I found that the $conid cannot be correctly obtained in the TCP: closed routing block of the TCP module event_route. I am certain that it is normal in version 5.4.8. ### Troubleshooting ``` pv [pv_core.c:2725]: pv_get_tcpconn_id() ``` #### Reproduction The test scenario initiated a register registration process for me, and after completing the disconnection of the TCP connection, triggered this event. #### Log Messages  ``` 2024-02-26T01:35:55.902002512Z 52(98) DEBUG: <core> [core/receive.c:635]: receive_msg(): cleaning up 2024-02-26T01:35:55.902034482Z 52(98) DEBUG: <core> [core/tcp_read.c:280]: tcp_read_data(): EOF on connection 0x7f99a1546a80 (state: 0, flags: c018) - FD 24, bytes 0, rd-flags 10000 ([12.0.1.6]:15821 -> [12.0.1.6]:5060)52(98) DEBUG: <core> [core/tcp_read.c:343]: tcp_read(): read 0 bytes: 2024-02-26T01:35:55.902051542Z 2024-02-26T01:35:55.902058282Z 52(98) DEBUG: <core> [core/tcp_read.c:1532]: tcp_read_req(): read= 0 bytes, parsed=0, state=0, error=1 2024-02-26T01:35:55.902063282Z 52(98) DEBUG: <core> [core/tcp_read.c:1534]: tcp_read_req(): last char=0x00, parsed msg= 2024-02-26T01:35:55.902069402Z 2024-02-26T01:35:55.902074032Z 52(98) DEBUG: <core> [core/tcp_read.c:1544]: tcp_read_req(): EOF 2024-02-26T01:35:55.902101372Z 52(98) DEBUG: <core> [core/io_wait.h:598]: io_watch_del(): DBG: io_watch_del (0x559e8a029740, 24, -1, 0x10) fd_no=2 called 2024-02-26T01:35:55.902153162Z 52(98) DEBUG: <core> [core/tcp_read.c:1927]: handle_io(): removing from list 0x7f99a1546a80 id 2 fd 24, state 2, flags c018, main fd 134, refcnt 2 ([12.0.1.6]:15821 -> [12.0.1.6]:5060) 2024-02-26T01:35:55.902168112Z 52(98) DEBUG: <core> [core/tcp_read.c:1702]: release_tcpconn(): releasing con 0x7f99a1546a80, state -1, fd=24, id=2 ([12.0.1.6]:15821 -> [12.0.1.6]:5060) 2024-02-26T01:35:55.902173372Z 52(98) DEBUG: <core> [core/tcp_read.c:1705]: release_tcpconn(): extra_data (nil) 2024-02-26T01:35:55.902208402Z 83(129) DEBUG: <core> [core/tcp_main.c:3747]: handle_tcp_child(): reader response= 7f99a1546a80, -1 from 1 2024-02-26T01:35:55.902224742Z 83(129) DEBUG: <core> [core/tcp_main.c:3904]: handle_tcp_child(): case CONN_EOF tcp_emit_closed_event before 5 2024-02-26T01:35:55.902229802Z 83(129) DEBUG: <core> [core/tcp_main.c:3671]: tcp_emit_closed_event(): TCP closed event creation triggered (reason: 0) 2024-02-26T01:35:55.902318572Z 83(129) DEBUG: tcpops [tcpops.c:311]: tcpops_handle_tcp_closed(): received TCP closed event 2024-02-26T01:35:55.902331352Z 83(129) DEBUG: tcpops [tcpops.c:261]: tcpops_tcp_closed_run_route(): event reason id: 0 rt: 1 2024-02-26T01:35:55.902335132Z 83(129) ERROR: tcpops [tcpops.c:278]: tcpops_tcp_closed_run_route(): run_top_route() before tev->id: 2 2024-02-26T01:35:55.902480972Z 83(129) DEBUG: <core> [core/tcp_main.c:1713]: _tcpconn_find(): 2 port 0 2024-02-26T01:35:55.902493872Z 83(129) DEBUG: pv [pv_core.c:2725]: pv_get_tcpconn_id(): no conid 2024-02-26T01:35:55.902498762Z 83(129) DEBUG: pv [pv_core.c:2726]: pv_get_tcpconn_id(): msg->rcv.proto_reserved1: 2 2024-02-26T01:35:55.902503592Z 83(129) DEBUG: <core> [core/tcp_main.c:1713]: _tcpconn_find(): 2 port 0 2024-02-26T01:35:55.902508262Z 83(129) DEBUG: <core> [core/pvapi.c:1418]: pv_printf_mode(): final buffer length 111 2024-02-26T01:35:55.902513422Z 83(129) ERROR: <script>: tcp connection closed conid: (<null>), tcp(conid): <null>, Ri: 12.0.1.185, Rp: 5060 , si: 12.0.1.6 , sp: 15821 2024-02-26T01:35:55.902607692Z 83(129) DEBUG: <core> [core/tcp_main.c:1713]: _tcpconn_find(): 2 port 0 2024-02-26T01:35:55.902625622Z 83(129) DEBUG: pv [pv_core.c:2725]: pv_get_tcpconn_id(): no conid 2024-02-26T01:35:55.902630672Z 83(129) DEBUG: pv [pv_core.c:2726]: pv_get_tcpconn_id(): msg->rcv.proto_reserved1: 2 2024-02-26T01:35:55.902635822Z 83(129) ERROR: tcpops [tcpops.c:280]: tcpops_tcp_closed_run_route(): run_top_route() after tev->id: 2 2024-02-26T01:35:58.777642759Z 41(87) DEBUG: ims_dialog [dlg_handlers.c:2026]: print_all_dlgs(): ********************41(87) DEBUG: ims_dialog [dlg_handlers.c:2027]: print_all_dlgs(): printing 65536 dialogs ``` #### SIP Traffic  ``` my test script block event_route[tcp:closed] { xlog("L_ERR", "$proto connection closed conid: ($conid), tcp(conid): $tcp(conid), Ri: $Ri, Rp: $Rp , si: $si , sp: $sp\n"); } file: src/modules/pv/pv_core.c int pv_get_tcpconn_id(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { ... if((con = tcpconn_get(msg->rcv.proto_reserved1, 0, 0, 0, 0)) == NULL) // return false { LM_DBG("no conid\n"); //additional custom log LM_DBG("msg->rcv.proto_reserved1: %d\n",msg->rcv.proto_reserved1); return pv_get_null(msg, param, res); } .... } file: src/core/tcp_main.c struct tcp_connection *tcpconn_lookup(int id, struct ip_addr *ip, int port, union sockaddr_union *local_addr, int try_local_port, ticks_t timeout) { ... if(unlikely(c == NULL)) { c = _tcpconn_find(id, ip, port, &local_ip, local_port); // retrun c == null } ... } struct tcp_connection *_tcpconn_find( int id, struct ip_addr *ip, int port, struct ip_addr *l_ip, int l_port) { ... if(likely(id)) { hash = tcp_id_hash(id); for(c = tcpconn_id_hash[hash]; c; c = c->id_next) { //tcpconn_id_hash find c is null #ifdef EXTRA_DEBUG LM_DBG("c=%p, c->id=%d, port=%d\n", c, c->id, c->rcv.src_port); print_ip("ip=", &c->rcv.src_ip, "\n"); #endif .... } inline static int tcpconn_try_unhash(struct tcp_connection *tcpconn) { ... _tcpconn_detach(tcpconn); //executed ... lock_release(&tcpconn->write_lock); ... } static inline void _tcpconn_detach(struct tcp_connection *c) { ... tcpconn_listrm(tcpconn_id_hash[c->id_hash], c, id_next, id_prev); //remove c ... } ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) 9920d9-dirty flags: , EXTRA_DEBUGUSE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 9920d9 -dirty compiled on 09:59:52 Feb 26 2024 with gcc 7.5.0 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3767 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3767(a)github.com>

5 8

git:master:6f434afc: ndb_redis: larger size for buffers to create server specs on cluster redirect
by Daniel-Constantin Mierla 05 Jul '24

05 Jul '24

Module: kamailio Branch: master Commit: 6f434afc414b7f5b66374a124138990f7a3dd1d1 URL: https://github.com/kamailio/kamailio/commit/6f434afc414b7f5b66374a124138990… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-05T11:47:34+02:00 ndb_redis: larger size for buffers to create server specs on cluster redirect - GH #3894 --- Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/kamailio/commit/6f434afc414b7f5b66374a124138990… Patch: https://github.com/kamailio/kamailio/commit/6f434afc414b7f5b66374a124138990… --- diff --git a/src/modules/ndb_redis/redis_client.c b/src/modules/ndb_redis/redis_client.c index cba94a38c06..74df8efda0b 100644 --- a/src/modules/ndb_redis/redis_client.c +++ b/src/modules/ndb_redis/redis_client.c @@ -886,11 +886,11 @@ int redisc_exec_pipelined(redisc_server_t *rsrv) int check_cluster_reply(redisReply *reply, redisc_server_t **rsrv) { redisc_server_t *rsrv_new; - char buffername[100]; + char buffername[512]; unsigned int port; str addr = {0, 0}, tmpstr = {0, 0}, name = {0, 0}; int server_len = 0; - char spec_new[100]; + char spec_new[512]; if(redis_cluster_param) { LM_DBG("Redis replied: \"%.*s\"\n", (int)reply->len, reply->str);

1 0

git:master:4d2988a7: ndb_redis: print server spec lenght in error message
by Daniel-Constantin Mierla 05 Jul '24

05 Jul '24

Module: kamailio Branch: master Commit: 4d2988a79d992ed8f3ce4cffa6c387ef0425be94 URL: https://github.com/kamailio/kamailio/commit/4d2988a79d992ed8f3ce4cffa6c387e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-05T10:41:09+02:00 ndb_redis: print server spec lenght in error message - use standard pkg alloc error message --- Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/kamailio/commit/4d2988a79d992ed8f3ce4cffa6c387e… Patch: https://github.com/kamailio/kamailio/commit/4d2988a79d992ed8f3ce4cffa6c387e… --- diff --git a/src/modules/ndb_redis/redis_client.c b/src/modules/ndb_redis/redis_client.c index c9280991ff3..cba94a38c06 100644 --- a/src/modules/ndb_redis/redis_client.c +++ b/src/modules/ndb_redis/redis_client.c @@ -944,12 +944,13 @@ int check_cluster_reply(redisReply *reply, redisc_server_t **rsrv) addr.len, addr.s, port); if(server_len < 0 || server_len > sizeof(spec_new) - 1) { - LM_ERR("failed to print server spec string\n"); + LM_ERR("failed to print server spec string (%d)\n", + server_len); return 0; } server_new = (char *)pkg_malloc(server_len + 1); if(server_new == NULL) { - LM_ERR("Error allocating pkg mem\n"); + PKG_MEM_ERROR; return 0; } @@ -969,7 +970,7 @@ int check_cluster_reply(redisReply *reply, redisc_server_t **rsrv) name.len, name.s); return 1; } else { - LM_ERR("ERROR connecting to the new server with " + LM_ERR("failed connecting to the new server with " "name: %.*s\n", name.len, name.s); return 0;

1 0

[kamailio/kamailio] [Warning] Aborted connection 203 to db: 'kamailio' user: 'kamailio' host: 'localhost' (Issue #3906)
by Hieu Nguyen Minh 05 Jul '24

05 Jul '24

After a period of use, this warning occurs continuously and affects the performance of the system. Is this the bug of the system? Currently, I am using version 5.6 and MariaDB 10.5.25 + Galera Cluster. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3906 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3906(a)github.com>

2 2

[kamailio/kamailio] secsipid method to only validate signature without checking the rest of the header (Issue #3784)
by Ben Kaufman 05 Jul '24

05 Jul '24

### Description Currently secsipid has a method to sign arbitrary (json) data (`secsipid_sign`), however it has no converse method to check the signature. Currently, an attempt to check a `div` signature for example will yield a `-303` error (`SIPHdrInfo`). Rather than trying to have full parsing for every possible type of Identity header (which are likely to increase in variety), it would be good to simply check "is this signature valid by trusted key", possibly validating the `iat` timestamp as well, but without any other opinions on the header values. ### Expected behavior A feature to check only the signature of an identity header. #### Actual observed behavior Currently the `secsipid_check_` family of functions fails for non- `shaken` passport types. #### Debugging Data The following DIV identity header was generated by secsipid's `secsipid_sign()` function, so it should be possible to reverse this to validate the signature: ``` Identity: eyJhbGciOiJFUzI1NiIsInBwdCI6ImRpdiIsInR5cCI6InBhc3Nwb3J0IiwieDV1IjoiaHR0cHM6Ly9kLm10c2VjLm1lL2QzYTkvQmZUeGJVTlozS1FMLnBlbSJ9.eyJkZXN0Ijp7InRuIjpbIjE2MTI1NTU0MzIxIl19LCJpYXQiOiIxNzEwMTY5MzQ1Iiwib3JpZyI6eyJ0biI6IjE1NTU3MzU5MzA5In0sImRpdiI6eyJ0biI6IjE5NTI1NTU5ODc2In19.-0QF6-u6zgAQNoAhdiETuhAu7FuRDzxmFch_cTdhcbeWvUZ60NQXxdPM-JucpOtFaEdn9wnFreAZ_6vZoc_Phg;info=<https://d.mtsec.me/d3a9/BfTxbUNZ3KQL.pem>;alg=ES256;ppt=div ``` ### Possible Solutions Because it's fairly straight forward to investigate the JWT, it's not necessary to try to account for every possible passport type, etc. The act of validating the signature is the complicated part, so a function that does only that would be convenient. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: Currently alpine linux 3.19 in a docker container, but it should be pretty reproducible everywhere. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3784 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3784(a)github.com>

3 12

git:master:d13e103a: modules: readme files regenerated - tls ... [skip ci]
by Kamailio Dev 04 Jul '24

04 Jul '24

Module: kamailio Branch: master Commit: d13e103ad047405e410d22046d354442b5a566f3 URL: https://github.com/kamailio/kamailio/commit/d13e103ad047405e410d22046d35444… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-04T16:31:11+02:00 modules: readme files regenerated - tls ... [skip ci] --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/d13e103ad047405e410d22046d35444… Patch: https://github.com/kamailio/kamailio/commit/d13e103ad047405e410d22046d35444… --- diff --git a/src/modules/tls/README b/src/modules/tls/README index 7fe63fc3b20..0ebecec8801 100644 --- a/src/modules/tls/README +++ b/src/modules/tls/README @@ -245,6 +245,9 @@ Chapter 1. Admin Guide module that uses libssl (OpenSSL library). A safe option is to have the tls module loaded first (be in the first "loadmodule" in Kamailio.cfg). + IMPORTANT: For libssl v3.x, the core parameter "tls_threads_mode" has + to be set, see the Core Cookbook for possible values. + IMPORTANT: using this module compiled with newer versions of libssl (e.g., v1.1+) may require Kamailio to be started with --atexit=no command line parameters to avoid calling C atexit callbacks inside the

1 0

git:master:91d6a131: etc/kamailio.cfg: set tls_threads_mode to 2
by Daniel-Constantin Mierla 04 Jul '24

04 Jul '24

Module: kamailio Branch: master Commit: 91d6a131ab9d3e58a1560c6305af542c92c2b19f URL: https://github.com/kamailio/kamailio/commit/91d6a131ab9d3e58a1560c6305af542… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-04T16:23:39+02:00 etc/kamailio.cfg: set tls_threads_mode to 2 - recommended value for libssl 3.x, which is the library shipped with latest stable popular Linux distros --- Modified: etc/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/91d6a131ab9d3e58a1560c6305af542… Patch: https://github.com/kamailio/kamailio/commit/91d6a131ab9d3e58a1560c6305af542… --- diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index cd2ecd0109f..94c97f86628 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -230,7 +230,7 @@ tls_max_connections=2048 * 1: use thread executors for process#0 only * 2: no thread executors, but use atfork handler to reset thread-locals to NULL * 3: use thread executors for all processes */ -tls_threads_mode=1 +tls_threads_mode=2 #!endif /* set it to yes to enable sctp and load sctp.so module */

1 0

git:master:234f2ae0: tls: docs - note about tls_threads_mode core parameter
by Daniel-Constantin Mierla 04 Jul '24

04 Jul '24

Module: kamailio Branch: master Commit: 234f2ae07a26af8948a176d10358a0b7039ad1a2 URL: https://github.com/kamailio/kamailio/commit/234f2ae07a26af8948a176d10358a0b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-04T16:20:47+02:00 tls: docs - note about tls_threads_mode core parameter --- Modified: src/modules/tls/doc/tls.xml --- Diff: https://github.com/kamailio/kamailio/commit/234f2ae07a26af8948a176d10358a0b… Patch: https://github.com/kamailio/kamailio/commit/234f2ae07a26af8948a176d10358a0b… --- diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml index 5697792655a..3a0416fed61 100644 --- a/src/modules/tls/doc/tls.xml +++ b/src/modules/tls/doc/tls.xml @@ -64,6 +64,10 @@ that uses libssl (OpenSSL library). A safe option is to have the tls module loaded first (be in the first "loadmodule" in &kamailio;.cfg). </para> + <para> + IMPORTANT: For libssl v3.x, the core parameter "tls_threads_mode" + has to be set, see the Core Cookbook for possible values. + </para> <para> IMPORTANT: using this module compiled with newer versions of libssl (e.g., v1.1+) may require &kamailio; to be started with

1 0

Initial Support for CMake in Kamailio - Feedback Needed!
by Xenofon Karamanos 04 Jul '24

04 Jul '24

Hello all, I've started working on integrating CMake as a build system for the Kamailio. This is an initial step towards potentially offering CMake as an alternative to the current build system across the entire Kamailio project. Right now, the CMake configuration is quite basic and covers only the core module. It offers limited options described in Makefile.defs that are required to build the core module. Some notes regarding the definitions can be found also in the CMakelists.notes<https://github.com/kamailio/kamailio/compare/master...cmake#diff-4e8ba0f2d5…> that made the build failed and maybe it's good to remove from current Makefiles as well, if i am not wrong. Before we consider extending it to other modules and components, i would like some feedback whether you find it useful at all. You can find the initial CMake files in the cmake branch. Please take a look and feel free to share any feedback or suggestions. Your input will be much appreciated and nessecary if we want CMake as a build system. For anyone wanting to try and compile using cmake, here are some basic instructions on how to get you started. Checkout the cmake branch of kamailio repo. Create a new folder, let's call it build. mkdir build && cd build Then run CMake for the configuration cmake .. (you can also then use ccmake . for a visual of the offered options) Build and install using make make -j4 make install OR Build and install using cmake cmake --build . cmake --install . You can of course use the CMake variable CMAKE_INSTALL_PREFIX to change the installation paths as follows and of course other preprocessor defintions: cmake -DCMAKE_INSTALL_PREFIX=./kamailio-cmake -DUSE_TCP=0 .. This will install it in the build/kamailio-cmake folder but fails to build because USE_TCP is required for kamailio to build (Check CMakelists.notes). Thank you all for your continuous contributions and support. Looking forward to hearing your thoughts and insights. Best regards, Xenofon https://github.com/kamailio/kamailio/tree/cmake [https://repository-images.githubusercontent.com/15101579/2d895000-e695-11e9…]<https://github.com/kamailio/kamailio/tree/cmake> GitHub - kamailio/kamailio at cmake<https://github.com/kamailio/kamailio/tree/cmake> Kamailio - The Open Source SIP Server for large VoIP and real-time communication platforms - - GitHub - kamailio/kamailio at cmake github.com

2 7

[kamailio/kamailio] usrloc: refactor some db queries using global usrloc_columns variable (PR #3888)
by Lucian Balaceanu 04 Jul '24

04 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3888 -- Commit Summary -- * usrloc: refactor some db queries using global usrloc_columns variable -- File Changes -- M src/modules/usrloc/udomain.c (260) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3888.patch https://github.com/kamailio/kamailio/pull/3888.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3888 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3888(a)github.com>

2 3

git:master:d923f7b2: usrloc: refactor some db queries using global usrloc_columns variable
by Lucian Balaceanu 04 Jul '24

04 Jul '24

Module: kamailio Branch: master Commit: d923f7b2a3c2fb0df506f9a211065566f6da3747 URL: https://github.com/kamailio/kamailio/commit/d923f7b2a3c2fb0df506f9a21106556… Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Committer: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Date: 2024-07-04T13:08:56+03:00 usrloc: refactor some db queries using global usrloc_columns variable --- Modified: src/modules/usrloc/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/d923f7b2a3c2fb0df506f9a21106556… Patch: https://github.com/kamailio/kamailio/commit/d923f7b2a3c2fb0df506f9a21106556…

1 0

[kamailio/kamailio] Kamailio core dum v5.6 (Issue #3859)
by itpanda2024 04 Jul '24

04 Jul '24

we use Kamailio v5.6 and run cncxx module but when run cncxx function , it restart kamailio service and infor core dump -Log ; ay 28 10:08:30 KAM02 kamailio[45289]: 35(45289) ERROR: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: check : 2 35(45289) INFO: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: CDR Recording May 28 10:08:30 KAM02 kamailio[45289]: 35(45289) INFO: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: check source and dest : 0 va 0 May 28 10:08:30 KAM02 kamailio[45289]: 35(45289) INFO: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: thông tin nmp : May 28 10:08:30 KAM02 kamailio[45289]: 35(45289) INFO: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: vao 20 May 28 10:08:30 KAM02 kamailio[45289]: 35(45289) INFO: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: vao 3 May 28 10:08:30 KAM02 kamailio[45289]: 35(45289) ERROR: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: huong goi t1 giong t2 \n35(45289) ERROR: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: cap nhạt update fail route May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: check : 1 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: telco id 1: 1 \n 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: payment_method: 1 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: IP telco 1: 1 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: credit_money : 10.000000 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: customer_id : htc May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: start_cost : 0.000 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: cps : 0 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: initial_p : 0 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: final_p : 0 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) INFO: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} app_perl [kamailioxs.xs:489]: XS_Kamailio_log(): >>> input: 10.000000, 0, <= May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) INFO: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} app_perl [kamailioxs.xs:489]: XS_Kamailio_log(): >>> return -1 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: check credit : -1 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: check cuoc realtime May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: IP telco 2: 1 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: cap nhạt update fail route May 28 10:08:35 KAM02 kamailio[45262]: 8(45262) ERROR: {1 83965494 ACK 592b5ff7-9742-123d-7eb8-00505697ee23} uac [replace.c:660]: restore_uri(): new URI [] shorter than old URI [sip:0868233455@125.212.210.235:65000] May 28 10:08:36 KAM02 kernel: traps: kamailio[45361] trap divide error ip:7f0ebbc39ec7 sp:7fffe1365020 error:0 in cnxcc.so[7f0ebbc39000+3c000] May 28 10:08:36 KAM02 systemd[1]: Started Process Core Dump (PID 46616/UID 0). May 28 10:08:37 KAM02 systemd-coredump[46617]: Process 45361 (kamailio) of user 982 dumped core.#012#012Stack trace of thread 45361:#012#0 0x00007f0ebbc39ec7 check_calls_by_money (cnxcc.so + 0x3ec7)#012#1 0x00000000006c5f2a fork_basic_timer (kamailio + 0x2c5f2a)#012#2 0x00007f0ebbc41a2c __child_init (cnxcc.so + 0xba2c)#012#3 0x0000000000636f94 init_mod_child (kamailio + 0x236f94)#012#4 0x0000000000636bde init_mod_child (kamailio + 0x236bde)#012#5 0x000000000063778f init_child (kamailio + 0x23778f)#012#6 0x000000000042f78d main_loop (kamailio + 0x2f78d)#012#7 0x000000000043995c main (kamailio + 0x3995c)#012#8 0x00007f0ec2629590 __libc_start_call_main (libc.so.6 + 0x29590)#012#9 0x00007f0ec2629640 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x29640)#012#10 0x000000000041dc35 _start (kamailio + 0x1dc35)#012ELF object binary architecture: AMD x86-64 May 28 10:08:37 KAM02 systemd[1]: systemd-coredump(a)4-46616-0.service: Deactivated successfully. May 28 10:08:37 KAM02 kamailio[45363]: 109(45363) CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 115 May 28 10:08:37 KAM02 kamailio[45254]: 0(45254) ALERT: <core> [main.c:783]: handle_sigs(): child process 45361 exited by a signal 8 May 28 10:08:37 KAM02 kamailio[45254]: 0(45254) ALERT: <core> [main.c:787]: handle_sigs(): core was generated May 28 10:08:37 KAM02 kamailio[45254]: 0(45254) INFO: <core> [main.c:810]: handle_sigs(): terminating due to SIGCHLD May 28 10:08:37 KAM02 kamailio[45256]: 2(45256) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45259]: 5(45259) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45359]: 105(45359) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45260]: 6(45260) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45262]: 8(45262) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45264]: 10(45264) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45267]: 13(45267) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45357]: 103(45357) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45271]: 17(45271) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45273]: 19(45273) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45265]: 11(45265) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45263]: 9(45263) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45276]: 22(45276) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45353]: 99(45353) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45278]: 24(45278) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45281]: 27(45281) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45283]: 29(45283) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45269]: 15(45269) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45268]: 14(45268) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45362]: 108(45362) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45285]: 31(45285) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45288]: 34(45288) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45274]: 20(45274) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45272]: 18(45272) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45280]: 26(45280) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45275]: 21(45275) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45286]: 32(45286) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45352]: 98(45352) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45290]: 36(45290) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45294]: 40(45294) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45277]: 23(45277) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45296]: 42(45296) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45279]: 25(45279) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45299]: 45(45299) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45304]: 50(45304) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45257]: 3(45257) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45306]: 52(45306) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45282]: 28(45282) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45308]: 54(45308) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45300]: 46(45300) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45284]: 30(45284) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45302]: 48(45302) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45255]: 1(45255) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45287]: 33(45287) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45310]: 56(45310) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45315]: 61(45315) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45295]: 41(45295) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45258]: 4(45258) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45297]: 43(45297) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45301]: 47(45301) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45312]: 58(45312) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45314]: 60(45314) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45292]: 38(45292) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45303]: 49(45303) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45317]: 63(45317) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45305]: 51(45305) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45261]: 7(45261) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45360]: 106(45360) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45319]: 65(45319) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45321]: 67(45321) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45307]: 53(45307) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45323]: 69(45323) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45309]: 55(45309) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45289]: 35(45289) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45311]: 57(45311) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45348]: 94(45348) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45340]: 86(45340) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45313]: 59(45313) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45291]: 37(45291) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45316]: 62(45316) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45318]: 64(45318) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45293]: 39(45293) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45324]: 70(45324) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45270]: 16(45270) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45320]: 66(45320) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45266]: 12(45266) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45332]: 78(45332) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45326]: 72(45326) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45322]: 68(45322) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45356]: 102(45356) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45328]: 74(45328) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45330]: 76(45330) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45325]: 71(45325) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45327]: 73(45327) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45334]: 80(45334) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45329]: 75(45329) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45331]: 77(45331) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45336]: 82(45336) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45333]: 79(45333) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45335]: 81(45335) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45338]: 84(45338) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45342]: 88(45342) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45344]: 90(45344) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45346]: 92(45346) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45354]: 100(45354) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45339]: 85(45339) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45337]: 83(45337) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45351]: 97(45351) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45349]: 95(45349) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45341]: 87(45341) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45355]: 101(45355) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45343]: 89(45343) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45358]: 104(45358) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45350]: 96(45350) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45345]: 91(45345) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45347]: 93(45347) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45298]: 44(45298) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45363]: 109(45363) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45254]: 0(45254) INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized May 28 10:08:37 KAM02 systemd[1]: kamailio.service: Main process exited, code=exited, status=1/FAILURE May 28 10:08:37 KAM02 systemd[1]: kamailio.service: Failed with result 'exit-code'. May 28 10:08:37 KAM02 systemd[1]: kamailio.service: Consumed 1.023s CPU time. May 28 10:08:37 KAM02 systemd[1]: kamailio.service: Scheduled restart job, restart counter is at 2. May 28 10:08:37 KAM02 systemd[1]: Stopped kamailio - the Open Source SIP Server. May 28 10:08:37 KAM02 systemd[1]: kamailio.service: Consumed 1.023s CPU time. May 28 10:08:37 KAM02 systemd[1]: Started kamailio - the Open Source SIP Server. May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: rtimer [rtimer_mod.c:299]: stm_t_param(): created rtimer name=cdr interval=300 mode=1 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/tcp_main.c:5105]: init_tcp(): using epoll_lt as the io watch method (auto detected) May 28 10:08:37 KAM02 kamailio[46624]: Listening on May 28 10:08:37 KAM02 kamailio[46624]: udp: 125.212.210.235:65000 May 28 10:08:37 KAM02 kamailio[46624]: udp: 172.16.172.245:65000 May 28 10:08:37 KAM02 kamailio[46624]: udp: 172.16.172.246:65000 May 28 10:08:37 KAM02 kamailio[46624]: Aliases: May 28 10:08:37 KAM02 kamailio[46624]: udp: KAM02:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: http_client [http_client.c:316]: mod_init(): HTTP proxy port set to 0. Disabling HTTP proxy May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: regex [regex_mod.c:375]: load_pcres(): num groups = 4 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: regex [regex_mod.c:377]: load_pcres(): <group[0]>((^09[03]\d{7}$#015)|(^089\d{7}$#015)|(^07\d{8}$#015))</group[0]> (size = 45) May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: regex [regex_mod.c:377]: load_pcres(): <group[1]>((^09[6-8]\d{7}$#015)|(^086\d{7}$#015)|(^03\d{8}$#015))</group[1]> (size = 46) May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: regex [regex_mod.c:377]: load_pcres(): <group[2]>((^09[14]\d{7}$#015)|(^08[1-58]\d{7}$#015))</group[2]> (size = 37) May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: regex [regex_mod.c:377]: load_pcres(): <group[3]>((^02[48]\d{8}$#015)|(^842[48]\d{8}$))</group[3]> (size = 35) May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: outbound [outbound_mod.c:117]: mod_init(): "stun" module is not loaded. STUN is required to use outbound with UDP. May 28 10:08:37 KAM02 kamailio[46624]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. May 28 10:08:37 KAM02 kamailio[46624]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. May 28 10:08:37 KAM02 kamailio[46624]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. May 28 10:08:37 KAM02 kamailio[46624]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: pike [pike.c:93]: pike_init(): PIKE - initializing May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: pike [ip_tree.c:79]: init_lock_set(): probing 256 set size May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: app_perl [app_perl_mod.c:210]: parser_init(): setting lib path: '/usr/local/lib64/kamailio/perl/' May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: app_perl [app_perl_mod.c:242]: parser_init(): successfully loaded perl file "/usr/local/etc/plugin/realtime-payment/scripts/aaa-script.pl" May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: app_perl [app_perl_mod.c:345]: mod_init(): perl interpreter has been initialized (1716865717.772062 => 1716865717.813451) May 28 10:08:37 KAM02 kamailio[46624]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 125.212.210.236:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 125.212.210.237:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 125.212.210.238:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 172.16.172.244:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 172.16.172.243:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 172.16.172.242:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 101.99.1.36:5060 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: cnxcc [cnxcc_mod.c:246]: __mod_init(): Loading cnxcc module May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: drouting [drouting.c:279]: dr_init(): DRouting - initializing May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [main.c:3150]: main(): processes (at least): 110 - shm size: 67108864 - pkg size: 8388608 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("OUT_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("OUT_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("MS_IN_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("MS_IN_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("MS_IN_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("MS_OUT_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:163]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992 for fd 8 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:233]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984 on fd 8 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:163]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992 for fd 9 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:233]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984 on fd 9 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:163]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992 for fd 10 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:233]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984 on fd 10 May 28 10:08:37 KAM02 kamailio[46625]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a f -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3859 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3859(a)github.com>

3 15

[kamailio/kamailio] db_redis: change logs on delete (PR #3892)
by Stefan Mititelu 03 Jul '24

03 Jul '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Issue: when using usrloc with db_redis, I get constant WARNING logs for 'delete' via usrloc timer. The real WARNING, in my opinion, is when doing full table scans(which is already logged as so). Make logs less important when performing table scans using a match key. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3892 -- Commit Summary -- * db_redis: change logs on delete -- File Changes -- M src/modules/db_redis/redis_dbase.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3892.patch https://github.com/kamailio/kamailio/pull/3892.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3892 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3892(a)github.com>

3 8

git:master:97ba5dff: db_redis: change logs on delete
by Stefan Mititelu 03 Jul '24

03 Jul '24

Module: kamailio Branch: master Commit: 97ba5dff468fc309acc9245108a0d7645fe45361 URL: https://github.com/kamailio/kamailio/commit/97ba5dff468fc309acc9245108a0d76… Author: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)govoip.ro> Date: 2024-07-03T18:27:03+03:00 db_redis: change logs on delete --- Modified: src/modules/db_redis/redis_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/97ba5dff468fc309acc9245108a0d76… Patch: https://github.com/kamailio/kamailio/commit/97ba5dff468fc309acc9245108a0d76… --- diff --git a/src/modules/db_redis/redis_dbase.c b/src/modules/db_redis/redis_dbase.c index 84c0c3a9459..b3624975cf4 100644 --- a/src/modules/db_redis/redis_dbase.c +++ b/src/modules/db_redis/redis_dbase.c @@ -1827,13 +1827,13 @@ static int db_redis_perform_delete(const db1_con_t *_h, km_redis_con_t *con, "performing delete\n", CON_TABLE(_h)->len, CON_TABLE(_h)->s); else - LM_WARN("performing table scan on table '%.*s' while performing " - "delete using match key " - "'%.*s' at offset %llx\n", + LM_DBG("performing table scan on table '%.*s' while performing " + "delete using match key " + "'%.*s' at offset %llx\n", CON_TABLE(_h)->len, CON_TABLE(_h)->s, ts_scan_key->len, ts_scan_key->s, (unsigned long long)ts_scan_start); for(i = 0; i < _n; ++i) { - LM_WARN(" scan key %d is '%.*s'\n", i, _k[i]->len, _k[i]->s); + LM_DBG(" scan key %d is '%.*s'\n", i, _k[i]->len, _k[i]->s); } if(db_redis_scan_query_keys(con, CON_TABLE(_h), _n, keys, keys_count, manual_keys, manual_keys_count, ts_scan_start, ts_scan_key,

1 0

Kamailio v5.6.6 Released
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Hello, Kamailio SIP Server v5.6.6 stable release is out. This is a maintenance release of the latest stable branch, 5.6, that includes fixes since the release of v5.6.5. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.6.x. Deployments running previous v5.6.x versions are strongly recommended to be upgraded to v5.6.6. Note that 5.6 is now the third last stable branch, v5.6.6 being the last planned released in 5.5.x series. The latest two stable branch are 5.7 and 5.8, with v5.8.2 being released a while ago. For more details about version 5.6.6 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2024/07/kamailio-v5-6-6-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy and Development Services Kamailio Advanced Training -- asipto.com

1 0

git:5.6:144b61dc: ChangeLog: content updated for v5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: 144b61dc9e66f574e6a32a7dcd3b3e3e1343666f URL: https://github.com/kamailio/kamailio/commit/144b61dc9e66f574e6a32a7dcd3b3e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:51:14+02:00 ChangeLog: content updated for v5.6.6 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/144b61dc9e66f574e6a32a7dcd3b3e3… Patch: https://github.com/kamailio/kamailio/commit/144b61dc9e66f574e6a32a7dcd3b3e3…

1 0

git:5.6:fe1c5b4c: Makefile.defs: version set to 5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: fe1c5b4c42795be5218ddc88a3245ed8be9865c7 URL: https://github.com/kamailio/kamailio/commit/fe1c5b4c42795be5218ddc88a3245ed… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:29:23+02:00 Makefile.defs: version set to 5.6.6 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/fe1c5b4c42795be5218ddc88a3245ed… Patch: https://github.com/kamailio/kamailio/commit/fe1c5b4c42795be5218ddc88a3245ed… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 872c5fc5d90..b3c1c74d135 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 6 -SUBLEVEL = 5 +SUBLEVEL = 6 EXTRAVERSION = # memory manager switcher

1 0

git:5.6:80926422: pkg: deb specs updated for v5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: 80926422b3aa0c98dfb73aa9a87eece98efb1ff8 URL: https://github.com/kamailio/kamailio/commit/80926422b3aa0c98dfb73aa9a87eece… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:28:36+02:00 pkg: deb specs updated for v5.6.6 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/80926422b3aa0c98dfb73aa9a87eece… Patch: https://github.com/kamailio/kamailio/commit/80926422b3aa0c98dfb73aa9a87eece…

1 0

git:5.6:6cea0990: pkg: version set to 5.6.6 for rpms and alpine specs
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: 6cea09909229abe759d2bf860ea93e714699feae URL: https://github.com/kamailio/kamailio/commit/6cea09909229abe759d2bf860ea93e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:27:54+02:00 pkg: version set to 5.6.6 for rpms and alpine specs --- Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/6cea09909229abe759d2bf860ea93e7… Patch: https://github.com/kamailio/kamailio/commit/6cea09909229abe759d2bf860ea93e7… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index a409d8fdde6..9662c1d5873 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -4,7 +4,7 @@ # Maintainer: Nathan Angelacos <nangel(a)alpinelinux.org> pkgname=kamailio -pkgver=5.6.5 +pkgver=5.6.6 pkgrel=0 # If building from a git snapshot, specify the gitcommit diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 075321ec592..eb0e821f76a 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.6.5 +%define ver 5.6.6 %define rel dev1.0%{dist} %if 0%{?fedora}

1 0

Releasing v5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Hello, I am considering to release Kamailio v5.6.6 (out of branch 5.6) later this week (likely on Wednesday, July 3, 2024). If anyone is aware of issues not yet on the bug tracker, report them there asap in order to have a better chance to be fixed. This is going to be the last release out of branch 5.6 to mark the end of official/packaging maintenance. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 1

[kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)
by Oded Arbel 02 Jul '24

02 Jul '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #### Description In `send_rtpp_command()` if socket operations fail with an error other than `EINTR` or `ENOBUFS`, the actual error is not reported - we just get a generic "Can't send command to/read reply from RTPEngine". Other places in the module report `errno` and `strerror(errno)` using the log format "`(%s:%d)`" so added that to the error log. Also fixed `bind_force_send_ip()` error log to use the same semantic as the other places. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3899 -- Commit Summary -- * rtpengine: show errno and error string in more places where it is useful -- File Changes -- M src/modules/rtpengine/rtpengine.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3899.patch https://github.com/kamailio/kamailio/pull/3899.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3899 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3899(a)github.com>

2 9

git:master:fae2a467: rtpengine: show errno and error string in more places where it is useful (#3899)
by GitHub 02 Jul '24

02 Jul '24

Module: kamailio Branch: master Commit: fae2a467cb7b543920cf8bea3ce655ad07b70969 URL: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… Author: Oded Arbel <oded(a)geek.co.il> Committer: GitHub <noreply(a)github.com> Date: 2024-07-02T08:19:11-04:00 rtpengine: show errno and error string in more places where it is useful (#3899) Also fixed bind_force_send_ip() error log to use the same semantic as other places --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… Patch: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 54f22b1843f..7b97a2ae1ee 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -830,7 +830,7 @@ static int bind_force_send_ip(int sock_idx) sizeof(ip6addr))) < 0) { LM_ERR("can't bind socket to required ipv6 interface\n"); - LM_ERR("ret=%d errno=%d\n", ret, errno); + LM_ERR("ret=%d (%s:%d)\n", ret, strerror(errno), errno); return -1; } @@ -3598,7 +3598,7 @@ static char *send_rtpp_command( struct rtpp_node *node, bencode_item_t *dict, int *outlen) { struct sockaddr_un addr; - int fd, len, i, vcnt; + int fd = -1, len, i, vcnt; int rtpengine_retr, rtpengine_tout_ms = 1000; char *cp; static char buf[0x40000]; @@ -3632,8 +3632,8 @@ static char *send_rtpp_command( goto badproxy; } if(connect(fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) { - close(fd); - LM_ERR("can't connect to RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't connect to RTPEngine <%s> (%s:%d)\n", node->rn_url.s, + strerror(errno), errno); goto badproxy; } @@ -3641,18 +3641,19 @@ static char *send_rtpp_command( len = writev(fd, v + 1, vcnt); } while(len == -1 && errno == EINTR); if(len <= 0) { - close(fd); - LM_ERR("can't send command to RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't send command to RTPEngine <%s> (%s:%d)\n", + node->rn_url.s, strerror(errno), errno); goto badproxy; } do { len = read(fd, buf, sizeof(buf) - 1); } while(len == -1 && errno == EINTR); - close(fd); if(len <= 0) { - LM_ERR("can't read reply from RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't read reply from RTPEngine <%s> (%s:%d)\n", + node->rn_url.s, strerror(errno), errno); goto badproxy; } + close(fd); } else if(node->rn_umode == RNU_WS || node->rn_umode == RNU_WSS) { /* assemble full request string, flatten iovec */ v[0].iov_base = gencookie(); @@ -3721,8 +3722,9 @@ static char *send_rtpp_command( } while(len == -1 && (errno == EINTR || errno == ENOBUFS)); if(len <= 0) { bencode_get_str(bencode_dictionary_get(dict, "command"), &cmd); - LM_ERR("can't send command \"%.*s\" to RTPEngine <%s>\n", - cmd.len, cmd.s, node->rn_url.s); + LM_ERR("can't send command \"%.*s\" to RTPEngine <%s> " + "(%s:%d)\n", + cmd.len, cmd.s, node->rn_url.s, strerror(errno), errno); goto badproxy; } while((poll(fds, 1, rtpengine_tout_ms) == 1) @@ -3734,8 +3736,9 @@ static char *send_rtpp_command( bencode_get_str( bencode_dictionary_get(dict, "command"), &cmd); LM_ERR("can't read reply for command \"%.*s\" from " - "RTPEngine <%s>\n", - cmd.len, cmd.s, node->rn_url.s); + "RTPEngine <%s> (%s:%d)\n", + cmd.len, cmd.s, node->rn_url.s, strerror(errno), + errno); goto badproxy; } if(len >= (v[0].iov_len - 1) @@ -3767,6 +3770,7 @@ static char *send_rtpp_command( return cp; badproxy: + close(fd); return NULL; }

1 0

[kamailio/kamailio] misc/examples/ims/icscf: fix bad prefix added on all incoming requests (PR #3900)
by Dragos Vingarzan 02 Jul '24

02 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to PR https://github.com/kamailio/kamailio/pull/3891 - splitting by components #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3900 -- Commit Summary -- * misc/examples/ims/icscf: removed always adding a plus as a prefix on requests arriving to the I-CSCF -- File Changes -- M misc/examples/ims/icscf/kamailio.cfg (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3900.patch https://github.com/kamailio/kamailio/pull/3900.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3900 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3900(a)github.com>

3 2

git:master:b753682b: misc/examples/ims/icscf: removed always adding a plus as a prefix on requests arriving to the I-CSCF (#3900)
by GitHub 02 Jul '24

02 Jul '24

Module: kamailio Branch: master Commit: b753682bdfa722280ed2dd3ca79b790f5c7529d1 URL: https://github.com/kamailio/kamailio/commit/b753682bdfa722280ed2dd3ca79b790… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2024-07-02T11:41:25+02:00 misc/examples/ims/icscf: removed always adding a plus as a prefix on requests arriving to the I-CSCF (#3900) --- Modified: misc/examples/ims/icscf/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/b753682bdfa722280ed2dd3ca79b790… Patch: https://github.com/kamailio/kamailio/commit/b753682bdfa722280ed2dd3ca79b790… --- diff --git a/misc/examples/ims/icscf/kamailio.cfg b/misc/examples/ims/icscf/kamailio.cfg index 4434e6a25d6..1fb51fef680 100644 --- a/misc/examples/ims/icscf/kamailio.cfg +++ b/misc/examples/ims/icscf/kamailio.cfg @@ -238,10 +238,6 @@ route{ xlog("I-CSCF >>>>>>>>>>>>>>>>>>>> $rm $ru ($fu => $tu ($si:$sp) to $tu, $ci)\n"); #!endif - if !($rU =~ "\+.*") { - prefix("+"); - } - # per request initial checks route(REQINIT);

1 0

Kamailio v5.7.6 Released
by Daniel-Constantin Mierla 02 Jul '24

02 Jul '24

Hello, Kamailio SIP Server v5.7.6 stable release is out. This is a maintenance release of the latest stable branch, 5.7, that includes fixes since the release of v5.7.5. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.7.x. Deployments running previous v5.7.x versions are strongly recommended to be upgraded to v5.7.6. For more details about version 5.7.6 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2024/07/kamailio-v5-7-6-released/ RPM, Debian/Ubuntu packages will be available soon as well. Note that 5.7.x is currently the previous stable release series, the latest is 5.8.x and v5.8.2 was released on June 12, 2024. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev