### Description
On systems with a high number of TCP sessions there can be a significant performance regression observed, probably related to the newly added TCP connection tracking feature.
### Troubleshooting
#### Reproduction
No special configuration is necessary, just install the latest 5.7.x release, e.g. 5.7.3 on a production system with a lot of clients connected over TCP or TLS. You need to have a large number of clients connected to be able to observe the regression. For a high …
[View More]number of connections (e.g. more then 20.000 up to 30.000 connections) the Kamailio servers uses about 30% to 50% more CPU as with the old version.
#### Debugging Data
Two graphs were attached to this issue. The first shows the CPU load before (less load) and after the upgrade (increased load). The second is a flamegraph that shows that over 80% of the CPU time is spent in the newly added function tcp_connection_limit_srcip().
<img width="372" alt="cpu-load-before-after" src="https://github.com/kamailio/kamailio/assets/6481937/ec92c41b-25e2-4847-a4bc…">

Most of the CPU time is spend in the TCP main process, as expected.
#### Log Messages
No special log messages could be observed.
#### SIP Traffic
### Possible Solutions
The TCP limit feature should probably be optimized to not cause such a large performance regression. It should be also possible to deactivate it completly and therefore getting a comparable performance as before the feature addition.
### Additional Information
Kamailio 5.7.3 and probably also git master version.
* **Operating System**:
Debian 11, Debian 12
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3759
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3759(a)github.com>
[View Less]
After a period of use, this warning occurs continuously and affects the performance of the system. Is this the bug of the system?
Currently, I am using version 5.6 and MariaDB 10.5.25 + Galera Cluster.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3906
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3906(a)github.com>
### Description
Currently secsipid has a method to sign arbitrary (json) data (`secsipid_sign`), however it has no converse method to check the signature. Currently, an attempt to check a `div` signature for example will yield a `-303` error (`SIPHdrInfo`). Rather than trying to have full parsing for every possible type of Identity header (which are likely to increase in variety), it would be good to simply check "is this signature valid by trusted key", possibly validating the `iat` …
[View More]timestamp as well, but without any other opinions on the header values.
### Expected behavior
A feature to check only the signature of an identity header.
#### Actual observed behavior
Currently the `secsipid_check_` family of functions fails for non- `shaken` passport types.
#### Debugging Data
The following DIV identity header was generated by secsipid's `secsipid_sign()` function, so it should be possible to reverse this to validate the signature:
```
Identity: eyJhbGciOiJFUzI1NiIsInBwdCI6ImRpdiIsInR5cCI6InBhc3Nwb3J0IiwieDV1IjoiaHR0cHM6Ly9kLm10c2VjLm1lL2QzYTkvQmZUeGJVTlozS1FMLnBlbSJ9.eyJkZXN0Ijp7InRuIjpbIjE2MTI1NTU0MzIxIl19LCJpYXQiOiIxNzEwMTY5MzQ1Iiwib3JpZyI6eyJ0biI6IjE1NTU3MzU5MzA5In0sImRpdiI6eyJ0biI6IjE5NTI1NTU5ODc2In19.-0QF6-u6zgAQNoAhdiETuhAu7FuRDzxmFch_cTdhcbeWvUZ60NQXxdPM-JucpOtFaEdn9wnFreAZ_6vZoc_Phg;info=<https://d.mtsec.me/d3a9/BfTxbUNZ3KQL.pem>;alg=ES256;ppt=div
```
### Possible Solutions
Because it's fairly straight forward to investigate the JWT, it's not necessary to try to account for every possible passport type, etc. The act of validating the signature is the complicated part, so a function that does only that would be convenient.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.7.4 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 12.2.0
```
* **Operating System**:
Currently alpine linux 3.19 in a docker container, but it should be pretty reproducible everywhere.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3784
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3784(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: d13e103ad047405e410d22046d354442b5a566f3
URL: https://github.com/kamailio/kamailio/commit/d13e103ad047405e410d22046d35444…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-07-04T16:31:11+02:00
modules: readme files regenerated - tls ... [skip ci]
---
Modified: src/modules/tls/README
---
Diff: https://github.com/kamailio/kamailio/commit/d13e103ad047405e410d22046d35444……
[View More]Patch: https://github.com/kamailio/kamailio/commit/d13e103ad047405e410d22046d35444…
---
diff --git a/src/modules/tls/README b/src/modules/tls/README
index 7fe63fc3b20..0ebecec8801 100644
--- a/src/modules/tls/README
+++ b/src/modules/tls/README
@@ -245,6 +245,9 @@ Chapter 1. Admin Guide
module that uses libssl (OpenSSL library). A safe option is to have the
tls module loaded first (be in the first "loadmodule" in Kamailio.cfg).
+ IMPORTANT: For libssl v3.x, the core parameter "tls_threads_mode" has
+ to be set, see the Core Cookbook for possible values.
+
IMPORTANT: using this module compiled with newer versions of libssl
(e.g., v1.1+) may require Kamailio to be started with --atexit=no
command line parameters to avoid calling C atexit callbacks inside the
[View Less]
Module: kamailio
Branch: master
Commit: 91d6a131ab9d3e58a1560c6305af542c92c2b19f
URL: https://github.com/kamailio/kamailio/commit/91d6a131ab9d3e58a1560c6305af542…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-04T16:23:39+02:00
etc/kamailio.cfg: set tls_threads_mode to 2
- recommended value for libssl 3.x, which is the library shipped with
latest stable popular Linux distros
---
Modified: etc/…
[View More]kamailio.cfg
---
Diff: https://github.com/kamailio/kamailio/commit/91d6a131ab9d3e58a1560c6305af542…
Patch: https://github.com/kamailio/kamailio/commit/91d6a131ab9d3e58a1560c6305af542…
---
diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg
index cd2ecd0109f..94c97f86628 100644
--- a/etc/kamailio.cfg
+++ b/etc/kamailio.cfg
@@ -230,7 +230,7 @@ tls_max_connections=2048
* 1: use thread executors for process#0 only
* 2: no thread executors, but use atfork handler to reset thread-locals to NULL
* 3: use thread executors for all processes */
-tls_threads_mode=1
+tls_threads_mode=2
#!endif
/* set it to yes to enable sctp and load sctp.so module */
[View Less]
Module: kamailio
Branch: master
Commit: 234f2ae07a26af8948a176d10358a0b7039ad1a2
URL: https://github.com/kamailio/kamailio/commit/234f2ae07a26af8948a176d10358a0b…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-04T16:20:47+02:00
tls: docs - note about tls_threads_mode core parameter
---
Modified: src/modules/tls/doc/tls.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]234f2ae07a26af8948a176d10358a0b…
Patch: https://github.com/kamailio/kamailio/commit/234f2ae07a26af8948a176d10358a0b…
---
diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml
index 5697792655a..3a0416fed61 100644
--- a/src/modules/tls/doc/tls.xml
+++ b/src/modules/tls/doc/tls.xml
@@ -64,6 +64,10 @@
that uses libssl (OpenSSL library). A safe option is to have the tls module
loaded first (be in the first "loadmodule" in &kamailio;.cfg).
</para>
+ <para>
+ IMPORTANT: For libssl v3.x, the core parameter "tls_threads_mode"
+ has to be set, see the Core Cookbook for possible values.
+ </para>
<para>
IMPORTANT: using this module compiled with newer versions of libssl
(e.g., v1.1+) may require &kamailio; to be started with
[View Less]
Hello all,
I've started working on integrating CMake as a build system for the Kamailio. This is an initial step towards potentially offering CMake as an alternative to the current build system across the entire Kamailio project.
Right now, the CMake configuration is quite basic and covers only the core module. It offers limited options described in Makefile.defs that are required to build the core module.
Some notes regarding the definitions can be found also in the CMakelists.notes<https:/…
[View More]/github.com/kamailio/kamailio/compare/master...cmake#diff-4e8ba0f2d5…> that made the build failed and maybe it's good to remove from current Makefiles as well, if i am not wrong.
Before we consider extending it to other modules and components, i would like some feedback whether you find it useful at all.
You can find the initial CMake files in the cmake branch. Please take a look and feel free to share any feedback or suggestions. Your input will be much appreciated and nessecary if we want CMake as a build system.
For anyone wanting to try and compile using cmake, here are some basic instructions on how to get you started.
Checkout the cmake branch of kamailio repo.
Create a new folder, let's call it build.
mkdir build && cd build
Then run CMake for the configuration
cmake .. (you can also then use ccmake . for a visual of the offered options)
Build and install using make
make -j4
make install
OR
Build and install using cmake
cmake --build .
cmake --install .
You can of course use the CMake variable CMAKE_INSTALL_PREFIX to change the installation paths as follows and of course other preprocessor defintions:
cmake -DCMAKE_INSTALL_PREFIX=./kamailio-cmake -DUSE_TCP=0 ..
This will install it in the build/kamailio-cmake folder but fails to build because USE_TCP is required for kamailio to build (Check CMakelists.notes).
Thank you all for your continuous contributions and support. Looking forward to hearing your thoughts and insights.
Best regards,
Xenofon
https://github.com/kamailio/kamailio/tree/cmake
[https://repository-images.githubusercontent.com/15101579/2d895000-e695-11e9…]<https://github.com/kamailio/kamailio/tree/cmake>
GitHub - kamailio/kamailio at cmake<https://github.com/kamailio/kamailio/tree/cmake>
Kamailio - The Open Source SIP Server for large VoIP and real-time communication platforms - - GitHub - kamailio/kamailio at cmake
github.com
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3888
-- Commit Summary --
* usrloc: refactor some db queries using global usrloc_columns variable
-- File Changes --
M src/modules/usrloc/udomain.c (260)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3888.patchhttps://github.com/kamailio/kamailio/pull/3888.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3888
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3888(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Issue: when using usrloc with db_redis, I get constant WARNING logs for 'delete' via usrloc timer. The real WARNING, in my opinion, is when doing full table scans(which is already logged as so).
Make logs less important when performing table scans using a match key.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3892
-- Commit Summary --
* db_redis: change logs on delete
-- File Changes --
M src/modules/db_redis/redis_dbase.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3892.patchhttps://github.com/kamailio/kamailio/pull/3892.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3892
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3892(a)github.com>
[View Less]
Hello,
Kamailio SIP Server v5.6.6 stable release is out.
This is a maintenance release of the latest stable branch, 5.6, that
includes fixes since the release of v5.6.5. There is no change to
database schema or configuration language structure that you have to do
on previous installations of v5.6.x. Deployments running previous v5.6.x
versions are strongly recommended to be upgraded to v5.6.6.
Note that 5.6 is now the third last stable branch, v5.6.6 being the last
planned released in 5.5.x …
[View More]series. The latest two stable branch are 5.7
and 5.8, with v5.8.2 being released a while ago.
For more details about version 5.6.6 (including links and guidelines to
download the tarball or from GIT repository), visit:
* https://www.kamailio.org/w/2024/07/kamailio-v5-6-6-released/
RPM, Debian/Ubuntu packages will be available soon as well.
Many thanks to all contributing and using Kamailio!
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy and Development Services
Kamailio Advanced Training -- asipto.com
[View Less]
Hello,
I am considering to release Kamailio v5.6.6 (out of branch 5.6) later
this week (likely on Wednesday, July 3, 2024). If anyone is aware of
issues not yet on the bug tracker, report them there asap in order to
have a better chance to be fixed.
This is going to be the last release out of branch 5.6 to mark the end
of official/packaging maintenance.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training …
[View More]and Development Services -- asipto.com
[View Less]
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature …
[View More](non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue
#### Description
In `send_rtpp_command()` if socket operations fail with an error other than `EINTR` or `ENOBUFS`, the actual error is not reported - we just get a generic "Can't send command to/read reply from RTPEngine".
Other places in the module report `errno` and `strerror(errno)` using the log format "`(%s:%d)`" so added that to the error log.
Also fixed `bind_force_send_ip()` error log to use the same semantic as the other places.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3899
-- Commit Summary --
* rtpengine: show errno and error string in more places where it is useful
-- File Changes --
M src/modules/rtpengine/rtpengine.c (14)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3899.patchhttps://github.com/kamailio/kamailio/pull/3899.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3899
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3899(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to PR https://github.com/kamailio/kamailio/pull/3891 - splitting by components
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3900
-- Commit Summary --
* misc/examples/ims/icscf: removed always adding a plus as a prefix on requests arriving to the I-CSCF
-- File Changes --
M misc/examples/ims/icscf/kamailio.cfg (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3900.patchhttps://github.com/kamailio/kamailio/pull/3900.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3900
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3900(a)github.com>
[View Less]
Hello,
Kamailio SIP Server v5.7.6 stable release is out.
This is a maintenance release of the latest stable branch, 5.7, that
includes fixes since the release of v5.7.5. There is no change to
database schema or configuration language structure that you have to do
on previous installations of v5.7.x. Deployments running previous v5.7.x
versions are strongly recommended to be upgraded to v5.7.6.
For more details about version 5.7.6 (including links and guidelines to
download the tarball or …
[View More]from GIT repository), visit:
* https://www.kamailio.org/w/2024/07/kamailio-v5-7-6-released/
RPM, Debian/Ubuntu packages will be available soon as well.
Note that 5.7.x is currently the previous stable release series, the
latest is 5.8.x and v5.8.2 was released on June 12, 2024.
Many thanks to all contributing and using Kamailio!
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
[View Less]
Hello,
I am considering to release Kamailio v5.7.6 (out of branch 5.7) on
Tuesday, July 2, 2024. If anyone is aware of issues not yet on the bug
tracker, report them there asap in order to have a better chance to be
fixed.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
https://datatracker.ietf.org/doc/html/rfc3265#section-3.2.2 says that if a NOTIFY fails, the subscription should be removed. There is one exception only, when a Retry-After is specified.
This is done in order to cleanup state and not keep it around for huge periods of time. This is preferred and the client is the one that should re-subscribe at intervals to fix the situation.
Anyway, I guess I was super annoyed by the huge number of useless notifications that I'm getting for gone IMS clients.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3895
-- Commit Summary --
* ims_registrar_scscf: drop subscription on notification failure
-- File Changes --
M src/modules/ims_registrar_scscf/registrar_notify.c (153)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3895.patchhttps://github.com/kamailio/kamailio/pull/3895.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3895
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3895(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
The `ims_registrar_scscf` was not able to function with global-number tel-URIs. This fix prevents a bad AOR to search by from being formed, when the host part of Request-URI is empty.
e.g. INVITE with Request-URI `tel:+123` --> AOR to search by was `tel:+123@` --> not found in `ims_usrloc_scscf`
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3897
-- Commit Summary --
* ims_registrar_scscf: fix for location AOR with empty host
-- File Changes --
M src/modules/ims_registrar_scscf/lookup.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3897.patchhttps://github.com/kamailio/kamailio/pull/3897.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3897
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3897(a)github.com>
[View Less]
- URL: https://github.com/kamailio/kamailio/commit/1b96bb4a5a667c9838441876838d3c1…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T09:59:39+02:00
core: parse privacy recompute lenght of rest to parse
(cherry picked from commit 804ee651b45498727196886c97cb55d20b254c4a)
(cherry picked from commit 8674b333300d5829bff9cb4993886bcf7bea249b)
- URL: https://github.com/kamailio/kamailio/commit/f1d593b55f4334c1ac1e61c7dd5775a…
Author: Daniel-Constantin Mierla <…
[View More]miconda(a)gmail.com>
Date: 2024-07-01T09:59:53+02:00
pv: remove extra len increment for some uri transformations
(cherry picked from commit 3fe9a279abecf6f367ce9fd2d4b085c41c87ad77)
(cherry picked from commit 75aecd3f2e10509d5ed71cc5e89ae6f5c3bd0fea)
- URL: https://github.com/kamailio/kamailio/commit/6ed780aa1eea71c9c789809fce91d4a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:00:59+02:00
core: set proto on fixing forward actions
(cherry picked from commit e51ccd11fe51f2d53dd7719b8fdec561a6ba7494)
(cherry picked from commit 18fead63dca0982df500b35b7c4e2d06550d9b40)
- URL: https://github.com/kamailio/kamailio/commit/a8fe0bf1f07fba7662bea122e5f2ff0…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:01:08+02:00
dialog: prevent duplicate of leg1 attributes in json for dmq
- reported by #3656
(cherry picked from commit ca7e1e49aecd3e0f12cc783e3b97868980f1d3d2)
(cherry picked from commit 065203150aaf2f99bd6fe40ce5ffb960bd430c16)
- URL: https://github.com/kamailio/kamailio/commit/a7dd64a7d9183caccfdc280eb4f5d67…
Author: Pe����ter Baraba����s <peter.barabas(a)securesoft.hu>
Date: 2024-07-01T10:01:20+02:00
uac: fix socket length settings
- set _uac_req.s_sock.len value to 0 in pv_set_uac_req() method in case of "all" case
- change setting of _uac_req.s_apasswd.len to _uac_req.s_sock.len in pv_set_uac_req() method in case of "sock" case
(cherry picked from commit 10519d199f6cac116399f4473bd82f2b08de72ba)
(cherry picked from commit 3046d01bed4bdd0fe763fd770ffc8f7aeeae3418)
- URL: https://github.com/kamailio/kamailio/commit/fbc0728080c3846f49b34e56daf0ba2…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:01:37+02:00
dialog: check first the size
(cherry picked from commit 9db18bc48bff0d230e66973a45c8e72e1b7744e8)
(cherry picked from commit 37621005e38a0191a93fbaf4f39b8b88c7486c9d)
- URL: https://github.com/kamailio/kamailio/commit/f80a035be2846ab36cfe4209e210f0a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:01:54+02:00
core: check if conversion could not be done
(cherry picked from commit 077651fa3bfd50e0f654c907f3783b1421497bd5)
(cherry picked from commit 62b76c076ff0f36b847a13c180b7d5090e98d94e)
- URL: https://github.com/kamailio/kamailio/commit/c9f7bdb6024a05f03067c73e4a6e40b…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:02:12+02:00
pv: typo in transformation log message
(cherry picked from commit ca2a9479adf720e67bf50c9d2795cc8937e223dc)
(cherry picked from commit 2d385c1983a921a95fb392e8aea0332fdc10a387)
- URL: https://github.com/kamailio/kamailio/commit/bc81c9ae6e9bc22198e19be520255f1…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:02:39+02:00
pv: removed unnecessary condition
(cherry picked from commit 2f43510be37c157f800389dfb432b6c52d7435a7)
(cherry picked from commit 5a26d9e9fba36a49a93bb3b886836615f62ed3d1)
- URL: https://github.com/kamailio/kamailio/commit/c9e9112322cc392edc9071c35701d86…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:03:13+02:00
statsd: use bool type for local variable to match return of function
(cherry picked from commit 0186246fce8f0e4bb46b30c05174983cd957a3ba)
(cherry picked from commit fc0bd88b55121e3588f5793480f0594e44bf2b17)
- URL: https://github.com/kamailio/kamailio/commit/bd5f2d21f7aa64647ce24bdd16e565a…
Author: Dennis Yurasov <dennis-y(a)yandex-team.ru>
Date: 2024-07-01T10:03:36+02:00
dialog: fixed saving dialogs on shutdown that are already loaded at startup when using db_mode 3
- The dialogs that loaded at startup are not saved in DB on shutdown, and so not loaded at restart,
fixes issue #3669
(cherry picked from commit 2d00ce546bb0852dc1784d5bc2e794d06f919577)
(cherry picked from commit 37a07037b6e3485f3ddd1b27b1998af6e4283bcb)
- URL: https://github.com/kamailio/kamailio/commit/785b962507a21191a345add832bb241…
Author: Federico Cabiddu <federico.cabiddu(a)gmail.com>
Date: 2024-07-01T10:04:11+02:00
http_async_client: exit mod_init if tm is not loaded
(cherry picked from commit 5a40d1ef1b484c4fc437a3f0183a101241e80313)
(cherry picked from commit 2dff6f52d1393cf8eabe714262ec8e56aad0d212)
- URL: https://github.com/kamailio/kamailio/commit/b19b38f7d9a5b7568bd180e57027367…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:04:30+02:00
core: keep listen socket even if advertise address does not resolve
- the core advertise_address parameter works in the same fashion
- previously it was starting by skipping the listen, which resulted in
unexpected runtime list of sockets
(cherry picked from commit b50036200c5bc09fd2d412a18585b42d63763b27)
(cherry picked from commit a539ca32ec3a898e354aab90d899b99564064392)
- URL: https://github.com/kamailio/kamailio/commit/a5615fb833433eec6c9184ae8bfb245…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:06:05+02:00
topos: small rearangement by removing else after return in the true block
- reduce level of indentation
- a few wraps in curly braces for clearer view of the if block
(cherry picked from commit b6fccea258e56b7d3195659245713a6d44acb013)
(cherry picked from commit 772b464552cff0b9ebb769e57fae718c0357ba11)
(cherry picked from commit 0f31190eb15b1e1244f478cc9538bf071317cb35)
- URL: https://github.com/kamailio/kamailio/commit/fc9f03bf3f792acbc4ca4ae65881961…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:06:13+02:00
topos: properly handle cases of no user in contact for mode 1
- contact mode 1 accepted cases with no-user in contact uri but not in
r-uri, however, requests within dialog can have one's contact in r-uri
and then processing failed
(cherry picked from commit 24e410f9a20d004f55bcc79cd10fb35cb26e4570)
(cherry picked from commit 45ee72fcf0ae8aeb135196ef8729fe0cea14048e)
(cherry picked from commit 1666d4bce924b8c0d44119491199a164c9642469)
- URL: https://github.com/kamailio/kamailio/commit/ae9a257503fc78ad2f10691a14d2a23…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:06:30+02:00
keepalive: proper storing of last up/down timestamps
- GH #3790
(cherry picked from commit 9e2a0ee545646bd4491ecdbe58d7fea770764b54)
(cherry picked from commit 0b3aa00775a5c0b4b1dc4990f4c26bc637fc6de5)
(cherry picked from commit 6a9caa099352a31a2f14012d16c01d55c9250f02)
- URL: https://github.com/kamailio/kamailio/commit/5261da60ddfbfd6daf43469527b36f6…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:07:06+02:00
ndb_redis: fix index on parsing sentinel address inside redisc_reconnect_server()
(cherry picked from commit c8f3b496a05ae5bf29341dc7e2630f951d4effc5)
(cherry picked from commit 86df978bc9842687035d6673ee1b71e542dcbd71)
(cherry picked from commit 4cc28e453d8e62b9f6e2725b9496600c662a8811)
- URL: https://github.com/kamailio/kamailio/commit/768c7abe720848e48fcba61d7347d08…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:07:34+02:00
ctl: handle int input for double storage
(cherry picked from commit 1380a4a0d18159c7130b70c0216134a253ad83f7)
(cherry picked from commit 90f8117f9669069b4dab7e9d747dfa06245ec8a0)
(cherry picked from commit 29b6562d8ebe6277fda5524dda18b88cf2a4e1a9)
- URL: https://github.com/kamailio/kamailio/commit/54c1464db8d074415eeb01fcd0b71db…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:08:08+02:00
jansson: declare variables at the beginning of blocks
(cherry picked from commit a2bff77c3f7bfee8dae90c3ef20522d480f2e14d)
(cherry picked from commit fb685a8bd5d5e34edde44614f313cbb5c27b3c25)
- URL: https://github.com/kamailio/kamailio/commit/03e2c458f05dda76128be2031414a7f…
Author: Xenofon Karamanos <xk(a)gilawa.com>
Date: 2024-07-01T10:08:20+02:00
core: properly handle drop() action for kemi engines
- GH #3718
(cherry picked from commit 82593a09f8ef6d53e7e88238c057bbcdd9ab287b)
(cherry picked from commit 2758754f2bb427bff06b2a6e82175870eced336d)
- URL: https://github.com/kamailio/kamailio/commit/e325a662226888372e230421f5f7371…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:08:55+02:00
core: select - handle ws and wss inside select_ip_port()
(cherry picked from commit d8e0942c9e83c8cad7c182bf41c156ba35bf24d2)
(cherry picked from commit 089bf63178039b13cde0beccfacab1536af76179)
(cherry picked from commit cea618ede170bd02bb7ccd478a4f1a7a6c052cdf)
- URL: https://github.com/kamailio/kamailio/commit/44731d40834bcf75282c535a1770f4c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:09:07+02:00
core: parser rr - check for rr value before serializing
(cherry picked from commit 6ee26a3ae3293aaeb4507d5d0b16ad31173cc39a)
(cherry picked from commit 4626cb7f0e0b273153ce0004900a92553783a893)
(cherry picked from commit 92d3b52ca4595a7e4d8ab003951191c387d32eee)
- URL: https://github.com/kamailio/kamailio/commit/e4c30d23e87591c61e2c6684a44cd59…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:09:18+02:00
ctl: reset log prefix on reading ctl traffic
- it may be previously set in process by some event route
(cherry picked from commit 5b8b2717ee2f57da932132683b27eb33cea3fd59)
(cherry picked from commit d45c78eeeaea6a9fc9dcb927436f834392d9d7c9)
(cherry picked from commit d12613c8e357a8dc882eefe2d84fedd1df97a415)
- URL: https://github.com/kamailio/kamailio/commit/a507b2292724ca2e0426f986d422f60…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:09:31+02:00
acc: more log messages of failure arsing extra acc string
(cherry picked from commit 04a73ace6572dd5c95a8f50b39b2ce712f7ebe84)
(cherry picked from commit 91b0962679092f28abb5022d1505372356460f7d)
(cherry picked from commit f225edd2fdc87b0ebf72e15d8a11255ddd86b872)
- URL: https://github.com/kamailio/kamailio/commit/be6a52a7a685bfd3e3df595ae73030c…
Author: Elena-Ramona Modroiu <ramona(a)asipto.com>
Date: 2024-07-01T10:09:44+02:00
core: resolve/create_srv_pref_list() - insert at correct position in list
(cherry picked from commit f35cf8904119dcf582ea2451648de5fef095466b)
(cherry picked from commit dbf9208f3a402844c9981fb7ed09493a1338dfdd)
(cherry picked from commit c90b736a098e1d76224c1e97c2a71423efa5cf98)
- URL: https://github.com/kamailio/kamailio/commit/71db5b95b4b6125b1aa544efb459197…
Author: Elena-Ramona Modroiu <ramona(a)asipto.com>
Date: 2024-07-01T10:10:01+02:00
corex: fix conditions for dns_cache modparam srv attributes
(cherry picked from commit 8114b2016d032484edafe4edd04fb02d52cfd058)
(cherry picked from commit 3f44cabcfc0abc83ae1971ac74fbb0bd36829ce4)
(cherry picked from commit a82d1575d9ac7820e526741fc169033767a10ca5)
- URL: https://github.com/kamailio/kamailio/commit/980d823b7dd3d14b9656be1e1fc1526…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:10:12+02:00
smsops: reformat module exports structures
(cherry picked from commit 9848d43cb367d6901a0b8c727759feb8a8fad930)
(cherry picked from commit b21a7aaa467f2b76a52308557657c65274e34087)
(cherry picked from commit edbcfff018145372fd6fa5d1777912f0f84d8ea7)
- URL: https://github.com/kamailio/kamailio/commit/0df6e369d6cec014361c9808dd8eafa…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:10:22+02:00
smsops: short reference section about variables
(cherry picked from commit 9a94930ae1168d5df79e3dc1414841cdf23a2eba)
(cherry picked from commit c0c8ee05ab25256b9154d2056ee04b07f3f2290a)
(cherry picked from commit b3935051a8112b1a2152d8eb65da29b1941735df)
- URL: https://github.com/kamailio/kamailio/commit/17066ee9565105adabf6f4f8bcb650a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:10:30+02:00
blst: reformat exported structures
(cherry picked from commit e39557c96d2f419184c826d779f1a3309acc4269)
(cherry picked from commit e394a05152b29d4009c9cb963bced72526c7651b)
(cherry picked from commit f1969ecaacd47eb03ef6b54d71c70370d9e39150)
- URL: https://github.com/kamailio/kamailio/commit/a4b0da655bb0e9c64b8790d7b4801e4…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:10:40+02:00
sdpops: reformat the codecs map
(cherry picked from commit 359a442e14a156b0bcf60dc5b2580cbc57924e34)
(cherry picked from commit 855c76780c4399d6d9881ce3c525a7df56e111c4)
(cherry picked from commit 8bb69fd5f5911098a3e567887ad2a3a2820ae5e6)
- URL: https://github.com/kamailio/kamailio/commit/42669bec9c3f3ed75c010f645dddbe5…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:11:23+02:00
core: fmsg - parse loopback ip when initializing faked msg structure
- GH #3817
(cherry picked from commit 66b3c04a9653425b1602c82dd2456a7eb7cf59d1)
(cherry picked from commit 794c2edeaffe059bf8de6ab1d3df5db003ed4cb0)
(cherry picked from commit 365bb5d7fd1534e467f8a2d1b120f2c03fc4caff)
- URL: https://github.com/kamailio/kamailio/commit/ac221658e9227ec8f04a6a3bef677a8…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:11:43+02:00
phonenum: Makefile - option to set C standard version
- can be set via option CSTDVER
- defaults now to c++17
- GH #3659
(cherry picked from commit 6dd5598fc043fe3d2582e643d7d4ef675c9e6480)
(cherry picked from commit bec4ad646f127a1f5bbf31604e6185b246867770)
- URL: https://github.com/kamailio/kamailio/commit/824a1ce63b974256e6a5e8fdfe8a0f5…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:14:08+02:00
htable: error on not finding htable in pv set
(cherry picked from commit 82cfea317fd8d02a6c94347bc1be18c8a06e580f)
(cherry picked from commit 9a7e3e54f1c52ee69c68b1165de115894c2afc55)
(cherry picked from commit 239153a860875aba578ba060241fcb419ad98276)
- URL: https://github.com/kamailio/kamailio/commit/cc245af6947ac19d53abd3743c8a3f2…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:14:14+02:00
htable: error on not finding htable in pv get
(cherry picked from commit 24b27214231166366cceb88fcb3724298cc53b32)
(cherry picked from commit 7087ce6aa496de9b6015e5054d8fd70bf2e055b3)
(cherry picked from commit 5da78f619c747edb674970b87426582b90c8bae3)
- URL: https://github.com/kamailio/kamailio/commit/32f92d102325eed041d242aa27837df…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:14:23+02:00
siputils: free head of params list for get_uri_param()
- GH #3857
(cherry picked from commit d72a3fbc903da02ae3b26f3aae2ea228c9f8b255)
(cherry picked from commit 833b93563f43fa95e4bfdd175b144670b66a11cd)
(cherry picked from commit 5da933f3888ab3981fa8ec4ad255a4e8f3770d2d)
- URL: https://github.com/kamailio/kamailio/commit/d90e956f01ba8124d65d6fd6c3de7d3…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:14:30+02:00
siputils: free head of params list for get_uri_param()
- GH #3857
(cherry picked from commit 8363208fff7c101a2779ff64783e5b7dbf8ffd7c)
(cherry picked from commit ebc8acef7617a69dcc06b163c47e88a99d835f9e)
(cherry picked from commit d503c70bbc9790073424630ce842b1987cbe2a7c)
- URL: https://github.com/kamailio/kamailio/commit/d19843d691e8dc281dd5e49d516ab2c…
Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Date: 2024-07-01T10:14:52+02:00
core/resolve: Check dns_cache_init and choose appropriate functions
(cherry picked from commit 06d583e356351ae9d8a559c9f5de3e57fb128a38)
(cherry picked from commit 5999529be9ac2187dad465518bea3dee1b06d0f7)
(cherry picked from commit 22a28b0b0e7f66a8e73d92fcc5f014f722aa2d1f)
- URL: https://github.com/kamailio/kamailio/commit/c8c77bebb2c17ad3da5e2cdff467ab5…
Author: codenot <codenot(a)msn.com>
Date: 2024-07-01T10:15:04+02:00
nathelper: fixed handle_ruri_alias_mode(1) cannot proper handle multi alias
(cherry picked from commit 8e0b2e4b6450fa50bd573fa013dc888aaaccd2bf)
(cherry picked from commit eb4ec6f9305e334d9749e1fd56ad195c383cef77)
(cherry picked from commit 8d1f1843f04d9e1a6db983bf860c76f7a1ac4b40)
- URL: https://github.com/kamailio/kamailio/commit/bf5012af8958d3223d54a3021af7eea…
Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Date: 2024-07-01T10:15:11+02:00
nathelper: remove magic constant
(cherry picked from commit 3d187336f22e30800acefd28e4d0f98e0f677a49)
(cherry picked from commit e8dc8506dbc4d8964e02c3be175d7f18f5fe69a4)
(cherry picked from commit a11e8ae3f8daae13ba6b162ab050bb7d8c8bd01b)
- URL: https://github.com/kamailio/kamailio/commit/e5480572223b3d235762f4b1d773d9e…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:15:25+02:00
dmq_usrloc: reformat exported structures
(cherry picked from commit e94812149c6f2867a5b23f1218a9af139590bf51)
(cherry picked from commit 5571ea0ff8877a8a19b3fb76030af19b59f141db)
(cherry picked from commit b1ffd5982329cda6d1e5da008703fe302402ee36)
- URL: https://github.com/kamailio/kamailio/commit/bf1306430f26525f78571e93662767f…
Author: Dennis Yurasov <dennis-y(a)yandex-team.ru>
Date: 2024-07-01T10:15:42+02:00
siptrace: add SND_F_FORCE_SOCKET flag if send_sock_name/send_sock_address config parameters are used
- send_sock_name/send_sock_address is ineffective for tcp based transports if SND_F_FORCE_SOCKET flag is not set
(cherry picked from commit 1b97a0271b27794263b3eff61f4acfa81e66069f)
(cherry picked from commit 2606c4e07e598ea41cb5a8814e3587bf49f94c1e)
(cherry picked from commit eed224e4906b6691d07ea379727e2ed627c3e80f)
- URL: https://github.com/kamailio/kamailio/commit/12ace0b9d8214575ce9b1f5f4947004…
Author: Dragos Vingarzan <vingarzan(a)gmail.com>
Date: 2024-07-01T10:15:51+02:00
textopx/doc: fixed hard-to-read documentation for textopsx
- was missing line-wraps in examples list, hence very hard to read
(cherry picked from commit 48d97c1941f660aa396b5ef100584611cf92ad21)
(cherry picked from commit 7bf787d00f9f7ed8a2d758219d6d1413b2b5c975)
(cherry picked from commit e017ae88c155c2bd60a9611bca676308695f3c75)
- URL: https://github.com/kamailio/kamailio/commit/2ca23caf6c6766a7268ba51f6f67d11…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:15:58+02:00
textopsx: docs - note about @hf_value2 select
(cherry picked from commit d13c741d90c3887cdf144a9094a78c0c7cb9856d)
(cherry picked from commit 70cf3ebd2b52c341a90c9b9b6149985667a6b96c)
(cherry picked from commit a0cef6e8689b66f7548fe56eaa79e692d5061e93)
- URL: https://github.com/kamailio/kamailio/commit/57003d4382ad5e2e1ea1163005ede0c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:16:06+02:00
core: removed duplicated break
(cherry picked from commit 588b9c710b6555371bc8bbee21e474466bb099dd)
(cherry picked from commit 4fa5fc10370d81d534d75b034322a6250c7e2557)
(cherry picked from commit 1bd30c65b74b30339841c57d2948ea7db9a40fe9)
- URL: https://github.com/kamailio/kamailio/commit/559cbb1ea5f0b7da95fc6a864e0e9d0…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T10:16:16+02:00
cnxcc: check if final pulse is 0
- avoid dividing with it in such case
- GH #3859
(cherry picked from commit 7061a79fe64066dd5a6598e38d714bd40bf2eabc)
(cherry picked from commit ca3d4b3515024732805038509dd0d9f0b60ab273)
(cherry picked from commit a9a337562d1b57afedb31d49764e03c7ebd85f31)
[View Less]
Module: kamailio
Branch: 5.7
Commit: 4d1c41f2af5279f6ffbcba59f5b51e06989ba66d
URL: https://github.com/kamailio/kamailio/commit/4d1c41f2af5279f6ffbcba59f5b51e0…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-07-01T10:01:27+02:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/textopsx/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]4d1c41f2af5279f6ffbcba59f5b51e0…
Patch: https://github.com/kamailio/kamailio/commit/4d1c41f2af5279f6ffbcba59f5b51e0…
---
diff --git a/src/modules/textopsx/README b/src/modules/textopsx/README
index fa03fdf7b26..6941def2d83 100644
--- a/src/modules/textopsx/README
+++ b/src/modules/textopsx/README
@@ -731,27 +731,38 @@ bl_iterator_end("b1");
3.1. @hf_value
- Get value of required header-value or param. Note that functions called
- 'value2' works with Authorization-like headers where comma is not
- treated as value delimiter. Formats: @hf_value.HFNAME[IDX] # idx value,
- negative value counts from bottom @hf_value.HFNAME.PARAM_NAME
- @hf_value.HFNAME[IDX].PARAM_NAME @hf_value.HFNAME.p.PARAM_NAME # or
- .param., useful if required called "uri", "p", "param"
- @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto @hf_value.HFNAME[IDX].uri #
- (< & > excluded) @hf_value.HFNAME[*] # return comma delimited list of
- all values (combines headers) @hf_value.HFNAME # the same as above [*]
- but may be parsed by cfg.y @hf_value.HFNAME[*].uri # return comma
- delimited list of uris (< & > excluded) @hf_value.HFNAME.uri # the same
- as above [*] but may be parsed by cfg.y @hf_value.HFNAME[IDX].name #
- returns name part, quotes excluded @hf_value.HFNAME.name # returns name
- part of the first value @hf_value2.HFNAME # returns value of first
- header @hf_value2.HFNAME[IDX] # returns value of idx's header
- @hf_value2.HFNAME.PARAM_NAME @hf_value2.HFNAME[IDX].PARAM_NAME
- @hf_value.HFNAME[IDX].uri # return URI, quotes excluded
- @hf_value.HFNAME.p.uri # returns param named uri, not URI itself
- @hf_value.HFNAME.p.name # returns param named name, not name itself
- @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be
- used @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr
+ Get value of required header-value or param. Note that selects called
+ 'hf_value2' work with Authorization-like headers where comma is not
+ treated as value delimiter.
+
+ Formats:
+ * @hf_value.HFNAME[IDX] # idx value, negative value counts from
+ bottom
+ * @hf_value.HFNAME.PARAM_NAME
+ * @hf_value.HFNAME[IDX].PARAM_NAME
+ * @hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required
+ called "uri", "p", "param"
+ * @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto
+ * @hf_value.HFNAME[IDX].uri # (< & > excluded)
+ * @hf_value.HFNAME[*] # return comma delimited list of all values
+ (combines headers)
+ * @hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y
+ * @hf_value.HFNAME[*].uri # return comma delimited list of uris (< &
+ > excluded)
+ * @hf_value.HFNAME.uri # the same as above [*] but may be parsed by
+ cfg.y
+ * @hf_value.HFNAME[IDX].name # returns name part, quotes excluded
+ * @hf_value.HFNAME.name # returns name part of the first value
+ * @hf_value2.HFNAME # returns value of first header
+ * @hf_value2.HFNAME[IDX] # returns value of idx's header
+ * @hf_value2.HFNAME.PARAM_NAME
+ * @hf_value2.HFNAME[IDX].PARAM_NAME
+ * @hf_value.HFNAME[IDX].uri # return URI, quotes excluded
+ * @hf_value.HFNAME.p.uri # returns param named uri, not URI itself
+ * @hf_value.HFNAME.p.name # returns param named name, not name itself
+ * @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features
+ may be used
+ * @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr
Meaning of the parameters is as follows:
* HFNAME - Header field name. Underscores are treated as dashes.
@@ -772,7 +783,9 @@ $prt = @hf_value2.authorization.integrity_protected;
3.2. @hf_value2
- TBA.
+ Similar to selects called 'hf_value', but work with Authorization-like
+ headers where comma is treated as attribute delimiter instead of header
+ value delimiter.
3.3. @hf_value_exists
[View Less]
Module: kamailio
Branch: 5.8
Commit: 3161964efba19e5e7bd730bf656d019cac2c6ed8
URL: https://github.com/kamailio/kamailio/commit/3161964efba19e5e7bd730bf656d019…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-07-01T09:16:18+02:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/textopsx/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]3161964efba19e5e7bd730bf656d019…
Patch: https://github.com/kamailio/kamailio/commit/3161964efba19e5e7bd730bf656d019…
---
diff --git a/src/modules/textopsx/README b/src/modules/textopsx/README
index 1759870cb2f..3e2f9e2eb6b 100644
--- a/src/modules/textopsx/README
+++ b/src/modules/textopsx/README
@@ -731,27 +731,38 @@ bl_iterator_end("b1");
3.1. @hf_value
- Get value of required header-value or param. Note that functions called
- 'value2' works with Authorization-like headers where comma is not
- treated as value delimiter. Formats: @hf_value.HFNAME[IDX] # idx value,
- negative value counts from bottom @hf_value.HFNAME.PARAM_NAME
- @hf_value.HFNAME[IDX].PARAM_NAME @hf_value.HFNAME.p.PARAM_NAME # or
- .param., useful if required called "uri", "p", "param"
- @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto @hf_value.HFNAME[IDX].uri #
- (< & > excluded) @hf_value.HFNAME[*] # return comma delimited list of
- all values (combines headers) @hf_value.HFNAME # the same as above [*]
- but may be parsed by cfg.y @hf_value.HFNAME[*].uri # return comma
- delimited list of uris (< & > excluded) @hf_value.HFNAME.uri # the same
- as above [*] but may be parsed by cfg.y @hf_value.HFNAME[IDX].name #
- returns name part, quotes excluded @hf_value.HFNAME.name # returns name
- part of the first value @hf_value2.HFNAME # returns value of first
- header @hf_value2.HFNAME[IDX] # returns value of idx's header
- @hf_value2.HFNAME.PARAM_NAME @hf_value2.HFNAME[IDX].PARAM_NAME
- @hf_value.HFNAME[IDX].uri # return URI, quotes excluded
- @hf_value.HFNAME.p.uri # returns param named uri, not URI itself
- @hf_value.HFNAME.p.name # returns param named name, not name itself
- @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be
- used @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr
+ Get value of required header-value or param. Note that selects called
+ 'hf_value2' work with Authorization-like headers where comma is not
+ treated as value delimiter.
+
+ Formats:
+ * @hf_value.HFNAME[IDX] # idx value, negative value counts from
+ bottom
+ * @hf_value.HFNAME.PARAM_NAME
+ * @hf_value.HFNAME[IDX].PARAM_NAME
+ * @hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required
+ called "uri", "p", "param"
+ * @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto
+ * @hf_value.HFNAME[IDX].uri # (< & > excluded)
+ * @hf_value.HFNAME[*] # return comma delimited list of all values
+ (combines headers)
+ * @hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y
+ * @hf_value.HFNAME[*].uri # return comma delimited list of uris (< &
+ > excluded)
+ * @hf_value.HFNAME.uri # the same as above [*] but may be parsed by
+ cfg.y
+ * @hf_value.HFNAME[IDX].name # returns name part, quotes excluded
+ * @hf_value.HFNAME.name # returns name part of the first value
+ * @hf_value2.HFNAME # returns value of first header
+ * @hf_value2.HFNAME[IDX] # returns value of idx's header
+ * @hf_value2.HFNAME.PARAM_NAME
+ * @hf_value2.HFNAME[IDX].PARAM_NAME
+ * @hf_value.HFNAME[IDX].uri # return URI, quotes excluded
+ * @hf_value.HFNAME.p.uri # returns param named uri, not URI itself
+ * @hf_value.HFNAME.p.name # returns param named name, not name itself
+ * @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features
+ may be used
+ * @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr
Meaning of the parameters is as follows:
* HFNAME - Header field name. Underscores are treated as dashes.
@@ -772,7 +783,9 @@ $prt = @hf_value2.authorization.integrity_protected;
3.2. @hf_value2
- TBA.
+ Similar to selects called 'hf_value', but work with Authorization-like
+ headers where comma is treated as attribute delimiter instead of header
+ value delimiter.
3.3. @hf_value_exists
[View Less]
Module: kamailio
Branch: 5.8
Commit: 70cf3ebd2b52c341a90c9b9b6149985667a6b96c
URL: https://github.com/kamailio/kamailio/commit/70cf3ebd2b52c341a90c9b9b6149985…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T09:11:16+02:00
textopsx: docs - note about @hf_value2 select
(cherry picked from commit d13c741d90c3887cdf144a9094a78c0c7cb9856d)
---
Modified: src/modules/textopsx/doc/selects.xml
---
Diff: …
[View More]https://github.com/kamailio/kamailio/commit/70cf3ebd2b52c341a90c9b9b6149985…
Patch: https://github.com/kamailio/kamailio/commit/70cf3ebd2b52c341a90c9b9b6149985…
---
diff --git a/src/modules/textopsx/doc/selects.xml b/src/modules/textopsx/doc/selects.xml
index 3c72c21cd36..dd3ea3f7a62 100644
--- a/src/modules/textopsx/doc/selects.xml
+++ b/src/modules/textopsx/doc/selects.xml
@@ -8,8 +8,8 @@
<section id="textopsx.sel.hf_value">
<title>@hf_value</title>
<para>
- Get value of required header-value or param. Note that functions called 'value2'
- works with Authorization-like headers where comma is not treated as value delimiter.
+ Get value of required header-value or param. Note that selects called 'hf_value2'
+ work with Authorization-like headers where comma is not treated as value delimiter.
</para>
<para>
Formats:
@@ -73,7 +73,9 @@ $prt = @hf_value2.authorization.integrity_protected;
<section id="textopsx.sel.hf_value2">
<title>@hf_value2</title>
<para>
- TBA.
+ Similar to selects called 'hf_value', but work with Authorization-like
+ headers where comma is treated as attribute delimiter instead of header
+ value delimiter.
</para>
</section>
<section id="textopsx.sel.hf_value_exists">
[View Less]
Module: kamailio
Branch: 5.8
Commit: 7bf787d00f9f7ed8a2d758219d6d1413b2b5c975
URL: https://github.com/kamailio/kamailio/commit/7bf787d00f9f7ed8a2d758219d6d141…
Author: Dragos Vingarzan <vingarzan(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-01T09:10:51+02:00
textopx/doc: fixed hard-to-read documentation for textopsx
- was missing line-wraps in examples list, hence very hard to read
(cherry picked from commit …
[View More]48d97c1941f660aa396b5ef100584611cf92ad21)
---
Modified: src/modules/textopsx/doc/selects.xml
---
Diff: https://github.com/kamailio/kamailio/commit/7bf787d00f9f7ed8a2d758219d6d141…
Patch: https://github.com/kamailio/kamailio/commit/7bf787d00f9f7ed8a2d758219d6d141…
---
diff --git a/src/modules/textopsx/doc/selects.xml b/src/modules/textopsx/doc/selects.xml
index 6d4dd4e3a25..3c72c21cd36 100644
--- a/src/modules/textopsx/doc/selects.xml
+++ b/src/modules/textopsx/doc/selects.xml
@@ -9,30 +9,35 @@
<title>@hf_value</title>
<para>
Get value of required header-value or param. Note that functions called 'value2'
- works with Authorization-like headers where comma is not treated as value delimiter. Formats:
- @hf_value.HFNAME[IDX] # idx value, negative value counts from bottom
- @hf_value.HFNAME.PARAM_NAME
- @hf_value.HFNAME[IDX].PARAM_NAME
- @hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required called "uri", "p", "param"
- @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto
- @hf_value.HFNAME[IDX].uri # (< & > excluded)
- @hf_value.HFNAME[*] # return comma delimited list of all values (combines headers)
- @hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y
- @hf_value.HFNAME[*].uri # return comma delimited list of uris (< & > excluded)
- @hf_value.HFNAME.uri # the same as above [*] but may be parsed by cfg.y
- @hf_value.HFNAME[IDX].name # returns name part, quotes excluded
- @hf_value.HFNAME.name # returns name part of the first value
+ works with Authorization-like headers where comma is not treated as value delimiter.
+ </para>
+ <para>
+ Formats:
+ <itemizedlist>
+ <listitem>@hf_value.HFNAME[IDX] # idx value, negative value counts from bottom</listitem>
+ <listitem>@hf_value.HFNAME.PARAM_NAME</listitem>
+ <listitem>@hf_value.HFNAME[IDX].PARAM_NAME</listitem>
+ <listitem>@hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required called "uri", "p", "param"</listitem>
+ <listitem>@hf_value.HFNAME[IDX].p.PARAM_NAME # dtto</listitem>
+ <listitem>@hf_value.HFNAME[IDX].uri # (< & > excluded)</listitem>
+ <listitem>@hf_value.HFNAME[*] # return comma delimited list of all values (combines headers)</listitem>
+ <listitem>@hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y</listitem>
+ <listitem>@hf_value.HFNAME[*].uri # return comma delimited list of uris (< & > excluded)</listitem>
+ <listitem>@hf_value.HFNAME.uri # the same as above [*] but may be parsed by cfg.y</listitem>
+ <listitem>@hf_value.HFNAME[IDX].name # returns name part, quotes excluded</listitem>
+ <listitem>@hf_value.HFNAME.name # returns name part of the first value</listitem>
- @hf_value2.HFNAME # returns value of first header
- @hf_value2.HFNAME[IDX] # returns value of idx's header
- @hf_value2.HFNAME.PARAM_NAME
- @hf_value2.HFNAME[IDX].PARAM_NAME
+ <listitem>@hf_value2.HFNAME # returns value of first header</listitem>
+ <listitem>@hf_value2.HFNAME[IDX] # returns value of idx's header</listitem>
+ <listitem>@hf_value2.HFNAME.PARAM_NAME</listitem>
+ <listitem>@hf_value2.HFNAME[IDX].PARAM_NAME</listitem>
- @hf_value.HFNAME[IDX].uri # return URI, quotes excluded
- @hf_value.HFNAME.p.uri # returns param named uri, not URI itself
- @hf_value.HFNAME.p.name # returns param named name, not name itself
- @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be used
- @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr
+ <listitem>@hf_value.HFNAME[IDX].uri # return URI, quotes excluded</listitem>
+ <listitem>@hf_value.HFNAME.p.uri # returns param named uri, not URI itself</listitem>
+ <listitem>@hf_value.HFNAME.p.name # returns param named name, not name itself</listitem>
+ <listitem>@hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be used</listitem>
+ <listitem>@hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr</listitem>
+ </itemizedlist>
</para>
<para>Meaning of the parameters is as follows:</para>
<itemizedlist>
[View Less]
### Description
When using the RPC command `rtpengine.show`, the resulting list has the field `disabled` for each RTPEngine configured, and its value - for some reason can be either `0` (number), `1` (number) or `"1(permanent)"` (string).
For example:
```
$ curl -k -X POST -HContent-Type:application/json -d '{"jsonrpc":"2.0","method":"rtpengine.show","params":["all"],"id":1}' https://localhost:8443/rpc
{
"jsonrpc": "2.0",
"result": [{
"url": …
[View More] "udp:old-rtpengine2227",
"set": 0,
"index": 0,
"weight": 1,
"disabled": 1,
"recheck_ticks": 0
}, {
"url": "udp:172.24.73.28:2227",
"set": 0,
"index": 1,
"weight": 1,
"disabled": 0,
"recheck_ticks": 0
}, {
"url": "udp:172.24.75.15:2227",
"set": 0,
"index": 2,
"weight": 1,
"disabled": "1(permanent)",
"recheck_ticks": "N/A"
}],
"id": 1
}
```
This makes it very annoying to parse the results from JSON RPC (and maybe other machine readable RPC APIs). Also the same problem for `recheck_ticks`, but I never actually read it so it is less important for me.
#### Reproduction
The difference between `0` and `"1(permanent)"` can be seen by setting up multiple RTPEngine sockets that work and then disable one of the using the `rtpengine.enable` RPC command with the `flag` set to `0`. As far as I can tell that is the only way to get `recheck_ticks` to be set to `RTPENGINE_MAX_RECHECK_TICKS` which causes the "permanently disabled" state.
### Possible Solutions
I can try to offer a patch, but any change I can make will be a breaking API change - so if users are relying on this weird behavior, that could be a problem.
Maybe the best way to move forward is to expose two additional fields:
- `active` : `boolean` - set to `true` if the RTPEngine is not disabled, and to `false` if it is disabled (i.e. the value is equal to `disabled == 0`).
- `active` : `boolean` - set to `true` if the RTPEngine had not failed it checks (i.e. `recheck_ticks` is either 0 or `RTPENGINE_MAX_RECHECK_TICKS`). This will be set to `false` if `disabled` is set to `1`, and not `"1(permanent)"`.
Maybe the last field is unneeded? Maybe `"disabled"` can be changed to only report whether the RPC was used to disable the socket and let the `active` field specify whether the socket can be used?
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.7.5 (x86_64/linux) 58499a
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 58499a
compiled on 00:00:00 Sep 13 2022 with gcc 11.4.1
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
$ uname -a
Linux sip-172-24-50-23.XX.XX.XX 6.5.0-1020-aws #20~22.04.1-Ubuntu SMP Wed May 1 16:10:50 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
$ cat /etc/os-release
NAME="AlmaLinux"
VERSION="9.4 (Seafoam Ocelot)"
ID="almalinux"
ID_LIKE="rhel centos fedora"
VERSION_ID="9.4"
PLATFORM_ID="platform:el9"
PRETTY_NAME="AlmaLinux 9.4 (Seafoam Ocelot)"
ANSI_COLOR="0;34"
LOGO="fedora-logo-icon"
CPE_NAME="cpe:/o:almalinux:almalinux:9::baseos"
HOME_URL="https://almalinux.org/"
DOCUMENTATION_URL="https://wiki.almalinux.org/"
BUG_REPORT_URL="https://bugs.almalinux.org/"
ALMALINUX_MANTISBT_PROJECT="AlmaLinux-9"
ALMALINUX_MANTISBT_PROJECT_VERSION="9.4"
REDHAT_SUPPORT_PRODUCT="AlmaLinux"
REDHAT_SUPPORT_PRODUCT_VERSION="9.4"
SUPPORT_END=2032-06-01
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3896
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3896(a)github.com>
[View Less]
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature …
[View More](non-breaking change which adds new functionality)
- [x] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #3896
#### Description
As per issue #3896, "active" is a boolean field that just describes whether the socket will be used, while "disabled" now just describes whether the socket was disabled by an RPC command. Also make "disabled" and "recheck_ticks" fields have a fixed value type of boolean and number respectively.
use `"recheck_ticks": -1` instead of "N/A" as per discussion.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3898
-- Commit Summary --
* rtpengine: add "active" field to rtpengine.show as alternate of "disabled"
-- File Changes --
M src/modules/rtpengine/rtpengine.c (7)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3898.patchhttps://github.com/kamailio/kamailio/pull/3898.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3898
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3898(a)github.com>
[View Less]
Hey everybody,
While attempting to use the official Ubuntu package for Kamailio version 5.7.4 on Ubunut 24.04, we encountered an issue where TLS functionality does not seem to work as expected but 5.8 branch does.
Given this, I am inquiring about the availability and status of Kamailio packages for Ubuntu 24.04 on the official Kamailio repository at deb.kamailio.org. Are there any plans to support this version of Ubuntu with updated packages? If so, is there an estimated timeline for when these …
[View More]packages might become available?
Thank you in advance for your assistance.
Best regards,
Xenofon
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev…
[View More]Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
Hi, I ran into an issue where the Kamailio service seemingly froze (didn't crash, but failed to receive and deliver calls) while running, I went through the logs a little bit, and saw the same log pattern (pasted below) recouring every few months or so, on an older installation (5.2.0). Usually, it ended up automatically restarting the service. But not this time, I had to reload it manually to make the service work again.
Is this a known issue?
How can I make sure that the service will be able to restart the next time it happens?
Edward
### Troubleshooting
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
GNU gdb (Ubuntu 7.11.1-0ubuntu1~16.5) 7.11.1
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /usr/local/sbin/kamailio...done.
warning: exec file is newer than core file.
[New LWP 11413]
Core was generated by `kamailio'.
Program terminated with signal SIGABRT, Aborted.
#0 0x00007f4e4a52e428 in ?? ()
(gdb) Quit
(gdb) bt full
#0 0x00007f4e4a52e428 in ?? ()
No symbol table info available.
#1 0x00007f4e4a53002a in ?? ()
No symbol table info available.
#2 0x0000000000000020 in ?? ()
No symbol table info available.
#3 0x0000000000000000 in ?? ()
No symbol table info available.
(gdb) info locals
No symbol table info available.
(gdb) list
1871 & now if we don't need it */
1872 #ifdef USE_SLOW_TIMER
1873 + 1 /* slow timer process */
1874 #endif
1875 #ifdef USE_TCP
1876 +((!tcp_disable)?( 1/* tcp main */ + tcp_listeners ):0)
1877 #endif
1878 #ifdef USE_SCTP
1879 +((!sctp_disable)?sctp_listeners:0)
1880 #endif
(gdb)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
Jun 28 16:35:22 kamprodegres kamailio: INFO: <core> [core/sctp_core.c:74]: sctp_core_check_support(): SCTP API not enabled - if you want to use it, load sctp module
Jun 28 16:35:22 kamprodegres kamailio: WARNING: <core> [core/socket_info.c:1394]: fix_hostname(): could not rev. resolve 70.36.25.87
Jun 28 16:35:22 kamprodegres kamailio: WARNING: <core> [core/socket_info.c:1394]: fix_hostname(): could not rev. resolve 70.36.25.87
Jun 28 16:35:22 kamprodegres kamailio: INFO: <core> [core/tcp_main.c:5042]: init_tcp(): using epoll_lt as the io watch method (auto detected)
Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: jsonrpcs [jsonrpcs_sock.c:197]: jsonrpc_dgram_mod_init(): the socket /var/run/kamailio/kamailio_rpc.sock already exists, trying to delete it...
Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: rr [../outbound/api.h:52]: ob_load_api(): unable to import bind_ob - maybe module is not loaded
Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: rr [rr_mod.c:177]: mod_init(): outbound module not available
Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [main.c:2779]: main(): processes (at least): 40 - shm size: 67108864 - pkg size: 8388608
Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992
Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984
Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992
Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984
Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992
Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984
Jun 28 16:35:22 kamprodegres kamailio[8518]: INFO: jsonrpcs [jsonrpcs_sock.c:443]: jsonrpc_dgram_process(): a new child 0/8518
Jun 28 16:35:22 kamprodegres kamailio[8519]: INFO: ctl [io_listener.c:214]: io_listen_loop(): io_listen_loop: using epoll_lt io watch method (config)
Jun 29 18:13:37 kamprodegres kamailio[8513]: INFO: {1 581461 CANCEL 402954192_49936786(a)67.231.13.146} tm [t_reply.c:478]: _reply_light(): can't generate 487 reply when a final 404 was sent out
Jun 29 18:27:00 kamprodegres kamailio[8508]: INFO: {1 211236 CANCEL 405019408_127896329(a)67.231.13.146} tm [t_reply.c:478]: _reply_light(): can't generate 487 reply when a final 404 was sent out
Jun 29 18:51:10 kamprodegres /usr/local/sbin/kamailio[2269]: NOTICE: <core> [main.c:725]: handle_sigs(): Thank you for flying kamailio!!!
Jun 29 18:51:10 kamprodegres /usr/local/sbin/kamailio[2326]: INFO: <core> [main.c:847]: sig_usr(): signal 15 received
```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.3.2 (x86_64/linux) 7ba545
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 7ba545
compiled on 16:37:32 Jun 14 2020 with gcc 5.4.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
Ubuntu 16.04
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2380
[View Less]
### Description
When I set up Kamailio, it is not easy to configure, monitor, and register visually.
There are compatibility issues with the older versions of Siremis components mentioned in the guide, and there are many problems in initialization and deployment that cannot be matched with the latest version.
Any other web management tools suggestions?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3881
You are receiving this because you …
[View More]are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3881(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 8df69ebca23bde071b08b0ed5b8cd34b2d28446b
URL: https://github.com/kamailio/kamailio/commit/8df69ebca23bde071b08b0ed5b8cd34…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-06-25T13:00:08+02:00
pv: docs for xavp_xparams_explode(...)
---
Modified: src/modules/pv/doc/pv_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/8df69ebca23bde071b08b0ed5b8cd34……
[View More]Patch: https://github.com/kamailio/kamailio/commit/8df69ebca23bde071b08b0ed5b8cd34…
---
diff --git a/src/modules/pv/doc/pv_admin.xml b/src/modules/pv/doc/pv_admin.xml
index 1f91e633a00..6a06bb717de 100644
--- a/src/modules/pv/doc/pv_admin.xml
+++ b/src/modules/pv/doc/pv_admin.xml
@@ -387,6 +387,39 @@ xavp_params_explode("a=b;c=d;e=d", "x");
# $xavp(x=>a) = "b";
# $xavp(x=>c) = "d";
# $xavp(x=>e) = "f";
+...
+ </programlisting>
+ </example>
+ </section>
+ <section id="pv.f.xavp_xparams_explode">
+ <title>
+ <function moreinfo="none">xavp_xparams_explode(sparams, sep, xname)</function>
+ </title>
+ <para>
+ Convert a parameters string in xavp attributes.
+ </para>
+ <para>
+ The first parameter has to be a string in similar format of SIP header
+ parameters (name1=value1;...;nameN=valueN), but the separator can
+ be other character than ';'. The second parameter is the separator
+ for the parameters list. The third parameter is the name of the
+ root xavp to hold the pairs (nameX,valueX).
+ </para>
+ <para>
+ The values are stored as string type.
+ </para>
+ <para>
+ Function can be used from ANY ROUTE.
+ </para>
+ <example>
+ <title><function>xavp_xparams_explode</function> usage</title>
+ <programlisting format="linespecific">
+...
+xavp_xparams_explode("a=b,c=d,e=d", ",", "x");
+# results in:
+# $xavp(x=>a) = "b";
+# $xavp(x=>c) = "d";
+# $xavp(x=>e) = "f";
...
</programlisting>
</example>
@@ -1132,4 +1165,3 @@ $ &kamcmd; pv.shvGet debug
</section>
</chapter>
-
[View Less]
I just study and work with Kamailio . I have a issue about listening port . Please help me.
I install kamailio in centos 9 stream with version 5.6.5 when start call sometime, my system established connect from google dns (8.8.8.8:53) to kamailio with random port and it do call fail (not reply when receive invite ). please help me and i attatch screenshot
github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 54aa2eac1a8c60e0741a5616e79b7b03e1e213e5
URL: https://github.com/kamailio/kamailio/commit/54aa2eac1a8c60e0741a5616e79b7b0…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-06-23T12:01:10+02:00
modules: readme files regenerated - textopsx ... [skip ci]
---
Modified: src/modules/textopsx/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]54aa2eac1a8c60e0741a5616e79b7b0…
Patch: https://github.com/kamailio/kamailio/commit/54aa2eac1a8c60e0741a5616e79b7b0…
---
diff --git a/src/modules/textopsx/README b/src/modules/textopsx/README
index 7c6bc59df14..5344e15043d 100644
--- a/src/modules/textopsx/README
+++ b/src/modules/textopsx/README
@@ -753,8 +753,8 @@ bl_iterator_end("b1");
3.1. @hf_value
- Get value of required header-value or param. Note that functions called
- 'value2' works with Authorization-like headers where comma is not
+ Get value of required header-value or param. Note that selects called
+ 'hf_value2' work with Authorization-like headers where comma is not
treated as value delimiter.
Formats:
@@ -805,7 +805,9 @@ $prt = @hf_value2.authorization.integrity_protected;
3.2. @hf_value2
- TBA.
+ Similar to selects called 'hf_value', but work with Authorization-like
+ headers where comma is treated as attribute delimiter instead of header
+ value delimiter.
3.3. @hf_value_exists
[View Less]
Module: kamailio
Branch: master
Commit: d13c741d90c3887cdf144a9094a78c0c7cb9856d
URL: https://github.com/kamailio/kamailio/commit/d13c741d90c3887cdf144a9094a78c0…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-06-23T11:52:34+02:00
textopsx: docs - note about @hf_value2 select
---
Modified: src/modules/textopsx/doc/selects.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]d13c741d90c3887cdf144a9094a78c0…
Patch: https://github.com/kamailio/kamailio/commit/d13c741d90c3887cdf144a9094a78c0…
---
diff --git a/src/modules/textopsx/doc/selects.xml b/src/modules/textopsx/doc/selects.xml
index 3c72c21cd36..dd3ea3f7a62 100644
--- a/src/modules/textopsx/doc/selects.xml
+++ b/src/modules/textopsx/doc/selects.xml
@@ -8,8 +8,8 @@
<section id="textopsx.sel.hf_value">
<title>@hf_value</title>
<para>
- Get value of required header-value or param. Note that functions called 'value2'
- works with Authorization-like headers where comma is not treated as value delimiter.
+ Get value of required header-value or param. Note that selects called 'hf_value2'
+ work with Authorization-like headers where comma is not treated as value delimiter.
</para>
<para>
Formats:
@@ -73,7 +73,9 @@ $prt = @hf_value2.authorization.integrity_protected;
<section id="textopsx.sel.hf_value2">
<title>@hf_value2</title>
<para>
- TBA.
+ Similar to selects called 'hf_value', but work with Authorization-like
+ headers where comma is treated as attribute delimiter instead of header
+ value delimiter.
</para>
</section>
<section id="textopsx.sel.hf_value_exists">
[View Less]
Module: kamailio
Branch: master
Commit: eaf18505360a3bbaf25889095fcf23b620caedff
URL: https://github.com/kamailio/kamailio/commit/eaf18505360a3bbaf25889095fcf23b…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-06-21T13:01:09+02:00
modules: readme files regenerated - textopsx ... [skip ci]
---
Modified: src/modules/textopsx/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]eaf18505360a3bbaf25889095fcf23b…
Patch: https://github.com/kamailio/kamailio/commit/eaf18505360a3bbaf25889095fcf23b…
---
diff --git a/src/modules/textopsx/README b/src/modules/textopsx/README
index 9d6b81c05cd..7c6bc59df14 100644
--- a/src/modules/textopsx/README
+++ b/src/modules/textopsx/README
@@ -755,25 +755,36 @@ bl_iterator_end("b1");
Get value of required header-value or param. Note that functions called
'value2' works with Authorization-like headers where comma is not
- treated as value delimiter. Formats: @hf_value.HFNAME[IDX] # idx value,
- negative value counts from bottom @hf_value.HFNAME.PARAM_NAME
- @hf_value.HFNAME[IDX].PARAM_NAME @hf_value.HFNAME.p.PARAM_NAME # or
- .param., useful if required called "uri", "p", "param"
- @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto @hf_value.HFNAME[IDX].uri #
- (< & > excluded) @hf_value.HFNAME[*] # return comma delimited list of
- all values (combines headers) @hf_value.HFNAME # the same as above [*]
- but may be parsed by cfg.y @hf_value.HFNAME[*].uri # return comma
- delimited list of uris (< & > excluded) @hf_value.HFNAME.uri # the same
- as above [*] but may be parsed by cfg.y @hf_value.HFNAME[IDX].name #
- returns name part, quotes excluded @hf_value.HFNAME.name # returns name
- part of the first value @hf_value2.HFNAME # returns value of first
- header @hf_value2.HFNAME[IDX] # returns value of idx's header
- @hf_value2.HFNAME.PARAM_NAME @hf_value2.HFNAME[IDX].PARAM_NAME
- @hf_value.HFNAME[IDX].uri # return URI, quotes excluded
- @hf_value.HFNAME.p.uri # returns param named uri, not URI itself
- @hf_value.HFNAME.p.name # returns param named name, not name itself
- @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be
- used @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr
+ treated as value delimiter.
+
+ Formats:
+ * @hf_value.HFNAME[IDX] # idx value, negative value counts from
+ bottom
+ * @hf_value.HFNAME.PARAM_NAME
+ * @hf_value.HFNAME[IDX].PARAM_NAME
+ * @hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required
+ called "uri", "p", "param"
+ * @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto
+ * @hf_value.HFNAME[IDX].uri # (< & > excluded)
+ * @hf_value.HFNAME[*] # return comma delimited list of all values
+ (combines headers)
+ * @hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y
+ * @hf_value.HFNAME[*].uri # return comma delimited list of uris (< &
+ > excluded)
+ * @hf_value.HFNAME.uri # the same as above [*] but may be parsed by
+ cfg.y
+ * @hf_value.HFNAME[IDX].name # returns name part, quotes excluded
+ * @hf_value.HFNAME.name # returns name part of the first value
+ * @hf_value2.HFNAME # returns value of first header
+ * @hf_value2.HFNAME[IDX] # returns value of idx's header
+ * @hf_value2.HFNAME.PARAM_NAME
+ * @hf_value2.HFNAME[IDX].PARAM_NAME
+ * @hf_value.HFNAME[IDX].uri # return URI, quotes excluded
+ * @hf_value.HFNAME.p.uri # returns param named uri, not URI itself
+ * @hf_value.HFNAME.p.name # returns param named name, not name itself
+ * @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features
+ may be used
+ * @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr
Meaning of the parameters is as follows:
* HFNAME - Header field name. Underscores are treated as dashes.
[View Less]
- affected: src/lib/ims, src/modules/cdp*, src/modules/ims_*
- the Fraunhofer FOKUS institute name was misspelled in the comment headers
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches …
[View More]must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
The name of the Fraunhofer FOKUS institute was incomplete and misspelled. It bugged me for a long time :upside_down_face: .
The changes are not split in 2 commits - one for lib and one for modules. Since these are just bulk changes with no effect on the output, should it be split or it's better if it is not?
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3889
-- Commit Summary --
* lib, modules: fixed Fraunhofer FOKUS name
-- File Changes --
M src/lib/ims/ims_getters.c (4)
M src/lib/ims/ims_getters.h (4)
M src/lib/ims/useful_defs.h (4)
M src/modules/cdp/acceptor.c (4)
M src/modules/cdp/acceptor.h (4)
M src/modules/cdp/api_process.c (4)
M src/modules/cdp/api_process.h (4)
M src/modules/cdp/authstatemachine.c (4)
M src/modules/cdp/authstatemachine.h (4)
M src/modules/cdp/cdp_load.c (4)
M src/modules/cdp/cdp_load.h (4)
M src/modules/cdp/cdp_mod.c (4)
M src/modules/cdp/cdp_mod.h (4)
M src/modules/cdp/config.c (4)
M src/modules/cdp/config.h (4)
M src/modules/cdp/configdtd.h (4)
M src/modules/cdp/configparser.c (4)
M src/modules/cdp/diameter.h (4)
M src/modules/cdp/diameter_api.h (4)
M src/modules/cdp/diameter_avp.c (4)
M src/modules/cdp/diameter_code_avp.h (4)
M src/modules/cdp/diameter_code_result.h (4)
M src/modules/cdp/diameter_comm.c (4)
M src/modules/cdp/diameter_epc.h (4)
M src/modules/cdp/diameter_epc_code_app.h (4)
M src/modules/cdp/diameter_epc_code_avp.h (4)
M src/modules/cdp/diameter_epc_code_cmd.h (4)
M src/modules/cdp/diameter_epc_code_result.h (4)
M src/modules/cdp/diameter_ims.h (4)
M src/modules/cdp/diameter_ims_code_app.h (4)
M src/modules/cdp/diameter_ims_code_avp.h (4)
M src/modules/cdp/diameter_ims_code_cmd.h (4)
M src/modules/cdp/diameter_ims_code_result.h (4)
M src/modules/cdp/diameter_msg.c (4)
M src/modules/cdp/diameter_peer.c (4)
M src/modules/cdp/diameter_peer.h (4)
M src/modules/cdp/globals.c (4)
M src/modules/cdp/globals.h (4)
M src/modules/cdp/peer.c (4)
M src/modules/cdp/peer.h (4)
M src/modules/cdp/peermanager.c (4)
M src/modules/cdp/peermanager.h (4)
M src/modules/cdp/peerstatemachine.c (4)
M src/modules/cdp/peerstatemachine.h (4)
M src/modules/cdp/receiver.c (4)
M src/modules/cdp/receiver.h (4)
M src/modules/cdp/routing.c (2)
M src/modules/cdp/routing.h (4)
M src/modules/cdp/sem.h (4)
M src/modules/cdp/session.c (4)
M src/modules/cdp/session.h (4)
M src/modules/cdp/tcp_accept.c (4)
M src/modules/cdp/tcp_accept.h (4)
M src/modules/cdp/timer.c (4)
M src/modules/cdp/timer.h (4)
M src/modules/cdp/transaction.c (4)
M src/modules/cdp/transaction.h (4)
M src/modules/cdp/utils.h (4)
M src/modules/cdp/worker.c (4)
M src/modules/cdp/worker.h (4)
M src/modules/cdp_avp/avp_add.c (4)
M src/modules/cdp_avp/avp_add.h (4)
M src/modules/cdp_avp/avp_get.c (4)
M src/modules/cdp_avp/avp_get.h (4)
M src/modules/cdp_avp/avp_get_base_data_format.c (4)
M src/modules/cdp_avp/avp_get_base_data_format.h (4)
M src/modules/cdp_avp/avp_new.c (4)
M src/modules/cdp_avp/avp_new.h (4)
M src/modules/cdp_avp/avp_new_base_data_format.c (4)
M src/modules/cdp_avp/avp_new_base_data_format.h (4)
M src/modules/cdp_avp/base.c (4)
M src/modules/cdp_avp/base.h (4)
M src/modules/cdp_avp/ccapp.c (4)
M src/modules/cdp_avp/ccapp.h (4)
M src/modules/cdp_avp/cdp_avp_mod.c (4)
M src/modules/cdp_avp/cdp_avp_mod.h (4)
M src/modules/cdp_avp/epcapp.c (4)
M src/modules/cdp_avp/epcapp.h (4)
M src/modules/cdp_avp/get_reference.h (4)
M src/modules/cdp_avp/imsapp.c (4)
M src/modules/cdp_avp/imsapp.h (4)
M src/modules/cdp_avp/macros.h (4)
M src/modules/cdp_avp/nasapp.c (4)
M src/modules/cdp_avp/nasapp.h (4)
M src/modules/ims_auth/api.h (4)
M src/modules/ims_auth/authorize.c (4)
M src/modules/ims_auth/authorize.h (4)
M src/modules/ims_auth/blurb (4)
M src/modules/ims_auth/conversion.c (4)
M src/modules/ims_auth/conversion.h (4)
M src/modules/ims_auth/cxdx_avp.c (4)
M src/modules/ims_auth/cxdx_avp.h (4)
M src/modules/ims_auth/cxdx_mar.c (4)
M src/modules/ims_auth/cxdx_mar.h (4)
M src/modules/ims_auth/ims_auth_mod.c (4)
M src/modules/ims_auth/ims_auth_mod.h (4)
M src/modules/ims_auth/pvt_message.c (4)
M src/modules/ims_auth/pvt_message.h (4)
M src/modules/ims_auth/rfc2617.c (4)
M src/modules/ims_auth/rfc2617.h (4)
M src/modules/ims_auth/sip_messages.h (4)
M src/modules/ims_auth/stats.c (4)
M src/modules/ims_auth/stats.h (4)
M src/modules/ims_auth/utils.c (4)
M src/modules/ims_auth/utils.h (4)
M src/modules/ims_diameter_server/sem.h (4)
M src/modules/ims_icscf/cxdx_avp.c (4)
M src/modules/ims_icscf/cxdx_avp.h (4)
M src/modules/ims_icscf/cxdx_lir.c (4)
M src/modules/ims_icscf/cxdx_lir.h (4)
M src/modules/ims_icscf/cxdx_uar.c (4)
M src/modules/ims_icscf/cxdx_uar.h (4)
M src/modules/ims_icscf/db.c (4)
M src/modules/ims_icscf/db.h (4)
M src/modules/ims_icscf/ims_icscf_mod.c (4)
M src/modules/ims_icscf/ims_icscf_mod.h (4)
M src/modules/ims_icscf/location.c (4)
M src/modules/ims_icscf/location.h (4)
M src/modules/ims_icscf/nds.c (4)
M src/modules/ims_icscf/nds.h (4)
M src/modules/ims_icscf/registration.c (4)
M src/modules/ims_icscf/registration.h (4)
M src/modules/ims_icscf/scscf_list.c (4)
M src/modules/ims_icscf/scscf_list.h (4)
M src/modules/ims_icscf/sip_messages.h (4)
M src/modules/ims_icscf/stats.c (4)
M src/modules/ims_icscf/stats.h (4)
M src/modules/ims_ipsec_pcscf/cmd.c (4)
M src/modules/ims_ipsec_pcscf/cmd.h (4)
M src/modules/ims_isc/blurb (4)
M src/modules/ims_isc/checker.c (4)
M src/modules/ims_isc/checker.h (4)
M src/modules/ims_isc/ims_isc_mod.c (4)
M src/modules/ims_isc/ims_isc_mod.h (4)
M src/modules/ims_isc/isc.c (4)
M src/modules/ims_isc/isc.h (4)
M src/modules/ims_isc/mark.c (4)
M src/modules/ims_isc/mark.h (4)
M src/modules/ims_isc/third_party_reg.c (4)
M src/modules/ims_isc/third_party_reg.h (4)
M src/modules/ims_ocs/sem.h (4)
M src/modules/ims_qos/cdpeventprocessor.c (4)
M src/modules/ims_qos/cdpeventprocessor.h (4)
M src/modules/ims_qos/ims_qos_mod.c (4)
M src/modules/ims_qos/ims_qos_mod.h (4)
M src/modules/ims_qos/ims_qos_stats.c (4)
M src/modules/ims_qos/rx_aar.c (4)
M src/modules/ims_qos/rx_aar.h (4)
M src/modules/ims_qos/rx_asr.c (4)
M src/modules/ims_qos/rx_asr.h (4)
M src/modules/ims_qos/rx_authdata.c (4)
M src/modules/ims_qos/rx_authdata.h (4)
M src/modules/ims_qos/rx_avp.c (4)
M src/modules/ims_qos/rx_avp.h (4)
M src/modules/ims_qos/rx_str.c (4)
M src/modules/ims_qos/rx_str.h (4)
M src/modules/ims_qos/sem.h (4)
M src/modules/ims_qos/stats.c (4)
M src/modules/ims_qos/stats.h (4)
M src/modules/ims_registrar_pcscf/async_reginfo.c (4)
M src/modules/ims_registrar_pcscf/async_reginfo.h (4)
M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (4)
M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.h (4)
M src/modules/ims_registrar_pcscf/save.c (4)
M src/modules/ims_registrar_pcscf/save.h (4)
M src/modules/ims_registrar_pcscf/sem.h (4)
M src/modules/ims_registrar_pcscf/ul_callback.c (4)
M src/modules/ims_registrar_pcscf/ul_callback.h (4)
M src/modules/ims_registrar_scscf/cxdx_avp.c (4)
M src/modules/ims_registrar_scscf/cxdx_avp.h (4)
M src/modules/ims_registrar_scscf/cxdx_sar.c (4)
M src/modules/ims_registrar_scscf/cxdx_sar.h (4)
M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c (4)
M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.h (4)
M src/modules/ims_registrar_scscf/pvt_message.c (4)
M src/modules/ims_registrar_scscf/pvt_message.h (4)
M src/modules/ims_registrar_scscf/registrar_notify.c (4)
M src/modules/ims_registrar_scscf/registrar_notify.h (4)
M src/modules/ims_registrar_scscf/save.c (4)
M src/modules/ims_registrar_scscf/save.h (4)
M src/modules/ims_registrar_scscf/sem.h (4)
M src/modules/ims_registrar_scscf/server_assignment.c (4)
M src/modules/ims_registrar_scscf/server_assignment.h (4)
M src/modules/ims_registrar_scscf/stats.c (4)
M src/modules/ims_registrar_scscf/stats.h (4)
M src/modules/ims_registrar_scscf/userdata_parser.c (4)
M src/modules/ims_registrar_scscf/userdata_parser.h (4)
M src/modules/ims_registrar_scscf/usrloc_cb.c (4)
M src/modules/ims_registrar_scscf/usrloc_cb.h (4)
M src/modules/ims_usrloc_pcscf/dlist.c (4)
M src/modules/ims_usrloc_pcscf/dlist.h (4)
M src/modules/ims_usrloc_pcscf/hslot.c (4)
M src/modules/ims_usrloc_pcscf/hslot.h (4)
M src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c (4)
M src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.h (4)
M src/modules/ims_usrloc_pcscf/pcontact.c (4)
M src/modules/ims_usrloc_pcscf/pcontact.h (4)
M src/modules/ims_usrloc_pcscf/reginfo.c (4)
M src/modules/ims_usrloc_pcscf/reginfo.h (4)
M src/modules/ims_usrloc_pcscf/udomain.c (4)
M src/modules/ims_usrloc_pcscf/udomain.h (4)
M src/modules/ims_usrloc_pcscf/ul_callback.c (4)
M src/modules/ims_usrloc_pcscf/ul_callback.h (4)
M src/modules/ims_usrloc_pcscf/ul_rpc.c (4)
M src/modules/ims_usrloc_pcscf/ul_rpc.h (4)
M src/modules/ims_usrloc_pcscf/usrloc.c (4)
M src/modules/ims_usrloc_pcscf/usrloc.h (4)
M src/modules/ims_usrloc_pcscf/utime.c (4)
M src/modules/ims_usrloc_pcscf/utime.h (4)
M src/modules/ims_usrloc_scscf/bin_utils.c (4)
M src/modules/ims_usrloc_scscf/bin_utils.h (4)
M src/modules/ims_usrloc_scscf/contact_hslot.c (4)
M src/modules/ims_usrloc_scscf/contact_hslot.h (4)
M src/modules/ims_usrloc_scscf/dlist.c (4)
M src/modules/ims_usrloc_scscf/dlist.h (4)
M src/modules/ims_usrloc_scscf/hslot.c (4)
M src/modules/ims_usrloc_scscf/hslot.h (4)
M src/modules/ims_usrloc_scscf/hslot_sp.c (4)
M src/modules/ims_usrloc_scscf/hslot_sp.h (4)
M src/modules/ims_usrloc_scscf/impurecord.c (4)
M src/modules/ims_usrloc_scscf/impurecord.h (4)
M src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.c (4)
M src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.h (4)
M src/modules/ims_usrloc_scscf/subscribe.c (4)
M src/modules/ims_usrloc_scscf/subscribe.h (4)
M src/modules/ims_usrloc_scscf/ucontact.c (4)
M src/modules/ims_usrloc_scscf/ucontact.h (4)
M src/modules/ims_usrloc_scscf/udomain.c (4)
M src/modules/ims_usrloc_scscf/udomain.h (4)
M src/modules/ims_usrloc_scscf/ul_callback.c (4)
M src/modules/ims_usrloc_scscf/ul_callback.h (4)
M src/modules/ims_usrloc_scscf/usrloc.c (4)
M src/modules/ims_usrloc_scscf/usrloc.h (4)
M src/modules/ims_usrloc_scscf/utime.c (4)
M src/modules/ims_usrloc_scscf/utime.h (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3889.patchhttps://github.com/kamailio/kamailio/pull/3889.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3889
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3889(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 9317670dc2624a0ed06114e42e0e054ac5cbafb6
URL: https://github.com/kamailio/kamailio/commit/9317670dc2624a0ed06114e42e0e054…
Author: Dragos Vingarzan <vingarzan(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-06-21T12:58:01+02:00
lib/ims: fixed Fraunhofer FOKUS Institute name
- #3889
---
Modified: src/lib/ims/ims_getters.c
Modified: src/lib/ims/ims_getters.h
Modified: src/lib/ims/useful_defs.h
---
Diff: …
[View More]https://github.com/kamailio/kamailio/commit/9317670dc2624a0ed06114e42e0e054…
Patch: https://github.com/kamailio/kamailio/commit/9317670dc2624a0ed06114e42e0e054…
---
diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c
index d50f6b3571d..c752f08eef1 100644
--- a/src/lib/ims/ims_getters.c
+++ b/src/lib/ims/ims_getters.c
@@ -4,7 +4,7 @@
*
* The initial version of this code was written by Dragos Vingarzan
* (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the
- * Fruanhofer Institute. It was and still is maintained in a separate
+ * Fraunhofer FOKUS Institute. It was and still is maintained in a separate
* branch of the original SER. We are therefore migrating it to
* Kamailio/SR and look forward to maintaining it from here on out.
* 2011/2012 Smile Communications, Pty. Ltd.
@@ -14,7 +14,7 @@
* effort to add full IMS support to Kamailio/SR using a new and
* improved architecture
*
- * NB: Alot of this code was originally part of OpenIMSCore,
+ * NB: A lot of this code was originally part of OpenIMSCore,
* FhG Fokus.
* Copyright (C) 2004-2006 FhG Fokus
* Thanks for great work! This is an effort to
diff --git a/src/lib/ims/ims_getters.h b/src/lib/ims/ims_getters.h
index 6004f228eb5..77a55a6695b 100644
--- a/src/lib/ims/ims_getters.h
+++ b/src/lib/ims/ims_getters.h
@@ -5,7 +5,7 @@
* Copyright (C) 2012 Smile Communications, richard.good(a)smilecoms.com
* The initial version of this code was written by Dragos Vingarzan
* (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the
- * Fruanhofer Institute. It was and still is maintained in a separate
+ * Fraunhofer FOKUS Institute. It was and still is maintained in a separate
* branch of the original SER. We are therefore migrating it to
* Kamailio/SR and look forward to maintaining it from here on out.
* 2011/2012 Smile Communications, Pty. Ltd.
@@ -15,7 +15,7 @@
* effort to add full IMS support to Kamailio/SR using a new and
* improved architecture
*
- * NB: Alot of this code was originally part of OpenIMSCore,
+ * NB: A lot of this code was originally part of OpenIMSCore,
* FhG Fokus.
* Copyright (C) 2004-2006 FhG Fokus
* Thanks for great work! This is an effort to
diff --git a/src/lib/ims/useful_defs.h b/src/lib/ims/useful_defs.h
index 111bd2e6c00..5461eea6859 100644
--- a/src/lib/ims/useful_defs.h
+++ b/src/lib/ims/useful_defs.h
@@ -6,7 +6,7 @@
*
* The initial version of this code was written by Dragos Vingarzan
* (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the
- * Fruanhofer Institute. It was and still is maintained in a separate
+ * Fraunhofer FOKUS Institute. It was and still is maintained in a separate
* branch of the original SER. We are therefore migrating it to
* Kamailio/SR and look forward to maintaining it from here on out.
* 2011/2012 Smile Communications, Pty. Ltd.
@@ -16,7 +16,7 @@
* effort to add full IMS support to Kamailio/SR using a new and
* improved architecture
*
- * NB: Alot of this code was originally part of OpenIMSCore,
+ * NB: A lot of this code was originally part of OpenIMSCore,
* FhG Fokus.
* Copyright (C) 2004-2006 FhG Fokus
* Thanks for great work! This is an effort to
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Part of the documentation of the textopsx module (the selectors) was hard to read, since it was missing line-wraps in the example.
- itemizing the list of examples for readability
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3887
-- Commit Summary --
* fixed hard-to-read documentation for textopsx
-- File Changes --
M src/modules/textopsx/README (49)
M src/modules/textopsx/doc/selects.xml (49)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3887.patchhttps://github.com/kamailio/kamailio/pull/3887.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3887
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3887(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: cd57d606cc6bfc96fca50e495d3a587fee25cc4f
URL: https://github.com/kamailio/kamailio/commit/cd57d606cc6bfc96fca50e495d3a587…
Author: Dragos Vingarzan <vingarzan(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-06-21T12:58:01+02:00
ims_ocs: fixed Fraunhofer FOKUS Institute name
- #3889
---
Modified: src/modules/ims_ocs/sem.h
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]cd57d606cc6bfc96fca50e495d3a587…
Patch: https://github.com/kamailio/kamailio/commit/cd57d606cc6bfc96fca50e495d3a587…
---
diff --git a/src/modules/ims_ocs/sem.h b/src/modules/ims_ocs/sem.h
index f72073004ee..45d4467dd1f 100644
--- a/src/modules/ims_ocs/sem.h
+++ b/src/modules/ims_ocs/sem.h
@@ -6,7 +6,7 @@
*
* The initial version of this code was written by Dragos Vingarzan
* (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the
- * Fruanhofer Institute. It was and still is maintained in a separate
+ * Fraunhofer FOKUS Institute. It was and still is maintained in a separate
* branch of the original SER. We are therefore migrating it to
* Kamailio/SR and look forward to maintaining it from here on out.
* 2011/2012 Smile Communications, Pty. Ltd.
@@ -16,7 +16,7 @@
* effort to add full IMS support to Kamailio/SR using a new and
* improved architecture
*
- * NB: Alot of this code was originally part of OpenIMSCore,
+ * NB: A lot of this code was originally part of OpenIMSCore,
* FhG Fokus.
* Copyright (C) 2004-2006 FhG Fokus
* Thanks for great work! This is an effort to
[View Less]
Module: kamailio
Branch: master
Commit: addc23622a4125293c25805cc8f1207af94a942a
URL: https://github.com/kamailio/kamailio/commit/addc23622a4125293c25805cc8f1207…
Author: Dragos Vingarzan <vingarzan(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-06-21T12:58:01+02:00
ims_ipsec_pcscf: fixed Fraunhofer FOKUS Institute name
- #3889
---
Modified: src/modules/ims_ipsec_pcscf/cmd.c
Modified: src/modules/ims_ipsec_pcscf/cmd.h
---
Diff: https://…
[View More]github.com/kamailio/kamailio/commit/addc23622a4125293c25805cc8f1207…
Patch: https://github.com/kamailio/kamailio/commit/addc23622a4125293c25805cc8f1207…
---
diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c
index 3ce36d27952..1f85cffc694 100644
--- a/src/modules/ims_ipsec_pcscf/cmd.c
+++ b/src/modules/ims_ipsec_pcscf/cmd.c
@@ -5,7 +5,7 @@
*
* The initial version of this code was written by Dragos Vingarzan
* (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the
- * Fruanhofer Institute. It was and still is maintained in a separate
+ * Fraunhofer FOKUS Institute. It was and still is maintained in a separate
* branch of the original SER. We are therefore migrating it to
* Kamailio/SR and look forward to maintaining it from here on out.
* 2011/2012 Smile Communications, Pty. Ltd.
@@ -15,7 +15,7 @@
* effort to add full IMS support to Kamailio/SR using a new and
* improved architecture
*
- * NB: Alot of this code was originally part of OpenIMSCore,
+ * NB: A lot of this code was originally part of OpenIMSCore,
* FhG Fokus.
* Copyright (C) 2004-2006 FhG Fokus
* Thanks for great work! This is an effort to
diff --git a/src/modules/ims_ipsec_pcscf/cmd.h b/src/modules/ims_ipsec_pcscf/cmd.h
index e22000028f1..bf0884b9623 100644
--- a/src/modules/ims_ipsec_pcscf/cmd.h
+++ b/src/modules/ims_ipsec_pcscf/cmd.h
@@ -7,7 +7,7 @@
*
* The initial version of this code was written by Dragos Vingarzan
* (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the
- * Fruanhofer Institute. It was and still is maintained in a separate
+ * Fraunhofer FOKUS Institute. It was and still is maintained in a separate
* branch of the original SER. We are therefore migrating it to
* Kamailio/SR and look forward to maintaining it from here on out.
* 2011/2012 Smile Communications, Pty. Ltd.
@@ -17,7 +17,7 @@
* effort to add full IMS support to Kamailio/SR using a new and
* improved architecture
*
- * NB: Alot of this code was originally part of OpenIMSCore,
+ * NB: A lot of this code was originally part of OpenIMSCore,
* FhG Fokus.
* Copyright (C) 2004-2006 FhG Fokus
* Thanks for great work! This is an effort to
[View Less]
Module: kamailio
Branch: master
Commit: f2f3e0bbb3f04cdb8fe184f4188ad83635a7a7c9
URL: https://github.com/kamailio/kamailio/commit/f2f3e0bbb3f04cdb8fe184f4188ad83…
Author: Dragos Vingarzan <vingarzan(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-06-21T12:58:01+02:00
ims_diameter_server: fixed Fraunhofer FOKUS Institute name
- #3889
---
Modified: src/modules/ims_diameter_server/sem.h
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]f2f3e0bbb3f04cdb8fe184f4188ad83…
Patch: https://github.com/kamailio/kamailio/commit/f2f3e0bbb3f04cdb8fe184f4188ad83…
---
diff --git a/src/modules/ims_diameter_server/sem.h b/src/modules/ims_diameter_server/sem.h
index f72073004ee..45d4467dd1f 100644
--- a/src/modules/ims_diameter_server/sem.h
+++ b/src/modules/ims_diameter_server/sem.h
@@ -6,7 +6,7 @@
*
* The initial version of this code was written by Dragos Vingarzan
* (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the
- * Fruanhofer Institute. It was and still is maintained in a separate
+ * Fraunhofer FOKUS Institute. It was and still is maintained in a separate
* branch of the original SER. We are therefore migrating it to
* Kamailio/SR and look forward to maintaining it from here on out.
* 2011/2012 Smile Communications, Pty. Ltd.
@@ -16,7 +16,7 @@
* effort to add full IMS support to Kamailio/SR using a new and
* improved architecture
*
- * NB: Alot of this code was originally part of OpenIMSCore,
+ * NB: A lot of this code was originally part of OpenIMSCore,
* FhG Fokus.
* Copyright (C) 2004-2006 FhG Fokus
* Thanks for great work! This is an effort to
[View Less]
Module: kamailio
Branch: master
Commit: 48d97c1941f660aa396b5ef100584611cf92ad21
URL: https://github.com/kamailio/kamailio/commit/48d97c1941f660aa396b5ef10058461…
Author: Dragos Vingarzan <vingarzan(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-06-21T12:57:56+02:00
textopx/doc: fixed hard-to-read documentation for textopsx
- was missing line-wraps in examples list, hence very hard to read
---
Modified: src/modules/textopsx/doc/selects.xml
---…
[View More]
Diff: https://github.com/kamailio/kamailio/commit/48d97c1941f660aa396b5ef10058461…
Patch: https://github.com/kamailio/kamailio/commit/48d97c1941f660aa396b5ef10058461…
---
diff --git a/src/modules/textopsx/doc/selects.xml b/src/modules/textopsx/doc/selects.xml
index 6d4dd4e3a25..3c72c21cd36 100644
--- a/src/modules/textopsx/doc/selects.xml
+++ b/src/modules/textopsx/doc/selects.xml
@@ -9,30 +9,35 @@
<title>@hf_value</title>
<para>
Get value of required header-value or param. Note that functions called 'value2'
- works with Authorization-like headers where comma is not treated as value delimiter. Formats:
- @hf_value.HFNAME[IDX] # idx value, negative value counts from bottom
- @hf_value.HFNAME.PARAM_NAME
- @hf_value.HFNAME[IDX].PARAM_NAME
- @hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required called "uri", "p", "param"
- @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto
- @hf_value.HFNAME[IDX].uri # (< & > excluded)
- @hf_value.HFNAME[*] # return comma delimited list of all values (combines headers)
- @hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y
- @hf_value.HFNAME[*].uri # return comma delimited list of uris (< & > excluded)
- @hf_value.HFNAME.uri # the same as above [*] but may be parsed by cfg.y
- @hf_value.HFNAME[IDX].name # returns name part, quotes excluded
- @hf_value.HFNAME.name # returns name part of the first value
+ works with Authorization-like headers where comma is not treated as value delimiter.
+ </para>
+ <para>
+ Formats:
+ <itemizedlist>
+ <listitem>@hf_value.HFNAME[IDX] # idx value, negative value counts from bottom</listitem>
+ <listitem>@hf_value.HFNAME.PARAM_NAME</listitem>
+ <listitem>@hf_value.HFNAME[IDX].PARAM_NAME</listitem>
+ <listitem>@hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required called "uri", "p", "param"</listitem>
+ <listitem>@hf_value.HFNAME[IDX].p.PARAM_NAME # dtto</listitem>
+ <listitem>@hf_value.HFNAME[IDX].uri # (< & > excluded)</listitem>
+ <listitem>@hf_value.HFNAME[*] # return comma delimited list of all values (combines headers)</listitem>
+ <listitem>@hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y</listitem>
+ <listitem>@hf_value.HFNAME[*].uri # return comma delimited list of uris (< & > excluded)</listitem>
+ <listitem>@hf_value.HFNAME.uri # the same as above [*] but may be parsed by cfg.y</listitem>
+ <listitem>@hf_value.HFNAME[IDX].name # returns name part, quotes excluded</listitem>
+ <listitem>@hf_value.HFNAME.name # returns name part of the first value</listitem>
- @hf_value2.HFNAME # returns value of first header
- @hf_value2.HFNAME[IDX] # returns value of idx's header
- @hf_value2.HFNAME.PARAM_NAME
- @hf_value2.HFNAME[IDX].PARAM_NAME
+ <listitem>@hf_value2.HFNAME # returns value of first header</listitem>
+ <listitem>@hf_value2.HFNAME[IDX] # returns value of idx's header</listitem>
+ <listitem>@hf_value2.HFNAME.PARAM_NAME</listitem>
+ <listitem>@hf_value2.HFNAME[IDX].PARAM_NAME</listitem>
- @hf_value.HFNAME[IDX].uri # return URI, quotes excluded
- @hf_value.HFNAME.p.uri # returns param named uri, not URI itself
- @hf_value.HFNAME.p.name # returns param named name, not name itself
- @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be used
- @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr
+ <listitem>@hf_value.HFNAME[IDX].uri # return URI, quotes excluded</listitem>
+ <listitem>@hf_value.HFNAME.p.uri # returns param named uri, not URI itself</listitem>
+ <listitem>@hf_value.HFNAME.p.name # returns param named name, not name itself</listitem>
+ <listitem>@hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be used</listitem>
+ <listitem>@hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr</listitem>
+ </itemizedlist>
</para>
<para>Meaning of the parameters is as follows:</para>
<itemizedlist>
[View Less]
When I start Kamailio master version that has been built on Debian 12 with default-libmysqlclient-dev depending on libmariadb-dev-compat, several warnings like this are produced:
```
2024-06-17T14:48:27.702827+03:00 siika /usr/bin/sip-proxy[297246]: WARNING: db_mysql
[km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql
version (value (null)) - ignoring
```
The only db_mysql configuration option used in the config is ping_interval.
I would expect that the …
[View More]warnings are not produced like it is the case when I build Kamailio branch 5.8.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3884
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3884(a)github.com>
[View Less]
### Description
amqp_ssl_socket_set_*() functions are just for amqp_ssl_socket sockets
#### Reproduction
```
loadmodule "rabbitmq.so"
modparam("rabbitmq", "url", "amqp://guest:guest@rabbitmq:5672/%2Fkamailio")
```
#### Debugging Data
```
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
#1 0x00007fd60b427e8f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/…
[View More]pthread_kill.c:78
#2 0x00007fd60b3d8fb2 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3 0x00007fd60b3c3472 in __GI_abort () at ./stdlib/abort.c:79
#4 0x00007fd5f5a78831 in amqp_abort (fmt=fmt@entry=0x7fd5f5a82358 "<%p> is not of type amqp_ssl_socket_t") at ./librabbitmq/amqp_api.c:183
#5 0x00007fd5f5a7f032 in amqp_ssl_socket_set_verify_peer (base=<optimized out>, verify=verify@entry=0) at ./librabbitmq/amqp_openssl.c:519
#6 0x00007fd5f5a8adf1 in rabbitmq_connect (conn=0x7fd5f5a98328 <amqp_conn>) at ./src/modules/rabbitmq/rabbitmq.c:610
#7 0x00007fd5f5a918e7 in mod_child_init (rank=-127) at ./src/modules/rabbitmq/rabbitmq.c:180
#8 0x000055ec03183a8f in init_mod_child (m=0x7fd607c8bd00, rank=-127) at core/sr_module.c:920
#9 0x000055ec031887ab in init_child (rank=rank@entry=-127) at core/sr_module.c:999
#10 0x000055ec02ff5e07 in main_loop () at ./src/main.c:1725
#11 0x000055ec02feba87 in main (argc=<optimized out>, argv=<optimized out>) at ./src/main.c:3256
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3883
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3883(a)github.com>
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/…
[View More]lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
I made a test :Several volte mobile accessed into eNB, some of them made call and hung up periodically .
After some time, ims registrations all failed. I found pcscf error log below periodically when try to ims register :
2024-05-28T13:32:30.952258+08:00 spid-YL-CLU6L-V1 pcscf[13401]: ERROR: {1 750211591 REGISTER 750211591_1277609064(a)172.60.5.12} cdp [routing.c:296]: get_routing_peer(): get_routing_peer(): No connected DefaultRoute peer found for app_id 16777236 and vendor id 10415.
2024-05-28T13:32:30.952346+08:00 spid-YL-CLU6L-V1 pcscf[13401]: ERROR: {1 750211591 REGISTER 750211591_1277609064(a)172.60.5.12} cdp [diameter_comm.c:144]: AAASendMessage(): AAASendMessage(): Can't find a suitable connected peer in the routing table.
And the RX reconnection appeared periodically ,which could be found in packet capture:
2024-05-28T13:32:49.595500+08:00 spid-YL-CLU6L-V1 pcscf[13372]: INFO: cdp [receiver.c:1006]: peer_connect(): peer_connect(): Trying to connect to 127.0.0.9 port 3868
2024-05-28T13:32:49.595621+08:00 spid-YL-CLU6L-V1 pcscf[13372]: INFO: cdp [receiver.c:1106]: peer_connect(): peer_connect(): Peer pcrf.epc.mnc009.mcc460.3gppnetwork.org:3868 connected
PCRF error log periodically :
[diam] ERROR: pid:PSM/pcscf.ims.mnc009.mcc460.3gppnetwork.org in [fd_p_ce_handle_newCER@p_ce.c](mailto:fd_p_ce_handle_newCER@p_ce.c):1138: pcscf.ims.mnc009.mcc460.3gppnetwork.org: Rejecting new connection attempt while our state machine is in state 'STATE_SUSPECT'
-->
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
Several volte mobile accessed into eNB, some of them made call and hung up periodically .
After some time, ims registrations all failed.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```

### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
If I restarted pcscf, ims registration worked well.After some time ,the error occurred again.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
kamailio v5.6.0
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
ubuntu server 18.04
```
(paste your output here)
```
[Uploading ims-reg-fail (1).zip…]()
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3879
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3879(a)github.com>
[View Less]
Recently ,I've learned about Kamailio and set up it. I want to decode my phone number before my FS, so whether it is possible to decode an number within Kamailio?Any help?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3882
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3882(a)github.com>
### Description
We have a quite basic scenario which sends a SIP MESSAGE and then receives SIP MESSAGE back. It also sets up two voice calls using SIP INVITE. It is only this specific scenario that is causing the core dump. Some time the core dump occur just a few seconds after the call/message scenario, but occasionally it takes up to 50 minutes.
We have been using the uac module for sending SIP MESSAGE in several other scenarios without experiencing a crash.
We always see the same lines …
[View More]in the log just prior to the core dump: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 49
We are using Kamailio 5.6 retrieved from the kamailio repository: http://deb.kamailio.org/kamailio56. We are running Kamailio in a Docker container which runs on "5.10.0-25-cloud-amd64 #1 SMP Debian 5.10.191-1 (2023-08-16) x86_64 GNU/Linux"
We have also tried Kamailio 5.7 from the same repo which crashes in exactly the same way.
### Troubleshooting
#### Reproduction
We have troubles to consistently reproduce it and it only happen from time to time when running a specific scenario sending SIP MESSAGE using the uac module. It does not happen for every call of this call scenario. At one instance Kamailo crashed with just 15 seconds in-between during the call scenario.
#### Debugging Data
```
# gdb /usr/sbin/kamailio /core
GNU gdb (Debian 10.1-1.7) 10.1.90.20210103-git
Copyright (C) 2021 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /usr/sbin/kamailio...
(No debugging symbols found in /usr/sbin/kamailio)
warning: Can't open file /dev/zero (deleted) during file-backed mapping note processing
[New LWP 4777]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/sbin/kamailio -DD -M 18 -m 192 -A serverId=17173 -A sendTraceLocal="sip:10'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 __strlen_evex () at ../sysdeps/x86_64/multiarch/strlen-evex.S:77
77 ../sysdeps/x86_64/multiarch/strlen-evex.S: No such file or directory.
(gdb) bt full
#0 __strlen_evex () at ../sysdeps/x86_64/multiarch/strlen-evex.S:77
No locals.
#1 0x00007f5425e34b78 in __vfprintf_internal (s=s@entry=0x55a06e969a60,
format=format@entry=0x55a06e558020 "%s: %.*s%s%s%sBUG: qm: fragm. %p (address %p) beginning overwritten (%lx)! Memory allocator was called from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n",
ap=ap@entry=0x7ffd6bebfb50, mode_flags=mode_flags@entry=0) at vfprintf-internal.c:1647
len = <optimized out>
step0_jumps = {0, 1717, 1621, 3413, 3317, 3997, 2677, 2837, 3613, 1773, 4309, 4445, 3517, 4437, 4389, 2789, 4197, 3917, 3221, 2997, 1141, 1365, 1997, 1925, 1885, 733, 3709, 533, 533, 4101}
space = <optimized out>
is_short = <optimized out>
use_outdigits = 0
outc = <optimized out>
step1_jumps = {0, 0, 0, 0, 0, 0, 0, 0, 0, 1773, 4309, 4445, 3517, 4437, 4389, 2789, 4197, 3917, 3221, 2997, 1141, 1365, 1997, 1925, 1885, 733, 3709, 533, 533, 0}
group = 0
prec = -1
step2_jumps = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 4309, 4445, 3517, 4437, 4389, 2789, 4197, 3917, 3221, 2997, 1141, 1365, 1997, 1925, 1885, 733, 3709, 533, 533, 0}
string = 0x756d6f7266222c22 <error: Cannot access memory at address 0x756d6f7266222c22>
left = 0
is_long_double = <optimized out>
width = 0
signed_number = <optimized out>
step3a_jumps = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 4213, 0, 0, 0, 4389, 2789, 4197, 3917, 3221, 0, 0, 0, 0, 1925, 0, 0, 0, 0, 0, 0}
alt = <optimized out>
showsign = 0
is_long = 0
is_char = <optimized out>
pad = <optimized out>
step3b_jumps = {0 <repeats 11 times>, 3517, 0, 0, 4389, 2789, 4197, 3917, 3221, 2997, 1141, 1365, 1997, 1925, 1885, 733, 3709, 0, 0, 0}
step4_jumps = {0 <repeats 14 times>, 4389, 2789, 4197, 3917, 3221, 2997, 1141, 1365, 1997, 1925, 1885, 733, 3709, 0, 0, 0}
args_value = <optimized out>
is_negative = <optimized out>
number = {longlong = <optimized out>, word = <optimized out>}
base = <optimized out>
the_arg = {pa_wchar = 4777 L'\x12a9', pa_int = 4777, pa_long_int = 4777, pa_long_long_int = 4777, pa_u_int = 4777, pa_u_long_int = 4777, pa_u_long_long_int = 4777,
pa_double = 2.3601515901836347e-320, pa_long_double = 1.74131181638025811763e-4947, pa_float128 = 3.09319115455554459548860449034534676e-4962,
pa_string = 0x12a9 <error: Cannot access memory at address 0x12a9>, pa_wstring = 0x12a9 <error: Cannot access memory at address 0x12a9>, pa_pointer = 0x12a9, pa_user = 0x12a9}
spec = 115 's'
_buffer = {__routine = 0x4, __arg = 0xd, __canceltype = 1855363680, __prev = 0xe0}
_avail = <optimized out>
thousands_sep = 0x0
grouping = 0xffffffffffffffff <error: Cannot access memory at address 0xffffffffffffffff>
done = 238
f = 0x55a06e5580a7 "s:%lu. Exec from %s:%u.\n"
lead_str_end = 0x55a06e558020 "%s: %.*s%s%s%sBUG: qm: fragm. %p (address %p) beginning overwritten (%lx)! Memory allocator was called from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n"
end_of_spec = <optimized out>
work_buffer = "h\r\000\000\000\000\000\000\000\000\000\000\060\000\000\000\000\000\000\000\375\177\000\000 \372\353k\375\177\000\000\237MSn\n\000\000\000\000\000\000\000\240U", '\000' <repeats 18 times>, "P\225Un\240U\000\000\000\000\000\000[\214A\323\f\000\000\000\000\000\000\000\377\377\377\377\377\377\377\377\206\002", '\000' <repeats 14 times>, "\004\000\000\000\000\000\000\000 \367\353k\375\177\000\000\301\225Un\240U\000\000\323\262\vn\240U\000\000\000\000\000\000\000\000\000\000s\374On\240U\000\000W\225Un\240U\000\000\350>\212\027T\177\000\000 \323\365$T\177\000\000\060\a\354k\375\177\000\00--Type <RET> for more, q to quit, c to continue without paging--
0\220\371\227n\240U\000\000"...
workend = 0x7ffd6bebf9f8 ""
ap_save = {{gp_offset = 16, fp_offset = 48, overflow_arg_area = 0x7ffd6bebfc30, reg_save_area = 0x7ffd6bebfb70}}
nspecs_done = 10
save_errno = 4
readonly_format = 0
do_longlong_number = <optimized out>
__result = <optimized out>
#2 0x00007f5425ec079f in __vsyslog_internal (pri=<optimized out>,
fmt=0x55a06e558020 "%s: %.*s%s%s%sBUG: qm: fragm. %p (address %p) beginning overwritten (%lx)! Memory allocator was called from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n",
ap=0x7ffd6bebfb50, mode_flags=0) at ../misc/syslog.c:233
now_tm = {tm_sec = 8, tm_min = 18, tm_hour = 12, tm_mday = 23, tm_mon = 0, tm_year = 124, tm_wday = 2, tm_yday = 22, tm_isdst = 0, tm_gmtoff = 0, tm_zone = 0x55a06e94c5e0 "UTC"}
now = 1706012288
fd = <optimized out>
f = 0x55a06e969a60
buf = 0x0
bufsize = 0
msgoff = 21
saved_errno = <optimized out>
failbuf = "`\232\226n\240U\000\000\000\204\201\247[\214A\323`\374\353k\375\177\000\000\300p\371%T"
clarg = {buf = <optimized out>, oldaction = <optimized out>}
#3 0x00007f5425ec0c46 in __syslog (pri=<optimized out>, fmt=<optimized out>) at ../misc/syslog.c:117
ap = {{gp_offset = 48, fp_offset = 48, overflow_arg_area = 0x7ffd6bebfc70, reg_save_area = 0x7ffd6bebfb70}}
#4 0x000055a06e3b7839 in ?? ()
No symbol table info available.
#5 0x000055a06e3bc039 in qm_free ()
No symbol table info available.
#6 0x000055a06e3c7c28 in qm_shm_free ()
No symbol table info available.
#7 0x00007f542325fb8e in uac_send_tm_callback () from /usr/lib/x86_64-linux-gnu/kamailio/modules/uac.so
No symbol table info available.
#8 0x00007f5424a2f002 in run_trans_callbacks_internal () from /usr/lib/x86_64-linux-gnu/kamailio/modules/tm.so
No symbol table info available.
#9 0x00007f5424a2f179 in run_trans_callbacks () from /usr/lib/x86_64-linux-gnu/kamailio/modules/tm.so
No symbol table info available.
#10 0x00007f54249d5e8c in free_cell_helper () from /usr/lib/x86_64-linux-gnu/kamailio/modules/tm.so
No symbol table info available.
#11 0x00007f5424aa8f82 in wait_handler () from /usr/lib/x86_64-linux-gnu/kamailio/modules/tm.so
No symbol table info available.
#12 0x000055a06e37a263 in ?? ()
No symbol table info available.
#13 0x000055a06e37a79d in ?? ()
No symbol table info available.
#14 0x000055a06e37acc6 in timer_main ()
No symbol table info available.
#15 0x000055a06e0a5f62 in main_loop ()
No symbol table info available.
--Type <RET> for more, q to quit, c to continue without paging--
#16 0x000055a06e0b120c in main ()
No symbol table info available.
(gdb) info locals
No locals.
(gdb) list
72 in ../sysdeps/x86_64/multiarch/strlen-evex.S
```
#### Log Messages
```
Log file:
2024-01-23T13:18:08.828+01:00 Jan 23 12:18:08 /usr/sbin/kamailio[4789]: INFO: <script>: Incoming SIP TCP request conid 21 call-id un0rihsRLJLvP-grn6LO-A
2024-01-23T13:18:08.835+01:00 Jan 23 12:18:08 /usr/sbin/kamailio[4789]: INFO: <script>: Incoming SIP TCP request conid 21 call-id WQjhldpRJbxjZRYe7fWgbw
2024-01-23T13:18:08.860+01:00 Jan 23 12:18:08 /usr/sbin/kamailio[4795]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 49
2024-01-23T13:18:09.486+01:00 Jan 23 12:18:09 /usr/sbin/kamailio[4751]: ALERT: <core> [main.c:783]: handle_sigs(): child process 4777 exited by a signal 11
2024-01-23T13:18:09.486+01:00 Jan 23 12:18:09 /usr/sbin/kamailio[4751]: ALERT: <core> [main.c:787]: handle_sigs(): core was generated
2024-01-23T13:18:09.516+01:00 Jan 23 12:18:09 /usr/sbin/kamailio[4751]: INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized
2024-01-23T13:18:09.570+01:00 Started /root/sipconfig/startkamailio.sh
2024-01-23T13:18:09.570+01:00 info: :-) Starting Kamailio
```
#### SIP Traffic
### Possible Solutions
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
# /usr/sbin/kamailio -v
version: kamailio 5.6.5 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 10.2.1
```
* **Operating System**:
```
# lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description: Debian GNU/Linux 11 (bullseye)
Release: 11
Codename: bullseye
Linux ip-nn-nn-nn-nn 5.10.0-25-cloud-amd64 #1 SMP Debian 5.10.191-1 (2023-08-16) x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3725
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3725(a)github.com>
[View Less]
- Adding missing ims_icscf database parameters to admin documents.
- Change the default value for ims_icscf db_url to Kamailio default db_url value.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to …
[View More]stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ :white_check_mark: ] Commit message has the format required by CONTRIBUTING guide
- [ :white_check_mark:] Commits are split per component (core, individual modules, libs, utils, ...)
- [ :white_check_mark:] Each component has a single commit (if not, squash them into one commit)
- [ :white_check_mark:] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ :white_check_mark:] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ :white_check_mark:] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Only an improvement for users to know they need to set database params for ims_icscf module.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3874
-- Commit Summary --
* ims_icscf: add missing documents for database params
-- File Changes --
M src/modules/ims_icscf/doc/ims_icscf_admin.xml (100)
M src/modules/ims_icscf/ims_icscf_mod.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3874.patchhttps://github.com/kamailio/kamailio/pull/3874.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3874
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3874(a)github.com>
[View Less]
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature …
[View More](non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This enables tls module statistics. This is needed for the xhttp_prom module to export tls module statistics.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3852
-- Commit Summary --
* tls: enable statistics
* tls: code formatting
-- File Changes --
M src/modules/tls/tls_mod.c (43)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3852.patchhttps://github.com/kamailio/kamailio/pull/3852.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3852
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3852(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3869
-- Commit Summary --
* ims_registrar_pcscf: fix typo in comments
* ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact
-- File Changes --
M src/modules/ims_ipsec_pcscf/cmd.c (12)
M src/modules/ims_registrar_pcscf/save.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3869.patchhttps://github.com/kamailio/kamailio/pull/3869.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3869
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3869(a)github.com>
[View Less]
The Kamailio ims_charging module Ro interface is sending:
AVP: User-Equipment-Info(458) -> AVP: User-Equipment-Info-Type(459) l=12 f=-M- val=MAC (1)
see attached Ro.pcapng packet #7.
but (unless I'm not understanding correctly) according to TS 132 299 this AVP should be of type IMEISV and not MAC for the Ro charging interface. also, the MAC is not encoded correctly. again, see the attached pcap at packet #7
from TS 132 299:
"User-Equipment-Info-Type This field determines the type …
[View More]of the identifier. The used value is 0 for the international mobile equipment identifier and software version according to TS 23.003[224].
User-Equipment-Info-Value This field contains the user IMEI."
"For PS charging, when the User-Equipment-Info-Type AVP (AVP code 459) is set to IMEISV (0), the value within the
User-Equipment-Info-Value AVP (AVP code 460) is of type OctetString and shall be a UTF-8 encoded hexadecimal.
The composition of the IMEISV follows the definition in TS 23.003 [224] . If only IMEI is received a filler ‘F’ is used
to make it 16 digits."
"For IMS charging, when the User-Equipment-Info-Type AVP (AVP code 459) is set to IMEISV (0), the value within
the User-Equipment-Info-Value AVP (AVP code 460) is of type OctetString and shall be a UTF-8 encoded decimal.
The composition of the IMEISV follows the definition in TS 23.003 [224]. If only IMEI is received the number of
digits are truncated to 15."
I have tested and found this in the following versions:
version: kamailio 5.9.0-dev0 (x86_64/linux) 4fb8ac
version: kamailio 5.3.2 (x86_64/linux) 87e8a1
Thank you so much for your help with this issue,
[Ro.zip](https://github.com/kamailio/kamailio/files/14924042/Ro.zip)
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3807
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3807(a)github.com>
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/…
[View More]lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
During de-registration, Kamailio receives REGISTER (with expire 0), and then send Session Termination request, and only after getting Session Termination Answer, Kamailo sends 200OK. This is not sent till UE. The reason is after receiving Session Termination Request, the PCRF sends ReAuthRequest towards PCEF and it followed delete bearer procedure in IMS-PGW and bearer is getting deleted :(.
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
In the kamailio script, pcscf_save() is used after receiving 200OK from SCSCF. And within this function, STR is sent and STA received.
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
RX_SUPPORT flag shall be defined and it can be observed in De-registration procedure.
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
kamailio --version
version: kamailio 5.7.5 (x86_64/linux) 58499a-dirty
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 58499a -dirty
compiled on 11:23:55 May 8 2024 with gcc 9.4.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
uname -a
Linux openims-tvmcfg-node-focal 5.4.0-181-generic #201-Ubuntu SMP Thu Mar 28 15:39:01 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3866
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3866(a)github.com>
[View Less]
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual …
[View More]modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
#### Description
On start:
```
CRITICAL: <core> [core/ip_addr.c:232]: ip_addr2sbuf(): unknown address family 0
NOTICE: tls [tls_domain.c:1176]: ksr_tls_fix_domain(): registered server_name callback handler for socket [:0], server_name='<default>' ...
```
Now it will print:
```
NOTICE: tls [tls_domain.c:1176]: ksr_tls_fix_domain(): registered server_name callback handler for socket [0.0.0.0:0], server_name='<default>' ...
```
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3875
-- Commit Summary --
* tls: remove confusing error message when trying to print socket for <default> server
-- File Changes --
M src/modules/tls/tls_domain.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3875.patchhttps://github.com/kamailio/kamailio/pull/3875.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3875
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3875(a)github.com>
[View Less]
For tcp based transports it is need to set SND_F_FORCE_SOCKET flag before msg_send_buffer call, or duplicate will send from wrong addr/port.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable …
[View More]branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3837
-- Commit Summary --
* siptrace: add SND_F_FORCE_SOCKET flag if send_sock_name/send_sock_address config parameters are used
-- File Changes --
M src/modules/siptrace/siptrace_send.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3837.patchhttps://github.com/kamailio/kamailio/pull/3837.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3837
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3837(a)github.com>
[View Less]
Hello,
Kamailio SIP Server v5.8.2 stable release is out.
This is a maintenance release of the latest stable branch, 5.8, that
includes fixes since the release of v5.8.1. There is no change to
database schema or configuration language structure that you have to do
on previous installations of v5.8.x. Deployments running previous v5.8.x
versions are strongly recommended to be upgraded to v5.8.2.
For more details about version 5.8.2 (including links and guidelines to
download the tarball or …
[View More]from GIT repository), visit:
* https://www.kamailio.org/w/2024/06/kamailio-v5-8-2-released/
RPM, Debian/Ubuntu packages will be available soon as well.
Many thanks to all contributing and using Kamailio!
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
[View Less]
Hello,
I am considering to release Kamailio v5.8.2 (out of branch 5.8) on
Wednesday,
June 12, 2024. If anyone is aware of issues not yet on the bug tracker,
report them there asap in order to have a better chance to be fixed.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
- Adding missing ims_icscf database parameters documents.
- Change the default value for ims_icscf db_url to Kamailio db_url.
- ims_usrloc_pcscf: fix the db_url type from into to string in document.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from …
[View More]master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ :white_check_mark:] Commit message has the format required by CONTRIBUTING guide
- [ :white_check_mark:] Commits are split per component (core, individual modules, libs, utils, ...)
- [ :white_check_mark:] Each component has a single commit (if not, squash them into one commit)
- [ :white_check_mark:] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ :white_check_mark: ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ :white_check_mark:] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3873
-- Commit Summary --
* ims_icscf: add missing documents for database params
-- File Changes --
M src/modules/ims_icscf/doc/ims_icscf_admin.xml (100)
M src/modules/ims_icscf/ims_icscf_mod.c (3)
M src/modules/ims_usrloc_pcscf/doc/ims_usrloc_pcscf_admin.xml (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3873.patchhttps://github.com/kamailio/kamailio/pull/3873.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3873
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3873(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3806
-- Commit Summary --
* pike: fix documentation for reqs_density_per_unit
-- File Changes --
M src/modules/pike/doc/pike_admin.xml (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3806.patchhttps://github.com/kamailio/kamailio/pull/3806.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3806
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3806(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: dd30f8b905a80f85891df72a1f865c9ad1508c9a
URL: https://github.com/kamailio/kamailio/commit/dd30f8b905a80f85891df72a1f865c9…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-06-10T13:16:10+02:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]dd30f8b905a80f85891df72a1f865c9…
Patch: https://github.com/kamailio/kamailio/commit/dd30f8b905a80f85891df72a1f865c9…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index c095bc201be..1e99229575a 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -122,7 +122,7 @@ Federico Cabiddu
4.14. ds_load_unset()
4.15. ds_reload()
4.16. ds_dsg_fetch(setid)
- 4.17. ds_oc_set_rate(setid, uri, val)
+ 4.17. ds_oc_set_attrs(setid, uri, rval, tval)
5. RPC Commands
@@ -212,7 +212,7 @@ Federico Cabiddu
1.57. ds_load_unset usage
1.58. ds_reload usage
1.59. ds_dsg_fetch() usage
- 1.60. ds_oc_set_rate() usage
+ 1.60. ds_oc_set_attrs() usage
1.61. dispatcher list file
1.62. Kamailio config script - sample dispatcher usage
@@ -291,7 +291,7 @@ Chapter 1. Admin Guide
4.14. ds_load_unset()
4.15. ds_reload()
4.16. ds_dsg_fetch(setid)
- 4.17. ds_oc_set_rate(setid, uri, val)
+ 4.17. ds_oc_set_attrs(setid, uri, rval, tval)
5. RPC Commands
@@ -1118,7 +1118,7 @@ modparam("dispatcher", "ds_interval_mode", 7200)
4.14. ds_load_unset()
4.15. ds_reload()
4.16. ds_dsg_fetch(setid)
- 4.17. ds_oc_set_rate(setid, uri, val)
+ 4.17. ds_oc_set_attrs(setid, uri, rval, tval)
4.1. ds_select_dst(set, alg[, limit])
@@ -1636,22 +1636,26 @@ onreply_route {
xinfo("set id: 1 - all: $dsg(count); active: $dsg(active)\n");
...
-4.17. ds_oc_set_rate(setid, uri, val)
+4.17. ds_oc_set_attrs(setid, uri, rval, tval)
- Sets the overload control rate for the destination (setid, uri).
+ Sets the overload control rate and time internval limit for the
+ destination (setid, uri).
Description of parameters:
* setid - the set (group) id. The parameter can be an integer or a
variable holding an integer value.
* uri - the URI of the destination.
- * val - the value of the overload control rate (from 1 to 100) - how
+ * rval - the value of the overload control rate (from 1 to 100) - how
many times to skip using this destination in 100 selections.
+ * tval - time interval limit to apply the overload control rate (in
+ milliseconds). If the value is 0 or negative, then the default
+ value 500 is used.
This function can be used from ANY_ROUTE.
- Example 1.60. ds_oc_set_rate() usage
+ Example 1.60. ds_oc_set_attrs() usage
...
- ds_oc_set_rate("1", "sip:127.0.0.1:5080", "30");
+ ds_oc_set_attrs("1", "sip:127.0.0.1:5080", "30", "1000");
...
5. RPC Commands
[View Less]
Module: kamailio
Branch: master
Commit: 244fc84a971d3381e731dab558c19d96e0922f5f
URL: https://github.com/kamailio/kamailio/commit/244fc84a971d3381e731dab558c19d9…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-06-10T12:49:42+02:00
dispatcher: docs for ds_oc_set_attrs(...)
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]244fc84a971d3381e731dab558c19d9…
Patch: https://github.com/kamailio/kamailio/commit/244fc84a971d3381e731dab558c19d9…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index e0e8d1beed8..62e212f8744 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -2014,12 +2014,13 @@ onreply_route {
</programlisting>
</example>
</section>
- <section id="dispatcher.f.ds_oc_set_rate">
+ <section id="dispatcher.f.ds_oc_set_attrs">
<title>
- <function moreinfo="none">ds_oc_set_rate(setid, uri, val)</function>
+ <function moreinfo="none">ds_oc_set_attrs(setid, uri, rval, tval)</function>
</title>
<para>
- Sets the overload control rate for the destination (setid, uri).
+ Sets the overload control rate and time internval limit
+ for the destination (setid, uri).
</para>
<para>Description of parameters:</para>
<itemizedlist>
@@ -2032,9 +2033,14 @@ onreply_route {
<para><emphasis>uri</emphasis> - the URI of the destination.</para>
</listitem>
<listitem>
- <para><emphasis>val</emphasis> - the value of the overload control
+ <para><emphasis>rval</emphasis> - the value of the overload control
rate (from 1 to 100) - how many times to skip using this destination
in 100 selections.</para>
+ </listitem>
+ <listitem>
+ <para><emphasis>tval</emphasis> - time interval limit to apply the
+ overload control rate (in milliseconds). If the value is 0 or
+ negative, then the default value 500 is used.</para>
</listitem>
</itemizedlist>
@@ -2042,10 +2048,10 @@ onreply_route {
This function can be used from ANY_ROUTE.
</para>
<example>
- <title><function>ds_oc_set_rate()</function> usage</title>
+ <title><function>ds_oc_set_attrs()</function> usage</title>
<programlisting format="linespecific">
...
- ds_oc_set_rate("1", "sip:127.0.0.1:5080", "30");
+ ds_oc_set_attrs("1", "sip:127.0.0.1:5080", "30", "1000");
...
</programlisting>
</example>
[View Less]
Module: kamailio
Branch: 5.8
Commit: 955c6e02ed0e31a4c7f148518bf44edb12c37a07
URL: https://github.com/kamailio/kamailio/commit/955c6e02ed0e31a4c7f148518bf44ed…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-06-08T20:31:20+02:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/ims_ipsec_pcscf/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]955c6e02ed0e31a4c7f148518bf44ed…
Patch: https://github.com/kamailio/kamailio/commit/955c6e02ed0e31a4c7f148518bf44ed…
---
diff --git a/src/modules/ims_ipsec_pcscf/README b/src/modules/ims_ipsec_pcscf/README
index bce99b791da..3d831eb2c47 100644
--- a/src/modules/ims_ipsec_pcscf/README
+++ b/src/modules/ims_ipsec_pcscf/README
@@ -361,7 +361,7 @@ ipsec_destroy("location");
recv_host - received host to match the record.
recv_port - received port to match the record.
- The last three parameters have to be string valies and can contain
+ The last three parameters have to be string values and can contain
variables.
Example 1.14. ipsec_destroy_by_contact()
[View Less]
### Description
What I did: I enabled the pua_dialoginfo module to publish changes for both the caller and the callee.
What I expected: PUBLISH to be generated for the caller and the callee
What actually happened: PUBLISH is only generated for the callee.
### Troubleshooting
I troubleshooted the issue by adding LM_ERR messages at various point in the pua_dialoginfo.c
#### Reproduction
Add a db-url as modparam to pua
Do not add any modparam to pua_dialoginfo.
Then make a phone call while …
[View More]making sure dialog.dlg_manage() is called to track the call.
#### Debugging Data
Not applicable
#### Log Messages
pua_dialoginfo [dialog_publish.c:303]: dialog_publish(): failed to parse the PUBLISH R-URI
### Possible Solutions
I tracked the issue to line 840 of pua_dialoginfo.c (see enclosed patch file), where dlginfo->pubruris_caller->s.s is set to the value of dlginfo->from_uri but dlginfo->pubruris_caller->s.len is not set to anything (left at zero).
So I added a line to set the len value to the len value of dlginfo->from_uri.len
See patch below:
```
diff -ru a/src/modules/pua_dialoginfo/pua_dialoginfo.c b/src/modules/pua_dialoginfo/pua_dialoginfo.c
--- a/src/modules/pua_dialoginfo/pua_dialoginfo.c 2024-05-02 11:14:34.150097771 -0600
+++ b/src/modules/pua_dialoginfo/pua_dialoginfo.c 2024-05-02 11:09:30.855960974 -0600
@@ -838,6 +838,8 @@
}
memset(dlginfo->pubruris_caller, 0, sizeof(struct str_list));
dlginfo->pubruris_caller->s.s = shm_str2char_dup(&dlginfo->from_uri);
+ dlginfo->pubruris_caller->s.len = dlginfo->from_uri.len;
+
if(!dlginfo->pubruris_caller->s.s) {
free_dlginfo_cell(dlginfo);
return NULL;
```
### Additional Information
version: kamailio 5.8.1 (x86_64/linux) 384843
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 384843
compiled on 13:45:08 May 2 2024 with gcc 10.2.1
* **Operating System**:
Linux yto11-stg-smf-vtr1.vcn.ms 5.10.0-27-amd64 #1 SMP Debian 5.10.205-2 (2023-12-31) x86_64 GNU/Linux
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3838
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3838(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3838
#### Description
<!-- Describe your changes in detail -->
This PR fixes a bug where R-URI couldn't be parsed correctly by assing the correct length to the str variable
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3871
-- Commit Summary --
* pua_dialoginfo: Fix ruri length
-- File Changes --
M src/modules/pua_dialoginfo/pua_dialoginfo.c (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3871.patchhttps://github.com/kamailio/kamailio/pull/3871.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3871
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3871(a)github.com>
[View Less]
### Description
Carrierroute's CRC32 algorithm over call_id tends to produce poor call distribution under real world examples. Having 4 records for a given carrier/domain combo (assuming no flags, mask, or scan_prefix) and a probability of `0.25` using a hash source of `call_id` I observed over 800 hundred consecutive calls from a carrier (bandwidth.com) where `CRC32(call_id) % 1000` was less than 250.
To be fair, the module does what it says - it uses a CRC32 hash over the call id, …
[View More]however the data from the UA generating the call is yielding poor results. Would it be possible to change to an alternate hashing mechanism (or add another hashing mechanism, selectable via `modparam`) such as MD5?
### Expected behavior
Even distribution across all hosts provided.
#### Actual observed behavior
Uneven distribution under real-world conditions.
#### Debugging Data
I can provide a list of > 800 call-ids observed that all routed to the same endpoint. These are pulled from real world calls, and while there's not much danger in just having call-id's I would still prefer not to post it into github for posterity.
#### Log Messages
Log messages end up looking similar to this. I validated that the number is the CRC32 hash of the call id, so it's not a bug in the module.
```
proxy-1 | 1(7) DEBUG: carrierroute [cr_func.c:449]: rewrite_on_rule(): searching for matching routing rules 1(7) DEBUG: carrierroute [prime_hash.c:66]: hash_func(): hash: 2417021133 % 1000 = 133
proxy-1 | 1(7) INFO: carrierroute [cr_func.c:689]: ki_cr_do_route_helper(): uri service was rewritten to sip:service@host-d, carrier 1, domain 1
```
### Possible Solutions
Ability to use MD5, kamailio's core hash function or other such hashing function
### Additional Information
Problem validate in 5.7.3, but since it's *correct* by module design, it shouldn't have changed in 5.8
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3786
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3786(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 637c5ce2a9f2a9f82937f9102545f896a5a8abed
URL: https://github.com/kamailio/kamailio/commit/637c5ce2a9f2a9f82937f9102545f89…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-06-07T19:46:11+02:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
Modified: src/modules/ims_ipsec_pcscf/README
---
Diff: https://github.com/…
[View More]kamailio/kamailio/commit/637c5ce2a9f2a9f82937f9102545f89…
Patch: https://github.com/kamailio/kamailio/commit/637c5ce2a9f2a9f82937f9102545f89…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index c915f552809..c095bc201be 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -1644,7 +1644,7 @@ onreply_route {
* setid - the set (group) id. The parameter can be an integer or a
variable holding an integer value.
* uri - the URI of the destination.
- * val - the valie of the overload control rate (from 1 to 100) - how
+ * val - the value of the overload control rate (from 1 to 100) - how
many times to skip using this destination in 100 selections.
This function can be used from ANY_ROUTE.
diff --git a/src/modules/ims_ipsec_pcscf/README b/src/modules/ims_ipsec_pcscf/README
index bce99b791da..3d831eb2c47 100644
--- a/src/modules/ims_ipsec_pcscf/README
+++ b/src/modules/ims_ipsec_pcscf/README
@@ -361,7 +361,7 @@ ipsec_destroy("location");
recv_host - received host to match the record.
recv_port - received port to match the record.
- The last three parameters have to be string valies and can contain
+ The last three parameters have to be string values and can contain
variables.
Example 1.14. ipsec_destroy_by_contact()
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Fix two small typos
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3870
-- Commit Summary --
* dispatcher: Fix typo
* ims_ipsec_pcscf: Fix typo
-- File Changes --
M src/modules/dispatcher/doc/dispatcher_admin.xml (2)
M src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3870.patchhttps://github.com/kamailio/kamailio/pull/3870.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3870
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3870(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 16e1b38fcc1593ad09eb03d86cd056ab8ff7f7f7
URL: https://github.com/kamailio/kamailio/commit/16e1b38fcc1593ad09eb03d86cd056a…
Author: Bastian Triller <bastian.triller(a)gmail.com>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-06-07T19:37:57+02:00
ims_ipsec_pcscf: Fix typo
---
Modified: src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]16e1b38fcc1593ad09eb03d86cd056a…
Patch: https://github.com/kamailio/kamailio/commit/16e1b38fcc1593ad09eb03d86cd056a…
---
diff --git a/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml b/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
index ee58f16fb63..f4a388ee777 100644
--- a/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
+++ b/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
@@ -405,7 +405,7 @@ ipsec_destroy("location");
</para>
</listitem>
</itemizedlist>
- <para>The last three parameters have to be string valies and can contain
+ <para>The last three parameters have to be string values and can contain
variables.</para>
<example>
<title>ipsec_destroy_by_contact()</title>
[View Less]
Module: kamailio
Branch: master
Commit: e10a629a7737c12cc58a8abebf1fe67ed1f30ab9
URL: https://github.com/kamailio/kamailio/commit/e10a629a7737c12cc58a8abebf1fe67…
Author: Bastian Triller <bastian.triller(a)gmail.com>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-06-07T19:37:57+02:00
dispatcher: Fix typo
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/e10a629a7737c12cc58a8abebf1fe67……
[View More]
Patch: https://github.com/kamailio/kamailio/commit/e10a629a7737c12cc58a8abebf1fe67…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index cdd1ebc896e..e0e8d1beed8 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -2032,7 +2032,7 @@ onreply_route {
<para><emphasis>uri</emphasis> - the URI of the destination.</para>
</listitem>
<listitem>
- <para><emphasis>val</emphasis> - the valie of the overload control
+ <para><emphasis>val</emphasis> - the value of the overload control
rate (from 1 to 100) - how many times to skip using this destination
in 100 selections.</para>
</listitem>
[View Less]
Module: kamailio
Branch: master
Commit: a366c9a30f953571f89f539e87448ff0c5ac8585
URL: https://github.com/kamailio/kamailio/commit/a366c9a30f953571f89f539e87448ff…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-06-07T12:31:09+02:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]a366c9a30f953571f89f539e87448ff…
Patch: https://github.com/kamailio/kamailio/commit/a366c9a30f953571f89f539e87448ff…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index 209d77f4c87..c915f552809 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -122,6 +122,7 @@ Federico Cabiddu
4.14. ds_load_unset()
4.15. ds_reload()
4.16. ds_dsg_fetch(setid)
+ 4.17. ds_oc_set_rate(setid, uri, val)
5. RPC Commands
@@ -211,8 +212,9 @@ Federico Cabiddu
1.57. ds_load_unset usage
1.58. ds_reload usage
1.59. ds_dsg_fetch() usage
- 1.60. dispatcher list file
- 1.61. Kamailio config script - sample dispatcher usage
+ 1.60. ds_oc_set_rate() usage
+ 1.61. dispatcher list file
+ 1.62. Kamailio config script - sample dispatcher usage
Chapter 1. Admin Guide
@@ -289,6 +291,7 @@ Chapter 1. Admin Guide
4.14. ds_load_unset()
4.15. ds_reload()
4.16. ds_dsg_fetch(setid)
+ 4.17. ds_oc_set_rate(setid, uri, val)
5. RPC Commands
@@ -1115,6 +1118,7 @@ modparam("dispatcher", "ds_interval_mode", 7200)
4.14. ds_load_unset()
4.15. ds_reload()
4.16. ds_dsg_fetch(setid)
+ 4.17. ds_oc_set_rate(setid, uri, val)
4.1. ds_select_dst(set, alg[, limit])
@@ -1227,6 +1231,9 @@ GATEWAY | PRIORITY | ESTIMATED | ADJUSTED | LOAD
With congestion control the formula becomes :
CONGESTION_MS = CURRENT_LATENCY_MS - NORMAL_CONDITION_LATENCY_MS
ADJUSTED_PRIORITY = PRIORITY - (CONGESTION_MS/PRIORITY)
+ + ���64��� - round-robin (next destination) with over load control
+ (destination record is skipped based on over load control
+ rate).
+ ���X��� - if the algorithm is not implemented, the first entry in
set is chosen.
* limit - the maximum number of items to be stored in XAVP list for
@@ -1629,6 +1636,24 @@ onreply_route {
xinfo("set id: 1 - all: $dsg(count); active: $dsg(active)\n");
...
+4.17. ds_oc_set_rate(setid, uri, val)
+
+ Sets the overload control rate for the destination (setid, uri).
+
+ Description of parameters:
+ * setid - the set (group) id. The parameter can be an integer or a
+ variable holding an integer value.
+ * uri - the URI of the destination.
+ * val - the valie of the overload control rate (from 1 to 100) - how
+ many times to skip using this destination in 100 selections.
+
+ This function can be used from ANY_ROUTE.
+
+ Example 1.60. ds_oc_set_rate() usage
+...
+ ds_oc_set_rate("1", "sip:127.0.0.1:5080", "30");
+...
+
5. RPC Commands
5.1. dispatcher.set_state
@@ -1890,6 +1915,10 @@ kamctl rpc dispatcher.hash 4 bob server.com
* 'obproxy' - SIP URI of outbound proxy to be used when sending
pings. It overwrites the general ds_outbound_proxy parameter.
* 'latency' - latency_stats initialization in ms.
+ * 'ocmin' - minimum limit for over load control rate (value between 0
+ and 100, default 10).
+ * 'ocrate' - over load control rate (value between 0 and 100, default
+ 100).
6.1.2. File Format
@@ -1907,7 +1936,7 @@ setid(int) destination(sip uri) flags(int,opt) priority(int,opt) attrs(str,opt)
For database, each element of a line resides in a different column.
Next is a dispatcher.list file example:
- Example 1.60. dispatcher list file
+ Example 1.61. dispatcher list file
...
#
# dispatcher destination sets (groups)
@@ -1932,7 +1961,7 @@ r,opt)
Next listing shows a sample config for using the dispatcher module.
- Example 1.61. Kamailio config script - sample dispatcher usage
+ Example 1.62. Kamailio config script - sample dispatcher usage
...
#!KAMAILIO
#
[View Less]
Module: kamailio
Branch: master
Commit: c2bde271f9d606e6cef987a223f746092c59d306
URL: https://github.com/kamailio/kamailio/commit/c2bde271f9d606e6cef987a223f7460…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-06-07T12:02:04+02:00
dispatcher: docs for algorithm 64 - round robin with overload control
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/…
[View More]kamailio/commit/c2bde271f9d606e6cef987a223f7460…
Patch: https://github.com/kamailio/kamailio/commit/c2bde271f9d606e6cef987a223f7460…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index 83ef06285a0..979b59798af 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -1418,6 +1418,13 @@ With congestion control the formula becomes :
</programlisting>
</example>
</listitem>
+ <listitem>
+ <para>
+ <quote>64</quote> - round-robin (next destination) with over
+ load control (destination record is skipped based on over
+ load control rate).
+ </para>
+ </listitem>
<listitem>
<para>
<quote>X</quote> - if the algorithm is not implemented, the
@@ -2388,6 +2395,14 @@ kamctl rpc dispatcher.hash 4 bob server.com
<listitem>
<para>'latency' - latency_stats initialization in ms.</para>
</listitem>
+ <listitem>
+ <para>'ocmin' - minimum limit for over load control rate
+ (value between 0 and 100, default 10).</para>
+ </listitem>
+ <listitem>
+ <para>'ocrate' - over load control rate
+ (value between 0 and 100, default 100).</para>
+ </listitem>
</itemizedlist>
</para>
</section>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Add a new update/delete function based on contact's uniq uniq. Some devices may use same uniq for multiple contacts, so I needed to restrain it further based on ruid value.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3865
-- Commit Summary --
* p_usrloc: Add update/delete based on uniq
-- File Changes --
M src/modules/p_usrloc/doc/p_usrloc_admin.xml (5)
M src/modules/p_usrloc/ucontact.c (307)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3865.patchhttps://github.com/kamailio/kamailio/pull/3865.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3865
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3865(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Make timeout modparam runtime configurable.
Also update timout execeded logs from NOTICE to ERR and add more info to them.
Also update utils/pdbt.c query tool to allow 0 carrier id.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3850
-- Commit Summary --
* pdb: make 'timeout' runtime configurable
-- File Changes --
A src/modules/pdb/config.c (42)
A src/modules/pdb/config.h (37)
M src/modules/pdb/pdb.c (40)
M utils/pdbt/pdbt.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3850.patchhttps://github.com/kamailio/kamailio/pull/3850.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3850
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3850(a)github.com>
[View Less]
Hello,
based on many reports coming over along all the past years, there are
crashes that happen on module destroy callbacks, many could be fixed,
but some cannot be predicted, depending on the moment when the kill
(shut down) is triggered.
Furthermore, there are cases when the clean makes no much sense, like
attempting to close the DB connection, because the destroy callback is
executed by Kamailio's main process only, which does not handle SIP
traffic and usually does not have DB connection,…
[View More]. So actually, all the
other connections from the SIP works are clean up automatically by the
OS on process shut down.
Also, the pkg and shm blocks are cleaned up as a whole after all,
therefore trying to free chunks inside them that were used by various
internal structures is kind of waste of time. The main purpose to do it
in the past it to be able to discover memory leaks by having status
reports written in syslog, but these reports can be triggered by RPC
during runtime and it is even better to get them in such way.
I think that the best is to use module destroy callbacks only to save
data to backend (e.g., database) that has to be reloaded on restart, and
leave the memory/resources clean up to the OS. In this way we also deal
nicer with the inter-modules dependencies, the structures of a module
will be always available, even after its mod-destroy callback execution,
so if another module depending on them still wants to access, it should
be no problem.
At the last Kamailio Devel meeting we had a brief discussion that we may
want to change mod-destroy to be done in two steps, first for storing
meeded data to backed and then do the cleanup, but I think it is better
without the 2nd step.
Any comments or other suggestions?
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
[View Less]