### Description
Since 5.7.4, the `htable.seti` RPC command returns error 500. This seems to occur whenever an integer value is passed. If the integer is passed as a decimal (eg. `1.0` or `1.`) the error disappears. Also reproducible with latest master.
### Troubleshooting
Bisecting shows the offending commit to be https://github.com/kamailio/kamailio/commit/dc59286c26e9799f86e698a9698c9da…. Reverting this commit fixes the 500 error but reintroduces the previous error referenced in the commit.
#### Reproduction
```
$ kamcmd htable.seti rconfig foo 1
error: 500 - Not enough parameters (htable name, key name and value)
```
#### Log Messages
No messages in the kamailio log when the error occurs. The RPC command responds with
```
error: 500 - Not enough parameters (htable name, key name and value)
```
### Possible Solutions
A workaround is to pass the value as a decimal value, eg. `1.0`. Any decimals are ignored since the value is treated as an integer.
For XMLRPC this can be worked around by explicitly passing the value as an integer (passing the value as `i/1`).
### Additional Information
```
version: kamailio 5.9.0-dev0 (x86_64/linux) f6f9d9
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: f6f9d9
compiled on 11:57:50 Mar 5 2024 with gcc 13.2.1
```
* **Operating System**:
Reproduced on the following:
```
Linux jon 6.6.2-arch1-1 #1 SMP PREEMPT_DYNAMIC Mon, 20 Nov 2023 23:18:21 +0000 x86_64 GNU/Linux
```
```
Linux ip-10-105-240-190 4.9.0-19-amd64 #1 SMP Debian 4.9.320-2 (2022-06-30) x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3774
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3774(a)github.com>
Module: kamailio
Branch: 5.8
Commit: 7bcef8ef487a713f5b6c6fadb7a3166ed41fb136
URL: https://github.com/kamailio/kamailio/commit/7bcef8ef487a713f5b6c6fadb7a3166…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-03-20T13:31:25+01:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/7bcef8ef487a713f5b6c6fadb7a3166…
Patch: https://github.com/kamailio/kamailio/commit/7bcef8ef487a713f5b6c6fadb7a3166…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index 79fc82ec175..209d77f4c87 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -1489,9 +1489,16 @@ if(ds_list_exists("10")) {
ignoring the protocol (value 2). If parameter is 0, all ip, port
and proto are matched and active status is ignored. If bit one is
set, then port is ignored. If bit two is set, then protocol is
- ignored. If bit three is set, then state must be active. The
- parameter can be an integer or a variable holding an integer value.
- It must be provided if the uri parameter is provided.
+ ignored. If bit three is set, then state must be active. If bit
+ four is set, then socket/sockname be matched. If bit five is set,
+ then try to find the most closest target from all dispatcher
+ targets with the mandatory ip and combination of local socket,
+ protocol, port, the weighted search result is combined from bit
+ flags of matched components: ip - 1, port - 2, protocol - 4, local
+ socket - 8, the target with the maximum value of flags combination
+ will be selected. The parameter can be an integer or a variable
+ holding an integer value. It must be provided if the uri parameter
+ is provided.
* uri (optional) - if parameter is empty or missing, the matching is
done against source IP, port and protocol. Otherwise the value has
to be a valid SIP URI, used to match against addresses in the
Module: kamailio
Branch: 5.7
Commit: f654b9c1943be6816827f9048627a7c8a7fe50f6
URL: https://github.com/kamailio/kamailio/commit/f654b9c1943be6816827f9048627a7c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-20T13:26:43+01:00
keepalive: small formatting updates and comments to the ka dest structure
(cherry picked from commit cee82c92b06a026b88fea654944f6146eb5cb4d8)
(cherry picked from commit a7d4ce95b383dc26c547ef9ee07b05d51abc50f9)
---
Modified: src/modules/keepalive/keepalive.h
---
Diff: https://github.com/kamailio/kamailio/commit/f654b9c1943be6816827f9048627a7c…
Patch: https://github.com/kamailio/kamailio/commit/f654b9c1943be6816827f9048627a7c…
---
diff --git a/src/modules/keepalive/keepalive.h b/src/modules/keepalive/keepalive.h
index d5a8fcb2197..5ca1ce3561d 100644
--- a/src/modules/keepalive/keepalive.h
+++ b/src/modules/keepalive/keepalive.h
@@ -69,13 +69,15 @@ typedef struct _ka_initial_dest
typedef struct _ka_dest
{
str uri;
- str owner; // name of destination "owner"
- // (module asking to monitor this destination
- str uuid; // Universal id for this record
+ str owner; /*!< Name of destination "owner" */
+ /*!< Module asking to monitor this destination */
+ str uuid; /*!< Universal id for this record */
int flags;
int state;
- time_t last_checked, last_up, last_down;
- int counter; // counts unreachable attempts
+ time_t last_checked;
+ time_t last_up; /*!< Time of last successful SIP reply */
+ time_t last_down; /*!< Time of last failure SIP reply */
+ int counter; /*!< Counts unreachable attempts */
ticks_t ping_interval; /*!< Actual interval between OPTIONS */
void *user_attr;
Module: kamailio
Branch: 5.8
Commit: a7d4ce95b383dc26c547ef9ee07b05d51abc50f9
URL: https://github.com/kamailio/kamailio/commit/a7d4ce95b383dc26c547ef9ee07b05d…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-20T13:16:00+01:00
keepalive: small formatting updates and comments to the ka dest structure
(cherry picked from commit cee82c92b06a026b88fea654944f6146eb5cb4d8)
---
Modified: src/modules/keepalive/keepalive.h
---
Diff: https://github.com/kamailio/kamailio/commit/a7d4ce95b383dc26c547ef9ee07b05d…
Patch: https://github.com/kamailio/kamailio/commit/a7d4ce95b383dc26c547ef9ee07b05d…
---
diff --git a/src/modules/keepalive/keepalive.h b/src/modules/keepalive/keepalive.h
index d5a8fcb2197..5ca1ce3561d 100644
--- a/src/modules/keepalive/keepalive.h
+++ b/src/modules/keepalive/keepalive.h
@@ -69,13 +69,15 @@ typedef struct _ka_initial_dest
typedef struct _ka_dest
{
str uri;
- str owner; // name of destination "owner"
- // (module asking to monitor this destination
- str uuid; // Universal id for this record
+ str owner; /*!< Name of destination "owner" */
+ /*!< Module asking to monitor this destination */
+ str uuid; /*!< Universal id for this record */
int flags;
int state;
- time_t last_checked, last_up, last_down;
- int counter; // counts unreachable attempts
+ time_t last_checked;
+ time_t last_up; /*!< Time of last successful SIP reply */
+ time_t last_down; /*!< Time of last failure SIP reply */
+ int counter; /*!< Counts unreachable attempts */
ticks_t ping_interval; /*!< Actual interval between OPTIONS */
void *user_attr;
Module: kamailio
Branch: 5.8
Commit: 7df7508d7d2b7b9495dafab8b515a5721bd669ee
URL: https://github.com/kamailio/kamailio/commit/7df7508d7d2b7b9495dafab8b515a57…
Author: Dennis Yurasov <dennis-y(a)yandex-team.ru>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-20T13:14:16+01:00
dispatcher: refine documentation
- more clear documentation for the new ds_is_from_list flags
(cherry picked from commit 761e963c0f7d9bf1b66c1ef18a409756b919ae2c)
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/7df7508d7d2b7b9495dafab8b515a57…
Patch: https://github.com/kamailio/kamailio/commit/7df7508d7d2b7b9495dafab8b515a57…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index 4708ca06c92..83ef06285a0 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -1805,9 +1805,12 @@ if(ds_list_exists("10")) {
If bit two is set, then protocol is ignored.
If bit three is set, then state must be active.
If bit four is set, then socket/sockname be matched.
- If bit five is set, then try to find the most complete
- "address/protocol/port/local socket" combination for all dispatcher targets. The parameter
- can be an integer or a variable holding an integer value.
+ If bit five is set, then try to find the most closest target from all
+ dispatcher targets with the mandatory ip and combination of local socket, protocol, port,
+ the weighted search result is combined from bit flags of matched components:
+ ip - 1, port - 2, protocol - 4, local socket - 8,
+ the target with the maximum value of flags combination will be selected.
+ The parameter can be an integer or a variable holding an integer value.
It must be provided if the uri parameter is provided.
</para>
</listitem>
This started happening with 5.8.0. I was to update our project with Docker image from 5.7.1 to 5.8.0
```
kamailio[594]: ERROR: acc [acc_extra.c:169]: parse_acc_extra(): parse failed in <callid=$dlg(callid);src_user=$(dlg(from_uri){uri.user});dst_user=$(dlg(to_uri){uri.user});xxx_channel_id=$dlg_var(xxx_channel_id);t_error=$dlg_var(to_original_user);src_original_user=$dlg_var(from_original_user);dst_original_user=$dlg_var(to_original_user)id);src_user=$(dlg(from_uri){uri.user});dst_user=$(dlg(to_uri){uri.user});xxx_channel_id=$dlg_var(xxx_channel_id);t_error=$dlg_var(to_original_user);src_original_user=$dlg_var(from_original_user);dst_original_user=$dlg_var(to_original_user> around position 257
kamailio[594]: ERROR: acc [acc_extra.c:173]: parse_acc_extra(): error
kamailio[594]: ERROR: acc [acc_cdr.c:827]: set_cdr_extra(): failed to parse crd_extra param
kamailio[594]: ERROR: acc [acc_mod.c:528]: mod_init(): failed to set cdr extra 'callid=$dlg(callid);src_user=$(dlg(from_uri){uri.user});dst_user=$(dlg(to_uri){uri.user});xxx_channel_id=$dlg_var(xxx_channel_id);t_error=$dlg_var(to_original_user);src_original_user=$dlg_var(from_original_user);dst_original_user=$dlg_var(to_original_user)id);src_user=$(dlg(from_uri){uri.user});dst_user=$(dlg(to_uri){uri.user});xxx_channel_id=$dlg_var(xxx_channel_id);t_error=$dlg_var(to_original_user);src_original_user=$dlg_var(from_original_user);dst_original_user=$dlg_var(to_original_user'
kamailio[594]: ERROR: <core> [core/sr_module.c:1039]: init_mod(): Error while initializing module acc (/usr/lib/x86_64-linux-gnu/kamailio/modules/acc.so)
```
This is how it looks in cfg:
```
modparam("acc", "cdr_extra",
"callid=$dlg(callid);src_user=$(dlg(from_uri){uri.user});dst_user=$(dlg(to_uri){uri.user});"
"xxx_channel_id=$dlg_var(xxx_channel_id);t_error=$dlg_var(to_original_user);"
"src_original_user=$dlg_var(from_original_user);dst_original_user=$dlg_var(to_original_user)")
```
I have tested and it looks like it only happen if cdr_extra fields are bigger > 255 char.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3785
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3785(a)github.com>
Module: kamailio
Branch: master
Commit: cee82c92b06a026b88fea654944f6146eb5cb4d8
URL: https://github.com/kamailio/kamailio/commit/cee82c92b06a026b88fea654944f614…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-19T10:21:51+01:00
keepalive: small formatting updates and comments to the ka dest structure
---
Modified: src/modules/keepalive/keepalive.h
---
Diff: https://github.com/kamailio/kamailio/commit/cee82c92b06a026b88fea654944f614…
Patch: https://github.com/kamailio/kamailio/commit/cee82c92b06a026b88fea654944f614…
---
diff --git a/src/modules/keepalive/keepalive.h b/src/modules/keepalive/keepalive.h
index d5a8fcb2197..5ca1ce3561d 100644
--- a/src/modules/keepalive/keepalive.h
+++ b/src/modules/keepalive/keepalive.h
@@ -69,13 +69,15 @@ typedef struct _ka_initial_dest
typedef struct _ka_dest
{
str uri;
- str owner; // name of destination "owner"
- // (module asking to monitor this destination
- str uuid; // Universal id for this record
+ str owner; /*!< Name of destination "owner" */
+ /*!< Module asking to monitor this destination */
+ str uuid; /*!< Universal id for this record */
int flags;
int state;
- time_t last_checked, last_up, last_down;
- int counter; // counts unreachable attempts
+ time_t last_checked;
+ time_t last_up; /*!< Time of last successful SIP reply */
+ time_t last_down; /*!< Time of last failure SIP reply */
+ int counter; /*!< Counts unreachable attempts */
ticks_t ping_interval; /*!< Actual interval between OPTIONS */
void *user_attr;
AFAIK the commits from Herle Supreeth from its fork https://github.com/herlesupreeth/kamailio were migrated manually (not via PR) to upstream at the end of last year. While reviewing the migration I have found two discrepancies:
1. https://github.com/kamailio/kamailio/commit/8b9a2977e111d9adb8595d98ab59f8c… vs. https://github.com/kamailio/kamailio/commit/a6a3bd088368fbf65c283ae27e999d3…
```
herlesupreeth/kamailio (fork)
commit 8b9a2977e111d9adb8595d98ab59f8c8eb033120
Author: herlesupreeth <herlesupreeth(a)gmail.com>
Date: Mon Jun 7 14:01:54 2021 +0200
IPSec fixes
diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c
index 8e0cabcb80..9de3cf7331 100644
--- a/src/modules/ims_ipsec_pcscf/cmd.c
+++ b/src/modules/ims_ipsec_pcscf/cmd.c
@@ -937,7 +939,14 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d)
dst_port = s->port_us;
}
- int buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d", ci.via_host.len, ci.via_host.s, dst_port);
+ int buf_len = 0;
+ if (dst_proto == PROTO_TCP) {
+ buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d;transport=tcp", ci.via_host.len, ci.via_host.s, dst_port);
+ } else if (dst_proto == PROTO_TLS) {
+ buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d;transport=tls", ci.via_host.len, ci.via_host.s, dst_port);
+ } else {
+ buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d", ci.via_host.len, ci.via_host.s, dst_port);
+ }
if((m->dst_uri.s = pkg_malloc(buf_len + 1)) == NULL) {
LM_ERR("Error allocating memory for dst_uri\n");
```
vs.
```
kamailio/kamailio (upstream)
commit a6a3bd088368fbf65c283ae27e999d315db0844b
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Wed Jun 1 18:11:22 2022 +0200
ims_ipsec_pcscf: new option for ipsec_forward() to set trasport for tcp dst uri
diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c
index 5aa208d334..6f6c15e21b 100644
--- a/src/modules/ims_ipsec_pcscf/cmd.c
+++ b/src/modules/ims_ipsec_pcscf/cmd.c
@@ -947,8 +949,14 @@ int ipsec_forward(struct sip_msg *m, udomain_t *d, int _cflags)
if(!(_cflags & IPSEC_NODSTURI_RESET)) {
char buf[1024];
- int buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d", ci.via_host.len,
- ci.via_host.s, dst_port);
+ int buf_len;
+ if((_cflags & IPSEC_SETDSTURI_FULL) && (dst_proto == PROTO_TCP)) {
+ buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d;transport=tcp",
+ ci.via_host.len, ci.via_host.s, dst_port);
+ } else {
+ buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d", ci.via_host.len,
+ ci.via_host.s, dst_port);
+ }
if((m->dst_uri.s = pkg_malloc(buf_len + 1)) == NULL) {
LM_ERR("Error allocating memory for dst_uri\n");
```
To me it seems the handling of the case `dst_proto == PROTO_TLS` is missing upstream.
2. The commit https://github.com/kamailio/kamailio/commit/bfb0a17f3998d26991b4da7a8e83b8c… seems to be absent in upstream.
(From my point of view all the other commits are migrated fine, thanks for the good work!)
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3772
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3772(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Carrier id 0 might be a valid carrier number(e.g. for Germany D000-D999 are valid). Return negative carrier id in case of failures.
If all ok, I'd like to backport this to 5.8, 5.7 and 5.6
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3775
-- Commit Summary --
* pdb: Return negative carrierid for failures
-- File Changes --
M src/modules/pdb/pdb.c (14)
M utils/pdbt/pdb_server.c (2)
M utils/pdbt/pdb_server_backend.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3775.patchhttps://github.com/kamailio/kamailio/pull/3775.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3775
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3775(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [x] Related to issue #3772
#### Description
<!-- Describe your changes in detail -->
This patch was initially done by Herle Supreeth in his fork but isn't present upstream yet: https://github.com/kamailio/kamailio/commit/8b9a2977e111d9adb8595d98ab59f8c…
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3780
-- Commit Summary --
* ims_ipsec_pcscf: TLS support in ipsec_forward() improved
-- File Changes --
M src/modules/ims_ipsec_pcscf/cmd.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3780.patchhttps://github.com/kamailio/kamailio/pull/3780.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3780
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3780(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for feature requests.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If you submit a feature request (or enhancement) add the description of what you would like to be added.
If there is no content to be filled in a section, the entire section can be removed.
Note that a feature request may be closed automatically after about 2 months
if there is no interest from developers or community users to implement it, being
considered expired. In such case can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the item is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in the proposed feature request.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
We recently deployed successfully Kamailio with TLS certificates. Now we would like to use let's encrypt certificate which expire after 3 months. Means we need to renew certificate approximatively every 2 months. But while reading docs, in [known limitations](https://kamailio.org/docs/modules/devel/modules/tls.html#tls.k… it says :
> TLS specific config reloading is not safe, so for now better don't use it, especially under heavy traffic.
We struggle to understand if this behaviour is risky and not recommended under heavy traffic for certificate renewal. The doc has been added initially by @poandrei 18 years ago in Feb 21 2007 (see [commit](https://github.com/kamailio/kamailio/commit/32e4977cdb9c1c9ca24c140…)
While digging we came across few discussions Kamailio user groups which are saying "the opposite" (kind of):
- [Comments by a co-founder of Kamailio ](https://www.mail-archive.com/sr-users@lists.kamailio.org/msg16014.html)stating that the old connections shouldn’t be affected by reload.
- Comments by a Kamailio core developer stating that certificate reload is fine with the “reload” cmd ([link1](https://lists.kamailio.org/pipermail/sr-users/2022-February/114296.h…, [link2](https://github.com/kamailio/kamailio/issues/3305))
Plus in another section in docs:
- [By definition :](https://kamailio.org/docs/modules/devel/modules/tls.html#tls.r.tls.reload) (the) existing active TLS connections are not terminated and they continue to use the old certificates. The new configuration will be used for new connections.
So 18 years after, Is it safe to use `tls.reload` command in production and in heavy traffic for **TLS certificate renewal** ? Because it sounds scary and confusing.
So the documentation as it is, really needs clarifications to let users know which risk they're taking when running the `tls.reload` command.
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Expected behavior
The document should clearly documents risks, at least for certificate renewal.
#### Actual observed behavior
Docs and Kamailio user/dev groups are confusing.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3717
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3717(a)github.com>
#### Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #3592
#### Description
Building the WolfSSL module should be optional, even if it is on by default, builders should be able to choose to not need to install 4th party repositories.
See pr #3592 and specifically [this comment](https://github.com/kamailio/kamailio/pull/3592#issuecomment-198730…
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3781
-- Commit Summary --
* Allow builders to disable wolfssl module
-- File Changes --
M pkg/kamailio/obs/kamailio.spec (21)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3781.patchhttps://github.com/kamailio/kamailio/pull/3781.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3781
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3781(a)github.com>
Module: kamailio
Branch: master
Commit: e55d9f50be4adfc14ff9de45c77c23bd0f5e1981
URL: https://github.com/kamailio/kamailio/commit/e55d9f50be4adfc14ff9de45c77c23b…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-03-13T10:16:29+01:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/e55d9f50be4adfc14ff9de45c77c23b…
Patch: https://github.com/kamailio/kamailio/commit/e55d9f50be4adfc14ff9de45c77c23b…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index 17885b6f77c..209d77f4c87 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -1491,10 +1491,14 @@ if(ds_list_exists("10")) {
set, then port is ignored. If bit two is set, then protocol is
ignored. If bit three is set, then state must be active. If bit
four is set, then socket/sockname be matched. If bit five is set,
- then try to find the most complete "address/protocol/port/local
- socket" combination for all dispatcher targets. The parameter can
- be an integer or a variable holding an integer value. It must be
- provided if the uri parameter is provided.
+ then try to find the most closest target from all dispatcher
+ targets with the mandatory ip and combination of local socket,
+ protocol, port, the weighted search result is combined from bit
+ flags of matched components: ip - 1, port - 2, protocol - 4, local
+ socket - 8, the target with the maximum value of flags combination
+ will be selected. The parameter can be an integer or a variable
+ holding an integer value. It must be provided if the uri parameter
+ is provided.
* uri (optional) - if parameter is empty or missing, the matching is
done against source IP, port and protocol. Otherwise the value has
to be a valid SIP URI, used to match against addresses in the
- more clear documentation for the new ds_is_from_list flags
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3783
-- Commit Summary --
* dispatcher: refine documentation
-- File Changes --
M src/modules/dispatcher/doc/dispatcher_admin.xml (9)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3783.patchhttps://github.com/kamailio/kamailio/pull/3783.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3783
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3783(a)github.com>
Module: kamailio
Branch: master
Commit: 761e963c0f7d9bf1b66c1ef18a409756b919ae2c
URL: https://github.com/kamailio/kamailio/commit/761e963c0f7d9bf1b66c1ef18a40975…
Author: Dennis Yurasov <dennis-y(a)yandex-team.ru>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-13T10:08:05+01:00
dispatcher: refine documentation
- more clear documentation for the new ds_is_from_list flags
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/761e963c0f7d9bf1b66c1ef18a40975…
Patch: https://github.com/kamailio/kamailio/commit/761e963c0f7d9bf1b66c1ef18a40975…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index 4708ca06c92..83ef06285a0 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -1805,9 +1805,12 @@ if(ds_list_exists("10")) {
If bit two is set, then protocol is ignored.
If bit three is set, then state must be active.
If bit four is set, then socket/sockname be matched.
- If bit five is set, then try to find the most complete
- "address/protocol/port/local socket" combination for all dispatcher targets. The parameter
- can be an integer or a variable holding an integer value.
+ If bit five is set, then try to find the most closest target from all
+ dispatcher targets with the mandatory ip and combination of local socket, protocol, port,
+ the weighted search result is combined from bit flags of matched components:
+ ip - 1, port - 2, protocol - 4, local socket - 8,
+ the target with the maximum value of flags combination will be selected.
+ The parameter can be an integer or a variable holding an integer value.
It must be provided if the uri parameter is provided.
</para>
</listitem>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
This PR adds 2 new flags to the mode parameter of the ds_is_from_list function.
Some times the dispatcher configuration can look like this (route attribute is just for exampe, sockname is important here):
70 sip:192.168.1.1:5060;transport=udp 0 1 route=route1;sockname=udp_5060
71 sip:192.168.1.1:5060;transport=udp 0 1 route=route2;sockname=udp_5061
72 sip:192.168.1.1:5060;transport=udp 0 1 route=route3;sockname=udp_5062
73 sip:192.168.1.1:5060;transport=udp 0 1 route=route4;sockname=udp_5063
Here we have one host/port/protocol on the remote side and different ports that we are listening on,
In stock dispatcher version ds_is_from_list(-1,0) will always match first available - 70, but this is not right
for dst ports 5061-5063 (sockets in realality, because we can have different local ip on same port also).
The new mode flag DS_MATCH_SOCKET (8) allow match for dispatcher socket also.
Second flag is DS_MATCH_STRICTEST (16), it allow to match more strictness target in "address/protocol/port/socket" key,
for example:
70 sip:192.168.1.1;transport=udp 0 1 route=route1
71 sip:192.168.1.1:5061;transport=udp 0 1 route=route2
72 sip:192.168.1.1:5062;transport=udp 0 1 route=route3
73 sip:192.168.1.1;transport=udp 0 1 route=route4;socket=udp:192.168.10.10:5063
if packet come from from any port of sip:192.168.1.1;transport=udp except 5061-5062 ds_is_from list will return 70,
if received port also is 5063 the result will be 73, packets from ports 5061-5062 will be matched at 71-72 respectively.
In stock version of ds_is_from_list the result will always be 70.
Note, the DS_MATCH_STRICTEST method can be more compute intensive, because we can potentially traverse all the dispatcher tree.
The behavior of existing flags are not changed.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3699
-- Commit Summary --
* dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching
-- File Changes --
M src/modules/dispatcher/dispatch.c (112)
M src/modules/dispatcher/dispatch.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3699.patchhttps://github.com/kamailio/kamailio/pull/3699.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3699
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3699(a)github.com>
Module: kamailio
Branch: master
Commit: ef29e84929b8ef779341ef63a77e68ca6909705a
URL: https://github.com/kamailio/kamailio/commit/ef29e84929b8ef779341ef63a77e68c…
Author: Elena-Ramona Modroiu <ramona(a)asipto.com>
Committer: Elena-Ramona Modroiu <ramona(a)asipto.com>
Date: 2024-03-11T07:18:17+01:00
http_client: docs for http_client_request() function
---
Modified: src/modules/http_client/doc/http_client_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/ef29e84929b8ef779341ef63a77e68c…
Patch: https://github.com/kamailio/kamailio/commit/ef29e84929b8ef779341ef63a77e68c…
---
diff --git a/src/modules/http_client/doc/http_client_admin.xml b/src/modules/http_client/doc/http_client_admin.xml
index 0e182cc95e3..df9d8c288e5 100644
--- a/src/modules/http_client/doc/http_client_admin.xml
+++ b/src/modules/http_client/doc/http_client_admin.xml
@@ -960,6 +960,30 @@ http_client_get("http://api.com/index.php?r_uri=$(ru{s.escape.param})&f_uri=
switch ($rc) {
...
}
+...
+ </programlisting>
+ </example>
+ </section>
+ <section id="http_client.f.http_client_request">
+ <title>
+ <function moreinfo="none">http_client_request(url, met, body, hdrs, respv)</function>
+ </title>
+ <para>
+ Perform a HTTP request to "url", storing the response body
+ in the "respv" variable. The method of the request is set by "met".
+ The "body" and "hdrs" can be empty strings to skip setting them.
+ The first four parameters can contain variables that are evaluated
+ at runtime. The "respv" has to be the name of a writable variable.
+ </para>
+ <example>
+ <title><function>http_client_request()</function> usage</title>
+ <programlisting format="linespecific">
+...
+http_client_request("GET", "http://api.com/index.php?r_uri=$(ru{s.escape.param})&f_uri=$(fu{s.escap…",
+ "", "X-Token: abc", "$var(result)");
+switch ($rc) {
+ ...
+}
...
</programlisting>
</example>
Kamailio v5.8.0 is out – it comes with 4 new modules and a large set of
improvements touching again more than 50 existing modules.
You can read a bit more detailed release notes at:
* https://www.kamailio.org/w/kamailio-v5-8-0-release-notes/
Many thanks to all developers and community members that made possible
this release.
v5.8.0 brings more flexibility and optimizations across many existing
components and modules, new parameters, functions, variables and
transformations.
Enjoy Kamailio v5.8.0!
Thank you for flying Kamailio!
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com
Module: kamailio
Branch: 5.7
Commit: 3eb545779876265f4587ff8ff627530b70c761dc
URL: https://github.com/kamailio/kamailio/commit/3eb545779876265f4587ff8ff627530…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-03-07T10:17:45+01:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/db_mysql/README
---
Diff: https://github.com/kamailio/kamailio/commit/3eb545779876265f4587ff8ff627530…
Patch: https://github.com/kamailio/kamailio/commit/3eb545779876265f4587ff8ff627530…
---
diff --git a/src/modules/db_mysql/README b/src/modules/db_mysql/README
index 8d9f526cbe1..b1ae13eca1b 100644
--- a/src/modules/db_mysql/README
+++ b/src/modules/db_mysql/README
@@ -32,6 +32,7 @@ Daniel-Constantin Mierla
3.5. insert_delayed (integer)
3.6. update_affected_found (integer)
3.7. opt_ssl_mode (integer)
+ 3.8. opt_ssl_ca (string)
4. Functions
5. Installation
@@ -46,9 +47,10 @@ Daniel-Constantin Mierla
1.5. Set insert_delayed parameter
1.6. Set update_affected_found parameter
1.7. Set opt_ssl_mode parameter
- 1.8. Set a my.cnf group in db_url parameter
- 1.9. Adding a kamailio group to my.cnf
- 1.10. Using [client] and specific group
+ 1.8. Set opt_ssl_ca parameter
+ 1.9. Set a my.cnf group in db_url parameter
+ 1.10. Adding a kamailio group to my.cnf
+ 1.11. Using [client] and specific group
Chapter 1. Admin Guide
@@ -69,6 +71,7 @@ Chapter 1. Admin Guide
3.5. insert_delayed (integer)
3.6. update_affected_found (integer)
3.7. opt_ssl_mode (integer)
+ 3.8. opt_ssl_ca (string)
4. Functions
5. Installation
@@ -105,6 +108,7 @@ Chapter 1. Admin Guide
3.5. insert_delayed (integer)
3.6. update_affected_found (integer)
3.7. opt_ssl_mode (integer)
+ 3.8. opt_ssl_ca (string)
3.1. ping_interval (integer)
@@ -209,6 +213,21 @@ modparam("db_mysql", "update_affected_found", 1)
modparam("db_mysql", "opt_ssl_mode", 1)
...
+3.8. opt_ssl_ca (string)
+
+ Configures the CA certs used to verify the MySQL server cert when SSL
+ is enabled.
+
+ Required when opt_ssl_mode = 4 or 5 and db_mysql is built with
+ libmysqlclient.
+
+ Default value is NULL (NULL - not configured).
+
+ Example 1.8. Set opt_ssl_ca parameter
+...
+modparam("db_mysql", "opt_ssl_ca", "/etc/ssl/certs/mysql-ca.pem")
+...
+
4. Functions
No function exported to be used from configuration file.
@@ -235,12 +254,12 @@ modparam("db_mysql", "opt_ssl_mode", 1)
* mysql://user:pass@[group]/db
* mysql://[group]/db
- Example 1.8. Set a my.cnf group in db_url parameter
+ Example 1.9. Set a my.cnf group in db_url parameter
...
modparam("usrloc", "db_url", "mysql://[kamailio]/kamailio)
...
- Example 1.9. Adding a kamailio group to my.cnf
+ Example 1.10. Adding a kamailio group to my.cnf
...
[kamailio]
socket = /path/to/mysql.sock
@@ -254,7 +273,7 @@ default-character-set = utf8
both your specific group and the client group, then the value is taken
from the last one.
- Example 1.10. Using [client] and specific group
+ Example 1.11. Using [client] and specific group
...
[client]
socket = /run/mysql/mysqld.sock
Module: kamailio
Branch: 5.8
Commit: ed99a5e2648c39e29fbbc7842c86425147c607c6
URL: https://github.com/kamailio/kamailio/commit/ed99a5e2648c39e29fbbc7842c86425…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-03-07T10:17:15+01:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/tls/README
---
Diff: https://github.com/kamailio/kamailio/commit/ed99a5e2648c39e29fbbc7842c86425…
Patch: https://github.com/kamailio/kamailio/commit/ed99a5e2648c39e29fbbc7842c86425…
---
diff --git a/src/modules/tls/README b/src/modules/tls/README
index 78af3bdcc77..d98f94eb8ed 100644
--- a/src/modules/tls/README
+++ b/src/modules/tls/README
@@ -263,8 +263,9 @@ Chapter 1. Admin Guide
profiles of tls.cfg file.
When installing tls module of kamailio, a sample 'tls.cfg' file is
- deployed in the same folder with 'kamailio.cfg', along with freshly
- generated self signed certificates.
+ deployed in the same folder with 'kamailio.cfg'. For freshly generated
+ self signed certificates make must be called from tls folder
+make install-tls-cert
HINT: be sure you have enable_tls=yes to your kamailio.cfg.
@@ -402,9 +403,6 @@ make -C modules/tls extra_defs="-DTLS_WR_DEBUG -DTLS_RD_DEBUG"
standard conforming (the verification should happen during TLS
connection establishment and not after).
- TLS specific config reloading is not safe, so for now better don't use
- it, especially under heavy traffic.
-
This documentation is incomplete. The provided selects are not
documented in this file. A list with all the ones implemented by the
TLS module can be found in the Cookbook
@@ -1683,6 +1681,10 @@ verify_client = optional_no_ca
are not terminated and they continue to use the old certificates. The
new configuration will be used for new connections.
+ Reload is generally safe and usable in production environments. If
+ possible should be done in a time where the service has lower
+ usage/connections.
+
This RPC command is exported with "RPC_EXEC_DELTA" flag, therefore its
execution rate can be restricted to specific time intervals by setting
the "rpc_exec_delta" core parameter.
Module: kamailio
Branch: 5.8
Commit: 22f274513a98cc081d44a6694e35c3e96844dae3
URL: https://github.com/kamailio/kamailio/commit/22f274513a98cc081d44a6694e35c3e…
Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-07T10:07:03+01:00
tls/docs: Update certificate generation docs
(cherry picked from commit 67785fea8f906236e4a30bc09bb11b3292c46572)
---
Modified: src/modules/tls/doc/tls.xml
---
Diff: https://github.com/kamailio/kamailio/commit/22f274513a98cc081d44a6694e35c3e…
Patch: https://github.com/kamailio/kamailio/commit/22f274513a98cc081d44a6694e35c3e…
---
diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml
index 9b3f4eaacb3..5697792655a 100644
--- a/src/modules/tls/doc/tls.xml
+++ b/src/modules/tls/doc/tls.xml
@@ -93,7 +93,10 @@
</para>
<para>
When installing tls module of kamailio, a sample 'tls.cfg' file is deployed in the same
- folder with 'kamailio.cfg', along with freshly generated self signed certificates.
+ folder with 'kamailio.cfg'. For freshly generated self signed certificates make must be called from tls folder
+ <programlisting>
+make install-tls-cert
+ </programlisting>
</para>
<para>
HINT: be sure you have <emphasis>enable_tls=yes</emphasis> to your kamailio.cfg.
Module: kamailio
Branch: 5.8
Commit: 6533c42fc0bba6408376a8f8b41b02b97b04ca1b
URL: https://github.com/kamailio/kamailio/commit/6533c42fc0bba6408376a8f8b41b02b…
Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-07T10:06:56+01:00
tls/docs: Update tls.reload docs
(cherry picked from commit 4c9cfa7a6a770a693ecb3b840ad042fb201db675)
---
Modified: src/modules/tls/doc/rpc.xml
Modified: src/modules/tls/doc/tls.xml
---
Diff: https://github.com/kamailio/kamailio/commit/6533c42fc0bba6408376a8f8b41b02b…
Patch: https://github.com/kamailio/kamailio/commit/6533c42fc0bba6408376a8f8b41b02b…
---
diff --git a/src/modules/tls/doc/rpc.xml b/src/modules/tls/doc/rpc.xml
index 495fc7b31c2..d9e75b014b2 100644
--- a/src/modules/tls/doc/rpc.xml
+++ b/src/modules/tls/doc/rpc.xml
@@ -70,6 +70,10 @@
terminated and they continue to use the old certificates. The new configuration
will be used for new connections.
</para>
+ <para>
+ Reload is generally safe and usable in production environments. If possible should
+ be done in a time where the service has lower usage/connections.
+ </para>
<para>
This RPC command is exported with "RPC_EXEC_DELTA" flag, therefore its
execution rate can be restricted to specific time intervals by setting
diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml
index 9460d73c89f..9b3f4eaacb3 100644
--- a/src/modules/tls/doc/tls.xml
+++ b/src/modules/tls/doc/tls.xml
@@ -284,10 +284,6 @@ make -C modules/tls extra_defs="-DTLS_WR_DEBUG -DTLS_RD_DEBUG"
but also not exactly standard conforming (the verification should happen during TLS
connection establishment and not after).
</para>
- <para>
- TLS specific config reloading is not safe, so for now better don't use it,
- especially under heavy traffic.
- </para>
<para>
This documentation is incomplete.
The provided selects are not documented in this file. A list with all the
@@ -364,4 +360,3 @@ event_route[tls:connection-out] {
</section>
</chapter>
</book>
-
Hello,
discussed a bit during the online Kamailio devel meeting, it is time to
set the milestones towards the next major Kamailio release series v5.8.x.
If no other suggestions that suit more developers, I would propose to
freeze by end of this month or early February, then test for about 4
weeks as usual and release by end of February or during March.
If anyone wants to add new features/modules, they have to be published
till freezing date, either pushed in the git repository or proposed as
pull request.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
Kamailio Advanced Training, February 20-22, 2024 -- asipto.com
Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3717
#### Description
<!-- Describe your changes in detail -->
This PR updates some of the TLS documentation.
tls.reload: See #3717 for details and suggestions from core developers.
certificate generation: According to the History section, certificates are no longer generated automatically. Instead, the command `make install-tls-cert` should be used. This was verified to be working as intended and added suggestion in `Quick Start` section.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3776
-- Commit Summary --
* tls/docs: Update tls.reload docs
* tls/docs: Update certificate generation docs
-- File Changes --
M src/modules/tls/doc/rpc.xml (4)
M src/modules/tls/doc/tls.xml (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3776.patchhttps://github.com/kamailio/kamailio/pull/3776.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3776
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3776(a)github.com>
Module: kamailio
Branch: master
Commit: 67785fea8f906236e4a30bc09bb11b3292c46572
URL: https://github.com/kamailio/kamailio/commit/67785fea8f906236e4a30bc09bb11b3…
Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-06T19:40:26+01:00
tls/docs: Update certificate generation docs
---
Modified: src/modules/tls/doc/tls.xml
---
Diff: https://github.com/kamailio/kamailio/commit/67785fea8f906236e4a30bc09bb11b3…
Patch: https://github.com/kamailio/kamailio/commit/67785fea8f906236e4a30bc09bb11b3…
---
diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml
index 9b3f4eaacb3..5697792655a 100644
--- a/src/modules/tls/doc/tls.xml
+++ b/src/modules/tls/doc/tls.xml
@@ -93,7 +93,10 @@
</para>
<para>
When installing tls module of kamailio, a sample 'tls.cfg' file is deployed in the same
- folder with 'kamailio.cfg', along with freshly generated self signed certificates.
+ folder with 'kamailio.cfg'. For freshly generated self signed certificates make must be called from tls folder
+ <programlisting>
+make install-tls-cert
+ </programlisting>
</para>
<para>
HINT: be sure you have <emphasis>enable_tls=yes</emphasis> to your kamailio.cfg.
Module: kamailio
Branch: master
Commit: 4c9cfa7a6a770a693ecb3b840ad042fb201db675
URL: https://github.com/kamailio/kamailio/commit/4c9cfa7a6a770a693ecb3b840ad042f…
Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-06T19:40:26+01:00
tls/docs: Update tls.reload docs
---
Modified: src/modules/tls/doc/rpc.xml
Modified: src/modules/tls/doc/tls.xml
---
Diff: https://github.com/kamailio/kamailio/commit/4c9cfa7a6a770a693ecb3b840ad042f…
Patch: https://github.com/kamailio/kamailio/commit/4c9cfa7a6a770a693ecb3b840ad042f…
---
diff --git a/src/modules/tls/doc/rpc.xml b/src/modules/tls/doc/rpc.xml
index 495fc7b31c2..d9e75b014b2 100644
--- a/src/modules/tls/doc/rpc.xml
+++ b/src/modules/tls/doc/rpc.xml
@@ -70,6 +70,10 @@
terminated and they continue to use the old certificates. The new configuration
will be used for new connections.
</para>
+ <para>
+ Reload is generally safe and usable in production environments. If possible should
+ be done in a time where the service has lower usage/connections.
+ </para>
<para>
This RPC command is exported with "RPC_EXEC_DELTA" flag, therefore its
execution rate can be restricted to specific time intervals by setting
diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml
index 9460d73c89f..9b3f4eaacb3 100644
--- a/src/modules/tls/doc/tls.xml
+++ b/src/modules/tls/doc/tls.xml
@@ -284,10 +284,6 @@ make -C modules/tls extra_defs="-DTLS_WR_DEBUG -DTLS_RD_DEBUG"
but also not exactly standard conforming (the verification should happen during TLS
connection establishment and not after).
</para>
- <para>
- TLS specific config reloading is not safe, so for now better don't use it,
- especially under heavy traffic.
- </para>
<para>
This documentation is incomplete.
The provided selects are not documented in this file. A list with all the
@@ -364,4 +360,3 @@ event_route[tls:connection-out] {
</section>
</chapter>
</book>
-
Hi
When I add a destination to MySQL server to block and use kamcmd to reload, the call will not be blocked, while if I use kamcmd to add destination with `secfilter.add_dst` it works properly. It's considerable that after reloading if I print the blocked list in kamcmd (with `secfilter.print`) new database row will be printed correctly.
my secfilter SQL table:
+----+--------+------+------+
| id | action | type | data |
+----+--------+------+------+
| 1 | 2 | 4 | 1111 |
+----+--------+------+------+
kamailio 5.4.6 (x86_64/linux)
Ubuntu 22.04.3 LTS
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3694
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3694(a)github.com>
The uac module lacks the uac_reg_unregister(attr, val) method, Send REGISTER with expires 0 for matching record in real time, instead of through RPC command。uac_reg_disable(attr, val) :SIP processing is done on the next timer routine.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3702
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3702(a)github.com>
Hi sr-dev
Just a heads-up that I have included a (slightly larger than normal)
commit to 5.8.
This offers provider support (v3) in parallel to ENGINE(v1.1.1).
- provides basic infrastructure for OpenSSL 3 providers
- it can be guarded with -DOPENSSL_NO_PROVIDER (which turns this commit off
completely.
Thanks for your patience with all the tls.so churn.
Regards
Richard
Module: kamailio
Branch: 5.8
Commit: 3d80bc811c75eb0cbcf0f4aee8929a5082b4de6a
URL: https://github.com/kamailio/kamailio/commit/3d80bc811c75eb0cbcf0f4aee8929a5…
Author: S-P Chan <shihping.chan(a)gmail.com>
Committer: S-P Chan <shihping.chan(a)gmail.com>
Date: 2024-03-03T14:38:56+08:00
tls: basic OpenSSL 3 support of provider keys (replaces ENGINE)
- initial support for v3 provider keys (replaces ENGINE from v1.1.1)
- can be disabled behind build flag -DOPENSSL_NO_PROVIDER
- provider keys start with /uri: e.g
private_key = /uri:pkcs11:token=NSS%20Certificate%20DB;type=private;object=Fork-Test-c67cc0e0
- global config:
provider_quirks: 0 | 1
- 0 - default
- 1 - create a new OSS_LIB_CTX* in the child
This integration does not load any providers itself and depends on
the usual
export OPENSSL_CONF=my-openssl.cnf
to configure providers.
(cherry picked from commit 69883dd381368ca219cc52140e71d571775f95d5)
---
Modified: src/modules/tls/tls_domain.c
Modified: src/modules/tls/tls_mod.c
---
Diff: https://github.com/kamailio/kamailio/commit/3d80bc811c75eb0cbcf0f4aee8929a5…
Patch: https://github.com/kamailio/kamailio/commit/3d80bc811c75eb0cbcf0f4aee8929a5…
Module: kamailio
Branch: master
Commit: 69883dd381368ca219cc52140e71d571775f95d5
URL: https://github.com/kamailio/kamailio/commit/69883dd381368ca219cc52140e71d57…
Author: S-P Chan <shihping.chan(a)gmail.com>
Committer: S-P Chan <shihping.chan(a)gmail.com>
Date: 2024-03-03T14:34:47+08:00
tls: basic OpenSSL 3 support of provider keys (replaces ENGINE)
- initial support for v3 provider keys (replaces ENGINE from 1.1.1)
- can be disabled behind build flag -DOPENSSL_NO_PROVIDER
- provider keys start with /uri: e.g
private_key = /uri:pkcs11:token=NSS%20Certificate%20DB;type=private;object=Fork-Test-c67cc0e0
- global config:
provider_quirks: 0 | 1
- 0 - default
- 1 - create a new OSS_LIB_CTX* in the child
This integration does not load any providers itself and depends on
the usual
export OPENSSL_CONF=my-openssl.cnf
to configure providers.
---
Modified: src/modules/tls/tls_domain.c
Modified: src/modules/tls/tls_mod.c
---
Diff: https://github.com/kamailio/kamailio/commit/69883dd381368ca219cc52140e71d57…
Patch: https://github.com/kamailio/kamailio/commit/69883dd381368ca219cc52140e71d57…
Module: kamailio
Branch: 5.8
Commit: 8e81774d5a71c06906df84fb4809bcfb73bd532e
URL: https://github.com/kamailio/kamailio/commit/8e81774d5a71c06906df84fb4809bcf…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-02T08:18:15+01:00
tlsa: removed the map files used in the past for tls engine
- sync with code of tls module
(cherry picked from commit d443a1e37d85e0eec6f6c9875bb8e821b34c8d6b)
---
Removed: src/modules/tlsa/tls_map.c
Removed: src/modules/tlsa/tls_map.h
---
Diff: https://github.com/kamailio/kamailio/commit/8e81774d5a71c06906df84fb4809bcf…
Patch: https://github.com/kamailio/kamailio/commit/8e81774d5a71c06906df84fb4809bcf…
---
diff --git a/src/modules/tlsa/tls_map.c b/src/modules/tlsa/tls_map.c
deleted file mode 100644
index ad799b5cdff..00000000000
--- a/src/modules/tlsa/tls_map.c
+++ /dev/null
@@ -1,27 +0,0 @@
-/**
- * Copyright (C) 2021 Daniel-Constantin Mierla (asipto.com)
- *
- * This file is part of Kamailio, a free SIP server.
- *
- * This file is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version
- *
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- *
- */
-
-/**
- * THIS FILE IS GENERATED - DO NOT MODIFY IT
- */
-
-#include "../tls/tls_map.c"
diff --git a/src/modules/tlsa/tls_map.h b/src/modules/tlsa/tls_map.h
deleted file mode 100644
index 96705a7f7fa..00000000000
--- a/src/modules/tlsa/tls_map.h
+++ /dev/null
@@ -1,27 +0,0 @@
-/**
- * Copyright (C) 2021 Daniel-Constantin Mierla (asipto.com)
- *
- * This file is part of Kamailio, a free SIP server.
- *
- * This file is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version
- *
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- *
- */
-
-/**
- * THIS FILE IS GENERATED - DO NOT MODIFY IT
- */
-
-#include "../tls/tls_map.h"
Module: kamailio
Branch: master
Commit: d443a1e37d85e0eec6f6c9875bb8e821b34c8d6b
URL: https://github.com/kamailio/kamailio/commit/d443a1e37d85e0eec6f6c9875bb8e82…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-02T08:13:40+01:00
tlsa: removed the map files used in the past for tls engine
- sync with code of tls module
---
Removed: src/modules/tlsa/tls_map.c
Removed: src/modules/tlsa/tls_map.h
---
Diff: https://github.com/kamailio/kamailio/commit/d443a1e37d85e0eec6f6c9875bb8e82…
Patch: https://github.com/kamailio/kamailio/commit/d443a1e37d85e0eec6f6c9875bb8e82…
---
diff --git a/src/modules/tlsa/tls_map.c b/src/modules/tlsa/tls_map.c
deleted file mode 100644
index ad799b5cdff..00000000000
--- a/src/modules/tlsa/tls_map.c
+++ /dev/null
@@ -1,27 +0,0 @@
-/**
- * Copyright (C) 2021 Daniel-Constantin Mierla (asipto.com)
- *
- * This file is part of Kamailio, a free SIP server.
- *
- * This file is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version
- *
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- *
- */
-
-/**
- * THIS FILE IS GENERATED - DO NOT MODIFY IT
- */
-
-#include "../tls/tls_map.c"
diff --git a/src/modules/tlsa/tls_map.h b/src/modules/tlsa/tls_map.h
deleted file mode 100644
index 96705a7f7fa..00000000000
--- a/src/modules/tlsa/tls_map.h
+++ /dev/null
@@ -1,27 +0,0 @@
-/**
- * Copyright (C) 2021 Daniel-Constantin Mierla (asipto.com)
- *
- * This file is part of Kamailio, a free SIP server.
- *
- * This file is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version
- *
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- *
- */
-
-/**
- * THIS FILE IS GENERATED - DO NOT MODIFY IT
- */
-
-#include "../tls/tls_map.h"
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3771
-- Commit Summary --
* ims_usrloc: make matching of username in contact conditional
* ims_registrar_pcscf: update registered state to pending registration if contact exists
-- File Changes --
M src/modules/ims_registrar_pcscf/save.c (11)
M src/modules/ims_usrloc_pcscf/udomain.c (58)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3771.patchhttps://github.com/kamailio/kamailio/pull/3771.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3771
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3771(a)github.com>
There seems to be an incompatibility in the pua_json module related to the libjson-c-dev" version.
The module crashes on startup on version 0.15.2 (e.g. from Debian bullseye).
It works with version 0.12 (e.g. Debian buster).
Backtrace below:
```
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x00007f6d265e5537 in __GI_abort () at abort.c:79
#2 0x00007f6d265e540f in __assert_fail_base (fmt=0x7f6d2675d6a8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7f6d2322c091 "jso->_ref_count > 0",
file=0x7f6d2322c064 "./json_object.c", line=308, function=<optimized out>) at assert.c:92
#3 0x00007f6d265f4662 in __GI___assert_fail (assertion=0x7f6d2322c091 "jso->_ref_count > 0", file=0x7f6d2322c064 "./json_object.c", line=308, function=0x7f6d2322c480 "json_object_put")
at assert.c:101
#4 0x00007f6d23224732 in json_object_put () from /lib/x86_64-linux-gnu/libjson-c.so.5
#5 0x00007f6d25842362 in pua_json_publish (msg=0x7fffb3fffb20,
json=0x7f6d25ff5778 "{\"Call-ID\":\"111\",\"Event-Category\":\"presence\",\"Event-Name\":\"update\",\"Event-Package\":\"message-summary\",\"Expires\":\"3600\",\"To\":\"sip:103@XXX.YYY.55.208\",\"To-User\":\"103\",\"To-Realm\":\"XXX.YYY.55.208\",\"From\":\""...) at pua_json_publish.c:383
#6 0x00007f6d2583e74a in w_pua_json_publish (msg=0x7fffb3fffb20, p1pjson=0x7f6d25ff5988 "xW\377%m\177", p2=0x0) at pua_json_mod.c:100
#7 0x0000563199d1c47e in do_action ()
#8 0x0000563199d29ae6 in run_actions ()
#9 0x00007f6d2324444e in ?? () from /usr/lib/x86_64-linux-gnu/kamailio/modules/xhttp.so
#10 0x00007f6d23246005 in ?? () from /usr/lib/x86_64-linux-gnu/kamailio/modules/xhttp.so
#11 0x0000563199e6cb10 in nonsip_msg_run_hooks ()
#12 0x0000563199ede538 in receive_msg ()
#13 0x0000563199cac4f2 in receive_tcp_msg ()
#14 0x0000563199caeb51 in tcp_read_req ()
#15 0x0000563199cb2028 in ?? ()
#16 0x0000563199c9da4f in ?? ()
#17 0x0000563199cb4f8c in tcp_receive_loop ()
#18 0x0000563199e2330b in tcp_init_children ()
#19 0x0000563199c8967f in main_loop ()
#20 0x0000563199c9446e in main ()
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3376
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3376(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR free allocated memory and add heder guards.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3770
-- Commit Summary --
* file_out: Add header guards
* file_out: Fix leaks
-- File Changes --
M src/modules/file_out/file_out.c (8)
M src/modules/file_out/types.c (14)
M src/modules/file_out/types.h (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3770.patchhttps://github.com/kamailio/kamailio/pull/3770.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3770
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3770(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
(paste your output here)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3769
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3769(a)github.com>
Module: kamailio
Branch: master
Commit: 993583015b127b0a83603acd352925c8d6e6db70
URL: https://github.com/kamailio/kamailio/commit/993583015b127b0a83603acd352925c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-02-26T13:09:27+01:00
microhttpd: docs - note about variables available in the event route
---
Modified: src/modules/microhttpd/doc/microhttpd_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/993583015b127b0a83603acd352925c…
Patch: https://github.com/kamailio/kamailio/commit/993583015b127b0a83603acd352925c…
---
diff --git a/src/modules/microhttpd/doc/microhttpd_admin.xml b/src/modules/microhttpd/doc/microhttpd_admin.xml
index 1967c845b82..c548d0dfc42 100644
--- a/src/modules/microhttpd/doc/microhttpd_admin.xml
+++ b/src/modules/microhttpd/doc/microhttpd_admin.xml
@@ -157,6 +157,11 @@ event_route[microhttpd:request] {
<para>
The event route is executed when a new HTTP request is received.
</para>
+ <para>
+ Inside it, the $mhttpd(...) group of variables is available, giving
+ access to several attributes of the HTTP request, such as method,
+ URL, data (body) or headers.
+ </para>
<programlisting format="linespecific">
...
...
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
While trying latest kamailio 5.7 branch, when tls_threads_mode is set to 1, it fails to load self signed certificates. Setting tls_threads_mode to 0 works as expected. Certificates are self signed for a local test env, generated with openssl 3.x.
### Troubleshooting
The issue is very similar to https://github.com/kamailio/kamailio/issues/3737 but in my case the openssl config seems correct, and happens only enabling the tls_threads_mode
#### Reproduction
Certs have been generated with `openssl req -new -newkey rsa:4096 -x509 -sha256 -days 3650 -nodes -out server.pem -keyout server.key`
[server.pem.txt](https://github.com/kamailio/kamailio/files/14384611/server.…
[server.key.txt](https://github.com/kamailio/kamailio/files/14384612/server.…
(these are self signed cert for testing, nothing that cannot be shared)
My tls.cfg is very simple:
```
[server:default]
method = TLSv1.2+
verify_certificate = no
require_certificate = no
private_key = /etc/kamailio/server.key
certificate = /etc/kamailio/server.pem
[client:default]
method = TLSv1.2+
verify_certificate = no
require_certificate = no
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
1(35) NOTICE: tls [tls_domain.c:1168]: ksr_tls_fix_domain(): registered server_name callback handler for socket [:0], server_name='<default>' ...
1(35) ERROR: tls [tls_domain.c:590]: load_cert(): TLSs<default>: Unable to load certificate file '/etc/kamailio/server.pem'
1(35) ERROR: tls [tls_util.h:49]: tls_err_ret(): load_cert:error:03000072:digital envelope routines::decode error (sni: unknown)
1(35) ERROR: tls [tls_util.h:49]: tls_err_ret(): load_cert:error:0A00018F:SSL routines::ee key too small (sni: unknown)
1(35) ERROR: <core> [core/sr_module.c:913]: init_mod_child(): error while initializing module tls (/usr/lib/x86_64-linux-gnu/kamailio/modules/tls.so)
```
### Possible Solutions
Don't use tls_threads_mode for now.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.7.4 (x86_64/linux) a0dfb8
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: a0dfb8
compiled with gcc 11.4.0
```
Actually this is built from 5.7 branch, on commit a0dfb8cbdf4282040351e9dc014d9ef13e0e77fd
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
Containerized Ubunu jammy, updated as of today.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3764
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3764(a)github.com>
### Description
after some nearest changes, there are problems with the TLS handshake (for at least ECDHE-RSA-AES256-GCM-SHA384)
because of the missed `OPENSSL_init_ssl()` call for TCP workers
#### Reproduction
try to send any SIP message over TLS to the server which accepts ECDHE-RSA-AES256-GCM-SHA384 in Server Hello during handshake
the simplest way to reproduce is to add microsoft teams server to the dispatcher and enable probing to send OPTIONS
kamailio.cfg:
```
loadmodule "tls.so"
modparam("tls", "config", "/etc/kamailio/tls.cfg")
loadmodule "dispatcher.so"
modparam("dispatcher","flags",2)
modparam("dispatcher", "list_file", "/etc/kamailio/dispatcher.list")
modparam("dispatcher", "ds_ping_method","OPTIONS")
modparam("dispatcher", "ds_ping_interval",5)
modparam("dispatcher", "ds_probing_mode",1)
```
tls.cfg:
```
[server:default]
certificate = /etc/kamailio/ssl/ssl-cert-snakeoil.pem
private_key = /etc/kamailio/ssl/ssl-cert-snakeoil.key
[client:default]
certificate = /etc/kamailio/ssl/ssl-cert-snakeoil.pem
private_key = /etc/kamailio/ssl/ssl-cert-snakeoil.key
```
dispatcher.list:
```
1 sip:sip.pstnhub.microsoft.com;transport=tls 0 0
```
#### Debugging Data
backtrace for the cipher suite lookup:
```
(gdb) bt
#0 ssl_cipher_id_cmp_BSEARCH_CMP_FN (a_=0x7ffd2a0aade0, b_=0x7fa110ceeec0 <ssl3_ciphers+11680>) at ../ssl/ssl_lib.c:4985
#1 0x00007fa110832a95 in ossl_bsearch (key=key@entry=0x7ffd2a0aade0, base=base@entry=0x7fa110cec120 <ssl3_ciphers>, num=num@entry=167, size=size@entry=80, cmp=cmp@entry=0x7fa110c7cac0 <ssl_cipher_id_cmp_BSEARCH_CMP_FN>, flags=flags@entry=0)
at ../crypto/bsearch.c:28
#2 0x00007fa1108fc229 in OBJ_bsearch_ex_ (key=key@entry=0x7ffd2a0aade0, base=base@entry=0x7fa110cec120 <ssl3_ciphers>, num=num@entry=167, size=size@entry=80, cmp=cmp@entry=0x7fa110c7cac0 <ssl_cipher_id_cmp_BSEARCH_CMP_FN>, flags=flags@entry=0)
at ../crypto/objects/obj_dat.c:699
#3 0x00007fa1108fc23c in OBJ_bsearch_ (key=key@entry=0x7ffd2a0aade0, base=base@entry=0x7fa110cec120 <ssl3_ciphers>, num=num@entry=167, size=size@entry=80, cmp=cmp@entry=0x7fa110c7cac0 <ssl_cipher_id_cmp_BSEARCH_CMP_FN>)
at ../crypto/objects/obj_dat.c:691
#4 0x00007fa110c7fb95 in OBJ_bsearch_ssl_cipher_id (key=key@entry=0x7ffd2a0aade0, base=base@entry=0x7fa110cec120 <ssl3_ciphers>, num=num@entry=167) at ../ssl/ssl_lib.c:4985
#5 0x00007fa110c6ed4c in ssl3_get_cipher_by_id (id=<optimized out>) at ../ssl/s3_lib.c:4075
#6 0x00007fa110c76077 in ssl_get_cipher_by_char (ssl=ssl@entry=0x7fa10cfca900, ptr=ptr@entry=0x7fa10cfcc767 "\3000", all=all@entry=0) at ../ssl/ssl_ciph.c:2102
#7 0x00007fa110cae0ee in set_client_ciphersuite (s=s@entry=0x7fa10cfca900, cipherchars=cipherchars@entry=0x7fa10cfcc767 "\3000") at ../ssl/statem/statem_clnt.c:1310
#8 0x00007fa110cb03b3 in tls_process_server_hello (s=0x7fa10cfca900, pkt=<optimized out>) at ../ssl/statem/statem_clnt.c:1614
#9 0x00007fa110cace72 in read_state_machine (s=0x7fa10cfca900) at ../ssl/statem/statem.c:647
#10 state_machine (s=0x7fa10cfca900, server=0) at ../ssl/statem/statem.c:442
#11 0x00007fa110d33aaa in tls_connect (c=c@entry=0x7fa10cfc64e0, error=error@entry=0x7ffd2a0ab0e4) at ./src/modules/tls/tls_server.c:542
#12 0x00007fa110d01edd in ssl_flush (size=413, buf=0x7fa10cfdafdc, error=<synthetic pointer>, tcp_c=0x7fa10cfc64e0) at ./src/modules/tls/tls_ct_wrq.c:101
#13 sbufq_flush (flush_f=<optimized out>, flush_p2=<synthetic pointer>, flush_p1=0x7fa10cfc64e0, flags=0x7ffd2a0ab1ac, q=0x7fa10cfb43a0) at ./src/modules/tls/sbufq.h:247
#14 tls_ct_q_flush (flush_p2=<synthetic pointer>, flush_p1=0x7fa10cfc64e0, flush_f=<optimized out>, flags=0x7ffd2a0ab1ac, tc_q=0x18) at ./src/modules/tls/tls_ct_q.h:122
#15 tls_ct_wq_flush (c=c@entry=0x7fa10cfc64e0, ct_q=ct_q@entry=0x7fa10cfb34c0, flags=flags@entry=0x7ffd2a0ab1ac, ssl_err=ssl_err@entry=0x7ffd2a0ab1a8) at ./src/modules/tls/tls_ct_wrq.c:147
#16 0x00007fa110d386f4 in tls_h_read_f (c=0x7fa10cfc64e0, flags=0x7ffd2a0cb5d0) at ./src/modules/tls/tls_server.c:1140
#17 0x0000562ad6b0c46e in tcp_read_headers (c=c@entry=0x7fa10cfc64e0, read_flags=read_flags@entry=0x7ffd2a0cb5d0) at core/tcp_read.c:445
#18 0x0000562ad6b0f543 in tcp_read_req (con=0x7fa10cfc64e0, bytes_read=bytes_read@entry=0x7ffd2a0cb5cc, read_flags=read_flags@entry=0x7ffd2a0cb5d0) at core/tcp_read.c:1508
#19 0x0000562ad6b14879 in handle_io (fm=fm@entry=0x7fa110ed31c8, events=events@entry=1, idx=idx@entry=-1) at core/tcp_read.c:1832
#20 0x0000562ad6b1a7fd in io_wait_loop_epoll (repeat=repeat@entry=0, t=2, h=0x562ad6de8c20 <io_w>) at core/io_wait.h:1073
#21 0x0000562ad6b1b017 in tcp_receive_loop (unix_sock=<optimized out>) at core/tcp_read.c:2032
#22 0x0000562ad6b02df5 in tcp_init_children (woneinit=woneinit@entry=0x7ffd2a0cbb0c) at core/tcp_main.c:5364
#23 0x0000562ad6928b60 in main_loop () at ./src/main.c:1936
#24 0x0000562ad691a463 in main (argc=<optimized out>, argv=<optimized out>) at ./src/main.c:3212
```
part of the `ssl3_ciphers` array that should be sorted by id ascending:
```
}, {
valid = 1,
name = 0x7fa110cc3720 "ECDHE-RSA-AES256-GCM-SHA384",
stdname = 0x7fa110cc89f8 "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
id = 50380848,
...
}, {
valid = 1,
name = 0x7fa110cc3770 "PSK-NULL-SHA",
stdname = 0x7fa110cc373c "TLS_PSK_WITH_NULL_SHA",
id = 50331692,
...
```
* `ossl_bsearch` assumes that it works with sorted `ssl3_ciphers`
* `ssl3_ciphers` sorting performed by `OPENSSL_init_ssl(uint64_t opts, const OPENSSL_INIT_SETTINGS * settings)` -> `ossl_init_ssl_base()` -> `ssl_sort_cipher_list()` -> `qsort(ssl3_ciphers...`
#### Log Messages
```
ERROR: tls [tls_util.h:49]: tls_err_ret(): TLS write:error:0A0000F8:SSL routines::unknown cipher returned (sni: unknown)
```
### Possible Solutions
* ensure `OPENSSL_init_ssl()` to be called (directly or using OPENSSL_INIT_ATFORK) for TCP workers
* fixed by `OPENSSL_init_ssl(0, NULL);` call in `tls_init.c:int tls_h_mod_init_f(void)` but it's hardly the fully correct solution
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
# kamailio -v
version: kamailio 5.7.4 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 13.2.0
```
```
# apt list kamailio --installed
Listing... Done
kamailio/testing,now 5.7.4-1 amd64 [installed]
```
* **Operating System**:
Debian GNU/Linux trixie/sid (reproduced on Debian bookworm either)
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3765
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3765(a)github.com>
Hello,
the branch 5.8 was created, therefore the master branch is open for
adding new features, to be part of future release series v5.9.x (or
whatever version is decided for next series).
Any bug fix committed to master that applies to 5.8.x or older stable
branches should be backported as usual with "git cherry-pick -x ..." to
appropriate branches like 5.8 or 5.7.
Expect that v5.8.0 will be released in a few weeks from now.
Based on the workflow used during the past years, the next future
release v5.9.0 should be out after another 8-10 months of development,
plus 1-2 months of testing, so sometime during the last part of 2024 or
the beginning of 2025.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com
Hello,
the branch 5.8 has been created, to be used for releasing v5.8.x series.
To check out this branch, the following commands can be used:
git clone https://github.com/kamailio/kamailio kamailio-5.8
cd kamailio-5.8
git checkout -b 5.8 origin/5.8
Pushing commits in this branch:
git push origin 5.8:5.8
Note that 5.8 is an official stable branch, so only bug fixes, missing
kemi exports (discuss on sr-dev if not sure) or improvements to
documentation or helper tools can be pushed to this branch.
As usual, if there is a bug fixed, commit and push first to master
branch and then cherry pick to 5.8 branch:
git cherry-pick -x COMMITID
In few weeks, the first release from branch 5.8 will be out,
respectively Kamailio v5.8.0.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com
Module: kamailio
Branch: master
Commit: 48f4da344bd96e9a19b7c99c37d9dfe29de78933
URL: https://github.com/kamailio/kamailio/commit/48f4da344bd96e9a19b7c99c37d9dfe…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-02-23T19:28:52+01:00
Makefile.defs: version set to 5.9.0-dev0
- master branch is open for new features to be part of the future major
series, to be versioned 5.9.x or maybe 6.0.x
---
Modified: src/Makefile.defs
---
Diff: https://github.com/kamailio/kamailio/commit/48f4da344bd96e9a19b7c99c37d9dfe…
Patch: https://github.com/kamailio/kamailio/commit/48f4da344bd96e9a19b7c99c37d9dfe…
---
diff --git a/src/Makefile.defs b/src/Makefile.defs
index b195c7fe59d..4165ca084fb 100644
--- a/src/Makefile.defs
+++ b/src/Makefile.defs
@@ -105,9 +105,9 @@ INSTALL_FLAVOUR=$(FLAVOUR)
# version number
VERSION = 5
-PATCHLEVEL = 8
+PATCHLEVEL = 9
SUBLEVEL = 0
-EXTRAVERSION = -pre1
+EXTRAVERSION = -dev0
# memory manager switcher
# 0 - f_malloc (fast malloc)
Module: kamailio
Branch: master
Commit: 17536b1064b40c305f28c4c19392504afc0b9701
URL: https://github.com/kamailio/kamailio/commit/17536b1064b40c305f28c4c19392504…
Author: Dennis Yurasov <dennis-y(a)yandex-team.ru>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-02-23T12:36:20+01:00
dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching
- Two new flgs added:
DS_MATCH_SOCKET (8) to take in account socket/sockname attribute of gw
DS_MATCH_TRY_FULLADDRSOCK (16) try to find the most complete "address/protocol/port/local socket" combination for all dispatcher targets
---
Modified: src/modules/dispatcher/dispatch.c
Modified: src/modules/dispatcher/dispatch.h
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/17536b1064b40c305f28c4c19392504…
Patch: https://github.com/kamailio/kamailio/commit/17536b1064b40c305f28c4c19392504…
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR adds the support of using PVs in the `prefix` parameter.
Also refactors the properties into a structure for each file.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3763
-- Commit Summary --
* file_out: Prefix can use PVs
* file_out: Refactor
-- File Changes --
M src/modules/file_out/file_out.c (140)
M src/modules/file_out/types.c (38)
M src/modules/file_out/types.h (17)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3763.patchhttps://github.com/kamailio/kamailio/pull/3763.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3763
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3763(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3761
-- Commit Summary --
* microhttpd: fixed typo in the documentation
-- File Changes --
M src/modules/microhttpd/doc/microhttpd_admin.xml (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3761.patchhttps://github.com/kamailio/kamailio/pull/3761.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3761
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3761(a)github.com>