- sr-dev - kamailio.org

[kamailio/kamailio] wip: pua_reginfo: add helper to disable publishing for current message (PR #4253)
by Matteo 06 Jun '25

06 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4252 #### Description This PR adds a new helper `reginfo_disable_publish` to `pua_reginfo` module which disabled the publishing for the current message, which is useful to control when to actually send it or not (eg in DMQ replication scenarios). The helper is "negative" (it *disables* not enables) on purpose in order to mantain backward compatibility to current behaviour. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4253 -- Commit Summary -- * pua_reginfo: add helper to disable publishing for current message -- File Changes -- M src/modules/pua_reginfo/pua_reginfo.c (4) M src/modules/pua_reginfo/pua_reginfo.h (4) M src/modules/pua_reginfo/usrloc_cb.c (21) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4253.patch https://github.com/kamailio/kamailio/pull/4253.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4253 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4253(a)github.com>

3 8

git:master:708dd175: pua_reginfo: add helper to disable publishing for current message
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 708dd1753483240c82c5796e11686db40544d145 URL: https://github.com/kamailio/kamailio/commit/708dd1753483240c82c5796e11686db… Author: Matteo Brancaleoni <matteo.brancaleoni(a)voismart.it> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T15:14:48+02:00 pua_reginfo: add helper to disable publishing for current message --- Modified: src/modules/pua_reginfo/doc/pua_reginfo_admin.xml Modified: src/modules/pua_reginfo/pua_reginfo.c Modified: src/modules/pua_reginfo/pua_reginfo.h Modified: src/modules/pua_reginfo/usrloc_cb.c --- Diff: https://github.com/kamailio/kamailio/commit/708dd1753483240c82c5796e11686db… Patch: https://github.com/kamailio/kamailio/commit/708dd1753483240c82c5796e11686db… --- diff --git a/src/modules/pua_reginfo/doc/pua_reginfo_admin.xml b/src/modules/pua_reginfo/doc/pua_reginfo_admin.xml index 9e2da526c8e..8229377adb4 100644 --- a/src/modules/pua_reginfo/doc/pua_reginfo_admin.xml +++ b/src/modules/pua_reginfo/doc/pua_reginfo_admin.xml @@ -234,6 +234,33 @@ reply_route[1] { if (t_check_status("200")) reginfo_subscribe("$ru"); } +... + </programlisting> + </example> + </section> + <section id="pua_reginfo.f.reginfo_disable_publish"> + <title> + <function moreinfo="none">reginfo_disable_publish()</function> + </title> + <para> + This function disables sending the PUBLISH request in the registrar + callback invocation, for the current message only. + </para> + + <example> + <title><function>reginfo_disable_publish</function> usage</title> + <programlisting format="linespecific"> +... +if(is_method("REGISTER")) { + if (dmq_is_from_node()) + # coming from a DMQ node, just save without triggering PUBLISH + # which may be replicated differently, like with presence DMQ support + reginfo_disable_publish(); + save("location"); + } else { + # coming from end point - authenticate, save contact, etc... + } +} ... </programlisting> </example> diff --git a/src/modules/pua_reginfo/pua_reginfo.c b/src/modules/pua_reginfo/pua_reginfo.c index 6a0b91170ea..573b6efc15d 100644 --- a/src/modules/pua_reginfo/pua_reginfo.c +++ b/src/modules/pua_reginfo/pua_reginfo.c @@ -46,6 +46,8 @@ str server_address = {NULL, 0}; int publish_reginfo = 1; +int reginfo_disable_publish = 0; /* Disables publish for current message */ + sruid_t _reginfo_sruid; int reginfo_use_domain = 0; @@ -65,6 +67,8 @@ static cmd_export_t cmds[] = { fixup_subscribe, 0, REQUEST_ROUTE | ONREPLY_ROUTE}, {"reginfo_handle_notify", (cmd_function)reginfo_handle_notify, 1, domain_fixup, 0, REQUEST_ROUTE}, + {"reginfo_disable_publish", (cmd_function)w_reginfo_disable_publish, 0, + 0, 0, REQUEST_ROUTE}, {0, 0, 0, 0, 0, 0} }; diff --git a/src/modules/pua_reginfo/pua_reginfo.h b/src/modules/pua_reginfo/pua_reginfo.h index 6ffaa6ba516..70fd42a1cb5 100644 --- a/src/modules/pua_reginfo/pua_reginfo.h +++ b/src/modules/pua_reginfo/pua_reginfo.h @@ -37,5 +37,9 @@ extern usrloc_api_t ul; /*!< Structure containing pointers to usrloc functions*/ extern pua_api_t pua; /*!< Structure containing pointers to PUA functions*/ extern int reginfo_use_domain; +extern int reginfo_disable_publish; + +int w_reginfo_disable_publish(sip_msg_t *, char *, char *); +int ki_reginfo_disable_publish(sip_msg_t *); #endif diff --git a/src/modules/pua_reginfo/usrloc_cb.c b/src/modules/pua_reginfo/usrloc_cb.c index 5cc1377b9de..8bc5a7884bd 100644 --- a/src/modules/pua_reginfo/usrloc_cb.c +++ b/src/modules/pua_reginfo/usrloc_cb.c @@ -53,6 +53,18 @@ Call-ID: 9ad9f89f-164d-bb86-1072-52e7e9eb5025. static int _pua_reginfo_self_op = 0; +#define BUF_LEN 256 +int ki_reginfo_disable_publish(sip_msg_t *msg) +{ + reginfo_disable_publish = 1; + return 1; +} + +int w_reginfo_disable_publish(struct sip_msg *msg, char *s1, char *s2) +{ + return ki_reginfo_disable_publish(msg); +} + void pua_reginfo_update_self_op(int v) { _pua_reginfo_self_op = v; @@ -266,6 +278,15 @@ void reginfo_usrloc_cb(ucontact_t *c, int type, void *param) return; } + if(reginfo_disable_publish == 1) { + LM_DBG("Not publishing due to reginfo_disable_publish for aor: %.*s " + "(%d)\n", + c->aor->len, c->aor->s, type); + + reginfo_disable_publish = 0; + return; + } + content_type.s = "application/reginfo+xml"; content_type.len = 23;

1 0

[kamailio/kamailio] tls: add WSS to RPC funtions (PR #4262)
by Benjamin 06 Jun '25

06 Jun '25

- tls_list() add PROTO_WSS to TLS_LIST RPC call to include WSS connections in tls.list - tls_kill() add PROTO_WSS to handle WSS connections Co-authored-by: Andreas Tarp <tarp(a)sipgate.de> #### Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #4167 #### Description WSS connection is not shown in tls.list RPC command like all other TLS connections. Also tls_kill does not handle WSS connections. This is related to the issue 4167. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4262 -- Commit Summary -- * tls: add WSS to RPC funtions -- File Changes -- M src/modules/tls/tls_rpc.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4262.patch https://github.com/kamailio/kamailio/pull/4262.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4262 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4262(a)github.com>

2 2

git:master:9581e5b3: tls: add WSS to RPC funtions
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 9581e5b332bff8e61ed65c6ddd340a472cb1d93c URL: https://github.com/kamailio/kamailio/commit/9581e5b332bff8e61ed65c6ddd340a4… Author: Benjamin Tietz <tietz(a)sipgate.de> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T15:10:58+02:00 tls: add WSS to RPC funtions - tls_list() add PROTO_WSS to TLS_LIST RPC call to include WSS connections in tls.list - tls_kill() add PROTO_WSS to handle WSS connections Co-authored-by: Andreas Tarp <tarp(a)sipgate.de> --- Modified: src/modules/tls/tls_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/9581e5b332bff8e61ed65c6ddd340a4… Patch: https://github.com/kamailio/kamailio/commit/9581e5b332bff8e61ed65c6ddd340a4… --- diff --git a/src/modules/tls/tls_rpc.c b/src/modules/tls/tls_rpc.c index b707a3063f1..ef621407781 100644 --- a/src/modules/tls/tls_rpc.c +++ b/src/modules/tls/tls_rpc.c @@ -118,7 +118,7 @@ static void tls_list(rpc_t *rpc, void *c) TCPCONN_LOCK; for(i = 0; i < TCP_ID_HASH_SIZE; i++) { for(con = tcpconn_id_hash[i]; con; con = con->id_next) { - if(con->rcv.proto != PROTO_TLS) + if(con->rcv.proto != PROTO_TLS && con->rcv.proto != PROTO_WSS) continue; tls_d = con->extra_data; rpc->add(c, "{", &handle); @@ -276,7 +276,7 @@ static void tls_kill(rpc_t *rpc, void *c) TCPCONN_LOCK; for(i = 0; i < TCP_ID_HASH_SIZE; i++) { for(con = tcpconn_id_hash[i]; con; con = con->id_next) { - if(con->rcv.proto != PROTO_TLS) + if(con->rcv.proto != PROTO_TLS && con->rcv.proto != PROTO_WSS) continue; if(con->id == kill_id) { con->state = -2;

1 0

git:master:d7156079: dispatcher: docs for ds_ping_fr_timer modparam
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: d71560794239668a9488ef2aca8330307779a6c8 URL: https://github.com/kamailio/kamailio/commit/d71560794239668a9488ef2aca83303… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T15:00:45+02:00 dispatcher: docs for ds_ping_fr_timer modparam --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d71560794239668a9488ef2aca83303… Patch: https://github.com/kamailio/kamailio/commit/d71560794239668a9488ef2aca83303… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index 37194e4973e..3a6c26b41b7 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -577,6 +577,28 @@ modparam("dispatcher", "ds_ping_interval", 30) </example> </section> + + <section id="dispatcher.p.ds_ping_fr_timer"> + <title><varname>ds_ping_fr_timer</varname> (int)</title> + <para> + If greater than 0, its value is used to set the "fr_timer" value for + the local transactions created to send out the OPTIONS pings. + </para> + <para> + <emphasis> + Default value is <quote>0</quote> (not set). + </emphasis> + </para> + <example> + <title>Set the <quote>ds_ping_fr_timer</quote> parameter</title> +<programlisting format="linespecific"> +... +modparam("dispatcher", "ds_ping_fr_timer", 10) +... +</programlisting> + </example> + </section> + <section id="dispatcher.p.ds_probing_threshold"> <title><varname>ds_probing_threshold</varname> (int)</title> <para>

1 0

git:master:df0e36fb: dispatcher: new modparam ds_ping_fr_timeout
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: df0e36fbb0dc1139acd6c5d92dc3f986cca73af2 URL: https://github.com/kamailio/kamailio/commit/df0e36fbb0dc1139acd6c5d92dc3f98… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T14:55:02+02:00 dispatcher: new modparam ds_ping_fr_timeout - ability to set the transaction fr_timeout value for the OPTIONS pings requests --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/df0e36fbb0dc1139acd6c5d92dc3f98… Patch: https://github.com/kamailio/kamailio/commit/df0e36fbb0dc1139acd6c5d92dc3f98… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index a90daa2abfa..cf0a75a09dd 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -118,6 +118,7 @@ static int *_ds_ping_active = NULL; extern int ds_force_dst; extern str ds_event_callback; extern int ds_ping_latency_stats; +extern int ds_ping_fr_timeout; extern int ds_retain_latency_stats; extern float ds_latency_estimator_alpha; extern int ds_attrs_none; @@ -4175,6 +4176,9 @@ void ds_ping_set(ds_set_t *node) && ds_default_socket.len > 0) { uac_r.ssock = &ds_default_socket; } + if(ds_ping_fr_timeout > 0) { + uac_r.fr_timeout = (unsigned int)ds_ping_fr_timeout; + } /* Overwrite default ping From URI with attribute */ if(node->dlist[j].attrs.ping_from.s != NULL diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 1d6acaaede5..84c65a6019e 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -103,6 +103,7 @@ str ds_ping_method = str_init("OPTIONS"); str ds_ping_from = str_init("sip:dispatcher@localhost"); static int ds_ping_interval = 0; int ds_ping_latency_stats = 0; +int ds_ping_fr_timeout = 0; int ds_retain_latency_stats = 0; int ds_latency_estimator_alpha_i = 900; float ds_latency_estimator_alpha = 0.9f; @@ -301,6 +302,7 @@ static param_export_t params[]={ {"ds_ping_method", PARAM_STR, &ds_ping_method}, {"ds_ping_from", PARAM_STR, &ds_ping_from}, {"ds_ping_interval", PARAM_INT, &ds_ping_interval}, + {"ds_ping_fr_timeout", PARAM_INT, &ds_ping_fr_timeout}, {"ds_ping_latency_stats", PARAM_INT, &ds_ping_latency_stats}, {"ds_retain_latency_stats", PARAM_INT, &ds_retain_latency_stats}, {"ds_latency_estimator_alpha", PARAM_INT, &ds_latency_estimator_alpha_i},

1 0

git:master:98bcd014: uac: fields for $uac_req() to set fr_timeout, fr_inv_timeout
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 98bcd01471744eaaa142c388782a5c91c99a78f7 URL: https://github.com/kamailio/kamailio/commit/98bcd01471744eaaa142c388782a5c9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T14:28:12+02:00 uac: fields for $uac_req() to set fr_timeout, fr_inv_timeout --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/98bcd01471744eaaa142c388782a5c9… Patch: https://github.com/kamailio/kamailio/commit/98bcd01471744eaaa142c388782a5c9… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index f8a77b6a6b4..ea3595ca755 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -82,6 +82,8 @@ typedef struct _uac_send_info char b_evparam[MAX_UACD_SIZE]; str s_evparam; unsigned int cseqno; + unsigned int fr_timeout; + unsigned int fr_inv_timeout; unsigned int evroute; unsigned int evcode; unsigned int evtype; @@ -187,6 +189,10 @@ int pv_get_uac_req(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) return pv_get_uintval(msg, param, res, _uac_req.flags); case 18: return pv_get_uintval(msg, param, res, _uac_req.cseqno); + case 19: + return pv_get_uintval(msg, param, res, _uac_req.fr_timeout); + case 20: + return pv_get_uintval(msg, param, res, _uac_req.fr_inv_timeout); default: return pv_get_uintval(msg, param, res, _uac_req.flags); } @@ -484,6 +490,28 @@ int pv_set_uac_req( } _uac_req.cseqno = tval->ri; break; + case 19: + if(tval == NULL) { + _uac_req.fr_timeout = 0; + return 0; + } + if(!(tval->flags & PV_VAL_INT)) { + LM_ERR("Invalid value type\n"); + return -1; + } + _uac_req.fr_timeout = tval->ri; + break; + case 20: + if(tval == NULL) { + _uac_req.fr_inv_timeout = 0; + return 0; + } + if(!(tval->flags & PV_VAL_INT)) { + LM_ERR("Invalid value type\n"); + return -1; + } + _uac_req.fr_inv_timeout = tval->ri; + break; } return 0; } @@ -550,6 +578,16 @@ int pv_parse_uac_req_name(pv_spec_p sp, str *in) else goto error; break; + case 10: + if(strncmp(in->s, "fr_timeout", 10) == 0) + sp->pvp.pvn.u.isname.name.n = 19; + else + goto error; + case 14: + if(strncmp(in->s, "fr_inv_timeout", 14) == 0) + sp->pvp.pvn.u.isname.name.n = 20; + else + goto error; default: goto error; } @@ -803,6 +841,8 @@ void uac_send_tm_callback(struct cell *t, int type, struct tmcb_params *ps) uac_r.ssock = (tp->s_sock.len <= 0) ? NULL : &tp->s_sock; uac_r.dialog = &tmdlg; uac_r.cb_flags = TMCB_LOCAL_COMPLETED | TMCB_DESTROY; + uac_r.fr_timeout = tp->fr_timeout; + uac_r.fr_inv_timeout = tp->fr_inv_timeout; if(tp->evroute != 0) { /* Callback function */ uac_r.cb = uac_resend_tm_callback; @@ -861,6 +901,9 @@ int uac_req_send(void) uac_r.ssock = &uac_default_socket; } + uac_r.fr_timeout = _uac_req.fr_timeout; + uac_r.fr_inv_timeout = _uac_req.fr_inv_timeout; + if((_uac_req.s_auser.len > 0 && _uac_req.s_apasswd.len > 0) || (_uac_req.evroute > 0)) { tp = uac_send_info_clone(&_uac_req);

1 0

git:master:d0bfcac2: uac: added fr_timeout and fr_inv_timeout to uac_req_t struct
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: d0bfcac231ae67d683ff1c7ace2cebfdca33e0b4 URL: https://github.com/kamailio/kamailio/commit/d0bfcac231ae67d683ff1c7ace2cebf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T14:28:12+02:00 uac: added fr_timeout and fr_inv_timeout to uac_req_t struct - can be used to set the timeouts for the locally generated requests via the intermodule API functions --- Modified: src/modules/tm/uac.c Modified: src/modules/tm/uac.h --- Diff: https://github.com/kamailio/kamailio/commit/d0bfcac231ae67d683ff1c7ace2cebf… Patch: https://github.com/kamailio/kamailio/commit/d0bfcac231ae67d683ff1c7ace2cebf… --- diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index 26748f4570c..2dfb218724f 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -517,8 +517,12 @@ static inline int t_uac_prepare( * we can't call init_new_t() because we don't have a sip msg * => we'll ignore t_set_fr() or avp timer value and will use directly the * module params fr_inv_timer and fr_timer -- andrei */ - new_cell->fr_timeout = cfg_get(tm, tm_cfg, fr_timeout); - new_cell->fr_inv_timeout = cfg_get(tm, tm_cfg, fr_inv_timeout); + new_cell->fr_timeout = (uac_r->fr_timeout > 0) + ? uac_r->fr_timeout + : cfg_get(tm, tm_cfg, fr_timeout); + new_cell->fr_inv_timeout = (uac_r->fr_inv_timeout > 0) + ? uac_r->fr_inv_timeout + : cfg_get(tm, tm_cfg, fr_inv_timeout); new_cell->end_of_life = get_ticks_raw() + lifetime; /* same as above for retransmission intervals */ new_cell->rt_t1_timeout_ms = cfg_get(tm, tm_cfg, rt_t1_timeout_ms); diff --git a/src/modules/tm/uac.h b/src/modules/tm/uac.h index 00dc32d2a5b..f35cf9f70ac 100644 --- a/src/modules/tm/uac.h +++ b/src/modules/tm/uac.h @@ -55,6 +55,8 @@ typedef struct uac_req void *cbp; str *callid; unsigned int cseqno; + unsigned int fr_timeout; + unsigned int fr_inv_timeout; } uac_req_t; /* macro for setting the values of uac_req_t struct */

1 0

git:master:7de2b9b7: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 7de2b9b7625d9cb856944627a3a5d7c167006dc6 URL: https://github.com/kamailio/kamailio/commit/7de2b9b7625d9cb856944627a3a5d7c… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-06T12:46:10+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/7de2b9b7625d9cb856944627a3a5d7c… Patch: https://github.com/kamailio/kamailio/commit/7de2b9b7625d9cb856944627a3a5d7c…

1 0

[kamailio/kamailio] rtpengine hash table dmq replication (PR #4240)
by vlitvinov 06 Jun '25

06 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adding KDMQ replication for rtpengine hash table (call -> rtpengine instance assignment) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4240 -- Commit Summary -- * rtpegnine hash table dmq replication -- File Changes -- M src/modules/rtpengine/rtpengine.c (49) M src/modules/rtpengine/rtpengine.h (4) M src/modules/rtpengine/rtpengine_db.c (2) A src/modules/rtpengine/rtpengine_dmq.c (310) A src/modules/rtpengine/rtpengine_dmq.h (54) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4240.patch https://github.com/kamailio/kamailio/pull/4240.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4240 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4240(a)github.com>

4 10

git:master:98cbb5cd: rtpengine: hash table dmq replication
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 98cbb5cdf169578c75f60f4f12c2e9e4dadeed3e URL: https://github.com/kamailio/kamailio/commit/98cbb5cdf169578c75f60f4f12c2e9e… Author: vlitvinov <litvvitya92(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T12:43:33+02:00 rtpengine: hash table dmq replication --- Added: src/modules/rtpengine/rtpengine_dmq.c Added: src/modules/rtpengine/rtpengine_dmq.h Modified: src/modules/rtpengine/doc/rtpengine_admin.xml Modified: src/modules/rtpengine/rtpengine.c Modified: src/modules/rtpengine/rtpengine.h Modified: src/modules/rtpengine/rtpengine_db.c --- Diff: https://github.com/kamailio/kamailio/commit/98cbb5cdf169578c75f60f4f12c2e9e… Patch: https://github.com/kamailio/kamailio/commit/98cbb5cdf169578c75f60f4f12c2e9e…

1 0

git:master:2492b92e: dialog: use defined tockens for is_set field of local cseq structure for keepalives
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 2492b92e49cfcd5f6828007b6a289b3f881dba69 URL: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T10:15:02+02:00 dialog: use defined tockens for is_set field of local cseq structure for keepalives --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… Patch: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 52e492d2074..48494bef428 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -790,10 +790,11 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) * - dialog is ended on timeout (408) or C/L does not exist (481) */ if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; + di->loc_seq.is_set = DLG_SEQ_VALSET; } else { di->loc_seq.value = 0; + di->loc_seq.is_set = DLG_SEQ_VALNEW; } - di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:73c8316b: tm: add defines for dlg cseq is_self field
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 73c8316bf89703156f241886554919339ac270d0 URL: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T10:08:12+02:00 tm: add defines for dlg cseq is_self field - DLG_SEQ_VALINIT (should be initialized), DLG_SEQ_VALSET (is set, but can be updated for requests within dialog), DLG_SEQ_VALNEW (is set, and ready to be used as new cseq number in generated request) --- Modified: src/modules/tm/dlg.c Modified: src/modules/tm/dlg.h Modified: src/modules/tm/rpc_uac.c Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… Patch: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… --- diff --git a/src/modules/tm/dlg.c b/src/modules/tm/dlg.c index b99065a94c2..6c97db622af 100644 --- a/src/modules/tm/dlg.c +++ b/src/modules/tm/dlg.c @@ -357,7 +357,7 @@ int new_dlg_uac(str *_cid, str *_ltag, unsigned int _lseq, str *_luri, /* Make a copy of local sequence (usually CSeq) */ res->loc_seq.value = _lseq; /* And mark it as set */ - res->loc_seq.is_set = 1; + res->loc_seq.is_set = DLG_SEQ_VALSET; *_d = res; @@ -979,7 +979,7 @@ static inline int request2dlg(struct sip_msg *_m, dlg_t *_d) if(get_cseq_value(_m, &_d->rem_seq.value) < 0) goto err3; - _d->rem_seq.is_set = 1; + _d->rem_seq.is_set = DLG_SEQ_VALSET; if(get_dlg_uri(_m->from, &_d->rem_uri) < 0) goto err3; @@ -1149,7 +1149,7 @@ int dlg_request_uas( /* Neither out of order nor retransmission -> update */ _d->rem_seq.value = cseq; - _d->rem_seq.is_set = 1; + _d->rem_seq.is_set = DLG_SEQ_VALSET; /* We will als update remote target URI if the message * is target refresher diff --git a/src/modules/tm/dlg.h b/src/modules/tm/dlg.h index 732ba970bc0..ff37bc4bd9a 100644 --- a/src/modules/tm/dlg.h +++ b/src/modules/tm/dlg.h @@ -52,6 +52,10 @@ #endif /* DIALOG_CALLBACKS */ +#define DLG_SEQ_VALINIT 0 +#define DLG_SEQ_VALSET 1 +#define DLG_SEQ_VALNEW 2 + /* * Dialog sequence */ diff --git a/src/modules/tm/rpc_uac.c b/src/modules/tm/rpc_uac.c index 285f3c7e9eb..3cd99a4d9c6 100644 --- a/src/modules/tm/rpc_uac.c +++ b/src/modules/tm/rpc_uac.c @@ -757,7 +757,7 @@ static void rpc_t_uac(rpc_t *rpc, void *c, int reply_wait, int cbflags) dlg.loc_seq.value = cseq; else dlg.loc_seq.value = DEFAULT_CSEQ; - dlg.loc_seq.is_set = 1; + dlg.loc_seq.is_set = DLG_SEQ_VALSET; dlg.loc_uri = get_from(&faked_msg)->uri; dlg.rem_uri = get_to(&faked_msg)->uri; @@ -1077,7 +1077,7 @@ int t_uac_send(str *method, str *ruri, str *nexthop, str *send_socket, dlg.loc_seq.value = cseq; else dlg.loc_seq.value = DEFAULT_CSEQ; - dlg.loc_seq.is_set = 1; + dlg.loc_seq.is_set = DLG_SEQ_VALSET; dlg.loc_uri = get_from(&faked_msg)->uri; dlg.rem_uri = get_to(&faked_msg)->uri; diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index a9a327745ec..26748f4570c 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -451,11 +451,11 @@ static inline int t_uac_prepare( /* if err's returned, the message is incorrect */ goto error3; - if(!uac_r->dialog->loc_seq.is_set) { + if(uac_r->dialog->loc_seq.is_set == DLG_SEQ_VALINIT) { /* this is the first request in the dialog, set cseq to default value now - Miklos */ uac_r->dialog->loc_seq.value = DEFAULT_CSEQ; - uac_r->dialog->loc_seq.is_set = 1; + uac_r->dialog->loc_seq.is_set = DLG_SEQ_VALSET; } /* build cell sets X/AVP lists to new transaction structure @@ -677,7 +677,9 @@ int prepare_req_within(uac_req_t *uac_r, struct retr_buf **dst_req) goto send; if((uac_r->method->len == 6) && (!memcmp("CANCEL", uac_r->method->s, 6))) goto send; - uac_r->dialog->loc_seq.value++; /* Increment CSeq */ + if(uac_r->dialog->loc_seq.is_set != DLG_SEQ_VALNEW) { + uac_r->dialog->loc_seq.value++; /* Increment CSeq */ + } send: ret = t_uac_prepare(uac_r, dst_req, 0);

1 0

[kamailio/kamailio] Frequent hangs in Kamailio probably related due to lock contention in xhttp_prom module with high concurrency (Issue #4209)
by Henning Westerholt 06 Jun '25

06 Jun '25

henningw created an issue (kamailio/kamailio#4209) Frequent hangs in Kamailio probably related due to lock contention in xhttp_prom module. ### Environment: The systems are using 32 Kamailio worker processes for the relevant network interface, Its also using Prometheus counter increment operations more than 30 times in the cfg during INVITE processing. The Kamailio uses otherwise no database or other IO related services. Kamailio version 5.8.3, but no relevant changes in the xhttp_prom module could be found. ### Quick summary of the findings: Multiple systems showed frequent hangs in their Kamailio servers on a customer setup. It happens usually after a few hours that all Kamailio processes gets blocked, and no more traffic can be processed on the respective system. I have analysed three stack traces of the Kamailio on one of the system that showed the behaviour. Two without problems and one that was created from during a period where the server had problems. ### Details: Here some details of the stack traces from a problematic case. The relevant processes are from PID 494551 to 494582. The majority of all of these processes are blocked in paths related to the Prometheus module (PID 494551 to 494576): #### PID 494551: ``` #1 0x00007fc69ea5f053 in futex_get (lock=0x7fc4a147acd0) at ../../core/mem/../futexlock.h:108 v = 2 i = 1024 #2 0x00007fc69ea70f99 in prom_counter_inc (s_name=0x7fffe339ffa0, number=1, l1=0x7fffe339ff90, l2=0x0, l3=0x0) at prom_metric.c:1154 p = 0x6b __func__ = "prom_counter_inc" […] #14 0x00000000005ab179 in receive_msg (buf=0x9f47e0 <buf> "INVITE [sip:+1YYYYYYY737@10.XXX.XXX107](sip:+1YYYYYYYYYY737@10.XXX.XX.107) SIP/2.0\r\nRecord-Route: [sip:10.1XXX.XXX.104;lr=on;ftag=HK507HSy55p9F;dlgcor=62b91.985c3](sip:10.XXX.XXX.104;lr=on;ftag=HK507HSy55p9F;dlgcor=62b91.985c3)\r\nRecord-Route: [sip:10.XXX.XXX.117;r2=on;lr;ftag=HK507HSy55p9F](sip:10.XXX.XXX.117;r2=on;lr;ftag=HK507HSy55p9F)\r\nRecord-R"..., len=2819, rcv_info=0x7fffe33a28d0) at core/receive.c:518 ``` Most of the worker processes are in the same state as shown above. Some of the processes are also working in other Prometheus related operations: #### PID 494554: ``` #0 prom_metric_timeout_delete (p_m=0x7fc49ea102f0) at prom_metric.c:646 current = 0x7fc4a2810fd0 ts = 1744143945433 __func__ = "prom_metric_timeout_delete" l = 0x7fc4abffc808 #1 0x00007fc69ea676ce in prom_metric_list_timeout_delete () at prom_metric.c:668 p = 0x7fc49ea102f0 ``` ### Problem hypothesis: My hypothesis is that the hang is caused from lock contention around the Prometheus module. The relevant code uses only one lock, and this together with the extensive usage of the increment counters probably causes this issues under high load. The majority of the worker processed are occupied in the Prometheus path and are not working on SIP packets. This will cause of course an increase of the UDP queue and the described problems. In order to test this hypothesis we removed temporarily the Prometheus logic in the kamailio cfg and see if the issue still persists. The issue did not showed up again after two days of testing, when before it was observed after a few hours. ### Possible solutions: The Prometheus module probably needs some improvements to support better high-load and concurrency situations. On common approach is to split the locks, e.g. using a per process lock array and then combining the individual values in a second pass when read from outside. Alternatively the xhttp_prom module should be used only carefully in situations with a high concurrency setup. I have the full backtrace available, if helpful just let me know. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4209 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4209(a)github.com>

2 2

Kamailio Deployment in AWS
by gcampos＠momenta.network 05 Jun '25

05 Jun '25

Hi community, I'm not sure if anyone has ever tried that before, but I'm trying to run Kamailio in AWS with RTPengine. I successfully installed both Kamailio and RTPengine on my EC2 instance and I'm able to make my devices register to it. However, when I make a call from one of my devices, the call is muted. As I analyze my kamailio.cfg file, I see that the "route[NATMANAGE]" is likely the cause of the mute call. I think that none of the conditions below are met, therefore, the flags are not set. Because of that, the last condition is met, thus triggering the "return" and exiting from the route[NATMANAGE] prematurely without even reaching the section where I define the RTPengine modifications. Not only that, but if I remove/comment out the "return", then the RTPengine is triggered, but there call doesn't connect. I wonder why this is happening and if there's any known workaround. # RTP relaying management and signaling updates for NAT traversal route[NATMANAGE] { xlog("L_INFO", "NATMANAGE path was followed\n"); #!ifdef WITH_NAT xlog("L_INFO", "WITH_NAT Triggered\n"); if (is_request()) { xlog("L_INFO", "is_request path was followed\n"); if (has_totag()) { xlog("L_INFO", "has_totag path was followed\n"); if (check_route_param("nat=yes")) { xlog("L_INFO", "nat=yes param detected, setting FLB_NATB\n"); setbflag(FLB_NATB); } } if (nat_uac_test("3")) { xlog("L_INFO", "nat_uac_test(3) matched, setting FLT_NATS + FLB_NATB\n"); setflag(FLT_NATS); setbflag(FLB_NATB); } } if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) { xlog("L_INFO", "No NAT flags set, skipping NAT handling\n"); return; } #!ifdef WITH_RTPENGINE xlog("L_INFO", "WITH_RTPENGINE Path followed\n"); if (has_body("application/sdp")) { if (is_method("INVITE")) { xlog("L_INFO", "IS_METHOD_INVITE Path Followed\n"); rtpengine_manage("replace-origin replace-session-connection trust-address direction=internal"); } else if (is_reply()) { xlog("L_INFO", "IS_Reply Path Followed\n"); rtpengine_manage("replace-origin replace-session-connection trust-address direction=internal"); } } #!else if(nat_uac_test("8")) { rtpproxy_manage("co"); } else { rtpproxy_manage("cor"); } #!endif if (is_request()) { if (!has_totag()) { if(t_is_branch_route()) { add_rr_param(";nat=yes"); } } } if (is_reply()) { if(isbflagset(FLB_NATB)) { if(is_first_hop()) set_contact_alias(); } } if(isbflagset(FLB_NATB)) { # no connect message in a dialog involving NAT traversal if (is_request()) { if(has_totag()) { set_forward_no_connect(); } } } #!endif return; }

3 2

git:5.8:6c71d5e7: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 5.8 Commit: 6c71d5e7364e169373a38d899793c78ae4f93835 URL: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T14:46:57+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 (cherry picked from commit 444fef809c21b250402cfdbd48de65926ac6286a) (cherry picked from commit 21c944e4a8c04d6f1a4c66897021e01a5ea6f22b) --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… Patch: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index a22e64cb1e6..02f72d77521 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

git:6.0:a37a57c2: dialog: bump cseq for generated byes also for caller side
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: a37a57c2b4db73b4963d3af5e733ea8fe5c5833d URL: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T13:10:49+02:00 dialog: bump cseq for generated byes also for caller side - do it always, they are the last requests within dialog (cherry picked from commit 43e64af9bade5fedf34e847f662b97ce94c041bc) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… Patch: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 6349e88c1f8..773ae788e3b 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -425,10 +425,9 @@ static inline int send_bye( goto err; } - /* safety bump of cseq if prack was involved in call setup */ - if(cell->iflags & DLG_IFLAG_PRACK) { - dialog_info->loc_seq.value += 80; - } + /* safety bump of cseq for callee side if prack was involved in call setup + * or keepalives were sent to caller side */ + dialog_info->loc_seq.value += 100; LM_DBG("sending BYE to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:43e64af9: dialog: bump cseq for generated byes also for caller side
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: master Commit: 43e64af9bade5fedf34e847f662b97ce94c041bc URL: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T13:07:59+02:00 dialog: bump cseq for generated byes also for caller side - do it always, they are the last requests within dialog --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… Patch: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 6467b32b349..52e492d2074 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -425,10 +425,9 @@ static inline int send_bye( goto err; } - /* safety bump of cseq if prack was involved in call setup */ - if(cell->iflags & DLG_IFLAG_PRACK) { - dialog_info->loc_seq.value += 80; - } + /* safety bump of cseq for callee side if prack was involved in call setup + * or keepalives were sent to caller side */ + dialog_info->loc_seq.value += 100; LM_DBG("sending BYE to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:6.0:b293f206: dialog: set cseq is_set for keepalive
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: b293f20620c3396130f6409ddf30b69499bb482f URL: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:33:15+02:00 dialog: set cseq is_set for keepalive (cherry picked from commit b5d4c20172bdcaf0e63b15b4e23d205125398a42) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… Patch: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 7645ebeca37..6349e88c1f8 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -784,10 +784,12 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) /* tm increases cseq value, decrease it no to make it invalid * - dialog is ended on timeout (408) or C/L does not exist (481) */ - if(di->loc_seq.value > 1) + if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; - else + } else { di->loc_seq.value = 0; + } + di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:6.0:21c944e4: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: 21c944e4a8c04d6f1a4c66897021e01a5ea6f22b URL: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:33:03+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 (cherry picked from commit 444fef809c21b250402cfdbd48de65926ac6286a) --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… Patch: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 5e9b3f121ab..2e7d996bc54 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

git:master:b5d4c201: dialog: set cseq is_set for keepalive
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: master Commit: b5d4c20172bdcaf0e63b15b4e23d205125398a42 URL: https://github.com/kamailio/kamailio/commit/b5d4c20172bdcaf0e63b15b4e23d205… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:32:36+02:00 dialog: set cseq is_set for keepalive --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/b5d4c20172bdcaf0e63b15b4e23d205… Patch: https://github.com/kamailio/kamailio/commit/b5d4c20172bdcaf0e63b15b4e23d205… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 9ffd65e9526..6467b32b349 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -789,10 +789,12 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) /* tm increases cseq value, decrease it no to make it invalid * - dialog is ended on timeout (408) or C/L does not exist (481) */ - if(di->loc_seq.value > 1) + if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; - else + } else { di->loc_seq.value = 0; + } + di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:730d6872: core: print default path to runtime dir on internals output
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: master Commit: 730d6872054cb6218684d5e48af341c7c2749233 URL: https://github.com/kamailio/kamailio/commit/730d6872054cb6218684d5e48af341c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:32:36+02:00 core: print default path to runtime dir on internals output --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/730d6872054cb6218684d5e48af341c… Patch: https://github.com/kamailio/kamailio/commit/730d6872054cb6218684d5e48af341c… --- diff --git a/src/main.c b/src/main.c index 95588200ba9..b0ec7fcb0d9 100644 --- a/src/main.c +++ b/src/main.c @@ -288,6 +288,7 @@ void print_internals(void) printf(" Version: %s\n", full_version); printf(" Default config: %s\n", CFG_FILE); printf(" Default paths to modules: %s\n", MODS_DIR); + printf(" Default path to runtime dir: %s\n", RUN_DIR); printf(" Compile flags: %s\n", ver_flags); printf(" MAX_RECV_BUFFER_SIZE=%d\n", MAX_RECV_BUFFER_SIZE); printf(" MAX_SEND_BUFFER_SIZE=%d\n", MAX_SEND_BUFFER_SIZE);

1 0

[kamailio/kamailio] Replace ip address of source (Issue #4272)
by nochnoi82 04 Jun '25

04 Jun '25

nochnoi82 created an issue (kamailio/kamailio#4272) Hello to everyone. I deployed Kamailio on Debian system. Install was successfull. I have the task to use Kamailio as proxy between Avaya PBX and Videoconference System. Outgoing calls only from IPPhone ----- Avaya PBX ---sip----> Kamailio -----sip----> Video System-IVR IVR number is 3000. Avaya Prefix for routing to Kamailio is 1234. When we dial number 12343000 the call goes to Video system with Header "TO" 12343000@ip_of_PBXAvaya and call drops. How to replace ip-address of Avaya to ip-address of Video_System? What to add in kamailio.cfg? ip video_system - *.*.60.3 ip avaya *.*.20.10 My route config ####### Routing Logic ######## /* Main SIP request routing logic * - processing of any incoming SIP request starts with this route * - note: this is the same as route { ... } */ request_route { # per request initial checks route(REQINIT); # NAT detection route(NATDETECT); # CANCEL processing if (is_method("CANCEL")) { if (t_check_trans()) { route(RELAY); } exit; } # handle retransmissions if (!is_method("ACK")) { if(t_precheck_trans()) { t_check_trans(); exit; } t_check_trans(); } # handle requests within SIP dialogs route(WITHINDLG); ### only initial requests (no To tag) # authentication route(AUTH); # record routing for dialog forming requests (in case they are routed) # - remove preloaded route headers remove_hf("Route"); if (is_method("INVITE|SUBSCRIBE")) { record_route(); } # account only INVITEs if (is_method("INVITE")) { setflag(FLT_ACC); # do accounting } if ($rU==$null) { sl_send_reply("484", "Address Incomplete"); exit; } $du = "sip:*.*.60.3:5060"; route(RELAY); exit; } # Wrapper for relaying requests route[RELAY] { # enable additional event routes for forwarded requests # - serial forking, RTP relaying handling, a.s.o. if (is_method("INVITE|BYE|SUBSCRIBE|UPDATE")) { if(!t_is_set("branch_route")) t_on_branch("MANAGE_BRANCH"); } if (is_method("INVITE|SUBSCRIBE|UPDATE")) { if(!t_is_set("onreply_route")) t_on_reply("MANAGE_REPLY"); } if (is_method("INVITE")) { if(!t_is_set("failure_route")) t_on_failure("MANAGE_FAILURE"); } if (!t_relay()) { sl_reply_error(); } exit; } # Per SIP request initial checks route[REQINIT] { # no connect for sending replies set_reply_no_connect(); # enforce symmetric signaling # - send back replies to the source address of request force_rport(); #!ifdef WITH_ANTIFLOOD # flood detection from same IP and traffic ban for a while # be sure you exclude checking trusted peers, such as pstn gateways # - local host excluded (e.g., loop to self) if(src_ip!=myself) { if($sht(ipban=>$si)!=$null) { # ip is already blocked xdbg("request from blocked IP - $rm from $fu (IP:$si:$sp)\n"); exit; } if (!pike_check_req()) { xlog("L_ALERT","ALERT: pike blocking $rm from $fu (IP:$si:$sp)\n"); $sht(ipban=>$si) = 1; exit; } } #!endif if($ua =~ "friendly|scanner|sipcli|sipvicious|VaxSIPUserAgent|pplsip") { # silent drop for scanners - uncomment next line if want to reply # sl_send_reply("200", "OK"); exit; } if (!mf_process_maxfwd_header("10")) { sl_send_reply("483","Too Many Hops"); exit; } if(is_method("OPTIONS") && uri==myself && $rU==$null) { sl_send_reply("200","Keepalive"); exit; } if(!sanity_check("17895", "7")) { xlog("Malformed SIP request from $si:$sp\n"); exit; } } # Handle requests within SIP dialogs route[WITHINDLG] { if (!has_totag()) return; # sequential request withing a dialog should # take the path determined by record-routing if (loose_route()) { route(DLGURI); if (is_method("BYE")) { setflag(FLT_ACC); # do accounting ... setflag(FLT_ACCFAILED); # ... even if the transaction fails } else if ( is_method("ACK") ) { # ACK is forwarded statelessly route(NATMANAGE); } else if ( is_method("NOTIFY") ) { # Add Record-Route for in-dialog NOTIFY as per RFC 6665. record_route(); } route(RELAY); exit; } if (is_method("SUBSCRIBE") && uri == myself) { # in-dialog subscribe requests route(PRESENCE); exit; } if ( is_method("ACK") ) { if ( t_check_trans() ) { # no loose-route, but stateful ACK; # must be an ACK after a 487 # or e.g. 404 from upstream server route(RELAY); exit; } else { # ACK without matching transaction ... ignore and discard exit; } } sl_send_reply("404","Not here"); exit; } # Handle SIP registrations route[REGISTRAR] { if (!is_method("REGISTER")) return; if(isflagset(FLT_NATS)) { setbflag(FLB_NATB); #!ifdef WITH_NATSIPPING # do SIP NAT pinging setbflag(FLB_NATSIPPING); #!endif } if (!save("location")) { sl_reply_error(); } exit; } # User location service route[LOCATION] { #!ifdef WITH_SPEEDDIAL # search for short dialing - 2-digit extension if($rU=~"^[0-9][0-9]$") { if(sd_lookup("speed_dial")) { route(SIPOUT); } } #!endif #!ifdef WITH_ALIASDB # search in DB-based aliases if(alias_db_lookup("dbaliases")) { route(SIPOUT); } #!endif $avp(oexten) = $rU; if (!lookup("location")) { $var(rc) = $rc; route(TOVOICEMAIL); t_newtran(); switch ($var(rc)) { case -1: case -3: send_reply("404", "Not Found"); exit; case -2: send_reply("405", "Method Not Allowed"); exit; } } # when routing via usrloc, log the missed calls also if (is_method("INVITE")) { setflag(FLT_ACCMISSED); } route(RELAY); exit; } # Presence server processing route[PRESENCE] { if(!is_method("PUBLISH|SUBSCRIBE")) return; if(is_method("SUBSCRIBE") && $hdr(Event)=="message-summary") { route(TOVOICEMAIL); # returns here if no voicemail server is configured sl_send_reply("404", "No voicemail service"); exit; } #!ifdef WITH_PRESENCE #!ifdef WITH_MSGREBUILD # apply changes in case the request headers or body were modified msg_apply_changes(); #!endif if (!t_newtran()) { sl_reply_error(); exit; } if(is_method("PUBLISH")) { handle_publish(); t_release(); } else if(is_method("SUBSCRIBE")) { handle_subscribe(); t_release(); } exit; #!endif # if presence enabled, this part will not be executed if (is_method("PUBLISH") || $rU==$null) { sl_send_reply("404", "Not here"); exit; } return; } # IP authorization and user authentication route[AUTH] { #!ifdef WITH_AUTH #!ifdef WITH_IPAUTH if((!is_method("REGISTER")) && allow_source_address()) { # source IP allowed return; } #!endif if (is_method("REGISTER") || from_uri==myself) { # authenticate requests if (!auth_check("$fd", "subscriber", "1")) { auth_challenge("$fd", "0"); exit; } # user authenticated - remove auth header if(!is_method("REGISTER|PUBLISH")) consume_credentials(); } # if caller is not local subscriber, then check if it calls # a local destination, otherwise deny, not an open relay here if (from_uri!=myself && uri!=myself) { sl_send_reply("403","Not relaying"); exit; } #!else # authentication not enabled - do not relay at all to foreign networks if(uri!=myself) { sl_send_reply("403","Not relaying"); exit; } #!endif return; } # Caller NAT detection route[NATDETECT] { #!ifdef WITH_NAT if (nat_uac_test("19")) { if (is_method("REGISTER")) { fix_nated_register(); } else { if(is_first_hop()) { set_contact_alias(); } } setflag(FLT_NATS); } #!endif return; } # RTPProxy control and signaling updates for NAT traversal route[NATMANAGE] { #!ifdef WITH_NAT if (is_request()) { if(has_totag()) { if(check_route_param("nat=yes")) { setbflag(FLB_NATB); } } } if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) return; #!ifdef WITH_RTPENGINE if(nat_uac_test("8")) { rtpengine_manage("SIP-source-address replace-origin replace-session-connection"); } else { rtpengine_manage("replace-origin replace-session-connection"); } #!else if(nat_uac_test("8")) { rtpproxy_manage("co"); } else { rtpproxy_manage("cor"); } #!endif if (is_request()) { if (!has_totag()) { if(t_is_branch_route()) { add_rr_param(";nat=yes"); } } } if (is_reply()) { if(isbflagset(FLB_NATB)) { if(is_first_hop()) set_contact_alias(); } } if(isbflagset(FLB_NATB)) { # no connect message in a dialog involving NAT traversal if (is_request()) { if(has_totag()) { set_forward_no_connect(); } } } #!endif return; } # URI update for dialog requests route[DLGURI] { #!ifdef WITH_NAT if(!isdsturiset()) { handle_ruri_alias(); } #!endif return; } # Routing to foreign domains route[SIPOUT] { if (uri==myself) return; append_hf("P-Hint: outbound\r\n"); route(RELAY); exit; } # PSTN GW routing route[PSTN] { #!ifdef WITH_PSTN # check if PSTN GW IP is defined if (strempty($sel(cfg_get.pstn.gw_ip))) { xlog("SCRIPT: PSTN routing enabled but pstn.gw_ip not defined\n"); return; } # route to PSTN dialed numbers starting with '+' or '00' # (international format) # - update the condition to match your dialing rules for PSTN routing if(!($rU=~"^(\+|00)[1-9][0-9]{3,20}$")) return; # only local users allowed to call if(from_uri!=myself) { sl_send_reply("403", "Not Allowed"); exit; } # normalize target number for pstn gateway # - convert leading 00 to + if (starts_with("$rU", "00")) { strip(2); prefix("+"); } if (strempty($sel(cfg_get.pstn.gw_port))) { $ru = "sip:" + $rU + "@" + $sel(cfg_get.pstn.gw_ip); } else { $ru = "sip:" + $rU + "@" + $sel(cfg_get.pstn.gw_ip) + ":" + $sel(cfg_get.pstn.gw_port); } route(RELAY); exit; #!endif return; } # JSONRPC over HTTP(S) routing #!ifdef WITH_JSONRPC event_route[xhttp:request] { set_reply_close(); set_reply_no_connect(); if(src_ip!=127.0.0.1) { xhttp_reply("403", "Forbidden", "text/html", "<html><body>Not allowed from $si</body></html>"); exit; } if ($hu =~ "^/RPC") { jsonrpc_dispatch(); exit; } xhttp_reply("200", "OK", "text/html", "<html><body>Wrong URL $hu</body></html>"); exit; } #!endif # Routing to voicemail server route[TOVOICEMAIL] { #!ifdef WITH_VOICEMAIL if(!is_method("INVITE|SUBSCRIBE")) return; # check if VoiceMail server IP is defined if (strempty($sel(cfg_get.voicemail.srv_ip))) { xlog("SCRIPT: VoiceMail routing enabled but IP not defined\n"); return; } if(is_method("INVITE")) { if($avp(oexten)==$null) return; $ru = "sip:" + $avp(oexten) + "@" + $sel(cfg_get.voicemail.srv_ip) + ":" + $sel(cfg_get.voicemail.srv_port); } else { if($rU==$null) return; $ru = "sip:" + $rU + "@" + $sel(cfg_get.voicemail.srv_ip) + ":" + $sel(cfg_get.voicemail.srv_port); } route(RELAY); exit; #!endif return; } # Manage outgoing branches branch_route[MANAGE_BRANCH] { xdbg("new branch [$T_branch_idx] to $ru\n"); route(NATMANAGE); return; } # Manage incoming replies reply_route { if(!sanity_check("17604", "6")) { xlog("Malformed SIP response from $si:$sp\n"); drop; } return; } # Manage incoming replies in transaction context onreply_route[MANAGE_REPLY] { xdbg("incoming reply\n"); if(status=~"[12][0-9][0-9]") { route(NATMANAGE); } return; } # Manage failure routing cases failure_route[MANAGE_FAILURE] { route(NATMANAGE); if (t_is_canceled()) exit; #!ifdef WITH_BLOCK3XX # block call redirect based on 3xx replies. if (t_check_status("3[0-9][0-9]")) { t_reply("404","Not found"); exit; } #!endif #!ifdef WITH_BLOCK401407 # block call redirect based on 401, 407 replies. if (t_check_status("401|407")) { t_reply("404","Not found"); exit; } #!endif #!ifdef WITH_VOICEMAIL # serial forking # - route to voicemail on busy or no answer (timeout) if (t_check_status("486|408")) { $du = $null; route(TOVOICEMAIL); exit; } #!endif return; -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4272 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4272(a)github.com>

2 2

git:master:0ab44e99: modules: readme files regenerated - userblocklist ... [skip ci]
by Kamailio Dev 04 Jun '25

04 Jun '25

Module: kamailio Branch: master Commit: 0ab44e999c81a25dc826f23e724cf699ce894beb URL: https://github.com/kamailio/kamailio/commit/0ab44e999c81a25dc826f23e724cf69… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-04T08:01:09+02:00 modules: readme files regenerated - userblocklist ... [skip ci] --- Modified: src/modules/userblocklist/README --- Diff: https://github.com/kamailio/kamailio/commit/0ab44e999c81a25dc826f23e724cf69… Patch: https://github.com/kamailio/kamailio/commit/0ab44e999c81a25dc826f23e724cf69… --- diff --git a/src/modules/userblocklist/README b/src/modules/userblocklist/README index 9aabcb73d19..4cff231c495 100644 --- a/src/modules/userblocklist/README +++ b/src/modules/userblocklist/README @@ -154,9 +154,9 @@ Chapter 1. Admin Guide blocklisted or not. An additional functionality that this module provides is the ability to - handle global blocklists. This lists are loaded on startup into memory, - thus providing a better performance than the userblocklist case. These - global blocklists are useful to allow only calls to certain + handle global blocklists. These lists are loaded on startup into + memory, thus providing a better performance than the userblocklist + case. These global blocklists are useful to allow only calls to certain international destinations, i.e. block all not allowlisted numbers. They could also be used to prevent the blocklisting of important numbers, as allowlisting is supported too. This is useful for example

1 0

git:master:81357b54: userblocklist: docs - small typo
by Daniel-Constantin Mierla 04 Jun '25

04 Jun '25

Module: kamailio Branch: master Commit: 81357b548b6e0cdf464361c2b1742d797f0d7e95 URL: https://github.com/kamailio/kamailio/commit/81357b548b6e0cdf464361c2b1742d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-04T07:50:46+02:00 userblocklist: docs - small typo --- Modified: src/modules/userblocklist/doc/userblocklist_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/81357b548b6e0cdf464361c2b1742d7… Patch: https://github.com/kamailio/kamailio/commit/81357b548b6e0cdf464361c2b1742d7… --- diff --git a/src/modules/userblocklist/doc/userblocklist_admin.xml b/src/modules/userblocklist/doc/userblocklist_admin.xml index db8efd86896..0a64d648ea1 100644 --- a/src/modules/userblocklist/doc/userblocklist_admin.xml +++ b/src/modules/userblocklist/doc/userblocklist_admin.xml @@ -20,7 +20,7 @@ </para> <para> An additional functionality that this module provides is the ability - to handle global blocklists. This lists are loaded on startup into + to handle global blocklists. These lists are loaded on startup into memory, thus providing a better performance than the userblocklist case. These global blocklists are useful to allow only calls to certain international destinations, i.e. block all not allowlisted numbers.

1 0

git:master:0195e860: siptrace: reset x/avp lists after event route
by Daniel-Constantin Mierla 04 Jun '25

04 Jun '25

Module: kamailio Branch: master Commit: 0195e86084ffbe5333310fc4206f4a6d01662a85 URL: https://github.com/kamailio/kamailio/commit/0195e86084ffbe5333310fc4206f4a6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-04T07:50:46+02:00 siptrace: reset x/avp lists after event route --- Modified: src/modules/sipdump/sipdump_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0195e86084ffbe5333310fc4206f4a6… Patch: https://github.com/kamailio/kamailio/commit/0195e86084ffbe5333310fc4206f4a6… --- diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c index cdac1a32ccf..e199d1cefc9 100644 --- a/src/modules/sipdump/sipdump_mod.c +++ b/src/modules/sipdump/sipdump_mod.c @@ -40,6 +40,8 @@ #include "../../core/mod_fix.h" #include "../../core/fmsg.h" #include "../../core/events.h" +#include "../../core/srapi.h" +#include "../../core/receive.h" #include "../../core/kemi.h" #include "sipdump_write.h" @@ -286,14 +288,14 @@ static sipdump_data_t *sipdump_event_data = NULL; */ int sipdump_event_route(sipdump_data_t *sdi) { - int backup_rt; run_act_ctx_t ctx; run_act_ctx_t *bctx; sr_kemi_eng_t *keng = NULL; str evname = str_init("sipdump:msg"); sip_msg_t *fmsg = NULL; + ksr_msg_env_t menv = {0}; - backup_rt = get_route_type(); + ksr_msg_env_push(&menv); set_route_type(EVENT_ROUTE); init_run_actions_ctx(&ctx); fmsg = faked_msg_next(); @@ -312,7 +314,8 @@ int sipdump_event_route(sipdump_data_t *sdi) } } sipdump_event_data = NULL; - set_route_type(backup_rt); + ksr_msg_env_reset(); + ksr_msg_env_pop(&menv); if(ctx.run_flags & DROP_R_F) { return DROP_R_F; }

1 0

[kamailio/kamailio] Cannot connect using MySQL option group name in DBURL (Issue #4271)
by dynax60 03 Jun '25

03 Jun '25

dynax60 created an issue (kamailio/kamailio#4271) Hi all! ```bash [root@kamailio kamailio]# cat /etc/rocky-release Rocky Linux release 9.5 (Blue Onyx) [root@kamailio kamailio]# sestatus SELinux status: disabled [root@kamailio kamailio]# kamailio -v version: kamailio 6.0.1 (x86_64/linux) fce50d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fce50d compiled on 00:00:00 Sep 13 2022 with gcc 11.5.0 ``` I am trying to use the mysql option group name `kamailio` to connect to MySQL: ``` #!ifdef WITH_MYSQL #!trydef DBURL "mysql://[kamailio]/kamailio" #!endif ``` My /etc/my.cnf file: ``` # # This group is read both both by the client and the server # use it for options that affect everything # [client-server] # # include all files from the config directory # !includedir /etc/my.cnf.d/ ``` /etc/my.cnf.d/kamailio.cnf: ``` [kamailio] socket=/var/lib/mysql/mysql.sock user = kamailio password = ... default-character-set = utf8 ``` Let's check the group name and permissions (for test purposes): ```bash [root@kamailio kamailio]# usermod -s /bin/sh kamailio [root@kamailio kamailio]# su - kamailio -c 'my_print_defaults -c /etc/my.cnf kamailio' --socket=/var/lib/mysql/mysql.sock --user=kamailio --password=... --default-character-set=utf8 ``` The cuts from log file: ``` May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:1035]: init_mod(): auth_db May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <db_bind_api> in module db_mysql [/usr/lib64/kamailio/modules/db_mysql.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [lib/srdb1/db.c:217]: db_bind_mod(): using db bind api for db_mysql May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <bind_auth_s> in module auth [/usr/lib64/kamailio/modules/auth.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:1035]: init_mod(): presence May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: presence [presence.c:301]: mod_init(): db_url=mysql://[kamailio]/kamailio (len=27 addr=0x7f6002ba6f00) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/utils/sruid.c:127]: sruid_init(): root for sruid is [pres-683a04b4-1c59-] (0 / 19) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: presence [presence.c:345]: mod_init(): server_address parameter not set in configuration file May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <bind_sl> in module sl [/usr/lib64/kamailio/modules/sl.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <load_tm> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_newtran> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_relay_to_tcp> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_relay_to_udp> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_relay> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_forward_nonack> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_release> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <db_bind_api> in module db_mysql [/usr/lib64/kamailio/modules/db_mysql.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [lib/srdb1/db.c:217]: db_bind_mod(): using db bind api for db_mysql May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [lib/srdb1/db.c:322]: db_do_init2(): connection 0x7f6002c25500 not found in pool May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: db_mysql [km_my_con.c:121]: db_mysql_new_connection(): opening connection: mysql://xxxx:xxxx@/kamailio May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: db_mysql [km_my_con.c:219]: db_mysql_new_connection(): driver error: Access denied for user 'kamailio'@'localhost' (using password: NO) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: <core> [lib/srdb1/db.c:326]: db_do_init2(): could not add connection to the pool May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: presence [presence.c:417]: mod_init(): Connection to database failed May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: <core> [core/sr_module.c:1040]: init_mod(): Error while initializing module presence (/usr/lib64/kamailio/modules/presence.so) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:875]: destroy_modules(): starting modules destroy phase ``` Strange things happens if I place [kamailio] configuration into /etc/my.cnf - everything works like a charm! What could be wrong? How to check by other means? The problem is exactly that kamailio can't read the configuration in the external file /etc/my.cnf.d/kamailio.cnf -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4271 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4271(a)github.com>

3 4

[kamailio/kamailio] rtpengine: fix race condn (same ip:port) in parallel forks due to gencookie (PR #4139)
by Souradeep Bera 01 Jun '25

01 Jun '25

- avoid parallel calls to gencookie from generating the same cookie for rtpengine #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4139 -- Commit Summary -- * rtpengine: fix race condn assigning same ip:port due to gencookie in parallel forks -- File Changes -- M src/modules/rtpengine/rtpengine.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4139.patch https://github.com/kamailio/kamailio/pull/4139.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4139 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4139(a)github.com>

4 6

[kamailio/kamailio] Possibly adjusting the SDP parser to be more lenient towards scenarios where a stream is being removed/rejected and connection-information "c=" is only available per media (no session-wide "c=") and the removed/rejected stream omits all fields (Issue #3982)
by thomas414 31 May '25

31 May '25

### Description I encountered an issue with a specific device that is receiving a T.38 fax. The call gets established towards the device normally with inband media, then the device requests T.38 media and tries to remove the audio media via sending port 0 in the ReInvite SDP. Also it sends connection-information only on the media level and there is no "c=" on the session level. Reading through the related RFCs and the kamailio code and discussing this on the mailing list, we came to the conclusion that kamailio is doing everything correct as per RFC. Though we were wondering if it would be possible to adjust the parser to be not as strict as it is right now, and allow a missing "c=" line on the media-level if the stream is removed/rejected via port 0, since i see no sense in requiring connection information. Of course we are also in contact with the vendor to hopefully adjust on their side. Here are the related RFCs: 1. RFC8866 5.7 `A session description MUST contain either at least one "c=" line in each media description or a single "c=" line at the session level. It MAY contain a single session-level "c=" line and additional media-level "c=" line(s) per-media-description, in which case the media-level values override the session-level settings for the respective media.` 2. RFC3264 8.2 `Existing media streams are removed by creating a new SDP with the port number for that stream set to zero. The stream description MAY omit all attributes present previously, and MAY list just a single media format.` At first i was especially confused by the RFC3264 8.2 part, since it seemed correct what the device is sending, but if you read carefully and keep the wording for SDP in mind only attributes ("a=") MAY be omitted. So a "c=" line should still be in the SDP for the removed media if it's not included on the session-level. Or do you see this differently? ### Expected behavior Kamailio allows and parses the SDP when there is no session-wide "c=", a media stream is being removed via port zero and there is no "c=" for this media stream and only the remaining media streams include a "c=" line. #### Actual observed behavior Kamailio throws an error when trying to parse the SDP. #### Log Messages ``` <core> [core/parser/sdp/sdp.c:523]: parse_sdp_session(): can't find media IP in the message ``` #### SIP Traffic ``` v=0 o=xmserver 1726638425 1726638427 IN IP4 169.254.1.1 s=xmserver t=0 0 m=audio 0 RTP/AVP 8 m=image 56002 udptl t38 c=IN IP4 169.254.1.1 a=sendrecv a=T38FaxVersion:0 a=T38MaxBitRate:14400 a=T38FaxFillBitRemoval:0 a=T38FaxTranscodingMMR:0 a=T38FaxTranscodingJBIG:0 a=T38FaxRateManagement:transferredTCF a=T38FaxMaxBuffer:200 a=T38FaxMaxDatagram:72 a=T38FaxUdpEC:t38UDPRedundancy ``` ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.3 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: ``` Debian 12 Linux hostname 6.1.0-20-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.85-1 (2024-04-11) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3982 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3982(a)github.com>

3 5

[kamailio/kamailio] Inactive video stream: can't find media IP in the message (Issue #3406)
by schoberw 31 May '25

31 May '25

### Description In some situations the other side UA must reply with an inactive media stream. E.g. if video was added but not supported by the other side. The UAS then must answer with an m=video 0 RTP/.. line. It seams that the video section must contain a c= line with an IP address for rtpengine to function. If there is no c line (no IP address) the SDP body cannot be parsed and thus no RTP proxy is invoked. ### Troubleshooting Not easy to reproduce since the answer must bei "wrong". Is it correct to reply an SDP body (media = video) like this? ``` m=video 0 RTP/AVPF 96 a=label:1 a=inactive a=mid:1 ``` Maybe not (but Audiocodes SBC lates LTS version does it) - so we are dependent on other side now that this service works. #### Reproduction reInvite with Video to a UA that has no video Support (e.g. Bria -> Snom). Drop the c line in the video part with some textops in 200 OK (just to reproduce of course). A -> B, connect the call A -> + video, B has no video support A presses hold #### Log Messages Incoming 200 OK after doing hold with an inactive video: ``` v=0 o=root 436040161 309284577 IN IP4 1.2.3.5 s=call t=0 0 m=audio 14200 RTP/AVPF 9 8 126 c=IN IP4 1.2.3.5 a=ptime:20 a=recvonly a=mid:0 a=rtpmap:9 G722/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:126 telephone-event/8000 a=fmtp:126 0-15 m=video 0 RTP/AVPF 96 a=label:1 a=inactive a=mid:1 Mar 27 17:52:22 c5p05es2-1 /usr/sbin/kamailio[2938205]: ERROR: <core> [core/parser/sdp/sdp.c:490]: parse_sdp_session(): can't find media IP in the message Mar 27 17:52:22 c5p05es2-1 /usr/sbin/kamailio[2938205]: INFO: <script>: >>> Sending Reply: 200 OK (1.2.3.4:443 -> 100.108.48.38:65251) ``` Compare to working SDP parsing: ``` a=rtpmap:9 G722/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:126 telephone-event/8000 a=fmtp:126 0-15 m=video 0 RTP/AVP 96 c=IN IP4 1.2.3.5 a=inactive a=mid:1 Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: ONREPLY_ROUTE[FORWARD] Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: ROUTE[RTPP_REPLY] Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > 200 with video Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > 200 with inactive video Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > Remove inactive video Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > Answer to WebRTC client: 200 - qijpuibkv6ufhnd282ks Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: >>> Sending Reply: 200 OK (91.237.65.14:443 -> 80.108.48.38:65388) ``` ### Possible Solutions Tried to fix in script: ``` if(sdp_with_media("video")) xlog("L_INFO", "> $rs with video"); if(sdp_with_active_media("video")) xlog("L_INFO", "> $rs with active video"); if(!sdp_with_active_media("video")) xlog("L_INFO", "> $rs with inactive video"); if(sdp_with_media("video") && !sdp_with_active_media("video")) { # try fix for RMT#60189 xlog("L_INFO", "> Remove inactive video"); sdp_remove_media("video"); msg_apply_changes(); # needed? } ``` But since sdpops cannot parse it cannot remove the buggy media, too. See the log: non of the xlog is logging. If there is inactive media the c line is not mandatory. The parser should accept this by adding a default IP of 0.0.0.0, if needed Doing tricks with textops is not a easy nor performant solution to accept this wrong SDP from other parties. ### Additional Information ``` version: kamailio 5.6.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` * **Operating System**: Debian Bullseye -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3406 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3406(a)github.com>

3 5

[kamailio/kamailio] dispatcher: weight documentation and workaround for limitations (PR #4158)
by Christian Berger 31 May '25

31 May '25

- describe limitation of weight parameter - describe a potential workaround against those limitations  #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  We had problems understanding the weight parameter of the dispatcher module and wrote a little workaround against the problems we have found. This workaround in the configuration file improves behavior for setups with many dispatcher targets at the cost of more CPU load. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4158 -- Commit Summary -- * dispatcher: weight documentation and workaround for limitations -- File Changes -- M src/modules/dispatcher/doc/dispatcher_admin.xml (28) A src/modules/dispatcher/doc/weights.cfg (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4158.patch https://github.com/kamailio/kamailio/pull/4158.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4158 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4158(a)github.com>

4 4

[kamailio/kamailio] kafka_send in event_route not work (Issue #4198)
by wangduanduan 31 May '25

31 May '25

wangduanduan created an issue (kamailio/kamailio#4198)  ### Description kafka_send in event_route like tcp:timeout, tcp:closed not work ``` event_route[tcp:closed] { if (kafka_send("my_topic", "tcp:closed")) { xlog("L_INFO", "send success tcp:closed"); } } event_route[tcp:timeout] { if (kafka_send("my_topic", "tcp:timeout")) { xlog("L_INFO", "send success tcp:timeout"); } } ``` in log, its show "send success tcp:closed", "send success tcp:timeout", but in kafka web ui, in the **my_topic**, can't find the "tcp:closed" or " tcp:timeout" message. --- but if the kafka_send in onreply_route, message will be send ok, in the kafka web ui, the "some_route" can be find. ``` onreplay_route[some_route]{ if (kafka_send("my_topic", "some_routet")) { xlog("L_INFO", "send success some_routet"); } } ```  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic i use tcpdump to capture the traffic between kamailio and kafka. - when use kafka_send in event_route, no packages captured.  ``` ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 5.6.1 ``` * **Operating System**: centos7  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4198 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4198(a)github.com>

5 10

git:master:218de360: modules: readme files regenerated - jansson ... [skip ci]
by Kamailio Dev 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 218de360f439c3ef203f4403b5d06cd7ecca19df URL: https://github.com/kamailio/kamailio/commit/218de360f439c3ef203f4403b5d06cd… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-30T12:31:11+02:00 modules: readme files regenerated - jansson ... [skip ci] --- Modified: src/modules/jansson/README --- Diff: https://github.com/kamailio/kamailio/commit/218de360f439c3ef203f4403b5d06cd… Patch: https://github.com/kamailio/kamailio/commit/218de360f439c3ef203f4403b5d06cd… --- diff --git a/src/modules/jansson/README b/src/modules/jansson/README index 550c9d62a8d..47a091b8ca6 100644 --- a/src/modules/jansson/README +++ b/src/modules/jansson/README @@ -134,7 +134,7 @@ if(!jansson_get("inner.deep.list[3]", "$var(myjson)", "$var(n)")) { } xlog("L_INFO", "foo is $var(n)"); ... -jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)") +jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)"); ... 3.2. jansson_pv_get(key/path, srcvar, dst)

1 0

git:master:5ee87b79: siptrace: reset x/avp lists after event route
by Daniel-Constantin Mierla 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 5ee87b7905d931931dece44ec591d8e6bcf567e2 URL: https://github.com/kamailio/kamailio/commit/5ee87b7905d931931dece44ec591d8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-30T12:23:19+02:00 siptrace: reset x/avp lists after event route - GH #4258 --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/5ee87b7905d931931dece44ec591d8e… Patch: https://github.com/kamailio/kamailio/commit/5ee87b7905d931931dece44ec591d8e… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 6e6ffcaf237..3c27e20fe87 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -41,6 +41,7 @@ #include "../../core/ip_addr.h" #include "../../core/mem/mem.h" #include "../../core/mem/shm_mem.h" +#include "../../core/receive.h" #include "../../core/rpc.h" #include "../../core/rpc_lookup.h" #include "../../lib/srdb1/db.h" @@ -54,6 +55,7 @@ #include "../../core/str.h" #include "../../core/onsend.h" #include "../../core/events.h" +#include "../../core/srapi.h" #include "../../core/kemi.h" #include "siptrace_data.h" @@ -2220,12 +2222,12 @@ static siptrace_data_t *siptrace_event_data = NULL; static int siptrace_exec_evcb_msg(siptrace_data_t *sto) { - int backup_rt; run_act_ctx_t ctx; run_act_ctx_t *bctx; sr_kemi_eng_t *keng = NULL; str evname = str_init("siptrace:msg"); sip_msg_t msg; + ksr_msg_env_t menv = {0}; if(_siptrace_evrt_msg_idx < 0 && _siptrace_evcb_msg.len <= 0) { return 0; @@ -2248,7 +2250,7 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) return -1; } - backup_rt = get_route_type(); + ksr_msg_env_push(&menv); set_route_type(EVENT_ROUTE); init_run_actions_ctx(&ctx); @@ -2267,8 +2269,9 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) } siptrace_event_data = NULL; + ksr_msg_env_reset(); free_sip_msg(&msg); - set_route_type(backup_rt); + ksr_msg_env_pop(&menv); if(ctx.run_flags & DROP_R_F) { return DROP_R_F; }

1 0

git:master:465fda0f: core: implement pop of lists from msg env
by Daniel-Constantin Mierla 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 465fda0f790e44e5484b2ef41363fb23fece3f41 URL: https://github.com/kamailio/kamailio/commit/465fda0f790e44e5484b2ef41363fb2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-30T12:07:46+02:00 core: implement pop of lists from msg env --- Modified: src/core/srapi.c --- Diff: https://github.com/kamailio/kamailio/commit/465fda0f790e44e5484b2ef41363fb2… Patch: https://github.com/kamailio/kamailio/commit/465fda0f790e44e5484b2ef41363fb2… --- diff --git a/src/core/srapi.c b/src/core/srapi.c index 8d7bd1ca620..a16acf97d21 100644 --- a/src/core/srapi.c +++ b/src/core/srapi.c @@ -79,7 +79,6 @@ void ksr_msg_env_push(ksr_msg_env_t *menv) { menv->route_type = get_route_type(); - /* make available the avp list from transaction */ menv->avps_uri_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, NULL); menv->avps_uri_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, NULL); menv->avps_user_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, NULL); @@ -100,5 +99,16 @@ void ksr_msg_env_push(ksr_msg_env_t *menv) void ksr_msg_env_pop(ksr_msg_env_t *menv) { set_route_type(menv->route_type); + + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, menv->avps_uri_from); + set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, menv->avps_uri_to); + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, menv->avps_user_from); + set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, menv->avps_user_to); + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_DOMAIN, menv->avps_domain_from); + set_avp_list(AVP_TRACK_TO | AVP_CLASS_DOMAIN, menv->avps_domain_to); + xavp_set_list(menv->xavps); + xavu_set_list(menv->xavus); + xavi_set_list(menv->xavis); + return; }

1 0

git:master:7fed8f52: jansson: docs - added missing semicolon in the example
by Daniel-Constantin Mierla 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 7fed8f52391aaef43d5cb672f4821d50d4855830 URL: https://github.com/kamailio/kamailio/commit/7fed8f52391aaef43d5cb672f4821d5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-30T11:53:06+02:00 jansson: docs - added missing semicolon in the example --- Modified: src/modules/jansson/doc/jansson_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7fed8f52391aaef43d5cb672f4821d5… Patch: https://github.com/kamailio/kamailio/commit/7fed8f52391aaef43d5cb672f4821d5… --- diff --git a/src/modules/jansson/doc/jansson_admin.xml b/src/modules/jansson/doc/jansson_admin.xml index daa5e9ea51e..71ffa92bff9 100644 --- a/src/modules/jansson/doc/jansson_admin.xml +++ b/src/modules/jansson/doc/jansson_admin.xml @@ -94,7 +94,7 @@ if(!jansson_get("inner.deep.list[3]", "$var(myjson)", "$var(n)")) { } xlog("L_INFO", "foo is $var(n)"); ... -jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)") +jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)"); ... </programlisting> </example> @@ -313,4 +313,3 @@ xlog("foo.foz is $var(foofoz)"); </section> </section> </chapter> -

1 0

[kamailio/kamailio] Sca in cluster/load balancer (Issue #4267)
by Maurotb 29 May '25

29 May '25

Maurotb created an issue (kamailio/kamailio#4267) We have two kamailio in load balancing, mysql is in cluster mode. We need to use sca, but kamailio db cluster is not supported (i need to specify connection string to sql not cluster name) and if phone1 is registered on kamailio1 and phone2 on kamailio2, sca not work. It is possibile to implement cluster? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4267 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4267(a)github.com>

2 2

[kamailio/kamailio] Disable IPSec in P-CSCF (Issue #4269)
by navjyoty 29 May '25

29 May '25

navjyoty created an issue (kamailio/kamailio#4269) I'm working on a custom IMS deployment using the pcscf module in Kamailio. For our setup, we do not want Kamailio to handle IPsec or generate Security-Server headers in 401/407 responses. Is there a clean way to disable IPsec functionality entirely in the pcscf module? Specifically, I would like to: Prevent the module from requiring IPsec setup during UE registration Avoid any modification of SIP messages related to IPsec (e.g., removing Security-Verify, Security-Client, or Security-Server headers) Use only TLS or UDP without IPsec involvement Has anyone achieved this via configuration or by disabling specific features? Any guidance or examples would be greatly appreciated. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4269 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4269(a)github.com>

2 2

[kamailio/kamailio] SIP Race condition when using dlg.end_dlg (Issue #4268)
by IgorG 29 May '25

29 May '25

IgorrG created an issue (kamailio/kamailio#4268) ### Description We use RPC dlg.end_dlg command to terminate dialog. In most cases it does operate properly and send BYE from kamailio to both sides of dialog (as show on screenshot). ![Image](https://github.com/user-attachments/assets/b49164a5-6442-4c66-bd4d-f5412678247f) We found that in some cases we have only first BYE sent to calling party. Second BYE never sent, when called party tries to terminate call by timeout it get responded with 481. ![Image](https://github.com/user-attachments/assets/10c90b4c-30a3-4123-8e2b-2ca64cdec3c3) ![Image](https://github.com/user-attachments/assets/f0facce8-3acf-4049-8a23-ad559874af7b) In logs we have such warning: мая 27 15:11:46 service-proxy.iqtek.ru kamailio[3518388]: 2(3518388) WARNING: {1 1 BYE 541d3f2c-43fd-43b6-af24-bad1fbf85eb6} dialog [dlg_handlers.c:1343]: dlg_onroute(): unable to find dialog for BYE with route param 'e1e.4f22' [3614:8948] and call-id '541d3f2c-43fd-43b6-af24-bad1fbf85eb6' We also found that in this case this warning shown in logs 0.04 seconds after kamailio receive 200ok. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # ./kamailio -V version: kamailio 5.8.6 (x86_64/linux) fb71db flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fb71db compiled on 17:38:27 May 26 2025 with gcc 12.2.0 ``` * **Operating System**: ``` # lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm # uname -a Linux rtp-kamailio2 6.1.0-32-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.129-1 (2025-03-06) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4268 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4268(a)github.com>

1 0

git:master:54a330bb: core: helper functions to get/set msg env lists
by Daniel-Constantin Mierla 28 May '25

28 May '25

Module: kamailio Branch: master Commit: 54a330bb707fb6b4943ba26356891696681a02e7 URL: https://github.com/kamailio/kamailio/commit/54a330bb707fb6b4943ba2635689169… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-28T21:28:47+02:00 core: helper functions to get/set msg env lists --- Modified: src/core/srapi.c Modified: src/core/srapi.h --- Diff: https://github.com/kamailio/kamailio/commit/54a330bb707fb6b4943ba2635689169… Patch: https://github.com/kamailio/kamailio/commit/54a330bb707fb6b4943ba2635689169… --- diff --git a/src/core/srapi.c b/src/core/srapi.c index 99fbf49d8a9..8d7bd1ca620 100644 --- a/src/core/srapi.c +++ b/src/core/srapi.c @@ -19,7 +19,9 @@ #include <stdio.h> #include <stdlib.h> + #include "dprint.h" +#include "route.h" #include "srapi.h" @@ -69,3 +71,34 @@ sr_cfgenv_t *sr_cfgenv_get(void) { return &_sr_cfgenv; } + +/** + * + */ +void ksr_msg_env_push(ksr_msg_env_t *menv) +{ + menv->route_type = get_route_type(); + + /* make available the avp list from transaction */ + menv->avps_uri_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, NULL); + menv->avps_uri_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, NULL); + menv->avps_user_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, NULL); + menv->avps_user_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, NULL); + menv->avps_domain_from = + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_DOMAIN, NULL); + menv->avps_domain_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_DOMAIN, NULL); + menv->xavps = xavp_set_list(NULL); + menv->xavus = xavu_set_list(NULL); + menv->xavis = xavi_set_list(NULL); + + return; +} + +/** + * + */ +void ksr_msg_env_pop(ksr_msg_env_t *menv) +{ + set_route_type(menv->route_type); + return; +} diff --git a/src/core/srapi.h b/src/core/srapi.h index 1f5f8e7d36b..b573493a62b 100644 --- a/src/core/srapi.h +++ b/src/core/srapi.h @@ -20,6 +20,8 @@ #define __SRAPI_H__ #include "str.h" +#include "usr_avp.h" +#include "xavp.h" #include "parser/msg_parser.h" typedef void (*sr_generate_callid_f)(str *); @@ -39,4 +41,21 @@ typedef struct sr_cfgenv void sr_cfgenv_init(void); sr_cfgenv_t *sr_cfgenv_get(void); +typedef struct ksr_msg_env +{ + int route_type; + avp_list_t *avps_user_from; + avp_list_t *avps_user_to; + avp_list_t *avps_domain_from; + avp_list_t *avps_domain_to; + avp_list_t *avps_uri_from; + avp_list_t *avps_uri_to; + sr_xavp_t **xavps; + sr_xavp_t **xavus; + sr_xavp_t **xavis; +} ksr_msg_env_t; + +void ksr_msg_env_push(ksr_msg_env_t *menv); +void ksr_msg_env_pop(ksr_msg_env_t *menv); + #endif

1 0

git:master:f0291728: ims_ipsec_pcscf: jump to error for clean up
by Daniel-Constantin Mierla 28 May '25

28 May '25

Module: kamailio Branch: master Commit: f0291728b7fb623faf1d4de0f3152e782a6782ae URL: https://github.com/kamailio/kamailio/commit/f0291728b7fb623faf1d4de0f3152e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-28T21:28:46+02:00 ims_ipsec_pcscf: jump to error for clean up --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/f0291728b7fb623faf1d4de0f3152e7… Patch: https://github.com/kamailio/kamailio/commit/f0291728b7fb623faf1d4de0f3152e7… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index e15de4e2de8..4672a45906a 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -272,7 +272,7 @@ static int fill_contact( if((srcip = pkg_malloc(50)) == NULL) { LM_ERR("Error allocating memory for source IP address\n"); - return -1; + goto error; } memcpy(srcip, alias_s.s, ci->received_host.len);

1 0

[kamailio/kamailio] tls: Create one shared context and reuse it. (PR #3972)
by Xenofon Karamanos 28 May '25

28 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3823 #### Description  This PR aims to implement what was discussed in [mailing list](https://lists.kamailio.org/mailman3/hyperkitty/list/sr-dev@lists.kama… regarding some `tls.reload` and increasing memory usage. It adds a new parameter `enable_shared_ctx` in `tls` module that if set to 0, preserves the old behavior and if set to 1 (other than 0 tbh), it creates a single SSL context that is being shared. This have the effect of using way less memory when initialized as well, but also minimizes (can't say it fixes the problem) the `tls.reload` memory increase. I have also added a small markdown (comparison.md) file, where some comparisons where made between enabled/disabled shared context and with/without CA file (where the initial problem was occurring by the reporter). Feedback would be necessary to verify whether this patch, acts as expected and kamailio works as intented. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3972 -- Commit Summary -- * tls: Add parameter for shared contexts * tls: Comparison for enable_shared_ctx -- File Changes -- A comparison.md (15) M src/modules/tls/tls_domain.c (172) M src/modules/tls/tls_mod.c (11) M src/modules/tls/tls_mod.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3972.patch https://github.com/kamailio/kamailio/pull/3972.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3972 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3972(a)github.com>

4 12

[kamailio/kamailio] core: local TCP socket is bound on listening address (PR #3925)
by sergey-safarov 28 May '25

28 May '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description As a local IP address for TCP sending operation the Kamailio service is taking the same network_interface/IP_address, which is used by the service for TCP listening. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3925 -- Commit Summary -- * core: local TCP socket is bound on listening address -- File Changes -- M src/core/tcp_main.c (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3925.patch https://github.com/kamailio/kamailio/pull/3925.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3925 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3925(a)github.com>

5 16

Re: [kamailio/kamailio] pkg/kamailio: switched RPM packaging to use cmake (9a1b9d0)
by Xenofon Karamanos 27 May '25

27 May '25

Same -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a741486da3/158142745(a)github.com>

1 0

Re: [kamailio/kamailio] pkg/kamailio: switched RPM packaging to use cmake (9a1b9d0)
by Xenofon Karamanos 27 May '25

27 May '25

@sergey-safarov I look a bit on this commit and some comments i can give are: 1) The config files of these modules are already installed by default when they are included to be built. No need for extra step. 2) These *-cfg components are no longer available after the refactoring to use build groups instead. Can you maybe confirm that? I expect that it silently does nothing instead of complaining... -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a741486da3/158142732(a)github.com>

1 0

git:master:6ccf41b3: modules: readme files regenerated - pdb ... [skip ci]
by Kamailio Dev 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 6ccf41b3e2c27b9f790aa9cc881eeca1054cb20c URL: https://github.com/kamailio/kamailio/commit/6ccf41b3e2c27b9f790aa9cc881eeca… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-27T16:01:09+02:00 modules: readme files regenerated - pdb ... [skip ci] --- Modified: src/modules/pdb/README --- Diff: https://github.com/kamailio/kamailio/commit/6ccf41b3e2c27b9f790aa9cc881eeca… Patch: https://github.com/kamailio/kamailio/commit/6ccf41b3e2c27b9f790aa9cc881eeca… --- diff --git a/src/modules/pdb/README b/src/modules/pdb/README index 52ebab2e8ae..0c2ec72e122 100644 --- a/src/modules/pdb/README +++ b/src/modules/pdb/README @@ -12,6 +12,11 @@ Pawel Kuzak 1&1 Internet AG <pawel.kuzak(a)1und1.de> +Muhammad Shahzad Shafi + + 1&1 Internet AG + <muhammad.shafi(a)1und1.de> + Copyright © 2009 1&1 Internet AG __________________________________________________________________ @@ -38,8 +43,9 @@ Pawel Kuzak 5. RPC Commands 5.1. pdb.status - 5.2. pdb.activate - 5.3. pdb.deactivate + 5.2. pdb.timeout + 5.3. pdb.activate + 5.4. pdb.deactivate List of Examples @@ -48,8 +54,9 @@ Pawel Kuzak 1.3. Set ll_info parameter 1.4. pdb_query usage 1.5. pdb.status usage - 1.6. pdb.activate usage - 1.7. pdb.deactivate usage + 1.6. pdb.timeout usage + 1.7. pdb.activate usage + 1.8. pdb.deactivate usage Chapter 1. Admin Guide @@ -74,8 +81,9 @@ Chapter 1. Admin Guide 5. RPC Commands 5.1. pdb.status - 5.2. pdb.activate - 5.3. pdb.deactivate + 5.2. pdb.timeout + 5.3. pdb.activate + 5.4. pdb.deactivate 1. Overview @@ -178,8 +186,9 @@ cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); 5. RPC Commands 5.1. pdb.status - 5.2. pdb.activate - 5.3. pdb.deactivate + 5.2. pdb.timeout + 5.3. pdb.activate + 5.4. pdb.deactivate 5.1. pdb.status @@ -191,22 +200,35 @@ cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); kamcmd pdb.status ... -5.2. pdb.activate +5.2. pdb.timeout + + Prints the current PDB query timeout value. This can also be used to + set the PDB query timeout. + + Example 1.6. pdb.timeout usage +... +# get the PDB query timeout +kamcmd pdb.timeout +# set the PDB query timeout to 10ms +kamcmd pdb.timeout 10 +... + +5.3. pdb.activate Activates the module. This is the default after loading the module. - Example 1.6. pdb.activate usage + Example 1.7. pdb.activate usage ... kamcmd pdb.activate ... -5.3. pdb.deactivate +5.4. pdb.deactivate Deactivates the module. No more queries are performed until it is activated again. As long as the module is deactivated, the pdb_query function will return -1. - Example 1.7. pdb.deactivate usage + Example 1.8. pdb.deactivate usage ... kamcmd pdb.deactivate ...

1 0

[kamailio/kamailio] PDB: new RPC command to get/set the PDB query timeout value (PR #4261)
by Muhammad Shahzad Shafi 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4261 -- Commit Summary -- * pdb: add new RPC command to view/change PDB query timeout * pdb: add documentation for new RPC command to view/change PDB query timeout * Merge branch 'kamailio:master' into master -- File Changes -- M src/modules/pdb/doc/pdb.xml (6) M src/modules/pdb/doc/pdb_admin.xml (18) M src/modules/pdb/pdb.c (35) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4261.patch https://github.com/kamailio/kamailio/pull/4261.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4261 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4261(a)github.com>

2 5

git:master:db903613: pdb: add documentation for new RPC command to view/change PDB query timeout
by Henning Westerholt 27 May '25

27 May '25

Module: kamailio Branch: master Commit: db903613a10ae93ce0b8ff93835486953df4437e URL: https://github.com/kamailio/kamailio/commit/db903613a10ae93ce0b8ff938354869… Author: Muhammad Shafi <muhammad.shafi(a)1und1.de> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-05-27T15:56:13+02:00 pdb: add documentation for new RPC command to view/change PDB query timeout --- Modified: src/modules/pdb/doc/pdb.xml Modified: src/modules/pdb/doc/pdb_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/db903613a10ae93ce0b8ff938354869… Patch: https://github.com/kamailio/kamailio/commit/db903613a10ae93ce0b8ff938354869… --- diff --git a/src/modules/pdb/doc/pdb.xml b/src/modules/pdb/doc/pdb.xml index 835353ca359..686cf6ab0be 100644 --- a/src/modules/pdb/doc/pdb.xml +++ b/src/modules/pdb/doc/pdb.xml @@ -24,6 +24,12 @@ <affiliation><orgname>1&1 Internet AG</orgname></affiliation> <email>pawel.kuzak(a)1und1.de</email> </editor> + <editor> + <firstname>Muhammad Shahzad</firstname> + <surname>Shafi</surname> + <affiliation><orgname>1&1 Internet AG</orgname></affiliation> + <email>muhammad.shafi(a)1und1.de</email> + </editor> </authorgroup> <copyright> <year>2009</year> diff --git a/src/modules/pdb/doc/pdb_admin.xml b/src/modules/pdb/doc/pdb_admin.xml index 19b00bd99d8..50fb4190dae 100644 --- a/src/modules/pdb/doc/pdb_admin.xml +++ b/src/modules/pdb/doc/pdb_admin.xml @@ -163,6 +163,24 @@ cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); <programlisting format="linespecific"> ... &kamcmd; pdb.status +... + </programlisting> + </example> + </section> + <section id="pdb.r.timeout"> + <title>pdb.timeout</title> + <para> + Prints the current PDB query timeout value. + This can also be used to set the PDB query timeout. + </para> + <example> + <title><function>pdb.timeout</function> usage</title> + <programlisting format="linespecific"> +... +# get the PDB query timeout +&kamcmd; pdb.timeout +# set the PDB query timeout to 10ms +&kamcmd; pdb.timeout 10 ... </programlisting> </example>

1 0

git:master:e2ab3174: pdb: add new RPC command to view/change PDB query timeout
by Henning Westerholt 27 May '25

27 May '25

Module: kamailio Branch: master Commit: e2ab3174fb8f013e0a536c0cd5b049f3e2015eec URL: https://github.com/kamailio/kamailio/commit/e2ab3174fb8f013e0a536c0cd5b049f… Author: Muhammad Shafi <muhammad.shafi(a)1und1.de> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-05-27T15:56:13+02:00 pdb: add new RPC command to view/change PDB query timeout --- Modified: src/modules/pdb/pdb.c --- Diff: https://github.com/kamailio/kamailio/commit/e2ab3174fb8f013e0a536c0cd5b049f… Patch: https://github.com/kamailio/kamailio/commit/e2ab3174fb8f013e0a536c0cd5b049f… --- diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c index 492fa99ec09..77806e49df6 100644 --- a/src/modules/pdb/pdb.c +++ b/src/modules/pdb/pdb.c @@ -27,6 +27,8 @@ #include "../../core/sr_module.h" +#include "../../core/cfg/cfg.h" +#include "../../core/cfg/cfg_ctx.h" #include "../../core/mem/mem.h" #include "../../core/mem/shm_mem.h" #include "../../core/rpc_lookup.h" @@ -806,6 +808,36 @@ static void pdb_rpc_status(rpc_t *rpc, void *ctx) (*active) ? "active" : "inactive"); } +static void pdb_rpc_timeout(rpc_t *rpc, void *ctx) +{ + void *vh; + int new_val = -1; + int old_val = cfg_get(pdb, pdb_cfg, timeout); + + str gname = str_init("pdb"); + str vname = str_init("timeout"); + + if(rpc->add(ctx, "{", &vh) < 0) { + rpc->fault(ctx, 500, "Server error"); + return; + } + + if(rpc->scan(ctx, "*d", &new_val) < 1) { + if(rpc->struct_add(vh, "d", "timeout", old_val) < 0) { + rpc->fault(ctx, 500, "Internal error reply structure"); + } + return; + } + + if(rpc->struct_add(vh, "dd", "old_timeout", old_val, "new_timeout", new_val) + < 0) { + rpc->fault(ctx, 500, "Internal error reply structure"); + return; + } + + cfg_set_now_int(ctx, &gname, NULL, &vname, new_val); +} + static void pdb_rpc_activate(rpc_t *rpc, void *ctx) { if(active == NULL) { @@ -826,11 +858,14 @@ static void pdb_rpc_deactivate(rpc_t *rpc, void *ctx) static const char *pdb_rpc_status_doc[2] = {"Get the pdb status.", 0}; +static const char *pdb_rpc_timeout_doc[2] = {"Set the pdb_query timeout.", 0}; + static const char *pdb_rpc_activate_doc[2] = {"Activate pdb.", 0}; static const char *pdb_rpc_deactivate_doc[2] = {"Deactivate pdb.", 0}; rpc_export_t pdb_rpc[] = {{"pdb.status", pdb_rpc_status, pdb_rpc_status_doc, 0}, + {"pdb.timeout", pdb_rpc_timeout, pdb_rpc_timeout_doc, 0}, {"pdb.activate", pdb_rpc_activate, pdb_rpc_activate_doc, 0}, {"pdb.deactivate", pdb_rpc_deactivate, pdb_rpc_deactivate_doc, 0}, {0, 0, 0, 0}};

1 0

[kamailio/kamailio] tls: add WSS to RPC funtions (PR #4259)
by Benjamin 27 May '25

27 May '25

- tls_list() add PROTO_WSS to TLS_LIST RPC call to include WSS connections in tls.list - tls_kill() add PROTO_WSS to handle WSS connections Co-authored-by: Andreas Tarp <tarp(a)sipgate.de> #### Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #4167 #### Description WSS connection is not shown in tls.list RPC command like all other TLS connections. Also tls_kill does not handle WSS connections. This is related to the issue 4167. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4259 -- Commit Summary -- * http_client: add information about parameter loading * http_client: docs - typos from previous commit * tls: add WSS to RPC funtions -- File Changes -- M src/modules/http_client/doc/http_client_admin.xml (7) M src/modules/tls/tls_rpc.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4259.patch https://github.com/kamailio/kamailio/pull/4259.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4259 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4259(a)github.com>

1 5

git:master:0039c50e: permissions: don't allow reloads in the middle of ongoind reload
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 0039c50e83916c647a2ee38e6be2c39ad17adfcc URL: https://github.com/kamailio/kamailio/commit/0039c50e83916c647a2ee38e6be2c39… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T14:06:20+02:00 permissions: don't allow reloads in the middle of ongoind reload --- Modified: src/modules/permissions/rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/0039c50e83916c647a2ee38e6be2c39… Patch: https://github.com/kamailio/kamailio/commit/0039c50e83916c647a2ee38e6be2c39… --- diff --git a/src/modules/permissions/rpc.c b/src/modules/permissions/rpc.c index 6519c6343c0..7646ee0672e 100644 --- a/src/modules/permissions/rpc.c +++ b/src/modules/permissions/rpc.c @@ -45,7 +45,8 @@ int rpc_check_reload(rpc_t *rpc, void *ctx) rpc->fault(ctx, 500, "ongoing reload"); return -1; } - *perm_rpc_reload_time = time(NULL); + // we are reloading, don't allow new reloads + *perm_rpc_reload_time = time(NULL) + 86400; return 0; } @@ -61,10 +62,13 @@ void rpc_trusted_reload(rpc_t *rpc, void *c) if(reload_trusted_table_cmd() != 1) { rpc->fault(c, 500, "Reload failed."); - return; + goto done; } rpc->rpl_printf(c, "Reload OK"); +done: + // reloading is done + *perm_rpc_reload_time = time(NULL); return; } @@ -101,10 +105,13 @@ void rpc_address_reload(rpc_t *rpc, void *c) if(reload_address_table_cmd() != 1) { rpc->fault(c, 500, "Reload failed."); - return; + goto done; } rpc->rpl_printf(c, "Reload OK"); +done: + // reloading is done + *perm_rpc_reload_time = time(NULL); return; }

1 0

git:5.8:02edb040: sca: reserve subscription.rr.s separately since it could be updated
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: 5.8 Commit: 02edb0408d907fa2a9031faf40bca899dbfcf050 URL: https://github.com/kamailio/kamailio/commit/02edb0408d907fa2a9031faf40bca89… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T11:43:53+02:00 sca: reserve subscription.rr.s separately since it could be updated (cherry picked from commit fd04bcc152dd6ef88fbb819b0b77aee7ca817878) (cherry picked from commit 14de4b1101f62c3463e5f05836e8618a3b0db96b) --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/02edb0408d907fa2a9031faf40bca89… Patch: https://github.com/kamailio/kamailio/commit/02edb0408d907fa2a9031faf40bca89… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index 9e212f01e2c..c460cccdb36 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -625,9 +625,6 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, len += sizeof(sca_subscription); len += sizeof(char) * (aor->len + subscriber->len); - if(!SCA_STR_EMPTY(rr)) { - len += sizeof(char) * rr->len; - } sub = (sca_subscription *)shm_malloc(len); if(sub == NULL) { @@ -659,18 +656,20 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, SCA_STR_COPY(&sub->target_aor, aor); len += aor->len; + // we shm_malloc this parts separately in case we need to update in-memory + // info for this subscriber. This is likely to happen if the + // subscriber goes off-line for some reason. if(!SCA_STR_EMPTY(rr)) { - sub->rr.s = (char *)sub + len; + sub->rr.s = (char *)shm_malloc(rr->len); + if(sub->rr.s == NULL) { + SHM_MEM_ERROR; + goto error; + } SCA_STR_COPY(&sub->rr, rr); - len += rr->len; } // dialog.id holds call-id + from-tag + to-tag; dialog.call_id, // dialog.from_tag, and dialog.to_tag point to offsets within // dialog.id. - // - // we shm_malloc this separately in case we need to update in-memory - // dialog saved for this subscriber. This is likely to happen if the - // subscriber goes off-line for some reason. len = sizeof(char) * (call_id->len + from_tag->len + to_tag->len); sub->dialog.id.s = (char *)shm_malloc(len); if(sub->dialog.id.s == NULL) { @@ -701,6 +700,9 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, error: if(sub != NULL) { + if(sub->rr.s != NULL) { + shm_free(sub->rr.s); + } if(sub->dialog.id.s != NULL) { shm_free(sub->dialog.id.s); } @@ -733,6 +735,10 @@ void sca_subscription_free(void *value) LM_DBG("Freeing %s subscription from %.*s\n", sca_event_name_from_type(sub->event), STR_FMT(&sub->subscriber)); + if(!SCA_STR_EMPTY(&sub->rr)) { + shm_free(sub->rr.s); + } + if(!SCA_STR_EMPTY(&sub->dialog.id)) { shm_free(sub->dialog.id.s); }

1 0

git:6.0:14de4b11: sca: reserve subscription.rr.s separately since it could be updated
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: 6.0 Commit: 14de4b1101f62c3463e5f05836e8618a3b0db96b URL: https://github.com/kamailio/kamailio/commit/14de4b1101f62c3463e5f05836e8618… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T11:43:14+02:00 sca: reserve subscription.rr.s separately since it could be updated (cherry picked from commit fd04bcc152dd6ef88fbb819b0b77aee7ca817878) --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/14de4b1101f62c3463e5f05836e8618… Patch: https://github.com/kamailio/kamailio/commit/14de4b1101f62c3463e5f05836e8618… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index ca42fd138e9..5e34ceac6d2 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -626,9 +626,6 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, len += sizeof(sca_subscription); len += sizeof(char) * (aor->len + subscriber->len); - if(!SCA_STR_EMPTY(rr)) { - len += sizeof(char) * rr->len; - } sub = (sca_subscription *)shm_malloc(len); if(sub == NULL) { @@ -660,18 +657,20 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, SCA_STR_COPY(&sub->target_aor, aor); len += aor->len; + // we shm_malloc this parts separately in case we need to update in-memory + // info for this subscriber. This is likely to happen if the + // subscriber goes off-line for some reason. if(!SCA_STR_EMPTY(rr)) { - sub->rr.s = (char *)sub + len; + sub->rr.s = (char *)shm_malloc(rr->len); + if(sub->rr.s == NULL) { + SHM_MEM_ERROR; + goto error; + } SCA_STR_COPY(&sub->rr, rr); - len += rr->len; } // dialog.id holds call-id + from-tag + to-tag; dialog.call_id, // dialog.from_tag, and dialog.to_tag point to offsets within // dialog.id. - // - // we shm_malloc this separately in case we need to update in-memory - // dialog saved for this subscriber. This is likely to happen if the - // subscriber goes off-line for some reason. len = sizeof(char) * (call_id->len + from_tag->len + to_tag->len); sub->dialog.id.s = (char *)shm_malloc(len); if(sub->dialog.id.s == NULL) { @@ -702,6 +701,9 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, error: if(sub != NULL) { + if(sub->rr.s != NULL) { + shm_free(sub->rr.s); + } if(sub->dialog.id.s != NULL) { shm_free(sub->dialog.id.s); } @@ -734,6 +736,10 @@ void sca_subscription_free(void *value) LM_DBG("Freeing %s subscription from %.*s\n", sca_event_name_from_type(sub->event), STR_FMT(&sub->subscriber)); + if(!SCA_STR_EMPTY(&sub->rr)) { + shm_free(sub->rr.s); + } + if(!SCA_STR_EMPTY(&sub->dialog.id)) { shm_free(sub->dialog.id.s); }

1 0

[kamailio/kamailio] sca: reserve subscription.rr.s separately since it could be updated (PR #4251)
by Victor Seva 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally #### Description sca was generating a crash since it is trying to shm_free a part of a bigger block at: https://github.com/kamailio/kamailio/blob/master/src/modules/sca/sca_subscr… So, let's reserve memory that field separately. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4251 -- Commit Summary -- * sca: reserve subscription.rr.s separately since it could be updated -- File Changes -- M src/modules/sca/sca_subscribe.c (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4251.patch https://github.com/kamailio/kamailio/pull/4251.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4251 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4251(a)github.com>

1 1

git:master:fd04bcc1: sca: reserve subscription.rr.s separately since it could be updated
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: master Commit: fd04bcc152dd6ef88fbb819b0b77aee7ca817878 URL: https://github.com/kamailio/kamailio/commit/fd04bcc152dd6ef88fbb819b0b77aee… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T11:41:23+02:00 sca: reserve subscription.rr.s separately since it could be updated --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/fd04bcc152dd6ef88fbb819b0b77aee… Patch: https://github.com/kamailio/kamailio/commit/fd04bcc152dd6ef88fbb819b0b77aee… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index ca42fd138e9..5e34ceac6d2 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -626,9 +626,6 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, len += sizeof(sca_subscription); len += sizeof(char) * (aor->len + subscriber->len); - if(!SCA_STR_EMPTY(rr)) { - len += sizeof(char) * rr->len; - } sub = (sca_subscription *)shm_malloc(len); if(sub == NULL) { @@ -660,18 +657,20 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, SCA_STR_COPY(&sub->target_aor, aor); len += aor->len; + // we shm_malloc this parts separately in case we need to update in-memory + // info for this subscriber. This is likely to happen if the + // subscriber goes off-line for some reason. if(!SCA_STR_EMPTY(rr)) { - sub->rr.s = (char *)sub + len; + sub->rr.s = (char *)shm_malloc(rr->len); + if(sub->rr.s == NULL) { + SHM_MEM_ERROR; + goto error; + } SCA_STR_COPY(&sub->rr, rr); - len += rr->len; } // dialog.id holds call-id + from-tag + to-tag; dialog.call_id, // dialog.from_tag, and dialog.to_tag point to offsets within // dialog.id. - // - // we shm_malloc this separately in case we need to update in-memory - // dialog saved for this subscriber. This is likely to happen if the - // subscriber goes off-line for some reason. len = sizeof(char) * (call_id->len + from_tag->len + to_tag->len); sub->dialog.id.s = (char *)shm_malloc(len); if(sub->dialog.id.s == NULL) { @@ -702,6 +701,9 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, error: if(sub != NULL) { + if(sub->rr.s != NULL) { + shm_free(sub->rr.s); + } if(sub->dialog.id.s != NULL) { shm_free(sub->dialog.id.s); } @@ -734,6 +736,10 @@ void sca_subscription_free(void *value) LM_DBG("Freeing %s subscription from %.*s\n", sca_event_name_from_type(sub->event), STR_FMT(&sub->subscriber)); + if(!SCA_STR_EMPTY(&sub->rr)) { + shm_free(sub->rr.s); + } + if(!SCA_STR_EMPTY(&sub->dialog.id)) { shm_free(sub->dialog.id.s); }

1 0

[kamailio/kamailio] PDB: new RPC command to view/change PDB query timeout value (PR #4260)
by Muhammad Shahzad Shafi 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4260 -- Commit Summary -- * pdb: add new RPC command to view/change PDB query timeout * pdb: add documentation for new RPC command to view/change PDB query timeout * pdb: add new code contributor credits -- File Changes -- M src/modules/pdb/doc/pdb.xml (6) M src/modules/pdb/doc/pdb_admin.xml (18) M src/modules/pdb/pdb.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4260.patch https://github.com/kamailio/kamailio/pull/4260.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4260 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4260(a)github.com>

1 3

[kamailio/kamailio] PDB: add RPC command to get and set PDB query timeout (PR #4254)
by Muhammad Shahzad Shafi 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4254 -- Commit Summary -- * pdb: added rpc command to view/update the pdb query timeout * pdb: add documentation for rpc command to view/update the pdb query timeout -- File Changes -- M src/modules/pdb/doc/pdb.xml (55) M src/modules/pdb/doc/pdb_admin.xml (334) M src/modules/pdb/pdb.c (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4254.patch https://github.com/kamailio/kamailio/pull/4254.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4254 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4254(a)github.com>

3 8

[kamailio/kamailio] Adding kemi exports for play_dtmf event_callback and dlg_req_within functions (PR #4245)
by ggontariu 27 May '25

27 May '25

- [x ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Added missing kemi exports for RTP Engine module play_dtmf event_callback functions and Dialog module dlg_req_within function You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4245 -- Commit Summary -- * Add support for playing DTMF tones in RTP engine module using Kemi * Add support for KEMI callbacks in RTP engine events * Add `ki_dlg_req_within4` handling for dialog requests -- File Changes -- M src/modules/dialog/dialog.c (24) M src/modules/rtpengine/rtpengine.c (215) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4245.patch https://github.com/kamailio/kamailio/pull/4245.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4245 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4245(a)github.com>

2 17

git:master:472dbb59: dialog: Kemi export dlg_req_within
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 472dbb59006207629e9724b7d7155719cb653969 URL: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… Author: gabrielgontariu <114484712+gabrielgontariu(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T09:31:56+02:00 dialog: Kemi export dlg_req_within --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… Patch: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 4539d1657e2..36af6f54404 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -2615,6 +2615,27 @@ static int ki_dlg_var_is_null(sip_msg_t *msg, str *name) return -1; } +/** + * + */ +static int ki_dlg_req_within4(struct sip_msg *msg, str *side, str *method, + str *content_type, str *content) +{ + int n = 0; + if(side && side->len > 0) { + if(side->len == 6 && strncasecmp(side->s, "caller", 6) == 0) { + n = 1; + } else if(side->len == 6 && strncasecmp(side->s, "callee", 6) == 0) { + n = 2; + } else { + return -1; + } + } + + return ki_dlg_req_with_headers_and_content( + msg, n, method, NULL, content_type, content); +} + /** * */ @@ -2780,6 +2801,11 @@ static sr_kemi_t sr_kemi_dialog_exports[] = { { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("dialog"), str_init("dlg_req_within4"), + SR_KEMIP_INT, ki_dlg_req_within4, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, + SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

git:master:c52bf0aa: rtpengine: Kemi export play_dtmf and event_callback. Enhance support for dtmf event by adding support for source_label, tags, source_ip, type, volume and duration
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: c52bf0aaa4ad2bc53ede2eeb5df0d8a9bff0e140 URL: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a… Author: gabrielgontariu <114484712+gabrielgontariu(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T09:31:56+02:00 rtpengine: Kemi export play_dtmf and event_callback. Enhance support for dtmf event by adding support for source_label, tags, source_ip, type, volume and duration --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a… Patch: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a…

1 0

git:master:25daa044: pv_headers: set value after checking if src is set
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 25daa0445ebc611cda3e47fd34aefc74494550d7 URL: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T08:59:16+02:00 pv_headers: set value after checking if src is set --- Modified: src/modules/pv_headers/pvh_str.c --- Diff: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… Patch: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… --- diff --git a/src/modules/pv_headers/pvh_str.c b/src/modules/pv_headers/pvh_str.c index 28908a37069..1916f93e002 100644 --- a/src/modules/pv_headers/pvh_str.c +++ b/src/modules/pv_headers/pvh_str.c @@ -50,11 +50,12 @@ int pvh_str_free(str *s) int pvh_str_copy(str *dst, str *src, unsigned int max_size) { - unsigned int src_len = src->len + 1 >= max_size ? max_size - 1 : src->len; + unsigned int src_len = 0; if(src == NULL || dst == NULL || src->len <= 0) return -1; + src_len = src->len + 1 >= max_size ? max_size - 1 : src->len; memset(dst->s, 0, dst->len); memcpy(dst->s, src->s, src_len); dst->s[src_len] = '\0';

1 0

git:master:df8e3895: secfilter: remove unnecessary check on clean up
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: df8e38958a3fa0a2e356bec727bb8d7ce19bec43 URL: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T08:58:17+02:00 secfilter: remove unnecessary check on clean up --- Modified: src/modules/secfilter/secfilter_db.c --- Diff: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7… Patch: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7… --- diff --git a/src/modules/secfilter/secfilter_db.c b/src/modules/secfilter/secfilter_db.c index 1c0138b0193..24884b231c9 100644 --- a/src/modules/secfilter/secfilter_db.c +++ b/src/modules/secfilter/secfilter_db.c @@ -185,9 +185,9 @@ int secf_append_rule(int action, int type, str *value) /** * @brief Removes entries from a whitelist or blacklist based on action, type, and value. * - * The function validates the action and type, locates the relevant list, and iterates - * through its nodes to find and remove all matches for the given value. If matches are found, - * the corresponding memory is freed, and the list pointers are updated. Logs are generated + * The function validates the action and type, locates the relevant list, and iterates + * through its nodes to find and remove all matches for the given value. If matches are found, + * the corresponding memory is freed, and the list pointers are updated. Logs are generated * for each removal and at the end of the process to summarize the result. * @param action: Specifies the target list (0 = blacklist, 1 = whitelist, 2 = destination blacklist). * @param type: Indicates the type of rule to be removed (e.g., domain, IP, user, etc.). @@ -358,10 +358,8 @@ int secf_load_db(void) lock_release(&(*secf_data)->lock); clean: - if(db_res) { - if(db_funcs.free_result(db_handle, db_res) < 0) { - LM_DBG("Failed to free the result\n"); - } + if(db_funcs.free_result(db_handle, db_res) < 0) { + LM_DBG("Failed to free the result\n"); } db_funcs.close(db_handle); return res;

1 0

git:master:5c38b53b: dialog: check for message struct before accessing the fields
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 5c38b53b902949fa48c3bc60288514cd7c555d5b URL: https://github.com/kamailio/kamailio/commit/5c38b53b902949fa48c3bc60288514c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T19:24:49+02:00 dialog: check for message struct before accessing the fields - for build_dlg_t_early() --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/5c38b53b902949fa48c3bc60288514c… Patch: https://github.com/kamailio/kamailio/commit/5c38b53b902949fa48c3bc60288514c… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 7645ebeca37..9ffd65e9526 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -494,7 +494,12 @@ dlg_t *build_dlg_t_early( goto error; } - if(msg == NULL || msg->first_line.type != SIP_REPLY) { + if(msg == NULL) { + LM_ERR("no sip message\n"); + goto error; + } + + if(msg->first_line.type != SIP_REPLY) { if(!cell->t) { LM_ERR("no transaction associated\n"); goto error;

1 0

git:master:46548193: pua_dialoginfo.c: fix condition for refresh_pubruri_avps_flag
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 46548193144c0b8ab0bf2e3ecdfd7feb79bc3b2f URL: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T19:16:55+02:00 pua_dialoginfo.c: fix condition for refresh_pubruri_avps_flag --- Modified: src/modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… Patch: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… --- diff --git a/src/modules/pua_dialoginfo/pua_dialoginfo.c b/src/modules/pua_dialoginfo/pua_dialoginfo.c index 26883cc27ad..09d25a67ea3 100644 --- a/src/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/src/modules/pua_dialoginfo/pua_dialoginfo.c @@ -381,12 +381,9 @@ static void __dialog_sendpublish( uri = callee_entity_when_publish_disabled; } - if(use_pubruri_avps - && (refresh_pubruri_avps_flag > -1 - || (request - && (request->flags - & (1U << (unsigned int) - refresh_pubruri_avps_flag))))) { + if(use_pubruri_avps && (refresh_pubruri_avps_flag > -1) && (request != NULL) + && (request->flags + & (1U << (unsigned int)refresh_pubruri_avps_flag))) { lock_get(&dlginfo->lock); refresh_pubruri_avps(dlginfo, &uri); } @@ -584,12 +581,9 @@ static void __dialog_sendpublish( } } - if(use_pubruri_avps - && (refresh_pubruri_avps_flag > -1 - || (request - && (request->flags - & (1U << (unsigned int) - refresh_pubruri_avps_flag))))) { + if(use_pubruri_avps && (refresh_pubruri_avps_flag > -1) && (request != NULL) + && (request->flags + & (1U << (unsigned int)refresh_pubruri_avps_flag))) { lock_release(&dlginfo->lock); } }

1 0

git:master:423f46e6: carrierroute: check pointer and length for str value
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 423f46e6a68e241ef03f59f863ecf6dee92c07db URL: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T18:58:59+02:00 carrierroute: check pointer and length for str value --- Modified: src/modules/carrierroute/cr_rpc_helper.c --- Diff: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… Patch: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… --- diff --git a/src/modules/carrierroute/cr_rpc_helper.c b/src/modules/carrierroute/cr_rpc_helper.c index fa1537151df..5077875bce5 100644 --- a/src/modules/carrierroute/cr_rpc_helper.c +++ b/src/modules/carrierroute/cr_rpc_helper.c @@ -107,7 +107,7 @@ static int update_route_data_recursor( if(rr->host.s) { shm_free(rr->host.s); } - if(opts->new_host.len) { + if(opts->new_host.s && opts->new_host.len) { if((rr->host.s = shm_malloc(opts->new_host.len + 1)) == NULL) { SHM_MEM_ERROR; @@ -132,12 +132,10 @@ static int update_route_data_recursor( FIFO_ERR(E_RESET); return -1; } - if(opts->new_host.len > 0) { + if(opts->new_host.s && opts->new_host.len > 0) { LM_INFO("deactivating host %.*s\n", rr->host.len, rr->host.s); - if(opts->new_host.s - && (strcmp(opts->new_host.s, rr->host.s) - == 0)) { + if(strcmp(opts->new_host.s, rr->host.s) == 0) { LM_ERR("Backup host the same as initial host " "%.*s", rr->host.len, rr->host.s);

1 0

[kamailio/kamailio] failed alpine docker image build (Issue #4241)
by sergey-safarov 24 May '25

24 May '25

sergey-safarov created an issue (kamailio/kamailio#4241) ### Description In the GitHub Actions present Alpine Docker image build error ``` tar (child): kamailio_min-without_os_files.tar.gz: Cannot open: No such file or directory tar (child): Error is not recoverable: exiting now tar: Child returned status 2 tar: Error is not recoverable: exiting now ``` https://github.com/kamailio/kamailio/actions/runs/14722992691/job/413201110… With high probability, this does not work I will work to fix this, but if possible, it will be fine to switch to use `cmake` for Alpine Docker image. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4241 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4241(a)github.com>

2 5

[kamailio/kamailio] cmake: do not packaged (Issue #4255)
by sergey-safarov 23 May '25

23 May '25

sergey-safarov created an issue (kamailio/kamailio#4255) ### Description I now make testing `cmake` packaging and see this error ``` RPM build errors: Directory not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres File not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres/* ``` ### Troubleshooting #### Reproduction I use this module list for build https://github.com/sergey-safarov/kamailio/blob/master/pkg/kamailio/obs/kam… @xkaraman could you look? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4255 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4255(a)github.com>

2 6

git:master:9a1b9d08: pkg/kamailio: switched RPM packaging to use cmake
by Sergey Safarov 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 9a1b9d08a112745663f37f0dfcbe86a741486da3 URL: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-05-23T18:47:42+03:00 pkg/kamailio: switched RPM packaging to use cmake --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… Patch: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a…

1 0

git:master:57bd37c5: cmake: dbschema Coorect install folder of pi_framework
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 57bd37c54390fdb70520834b0c2eb29fbb79510e URL: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T13:34:50Z cmake: dbschema Coorect install folder of pi_framework --- Modified: cmake/dbschema.cmake --- Diff: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… Patch: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… --- diff --git a/cmake/dbschema.cmake b/cmake/dbschema.cmake index dcd7bb0645b..a45e7e85470 100644 --- a/cmake/dbschema.cmake +++ b/cmake/dbschema.cmake @@ -59,6 +59,8 @@ function(add_db_target db_name xsl_file) set(install_folder "postgres") elseif(db_name STREQUAL "db_text") set(install_folder "dbtext") + elseif(db_name STREQUAL "pi_framework_table" OR db_name STREQUAL "pi_framework_mod") + set(install_folder "xhttp_pi") else() set(install_folder "${db_name}") endif() @@ -101,7 +103,6 @@ function(add_db_target db_name xsl_file) TARGET dbschema_${db_name} POST_BUILD COMMAND ${POSTPROCESS_SCRIPT} 1 1 - # ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} COMMENT "Creating version table for ${db_name}" WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} ) @@ -110,7 +111,6 @@ function(add_db_target db_name xsl_file) TARGET dbschema_${db_name} POST_BUILD COMMAND ${POSTPROCESS_SCRIPT} 2 10 - # ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} COMMENT "Creating version table for ${db_name}" WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} ) @@ -130,7 +130,8 @@ function(add_db_target db_name xsl_file) # message(WARNING "group name is ${group_name}") # Before installing, ensure the target is built `dbschema_${db_name}` # install as previously done in makefile folder. see naming above - # TODO: when tools adopt to new folder structure, remove the install_folder variable + # TODO: when tools adopt to new folder structure, replace the install_folder variable + # with ${db_name_folder} install( DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/

1 0

git:master:c7fcdfdb: cmake: Add some check for finding group name if using non K-variants of group names
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: c7fcdfdb13aeec9aeae726a9cc1ccaeda557e7bb URL: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T11:10:13Z cmake: Add some check for finding group name if using non K-variants of group names --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… Patch: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index a41560f17fc..c629ee49f93 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -764,6 +764,20 @@ function(find_group_name module) "" PARENT_SCOPE ) + # This was need due to the dbschema.cmake + # If one select one of these option as group + # we want the group name to match instead of the actual group it belongs to + if(MODULE_GROUP_NAME STREQUAL "ALL" + OR MODULE_GROUP_NAME STREQUAL "DEFAULT" + OR MODULE_GROUP_NAME STREQUAL "STANDARD" + OR MODULE_GROUP_NAME STREQUAL "COMMON" + ) + set(group_name + "${MODULE_GROUP_NAME}" + PARENT_SCOPE + ) + return() + endif() # message(WARNING "groups to search in" ${MODULE_GROUP_PACKAGE_GROUPS}) # Get all variable names in the current CMake context foreach(group IN LISTS MODULE_GROUP_PACKAGE_GROUPS) @@ -776,6 +790,8 @@ function(find_group_name module) "${group}" PARENT_SCOPE ) + return() endif() endforeach() + message((STATUS "module ${module} not found in any group")) endfunction()

1 0

git:master:0fb18272: cmake: Add missing package KSTANDARD
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 0fb182720428b276793899debb210279a0b5ec97 URL: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T11:10:13Z cmake: Add missing package KSTANDARD - When `ALL_PACKAGED` is used, KSTANDARD should be built as well, but not KMINI which is a subset of it. - Fix RTP_MEDIA group name --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… Patch: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index 90c47413d22..a41560f17fc 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -688,6 +688,7 @@ set(MODULE_GROUP_KRTP_MEDIA_SERVER ${MOD_LIST_RTP_MEDIA_SERVER}) set(STATIC_MODULES "") set(MODULE_GROUP_PACKAGE_GROUPS + KSTANDARD KPCRE KMYSQL KPOSTGRES @@ -748,7 +749,7 @@ set(MODULE_GROUP_PACKAGE_GROUPS KNGHTTP2 KGCRYPT KSECSIPID - KRT_MEDIA_SERVER + KRTP_MEDIA_SERVER ) # Add group names to available group and provide "ALL_PACKAGED" as well

1 0

5.7.7 release, tag and docker build
by Henning Westerholt 23 May '25

23 May '25

Hello, I have noticed that the git tag for release 5.7.7 was missing, I've just set it. The 5.7.7-bullseye docker image is also missing from https://github.com/kamailio/kamailio-docker/pkgs/container/kamailio Not sure if this is done automatically, if not - please can somebody please trigger the workflow to create it? Thank you, Henning

2 3

git:master:2ec8ddba: cmake: Move prefix/suffix calculation back.
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 2ec8ddba5eeaeea1c7292d1aa56ed90dc834341e URL: https://github.com/kamailio/kamailio/commit/2ec8ddba5eeaeea1c7292d1aa56ed90… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T10:56:50Z cmake: Move prefix/suffix calculation back. - Prefix depends on each table name.. - Fix postgress with correct install folder..... --- Modified: cmake/dbschema.cmake --- Diff: https://github.com/kamailio/kamailio/commit/2ec8ddba5eeaeea1c7292d1aa56ed90… Patch: https://github.com/kamailio/kamailio/commit/2ec8ddba5eeaeea1c7292d1aa56ed90… --- diff --git a/cmake/dbschema.cmake b/cmake/dbschema.cmake index 17528d83ed0..dcd7bb0645b 100644 --- a/cmake/dbschema.cmake +++ b/cmake/dbschema.cmake @@ -50,26 +50,13 @@ function(add_db_target db_name xsl_file) # For consistency, we are now using the new names. # For compatibility with tools, we are still using the old names for install folder - # Determine the prefix/suffix - if(db_name STREQUAL "db_berkeley" - OR db_name STREQUAL "db_redis" - OR db_name STREQUAL "db_text" - OR db_name STREQUAL "db_mongodb" - ) - set(prefix '') - set(folder_suffix "${MAIN_NAME}") - else() - set(prefix "${table}-") - set(folder_suffix '') - endif() - # install folder based on db_name if(db_name STREQUAL "db_mongodb") set(install_folder "mongodb") elseif(db_name STREQUAL "db_mysql") set(install_folder "mysql") elseif(db_name STREQUAL "db_postgres") - set(install_folder "mysql") + set(install_folder "postgres") elseif(db_name STREQUAL "db_text") set(install_folder "dbtext") else() @@ -79,6 +66,19 @@ function(add_db_target db_name xsl_file) # Loop through each table and add a command for xsltproc foreach(table ${EXTRACTED_TABLES}) + # Determine the prefix/suffix + if(db_name STREQUAL "db_berkeley" + OR db_name STREQUAL "db_redis" + OR db_name STREQUAL "db_text" + OR db_name STREQUAL "db_mongodb" + ) + set(prefix '') + set(folder_suffix "${MAIN_NAME}") + else() + set(prefix "${table}-") + set(folder_suffix '') + endif() + # Stringparam db is the db_* module name add_custom_command( TARGET dbschema_${db_name}

1 0

git:master:c2fc8090: pkg/kamailio: use radcli on RHEL based dist [skip ci]
by Sergey Safarov 23 May '25

23 May '25

Module: kamailio Branch: master Commit: c2fc809059e0c70aa4324f5727666989ee8aff05 URL: https://github.com/kamailio/kamailio/commit/c2fc809059e0c70aa4324f572766698… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-05-23T11:04:14+03:00 pkg/kamailio: use radcli on RHEL based dist [skip ci] --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/c2fc809059e0c70aa4324f572766698… Patch: https://github.com/kamailio/kamailio/commit/c2fc809059e0c70aa4324f572766698… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index d31f8c84d9b..094171caaeb 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -746,8 +746,8 @@ Summary: RADIUS modules for Kamailio Group: %{PKGGROUP} Requires: kamailio = %ver %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} -Requires: freeradius-client -BuildRequires: freeradius-client-devel +Requires: radcli +BuildRequires: radcli-devel %else Requires: radiusclient-ng BuildRequires: radiusclient-ng-devel @@ -1072,7 +1072,7 @@ rm -f misc/examples/pkg/sipcapture.cfg %build %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 -export FREERADIUS=1 +export RADCLI=1 %endif make cfg prefix=/usr \ basedir=%{buildroot} \ @@ -1084,7 +1084,7 @@ make make every-module skip_modules="app_mono db_cassandra db_oracle iptrtpproxy \ jabber ndb_cassandra osp" \ %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 - FREERADIUS=1 \ + RADCLI=1 \ %endif %if 0%{?rhel} >= 8 PYTHON3=python3.12 \ @@ -1192,7 +1192,7 @@ make install make install-modules-all skip_modules="app_mono db_cassandra db_oracle \ iptrtpproxy jabber osp" \ %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 - FREERADIUS=1 \ + RADCLI=1 \ %endif %if 0%{?rhel} >= 8 PYTHON3=python3.12 \

1 0

git:master:701d07df: pkg/kamailio: removed RHEL 6 and 7 if macros from RPM spec file
by Sergey Safarov 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 701d07df14d0d66125ff0ff3adec3ce424929472 URL: https://github.com/kamailio/kamailio/commit/701d07df14d0d66125ff0ff3adec3ce… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-05-23T10:46:18+03:00 pkg/kamailio: removed RHEL 6 and 7 if macros from RPM spec file --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/701d07df14d0d66125ff0ff3adec3ce… Patch: https://github.com/kamailio/kamailio/commit/701d07df14d0d66125ff0ff3adec3ce…

1 0

git:master:a7c4d400: pkg/kamailio: sipcapture remove
by Sergey Safarov 23 May '25

23 May '25

Module: kamailio Branch: master Commit: a7c4d4003dced50b3f6cbc7c9c6235e6bf894334 URL: https://github.com/kamailio/kamailio/commit/a7c4d4003dced50b3f6cbc7c9c6235e… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-05-23T10:18:56+03:00 pkg/kamailio: sipcapture remove --- Modified: pkg/kamailio/obs/kamailio.spec Removed: pkg/kamailio/obs/sipcapture.service Removed: pkg/kamailio/obs/sipcapture.sysconfig Removed: pkg/kamailio/obs/sipcapture.tmpfiles --- Diff: https://github.com/kamailio/kamailio/commit/a7c4d4003dced50b3f6cbc7c9c6235e… Patch: https://github.com/kamailio/kamailio/commit/a7c4d4003dced50b3f6cbc7c9c6235e…

1 0

[kamailio/kamailio] arm64 support issues (Issue #4235)
by Victor Seva 22 May '25

22 May '25

linuxmaniac created an issue (kamailio/kamailio#4235) Finally I had the time and patience to address the last issues in our deb environment. Now build flow is by _distribution/architecture_ so errors doesn't interfere in a healthy _distribution/architecture_ combination. > Follow up: same situation > > - **bookworm**: https://kamailio.sipwise.com/view/kamailiodev/job/kamailiodev-nightly-binar… > ``` > /usr/bin/make every-module group_include="kerlang" quiet=verbose > make[1]: Entering directory '/build/kamailio-6.1.0~dev1+bpo12.20250509084438.1' > /usr/bin/make -C src/ every-module > make[2]: Entering directory '/build/kamailio-6.1.0~dev1+bpo12.20250509084438.1/src' > config.mak loaded > Makefile.defs defs skipped > Makefile.defs defs skipped > qemu: uncaught target signal 11 (Segmentation fault) - core dumped > Segmentation fault > qemu: uncaught target signal 11 (Segmentation fault) - core dumped > Segmentation fault > Makefile:16: *** Not found Erlang. Stop. > make[2]: *** [Makefile:509: modules] Error 1 > make[2]: Leaving directory '/build/kamailio-6.1.0~dev1+bpo12.20250509084438.1/src' > make[1]: *** [Makefile:34: every-module] Error 2 > make[1]: Leaving directory '/build/kamailio-6.1.0~dev1+bpo12.20250509084438.1' > make: *** [debian/rules:134: build_erlang] Error 2 > make: *** Waiting for unfinished jobs.... > ``` > > - **bionic**: https://kamailio.sipwise.com/view/kamailiodev/job/kamailiodev-nightly-binar… > ``` > gcc -shared -g -pthread -Wl,-O2 -Wl,-E -Wl,-Bsymbolic-functions -Wl,-z,relro -rdynamic "-ldl" -Wl,-Bsymbolic-functions tls_domain.o tls_init.o tls_verify.o tls_locking.o tls_select.o tls_dump_vf.o tls_bio.o tlsa_mod.o tls_server.o tls_rpc.o tls_ct_wrq.o tls_rand.o tls_util.o tls_cfg.o tls_config.o -lm /usr/lib/aarch64-linux-gnu/libssl.a /usr/lib/aarch64-linux-gnu/libcrypto.a -o tlsa.so > /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libcrypto.a(sha1-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC > /usr/lib/aarch64-linux-gnu/libcrypto.a(sha1-armv8.o): In function `sha1_block_armv8': > (.text+0x1240): dangerous relocation: unsupported relocation > /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libcrypto.a(chacha-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC > /usr/lib/aarch64-linux-gnu/libcrypto.a(chacha-armv8.o):(.text+0x20): dangerous relocation: unsupported relocation > /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libcrypto.a(poly1305-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC > /usr/lib/aarch64-linux-gnu/libcrypto.a(poly1305-armv8.o): In function `poly1305_emit_neon': > (.text+0x9a0): dangerous relocation: unsupported relocation > /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libcrypto.a(sha256-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC > /usr/lib/aarch64-linux-gnu/libcrypto.a(sha256-armv8.o): In function `sha256_block_data_order': > (.text+0xf88): dangerous relocation: unsupported relocation > /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libcrypto.a(sha512-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC > /usr/lib/aarch64-linux-gnu/libcrypto.a(sha512-armv8.o): In function `sha512_block_data_order': > (.text+0x10c8): dangerous relocation: unsupported relocation > collect2: error: ld returned 1 exit status > ../../Makefile.rules:191: recipe for target 'tlsa.so' failed > make[3]: *** [tlsa.so] Error 1 > ``` > > - **focal**: https://kamailio.sipwise.com/view/kamailiodev/job/kamailiodev-nightly-binar… > ``` > gcc -shared -g -pthread -Wl,-O2 -Wl,-E -Wl,-Bsymbolic-functions -Wl,-z,relro -rdynamic "-ldl" -Wl,-Bsymbolic-functions tls_domain.o tls_init.o tls_verify.o tls_locking.o tls_select.o tls_dump_vf.o tls_bio.o tlsa_mod.o tls_server.o tls_rpc.o tls_ct_wrq.o tls_rand.o tls_util.o tls_cfg.o tls_config.o -lm /usr/lib/aarch64-linux-gnu/libssl.a /usr/lib/aarch64-linux-gnu/libcrypto.a -o tlsa.so > /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libcrypto.a(sha1-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC > /usr/lib/aarch64-linux-gnu/libcrypto.a(sha1-armv8.o): in function `sha1_block_armv8': > (.text+0x1240): dangerous relocation: unsupported relocation > /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libcrypto.a(chacha-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC > /usr/lib/aarch64-linux-gnu/libcrypto.a(chacha-armv8.o):(.text+0x20): dangerous relocation: unsupported relocation > /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libcrypto.a(poly1305-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC > /usr/lib/aarch64-linux-gnu/libcrypto.a(poly1305-armv8.o): in function `poly1305_emit_neon': > (.text+0x9a0): dangerous relocation: unsupported relocation > /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libcrypto.a(sha256-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC > /usr/lib/aarch64-linux-gnu/libcrypto.a(sha256-armv8.o): in function `sha256_block_data_order': > (.text+0xf88): dangerous relocation: unsupported relocation > /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libcrypto.a(sha512-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC > /usr/lib/aarch64-linux-gnu/libcrypto.a(sha512-armv8.o): in function `sha512_block_data_order': > (.text+0x1108): dangerous relocation: unsupported relocation > collect2: error: ld returned 1 exit status > ``` > _Originally posted by @linuxmaniac in [#13](https://github.com/sipwise/kamailio-deb-jenkins/issues/13#issuecomment-2866741862)_ -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4235 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4235(a)github.com>

2 1

[kamailio/kamailio] Duplicated presentities (and notifies) when usrloc and presence are replicated via dmq and pua_reginfo used (Issue #4252)
by Matteo 22 May '25

22 May '25

xadhoom created an issue (kamailio/kamailio#4252) ### Description A kamailio cluster which replicates presentities and usrloc via dmq may incur into duplicated presentities and notifications depending on config. The problematic setup, where each kamailio node has the following setup: - presence enabled with dmq - usrloc distributed with dmq - pua_reginfo used to publish reginfo to self Really is multiplicated by the numbers of nodes, so 4 nodes -> 4 times notifications and presentities. ### Troubleshooting The problem arise because pua_reginfo hooks to usrloc and every time a "save()" is done a publish is sent, which is by design. Then the handled publish generates a presentity which is replicated via dmq from presence module. Now, if also usrloc is replicated via DMQ, the handling of such message still trigger the hook, causing another publish with generates a different presentiy, since is new and the e-tag is different. This causes subscribers to receive <number of nodes> notifications on every status change. ### Possible Solutions The approach can be to optionally disable that hook (basically making pua_reginfo skipping publish) when handling a message via DMQ, so the usrloc replica is just saved. In other modules, like pua_dialoginfo or pua_usrloc this can be already done, since publishing can be controlled from script. ### Additional Information * **Kamailio Version** ``` 6.0.1 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4252 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4252(a)github.com>

1 0

[kamailio/kamailio] dmq send dialog message failed (Issue #4189)
by QuincyGao 22 May '25

22 May '25

QuincyGao created an issue (kamailio/kamailio#4189)  ### Description  I used dmq on two machines, registered two softphones on the 111 machine, and then used one phone to call another. After the call was connected, dmq sent a dialog message with an error message 400 bad request. Here is the 111 config, 113 almost same to 111: ``` loadmodule "dmq.so" modparam("dmq", "server_address", "sip:172.16.4.111:5464") modparam("dmq", "server_socket", "udp:172.16.4.111:5464") modparam("dmq", "notification_address", "sip:172.16.4.113:5464") modparam("dmq", "notification_channel", "peers") modparam("dmq", "num_workers", 4) modparam("dmq", "ping_interval", 30) loadmodule "dmq_usrloc.so" modparam("dmq_usrloc", "enable", 1) modparam("dmq_usrloc", "sync", 1) modparam("dmq_usrloc", "batch_msg_contacts", 50) # 50 contacts / message modparam("dmq_usrloc", "batch_size", 10000) # 10000 contacts / batch modparam("dmq_usrloc", "batch_usleep", 500000) loadmodule "dialog.so" modparam("dialog", "enable_stats", 1) modparam("dialog", "enable_dmq", 1) ... if (is_method("INVITE")) { setflag(FLT_ACC); # do accounting dlg_manage(); } ``` Here is the sip: <img width="836" alt="Image" src="https://github.com/user-attachments/assets/df609e21-77bb-43e9-a8aa-112069a3…" /> the 113 log error: ``` dialog [dlg_dmq.c:127]: dlg_dmq_handle_msg(): no content length header found ``` ### Troubleshooting #### Reproduction  The inevitable bug #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` 113 log: 22(4389) DEBUG: <core> [core/udp_server.c:708]: udp_rcv_loop(): received on udp socket: (106/100/767) [[KDMQ sip:dialog@172.16.4.113:5464 SIP/2.0 0D 0A Via: SIP/2.0/UDP 172.16.4.111:5464;branch=z9hG4bK28e.2ec7]] 22(4389) DEBUG: <core> [core/receive.c:190]: ksr_evrt_received(): event route core:msg-received not defined 22(4389) DEBUG: <core> [core/parser/parse_fline.c:249]: parse_first_line(): first line type 1 (request) flags 1 22(4389) DEBUG: <core> [core/parser/msg_parser.c:722]: parse_msg(): SIP Request: 22(4389) DEBUG: <core> [core/parser/msg_parser.c:724]: parse_msg(): method: <KDMQ> 22(4389) DEBUG: <core> [core/parser/msg_parser.c:726]: parse_msg(): uri: <sip:dialog@172.16.4.113:5464> 22(4389) DEBUG: <core> [core/parser/msg_parser.c:728]: parse_msg(): version: <SIP/2.0> 22(4389) DEBUG: <core> [core/parser/parse_hname2.c:316]: parse_sip_header_name(): parsed header name [Via] type 1 22(4389) DEBUG: <core> [core/parser/parse_via.c:1312]: parse_via_param(): Found param type 232, <branch> = <z9hG4bK28e.2ec78467000000000000000000000000.0>; state=16 22(4389) DEBUG: <core> [core/parser/parse_via.c:2663]: parse_via(): end of header reached, state=5 22(4389) DEBUG: <core> [core/parser/msg_parser.c:592]: parse_headers(): Via found, flags=2 22(4389) DEBUG: <core> [core/parser/msg_parser.c:594]: parse_headers(): this is the first via 22(4389) DEBUG: <core> [core/parser/parse_hname2.c:316]: parse_sip_header_name(): parsed header name [To] type 3 22(4389) DEBUG: <core> [core/parser/parse_addr_spec.c:904]: parse_addr_spec(): end of header reached, state=10 22(4389) DEBUG: <core> [core/parser/msg_parser.c:173]: get_hdr_field(): <To> [32]; uri=[sip:dialog@172.16.4.113:5464] 22(4389) DEBUG: <core> [core/parser/msg_parser.c:176]: get_hdr_field(): to body (32)[<sip:dialog@172.16.4.113:5464> ], to tag (0)[] 22(4389) DEBUG: <core> [core/parser/parse_hname2.c:316]: parse_sip_header_name(): parsed header name [From] type 4 22(4389) DEBUG: <core> [core/parser/parse_hname2.c:316]: parse_sip_header_name(): parsed header name [CSeq] type 5 22(4389) DEBUG: <core> [core/parser/msg_parser.c:154]: get_hdr_field(): cseq <CSeq>: <10> <KDMQ> 22(4389) DEBUG: <core> [core/parser/parse_hname2.c:316]: parse_sip_header_name(): parsed header name [Call-ID] type 6 22(4389) DEBUG: <core> [core/receive.c:397]: receive_msg(): --- received sip message - request - call-id: [6ecc0d71033645ea-1972(a)172.16.4.111] - cseq: [10 KDMQ] 22(4389) DEBUG: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| <core> [core/receive.c:263]: ksr_evrt_pre_routing(): event route core:pre-routing not defined 22(4389) DEBUG: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| <core> [core/receive.c:474]: receive_msg(): preparing to run routing scripts... 22(4389) exec: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| *** cfgtrace:dbg_cfg_trace(): request_route=[DEFAULT_ROUTE] c=[/usr/local/bin/../etc/kamailio/conf/kamailio.cfg] l=584 a=26 n=xlog 22(4389) INFO: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| <script>: 172.16.4.111:5464|172.16.4.113:5464|udp|KDMQ 22(4389) exec: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| *** cfgtrace:dbg_cfg_trace(): request_route=[DEFAULT_ROUTE] c=[/usr/local/bin/../etc/kamailio/conf/kamailio.cfg] l=592 a=16 n=if 22(4389) exec: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| *** cfgtrace:dbg_cfg_trace(): request_route=[DEFAULT_ROUTE] c=[/usr/local/bin/../etc/kamailio/conf/kamailio.cfg] l=589 a=25 n=is_method 22(4389) exec: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| *** cfgtrace:dbg_cfg_trace(): request_route=[DEFAULT_ROUTE] c=[/usr/local/bin/../etc/kamailio/conf/kamailio.cfg] l=590 a=24 n=dmq_process_message 22(4389) DEBUG: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| dmq [message.c:154]: ki_dmq_process_message_rc(): dmq_handle_message [KDMQ sip:dialog@172.16.4.113:5464] 22(4389) DEBUG: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| dmq [message.c:168]: ki_dmq_process_message_rc(): dmq_handle_message peer found: dialog 22(4389) DEBUG: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| <core> [core/parser/parse_addr_spec.c:185]: parse_to_param(): add param: tag=6c399121368d030ed41b62758342ea91-0405b528 22(4389) DEBUG: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| <core> [core/parser/parse_addr_spec.c:904]: parse_addr_spec(): end of header reached, state=29 22(4389) DEBUG: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| dialog [dlg_dmq.c:124]: dlg_dmq_handle_msg(): dmq message received 22(4389) ERROR: |25-03-26 15:25:01|6ecc0d71033645ea-1972@172.16.4.111| dialog [dlg_dmq.c:127]: dlg_dmq_handle_msg(): no content length header found ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.5 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: compiled on 11:27:01 Mar 21 2025 with gcc 4.8.5 ``` * **Operating System**:  ``` centos7.9 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4189 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4189(a)github.com>

1 3

[kamailio/kamailio] siptrace: sip_trace_mode("d") not working (Issue #4178)
by c.long 22 May '25

22 May '25

longchun4835 created an issue (kamailio/kamailio#4178)  ### Description Using function sip_trace_mode() with parameter d to enable dialog tracing mode logs: ``` BUG: siptrace [siptrace.c:1671]: add_info_xavp(): URI should be in raw format here ERROR: siptrace [siptrace.c:888]: sip_trace_helper(): failed to serialize siptrace info! Won't trace dialog! ``` ### Troubleshooting #### Reproduction my module parameters: ``` #!ifdef WITH_HOMER loadmodule "siptrace.so" modparam("siptrace", "duplicate_uri", HOMER_URL) modparam("siptrace", "hep_mode_on", 1) modparam("siptrace", "trace_to_database", 0) modparam("siptrace", "trace_flag", 22) modparam("siptrace", "trace_on", 1) modparam("siptrace", "hep_version", 3) modparam("siptrace", "hep_capture_id", HOMER_HEP_ID) #!endif ... request_route { ... if (is_method("INVITE")) { sip_trace_mode("d"); } } ``` ### Possible Solutions I checked the source code and found that the issue occurs when sip_trace_helper() is called inside the ki_sip_trace_mode() function, with the third parameter (duri) set to NULL. I don’t quite understand the logic behind passing NULL does this mean that the 'D' parameter will never working when calling sip_trace_mode()? Additionally, I have another question: in the sip_trace_helper() function, why does it call trace_transaction() instead of trace_dialog() when strace_type == SIPTRACE_DIALOG? ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.6.4 (x86_64/linux) a004cf flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: a004cf compiled on 09:14:30 Jan 23 2025 with gcc 8.3.1 ``` * **Operating System**: ``` NAME="CentOS Linux" VERSION="7 (Core)" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="7" PRETTY_NAME="CentOS Linux 7 (Core)" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:7" HOME_URL="https://www.centos.org/" BUG_REPORT_URL="https://bugs.centos.org/" ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4178 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4178(a)github.com>

3 3

Kamailio v5.7.7 Released
by Daniel-Constantin Mierla 21 May '25

21 May '25

Hello, Kamailio SIP Server v5.7.7 stable release is out. This is a maintenance release of the latest stable branch, 5.7, that includes fixes since the release of v5.7.6. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.7.x. Deployments running previous v5.7.x versions are strongly recommended to be upgraded to v5.7.7. Note that 5.7 is now the third last stable branch, v5.7.7 being the last planned released in 5.7.x series. The latest two stable branch are 5.8 and 6.0, with v6.0.1 being released a while ago. For more details about version 5.7.7 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2025/05/kamailio-v5-7-7-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 0

git:5.7:b228816f: ChangeLog: content updated for v5.7.7
by Daniel-Constantin Mierla 21 May '25

21 May '25

Module: kamailio Branch: 5.7 Commit: b228816f36f7963f1448c0f5a9fa2c5f434271d6 URL: https://github.com/kamailio/kamailio/commit/b228816f36f7963f1448c0f5a9fa2c5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-21T09:36:47+02:00 ChangeLog: content updated for v5.7.7 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/b228816f36f7963f1448c0f5a9fa2c5… Patch: https://github.com/kamailio/kamailio/commit/b228816f36f7963f1448c0f5a9fa2c5…

1 0

git:5.7:690a4160: Makefile.defs: version set to 5.7.7
by Daniel-Constantin Mierla 21 May '25

21 May '25

Module: kamailio Branch: 5.7 Commit: 690a41609bb6308834527f5081a19e20bd63e0ca URL: https://github.com/kamailio/kamailio/commit/690a41609bb6308834527f5081a19e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-21T09:10:42+02:00 Makefile.defs: version set to 5.7.7 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/690a41609bb6308834527f5081a19e2… Patch: https://github.com/kamailio/kamailio/commit/690a41609bb6308834527f5081a19e2… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index c598d6cb02c..a91846e5c19 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 7 -SUBLEVEL = 6 +SUBLEVEL = 7 EXTRAVERSION = # memory manager switcher

1 0

git:5.7:ebb630f9: pkg: deb specs updated for v5.7.7
by Daniel-Constantin Mierla 21 May '25

21 May '25

Module: kamailio Branch: 5.7 Commit: ebb630f9c7ff6e67209b8dbb67da69403b979661 URL: https://github.com/kamailio/kamailio/commit/ebb630f9c7ff6e67209b8dbb67da694… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-21T08:55:54+02:00 pkg: deb specs updated for v5.7.7 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/ebb630f9c7ff6e67209b8dbb67da694… Patch: https://github.com/kamailio/kamailio/commit/ebb630f9c7ff6e67209b8dbb67da694…

1 0

git:5.7:951e5360: pkg: version set to 5.7.7 for rpms and alpine specs
by Daniel-Constantin Mierla 21 May '25

21 May '25

Module: kamailio Branch: 5.7 Commit: 951e53600f17bf4b05f414b1dbfe8f8853cb0a70 URL: https://github.com/kamailio/kamailio/commit/951e53600f17bf4b05f414b1dbfe8f8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-21T08:48:18+02:00 pkg: version set to 5.7.7 for rpms and alpine specs --- Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/951e53600f17bf4b05f414b1dbfe8f8… Patch: https://github.com/kamailio/kamailio/commit/951e53600f17bf4b05f414b1dbfe8f8… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index c9a6b828707..e84d3a0bed3 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -4,7 +4,7 @@ # Maintainer: Nathan Angelacos <nangel(a)alpinelinux.org> pkgname=kamailio -pkgver=5.7.6 +pkgver=5.7.7 pkgrel=0 # If building from a git snapshot, specify the gitcommit diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 7e15f95fdc8..c0f4b3e7eba 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.7.6 +%define ver 5.7.7 %define rel dev1.0%{dist} %if 0%{?fedora}

1 0

Releasing v5.7.7
by Daniel-Constantin Mierla 21 May '25

21 May '25

Hello, I am considering to release Kamailio v5.7.7 (out of branch 5.7) on Wednesday, May 21, 2025, as the last one from the 5.7.x series, to mark the end of support for it. Currently 5.8.x and 6.0.x are the latest two maintained branches. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 1

git:master:cdf9a471: cmake: Refactor packaging setup and improve installation paths
by Xenofon Karamanos 20 May '25

20 May '25

Module: kamailio Branch: master Commit: cdf9a4716db3762b172df059d7366983216fd48c URL: https://github.com/kamailio/kamailio/commit/cdf9a4716db3762b172df059d736698… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-20T15:09:40Z cmake: Refactor packaging setup and improve installation paths - Moved packaging configuration to a new deb-packaging.cmake file for better organization. - Updated installation paths in CMakeLists to use DESTDIR for flexibility. - Enhanced group handling for module packaging, allowing for "ALL_PACKAGED" option. --- Added: cmake/deb-packaging.cmake Modified: CMakeLists.txt Modified: cmake/groups.cmake Modified: src/CMakeLists.txt Modified: src/modules/CMakeLists.txt Modified: utils/kamctl/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/cdf9a4716db3762b172df059d736698… Patch: https://github.com/kamailio/kamailio/commit/cdf9a4716db3762b172df059d736698…

1 0

git:master:201a2bde: cmake: snmpstats Remove warning message
by Xenofon Karamanos 20 May '25

20 May '25

Module: kamailio Branch: master Commit: 201a2bdee6a8b78787908b296824cd282b78eef5 URL: https://github.com/kamailio/kamailio/commit/201a2bdee6a8b78787908b296824cd2… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-20T15:08:35Z cmake: snmpstats Remove warning message --- Modified: src/modules/snmpstats/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/201a2bdee6a8b78787908b296824cd2… Patch: https://github.com/kamailio/kamailio/commit/201a2bdee6a8b78787908b296824cd2… --- diff --git a/src/modules/snmpstats/CMakeLists.txt b/src/modules/snmpstats/CMakeLists.txt index fead0651f33..3c5f2428242 100644 --- a/src/modules/snmpstats/CMakeLists.txt +++ b/src/modules/snmpstats/CMakeLists.txt @@ -8,7 +8,6 @@ find_package(NETSNMP REQUIRED) # TODO: Compiles fine but need to do some more verifcation target_link_libraries(${module_name} PRIVATE NETSNMP::NETSNMP) -message(WARNING "group_name is: ${group_name}") install( DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/mibs DESTINATION ${CMAKE_INSTALL_DATADIR}/snmp

1 0

git:master:e0dd3961: cmake: Fix dbschema generation to match older makefile structure
by Xenofon Karamanos 20 May '25

20 May '25

Module: kamailio Branch: master Commit: e0dd39618fae2004cd1ab44758ca323376935e2e URL: https://github.com/kamailio/kamailio/commit/e0dd39618fae2004cd1ab44758ca323… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-20T15:08:35Z cmake: Fix dbschema generation to match older makefile structure --- Added: cmake/dbschema-version-postprocess.sh Added: doc/stylesheets/dbschema_k/xsl/db_mongodb.xsl Added: doc/stylesheets/dbschema_k/xsl/db_mysql.xsl Added: doc/stylesheets/dbschema_k/xsl/db_oracle.xsl Added: doc/stylesheets/dbschema_k/xsl/db_postgres.xsl Added: doc/stylesheets/dbschema_k/xsl/db_text.xsl Modified: CMakeLists.txt Modified: cmake/dbschema.cmake Modified: doc/stylesheets/dbschema_k/xsl/common.xsl Modified: doc/stylesheets/dbschema_k/xsl/pi_framework_table.xsl Modified: src/CMakeLists.txt Modified: src/lib/srdb1/schema/version.xml Removed: doc/stylesheets/dbschema_k/xsl/dbtext.xsl Removed: doc/stylesheets/dbschema_k/xsl/mongodb.xsl Removed: doc/stylesheets/dbschema_k/xsl/mysql.xsl Removed: doc/stylesheets/dbschema_k/xsl/oracle.xsl Removed: doc/stylesheets/dbschema_k/xsl/postgres.xsl --- Diff: https://github.com/kamailio/kamailio/commit/e0dd39618fae2004cd1ab44758ca323… Patch: https://github.com/kamailio/kamailio/commit/e0dd39618fae2004cd1ab44758ca323…

1 0

git:master:ccad04cc: cmake: Fix dbschema generation with group names
by Xenofon Karamanos 20 May '25

20 May '25

Module: kamailio Branch: master Commit: ccad04cc13b1c5695aded8ee02181f10c8ed7d11 URL: https://github.com/kamailio/kamailio/commit/ccad04cc13b1c5695aded8ee02181f1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-20T15:06:11Z cmake: Fix dbschema generation with group names - Add function to find group of module - Some targets and destinations folders have changed due to changing to more consistency naming. - dbschema_{db_module_name) targets - stringparam db set to module name --- Modified: cmake/dbschema.cmake Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/ccad04cc13b1c5695aded8ee02181f1… Patch: https://github.com/kamailio/kamailio/commit/ccad04cc13b1c5695aded8ee02181f1…

1 0

[kamailio/kamailio] MAR callback is not executed after a MAR request is sent (ims _auth module) (Issue #4205)
by Amin Nazari 20 May '25

20 May '25

amnapa created an issue (kamailio/kamailio#4205) ### Description Using sCSCF sample found [here](https://github.com/kamailio/kamailio/blob/master/misc/examples/ims/sc…, after calling ims_www_challenge in REGISTER route block and sending a Diameter MAR request, the control is never passed to REG_MAR_REPLY route block and debug messages within REG_MAR_REPLY are not logged. This is not the case with REG_SAR_REPLY and PRE_REG_SAR_REPLY, those blocks are executed as expected. ``` ###################################################################### # Route for handling Registrations: ###################################################################### route[REGISTER] { xlog("ALGORITHM IS [$aa] and User-Agent is [$ua]\n"); $var(alg) = $aa; if ($aa == $null) { $var(alg) = "MD5"; #force to MD5 for zoiper.... non-ims } #!ifdef WITH_AUTH if (!ims_www_authenticate("$td")) { #!else if (($var(alg) == "MD5") && (!ims_www_authenticate("$td"))) { #!endif if ($? == -2) { send_reply("403", "Authentication Failed"); exit; } else if ($? == -3) { send_reply("400", "Bad Request"); exit; } else if ($? == -9) { xlog("L_DBG", "Authentication re-sync requested\n"); ims_www_resync_auth("REG_RESYNC_REPLY", "$td"); exit; } else { #user has not been authenticated. Lets send a challenge via 401 Unauthorized xlog("L_DBG", "About to challenge! auth_ims\n"); ims_www_challenge("REG_MAR_REPLY", "$td", "$var(alg)"); exit; } } else { xlog("L_DBG", "Auth succeeded\n"); # We need to check if this user is registered or not if (!impu_registered("location")) { xlog("L_ERR", "Not REGISTERED\n"); save("PRE_REG_SAR_REPLY", "location"); exit; } else { isc_match_filter_reg("1", "location"); save("REG_SAR_REPLY", "location"); exit; } } } route[REG_MAR_REPLY] { #this is async so to know status we have to check the reply avp xlog("L_DBG", "maa_return code is $avp(s:maa_return_code)\n"); switch ($avp(s:maa_return_code)){ case 1: #success xlog("L_DBG", "MAR success - 401/407 response sent from module\n"); break; case -1: #failure xlog("L_ERR", "MAR failure - error response sent from module\n"); break; case -2: #error xlog("L_ERR", "MAR error - sending error response now\n"); send_reply("500", "MAR failed"); break; default: xlog("L_ERR", "Unknown return code from MAR, value is [$avp(s:maa_return_code)]\n"); send_reply("500", "Unknown response code from MAR"); break; } exit; } ``` ### Troubleshooting #### Reproduction  #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages ``` ERROR: *** cfgtrace:request_route=[REGISTER] c=[/usr/local/etc/kamailio/kamailio.cfg] l=712 a=27 n=ims_www_challenge DEBUG: ims_auth [authorize.c:290]: challenge(): Looking for route block [REG_MAR_REPLY] INFO: ims_auth [cxdx_mar.c:76]: create_return_code(): created AVP successfully : [maa_return_code] - [-2] DEBUG: ims_auth [authorize.c:314]: challenge(): Need to challenge for realm [ims.mnc072.mcc432.3gppnetwork.org] DEBUG: ims_auth [authorize.c:321]: challenge(): Checking if REGISTER is authorized for realm [ims.mnc072.mcc432.3gppnetwork.org]... DEBUG: ims_auth [authorize.c:1446]: get_auth_userdata(): Searching auth_userdata for IMPU sip:bob@ims.mnc072.mcc432.3gppnetwork.org (Hash 295) DEBUG: ims_auth [authorize.c:1455]: get_auth_userdata(): Found auth_userdata DEBUG: ims_auth [authorize.c:1061]: get_auth_vector(): looping through AV status is 3 and were looking for 0 DEBUG: tm [t_lookup.c:1343]: t_newtran(): msg (0x7f8d3f410cb0) id=1/11 global id=1/11 T start=(nil) DEBUG: tm [t_lookup.c:498]: t_lookup_request(): start searching: hash=21555, isACK=0 DEBUG: tm [t_lookup.c:456]: matching_3261(): RFC3261 transaction matching failed - via branch [z9hG4bK3345.d6f2aff0d9192c2647aca3baea62cf94.1] DEBUG: tm [t_lookup.c:681]: t_lookup_request(): no transaction found DEBUG: tm [t_hooks.c:337]: run_reqin_callbacks_internal(): trans=0x7f8d2bff4520, callback type 1, id 0 entered DEBUG: ims_auth [authorize.c:457]: challenge(): Suspending SIP TM transaction DEBUG: ims_auth [authorize.c:1526]: multimedia_auth_request(): Sending MAR DEBUG: ims_auth [cxdx_mar.c:572]: cxdx_send_mar(): Successfully sent async diameter DEBUG: tm [t_lookup.c:1628]: t_lookup_ident_filter(): transaction found INFO: ims_auth [cxdx_avp.c:134]: cxdx_get_avp(): cxdx_get_experimental_result_code: Failed finding avp (avp_code = 297, vendor_id = 0) DEBUG: ims_auth [authorize.c:1557]: pack_challenge(): setting QOP str used is [, qop="auth"] DEBUG: ims_auth [authorize.c:1559]: pack_challenge(): QOP str used is [, qop="auth"] DEBUG: tm [t_reply.c:1660]: cleanup_uac_timers(): RETR/FR timers reset DEBUG: tm [t_reply.c:595]: _reply_light(): reply sent out. buf=0x7f8d3f4120b8: SIP/2.0 401 Unauthor..., shmem=0x7f8d2bff9288: SIP/2.0 401 Unauthor DEBUG: tm [t_reply.c:606]: _reply_light(): finished DEBUG: ims_auth [authorize.c:1446]: get_auth_userdata(): Searching auth_userdata for IMPU sip:bob@ims.mnc072.mcc432.3gppnetwork.org (Hash 295) DEBUG: ims_auth [authorize.c:1455]: get_auth_userdata(): Found auth_userdata DEBUG: ims_auth [authorize.c:1679]: add_auth_vector(): Adding auth_vector (status 1) for IMPU sip:bob@ims.mnc072.mcc432.3gppnetwork.org / IMPI bob(a)ims.mnc072.mcc432.3gppnetwork.org (Hash 295) DEBUG: ims_auth [cxdx_mar.c:483]: async_cdp_callback(): DBG:UAR Async CDP callback: ... Done resuming transaction INFO: ims_auth [cxdx_mar.c:76]: create_return_code(): created AVP successfully : [maa_return_code] - [1] DEBUG: ims_auth [cxdx_mar.c:495]: async_cdp_callback(): Destroying current transaction prevented! DEBUG: tm [t_lookup.c:1620]: t_lookup_ident_filter(): transaction in terminated phase - skipping ERROR: tm [t_suspend.c:196]: t_continue_helper(): active transaction not found DEBUG: ims_auth [cxdx_mar.c:84]: free_saved_transaction_data(): Freeing saved transaction data: async ``` #### SIP Traffic ``` (paste your sip traffic here) ``` ### Possible Solutions The issue is related to ims_auth module, in [cxdx_mar.c ](https://github.com/kamailio/kamailio/blob/master/src/modules/ims_auth/cxdx_mar.c). within async_cdp_callback function, if I replace: ``` tmb.t_continue(data->tindex, data->tlabel, data->act); ```` with the following: ``` tmb.t_continue_skip_timer(data->tindex, data->tlabel, data->act); ``` the issue will be fixed and the control will be passed to REG_MAR_REPLY route block. In fact, in ims_registrar_scscf module, in [cxdx_sar.c ](https://github.com/kamailio/kamailio/blob/master/src/modules/ims_registrar_scscf/cxdx_sar.c) file, the t_continue_skip_timer is called instead of t_continue, if I replace it with t_continue the same issue happens for SAR callbacks. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.1.0-dev0 (x86_64/linux) c858ce-dirty flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c858ce -dirty compiled on 10:33:37 Apr 5 2025 with gcc 11.4.0 ``` * **Operating System**: ``` Distributor ID: Ubuntu Description: Ubuntu 22.04.5 LTS Release: 22.04 Codename: jammy Linux kuber-worker 5.15.0-133-generic #144-Ubuntu SMP Fri Feb 7 20:47:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4205 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4205(a)github.com>

2 3

TSILO With Multiple Devices Over WebSocket
by bhavikpatel14388＠gmail.com 20 May '25

20 May '25

Hello, I am using exact same logic for which is define in this documentation and single device its working fine. https://www.kamailio.org/events/2015-KamailioWorld/Day2/20-Federico.Cabiddu… But seems like if multiple registration with same extension, like if extension 102 logged in mobile as well web. If web device registered and mobile is not registered with wss, then the Current transaction is not going to suspend due to its consider like there is only one location entry on location table.so only one Invite send to web and mobile its going to send notification but never get Invite, even it is going to register using push notification. So below LOCATION function should be called and sending invite to registered extension and should be waiting for Other device as well. But in my case its consider like only one device is there and transaction is not suspending. Could you check and suggest me which part of code need to improve to so i can make it working with registered device with parallel forking for adding new branch. Here is my code. modparam("registrar", "max_contacts", 10) modparam("registrar", "append_branches", 1) modparam("registrar", "use_path", 1) modparam("registrar", "path_mode", 1) loadmodule "tsilo.so" modparam("tsilo", "use_domain", 1) modparam("htable", "htable", "vtp=>size=100;autoexpire=30;") # append branches or resume the transaction route[PUSHJOIN] { $var(hjoin) = 0; lock("$tU"); $var(hjoin) = $sht(vtp=>join::$tU); $var(hstored) = $sht(vtp=>stored::$tU); $sht(vtp=>join::$tU) = $null; unlock("$tU"); if ($var(hjoin)==0) { if ($var(hstored)) ts_append("location", "$tU"); return; } $var(id_index) = $(var(hjoin){s.select,0,:}{s.int}); $var(id_label) = $(var(hjoin){s.select,1,:}{s.int}); t_continue("$var(id_index)", "$var(id_label)", "INVRESUME"); } # lookup and relay after resuming transaction route[INVRESUME] { lookup("location"); xlog("L_INFO","[RESUME] rm=$rm ru=$ru du=$du \n"); t_relay(); ts_store(); $sht(vtp=>stored::$rU) = 1; $sht(vtp=>id_index::$tu) = $null; $sht(vtp=>id_label::$tu) = $null; xlog("L_INFO","stored transaction [$T(id_index):$T(id_label)] $fU => $rU\n"); } route[SUSPEND] { if ( !t_suspend() ) { xlog("L_ERROR","[SUSPEND] failed suspending trasaction [$T(id_index):$T(id_label)]\n"); send_reply("501", "Suspending error"); exit; } xlog("L_INFO","[SUSPEND] suspended transaction [$T(id_index):$T(id_label)] $fU=> $rU\n"); $sht(vtp=>join::$rU) = "" + $T(id_index) + ":" + $T(id_label); xlog("L_INFO","htable key value [$sht(vtp=>join::$rU)]\n"); } route[SENDPUSH] { $avp(platform) = $hdr(X-pn-platform); $var(headers) = "Content-Type: application/json\r\nAuthorization: Bearer 55466cc-c789-4a48-39c8-219ebaa1512f"; $var(body) = "{\"user\": \"" + $rU + "\", " + "\"platform\": \"" + $avp(platform) + "\"}"; http_client_query("https://handlepush.xxx.com/v2/phone/call/send_notification_kamalio", "$var(body)", "$var(headers)", "$var(res)"); } # User location service route[LOCATION] { if (!lookup("location")) { send_reply("100", "Trying"); xlog("L_INFO","SUSPENDING TRANASACTION $fU => $rU\n"); route(SUSPEND); } else { t_relay(); ts_store(); $sht(vtp=>stored::$rU) = 1; xlog("L_INFO","stored transaction [$T(id_index):$T(id_label)] $fU=> $rU\n"); } route(SENDPUSH); exit; } if (is_method("REGISTER") || from_uri==myself) { xlog("L_INFO", "SAVING TO LOCATIONS $si:$sp\n"); if (!save("location")) { sl_reply_error(); } route(PUSHJOIN); exit; } Can you help me to understand why parallel forking not working in this case ? Thanks

3 8

[kamailio/kamailio] ims_dialog: missing srdb1 schema definition (Issue #4100)
by Victor Seva 20 May '25

20 May '25

there's no ``kamailio-ims_dialog.xml`` at ``src/lib/srdb1/schema`` but there's a manual file created at ``utils/kamctl/mysql/ims_dialog-create.sql`` Same thing for: - ``utils/kamctl/mysql/ims_charging-create.sql`` - ``utils/kamctl/mysql/ims_usrloc_pcscf-create.sql`` - ``utils/kamctl/mysql/ims_usrloc_scscf-create.sql`` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4100 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4100(a)github.com>

3 10

git:master:068ace09: modules: readme files regenerated - textops ... [skip ci]
by Kamailio Dev 20 May '25

20 May '25

Module: kamailio Branch: master Commit: 068ace09409ef1f03bf6d617b315579cfe2a46f6 URL: https://github.com/kamailio/kamailio/commit/068ace09409ef1f03bf6d617b315579… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-20T09:31:10+02:00 modules: readme files regenerated - textops ... [skip ci] --- Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/068ace09409ef1f03bf6d617b315579… Patch: https://github.com/kamailio/kamailio/commit/068ace09409ef1f03bf6d617b315579…

1 0

git:master:0cb4dd32: dialog: split w_dlg_req_with_headers_and_content() for kemi usage
by Daniel-Constantin Mierla 20 May '25

20 May '25

Module: kamailio Branch: master Commit: 0cb4dd3282ec12cdaefca491f9ed43acd0f21bdd URL: https://github.com/kamailio/kamailio/commit/0cb4dd3282ec12cdaefca491f9ed43a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-20T09:25:09+02:00 dialog: split w_dlg_req_with_headers_and_content() for kemi usage - PR #4245 --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/0cb4dd3282ec12cdaefca491f9ed43a… Patch: https://github.com/kamailio/kamailio/commit/0cb4dd3282ec12cdaefca491f9ed43a… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 382941c9925..4539d1657e2 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -1363,19 +1363,57 @@ static int fixup_dlg_req_with_headers_and_content(void **param, int param_no) return 0; } +static int ki_dlg_req_with_headers_and_content(struct sip_msg *msg, int nside, + str *smethod, str *sheaders, str *scontent_type, str *scontent) +{ + dlg_cell_t *dlg = NULL; + + dlg = dlg_get_ctx_dialog(); + if(dlg == NULL) + return -1; + + if(nside == 1) { + if(dlg_request_within(msg, dlg, DLG_CALLER_LEG, smethod, sheaders, + scontent_type, scontent) + != 0) + goto error; + goto done; + } else if(nside == 2) { + if(dlg_request_within(msg, dlg, DLG_CALLEE_LEG, smethod, sheaders, + scontent_type, scontent) + != 0) + goto error; + goto done; + } else { + if(dlg_request_within(msg, dlg, DLG_CALLER_LEG, smethod, sheaders, + scontent_type, scontent) + != 0) + goto error; + if(dlg_request_within(msg, dlg, DLG_CALLEE_LEG, smethod, sheaders, + scontent_type, scontent) + != 0) + goto error; + goto done; + } + +done: + dlg_release(dlg); + return 1; + +error: + dlg_release(dlg); + return -1; +} + static int w_dlg_req_with_headers_and_content(struct sip_msg *msg, char *side, char *method, char *headers, char *content_type, char *content) { - dlg_cell_t *dlg = NULL; int n; str str_method = {0, 0}; str str_headers = {0, 0}; str str_content_type = {0, 0}; str str_content = {0, 0}; - dlg = dlg_get_ctx_dialog(); - if(dlg == NULL) - return -1; if(fixup_get_svalue(msg, (gparam_p)method, &str_method) != 0) { LM_ERR("unable to get Method\n"); @@ -1417,36 +1455,11 @@ static int w_dlg_req_with_headers_and_content(struct sip_msg *msg, char *side, } n = (int)(long)side; - if(n == 1) { - if(dlg_request_within(msg, dlg, DLG_CALLER_LEG, &str_method, - &str_headers, &str_content_type, &str_content) - != 0) - goto error; - goto done; - } else if(n == 2) { - if(dlg_request_within(msg, dlg, DLG_CALLEE_LEG, &str_method, - &str_headers, &str_content_type, &str_content) - != 0) - goto error; - goto done; - } else { - if(dlg_request_within(msg, dlg, DLG_CALLER_LEG, &str_method, - &str_headers, &str_content_type, &str_content) - != 0) - goto error; - if(dlg_request_within(msg, dlg, DLG_CALLEE_LEG, &str_method, - &str_headers, &str_content_type, &str_content) - != 0) - goto error; - goto done; - } -done: - dlg_release(dlg); - return 1; + return ki_dlg_req_with_headers_and_content( + msg, n, &str_method, &str_headers, &str_content_type, &str_content); error: - dlg_release(dlg); return -1; }

1 0

git:master:c1e81dfa: textops: docs for str_all_in()
by Daniel-Constantin Mierla 20 May '25

20 May '25

Module: kamailio Branch: master Commit: c1e81dfa915f5c52da83cf02cbecdcf881eb057c URL: https://github.com/kamailio/kamailio/commit/c1e81dfa915f5c52da83cf02cbecdcf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-20T09:17:00+02:00 textops: docs for str_all_in() --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c1e81dfa915f5c52da83cf02cbecdcf… Patch: https://github.com/kamailio/kamailio/commit/c1e81dfa915f5c52da83cf02cbecdcf… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index 86f02b97336..9560eb6d663 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -1955,6 +1955,29 @@ if (str_any_in("$hdr(X-Hdr)", ";',:")) { </example> </section> + <section id="textops.f.str_all_in"> + <title> + <function moreinfo="none">str_all_in(txt, clist)</function> + </title> + <para> + Return 1 (true) if all character in "clist" are found inside "txt". + Both paramters can contain variables. + </para> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>str_all_in</function> usage</title> + <programlisting format="linespecific"> +... +if (str_all_in("$hdr(X-Hdr)", ".;-")) { + # do interesting stuff here +} +... +</programlisting> + </example> + </section> + <section id="textops.f.set_body_multipart"> <title> <function moreinfo="none">set_body_multipart([txt, content_type][, boundary])</function>

1 0

git:master:1c398d31: textops: added str_all_in() function
by Daniel-Constantin Mierla 20 May '25

20 May '25

Module: kamailio Branch: master Commit: 1c398d313f5b73e7ee8cf5415b2e3045989ba385 URL: https://github.com/kamailio/kamailio/commit/1c398d313f5b73e7ee8cf5415b2e304… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-20T09:17:00+02:00 textops: added str_all_in() function - check if a group of characters is inside a string --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/1c398d313f5b73e7ee8cf5415b2e304… Patch: https://github.com/kamailio/kamailio/commit/1c398d313f5b73e7ee8cf5415b2e304… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index aee46a301a6..4a541399f18 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -142,6 +142,7 @@ static int ends_with_f(struct sip_msg *msg, char *str1, char *str2); static int str_find_f(sip_msg_t *msg, char *str1, char *str2); static int str_ifind_f(sip_msg_t *msg, char *str1, char *str2); static int str_any_in_f(sip_msg_t *msg, char *str1, char *str2); +static int str_all_in_f(struct sip_msg *msg, char *str1, char *str2); static int remove_hf_re_f(struct sip_msg *msg, char *key, char *foo); static int remove_hf_exp_f(sip_msg_t *msg, char *ematch, char *eskip); static int is_present_hf_re_f(struct sip_msg *msg, char *key, char *foo); @@ -291,6 +292,8 @@ static cmd_export_t cmds[] = { ANY_ROUTE}, {"str_any_in", (cmd_function)str_any_in_f, 2, fixup_spve_spve, 0, ANY_ROUTE}, + {"str_all_in", (cmd_function)str_all_in_f, 2, fixup_spve_spve, 0, + ANY_ROUTE}, {"is_audio_on_hold", (cmd_function)is_audio_on_hold_f, 0, 0, 0, ANY_ROUTE}, {"append_time_to_request", (cmd_function)append_time_request_f, 0, 0, 0, @@ -4630,6 +4633,47 @@ static int str_any_in_f(struct sip_msg *msg, char *str1, char *str2) return ki_str_any_in(msg, &s1, &s2); } +static int ki_str_all_in(sip_msg_t *msg, str *txt, str *clist) +{ + int i, j, f; + + if(txt == NULL || txt->len <= 0 || clist == NULL || clist->len <= 0) { + return -1; + } + + for(j = 0; j < clist->len; j++) { + f = 0; + for(i = 0; i < txt->len; i++) { + if(txt->s[i] == clist->s[j]) { + f = 1; + break; + } + } + if(f == 0) { + return -1; + } + } + + return 1; +} + +static int str_all_in_f(struct sip_msg *msg, char *str1, char *str2) +{ + str s1; + str s2; + + if(fixup_get_svalue(msg, (gparam_p)str1, &s1) != 0) { + LM_ERR("cannot get first parameter\n"); + return -8; + } + if(fixup_get_svalue(msg, (gparam_p)str2, &s2) != 0) { + LM_ERR("cannot get second parameter\n"); + return -8; + } + + return ki_str_all_in(msg, &s1, &s2); +} + static int ki_is_audio_on_hold(sip_msg_t *msg) { int sdp_session_num = 0, sdp_stream_num; @@ -5512,6 +5556,11 @@ static sr_kemi_t sr_kemi_textops_exports[] = { { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("textops"), str_init("str_all_in"), + SR_KEMIP_INT, ki_str_all_in, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("textops"), str_init("is_audio_on_hold"), SR_KEMIP_INT, ki_is_audio_on_hold, { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,

1 0

[kamailio/kamailio] cmake: Main change is the component based installation. (PR #4244)
by Xenofon Karamanos 19 May '25

19 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PRs main focus is to introduce components groups for easier building of various groups. Other main changes: - Forbid in-source builds - First draft packaging file for easier debian generation - Introduce checksymbol exists for feature detection - Since during the dev of itm more and more commits were included, I am creating a PR for easier rollback if something goes wrong. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4244 -- Commit Summary -- * cmake: Use components to install groups * cmake: Forbid in-source builds * cmake: Warning if no modules/group were selected * cmake: If BUILD_DOC options is set to ON, include doc and man targets to default target! * cmake: quote variables for expansion * cmake: Better handling of doc generation dependencies * cmake: Fix formatting according to cmake-format config file * cmake: Refactor packaging setup and improve installation paths * cmake: Fix build paths for dbschema. * cmake: Remove warning message * cmake: Add check and warning for module docs * cmake: Add missing defintion * cmake: Add some comments * cmake: Introduce CheckSymbolExists for feature detection * cmake: Remove unused groups * cmake: Fix wrong name of option * cmake: Remove unnessecary components to be consistent * cmake: Quiet fail for rabbit-mq * cmake: Remove find_package for ORTP and Mediastreamer2 libraries -- File Changes -- M CMakeLists.txt (23) M cmake/compiler-specific.cmake (6) A cmake/db_files.cmake (51) A cmake/dbschema.cmake (117) A cmake/deb-packaging.cmake (18) M cmake/defs.cmake (51) M cmake/groups.cmake (179) M cmake/modules-docs.cmake (144) M cmake/os-specific.cmake (8) M cmake/os-specific/darwin.cmake (8) M cmake/os-specific/dragonfly.cmake (12) M cmake/os-specific/freebsd.cmake (8) M cmake/os-specific/linux.cmake (14) M src/CMakeLists.txt (79) M src/core/CMakeLists.txt (2) M src/modules/CMakeLists.txt (46) M src/modules/app_perl/CMakeLists.txt (10) M src/modules/auth_radius/CMakeLists.txt (3) M src/modules/crypto/CMakeLists.txt (2) M src/modules/db_berkeley/CMakeLists.txt (7) M src/modules/db_mongodb/CMakeLists.txt (25) M src/modules/db_mysql/CMakeLists.txt (7) M src/modules/db_oracle/CMakeLists.txt (7) M src/modules/db_postgres/CMakeLists.txt (7) M src/modules/db_redis/CMakeLists.txt (3) M src/modules/db_sqlite/CMakeLists.txt (7) M src/modules/db_text/CMakeLists.txt (13) M src/modules/dnssec/CMakeLists.txt (2) M src/modules/kazoo/CMakeLists.txt (4) M src/modules/rabbitmq/CMakeLists.txt (3) M src/modules/rtp_media_server/CMakeLists.txt (21) M src/modules/snmpstats/CMakeLists.txt (3) M src/modules/tls/CMakeLists.txt (2) M src/modules/xhttp_pi/CMakeLists.txt (18) M utils/db_berkeley/CMakeLists.txt (1) M utils/kamcmd/CMakeLists.txt (13) M utils/kamctl/CMakeLists.txt (293) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4244.patch https://github.com/kamailio/kamailio/pull/4244.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4244 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4244(a)github.com>

1 9

git:master:6753acd0: cmake: Centralize dbschema generation
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 6753acd06859e5e5e34a7981765c4bcdbeb66897 URL: https://github.com/kamailio/kamailio/commit/6753acd06859e5e5e34a7981765c4bc… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-05-19T16:58:32+03:00 cmake: Centralize dbschema generation - Do not define the targets if xsltproc is missing --- Modified: cmake/dbschema.cmake Modified: src/CMakeLists.txt Modified: src/modules/db_berkeley/CMakeLists.txt Modified: src/modules/db_mongodb/CMakeLists.txt Modified: src/modules/db_mysql/CMakeLists.txt Modified: src/modules/db_oracle/CMakeLists.txt Modified: src/modules/db_postgres/CMakeLists.txt Modified: src/modules/db_redis/CMakeLists.txt Modified: src/modules/db_sqlite/CMakeLists.txt Modified: src/modules/db_text/CMakeLists.txt Modified: src/modules/xhttp_pi/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/6753acd06859e5e5e34a7981765c4bc… Patch: https://github.com/kamailio/kamailio/commit/6753acd06859e5e5e34a7981765c4bc…

1 0

git:master:f9bbac51: cmake: Fix wrong name of option
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: f9bbac5167e98952ef5b1764c3f2c4b6939fd25d URL: https://github.com/kamailio/kamailio/commit/f9bbac5167e98952ef5b1764c3f2c4b… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-05-19T16:58:32+03:00 cmake: Fix wrong name of option --- Modified: cmake/dbschema.cmake --- Diff: https://github.com/kamailio/kamailio/commit/f9bbac5167e98952ef5b1764c3f2c4b… Patch: https://github.com/kamailio/kamailio/commit/f9bbac5167e98952ef5b1764c3f2c4b… --- diff --git a/cmake/dbschema.cmake b/cmake/dbschema.cmake index db7ff430d92..eac256f17e2 100644 --- a/cmake/dbschema.cmake +++ b/cmake/dbschema.cmake @@ -19,8 +19,8 @@ else() add_custom_target(dbschema_clean COMMENT "Cleaning schemas for all dbs...") endif() - option(XSLT_VALIDATE, "Enable schema validation during XSL transformations" ON) - option(XSLT_VERBOSE, "Enable verbose output for XSL transformations" OFF) + option(XSLT_VALIDATE "Enable schema validation during XSL transformations" ON) + option(XSLT_VERBOSE "Enable verbose output for XSL transformations" OFF) set(XSLTPROC_FLAGS --xinclude) if(NOT ${XSLT_VALIDATE})

1 0

git:master:497b7d94: cmake: Add some comments
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 497b7d94b8d3575cf7399c8537e96297bcd4062b URL: https://github.com/kamailio/kamailio/commit/497b7d94b8d3575cf7399c8537e9629… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-05-19T16:58:32+03:00 cmake: Add some comments --- Modified: cmake/compiler-specific.cmake Modified: cmake/db_files.cmake Modified: cmake/dbschema.cmake Modified: cmake/os-specific.cmake Modified: src/CMakeLists.txt Modified: src/modules/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/497b7d94b8d3575cf7399c8537e9629… Patch: https://github.com/kamailio/kamailio/commit/497b7d94b8d3575cf7399c8537e9629…

1 0

git:master:782d9319: cmake: Add check and warning for module docs
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 782d93197c928f8856a7026c93aebd223c6cb682 URL: https://github.com/kamailio/kamailio/commit/782d93197c928f8856a7026c93aebd2… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-05-19T16:58:32+03:00 cmake: Add check and warning for module docs --- Modified: src/modules/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/782d93197c928f8856a7026c93aebd2… Patch: https://github.com/kamailio/kamailio/commit/782d93197c928f8856a7026c93aebd2… --- diff --git a/src/modules/CMakeLists.txt b/src/modules/CMakeLists.txt index 33948dc9f6c..dea294090a6 100644 --- a/src/modules/CMakeLists.txt +++ b/src/modules/CMakeLists.txt @@ -107,8 +107,14 @@ function(add_module_group group_name group_modules) ) # Add the module to the list of added modules set_property(GLOBAL APPEND PROPERTY ADDED_MODULES_LIST ${module_name}) - docs_add_module(${group_name} ${module_name}) - set_property(GLOBAL APPEND PROPERTY ALL_MODULE_DOC_TARGETS ${module_name}_doc) + if(NOT EXISTS ${CMAKE_SOURCE_DIR}/src/modules/${module_name}/doc/${module_name}.xml) + message(WARNING "No documentation found for module ${module_name}.") + return() + else() + docs_add_module(${group_name} ${module_name}) + set_property(GLOBAL APPEND PROPERTY ALL_MODULE_DOC_TARGETS ${module_name}_doc) + endif() + else() message(FATAL_ERROR "Module directory ${module_path} does not exist.") endif()

1 0

git:master:478ddb1f: cmake: Fix build paths for dbschema.
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 478ddb1f38817ac4730d0f499c73046be26b6907 URL: https://github.com/kamailio/kamailio/commit/478ddb1f38817ac4730d0f499c73046… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-05-19T16:58:32+03:00 cmake: Fix build paths for dbschema. - Build artifcats of dbschema should be in utils folder --- Modified: cmake/dbschema.cmake --- Diff: https://github.com/kamailio/kamailio/commit/478ddb1f38817ac4730d0f499c73046… Patch: https://github.com/kamailio/kamailio/commit/478ddb1f38817ac4730d0f499c73046… --- diff --git a/cmake/dbschema.cmake b/cmake/dbschema.cmake index 515b1048b9b..a380281a295 100644 --- a/cmake/dbschema.cmake +++ b/cmake/dbschema.cmake @@ -62,7 +62,7 @@ else() add_custom_target( dbschema_${db_name} COMMAND ${CMAKE_COMMAND} -E make_directory "${db_name_folder}" - WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} + WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl COMMENT "Creating schemas for ${db_name}" ) @@ -86,7 +86,7 @@ else() PRE_BUILD COMMAND "XML_CATALOG_FILES=${CATALOG}" ${XSLTPROC_EXECUTABLE} ${XSLTPROC_FLAGS} --stringparam dir - ${CMAKE_CURRENT_BINARY_DIR}/${db_name_folder}/${folder_suffix} --stringparam prefix + ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} --stringparam prefix ${prefix} --stringparam db ${db_name} ${xsl_file} "kamailio-${table}.xml" WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}/src/lib/srdb1/schema" COMMENT "Processing ${table} for ${db_name}" @@ -95,7 +95,8 @@ else() add_custom_target( dbschema_${db_name}_clean - COMMAND ${CMAKE_COMMAND} -E remove_directory "${CMAKE_CURRENT_BINARY_DIR}/${db_name_folder}" + COMMAND ${CMAKE_COMMAND} -E remove_directory + "${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}" COMMENT "Cleaning ${db_name} schema files" )

1 0

git:master:0550b630: cmake: Fix formatting and add some comments.
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 0550b6300703ec5536a033e1d4ba4d70ec53f83a URL: https://github.com/kamailio/kamailio/commit/0550b6300703ec5536a033e1d4ba4d7… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-05-19T16:58:32+03:00 cmake: Fix formatting and add some comments. - Remove unused replacement SRC_NAME to MAIN_NAME --- Modified: CMakeLists.txt Modified: src/CMakeLists.txt Modified: src/core/CMakeLists.txt Modified: src/modules/CMakeLists.txt Modified: src/modules/app_perl/CMakeLists.txt Modified: utils/kamcmd/CMakeLists.txt Modified: utils/kamctl/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/0550b6300703ec5536a033e1d4ba4d7… Patch: https://github.com/kamailio/kamailio/commit/0550b6300703ec5536a033e1d4ba4d7…

1 0

git:master:08bfcad2: cmake: Better handling of doc generation dependencies
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 08bfcad2c34855dbadd3c9eafda72b38a6e65a1c URL: https://github.com/kamailio/kamailio/commit/08bfcad2c34855dbadd3c9eafda72b3… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-05-19T16:58:32+03:00 cmake: Better handling of doc generation dependencies --- Modified: cmake/modules-docs.cmake Modified: src/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/08bfcad2c34855dbadd3c9eafda72b3… Patch: https://github.com/kamailio/kamailio/commit/08bfcad2c34855dbadd3c9eafda72b3…

1 0

git:master:d3f85d8a: cmake: quote variables for expansion
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: d3f85d8a3b13a444ac66b440056aee8232cbae54 URL: https://github.com/kamailio/kamailio/commit/d3f85d8a3b13a444ac66b440056aee8… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-05-19T16:58:32+03:00 cmake: quote variables for expansion --- Modified: cmake/dbschema.cmake --- Diff: https://github.com/kamailio/kamailio/commit/d3f85d8a3b13a444ac66b440056aee8… Patch: https://github.com/kamailio/kamailio/commit/d3f85d8a3b13a444ac66b440056aee8… --- diff --git a/cmake/dbschema.cmake b/cmake/dbschema.cmake index c70e6aff79e..515b1048b9b 100644 --- a/cmake/dbschema.cmake +++ b/cmake/dbschema.cmake @@ -85,7 +85,7 @@ else() TARGET dbschema_${db_name} PRE_BUILD COMMAND - XML_CATALOG_FILES=${CATALOG} ${XSLTPROC_EXECUTABLE} ${XSLTPROC_FLAGS} --stringparam dir + "XML_CATALOG_FILES=${CATALOG}" ${XSLTPROC_EXECUTABLE} ${XSLTPROC_FLAGS} --stringparam dir ${CMAKE_CURRENT_BINARY_DIR}/${db_name_folder}/${folder_suffix} --stringparam prefix ${prefix} --stringparam db ${db_name} ${xsl_file} "kamailio-${table}.xml" WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}/src/lib/srdb1/schema"

1 0

git:master:3c9f6077: cmake: Use components to install groups
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 3c9f60772e04edbc853d8162543b3b0af7f46217 URL: https://github.com/kamailio/kamailio/commit/3c9f60772e04edbc853d8162543b3b0… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-05-19T16:58:32+03:00 cmake: Use components to install groups - kamailio-core for anything related to core - group_name as defined in groups.cmake - Preferably use K-variants instead of DEFAULT,STANDARD - Refactor kamctl and dbschema CMakLists for component based installation --- Added: cmake/db_files.cmake Added: cmake/dbschema.cmake Modified: cmake/modules-docs.cmake Modified: src/CMakeLists.txt Modified: src/modules/CMakeLists.txt Modified: src/modules/app_perl/CMakeLists.txt Modified: src/modules/auth_radius/CMakeLists.txt Modified: src/modules/db_berkeley/CMakeLists.txt Modified: src/modules/db_mongodb/CMakeLists.txt Modified: src/modules/db_mysql/CMakeLists.txt Modified: src/modules/db_oracle/CMakeLists.txt Modified: src/modules/db_postgres/CMakeLists.txt Modified: src/modules/db_redis/CMakeLists.txt Modified: src/modules/db_sqlite/CMakeLists.txt Modified: src/modules/db_text/CMakeLists.txt Modified: src/modules/snmpstats/CMakeLists.txt Modified: src/modules/tls/CMakeLists.txt Modified: src/modules/xhttp_pi/CMakeLists.txt Modified: utils/db_berkeley/CMakeLists.txt Modified: utils/kamcmd/CMakeLists.txt Modified: utils/kamctl/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/3c9f60772e04edbc853d8162543b3b0… Patch: https://github.com/kamailio/kamailio/commit/3c9f60772e04edbc853d8162543b3b0…

1 0

git:master:8cc60c03: cmake: If BUILD_DOC options is set to ON, include doc and man targets to default target!
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 8cc60c03a25a2a9b1f7fbe93e08c21165336ad0a URL: https://github.com/kamailio/kamailio/commit/8cc60c03a25a2a9b1f7fbe93e08c211… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T11:11:11Z cmake: If BUILD_DOC options is set to ON, include doc and man targets to default target! --- Modified: src/CMakeLists.txt Modified: src/modules/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/8cc60c03a25a2a9b1f7fbe93e08c211… Patch: https://github.com/kamailio/kamailio/commit/8cc60c03a25a2a9b1f7fbe93e08c211… --- diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index c9933ab7ede..724f964e64f 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -73,6 +73,12 @@ else() ${CMAKE_CURRENT_BINARY_DIR}/core/cfg.tab.h PROPERTIES GENERATED TRUE ) endif() + +if(BUILD_DOC) + set(docs_in_all_target ALL) +else() + set(docs_in_all_target "") +endif() # ----------------------- # ----------------------- @@ -159,8 +165,9 @@ add_custom_command( ) add_custom_target( - man DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${MAIN_NAME}.8 - ${CMAKE_CURRENT_BINARY_DIR}/${MAIN_NAME}.cfg.5 + man + ${docs_in_all_target} + DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${MAIN_NAME}.8 ${CMAKE_CURRENT_BINARY_DIR}/${MAIN_NAME}.cfg.5 ) add_dependencies(man kamctl_man) add_dependencies(man kamcmd_man) diff --git a/src/modules/CMakeLists.txt b/src/modules/CMakeLists.txt index 0decc1865ab..430e88af1f9 100644 --- a/src/modules/CMakeLists.txt +++ b/src/modules/CMakeLists.txt @@ -163,6 +163,7 @@ get_property(ALL_MODULE_DOC_TARGETS GLOBAL PROPERTY ALL_MODULE_DOC_TARGETS) # Add a kamailio_docs target that depends on all module documentation targets add_custom_target( kamailio_docs + ${docs_in_all_target} DEPENDS ${ALL_MODULE_DOC_TARGETS} COMMENT "Generating Kamailio documentation" )

1 0

git:master:42e1a9c3: cmake: Remove find_package for ORTP and Mediastreamer2 libraries
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 42e1a9c3c5df65cae8a5f559f6fe47a6de5f6fac URL: https://github.com/kamailio/kamailio/commit/42e1a9c3c5df65cae8a5f559f6fe47a… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T10:48:51Z cmake: Remove find_package for ORTP and Mediastreamer2 libraries - Use pkg-config instead because their cmake configs are not up to standard and complicates things --- Modified: src/modules/rtp_media_server/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/42e1a9c3c5df65cae8a5f559f6fe47a… Patch: https://github.com/kamailio/kamailio/commit/42e1a9c3c5df65cae8a5f559f6fe47a… --- diff --git a/src/modules/rtp_media_server/CMakeLists.txt b/src/modules/rtp_media_server/CMakeLists.txt index 59a1d868d34..15114891902 100644 --- a/src/modules/rtp_media_server/CMakeLists.txt +++ b/src/modules/rtp_media_server/CMakeLists.txt @@ -2,18 +2,15 @@ file(GLOB MODULE_SOURCES "*.c") add_library(${module_name} SHARED ${MODULE_SOURCES}) -find_package(ortp QUIET) -if(NOT ortp_FOUND) - find_package(PkgConfig REQUIRED) - pkg_check_modules(ortp REQUIRED IMPORTED_TARGET ortp) - add_library(ortp ALIAS PkgConfig::ortp) -endif() +find_package(PkgConfig REQUIRED) -find_package(mediastreamer2 QUIET) -if(NOT mediastreamer2_FOUND) - find_package(PkgConfig REQUIRED) - pkg_check_modules(mediastreamer2 REQUIRED IMPORTED_TARGET mediastreamer) - add_library(mediastreamer2 ALIAS PkgConfig::mediastreamer2) -endif() +# ortp and mediastreamer2 do have cmake support on newer version but +# is not up to standard and complicates things. +# So we use pkg-config to find them. +pkg_check_modules(ortp REQUIRED IMPORTED_TARGET ortp) +add_library(ortp ALIAS PkgConfig::ortp) + +pkg_check_modules(mediastreamer2 REQUIRED IMPORTED_TARGET mediastreamer) +add_library(mediastreamer2 ALIAS PkgConfig::mediastreamer2) target_link_libraries(${module_name} PRIVATE ortp mediastreamer2)

1 0

git:master:1c4de241: cmake: Quiet fail for rabbit-mq
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 1c4de2410f8f5d3f600c96ac823c88911c58ae22 URL: https://github.com/kamailio/kamailio/commit/1c4de2410f8f5d3f600c96ac823c889… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T10:48:36Z cmake: Quiet fail for rabbit-mq - Remove extra find_package(pkgconfig) - Remove required version --- Modified: src/modules/kazoo/CMakeLists.txt Modified: src/modules/rabbitmq/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/1c4de2410f8f5d3f600c96ac823c889… Patch: https://github.com/kamailio/kamailio/commit/1c4de2410f8f5d3f600c96ac823c889… --- diff --git a/src/modules/kazoo/CMakeLists.txt b/src/modules/kazoo/CMakeLists.txt index 44b2e0b3c0e..d05ff75464c 100644 --- a/src/modules/kazoo/CMakeLists.txt +++ b/src/modules/kazoo/CMakeLists.txt @@ -18,7 +18,8 @@ pkg_check_modules(json-c REQUIRED IMPORTED_TARGET json-c) add_library(json-c::json-c ALIAS PkgConfig::json-c) # endif() -find_package(rabbitmq-c 0.13) +# rabbitmq provides cmake support for versions 0.13 and above. +find_package(rabbitmq-c QUIET) if(NOT rabbitmq-c_FOUND) message(STATUS "rabbitmq-c not found. looking with pkg-config") find_package(PkgConfig REQUIRED) @@ -26,7 +27,6 @@ if(NOT rabbitmq-c_FOUND) add_library(rabbitmq::rabbitmq ALIAS PkgConfig::rabbitmq-c) endif() -find_package(PkgConfig REQUIRED) pkg_check_modules(UUID REQUIRED IMPORTED_TARGET uuid) add_library(uuid::uuid ALIAS PkgConfig::UUID) diff --git a/src/modules/rabbitmq/CMakeLists.txt b/src/modules/rabbitmq/CMakeLists.txt index 9ad3b4c8112..e9bcef86b58 100644 --- a/src/modules/rabbitmq/CMakeLists.txt +++ b/src/modules/rabbitmq/CMakeLists.txt @@ -2,7 +2,8 @@ file(GLOB MODULE_SOURCES "*.c") add_library(${module_name} SHARED ${MODULE_SOURCES}) -find_package(rabbitmq-c 0.13 QUIET) +# rabbitmq provides cmake support for versions 0.13 and above. +find_package(rabbitmq-c QUIET) if(NOT rabbitmq-c_FOUND) message(STATUS "rabbitmq-c not found. looking with pkg-config") find_package(PkgConfig REQUIRED)

1 0

git:master:898f680d: cmake: Remove unnessecary components to be consistent
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 898f680d85b3e558038b41a14fa6f2ebca05bc94 URL: https://github.com/kamailio/kamailio/commit/898f680d85b3e558038b41a14fa6f2e… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T10:48:24Z cmake: Remove unnessecary components to be consistent --- Modified: src/modules/crypto/CMakeLists.txt Modified: src/modules/dnssec/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/898f680d85b3e558038b41a14fa6f2e… Patch: https://github.com/kamailio/kamailio/commit/898f680d85b3e558038b41a14fa6f2e… --- diff --git a/src/modules/crypto/CMakeLists.txt b/src/modules/crypto/CMakeLists.txt index 63d56fb6a8e..a111e1f2799 100644 --- a/src/modules/crypto/CMakeLists.txt +++ b/src/modules/crypto/CMakeLists.txt @@ -2,6 +2,6 @@ file(GLOB MODULE_SOURCES "*.c") add_library(${module_name} SHARED ${MODULE_SOURCES}) -find_package(OpenSSL REQUIRED COMPONENTS SSL Crypto) +find_package(OpenSSL REQUIRED) target_link_libraries(${module_name} PRIVATE OpenSSL::SSL OpenSSL::Crypto) diff --git a/src/modules/dnssec/CMakeLists.txt b/src/modules/dnssec/CMakeLists.txt index 82abef707b1..3177aff9a2f 100644 --- a/src/modules/dnssec/CMakeLists.txt +++ b/src/modules/dnssec/CMakeLists.txt @@ -2,7 +2,7 @@ file(GLOB MODULE_SOURCES "*.c") add_library(${module_name} SHARED ${MODULE_SOURCES}) -find_package(OpenSSL REQUIRED COMPONENTS SSL Crypto) +find_package(OpenSSL REQUIRED) find_package(Threads REQUIRED) # TODO: library libval not foud on recent distributions: whichi library is sres?

1 0

git:master:85b821b4: cmake: Remove unused groups
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 85b821b4b6e6cfaa5495d39bcd3ef2e1b939b499 URL: https://github.com/kamailio/kamailio/commit/85b821b4b6e6cfaa5495d39bcd3ef2e… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T10:47:54Z cmake: Remove unused groups --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/85b821b4b6e6cfaa5495d39bcd3ef2e… Patch: https://github.com/kamailio/kamailio/commit/85b821b4b6e6cfaa5495d39bcd3ef2e… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index 96a16979de8..d71e60318a0 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -483,37 +483,6 @@ set(MODULE_GROUP_COMMON ${MOD_LIST_TLSDEPS} ) -# For db use (db modules, excluding drivers) module_group_db=$(mod_list_db) -set(MODULE_GROUP_DB ${MOD_LIST_DB}) - -# For mysql module_group_mysql_driver=$(mod_list_mysql) -# module_group_mysql=$(module_group_mysql_driver) $(module_group_db) -set(MODULE_GROUP_MYSQL_DRIVER ${MOD_LIST_MYSQL}) -set(MODULE_GROUP_MYSQL ${MODULE_GROUP_MYSQL_DRIVER} ${MODULE_GROUP_DB}) - -# For postgress module_group_postgres_driver=$(mod_list_postgres) -# module_group_postgres=$(module_group_postgres_driver) $(module_group_db) -set(MODULE_GROUP_POSTGRES_DRIVER ${MOD_LIST_POSTGRES}) -set(MODULE_GROUP_POSTGRES ${MODULE_GROUP_POSTGRES_DRIVER} ${MODULE_GROUP_DB}) - -# For sqlite module_group_sqlite_driver=$(mod_list_sqlite) -# module_group_sqlite=$(module_group_sqlite_driver) $(module_group_db) -set(MODULE_GROUP_SQLITE_DRIVER ${MOD_LIST_SQLITE}) -set(MODULE_GROUP_SQLITE ${MODULE_GROUP_SQLITE_DRIVER} ${MODULE_GROUP_DB}) - -# For radius -set(MODULE_GROUP_RADIUS ${MODULE_LIST_RADIUS}) - -# For presence kamailio modules -set(MODULE_GROUP_PRESENCE ${MOD_LIST_PRESENCE}) - -# For cassandra -set(MODULE_GROUP_CASSANDRA_DRIVER ${MODULE_LIST_CASSANDRA}) -set(MODULE_GROUP_CASSANDRA ${MODULE_GROUP_CASSANDRA_DRIVER} ${MODULE_GROUP_DB}) - -# For all modules not compiled by default -# list(FILTER MOD_LIST_ALL EXCLUDE REGEX "${MODULE_GROUP_DEFAULT}") - # for all protocols (excl. local ones such as unix, tcp, etc.) set(AVAILABLE_GROUPS ALL DEFAULT STANDARD COMMON)

1 0

git:master:165f2cd3: cmake: Add missing defintion
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 165f2cd3c2e1197b8d1986cbc2784a24c02e06e9 URL: https://github.com/kamailio/kamailio/commit/165f2cd3c2e1197b8d1986cbc2784a2… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T10:47:24Z cmake: Add missing defintion --- Modified: cmake/defs.cmake --- Diff: https://github.com/kamailio/kamailio/commit/165f2cd3c2e1197b8d1986cbc2784a2… Patch: https://github.com/kamailio/kamailio/commit/165f2cd3c2e1197b8d1986cbc2784a2… --- diff --git a/cmake/defs.cmake b/cmake/defs.cmake index 6ec6ac59b72..7fa11e89093 100644 --- a/cmake/defs.cmake +++ b/cmake/defs.cmake @@ -108,6 +108,7 @@ option(CORE_TLS "CORE_TLS" OFF) if(${CORE_TLS}) set(RELEASE "${RELEASE}-tls") set(TLS_HOOKS OFF) + target_compile_definitions(common INTERFACE CORE_TLS) else() set(TLS_HOOKS ON) endif()

1 0

git:master:549643ec: cmake: Remove warning message
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 549643ec1e283b07e9fae274b6ed923065ba46e0 URL: https://github.com/kamailio/kamailio/commit/549643ec1e283b07e9fae274b6ed923… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T10:44:40Z cmake: Remove warning message --- Modified: src/modules/snmpstats/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/549643ec1e283b07e9fae274b6ed923… Patch: https://github.com/kamailio/kamailio/commit/549643ec1e283b07e9fae274b6ed923… --- diff --git a/src/modules/snmpstats/CMakeLists.txt b/src/modules/snmpstats/CMakeLists.txt index 0fc68b2c8df..fdcbe151d41 100644 --- a/src/modules/snmpstats/CMakeLists.txt +++ b/src/modules/snmpstats/CMakeLists.txt @@ -10,6 +10,6 @@ target_link_libraries(${module_name} PRIVATE NETSNMP::NETSNMP) install( DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/mibs - DESTINATION ${CMAKE_INSTALL_DATADIR}/snmp/ + DESTINATION ${CMAKE_INSTALL_DATADIR}/snmp OPTIONAL )

1 0

git:master:cf8cdb99: cmake: Warning if no modules/group were selected
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: cf8cdb99355e19a30460229633eaf087717ee44d URL: https://github.com/kamailio/kamailio/commit/cf8cdb99355e19a30460229633eaf08… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T08:15:11Z cmake: Warning if no modules/group were selected --- Modified: src/modules/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/cf8cdb99355e19a30460229633eaf08… Patch: https://github.com/kamailio/kamailio/commit/cf8cdb99355e19a30460229633eaf08… --- diff --git a/src/modules/CMakeLists.txt b/src/modules/CMakeLists.txt index cc303f0bb88..0decc1865ab 100644 --- a/src/modules/CMakeLists.txt +++ b/src/modules/CMakeLists.txt @@ -149,8 +149,14 @@ message(STATUS "Modules to be built: ${ADDED_MODULES_LIST}") # TODO: Comment is not showing. probably a bug in CMAKE # https://gitlab.kitware.com/cmake/cmake/-/issues/26571 add_custom_target(modules COMMENT "Building modules") -add_dependencies(modules ${ADDED_MODULES_LIST}) - +if(NOT ADDED_MODULES_LIST) + message( + WARNING + "No modules to build. Did you forget to add a module group or include module?" + ) +else() + add_dependencies(modules ${ADDED_MODULES_LIST}) +endif() get_property(ALL_MODULE_DOC_TARGETS GLOBAL PROPERTY ALL_MODULE_DOC_TARGETS) # message(STATUS "ALL_MODULE_DOC_TARGETS: ${ALL_MODULE_DOC_TARGETS}")

1 0

git:master:0afea1fd: cmake: Forbid in-source builds
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 0afea1fd170a79d3f260c18a293bac1ce8fd8527 URL: https://github.com/kamailio/kamailio/commit/0afea1fd170a79d3f260c18a293bac1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T08:14:54Z cmake: Forbid in-source builds --- Modified: CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/0afea1fd170a79d3f260c18a293bac1… Patch: https://github.com/kamailio/kamailio/commit/0afea1fd170a79d3f260c18a293bac1… --- diff --git a/CMakeLists.txt b/CMakeLists.txt index 6d68b5da980..22ee9a8e3a2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -10,6 +10,17 @@ project( HOMEPAGE_URL "https://www.kamailio.org" ) +# ---- Include guards ---- + +if(PROJECT_SOURCE_DIR STREQUAL PROJECT_BINARY_DIR) + message( + FATAL_ERROR + "In-source builds not allowed. Please make a new directory (called a build directory) \ +and run CMake again accordingly.") +endif() + +# ---- Project settings ---- + # Set the version number set(EXTRAVERSION "-dev1") set(RELEASE "${PROJECT_VERSION}${EXTRAVERSION}")

1 0

[kamailio/kamailio] generate rpm packages using github actions (PR #4194)
by sergey-safarov 17 May '25

17 May '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description I have refactored the rpm packaging and am now using the GitHub actions. Now `tar.gz` archive with rpm packages, source rpm and deps rpm files attached to the release message like. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4194 -- Commit Summary -- * generate rpm packages using github actions -- File Changes -- A .github/workflows/rpm.yml (57) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4194.patch https://github.com/kamailio/kamailio/pull/4194.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4194 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4194(a)github.com>

2 5

git:master:afa2d017: github: generate rpm packages
by Victor Seva 17 May '25

17 May '25

Module: kamailio Branch: master Commit: afa2d017e3b5a1f5a776935767e485c1158be461 URL: https://github.com/kamailio/kamailio/commit/afa2d017e3b5a1f5a776935767e485c… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-17T20:41:05+02:00 github: generate rpm packages --- Added: .github/workflows/rpm.yml --- Diff: https://github.com/kamailio/kamailio/commit/afa2d017e3b5a1f5a776935767e485c… Patch: https://github.com/kamailio/kamailio/commit/afa2d017e3b5a1f5a776935767e485c… --- diff --git a/.github/workflows/rpm.yml b/.github/workflows/rpm.yml new file mode 100644 index 00000000000..0d890b63a8c --- /dev/null +++ b/.github/workflows/rpm.yml @@ -0,0 +1,89 @@ +--- +name: build_rpm +'on': + schedule: + - cron: '41 6 * * 0' + push: + tags: + - '[0-9]+.[0-9]+.[0-9]+' +jobs: + # is required nightly build? + # More info at https://stackoverflow.com/questions/63014786/how-to-schedule-a-github-actio… + # looking commit_id of the last successful daily build + check: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - uses: octokit/request-action(a)v2.x + id: check_last_run + with: + route: GET /repos/{owner}/{repo}/actions/workflows/rpm.yml/runs?per_page=1&status=success + owner: ${{ github.repository_owner }} + repo: kamailio + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Show last execution info + run: | + echo "Last daily build: ${{ fromJson(steps.check_last_run.outputs.data).workflow_runs[0].head_sha }}" + + outputs: + last_sha: ${{ fromJson(steps.check_last_run.outputs.data).workflow_runs[0].head_sha }} + + native: + needs: [check] + if: needs.check.outputs.last_sha != github.sha + strategy: + matrix: + os: + - centos-10 + - rhel-10 + - centos-9 + - rhel-9 + - centos-8 + - rhel-8 + runner: + - ubuntu-latest + - ubuntu-24.04-arm + runs-on: ${{ matrix.runner }} + permissions: + contents: write + steps: + - name: checkout sources + uses: actions/checkout@v4 + + - name: print commit info and init hosttype var + id: init + run: | + echo ${{ github.sha }} + echo "hosttype=${HOSTTYPE}" >> $GITHUB_OUTPUT + + - name: build rpm files + uses: addnab/docker-run-action@v3 + with: + image: safarov/kamailio-builder:${{ matrix.os }} + options: -v ${{ github.workspace }}:/usr/src/kamailio + run: | + cd /usr/src/kamailio + make cfg + make -C pkg/kamailio src.rpm + rpmbuild -ra /usr/src/kamailio/kamailio*.src.rpm + cp -R /deps ~/rpmbuild/RPMS + mv ~/rpmbuild/SRPMS/* ~/rpmbuild/RPMS + mv ~/rpmbuild/RPMS . + tar czf kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm.tar.gz RPMS + + - name: Push artifacts + uses: actions/upload-artifact@v4 + if: "! startsWith(github.ref, 'refs/tags/')" + with: + name: kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm + path: | + RPMS/* + + - name: Release + uses: softprops/action-gh-release@v2 + if: "startsWith(github.ref, 'refs/tags/')" + with: + files: | + kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm.tar.gz

1 0

[kamailio/kamailio] ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c (PR #4206)
by Amin Nazari 17 May '25

17 May '25

- fixed log message in MAR Async CDP callback - fixed executing cfg_action after sending MAR Diameter request - cfg_action is the callback parameter of the ims_www_challenge function   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #4205 (replace XXXX with an open issue number) #### Description Based on the description in issue #4205, this PR will fix a bug in ims_auth module related to MAR Diameter request callbacks, by replacing the call to t_continue function with t_continue_skip_timer, after the MAR request is sent, the control will successfully move to the cfg action in Kamailio scripts. Just like what we already have in ims_registrar_scscf module, using t_continue_skip_timer instead of t_continue cause the transaction to be found and resumed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4206 -- Commit Summary -- * ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c -- File Changes -- M src/modules/ims_auth/cxdx_mar.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4206.patch https://github.com/kamailio/kamailio/pull/4206.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4206 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4206(a)github.com>

2 1

git:master:74709677: ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c
by Victor Seva 17 May '25

17 May '25

Module: kamailio Branch: master Commit: 7470967790a78ba67ef7acb7c87d94482fbea0cb URL: https://github.com/kamailio/kamailio/commit/7470967790a78ba67ef7acb7c87d944… Author: amnapa <marvelousvip(a)live.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-17T20:34:43+02:00 ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c - fixed log message in MAR Async CDP callback - fixed executing cfg_action after sending MAR Diameter request - cfg_action is the callback parameter of the ims_www_challenge function --- Modified: src/modules/ims_auth/cxdx_mar.c --- Diff: https://github.com/kamailio/kamailio/commit/7470967790a78ba67ef7acb7c87d944… Patch: https://github.com/kamailio/kamailio/commit/7470967790a78ba67ef7acb7c87d944… --- diff --git a/src/modules/ims_auth/cxdx_mar.c b/src/modules/ims_auth/cxdx_mar.c index 51e05ce7a27..3868dee4f60 100644 --- a/src/modules/ims_auth/cxdx_mar.c +++ b/src/modules/ims_auth/cxdx_mar.c @@ -479,7 +479,7 @@ void async_cdp_callback( adi_list = 0; } - LM_DBG("DBG:UAR Async CDP callback: ... Done resuming transaction\n"); + LM_DBG("DBG:MAR Async CDP callback: ... Done resuming transaction\n"); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, &t->uri_avps_from); set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, &t->uri_avps_to); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, &t->user_avps_from); @@ -493,7 +493,7 @@ void async_cdp_callback( //del_nonshm_lump_rpl(&req->reply_lump); tmb.unref_cell(t); } - tmb.t_continue(data->tindex, data->tlabel, data->act); + tmb.t_continue_skip_timer(data->tindex, data->tlabel, data->act); free_saved_transaction_data(data); return; @@ -504,7 +504,7 @@ void async_cdp_callback( //del_nonshm_lump_rpl(&t->uas.request->reply_lump); tmb.unref_cell(t); } - tmb.t_continue(data->tindex, data->tlabel, data->act); + tmb.t_continue_skip_timer(data->tindex, data->tlabel, data->act); error1: free_saved_transaction_data(data);

1 0

git:master:b51c78ba: usrloc: use the internal wrappers for time value
by Daniel-Constantin Mierla 16 May '25

16 May '25

Module: kamailio Branch: master Commit: b51c78ba27ca552893ba88cefe2d941246322a69 URL: https://github.com/kamailio/kamailio/commit/b51c78ba27ca552893ba88cefe2d941… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-16T11:05:47+02:00 usrloc: use the internal wrappers for time value --- Modified: src/modules/usrloc/ul_keepalive.c --- Diff: https://github.com/kamailio/kamailio/commit/b51c78ba27ca552893ba88cefe2d941… Patch: https://github.com/kamailio/kamailio/commit/b51c78ba27ca552893ba88cefe2d941… --- diff --git a/src/modules/usrloc/ul_keepalive.c b/src/modules/usrloc/ul_keepalive.c index 5ea58f25a9f..a0704da2a69 100644 --- a/src/modules/usrloc/ul_keepalive.c +++ b/src/modules/usrloc/ul_keepalive.c @@ -156,9 +156,10 @@ int ul_ka_urecord(urecord_t *ur) /* set contact as expired in 10s */ LM_DBG("set expired contact on keepalive (%u + %u < %u)" " - aor: %.*s c: %.*s\n", - (unsigned int)uc->last_keepalive, - (unsigned int)ul_keepalive_timeout, (unsigned int)tnow, - ur->aor.len, ur->aor.s, uc->c.len, uc->c.s); + ksr_time_uint(&uc->last_keepalive, NULL), + (unsigned int)ul_keepalive_timeout, + ksr_time_sint(&tnow, NULL), ur->aor.len, ur->aor.s, + uc->c.len, uc->c.s); if(uc->expires > tnow + 10) { uc->expires = tnow + 10; continue;

1 0

git:master:73dc08af: tls: removed unnecessary code
by Daniel-Constantin Mierla 16 May '25

16 May '25

Module: kamailio Branch: master Commit: 73dc08affb9d0a7a3f9ab83c24e01bada8958b2d URL: https://github.com/kamailio/kamailio/commit/73dc08affb9d0a7a3f9ab83c24e01ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-16T10:49:09+02:00 tls: removed unnecessary code --- Modified: src/modules/tls/tls_select.c --- Diff: https://github.com/kamailio/kamailio/commit/73dc08affb9d0a7a3f9ab83c24e01ba… Patch: https://github.com/kamailio/kamailio/commit/73dc08affb9d0a7a3f9ab83c24e01ba… --- diff --git a/src/modules/tls/tls_select.c b/src/modules/tls/tls_select.c index 6a2711bd36a..18abcc7dd03 100644 --- a/src/modules/tls/tls_select.c +++ b/src/modules/tls/tls_select.c @@ -1415,8 +1415,6 @@ static int get_alt_count(long *res, int local, int type, sip_msg_t *msg) tcpconn_put(c); return 0; err: - if(names) - sk_GENERAL_NAME_pop_free(names, GENERAL_NAME_free); if(!local) X509_free(cert); tcpconn_put(c);

1 0

git:master:87cfa9f3: pv_headers: compare the pvh_set_xavi() result with NULL
by Daniel-Constantin Mierla 16 May '25

16 May '25

Module: kamailio Branch: master Commit: 87cfa9f3c5ae337dceb78654beb6fe4b00587993 URL: https://github.com/kamailio/kamailio/commit/87cfa9f3c5ae337dceb78654beb6fe4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-16T10:39:33+02:00 pv_headers: compare the pvh_set_xavi() result with NULL --- Modified: src/modules/pv_headers/pvh_func.c --- Diff: https://github.com/kamailio/kamailio/commit/87cfa9f3c5ae337dceb78654beb6fe4… Patch: https://github.com/kamailio/kamailio/commit/87cfa9f3c5ae337dceb78654beb6fe4… --- diff --git a/src/modules/pv_headers/pvh_func.c b/src/modules/pv_headers/pvh_func.c index 1fe3d58f07c..5cbeb143113 100644 --- a/src/modules/pv_headers/pvh_func.c +++ b/src/modules/pv_headers/pvh_func.c @@ -113,20 +113,20 @@ int pvh_collect_headers(struct sip_msg *msg) val_part.len = strlen(hvals[idx]); if(pvh_set_xavi(msg, &_pvh_params.xavi_name, &name, &val_part, SR_XTYPE_STR, 0, 1) - < 0) + == NULL) return -1; } continue; } if(pvh_set_xavi( msg, &_pvh_params.xavi_name, &name, &val, SR_XTYPE_STR, 0, 1) - < 0) + == NULL) return -1; } if(pvh_set_xavi(msg, &_pvh_params.xavi_helper_xname, &xavi_helper_name, &_pvh_params.xavi_name, SR_XTYPE_STR, 0, 0) - < 0) + == NULL) return -1; pvh_hdrs_set_collected(msg);

1 0

git:master:cf53743b: presence: use internal wrapper to get int time values
by Daniel-Constantin Mierla 16 May '25

16 May '25

Module: kamailio Branch: master Commit: cf53743ba79b60724150738eb482473043925ffc URL: https://github.com/kamailio/kamailio/commit/cf53743ba79b60724150738eb482473… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-16T10:33:21+02:00 presence: use internal wrapper to get int time values --- Modified: src/modules/presence/notify.c --- Diff: https://github.com/kamailio/kamailio/commit/cf53743ba79b60724150738eb482473… Patch: https://github.com/kamailio/kamailio/commit/cf53743ba79b60724150738eb482473… --- diff --git a/src/modules/presence/notify.c b/src/modules/presence/notify.c index 191cac0d04b..6c86a5237e7 100644 --- a/src/modules/presence/notify.c +++ b/src/modules/presence/notify.c @@ -297,7 +297,7 @@ int get_wi_subs_db(subs_t *subs, watcher_t *watchers) query_vals[n_query_cols].type = DB1_INT; query_vals[n_query_cols].nul = 0; query_vals[n_query_cols].val.int_val = - (int)time(NULL) + pres_expires_offset; + ksr_time_sint(NULL, NULL) + pres_expires_offset; n_query_cols++; result_cols[status_col = n_result_cols++] = &str_status_col; @@ -367,7 +367,7 @@ str *get_wi_notify_body(subs_t *subs, subs_t *watcher_subs) unsigned int hash_code; subs_t *s = NULL; int state = FULL_STATE_FLAG; - unsigned int now = (int)time(NULL); + unsigned int now = ksr_time_uint(NULL, NULL); hash_code = 0; version_str = int2str(subs->version, &len); @@ -655,7 +655,7 @@ str *ps_db_get_p_notify_body( query_cols[n_query_cols] = &str_expires_col; query_vals[n_query_cols].type = DB1_INT; query_vals[n_query_cols].nul = 0; - query_vals[n_query_cols].val.int_val = (int)time(NULL); + query_vals[n_query_cols].val.int_val = ksr_time_sint(NULL, NULL); query_ops[n_query_cols] = OP_GT; n_query_cols++; } @@ -891,7 +891,7 @@ str *ps_cache_get_p_notify_body( ptm.domain = uri.host; ptm.event = event->name; if(pres_startup_mode == 1) { - ptm.expires = (int)time(NULL); + ptm.expires = ksr_time_sint(NULL, NULL); } ptlist = ps_ptable_search(&ptm, 1, pres_retrieve_order); @@ -1343,10 +1343,11 @@ int get_subs_db( s.event = event; s.local_cseq = row_vals[cseq_col].val.int_val + 1; if(row_vals[expires_col].val.int_val - < (int)time(NULL) + pres_expires_offset) + < ksr_time_sint(NULL, NULL) + pres_expires_offset) s.expires = 0; else - s.expires = row_vals[expires_col].val.int_val - (int)time(NULL); + s.expires = row_vals[expires_col].val.int_val + - ksr_time_sint(NULL, NULL); s.version = row_vals[version_col].val.int_val + 1; s.flags = row_vals[flags_col].val.int_val; s.user_agent.s = (char *)row_vals[user_agent_col].val.string_val; @@ -1401,7 +1402,7 @@ subs_t *get_subs_dialog(str *pres_uri, pres_ev_t *event, str *sender) printf_subs(s); - if(s->expires < (int)time(NULL)) { + if(s->expires < ksr_time_sint(NULL, NULL)) { LM_DBG("expired subs\n"); continue; } @@ -1420,7 +1421,7 @@ subs_t *get_subs_dialog(str *pres_uri, pres_ev_t *event, str *sender) lock_release(&subs_htable[hash_code].lock); goto error; } - s_new->expires -= (int)time(NULL); + s_new->expires -= ksr_time_sint(NULL, NULL); s_new->next = s_array; s_array = s_new; } @@ -2883,7 +2884,7 @@ int process_dialogs(int round, int presence_winfo) int end_transaction = 0; subs_t sub; str ev_sname, winfo = str_init("presence.winfo"); - int now = (int)time(NULL); + int now = ksr_time_sint(NULL, NULL); int updated = 0; int no_active_watchers = 0; db_query_f query_fn = pa_dbf.query_lock ? pa_dbf.query_lock : pa_dbf.query; @@ -3228,7 +3229,7 @@ void ps_active_watchers_db_timer_clean(unsigned int ticks, void *param) db_ops[0] = OP_LT; db_vals[0].type = DB1_INT; db_vals[0].nul = 0; - db_vals[0].val.int_val = (int)time(NULL); + db_vals[0].val.int_val = ksr_time_sint(NULL, NULL); db_keys[1] = &str_expires_col; db_ops[1] = OP_GT;

1 0

[kamailio/kamailio] kamailio.pid does not exist -- Kamailio start failed (Issue #4243)
by nochnoi82 16 May '25

16 May '25

nochnoi82 created an issue (kamailio/kamailio#4243) Greetings folks. Need your help or conclusion. Debian 12 Kamailio 6.0.1 (Open source installed) Init script and systemd script were applied. kamctl start (/usr/local/sbin) ERROR: PID file /var/run/kamailio.pid does not exist -- Kamailio start failed kamailio start (/usr/local/sbin) error: 'start' is not a supported argument error: stopping kamailio ... sudo journalctl -xeu kamailio ERROR: db_mysql [km_my_con.c:219]: db_mysql_new_connection(): driver error: Access denied for user 'kamailio'@'localhost' (using password: YES) May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [lib/srdb1/db.c:326]: db_do_init2(): could not add connection to the pool May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: usrloc [dlist.c:848]: register_udomain(): failed to open database connection May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: registrar [registrar.c:773]: domain_fixup(): failed to register domain May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/route.c:1195]: fix_actions(): fixing failed (code=-1) at cfg:/usr/local/etc/kamailio/kamailio.cfg:750 May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/rvalue.c:3816]: fix_rval_expr(): failure in cfg at line: 750 col: 22 May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/rvalue.c:3816]: fix_rval_expr(): failure in cfg at line: 750 col: 22 May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/route.c:1195]: fix_actions(): fixing failed (code=-1) at cfg:/usr/local/etc/kamailio/kamailio.cfg:753 Kamailio acts as proxy server only. What did i miss? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4243 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4243(a)github.com>

3 4

git:master:57ec3497: pv: added $tts variable
by Daniel-Constantin Mierla 15 May '25

15 May '25

Module: kamailio Branch: master Commit: 57ec3497c5a584850bd2883d6a6e8fd0535e11d7 URL: https://github.com/kamailio/kamailio/commit/57ec3497c5a584850bd2883d6a6e8fd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-15T12:10:30+02:00 pv: added $tts variable - return to-tag state: 0 - if not set; 1 - if set --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/57ec3497c5a584850bd2883d6a6e8fd… Patch: https://github.com/kamailio/kamailio/commit/57ec3497c5a584850bd2883d6a6e8fd… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index 81781303049..89f5d5c2a14 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -398,6 +398,8 @@ static pv_export_t mod_pvs[] = { pv_init_iname, 5}, {{"tt", (sizeof("tt") - 1)}, /* */ PVT_OTHER, pv_get_to_attr, 0, 0, 0, pv_init_iname, 4}, + {{"tts", (sizeof("tts") - 1)}, /* */ + PVT_OTHER, pv_get_totagstate, 0, 0, 0, 0, 0}, {{"tu", (sizeof("tu") - 1)}, /* */ PVT_TO, pv_get_to_attr, pv_set_to_uri, 0, 0, pv_init_iname, 1}, {{"to", (sizeof("to") - 1)}, /* */ diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 56d96b20d75..a1064738bba 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -509,6 +509,27 @@ int pv_get_to_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) return pv_get_xto_attr(msg, param, res, get_to(msg), 0); } +int pv_get_totagstate(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + if(msg == NULL) + return pv_get_uintval(msg, param, res, 0); + + if(msg->to == NULL && parse_headers(msg, HDR_TO_F, 0) == -1) { + LM_ERR("cannot parse To header\n"); + return pv_get_uintval(msg, param, res, 0); + } + if(msg->to == NULL || get_to(msg) == NULL) { + LM_DBG("no To header\n"); + return pv_get_uintval(msg, param, res, 0); + } + + if(get_to(msg)->tag_value.s != NULL && get_to(msg)->tag_value.len > 0) { + return pv_get_uintval(msg, param, res, 1); + } + + return pv_get_uintval(msg, param, res, 0); +} + int pv_get_from_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { if(msg == NULL) diff --git a/src/modules/pv/pv_core.h b/src/modules/pv/pv_core.h index 16b14bf31cd..1341c9ba0f0 100644 --- a/src/modules/pv/pv_core.h +++ b/src/modules/pv/pv_core.h @@ -77,6 +77,8 @@ int pv_get_xto_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res, int pv_get_to_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); +int pv_get_totagstate(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); + int pv_get_from_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); int pv_get_cseq(struct sip_msg *msg, pv_param_t *param, pv_value_t *res);

1 0

[kamailio/kamailio] tcp_main : Crash on local_timer_list_expire (Issue #4238)
by ctylihuai 14 May '25

14 May '25

ctylihuai created an issue (kamailio/kamailio#4238) ### Description The Kamailio “P” node responsible for 5G messaging encountered an unhandled exception and generated a core dump during operation . This node had been continuously running for over one month (34 days) without any issues, and the failure occurred only once . As of now, no reproducible steps have been identified to trigger the problem again ### Troubleshooting #### Reproduction It cannot be reproduced for the time being #### Debugging Data ``` (gdb) bt full #0 0x0000aaaac25ffd10 in local_timer_list_expire (l=0xaaaac29ef340 <tcp_main_ltimer>, t=1691001057, h=0xaaaac2a10158 <tcp_main_ltimer+134680>) at core/local_timer.c:193 tl = 0xaaaac2a7b528 <tcp_reader_ltimer+197384> ret = 0 #1 0x0000aaaac25ffe98 in local_timer_expire (h=0xaaaac29ef340 <tcp_main_ltimer>, t=1691001057) at core/local_timer.c:222 No locals. #2 0x0000aaaac260031c in local_timer_run (lt=0xaaaac29ef340 <tcp_main_ltimer>, saved_ticks=1691001057) at core/local_timer.c:245 __func__ = "local_timer_run" #3 0x0000aaaac2552bec in tcp_timer_run () at core/tcp_main.c:4875 ticks = 1691001057 #4 0x0000aaaac2555074 in tcp_main_loop () at core/tcp_main.c:5060 si = 0x0 r = 48 __func__ = "tcp_main_loop" #5 0x0000aaaac23d24b0 in main_loop () at main.c:1945 i = 48 pid = 0 si = 0x0 si_desc = "udp receiver child=47 sock=10.185.16.12:5060\000\000\000\000\000\027\065\215sw\247\235\060\346\256\310\377\377\000\000|\312p\302\252\252\000\000@\346\256\310\377\377\000\000\000\263\252\302\252\252\000\000\200\346\256\310\377\377\000\000\n\000\000\000\000\000\000\000\200\346\256\310\377\377\000\000\250\345=\302\252\252\000\000\200\346\256\310\377\377\000" nrprocs = 48 woneinit = 1 __func__ = "main_loop" #6 0x0000aaaac23de5f4 in main (argc=19, argv=0xffffc8aeebe8) at main.c:3212 cfg_stream = 0xaaaafeb0d260 c = -1 r = 0 tmp = 0xffffc8aefe85 "" tmp_len = -1484867064 port = 65535 proto = -1487420584 ahost = 0x0 aport = 0 options = 0xaaaac28ec2a0 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 3762187974 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 2 ---Type <return> to continue, or q <return> to quit--- n_lst = 0xffffc8aee8f8 p = 0x0 st = {st_dev = 64772, st_ino = 4298835, st_mode = 16877, st_nlink = 2, st_uid = 103, st_gid = 105, st_rdev = 0, __pad1 = 0, st_size = 6, st_blksize = 4096, __pad2 = 0, st_blocks = 0, st_atim = { tv_sec = 0, tv_nsec = 0}, st_mtim = {tv_sec = 1733885384, tv_nsec = 0}, st_ctim = {tv_sec = 1737443001, tv_nsec = 2493470}, __glibc_reserved = {0, 0}} tbuf = "\210\351\256\310\377\377\000\000\204\351\256\310\377\377\000\000\002\b \200\002\b \200\260\351\256\310\377\377\000\000\234\303~\247\377\377\000\000\230e;\330\000\000\000\000\310*\201\247\377\377\000\000\330\fi\247\377\377\000\000\310\352\256\310\377\377\000\000\070\353\256\310\377\377\000\000\000\000\000\000\000\000\000\000@'\201\247\377\377\000\000\000\000\000\000\000\000\000\000X\352\256\310\377\377\000\000h\352\256\310\377\377\000\000\001", '\000' <repeats 15 times>, "\230e;\330\000\000\000\000h'\201\247\377\377\000\000\000\000\000\000\000\000\000\000X\352\256\310\377\377\000\000h\352\256\310\377\377\000\000\320\352\256\310\377\377\000\000\330\fi\247\377\377\000\000\210\351\256\310\377\377\000\000"... option_index = 12 long_options = {{name = 0xaaaac28ee678 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0xaaaac28e9410 "version", has_arg = 0, flag = 0x0, val = 118}, {name = 0xaaaac28ee680 "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0xaaaac28ee688 "subst", has_arg = 1, flag = 0x0, val = 1025}, {name = 0xaaaac28ee690 "substdef", has_arg = 1, flag = 0x0, val = 1026}, { name = 0xaaaac28ee6a0 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0xaaaac28ee6b0 "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0xaaaac28ee6c0 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0xaaaac28ee6d0 "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0xaaaac28ee6e0 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, { name = 0xaaaac28ee6f0 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0xaaaac28ee6f8 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0xaaaac28ee708 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0xaaaac28ee710 "all-errors", has_arg = 0, flag = 0x0, val = 1035}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" (gdb) p tl $30 = (struct timer_ln *) 0xaaaac2a7b528 <tcp_reader_ltimer+197384> (gdb) p *tl $31 = {next = 0x0, prev = 0xaaaac2a10158 <tcp_main_ltimer+134680>, expire = 0, initial_timeout = 0, data = 0x0, f = 0x0, flags = 0, slow_idx = 0} (gdb) p *h $10 = {next = 0x0, prev = 0xfff8adcef5d8} 循环打印 h->prev内容 $177 = (struct timer_ln *) 0xaaaac2a10158 <tcp_main_ltimer+134680> next = 0x0, prev = 0xfff8adcef5d8 $178 = (struct timer_ln * volatile) 0xfff8adcef5d8 next = 0xaaaac2a10158 <tcp_main_ltimer+134680>, prev = 0xfff9437ede60 $179 = (struct timer_ln *) 0xfff9437ede60 next = 0xfff8adcef5d8, prev = 0xfffa58c31970 $180 = (struct timer_ln *) 0xfffa58c31970 next = 0xfff9437ede60, prev = 0xaaaac2a1bd48 $181 = (struct timer_ln *) 0xaaaac2a1bd48 <tcp_main_ltimer+182792> next = 0xfffa58c31970, prev = 0xfffa53da92a8 $182 = (struct timer_ln *) 0xfffa53da92a8 next = 0xaaaac2a1bd48 <tcp_main_ltimer+182792>, prev = 0xfff96e22e0e0 $183 = (struct timer_ln *) 0xfff96e22e0e0 next = 0xfffa53da92a8, prev = 0xfffa4f642a28 $184 = (struct timer_ln *) 0xfffa4f642a28 next = 0xfff96e22e0e0, prev = 0xfff880261368 $185 = (struct timer_ln *) 0xfff880261368 next = 0xfffa4f642a28, prev = 0xfff99e55db30 $186 = (struct timer_ln *) 0xfff99e55db30 next = 0xfff880261368, prev = 0xfff99fe12eb0 $187 = (struct timer_ln *) 0xfff99fe12eb0 next = 0xfff99e55db30, prev = 0xfffa7f14dfa8 $188 = (struct timer_ln *) 0xfffa7f14dfa8 next = 0xfff99fe12eb0, prev = 0xaaaac2a21658 <tcp_main_ltimer+205592 $189 = (struct timer_ln *) 0xaaaac2a21658 <tcp_main_ltimer+205592> next = 0xfffa7f14dfa8, prev = 0xfff82902dfb8 $190 = (struct timer_ln *) 0xfff82902dfb8 next = 0xaaaac2a21658 <tcp_main_ltimer+205592>, prev = 0xfffa3728f340 $191 = (struct timer_ln *) 0xfffa3728f340 next = 0xfff82902dfb8, prev = 0xfff8f0b5ec40 $192 = (struct timer_ln *) 0xfff8f0b5ec40 next = 0xfffa3728f340, prev = 0xfffaa900c338 $193 = (struct timer_ln *) 0xfffaa900c338 next = 0xfff8f0b5ec40, prev = 0xfff888f53088 $194 = (struct timer_ln *) 0xfff888f53088 next = 0xfffaa900c338, prev = 0xfff79d06ff60 $195 = (struct timer_ln *) 0xfff79d06ff60 next = 0xfff888f53088, prev = 0xfff8eea80ff8 $196 = (struct timer_ln *) 0xfff8eea80ff8 next = 0xfffa38e4f870, prev = 0xfff83d1a6a18 $197 = (struct timer_ln *) 0xfff83d1a6a18 next = 0xfff8eea80ff8, prev = 0xfffa5c69fb48 $198 = (struct timer_ln *) 0xfffa5c69fb48 next = 0xfff83d1a6a18, prev = 0xfff8b5c31c58 $199 = (struct timer_ln *) 0xfff8b5c31c58 next = 0xfffa5c69fb48, prev = 0xfff9a4ac6688 $200 = (struct timer_ln *) 0xfff9a4ac6688 next = 0xfff8b5c31c58, prev = 0xfff9e3ee0200 $201 = (struct timer_ln *) 0xfff9e3ee0200 next = 0xfff9a4ac6688, prev = 0xaaaac2a267b8 $202 = (struct timer_ln *) 0xaaaac2a267b8 <tcp_main_ltimer+226424> next = 0xfff9e3ee0200, prev = 0xfff9b6b00188 $203 = (struct timer_ln *) 0xfff9b6b00188 next = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, prev = 0xfffa38e4f870 $204 = (struct timer_ln *) 0xfffa38e4f870 next = 0xfff9b6b00188, prev = 0xfff8eea80ff8 $205 = (struct timer_ln *) 0xfff8eea80ff8 next = 0xfffa38e4f870, prev = 0xfff83d1a6a18 $206 = (struct timer_ln *) 0xfff83d1a6a18 next = 0xfff8eea80ff8, prev = 0xfffa5c69fb48 $207 = (struct timer_ln *) 0xfffa5c69fb48 next = 0xfff83d1a6a18, prev = 0xfff8b5c31c58 $208 = (struct timer_ln *) 0xfff8b5c31c58 next = 0xfffa5c69fb48, prev = 0xfff9a4ac6688 $209 = (struct timer_ln *) 0xfff9a4ac6688 next = 0xfff8b5c31c58, prev = 0xfff9e3ee0200 $210 = (struct timer_ln *) 0xfff9e3ee0200 next = 0xfff9a4ac6688, prev = 0xaaaac2a267b8 <tcp_main_ltimer+226424> $211 = (struct timer_ln *) 0xaaaac2a267b8 <tcp_main_ltimer+226424> next = 0xfff9e3ee0200, prev = 0xfff9b6b00188 $212 = (struct timer_ln *) 0xfff9b6b00188 next = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, prev = 0xfffa38e4f870 $213 = (struct timer_ln *) 0xfffa38e4f870 next = 0xfff9b6b00188, prev = 0xfff8eea80ff8 (gdb) set $node = h->prev (gdb) while ($node != 0) >print *$node >set $node = $node->prev >end $50 = {next = 0xaaaac2a10158 <tcp_main_ltimer+134680>, prev = 0xfff9437ede60, expire = 1691004064, initial_timeout = 5760, data = 0xfff8adcef430, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $51 = {next = 0xfff8adcef5d8, prev = 0xfffa58c31970, expire = 1691004064, initial_timeout = 5760, data = 0xfff9437edcb8, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $52 = {next = 0xfff9437ede60, prev = 0xaaaac2a1bd48 <tcp_main_ltimer+182792>, expire = 1691004064, initial_timeout = 5760, data = 0xfffa58c317c8, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $53 = {next = 0xfffa58c31970, prev = 0xfffa53da92a8, expire = 3125221032, initial_timeout = 65529, data = 0xfffa51099620, f = 0xfff7f9d36838, flags = 4191381560, slow_idx = 65527} $54 = {next = 0xaaaac2a1bd48 <tcp_main_ltimer+182792>, prev = 0xfff96e22e0e0, expire = 1691004064, initial_timeout = 5760, data = 0xfffa53da9100, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $55 = {next = 0xfffa53da92a8, prev = 0xfffa4f642a28, expire = 1691004064, initial_timeout = 5760, data = 0xfff96e22df38, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $56 = {next = 0xfff96e22e0e0, prev = 0xfff880261368, expire = 1691004064, initial_timeout = 5760, data = 0xfffa4f642880, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $57 = {next = 0xfffa4f642a28, prev = 0xfff99e55db30, expire = 1691005489, initial_timeout = 5760, data = 0xfff8802611c0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $58 = {next = 0xfff880261368, prev = 0xfff99fe12eb0, expire = 1691005489, initial_timeout = 5760, data = 0xfff99e55d988, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $59 = {next = 0xfff99e55db30, prev = 0xfffa7f14dfa8, expire = 1691005489, initial_timeout = 5760, data = 0xfff99fe12d08, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $60 = {next = 0xfff99fe12eb0, prev = 0xaaaac2a21658 <tcp_main_ltimer+205592>, expire = 1691005489, initial_timeout = 5760, data = 0xfffa7f14de00, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $61 = {next = 0xfffa7f14dfa8, prev = 0xfff82902dfb8, expire = 888530032, initial_timeout = 65528, data = 0xfff81b870028, f = 0xfff798f80cc0, flags = 522077992, slow_idx = 65529} $62 = {next = 0xaaaac2a21658 <tcp_main_ltimer+205592>, prev = 0xfffa3728f340, expire = 1691005489, initial_timeout = 5760, data = 0xfff82902de10, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $63 = {next = 0xfff82902dfb8, prev = 0xfff8f0b5ec40, expire = 1691005489, initial_timeout = 5760, data = 0xfffa3728f198, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $64 = {next = 0xfffa3728f340, prev = 0xfffaa900c338, expire = 1691005489, initial_timeout = 5760, data = 0xfff8f0b5ea98, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $65 = {next = 0xfff8f0b5ec40, prev = 0xfff888f53088, expire = 1691005489, initial_timeout = 5760, data = 0xfffaa900c190, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $66 = {next = 0xfffaa900c338, prev = 0xfff79d06ff60, expire = 1691005489, initial_timeout = 5760, data = 0xfff888f52ee0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $67 = {next = 0xfff888f53088, prev = 0xfff8eea80ff8, expire = 1691005489, initial_timeout = 5760, data = 0xfff79d06fdb8, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $68 = {next = 0xfffa38e4f870, prev = 0xfff83d1a6a18, expire = 1691006791, initial_timeout = 5760, data = 0xfff8eea80e50, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $69 = {next = 0xfff8eea80ff8, prev = 0xfffa5c69fb48, expire = 1691006791, initial_timeout = 5760, data = 0xfff83d1a6870, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $70 = {next = 0xfff83d1a6a18, prev = 0xfff8b5c31c58, expire = 1691006791, initial_timeout = 5760, data = 0xfffa5c69f9a0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $71 = {next = 0xfffa5c69fb48, prev = 0xfff9a4ac6688, expire = 1691006791, initial_timeout = 5760, data = 0xfff8b5c31ab0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $72 = {next = 0xfff8b5c31c58, prev = 0xfff9e3ee0200, expire = 1691006791, initial_timeout = 5760, data = 0xfff9a4ac64e0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $73 = {next = 0xfff9a4ac6688, prev = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, expire = 1691006791, initial_timeout = 5760, data = 0xfff9e3ee0058, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $74 = {next = 0xfff9e3ee0200, prev = 0xfff9b6b00188, expire = 1429254648, initial_timeout = 65528, data = 0xfff88564eb80, f = 0xfff9cc7da958, flags = 881566008, slow_idx = 65529} $75 = {next = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, prev = 0xfffa38e4f870, expire = 1691006791, initial_timeout = 5760, data = 0xfff9b6afffe0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $76 = {next = 0xfff9b6b00188, prev = 0xfff8eea80ff8, expire = 1691006791, initial_timeout = 5760, data = 0xfffa38e4f6c8, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $77 = {next = 0xfffa38e4f870, prev = 0xfff83d1a6a18, expire = 1691006791, initial_timeout = 5760, data = 0xfff8eea80e50, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $78 = {next = 0xfff8eea80ff8, prev = 0xfffa5c69fb48, expire = 1691006791, initial_timeout = 5760, data = 0xfff83d1a6870, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $79 = {next = 0xfff83d1a6a18, prev = 0xfff8b5c31c58, expire = 1691006791, initial_timeout = 5760, data = 0xfffa5c69f9a0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $80 = {next = 0xfffa5c69fb48, prev = 0xfff9a4ac6688, expire = 1691006791, initial_timeout = 5760, data = 0xfff8b5c31ab0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $81 = {next = 0xfff8b5c31c58, prev = 0xfff9e3ee0200, expire = 1691006791, initial_timeout = 5760, data = 0xfff9a4ac64e0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} ---Type <return> to continue, or q <return> to quit--- $82 = {next = 0xfff9a4ac6688, prev = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, expire = 1691006791, initial_timeout = 5760, data = 0xfff9e3ee0058, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $83 = {next = 0xfff9e3ee0200, prev = 0xfff9b6b00188, expire = 1429254648, initial_timeout = 65528, data = 0xfff88564eb80, f = 0xfff9cc7da958, flags = 881566008, slow_idx = 65529} $84 = {next = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, prev = 0xfffa38e4f870, expire = 1691006791, initial_timeout = 5760, data = 0xfff9b6afffe0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} ``` #### Log Messages ``` 2025-05-02T05:39:54.151913300Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([49.69.41.98]:36121 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.152035620Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff7cd0a8ba0 r: 0xfff7cd0a8cc8 (-1) 2025-05-02T05:39:54.152046140Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([110.252.23.203]:27380 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.152053220Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff9a1658f08 r: 0xfff9a1659030 (-1) 2025-05-02T05:39:54.152067100Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([240e:440:1b18:1fb3:22:da32:6be9:33e7]:50529 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [240e:954:2000:208::31]:5460) 2025-05-02T05:39:54.152468020Z 90(137) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([124.236.136.161]:13636 ->90(137) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.152535370Z 87(134) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([111.61.229.67]:41796 ->87(134) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.152895350Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfffa8d174330 r: 0xfffa8d174458 (-1) 2025-05-02T05:39:54.152916500Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([240e:440:9a08:24:1444:71da:9ff4:a6e6]:57851 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [240e:954:2000:208::31]:5460) 2025-05-02T05:39:54.153179200Z 90(137) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfffa45cedc18 r: 0xfffa45cedd40 (-1) 2025-05-02T05:39:54.153425390Z 87(134) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfffa22771e70 r: 0xfffa22771f98 (-1) 2025-05-02T05:39:54.153520770Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff83da65638 r: 0xfff83da65760 (-1) 2025-05-02T05:39:54.153540580Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([2408:8431:6810:2e2:1cbb:1c9e:63e6:abf1]:61717 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [240e:954:2000:208::31]:5260) 2025-05-02T05:39:54.154460230Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff7ccf40938 r: 0xfff7ccf40a60 (-1) 2025-05-02T05:39:54.154502480Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([123.182.115.202]:21533 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.154629490Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff89ae41378 r: 0xfff89ae414a0 (-1) 2025-05-02T05:39:54.154649140Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([183.199.201.13]:3125 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.154830180Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff9acc5d970 r: 0xfff9acc5da98 (-1) 2025-05-02T05:39:54.173624940Z 90(137) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff7de186590 r: 0xfff7de1866b8 (-1) 2025-05-02T05:39:54.325541260Z 117(164) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection reset by peer (104) ([171.114.149.119]:18629 ->117(164) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.325597230Z 117(164) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff83556b7e0 r: 0xfff83556b908 (-1) 2025-05-02T05:39:54.395159000Z 41(88) ERROR: <core> [core/tcp_main.c:1406]: tcp_do_connect(): connect 183.198.156.45:1272 failed Cannot assign requested address 2025-05-02T05:39:54.395211960Z 41(88) ERROR: <core> [core/tcp_main.c:1409]: tcp_do_connect(): connect 183.198.156.45:1272: (99) Cannot assign requested address 2025-05-02T05:39:54.395220020Z 41(88) ERROR: <core> [core/tcp_main.c:1545]: tcpconn_finish_connect(): 183.198.156.45:1272: tcp_do_connect for 0xfff95f7037e0 failed 2025-05-02T05:39:54.395226280Z 41(88) ERROR: <core> [core/tcp_main.c:2200]: tcp_send(): 183.198.156.45:1272: tcpconn_finish_connect(0xfff95f7037e0) failed 2025-05-02T05:39:54.395232270Z 41(88) ERROR: tm [../../core/forward.h:290]: msg_send_buffer(): tcp_send failed 2025-05-02T05:39:54.395337640Z 41(88) ERROR: sl [sl_funcs.c:415]: sl_reply_error(): stateless error reply used: Unfortunately error on sending to next hop occurred (477/SL) 2025-05-02T05:39:54.484799620Z 19(66) ERROR: <core> [core/tcp_main.c:1406]: tcp_do_connect(): connect 1.202.124.130:54952 failed Cannot assign requested address 2025-05-02T05:39:54.484847710Z 19(66) ERROR: <core> [core/tcp_main.c:1409]: tcp_do_connect(): connect 1.202.124.130:54952: (99) Cannot assign requested address 2025-05-02T05:39:54.484882280Z 19(66) ERROR: <core> [core/tcp_main.c:1545]: tcpconn_finish_connect(): 1.202.124.130:54952: tcp_do_connect for 0xfff9c7c0d500 failed 2025-05-02T05:39:54.484889320Z 19(66) ERROR: <core> [core/tcp_main.c:2200]: tcp_send(): 1.202.124.130:54952: tcpconn_finish_connect(0xfff9c7c0d500) failed 2025-05-02T05:39:54.484894930Z 19(66) ERROR: tm [../../core/forward.h:260]: msg_send_buffer(): tcp_send failed 2025-05-02T05:39:54.484899790Z 19(66) ERROR: sl [sl_funcs.c:415]: sl_reply_error(): stateless error reply used: Unfortunately error on sending to next hop occurred (477/SL) 2025-05-02T05:39:54.759458370Z 118(165) CRITICAL: <core> [core/io_wait.h:594]: io_watch_del(): invalid fd 69, not in [0, 0) 2025-05-02T05:39:54.759506810Z 118(165) ERROR: <core> [core/tcp_read.c:1765]: tcpconn_read_timeout(): io_watch_del failed for 0xfff80ff7f860 id 65244425 fd 69, state 0, flags c018, main fd 48347 ([240e::31]:63566 -> [240e::31]:5460) note：[240e::31] is the service address of kamailio, hiding the real IP address . ``` ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) fdc771 ``` * **Operating System**:  ``` OpenEuler 22.03 Linux localhost.localdomain 5.10.0-136.12.0.86.ctl3.x86_64 #1 SMP Fri Jan 13 08:18:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4238 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4238(a)github.com>

2 10

[kamailio/kamailio] rtpengine: select node with weight=0 if no other nodes online (Issue #4180)
by sergey-safarov 13 May '25

13 May '25

sergey-safarov created an issue (kamailio/kamailio#4180) ### Description I have installed two `rtpengine` instances and want to use them as an `active backup`. I want to use `backup` only when `active` is unavailable. Closest settings for this rtpengine node `weight` and want to use settings like ``` MariaDB [kamailio]> select * from rtpengine; +----+-------+---------------------------------+--------+----------+---------------------+ | id | setid | url | weight | disabled | stamp | +----+-------+---------------------------------+--------+----------+---------------------+ | 1 | 0 | udp6:[2005:84c0:bf:11::20]:2223 | 1 | 0 | 1900-01-01 00:00:01 | | 2 | 0 | udp6:[2005:84c0:bf:11::21]:2223 | 0 | 0 | 1900-01-01 00:00:01 | +----+-------+---------------------------------+--------+----------+---------------------+ ``` But in case `weight=0` node is not selected and handled as disabled. It will be fine do not use rtpengine nodes with `weight=0` when other rtpengine with `weight!=0` are available. But if no other nodes are available, use `weight=0` nodes as last resort. ### Expected behavior Do not use rtpengine nodes with `weight=0` when other rtpengine with `weight!=0` are available. But if no other nodes are available, use `weight=0` nodes as last resort. #### Actual observed behavior The node is not selected and handled as disabled when `weight=0`. #### Log Messages ``` rtpengine [rtpengine.c:3430]: rtpp_test(): rtpengine instance <udp6:[2005:84c0:bf:11::21]:2223> found, support for it enabled rtpengine [rtpengine.c:3883]: select_rtpp_node(): rtpengine failed to select new for calllen=27 callid=1-10824@2005:84c0:bf:11::22 rtpengine [rtpengine.c:3183]: rtpp_function_call(): no available proxies ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4180 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4180(a)github.com>

3 3

[kamailio/kamailio] WSS-connections show up as <null> in $tls_version and $tls_cypher_info (Issue #4167)
by Christian Berger 12 May '25

12 May '25

ChristianBergerSipgate created an issue (kamailio/kamailio#4167) Hi, we have found a potential bug. The pseudo variables return null for WSS connections. Example config: `xlog("L_INFO", "<mainLogic> REGISTER: TLS or WSS detected: fU=$fU tls_version=$tls_version tls_cipher_info=$tls_cipher_info ua=$ua\n");` Log output: `Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "ERROR", "module": "tls", "file": "tls_select.c", "line": 131, "function": "get_cur_connection", "message": "Transport protocol is not TLS (bug in config)\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "tls", "file": "tls_select.c", "line": 310, "function": "get_version", "message": "TLS connection not found in select_version\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "ERROR", "module": "tls", "file": "tls_select.c", "line": 131, "function": "get_cur_connection", "message": "Transport protocol is not TLS (bug in config)\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "tls", "file": "tls_select.c", "line": 201, "function": "get_cipher", "message": "TLS connection not found in select_cipher\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "xlog", "file": "xlog.c", "line": 278, "function": "", "message": "<mainLogic> REGISTER: TLS or WSS detected: fU=1125411e0 tls_version=<null> tls_cipher_info=<null> ua=webphone\n" }` As you can see both tls_version and tls_cipher_info return <null> even though the underlying connection is via WSS. We have looked into it, and it seems like `get_cur_connection` in `modules/tls/tls_select.c` only checks for TLS, but not WSS. ``` struct tcp_connection *get_cur_connection(struct sip_msg *msg) { struct tcp_connection *c; if(_tls_pv_con != 0) return _tls_pv_con; if(msg->rcv.proto != PROTO_TLS) { ERR("Transport protocol is not TLS (bug in config)\n"); return 0; } c = tcpconn_get(msg->rcv.proto_reserved1, 0, 0, 0, cfg_get(tls, tls_cfg, con_lifetime)); if(c && c->type != PROTO_TLS) { ERR("Connection found but is not TLS\n"); tcpconn_put(c); return 0; } return c; } ``` We think that checking for `PROTO_WSS` might solve the issue. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4167 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4167(a)github.com>

4 5

[kamailio/kamailio] dispatcher: OPTIONS check does not triggered after new target added (Issue #4212)
by sergey-safarov 12 May '25

12 May '25

sergey-safarov created an issue (kamailio/kamailio#4212) ### Description When I add a new dispatcher target using the kamcmd command, then kamailio does not start send OPTIONS. #### Reproduction Need to start Kamailio with config file ``` listen=eth0 loadmodule "xlog.so" loadmodule "pv.so" loadmodule "ctl.so" loadmodule "jsonrpcs.so" loadmodule "dispatcher.so" modparam("dispatcher", "list_file", "/dev/null") route{ xerr("TEST $ci\n"); drop; } ``` And then execute comands ``` kamcmd dispatcher.add 1 "sip:sip.telnyx.com:5060;transport=tcp" 8 kamcmd dispatcher.list ``` After the last command expected output ``` { NRSETS: 1 RECORDS: { SET: { ID: 1 TARGETS: { DEST: { URI: sip:sip.telnyx.com:5060;transport=tcp FLAGS: AP PRIORITY: 0 } } } } } ``` As you can see, the target has `AP` flags, which means the target is active and probing enabled. But no OPTIONS messages were sent. #### Log Messages Here is kamailio debug output for during kamcmd execitions and some time after ``` 12(94363) DEBUG: ctl [../../core/io_wait.h:368]: io_watch_add(): processing io_watch_add(0x7fce67ac03a0, 10, 3, 0x21186bf0) - fd_no=1 12(94363) DEBUG: ctl [io_listener.c:440]: handle_new_connect(): new connection (1) on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [io_listener.c:501]: handle_stream_read(): bytes read: 68 12(94363) DEBUG: <core> [core/dns_cache.c:533]: _dns_hash_find(): (sip.telnyx.com(14), 1), h=507 12(94363) DEBUG: <core> [core/resolve.c:1021]: get_record(): skipping 0 NS (p=0x9c6ad0, end=0x9c6ad0) 12(94363) DEBUG: <core> [core/resolve.c:1035]: get_record(): parsing 0 ARs (p=0x9c6ad0, end=0x9c6ad0) 12(94363) DEBUG: <core> [core/dns_cache.c:1699]: dns_get_related(): (0x7fce63a32000 (sip.telnyx.com, 1), 1, *(nil)) (0) 12(94363) DEBUG: <core> [core/dns_cache.c:1702]: dns_get_related(): record not alone: 0x7fce63a32000 - type: 1 12(94363) DEBUG: <core> [core/dns_cache.c:748]: dns_cache_add_unsafe(): adding sip.telnyx.com(14) 1 (flags=0) at 507 12(94363) DEBUG: dispatcher [dispatch.c:768]: add_dest2list(): dest [1/1] <sip:sip.telnyx.com:5060;transport=tcp> 12(94363) DEBUG: dispatcher [dispatch.c:258]: ds_log_dst_cb(): dst>> 1 sip:sip.telnyx.com:5060;transport=tcp 8 0 (,0,0,0) 12(94363) DEBUG: ctl [io_listener.c:522]: handle_stream_read(): bytes processed: 68 12(94363) DEBUG: ctl [io_listener.c:498]: handle_stream_read(): handle_stream read: eof on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [../../core/io_wait.h:599]: io_watch_del(): DBG: io_watch_del (0x7fce67ac03a0, 10, -1, 0x10) fd_no=2 called 12(94363) DEBUG: ctl [../../core/io_wait.h:368]: io_watch_add(): processing io_watch_add(0x7fce67ac03a0, 10, 3, 0x21186bf0) - fd_no=1 12(94363) DEBUG: ctl [io_listener.c:440]: handle_new_connect(): new connection (1) on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [io_listener.c:501]: handle_stream_read(): bytes read: 25 12(94363) DEBUG: ctl [io_listener.c:522]: handle_stream_read(): bytes processed: 25 12(94363) DEBUG: ctl [io_listener.c:498]: handle_stream_read(): handle_stream read: eof on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [../../core/io_wait.h:599]: io_watch_del(): DBG: io_watch_del (0x7fce67ac03a0, 10, -1, 0x10) fd_no=2 called ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (x86_64/linux) fce50d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fce50d compiled on 00:00:00 Sep 13 2022 with gcc 14.2.1 ``` * **Operating System**:  ``` root@nout:~# cat /etc/os-release NAME="Fedora Linux" VERSION="41 (Workstation Edition)" RELEASE_TYPE=stable ID=fedora VERSION_ID=41 VERSION_CODENAME="" PLATFORM_ID="platform:f41" PRETTY_NAME="Fedora Linux 41 (Workstation Edition)" ANSI_COLOR="0;38;2;60;110;180" LOGO=fedora-logo-icon CPE_NAME="cpe:/o:fedoraproject:fedora:41" DEFAULT_HOSTNAME="fedora" HOME_URL="https://fedoraproject.org/" DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f41/system-administrators-guide/" SUPPORT_URL="https://ask.fedoraproject.org/" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_BUGZILLA_PRODUCT="Fedora" REDHAT_BUGZILLA_PRODUCT_VERSION=41 REDHAT_SUPPORT_PRODUCT="Fedora" REDHAT_SUPPORT_PRODUCT_VERSION=41 SUPPORT_END=2025-12-15 VARIANT="Workstation Edition" VARIANT_ID=workstation ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4212 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4212(a)github.com>

3 8

[kamailio/kamailio] Improve and document cdp module list_peers output (Issue #4226)
by Henning Westerholt 12 May '25

12 May '25

henningw created an issue (kamailio/kamailio#4226) Improve and document cdp module list_peers output Example output: reg03:~$ sudo kamcmd cdp.list_peers { Realm: YYY.com Identity: 212.XX.XX.3 Accept unknown peers: 0 Connect timeout: 5 Transaction timeout: 5 Default auth session timeout: 3600 Queue length: 32 Workers: 8 Peer count: 3 Peers: { FQDN: 212.XX.XX.1 Details: { State: R_Open Disabled: False Last used: 1745907094 Applications: { appid:vendorid: 4:10415 } } FQDN: 212.XX.XX.2 Details: { State: R_Open Disabled: False Last used: -1406883582 Applications: { appid:vendorid: 4:10415 } } FQDN: 212.XX.XX.3 Details: { State: R_Open Disabled: False Last used: 1745907095 Applications: { appid:vendorid: 4:10415 } } } } 1. Add list_peers command to module XML docs 2. Document State meaning (e.g. what means R_Open etc..) 3. Check/ probably cast time_t value to not output negative numbers -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4226 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4226(a)github.com>

1 2

Analysis regarding performance regressions OpenSSL 3.0/3.x
by Henning Westerholt 11 May '25

11 May '25

Hello, If somebody is using Kamailio in a larger environment with TLS, this new technical analysis and performance report from haproxy could be interesting: https://www.haproxy.com/blog/state-of-ssl-stacks The bottom-line - OpenSSL 3.0 will show serious performance regressions for larger TLS services with higher performance requirements. OpenSSL 3.1 and newer versions are a bit better, but still much slower in key operations. You should consider using the tls_wolfssl module or stay on OpenSSL 1.1.1. For the medium- to long-term we probably should observe how other OpenSSL libraries are developing and act accordingly for the tls modules. The haproxy project recommends besides using wolfssl also the aws-lc library. The situation regarding OpenSSL 3.x seems to be not easily fixable, as these regressions are caused from internal design decisions. Cheers, Henning -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.com<https://gilawa.com/>

1 0

git:master:fdce48b0: modules: readme files regenerated - pv ... [skip ci]
by Kamailio Dev 11 May '25

11 May '25

Module: kamailio Branch: master Commit: fdce48b007d0bede3b1b18cc9249f8351a8ce220 URL: https://github.com/kamailio/kamailio/commit/fdce48b007d0bede3b1b18cc9249f83… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-11T16:01:10+02:00 modules: readme files regenerated - pv ... [skip ci] --- Modified: src/modules/pv/README --- Diff: https://github.com/kamailio/kamailio/commit/fdce48b007d0bede3b1b18cc9249f83… Patch: https://github.com/kamailio/kamailio/commit/fdce48b007d0bede3b1b18cc9249f83…

1 0

git:master:57316690: pv: docs for the new xavp/i rm all functions
by Daniel-Constantin Mierla 11 May '25

11 May '25

Module: kamailio Branch: master Commit: 57316690e96f8c458e9f83af7e102bfa816bf2cf URL: https://github.com/kamailio/kamailio/commit/57316690e96f8c458e9f83af7e102bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-11T15:57:50+02:00 pv: docs for the new xavp/i rm all functions --- Modified: src/modules/pv/doc/pv_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/57316690e96f8c458e9f83af7e102bf… Patch: https://github.com/kamailio/kamailio/commit/57316690e96f8c458e9f83af7e102bf… --- diff --git a/src/modules/pv/doc/pv_admin.xml b/src/modules/pv/doc/pv_admin.xml index 6a06bb717de..0d962a81ca5 100644 --- a/src/modules/pv/doc/pv_admin.xml +++ b/src/modules/pv/doc/pv_admin.xml @@ -726,6 +726,29 @@ xavi_child_sets("WhatEver", "FoO", "Count: $var(n)"); ... xavp_rm("x"); # same result as: $xavp(x) = $null; +... + </programlisting> + </example> + </section> + <section id="pv.f.xavp_rm_all"> + <title> + <function moreinfo="none">xavp_rm_all(rname)</function> + </title> + <para> + Remove all the values of $xavp(rname). + </para> + <para> + The parameter has to be the name of XAVP in the root list. + It can be static or dynamic string (to include variables). + </para> + <para> + Function can be used from ANY ROUTE. + </para> + <example> + <title><function>xavp_rm_all</function> usage</title> + <programlisting format="linespecific"> +... +xavp_rm_all("x"); ... </programlisting> </example> @@ -750,6 +773,29 @@ xavp_rm("x"); ... xavi_rm("WhatEver"); # same result as: $xavi(whatever) = $null; +... + </programlisting> + </example> + </section> + <section id="pv.f.xavi_rm_all"> + <title> + <function moreinfo="none">xavi_rm_all(rname)</function> + </title> + <para> + Remove all the values of $xavi(rname). + </para> + <para> + The parameter has to be the name of XAVI in the root list. + It can be static or dynamic string (to include variables). + </para> + <para> + Function can be used from ANY ROUTE. + </para> + <example> + <title><function>xavi_rm_all</function> usage</title> + <programlisting format="linespecific"> +... +xavi_rm_all("WhatEver"); ... </programlisting> </example>

1 0

git:master:acf3f1eb: pv: added functions to remove all root xavp/xavi items
by Daniel-Constantin Mierla 11 May '25

11 May '25

Module: kamailio Branch: master Commit: acf3f1ebeebec1540d0e93a80c8df54fee939610 URL: https://github.com/kamailio/kamailio/commit/acf3f1ebeebec1540d0e93a80c8df54… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-11T15:57:50+02:00 pv: added functions to remove all root xavp/xavi items --- Modified: src/modules/pv/pv.c --- Diff: https://github.com/kamailio/kamailio/commit/acf3f1ebeebec1540d0e93a80c8df54… Patch: https://github.com/kamailio/kamailio/commit/acf3f1ebeebec1540d0e93a80c8df54… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index d5f21ebba65..81781303049 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -507,6 +507,7 @@ static int w_xavp_child_seti( static int w_xavp_child_sets( sip_msg_t *msg, char *prname, char *pcname, char *pval); static int w_xavp_rm(sip_msg_t *msg, char *prname, char *p2); +static int w_xavp_rm_all(sip_msg_t *msg, char *prname, char *p2); static int w_xavp_child_rm(sip_msg_t *msg, char *prname, char *pcname); static int w_sbranch_set_ruri(sip_msg_t *msg, char p1, char *p2); static int w_sbranch_append(sip_msg_t *msg, char p1, char *p2); @@ -519,6 +520,7 @@ static int w_xavi_child_seti( static int w_xavi_child_sets( sip_msg_t *msg, char *prname, char *pcname, char *pval); static int w_xavi_rm(sip_msg_t *msg, char *prname, char *p2); +static int w_xavi_rm_all(sip_msg_t *msg, char *prname, char *p2); static int w_xavi_child_rm(sip_msg_t *msg, char *prname, char *pcname); static int w_xavp_lshift(sip_msg_t *msg, char *pxname, char *pidx); @@ -577,6 +579,8 @@ static cmd_export_t cmds[] = { fixup_spve_all, fixup_free_spve_all, ANY_ROUTE}, {"xavp_rm", (cmd_function)w_xavp_rm, 1, fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, + {"xavp_rm_all", (cmd_function)w_xavp_rm_all, 1, + fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, {"xavp_child_rm", (cmd_function)w_xavp_child_rm, 2, fixup_spve_spve, fixup_free_spve_spve, ANY_ROUTE}, {"xavi_child_seti", (cmd_function)w_xavi_child_seti, 3, @@ -585,6 +589,8 @@ static cmd_export_t cmds[] = { fixup_spve_all, fixup_free_spve_all, ANY_ROUTE}, {"xavi_rm", (cmd_function)w_xavi_rm, 1, fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, + {"xavi_rm_all", (cmd_function)w_xavi_rm_all, 1, + fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, {"xavi_child_rm", (cmd_function)w_xavi_child_rm, 2, fixup_spve_spve, fixup_free_spve_spve, ANY_ROUTE}, {"xavp_lshift", (cmd_function)w_xavp_lshift, 2, @@ -1645,6 +1651,56 @@ static int w_xavi_rm(sip_msg_t *msg, char *prname, char *p2) return w_xav_rm(msg, prname, p2, 1); } +/** + * + */ +static int ki_xav_rm_all(sip_msg_t *msg, str *rname, int _case) +{ + int ret; + if(_case) { + ret = xavi_rm_by_name(rname, 1, NULL); + } else { + ret = xavp_rm_by_name(rname, 1, NULL); + } + + return (ret == 0) ? 1 : ret; +} + +static int ki_xavp_rm_all(sip_msg_t *msg, str *rname) +{ + return ki_xav_rm_all(msg, rname, 0); +} + +static int ki_xavi_rm_all(sip_msg_t *msg, str *rname) +{ + return ki_xav_rm_all(msg, rname, 1); +} + +/** + * + */ +static int w_xav_rm_all(sip_msg_t *msg, char *prname, char *p2, int _case) +{ + str rname; + + if(fixup_get_svalue(msg, (gparam_t *)prname, &rname) < 0) { + LM_ERR("failed to get root xavp name\n"); + return -1; + } + + return ki_xav_rm_all(msg, &rname, _case); +} + +static int w_xavp_rm_all(sip_msg_t *msg, char *prname, char *p2) +{ + return w_xav_rm_all(msg, prname, p2, 0); +} + +static int w_xavi_rm_all(sip_msg_t *msg, char *prname, char *p2) +{ + return w_xav_rm_all(msg, prname, p2, 1); +} + /** * */ @@ -3041,6 +3097,11 @@ static sr_kemi_t sr_kemi_pvx_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("pvx"), str_init("xavp_rm_all"), + SR_KEMIP_INT, ki_xavp_rm_all, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("pvx"), str_init("xavp_is_null"), SR_KEMIP_INT, ki_xavp_is_null, { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, @@ -3196,6 +3257,11 @@ static sr_kemi_t sr_kemi_pvx_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("pvx"), str_init("xavi_rm_all"), + SR_KEMIP_INT, ki_xavi_rm_all, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("pvx"), str_init("xavi_is_null"), SR_KEMIP_INT, ki_xavi_is_null, { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE,

1 0

git:master:35733d16: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 10 May '25

10 May '25

Module: kamailio Branch: master Commit: 35733d163829e6c9ffd5a5391da872ecf46f4fa1 URL: https://github.com/kamailio/kamailio/commit/35733d163829e6c9ffd5a5391da872e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-10T13:16:11+02:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/35733d163829e6c9ffd5a5391da872e… Patch: https://github.com/kamailio/kamailio/commit/35733d163829e6c9ffd5a5391da872e… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index 6bfa6e44d81..be626d40c7c 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -2211,6 +2211,7 @@ kamcmd dlg.list_ctx greater comparison; 'lt' - match using integer lesser comparison. Integer comparison can be used only with 'start_ts' key. * mval - matching value. + * limit (optional) - limit of matched dialogs. RPC Command Format: ...

1 0

git:master:c66d9f72: dialog: add missing documentation for optional limit parameter for list_match
by Henning Westerholt 10 May '25

10 May '25

Module: kamailio Branch: master Commit: c66d9f7298aa1d76d1905b3388e3e55023baa5ae URL: https://github.com/kamailio/kamailio/commit/c66d9f7298aa1d76d1905b3388e3e55… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-05-10T11:07:56Z dialog: add missing documentation for optional limit parameter for list_match --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c66d9f7298aa1d76d1905b3388e3e55… Patch: https://github.com/kamailio/kamailio/commit/c66d9f7298aa1d76d1905b3388e3e55… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index 4a522cd553e..2653f159ea4 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -2848,6 +2848,9 @@ dlg_set_state("early"); <listitem><para> <emphasis>mval</emphasis> - matching value. </para></listitem> + <listitem><para> + <emphasis>limit</emphasis> (optional) - limit of matched dialogs. + </para></listitem> </itemizedlist> <para>RPC Command Format:</para> <programlisting format="linespecific">

1 0

git:master:1f5afd30: app_jsdt: use snprintf() to build path instead of strcat()
by Daniel-Constantin Mierla 08 May '25

08 May '25

Module: kamailio Branch: master Commit: 1f5afd3044dd399a7a8b03430c9d2b899d044b5a URL: https://github.com/kamailio/kamailio/commit/1f5afd3044dd399a7a8b03430c9d2b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-08T10:08:21+02:00 app_jsdt: use snprintf() to build path instead of strcat() --- Modified: src/modules/app_jsdt/app_jsdt_api.c --- Diff: https://github.com/kamailio/kamailio/commit/1f5afd3044dd399a7a8b03430c9d2b8… Patch: https://github.com/kamailio/kamailio/commit/1f5afd3044dd399a7a8b03430c9d2b8… --- diff --git a/src/modules/app_jsdt/app_jsdt_api.c b/src/modules/app_jsdt/app_jsdt_api.c index 93383860379..53464f3ced5 100644 --- a/src/modules/app_jsdt/app_jsdt_api.c +++ b/src/modules/app_jsdt/app_jsdt_api.c @@ -459,7 +459,7 @@ static int jsdt_load_dir(duk_context *ctx, const char *path) DIR *directory = NULL; struct dirent *dir_entry = NULL; size_t size_to_allocate = 0; - char full_path_to_file[255] = {0}; + char full_path_to_file[512] = {0}; size_t name_len = 0; directory = opendir(_sr_jsdt_load_dir.s); @@ -474,9 +474,8 @@ static int jsdt_load_dir(duk_context *ctx, const char *path) name_len = strlen(dir_entry->d_name); if(name_len >= 3 && strcmp(dir_entry->d_name + name_len - 3, ".js") == 0) { - strcpy(full_path_to_file, _sr_jsdt_load_dir.s); - strcat(full_path_to_file, "/"); - strcat(full_path_to_file, dir_entry->d_name); + snprintf(full_path_to_file, 512, "%s/%s", _sr_jsdt_load_dir.s, + dir_entry->d_name); LM_DBG("loading js script file: %s from folder %.*s\n", dir_entry->d_name, _sr_jsdt_load_dir.len,

1 0

git:master:03c93484: app_jsdt: initialize allocated buffer
by Daniel-Constantin Mierla 08 May '25

08 May '25

Module: kamailio Branch: master Commit: 03c93484901928700d282a1684e4b6e4eaeed6c4 URL: https://github.com/kamailio/kamailio/commit/03c93484901928700d282a1684e4b6e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-08T09:59:25+02:00 app_jsdt: initialize allocated buffer --- Modified: src/modules/app_jsdt/app_jsdt_api.c --- Diff: https://github.com/kamailio/kamailio/commit/03c93484901928700d282a1684e4b6e… Patch: https://github.com/kamailio/kamailio/commit/03c93484901928700d282a1684e4b6e… --- diff --git a/src/modules/app_jsdt/app_jsdt_api.c b/src/modules/app_jsdt/app_jsdt_api.c index b11d66aa519..93383860379 100644 --- a/src/modules/app_jsdt/app_jsdt_api.c +++ b/src/modules/app_jsdt/app_jsdt_api.c @@ -496,6 +496,7 @@ static int jsdt_load_dir(duk_context *ctx, const char *path) full_buffer = (char *)malloc(size_to_allocate); if(full_buffer) { + memset(full_buffer, 0, size_to_allocate); buf = full_buffer; allocated_len = size_to_allocate; }

1 0

[kamailio/kamailio] rtpengine: improve compatibility of rtpengine per call leg stats parsing (PR #4233)
by tsearle 08 May '25

08 May '25

#### Pre-Submission Checklist    - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [*] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [*] PR should be backported to stable branches - [*] Tested changes locally - [*] Related to issue #4232 #### Description not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4233 -- Commit Summary -- * rtpengine: improve compatibility of rtpengine per call leg stats parsing -- File Changes -- M src/modules/rtpengine/rtpengine.c (19) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4233.patch https://github.com/kamailio/kamailio/pull/4233.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4233 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4233(a)github.com>

3 8

git:5.8:9fb936b7: rtpengine: improve compatibility of rtpengine per call leg stats parsing
by Torrey Searle 07 May '25

07 May '25

Module: kamailio Branch: 5.8 Commit: 9fb936b75dd7a06ac8b9a012b03b7c85ca7884ab URL: https://github.com/kamailio/kamailio/commit/9fb936b75dd7a06ac8b9a012b03b7c8… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Torrey Searle <torrey.searle(a)wavecrest.com> Date: 2025-05-07T16:41:50+02:00 rtpengine: improve compatibility of rtpengine per call leg stats parsing not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. (cherry picked from commit 992ee3df02148a940c255b8be7eb9d8e63465834) (cherry picked from commit e3b1220b375b48f16ae361cfe592e8c1bd8e7649) --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/9fb936b75dd7a06ac8b9a012b03b7c8… Patch: https://github.com/kamailio/kamailio/commit/9fb936b75dd7a06ac8b9a012b03b7c8… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 561384df566..81456c4faea 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -4052,7 +4052,8 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, long long ssrc; char *endp; bencode_item_t *ssrc_list, *ssrc_key, *ssrc_dict, *tags, *tag_key, - *tag_dict, *medias, *media, *streams, *stream; + *tag_dict, *medias, *media, *streams, *stream, *ingress_ssrcs, + *ingress_ssrc; struct minmax_stats_vals min_vals = {.mos = 100}, max_vals = {.mos = -1}, average_vals = {.avg_samples = 0}, vals_decoded; @@ -4107,9 +4108,21 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, (char *)stream->child->iov[1].iov_base); LM_DBG("rtpengine: XXX stream child val type %i\n", stream->child->sibling->type); - if((ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1)) - == -1) - continue; + ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1); + if(ssrc == -1) { + ingress_ssrcs = bencode_dictionary_get_expect( + stream, "ingress SSRCs", BENCODE_LIST); + if(!ingress_ssrcs || !ingress_ssrcs->child) + continue; + LM_DBG("rtpengine: XXX got ingress SSRCs\n"); + ingress_ssrc = ingress_ssrcs->child; + if((ssrc = bencode_dictionary_get_integer( + ingress_ssrc, "SSRC", -1)) + == -1) { + continue; + } + } + /* got a valid SSRC to watch for */ ssrcs[num_ssrcs] = ssrc; LM_DBG("rtpengine: found SSRC '%lli' for label '%.*s'\n", ssrc,

1 0

git:6.0:e3b1220b: rtpengine: improve compatibility of rtpengine per call leg stats parsing
by Torrey Searle 07 May '25

07 May '25

Module: kamailio Branch: 6.0 Commit: e3b1220b375b48f16ae361cfe592e8c1bd8e7649 URL: https://github.com/kamailio/kamailio/commit/e3b1220b375b48f16ae361cfe592e8c… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Torrey Searle <torrey.searle(a)wavecrest.com> Date: 2025-05-07T16:40:06+02:00 rtpengine: improve compatibility of rtpengine per call leg stats parsing not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. (cherry picked from commit 992ee3df02148a940c255b8be7eb9d8e63465834) --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/e3b1220b375b48f16ae361cfe592e8c… Patch: https://github.com/kamailio/kamailio/commit/e3b1220b375b48f16ae361cfe592e8c… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 49c942627cd..2401ad09cbd 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -4490,7 +4490,8 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, long long ssrc; char *endp; bencode_item_t *ssrc_list, *ssrc_key, *ssrc_dict, *tags, *tag_key, - *tag_dict, *medias, *media, *streams, *stream; + *tag_dict, *medias, *media, *streams, *stream, *ingress_ssrcs, + *ingress_ssrc; struct minmax_stats_vals min_vals = {.mos = 100}, max_vals = {.mos = -1}, average_vals = {.avg_samples = 0}, vals_decoded; @@ -4545,9 +4546,21 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, (char *)stream->child->iov[1].iov_base); LM_DBG("rtpengine: XXX stream child val type %i\n", stream->child->sibling->type); - if((ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1)) - == -1) - continue; + ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1); + if(ssrc == -1) { + ingress_ssrcs = bencode_dictionary_get_expect( + stream, "ingress SSRCs", BENCODE_LIST); + if(!ingress_ssrcs || !ingress_ssrcs->child) + continue; + LM_DBG("rtpengine: XXX got ingress SSRCs\n"); + ingress_ssrc = ingress_ssrcs->child; + if((ssrc = bencode_dictionary_get_integer( + ingress_ssrc, "SSRC", -1)) + == -1) { + continue; + } + } + /* got a valid SSRC to watch for */ ssrcs[num_ssrcs] = ssrc; LM_DBG("rtpengine: found SSRC '%lli' for label '%.*s'\n", ssrc,

1 0

[kamailio/kamailio] rtpengine: improve compatibility of per-leg statistics parsing (Issue #4232)
by tsearle 07 May '25

07 May '25

tsearle created an issue (kamailio/kamailio#4232) ### Description For getting A and B leg QoS stats, Kamailio expects there to be a SSRC key inside the Stream object. However some versions of rtpengine (tested with mr13.3.1.1) do not send this key. Looking at the master version of rtpengine, I see this key has been added to correspond to ingress SSRCs[0]. This patch adds a checking ingress SSRCs[0] as a fallback if SSRC ### Troubleshooting #### Reproduction use kamailio 6.0.1 and rtpengine mr13.3.1.1 using baresip as the calling and called party the following in the kamailio.cfg ``` modparam("rtpengine", "mos_A_label_pv", "$avp(mos_A_label)") #The name of a pseudovariable to hold the minimum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_min_A_pv", "$avp(mos_min_mos_A)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_packetloss_A_pv", "$avp(mos_min_packetloss_A)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_jitter_A_pv", "$avp(mos_min_jitter_A)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_roundtrip_A_pv", "$avp(mos_min_roundtrip_A)") #The name of a pseudovariable to hold the maximum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_max_A_pv", "$avp(mos_max_mos_A)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_packetloss_A_pv", "$avp(mos_max_packetloss_A)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_jitter_A_pv", "$avp(mos_max_jitter_A)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_roundtrip_A_pv", "$avp(mos_max_roundtrip_A)") #The name of a pseudovariable to hold the average (median) MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_average_A_pv", "$avp(mos_average_mos_A)") #The name of a pseudovariable to hold the average (median) amount of packetloss in percent present throughout the call. modparam("rtpengine", "mos_average_packetloss_A_pv", "$avp(mos_average_packetloss_A)") #The name of a pseudovariable to hold the average (median) amount of jitter in milliseconds present throughout the call. modparam("rtpengine", "mos_average_jitter_A_pv", "$avp(mos_average_jitter_A)") #The name of a pseudovariable to hold the average (median) packet round-trip time in microseconds present throughout the call. modparam("rtpengine", "mos_average_roundtrip_A_pv", "$avp(mos_average_roundtrip_A)") modparam("rtpengine", "mos_B_label_pv", "$avp(mos_B_label)") #The name of a pseudovariable to hold the minimum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_min_B_pv", "$avp(mos_min_mos_B)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_packetloss_B_pv", "$avp(mos_min_packetloss_B)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_jitter_B_pv", "$avp(mos_min_jitter_B)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_roundtrip_B_pv", "$avp(mos_min_roundtrip_B)") #The name of a pseudovariable to hold the maximum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_max_B_pv", "$avp(mos_max_mos_B)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_packetloss_B_pv", "$avp(mos_max_packetloss_B)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_jitter_B_pv", "$avp(mos_max_jitter_B)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_roundtrip_B_pv", "$avp(mos_max_roundtrip_B)") #The name of a pseudovariable to hold the average (median) MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_average_B_pv", "$avp(mos_average_mos_B)") #The name of a pseudovariable to hold the average (median) amount of packetloss in percent present throughout the call. modparam("rtpengine", "mos_average_packetloss_B_pv", "$avp(mos_average_packetloss_B)") #The name of a pseudovariable to hold the average (median) amount of jitter in milliseconds present throughout the call. modparam("rtpengine", "mos_average_jitter_B_pv", "$avp(mos_average_jitter_B)") #The name of a pseudovariable to hold the average (median) packet round-trip time in microseconds present throughout the call. modparam("rtpengine", "mos_average_roundtrip_B_pv", "$avp(mos_average_roundtrip_B)") ``` #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages ``` May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 3684, "function": "rtpp_function_call", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine hash table remove entry for callen=16 callid=3df537fef966eb1a viabranch=" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4508, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: looking for label 'Aleg_label'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4514, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tags" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Aleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4525, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX label match" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4530, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got medias" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4532, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got media" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4537, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got streams" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4542, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got stream type 4" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4543, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child 'local port'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4546, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child val type 2" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Bleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4508, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: looking for label 'Bleg_label'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4514, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tags" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Aleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Bleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4525, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX label match" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4530, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got medias" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4532, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got media" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4537, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got streams" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4542, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got stream type 4" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4543, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child 'local port'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4546, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child val type 2" } ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4232 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4232(a)github.com>

2 2

git:master:992ee3df: rtpengine: improve compatibility of rtpengine per call leg stats parsing
by Richard Fuchs 07 May '25

07 May '25

Module: kamailio Branch: master Commit: 992ee3df02148a940c255b8be7eb9d8e63465834 URL: https://github.com/kamailio/kamailio/commit/992ee3df02148a940c255b8be7eb9d8… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2025-05-07T09:06:19-04:00 rtpengine: improve compatibility of rtpengine per call leg stats parsing not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/992ee3df02148a940c255b8be7eb9d8… Patch: https://github.com/kamailio/kamailio/commit/992ee3df02148a940c255b8be7eb9d8… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 49c942627cd..2401ad09cbd 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -4490,7 +4490,8 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, long long ssrc; char *endp; bencode_item_t *ssrc_list, *ssrc_key, *ssrc_dict, *tags, *tag_key, - *tag_dict, *medias, *media, *streams, *stream; + *tag_dict, *medias, *media, *streams, *stream, *ingress_ssrcs, + *ingress_ssrc; struct minmax_stats_vals min_vals = {.mos = 100}, max_vals = {.mos = -1}, average_vals = {.avg_samples = 0}, vals_decoded; @@ -4545,9 +4546,21 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, (char *)stream->child->iov[1].iov_base); LM_DBG("rtpengine: XXX stream child val type %i\n", stream->child->sibling->type); - if((ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1)) - == -1) - continue; + ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1); + if(ssrc == -1) { + ingress_ssrcs = bencode_dictionary_get_expect( + stream, "ingress SSRCs", BENCODE_LIST); + if(!ingress_ssrcs || !ingress_ssrcs->child) + continue; + LM_DBG("rtpengine: XXX got ingress SSRCs\n"); + ingress_ssrc = ingress_ssrcs->child; + if((ssrc = bencode_dictionary_get_integer( + ingress_ssrc, "SSRC", -1)) + == -1) { + continue; + } + } + /* got a valid SSRC to watch for */ ssrcs[num_ssrcs] = ssrc; LM_DBG("rtpengine: found SSRC '%lli' for label '%.*s'\n", ssrc,

1 0

git:master:f2a60cfa: pkg/kamailio/deb: version set 6.1.0~dev1 [skip ci]
by Victor Seva 06 May '25

06 May '25

Module: kamailio Branch: master Commit: f2a60cfac4cf3a5a6d84e24f7845ab4faeacf45e URL: https://github.com/kamailio/kamailio/commit/f2a60cfac4cf3a5a6d84e24f7845ab4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-06T15:39:08+02:00 pkg/kamailio/deb: version set 6.1.0~dev1 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/noble/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/f2a60cfac4cf3a5a6d84e24f7845ab4… Patch: https://github.com/kamailio/kamailio/commit/f2a60cfac4cf3a5a6d84e24f7845ab4…

1 0

git:master:4405af93: modules: readme files regenerated - app_jsdt ... [skip ci]
by Kamailio Dev 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 4405af938ec72c0482e85abb3abea7853c5a22bb URL: https://github.com/kamailio/kamailio/commit/4405af938ec72c0482e85abb3abea78… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-06T14:46:10+02:00 modules: readme files regenerated - app_jsdt ... [skip ci] --- Modified: src/modules/app_jsdt/README --- Diff: https://github.com/kamailio/kamailio/commit/4405af938ec72c0482e85abb3abea78… Patch: https://github.com/kamailio/kamailio/commit/4405af938ec72c0482e85abb3abea78…

1 0

git:master:2e20c74f: app_jsdt: doc - fix section tags for loaddir
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 2e20c74fb03f2442cde5f3f69989a0ed914f542c URL: https://github.com/kamailio/kamailio/commit/2e20c74fb03f2442cde5f3f69989a0e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T14:38:02+02:00 app_jsdt: doc - fix section tags for loaddir --- Modified: src/modules/app_jsdt/doc/app_jsdt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/2e20c74fb03f2442cde5f3f69989a0e… Patch: https://github.com/kamailio/kamailio/commit/2e20c74fb03f2442cde5f3f69989a0e… --- diff --git a/src/modules/app_jsdt/doc/app_jsdt_admin.xml b/src/modules/app_jsdt/doc/app_jsdt_admin.xml index 6d139c29428..bbf2148b9b4 100644 --- a/src/modules/app_jsdt/doc/app_jsdt_admin.xml +++ b/src/modules/app_jsdt/doc/app_jsdt_admin.xml @@ -107,35 +107,31 @@ modparam("app_jsdt", "load", "/usr/local/etc/kamailio/js/myscript.js") </programlisting> </example> </section> - <section> - <title>Parameters</title> - <section id="app_jsdt.p.loaddir"> - <title> - <varname>loaddir</varname> (str) - </title> - <para> - Set the path to the folder containing JavaScript files to be loaded at startup. All - .js files in the folder will be loaded and combined into a single javascript script. - Then you can use jsdt_run(function, params) to execute a function from the - script at runtime. If you use it for KEMI configuration, - then it has to include the required functions. - </para> - <para> - <emphasis> - Default value is <quote>null</quote>. - </emphasis> - </para> - <example> - <title> - Set <varname>loaddir</varname> parameter - </title> - <programlisting format="linespecific"> - ... - modparam("app_jsdt", "loaddir", "/usr/local/etc/kamailio/js") - ... - </programlisting> - </example> - </section> + <section id="app_jsdt.p.loaddir"> + <title><varname>loaddir</varname> (str)</title> + <para> + Set the path to the folder containing JavaScript files to be loaded at startup. All + .js files in the folder will be loaded and combined into a single javascript script. + Then you can use jsdt_run(function, params) to execute a function from the + script at runtime. If you use it for KEMI configuration, + then it has to include the required functions. + </para> + <para> + <emphasis> + Default value is <quote>null</quote>. + </emphasis> + </para> + <example> + <title> + Set <varname>loaddir</varname> parameter + </title> + <programlisting format="linespecific"> +... +modparam("app_jsdt", "loaddir", "/usr/local/etc/kamailio/js") +... +</programlisting> + </example> + </section> <section id="app_jsdt.p.mode"> <title><varname>mode</varname> (int)</title> <para> @@ -328,4 +324,3 @@ request_route { </programlisting> </section> </chapter> -

1 0

git:master:7fa8b166: Makefile.defs/CMakeLists.txt: version set to 6.1.0-dev1
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 7fa8b166bfc813270d19a30351326a94a9187852 URL: https://github.com/kamailio/kamailio/commit/7fa8b166bfc813270d19a30351326a9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T14:34:06+02:00 Makefile.defs/CMakeLists.txt: version set to 6.1.0-dev1 --- Modified: CMakeLists.txt Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/7fa8b166bfc813270d19a30351326a9… Patch: https://github.com/kamailio/kamailio/commit/7fa8b166bfc813270d19a30351326a9… --- diff --git a/CMakeLists.txt b/CMakeLists.txt index 36451562d6f..6d68b5da980 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -11,7 +11,7 @@ project( ) # Set the version number -set(EXTRAVERSION "-dev0") +set(EXTRAVERSION "-dev1") set(RELEASE "${PROJECT_VERSION}${EXTRAVERSION}") message(STATUS "PROJECT_VERSION: ${PROJECT_VERSION}") diff --git a/src/Makefile.defs b/src/Makefile.defs index 7656029123e..6ff7eeddb51 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 6 PATCHLEVEL = 1 SUBLEVEL = 0 -EXTRAVERSION = -dev0 +EXTRAVERSION = -dev1 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

[kamailio/kamailio] cdp: restructure locking order to prevent rare deadlock (PR #4191)
by Morten Tryfoss 06 May '25

06 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description We've been running the ims_charging module in production for quite some time, without any issues. A couple of days ago the whole instance freezed, but I was able to get a dump before the stuck processes before restarting. The traffic volume has gradually increased over time, so it's likely related to that. I then did a summary of the different types of stuck processes. Which locks they're holding, and what they're waiting for: ``` holding lock: AAASessionsLock waiting for lock: lock_get(peer_list_lock); #1 0x00007fe70eba8cde in futex_get (lock=0x7fe6e4a5c680) at ../../core/futexlock.h:108 #2 0x00007fe70ebaaca2 in get_peer_by_fqdn (fqdn=0x7fe6e4a5ba30) at peermanager.c:259 #3 0x00007fe70ebb64b7 in get_first_connected_route (cdp_session=0x7fe6e5cc5350, r=0x7fe6e4a5ba30, app_id=4, vendor_id=10415) at routing.c:115 #4 0x00007fe70ebb9a37 in get_routing_peer (cdp_session=0x7fe6e5cc5350, m=0x7fe6e5447ab0) at routing.c:293 #5 0x00007fe70ebcaf8c in AAASendMessage (message=0x7fe6e5447ab0, callback_f=0x7fe707a9e323 <resume_on_initial_ccr>, callback_param=0x7fe6e5297110) at diameter_comm.c:139 #6 0x00007fe707a9d3e0 in Ro_Send_CCR (msg=0x7fe70f011100, dlg=0x7fe6e5c571f0, dir=0, reservation_units=30, incoming_trunk_id=0x7ffe50efb060, outgoing_trunk_id=0x7ffe50efb050, pani=0x7ffe50efaee0, action=0x7fe70efa4730, tindex=10484, tlabel=677172593) at ims_ro.c:1511 #7 0x00007fe707a8285d in ki_ro_ccr (msg=0x7fe70f011100, s_route_name=0x7ffe50efb080, s_direction=0x7ffe50efb070, reservation_units=30, s_incoming_trunk_id=0x7ffe50efb060, s_outgoing_trunk_id=0x7ffe50efb050) at ims_charging_mod.c:742 #8 0x00007fe707a7bf01 in w_ro_ccr (msg=0x7fe70f011100, c_route_name=0x7fe70ef8b8d0 "\220\311\371\016\347\177", c_direction=0x7fe70ef8b980 "p\240\371\016\347\177", reservation_units=30, c_incoming_trunk_id=0x7fe70ef8ba30 "p\241\371\016\347\177", c_outgoing_trunk_id=0x7fe70ef8bae0 "\360\241\371\016\347\177") at ims_charging_mod.c:507 #9 0x00000000004858d8 in do_action (h=0x7ffe50efb970, a=0x7fe70ef99e20, msg=0x7fe70f011100) at core/action.c:1144 #10 0x00000000004928d6 in run_actions (h=0x7ffe50efb970, a=0x7fe70ef99e20, msg=0x7fe70f011100) at core/action.c:1618 #11 0x0000000000492f52 in run_actions_safe (h=0x7ffe50eff1e0, a=0x7fe70ef99e20, msg=0x7fe70f011100) at core/action.c:1681 #12 0x0000000000450156 in rval_get_long (h=0x7ffe50eff1e0, msg=0x7fe70f011100, i=0x7ffe50efbec8, rv=0x7fe70ef9c1d8, cache=0x0) at core/rvalue.c:973 #13 0x0000000000454d24 in rval_expr_eval_long (h=0x7ffe50eff1e0, msg=0x7fe70f011100, res=0x7ffe50efbec8, rve=0x7fe70ef9c1d0) at core/rvalue.c:1854 #14 0x0000000000454d52 in rval_expr_eval_long (h=0x7ffe50eff1e0, msg=0x7fe70f011100, res=0x7ffe50efc448, rve=0x7fe70ef9b920) at core/rvalue.c:1864 #15 0x00000000004850ce in do_action (h=0x7ffe50eff1e0, a=0x7fe70ef9b070, msg=0x7fe70f011100) at core/action.c:1097 -- holding lock: AAASessionsLock waiting for lock: lock_get(peer_list_lock); #1 0x00007fe70eba8d4f in futex_get (lock=0x7fe6e4a5c680) at ../../core/futexlock.h:121 #2 0x00007fe70ebaaca2 in get_peer_by_fqdn (fqdn=0x7ffe50efab90) at peermanager.c:259 #3 0x00007fe70ebb8e89 in get_routing_peer (cdp_session=0x7fe6e5ab6910, m=0x7fe6e5435be0) at routing.c:252 #4 0x00007fe70ebcaf8c in AAASendMessage (message=0x7fe6e5435be0, callback_f=0x7fe707a95edc <resume_on_termination_ccr>, callback_param=0x0) at diameter_comm.c:139 #5 0x00007fe707a95b02 in send_ccr_stop_with_param (ro_session=0x7fe6e5ab65e0, code=0, reason=0x7ffe50efb060) at ims_ro.c:1181 #6 0x00007fe707a72ff7 in dlg_terminated (dlg=0x7fe6e623d7a0, type=64, termcode=0, reason=0x7fe707ab72b3 "normal call clearing", _params=0x7fe707f67280 <params>) at dialog.c:249 #7 0x00007fe707a6a729 in dlg_callback_received (dlg=0x7fe6e623d7a0, type=64, _params=0x7fe707f67280 <params>) at dialog.c:25 #8 0x00007fe707d341b9 in run_dlg_callbacks (type=64, dlg=0x7fe6e623d7a0, req=0x7fe70f011100, rpl=0x0, dir=1, dlg_data=0x0) at dlg_cb.c:271 #9 0x00007fe707cf4db4 in dlg_terminated (req=0x7fe70f011100, dlg=0x7fe6e623d7a0, dir=1) at dlg_handlers.c:413 #10 0x00007fe707cfddeb in dlg_onroute (req=0x7fe70f011100, route_params=0x7ffe50efb6d0, param=0x0) at dlg_handlers.c:1097 #11 0x00007fe70ad285f6 in run_rr_callbacks (req=0x7fe70f011100, rr_param=0x7ffe50efb7c0) at rr_cb.c:96 #12 0x00007fe70ad3ae92 in after_loose (_m=0x7fe70f011100, preloaded=0) at loose.c:1021 #13 0x00007fe70ad3b5ce in loose_route_mode (_m=0x7fe70f011100, _mode=0) at loose.c:1056 #14 0x00007fe70ad3f74f in w_loose_route (msg=0x7fe70f011100, p1=0x0, p2=0x0) at rr_mod.c:273 #15 0x00000000004855ff in do_action (h=0x7ffe50efc390, a=0x7fe70efe0d40, msg=0x7fe70f011100) at core/action.c:1121 -- holding lock: lock_get(peer_list_lock); waiting for lock: lock_get(p->lock); #1 0x00007fe70eba8d4f in futex_get (lock=0x7fe6e4a5cbd0) at ../../core/futexlock.h:121 #2 0x00007fe70ebab0ae in peer_timer (now=1742807320, ptr=0x0) at peermanager.c:286 #3 0x00007fe70ebd0f39 in timer_loop () at timer.c:116 #4 0x00007fe70ebd21b2 in timer_process (returns=0) at timer.c:216 #5 0x00007fe70eb8ccf8 in diameter_peer_start (blocking=0) at diameter_peer.c:350 #6 0x00007fe70eb7cbb2 in cdp_child_init (rank=0) at cdp_mod.c:272 -- holding lock: lock_get(p->lock) waiting for lock: AAASessionsLock #1 0x00007fe70ebf2597 in futex_get (lock=0x7fe6e4a5d490) at ../../core/futexlock.h:108 #2 0x00007fe70ebf26f1 in AAASessionsLock (hash=0) at session.c:79 #3 0x00007fe70ebf5e6e in cdp_get_session (id=...) at session.c:316 #4 0x00007fe70eba6892 in Snd_Message (p=0x7fe6e4a5c880, msg=0x7fe6e63998d0) at peerstatemachine.c:1237 #5 0x00007fe70eba003e in sm_process (p=0x7fe6e4a5c880, event=Send_Message, msg=0x7fe6e63998d0, peer_locked=0, sock=0) at peerstatemachine.c:429 #6 0x00007fe70ebcbdc6 in AAASendMessage (message=0x7fe6e63998d0, callback_f=0x7fe707a8f208 <resume_on_interim_ccr>, callback_param=0x7fe6e6190a90) at diameter_comm.c:166 #7 0x00007fe707a8edb3 in send_ccr_interim (ro_session=0x7fe6e5399160, used=60, reserve=30) at ims_ro.c:847 #8 0x00007fe707a68bd6 in ro_session_ontimeout (tl=0x7fe6e5399200) at ro_timer.c:513 #9 0x00007fe707a63078 in ro_timer_routine (ticks=114862426, attr=0x0) at ro_timer.c:279 #10 0x00000000004fd33e in compat_old_handler (ti=1837798827, tl=0x7fe6e4cf6260, data=0x7fe6e4cf6260) at core/timer.c:980 #11 0x00000000004fde7a in slow_timer_main () at core/timer.c:1103 #12 0x000000000042e4e7 in main_loop () at main.c:1911 #13 0x000000000043876c in main (argc=10, argv=0x7ffe50f001c8) at main.c:3236 ``` In `get_first_connected_route()` in `routing.c` of the cdp module there are two places `get_peer_by_fqdn()` are called. One of them has an unlock/relock of the session list before and after (and a comment about holding two locks at a time), while the other doesn't. I'm currently testing two version of this. The first by just doing the some relock for the other `get_peer_by_fqdn()`, but this PR got an approach for maybe fixing more latent issues. `sm_process()` also got some strange handling by `Rcv_Process()` after the peer lock is released, which seems to be about the same thing. My deadlock is for the `Snd_Message()` equivalent. I've now removed this queueing behaviour, and instead doing a re-lock of the peer to (hopefully) have the same locking order as the other operations. The problem with this thing is how rare it occurs. Just wanted to share my findings for others with more knowledge to the cdp module for comments, suggestions and hopefully some extra testing. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4191 -- Commit Summary -- * cdp: restructure locking order to prevent rare deadlock -- File Changes -- M src/modules/cdp/peerstatemachine.c (25) M src/modules/cdp/routing.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4191.patch https://github.com/kamailio/kamailio/pull/4191.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4191 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4191(a)github.com>

4 13

git:master:12bfe206: modules: readme files regenerated - app_jsdt ... [skip ci]
by Kamailio Dev 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 12bfe206daa6b9c2e8aa73e0d0da416d6593fd4e URL: https://github.com/kamailio/kamailio/commit/12bfe206daa6b9c2e8aa73e0d0da416… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-06T13:46:10+02:00 modules: readme files regenerated - app_jsdt ... [skip ci] --- Modified: src/modules/app_jsdt/README Modified: src/modules/cdp/README Modified: src/modules/stirshaken/README --- Diff: https://github.com/kamailio/kamailio/commit/12bfe206daa6b9c2e8aa73e0d0da416… Patch: https://github.com/kamailio/kamailio/commit/12bfe206daa6b9c2e8aa73e0d0da416…

1 0

[kamailio/kamailio] stirshaken: removed repeated x509 certification path check (PR #4202)
by Felipe Cuadra Plaza 06 May '25

06 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Currently `stirshaken` module performs x509 certificate path check twice (when enabled): - first by calling `stir_shaken_verify_cert_path` directly from the [`stirshaken_mod.c`](https://github.com/kamailio/kamailio/blob/330543f46cbb6bf815ebf77c98378314091197ce/src/modules/stirshaken/stirshaken_mod.c#L626) - second time from the [`libstirshaken`](https://github.com/signalwire/libstirshaken/blame/cb6ede40b3ce12ab76e370186a14dc141839ef07/src/stir_shaken_verify.c#L445) `libstirshaken` had the path check built in since approx 2020 ([last commit mentioning it as TODO](https://github.com/signalwire/libstirshaken/blame/552650e31e3dc668069… before the `stir_shaken_verify_cert_path` function was introduced). This shouldn't be an issue since `stirshaken` module was added to Kamailio in 2021. This PR removes the x509 certificate path check from the `stirshaken_mod.c` by passing the responsibility to perform certificate path check to the `libstirshaken`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4202 -- Commit Summary -- * stirshaken: removed repeated x509 certification path check -- File Changes -- M src/modules/stirshaken/doc/stirshaken_admin.xml (4) M src/modules/stirshaken/stirshaken_mod.c (17) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4202.patch https://github.com/kamailio/kamailio/pull/4202.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4202 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4202(a)github.com>

2 2

git:master:f007736b: stirshaken: removed repeated x509 certification path check
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: f007736ba18f5cc2114ffdd1e6df2b9b03808fe7 URL: https://github.com/kamailio/kamailio/commit/f007736ba18f5cc2114ffdd1e6df2b9… Author: FelipeCuadra <f.cuadra(a)zaleos.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:34:41+02:00 stirshaken: removed repeated x509 certification path check - removed a second check of the x509 certificate path from the module, since it is already done earlier in the library and updated documentation --- Modified: src/modules/stirshaken/doc/stirshaken_admin.xml Modified: src/modules/stirshaken/stirshaken_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f007736ba18f5cc2114ffdd1e6df2b9… Patch: https://github.com/kamailio/kamailio/commit/f007736ba18f5cc2114ffdd1e6df2b9… --- diff --git a/src/modules/stirshaken/doc/stirshaken_admin.xml b/src/modules/stirshaken/doc/stirshaken_admin.xml index ef07e6a7212..41f72e5c1b7 100644 --- a/src/modules/stirshaken/doc/stirshaken_admin.xml +++ b/src/modules/stirshaken/doc/stirshaken_admin.xml @@ -528,6 +528,10 @@ request_route { ... </programlisting> </example> + <para> + To ensure proper functionality, the Kamailio stirshaken module requires a minimum version of libstirshaken that includes the stir_shaken_verify_cert_path function for performing the x509 certificate path check. This functionality was added to libstirshaken around 2020 (<![CDATA[https://github.com/signalwire/libstirshaken/commit/58e740b897ae40e2bb02ada2231a051a7eb55137]]>). + If you're using an older version of libstirshaken that predates this commit, the stirshaken module may not function correctly. + </para> </section> </chapter> diff --git a/src/modules/stirshaken/stirshaken_mod.c b/src/modules/stirshaken/stirshaken_mod.c index 95bbdeb5736..5d0bc744885 100644 --- a/src/modules/stirshaken/stirshaken_mod.c +++ b/src/modules/stirshaken/stirshaken_mod.c @@ -613,23 +613,6 @@ static int ki_stirshaken_check_identity(sip_msg_t *msg) goto fail; } - if(stirshaken_vs_verify_x509_cert_path) { - - LM_DBG("Running X509 certificate path verification\n"); - - if(!vs) { - LM_ERR("Verification Service not started\n"); - goto fail; - } - - if(STIR_SHAKEN_STATUS_OK - != stir_shaken_verify_cert_path(&ss, cert_out, vs->store)) { - LM_ERR("Cert did not pass X509 path validation\n"); - stirshaken_print_error_details(&ss); - goto fail; - } - } - if(stirshaken_vs_pptg_pvname.s != 0) { memset(&val, 0, sizeof(pv_value_t)); val.flags = PV_VAL_STR;

1 0

[kamailio/kamailio] app_jstd: Added dynamic buffer sizing to load bigger .js files and Added ability to load all JavaScript files from a specified directory (PR #4221)
by nickgashcc 06 May '25

06 May '25

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  - The code that loaded a JavaScript file used a fix buffer length of 128K on the stack. This has been changed so that the file size is determined and an attempt to allocate an appropriate buffer size temporarily is made. The file contents are then loaded into that buffer before being passed to the duktape engine. - In addition a new module param 'loaddir' has been added that allows you to specify a directory containing .js files rather than specifying a single .js file to load with the existing 'load' param. If loaddir is set it will take a higher priority than load. All .js files in the directory are loaded into a temporary buffer and combined before passing to the duktape engine. This allows you to split logic/routes into separate .js files but load them all into the JavaScript engine. - Updated documentation You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4221 -- Commit Summary -- * app_jstd: Added dynamic buffer sizing to load bigger .js files and Added ability to load all JavaScript files from a specified directory -- File Changes -- M src/modules/app_jsdt/app_jsdt_api.c (175) M src/modules/app_jsdt/app_jsdt_mod.c (2) M src/modules/app_jsdt/doc/app_jsdt_admin.xml (31) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4221.patch https://github.com/kamailio/kamailio/pull/4221.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4221 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4221(a)github.com>

2 9

git:master:4ed24494: app_jsdt: Added dynamic buffer sizing to load bigger .js files and Added ability to load all JavaScript files from a specified directory
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 4ed2449454d07594f9bc30622b7fada9d719c5a3 URL: https://github.com/kamailio/kamailio/commit/4ed2449454d07594f9bc30622b7fada… Author: ngash <nick.gash(a)ccprosolutions.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:33:50+02:00 app_jsdt: Added dynamic buffer sizing to load bigger .js files and Added ability to load all JavaScript files from a specified directory - The code that loaded a JavaScript file used a fix buffer length of 128K on the stack. This has been changed so that the file size is determined and an attempt to allocate an appropriate buffer size temporarily is made. The file contents are then loaded into that buffer before being passed to the duktape engine. - In addition a new module param 'loaddir' has been added that allows you to specify a directory containing .js files rather than specifying a single .js file to load with the existing 'load' param. If loaddir is set it will take a higher priority than load. All .js files in the directory are loaded into a temporary buffer and combined before passing to the duktape engine. This allows you to split logic/routes into seperate .js files but load them all inbto the JavaScript engine. - Updated documentation accordinglyapp_jsdt: Added dynamic buffer sizing to load bigger .js files and Added ability to load all JavaScript files from a specified directory - The code that loaded a JavaScript file used a fix buffer length of 128K on the stack. This has been changed so that the file size is determined and an attempt to allocate an appropriate buffer size temporarily is made. The file contents are then loaded into that buffer before being passed to the duktape engine. - In addition a new module param 'loaddir' has been added that allows you to specify a directory containing .js files rather than specifying a single .js file to load with the existing 'load' param. If loaddir is set it will take a higher priority than load. All .js files in the directory are loaded into a temporary buffer and combined before passing to the duktape engine. This allows you to split logic/routes into seperate .js files but load them all inbto the JavaScript engine. - Updated documentation accordingly --- Modified: src/modules/app_jsdt/app_jsdt_api.c Modified: src/modules/app_jsdt/app_jsdt_mod.c Modified: src/modules/app_jsdt/doc/app_jsdt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4ed2449454d07594f9bc30622b7fada… Patch: https://github.com/kamailio/kamailio/commit/4ed2449454d07594f9bc30622b7fada…

1 0

[kamailio/kamailio] Feature/tcp/tls domain matching (PR #4222)
by Michael Furmur 06 May '25

06 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description PR adds new core option `tls_connection_match_domain` with the default value 0 (old behavior) to solve the problem when we need to have multiple TLS connections with different SNI to the same host:port endpoint. for example: multiple customers (authorized by cert) for MS Teams on the single kamailio instance. originally, functions `_tcpconn_find` and `_tcpconn_add_alias_unsafe` use only endpoint and protocol to match connections. setting `tls_connection_match_domain` to `1` will match additionaly with `tls_domain_str()` output for matched TLS domain. as a result, we will be able to establish new TLS connections if TLS domain is changed instead of reusing of the existent one with the wrong SNI. i'm not considering this PR as the final version but we need something to start with. looking forward for any input. FIXME: not found the right place where new core option should be documented. #### Behavior difference example * /etc/kamailio/kamailio.cfg (relays all requests to 127.0.0.1:5081 using TLS domain matched by server_id retreived from RURI-User): ``` #!KAMAILIO listen=udp:127.0.0.1:5060 listen=tls:127.0.0.1:5061 enable_tls = yes tls_connection_match_domain = 1 debug = 3 loadmodule "tls.so" modparam("tls", "config", "/etc/kamailio/tls.cfg") modparam("tls", "xavp_cfg", "tls") loadmodule "ctl.so" loadmodule "pv.so" loadmodule "tm.so" route { $xavp(tls=>server_id) = $rU; t_relay_to_tls("127.0.0.1", 5081); } ``` * /etc/kamailio/tls.cfg: ``` [server:default] certificate = /etc/ssl/certs/ssl-cert-snakeoil.pem private_key = /etc/ssl/private/ssl-cert-snakeoil.key [client:any] server_name = server_name_1.invalid server_id = 1 [client:any] server_name = server_name_2.invalid server_id = 2 ``` * run tls server: ```bash $ openssl s_server -port 5081 -cert /etc/ssl/certs/ssl-cert-snakeoil.pem -key /etc/ssl/private/ssl-cert-snakeoil.key ``` * send `INVITE sip:1@127.0.0.1:5060` and `INVITE sip:2@127.0.0.1:5060` using sipp: ```bash $ for u in 1 2; do sipp -sn uac -m 1 -nd -recv_timeout 1 -bg -s $u 127.0.0.1:5060; done ``` * resulting `tls.list` for kamailio instance WITHOUT `tls_connection_match_domain = 1` (old behavior): ```bash # kamcmd tls.list { id: 1 dom: TLSc<any:server_name_1.invalid> sni: N/A timestamp: 2025-04-24 14:07:20 timeout: 118 src_ip: 127.0.0.1 src_port: 5081 dst_ip: 127.0.0.1 dst_port: 58808 cipher: unknown ct_wq_size: 1162 enc_rd_buf: 0 flags: 1 state: tls_connect } ``` * `tls.list` for kamailio instance WITH `tls_connection_match_domain = 1` (new behavior): ```bash # kamcmd tls.list { id: 1 dom: TLSc<any:server_name_1.invalid> sni: N/A timestamp: 2025-04-24 14:09:10 timeout: 117 src_ip: 127.0.0.1 src_port: 5081 dst_ip: 127.0.0.1 dst_port: 55480 cipher: unknown ct_wq_size: 581 enc_rd_buf: 0 flags: 1 state: tls_connect } { id: 2 dom: TLSc<any:server_name_2.invalid> sni: N/A timestamp: 2025-04-24 14:09:10 timeout: 117 src_ip: 127.0.0.1 src_port: 5081 dst_ip: 127.0.0.1 dst_port: 55488 cipher: unknown ct_wq_size: 581 enc_rd_buf: 0 flags: 1 state: tls_connect } ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4222 -- Commit Summary -- * core: support tls connection domain matching * tls: implement match_domain,match_connections_domain hooks * tls_wolfssl: implement match_domain,match_connections_domain hooks -- File Changes -- M src/core/cfg.lex (3) M src/core/cfg.y (9) M src/core/globals.h (1) M src/core/tcp_main.c (14) M src/core/tls_hooks.h (9) M src/main.c (4) M src/modules/tls/tls_mod.c (2) M src/modules/tls/tls_rpc.c (12) M src/modules/tls/tls_server.c (97) M src/modules/tls/tls_server.h (8) M src/modules/tls_wolfssl/tls_rpc.c (12) M src/modules/tls_wolfssl/tls_server.c (94) M src/modules/tls_wolfssl/tls_server.h (7) M src/modules/tls_wolfssl/tls_wolfssl_mod.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4222.patch https://github.com/kamailio/kamailio/pull/4222.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4222 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4222(a)github.com>

2 4

git:master:fabf509a: tls_wolfssl: implement match_domain,match_connections_domain hooks
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: fabf509a7e2ce550f71554517346f873b8426ff6 URL: https://github.com/kamailio/kamailio/commit/fabf509a7e2ce550f71554517346f87… Author: Michael Furmur <furmur(a)pm.me> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:32:35+02:00 tls_wolfssl: implement match_domain,match_connections_domain hooks * save tls_domain_str() to the tls_extra_data and use it for connections matching * rpc tls.list: add 'dom' attribute --- Modified: src/modules/tls_wolfssl/tls_rpc.c Modified: src/modules/tls_wolfssl/tls_server.c Modified: src/modules/tls_wolfssl/tls_server.h Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fabf509a7e2ce550f71554517346f87… Patch: https://github.com/kamailio/kamailio/commit/fabf509a7e2ce550f71554517346f87…

1 0

git:master:98feec09: tls: implement match_domain,match_connections_domain hooks
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 98feec09b3cc0fe67d1a2f8484b5c9583a4beb21 URL: https://github.com/kamailio/kamailio/commit/98feec09b3cc0fe67d1a2f8484b5c95… Author: Michael Furmur <furmur(a)pm.me> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:32:35+02:00 tls: implement match_domain,match_connections_domain hooks * save tls_domain_str() to the tls_extra_data and use it for connections matching * rpc tls.list: add 'dom' attribute --- Modified: src/modules/tls/tls_mod.c Modified: src/modules/tls/tls_rpc.c Modified: src/modules/tls/tls_server.c Modified: src/modules/tls/tls_server.h --- Diff: https://github.com/kamailio/kamailio/commit/98feec09b3cc0fe67d1a2f8484b5c95… Patch: https://github.com/kamailio/kamailio/commit/98feec09b3cc0fe67d1a2f8484b5c95…

1 0

git:master:69f22ad4: core: support tls connection domain matching
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 69f22ad49be1302c884f47903d0e32d8491912fd URL: https://github.com/kamailio/kamailio/commit/69f22ad49be1302c884f47903d0e32d… Author: Michael Furmur <furmur(a)pm.me> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:32:35+02:00 core: support tls connection domain matching * add tls_connection_match_domain core option (default: 0) * add match_domain, match_connections_domain tls hooks * modify _tcpconn_find, _tcpconn_add_alias_unsafe to use newly added tls hooks --- Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/globals.h Modified: src/core/tcp_main.c Modified: src/core/tls_hooks.h Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/69f22ad49be1302c884f47903d0e32d… Patch: https://github.com/kamailio/kamailio/commit/69f22ad49be1302c884f47903d0e32d…

1 0

[kamailio/kamailio] cdp: Cast time for printing and Improve cdp docs (PR #4227)
by Xenofon Karamanos 06 May '25

06 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4226 #### Description  - Improve and add missing function documentation `list_peers`. - Use correct identifier in `struct_add` rpc function and cast `time_t` for time_t field. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4227 -- Commit Summary -- * cdp: Cast time_t and use 'L' (long long) identifier in rpc function. * cdp/docs: Add missing list_peers function -- File Changes -- M src/modules/cdp/cdp_rpc.c (4) M src/modules/cdp/doc/cdp_admin.xml (29) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4227.patch https://github.com/kamailio/kamailio/pull/4227.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4227 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4227(a)github.com>

2 2

git:master:11275ccb: cdp: docs: Add missing list_peers function
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 11275ccb94cdddfec49191eaf80b2bc2f083c284 URL: https://github.com/kamailio/kamailio/commit/11275ccb94cdddfec49191eaf80b2bc… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:31:54+02:00 cdp: docs: Add missing list_peers function - Fix some typos - Remove unused section 7.2 --- Modified: src/modules/cdp/doc/cdp_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/11275ccb94cdddfec49191eaf80b2bc… Patch: https://github.com/kamailio/kamailio/commit/11275ccb94cdddfec49191eaf80b2bc… --- diff --git a/src/modules/cdp/doc/cdp_admin.xml b/src/modules/cdp/doc/cdp_admin.xml index d1e313247e1..afc93be5066 100644 --- a/src/modules/cdp/doc/cdp_admin.xml +++ b/src/modules/cdp/doc/cdp_admin.xml @@ -365,7 +365,7 @@ if(!cdp_check_peer("hss.mnc001.mcc001.3gppnetwork.org")) { </listitem> </itemizedlist> <example> - <title><function>cdp_check_peer</function> usage</title> + <title><function>cdp_has_app</function> usage</title> <programlisting format="linespecific"> ... if(!cdp_has_app("10415", "4")) { @@ -376,7 +376,7 @@ if(!cdp_has_app("10415", "4")) { </programlisting> </example> <example> - <title><function>cdp_check_peer</function> usage</title> + <title><function>cdp_has_app</function> usage</title> <programlisting format="linespecific"> ... if(!cdp_has_app("16777216")) { @@ -392,7 +392,20 @@ if(!cdp_has_app("16777216")) { <section> <title>RPC Commands</title> - <para>exported RPC commands.</para> + <section id="cdp.states"> + <title>States</title> + <itemizedlist id="cdp.cdp_states" title="States"> + <listitem><para>Closed (0) - Not connected</para></listitem> + <listitem><para>Wait_Conn_Ack (1) - Connecting - waiting for Ack</para></listitem> + <listitem><para>Wait_I_CEA (2) - Connecting - waiting for Capabilities Exchange Answer</para></listitem> + <listitem><para>Wait_Conn_Ack_Elect (3) - Connecting - Acknowledged and going for Election</para></listitem> + <listitem><para>Wait_Returns (4) - Connecting - done</para></listitem> + <listitem><para>R_Open (5) - Connected as receiver</para></listitem> + <listitem><para>I_Open (6) - Connected as initiator</para></listitem> + <listitem><para>Closing (7) - Closing the connection</para></listitem> + </itemizedlist> + </section> + <para>Exported RPC commands.</para> <section> <title>cdp.disable_peer</title> @@ -405,6 +418,14 @@ if(!cdp_has_app("16777216")) { <para>enable/re-enable a diameter peer</para> </section> + + <section> + <title>cdp.list_peers</title> + <para>list all configured diameter peers</para> + <para> + State details can be found in the list above (<xref linkend="cdp.states" />) + </para> + </section> </section> <section> @@ -538,7 +559,5 @@ if(!cdp_has_app("16777216")) { </programlisting> </example> </section> - - <section/> </section> </chapter>

1 0

git:master:4e945720: cdp: Cast time_t and use 'L' (long long) identifier in rpc function.
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 4e94572059d46b6bdd6726abfd52cb59793f5b03 URL: https://github.com/kamailio/kamailio/commit/4e94572059d46b6bdd6726abfd52cb5… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:31:54+02:00 cdp: Cast time_t and use 'L' (long long) identifier in rpc function. --- Modified: src/modules/cdp/cdp_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/4e94572059d46b6bdd6726abfd52cb5… Patch: https://github.com/kamailio/kamailio/commit/4e94572059d46b6bdd6726abfd52cb5… --- diff --git a/src/modules/cdp/cdp_rpc.c b/src/modules/cdp/cdp_rpc.c index 576b1ba8fcc..8df60230c51 100644 --- a/src/modules/cdp/cdp_rpc.c +++ b/src/modules/cdp/cdp_rpc.c @@ -101,10 +101,10 @@ static void cdp_rpc_list_peers(rpc_t *rpc, void *ctx) lock_release(i->lock); return; } - if(rpc->struct_add(peerdetail_container, "ssd", "State", + if(rpc->struct_add(peerdetail_container, "ssL", "State", dp_states[(int)i->state], "Disabled", i->disabled ? "True" : "False", "Last used", - i->last_selected) + TIME_T_CAST(i->last_selected)) < 0) { rpc->fault(ctx, 500, "Internal error creating peer detail container struct");

1 0

[kamailio/kamailio] core: docs: Update type identifiers that can be used in the RPC API (PR #4228)
by Xenofon Karamanos 06 May '25

06 May '25

- format as well   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #4227 #### Description  There was missing information of type identifiers that can be used in [rpc tutorial docs](https://www.kamailio.org/docs/docbooks/5.7.x/rpc_api/rpc_api.html#rpc…. This is an update to those docs. The most recent I could find was for 5.7. Maybe there is a need for manual updating the page? Also during the relevant PR #4227 , we found the `t` identifier is never used in the code. since it can overflow on 64bit systems due to being a `long` and not `int` type when saved/load, maybe we can remove it completely?. One can just cast the `time_t` to the relevant type and use the correct identifier as done in https://github.com/kamailio/kamailio/blob/2081b3aac394223b68b849fbac2a9e5ac… You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4228 -- Commit Summary -- * Update type identifiers that can be used in the RPC API -- File Changes -- M doc/tutorials/rpc/kamailio_rpc.xml (86) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4228.patch https://github.com/kamailio/kamailio/pull/4228.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4228 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4228(a)github.com>

2 3

git:master:9a8ab319: core: docs - Update type identifiers that can be used in the RPC API
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 9a8ab3199488f02bd01e39bb6e13ef192321b37c URL: https://github.com/kamailio/kamailio/commit/9a8ab3199488f02bd01e39bb6e13ef1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:31:05+02:00 core: docs - Update type identifiers that can be used in the RPC API - format as well --- Modified: doc/tutorials/rpc/kamailio_rpc.xml --- Diff: https://github.com/kamailio/kamailio/commit/9a8ab3199488f02bd01e39bb6e13ef1… Patch: https://github.com/kamailio/kamailio/commit/9a8ab3199488f02bd01e39bb6e13ef1…

1 0

[kamailio/kamailio] core: sdp - update start pointer only after len adjustment (PR #4230)
by space88man 06 May '25

06 May '25

- len is first adjusted by the amount of chars consumed so far - start pointer is then adjusted to begin new search #### Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [X] Related to issue #4229 #### Description Small logic tweak — we adjust `len` by the amount of chars consumed first, then adjust the `start` pointer to begin the new search. Existing: ``` start = space + 1; len = len - (space - start + 1); // this is a no-op // as the pointer was adjusted first ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4230 -- Commit Summary -- * core: sdp - update start pointer only after len adjustment -- File Changes -- M src/core/parser/sdp/sdp_helpr_funcs.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4230.patch https://github.com/kamailio/kamailio/pull/4230.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4230 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4230(a)github.com>

2 2

git:master:c9fbf6f4: core: sdp - update start pointer only after len adjustment
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: c9fbf6f46898dbb2a8413a1c9d824a56241f2288 URL: https://github.com/kamailio/kamailio/commit/c9fbf6f46898dbb2a8413a1c9d824a5… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:29:44+02:00 core: sdp - update start pointer only after len adjustment - len is adjusted first by the amount of chars consumed so far - start pointer is adjusted to start new search --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/c9fbf6f46898dbb2a8413a1c9d824a5… Patch: https://github.com/kamailio/kamailio/commit/c9fbf6f46898dbb2a8413a1c9d824a5… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 2e7d996bc54..0d18d787242 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -330,8 +330,8 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) fl = space - start; - start = space + 1; len = len - (space - start + 1); + start = space + 1; space = memchr(start, 32, len); if(space == NULL) {

1 0

[kamailio/kamailio] core(sdp_helpr_funcs.c): always parsing a=candidate: as "no component … " (Issue #4229)
by space88man 06 May '25

06 May '25

space88man created an issue (kamailio/kamailio#4229)  ### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4229 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4229(a)github.com>

2 3

git:master:444fef80: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 May '25

05 May '25

Module: kamailio Branch: master Commit: 444fef809c21b250402cfdbd48de65926ac6286a URL: https://github.com/kamailio/kamailio/commit/444fef809c21b250402cfdbd48de659… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-05T16:48:21+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/444fef809c21b250402cfdbd48de659… Patch: https://github.com/kamailio/kamailio/commit/444fef809c21b250402cfdbd48de659… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 5e9b3f121ab..2e7d996bc54 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

git:master:cd2db38b: presence: use internal wraper for signed int time
by Daniel-Constantin Mierla 05 May '25

05 May '25

Module: kamailio Branch: master Commit: cd2db38bb3f8f3926cac7e7c5cd58af8f5143fe1 URL: https://github.com/kamailio/kamailio/commit/cd2db38bb3f8f3926cac7e7c5cd58af… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-04T21:03:27+02:00 presence: use internal wraper for signed int time --- Modified: src/modules/presence/hash.c --- Diff: https://github.com/kamailio/kamailio/commit/cd2db38bb3f8f3926cac7e7c5cd58af… Patch: https://github.com/kamailio/kamailio/commit/cd2db38bb3f8f3926cac7e7c5cd58af… --- diff --git a/src/modules/presence/hash.c b/src/modules/presence/hash.c index 39878ac08d9..1d998ca4294 100644 --- a/src/modules/presence/hash.c +++ b/src/modules/presence/hash.c @@ -309,7 +309,7 @@ int insert_shtable(shtable_t htable, unsigned int hash_code, subs_t *subs) LM_ERR("copying in share memory a subs_t structure\n"); return -1; } - new_rec->expires += (int)time(NULL); + new_rec->expires += ksr_time_sint(NULL, NULL); lock_get(&htable[hash_code].lock); new_rec->next = htable[hash_code].entries->next; @@ -417,7 +417,7 @@ int update_shtable( } if(type & REMOTE_TYPE) { - s->expires = subs->expires + (int)time(NULL); + s->expires = subs->expires + ksr_time_sint(NULL, NULL); s->remote_cseq = subs->remote_cseq; } else { subs->local_cseq = ++s->local_cseq;

1 0

git:master:2dd6dcfb: dmq: use internal wrapper for signed int time
by Daniel-Constantin Mierla 05 May '25

05 May '25

Module: kamailio Branch: master Commit: 2dd6dcfb0e4fe353536c411a25d44fa8a796672f URL: https://github.com/kamailio/kamailio/commit/2dd6dcfb0e4fe353536c411a25d44fa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-04T20:58:36+02:00 dmq: use internal wrapper for signed int time --- Modified: src/modules/dmq/dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/2dd6dcfb0e4fe353536c411a25d44fa… Patch: https://github.com/kamailio/kamailio/commit/2dd6dcfb0e4fe353536c411a25d44fa… --- diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c index 0022f569008..c01c38ba13b 100644 --- a/src/modules/dmq/dmq.c +++ b/src/modules/dmq/dmq.c @@ -277,7 +277,7 @@ static int mod_init(void) return -1; } - dmq_startup_time = (int)time(NULL); + dmq_startup_time = ksr_time_sint(NULL, NULL); /** * add the ping timer

1 0

[kamailio/kamailio] Topoh module does not hide 180 Ringing and 200 Ok to the caller UE in IMS config (Issue #4164)
by Farzaneh Soltanzadeh 05 May '25

05 May '25

Fr-Soltanzadeh created an issue (kamailio/kamailio#4164) ### Description In a IMS lab using Kamailio PCSCF, ICSCF and SCSCF default configs, I have used TOPOH module in PCSCF for topology hiding. Topoh config is as follows: ``` modparam("topoh", "mask_key", "my-key") modparam("topoh", "mask_ip", "127.0.0.2") modparam("topoh", "sanity_checks", 1) ``` As shown in attached traffic, SCSCF IP is not hided in 180 ringing and 200ok messages to the caller. In invite, ack and bye messages hiding is performed well. [topoh.zip](https://github.com/user-attachments/files/19086420/topoh.zip) [topoh.zip](https://github.com/user-attachments/files/19086428/topoh.zip) [topoh.zip](https://github.com/user-attachments/files/19086431/topoh.zip)  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4164 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4164(a)github.com>

3 4

Build failed in Jenkins: kamailiodev-nightly-binaries » amd64,bullseye #2974
by kamailio＠sipwise.com 04 May '25

04 May '25

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> Changes: ------------------------------------------ [...truncated 67.11 KiB...] I: new cache content 'libicu67_67.1-7_amd64.deb' added I: new cache content 'libltdl7_2.4.6-15_amd64.deb' added I: new cache content 'dwz_0.13+20210201-1_amd64.deb' added I: new cache content 'libmaxminddb0_1.5.2-1_amd64.deb' added I: new cache content 'ruby_1%3a2.7+2_amd64.deb' added I: new cache content 'sgml-data_2.0.11+nmu1_all.deb' added I: new cache content 'autopoint_0.21-4_all.deb' added I: new cache content 'libcap-dev_1%3a2.44-1+deb11u1_amd64.deb' added I: new cache content 'libgnutls-openssl27_3.7.1-5+deb11u7_amd64.deb' added I: new cache content 'libncurses6_6.2+20201114-2+deb11u2_amd64.deb' added I: new cache content 'libjson-c-dev_0.15-2+deb11u1_amd64.deb' added I: new cache content 'ruby-net-telnet_0.1.1-2_all.deb' added I: new cache content 'python3-dev_3.9.2-3_amd64.deb' added I: new cache content 'libprotobuf-dev_3.12.4-1+deb11u1_amd64.deb' added I: new cache content 'libpsl5_0.21.0-1.2_amd64.deb' added I: new cache content 'libpython3.9-minimal_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'libphonenumber8_8.12.16-4_amd64.deb' added I: new cache content 'python3.9-minimal_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'libjs-jquery_3.5.1+dfsg+~3.5.5-7_all.deb' added I: new cache content 'libsecsipid1_1.1.1~git20210601.d388d64-1+b2_amd64.deb' added I: new cache content 'mariadb-common_1%3a10.5.28-0+deb11u1_all.deb' added I: new cache content 'icu-devtools_67.1-7_amd64.deb' added I: new cache content 'libboost-system1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'libelf1_0.183-1_amd64.deb' added I: new cache content 'libevent-core-2.1-7_2.1.12-stable-1_amd64.deb' added I: new cache content 'libmnl0_1.0.4-3_amd64.deb' added I: new cache content 'libjs-underscore_1.9.1~dfsg-3_all.deb' added I: new cache content 'libreadline-dev_8.1-1_amd64.deb' added I: new cache content 'ruby-dev_1%3a2.7+2_amd64.deb' added I: new cache content 'libradcli4_1.2.11-1+b2_amd64.deb' added I: new cache content 'pkg-config_0.29.2-1_amd64.deb' added I: new cache content 'libpython2.7_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'libsigsegv2_2.13-1_amd64.deb' added I: new cache content 'm4_1.4.18-5_amd64.deb' added I: new cache content 'libmongoc-dev_1.17.6-1_amd64.deb' added I: new cache content 'python3-lib2to3_3.9.2-1_all.deb' added I: new cache content 'libreadline8_8.1-1_amd64.deb' added I: new cache content 'python2_2.7.18-3_amd64.deb' added I: new cache content 'default-libmysqlclient-dev_1.0.7_amd64.deb' added I: new cache content 'libmariadb-dev-compat_1%3a10.5.28-0+deb11u1_amd64.deb' added I: new cache content 'erlang-dev_1%3a23.2.6+dfsg-1+deb11u2_amd64.deb' added I: new cache content 'librdkafka-dev_1.6.0-1_amd64.deb' added I: new cache content 'libuv1-dev_1.40.0-2+deb11u1_amd64.deb' added I: new cache content 'libprotobuf23_3.12.4-1+deb11u1_amd64.deb' added I: new cache content 'libjs-sphinxdoc_3.4.3-2_all.deb' added I: new cache content 'libcap2_1%3a2.44-1+deb11u1_amd64.deb' added I: new cache content 'libboost-atomic1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'libpython3-dev_3.9.2-3_amd64.deb' added I: new cache content 'docbook-xml_4.5-9_all.deb' added I: new cache content 'ruby-power-assert_1.1.7-2_all.deb' added I: new cache content 'libjansson4_2.13.1-1.1_amd64.deb' added I: new cache content 'libudev-dev_247.3-7+deb11u6_amd64.deb' added I: new cache content 'libedit2_3.1-20191231-2+b1_amd64.deb' added I: new cache content 'libpci3_1%3a3.7.0-5_amd64.deb' added I: new cache content 'automake_1%3a1.16.3-2_all.deb' added I: new cache content 'flex_2.6.4-8_amd64.deb' added I: new cache content 'libdebhelper-perl_13.3.4_all.deb' added I: new cache content 'libldap2-dev_2.4.57+dfsg-3+deb11u1_amd64.deb' added I: new cache content 'libpq-dev_13.20-0+deb11u1_amd64.deb' added I: new cache content 'libsub-override-perl_0.09-2_all.deb' added I: new cache content 'libmemcached11_1.0.18-4.2_amd64.deb' added I: new cache content 'libruby2.7_2.7.4-1+deb11u5_amd64.deb' added I: new cache content 'libsnappy-dev_1.1.8-1_amd64.deb' added I: new cache content 'libpcre2-posix2_10.36-2+deb11u1_amd64.deb' added I: new cache content 'python-is-python2_2.7.18-9_all.deb' added I: new cache content 'odbcinst1debian2_2.3.6-0.1+b1_amd64.deb' added I: new cache content 'libbson-dev_1.17.6-1_amd64.deb' added I: new cache content 'libjansson-dev_2.13.1-1.1_amd64.deb' added I: new cache content 'libgmpxx4ldbl_2%3a6.2.1+dfsg-1+deb11u1_amd64.deb' added I: new cache content 'libsnmp-dev_5.9+dfsg-4+deb11u1_amd64.deb' added I: new cache content 'libmongocrypt0_1.1.0-1_amd64.deb' added I: new cache content 'libboost-serialization1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'libzstd-dev_1.4.8+dfsg-2.1_amd64.deb' added I: new cache content 'libsnmp40_5.9+dfsg-4+deb11u1_amd64.deb' added I: new cache content 'libsctp-dev_1.0.18+dfsg-1_amd64.deb' added I: new cache content 'libhashkit-dev_1.0.18-4.2_amd64.deb' added I: new cache content 'libboost-date-time1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'xml-core_0.18+nmu1_all.deb' added I: new cache content 'libxml2-dev_2.9.10+dfsg-6.7+deb11u6_amd64.deb' added I: new cache content 'python3.9-dev_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'libmpdec3_2.5.1-1_amd64.deb' added I: new cache content 'libmosquitto-dev_2.0.11-1+deb11u2_amd64.deb' added I: new cache content 'libsasl2-2_2.1.27+dfsg-2.1+deb11u1_amd64.deb' added I: new cache content 'libboost-system1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'libperl-dev_5.32.1-4+deb11u4_amd64.deb' added I: new cache content 'ruby-rubygems_3.2.5-2_all.deb' added I: new cache content 'libxml2_2.9.10+dfsg-6.7+deb11u6_amd64.deb' added I: new cache content 'libevent-extra-2.1-7_2.1.12-stable-1_amd64.deb' added I: new cache content 'ruby-minitest_5.13.0-1_all.deb' added I: new cache content 'libwrap0-dev_7.6.q-31_amd64.deb' added I: new cache content 'librabbitmq-dev_0.10.0-1+deb11u1_amd64.deb' added I: new cache content 'libexpat1_2.2.10-2+deb11u6_amd64.deb' added I: new cache content 'python2-dev_2.7.18-3_amd64.deb' added I: new cache content 'libboost-date-time1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'librdkafka++1_1.6.0-1_amd64.deb' added I: new cache content 'bsdextrautils_2.36.1-8+deb11u2_amd64.deb' added I: new cache content 'libmongocrypt-dev_1.1.0-1_amd64.deb' added I: new cache content 'python3-distutils_3.9.2-1_all.deb' added I: new cache content 'libcurl4_7.74.0-1.3+deb11u14_amd64.deb' added I: new cache content 'libyaml-0-2_0.2.2-1_amd64.deb' added I: new cache content 'libpython2.7-dev_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'rake_13.0.3-1_all.deb' added I: new cache content 'libunbound8_1.13.1-1+deb11u4_amd64.deb' added I: new cache content 'libboost-thread-dev_1.74.0.3_amd64.deb' added I: new cache content 'libgnutls-dane0_3.7.1-5+deb11u7_amd64.deb' added I: new cache content 'libtasn1-6-dev_4.16.0-2+deb11u2_amd64.deb' added I: new cache content 'libprocps8_2%3a3.3.17-5_amd64.deb' added I: new cache content 'libtool_2.4.6-15_all.deb' added I: new cache content 'libpython3.9-stdlib_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'python2.7_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'libgnutlsxx28_3.7.1-5+deb11u7_amd64.deb' added I: new cache content 'debhelper_13.3.4_all.deb' added I: new cache content 'libarchive-zip-perl_1.68-1_all.deb' added I: new cache content 'libnetsnmptrapd40_5.9+dfsg-4+deb11u1_amd64.deb' added I: new cache content 'libwebsockets-dev_4.0.20-2_amd64.deb' added I: new cache content 'libunistring-dev_0.9.10-4_amd64.deb' added I: new cache content 'bison_2%3a3.7.5+dfsg-1_amd64.deb' added I: new cache content 'libpython3.9_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'libevent-dev_2.1.12-stable-1_amd64.deb' added I: new cache content 'libpcre2-32-0_10.36-2+deb11u1_amd64.deb' added I: new cache content 'libmagic1_1%3a5.39-3+deb11u1_amd64.deb' added I: new cache content 'libwebsockets16_4.0.20-2_amd64.deb' added I: new cache content 'libphonenumber-dev_8.12.16-4_amd64.deb' added I: new cache content 'libdb5.3-dev_5.3.28+dfsg1-0.8_amd64.deb' added I: new cache content 'libpython3.9-dev_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'libprotobuf-lite23_3.12.4-1+deb11u1_amd64.deb' added I: new cache content 'libevent-openssl-2.1-7_2.1.12-stable-1_amd64.deb' added I: new cache content 'libsasl2-dev_2.1.27+dfsg-2.1+deb11u1_amd64.deb' added I: new cache content 'libdb-dev_5.3.1+nmu1_amd64.deb' added I: new cache content 'liblua5.1-0_5.1.5-8.1+b3_amd64.deb' added I: new cache content 'libhiredis-dev_0.14.1-1_amd64.deb' added I: new cache content 'libsctp1_1.0.18+dfsg-1_amd64.deb' added I: new cache content 'libmaxminddb-dev_1.5.2-1_amd64.deb' added I: new cache content 'python2-minimal_2.7.18-3_amd64.deb' added I: new cache content 'libbrotli1_1.0.9-2+b2_amd64.deb' added I: new cache content 'libnghttp2-14_1.43.0-1+deb11u2_amd64.deb' added I: new cache content 'libssl-dev_1.1.1w-0+deb11u2_amd64.deb' added I: new cache content 'libhashkit2_1.0.18-4.2_amd64.deb' added I: new cache content 'libmariadb3_1%3a10.5.28-0+deb11u1_amd64.deb' added I: new cache content 'libidn2-dev_2.3.0-5_amd64.deb' added I: new cache content 'man-db_2.9.4-2_amd64.deb' added I: new cache content 'media-types_4.0.0_all.deb' added I: new cache content 'libboost-chrono1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'po-debconf_1.0.21+nmu1_all.deb' added I: new cache content 'mailcap_3.69_all.deb' added I: new cache content 'libpython2.7-minimal_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'libboost-thread1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'dh-autoreconf_20_all.deb' added I: new cache content 'openssl_1.1.1w-0+deb11u2_amd64.deb' added I: new cache content 'libboost1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'libboost-serialization1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'groff-base_1.22.4-6_amd64.deb' added I: new cache content 'libsecsipid-dev_1.1.1~git20210601.d388d64-1+b2_amd64.deb' added I: new cache content 'libexpat1-dev_2.2.10-2+deb11u6_amd64.deb' added I: new cache content 'python3.9_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'uuid-dev_2.36.1-8+deb11u2_amd64.deb' added I: new cache content 'unixodbc-dev_2.3.6-0.1+b1_amd64.deb' added I: new cache content 'libuchardet0_0.0.7-1_amd64.deb' added I: new cache content 'libmosquitto1_2.0.11-1+deb11u2_amd64.deb' added I: new cache content 'libsasl2-modules-db_2.1.27+dfsg-2.1+deb11u1_amd64.deb' added I: new cache content 'ca-certificates_20210119_all.deb' added I: new cache content 'libuv1_1.40.0-2+deb11u1_amd64.deb' added I: new cache content 'python3-minimal_3.9.2-3_amd64.deb' added I: new cache content 'pci.ids_0.0~2021.02.08-1_all.deb' added I: new cache content 'libpcre2-dev_10.36-2+deb11u1_amd64.deb' added I: new cache content 'libev-dev_1%3a4.33-1_amd64.deb' added I: new cache content 'libjson-c5_0.15-2+deb11u1_amd64.deb' added I: new cache content 'libsensors-config_1%3a3.6.0-7_all.deb' added I: new cache content 'gettext-base_0.21-4_amd64.deb' added I: new cache content 'libncurses-dev_6.2+20201114-2+deb11u2_amd64.deb' added I: new cache content 'ruby-xmlrpc_0.3.0-2_all.deb' added I: new cache content 'autoconf_2.69-14_all.deb' added I: new cache content 'librabbitmq4_0.10.0-1+deb11u1_amd64.deb' added I: new cache content 'libpq5_13.20-0+deb11u1_amd64.deb' added I: new cache content 'libboost-chrono1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'libbson-1.0-0_1.17.6-1_amd64.deb' added I: new cache content 'mysql-common_5.8+1.0.7_all.deb' added I: new cache content 'libgeocoding8_8.12.16-4_amd64.deb' added I: new cache content 'libevent-2.1-7_2.1.12-stable-1_amd64.deb' added I: new cache content 'python2.7-dev_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'mime-support_3.66_all.deb' added I: new cache content 'libboost-thread1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'libmariadb-dev_1%3a10.5.28-0+deb11u1_amd64.deb' added I: new cache content 'libpython2.7-stdlib_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'python3_3.9.2-3_amd64.deb' added I: new cache content 'ruby2.7_2.7.4-1+deb11u5_amd64.deb' added I: new cache content 'libpython2-dev_2.7.18-3_amd64.deb' added I: new cache content 'libev4_1%3a4.33-1_amd64.deb' added I: new cache content 'odbcinst_2.3.6-0.1+b1_amd64.deb' added I: new cache content 'libmicrohttpd12_0.9.72-2+deb11u1_amd64.deb' added I: new cache content 'libmnl-dev_1.0.4-3_amd64.deb' added I: new cache content 'file_1%3a5.39-3+deb11u1_amd64.deb' added I: new cache content 'libcurl4-openssl-dev_7.74.0-1.3+deb11u14_amd64.deb' added I: new cache content 'libmd0_1.0.3-3_amd64.deb' added I: new cache content 'erlang-base_1%3a23.2.6+dfsg-1+deb11u2_amd64.deb' added I: new cache content 'libmemcached-dev_1.0.18-4.2_amd64.deb' added I: new cache content 'dh-strip-nondeterminism_1.12.0-1_all.deb' added I: new cache content 'libsnmp-base_5.9+dfsg-4+deb11u1_all.deb' added I: new cache content 'libmicrohttpd-dev_0.9.72-2+deb11u1_amd64.deb' added I: new cache content 'libfile-stripnondeterminism-perl_1.12.0-1_all.deb' added I: new cache content 'rubygems-integration_1.18_all.deb' added I: new cache content 'libhiredis0.14_0.14.1-1_amd64.deb' added I: new cache content 'libsnappy1v5_1.1.8-1_amd64.deb' added I: new cache content 'libpipeline1_1.5.3-1_amd64.deb' added I: new cache content 'libradcli-dev_1.2.11-1+b2_amd64.deb' added I: new cache content 'libicu-dev_67.1-7_amd64.deb' added I: new cache content 'libpci-dev_1%3a3.7.0-5_amd64.deb' added I: new cache content 'python2.7-minimal_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'librtmp1_2.4+20151223.gitfa8646d.1-2+b2_amd64.deb' added I: unmounting /tmp/apt-jdg_hSZpAB filesystem I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: Cleaning COW directory I: forking: rm -rf /var/cache/pbuilder/build/cow.15391 + '[' 1 -eq 0 ']' + bailout 1 'Error: Failed to build with cowbuilder.' + '[' -n 1 ']' + EXIT=1 + '[' -n 'Error: Failed to build with cowbuilder.' ']' + echo 'Error: Failed to build with cowbuilder.' Error: Failed to build with cowbuilder. + rm -f /run/lock/bullseye-amd64.building.15047 + '[' -r /run/lock/bullseye-amd64.update.15047 ']' + '[' '' = true ']' + echo '*** Getting rid of files in <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> to avoid problems in next run. ***' *** Getting rid of files in <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> to avoid problems in next run. *** + rm -f '<https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…'> + '[' -n /tmp/tmp.oTsUhZvZv3 ']' + rm -rf /tmp/tmp.oTsUhZvZv3 + '[' -n /tmp/apt-jdg_hSZpAB ']' + sudo rm -rf /tmp/apt-jdg_hSZpAB + '[' -n 327 ']' ++ sed -e 's/^$[0-9]*$.*/\1/' + SECONDS=12 ++ date + echo '*** Finished execution of /usr/bin/build-and-provide-package at Wed Apr 30 01:04:09 UTC 2025 [running 12 seconds] ***' *** Finished execution of /usr/bin/build-and-provide-package at Wed Apr 30 01:04:09 UTC 2025 [running 12 seconds] *** + exit 1 Build step 'Execute shell' marked build as failure Archiving artifacts Recording fingerprints TAP Reports Processing: START Looking for TAP results report in workspace using pattern: report/*.tap Did not find any matching files. Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

1 4

git:master:eee44314: drouting: rework expression to prevent value overflow
by Daniel-Constantin Mierla 02 May '25

02 May '25

Module: kamailio Branch: master Commit: eee4431447789b2fc614144064dd61b97570e8bf URL: https://github.com/kamailio/kamailio/commit/eee4431447789b2fc614144064dd61b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-02T08:58:32+02:00 drouting: rework expression to prevent value overflow --- Modified: src/modules/drouting/dr_time.c --- Diff: https://github.com/kamailio/kamailio/commit/eee4431447789b2fc614144064dd61b… Patch: https://github.com/kamailio/kamailio/commit/eee4431447789b2fc614144064dd61b… --- diff --git a/src/modules/drouting/dr_time.c b/src/modules/drouting/dr_time.c index b08f6eb3587..b65477af890 100644 --- a/src/modules/drouting/dr_time.c +++ b/src/modules/drouting/dr_time.c @@ -964,7 +964,7 @@ int dr_check_freq_interval(dr_tmrec_p _trp, dr_ac_tm_p _atp) ? REC_MATCH : REC_NOMATCH; case FREQ_MONTHLY: - _t0 = (_atp->t.tm_year - _trp->ts.tm_year) * 12 + _atp->t.tm_mon + _t0 = 12ULL * (_atp->t.tm_year - _trp->ts.tm_year) + _atp->t.tm_mon - _trp->ts.tm_mon; return (_t0 % _trp->interval == 0) ? REC_MATCH : REC_NOMATCH; case FREQ_YEARLY:

1 0

git:master:c2f36a2c: pv_headers: proper pointer comparison for returned value
by Daniel-Constantin Mierla 02 May '25

02 May '25

Module: kamailio Branch: master Commit: c2f36a2c4f83b0ea077722ae6cc2fcecfb3616c1 URL: https://github.com/kamailio/kamailio/commit/c2f36a2c4f83b0ea077722ae6cc2fce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-02T08:53:58+02:00 pv_headers: proper pointer comparison for returned value --- Modified: src/modules/pv_headers/pvh_xavp.c --- Diff: https://github.com/kamailio/kamailio/commit/c2f36a2c4f83b0ea077722ae6cc2fce… Patch: https://github.com/kamailio/kamailio/commit/c2f36a2c4f83b0ea077722ae6cc2fce… --- diff --git a/src/modules/pv_headers/pvh_xavp.c b/src/modules/pv_headers/pvh_xavp.c index e200afcf93a..f416fdb0c83 100644 --- a/src/modules/pv_headers/pvh_xavp.c +++ b/src/modules/pv_headers/pvh_xavp.c @@ -520,7 +520,7 @@ int pvh_clone_branch_xavi(struct sip_msg *msg, str *xname) if(sub->val.type == SR_XTYPE_DATA) continue; if(pvh_xavi_append_value(&sub->name, &sub->val, &br_xavi->val.v.xavp) - < 0) { + == NULL) { LM_ERR("cannot clone xavi %.*s\n", sub->name.len, sub->name.s); return -1; }

1 0

git:master:08916aa9: modules: readme files regenerated - outbound ... [skip ci]
by Kamailio Dev 02 May '25

02 May '25

Module: kamailio Branch: master Commit: 08916aa91fae8f09c97f3e99585bd914673537cd URL: https://github.com/kamailio/kamailio/commit/08916aa91fae8f09c97f3e99585bd91… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-02T04:16:10+02:00 modules: readme files regenerated - outbound ... [skip ci] --- Modified: src/modules/outbound/README --- Diff: https://github.com/kamailio/kamailio/commit/08916aa91fae8f09c97f3e99585bd91… Patch: https://github.com/kamailio/kamailio/commit/08916aa91fae8f09c97f3e99585bd91… --- diff --git a/src/modules/outbound/README b/src/modules/outbound/README index af2f86cb3c2..899cf9008a2 100644 --- a/src/modules/outbound/README +++ b/src/modules/outbound/README @@ -71,17 +71,19 @@ Chapter 1. Admin Guide 1.1. Conditions - The module analyzes SIP requests so that users (e.g. path, rr) can - determine whether to apply RFC5626 processing. This section applies if - outbound processing is not forced by the force_outbound_flag flag. + The module analyses SIP requests so that other module (e.g. path, rr) + can determine whether to apply RFC5626 processing. This section applies + if outbound processing is not forced by the force_outbound_flag flag, + or disabled with force_no_outbound_flag. REGISTER request: * single Via: header (first hop) and Contact: header has ;reg-id parameter - Non-REGISTER requests: + Non-REGISTER requests if either of the following conditions is true: * top Route header URI is myself and has ;ob parameter - * single Via: header and Contact: header has ;ob parameter + * Supported: outbound... header, single Via: header, and Contact: + header has ;ob parameter 1.2. Edge Proxy Keep-Alives (STUN)

1 0

git:master:1a48c1d1: outbound: docs - more tweaks
by S-P Chan 02 May '25

02 May '25

Module: kamailio Branch: master Commit: 1a48c1d18e3c6fa21394eb2075a1b348757c47a0 URL: https://github.com/kamailio/kamailio/commit/1a48c1d18e3c6fa21394eb2075a1b34… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-05-02T10:12:42+08:00 outbound: docs - more tweaks --- Modified: src/modules/outbound/doc/outbound_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1a48c1d18e3c6fa21394eb2075a1b34… Patch: https://github.com/kamailio/kamailio/commit/1a48c1d18e3c6fa21394eb2075a1b34… --- diff --git a/src/modules/outbound/doc/outbound_admin.xml b/src/modules/outbound/doc/outbound_admin.xml index e2f3e3f468f..55a54ed434f 100644 --- a/src/modules/outbound/doc/outbound_admin.xml +++ b/src/modules/outbound/doc/outbound_admin.xml @@ -22,10 +22,11 @@ <section> <title>Conditions</title> - <para>The module analyzes SIP requests so that users (e.g. path, rr) + <para>The module analyses SIP requests so that other module (e.g. path, rr) can determine whether to apply RFC5626 processing. This section applies if outbound processing - is not forced by the <code>force_outbound_flag</code> flag.</para> + is not forced by the <code>force_outbound_flag</code> flag, or disabled with + <code>force_no_outbound_flag</code>.</para> <para><code>REGISTER</code> request: <itemizedlist> <listitem> @@ -33,13 +34,14 @@ </listitem> </itemizedlist> </para> - <para>Non-<code>REGISTER</code> requests: + <para>Non-<code>REGISTER</code> requests if either of the following conditions is true: <itemizedlist> <listitem> <para>top Route header URI is myself and has <code>;ob</code> parameter</para> </listitem> <listitem> - <para>single <code>Via:</code> header and <code>Contact:</code> header has <code>;ob</code> parameter</para> + <para><code>Supported: outbound...</code> header, single <code>Via:</code> header, + and <code>Contact:</code> header has <code>;ob</code> parameter</para> </listitem> </itemizedlist> </para>

1 0

git:master:4ade5f53: secfilter: fix table of contents index points [skip ci]
by pepelux 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 4ade5f53c1f7f6eb7357b0561b67928e39a91b9f URL: https://github.com/kamailio/kamailio/commit/4ade5f53c1f7f6eb7357b0561b67928… Author: pepelux <pepeluxx(a)gmail.com> Committer: pepelux <pepeluxx(a)gmail.com> Date: 2025-04-30T22:49:54+02:00 secfilter: fix table of contents index points [skip ci] --- Modified: src/modules/secfilter/doc/secfilter_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4ade5f53c1f7f6eb7357b0561b67928… Patch: https://github.com/kamailio/kamailio/commit/4ade5f53c1f7f6eb7357b0561b67928… --- diff --git a/src/modules/secfilter/doc/secfilter_admin.xml b/src/modules/secfilter/doc/secfilter_admin.xml index 07eaa565267..8f2493f1711 100644 --- a/src/modules/secfilter/doc/secfilter_admin.xml +++ b/src/modules/secfilter/doc/secfilter_admin.xml @@ -827,7 +827,6 @@ </programlisting> </example> </section> - </section> <section id="secfilter.r.del_wl"> <title> @@ -855,6 +854,7 @@ </programlisting> </example> </section> + </section> <section> <title>Installation</title>

1 0

Re: [kamailio/kamailio] secfilter: fix table of contents index points [skip ci] (c92795b)
by Jose Luis Verdeguer 30 Apr '25

30 Apr '25

I'm sorry @miconda -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd15ba3e32d/156150906(a)github.com>

1 0

Re: [kamailio/kamailio] secfilter: fix table of contents index points [skip ci] (c92795b)
by Daniel-Constantin Mierla 30 Apr '25

30 Apr '25

For the records and future consideration: the README file for a module must not be changed manually, it is generated from the xml files located in the `doc/` subfolder of the module directory. If you want to change something in the README file, change inside the xml files and a job on kamailio.org server will generate and push to git the updated README content. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd15ba3e32d/156146968(a)github.com>

1 0

git:master:c92795b6: secfilter: fix table of contents index points [skip ci]
by pepelux 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: c92795b672ce8cfc7ff0ff361e5fdbd15ba3e32d URL: https://github.com/kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd… Author: pepelux <pepeluxx(a)gmail.com> Committer: pepelux <pepeluxx(a)gmail.com> Date: 2025-04-30T17:36:31+02:00 secfilter: fix table of contents index points [skip ci] --- Modified: src/modules/secfilter/README --- Diff: https://github.com/kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd… Patch: https://github.com/kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd… --- diff --git a/src/modules/secfilter/README b/src/modules/secfilter/README index e3efbd172a4..574e9446c74 100644 --- a/src/modules/secfilter/README +++ b/src/modules/secfilter/README @@ -52,16 +52,16 @@ Jose Luis Verdeguer 5.7. secfilter.add_bl 5.8. secfilter.del_bl 5.9. secfilter.add_wl + 5.10. secfilter.del_wl - 6. secfilter.del_wl - 7. Installation + 6. Installation - 7.1. Database setup + 6.1. Database setup - 8. Some examples + 7. Some examples - 8.1. Print data - 8.2. Statistics + 7.1. Print data + 7.2. Statistics List of Examples @@ -140,16 +140,16 @@ Chapter 1. Admin Guide 5.7. secfilter.add_bl 5.8. secfilter.del_bl 5.9. secfilter.add_wl + 5.10. secfilter.del_wl - 6. secfilter.del_wl - 7. Installation + 6. Installation - 7.1. Database setup + 6.1. Database setup - 8. Some examples + 7. Some examples - 8.1. Print data - 8.2. Statistics + 7.1. Print data + 7.2. Statistics 1. Overview @@ -555,6 +555,7 @@ d in the user-agent header ($ua)"); 5.7. secfilter.add_bl 5.8. secfilter.del_bl 5.9. secfilter.add_wl + 5.10. secfilter.del_wl 5.1. secfilter.reload @@ -674,7 +675,7 @@ d in the user-agent header ($ua)"); kamcmd secfilter.add_wl user trusted_user ... -6. secfilter.del_wl +5.10. secfilter.del_wl Delete value from whitelist. @@ -688,11 +689,11 @@ d in the user-agent header ($ua)"); kamcmd secfilter.del_wl user trusted_user ... -7. Installation +6. Installation - 7.1. Database setup + 6.1. Database setup -7.1. Database setup +6.1. Database setup Before running Kamailio with the secfilter module, it is necessary to set up the database table where the module will read the blacklist data @@ -736,12 +737,12 @@ d in the user-agent header ($ua)"); * 3 (IP address) * 4 (user) -8. Some examples +7. Some examples - 8.1. Print data - 8.2. Statistics + 7.1. Print data + 7.2. Statistics -8.1. Print data +7.1. Print data Example 1.29. kamcmd secfilter.print ua ... @@ -775,7 +776,7 @@ d in the user-agent header ($ua)"); } ... -8.2. Statistics +7.2. Statistics Example 1.30. kamcmd secfilter.stats ...

1 0

git:master:39a0aae9: modules: readme files regenerated - secfilter ... [skip ci]
by Kamailio Dev 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 39a0aae9c75f3d76c9b3d7f41a27a7fb26ce3e01 URL: https://github.com/kamailio/kamailio/commit/39a0aae9c75f3d76c9b3d7f41a27a7f… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-30T16:01:11+02:00 modules: readme files regenerated - secfilter ... [skip ci] --- Modified: src/modules/secfilter/README --- Diff: https://github.com/kamailio/kamailio/commit/39a0aae9c75f3d76c9b3d7f41a27a7f… Patch: https://github.com/kamailio/kamailio/commit/39a0aae9c75f3d76c9b3d7f41a27a7f…

1 0

[kamailio/kamailio] secfilter‌: support remove rule in Whitelist and Blacklist (PR #4089)
by AsedMorteza 30 Apr '25

30 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description ##### **Summary** This update introduces new functionality to the `secfilter` module, enabling the removal of entries from both the Blacklist and Whitelist. It also includes automatic detection and removal of duplicate values from these lists. ##### **Details** * Users can now remove specific entries from the Blacklist or Whitelist based on type (e.g., IP, domain, user) and a given value. * Supports removal of single or multiple matching entries in one operation. ##### **Benefits** - Improves the usability and flexibility of the `secfilter` module by allowing fine-grained control over list management. - Ensures that the Blacklist and Whitelist are kept clean and free from redundant entries. - Enhances performance by reducing unnecessary duplication in the lists. ##### Testing This feature was tested using `kmcmd` commands in various scenarios: - Removing the **first element** in the list. - Removing an element from the **middle** of the list. - Removing the **last element** in the list. - Removing **all matching elements** in the list. In all cases, the commands worked correctly, and the lists were updated and cleaned as expected. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4089 -- Commit Summary -- * secfilter‌: support remove rule in Whitelist and Blacklist -- File Changes -- M src/modules/secfilter/secfilter.c (8) M src/modules/secfilter/secfilter.h (3) M src/modules/secfilter/secfilter_db.c (106) M src/modules/secfilter/secfilter_rpc.c (95) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4089.patch https://github.com/kamailio/kamailio/pull/4089.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4089 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4089(a)github.com>

6 11

git:master:e8732629: secfilter: add RPC del_* commands [skip ci]
by Victor Seva 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: e87326297a30f2adeaa4936da4e1e30fa5a81dc8 URL: https://github.com/kamailio/kamailio/commit/e87326297a30f2adeaa4936da4e1e30… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-04-30T15:53:39+02:00 secfilter: add RPC del_* commands [skip ci] Related #4089 --- Modified: src/modules/secfilter/doc/secfilter_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/e87326297a30f2adeaa4936da4e1e30… Patch: https://github.com/kamailio/kamailio/commit/e87326297a30f2adeaa4936da4e1e30… --- diff --git a/src/modules/secfilter/doc/secfilter_admin.xml b/src/modules/secfilter/doc/secfilter_admin.xml index 97772e3844f..07eaa565267 100644 --- a/src/modules/secfilter/doc/secfilter_admin.xml +++ b/src/modules/secfilter/doc/secfilter_admin.xml @@ -718,6 +718,31 @@ </example> </section> + <section id="secfilter.r.del_dst"> + <title> + <function moreinfo="none">secfilter.del_dst</function> + </title> + + <para>Delete value from destination blacklist.</para> + + <para> + Parameters: + <itemizedlist> + <listitem>number (number to remove from the destination blacklist)</listitem> + </itemizedlist> + </para> + + <example> + <title><function>secfilter.del_dst</function> usage</title> + + <programlisting format="linespecific"> + ... + &kamcmd; secfilter.del_dst 555123123 + ... + </programlisting> + </example> + </section> + <section id="secfilter.r.add_bl"> <title> <function moreinfo="none">secfilter.add_bl</function> @@ -747,6 +772,33 @@ </example> </section> + <section id="secfilter.r.del_bl"> + <title> + <function moreinfo="none">secfilter.del_bl</function> + </title> + + <para>Delete value from blacklist.</para> + + <para> + Parameters: + <itemizedlist> + <listitem>type (must be: ua, country, domain, user or ip)</listitem> + <listitem>value (value to remove from the blacklist)</listitem> + </itemizedlist> + </para> + + <example> + <title><function>secfilter.del_bl</function> usage</title> + + <programlisting format="linespecific"> + ... + &kamcmd; secfilter.del_bl ua friendly-scanner + &kamcmd; secfilter.del_bl user sipvicious + ... + </programlisting> + </example> + </section> + <section id="secfilter.r.add_wl"> <title> <function moreinfo="none">secfilter.add_wl</function> @@ -777,6 +829,33 @@ </section> </section> + <section id="secfilter.r.del_wl"> + <title> + <function moreinfo="none">secfilter.del_wl</function> + </title> + + <para>Delete value from whitelist.</para> + + <para> + Parameters: + <itemizedlist> + <listitem>type (must be: ua, country, domain, user or ip)</listitem> + <listitem>value (value to remove from the blacklist)</listitem> + </itemizedlist> + </para> + + <example> + <title><function>secfilter.del_wl</function> usage</title> + + <programlisting format="linespecific"> + ... + &kamcmd; secfilter.del_wl country es + &kamcmd; secfilter.del_wl user trusted_user + ... + </programlisting> + </example> + </section> + <section> <title>Installation</title>

1 0

git:master:dca075fe: secfilter: add missing RPC del_wl command
by Victor Seva 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: dca075fec723fa9d1d64997d6d5c0a992780c83c URL: https://github.com/kamailio/kamailio/commit/dca075fec723fa9d1d64997d6d5c0a9… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-04-30T15:53:14+02:00 secfilter: add missing RPC del_wl command Related #4089 --- Modified: src/modules/secfilter/secfilter.c --- Diff: https://github.com/kamailio/kamailio/commit/dca075fec723fa9d1d64997d6d5c0a9… Patch: https://github.com/kamailio/kamailio/commit/dca075fec723fa9d1d64997d6d5c0a9… --- diff --git a/src/modules/secfilter/secfilter.c b/src/modules/secfilter/secfilter.c index 99807154edd..eed7ef9b6a4 100644 --- a/src/modules/secfilter/secfilter.c +++ b/src/modules/secfilter/secfilter.c @@ -145,6 +145,7 @@ rpc_export_t secfilter_rpc[] = { {"secfilter.add_bl", secf_rpc_add_bl, rpc_add_bl_doc, 0}, {"secfilter.del_bl", secf_rpc_del_bl, rpc_del_bl_doc, 0}, {"secfilter.add_wl", secf_rpc_add_wl, rpc_add_wl_doc, 0}, + {"secfilter.del_wl", secf_rpc_del_wl, rpc_del_wl_doc, 0}, {0, 0, 0, 0} }; /* clang-format on */

1 0

git:master:1543ddae: modules: readme files regenerated - topoh ... [skip ci]
by Kamailio Dev 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 1543ddae588b339c8346875a93d3be170bf8d3df URL: https://github.com/kamailio/kamailio/commit/1543ddae588b339c8346875a93d3be1… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-30T15:16:10+02:00 modules: readme files regenerated - topoh ... [skip ci] --- Modified: src/modules/topoh/README --- Diff: https://github.com/kamailio/kamailio/commit/1543ddae588b339c8346875a93d3be1… Patch: https://github.com/kamailio/kamailio/commit/1543ddae588b339c8346875a93d3be1… --- diff --git a/src/modules/topoh/README b/src/modules/topoh/README index 0217b90d30f..e4d065fa748 100644 --- a/src/modules/topoh/README +++ b/src/modules/topoh/README @@ -45,6 +45,8 @@ Daniel-Constantin Mierla 4.1. event_route[topoh:msg-outgoing] 4.2. event_route[topoh:msg-sending] + 5. Pesudo-Variables + List of Examples 1.1. Set mask_key parameter @@ -96,6 +98,8 @@ Chapter 1. Admin Guide 4.1. event_route[topoh:msg-outgoing] 4.2. event_route[topoh:msg-sending] + 5. Pesudo-Variables + 1. Overview This module hides the SIP routing headers that show topology details. @@ -385,3 +389,7 @@ event_route[topoh:msg-sending] { } } ... + +5. Pesudo-Variables + + - $th(ecallid) - return the topoh-encoded Call-Id

1 0

git:master:022f9ed2: topoh: docs listed $th(ecallid)
by Daniel-Constantin Mierla 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 022f9ed2a49e9e72d323aa33d0ff7209c33f945f URL: https://github.com/kamailio/kamailio/commit/022f9ed2a49e9e72d323aa33d0ff720… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-30T12:26:30+02:00 topoh: docs listed $th(ecallid) --- Modified: src/modules/topoh/doc/topoh_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/022f9ed2a49e9e72d323aa33d0ff720… Patch: https://github.com/kamailio/kamailio/commit/022f9ed2a49e9e72d323aa33d0ff720… --- diff --git a/src/modules/topoh/doc/topoh_admin.xml b/src/modules/topoh/doc/topoh_admin.xml index 1aaffcecbce..feac68d02aa 100644 --- a/src/modules/topoh/doc/topoh_admin.xml +++ b/src/modules/topoh/doc/topoh_admin.xml @@ -435,4 +435,10 @@ event_route[topoh:msg-sending] { </example> </section> </section> + <section> + <title>Pesudo-Variables</title> + <para> + <emphasis>- $th(ecallid)</emphasis> - return the topoh-encoded Call-Id + </para> + </section> </chapter>

1 0

git:master:5fd6ff04: topoh: added $th(ecallid) - return encoded call id
by Daniel-Constantin Mierla 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 5fd6ff04e2ef8365dfabe16d4d612ac7ee5fbecf URL: https://github.com/kamailio/kamailio/commit/5fd6ff04e2ef8365dfabe16d4d612ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-30T12:26:30+02:00 topoh: added $th(ecallid) - return encoded call id --- Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/5fd6ff04e2ef8365dfabe16d4d612ac… Patch: https://github.com/kamailio/kamailio/commit/5fd6ff04e2ef8365dfabe16d4d612ac… --- diff --git a/src/modules/topoh/topoh_mod.c b/src/modules/topoh/topoh_mod.c index b2f10d120e0..ebda46571f8 100644 --- a/src/modules/topoh/topoh_mod.c +++ b/src/modules/topoh/topoh_mod.c @@ -46,6 +46,7 @@ #include "../../core/fmsg.h" #include "../../core/onsend.h" #include "../../core/kemi.h" +#include "../../core/pvapi.h" #include "../../core/str_hash.h" #include "../../core/parser/msg_parser.h" #include "../../core/parser/parse_uri.h" @@ -117,7 +118,17 @@ static str _th_eventrt_outgoing_name = str_init("topoh:msg-outgoing"); static int _th_eventrt_sending = -1; static str _th_eventrt_sending_name = str_init("topoh:msg-sending"); +static int pv_parse_th_name(pv_spec_t *sp, str *in); +static int pv_get_th(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); + /* clang-format off */ +static pv_export_t mod_pvs[] = { + {{"th", (sizeof("th") - 1)}, PVT_OTHER, pv_get_th, 0, pv_parse_th_name, + 0, 0, 0}, + + {{0, 0}, 0, 0, 0, 0, 0, 0, 0} +}; + static param_export_t params[] = { {"mask_key", PARAM_STR, &_th_key}, {"mask_ip", PARAM_STR, &th_ip}, @@ -148,7 +159,7 @@ struct module_exports exports = { cmds, /* exported functions */ params, /* exported parameters */ 0, /* exported rpc functions */ - 0, /* exported pseudo-variables */ + mod_pvs, /* exported pseudo-variables */ 0, /* response handling function */ mod_init, /* module init function */ 0, /* per-child init function */ @@ -801,6 +812,66 @@ int th_execute_event_route(sip_msg_t *msg, sr_event_param_t *evp, int evtype, return 0; } +static int pv_parse_th_name(pv_spec_t *sp, str *in) +{ + if(sp == NULL || in == NULL || in->len <= 0) + return -1; + + switch(in->len) { + case 7: + if(strncmp(in->s, "ecallid", 7) == 0) + sp->pvp.pvn.u.isname.name.n = 0; + else + goto error; + break; + default: + goto error; + } + sp->pvp.pvn.type = PV_NAME_INTSTR; + sp->pvp.pvn.u.isname.type = 0; + + return 0; + +error: + LM_ERR("unknown PV th key: %.*s\n", in->len, in->s); + return -1; +} + +static str _th_masked_callid = STR_NULL; + +/** + * + */ +static int pv_get_th(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + if(msg == NULL) { + return pv_get_null(msg, param, res); + } + + if(param == NULL) { + return pv_get_null(msg, param, res); + } + + if(msg->callid == NULL + && ((parse_headers(msg, HDR_CALLID_F, 0) == -1) + || (msg->callid == NULL))) { + LM_ERR("cannot parse Call-Id header\n"); + return pv_get_null(msg, param, res); + } + + switch(param->pvn.u.isname.name.n) { + case 0: /* masked call-id */ + if(th_mask_callid_str(&msg->callid->body, &_th_masked_callid) < 0) { + LM_ERR("cannot encode Call-Id\n"); + return pv_get_null(msg, param, res); + } + return pv_get_strval(msg, param, res, &_th_masked_callid); + + default: + return pv_get_null(msg, param, res); + } +} + /** * */

1 0

git:master:f68cd7a4: modules: readme files regenerated - outbound ... [skip ci]
by Kamailio Dev 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: f68cd7a4b1d035d48c28b774dcf9b9bde557f38f URL: https://github.com/kamailio/kamailio/commit/f68cd7a4b1d035d48c28b774dcf9b9b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-30T03:46:09+02:00 modules: readme files regenerated - outbound ... [skip ci] --- Modified: src/modules/outbound/README --- Diff: https://github.com/kamailio/kamailio/commit/f68cd7a4b1d035d48c28b774dcf9b9b… Patch: https://github.com/kamailio/kamailio/commit/f68cd7a4b1d035d48c28b774dcf9b9b… --- diff --git a/src/modules/outbound/README b/src/modules/outbound/README index aa712cd73fc..af2f86cb3c2 100644 --- a/src/modules/outbound/README +++ b/src/modules/outbound/README @@ -75,12 +75,13 @@ Chapter 1. Admin Guide determine whether to apply RFC5626 processing. This section applies if outbound processing is not forced by the force_outbound_flag flag. - REGISTER request — - * single Via: (first hop) and Contact: has ;ob parameter + REGISTER request: + * single Via: header (first hop) and Contact: header has ;reg-id + parameter - Non-REGISTER requests — - * top Route header is me and has ;ob parameter - * single Via: and Contact: URI has ;ob parameter + Non-REGISTER requests: + * top Route header URI is myself and has ;ob parameter + * single Via: header and Contact: header has ;ob parameter 1.2. Edge Proxy Keep-Alives (STUN)

1 0

git:master:35e622df: outbound: docs fix reference to wrong parameter in REGISTER
by S-P Chan 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 35e622df641013ddac4d8f6dc79ffcd9be7fde46 URL: https://github.com/kamailio/kamailio/commit/35e622df641013ddac4d8f6dc79ffcd… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-30T09:41:08+08:00 outbound: docs fix reference to wrong parameter in REGISTER - should be ;reg-id, not ;ob --- Modified: src/modules/outbound/doc/outbound_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/35e622df641013ddac4d8f6dc79ffcd… Patch: https://github.com/kamailio/kamailio/commit/35e622df641013ddac4d8f6dc79ffcd… --- diff --git a/src/modules/outbound/doc/outbound_admin.xml b/src/modules/outbound/doc/outbound_admin.xml index 69a4b304a92..e2f3e3f468f 100644 --- a/src/modules/outbound/doc/outbound_admin.xml +++ b/src/modules/outbound/doc/outbound_admin.xml @@ -26,20 +26,20 @@ can determine whether to apply RFC5626 processing. This section applies if outbound processing is not forced by the <code>force_outbound_flag</code> flag.</para> - <para><code>REGISTER</code> request — + <para><code>REGISTER</code> request: <itemizedlist> <listitem> - <para>single Via: (first hop) and <code>Contact:</code> has <code>;ob</code> parameter</para> + <para>single <code>Via:</code> header (first hop) and <code>Contact:</code> header has <code>;reg-id</code> parameter</para> </listitem> </itemizedlist> </para> - <para>Non-<code>REGISTER</code> requests — + <para>Non-<code>REGISTER</code> requests: <itemizedlist> <listitem> - <para>top Route header is me and has <code>;ob</code> parameter</para> + <para>top Route header URI is myself and has <code>;ob</code> parameter</para> </listitem> <listitem> - <para>single Via: and Contact: URI has <code>;ob</code> parameter</para> + <para>single <code>Via:</code> header and <code>Contact:</code> header has <code>;ob</code> parameter</para> </listitem> </itemizedlist> </para>

1 0

git:master:2e23bf67: modules: readme files regenerated - outbound ... [skip ci]
by Kamailio Dev 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 2e23bf67839cff85cdd4413cedab5d2c4757f8f4 URL: https://github.com/kamailio/kamailio/commit/2e23bf67839cff85cdd4413cedab5d2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-30T02:46:09+02:00 modules: readme files regenerated - outbound ... [skip ci] --- Modified: src/modules/outbound/README --- Diff: https://github.com/kamailio/kamailio/commit/2e23bf67839cff85cdd4413cedab5d2… Patch: https://github.com/kamailio/kamailio/commit/2e23bf67839cff85cdd4413cedab5d2…

1 0

git:master:fa458f97: outbound: docs - fix bad XML
by S-P Chan 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: fa458f97c307f590d1f3d726d22786fbbe337b09 URL: https://github.com/kamailio/kamailio/commit/fa458f97c307f590d1f3d726d22786f… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-30T08:43:57+08:00 outbound: docs - fix bad XML --- Modified: src/modules/outbound/doc/outbound_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/fa458f97c307f590d1f3d726d22786f… Patch: https://github.com/kamailio/kamailio/commit/fa458f97c307f590d1f3d726d22786f… --- diff --git a/src/modules/outbound/doc/outbound_admin.xml b/src/modules/outbound/doc/outbound_admin.xml index 882f1225e9a..69a4b304a92 100644 --- a/src/modules/outbound/doc/outbound_admin.xml +++ b/src/modules/outbound/doc/outbound_admin.xml @@ -25,11 +25,11 @@ <para>The module analyzes SIP requests so that users (e.g. path, rr) can determine whether to apply RFC5626 processing. This section applies if outbound processing - is not forced by the <code>force_outbound_flag<code> flag.</para> + is not forced by the <code>force_outbound_flag</code> flag.</para> <para><code>REGISTER</code> request — <itemizedlist> <listitem> - <para>single Via: (first hop) and <code>Contact:</code> has <code>;ob</code> parameter + <para>single Via: (first hop) and <code>Contact:</code> has <code>;ob</code> parameter</para> </listitem> </itemizedlist> </para>

1 0

git:master:6114c433: modules: readme files regenerated - outbound ... [skip ci]
by Kamailio Dev 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 6114c4338a9175d0bff05e6b7bbd0d9a00bfa25f URL: https://github.com/kamailio/kamailio/commit/6114c4338a9175d0bff05e6b7bbd0d9… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-30T01:46:09+02:00 modules: readme files regenerated - outbound ... [skip ci] --- Modified: src/modules/outbound/README --- Diff: https://github.com/kamailio/kamailio/commit/6114c4338a9175d0bff05e6b7bbd0d9… Patch: https://github.com/kamailio/kamailio/commit/6114c4338a9175d0bff05e6b7bbd0d9…

1 0

git:master:1efbf2d4: outbound: docs - elaborate on when outbound processing is used
by S-P Chan 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 1efbf2d4e614ca7259ffa52941d4b1c089f2eb7f URL: https://github.com/kamailio/kamailio/commit/1efbf2d4e614ca7259ffa52941d4b1c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-30T07:34:12+08:00 outbound: docs - elaborate on when outbound processing is used --- Modified: src/modules/outbound/doc/outbound_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1efbf2d4e614ca7259ffa52941d4b1c… Patch: https://github.com/kamailio/kamailio/commit/1efbf2d4e614ca7259ffa52941d4b1c… --- diff --git a/src/modules/outbound/doc/outbound_admin.xml b/src/modules/outbound/doc/outbound_admin.xml index ed458c39495..882f1225e9a 100644 --- a/src/modules/outbound/doc/outbound_admin.xml +++ b/src/modules/outbound/doc/outbound_admin.xml @@ -19,6 +19,32 @@ used as an outbound Edge Proxy (see &rfc5626; section 5).</para> <para>The <emphasis>path</emphasis> and <emphasis>rr</emphasis> modules will bind to this module if it is loaded before they are.</para> + + <section> + <title>Conditions</title> + <para>The module analyzes SIP requests so that users (e.g. path, rr) + can determine whether to apply RFC5626 processing. + This section applies if outbound processing + is not forced by the <code>force_outbound_flag<code> flag.</para> + <para><code>REGISTER</code> request — + <itemizedlist> + <listitem> + <para>single Via: (first hop) and <code>Contact:</code> has <code>;ob</code> parameter + </listitem> + </itemizedlist> + </para> + <para>Non-<code>REGISTER</code> requests — + <itemizedlist> + <listitem> + <para>top Route header is me and has <code>;ob</code> parameter</para> + </listitem> + <listitem> + <para>single Via: and Contact: URI has <code>;ob</code> parameter</para> + </listitem> + </itemizedlist> + </para> + </section> + <section> <title>Edge Proxy Keep-Alives (STUN)</title> <para>Outbound Edge Proxies MUST support STUN NAT keep-alives

1 0

[kamailio/kamailio] Corrupted output with log-engine json (Issue #4203)
by Matteo 29 Apr '25

29 Apr '25

xadhoom created an issue (kamailio/kamailio#4203)  ### Description Enabled json logging engine, with the following setup: - kam cmd line params: `--log-engine=json:Mp` - prefix: `log_prefix=", \"callid\": \"$ci\",\"srcip\": \"$si\", \"ts\": $TV(Sn), \"method\": \"$rm\", \"mt\": $mt, \"ua\": \"$(ua{s.escape.common})\", \"cseq\": \"$hdr(CSeq)\", \"status\": $rs "` - another prefix (same result): `log_prefix=", \"callid\": \"$ci\", \"ts\": $TV(Sn) "` What I see that certain json lines are truncated, for example - one line is interrupted by another json entry - one line starts "truncated" ### Troubleshooting What I can observe is that seems to happens always with same "kind" of line, usually internal logs, which don't have callid etc. #### Log Messages  The following first 3 lines are ok, then the latest is corrupted: ``` { "time": "2025-04-04T15:51:44.448427533Z", "idx": 193, "pid": 200, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:51:44.448682606Z", "idx": 194, "pid": 201, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:52:14.448279053Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:52:14.448505797Z", "idx": 196, "pid": 203, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T15:52:14.448508084Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/parser/msg, "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } ``` or (notice 2nd line or 5th one) ``` { "time": "2025-04-04T16:13:33.789641936Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T16:13:33.789642978Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", ", "line": 265, "function": "ksr_evrt_pre_routing", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "event route core:pre-routing not defined" } line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" } { "time": "2025-04-04T16:13:33.789646470Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", "line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" } { "time": "2025-04-04T16:13:33.789648201Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1579, "function": "t_check_msg", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "msg (0x7f{ "time": "2025-04-04T16:13:33.789649346Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/receive.c"8f7a693c50) id=2/228 global id=1/228 T start=0xffffffffffffffff" } , "line": 637, "function": "receive_msg", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "cleaning up" } { "time": "2025-04-04T16:13:33.789652839Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1424, "function": "t_reply_matching", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "t_reply_matching: hash 26404 label 0 branch 0" } ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 6.0.1 ``` happens also with 5.8.x * **Operating System**:  ``` Debian noble, docker container ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4203 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4203(a)github.com>

3 8

git:master:2081b3aa: core: utils/tmrec - reworked bymonth matching for negative indexes
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 2081b3aac394223b68b849fbac2a9e5ac4392334 URL: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T11:49:04+02:00 core: utils/tmrec - reworked bymonth matching for negative indexes - GH #4214 --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… Patch: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index d609e136310..eec02d22431 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -1104,6 +1104,7 @@ int check_min_unit(tmrec_t *_trp, ac_tm_t *_atp, tr_res_t *_tsw) int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) { int i; + int v; ac_maxval_t *_amp = NULL; if(!_trp || !_atp) return REC_ERR; @@ -1117,10 +1118,12 @@ int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { - if(_atp->t.tm_mon - == ((_trp->bymonth->xxx[i] - 1) * _trp->bymonth->req[i] - + 12) - % 12) + if(_trp->bymonth->req[i] < 0) { + v = 12 - _trp->bymonth->xxx[i]; + } else { + v = _trp->bymonth->xxx[i] - 1; + } + if(_atp->t.tm_mon == v) break; } if(i >= _trp->bymonth->nr)

1 0

[kamailio/kamailio] dispatcher: Check if tm is enabled before probing (PR #4223)
by Xenofon Karamanos 29 Apr '25

29 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4212 #### Description  Probing a host correctly needs the tm module to be loaded. This PR adds a check for when adding a target in dispatcher with probing enabled to verify whether tm is loaded. If it's not, it emmits a warning and disable the probing to the target. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4223 -- Commit Summary -- * dispatcher: Check if tm is enabled before probing -- File Changes -- M src/modules/dispatcher/dispatch.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4223.patch https://github.com/kamailio/kamailio/pull/4223.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4223 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4223(a)github.com>

2 2

git:master:512c5f51: dispatcher: Check if tm is enabled before probing
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 512c5f51bba77529b9cc844a6b4904a1d6275c1e URL: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T09:28:29+02:00 dispatcher: Check if tm is enabled before probing --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… Patch: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index a49e5638cd3..a90daa2abfa 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -745,6 +745,12 @@ ds_dest_t *add_dest2list(int id, str uri, int flags, int priority, str *attrs, ds_dest_t *dp0 = NULL; ds_dest_t *dp1 = NULL; + /* Check if tm binding (by testing tmb.t_gett) is loaded and if not, disable the probing */ + if(tmb.t_gett == NULL && (flags & DS_PROBING_DST)) { + LM_WARN("tm module not loaded, disabling probing\n"); + flags &= ~DS_PROBING_DST; + } + dp = pack_dest(uri, flags, priority, attrs, dload); if(!dp) { goto error;

1 0

[kamailio/kamailio] The <bymonth> logic in tmrec_match() is flawed (Issue #4214)
by intliang 29 Apr '25

29 Apr '25

intliang created an issue (kamailio/kamailio#4214) ### Description The **<bymonth>** comparison logic in **tmrec_match()** fails to properly evaluate equivalence conditions, as shown below: ``` int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) { ... if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { if(_atp->t.tm_mon == (_trp->bymonth->xxx[i] * _trp->bymonth->req[i] + 12) % 12) break; } ... ``` ### Troubleshooting #### Reproduction Rule string: "20250403T100000|PT14H|weekly|20250425T000000|2|-1WE, -2WE|16|||4" Date time: 20250416T190000 Expected output: MATCH Actual output: NOT MATCH  #### Debugging Data  ``` ((lldb) p _trp->bymonth->xxx[0] (int) 4 (lldb) p _trp->bymonth->req[0] (int) 1 (lldb) p _atp->t.tm_mon (int) 3 (lldb) p _trp->bymonth->nr (int) 1 ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions The **tm_mon** field in the tm struct uses a 0-11 range (January=0), while the **<bymonth>** parameter follows a 1-12 convention (January=1) as documented in the tmrec module's README. Therefore, we should first decrement the value of **_trp->bymonth->xxx[i]** by 1 for proper conversion. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.1.0-dev0 (x86_64/Darwin) 9f24f1-dirty flags: , EXTRA_DEBUGUSE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, select, kqueue. id: 9f24f1 dirty compiled on 11:59:55 Apr 16 2025 with AppleClang 17.0.0.17000013 ``` * **Operating System**: ``` Darwin yintiliangdeMacBook-Pro19.local 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 18:41:43 PST 2024; root:xnu-11215.61.5~2/RELEASE_X86_64 x86_64 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4214 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4214(a)github.com>

2 2

git:master:8f1a8c50: core: utils/tmrec - decrement month for bymonth matching
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 8f1a8c50ff230a1fffdd6b376f172cabe9fe60e3 URL: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T09:23:07+02:00 core: utils/tmrec - decrement month for bymonth matching - struct tm uses 0-11, comparing with 1-12 in the date format - GH #4214 --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… Patch: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index 7cbe6153824..d609e136310 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -1118,7 +1118,8 @@ int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { if(_atp->t.tm_mon - == (_trp->bymonth->xxx[i] * _trp->bymonth->req[i] + 12) + == ((_trp->bymonth->xxx[i] - 1) * _trp->bymonth->req[i] + + 12) % 12) break; }

1 0

[kamailio/kamailio] Allow single quotes in From name (Issue #3984)
by ThomasSevestre 28 Apr '25

28 Apr '25

### Description `secf_check_sqli_all();` block requests when a single quote is present in From name : ``` From: "O'Reilly" <sip:100@example.net>;tag=abcd ``` Since single quotes are frequent in names. It makes it difficult to use this function. ### Possible Solutions A solution would be to skip single quote check in From name. I'll write the PR if you are OK with this solution -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3984 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3984(a)github.com>

5 10

[kamailio/kamailio] secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all(); (PR #4225)
by Jose Luis Verdeguer 28 Apr '25

28 Apr '25

secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all();   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3984 (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4225 -- Commit Summary -- * secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all(); -- File Changes -- M src/modules/secfilter/secfilter.c (56) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4225.patch https://github.com/kamailio/kamailio/pull/4225.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4225 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4225(a)github.com>

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev