Please package evapi into centos7 rpm.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2098
Module: kamailio
Branch: master
Commit: 4d045438c4451cfc70e995344a2cfb42eb0ccb30
URL: https://github.com/kamailio/kamailio/commit/4d045438c4451cfc70e995344a2cfb4…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-12-19T18:31:12+01:00
modules: readme files regenerated - cnxcc ... [skip ci]
---
Modified: src/modules/cnxcc/README
---
Diff: https://github.com/kamailio/kamailio/commit/4d045438c4451cfc70e995344a2cfb4…
Patch: https://github.com/kamailio/kamailio/commit/4d045438c4451cfc70e995344a2cfb4…
---
diff --git a/src/modules/cnxcc/README b/src/modules/cnxcc/README
index d2e317de72..425a473f16 100644
--- a/src/modules/cnxcc/README
+++ b/src/modules/cnxcc/README
@@ -188,18 +188,32 @@ modparam("cnxcc", "credit_check_period", 1)
Associates the call with a customer id and sets the max credit, connect
cost, cost per second, initial pulse and final pulse. The discount is
- calculated in pulses (30/6, 1/1, etc) and subtracted from the pool of
+ calculated in pulses (1/1, 60/1, etc) and subtracted from the pool of
credit.
The customer value can be provided as a string or a variable holding a
- string.
+ string. This value identifies all calls from the same customer.
+
+ The maxcredit (float) value is the maximum credit available for the
+ current call.
+
+ The connect (float) value is the connect cost for the current call.
+
+ The cps (float) value is the cost per second for the current call.
+
+ The ipuse (integer) value is the initial pulse and establishes the
+ minimum time to be charged. For example, value 1 establishes a charge
+ per second and value 60 sets a charge per minute. If it is taken as
+ value 60, even if the duration is 5 seconds, 1 minute will be charged.
- The maxcredit, connect and cps can be double (float) or integer values,
- they have to be provided as static string values of variables holding
- string values.
+ The fpulse (integer) value is the final pulse and establishes, from the
+ initial pulse, the time range to be charged. For example, the value 1
+ establishes a charge per second, 5 sets a charge in blocks of 5
+ seconds, 60 sets a full minute charge.
- The ipulse and fpulse values are integer values, they can be also given
- via variables holding integers.
+ 1/1 will make a charge per seconds for the entire call. 60/1 will make
+ a charge per seconds with the first full minute. 60/60 always perform a
+ full minute charge.
Return code:
* 1 - successful
@@ -210,12 +224,15 @@ modparam("cnxcc", "credit_check_period", 1)
...
cnxcc_set_max_credit("john-doe", "100", "3.0", "0.5", 60, 1);
...
-$var(customer) = "john-doe-premium"; # customer id
-$var(credit) = "100"; # max credit
-$var(connect) = "3.0"; # connect const
-$var(cps) = "0.5"; # cost per second
-$var(initial_p) = 60; # initial pulse
-$var(final_p) = 1; # final pulse
+$var(customer) = "john-doe"; # customer id
+$var(credit) = "100"; # max credit for all calls with the same
+ # customer id
+$var(connect) = "3.0"; # connect cost or initial cost for the call
+$var(cps) = "0.5"; # cost per second
+$var(initial_p) = 60; # initial pulse (60 = the first minute will be
+ # charged even if the call is shorter)
+$var(final_p) = 1; # final pulse (after the first minute, it will
+ # be charge in ranges of 1 second)
cnxcc_set_max_credit("$var(customer)", "$var(credit)", "$var(connect)",
"$var(cps)", "$var(initial_p)", "$var(final_p)");
...
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2182
-- Commit Summary --
* cnxcc: updated readme file [skip ci]
-- File Changes --
M src/modules/cnxcc/doc/cnxcc_admin.xml (45)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2182.patchhttps://github.com/kamailio/kamailio/pull/2182.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2182
Module: kamailio
Branch: master
Commit: cea7fa14b0aefc647d28eb1bf56faaec89d90d67
URL: https://github.com/kamailio/kamailio/commit/cea7fa14b0aefc647d28eb1bf56faae…
Author: Jose Luis Verdeguer <pepeluxx(a)gmail.com>
Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com>
Date: 2019-12-19T18:22:59+01:00
cnxcc: updated readme file [skip ci]
---
Modified: src/modules/cnxcc/doc/cnxcc_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/cea7fa14b0aefc647d28eb1bf56faae…
Patch: https://github.com/kamailio/kamailio/commit/cea7fa14b0aefc647d28eb1bf56faae…
---
diff --git a/src/modules/cnxcc/doc/cnxcc_admin.xml b/src/modules/cnxcc/doc/cnxcc_admin.xml
index 4284437a8b..0c26cb0a58 100644
--- a/src/modules/cnxcc/doc/cnxcc_admin.xml
+++ b/src/modules/cnxcc/doc/cnxcc_admin.xml
@@ -128,21 +128,37 @@ modparam("cnxcc", "credit_check_period", 1)
<para>
Associates the call with a customer id and sets the max credit,
connect cost, cost per second, initial pulse and final pulse. The discount
- is calculated in pulses (30/6, 1/1, etc) and subtracted from the pool
+ is calculated in pulses (1/1, 60/1, etc) and subtracted from the pool
of credit.
</para>
<para>
The customer value can be provided as a string or a variable holding
- a string.
+ a string. This value identifies all calls from the same customer.
+ </para>
+ <para>
+ The maxcredit (float) value is the maximum credit available for the current call.
+ </para>
+ <para>
+ The connect (float) value is the connect cost for the current call.
+ </para>
+ <para>
+ The cps (float) value is the cost per second for the current call.
+ </para>
+ <para>
+ The ipuse (integer) value is the initial pulse and establishes the minimum
+ time to be charged. For example, value 1 establishes a charge per second
+ and value 60 sets a charge per minute. If it is taken as value 60, even
+ if the duration is 5 seconds, 1 minute will be charged.
</para>
<para>
- The maxcredit, connect and cps can be double (float) or integer values, they
- have to be provided as static string values of variables holding string
- values.
+ The fpulse (integer) value is the final pulse and establishes, from the initial
+ pulse, the time range to be charged. For example, the value 1 establishes a charge
+ per second, 5 sets a charge in blocks of 5 seconds, 60 sets a full minute charge.
</para>
<para>
- The ipulse and fpulse values are integer values, they can be also
- given via variables holding integers.
+ 1/1 will make a charge per seconds for the entire call. 60/1 will make a
+ charge per seconds with the first full minute. 60/60 always perform
+ a full minute charge.
</para>
<para>
<emphasis>Return code:</emphasis>
@@ -173,12 +189,15 @@ modparam("cnxcc", "credit_check_period", 1)
...
cnxcc_set_max_credit("john-doe", "100", "3.0", "0.5", 60, 1);
...
-$var(customer) = "john-doe-premium"; # customer id
-$var(credit) = "100"; # max credit
-$var(connect) = "3.0"; # connect const
-$var(cps) = "0.5"; # cost per second
-$var(initial_p) = 60; # initial pulse
-$var(final_p) = 1; # final pulse
+$var(customer) = "john-doe"; # customer id
+$var(credit) = "100"; # max credit for all calls with the same
+ # customer id
+$var(connect) = "3.0"; # connect cost or initial cost for the call
+$var(cps) = "0.5"; # cost per second
+$var(initial_p) = 60; # initial pulse (60 = the first minute will be
+ # charged even if the call is shorter)
+$var(final_p) = 1; # final pulse (after the first minute, it will
+ # be charge in ranges of 1 second)
cnxcc_set_max_credit("$var(customer)", "$var(credit)", "$var(connect)",
"$var(cps)", "$var(initial_p)", "$var(final_p)");
...
Module: kamailio
Branch: 5.2
Commit: 9d8be519bb0cc97a20360652085da6aaed94e86e
URL: https://github.com/kamailio/kamailio/commit/9d8be519bb0cc97a20360652085da6a…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-12-19T17:46:43+01:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/9d8be519bb0cc97a20360652085da6a…
Patch: https://github.com/kamailio/kamailio/commit/9d8be519bb0cc97a20360652085da6a…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index 446055571c..ace384e35f 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -698,7 +698,7 @@ Note
set to TRYING state. This means that probing will be executed all
the time, but you can skip some servers with flag 4 in destination
list file, for example.
- * Value 2: if set to 2, only gateways in inactive state with probing
+ * Value 2: if set to 2, only gateways in INACTIVE state with PROBING
mode set are tested.
* Value 3: If set to 3, any gateway with state PROBING is continually
probed without modifying/removing the PROBING state. This allows
Module: kamailio
Branch: 5.3
Commit: 7fa917eef3c1940bb9a178b5e538fd9931dd431c
URL: https://github.com/kamailio/kamailio/commit/7fa917eef3c1940bb9a178b5e538fd9…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-12-19T17:46:29+01:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/7fa917eef3c1940bb9a178b5e538fd9…
Patch: https://github.com/kamailio/kamailio/commit/7fa917eef3c1940bb9a178b5e538fd9…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index 4f6f3c6b83..fee1d2f27a 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -710,7 +710,7 @@ Note
set to TRYING state. This means that probing will be executed all
the time, but you can skip some servers with flag 4 in destination
list file, for example.
- * Value 2: if set to 2, only gateways in inactive state with probing
+ * Value 2: if set to 2, only gateways in INACTIVE state with PROBING
mode set are tested.
* Value 3: If set to 3, any gateway with state PROBING is continually
probed without modifying/removing the PROBING state. This allows
Module: kamailio
Branch: master
Commit: 42bad429680d4dbf1201394de1a5579573bcac74
URL: https://github.com/kamailio/kamailio/commit/42bad429680d4dbf1201394de1a5579…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-12-19T17:46:13+01:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/42bad429680d4dbf1201394de1a5579…
Patch: https://github.com/kamailio/kamailio/commit/42bad429680d4dbf1201394de1a5579…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index 7408b51713..bdb27f57c7 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -714,7 +714,7 @@ Note
set to TRYING state. This means that probing will be executed all
the time, but you can skip some servers with flag 4 in destination
list file, for example.
- * Value 2: if set to 2, only gateways in inactive state with probing
+ * Value 2: if set to 2, only gateways in INACTIVE state with PROBING
mode set are tested.
* Value 3: If set to 3, any gateway with state PROBING is continually
probed without modifying/removing the PROBING state. This allows
Module: kamailio
Branch: 5.3
Commit: e57e8e9e9301982078005ca5fdd9ad9c6310de64
URL: https://github.com/kamailio/kamailio/commit/e57e8e9e9301982078005ca5fdd9ad9…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-12-19T17:44:25+01:00
dispatcher: small style fix in ds_probing_mode docs
(cherry picked from commit faccbb1cf62bfb625d0bcc9d1a52727dcdd962ff)
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/e57e8e9e9301982078005ca5fdd9ad9…
Patch: https://github.com/kamailio/kamailio/commit/e57e8e9e9301982078005ca5fdd9ad9…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index 75d26de330..f1cf9b7214 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -644,8 +644,8 @@ modparam("dispatcher", "force_dst", 1)
but you can skip some servers with flag 4 in destination list file, for example.</para>
</listitem>
<listitem>
- <para>Value 2: if set to 2, only gateways in inactive state with
- probing mode set are tested.</para>
+ <para>Value 2: if set to 2, only gateways in INACTIVE state with
+ PROBING mode set are tested.</para>
</listitem>
<listitem>
<para>Value 3: If set to 3, any gateway with state PROBING is continually probed
Module: kamailio
Branch: 5.2
Commit: fdd8bd3cce007e6256be5373d84413ffdeff802e
URL: https://github.com/kamailio/kamailio/commit/fdd8bd3cce007e6256be5373d84413f…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-12-19T17:43:48+01:00
dispatcher: small style fix in ds_probing_mode docs
(cherry picked from commit faccbb1cf62bfb625d0bcc9d1a52727dcdd962ff)
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/fdd8bd3cce007e6256be5373d84413f…
Patch: https://github.com/kamailio/kamailio/commit/fdd8bd3cce007e6256be5373d84413f…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index bcfa4a95c9..ed8b1808ad 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -644,8 +644,8 @@ modparam("dispatcher", "force_dst", 1)
but you can skip some servers with flag 4 in destination list file, for example.</para>
</listitem>
<listitem>
- <para>Value 2: if set to 2, only gateways in inactive state with
- probing mode set are tested.</para>
+ <para>Value 2: if set to 2, only gateways in INACTIVE state with
+ PROBING mode set are tested.</para>
</listitem>
<listitem>
<para>Value 3: If set to 3, any gateway with state PROBING is continually probed
Module: kamailio
Branch: 5.1
Commit: 45f6263470bc6866352d450a606d094a45bcbb70
URL: https://github.com/kamailio/kamailio/commit/45f6263470bc6866352d450a606d094…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-12-19T17:42:44+01:00
dispatcher: small style fix in ds_probing_mode docs
(cherry picked from commit faccbb1cf62bfb625d0bcc9d1a52727dcdd962ff)
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/45f6263470bc6866352d450a606d094…
Patch: https://github.com/kamailio/kamailio/commit/45f6263470bc6866352d450a606d094…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index c62385279c..2b486ad090 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -681,8 +681,8 @@ modparam("dispatcher", "force_dst", 1)
set to TRYING state.</para>
</listitem>
<listitem>
- <para>Value 2: if set to 2, only gateways in inactive state with
- probing mode set are tested.</para>
+ <para>Value 2: if set to 2, only gateways in INACTIVE state with
+ PROBING mode set are tested.</para>
</listitem>
<listitem>
<para>Value 3: If set to 3, any gateway with state PROBING is continually probed
I observed inconsistent behaviour in the dispatcher module. In some modes either the code needs to be fixed or the documentation adapted. As it is a widely used module, some feedback about this would be appreciated.
1) ds_probing_mode 0
This mode don't work together with a ds_inactive_threshold > 1 and gateway set to "IP". It will set a gateway to IX after the first successful ping. Therefore gateways will not be activated automatically. In mode "TP" it works and sets the gateway to "AX".
My suggestion would be to fix this in the code, that it behaves as mode 1 and 3: count to the ds_inactive_threshold and then set to "AX".
2) ds_probing_mode 2
According to the docs this should like this: “only gateways in inactive state with probing mode set are tested”. I understood it that it means gateways with mode "IP".
But according to my tests it also probes gateways in "TP" or "AP" probing state and changes this both to AX. Either the documentation or the module behaviour should be fixed.
The same issue mentioned above (ds_probing_mode 0 together with ds_inactive_threshold > 1) is also present. I also would suggest to fix it in the code here as well.
root@sip:/etc/kamailio# kamcmd core.version
kamailio 5.4.0-dev1 (x86_64/linux) 8ee711
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2100
Module: kamailio
Branch: master
Commit: faccbb1cf62bfb625d0bcc9d1a52727dcdd962ff
URL: https://github.com/kamailio/kamailio/commit/faccbb1cf62bfb625d0bcc9d1a52727…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-12-19T17:35:58+01:00
dispatcher: small style fix in ds_probing_mode docs
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/faccbb1cf62bfb625d0bcc9d1a52727…
Patch: https://github.com/kamailio/kamailio/commit/faccbb1cf62bfb625d0bcc9d1a52727…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index 4c9430a630..36bf343a0d 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -651,8 +651,8 @@ modparam("dispatcher", "force_dst", 1)
but you can skip some servers with flag 4 in destination list file, for example.</para>
</listitem>
<listitem>
- <para>Value 2: if set to 2, only gateways in inactive state with
- probing mode set are tested.</para>
+ <para>Value 2: if set to 2, only gateways in INACTIVE state with
+ PROBING mode set are tested.</para>
</listitem>
<listitem>
<para>Value 3: If set to 3, any gateway with state PROBING is continually probed
Module: kamailio
Branch: master
Commit: cb8b582f478d80e80d0dff492e0e376427182d91
URL: https://github.com/kamailio/kamailio/commit/cb8b582f478d80e80d0dff492e0e376…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-12-19T11:01:22+01:00
modules: readme files regenerated - ims_ipsec_pcscf ... [skip ci]
---
Modified: src/modules/ims_ipsec_pcscf/README
---
Diff: https://github.com/kamailio/kamailio/commit/cb8b582f478d80e80d0dff492e0e376…
Patch: https://github.com/kamailio/kamailio/commit/cb8b582f478d80e80d0dff492e0e376…
---
diff --git a/src/modules/ims_ipsec_pcscf/README b/src/modules/ims_ipsec_pcscf/README
index 32bb2d6000..fb95bae68b 100644
--- a/src/modules/ims_ipsec_pcscf/README
+++ b/src/modules/ims_ipsec_pcscf/README
@@ -54,7 +54,7 @@ Tsvetomir Dimitrov
4. Functions
4.1. ipsec_create(domain)
- 4.2. ipsec_forward(domain)
+ 4.2. ipsec_forward(domain, flags)
4.3. ipsec_destroy(domain)
List of Examples
@@ -93,7 +93,7 @@ Chapter 1. Admin Guide
4. Functions
4.1. ipsec_create(domain)
- 4.2. ipsec_forward(domain)
+ 4.2. ipsec_forward(domain, flags)
4.3. ipsec_destroy(domain)
1. Overview
@@ -222,7 +222,7 @@ modparam("ims_ipsec_pcscf", "ipsec_spi_id_range", 1000)
4. Functions
4.1. ipsec_create(domain)
- 4.2. ipsec_forward(domain)
+ 4.2. ipsec_forward(domain, flags)
4.3. ipsec_destroy(domain)
4.1. ipsec_create(domain)
@@ -241,7 +241,7 @@ modparam("ims_ipsec_pcscf", "ipsec_spi_id_range", 1000)
ipsec_create("location");
...
-4.2. ipsec_forward(domain)
+4.2. ipsec_forward(domain, flags)
The function processes redirects outgoing message via the IPSec tunnel
initiated with ipsec_create().
@@ -249,10 +249,15 @@ ipsec_create("location");
Meaning of the parameters is as follows:
* domain - Logical domain within the registrar. If a database is used
then this must be name of the table which stores the contacts.
+ flags - Set send force socket for request messages. If 1 - set
+ force socket for request messages. Useful for ipsec and TCP. This
+ is an optional parameter, default value - 0.
Example 1.9. ipsec_forward
...
ipsec_forward("location");
+# or
+ipsec_forward("location", "1");
...
4.3. ipsec_destroy(domain)
- added a new optional parameter in ipsec_forward()
to set or not 'send force socket' for request
messages. Useful for ipsec and tcp connections.
If set to 1 - send requests through existing
ipsec tunnel when tcp is used. In combination
with tcp_reuse_port=yes.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2176
-- Commit Summary --
* ims_ipsec_pcscf: new parameter in ipsec_forward()
-- File Changes --
M src/modules/ims_ipsec_pcscf/cmd.c (8)
M src/modules/ims_ipsec_pcscf/cmd.h (2)
M src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml (9)
M src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c (49)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2176.patchhttps://github.com/kamailio/kamailio/pull/2176.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2176
Module: kamailio
Branch: master
Commit: 6048a966df29b6447052b93cd86ecaf3eaaa7a41
URL: https://github.com/kamailio/kamailio/commit/6048a966df29b6447052b93cd86ecaf…
Author: Aleksandar Yosifov <alexyosifov(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-12-19T10:56:49+01:00
ims_ipsec_pcscf: new parameter in ipsec_forward()
- added a new optional parameter in ipsec_forward()
to set or not 'send force socket' for request
messages. Useful for ipsec and tcp connections.
If set to 1 - send requests through existing
ipsec tunnel when tcp is used. In combination
with tcp_reuse_port=yes.
---
Modified: src/modules/ims_ipsec_pcscf/cmd.c
Modified: src/modules/ims_ipsec_pcscf/cmd.h
Modified: src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
Modified: src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c
---
Diff: https://github.com/kamailio/kamailio/commit/6048a966df29b6447052b93cd86ecaf…
Patch: https://github.com/kamailio/kamailio/commit/6048a966df29b6447052b93cd86ecaf…
Module: kamailio
Branch: master
Commit: e99bfd2368c28e920f92af9ade1c29cb2ba709da
URL: https://github.com/kamailio/kamailio/commit/e99bfd2368c28e920f92af9ade1c29c…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-12-17T19:31:12+01:00
modules: readme files regenerated - tm ... [skip ci]
---
Modified: src/modules/tm/README
---
Diff: https://github.com/kamailio/kamailio/commit/e99bfd2368c28e920f92af9ade1c29c…
Patch: https://github.com/kamailio/kamailio/commit/e99bfd2368c28e920f92af9ade1c29c…
---
diff --git a/src/modules/tm/README b/src/modules/tm/README
index 4b23eacb58..71ae54e48e 100644
--- a/src/modules/tm/README
+++ b/src/modules/tm/README
@@ -117,7 +117,7 @@ Daniel-Constantin Mierla
4.36. t_lookup_cancel([1])
4.37. t_drop_replies([mode])
4.38. t_save_lumps()
- 4.39. t_load_contacts()
+ 4.39. t_load_contacts([mode])
4.40. t_next_contacts()
4.41. t_next_contact_flow()
4.42. t_check_status(re)
@@ -372,7 +372,7 @@ Chapter 1. Admin Guide
4.36. t_lookup_cancel([1])
4.37. t_drop_replies([mode])
4.38. t_save_lumps()
- 4.39. t_load_contacts()
+ 4.39. t_load_contacts([mode])
4.40. t_next_contacts()
4.41. t_next_contact_flow()
4.42. t_check_status(re)
@@ -1724,7 +1724,7 @@ modparam("tm", "rich_redirect", 3)
4.36. t_lookup_cancel([1])
4.37. t_drop_replies([mode])
4.38. t_save_lumps()
- 4.39. t_load_contacts()
+ 4.39. t_load_contacts([mode])
4.40. t_next_contacts()
4.41. t_next_contact_flow()
4.42. t_check_status(re)
@@ -2473,7 +2473,7 @@ failure_route[1] {
t_relay();
}
-4.39. t_load_contacts()
+4.39. t_load_contacts([mode])
This is the first of the three functions that can be used to implement
serial/parallel forking based on q and +sip.instance values of
@@ -2489,18 +2489,33 @@ failure_route[1] {
nothing.
If the current destination set contains more than one branch, the
- function sorts them according to increasing value of the q parameter
- and then stores the branches in reverse order into the XAVP.
+ function sorts them according to the algorithm selected with the 'mode'
+ paramenter and then stores the branches in reverse order into the XAVP.
The q parameter of a branch contains a value from range 0-1.0 and it
expresses relative preference of the branch among all branches in the
destination set. The higher the q value the more preference the user
- agent gave to the branch. Branches with higher q values will be tried
- before branches with lower ones when serial forking takes place.
+ agent gave to the branch. The parameter 'mode' controls which type of
+ algorithm kamailio will apply to sort the branches based on the q
+ values:
+
+ - '0' or missing: branches with higher q values will be tried before
+ branches with lower ones when serial forking takes place Equals q
+ values will result in a parallel forking.
+
+ - '1': branches are ordered using a proportional algorithm that uses to
+ q value as the weight of the branch. Higher is the q value, higher is
+ the probability to be tried as first. Equals q values means equals
+ probability to be tried. Differently from the previous mode there is no
+ possibility to have parallel forking. Branches with q values equals to
+ 0 or lower are not considered by the ordering algorithm, but just added
+ at the end of the list as backup option if all other branches fail.
+ This algorithm can be useful in case of endpoints in ACTIVE-ACTIVE
+ configuration to load-balance the calls.
After calling t_load_contacts(), function t_next_contacts() and
possibly also t_next_contact_flow() need to be called one or more times
- in order to retrieve the branches based on their q value.
+ in order to retrieve the branches based on their order.
Function returns 1 if loading of contacts succeeded or there was
nothing to do. In case of an error, function returns -1 (see syslog).
#### Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #2167
#### Description
Extended t_load_contacts function with the parameter 'mode'.
It can be used to define the algorithm to use for ordering the contacts.
If 0, or missing, the standard algorithm with be used.
If 1, the new weight-based algorithm will be used.
The new algorithm uses the q value as the weight of the branch.
Higher is the q value, higher is the probability to be tried as first. Equals q values means equals probability to be tried.
Branches with q values equals to 0 or lower are not considered by the ordering algorithm, but just added at the end of the list as backup option if all other branches fail.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2178
-- Commit Summary --
* tm: new weight-based call-termination distribution
-- File Changes --
M src/modules/tm/doc/functions.xml (33)
M src/modules/tm/t_serial.c (266)
M src/modules/tm/t_serial.h (7)
M src/modules/tm/tm.c (9)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2178.patchhttps://github.com/kamailio/kamailio/pull/2178.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2178
Module: kamailio
Branch: master
Commit: 1399714fbba63732f94eb8034dabb1e565ca832a
URL: https://github.com/kamailio/kamailio/commit/1399714fbba63732f94eb8034dabb1e…
Author: Marco Capetta <mcapetta(a)sipwise.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-12-17T19:29:36+01:00
tm: new weight-based call-termination distribution
Extended t_load_contacts function with the parameter 'mode'.
It can be used to define the algorithm to use for ordering
the contacts.
If 0, or missing, the standard algorithm with be used.
If 1, the new weight-based algorithm will be used.
The new algorithm uses the q value as the weight of the branch.
Higher is the q value, higher is the probability to be tried
as first. Equals q values means equals probability to be tried.
Branches with q values equals to 0 or lower are not considered by
the ordering algorithm, but just added at the end of the list
as backup option if all other branches fail.
---
Modified: src/modules/tm/doc/functions.xml
Modified: src/modules/tm/t_serial.c
Modified: src/modules/tm/t_serial.h
Modified: src/modules/tm/tm.c
---
Diff: https://github.com/kamailio/kamailio/commit/1399714fbba63732f94eb8034dabb1e…
Patch: https://github.com/kamailio/kamailio/commit/1399714fbba63732f94eb8034dabb1e…
- only handles active dialogs in state 4
- wipes out a given dialog callously
- no subcalls to dialog-ending functions
- dialog is then removed by the recurring cleaning function execution
- as discussed in sr-users in topic "[Dialog] Removing entries from dialog memory"
#### Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Hi,
As discussed in the sr-users mailing-list, I am proposing this PR to add a very simple new rpc command to the dialog module. dlg.kill_active_dialog kills any given active dialog from memory.
A paragraph in the dialog documentation precises the dangerous nature of this command, to be used with caution.
Please feel free to discuss about it.
Thanks!
Julien
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2111
-- Commit Summary --
* dialog: adding RPC dlg.kill_active_dlg command
-- File Changes --
M src/modules/dialog/dialog.c (56)
M src/modules/dialog/doc/dialog.xml (5)
M src/modules/dialog/doc/dialog_admin.xml (33)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2111.patchhttps://github.com/kamailio/kamailio/pull/2111.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2111
Hi I am using kamailio server to forward the request to a new
kamailio-server which listens only on TLS.
*problem: Not able to specify the dispatcher with tls protocol*
I am using the below configuration in dispatcher.list
kamailio version:4.4.2
*# setid(integer) destination(sip uri) flags (integer, optional),
priority(int,opt), attrs (str,optional)1 sip:mynetwork.com
<http://mynetwork.com/>;transport=tls 8 1 socket=tls:mynetwork.com:5328
<http://mynetwork.com:5328/>*
and if I specify the destination as just sip:mynetwork.com:5328 with out
attrs and transport=tls if is falling back to UDP.
Thank you
vinod.M.N
(adding sr-dev list to CC)
Hi Michael,
small general addition - you are probably already aware of this
documentation:
https://www.asipto.com/pub/kamailio-devel-guide/
There is work going on right now to update it, it needs also some
extensions, e.g. for the PV core functions.
Cheers,
Henning
Am 13.12.19 um 19:10 schrieb Michael Iedema:
> Hi all,
>
> I’m trying to write a basic Kamailio module from scratch and have run into an area where I’m in need of a couple pointers (pun not intended). :-) I have the module loading correctly and can call a function in my routing script like this:
>
> mymod_getinfo(“5551234”);
>
> This, for now, just triggers a print of the submitted parameter.
>
> What I’d like to do next is have it accept and print the From URI in configuration script like so:
>
> mymod_getinfo(“$fU”);
>
> For now, this prints the string literal of “$fU” and I’m trying to extract the value of the referenced variable and print that. The example module “print” does not involve this concept of pseudo-variables. The skeleton module example in the wiki also does not mention variables.
>
> I’ve looked into other modules to see how it works but they all seem to have a slightly different handling of this task. Can someone point me to an example in the modules which accomplishes this?
>
> What I’ve been searching for is a replace_all function which accepts a string containing pseudo-variables and returns a new string with them all replaced with their corresponding values.
>
> Thanks in advance and apologies if I’ve overlooked a relevant piece of developer documentation or if I’m looking at this incorrectly.
>
> Regards,
> -Michael
>
>
> _______________________________________________
> Kamailio (SER) - Users Mailing List
> sr-users(a)lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Kamailio Merchandising - https://skalatan.de/merchandising/
Kamailio services - https://skalatan.de/services
Henning Westerholt - https://skalatan.de/blog/
Module: kamailio
Branch: master
Commit: 36d941442496a51e265bdb96362624b667a40132
URL: https://github.com/kamailio/kamailio/commit/36d941442496a51e265bdb96362624b…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-12-13T18:46:09+01:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/36d941442496a51e265bdb96362624b…
Patch: https://github.com/kamailio/kamailio/commit/36d941442496a51e265bdb96362624b…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index 6929bfaf84..7408b51713 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -1295,24 +1295,24 @@ if(ds_list_exists("10")) {
Description of parameters:
* groupid (optional) - if not given or its value is -1, the matching
- will be done over all addresses in all dispacher groups. Otherwise
+ will be done over all addresses in all dispatcher groups. Otherwise
the matching will be done only against the addresses in the
specific group id. The parameter can be an integer or a variable
holding an integer value.
* mode - (optional) - a bitmask to specify how the matching should be
- done. If is 0, all ip, port and proto are matched and active status
- is ignored. If bit one is set, then port is ignored. If bit two is
- set, then protocol is ignored. If bit three is set, then state must
- be active. The parameter can be an integer or a variable holding an
- integer value. It must be provided if the uri parameter is
- provided.
- * uri (optional) - if is empty or missing, the matching is done
- against source IP, port and protocol. Otherwise the value has to be
- a valid SIP URI, used to match against addresses in the dispatcher
- list. Only IP, port and protocol are matches, any additional
- parameters are ignored. The parameter can be a static or dynamic
- (with variables) string. The domain part of the URI can be an IP
- address or a hostname.
+ done. If parameter is 0, all ip, port and proto are matched and
+ active status is ignored. If bit one is set, then port is ignored.
+ If bit two is set, then protocol is ignored. If bit three is set,
+ then state must be active. The parameter can be an integer or a
+ variable holding an integer value. It must be provided if the uri
+ parameter is provided.
+ * uri (optional) - if parameter is empty or missing, the matching is
+ done against source IP, port and protocol. Otherwise the value has
+ to be a valid SIP URI, used to match against addresses in the
+ dispatcher list. Only IP, port and protocol are matches, any
+ additional parameters are ignored. The parameter can be a static or
+ dynamic (with variables) string. The domain part of the URI can be
+ an IP address or a hostname.
Upon a match, the variable specified by 'setid_pvname' parameter will
be set to groupid of matching address and the attributes will be set in
Module: kamailio
Branch: master
Commit: da115fae61f5e1aa5e29edd4a7a9e5a9bcd291f0
URL: https://github.com/kamailio/kamailio/commit/da115fae61f5e1aa5e29edd4a7a9e5a…
Author: Mikko Lehto <mslehto(a)iki.fi>
Committer: Mikko Lehto <mslehto(a)iki.fi>
Date: 2019-12-13T19:37:21+02:00
dispatcher: Minor documentation improvement for ds_is_from_list()
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/da115fae61f5e1aa5e29edd4a7a9e5a…
Patch: https://github.com/kamailio/kamailio/commit/da115fae61f5e1aa5e29edd4a7a9e5a…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index 87a7735b1d..4c9430a630 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -1568,14 +1568,14 @@ if(ds_list_exists("10")) {
<listitem>
<para><emphasis>groupid</emphasis> (optional) - if not given or its
value is -1, the matching will be done over all addresses in
- all dispacher groups. Otherwise the matching will be done only
+ all dispatcher groups. Otherwise the matching will be done only
against the addresses in the specific group id. The parameter
can be an integer or a variable holding an integer value.
</para>
</listitem>
<listitem>
<para><emphasis>mode</emphasis> - (optional) - a bitmask to specify
- how the matching should be done. If is 0, all ip, port and
+ how the matching should be done. If parameter is 0, all ip, port and
proto are matched and active status is ignored.
If bit one is set, then port is ignored.
If bit two is set, then protocol is ignored.
@@ -1585,7 +1585,7 @@ if(ds_list_exists("10")) {
</para>
</listitem>
<listitem>
- <para><emphasis>uri</emphasis> (optional) - if is empty or missing,
+ <para><emphasis>uri</emphasis> (optional) - if parameter is empty or missing,
the matching is done against source IP, port and protocol.
Otherwise the value has to be a valid SIP URI, used to match
against addresses in the dispatcher list. Only IP, port and
Module: kamailio
Branch: master
Commit: 9ddef1571c5508f2b12614d3cebac4368609a498
URL: https://github.com/kamailio/kamailio/commit/9ddef1571c5508f2b12614d3cebac43…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2019-12-13T16:14:04+01:00
rr: docs for rr_next_hop_route() function
---
Modified: src/modules/rr/doc/rr_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/9ddef1571c5508f2b12614d3cebac43…
Patch: https://github.com/kamailio/kamailio/commit/9ddef1571c5508f2b12614d3cebac43…
---
diff --git a/src/modules/rr/doc/rr_admin.xml b/src/modules/rr/doc/rr_admin.xml
index 362edd4f1f..01bee1b451 100644
--- a/src/modules/rr/doc/rr_admin.xml
+++ b/src/modules/rr/doc/rr_admin.xml
@@ -649,6 +649,35 @@ if (is_direction("downstream")) {
</programlisting>
</example>
</section>
+
+ <section id="rr.f.rr_next_hop_route">
+ <title><function moreinfo="none">rr_next_hop_route()</function></title>
+
+ <para>The function returns 1 (true) if there is a Route header for the
+ next hop address. It has to be used after loose_route(), when the
+ local Route headers are processed.
+ </para>
+
+ <para>
+ This function can be used from ANY_ROUTE.
+ </para>
+
+ <example>
+ <title><function>rr_next_hop_route</function> usage</title>
+
+ <programlisting format="linespecific">
+...
+if(loose_route) {
+ if(rr_next_hop_route()) {
+ # next hop address is from Route header
+ }
+
+}
+...
+</programlisting>
+ </example>
+ </section>
+
</section>
<section>
Module: kamailio
Branch: master
Commit: 24afe136361402f49f62aadc4401706c77a6b253
URL: https://github.com/kamailio/kamailio/commit/24afe136361402f49f62aadc4401706…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2019-12-13T16:07:55+01:00
core: internal flag to mark sip request if there is a route for next hop
---
Modified: src/core/parser/msg_parser.h
---
Diff: https://github.com/kamailio/kamailio/commit/24afe136361402f49f62aadc4401706…
Patch: https://github.com/kamailio/kamailio/commit/24afe136361402f49f62aadc4401706…
---
diff --git a/src/core/parser/msg_parser.h b/src/core/parser/msg_parser.h
index 0b0f5044ed..f3ea088eb8 100644
--- a/src/core/parser/msg_parser.h
+++ b/src/core/parser/msg_parser.h
@@ -109,6 +109,7 @@ typedef enum request_method {
#define FL_USE_XAVP_VIA_FIELDS (1<<22) /*!< use xavp fields for local via attrs */
#define FL_MSG_NOREPLY (1<<23) /*!< do not send sip reply for request */
#define FL_SIPTRACE (1<<24) /*!< message to be traced in stateless replies */
+#define FL_ROUTE_ADDR (1<<25) /*!< request has Route address for next hop */
/* WARNING: Value (1 << 28) is temporarily reserved for use in kamailio call_control
* module (flag FL_USE_CALL_CONTROL )! */
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
added new function del_destination that deletes sip address from list
added add_destination module functions for kamailio.cfg
added counter parameter for attempt count. after count pass, module dont try until it adds again.
added kemi interfaces both of them
added lock to stack
added find_destination function
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2133
-- Commit Summary --
* keepalive : added new function del_destination and added .cfg functions
-- File Changes --
M src/modules/keepalive/api.h (4)
M src/modules/keepalive/keepalive.h (10)
M src/modules/keepalive/keepalive_api.c (117)
M src/modules/keepalive/keepalive_core.c (14)
M src/modules/keepalive/keepalive_mod.c (93)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2133.patchhttps://github.com/kamailio/kamailio/pull/2133.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2133
Module: kamailio
Branch: master
Commit: e8bd86d764eca0b9554f9eee665ba786d76230e7
URL: https://github.com/kamailio/kamailio/commit/e8bd86d764eca0b9554f9eee665ba78…
Author: Yasin CANER <caner_yaso(a)hotmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2019-12-12T12:06:24+01:00
keepalive : added new function del_destination and added cfg functions (#2133)
* keepalive : added new function del_destination and added .cfg functions
added new function del_destination that deletes sip address from list
added add_destination module functions for kamailio.cfg
added counter parameter for attempt count. after count pass, module dont try until it adds again.
added kemi interfaces both of them
added lock to stack
added find_destination function
* keepalive : fixed function names and re-placed un/lock functions
fixed function names and re-placed un/lock functions
* keepalive : added doc for exported new functions ka_add_destination and ka_del_destination [skip ci]
added documents for exported new function ka_add_destination and ka_del_destination
renamed in documents from is_alive to ka_is_alive
added missing rpc command in documents
---
Modified: src/modules/keepalive/api.h
Modified: src/modules/keepalive/doc/keepalive.xml
Modified: src/modules/keepalive/doc/keepalive_admin.xml
Modified: src/modules/keepalive/keepalive.h
Modified: src/modules/keepalive/keepalive_api.c
Modified: src/modules/keepalive/keepalive_core.c
Modified: src/modules/keepalive/keepalive_mod.c
---
Diff: https://github.com/kamailio/kamailio/commit/e8bd86d764eca0b9554f9eee665ba78…
Patch: https://github.com/kamailio/kamailio/commit/e8bd86d764eca0b9554f9eee665ba78…
Module: kamailio
Branch: master
Commit: ae08b5955935466c401709903b38491aba7ec33e
URL: https://github.com/kamailio/kamailio/commit/ae08b5955935466c401709903b38491…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-12-12T08:46:16+01:00
modules: readme files regenerated - tm ... [skip ci]
---
Modified: src/modules/tm/README
---
Diff: https://github.com/kamailio/kamailio/commit/ae08b5955935466c401709903b38491…
Patch: https://github.com/kamailio/kamailio/commit/ae08b5955935466c401709903b38491…
---
diff --git a/src/modules/tm/README b/src/modules/tm/README
index 3607b3969b..4b23eacb58 100644
--- a/src/modules/tm/README
+++ b/src/modules/tm/README
@@ -1937,17 +1937,20 @@ branch_route[1] {
the only way a script can add a new transaction in an atomic way.
Typically, it is used to deploy a UAS.
- Note that any flag operations (e.g. for accounting) after this function
- has been called will be ignored. You can use the the tmx module
- function t_flush_flags() to flush the altered flags to the already
- created transaction.
+ Note: once the t_newtran() is executed, the new message flag operations
+ (i.e., setflag() and resetflag()) are not syncronized to the
+ transaction, being stored only in the private memory SIP message
+ structure. Use the tmx module function t_flush_flags() to synchronize
+ the modified message flags to the already created transaction.
Example 1.56. t_newtran usage
...
if (t_newtran()) {
- log("UAS logic");
+ xlog("the transaction has been created\n");
t_reply("999","hello");
-} else sl_reply_error();
+} else {
+ sl_reply_error();
+}
...
See misc/examples/mixed/uas.cfg for more examples.
Module: kamailio
Branch: master
Commit: 9a0c850f98063da145120f90d2c5c2a43e76b976
URL: https://github.com/kamailio/kamailio/commit/9a0c850f98063da145120f90d2c5c2a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2019-12-12T08:42:06+01:00
tm: clarification that the sip message flags operations after t_newtran()
- they are not reflected in transaction, only in local sip message
structure
---
Modified: src/modules/tm/doc/functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/9a0c850f98063da145120f90d2c5c2a…
Patch: https://github.com/kamailio/kamailio/commit/9a0c850f98063da145120f90d2c5c2a…
---
diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml
index 82647117cd..489147afd1 100644
--- a/src/modules/tm/doc/functions.xml
+++ b/src/modules/tm/doc/functions.xml
@@ -303,19 +303,22 @@ branch_route[1] {
way. Typically, it is used to deploy a UAS.
</para>
<para>
- Note that any flag operations (e.g. for accounting) after this
- function has been called will be ignored. You can use the the tmx
- module function t_flush_flags() to flush the altered flags to the
- already created transaction.
+ Note: once the t_newtran() is executed, the new message flag operations
+ (i.e., setflag() and resetflag()) are not syncronized to the transaction,
+ being stored only in the private memory SIP message structure. Use the
+ tmx module function t_flush_flags() to synchronize the modified message
+ flags to the already created transaction.
</para>
<example>
<title><function>t_newtran</function> usage</title>
<programlisting>
...
-if (t_newtran()) {
- log("UAS logic");
- t_reply("999","hello");
-} else sl_reply_error();
+if (t_newtran()) {
+ xlog("the transaction has been created\n");
+ t_reply("999","hello");
+} else {
+ sl_reply_error();
+}
...
</programlisting>
</example>
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to PR #2162
#### Description
As discussed on #2162 with this change it's possible to decide witch xavp_rcd values will be stored using the new module parameter xavp_rcd_mask
Using the same helper function on build_contact() so the behavior is consistant. Before only ruid and expires where stored when build_contact() was called.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2168
-- Commit Summary --
* registrar: control what values to add to xavp_rcd via xavp_rcd_mask
* registrar: add documentation for xavp_rcd_mask parameter
-- File Changes --
M src/modules/registrar/doc/registrar_admin.xml (31)
M src/modules/registrar/lookup.c (35)
M src/modules/registrar/lookup.h (4)
M src/modules/registrar/registrar.c (3)
M src/modules/registrar/registrar.h (8)
M src/modules/registrar/reply.c (47)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2168.patchhttps://github.com/kamailio/kamailio/pull/2168.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2168
Note: See below for more info about motivation of this feature.
#### Pre-Submission Checklist
- [ * ] Commit message has the format required by CONTRIBUTING guide
- [ * ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ * ] Each component has a single commit (if not, squash them into one commit)
- [ * ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ * ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [ * ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
This feature aims to replace require_certificate and verify_certificate params with a single option, verify_client:
* Provides flexibility: require_certificate and verify_certificate are both booleans, so there are only 4 max combinations of params, and only 3 of them make sense (require_certificate=1 and verify_certificate=0 does not). In contrast, verify_client is a list of enumerated values, which can be more gracefully expanded by adding additional behaviors to the enum.
* Motivation for this feature is to enable optional_no_ca behavior, described in the docbook; Without this feature, that behavior cannot be represented by any combination of require_certificate and verify_certificate. I figured if I need to add another variable to support desired behavior, it may as well be one that can hold more than just boolean values.
* This feature was inspired from a similar one in Nginx; that software has a similar "ssl_verify_client" option that takes the same "on", "off", "optional", and "optional_no_ca" values, which effectively implement the same feature. Note that there is no shared code between implementations, and that these behaviors are implemented (in both cases) via a very thin layer of glue code on top of the OpenSSL library.
* Note that the only function definition in tls_verify.c, verify_callback(int pre_verify_ok, X509_STORE_CTX *ctx), has been compiled into the kamailio binary, but apparently not used. Rather than modify the existing function, I added a simple 1-line function (2 if you count the log message too) to enable this feature.
Please let me know if I can answer any questions. Thanks!
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2166
-- Commit Summary --
* tls: add verify_client support
-- File Changes --
M src/modules/tls/doc/params.xml (52)
M src/modules/tls/tls_cfg.c (3)
M src/modules/tls/tls_cfg.h (1)
M src/modules/tls/tls_config.c (31)
M src/modules/tls/tls_config.h (4)
M src/modules/tls/tls_domain.c (20)
M src/modules/tls/tls_domain.h (14)
M src/modules/tls/tls_mod.c (12)
M src/modules/tls/tls_rpc.c (3)
M src/modules/tls/tls_verify.c (6)
M src/modules/tls/tls_verify.h (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2166.patchhttps://github.com/kamailio/kamailio/pull/2166.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2166
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
- new dlg_reset_property() function is added to disable the previously enabled dialog module behaviour.
e.g. stop sending keep-alive OPTIONS messages.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2172
-- Commit Summary --
* dialog: add new dlg_reset_property function
* dialod: indentation fixed
-- File Changes --
M src/modules/dialog/dialog.c (63)
M src/modules/dialog/doc/dialog_admin.xml (42)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2172.patchhttps://github.com/kamailio/kamailio/pull/2172.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2172
Hi All,
I have Kamailio v4.4.1 installed in ubuntu 14.04 server with TLS enabled.
After I have done the patching of the server and then restarted the server.
After that, it is not working. When I try to start the Kamailio service it
says "already running". But when I check the status of the service it says
"Kamailio is not running".
I thought this Kamailio process might be using port 5061 but when checked
using netstat it shows 5061 is not used by anywhere. SO I am wondering why
it is not working?
Can anyone face similar issue? Please help me.
Thank you.
--
Best Regards,
__________________________________
Jignesh Datta
Lead Developer
Boston Byte LLC
Contact :+91 7385860123
Email : jignesh.datta(a)bostonbyte.com
Website : *www.bostonbyte.com <http://www.bostonbyte.com/>*
Blog: <http://bostonbyte.blogspot.com>bostonbyte.blogspot.com
Hello,
Jesus Rodrigues and Inaki Baz Castillo changed their work roles a while
ago, so they no longer deal with Kamailio and they do not expect to do
it in the near future. To keep the Management group with members
connected as much as possible with the project, Fred Posner and Victor
Seva were proposed to replace them.
For the new members in the public lists: the management group of
Kamailio is not involved in the daily development or administration of
the project -- all those are done on public mailing lists or kadmin
group (internal infrastructure administration) -- management team is
supposed to take the decisions on sensitive situations for the evolution
of the project.
Should anyone have opinions about these changes, let's discuss on
sr-users mailing list.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - April 27-29, 2020, in Berlin -- www.kamailioworld.com
### Description
Hi all!
It looks like in https://github.com/kamailio/kamailio/pull/2051 `record_route_preset` was exposed to KEMI, which is awesome (thank you @aalba6675 !). However the second parameter in this function should be optional (see https://kamailio.org/docs/modules/devel/modules/rr.html#rr.f.record_route_p…).
### Troubleshooting
When using with a single parameter, the following error is thrown:
`Dec 9 13:24:13 ip-10-0-0-1 /usr/local/sbin/kamailio[15828]: ERROR: app_ruby [app_ruby_api.c:499]: sr_kemi_ruby_exec_func_ex(): invalid str parameter type 2 (1)`
#### Reproduction
(ruby Kemi)
```ruby
# Failure
KSR::RR.record_route_preset('1.2.3.4:5060')
# Success
KSR::RR.record_route_preset('1.2.3.4:5060', '')
# Success
KSR::RR.record_route_preset('1.2.3.4:5060', '1.2.3.4:5060')
```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.4.0-dev2 (x86_64/linux) 283e46-dirty
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2171
### Description
Some daemon not able to handle IPv4 and IPv6 calls simultaneously. As example `FreeSwitch`. Need to create two dispatcher records for IPv4 and IPv6 FreeSwitch sockets. Each socket will be able to handle appropriate call type. Mixing not allowed.
Could you add `dispatcher` module options to compare used IP version for incoming call and for dispatcher backend sip uri. And select backend only if IP versions matched.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2170
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
#### Description
Add path value to xavp_rcd. This is needed when checking if a subscriber is still registered
with a certain parameter in the path.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2162
-- Commit Summary --
* registrar: add path value to xavp_rcd
-- File Changes --
M src/modules/registrar/doc/registrar_admin.xml (8)
M src/modules/registrar/lookup.c (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2162.patchhttps://github.com/kamailio/kamailio/pull/2162.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2162
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
#### Description
The main goal of the module is to offload the intermediate header
processing into the XAVP dynamic container as well as provide with high
level methods and pseudovariables to simplify SIP message header
modifications.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2156
-- Commit Summary --
* pv_headers: Initial commit
-- File Changes --
A src/modules/pv_headers/Makefile (12)
A src/modules/pv_headers/README (332)
A src/modules/pv_headers/doc/Makefile (4)
A src/modules/pv_headers/doc/functions.xml (131)
A src/modules/pv_headers/doc/params.xml (186)
A src/modules/pv_headers/doc/pv_headers.xml (39)
A src/modules/pv_headers/doc/pv_headers_admin.xml (116)
A src/modules/pv_headers/pv_headers.c (351)
A src/modules/pv_headers/pv_headers.h (51)
A src/modules/pv_headers/pvh_func.c (388)
A src/modules/pv_headers/pvh_func.h (38)
A src/modules/pv_headers/pvh_hash.c (132)
A src/modules/pv_headers/pvh_hash.h (39)
A src/modules/pv_headers/pvh_hdr.c (235)
A src/modules/pv_headers/pvh_hdr.h (39)
A src/modules/pv_headers/pvh_str.c (144)
A src/modules/pv_headers/pvh_str.h (38)
A src/modules/pv_headers/pvh_xavp.c (1050)
A src/modules/pv_headers/pvh_xavp.h (64)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2156.patchhttps://github.com/kamailio/kamailio/pull/2156.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2156
Module: kamailio
Branch: master
Commit: a37140bef370cdfab88dbff87bedc2e2e6922e6b
URL: https://github.com/kamailio/kamailio/commit/a37140bef370cdfab88dbff87bedc2e…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2019-12-05T19:38:39+01:00
pv_headers: Initial commit
The main goal of the module is to offload the intermediate header
processing into the XAVP dynamic container as well as provide with high
level methods and pseudovariables to simplify SIP message header
modifications.
---
Added: src/modules/pv_headers/Makefile
Added: src/modules/pv_headers/README
Added: src/modules/pv_headers/doc/Makefile
Added: src/modules/pv_headers/doc/functions.xml
Added: src/modules/pv_headers/doc/params.xml
Added: src/modules/pv_headers/doc/pv_headers.xml
Added: src/modules/pv_headers/doc/pv_headers_admin.xml
Added: src/modules/pv_headers/pv_headers.c
Added: src/modules/pv_headers/pv_headers.h
Added: src/modules/pv_headers/pvh_func.c
Added: src/modules/pv_headers/pvh_func.h
Added: src/modules/pv_headers/pvh_hash.c
Added: src/modules/pv_headers/pvh_hash.h
Added: src/modules/pv_headers/pvh_hdr.c
Added: src/modules/pv_headers/pvh_hdr.h
Added: src/modules/pv_headers/pvh_str.c
Added: src/modules/pv_headers/pvh_str.h
Added: src/modules/pv_headers/pvh_xavp.c
Added: src/modules/pv_headers/pvh_xavp.h
---
Diff: https://github.com/kamailio/kamailio/commit/a37140bef370cdfab88dbff87bedc2e…
Patch: https://github.com/kamailio/kamailio/commit/a37140bef370cdfab88dbff87bedc2e…
allow to clean the shared and private info of a test scenario in order to be able to re-trigger it without restart kamailio
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/574
Module: kamailio
Branch: 5.1
Commit: 36d08a574628fc668224fcbf4c9bdaff883a9b3f
URL: https://github.com/kamailio/kamailio/commit/36d08a574628fc668224fcbf4c9bdaf…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-12-04T12:17:07+01:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/tm/README
---
Diff: https://github.com/kamailio/kamailio/commit/36d08a574628fc668224fcbf4c9bdaf…
Patch: https://github.com/kamailio/kamailio/commit/36d08a574628fc668224fcbf4c9bdaf…
---
diff --git a/src/modules/tm/README b/src/modules/tm/README
index b12590d7d9..31c66b1508 100644
--- a/src/modules/tm/README
+++ b/src/modules/tm/README
@@ -1880,6 +1880,11 @@ branch_route[1] {
the only way a script can add a new transaction in an atomic way.
Typically, it is used to deploy a UAS.
+ Note that any flag operations (e.g. for accounting) after this function
+ has been called will be ignored. You can use the the tmx module
+ function t_flush_flags() to flush the altered flags to the already
+ created transaction.
+
Example 1.54. t_newtran usage
...
if (t_newtran()) {
Module: kamailio
Branch: 5.2
Commit: 097687c90fd9b51928aa0f10330f714f3371fa27
URL: https://github.com/kamailio/kamailio/commit/097687c90fd9b51928aa0f10330f714…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-12-04T12:16:24+01:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/tm/README
---
Diff: https://github.com/kamailio/kamailio/commit/097687c90fd9b51928aa0f10330f714…
Patch: https://github.com/kamailio/kamailio/commit/097687c90fd9b51928aa0f10330f714…
---
diff --git a/src/modules/tm/README b/src/modules/tm/README
index 0a8ea2d502..708e7c7e0f 100644
--- a/src/modules/tm/README
+++ b/src/modules/tm/README
@@ -1905,6 +1905,11 @@ branch_route[1] {
the only way a script can add a new transaction in an atomic way.
Typically, it is used to deploy a UAS.
+ Note that any flag operations (e.g. for accounting) after this function
+ has been called will be ignored. You can use the the tmx module
+ function t_flush_flags() to flush the altered flags to the already
+ created transaction.
+
Example 1.55. t_newtran usage
...
if (t_newtran()) {
- fixed a defect reported from Coverity Scan - Concurrent data access
violations in spi_gen.c for spi_data->spi_val.
- in create_ipsec_tunnel() return -1 when unable to convert ip address.
- in ipsec_create() go to cleanup instead return -1 when get request
for reply fails. Fixed debug message for that error.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2163
-- Commit Summary --
* ims_ipsec_pcscf: fixed defects and warnings:
-- File Changes --
M src/modules/ims_ipsec_pcscf/cmd.c (13)
M src/modules/ims_ipsec_pcscf/spi_gen.c (14)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2163.patchhttps://github.com/kamailio/kamailio/pull/2163.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2163
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
Point your browser to https://deb.kamailio.org
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
The lets encrypt certificate expired on 2019-11-30
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2161
Hello,
I would like to announce that Call for Presentations at Kamailio World
2020 is now open. You can submit your proposal or see more details at:
- https://www.kamailioworld.com/k08/call-for-speakers/
The 8th edition of the event takes place again in Berlin, Germany,
during April 27-29, 2020. Expect over 150 participants, developers and
community members as well as representatives of other popular open
source VoIP projects such as Asterisk or FreeSwitch.
Looking forward to meeting many of you there!
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - April 27-29, 2020, in Berlin -- www.kamailioworld.com
(I'm new and this issue is nonobvious, so I'm posting to the list
instead of opening an issue, hoping sr-dev is the right call.)
I am packaging kamailio for pkgsrc, a multi-OS multi-CPU portable
packaging system, with NetBSD and SmartOS being perhaps the biggest
targets. Mostly this is going well, and I'm probably doing a few things
wrong (but am not asking for help on those yet).
During the build (NetBSD 8 amd64), I got a failure in
src/lib/srdb1/db_ut.c:
CC (gcc) [L libsrdb1.so.1.0] db_ut.o
In file included from db_ut.c:63:0:
/usr/include/stdlib.h:273:28: error: unknown type name 'u_char'
void arc4random_addrandom(u_char *, int);
^
/usr/include/stdlib.h:306:1: error: unknown type name 'devmajor_t'
devmajor_t getdevmajor(const char *, mode_t);
^
gmake[3]: *** [../../Makefile.rules:100: db_ut.o] Error 1
This may be a NetBSD bug and I am investigating that in parallel.
In db_ut.c, several visibility defines are set. These have the effect
of ensuring that definitions mandated by a certain standard are visible,
but they also restrict visibility of definitions not mandated by that
standard.
The code is:
/**
* make strptime available
* use 600 for 'Single UNIX Specification, Version 3'
* _XOPEN_SOURCE creates conflict in swab definition in Solaris
*/
#ifndef __OS_solaris
#define _XOPEN_SOURCE 600 /* glibc2 on linux, bsd */
#define _BSD_SOURCE 1 /* needed on linux to "fix" the effect
* of the above define on
* features.h/unistd.h syscall() */
#define _DEFAULT_SOURCE 1 /* _BSD_SOURCE is deprecated */
#else
#define _XOPEN_SOURCE_EXTENDED 1 /* solaris */
#endif
#include <time.h>
#ifndef __OS_solaris
#undef _XOPEN_SOURCE
#undef _XOPEN_SOURCE_EXTENDED
#else /* solaris */
#undef _XOPEN_SOURCE_EXTENDED
#endif
strptime seems to have originally been XPG4, and now seems to be in base
POSIX:
https://pubs.opengroup.org/onlinepubs/9699919799/functions/strptime.html
_XOPEN_SOURCE being 600 seems to be "X/Open 6, incorporating POSIX 2004":
https://pubs.opengroup.org/onlinepubs/009695399/
I am not following the comment "_BSD_SOURCE is deprecated"; that is
perhaps referring to the situation on Linux. But that define is not
used on recent NetBSD.
Overall, feature tests macros are complicated, and while I'm sure there
were good reasons they was added over time, I suspect that today they
are not needed at all, or in a far more limited manner. (I'm unclear on
how far back on various systems kamailio intends to support.)
On NetBSD 8, removing all the visibility defines that I quoted results
in a clean build, and I have a patch in pkgsrc that does that.
I would advance the hypothesis that it would be preferable to remove the
visibility defines, and if there are systems on which they are needed,
to #ifdef system and perhaps #ifdef version <= OK_VERSION and then
define things. This would avoid setting visibility defines on systemss
where they haven't been tested and probably aren't needed.
I am therefore curious what happens on various systems if the
above-quoted text from db_ut is removed.
There are also POSIX and other XOPEN defines in other files, and I'm not
sure if they are ok or if I'm just not building those modules.
Alternatively I could prepare a PR to not set any defines on NetBSD, or
to define _NETBSD_SOURCE, which should be more or less equivalent.
Thanks,
Greg
Module: kamailio
Branch: 5.3
Commit: dc322c0d24fec1a864e133bff6bb8a7a67e136b5
URL: https://github.com/kamailio/kamailio/commit/dc322c0d24fec1a864e133bff6bb8a7…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-29T19:42:37+01:00
tm: extend t_newtran docs with a note about flag behaviour
(cherry picked from commit f2f492bd580621dec23d0538b8785635a013497a)
---
Modified: src/modules/tm/doc/functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/dc322c0d24fec1a864e133bff6bb8a7…
Patch: https://github.com/kamailio/kamailio/commit/dc322c0d24fec1a864e133bff6bb8a7…
---
diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml
index 8ceaa6360a..82647117cd 100644
--- a/src/modules/tm/doc/functions.xml
+++ b/src/modules/tm/doc/functions.xml
@@ -302,6 +302,12 @@ branch_route[1] {
is the only way a script can add a new transaction in an atomic
way. Typically, it is used to deploy a UAS.
</para>
+ <para>
+ Note that any flag operations (e.g. for accounting) after this
+ function has been called will be ignored. You can use the the tmx
+ module function t_flush_flags() to flush the altered flags to the
+ already created transaction.
+ </para>
<example>
<title><function>t_newtran</function> usage</title>
<programlisting>
Module: kamailio
Branch: 5.2
Commit: bb7e84d46017a112b88fa0c4a187bb5ca7f961c5
URL: https://github.com/kamailio/kamailio/commit/bb7e84d46017a112b88fa0c4a187bb5…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-29T19:42:10+01:00
tm: extend t_newtran docs with a note about flag behaviour
(cherry picked from commit f2f492bd580621dec23d0538b8785635a013497a)
---
Modified: src/modules/tm/doc/functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/bb7e84d46017a112b88fa0c4a187bb5…
Patch: https://github.com/kamailio/kamailio/commit/bb7e84d46017a112b88fa0c4a187bb5…
---
diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml
index 67cc5d017c..447f000eb6 100644
--- a/src/modules/tm/doc/functions.xml
+++ b/src/modules/tm/doc/functions.xml
@@ -302,6 +302,12 @@ branch_route[1] {
is the only way a script can add a new transaction in an atomic
way. Typically, it is used to deploy a UAS.
</para>
+ <para>
+ Note that any flag operations (e.g. for accounting) after this
+ function has been called will be ignored. You can use the the tmx
+ module function t_flush_flags() to flush the altered flags to the
+ already created transaction.
+ </para>
<example>
<title><function>t_newtran</function> usage</title>
<programlisting>
Module: kamailio
Branch: 5.1
Commit: c039af8752b553c65d375a00a017820f85ead41a
URL: https://github.com/kamailio/kamailio/commit/c039af8752b553c65d375a00a017820…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-29T19:41:48+01:00
tm: extend t_newtran docs with a note about flag behaviour
(cherry picked from commit f2f492bd580621dec23d0538b8785635a013497a)
---
Modified: src/modules/tm/doc/functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/c039af8752b553c65d375a00a017820…
Patch: https://github.com/kamailio/kamailio/commit/c039af8752b553c65d375a00a017820…
---
diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml
index 7983de257b..af8f10ffc2 100644
--- a/src/modules/tm/doc/functions.xml
+++ b/src/modules/tm/doc/functions.xml
@@ -302,6 +302,12 @@ branch_route[1] {
is the only way a script can add a new transaction in an atomic
way. Typically, it is used to deploy a UAS.
</para>
+ <para>
+ Note that any flag operations (e.g. for accounting) after this
+ function has been called will be ignored. You can use the the tmx
+ module function t_flush_flags() to flush the altered flags to the
+ already created transaction.
+ </para>
<example>
<title><function>t_newtran</function> usage</title>
<programlisting>
Module: kamailio
Branch: master
Commit: f2f492bd580621dec23d0538b8785635a013497a
URL: https://github.com/kamailio/kamailio/commit/f2f492bd580621dec23d0538b878563…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-29T19:40:03+01:00
tm: extend t_newtran docs with a note about flag behaviour
---
Modified: src/modules/tm/doc/functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/f2f492bd580621dec23d0538b878563…
Patch: https://github.com/kamailio/kamailio/commit/f2f492bd580621dec23d0538b878563…
---
diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml
index 8ceaa6360a..82647117cd 100644
--- a/src/modules/tm/doc/functions.xml
+++ b/src/modules/tm/doc/functions.xml
@@ -302,6 +302,12 @@ branch_route[1] {
is the only way a script can add a new transaction in an atomic
way. Typically, it is used to deploy a UAS.
</para>
+ <para>
+ Note that any flag operations (e.g. for accounting) after this
+ function has been called will be ignored. You can use the the tmx
+ module function t_flush_flags() to flush the altered flags to the
+ already created transaction.
+ </para>
<example>
<title><function>t_newtran</function> usage</title>
<programlisting>
Module: kamailio
Branch: 5.1
Commit: e5d94d3a8c9ce2962c03b130972715785652b605
URL: https://github.com/kamailio/kamailio/commit/e5d94d3a8c9ce2962c03b1309727157…
Author: Greg Troxel <gdt(a)lexort.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-29T18:43:20+01:00
utils: Change sh(1) "test ==" usage to "="
The POSIX sh(1) specification says that strings are compared with
test(1) (also "[") with "=". Bash accepts "==" and this leads to
non-portable code. This commit simply changes "==" within test/[ to
"=".
(cherry picked from commit e8b8251f6c7382f8e373c2b309422973a3bf730d)
---
Modified: utils/kamctl/kamdbctl
---
Diff: https://github.com/kamailio/kamailio/commit/e5d94d3a8c9ce2962c03b1309727157…
Patch: https://github.com/kamailio/kamailio/commit/e5d94d3a8c9ce2962c03b1309727157…
---
diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl
index ea15329a19..a8b0f60e7b 100755
--- a/utils/kamctl/kamdbctl
+++ b/utils/kamctl/kamdbctl
@@ -153,7 +153,7 @@ kamailio_dump() # pars: <database name>
merr "kamailio_dump function takes two param"
exit 1
fi
- if [ "$USED_DBENGINE" == "oracle" ]; then
+ if [ "$USED_DBENGINE" = "oracle" ]; then
oracle_dump $1 $2
elif [ "$PW" = "" ] ; then
$DUMP_CMD $1 > $2
@@ -174,7 +174,7 @@ kamailio_restore() #pars: <database name> <filename>
merr "kamailio_restore function takes two params"
exit 1
fi
- if [ "$USED_DBENGINE" == "oracle" ]; then
+ if [ "$USED_DBENGINE" = "oracle" ]; then
oracle_restore $1 $2
else
sql_query $1 < $2
@@ -313,7 +313,7 @@ case $1 in
;;
copy)
# copy database to some other name
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
@@ -346,7 +346,7 @@ case $1 in
exit $ret
;;
backup)
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
@@ -360,7 +360,7 @@ case $1 in
exit $?
;;
restore)
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
Module: kamailio
Branch: 5.3
Commit: 3eac27269bb60ec062eb0c2058319c70a94e0fbb
URL: https://github.com/kamailio/kamailio/commit/3eac27269bb60ec062eb0c2058319c7…
Author: Greg Troxel <gdt(a)lexort.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-29T18:42:52+01:00
utils: Change sh(1) "test ==" usage to "="
The POSIX sh(1) specification says that strings are compared with
test(1) (also "[") with "=". Bash accepts "==" and this leads to
non-portable code. This commit simply changes "==" within test/[ to
"=".
(cherry picked from commit e8b8251f6c7382f8e373c2b309422973a3bf730d)
---
Modified: utils/kamctl/kamdbctl
---
Diff: https://github.com/kamailio/kamailio/commit/3eac27269bb60ec062eb0c2058319c7…
Patch: https://github.com/kamailio/kamailio/commit/3eac27269bb60ec062eb0c2058319c7…
---
diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl
index f291228180..f9d48c9b4e 100755
--- a/utils/kamctl/kamdbctl
+++ b/utils/kamctl/kamdbctl
@@ -153,7 +153,7 @@ kamailio_dump() # pars: <database name>
merr "kamailio_dump function takes two param"
exit 1
fi
- if [ "$USED_DBENGINE" == "oracle" ]; then
+ if [ "$USED_DBENGINE" = "oracle" ]; then
oracle_dump $1 $2
elif [ "$PW" = "" ] ; then
$DUMP_CMD $1 > $2
@@ -174,7 +174,7 @@ kamailio_restore() #pars: <database name> <filename>
merr "kamailio_restore function takes two params"
exit 1
fi
- if [ "$USED_DBENGINE" == "oracle" ]; then
+ if [ "$USED_DBENGINE" = "oracle" ]; then
oracle_restore $1 $2
else
sql_query $1 < $2
@@ -290,7 +290,7 @@ kamailio_pframework() #pars: <action>
case $1 in
copy)
# copy database to some other name
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
@@ -323,7 +323,7 @@ case $1 in
exit $ret
;;
backup)
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
@@ -337,7 +337,7 @@ case $1 in
exit $?
;;
restore)
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
Module: kamailio
Branch: 5.2
Commit: d55905c1877b13f5d8367e8d4fd16cd0f01dffee
URL: https://github.com/kamailio/kamailio/commit/d55905c1877b13f5d8367e8d4fd16cd…
Author: Greg Troxel <gdt(a)lexort.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-29T18:42:04+01:00
utils: Change sh(1) "test ==" usage to "="
The POSIX sh(1) specification says that strings are compared with
test(1) (also "[") with "=". Bash accepts "==" and this leads to
non-portable code. This commit simply changes "==" within test/[ to
"=".
(cherry picked from commit e8b8251f6c7382f8e373c2b309422973a3bf730d)
---
Modified: utils/kamctl/kamdbctl
---
Diff: https://github.com/kamailio/kamailio/commit/d55905c1877b13f5d8367e8d4fd16cd…
Patch: https://github.com/kamailio/kamailio/commit/d55905c1877b13f5d8367e8d4fd16cd…
---
diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl
index ae44c5df45..7a7cfaa7f7 100755
--- a/utils/kamctl/kamdbctl
+++ b/utils/kamctl/kamdbctl
@@ -153,7 +153,7 @@ kamailio_dump() # pars: <database name>
merr "kamailio_dump function takes two param"
exit 1
fi
- if [ "$USED_DBENGINE" == "oracle" ]; then
+ if [ "$USED_DBENGINE" = "oracle" ]; then
oracle_dump $1 $2
elif [ "$PW" = "" ] ; then
$DUMP_CMD $1 > $2
@@ -174,7 +174,7 @@ kamailio_restore() #pars: <database name> <filename>
merr "kamailio_restore function takes two params"
exit 1
fi
- if [ "$USED_DBENGINE" == "oracle" ]; then
+ if [ "$USED_DBENGINE" = "oracle" ]; then
oracle_restore $1 $2
else
sql_query $1 < $2
@@ -290,7 +290,7 @@ kamailio_pframework() #pars: <action>
case $1 in
copy)
# copy database to some other name
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
@@ -323,7 +323,7 @@ case $1 in
exit $ret
;;
backup)
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
@@ -337,7 +337,7 @@ case $1 in
exit $?
;;
restore)
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
### Description
utils/kamctl/kamdbctl contains syntax beyond the POSIX sh stnadard. Specifically, there are multiple instances of "==" in test(1), which should be "="
#### Reproduction
In the 5.3.1 release, see line 156.
### Possible Solutions
Change == to = (multiple places).
### Additional Information
5.3.1 source tarball
This was detected by pkgsrc which has checks for various portability issues.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2157
The POSIX sh(1) specification says that strings are compared with
test(1) (also "[") with "=". Bash accepts "==" and this leads to
non-portable code. This commit simply changes "==" within test/[ to
"=".
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [] PR should be backported to stable branches
- [ ] Tested changes locally
- [x] Related to issue #2157
#### Description
This changes instances of "==" as a an operator to test(1) to "=".
I have not yes tested running the script, because I am still working through issues to package kamailio in pkgsrc. However, this patch avoids a lint-type warning from pkgsrc about non-portable shell script constructs.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2159
-- Commit Summary --
* utils: Change sh(1) "test ==" usage to "="
-- File Changes --
M utils/kamctl/kamdbctl (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2159.patchhttps://github.com/kamailio/kamailio/pull/2159.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2159
Module: kamailio
Branch: master
Commit: e8b8251f6c7382f8e373c2b309422973a3bf730d
URL: https://github.com/kamailio/kamailio/commit/e8b8251f6c7382f8e373c2b30942297…
Author: Greg Troxel <gdt(a)lexort.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-29T18:39:58+01:00
utils: Change sh(1) "test ==" usage to "="
The POSIX sh(1) specification says that strings are compared with
test(1) (also "[") with "=". Bash accepts "==" and this leads to
non-portable code. This commit simply changes "==" within test/[ to
"=".
---
Modified: utils/kamctl/kamdbctl
---
Diff: https://github.com/kamailio/kamailio/commit/e8b8251f6c7382f8e373c2b30942297…
Patch: https://github.com/kamailio/kamailio/commit/e8b8251f6c7382f8e373c2b30942297…
---
diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl
index faa07cb38a..89ddc81477 100755
--- a/utils/kamctl/kamdbctl
+++ b/utils/kamctl/kamdbctl
@@ -153,7 +153,7 @@ kamailio_dump() # pars: <database name>
merr "kamailio_dump function takes two param"
exit 1
fi
- if [ "$USED_DBENGINE" == "oracle" ]; then
+ if [ "$USED_DBENGINE" = "oracle" ]; then
oracle_dump $1 $2
elif [ "$PW" = "" ] ; then
$DUMP_CMD $1 > $2
@@ -174,7 +174,7 @@ kamailio_restore() #pars: <database name> <filename>
merr "kamailio_restore function takes two params"
exit 1
fi
- if [ "$USED_DBENGINE" == "oracle" ]; then
+ if [ "$USED_DBENGINE" = "oracle" ]; then
oracle_restore $1 $2
else
sql_query $1 < $2
@@ -290,7 +290,7 @@ kamailio_pframework() #pars: <action>
case $1 in
copy)
# copy database to some other name
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
@@ -323,7 +323,7 @@ case $1 in
exit $ret
;;
backup)
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
@@ -337,7 +337,7 @@ case $1 in
exit $?
;;
restore)
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
Hello,
I have created a "How-To" blog post on using Kamailio as "session border controller" for Microsoft Teams Direct Routing:
https://skalatan.de/de/blog/kamailio-sbc-teams
You can this way use all the existing possibilities that Kamailio provide to interact with MS Teams as well.
Best regards,
Henning
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://skalatan.de/services
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
It was discovered that the function t_newtran() is causing a conflict with the transaction flags. When calling it before setting transaction flags, the flags are apparently lost, so for instance when using the ACC module, if the ACC flags are set after the t_newtran, these flags seems to get lost and no ACC entries are saved....
Some discussion around the t_newtran usage was already held in the past and it seems the function is not needed anymore to help detecting retransmissions, given the t_precheck_trans() can do this job without having to have an early creation of the transaction.
Not sure if the t_newtran is necessary in any other scenario, but if it is not I think it should be deprecated.
### Reproduction
Create simple script which uses ACC and the setflag to save ACC entries in DB. Verify ACC records are being saved properly.
Before calling the setflag(), add a call to t_newtran(). Make calls and check ACC records are not saved anymore.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
# kamailio -v
version: kamailio 5.2.2 (x86_64/linux) 67f967
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 67f967
compiled on 11:40:41 Mar 11 2019 with gcc 4.8.5
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
# cat /etc/centos-release
CentOS Linux release 7.7.1908 (Core)
# uname -a
Linux dev1-sbc-01 3.10.0-1062.1.1.el7.x86_64 #1 SMP Fri Sep 13 22:55:44 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2155
Hello,
Kamailio is crashing when I'm trying to set the parameter;
`modparam("tm|usrloc", "xavp_contact", "ulattrs")
`
The crash is happening when I'm register 2 devices with the same extension.
This is the core dump:
#### Reproduction
Set the following parameter:
`modparam("tm|usrloc", "xavp_contact", "ulattrs")
`
and register the same extension from 2 different devices. Then send an message to them (NOTIFY/OPTION/INVITE etc)
#### Debugging Data
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `/usr/local/sbin/kamailio -P
/var/run/kamailio/kamailio.pid -f /usr/local/etc/ka'.
Program terminated with signal 11, Segmentation fault.
#0 0x000000000057cca2 in xavp_get_internal (name=0x8, list=0x0, idx=0,
prv=0x0) at core/xavp.c:288
288 core/xavp.c: No such file or directory.
(gdb) bt
#0 0x000000000057cca2 in xavp_get_internal (name=0x8, list=0x0, idx=0,
prv=0x0) at core/xavp.c:288
#1 0x0000000000581869 in xavp_insert (xavp=0x0, idx=0, list=0x0) at
core/xavp.c:752
#2 0x00007f05be0ee3a1 in ki_t_next_contacts (msg=0x7f05cb76c218) at
t_serial.c:552
#3 0x00007f05be0f09e8 in t_next_contacts (msg=0x7f05cb76c218, key=0x0,
value=0x0) at t_serial.c:756
#4 0x0000000000434d41 in do_action (h=0x7ffe93c9cad0, a=0x7f05cb642250,
msg=0x7f05cb76c218) at core/action.c:1067
#5 0x00000000004418e8 in run_actions (h=0x7ffe93c9cad0, a=0x7f05cb642250,
msg=0x7f05cb76c218) at core/action.c:1572
#6 0x0000000000441fa9 in run_actions_safe (h=0x7ffe93c9de90,
a=0x7f05cb642250, msg=0x7f05cb76c218) at core/action.c:1636
#7 0x000000000065734e in rval_get_int (h=0x7ffe93c9de90,
msg=0x7f05cb76c218, i=0x7ffe93c9cf78, rv=0x7f05cb642570, cache=0x0) at
core/rvalue.c:912
#8 0x000000000065b8fe in rval_expr_eval_int (h=0x7ffe93c9de90,
msg=0x7f05cb76c218, res=0x7ffe93c9cf78, rve=0x7f05cb642568) at
core/rvalue.c:1910
#9 0x000000000065bd51 in rval_expr_eval_int (h=0x7ffe93c9de90,
msg=0x7f05cb76c218, res=0x7ffe93c9d42c, rve=0x7f05cb642c98) at
core/rvalue.c:1918
#10 0x0000000000434807 in do_action (h=0x7ffe93c9de90, a=0x7f05cb645028,
msg=0x7f05cb76c218) at core/action.c:1043
#11 0x00000000004418e8 in run_actions (h=0x7ffe93c9de90, a=0x7f05cb637e48,
msg=0x7f05cb76c218) at core/action.c:1572
#12 0x0000000000431767 in do_action (h=0x7ffe93c9de90, a=0x7f05cb583858,
msg=0x7f05cb76c218) at core/action.c:691
#13 0x00000000004418e8 in run_actions (h=0x7ffe93c9de90, a=0x7f05cb574750,
msg=0x7f05cb76c218) at core/action.c:1572
#14 0x0000000000442071 in run_top_route (a=0x7f05cb574750,
msg=0x7f05cb76c218, c=0x0) at core/action.c:1657
#15 0x00000000005874a9 in receive_msg (buf=0xa6ec00 <buf.6868> "OPTIONS
sip:10 at 192.168.0.231:5060 SIP/2.0\r\nVia: SIP/2.0/UDP
192.168.0.231;branch=z9hG4bKd8a9.1b3abe656532065414a2f35a8916008d.1\r\nVia:
SIP/2.0/UDP 192.168.0.131:5060;received=192.168.0.131;branch=z9hG"...,
len=694, rcv_info=0x7ffe93c9e4d0) at core/receive.c:341
#16 0x000000000047bf81 in udp_rcv_loop () at core/udp_server.c:541
#17 0x0000000000424f9d in main_loop () at main.c:1669
#18 0x000000000042c688 in main (argc=13, argv=0x7ffe93c9ea18) at main.c:2710
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.2.5 (x86_64/linux) 18444d
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
Linux 3.10.0-1062.4.3.el7.x86_64 #1 SMP Wed Nov 13 23:58:53 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux CentOS 7```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2153
Module: kamailio
Branch: master
Commit: 063e6a025b8ca0163af2147f057d29447c6f9760
URL: https://github.com/kamailio/kamailio/commit/063e6a025b8ca0163af2147f057d294…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-23T22:49:28+01:00
core: increase SHM memory pool to 128 MB
- increase SHM memory pool to 128 MB
- even an embedded system like Raspberry Pi has 1 GB RAM nowadays
- make it less likely that new users run into issues because of lack of memory
---
Modified: src/core/config.h
---
Diff: https://github.com/kamailio/kamailio/commit/063e6a025b8ca0163af2147f057d294…
Patch: https://github.com/kamailio/kamailio/commit/063e6a025b8ca0163af2147f057d294…
---
diff --git a/src/core/config.h b/src/core/config.h
index 0eda20302b..96196a0224 100644
--- a/src/core/config.h
+++ b/src/core/config.h
@@ -142,7 +142,7 @@
#endif
#define PKG_MEM_POOL_SIZE PKG_MEM_SIZE*1024*1024 /*!< used only if PKG_MALLOC is defined*/
-#define SHM_MEM_SIZE 64 /*!< used if SH_MEM is defined*/
+#define SHM_MEM_SIZE 128 /*!< used if SH_MEM is defined*/
#define SHM_MEM_POOL_SIZE SHM_MEM_SIZE*1024*1024
/* dimensioning buckets in q_malloc */
# Description
Trying to avoid getting this warning:
Nov 22 20:36:35 test COPS[25531]: WARNING: db_redis [redis_dbase.c:1098]: db_redis_perform_query(): performing full table scan on table 'dispatcher' while performing query
### Troubleshooting
Having:
```
modparam("db_redis", "keys", "version=entry:table_name")
modparam("db_redis", "keys", "dispatcher=entry:id")
```
And debug logs showing the key being found:
```
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
zzzzzzzzzz
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
(paste your output here)
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2149
Can kamailio enforce client to REGISTER with AKAv1?
Here our setup:
1. kamailio version 4.3.4 for IMS
2. Boghe IMS client v1.0.58.550
3. scscf.cfg is configure with:
#!define REG_AUTH_DEFAULT_ALG "AKAv1-MD5"
a. First REGISTER fails with 401 Unauthorized
b. Second REGISTER 200 OK, but the REGISTER is MD5 and not AKAv1
Authorization:
Digest username="bob(a)net1.test",
realm="net1.test",
nonce="XdzPaF3czjz0oMKPeNLScpKAfb9prE7x",
uri="sip:net1.test",
response="854d9c2f3fe3dd3c96c14f8a2d20c2f9",
algorithm=MD5
Thank you,
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2150
Module: kamailio
Branch: master
Commit: 0cc8a34d3ddf2239fa8b9585d2b4432fe8362116
URL: https://github.com/kamailio/kamailio/commit/0cc8a34d3ddf2239fa8b9585d2b4432…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-25T20:45:46+01:00
nathelper: small spelling fix in docs
---
Modified: src/modules/nathelper/doc/nathelper_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/0cc8a34d3ddf2239fa8b9585d2b4432…
Patch: https://github.com/kamailio/kamailio/commit/0cc8a34d3ddf2239fa8b9585d2b4432…
---
diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml
index 8c3245c5b8..732a617396 100644
--- a/src/modules/nathelper/doc/nathelper_admin.xml
+++ b/src/modules/nathelper/doc/nathelper_admin.xml
@@ -829,7 +829,7 @@ if(is_rfc1918("$rd")) {
</title>
<para>
Reads <quote>;alias=ip~port~transport</quote> from Contact header then
- writes to target avp as a sip uri.
+ writes to target pseudo-variable as a sip uri.
</para>
<para>
This function can be used from
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
new function that read alias from Contact header then write to given avp as sip uri
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2124
-- Commit Summary --
* parse_uri : added new function proto type int to str
* nathelper : added new function set_alias_to_avp
* nathelper : added description of set_alias_to_avp function
-- File Changes --
M src/core/parser/parse_uri.c (23)
M src/core/parser/parse_uri.h (2)
M src/modules/nathelper/nathelper.c (176)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2124.patchhttps://github.com/kamailio/kamailio/pull/2124.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2124
Hello,
>From the xprint module README:
The xprint module is the former xlog module from SIP Express Router (SER), kept because it is used by other modules via API to get the value for strings with specifiers. If you want to print log messages from configuration file, use the real module named 'xlog'.
I just checked, there seems to be no module using it anymore. Therefore, I would like to propose to remove it in git master.
/repositories/kamailio$ grep -R xl_api * | egrep -v "modules/xprint"
/repositories/kamailio$
Cheers,
Henning
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com<https://gilawa.com/>
Kamailio Merchandising - https://skalatan.de/merchandising
I am forking a call to multiple destinations and want to keep the only branch which sends quicker provisional 180/183 reply and cancel the remaining branches. Below is my related cfg snippet.
modparam("tm", "failure_reply_mode", 3)
modparam("tm", "fr_timer", 30000)
modparam("tm", "fr_inv_timer", 120000)
modparam("tm", "cancel_b_method", 2)
...
route[SIPOUT] {
if (uri==myself) return;
append_hf("P-hint: outbound\r\n");
append_branch();
append_branch();
route(RELAY);
exit;
}
onreply_route[MANAGE_REPLY] {
xdbg("incoming reply\n");
if(status=~"[12][0-9][0-9]") {
xlog("L_INFO","Received $rs (IP:$si:$sp)\n");
if(status=~"18[03]"){
t_cancel_branches("others");
xlog("L_INFO","cancelled all other branches\n");
}
route(NATMANAGE);
}
}
...
But I see kamailio does not instantly send CANCEL to other branches after it has received 180/180 from any branch.
Kamailio is sending CANCEL to other branches after they start sending 180/183 one by one.
I want to cancel other brances instantly as soon as i get reply from any other branch.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/909
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Currently it is not possible to drop a local generated message in tm:local-request event route because there is no context associated when running the event route. With this PR I tried to solve this introducing a new returned error (E_DROP) and a context into t_run_local_req.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2147
-- Commit Summary --
* tm: add support for dropping messages in local-request event route
-- File Changes --
M src/core/error.h (1)
M src/modules/tm/uac.c (36)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2147.patchhttps://github.com/kamailio/kamailio/pull/2147.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2147
Hello,
last week we had the 2nd annual Kamailio Developers Meeting hosted by
Sipgate in Dusseldorf, Germany:
* https://www.kamailio.org/w/developers-meeting/
16 people were at the event in various roles.
Giacomo Vacca published on his blog a good summary of what happened there:
*
https://www.giacomovacca.com/2019/11/my-notes-on-kamailio-developer-meeting…
This year we had a lot of discussions, as well as work done on multiple
planes, not only Kamailio code. So I am trying to list here some of the
conclusions for future development, the technical aspects of the
meeting, so everyone is aware and can provide feedback.
1) Effective work was done on:
* kamailio code
* kamailio rpm packaging
* kamailio tools (kamctl)
* kamailio release process
* kamailio project keys (to be used to sign the packages)
2) Documentation
2.a) Wiki
* it was somehow a rough consensus to move the wiki content to github,
along with changing the format from dokuwiki markdown to the
standard/github markdown. This should enable people to make pull
requests so developers or community members can review and aprove new
content. It also makes it easier to contribute using existing github
account, now the kamailio.org/wiki is requiring to make a dedicated
account, which many prefer not to do it.
* the presentation can be done either by using mkdocs to generate html
files hosted on kamailio.org or using the github provided wiki portal.
2.b) Docs for variables and transformations
* there was a proposal to move them in the documentation the modules
that export them, there are pros and cons, needs more discussions. Now
they are in the wiki, so this probably has to resume after deciding on 2.a).
3) Kamailio Modules
3.a) replication (dmq) - several participants discussed about
negotiations between nodes to take active role on some cases (e.g.,
active dialogs)
3.b) api integration - quite some interest in JSON-based API routing,
concluding in extending rtjson to cover more use cases
3.c) security - have options to restrict the use of TLS1.3 or newer
4) Kamailio Releases
* v5.3.2 was released during the event, allowing to document the process
* work to automatize the process is planned, then eventually assing
teams for takeing cares of releases from specific branches
5) Kamailio Testing
* existing docker-based testing framework should be extended and
integrated in CD/CI pipeline
6) Kamailio packages
6.a) rpms
* rpm.kamailio.org has been prepared and is expected to take over the
opensuse build service for building rpms and hosting them. Expected to
provide support for hosting many kamailio versions in the same release
series so one can do downgrade to older releases. Also, there is work in
progress to provide nightly builds.
6.b) debs
* work is planned to offer many kamailio versions in the same release
series
7) Kamailio tools
* kamctl/kamdbctl should be obsoleted in favor of kamcli, which offers
a better framework for input validation and output formatting, as well
as better portability, no longer depending on shell interpreter
8) Various discussions
* kemi exports from C point of view and how to combine the
documentation for modules and their kemi exports
* how to make kamaiio friendlier in virtualized environments (ended up
in the need of making the use of advertised address a bit more dynamic)
* project organizatoric topics - to be approached separately
* next events - Fosdem - someone should submit a proposal to present
about Kamailio
9) Long term goals
We speak here more or less about Kamailio 6.0 ...
* change the behaviour of the native config interpreter to be
consistent with the other programming languages in terms of handling the
response code (change what is now: the evaluation of negative value to
false and positive value to true and the hidden return 0 to exit)
* make the pool of processes more generic, so they can handle traffic
from more sockets (being sip traffic or something else) -- this should
make better use of resources, as some sockets might be less busy that others
I hope I covered the important topics, if I remember something else, I
will reply on this thread. Or maybe other participants can contribute
missing topics.
Should anyone have comments or suggestions on the above topics, or new
ones, let's discuss on sr-users because it impacts the long term use of
Kamailio (sr-dev is cc-ed now for notification purposes).
Overall, there were 2 very intensive days, however in a friendly and
relaxed environment offered by Sipgate. Extremely useful discussions,
not only about Kamailio, but about RTC ecosystem. At the evening social
network event event, a couple of external people joined, some of them
presenting very interesting use cases of Kamailio.
Many thanks to all participants that allocated time and resources to
come to Dusseldorf, as well as to the companies that covered expenses
for participants.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - April 27-29, 2020, in Berlin -- www.kamailioworld.com
### Description
I have listeners on multiple ports. (5060, 5080, 7000)
I want force change port to 5060 for outbound messages. To do this i use
```
force_send_socket($Ri:5060);
```
When I check config using `kamailio -c`, then I get error message
```
syntax error, unexpected AVP_OR_PVAR
```
Could you add support of pseudo variable as argument of `force_send_socket` function
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2145