Module: kamailio
Branch: master
Commit: 42e1a9c3c5df65cae8a5f559f6fe47a6de5f6fac
URL: https://github.com/kamailio/kamailio/commit/42e1a9c3c5df65cae8a5f559f6fe47a…
Author: Xenofon Karamanos <xk(a)gilawa.com>
Committer: Xenofon Karamanos <xk(a)gilawa.com>
Date: 2025-05-19T10:48:51Z
cmake: Remove find_package for ORTP and Mediastreamer2 libraries
- Use pkg-config instead because their cmake configs are not up to standard and complicates things
---
Modified: src/modules/rtp_media_server/CMakeLists.txt
---
Diff: https://github.com/kamailio/kamailio/commit/42e1a9c3c5df65cae8a5f559f6fe47a…
Patch: https://github.com/kamailio/kamailio/commit/42e1a9c3c5df65cae8a5f559f6fe47a…
---
diff --git a/src/modules/rtp_media_server/CMakeLists.txt b/src/modules/rtp_media_server/CMakeLists.txt
index 59a1d868d34..15114891902 100644
--- a/src/modules/rtp_media_server/CMakeLists.txt
+++ b/src/modules/rtp_media_server/CMakeLists.txt
@@ -2,18 +2,15 @@ file(GLOB MODULE_SOURCES "*.c")
add_library(${module_name} SHARED ${MODULE_SOURCES})
-find_package(ortp QUIET)
-if(NOT ortp_FOUND)
- find_package(PkgConfig REQUIRED)
- pkg_check_modules(ortp REQUIRED IMPORTED_TARGET ortp)
- add_library(ortp ALIAS PkgConfig::ortp)
-endif()
+find_package(PkgConfig REQUIRED)
-find_package(mediastreamer2 QUIET)
-if(NOT mediastreamer2_FOUND)
- find_package(PkgConfig REQUIRED)
- pkg_check_modules(mediastreamer2 REQUIRED IMPORTED_TARGET mediastreamer)
- add_library(mediastreamer2 ALIAS PkgConfig::mediastreamer2)
-endif()
+# ortp and mediastreamer2 do have cmake support on newer version but
+# is not up to standard and complicates things.
+# So we use pkg-config to find them.
+pkg_check_modules(ortp REQUIRED IMPORTED_TARGET ortp)
+add_library(ortp ALIAS PkgConfig::ortp)
+
+pkg_check_modules(mediastreamer2 REQUIRED IMPORTED_TARGET mediastreamer)
+add_library(mediastreamer2 ALIAS PkgConfig::mediastreamer2)
target_link_libraries(${module_name} PRIVATE ortp mediastreamer2)
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
I have refactored the rpm packaging and am now using the GitHub actions.
Now `tar.gz` archive with rpm packages, source rpm and deps rpm files attached to the release message like.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4194
-- Commit Summary --
* generate rpm packages using github actions
-- File Changes --
A .github/workflows/rpm.yml (57)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4194.patchhttps://github.com/kamailio/kamailio/pull/4194.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4194
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4194(a)github.com>
- fixed log message in MAR Async CDP callback
- fixed executing cfg_action after sending MAR Diameter request
- cfg_action is the callback parameter of the ims_www_challenge function
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #4205 (replace XXXX with an open issue number)
#### Description
Based on the description in issue #4205, this PR will fix a bug in ims_auth module related to MAR Diameter request callbacks, by replacing the call to t_continue function with t_continue_skip_timer, after the MAR request is sent, the control will successfully move to the cfg action in Kamailio scripts. Just like what we already have in ims_registrar_scscf module, using t_continue_skip_timer instead of t_continue cause the transaction to be found and resumed.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4206
-- Commit Summary --
* ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c
-- File Changes --
M src/modules/ims_auth/cxdx_mar.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4206.patchhttps://github.com/kamailio/kamailio/pull/4206.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4206
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4206(a)github.com>
nochnoi82 created an issue (kamailio/kamailio#4243)
Greetings folks.
Need your help or conclusion.
Debian 12
Kamailio 6.0.1 (Open source installed)
Init script and systemd script were applied.
kamctl start (/usr/local/sbin)
ERROR: PID file /var/run/kamailio.pid does not exist -- Kamailio start failed
kamailio start (/usr/local/sbin)
error: 'start' is not a supported argument
error: stopping kamailio ...
sudo journalctl -xeu kamailio
ERROR: db_mysql [km_my_con.c:219]: db_mysql_new_connection(): driver error: Access denied for user 'kamailio'@'localhost' (using password: YES)
May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [lib/srdb1/db.c:326]: db_do_init2(): could not add connection to the pool
May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: usrloc [dlist.c:848]: register_udomain(): failed to open database connection
May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: registrar [registrar.c:773]: domain_fixup(): failed to register domain
May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/route.c:1195]: fix_actions(): fixing failed (code=-1) at cfg:/usr/local/etc/kamailio/kamailio.cfg:750
May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/rvalue.c:3816]: fix_rval_expr(): failure in cfg at line: 750 col: 22
May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/rvalue.c:3816]: fix_rval_expr(): failure in cfg at line: 750 col: 22
May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/route.c:1195]: fix_actions(): fixing failed (code=-1) at cfg:/usr/local/etc/kamailio/kamailio.cfg:753
Kamailio acts as proxy server only.
What did i miss?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4243
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4243(a)github.com>