- sr-dev - kamailio.org

git:master:964c21e1: pv_headers: rearrange module parameters
by Victor Seva 07 Dec '23

07 Dec '23

Module: kamailio Branch: master Commit: 964c21e16ab4da96d989c230ea18d95872257394 URL: https://github.com/kamailio/kamailio/commit/964c21e16ab4da96d989c230ea18d95… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-07T12:28:02+01:00 pv_headers: rearrange module parameters * pvh_ prefix for global variables --- Modified: src/modules/pv_headers/pv_headers.c Modified: src/modules/pv_headers/pv_headers.h Modified: src/modules/pv_headers/pvh_func.c Modified: src/modules/pv_headers/pvh_func.h Modified: src/modules/pv_headers/pvh_hash.c Modified: src/modules/pv_headers/pvh_hash.h Modified: src/modules/pv_headers/pvh_hdr.c Modified: src/modules/pv_headers/pvh_hdr.h Modified: src/modules/pv_headers/pvh_str.c Modified: src/modules/pv_headers/pvh_str.h Modified: src/modules/pv_headers/pvh_xavp.c Modified: src/modules/pv_headers/pvh_xavp.h --- Diff: https://github.com/kamailio/kamailio/commit/964c21e16ab4da96d989c230ea18d95… Patch: https://github.com/kamailio/kamailio/commit/964c21e16ab4da96d989c230ea18d95…

1 0

Error during TLS handshake
by Markus Bönke 07 Dec '23

07 Dec '23

Hello ng, I currently face an issue to forward a call via tls to a destination. The check with "openssl client -connect …" to the destination is successful and it returns a valid certificate. However if I forward the call via kamailio I see an TLS error: Alert (Level: Fatal, Description: Unknown CA) I’ve compiled tls module with extra_defs="-DTLS_WR_DEBUG -DTLS_RD_DEBUG“ (with 5.4.9 and 5.5.7) and can see: Dec 7 10:46:40 mbo-debian-vm1 /usr/local/sbin/kamailio[170469]: DEBUG: TLS_TRACE: tls [tls_server.c:1141]: tls_h_read_f(): tls_h_read_f(0xffff898c8a88, 0xffffcc5fe320) tls write on read (WRITE_WANTS_READ): ct_wq_flush()=> 0 (ff=2 ssl_error=1)) Dec 7 10:46:40 mbo-debian-vm1 /usr/local/sbin/kamailio[170469]: DEBUG: TLS_TRACE: tls [tls_server.c:1268]: tls_h_read_f(): tls_h_read_f(0xffff898c8a88, 0xffffcc5fe320) tcpconn_send_unsafe 7 bytes Dec 7 10:46:40 mbo-debian-vm1 /usr/local/sbin/kamailio[170469]: ERROR: tls [tls_server.c:1329]: tls_h_read_f(): protocol level error Dec 7 10:46:40 mbo-debian-vm1 /usr/local/sbin/kamailio[170469]: ERROR: tls [tls_util.h:42]: tls_err_ret(): TLS write:error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed It looks like the error "Unknown CA“ is a subsequent error, but the main problem occurs while reading from the tls connection. I’m currently can also debug the issue in the tls module, is there anything which I can check? Maybe the certificate chain is too long? Thanks and regards Markus

1 0

git:master:890dc5f0: ims_charging: free local structure in case of errors
by Daniel-Constantin Mierla 07 Dec '23

07 Dec '23

Module: kamailio Branch: master Commit: 890dc5f017084481cd2b0f0d759939393fa115bc URL: https://github.com/kamailio/kamailio/commit/890dc5f017084481cd2b0f0d7599393… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-07T08:21:22+01:00 ims_charging: free local structure in case of errors --- Modified: src/modules/ims_charging/ims_ro.c --- Diff: https://github.com/kamailio/kamailio/commit/890dc5f017084481cd2b0f0d7599393… Patch: https://github.com/kamailio/kamailio/commit/890dc5f017084481cd2b0f0d7599393… --- diff --git a/src/modules/ims_charging/ims_ro.c b/src/modules/ims_charging/ims_ro.c index 6fe14ae3dd7..11c74169293 100644 --- a/src/modules/ims_charging/ims_ro.c +++ b/src/modules/ims_charging/ims_ro.c @@ -1721,6 +1721,7 @@ static void resume_on_initial_ccr( } Ro_free_CCA(ro_cca_data); + ro_cca_data = NULL; LM_DBG("Freeing CCA message\n"); cdpb.AAAFreeMessage(&cca); @@ -1757,9 +1758,11 @@ static void resume_on_initial_ccr( return; error1: - Ro_free_CCA(ro_cca_data); - error0: + if(ro_cca_data != NULL) { + Ro_free_CCA(ro_cca_data); + } + LM_DBG("Trying to reserve credit on initial INVITE failed on cdp " "callback\n"); // counter_add(ims_charging_cnts_h.active_ro_sessions, -1); /*we bumped active on the original initial ccr sent */

1 0

git:master:8794e509: core: tcp - set type for literals usef for time difference
by Daniel-Constantin Mierla 07 Dec '23

07 Dec '23

Module: kamailio Branch: master Commit: 8794e509b951658e055cc06374c0e2561debdde3 URL: https://github.com/kamailio/kamailio/commit/8794e509b951658e055cc06374c0e25… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-07T07:02:42+01:00 core: tcp - set type for literals usef for time difference --- Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/8794e509b951658e055cc06374c0e25… Patch: https://github.com/kamailio/kamailio/commit/8794e509b951658e055cc06374c0e25… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 3d4a6a4e0b1..4972b7d20af 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -5489,11 +5489,11 @@ void tcp_timer_check_connections(unsigned int ticks, void *param) cidset = 0; if(con->state == S_CONN_OK) { if(con->req.tvrstart.tv_sec > 0) { - tvdiff = 1000000 + tvdiff = 1000000LL * (tvnow.tv_sec - con->req.tvrstart.tv_sec) + (tvnow.tv_usec - con->req.tvrstart.tv_usec); - if(tvdiff >= ksr_tcp_msg_read_timeout * 1000000) { + if(tvdiff >= 1000000LL * ksr_tcp_msg_read_timeout) { LM_DBG("n: %d - connection id: %d - message " "reading timeout: %lld\n", n, con->id, tvdiff);

1 0

Jenkins build is still unstable: kamailiodev-nightly-binaries » amd64,stretch #2546
by kamailio＠sipwise.com 07 Dec '23

07 Dec '23

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

git:master:8ca5d90a: cfgt: rearrange mod parameters
by Victor Seva 06 Dec '23

06 Dec '23

Module: kamailio Branch: master Commit: 8ca5d90a44166bf1a501680b2e01dfbbab5f5b94 URL: https://github.com/kamailio/kamailio/commit/8ca5d90a44166bf1a501680b2e01dfb… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-06T13:00:11+01:00 cfgt: rearrange mod parameters * use _cfgt_ prefix for init_flag --- Modified: src/modules/cfgt/cfgt.c Modified: src/modules/cfgt/cfgt.h Modified: src/modules/cfgt/cfgt_int.c Modified: src/modules/cfgt/cfgt_int.h Modified: src/modules/cfgt/cfgt_mod.c Modified: src/modules/cfgt/cfgt_mod.h --- Diff: https://github.com/kamailio/kamailio/commit/8ca5d90a44166bf1a501680b2e01dfb… Patch: https://github.com/kamailio/kamailio/commit/8ca5d90a44166bf1a501680b2e01dfb…

1 0

git:master:b7b3f94f: core: xavp - serialize long long values
by Daniel-Constantin Mierla 06 Dec '23

06 Dec '23

Module: kamailio Branch: master Commit: b7b3f94f949feed3cf9e2e3adf3b4596e6e20eac URL: https://github.com/kamailio/kamailio/commit/b7b3f94f949feed3cf9e2e3adf3b459… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-06T08:48:39+01:00 core: xavp - serialize long long values - they are printed as unsigned values, same as for long values --- Modified: src/core/xavp.c --- Diff: https://github.com/kamailio/kamailio/commit/b7b3f94f949feed3cf9e2e3adf3b459… Patch: https://github.com/kamailio/kamailio/commit/b7b3f94f949feed3cf9e2e3adf3b459… --- diff --git a/src/core/xavp.c b/src/core/xavp.c index 32d1cef8391..58f3a567611 100644 --- a/src/core/xavp.c +++ b/src/core/xavp.c @@ -1147,24 +1147,35 @@ int xavp_serialize_fields_style(str *rname, int mode, char *obuf, int olen) switch(avp->val.type) { case SR_XTYPE_LONG: LM_DBG(" XAVP long int value: %ld\n", avp->val.v.l); - ostr.len = snprintf(ostr.s, olen - rlen, "%s%.*s=%lu%s", - pr, avp->name.len, avp->name.s, - (unsigned long)avp->val.v.l, sf); + ostr.len = snprintf(ostr.s, olen - rlen, "%s%.*s=%lu%s", pr, + avp->name.len, avp->name.s, (unsigned long)avp->val.v.l, + sf); if(ostr.len <= 0 || ostr.len >= olen - rlen) { - LM_ERR("failed to serialize int value (%d/%d\n", ostr.len, - olen - rlen); + LM_ERR("failed to serialize long int value (%d/%d\n", + ostr.len, olen - rlen); + return -1; + } + break; + case SR_XTYPE_LLONG: + LM_DBG(" XAVP long long int value: %lld\n", avp->val.v.ll); + ostr.len = snprintf(ostr.s, olen - rlen, "%s%.*s=%llu%s", pr, + avp->name.len, avp->name.s, + (unsigned long long)avp->val.v.ll, sf); + if(ostr.len <= 0 || ostr.len >= olen - rlen) { + LM_ERR("failed to serialize long long value (%d/%d\n", + ostr.len, olen - rlen); return -1; } break; case SR_XTYPE_STR: LM_DBG(" XAVP str value: %s\n", avp->val.v.s.s); if(avp->val.v.s.len == 0) { - ostr.len = snprintf(ostr.s, olen - rlen, "%s%.*s%s", - pr, avp->name.len, avp->name.s, sf); + ostr.len = snprintf(ostr.s, olen - rlen, "%s%.*s%s", pr, + avp->name.len, avp->name.s, sf); } else { - ostr.len = snprintf(ostr.s, olen - rlen, "%s%.*s=%s%.*s%s%s", - pr, avp->name.len, avp->name.s, qs, avp->val.v.s.len, - avp->val.v.s.s, qs, sf); + ostr.len = snprintf(ostr.s, olen - rlen, + "%s%.*s=%s%.*s%s%s", pr, avp->name.len, avp->name.s, + qs, avp->val.v.s.len, avp->val.v.s.s, qs, sf); } if(ostr.len <= 0 || ostr.len >= olen - rlen) { LM_ERR("failed to serialize int value (%d/%d\n", ostr.len, @@ -1634,8 +1645,19 @@ int xavu_serialize_fields(str *rname, char *obuf, int olen) avu->name.len, avu->name.s, (unsigned long)avu->val.v.l); if(ostr.len <= 0 || ostr.len >= olen - rlen) { - LM_ERR("failed to serialize int value (%d/%d\n", ostr.len, - olen - rlen); + LM_ERR("failed to serialize long int value (%d/%d\n", + ostr.len, olen - rlen); + return -1; + } + break; + case SR_XTYPE_LLONG: + LM_DBG(" XAVP long long int value: %lld\n", avu->val.v.ll); + ostr.len = snprintf(ostr.s, olen - rlen, "%.*s=%llu;", + avu->name.len, avu->name.s, + (unsigned long long)avu->val.v.ll); + if(ostr.len <= 0 || ostr.len >= olen - rlen) { + LM_ERR("failed to serialize long long value (%d/%d\n", + ostr.len, olen - rlen); return -1; } break; @@ -2597,8 +2619,19 @@ int xavi_serialize_fields(str *rname, char *obuf, int olen) avi->name.len, avi->name.s, (unsigned long)avi->val.v.l); if(ostr.len <= 0 || ostr.len >= olen - rlen) { - LM_ERR("failed to serialize int value (%d/%d\n", ostr.len, - olen - rlen); + LM_ERR("failed to serialize long int value (%d/%d\n", + ostr.len, olen - rlen); + return -1; + } + break; + case SR_XTYPE_LLONG: + LM_DBG(" XAVP long long int value: %lld\n", avi->val.v.ll); + ostr.len = snprintf(ostr.s, olen - rlen, "%.*s=%llu;", + avi->name.len, avi->name.s, + (unsigned long long)avi->val.v.ll); + if(ostr.len <= 0 || ostr.len >= olen - rlen) { + LM_ERR("failed to serialize long long value (%d/%d\n", + ostr.len, olen - rlen); return -1; } break;

1 0

git:master:e0909ab1: topoh: init vars inside th_build_socket_strings()
by Daniel-Constantin Mierla 06 Dec '23

06 Dec '23

Module: kamailio Branch: master Commit: e0909ab1c890b11204dd38b26283cba5fad289c7 URL: https://github.com/kamailio/kamailio/commit/e0909ab1c890b11204dd38b26283cba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-06T08:48:39+01:00 topoh: init vars inside th_build_socket_strings() --- Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/e0909ab1c890b11204dd38b26283cba… Patch: https://github.com/kamailio/kamailio/commit/e0909ab1c890b11204dd38b26283cba… --- diff --git a/src/modules/topoh/topoh_mod.c b/src/modules/topoh/topoh_mod.c index d40f70fdd86..02098b1c1b0 100644 --- a/src/modules/topoh/topoh_mod.c +++ b/src/modules/topoh/topoh_mod.c @@ -312,9 +312,9 @@ int th_build_uri_prefix(str *uri_prefix, str *ip) */ int th_build_socket_strings(socket_info_t *socket) { - struct th_socket_strings *socket_strings; - struct str_hash_entry *table_entry; - str *socket_ip; + struct th_socket_strings *socket_strings = NULL; + struct str_hash_entry *table_entry = NULL; + str *socket_ip = NULL; if(str_hash_get( th_socket_hash_table, socket->sockname.s, socket->sockname.len)

1 0

git:master:a096684c: github: devcontainer support force build parameter [skip ci]
by Victor Seva 06 Dec '23

06 Dec '23

Module: kamailio Branch: master Commit: a096684c69bd121ba5e60f682e236f621f0e343b URL: https://github.com/kamailio/kamailio/commit/a096684c69bd121ba5e60f682e236f6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-06T01:57:51+01:00 github: devcontainer support force build parameter [skip ci] --- Modified: .github/workflows/devcontainer.yaml --- Diff: https://github.com/kamailio/kamailio/commit/a096684c69bd121ba5e60f682e236f6… Patch: https://github.com/kamailio/kamailio/commit/a096684c69bd121ba5e60f682e236f6… --- diff --git a/.github/workflows/devcontainer.yaml b/.github/workflows/devcontainer.yaml index 3321b4feec4..bfecd095f55 100644 --- a/.github/workflows/devcontainer.yaml +++ b/.github/workflows/devcontainer.yaml @@ -7,6 +7,11 @@ name: build devcontainer image - master # Allows you to run this workflow manually from the Actions tab workflow_dispatch: + inputs: + force: + required: true + type: boolean + default: false env: DIST: bookworm @@ -26,12 +31,14 @@ jobs: run: echo ${{ github.sha }} - name: Get changed files + if: ${{ ! inputs.force }} id: changed-files uses: tj-actions/changed-files@v40 with: since_last_remote_commit: true - name: changes in relevant files + if: ${{ ! inputs.force }} id: changed-files-builder uses: tj-actions/changed-files@v40 with: @@ -40,7 +47,7 @@ jobs: pkg/kamailio/deb/${{ env.DIST }}/** - name: Login to GitHub Container Registry - if: steps.changed-files-builder.outputs.any_changed == 'true' + if: steps.changed-files-builder.outputs.any_changed == 'true' || inputs.force uses: docker/login-action@v3 with: registry: ghcr.io @@ -48,7 +55,7 @@ jobs: password: ${{ secrets.GITHUB_TOKEN }} - name: Pre-build dev container image - if: steps.changed-files-builder.outputs.any_changed == 'true' + if: steps.changed-files-builder.outputs.any_changed == 'true' || inputs.force uses: devcontainers/ci(a)v0.3 with: imageName: ghcr.io/${{ github.repository_owner }}/kamailio-${{ github.ref_name }}-devcontainer

1 0

[kamailio/kamailio] phonenum: cannot build on Fedora 39 (Issue #3659)
by sergey-safarov 05 Dec '23

05 Dec '23

``` LD (gcc) [M db_perlvdb.so] db_perlvdb.so CC (gcc) [M phonenum.so] phonenum_mod.o CC (gcc) [M phonenum.so] phonenum_pv.o Compiling cphonenumber.cpp g++ -std=c++11 -fPIC -DPIC -g -funroll-loops -Wcast-align -pthread -DKSR_PTHREAD_MUTEX_SHARED -Wall -Wno-write-strings -Wno-deprecated -Wno-unused-function -Wno-sign-compare -Wno-strict-aliasing -fPIC -DPIC -g -funroll-loops -Wcast-align -pthread -DKSR_PTHREAD_MUTEX_SHARED -Wall -DNAME='"kamailio"' -DVERSION='"5.7.2"' -DARCH='"x86_64"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 13.2.1"' -D__CPU_x86_64 -D__OS_linux -DVERSIONVAL=5007002 -DCFG_DIR='"/etc/kamailio/"' -DSHARE_DIR='"/usr/share/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR -DWITH_XAVP -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKAROUND -DUSE_FUTEX -DHAVE_SELECT -I/usr/local/include -DMOD_NAME='"phonenum"' -c cphonenumber.cpp -o cphonenumber.o In file included from /usr/include/absl/base/config.h:86, from /usr/include/absl/base/const_init.h:25, from /usr/include/absl/synchronization/mutex.h:67, from /usr/include/phonenumbers/geocoding/phonenumber_offline_geocoder.h:24, from cphonenumber.cpp:24: /usr/include/absl/base/policy_checks.h:79:2: error: #error "C++ versions less than C++14 are not supported." 79 | #error "C++ versions less than C++14 are not supported." | ^~~~~ In file included from /usr/include/absl/time/time.h:89, from /usr/include/absl/time/clock.h:26, from /usr/include/absl/synchronization/internal/kernel_timeout.h:30, from /usr/include/absl/synchronization/mutex.h:74: /usr/include/absl/strings/string_view.h:52:26: error: ‘string_view’ in namespace ‘std’ does not name a type 52 | using string_view = std::string_view; | ^~~~~~~~~~~ /usr/include/absl/strings/string_view.h:52:21: note: ‘std::string_view’ is only available from C++17 onwards 52 | using string_view = std::string_view; | ^~~ /usr/include/absl/strings/string_view.h:686:8: error: ‘string_view’ does not name a type 686 | inline string_view ClippedSubstr(string_view s, size_t pos, | ^~~~~~~~~~~ /usr/include/absl/strings/string_view.h:697:11: error: ‘string_view’ does not name a type 697 | constexpr string_view NullSafeStringView(const char* p) { | ^~~~~~~~~~~ In file included from /usr/include/absl/time/time.h:90: /usr/include/absl/time/civil_time.h:489:27: error: ‘string_view’ is not a member of ‘absl’ 489 | bool ParseCivilTime(absl::string_view s, CivilSecond* c); | ^~~~~~~~~~~ /usr/include/absl/time/civil_time.h:489:53: error: expected primary-expression before ‘*’ token 489 | bool ParseCivilTime(absl::string_view s, CivilSecond* c); | ^ /usr/include/absl/time/civil_time.h:489:55: error: ‘c’ was not declared in this scope 489 | bool ParseCivilTime(absl::string_view s, CivilSecond* c); | ^ /usr/include/absl/time/civil_time.h:489:56: error: expression list treated as compound expression in initializer [-fpermissive] 489 | bool ParseCivilTime(absl::string_view s, CivilSecond* c); | ^ /usr/include/absl/time/civil_time.h:490:6: error: redefinition of ‘bool absl::lts_20230802::ParseCivilTime’ 490 | bool ParseCivilTime(absl::string_view s, CivilMinute* c); | ^~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:489:6: note: ‘bool absl::lts_20230802::ParseCivilTime’ previously defined here 489 | bool ParseCivilTime(absl::string_view s, CivilSecond* c); | ^~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:490:27: error: ‘string_view’ is not a member of ‘absl’ 490 | bool ParseCivilTime(absl::string_view s, CivilMinute* c); | ^~~~~~~~~~~ /usr/include/absl/time/civil_time.h:490:53: error: expected primary-expression before ‘*’ token 490 | bool ParseCivilTime(absl::string_view s, CivilMinute* c); | ^ /usr/include/absl/time/civil_time.h:490:55: error: ‘c’ was not declared in this scope 490 | bool ParseCivilTime(absl::string_view s, CivilMinute* c); | ^ /usr/include/absl/time/civil_time.h:491:6: error: redefinition of ‘bool absl::lts_20230802::ParseCivilTime’ 491 | bool ParseCivilTime(absl::string_view s, CivilHour* c); | ^~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:489:6: note: ‘bool absl::lts_20230802::ParseCivilTime’ previously defined here 489 | bool ParseCivilTime(absl::string_view s, CivilSecond* c); | ^~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:491:27: error: ‘string_view’ is not a member of ‘absl’ 491 | bool ParseCivilTime(absl::string_view s, CivilHour* c); | ^~~~~~~~~~~ /usr/include/absl/time/civil_time.h:491:51: error: expected primary-expression before ‘*’ token 491 | bool ParseCivilTime(absl::string_view s, CivilHour* c); | ^ /usr/include/absl/time/civil_time.h:491:53: error: ‘c’ was not declared in this scope 491 | bool ParseCivilTime(absl::string_view s, CivilHour* c); | ^ /usr/include/absl/time/civil_time.h:492:6: error: redefinition of ‘bool absl::lts_20230802::ParseCivilTime’ 492 | bool ParseCivilTime(absl::string_view s, CivilDay* c); | ^~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:489:6: note: ‘bool absl::lts_20230802::ParseCivilTime’ previously defined here 489 | bool ParseCivilTime(absl::string_view s, CivilSecond* c); | ^~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:492:27: error: ‘string_view’ is not a member of ‘absl’ 492 | bool ParseCivilTime(absl::string_view s, CivilDay* c); | ^~~~~~~~~~~ /usr/include/absl/time/civil_time.h:492:50: error: expected primary-expression before ‘*’ token 492 | bool ParseCivilTime(absl::string_view s, CivilDay* c); | ^ /usr/include/absl/time/civil_time.h:492:52: error: ‘c’ was not declared in this scope 492 | bool ParseCivilTime(absl::string_view s, CivilDay* c); | ^ /usr/include/absl/time/civil_time.h:493:6: error: redefinition of ‘bool absl::lts_20230802::ParseCivilTime’ 493 | bool ParseCivilTime(absl::string_view s, CivilMonth* c); | ^~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:489:6: note: ‘bool absl::lts_20230802::ParseCivilTime’ previously defined here 489 | bool ParseCivilTime(absl::string_view s, CivilSecond* c); | ^~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:493:27: error: ‘string_view’ is not a member of ‘absl’ 493 | bool ParseCivilTime(absl::string_view s, CivilMonth* c); | ^~~~~~~~~~~ /usr/include/absl/time/civil_time.h:493:52: error: expected primary-expression before ‘*’ token 493 | bool ParseCivilTime(absl::string_view s, CivilMonth* c); | ^ /usr/include/absl/time/civil_time.h:493:54: error: ‘c’ was not declared in this scope 493 | bool ParseCivilTime(absl::string_view s, CivilMonth* c); | ^ /usr/include/absl/time/civil_time.h:494:6: error: redefinition of ‘bool absl::lts_20230802::ParseCivilTime’ 494 | bool ParseCivilTime(absl::string_view s, CivilYear* c); | ^~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:489:6: note: ‘bool absl::lts_20230802::ParseCivilTime’ previously defined here 489 | bool ParseCivilTime(absl::string_view s, CivilSecond* c); | ^~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:494:27: error: ‘string_view’ is not a member of ‘absl’ 494 | bool ParseCivilTime(absl::string_view s, CivilYear* c); | ^~~~~~~~~~~ /usr/include/absl/time/civil_time.h:494:51: error: expected primary-expression before ‘*’ token 494 | bool ParseCivilTime(absl::string_view s, CivilYear* c); | ^ /usr/include/absl/time/civil_time.h:494:53: error: ‘c’ was not declared in this scope 494 | bool ParseCivilTime(absl::string_view s, CivilYear* c); | ^ /usr/include/absl/time/civil_time.h:509:34: error: ‘string_view’ is not a member of ‘absl’ 509 | bool ParseLenientCivilTime(absl::string_view s, CivilSecond* c); | ^~~~~~~~~~~ /usr/include/absl/time/civil_time.h:509:60: error: expected primary-expression before ‘*’ token 509 | bool ParseLenientCivilTime(absl::string_view s, CivilSecond* c); | ^ /usr/include/absl/time/civil_time.h:509:62: error: ‘c’ was not declared in this scope 509 | bool ParseLenientCivilTime(absl::string_view s, CivilSecond* c); | ^ /usr/include/absl/time/civil_time.h:509:63: error: expression list treated as compound expression in initializer [-fpermissive] 509 | bool ParseLenientCivilTime(absl::string_view s, CivilSecond* c); | ^ /usr/include/absl/time/civil_time.h:510:6: error: redefinition of ‘bool absl::lts_20230802::ParseLenientCivilTime’ 510 | bool ParseLenientCivilTime(absl::string_view s, CivilMinute* c); | ^~~~~~~~~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:509:6: note: ‘bool absl::lts_20230802::ParseLenientCivilTime’ previously defined here 509 | bool ParseLenientCivilTime(absl::string_view s, CivilSecond* c); | ^~~~~~~~~~~~~~~~~~~~~ /usr/include/absl/time/civil_time.h:510:34: error: ‘string_view’ is not a member of ‘absl’ 510 | bool ParseLenientCivilTime(absl::string_view s, CivilMinute* c); | ^~~~~~~~~~~ /usr/include/absl/time/civil_time.h:510:60: error: expected primary-expression before ‘*’ token 510 | bool ParseLenientCivilTime(absl::string_view s, CivilMinute* c); | ^ ``` Full log in the attached file [phonenum-build.log](https://github.com/kamailio/kamailio/files/13489193/pho… -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3659 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3659(a)github.com>

2 4

git:master:6dd5598f: phonenum: Makefile - option to set C standard version
by Daniel-Constantin Mierla 05 Dec '23

05 Dec '23

Module: kamailio Branch: master Commit: 6dd5598fc043fe3d2582e643d7d4ef675c9e6480 URL: https://github.com/kamailio/kamailio/commit/6dd5598fc043fe3d2582e643d7d4ef6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-05T19:30:21+01:00 phonenum: Makefile - option to set C standard version - can be set via option CSTDVER - defaults now to c++17 - GH #3659 --- Modified: src/modules/phonenum/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/6dd5598fc043fe3d2582e643d7d4ef6… Patch: https://github.com/kamailio/kamailio/commit/6dd5598fc043fe3d2582e643d7d4ef6… --- diff --git a/src/modules/phonenum/Makefile b/src/modules/phonenum/Makefile index f465226a974..47780869232 100644 --- a/src/modules/phonenum/Makefile +++ b/src/modules/phonenum/Makefile @@ -7,6 +7,7 @@ NAME=phonenum.so CXX?=g++ LD?=g++ +CSTDVER?="c++17" LIBS+=-L$(LOCALBASE)/lib cphonenumber.o -lphonenumber -lgeocoding DEFS+=-I$(LOCALBASE)/include @@ -18,7 +19,7 @@ include ../../Makefile.modules cphonenumber.o: cphonenumber.cpp cphonenumber.h @echo "Compiling $<" - $(CXX) -std=c++11 $(CXXFLAGS) $(CFLAGS) $(C_DEFS) $(DEFS) -c $< -o $@ + $(CXX) -std=$(CSTDVER) $(CXXFLAGS) $(CFLAGS) $(C_DEFS) $(DEFS) -c $< -o $@ phonenum.so: cphonenumber.o

1 0

git:master:a9e02966: core: remove unnecessary condition on msg
by Daniel-Constantin Mierla 05 Dec '23

05 Dec '23

Module: kamailio Branch: master Commit: a9e02966384cbcdf04aa16feb034b87e524352c9 URL: https://github.com/kamailio/kamailio/commit/a9e02966384cbcdf04aa16feb034b87… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-05T15:08:50+01:00 core: remove unnecessary condition on msg - the structure is already used before --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/a9e02966384cbcdf04aa16feb034b87… Patch: https://github.com/kamailio/kamailio/commit/a9e02966384cbcdf04aa16feb034b87… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index 51c3477c5ee..52307ce8ad8 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -2517,7 +2517,7 @@ char *build_res_buf_from_sip_req(unsigned int code, str *text, str *new_tag, } /* test and add xavp via reply params */ - if(msg && (msg->msg_flags & FL_ADD_XAVP_VIA_REPLY_PARAMS) + if((msg->msg_flags & FL_ADD_XAVP_VIA_REPLY_PARAMS) && _ksr_xavp_via_reply_params.len > 0) { xparams.s = pv_get_buffer(); xparams.len = xavp_serialize_fields_style(&_ksr_xavp_via_reply_params,

1 0

Updated: Online devel meeting on matrix - 15:00 UTC, Dec 5, 2023
by Daniel-Constantin Mierla 05 Dec '23

05 Dec '23

Hello, we should consider an online devel meeting sometime soon to summarize what was done at (and still needs to be done after) devel meeting in Dusseldorf and plan a bit the targets for next major release (5.8 or 6.0)? If considered useful, I propose Dec 5 at 15:00UTC (16:00 Berlin/Paris/Madrid/Rome), but we can also look for other dates as well. Topics to be discussed can be added at: - https://github.com/kamailio/kamailio-wiki/blob/main/docs/devel/irc-meetings… Pull requests can be made by users without git access. Cheers, Daniel PS: Previous announcement indicated the start time 14:30 UTC, this message changes it to 15:00 UTC - 30min later due to a constraint in availability of one of the Kamailio developers. -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

1 3

Kamailio + RTPEngine + TURN server to enable calling between WebRTC client and legacy SIP clients
by nguyenquocchinhdev＠gmail.com 05 Dec '23

05 Dec '23

Hi guys, Can anybody explain to me this flow. https://raw.githubusercontent.com/havfo/WEBRTC-to-SIP/master/images/webrtc-… And What will be done in 1,2,3,4,5. When a new connection the request flow is 1,2,3,4,5 order is created. 1: webRTC client -> SIp Server 2: SIP server -> SIP client 3: Kmailio -> RTPengine 4: SIP client -> RTPengine 5: RTPengine -> webRTC client

3 3

git:master:3a02bf42: ims_charging: log message on db updated error
by Daniel-Constantin Mierla 05 Dec '23

05 Dec '23

Module: kamailio Branch: master Commit: 3a02bf42bc182e0eb809e63d8fe828e3ece5f1da URL: https://github.com/kamailio/kamailio/commit/3a02bf42bc182e0eb809e63d8fe828e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-05T12:26:22+01:00 ims_charging: log message on db updated error --- Modified: src/modules/ims_charging/ro_db_handler.c --- Diff: https://github.com/kamailio/kamailio/commit/3a02bf42bc182e0eb809e63d8fe828e… Patch: https://github.com/kamailio/kamailio/commit/3a02bf42bc182e0eb809e63d8fe828e… --- diff --git a/src/modules/ims_charging/ro_db_handler.c b/src/modules/ims_charging/ro_db_handler.c index 7aaf6fb3a5d..d75126e33bc 100644 --- a/src/modules/ims_charging/ro_db_handler.c +++ b/src/modules/ims_charging/ro_db_handler.c @@ -717,7 +717,9 @@ void ro_update_db(unsigned int ticks, void *param) for(ro_session = ro_session_entry.first; ro_session != NULL; ro_session = ro_session->next) { - update_ro_dbinfo_unsafe(ro_session); + if(update_ro_dbinfo_unsafe(ro_session) != 0) { + LM_ERR("failed to update ro_session in DB\n"); + } } ro_session_unlock(ro_session_table, &ro_session_entry); }

1 0

git:master:4f6a2686: topoh: reorder conditions for safety of cleaning on error
by Daniel-Constantin Mierla 05 Dec '23

05 Dec '23

Module: kamailio Branch: master Commit: 4f6a2686c01a65fe3a23e4d2057c7940eedcf12a URL: https://github.com/kamailio/kamailio/commit/4f6a2686c01a65fe3a23e4d2057c794… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-05T12:20:01+01:00 topoh: reorder conditions for safety of cleaning on error - in the part related to the new th_build_socket_strings() internal function --- Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/4f6a2686c01a65fe3a23e4d2057c794… Patch: https://github.com/kamailio/kamailio/commit/4f6a2686c01a65fe3a23e4d2057c794… --- diff --git a/src/modules/topoh/topoh_mod.c b/src/modules/topoh/topoh_mod.c index dbb08d83084..d40f70fdd86 100644 --- a/src/modules/topoh/topoh_mod.c +++ b/src/modules/topoh/topoh_mod.c @@ -357,14 +357,18 @@ int th_build_socket_strings(socket_info_t *socket) return 0; error: - if(socket_strings->ip.s != NULL) - pkg_free(socket_strings->ip.s); - if(table_entry->key.s != NULL) - pkg_free(table_entry->key.s); - if(table_entry != NULL) - pkg_free(table_entry); - if(socket_strings != NULL) + if(socket_strings != NULL) { + if(socket_strings->ip.s != NULL) { + pkg_free(socket_strings->ip.s); + } pkg_free(socket_strings); + } + if(table_entry != NULL) { + if(table_entry->key.s != NULL) { + pkg_free(table_entry->key.s); + } + pkg_free(table_entry); + } return -1; }

1 0

git:master:0d78a1ad: pkg/kamailio/deb: version set 5.8.0~dev2 [skip ci]
by Victor Seva 05 Dec '23

05 Dec '23

Module: kamailio Branch: master Commit: 0d78a1add4292ff1e10347c0199f0d70d31678ea URL: https://github.com/kamailio/kamailio/commit/0d78a1add4292ff1e10347c0199f0d7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-05T12:04:36+01:00 pkg/kamailio/deb: version set 5.8.0~dev2 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/0d78a1add4292ff1e10347c0199f0d7… Patch: https://github.com/kamailio/kamailio/commit/0d78a1add4292ff1e10347c0199f0d7…

1 0

git:master:6305adef: Makefile.defs: version set to 5.8.0-dev2
by Daniel-Constantin Mierla 05 Dec '23

05 Dec '23

Module: kamailio Branch: master Commit: 6305adef50079891386a048b986fd27e9b6e7ca1 URL: https://github.com/kamailio/kamailio/commit/6305adef50079891386a048b986fd27… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-05T12:00:00+01:00 Makefile.defs: version set to 5.8.0-dev2 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/6305adef50079891386a048b986fd27… Patch: https://github.com/kamailio/kamailio/commit/6305adef50079891386a048b986fd27… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 075ac2041a6..68225943982 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 8 SUBLEVEL = 0 -EXTRAVERSION = -dev1 +EXTRAVERSION = -dev2 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master:ca7e1e49: dialog: prevent duplicate of leg1 attributes in json for dmq
by Daniel-Constantin Mierla 05 Dec '23

05 Dec '23

Module: kamailio Branch: master Commit: ca7e1e49aecd3e0f12cc783e3b97868980f1d3d2 URL: https://github.com/kamailio/kamailio/commit/ca7e1e49aecd3e0f12cc783e3b97868… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-05T10:27:32+01:00 dialog: prevent duplicate of leg1 attributes in json for dmq - reported by #3656 --- Modified: src/modules/dialog/dlg_dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/ca7e1e49aecd3e0f12cc783e3b97868… Patch: https://github.com/kamailio/kamailio/commit/ca7e1e49aecd3e0f12cc783e3b97868… --- diff --git a/src/modules/dialog/dlg_dmq.c b/src/modules/dialog/dlg_dmq.c index 419fa50a29c..bb8a69cffd6 100644 --- a/src/modules/dialog/dlg_dmq.c +++ b/src/modules/dialog/dlg_dmq.c @@ -535,6 +535,7 @@ int dlg_dmq_replicate_action(dlg_dmq_action_t action, dlg_cell_t *dlg, &jdoc, jdoc.root, "to_uri", dlg->to_uri.s, dlg->to_uri.len); srjson_AddStrToObject(&jdoc, jdoc.root, "req_uri", dlg->req_uri.s, dlg->req_uri.len); + srjson_AddStrToObject( &jdoc, jdoc.root, "tag1", dlg->tag[0].s, dlg->tag[0].len); srjson_AddStrToObject(&jdoc, jdoc.root, "cseq1", dlg->cseq[0].s, @@ -578,14 +579,16 @@ int dlg_dmq_replicate_action(dlg_dmq_action_t action, dlg_cell_t *dlg, srjson_AddNumberToObject( &jdoc, jdoc.root, "lifetime", dlg->lifetime); - srjson_AddStrToObject(&jdoc, jdoc.root, "tag1", - dlg->tag[0].s, dlg->tag[0].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "cseq1", - dlg->cseq[0].s, dlg->cseq[0].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "route_set1", - dlg->route_set[0].s, dlg->route_set[0].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "contact1", - dlg->contact[0].s, dlg->contact[0].len); + if(action != DLG_DMQ_UPDATE) { + srjson_AddStrToObject(&jdoc, jdoc.root, "tag1", + dlg->tag[0].s, dlg->tag[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "cseq1", + dlg->cseq[0].s, dlg->cseq[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "route_set1", + dlg->route_set[0].s, dlg->route_set[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "contact1", + dlg->contact[0].s, dlg->contact[0].len); + } break; case DLG_STATE_CONFIRMED: srjson_AddNumberToObject( @@ -593,23 +596,24 @@ int dlg_dmq_replicate_action(dlg_dmq_action_t action, dlg_cell_t *dlg, srjson_AddNumberToObject( &jdoc, jdoc.root, "lifetime", dlg->lifetime); - srjson_AddStrToObject(&jdoc, jdoc.root, "tag1", - dlg->tag[0].s, dlg->tag[0].len); + if(action != DLG_DMQ_UPDATE) { + srjson_AddStrToObject(&jdoc, jdoc.root, "tag1", + dlg->tag[0].s, dlg->tag[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "cseq1", + dlg->cseq[0].s, dlg->cseq[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "route_set1", + dlg->route_set[0].s, dlg->route_set[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "contact1", + dlg->contact[0].s, dlg->contact[0].len); + } srjson_AddStrToObject(&jdoc, jdoc.root, "tag2", dlg->tag[1].s, dlg->tag[1].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "cseq1", - dlg->cseq[0].s, dlg->cseq[0].len); srjson_AddStrToObject(&jdoc, jdoc.root, "cseq2", dlg->cseq[1].s, dlg->cseq[1].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "route_set1", - dlg->route_set[0].s, dlg->route_set[0].len); srjson_AddStrToObject(&jdoc, jdoc.root, "route_set2", dlg->route_set[1].s, dlg->route_set[1].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "contact1", - dlg->contact[0].s, dlg->contact[0].len); srjson_AddStrToObject(&jdoc, jdoc.root, "contact2", dlg->contact[1].s, dlg->contact[1].len); - break; case DLG_STATE_DELETED: //dlg->iflags &= ~DLG_IFLAG_DMQ_SYNC;

1 0

Jenkins build is still unstable: kamailiodev-nightly-binaries » amd64,stretch #2544
by kamailio＠sipwise.com 05 Dec '23

05 Dec '23

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

git:master:2f98aaca: ims_ipsec_pcscf: declare vars at beginning of the block
by Daniel-Constantin Mierla 04 Dec '23

04 Dec '23

Module: kamailio Branch: master Commit: 2f98aaca9e4b71b8086abce4c2b41c215fb2a26f URL: https://github.com/kamailio/kamailio/commit/2f98aaca9e4b71b8086abce4c2b41c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-04T20:33:40+01:00 ims_ipsec_pcscf: declare vars at beginning of the block --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/2f98aaca9e4b71b8086abce4c2b41c2… Patch: https://github.com/kamailio/kamailio/commit/2f98aaca9e4b71b8086abce4c2b41c2… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 80a714559ba..de61ad7cf6b 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -806,6 +806,10 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) struct pcontact_info ci; int ret = IPSEC_CMD_FAIL; // FAIL by default tm_cell_t *t = NULL; + sip_msg_t *req = NULL; + security_t *req_sec_params = NULL; + ipsec_t *s = NULL; + ipsec_t *old_s = NULL; if(m->first_line.type == SIP_REPLY) { t = tmb.t_gett(); @@ -847,12 +851,10 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) goto cleanup; } - struct sip_msg *req = t->uas.request; + req = t->uas.request; // Parse security parameters from the REGISTER request and get some data for the new tunnels - security_t *req_sec_params = cscf_get_security(req); - ipsec_t *s; - ipsec_t *old_s = NULL; + req_sec_params = cscf_get_security(req); // Update contacts only for initial registration, for re-registration the existing contacts shouldn't be updated. if(ci.via_port == SIP_PORT

1 0

git:master:812df264: ims_ipsec_pcscf: handle IPSec registration case where first SIP REGISTER does not have VIA port as 5060
by Daniel-Constantin Mierla 04 Dec '23

04 Dec '23

Module: kamailio Branch: master Commit: 812df26470b50d626ce9ee03b9272373b231ce2a URL: https://github.com/kamailio/kamailio/commit/812df26470b50d626ce9ee03b927237… Author: Supreeth Herle <herlesupreeth(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-04T20:29:40+01:00 ims_ipsec_pcscf: handle IPSec registration case where first SIP REGISTER does not have VIA port as 5060 --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/812df26470b50d626ce9ee03b927237… Patch: https://github.com/kamailio/kamailio/commit/812df26470b50d626ce9ee03b927237… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index c863eff5407..80a714559ba 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -855,7 +855,9 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) ipsec_t *old_s = NULL; // Update contacts only for initial registration, for re-registration the existing contacts shouldn't be updated. - if(ci.via_port == SIP_PORT) { + if(ci.via_port == SIP_PORT + || (pcontact->security_temp->data.ipsec->port_ps == 0 + && pcontact->security_temp->data.ipsec->port_pc == 0)) { LM_DBG("Registration for contact with AOR [%.*s], VIA [%d://%.*s:%d], " "received_host [%d://%.*s:%d]\n", ci.aor.len, ci.aor.s, ci.via_prot, ci.via_host.len,

1 0

[kamailio/kamailio] Hi, could you provide me with a .cfg demo for using SEMS as Announcements in the IMS module? (Issue #3662)
by Helloworld1668 04 Dec '23

04 Dec '23

Hello Kamailio team, I am an enthusiast of the Kamailio project, interested in an IMS project. I am working on integrating Kamailio with SEMS and am keen to utilize SEMS's Announcements (Prompts, Ringbacktones, Pre-call-prompts) feature. However, in the current project's PCSCF module, SEMS is being used as an SBC. Could you possibly provide some .cfg demos for using SEMS specifically for Announcements? I would greatly appreciate your assistance. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3662 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3662(a)github.com>

2 2

[kamailio/kamailio] [Textops] replace_body_all does not apply for SDP which process from RTPEngine (Issue #3661)
by Jakihiko 01 Dec '23

01 Dec '23

the function replace_body_all place after rtpengine_offer(), I expect that it will change the SDP however actually It does not. pseudo code like: ``` rtpengine_offer(); replace_body_all("Asterisk", "NipponMedia"); ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3661 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3661(a)github.com>

3 3

git:master:9cb6dae1: modules: readme files regenerated - ims_ipsec_pcscf ... [skip ci]
by Kamailio Dev 01 Dec '23

01 Dec '23

Module: kamailio Branch: master Commit: 9cb6dae183c7295a3c9753a2747f6b3d92c3ffe8 URL: https://github.com/kamailio/kamailio/commit/9cb6dae183c7295a3c9753a2747f6b3… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-12-01T13:46:54+01:00 modules: readme files regenerated - ims_ipsec_pcscf ... [skip ci] --- Modified: src/modules/ims_ipsec_pcscf/README --- Diff: https://github.com/kamailio/kamailio/commit/9cb6dae183c7295a3c9753a2747f6b3… Patch: https://github.com/kamailio/kamailio/commit/9cb6dae183c7295a3c9753a2747f6b3… --- diff --git a/src/modules/ims_ipsec_pcscf/README b/src/modules/ims_ipsec_pcscf/README index 3df520e95d1..8dd070ffe7d 100644 --- a/src/modules/ims_ipsec_pcscf/README +++ b/src/modules/ims_ipsec_pcscf/README @@ -321,6 +321,10 @@ ipsec_create("location", "1"); requests. + 0x80 (128) - set transport parameter in the new dst uri for TCP requests. + + 0x100 (256) - use Via attributes (port and protocol) for + routing UDP reply. + + 0x200 (512) - try TCP if corresponding UDP socket is not + found. This is an optional parameter, default value - 0. Example 1.12. ipsec_forward

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev