- sr-dev - kamailio.org

[kamailio/kamailio] TLS: Consider what's new and what's supported in OpenSSL (#1878)
by Olle E. Johansson 23 Nov '23

23 Nov '23

### Description  ### Expected behavior #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1878

3 7

[kamailio/kamailio] OpenSUSE warning cleanup (#1714)
by sergey-safarov 23 Nov '23

23 Nov '23

### Description During kamailio packaging on OpenSUSE in log exist this warnings ``` [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/acc_diameter.so [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/auth_diameter.so [ 860s] kamailio-json.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/jsonrpcc.so [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/pdb.so [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/siputils.so [ 860s] kamailio-xmpp.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/xmpp.so [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/sbin/kamailio [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/sbin/kamcmd [ 860s] The binary calls gethostbyname(). Please port the code to use getaddrinfo(). ``` Could you `port the code to use getaddrinfo()`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1714

3 3

[kamailio/kamailio] tls connection terminated frequently when mongodb cluster member becomes unavailable (#1599)
by flo-eyeson-team 23 Nov '23

23 Nov '23

### Description Kamailio frequently terminates tls connections to sip clients, if db_mongodb database driver is used and one mongodb cluster member becomes unavailable. If one mongodb secondary is shutdown (or the primary and a promotion takes place) kamailio will terminate the tls connection to a sip-client (sends a FIN/ACK) after a short period of time (differs 20s to 180s). If a sip client reconnects, registration will succeed (so mongodb access is fine) but kamailio will terminate the tls connection shortly after. This situation happens as well if only the connection between kamailio and a secondary is blocked (the cluster members can still communicate with each other). I assume that the mongo-c's server discovery might be the culprit. Mongoc iteratively tries to connect to all servers in the mongoc-uri to update their status (`mongodb://mongodb-cluster2:27017,mongodb-cluster1:27017,mongodb-cluster0:27017/kamailio?authMechanism=MONGODB-X509&replicaSet=rs1&ssl=true&sslcertificateauthorityfile=mongo.ca&sslclientcertificatekeyfile=mongo.certkey`). Nonethless, mongoc's server discovery should be transparent to the kamailio client as long as a primary exists (and this is the case). No reason to terminate tls client connections.  ### Troubleshooting #### Reproduction  1. Setup a mongodb cluster with 3 members. 2. Setup kamailio with tls using db-mongodb via tls. Note: The mongodb-uri must contain all three members, e.g. `mongodb://mongodb-cluster2:27017,mongodb-cluster1:27017,mongodb-cluster0:27017/kamailio?ssl=true`) 3. Connect/register a sip client via tls. 4. Stop one member. 5. Clients will receive a ready error on its tls connection. #### Log Messages  The db_mongodb kamailio logs don't reveal any errors. Operations are normal. The only thing which is shown in the logs is TLS read:error. As seen below. ``` Jul 23 14:22:09 bda3e8fce481 /usr/local/sbin/kamailio[318]: ERROR: tls [tls_util.h:42]: tls_err_ret(): TLS read:error:140E0197:SSL routines:SSL_shutdown:shutdown while in init Jul 23 14:22:09 bda3e8fce481 /usr/local/sbin/kamailio[318]: ERROR: <core> [core/tcp_read.c:1485]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0x7fa9b6343210 r: 0x7fa9b6343290 ``` A wireshark trace reveals that kamailio closes the tcp connection (FIN/ACK). The client receives a "stream truncated". ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.4 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 13:39:15 Jul 23 2018 with gcc 6.3.0 ``` * **mongoc-version** ``` mongoc-1.11.0 (built with cmake ../ -DENABLE_AUTOMATIC_INIT_AND_CLEANUP=OFF) ``` * **Operating System**:  ``` Debian 9.5 docker image running on CentOS 7 (kernel 3.10.0-514.6.1.el7.x86_64) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1599

3 9

[kamailio/kamailio] core: use standard c atomic code from stdatomic.h instead of providing assembly routines (#1430)
by Victor Seva 23 Nov '23

23 Nov '23

>From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886111 ``` Source: kamailio Version: 5.1.0-1 Severity: wishlist Hi, I noticed from the build log on mips64el a lot of warnings like this: > In file included from ../../core/parser/../mem/../atomic/atomic_native.h:50:0, > from ../../core/parser/../mem/../futexlock.h:42, > from ../../core/parser/../mem/../lock_ops.h:75, > from ../../core/parser/../mem/shm.h:39, > from ../../core/parser/../mem/shm_mem.h:34, > from ../../core/parser/../ut.h:45, > from ../../core/parser/../ip_addr.h:39, > from ../../core/parser/msg_parser.h:37, > from app_sqlang_api.h:28, > from app_sqlang_kemi_export.c:32: > ../../core/parser/../mem/../atomic/atomic_mips2.h:41:2: warning: #warning mips64 atomic code was not tested, please report problems to serdev(a)iptel.org or andrei(a)iptel.org [-Wcpp] > #warning mips64 atomic code was not tested, please report problems to \ > ^~~~~~~ If possible, kamailio should use the standard c atomic code from stdatomic.h instead of providing assembly routines. This will improve maintainability and architecture support. Thanks, James ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1430

4 4

[kamailio/kamailio] tmx: t_reuse_branch() doesn't copy $du into new branch (#1264)
by Sebastian Damm 23 Nov '23

23 Nov '23

### Description When using the t_reuse_branch() function after a branch failure, Kamailio doesn't send out the call again if $du was filled and differed from $ru. Instead, Kamailio tries to send the call directly to $ru. I would expect that the call gets sent out the same way as the original call. ### Troubleshooting #### Reproduction You need a setup like this: UAC1 K(LB) <=> K(Proxy/Registrar) <=> K(LB) => UAC2 When a UAC registers, the Path module is used to save the LB (Loadbalancer) for outbound calls. When UAC1 calls UAC2, the original call gets sent through K(LB) to UAC2. However, if the first call gets rejected and the call gets retried through branch failure route, K(Proxy/Registrar) tries to send the call directly to the request URI. In your branch_route add a reference to a branch failure route: ```t_on_branch_failure("samplename");``` Then add a branch failure route like this: ```event_route[tm:branch-failure:handle_tls_branch] { if(t_check_status("488")) { if (isbflagset(0) && !isbflagset(1)) { t_reuse_branch(); setbflag(1); t_relay(); } } }``` When filling $du manually before sending out the call again, everything works. ### Possible Solutions The original destination URI should be copied to the reused branch. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 4.4.5 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 4.7.2 ``` But from what I see in source code, the devel version still copies the same value. * **Operating System**:  ``` Debian Wheezy ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1264

4 5

[kamailio/kamailio] Solve the high potential of having conflicts for internal dialog id in multiple simultaneous kamailio instances (#1500)
by alexsosic 23 Nov '23

23 Nov '23

Regarding the issue 1274 (https://github.com/kamailio/kamailio/issues/1274) there's a problem in highly scalable environments to avoid conflicts in storing dialogs in the same DB. As @miconda pointed out: > The internal id is made from two integers, hash entry and hash id (h_entry, h_id). h_entry is the index of the slot in the hash table used to store the dialog structure, computed by hashing over call id. h_id is an incremented integer specific for each hash table slot. > > So, when loading a new record from database, if its h_id is not conflicting with an existing dialog on the same hash table slot, all is ok, otherwise the module is not going to work properly with two dialogs having same h_id. > > So, when loading a new record from database, if its h_id is not conflicting with an existing dialog on the same hash table slot, all is ok, otherwise the module is not going to work properly with two dialogs having same h_id. > > Among solutions I thought of: > > 1. have the servers generating non conflicting h_id, by having a start value different per server and an increment step larger than the number of servers. Iirc, here was at some point a similar attempt, but somehow didn't make it. Let's say one has two servers, first server starts allocating h_id from 1 and increments by 2 (e.g: 1, 3, 5, ...) and the seconds start from 2 and increments with 2 (2, 4, 6, ...). Those values can be set via mod params, eventually with an option to rely on server_id. > This should be the least intrusive in the other modules built on top of dialog. But it is rather rigid, with the example above, if one adds an extra server, it needs to reconfigure the old ones, so each server starts from either 1, 2 or 3 and increment by 3. Of course, one can set increment step to a larger value, like 100, and then has flexibility to deploy up to 1 hundred servers before having to reconfigure in case there is need for more server. > > 2. add server_id as the third field in the dialog id. It will require review of other modules using dialog and eventual code updates in those modules. One column to store the server_id needs to be added to dialog db tables. > > 3. switch from this conflicting id system to something like string unique ids, similar to what we have in usrloc records. This will require coding in other modules, changes to database schema, etc., so more work comparing with the above two, but could be the best in long term. It would be great to have the option 3 developed if possible but we would also be satisfied with the option 2 to have a third field, server_id, in the dialog id. Thank You! -- Alex -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1500

3 6

[kamailio/kamailio] allow more than one tcp/tls connection to same destination (#1107)
by juha-h 23 Nov '23

23 Nov '23

When K connects to another SIP proxy over TCP or TLS, the connection is shared for all requests to that destination. If the receiving SIP proxy is K, it means that only one worker process is handling all those requests. This may become a bottleneck if processing of requests is time consuming, e.g., because of DB operations. It should therefore be possible one way or another to establish more than one parallel TCP or TLS connections to the same destination. One solution could be based on a function call, such as t_forward_connect(number), to be called before t_relay specifying the desired number of parallel connections shared randomly by outgoing requests. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1107

6 6

[kamailio/kamailio] kazoo: incomplete documentation (#976)
by Ovidiu Sas 23 Nov '23

23 Nov '23

There are lots of module parameters that are not documented in the README file: "amqp_timmer_process_interval" "amqp_consumer_ack_timeout_micro" "amqp_consumer_ack_timeout_sec" "amqp_interprocess_timeout_micro" "amqp_interprocess_timeout_sec" "amqp_waitframe_timeout_micro" "amqp_waitframe_timeout_sec" "amqp_consumer_workers" "amqp_query_timeout_micro" "amqp_query_timeout_sec" "pua_include_entity" "json_escape_char" "app_name" "use_federated_exchange" "federated_exchange" "amqp_heartbeats" "amqp_primary_zone" "amqp_command_hashtable_size" "amqp_result_avp" "amqps_ca_cert" "amqps_cert" "amqps_key" "amqps_verify_peer" "amqps_verify_hostname" Also, the follwing functions are not documented: "kazoo_json_keys" "kazoo_async_query" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/976

3 3

[kamailio/kamailio] Presentity tabla, faster update when drop TCP/TLS connection (#915)
by jresende 23 Nov '23

23 Nov '23

Hello, I'm testing kamailio with a SIP client with presence support, when I get a connection drop from a client (i.e when the client lost the access to the Internet connection) I do not receive the change in the status to offline immediately, I just received when the timeout from the presentity database finishes. I know that I'm able to change the expiry parameter from the presentity table, but that increases my battery consumption and the data exchange, the same happens if I reduce the publish interval on the client side. The connection with the server are connected with the TLS or TCP. @miconda Suggested that a solution could be: "For TCP/TLS, what can work, it's to use tcpops module which can execute an event route when a tcp/tls connection is dropped. If you track the association of connection id with the call-id of the presence publish, then you may be able to do some tricks and lower the expires of the published presence state. I haven't had the time to see what's possible there, but could worth investing. An alternative would be to enhance presence module to behave as registrar/usrloc (which can delete contact records on connection drop) to expire documents when tcp/tls connection is closed (not sure if anyone already added it)." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/915

2 2

[kamailio/kamailio] support valgrind when *_MALLOC is used (#949)
by Victor Seva 23 Nov '23

23 Nov '23

As explain at https://www.kamailio.org/wiki/tutorials/troubleshooting/memory#pkg_with_sys… valgrind can be used to check memory leaks if kamailio is compiled without ``*_MALLOC``. I would like to support valgrind even if kamailio is compiled to use its own memory managers. In order to archive this, valgrind has to be informed of how those managers control the memory as described at http://valgrind.org/docs/manual/mc-manual.html#mc-manual.mempools -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/949

4 6

[kamailio/kamailio] dnssec: stop using libdnsval-dev for DNSSEC validation (#851)
by Victor Seva 23 Nov '23

23 Nov '23

From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843477 > From: Ondřej Surý <ondrej(a)debian.org> > To: Debian Bug Tracking System <submit(a)bugs.debian.org> > Subject: src:kamailio: stop using libval-dev for DNSSEC validation > > Package: src:kamailio > Version: 4.4.3-2 > Severity: serious > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > Dear maintainer, > > please stop using libdnsval-dev for DNSSEC validation. src:dnsval > is very poorly upstream maintained (SVN repository, issue tracker, > mailing list are non-functional) and I am going to schedule it for > removal for stretch. > > In a long term you should migrated to better and maintained library > (preferrably getdns or just libunbound), but now please just drop > it. > > Cheers, > Ondrej > > - -- System Information: > Debian Release: 8.6 > APT prefers stable-updates > APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'stable') > Architecture: amd64 (x86_64) > > Kernel: Linux 4.2.0-41-generic (SMP w/24 CPU cores) > Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) > Shell: /bin/sh linked to /bin/dash > Init: systemd (via /run/systemd/system) > > -----BEGIN PGP SIGNATURE----- So I'm going to remove **dnssec** module from the official Debian package -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/851

2 2

[kamailio/kamailio] track_cseq_updates does not update Rack SIP header in PRACK. (#801)
by scfcplummy 23 Nov '23

23 Nov '23

Hi, When using dialog module and track_cseq_updates when needing to update CSeq for authenticated invites, if early media is present the CSeq in the Rack header is not also incremented. Kamailio version: version: kamailio 4.4.2 (x86_64/linux) 892ad6 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 892ad6 compiled on 11:18:36 Sep 28 2016 with gcc 5.4.0 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/801

4 6

[kamailio/kamailio] sca: implement db_mode only (#781)
by Victor Seva 23 Nov '23

23 Nov '23

Sipwise hat ON: We have more than one server and we need to keep things in db in order to share sca subscription/appearance between servers -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/781

4 6

git:master:26d57116: sca: update rr if necessary for subscriptions
by Victor Seva 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 26d57116abc86e5d10bb1e5fe05c555e70e731c4 URL: https://github.com/kamailio/kamailio/commit/26d57116abc86e5d10bb1e5fe05c555… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-22T18:26:10+01:00 sca: update rr if necessary for subscriptions --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/26d57116abc86e5d10bb1e5fe05c555… Patch: https://github.com/kamailio/kamailio/commit/26d57116abc86e5d10bb1e5fe05c555… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index 6cdf33a6f74..6e9949a5d78 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -905,6 +905,17 @@ static int sca_subscription_update_unsafe(sca_mod *scam, } SCA_STR_COPY(&update_sub->rr, &saved_sub->rr); + } else if(!SCA_STR_EMPTY(&update_sub->rr) + && !STR_EQ(update_sub->rr, saved_sub->rr)) { + if(!SCA_STR_EMPTY(&saved_sub->rr)) { + shm_free(saved_sub->rr.s); + saved_sub->rr.len = 0; + } + if((saved_sub->rr.s = (char *)shm_malloc(update_sub->rr.len)) == NULL) { + SHM_MEM_ERROR; + goto done; + } + SCA_STR_COPY(&saved_sub->rr, &update_sub->rr); } rc = 1;

1 0

[kamailio/kamailio] sca: update rr if necessary for subscriptions (PR #3571)
by Victor Seva 22 Nov '23

22 Nov '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally #### Description From https://github.com/kamailio/kamailio/pull/3569 After initial subscription by the SCA device, if we power off and on again, we won't get an unsubscribe notification and we are getting a new record-route with sca-subscription. In this case kamailio not updating the new record-route for the SCA Device. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3571 -- Commit Summary -- * sca: update rr if necessary for subscriptions -- File Changes -- M src/modules/sca/sca_subscribe.c (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3571.patch https://github.com/kamailio/kamailio/pull/3571.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3571 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3571(a)github.com>

3 6

git:master:e45c97d1: dialog: do not print module name in log messages
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: e45c97d112c7c396ae0a11b7a431582a71361e5b URL: https://github.com/kamailio/kamailio/commit/e45c97d112c7c396ae0a11b7a431582… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:53:33+01:00 dialog: do not print module name in log messages - it is added automatically --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/e45c97d112c7c396ae0a11b7a431582… Patch: https://github.com/kamailio/kamailio/commit/e45c97d112c7c396ae0a11b7a431582… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index e937947432c..a6e8179326e 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -552,7 +552,7 @@ static int mod_init(void) /* register statistics */ if(dlg_enable_stats && (register_module_stats(exports.name, mod_stats) != 0)) { - LM_ERR("failed to register %s statistics\n", exports.name); + LM_ERR("failed to register statistics\n"); return -1; } #endif

1 0

git:master:463d5b34: avp: do not print module name in log messages
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 463d5b34390e330a2b733deb673c1c77e5be9fcb URL: https://github.com/kamailio/kamailio/commit/463d5b34390e330a2b733deb673c1c7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:53:33+01:00 avp: do not print module name in log messages - it is added automatically --- Modified: src/modules/avp/avp.c --- Diff: https://github.com/kamailio/kamailio/commit/463d5b34390e330a2b733deb673c1c7… Patch: https://github.com/kamailio/kamailio/commit/463d5b34390e330a2b733deb673c1c7… --- diff --git a/src/modules/avp/avp.c b/src/modules/avp/avp.c index 2478f38513c..38fa08fe1cb 100644 --- a/src/modules/avp/avp.c +++ b/src/modules/avp/avp.c @@ -1704,6 +1704,6 @@ select_row_t sel_declaration[] = {{NULL, SEL_PARAM_STR, STR_STATIC_INIT("avp"), static int mod_init() { - DBG("%s - initializing\n", exports.name); + DBG("initializing\n"); return register_select_table(sel_declaration); }

1 0

git:master:89a95ce1: avpops: do not print module name in log messages
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 89a95ce1abefd772c0f09054473b07bbfc5426bc URL: https://github.com/kamailio/kamailio/commit/89a95ce1abefd772c0f09054473b07b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:53:33+01:00 avpops: do not print module name in log messages - it is added automatically --- Modified: src/modules/avpops/avpops.c --- Diff: https://github.com/kamailio/kamailio/commit/89a95ce1abefd772c0f09054473b07b… Patch: https://github.com/kamailio/kamailio/commit/89a95ce1abefd772c0f09054473b07b… --- diff --git a/src/modules/avpops/avpops.c b/src/modules/avpops/avpops.c index 577a7d7fabe..9fc662ab603 100644 --- a/src/modules/avpops/avpops.c +++ b/src/modules/avpops/avpops.c @@ -810,12 +810,12 @@ static int fixup_subst(void **param, int param_no) } *param = (void *)av; } else if(param_no == 2) { - LM_DBG("%s fixing %s\n", exports.name, (char *)(*param)); + LM_DBG("fixing: %s\n", (char *)(*param)); subst.s = *param; subst.len = strlen(*param); se = subst_parser(&subst); if(se == 0) { - LM_ERR("%s: bad subst re %s\n", exports.name, (char *)*param); + LM_ERR("bad subst re: %s\n", (char *)*param); return E_BAD_RE; } /* don't free string -- needed for specifiers */

1 0

git:master:ba1c0424: textops: do not print module name in log messages
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: ba1c0424732f1f2ab01bfd078ee272221a6b3e10 URL: https://github.com/kamailio/kamailio/commit/ba1c0424732f1f2ab01bfd078ee2722… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:53:33+01:00 textops: do not print module name in log messages - it is added automatically --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/ba1c0424732f1f2ab01bfd078ee2722… Patch: https://github.com/kamailio/kamailio/commit/ba1c0424732f1f2ab01bfd078ee2722…

1 0

git:master:145659f9: github: set ``expired`` label when closing PR or issues automatically [skip ci]
by Victor Seva 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 145659f9b81a0d489548fa8a0f75c0bd05660e2e URL: https://github.com/kamailio/kamailio/commit/145659f9b81a0d489548fa8a0f75c0b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-22T14:50:21+01:00 github: set ``expired`` label when closing PR or issues automatically [skip ci] --- Modified: .github/workflows/issue_management.yml --- Diff: https://github.com/kamailio/kamailio/commit/145659f9b81a0d489548fa8a0f75c0b… Patch: https://github.com/kamailio/kamailio/commit/145659f9b81a0d489548fa8a0f75c0b… --- diff --git a/.github/workflows/issue_management.yml b/.github/workflows/issue_management.yml index 063df358c62..0d0b2ef9aa5 100644 --- a/.github/workflows/issue_management.yml +++ b/.github/workflows/issue_management.yml @@ -17,6 +17,8 @@ jobs: stale-pr-message: 'This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.' days-before-stale: 42 days-before-close: 14 + close-issue-label: expired + close-pr-label: expired exempt-issue-labels: bug remove-stale-when-updated: true operations-per-run: 500

1 0

git:master:65322a8e: app_ruby: use module name prefix for exports structure
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 65322a8ea66ed18fb2d089ade54702341e064944 URL: https://github.com/kamailio/kamailio/commit/65322a8ea66ed18fb2d089ade547023… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:05:21+01:00 app_ruby: use module name prefix for exports structure --- Modified: src/modules/app_ruby/app_ruby_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/65322a8ea66ed18fb2d089ade547023… Patch: https://github.com/kamailio/kamailio/commit/65322a8ea66ed18fb2d089ade547023… --- diff --git a/src/modules/app_ruby/app_ruby_mod.c b/src/modules/app_ruby/app_ruby_mod.c index 4d08464a996..4f713efea54 100644 --- a/src/modules/app_ruby/app_ruby_mod.c +++ b/src/modules/app_ruby/app_ruby_mod.c @@ -86,7 +86,7 @@ static param_export_t params[]={ {0, 0, 0} }; -struct module_exports exports = { +struct module_exports _app_ruby_exports = { "app_ruby", DEFAULT_DLFLAGS, /* dlopen flags */ cmds, /* exported functions */

1 0

git:master:a81e3c45: app_jsdt: use module name prefix for exports structure
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: a81e3c45dad338378fc8cf417bb0e9da1172a854 URL: https://github.com/kamailio/kamailio/commit/a81e3c45dad338378fc8cf417bb0e9d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:05:21+01:00 app_jsdt: use module name prefix for exports structure --- Modified: src/modules/app_jsdt/app_jsdt_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/a81e3c45dad338378fc8cf417bb0e9d… Patch: https://github.com/kamailio/kamailio/commit/a81e3c45dad338378fc8cf417bb0e9d… --- diff --git a/src/modules/app_jsdt/app_jsdt_mod.c b/src/modules/app_jsdt/app_jsdt_mod.c index f83c098ec1a..df7c305a123 100644 --- a/src/modules/app_jsdt/app_jsdt_mod.c +++ b/src/modules/app_jsdt/app_jsdt_mod.c @@ -84,7 +84,7 @@ static param_export_t params[]={ {0, 0, 0} }; -struct module_exports exports = { +struct module_exports _app_jsdt_exports = { "app_jsdt", /* module name */ DEFAULT_DLFLAGS, /* dlopen flags */ cmds, /* exported functions */

1 0

[kamailio/kamailio] Add AoR argument to ims_ipsec_pcscf ipsec_destroy() (PR #3645)
by jbipre2 22 Nov '23

22 Nov '23

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [X] Related to issue #3570 #### Description  Added optional AoR argument to ipsec_destroy(); to permit insertion of a real AoR from a cfg script. Otherwise, ipsec_destroy() uses the dummy AoR you(a)kamailio.org. The dummy AoR does not identify the IPSec SA of any UE present in the registrar, so no IPSec SA can be torn down. The real AoR, if present as an argument to ipsec_destroy() replaces the dummy AoR in m->first_line.u.request.uri.s, before calling fill_contact() (see changes to cmd.c / cmd.h). All other changes address ims_ipsec_pcscf_mod.c only, as required to implement the ipsec_destroy() optional argument. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3645 -- Commit Summary -- * Add AoR argument to ims_ipsec_pcscf ipsec_destroy() -- File Changes -- M src/modules/ims_ipsec_pcscf/cmd.c (8) M src/modules/ims_ipsec_pcscf/cmd.h (2) M src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c (52) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3645.patch https://github.com/kamailio/kamailio/pull/3645.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3645 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3645(a)github.com>

2 4

git:master:e59c4415: modules: readme files regenerated - ims_ipsec_pcscf ... [skip ci]
by Kamailio Dev 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: e59c4415707f0995a0d5315b5601ae518b4f1ed5 URL: https://github.com/kamailio/kamailio/commit/e59c4415707f0995a0d5315b5601ae5… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-11-22T10:17:01+01:00 modules: readme files regenerated - ims_ipsec_pcscf ... [skip ci] --- Modified: src/modules/ims_ipsec_pcscf/README --- Diff: https://github.com/kamailio/kamailio/commit/e59c4415707f0995a0d5315b5601ae5… Patch: https://github.com/kamailio/kamailio/commit/e59c4415707f0995a0d5315b5601ae5… --- diff --git a/src/modules/ims_ipsec_pcscf/README b/src/modules/ims_ipsec_pcscf/README index 81c0cb4cb99..f94669509f1 100644 --- a/src/modules/ims_ipsec_pcscf/README +++ b/src/modules/ims_ipsec_pcscf/README @@ -58,7 +58,7 @@ Tsvetomir Dimitrov 4.1. ipsec_create(domain) 4.2. ipsec_forward(domain, flags) - 4.3. ipsec_destroy(domain) + 4.3. ipsec_destroy(domain [, aor]) List of Examples @@ -103,7 +103,7 @@ Chapter 1. Admin Guide 4.1. ipsec_create(domain) 4.2. ipsec_forward(domain, flags) - 4.3. ipsec_destroy(domain) + 4.3. ipsec_destroy(domain [, aor]) 1. Overview @@ -270,7 +270,7 @@ modparam("ims_ipsec_pcscf", "ipsec_preferred_ealg", "aes-cbc") 4.1. ipsec_create(domain) 4.2. ipsec_forward(domain, flags) - 4.3. ipsec_destroy(domain) + 4.3. ipsec_destroy(domain [, aor]) 4.1. ipsec_create(domain) @@ -325,13 +325,15 @@ ipsec_forward("location"); ipsec_forward("location", "1"); ... -4.3. ipsec_destroy(domain) +4.3. ipsec_destroy(domain [, aor]) The function destroys IPSec tunnel, created with ipsec_create. Meaning of the parameters is as follows: * domain - Logical domain within the registrar. If a database is used then this must be name of the table which stores the contacts. + aor - SIP URI to match the record. If not provided, then R-URI is + used. Example 1.13. ipsec_destroy ...

1 0

git:master:57ed2639: ims_ipsec_pcscf: do not change msg r-uri with ipsec_destroy() param
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 57ed2639259f7116795f6214ca505cc86bb7ccb5 URL: https://github.com/kamailio/kamailio/commit/57ed2639259f7116795f6214ca505cc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T10:09:16+01:00 ims_ipsec_pcscf: do not change msg r-uri with ipsec_destroy() param - only changing r-uri shortcut inside sip msg field can have side effects, avoid it by providing the parameter to fill_contact() - use core fixup function for handling config parameter for aor --- Modified: src/modules/ims_ipsec_pcscf/cmd.c Modified: src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/57ed2639259f7116795f6214ca505cc… Patch: https://github.com/kamailio/kamailio/commit/57ed2639259f7116795f6214ca505cc… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index aa905b09a9b..69d1fccc502 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -162,7 +162,7 @@ static str get_www_auth_param(const char *param_name, str www_auth) } static int fill_contact( - pcontact_info_t *ci, sip_msg_t *m, tm_cell_t *t, int sflags) + pcontact_info_t *ci, sip_msg_t *m, tm_cell_t *t, str *ruri, int sflags) { contact_body_t *cb = NULL; struct via_body *vb = NULL; @@ -183,8 +183,13 @@ static int fill_contact( memset(&uri, 0, sizeof(struct sip_uri)); - if((sflags & IPSEC_DSTADDR_SEARCH) && m->dst_uri.s != NULL - && m->dst_uri.len > 0) { + if(ruri != NULL && ruri->len > 0) { + suri.s = ruri->s; + suri.len = ruri->len; + LM_DBG("using param r-uri for contact filling: %.*s\n", suri.len, + suri.s); + } else if((sflags & IPSEC_DSTADDR_SEARCH) && m->dst_uri.s != NULL + && m->dst_uri.len > 0) { suri = m->dst_uri; LM_DBG("using dst uri for contact filling: %.*s\n", suri.len, suri.s); @@ -702,7 +707,7 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) t = tmb.t_gett(); } // Find the contact - if(fill_contact(&ci, m, t, _cflags) != 0) { + if(fill_contact(&ci, m, t, NULL, _cflags) != 0) { LM_ERR("Error filling in contact data\n"); return ret; } @@ -860,7 +865,7 @@ int ipsec_forward(struct sip_msg *m, udomain_t *d, int _cflags) // // Find the contact // - if(fill_contact(&ci, m, t, _cflags) != 0) { + if(fill_contact(&ci, m, t, NULL, _cflags) != 0) { LM_ERR("Error filling in contact data\n"); return ret; } @@ -1052,14 +1057,8 @@ int ipsec_destroy(struct sip_msg *m, udomain_t *d, str *uri) t = tmb.t_gett(); } - // Insert URI in SIP message - if(uri != NULL) { - m->first_line.u.request.uri.s = uri->s; - m->first_line.u.request.uri.len = uri->len; - } - // Find the contact - if(fill_contact(&ci, m, t, 0) != 0) { + if(fill_contact(&ci, m, t, uri, 0) != 0) { LM_ERR("Error filling in contact data\n"); return ret; } diff --git a/src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c b/src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c index 3709a78c610..1e25650e1bc 100644 --- a/src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c +++ b/src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c @@ -23,6 +23,7 @@ */ #include "../../core/sr_module.h" +#include "../../core/mod_fix.h" #include "../../modules/tm/tm_load.h" #include "../ims_usrloc_pcscf/usrloc.h" @@ -459,24 +460,7 @@ static int unregister_fixup(void **param, int param_no) if(param_no == 1) { return domain_fixup(param, param_no); } else { - pv_elem_t *model = NULL; - str s; - - /* convert to str */ - s.s = (char *)*param; - s.len = strlen(s.s); - - model = NULL; - if(s.len == 0) { - LM_ERR("no param!\n"); - return E_CFG; - } - if(pv_parse_format(&s, &model) < 0 || model == NULL) { - LM_ERR("wrong format [%s]!\n", s.s); - return E_CFG; - } - *param = (void *)model; - return 0; + return fixup_spve_all(param, param_no); } return E_CFG; } @@ -503,13 +487,11 @@ static int w_forward(struct sip_msg *_m, char *_d, char *_cflags) static int w_destroy(struct sip_msg *_m, char *_d, char *_aor) { - pv_elem_t *model; str aor; if(_aor) { - model = (pv_elem_t *)_aor; - if(pv_printf_s(_m, model, &aor) < 0) { - LM_ERR("error - cannot print the format\n"); + if(fixup_get_svalue(_m, (gparam_t *)_aor, &aor) < 0) { + LM_ERR("failed to get aor parameter\n"); return -1; } LM_DBG("URI: %.*s\n", aor.len, aor.s);

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev