- sr-dev - kamailio.org

git:master:1543ddae: modules: readme files regenerated - topoh ... [skip ci]
by Kamailio Dev 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 1543ddae588b339c8346875a93d3be170bf8d3df URL: https://github.com/kamailio/kamailio/commit/1543ddae588b339c8346875a93d3be1… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-30T15:16:10+02:00 modules: readme files regenerated - topoh ... [skip ci] --- Modified: src/modules/topoh/README --- Diff: https://github.com/kamailio/kamailio/commit/1543ddae588b339c8346875a93d3be1… Patch: https://github.com/kamailio/kamailio/commit/1543ddae588b339c8346875a93d3be1… --- diff --git a/src/modules/topoh/README b/src/modules/topoh/README index 0217b90d30f..e4d065fa748 100644 --- a/src/modules/topoh/README +++ b/src/modules/topoh/README @@ -45,6 +45,8 @@ Daniel-Constantin Mierla 4.1. event_route[topoh:msg-outgoing] 4.2. event_route[topoh:msg-sending] + 5. Pesudo-Variables + List of Examples 1.1. Set mask_key parameter @@ -96,6 +98,8 @@ Chapter 1. Admin Guide 4.1. event_route[topoh:msg-outgoing] 4.2. event_route[topoh:msg-sending] + 5. Pesudo-Variables + 1. Overview This module hides the SIP routing headers that show topology details. @@ -385,3 +389,7 @@ event_route[topoh:msg-sending] { } } ... + +5. Pesudo-Variables + + - $th(ecallid) - return the topoh-encoded Call-Id

1 0

git:master:022f9ed2: topoh: docs listed $th(ecallid)
by Daniel-Constantin Mierla 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 022f9ed2a49e9e72d323aa33d0ff7209c33f945f URL: https://github.com/kamailio/kamailio/commit/022f9ed2a49e9e72d323aa33d0ff720… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-30T12:26:30+02:00 topoh: docs listed $th(ecallid) --- Modified: src/modules/topoh/doc/topoh_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/022f9ed2a49e9e72d323aa33d0ff720… Patch: https://github.com/kamailio/kamailio/commit/022f9ed2a49e9e72d323aa33d0ff720… --- diff --git a/src/modules/topoh/doc/topoh_admin.xml b/src/modules/topoh/doc/topoh_admin.xml index 1aaffcecbce..feac68d02aa 100644 --- a/src/modules/topoh/doc/topoh_admin.xml +++ b/src/modules/topoh/doc/topoh_admin.xml @@ -435,4 +435,10 @@ event_route[topoh:msg-sending] { </example> </section> </section> + <section> + <title>Pesudo-Variables</title> + <para> + <emphasis>- $th(ecallid)</emphasis> - return the topoh-encoded Call-Id + </para> + </section> </chapter>

1 0

git:master:5fd6ff04: topoh: added $th(ecallid) - return encoded call id
by Daniel-Constantin Mierla 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 5fd6ff04e2ef8365dfabe16d4d612ac7ee5fbecf URL: https://github.com/kamailio/kamailio/commit/5fd6ff04e2ef8365dfabe16d4d612ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-30T12:26:30+02:00 topoh: added $th(ecallid) - return encoded call id --- Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/5fd6ff04e2ef8365dfabe16d4d612ac… Patch: https://github.com/kamailio/kamailio/commit/5fd6ff04e2ef8365dfabe16d4d612ac… --- diff --git a/src/modules/topoh/topoh_mod.c b/src/modules/topoh/topoh_mod.c index b2f10d120e0..ebda46571f8 100644 --- a/src/modules/topoh/topoh_mod.c +++ b/src/modules/topoh/topoh_mod.c @@ -46,6 +46,7 @@ #include "../../core/fmsg.h" #include "../../core/onsend.h" #include "../../core/kemi.h" +#include "../../core/pvapi.h" #include "../../core/str_hash.h" #include "../../core/parser/msg_parser.h" #include "../../core/parser/parse_uri.h" @@ -117,7 +118,17 @@ static str _th_eventrt_outgoing_name = str_init("topoh:msg-outgoing"); static int _th_eventrt_sending = -1; static str _th_eventrt_sending_name = str_init("topoh:msg-sending"); +static int pv_parse_th_name(pv_spec_t *sp, str *in); +static int pv_get_th(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); + /* clang-format off */ +static pv_export_t mod_pvs[] = { + {{"th", (sizeof("th") - 1)}, PVT_OTHER, pv_get_th, 0, pv_parse_th_name, + 0, 0, 0}, + + {{0, 0}, 0, 0, 0, 0, 0, 0, 0} +}; + static param_export_t params[] = { {"mask_key", PARAM_STR, &_th_key}, {"mask_ip", PARAM_STR, &th_ip}, @@ -148,7 +159,7 @@ struct module_exports exports = { cmds, /* exported functions */ params, /* exported parameters */ 0, /* exported rpc functions */ - 0, /* exported pseudo-variables */ + mod_pvs, /* exported pseudo-variables */ 0, /* response handling function */ mod_init, /* module init function */ 0, /* per-child init function */ @@ -801,6 +812,66 @@ int th_execute_event_route(sip_msg_t *msg, sr_event_param_t *evp, int evtype, return 0; } +static int pv_parse_th_name(pv_spec_t *sp, str *in) +{ + if(sp == NULL || in == NULL || in->len <= 0) + return -1; + + switch(in->len) { + case 7: + if(strncmp(in->s, "ecallid", 7) == 0) + sp->pvp.pvn.u.isname.name.n = 0; + else + goto error; + break; + default: + goto error; + } + sp->pvp.pvn.type = PV_NAME_INTSTR; + sp->pvp.pvn.u.isname.type = 0; + + return 0; + +error: + LM_ERR("unknown PV th key: %.*s\n", in->len, in->s); + return -1; +} + +static str _th_masked_callid = STR_NULL; + +/** + * + */ +static int pv_get_th(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + if(msg == NULL) { + return pv_get_null(msg, param, res); + } + + if(param == NULL) { + return pv_get_null(msg, param, res); + } + + if(msg->callid == NULL + && ((parse_headers(msg, HDR_CALLID_F, 0) == -1) + || (msg->callid == NULL))) { + LM_ERR("cannot parse Call-Id header\n"); + return pv_get_null(msg, param, res); + } + + switch(param->pvn.u.isname.name.n) { + case 0: /* masked call-id */ + if(th_mask_callid_str(&msg->callid->body, &_th_masked_callid) < 0) { + LM_ERR("cannot encode Call-Id\n"); + return pv_get_null(msg, param, res); + } + return pv_get_strval(msg, param, res, &_th_masked_callid); + + default: + return pv_get_null(msg, param, res); + } +} + /** * */

1 0

git:master:f68cd7a4: modules: readme files regenerated - outbound ... [skip ci]
by Kamailio Dev 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: f68cd7a4b1d035d48c28b774dcf9b9bde557f38f URL: https://github.com/kamailio/kamailio/commit/f68cd7a4b1d035d48c28b774dcf9b9b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-30T03:46:09+02:00 modules: readme files regenerated - outbound ... [skip ci] --- Modified: src/modules/outbound/README --- Diff: https://github.com/kamailio/kamailio/commit/f68cd7a4b1d035d48c28b774dcf9b9b… Patch: https://github.com/kamailio/kamailio/commit/f68cd7a4b1d035d48c28b774dcf9b9b… --- diff --git a/src/modules/outbound/README b/src/modules/outbound/README index aa712cd73fc..af2f86cb3c2 100644 --- a/src/modules/outbound/README +++ b/src/modules/outbound/README @@ -75,12 +75,13 @@ Chapter 1. Admin Guide determine whether to apply RFC5626 processing. This section applies if outbound processing is not forced by the force_outbound_flag flag. - REGISTER request — - * single Via: (first hop) and Contact: has ;ob parameter + REGISTER request: + * single Via: header (first hop) and Contact: header has ;reg-id + parameter - Non-REGISTER requests — - * top Route header is me and has ;ob parameter - * single Via: and Contact: URI has ;ob parameter + Non-REGISTER requests: + * top Route header URI is myself and has ;ob parameter + * single Via: header and Contact: header has ;ob parameter 1.2. Edge Proxy Keep-Alives (STUN)

1 0

git:master:35e622df: outbound: docs fix reference to wrong parameter in REGISTER
by S-P Chan 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 35e622df641013ddac4d8f6dc79ffcd9be7fde46 URL: https://github.com/kamailio/kamailio/commit/35e622df641013ddac4d8f6dc79ffcd… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-30T09:41:08+08:00 outbound: docs fix reference to wrong parameter in REGISTER - should be ;reg-id, not ;ob --- Modified: src/modules/outbound/doc/outbound_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/35e622df641013ddac4d8f6dc79ffcd… Patch: https://github.com/kamailio/kamailio/commit/35e622df641013ddac4d8f6dc79ffcd… --- diff --git a/src/modules/outbound/doc/outbound_admin.xml b/src/modules/outbound/doc/outbound_admin.xml index 69a4b304a92..e2f3e3f468f 100644 --- a/src/modules/outbound/doc/outbound_admin.xml +++ b/src/modules/outbound/doc/outbound_admin.xml @@ -26,20 +26,20 @@ can determine whether to apply RFC5626 processing. This section applies if outbound processing is not forced by the <code>force_outbound_flag</code> flag.</para> - <para><code>REGISTER</code> request — + <para><code>REGISTER</code> request: <itemizedlist> <listitem> - <para>single Via: (first hop) and <code>Contact:</code> has <code>;ob</code> parameter</para> + <para>single <code>Via:</code> header (first hop) and <code>Contact:</code> header has <code>;reg-id</code> parameter</para> </listitem> </itemizedlist> </para> - <para>Non-<code>REGISTER</code> requests — + <para>Non-<code>REGISTER</code> requests: <itemizedlist> <listitem> - <para>top Route header is me and has <code>;ob</code> parameter</para> + <para>top Route header URI is myself and has <code>;ob</code> parameter</para> </listitem> <listitem> - <para>single Via: and Contact: URI has <code>;ob</code> parameter</para> + <para>single <code>Via:</code> header and <code>Contact:</code> header has <code>;ob</code> parameter</para> </listitem> </itemizedlist> </para>

1 0

git:master:2e23bf67: modules: readme files regenerated - outbound ... [skip ci]
by Kamailio Dev 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: 2e23bf67839cff85cdd4413cedab5d2c4757f8f4 URL: https://github.com/kamailio/kamailio/commit/2e23bf67839cff85cdd4413cedab5d2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-30T02:46:09+02:00 modules: readme files regenerated - outbound ... [skip ci] --- Modified: src/modules/outbound/README --- Diff: https://github.com/kamailio/kamailio/commit/2e23bf67839cff85cdd4413cedab5d2… Patch: https://github.com/kamailio/kamailio/commit/2e23bf67839cff85cdd4413cedab5d2…

1 0

git:master:fa458f97: outbound: docs - fix bad XML
by S-P Chan 30 Apr '25

30 Apr '25

Module: kamailio Branch: master Commit: fa458f97c307f590d1f3d726d22786fbbe337b09 URL: https://github.com/kamailio/kamailio/commit/fa458f97c307f590d1f3d726d22786f… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-30T08:43:57+08:00 outbound: docs - fix bad XML --- Modified: src/modules/outbound/doc/outbound_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/fa458f97c307f590d1f3d726d22786f… Patch: https://github.com/kamailio/kamailio/commit/fa458f97c307f590d1f3d726d22786f… --- diff --git a/src/modules/outbound/doc/outbound_admin.xml b/src/modules/outbound/doc/outbound_admin.xml index 882f1225e9a..69a4b304a92 100644 --- a/src/modules/outbound/doc/outbound_admin.xml +++ b/src/modules/outbound/doc/outbound_admin.xml @@ -25,11 +25,11 @@ <para>The module analyzes SIP requests so that users (e.g. path, rr) can determine whether to apply RFC5626 processing. This section applies if outbound processing - is not forced by the <code>force_outbound_flag<code> flag.</para> + is not forced by the <code>force_outbound_flag</code> flag.</para> <para><code>REGISTER</code> request — <itemizedlist> <listitem> - <para>single Via: (first hop) and <code>Contact:</code> has <code>;ob</code> parameter + <para>single Via: (first hop) and <code>Contact:</code> has <code>;ob</code> parameter</para> </listitem> </itemizedlist> </para>

1 0

git:master:6114c433: modules: readme files regenerated - outbound ... [skip ci]
by Kamailio Dev 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 6114c4338a9175d0bff05e6b7bbd0d9a00bfa25f URL: https://github.com/kamailio/kamailio/commit/6114c4338a9175d0bff05e6b7bbd0d9… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-30T01:46:09+02:00 modules: readme files regenerated - outbound ... [skip ci] --- Modified: src/modules/outbound/README --- Diff: https://github.com/kamailio/kamailio/commit/6114c4338a9175d0bff05e6b7bbd0d9… Patch: https://github.com/kamailio/kamailio/commit/6114c4338a9175d0bff05e6b7bbd0d9…

1 0

git:master:1efbf2d4: outbound: docs - elaborate on when outbound processing is used
by S-P Chan 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 1efbf2d4e614ca7259ffa52941d4b1c089f2eb7f URL: https://github.com/kamailio/kamailio/commit/1efbf2d4e614ca7259ffa52941d4b1c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-30T07:34:12+08:00 outbound: docs - elaborate on when outbound processing is used --- Modified: src/modules/outbound/doc/outbound_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1efbf2d4e614ca7259ffa52941d4b1c… Patch: https://github.com/kamailio/kamailio/commit/1efbf2d4e614ca7259ffa52941d4b1c… --- diff --git a/src/modules/outbound/doc/outbound_admin.xml b/src/modules/outbound/doc/outbound_admin.xml index ed458c39495..882f1225e9a 100644 --- a/src/modules/outbound/doc/outbound_admin.xml +++ b/src/modules/outbound/doc/outbound_admin.xml @@ -19,6 +19,32 @@ used as an outbound Edge Proxy (see &rfc5626; section 5).</para> <para>The <emphasis>path</emphasis> and <emphasis>rr</emphasis> modules will bind to this module if it is loaded before they are.</para> + + <section> + <title>Conditions</title> + <para>The module analyzes SIP requests so that users (e.g. path, rr) + can determine whether to apply RFC5626 processing. + This section applies if outbound processing + is not forced by the <code>force_outbound_flag<code> flag.</para> + <para><code>REGISTER</code> request — + <itemizedlist> + <listitem> + <para>single Via: (first hop) and <code>Contact:</code> has <code>;ob</code> parameter + </listitem> + </itemizedlist> + </para> + <para>Non-<code>REGISTER</code> requests — + <itemizedlist> + <listitem> + <para>top Route header is me and has <code>;ob</code> parameter</para> + </listitem> + <listitem> + <para>single Via: and Contact: URI has <code>;ob</code> parameter</para> + </listitem> + </itemizedlist> + </para> + </section> + <section> <title>Edge Proxy Keep-Alives (STUN)</title> <para>Outbound Edge Proxies MUST support STUN NAT keep-alives

1 0

[kamailio/kamailio] Corrupted output with log-engine json (Issue #4203)
by Matteo 29 Apr '25

29 Apr '25

xadhoom created an issue (kamailio/kamailio#4203)  ### Description Enabled json logging engine, with the following setup: - kam cmd line params: `--log-engine=json:Mp` - prefix: `log_prefix=", \"callid\": \"$ci\",\"srcip\": \"$si\", \"ts\": $TV(Sn), \"method\": \"$rm\", \"mt\": $mt, \"ua\": \"$(ua{s.escape.common})\", \"cseq\": \"$hdr(CSeq)\", \"status\": $rs "` - another prefix (same result): `log_prefix=", \"callid\": \"$ci\", \"ts\": $TV(Sn) "` What I see that certain json lines are truncated, for example - one line is interrupted by another json entry - one line starts "truncated" ### Troubleshooting What I can observe is that seems to happens always with same "kind" of line, usually internal logs, which don't have callid etc. #### Log Messages  The following first 3 lines are ok, then the latest is corrupted: ``` { "time": "2025-04-04T15:51:44.448427533Z", "idx": 193, "pid": 200, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:51:44.448682606Z", "idx": 194, "pid": 201, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:52:14.448279053Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:52:14.448505797Z", "idx": 196, "pid": 203, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T15:52:14.448508084Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/parser/msg, "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } ``` or (notice 2nd line or 5th one) ``` { "time": "2025-04-04T16:13:33.789641936Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T16:13:33.789642978Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", ", "line": 265, "function": "ksr_evrt_pre_routing", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "event route core:pre-routing not defined" } line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" } { "time": "2025-04-04T16:13:33.789646470Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", "line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" } { "time": "2025-04-04T16:13:33.789648201Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1579, "function": "t_check_msg", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "msg (0x7f{ "time": "2025-04-04T16:13:33.789649346Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/receive.c"8f7a693c50) id=2/228 global id=1/228 T start=0xffffffffffffffff" } , "line": 637, "function": "receive_msg", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "cleaning up" } { "time": "2025-04-04T16:13:33.789652839Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1424, "function": "t_reply_matching", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "t_reply_matching: hash 26404 label 0 branch 0" } ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 6.0.1 ``` happens also with 5.8.x * **Operating System**:  ``` Debian noble, docker container ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4203 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4203(a)github.com>

3 8

git:master:2081b3aa: core: utils/tmrec - reworked bymonth matching for negative indexes
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 2081b3aac394223b68b849fbac2a9e5ac4392334 URL: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T11:49:04+02:00 core: utils/tmrec - reworked bymonth matching for negative indexes - GH #4214 --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… Patch: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index d609e136310..eec02d22431 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -1104,6 +1104,7 @@ int check_min_unit(tmrec_t *_trp, ac_tm_t *_atp, tr_res_t *_tsw) int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) { int i; + int v; ac_maxval_t *_amp = NULL; if(!_trp || !_atp) return REC_ERR; @@ -1117,10 +1118,12 @@ int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { - if(_atp->t.tm_mon - == ((_trp->bymonth->xxx[i] - 1) * _trp->bymonth->req[i] - + 12) - % 12) + if(_trp->bymonth->req[i] < 0) { + v = 12 - _trp->bymonth->xxx[i]; + } else { + v = _trp->bymonth->xxx[i] - 1; + } + if(_atp->t.tm_mon == v) break; } if(i >= _trp->bymonth->nr)

1 0

[kamailio/kamailio] dispatcher: Check if tm is enabled before probing (PR #4223)
by Xenofon Karamanos 29 Apr '25

29 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4212 #### Description  Probing a host correctly needs the tm module to be loaded. This PR adds a check for when adding a target in dispatcher with probing enabled to verify whether tm is loaded. If it's not, it emmits a warning and disable the probing to the target. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4223 -- Commit Summary -- * dispatcher: Check if tm is enabled before probing -- File Changes -- M src/modules/dispatcher/dispatch.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4223.patch https://github.com/kamailio/kamailio/pull/4223.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4223 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4223(a)github.com>

2 2

git:master:512c5f51: dispatcher: Check if tm is enabled before probing
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 512c5f51bba77529b9cc844a6b4904a1d6275c1e URL: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T09:28:29+02:00 dispatcher: Check if tm is enabled before probing --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… Patch: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index a49e5638cd3..a90daa2abfa 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -745,6 +745,12 @@ ds_dest_t *add_dest2list(int id, str uri, int flags, int priority, str *attrs, ds_dest_t *dp0 = NULL; ds_dest_t *dp1 = NULL; + /* Check if tm binding (by testing tmb.t_gett) is loaded and if not, disable the probing */ + if(tmb.t_gett == NULL && (flags & DS_PROBING_DST)) { + LM_WARN("tm module not loaded, disabling probing\n"); + flags &= ~DS_PROBING_DST; + } + dp = pack_dest(uri, flags, priority, attrs, dload); if(!dp) { goto error;

1 0

[kamailio/kamailio] The <bymonth> logic in tmrec_match() is flawed (Issue #4214)
by intliang 29 Apr '25

29 Apr '25

intliang created an issue (kamailio/kamailio#4214) ### Description The **<bymonth>** comparison logic in **tmrec_match()** fails to properly evaluate equivalence conditions, as shown below: ``` int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) { ... if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { if(_atp->t.tm_mon == (_trp->bymonth->xxx[i] * _trp->bymonth->req[i] + 12) % 12) break; } ... ``` ### Troubleshooting #### Reproduction Rule string: "20250403T100000|PT14H|weekly|20250425T000000|2|-1WE, -2WE|16|||4" Date time: 20250416T190000 Expected output: MATCH Actual output: NOT MATCH  #### Debugging Data  ``` ((lldb) p _trp->bymonth->xxx[0] (int) 4 (lldb) p _trp->bymonth->req[0] (int) 1 (lldb) p _atp->t.tm_mon (int) 3 (lldb) p _trp->bymonth->nr (int) 1 ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions The **tm_mon** field in the tm struct uses a 0-11 range (January=0), while the **<bymonth>** parameter follows a 1-12 convention (January=1) as documented in the tmrec module's README. Therefore, we should first decrement the value of **_trp->bymonth->xxx[i]** by 1 for proper conversion. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.1.0-dev0 (x86_64/Darwin) 9f24f1-dirty flags: , EXTRA_DEBUGUSE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, select, kqueue. id: 9f24f1 dirty compiled on 11:59:55 Apr 16 2025 with AppleClang 17.0.0.17000013 ``` * **Operating System**: ``` Darwin yintiliangdeMacBook-Pro19.local 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 18:41:43 PST 2024; root:xnu-11215.61.5~2/RELEASE_X86_64 x86_64 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4214 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4214(a)github.com>

2 2

git:master:8f1a8c50: core: utils/tmrec - decrement month for bymonth matching
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 8f1a8c50ff230a1fffdd6b376f172cabe9fe60e3 URL: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T09:23:07+02:00 core: utils/tmrec - decrement month for bymonth matching - struct tm uses 0-11, comparing with 1-12 in the date format - GH #4214 --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… Patch: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index 7cbe6153824..d609e136310 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -1118,7 +1118,8 @@ int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { if(_atp->t.tm_mon - == (_trp->bymonth->xxx[i] * _trp->bymonth->req[i] + 12) + == ((_trp->bymonth->xxx[i] - 1) * _trp->bymonth->req[i] + + 12) % 12) break; }

1 0

[kamailio/kamailio] Allow single quotes in From name (Issue #3984)
by ThomasSevestre 28 Apr '25

28 Apr '25

### Description `secf_check_sqli_all();` block requests when a single quote is present in From name : ``` From: "O'Reilly" <sip:100@example.net>;tag=abcd ``` Since single quotes are frequent in names. It makes it difficult to use this function. ### Possible Solutions A solution would be to skip single quote check in From name. I'll write the PR if you are OK with this solution -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3984 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3984(a)github.com>

5 10

[kamailio/kamailio] secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all(); (PR #4225)
by Jose Luis Verdeguer 28 Apr '25

28 Apr '25

secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all();   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3984 (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4225 -- Commit Summary -- * secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all(); -- File Changes -- M src/modules/secfilter/secfilter.c (56) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4225.patch https://github.com/kamailio/kamailio/pull/4225.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4225 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4225(a)github.com>

2 2

git:master:2b4e9f8b: secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all();
by Victor Seva 28 Apr '25

28 Apr '25

Module: kamailio Branch: master Commit: 2b4e9f8beeb1643e7a175dea14f9366eac7b11e9 URL: https://github.com/kamailio/kamailio/commit/2b4e9f8beeb1643e7a175dea14f9366… Author: pepelux <pepeluxx(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-04-28T11:27:23+02:00 secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all(); --- Modified: src/modules/secfilter/secfilter.c --- Diff: https://github.com/kamailio/kamailio/commit/2b4e9f8beeb1643e7a175dea14f9366… Patch: https://github.com/kamailio/kamailio/commit/2b4e9f8beeb1643e7a175dea14f9366…

1 0

git:master:4a20f891: smsops: use global buffer for getting pv sms body
by Daniel-Constantin Mierla 28 Apr '25

28 Apr '25

Module: kamailio Branch: master Commit: 4a20f89185d82515e1ac55f8cf12eec332723fc0 URL: https://github.com/kamailio/kamailio/commit/4a20f89185d82515e1ac55f8cf12eec… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-28T11:17:12+02:00 smsops: use global buffer for getting pv sms body --- Modified: src/modules/smsops/smsops_impl.c --- Diff: https://github.com/kamailio/kamailio/commit/4a20f89185d82515e1ac55f8cf12eec… Patch: https://github.com/kamailio/kamailio/commit/4a20f89185d82515e1ac55f8cf12eec…

1 0

git:master:e0adeaa2: lib/ims: free before return on not finding the token
by Daniel-Constantin Mierla 28 Apr '25

28 Apr '25

Module: kamailio Branch: master Commit: e0adeaa22ec64444773d75b0ef04fce19b44ef2b URL: https://github.com/kamailio/kamailio/commit/e0adeaa22ec64444773d75b0ef04fce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-28T11:17:12+02:00 lib/ims: free before return on not finding the token --- Modified: src/lib/ims/ims_getters.c --- Diff: https://github.com/kamailio/kamailio/commit/e0adeaa22ec64444773d75b0ef04fce… Patch: https://github.com/kamailio/kamailio/commit/e0adeaa22ec64444773d75b0ef04fce… --- diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c index 8d97a7a54f9..aabf221d9d9 100644 --- a/src/lib/ims/ims_getters.c +++ b/src/lib/ims/ims_getters.c @@ -1310,6 +1310,7 @@ int cscf_get_p_charging_vector( p = strtok(header_body.s, " ;:\r\t\n\"="); loop: if(p == NULL || p > (header_body.s + header_body.len)) { + ims_str_free(header_body, pkg); return 1; }

1 0

git:master:c8217350: lost: clean allocated memory also for length 0
by Daniel-Constantin Mierla 28 Apr '25

28 Apr '25

Module: kamailio Branch: master Commit: c8217350f44a9ab897e3acdffbce1eb2a57fe1a2 URL: https://github.com/kamailio/kamailio/commit/c8217350f44a9ab897e3acdffbce1eb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-28T11:17:12+02:00 lost: clean allocated memory also for length 0 --- Modified: src/modules/lost/response.c --- Diff: https://github.com/kamailio/kamailio/commit/c8217350f44a9ab897e3acdffbce1eb… Patch: https://github.com/kamailio/kamailio/commit/c8217350f44a9ab897e3acdffbce1eb… --- diff --git a/src/modules/lost/response.c b/src/modules/lost/response.c index 64cd55170aa..ac1728b62ab 100644 --- a/src/modules/lost/response.c +++ b/src/modules/lost/response.c @@ -731,10 +731,10 @@ p_lost_list_t lost_get_response_list( new->next = list; list = new; - lost_free_string(&tmp); /* clean up */ } else { lost_delete_response_list(&new); /* clean up */ } + lost_free_string(&tmp); /* clean up */ } } } else {

1 0

Implementation of ED-137B
by Sandeep Nayak 27 Apr '25

27 Apr '25

Hi Kamailio Team, We have started inhouse implementation of ED-137B for VVCS project. I need your guidance in identifying credible source for deployment of this protocol. Regards, Sandeep Nayak (VP - Engineering) +91 80952 41019 [https://ci3.googleusercontent.com/mail-sig/AIorK4woqONsX5aNx6yhTdY0_mcz3Zal…] Applied Electro Magnetics Pvt Ltd. B-106, Block B, Sector 67, Noida, Uttar Pradesh-201301 Website: https://www.aemindia.com/

1 0

[kamailio/kamailio] Pepelux/secfilter Allow single quotes in From name and To name in secf_check_sqli_all(); (PR #4224)
by Jose Luis Verdeguer 25 Apr '25

25 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3984 (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4224 -- Commit Summary -- * secfilter: fix secf_check_dst bug * secfilter: Allow single quotes in From name and To name -- File Changes -- M src/modules/secfilter/secfilter.c (57) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4224.patch https://github.com/kamailio/kamailio/pull/4224.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4224 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4224(a)github.com>

1 1

git:master:e02eb4b2: add secf_remove_rule in header file
by Jose Luis Verdeguer 25 Apr '25

25 Apr '25

Module: kamailio Branch: master Commit: e02eb4b2ce854fc0f64a887d15588630d67a663b URL: https://github.com/kamailio/kamailio/commit/e02eb4b2ce854fc0f64a887d1558863… Author: AsedMorteza <mortezatorabi001(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2025-04-25T17:05:48+02:00 add secf_remove_rule in header file --- Modified: src/modules/secfilter/secfilter.h --- Diff: https://github.com/kamailio/kamailio/commit/e02eb4b2ce854fc0f64a887d1558863… Patch: https://github.com/kamailio/kamailio/commit/e02eb4b2ce854fc0f64a887d1558863… --- diff --git a/src/modules/secfilter/secfilter.h b/src/modules/secfilter/secfilter.h index 92d96f5916e..8317fac5453 100644 --- a/src/modules/secfilter/secfilter.h +++ b/src/modules/secfilter/secfilter.h @@ -58,6 +58,7 @@ extern int *secf_stats; void secf_reset_stats(void); int secf_append_rule(int action, int type, str *value); +int secf_remove_rule(int action, int type, str *value); /* Get header values from message */ int secf_get_ua(struct sip_msg *msg, str *ua);

1 0

git:master:d2d90af5: Fixing problems
by Jose Luis Verdeguer 25 Apr '25

25 Apr '25

Module: kamailio Branch: master Commit: d2d90af5c7177bbfdcd10d39fa70d6ddd481d583 URL: https://github.com/kamailio/kamailio/commit/d2d90af5c7177bbfdcd10d39fa70d6d… Author: AsedMorteza <mortezatorabi001(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2025-04-25T17:05:48+02:00 Fixing problems --- Modified: src/modules/secfilter/secfilter_db.c --- Diff: https://github.com/kamailio/kamailio/commit/d2d90af5c7177bbfdcd10d39fa70d6d… Patch: https://github.com/kamailio/kamailio/commit/d2d90af5c7177bbfdcd10d39fa70d6d… --- diff --git a/src/modules/secfilter/secfilter_db.c b/src/modules/secfilter/secfilter_db.c index e4dfc4ad77c..1c0138b0193 100644 --- a/src/modules/secfilter/secfilter_db.c +++ b/src/modules/secfilter/secfilter_db.c @@ -284,7 +284,7 @@ int secf_remove_rule(int action, int type, str *value) LM_DBG("Total matches removed: %d", total); return 0; // Return the total number of removed items } else { - LM_DGB("No matching values found in the list."); + LM_DBG("No matching values found in the list."); return -1; // Return -1 on no matches } }

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev