#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [x] Related to issue #3502
#### Description
From https://www.openssl.org/docs/man3.0/man7/migration_guide.html
> Use of low-level digest functions such as SHA1_Init(3) have been informally
> discouraged from use for a long time. Applications should instead use the
> high level EVP APIs EVP_DigestInit_ex(3), EVP_DigestUpdate(3) and
> EVP_DigestFinal_ex(3), or the quick one-shot EVP_Q_digest(3).
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3518
-- Commit Summary --
* crypto: SHA1_Init deprecated at openssl 3.0
-- File Changes --
M src/modules/crypto/crypto_uuid.c (19)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3518.patchhttps://github.com/kamailio/kamailio/pull/3518.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3518
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3518(a)github.com>
Hello everyone,
I'm trying to authenticate kamailio users using freeradius but I get the following error message when I try to start kamailio:
ERROR: <core> [core/cfg.y:3762]: yyparse(): cfg. parser: failed to find command radius_www_authorize (params 1).
Thanks for your help.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3525
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3525(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
The module has been broken in d00ceda2c04. The code to replace strcpy() did not terminate the target sting with \0.
Discovered by our voiptests rig:
https://github.com/sippy/voiptests/actions/workflows/kamailio.yml
Results in a broken SDP (note garbage around o= attribute:
```
1681 00:00:08.271/GLOBAL/alice_ua: RECEIVED message from [::1]:5060:
1682 SIP/2.0 183 Session Progress
1683 Via: SIP/2.0/UDP [::1]:5061;received=::1;rport=5061;branch=z9hG4bK20a1169c6781e4bfe26554e84d3b4925
1684 Record-Route: <sip:[::1];ftag=l5v4RNY4iYqP.*!0LQUA.MLVq8RX'm!q;lr>
1685 From: "Alice Smith" <sip:alice_2_ipv6@[::1]>;tag=l5v4RNY4iYqP.*!0LQUA.MLVq8RX'm!q
1686 To: <sip:bob_2@[::1]>;tag=c77c4b2c8430cf6c18566bc3d9212ed3
1687 Call-ID: O%CciL!Yf0-SQn]G46v4J(SPddRr<MtH(a))<0.ev}(]q.\%X[>
1688 CSeq: 200 INVITE
1689 Content-Type: application/sdp
1690 Content-Length: 296
1691
1692 v=0
1693 o=- 577651195072 577651195072 IN IP6 ::1\x86zU
1694 s=BOBSDP Session
1695 c=IN IP6 ::1\x86zU
1696 t=0 0
1697 m=image 13424 udptl t38
1698 a=T38FaxVersion:0
1699 a=T38MaxBitRate:14400
1700 a=T38FaxRateManagement:transferredTCF
1701 a=T38FaxMaxBuffer:262
1702 a=T38FaxMaxDatagram:176
1703 a=T38FaxUdpEC:t38UDPRedundancy
1704 a=nortpproxy:yes
1740 00:00:08.322/GLOBAL/alice_ua: RECEIVED message from 127.0.0.1:5060:
1741 SIP/2.0 183 Session Progress
1742 v: SIP/2.0/UDP 127.0.0.1:5061;received=127.0.0.1;rport=5061;branch=z9hG4bK8e357573055f35a768af0c9be78c836d
1743 Record-Route: <sip:127.0.0.1;ftag=q3~s'YH'`.Krs%LQKdFWrWnWgwPHJHnf;lr>
1744 f: "Alice Smith" <sip:alice_7_ipv4@127.0.0.1>;tag=q3~s'YH'`.Krs%LQKdFWrWnWgwPHJHnf
1745 t: <sip:bob_7@127.0.0.1>;tag=8ee80e5205ef358c3cb868fb5e5614f8
1746 i: m6!(QAFQlv}vTlycDH[rpMjW}mVV1phG@z/c{KI:L*n'[`%15
1747 CSeq: 200 INVITE
1748 c: application/sdp
1749 l: 328
1750
1751 v=0
1752 o=- 577651195078 577651195078 IN IP4 127.0.0.1z\xcfpzG\xd1\xcb`\xef=\x86zU
1753 s=BOBSDP Session
1754 c=IN IP4 127.0.0.1z\xcfpzG\xd1\xcb`\xef=\x86zU
1755 t=0 0
1756 m=image 13696 udptl t38
1757 a=T38FaxVersion:0
1758 a=T38MaxBitRate:14400
1759 a=T38FaxRateManagement:transferredTCF
1760 a=T38FaxMaxBuffer:262
1761 a=T38FaxMaxDatagram:176
1762 a=T38FaxUdpEC:t38UDPRedundancy
1763 a=nortpproxy:yes
```
Looks like there were multiple changes of the same nature. All of them probably needs to be re-evaluated to make sure this pattern is not propagated.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3524
-- Commit Summary --
* rtpproxy: make sure we null terminate the copy of the string.
-- File Changes --
M src/modules/rtpproxy/rtpproxy.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3524.patchhttps://github.com/kamailio/kamailio/pull/3524.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3524
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3524(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
CDR avp() mos values gets trimmed at the first larger mos value received.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3517
-- Commit Summary --
* rtpengine: increase buf size to print mos llint range
-- File Changes --
M src/modules/rtpengine/rtpengine.c (32)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3517.patchhttps://github.com/kamailio/kamailio/pull/3517.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3517
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3517(a)github.com>
Module: kamailio
Branch: master
Commit: 8b1139851d9f88add1fd7da0dbc0b2b56933cdd3
URL: https://github.com/kamailio/kamailio/commit/8b1139851d9f88add1fd7da0dbc0b2b…
Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro>
Committer: Stefan Mititelu <stefan.mititelu(a)govoip.ro>
Date: 2023-07-20T15:25:37+03:00
rtpengine: increase buf size to print mos llint range
---
Modified: src/modules/rtpengine/rtpengine.c
---
Diff: https://github.com/kamailio/kamailio/commit/8b1139851d9f88add1fd7da0dbc0b2b…
Patch: https://github.com/kamailio/kamailio/commit/8b1139851d9f88add1fd7da0dbc0b2b…
---
diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c
index 59bcfb47795..68003908268 100644
--- a/src/modules/rtpengine/rtpengine.c
+++ b/src/modules/rtpengine/rtpengine.c
@@ -180,14 +180,15 @@ struct minmax_mos_label_stats
};
struct minmax_stats_vals
{
- long long mos;
- long long at;
- long long packetloss;
- long long jitter;
- long long roundtrip;
- long long roundtrip_leg;
- long long samples;
- long long avg_samples; /* our own running count to average the averages */
+ long long int mos;
+ long long int at;
+ long long int packetloss;
+ long long int jitter;
+ long long int roundtrip;
+ long long int roundtrip_leg;
+ long long int samples;
+ long long int
+ avg_samples; /* our own running count to average the averages */
};
#define RTPE_LIST_VERSION_DELAY 10
@@ -3879,12 +3880,13 @@ static void avp_print_decimal(pv_elem_t *pv, int num, struct sip_msg *msg)
len = snprintf(buf, sizeof(buf), "%i.%i", num / 10, abs(num % 10));
avp_print_s(pv, buf, len, msg);
}
-static void avp_print_int(pv_elem_t *pv, int num, struct sip_msg *msg)
+static void avp_print_llint(
+ pv_elem_t *pv, long long int num, struct sip_msg *msg)
{
int len;
- char buf[8];
+ char buf[20];
- len = snprintf(buf, sizeof(buf), "%i", num);
+ len = snprintf(buf, sizeof(buf), "%lld", num);
avp_print_s(pv, buf, len, msg);
}
static void avp_print_time(pv_elem_t *pv, int num, struct sip_msg *msg)
@@ -3904,12 +3906,13 @@ static void avp_print_mos(struct minmax_mos_stats *s,
avp_print_decimal(s->mos_pv, vals->mos / vals->avg_samples, msg);
avp_print_time(s->at_pv, vals->at - created, msg);
- avp_print_int(s->packetloss_pv, vals->packetloss / vals->avg_samples, msg);
- avp_print_int(s->jitter_pv, vals->jitter / vals->avg_samples, msg);
- avp_print_int(s->roundtrip_pv, vals->roundtrip / vals->avg_samples, msg);
- avp_print_int(
+ avp_print_llint(
+ s->packetloss_pv, vals->packetloss / vals->avg_samples, msg);
+ avp_print_llint(s->jitter_pv, vals->jitter / vals->avg_samples, msg);
+ avp_print_llint(s->roundtrip_pv, vals->roundtrip / vals->avg_samples, msg);
+ avp_print_llint(
s->roundtrip_leg_pv, vals->roundtrip_leg / vals->avg_samples, msg);
- avp_print_int(s->samples_pv, vals->samples / vals->avg_samples, msg);
+ avp_print_llint(s->samples_pv, vals->samples / vals->avg_samples, msg);
}
static int decode_mos_vals_dict(
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Make sure dialog cbs list is NULL after is destroyed.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3514
-- Commit Summary --
* dialog: set cbs list to NULL after destroying
-- File Changes --
M src/modules/dialog/dlg_hash.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3514.patchhttps://github.com/kamailio/kamailio/pull/3514.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3514
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3514(a)github.com>
Hello,
Kamailio SIP Server v5.5.7 stable release is out.
This is a maintenance release of the stable branch 5.5 that includes
fixes since the release of v5.5.6. There is no change to
database schema or configuration language structure that you have to do
on previous installations of v5.5.x. Deployments running previous v5.5.x
versions are strongly recommended to be upgraded to v5.5.7.
Note that 5.5 is now the third last stable branch, v5.5.7 being the last
planned released in 5.5.x series. The latest two stable branch are 5.6
and 5.7, with v5.7.1 being released a while ago.
For more details about version 5.5.7 (including links and guidelines to
download the tarball or from GIT repository), visit:
 * https://www.kamailio.org/w/2023/07/kamailio-v5-5-7-released/
RPM, Debian/Ubuntu packages will be available soon as well.
Many thanks to all contributing and using Kamailio!
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - www.kamailioworld.com
Hello,
I am planning to release v5.5.7 our of branch 5.5 this week, most likely
on Wednesday, July 19, 2023. It will mark the end of official packaging
for release series 5.5.x, currently the latest two stable branches are
5.6 and 5.7.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - www.kamailioworld.com
Module: kamailio
Branch: master
Commit: c35088bf31b3e3e828433bf03b6ce647a75ef8e2
URL: https://github.com/kamailio/kamailio/commit/c35088bf31b3e3e828433bf03b6ce64…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-07-18T16:38:20+02:00
geoip2: docs - section ids and formatting
---
Modified: src/modules/geoip2/doc/geoip2_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/c35088bf31b3e3e828433bf03b6ce64…
Patch: https://github.com/kamailio/kamailio/commit/c35088bf31b3e3e828433bf03b6ce64…
---
diff --git a/src/modules/geoip2/doc/geoip2_admin.xml b/src/modules/geoip2/doc/geoip2_admin.xml
index 50a7d855fa8..cbc6ccb1493 100644
--- a/src/modules/geoip2/doc/geoip2_admin.xml
+++ b/src/modules/geoip2/doc/geoip2_admin.xml
@@ -11,26 +11,25 @@
<!-- Module User's Guide -->
<chapter>
-
+
<title>&adminguide;</title>
-
+
<section>
<title>Overview</title>
<para>
- This module allows real-time queries against the Max Mind GeoIP2
- database to be performed from the config script.
+ This module allows real-time queries against the Max Mind GeoIP2
+ database to be performed from the config script.
</para>
<para>
- The Max Mind GeoIP2 database is a map of IP network address assignments
+ The Max Mind GeoIP2 database is a map of IP network address assignments
to geographical locales that can be useful -- though approximate --
in identifying the physical location with which an IP host address
is associated on a relatively granular level.
</para>
<para>
- This database itself can be obtained on a free or commercial basis
+ This database itself can be obtained on a free or commercial basis
from <ulink url="http://dev.maxmind.com/geoip/">
- http://dev.maxmind.com/geoip/</ulink>. The
- library libmaxminddb
+ http://dev.maxmind.com/geoip/</ulink>. The library libmaxminddb
that interfaces with the Max Mind API, as well as scripts to
automate downloading of the on-disk version are available at
<ulink url="http://dev.maxmind.com/geoip/geoip2/downloadable/">
@@ -126,10 +125,10 @@ if(geoip2_match("$si", "src")) {
</example>
</section>
</section>
-
+
<section>
<title>Functions</title>
- <section>
+ <section id="geoip.f.geoip2_match">
<title>
<function moreinfo="none">geoip2_match(ipaddr, pvc)</function>
</title>
@@ -149,7 +148,7 @@ if(geoip2_match("$si", "src"))
</programlisting>
</example>
</section>
- <section>
+ <section id="geoip.f.geoip2_distance">
<title>
<function moreinfo="none">geoip2_distance(ip_addr, latitude, longitude)</function>
</title>
@@ -172,7 +171,7 @@ if(geoip2_match("$si", "src"))
</programlisting>
</example>
</section>
-
+
</section>
<section>
@@ -195,13 +194,13 @@ if(geoip2_match("$si", "src"))
</example>
</section>
</section>
-
- <section>
+
+ <section id="geoip.pvs">
<title>Exported pseudo-variables</title>
<itemizedlist>
<listitem><para>
- <emphasis>$gip2(pvc=>key)</emphasis> - <emphasis>pvc</emphasis> is an
- identifier for this query result; it is designated by the second
+ <emphasis>$gip2(pvc=>key)</emphasis> - <emphasis>pvc</emphasis> is an
+ identifier for this query result; it is designated by the second
parameter of geoip2_match(). The <emphasis>key</emphasis> can be one of
the following:
</para>